From patchwork Tue Feb 25 11:06:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 13989832 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F9FCC021B2 for ; Tue, 25 Feb 2025 11:06:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE8DC10E4BA; Tue, 25 Feb 2025 11:06:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="hGfoiBkx"; dkim-atps=neutral Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010000.outbound.protection.outlook.com [52.103.67.0]) by gabe.freedesktop.org (Postfix) with ESMTPS id B9BD510E4BA for ; Tue, 25 Feb 2025 11:06:11 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BLZmS3CWN0QJB7m6gvc183PppIdGpnu8LFtkciamUMqOnbACSRt0PFVGHh5NxS1rM5chV05MkaONalm2slt3xMidkqxbTzn1Ib6KMqixuKX5xKfsIJl87dnwdHv04JFOSSTLk+/B6rG5sOvR4ofG0A+HuuKI0LgvQWRc/GhlFF6QW+6Od6N5f36Eyfxdb4cv6zDSeTdSO2bEgZ5KnAoItYY1cGh7YETiH9xYWRjOx+6uYFP6/+z7k7ArWbo0bfbj3NxGBkR8iaWNtYjlGI9FFp+aPq8J3dI4cjWr9yQgkLrVqI/Um790Yuckn1QZxceGvVW3p9DgYJIfb1OpFUuv4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yts9bZQAaO+R2LbWbBH9Nx3QMynqSGPgSj847sgTzmQ=; b=B9lG91Hzk+C9qSgm3uelYIdD3VONgygaDjo8RvJn8bE90spKGH6mDrmTSR38qrJGWuXuucysrmZpPObRmcdHKaKEuyXSDoLP0bV5gQ1Uh3UQTBT6MfdzQsqooG8gW3MB0nA94/4Hk4F3ho+mHwOEA1EEt5UgD6xIH7Ucdq6JEaUhsTXbh5lq5d8y5mHQIVjkJeMJX455muSVv6NCyJ6nQ9PpbXvBYrrjgYL6IxDyAjMGsopI8RrbVvdmI9k3O/eHoQg9IsSPlq6c6nPTpbQ1bnwM9ASOXkqB4zcm+tKCBIsWezGkE31HdjbVVIffsg2J0ewfa5LlzyTj0Sg6+7cV8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yts9bZQAaO+R2LbWbBH9Nx3QMynqSGPgSj847sgTzmQ=; b=hGfoiBkxEAu2hbarXPEPXOv216Lxd6wpJWZvkcqHEJGVO8iuMJZW0OkSaf9pShTeGnJtRkDy4mQf0+McnD2MDy+nR3aMMe/KNATQLzXgbfA2uYUfZ5QnCWstsXH00tqRrdHoCRPN65Bl0CO+Ww4SaWdpVfB/53v1zqrsJW8EJnd5XFeehazckBkAJUiGAykC6N3vnrG89nBL4vJQfX3DMkGRGmZvubBtLugwrTB/LP9SrK1SN+A7bhmIFP1flMmg5aAxaESS6Y+i7oTR7rG3IG75/KSEEHE2vbOfgsfymiX9PgNqEq0CVKrSM9tfrB1XptHWCw2vGEQqmoihaVFX5A== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by MAZPR01MB8050.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:83::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.23; Tue, 25 Feb 2025 11:06:03 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8466.016; Tue, 25 Feb 2025 11:06:02 +0000 From: Aditya Garg To: "airlied@redhat.com" , "tzimmermann@suse.de" , "jfalempe@redhat.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "simona@ffwll.ch" , "kraxel@redhat.com" , "javierm@redhat.com" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux.dev" , "andriy.shevchenko@linux.intel.com" Subject: [PATCH 1/6] drm/ast: Remove redundant else in atomic_check Thread-Topic: [PATCH 1/6] drm/ast: Remove redundant else in atomic_check Thread-Index: AQHbh3VCVyNi4daYg0mU60+I+/4tfg== Date: Tue, 25 Feb 2025 11:06:02 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|MAZPR01MB8050:EE_ x-ms-office365-filtering-correlation-id: e2628023-bf42-4f0b-fd8a-08dd558c64a2 x-microsoft-antispam: BCL:0; ARA:14566002|19110799003|8062599003|8060799006|7092599003|15080799006|12121999004|461199028|3412199025|440099028|41001999003|102099032; x-microsoft-antispam-message-info: I69wH3CbS8eDM+tJ+gSRo+djOarIcoCU3BVKhzs15HDSOE35doYhAzP9QNbzzeOwmc2S4ws6GxgXF2vyK5fxjcyT/CcyzXGQuC79cWrBdgY8mYEDdYYa+dbab6BvgihFAqZr3hv9Ankdm/0Cx2wH4sa2Cv6J0ueiCxMdWlVrHzUezqZ7LGrxrHqWMQANf/FKRftogJ5wrfu+CrlxGS8OVHoKIzBRUz/OBORuuS0h1Pe8L0+9E7tY+k9mhRF/7jHVMTAIvHtBfLEzrd6z1lTBbhG+/0ZYZxl+fZMkDCXlLRudg3zGEVOeZ2t7HIzmOo3ktIsNGpm8fl0EF9r6BVgpGeJH674JAODs1PUn9iMyxvzOQ+oLQiBuLreUYO24DXEwzLk+7+SW9UeLra5tEik0AO0BLyAp57ce6hzewOPxzcsiXCK2Ng8yuTmCiMFKqL8MNclIwL6ojgV3TwhQAMOamXMwL62WJmeNokRZoqxOlpi8u5Gqa0y4NdicZR/rnHTHCKDEE/W5pZI4FEh1KJM3x/nFk5yIgUkuOeNJ2JLOfhyT8vGPGP+j7h0nHY0tdbR6JZTuTdYqUl8JtTF0nPMUWRqLcO9CFVTxdHbivyf6oRwGpz71bB9SBAL/80T3SKSAHLWbLvBCbS57Vm32YNhXhGnpAzGOow9JzEQNQC0Nr+sm6lj0668nLlhWU0kqdv9z+Yh1D1/EdnMxR4ehPk09NtgZOY3x4POd+xK0Sr206zl3/tyJealp+rK9da9ISCGzifylnkD2DFDA+U58fmEZDqq2oO9n6udo14Dt2OzVsagPfwAGNoDzFT3Ts37okMT1+PMVGHNUy9lpizRuSc+zQQCbv804a7I8Kmzf64VZJV5PHOSd1wXu/FfRrmQY5AYuYmi/dJW81ss8xHKkhRmXBYeY4M23rS7n+W7dIwJPdMUwKZP//hGUsZciYgxEwFshtvuDPQF2HC4K9OlUWkwfcn4dE8D8n7J6hAvTchaHcyAZFFhh3zaLHXNaVjTWpqomBCuFE2/QYkuCdnqW8fs3b9cGAOqXiNwcZbB3bSmF0+wtOeM3vigaoh/CpGfJjht7Umu5x1/OoIIycNYVRYmoG06r8ZRTm5JJhAA9mk2DU10NBDbvcjCnZ7n/AC2679xuixgU+M3r7ulyp8tVdA3uhw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: vLTrCdAlrmuwFXv71vWvPXqbLYAKdhHhOQefNrgaHdD0oGOCLEglQFzhNBJFpWz4kfhadCXd9QDykG0QaA8caQ2m6jAM/QT51gj+BME0a638eCqieAii3f55kwwe+i8dTL6oSSZ6I10zTryPZrWpaLbwC9Ije3z6t7hZSLQX00dAk+BONwu05UhkA1/NugCoLpHFcI3dpoG1ddalj8TAi2HpjaXlE/O8hEpmHKbpF23X65Y6lBH2VOh3Bw5n7i80Am5B30cnlWoMZl/t6kp4oq2xO4dHeoprCx4+cC8yBPj5jA73Ze+/L+NN0EC35T5T9L14mRYsbzm3SdgKAnVha0SVvwFSsx32FVKbD1rQ3YAvt0WAb+DxufNCKkBvMmjPMGkOOyDS6+/0jrjDNJE7uc4z8q/pdzELfPSlDeMRcZIL6H4SK7HWieeFMEODxykjhlGGEHwA2XmpTQGQ7G06y6H3aYelLaKL2ok9KrTUpvm42U7/tCDrrv4i4rowWVlVQ3UzxKy6S5DlDpJ/WTAG4GPhxZjogFunP/qBlWRuDm3tz+pMs+s4J1yB5ktYULPGHDBQw3g3uGejVT8H7pvNi87CKg1n3dG8AkBGzhcLOB1EkTrhIPDaYIVY7B9Pe2EHTU9KbNaYbUhEeNyaJhwLDHO1xMaDntOmEpIjgwo/As9Xj6VQB3ehknYYKs9B4rHy3+LH4qvp6WNsOjWMePNEuffkIDknnRRSrDsQyh38mazu+oxwNgMZy9FAioYUARyArro/IHWu1oabKvKt5OgY74NnmIN+E5mXzhdgtIJw6eOZx5eTpgz+HPjkwRaKOnmSInIDdjkEiV3Q8+/waXoX6WbfTxn7STpY0Sm/jYLQ/PlZtX9xZAbiBm14ygF9+oUao6oGu0cFOjVVyoiA5bGnjsnNAHBVPTnnlOXvITNKE0cJz/YU3Dh01LuiYzvgd4Q67wwj64HF9323+EWk/Em2xBRxUB4RYM/Y3un4fNAex0O3J6rwfsDxI3oLot53XE/RkBwvGgzegR/SMJX5SobEc8soR28sB4mzfgMMP0NUL7l9IHWbkot1XBFxWyDzrhoc7aSlx9iAJj/KLjm+3rRHa6XHNm4+l9/LW6fkbNCBC5mJYSv2zhkyVxhbgt68c67+coODT+3ns/d5g8t9yqsId20KwUnB/ajzad0QcPu9yIGMxZoS12WjQBjqCL7PSCl930h/zwcf6gVDqvtulqcd5OtHlQ7XUXhdNqekDkf8MpPveFl8H32M0mJyuvRIC8c7hZDq1AJkiI9Iu/anVyGN0QFDRKioReYzNihT7crVpPlPMfRzI6Szowab+XBQ5yZL Content-ID: <79AAF3C94DAA26419E3636C60430C2ED@INDPRD01.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: e2628023-bf42-4f0b-fd8a-08dd558c64a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2025 11:06:02.8367 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MAZPR01MB8050 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/ast/ast_mode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 9d5321c81..3817d1e4c 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@ -610,9 +610,10 @@ static int ast_primary_plane_helper_atomic_check(struct drm_plane *plane, DRM_PLANE_NO_SCALING, DRM_PLANE_NO_SCALING, false, true); - if (ret) { + if (ret) return ret; - } else if (!new_plane_state->visible) { + + if (!new_plane_state->visible) { if (drm_WARN_ON(dev, new_plane_state->crtc)) /* cannot legally happen */ return -EINVAL; else From patchwork Tue Feb 25 11:06:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 13989833 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73A33C021B2 for ; Tue, 25 Feb 2025 11:06:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D154710E4BE; Tue, 25 Feb 2025 11:06:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="pUJOAZwH"; dkim-atps=neutral Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010004.outbound.protection.outlook.com [52.103.67.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CB3010E4BE for ; Tue, 25 Feb 2025 11:06:47 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dPWSteS7HPJrIqDknVo+w6rZxJXGyy2pFjk8g1SR71DMxNqKapLHqsMwLuFBqGaDTlXrhAFLCfK3IU2QwlGh03+XLTNrSkq2EXJQDfuPuwkajDHWDnKC44IS7QsgYtxnykbhbVTMjf01E/vXQt4oscOa+8KN+jzHV3USJ2O8lAXoFroU3mLM/V0CMXlHCAlS563TVlexfWefyyu0XlJqp3esmiZbALn+6gfwXWMPH0J8oXR93tNXxdedNDpkfn2auP1hj5RFF4PdzkVjpF6xuH+d2K8eUHYxxY+f+ygxBM7fv1Xz3HjlnV1K89ZjOzR83Nm2MzvYONmIFXZQrUb+/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S2WpljUFxJZ2L3FPg7QSmSgChmgPvuVFc3eUr9Alo5k=; b=qaWcmOHo5OzkGQr6/h49UupWGwZv48jGnQKDm5hXYSDlaI+I+ff9/cYf4NJ2S9TdxhiVjmoxvga91IbJc5+GACvOIgvOIEoHDhfdycaTDwrX0LHhFjXpHZf1SrJMtayz+7w9NwmIrFHz66rR96Yny6ce7UZqZZw7eBiU9Rt7KJ6einxvQaUnZWnw+dq2m3M+Zpy0EOdPJc1VJle6aJkQovBNTXw8Jl/nEqlT5HfdeTkbDPwRN9OLFQBKbcAxJ1Xo1hpEUfPH+w1klwt7ShmqN6PB69qiCzToE/O0TCaHJUq9ObydzpPqsC1ipVYK/x1WGow3ygQg4KJ5G9FYu9Ts4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S2WpljUFxJZ2L3FPg7QSmSgChmgPvuVFc3eUr9Alo5k=; b=pUJOAZwHyvQfHn7QuRwLQeH/6h+WU5vUwbKV68pvFpY3e2iEjgYAwuxjKqPK3+H+MCA+lOybKr9EYSxmgdDfh+jzno8ua9CMU2SnvmN1SA0AM8HWSlzGjBf4UxPG+GOmR3I0+b+T/52itlehtubIU2hS56Bb5gWk2FUi6ow1XlzQH2/Tp6mTPuMAr1Aj+ylJxaggfD3McrGLlrgT2Q2jq9ZIhyWGCu1gjgiAKmqsI1A22DaCcW7Pxb34dVkW7Sxsp1bjdVBruz3Wrsec31t6DJk3j8YTizONH50XR3SG9k1HdBAGmLGnbl4VZhN+AZvSZnDQCkQ1FMkeMBdPLp/nnA== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by MAZPR01MB8050.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:83::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.23; Tue, 25 Feb 2025 11:06:39 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8466.016; Tue, 25 Feb 2025 11:06:39 +0000 From: Aditya Garg To: "airlied@redhat.com" , "tzimmermann@suse.de" , "jfalempe@redhat.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "simona@ffwll.ch" , "kraxel@redhat.com" , "javierm@redhat.com" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux.dev" , "andriy.shevchenko@linux.intel.com" Subject: [PATCH 2/6] drm/cirrus-qemu: Remove redundant else in atomic_check Thread-Topic: [PATCH 2/6] drm/cirrus-qemu: Remove redundant else in atomic_check Thread-Index: AQHbh3VXTtwLM92/iUSwQbLwovn//w== Date: Tue, 25 Feb 2025 11:06:39 +0000 Message-ID: <088E1983-D311-4B75-B198-242A32DCA3B5@live.com> References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|MAZPR01MB8050:EE_ x-ms-office365-filtering-correlation-id: 89ecd4c4-3162-438a-5f23-08dd558c7a69 x-microsoft-antispam: BCL:0; ARA:14566002|19110799003|8062599003|8060799006|7092599003|15080799006|12121999004|461199028|3412199025|440099028|41001999003|102099032; x-microsoft-antispam-message-info: J6plv9bwuDufpRJ2FsxKwIr0w2f1U8zEHYZoPbYrF06KmBE/KoqAWAhN8PXhCP6SXqD2qiMwMjG30z8gCEFHhu8rqVYObCQFBYIHlMtxCBsA179jv7GBocmj6jbNKfYAyo8zKOGDa4RUkzlhJg1tQbJFJ+G3AjOMM7xuhDTSZoo8EtYU8vDxCDmaod3A72Ht0TYRpK8OKHrhqeHR69s0qIM7vSVNLc/agNC/g57cXwynC0q9jTMo06QnvKwSdhmq0XIaxfwmx1vm44aClrKbX6M0h66T+3N9YdERAovpXxiC2oz/O8xkKLY3+dBv9NF0TAR0IX9QTEX/O6N2gH6aebe87/VoGKzqBd8FJe5MSGeH48XrWwTSIWIS4VzeevnrxKe/5uBY+1r1VMo9lCRQtYYxu0ZO4hTqg7zKSisyPI/NVqxDzfWHpslK80d1Eqv3OzWeZakxPV10wyTjQu1CTmvDRWLi72XXLoaFqBeUHLTCn1iCQOilgdFm9DMIEEZF69mVUz2FHp9CdgFBBCr5Ch49Hytq6TPTG/WdlAPO/Iz4yV8hKowzhXo43/PKFHa3L7dxjB+X1yH2TZvyolzpRdio4IprrtrRXhU8tPrJsPvkMObFAx9EpghviLSpgiLjPLgfeMgcjLs5/TZR4ugtN8P1JxEdX+QgjNEvwsENQd2iIImqfy9IKj/3jnNGHDiU3ZObDQxaOM1/zL0VS63qsPt9snm4qlIpDheCNiUH6HA3S9pCWiNty/JNDLHlliMMSFS/QBtUnpKDlPo6NK6Bavb96ZTtZRdZe03ehsWonIRsA7lLj0JT409wrSHHWEf0RYQ1T7BFiuXYvVvsNZn/BEqqtpNA/HEboeBQWgks1n50AuFQtCSLbvzUtjYXeF68G/uuWCE9gBPl7LJwCPZ2wcgLMIzNjFGWncYqTkLpQB+bwprPAVgt8p6slwSo9tTVrtVcmfZFg9egVnnPRmEpFKEbU6XzmdK1eVBLDcXagFwmOA3dc3cKqU0KRnMjl5c4L2mFgUMXeGcCi+EESt5S07tWutdJVdlmqwPFi3uW/KofrrZJz3eiXSrrxUQHdtUe4tMxr70XwbN8XZzOVzGKV9AOzrU0OyFDV3PzmVc/djSty0ZGP79JAP24Acw2MxUpYrJzBNMnfAGXFkKUwjE7cQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: FMth38t9MMDMAgcS/1q7a3sLjFuojEGPjKzjdBgSUilTByX+5sPMJ5XBQFT2vyhv2W6uTLsBDfJICznNaZDZjca8w4sXjT9ZBPwwhozWGCaVq4IkWI6YVk2QcVh1zhcaoH5e9lUlRi8OXshvqD5QBCQ1BtYhrguLdj3fJiCwpkmIthI3N9IzZ8a0BkAxyn+JQ3Xg6fy/URXrq63frtRWIxsBIpW9WJnj36mMZOzVyXsn5egbj6CZ/MRwp0Q18Cl3WEFNlMW4Pjx3liqqHGV9ExVbVtVTzFDJU8wjziM6aIszhKH0i4OyYOOFZ+eUdVT/uFRXHYE89V65ob5CHwBhHYIj5hJytvr6OBBgTYXY219FqmRtfFcbepw4b/4M9yuoJXTbYxbNs1TxkhXiKfD7r3tq+46Evuz1Kx3Zts/qhJcWPc40c2imjIOMxtPxTFDGloW5ZxIqZ0rPA/iWj7BABUzQZvry6pUGnKmZLv4wbZjxTrRWTNW9SA/t1Enc/7wxsqeHWK/C3xcLmDOG8CiAsWYUQLKazLjFogRjbbFyz2DKPAFVar54qaLvxxcPRyiczjv47MFP2NUY4wP/E5izcgXg0E8VSQanttOF9Nv6y0QRgw4AysXfdxVZIsR3YZXWBiVewszVsMrP2bFPTIr4wK9VkLQwurHuGthMkP28v7/C8FkXOD4GNFq2nyd/PNBxZakKZgRRafgawADkuRU052LlI0ybR2y0Ep5wK8dFVmpdsBw+MsizJdPuNUYWkz/90UQUAWjvGcHidZFTDpHWCf/3gX92cSfLZTPIhHF/h105V54w53cBifjQI+cLe+OIvGKZgcQCKCEqG9uDnUG/TqW0eguzt7XnnsdECMCd8cR7T9dA5bEMuEv4+ZCLpMmAw2naNJp4b85Qo2/TumFHTwv+fegDisqNQTMGW9CO5cF/gUnOugVo9um8MsBk2UNyyk2tQdq/wUtjfGxdrMetfbJ2mgnRDlu3hK//ewP5oTwFgNCHpjE39VxeCX+oak72P9ssyQZ/nYDL5w0a7/I46iFkM9temMpGXs1NwD/8y0TKDpDEDTBdKE7kQPjify8oWdM98pIZVnh67c4LCAzhuXZF1Uaqlns12eFjZQzwTh5qaJJof06HSVDc5jO7eGZDxHmi97Q9R60ppo5Ek6F+iF9v2gY5+XyoGnvY8hmnTVNto7Gp02xvImPxhQoB3LcRQ/uCFzt7rQFVOxKR9nuvKKLR5+zmmBCKILXiqIk8Z8zHgrgk16V8LNicyAYhip5IACRJolHM1eN+8rjL1uLFBoNa5hqjnwKghMDdezrvQeEEMOw3lBhtPY4XCuc2yXr6 Content-ID: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 89ecd4c4-3162-438a-5f23-08dd558c7a69 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2025 11:06:39.3406 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MAZPR01MB8050 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/cirrus-qemu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/cirrus-qemu.c b/drivers/gpu/drm/tiny/cirrus-qemu.c index 52ec1e4ea..e696531b6 100644 --- a/drivers/gpu/drm/tiny/cirrus-qemu.c +++ b/drivers/gpu/drm/tiny/cirrus-qemu.c @@ -359,7 +359,8 @@ static int cirrus_primary_plane_helper_atomic_check(struct drm_plane *plane, false, false); if (ret) return ret; - else if (!new_plane_state->visible) + + if (!new_plane_state->visible) return 0; pitch = cirrus_pitch(fb); @@ -367,7 +368,8 @@ static int cirrus_primary_plane_helper_atomic_check(struct drm_plane *plane, /* validate size constraints */ if (pitch > CIRRUS_MAX_PITCH) return -EINVAL; - else if (pitch * fb->height > CIRRUS_VRAM_SIZE) + + if (pitch * fb->height > CIRRUS_VRAM_SIZE) return -EINVAL; new_primary_plane_state->format = cirrus_format(fb); From patchwork Tue Feb 25 11:07:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 13989834 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1146C021B2 for ; Tue, 25 Feb 2025 11:07:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7258A10E60F; Tue, 25 Feb 2025 11:07:15 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="hdsmxPHY"; dkim-atps=neutral Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19011035.outbound.protection.outlook.com [52.103.68.35]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85FAA10E60F for ; Tue, 25 Feb 2025 11:07:13 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TvsM074+MkhCK9Ao1h2GiSYC3+j9jTOGCmgabmqZSoQMDV0yd8JcgMcGF8Fi4BYXpbiRpMMqCFqlA8wWCdc0gsYDvn4lqoK0iTn3FxBdQGFBdirKC7kuUMSEyK7wQEaNAgDdVy/z65Y2rg4a6jKxu9kW8Vxoj1vbpYf7/QeOAeTS9BsrKVkEJYYOJtS1v9i5/O2gAetYhAdlgjPKbarZWKLh06p/Yj5gIiXhplUDoJIJWMBWoCYb3uH11u9xgl+Jq91aAahsho8+maNswMMj5aIZiPsFEBVkA2hUdUxo3zsQe2kIbxsEUk07Nbe0EnLZLKLgRH89t57RLqf1xJhXVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a5E3g8QMilaBd14g/c4+6HWITmU8WGWTMs5AOkKaMdY=; b=ER1370fiGxDNwb3PZojD2YT1XXEHZqcNanxj522kwcni4teBVBI7FYqfKumRtofj3MVkbhGvSXm6GIYhOYSzWxhMxO5EYQWJweNgJVBT9ssrur3x+DF8JGBCBYllAXaYO704gs2Rv9V7bdvDx1IWHa59tqTbALeh71PSWtqO7yDV5MYlZkFzE/KkXCzkLNKLHgS4z8rI0AP3C5cv9ZjUEWD+Mxz75eVoB/QDQ4/l/5dtI+zUX92cdHEYct4Eo4fzydCBvWf6X2Jcg8B3YZBVYUUzA/n+5kq1WelMHfCBqBMqvDDYpeIaMff2IwDH0AUMpmn4nWaRR+ntKcgraKY4rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a5E3g8QMilaBd14g/c4+6HWITmU8WGWTMs5AOkKaMdY=; b=hdsmxPHYjCUy/WIqGOQhE4CXnov/yXta2A2zfA0WIdAvo1HjedM41nXoRkcHA2rE90x5RFEDh7rF78BgfZbV9LipHQYwmdKFPwXsB7z3RjAsEJMfUb7gmFgY4d5Nl9++0S6QqkSGMgkUl+KUaaflaoWnCl7Tvo/6/EwdqHah6DltLt1pGwBVfdVPDWhqBqgoXPzfNuvTbEntHtejAyb1suKbHGur19KQPg9B+ojy/W35dpmqlyivqPUlmQmMEr9MeU24/n2M3+ApdfAN2trXVu5skQXMK46urWu1feTyucx2rV5SkLrMyKSb/JWw2LQPf7fOUiV0+/BFv5MiuoLTIA== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by MAZPR01MB8050.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:83::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.23; Tue, 25 Feb 2025 11:07:08 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8466.016; Tue, 25 Feb 2025 11:07:08 +0000 From: Aditya Garg To: "airlied@redhat.com" , "tzimmermann@suse.de" , "jfalempe@redhat.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "simona@ffwll.ch" , "kraxel@redhat.com" , "javierm@redhat.com" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux.dev" , "andriy.shevchenko@linux.intel.com" Subject: [PATCH 3/6] drm/offdrm: Remove redundant else in atomic_check Thread-Topic: [PATCH 3/6] drm/offdrm: Remove redundant else in atomic_check Thread-Index: AQHbh3VpAUCc4jHRrk+X/vlg/SmCnA== Date: Tue, 25 Feb 2025 11:07:08 +0000 Message-ID: <9F565F81-DB68-4C41-8ADA-9F2EE158AE90@live.com> References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|MAZPR01MB8050:EE_ x-ms-office365-filtering-correlation-id: 8978b412-c817-4bd9-5a69-08dd558c8b8c x-microsoft-antispam: BCL:0; ARA:14566002|19110799003|8062599003|8060799006|7092599003|15080799006|12121999004|461199028|3412199025|440099028|41001999003|102099032; x-microsoft-antispam-message-info: zOgvbzMYSa+S3Ip4nA0rvPXHYCDDlx+27oyb041gUX/UVU5OEsz+rWnZZbpS5Qmo9oEiO6WlRuz4Xjgj3EVw3b44mxVq/t+bKXsRIfQ03jP6MLtAG7LUE/rdXVWnDuLLi/lwbS6OSgDn0yKge3PPIeiPCiG/8EHtbIsNdKjt8/lXkgHuut2MfTdT/rWtbgWXLNaJbXAYQnHF5xWXAD3Lf5Lb0umaOXY1rsr19x7U38eRUzB0Ps1O9eUJ8GYDVrO0Y6R1jA5YJ3fG5tai7wh9WMgKfXBF0t8HDRZh+/4IItkUDDMKX82Dyynxv7adfiToRZ8bk5Oqz62GrSl8GoAAHk/abkZ07ahPDQMMhExuFAB/0dYkvmtp7zgdtpMQWkjYlVC1RqSnimUkmje0HRGe+6xNEkcnK2vp4qo4jPVMxIr4VTdEGNhR9xnG5+5BvUoyQqVR0aXvYLFLnxsKb15lVDVVqF79IpPhOWsO3huOZ+T94O2KZCQ/N2ELxFbhFlidpNccKsPZgra52cj9epAor3HVlPXU4kzyMIqh/rtwuIGH8gg870W9z3PvxVsQfWiKmUwMkqlfN/zLN9Cd62/KPvSWh9ND12alQOIJOhPiJKpqsTNUf0yasnQHFjxA38gSF8R81MEfzKmKSHDSZ0zk76psqpaCBSDzEdyhP8KRCz2x8lmoKc0pnUdEXC+vz/a6NQHHyQ14lyVHPpwsCqqrO9/Rfs5ipcg6x0ts1sosXc5//X7b9jL6536nqyJim1LfKaPKMEy17ISSBhnbIX2gZtaCe+TyBcz2XNgKvbYEwiB3O802la/C1Aek4R6yBnS99zKne6Oj5Piv97F9nKPl+94PQ5eRpmZFXEgWaBYraYnhyYppMm08Bpa3FiAAFbLkKd0BHk5P3Q8NWAjWU5i563IKiuGVrQlJhRb0MKMPLh5HCHwOiNYnW9BcDuABWrOMpHUkRBuzts9wjuE6DuHaeOS9FagPMZfWUoVbw3icy3oE3UeWY3/Gtj0zJ7J2YdOQOcSiQV6cW3Dj+6f46IruFWvyxa0pSKMIZOf8RXAzcfbNClJbmBt0KEKe2ruojilVUjDFPv//803FfcTxCZd9+t2jaGq0MHhygCf/EiqVSRM5cgaRkG9QmQZndxNKmUjLPmPoov0k65N4kopAPUc7Bw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: /Jp0NSNclvkUzRSsu/tGbLYv6Ft5iyCgy+qQjECVqRhR++9aW4JGfqZQebPBiHomOZMUfexy56aNFltK7I0D2W0V90e/dIBSZ7cU7kIZDgKUFI4SDKDvBpWYlMuzmrCtY6yYrhYoHd1iBSl3u6N8Em8DtOqMEx/+ei+cgeUAS8NR0Eowf9d8gx1AVEr47ha0lLZKpytoA1CKeiSh71O1/fqKEVrNnvpWriiX8dY2Ou/R4Ohk5Ru37gPodF2ljzrkUsEO779FHfLWR01A+ZlobAAcOZ/NdpNDrl5FXUqZytDhiTg8wwGhetuNulTgxZyyyCt74TdJMOzJGWyItff8wKgJ/jexh2i8uuX4U+X6M5JS5etCG/Pyqjdw9bzGaulTHGT7e/P7Ks/gADS7SIMo6ISuUf1TaZcg0IJkOiuZNyxsWMGSZ85vgIvz0s3v1TLymAKCJw74iSjcnMme793j/KHqnQ2BitVPVYYctauZA9gE1vkZ9nEPSy9a+SLmupuz5vy1WPvV7/xqomNT5X9HiOoDvU+menVtHjpS7iQ/6m6u7Oxao4phoXpbYULPDcq3Kpp759328vQtpRH7bTzksJTsOhQS/sleYdiKfv5lV73CKH7xTsNhxNfumOLL44YV31r00BAJcBqgmT9B3q0xAN1efOeqXtUwg4E9ID9dHrDi33bNXjgnL4KbnaqUMoEbzd2axpszcefV75rWeptn/WcHRzP6nbQEFy4SiRBupEkv8Aiw9vYZ2DzrSAVbuwbqc8r9y4mOMAuNdkBwu00rxlFolgk3AOavRD+UOZAg+2b/3bxkcC6ijuBtdeejyDPRjCDs55DBlW3ojlwybCfsROphDgSz0VhiumBIDKBGsfFGpQqWrQQB9snLlASEhIOlAeL4LP5G2tbMS/JWzxaF9l4XilPSmpS/BsIwxvYcFR+3nyPTD8/S+ogjG1abKS8RpHUdQBSCahWkIHN91YDOEKo3aG36Z6e5+13yLQByKZmkO35xx6AWbPaehxLCez1hTQhjgb2wc/hIu0sPXl+w3ZK/pBJfLMi7aybflGePPM7JUdNVeO8vev6NR4rkxz/yKtG/qUIUmSf+lanEuMNIYheU73Ses0gD0vlb63J4vjSFoVIciwgzCqE56ADjzXjV3Juk1Zbsaqe5Zepqqb1l652rcE3Dm8Gss8xMqfrCYzEGjKm7OxLR5hXX7Z8cc+aTn2c6ck4G3+60E3/R3Lg7F6G6HvDeryeXoyTVFOoRPMMxOVugvs7T65++iIp/aYbkryzTR5BG5CGJvEea5uRoC9aLvAhHFMbEzKXFpSsq4F9fvbE+SM2CX4SFR8Mx/ZgA Content-ID: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 8978b412-c817-4bd9-5a69-08dd558c8b8c X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2025 11:07:08.1439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MAZPR01MB8050 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/ofdrm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c index 13491c0e7..fc669ab1d 100644 --- a/drivers/gpu/drm/tiny/ofdrm.c +++ b/drivers/gpu/drm/tiny/ofdrm.c @@ -777,7 +777,8 @@ static int ofdrm_primary_plane_helper_atomic_check(struct drm_plane *plane, false, false); if (ret) return ret; - else if (!new_plane_state->visible) + + if (!new_plane_state->visible) return 0; if (new_fb->format != odev->format) { From patchwork Tue Feb 25 11:07:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 13989835 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D64AFC021B2 for ; Tue, 25 Feb 2025 11:07:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 58DDC10E4C0; Tue, 25 Feb 2025 11:07:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="aQZIEsKB"; dkim-atps=neutral Received: from MA0PR01CU012.outbound.protection.outlook.com (mail-southindiaazolkn19011026.outbound.protection.outlook.com [52.103.67.26]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C27910E4C0 for ; Tue, 25 Feb 2025 11:07:49 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lruh/g7SPeh2ecItq4SuzXhTYv3DbJkJnpgCfcYCBoUugcLe4F8BSILL6D3ixvYB8uhguU1N+nKSKxdKKV6EjVX6HqY14IvSFV+ZNUsOLHQn89yTE8h9iRV024I5/IdJQ6AQkFl2Acn/eZD82a6N3rC/ZICVhsQDn6txNPM6J+6htWkxsSgZxrb1Xagl9Nq7R6ZC6RKmVjjO97AtUkEiTEm8vfGe5BOBDJ9R7zO2Ml47ynr56UMNTAX0/7wKvRgrMfFpH047pgN82MDI/7y59iiJOKunmGRb+AyqEVC6vL2rnno68DZjrZ+XSVp+G5LsyemU06VXTi7v6opqdd5AIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EiikcYG1IfarQ9EB8ne4nz9S7rmAlbtGs4PajaNo6p4=; b=rQqW8jLmHzu1KszDzF7ifAvpRG/KallVqucJN/NzwG2qjFiwzVSwagpWevEmajs+n81hYwS6rVOmKlphcsHULDxpacsCrLexyE0kf8O4Ffum/V1syXwCTXt0KT/OCNIDnkMWxsEFlyxsZlMKoPHK5EOgpi0zetK6vtYliSSVmWinbqU1MpIpotjcKjrgnzb3E8DMRK3wz/gEweEntL4Uee4opZiCqeiN+rQ6lzb0CYkAf3pqxCec2F7g797rkSst+mL2T8d/48ewMDOp/UZrVNm4khWoRph6KFFEa1F26oBAILaLJI0JQOAzfqauOj4w9z+heJ/Sj6LHiKCQsgre1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EiikcYG1IfarQ9EB8ne4nz9S7rmAlbtGs4PajaNo6p4=; b=aQZIEsKBAklCeFmLC4zb9zCCtOXaKheda4aPF6hU2kof0FexQO5KaGSgaDDld48tT/tNKuL9FGnJqhGHoQkZG3E+mPIJp7ID8dKUbYfwS9L5IBW0HW0T+YOPu/l804f6jNCiW+I2Fb76x0+5t7/eU7gFm0j59X+UcWHJiRtWKCApp87wzC8Z/05obnp1iaCC6R2kvyb5GjtcvgCug/WWZCWzJG+J1tP19laxERAMnmUy0Z/OyaNjhlboD46oxaHvP3eC7ekiTmcf/ilqEXTXnqJqSmgQU4azlr6q8yhFYujH/Xq9hoQcoYItdIk3XrYM9Mlh9GcBVz377z/9V2G95g== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN0PR01MB9351.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:108::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Tue, 25 Feb 2025 11:07:41 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8466.016; Tue, 25 Feb 2025 11:07:41 +0000 From: Aditya Garg To: "airlied@redhat.com" , "tzimmermann@suse.de" , "jfalempe@redhat.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "simona@ffwll.ch" , "kraxel@redhat.com" , "javierm@redhat.com" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux.dev" , "andriy.shevchenko@linux.intel.com" Subject: [PATCH 4/6] drm/bochs: Remove redundant else in atomic_check Thread-Topic: [PATCH 4/6] drm/bochs: Remove redundant else in atomic_check Thread-Index: AQHbh3V82G+UfH2cmUOONF0Ah6OAhQ== Date: Tue, 25 Feb 2025 11:07:41 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|PN0PR01MB9351:EE_ x-ms-office365-filtering-correlation-id: 071cd5db-914e-4bdb-676b-08dd558c9f60 x-microsoft-antispam: BCL:0; ARA:14566002|461199028|15080799006|7092599003|12121999004|8060799006|8062599003|19110799003|3412199025|440099028|102099032|41001999003; x-microsoft-antispam-message-info: yntTgA5UQwQF0or69AvDlcCSERyLZW2odT57d8Bwo2g5QeVGBXx9D4C592U65A7dADzUhElPhgThUAQF7b+uwUu28pwgR2GCOw/+sD1XMn6z6F3kOGGm50n2UPnvJuayI02LMzMGSKNA9p0IlybQq1GNWeiNG0bn9367H50uiVp1izjkuH2MZqwRq7VH7yrlmX3R+8mfuFCfTq91LM3qICpElmLSYN88j8nnDgPv2rZlpWyrwiEwgDXzREdZd0qeJx+DGCWd8SG3tQ66lIgAzeTvl3c884IHpVAFngWDsLyhdUdXOJWWDbn/fIzZgLU1zkIMM6YSBqU/ME8OyXAhvGl98W3jv4M4TKCViQw9f/7kfs56KWOROmT7lGo/WQ0fN/jsbpsLiUMs2glnL435fdbn/oqySD7m1zWguAF8WwaNPwPtFUQvKbKa+6AtZr7k9ndTCJ65y5+/h9+kh1+Mi77jXuMmKeYUNPnin5S7Ybsxj5wsqInHRxSexX0a5Sl0aYKXofH0Jj6vNRLLZgg6r2e7nxGmPKllvIcapXKvMnw149SthuN5rep6s3rgS/5suzkw60Xz+2H1ufieKd0lHRBn4aZ+92Ag1IFPjQKkj16wbHCdO0l2jVqU/LqhF0iG99pH/kiIyOCONLzh4LdSkZyouWeqXf54/Xwn81cnZc8V03xdiKH1IkoPJEVGCDIMwef/Uyqp4cjchLvHy1Mc7OJ+o6Q2agP528Hqm2vPCoxTx83Fu0fc8Emm9Y5HyAPxd994MlzCM3oHf+rjk6eKrzZTIgiL+lkkUxHh75WoSpVSKVB5D898da+v2AhVWxrBdm0xc+WKbVNJ8E7cYn79VYFGcaN64uzeCIZWKoD6Mj1Jx9b/mJNSLmJ+WsIvJAyn/bfqkD7we+c9C0h9ivZYpfY6Weh2hKJziTAUk6vv8kVHsKRxVspiNWpE+TxqJK7C7XtB3sSJxPJ4TBo8KcZyQMZWTjUtfCw96FrR6zBT6yNA0ISEeslZNbHDo/I3JU/ArTourur7PF/KEPB152zsSNL93P3Xe8Z1ecD0w5nglBiGPVH/93XtQSzEBa1VwNk8YNWNYpdWY2sCVtc9jq3MxNPBDrgXkZkRRzxFnsLLtVFd4ve+ziGomaSXfHjG852ZTSZ3X+ynJmdlM2iyrlGgKA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: iUN2AtnxEO3WAHDemSyAqS8S/ZUoS/wBAKCtZeL1un2REgwo37FiLpUTXnOqToKEE4sAxLvP5rzj/bt+u3VTRjK/syYfiLDJv9o8BarCzQadidk1usECSK5gs0Mr7qxFviWjvg+TobFrt2YzMUi7F9OHXjaSIyr3g2Iq27Dr9oxsSofYxtvmzJKaobZDj+npPQhBRIaQ8v1WfCkEuo8Yjk1pgfpoaBPeUD7HSMR5Cu/lMBt/gRu3BZp/ZvlR1XXAwoeVsAttiy+Cl+pGAJ4P19hje71QhxbX2wtlYJa728yYhokzOWrwzZ+BWMdi5YwU5fcS8DIC/7cJE8t0wrCyrInOlIzk07ShmwVF4a/yboah+f0RXXary6PVIwdxWawig7cmcKl66FGQf4ltfZKaGO7xpuzcRGAags6CHCrUnes/jD4OK6bBDkR4jItYBwYIi/X2iyxrcwRJrZpA3l2YhRAK2PVkoPR1aAvxWibqzKeL+cDk/x8UOP2Ly41fppKOdV3x3OaDqHixZfCgc1NXDNUJG5RlErNJWH1yUmg2Zh//yIfFQgmuczRAc9cnElyn+soQ1QJUg5/O8CHlIpUzOSyHse7VjrXCGMtBhzRkcpCu78eul4RkvCBFTpK9cwj2cK9a/YTmPNQcblUToG20DeJxus5sUcAn7073ApTvav2SDboPkioiAvkRcmA0GhljoF6w2dGFpvY3p5OubkW/AtDnP42Xv+PfpYL+46nkHn7qQ189WQki+Dwa5/Cb68ScPQMLEB+ifq3hok9RkTkPQTKUoQQbETZpKlY13BuBCccVvZIhoyq9GfRgIf/hMSGxfgB7qeqZYq5ShqaxvjlbF+vv6LCVS6mHdsbebKz7JFeI1D/0jLnhGihpftZY5Z1WUx+lgYatEs8WOSyS3X5w3IL6zs+bbECqos3272oWblMgFThSHSzsJyNJ2L7lD/4fooLkv8nNxoMKj7wmdp+Z+y+5gsukquyFh8r5iC0ZfRCuSvPJRIqnirkpktJgcHBb4LZfYqHonXiHftXT6keGzseMlJfnYFISHls+zjaoYTUTXj0ZKav7xUod9tUb3WUUw7DdNc2BEsPYYEFa1Zmi5VqQHSfw7Vh3T+PlwbyXkZQ624oL3SHsKL8LH22T4Rm6xuq2hTHxUH2aD9XpOx4Up4etGUFQaMN3XpoBfhJmS066u0NTowWmN4dgKvUW/YPl+wjmx11kLa6hLHQrwSQG6VSwmoa+7NbkvkAZkGIOg74m3dTY4RcvdHeA2asq8ocA7bNwEZwoWEx8erNY/9dg6gWLI0tGqwHbWGmnCMgh+Us26XzycCw4/yPa81BzSkrE Content-ID: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 071cd5db-914e-4bdb-676b-08dd558c9f60 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2025 11:07:41.3620 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0PR01MB9351 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/bochs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c index c67e1f906..9ed5f70a0 100644 --- a/drivers/gpu/drm/tiny/bochs.c +++ b/drivers/gpu/drm/tiny/bochs.c @@ -433,7 +433,8 @@ static int bochs_primary_plane_helper_atomic_check(struct drm_plane *plane, false, false); if (ret) return ret; - else if (!new_plane_state->visible) + + if (!new_plane_state->visible) return 0; return 0; From patchwork Tue Feb 25 11:08:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 13989836 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C085BC021B2 for ; Tue, 25 Feb 2025 11:08:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DB3A10E614; Tue, 25 Feb 2025 11:08:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="AOiCMNek"; dkim-atps=neutral Received: from MA0PR01CU012.outbound.protection.outlook.com (mail-southindiaazolkn19011034.outbound.protection.outlook.com [52.103.67.34]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE00F10E614 for ; Tue, 25 Feb 2025 11:08:18 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gqrIp1EpMLQUZR8at7yob77oMVAEwLnJmCLNPRdj0J/Wbe20iCK50EpXZfOl55Amr2MUkLLUVPHcngASLt0ipt6TrqtsX7aHbLYLdGVu/Kzkamk1FvDCNNU16yg9ZRpj4Ojzm4HzxaUx+yvLwoHC46v0u6diwGCbuVnj9BTcKtceMVz8OysTlR3DqPo+mnzEzgwJVqQz3XLkmVSBM+4FSGEcrJvdV3KdsOQ/cqr5POtNAYGdi4XxwU6w5OI2zGh50SGOYFE68VbZ1dXgeQZ+P8VTDnXecEspeW8yBHR488Npa2rw0WADQ0gJ6frnt3VjK4JcTRp3awTS0KakgoIJ8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UIyoiauYOluEMoB+huXSWyuUgD5t54cBnS2Kl2FULT0=; b=P/7CKSI50rPm3MbKunIFhh5KlWnIyIit20RIsyt56yZf37BUMxYOQrMjlXsGlFSxxZhPtiPOisJgl3K4bB4IrILmRTxoTT+PIbFeM3UPIyqaF2yecbyeuxlpNvkzDT4PxaMouTOw2EDgwlAzjnRQmpu+QgJRGDpa7RJLXeTMGjWiIUFuXrzLNupOT/5evateutAiRBud5Dt8WtaL5Nl1TdfnXx2lq9GquieKiSpoNBXCRNjhikwsbKUFqCBohlTmjMB2hAKUsX0VB1bQK2gsZdCQg4wcieTSWoZ/oZcvHQJo1doRaSHWVSkMbjItedDexGXUZ5J1FiaQ9PSIM9wtdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UIyoiauYOluEMoB+huXSWyuUgD5t54cBnS2Kl2FULT0=; b=AOiCMNek2mmhWl/RFMJmu6w3vHsDKSn+kEXlaWSiFZ0LSZE0+yIZ7YQ78Ju9KT2ZF9YUgKOSI/zTqlcsxTCeV0Bc13zWj+u626yk5TgyZgkWaLdhlSlAh+xayF7GtaveSv8mj6lprfgOhTwQqr6vC9L1LEnqr7pMhyPhMesFpodOjwht+S1652X3XTPCV6f+877zFXb9gHRFZSscf7gHUrEUCTdYy+9/9/u+CHZq5t4XWm/EbFONNGATngC+nI1PrdiwXT+lrp2amNdlbqmAHnNy8cnrkPcxGVaY1KsUZUDeix6jf0CcobiiepjPiUVBOuc2II/avJ+s368wJZzmBQ== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN0PR01MB9351.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:108::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Tue, 25 Feb 2025 11:08:13 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8466.016; Tue, 25 Feb 2025 11:08:12 +0000 From: Aditya Garg To: "airlied@redhat.com" , "tzimmermann@suse.de" , "jfalempe@redhat.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "simona@ffwll.ch" , "kraxel@redhat.com" , "javierm@redhat.com" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux.dev" , "andriy.shevchenko@linux.intel.com" Subject: [PATCH 5/6] drm/simpledrm: Remove redundant else in atomic_check Thread-Topic: [PATCH 5/6] drm/simpledrm: Remove redundant else in atomic_check Thread-Index: AQHbh3WPKkVmM2yDfkOjykyS+gpNrQ== Date: Tue, 25 Feb 2025 11:08:12 +0000 Message-ID: <79FBFE0E-ADCA-42A8-A92B-22FE68AB69C5@live.com> References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|PN0PR01MB9351:EE_ x-ms-office365-filtering-correlation-id: b22090be-875a-4db2-822f-08dd558cb1c0 x-microsoft-antispam: BCL:0; ARA:14566002|461199028|15080799006|7092599003|12121999004|8060799006|8062599003|19110799003|3412199025|440099028|102099032|41001999003; x-microsoft-antispam-message-info: qr3HGe6f9X980jGUdWT5o0QNXWSRzF5E64w6LRclNPzUbJsCOTWBNblJRnhhqHSqXUIslaE9CO+qoLkqslUP54v+typn8oLNfdtqxMHoIzgdjXOuDCSMqfjwUIQhIxKk9kT1gXjI7oZk3Y4SUx9vbxjJDYvQjjFCHZoWv8O+zldkneSWT4+HvscgQptsra3IPpOv0twz6iL/M7tcqmnJiUhiarw3IFhQ5AHn1XqHVyK6RwdFQJE4OBEonnCBmbfxIKvgRxYAw6NYG1KYPyeyPwwToEI3FN0MS+ynS5U51l5Mej9uHaN/1ebCr8WY9wxXqsOukMQbGyAYuNr++rQQPS5HfuTKtlHUiKA/9R7azVMXtqYH1gFkeqUdQdv4B2m23D9f7iW0JfJU+dbAIRCmZBRoD6uNYtZbm2uWWT+3JBLyDSUUSAh1wgKoEOuN9nXe3jqYTf9IrVY7gBhF14oeOlVoRDPh39BzvfvgkZ6C+4CDOgTtNv64fhXM2AvxDso/Hvurt3jJ58IDSIz/1OASJAsyrg5PUW2XSJYGUF56ODlkFCZGzf4RIsgdHFGVpIG5QV8Hp3ZTjKw1h88EEc9kINH+1pwr5jrErgY2bKsZzak9u3URO8NfCZfldrKunLRLg5cpO9tZRZPLTrkVSsDl+2XD83kFeUccDhPyv5Dh5t18JZeny4jdvwzA35GSO4AkLJGL0ylgVmS8dRE8iGhZMEIJKadwSz3zeL7rIaiTeM+rcC5IZeCjZCCGXhzVGdCVtrbRzAjiDNQYMGYWBwJ0MTAB6zrdvUiiutQQQN94ZxUuags3Kh81V/ewsVvjoKpgO9szSC5KGa9Cu+q+u8dhEfrHRuJKD7XyCTd2r3+fvjrckNkiArVjTJE3QYnFAiL3GQU4lXYtkp3mKyBJCZB+5IhnxyrSjIsJx857A/FM4OJNQmpiUipEkzo0UafU9dRq+R8BcRIo6UbGkdMf+LQP+iENsBtyEDbOxDT0af2kGPGkuG1zZIlt+n8GSbJ7OlpiWcU6RdL725Xcp9O+TMTLBe91jN1ipTtiJux9t5eAMaFRTQLHttajKEmfjkXC3oPJ9XayYthhkXhDi8dWyGXOwBCYediaoUDGVrKNNCqft6A6Kq/PDqMwIO/Nl1q3xEnyvK+CupqkG4oF3puk4nWsXw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: 4B1DZyg2nxrpLNfcbHbp7ZSzvzhrBqO57bIivf9UcuQoYP4LRnGaCi4NY0BMsvOGSF21RE5zGyQxnnRWMRuvc0UEa4qL0FeAaoV08nX4hPFADD8MSSvAuVE07mfOMs2qRsCeGYL5+2taxT7YXpYl4RTBjGo6KMDycwxQgwgZV0RctJQvngLN39oQKw4e6vZHMn2+NBgCjxXokylRQwHTe/Yoz91tQPWfjoBxVHOMmwtpFioKdEe8XOrawSp/mVhtQ7YQ7XfvoXEu/Rl8VxrI3ZTPPiCcMK9k+susxTFyqpj14IunqzDRJlmwkyquVJOz29l1k/M3camrZ/Nc5z55y8ENBCIJUclbmaF4+1hmfR7MXVu5v64pJ6xFxW4Zk8ZWHStI01zNTgzMOpSc3tJcqN0wxy8lNGBVYDRuMAf9HbsDclvQFO02dbe9mLkJDvjgwhDJfiNOub7pNjmD/V/DHVL0jPbnl4jNsUxGbQdXlBPVgfo5DgGzDxtMnuGpsIftmpVOFpeFqDPnkkBoUN4vvMa8JaNA6vx2FUZKqcKbVTn07q15aeM5ED75h7NzN2mnYG1SaBbb3zudxmBuqmjl3W1ChPmTQkFOPyIzcMKZfW0OPEqMnAUXBPKfFmTU4CAVIH2cn2PAd1GQ0/+mX/xDxDMs83gZUV9jESObLanFufUz0RYWT7/v6Fzj2491AeeGxd4lsT9g9bXWbuHeP7pyS1pavf5YNuqirpsxPLP7J+uOKMW+xE7LnIh9i28c3XqKD29sJ3o8TuBCkNkDrhKgpkQt2LsaS5gWkvL14SkuYNb5PmlWLX76/0cfFsDxb6ZM8j8zKVwiDh7D6WnaSGDfd00OC0zQXqe85cizOivn7aalh7zsdkhU3cKjrJCvDdO25oU+M05vgAMufySowPTFdLdS8ICbiJ6K+kZdDRv43QQHJ3GQgyLiIh0vUC1PuIVPrVeoE/wWw2AUgB3AJN7LfV/iltB4gSja5ywHuO+me97m/EmoK7eLNSNHQUKwm+SJIcEf0JiZ+eM2iBOs3ALTsw+t1xfbtSfUD6RdV2i8w4MpKzkakO7GIVBvBBF5sgZbf5Sp47R6gcOdAytluYb/dNQHpmc57XiuK1jgcCIMetdRbypQ9dlV4vpRS1g6q4ZxIkUmd01qnxd0AoDT+Q42T0yuTZoZsbI89wCBvmUSsRrg+WOJN97sikW99xX1ambZYYcz9FH7bgHH4Znnu4kVkeUYAs//Y8kAhbjACj/p8VETDsbw7MBqSnFaeZdqkhpfGq0vY5JUfcULz6i8rktEXSC5Kp3JZq6HmRk6IUCq1jXbIkB82ZWq9Z9pUpjXLIbi Content-ID: <49139D353ECF8C4E985297F8103D4B16@INDPRD01.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: b22090be-875a-4db2-822f-08dd558cb1c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2025 11:08:12.2128 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0PR01MB9351 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/simpledrm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c index 5d9ab8adf..1c20d4c49 100644 --- a/drivers/gpu/drm/tiny/simpledrm.c +++ b/drivers/gpu/drm/tiny/simpledrm.c @@ -602,7 +602,8 @@ static int simpledrm_primary_plane_helper_atomic_check(struct drm_plane *plane, false, false); if (ret) return ret; - else if (!new_plane_state->visible) + + if (!new_plane_state->visible) return 0; if (new_fb->format != sdev->format) { From patchwork Tue Feb 25 11:08:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 13989837 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71F73C021B6 for ; Tue, 25 Feb 2025 11:08:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EEF9B10E615; Tue, 25 Feb 2025 11:08:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="Neuh5Vkb"; dkim-atps=neutral Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010007.outbound.protection.outlook.com [52.103.67.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 896EF10E615 for ; Tue, 25 Feb 2025 11:08:56 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bc11LIKiYNjha8bfCaTV/ekbKI4WkSynCvoJBcSnvYKv8swcItQyut8t5na+Ye1S+lVfvZV1B5tRrxR/FrOEtw9CY/pHl4kuVQF79qAKW4k5eJDsTlHhCi3/u69KNO61UTQpli+KlCFy2NdDTbWOfXGEwDIXsCD141FFefk31crwDE+GLiwep3mhFuElbCFUSG9EF2qzAqaVTTDGLdk03Davo8vftxLW4/JlQSKy6b61zvc1Zu/0BadLlwc+krXTcga+hlLfJi3QPjFcBnoNn5FnR6nCcfN8T74haEp+r1rXlRWf7191CCKclX3xH8dRcwBR7Eeh/TWqifvhuwH2zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GAEaydk1bQrGgxI39LEo2OfttHhoe/JO7FU0F5yHrj8=; b=iBqGs4ntfdoKHn+Ph/+4hWJAnZU9Wc23jN7JqiGOO5vp+rJ1qu1In6J8g1iik5N4ET5zg6ALwOShcffa/s2Zm2LbibabyhMm9tUdU7LJn6yvrEb9DmrQjAjO2ZFcLefej2GOBfEQt66SV/qecoDYypVSn8tQ8ZVOakhsAosqAokhokUQlimH1iZDi0S0dfF4TzCHx+yfkHf5QquiBclQTNfv+ufGZL2ajgBoK0KE46iyzw29ytTeTcNrX+4Ud72afJJts2dACNF5jxiningRc6350PSWOwq+doJGUxk8P/MFlfMF91xBlbzsdErjK1nhpEMUK3rXIM0QJMvYOpJC4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GAEaydk1bQrGgxI39LEo2OfttHhoe/JO7FU0F5yHrj8=; b=Neuh5Vkb/neJU0PkKmQf1dHtti5mA93suSY0ool+LnhFFdVXad0F3Odv7dYiapJ+34PlqZspdAjHAfBvQAfz7ACXOWuamuw6cZupwCRbM4w1+jvQ23Y7j38kwm5TWGKqrQLZlmaHrHWNFjppLXP6IuFy/Nt7vCpZR8Q8AoKE0xkQ7bcwfeipt3NQdPbthiLBQIubEuQPDsRbWnB4fxORi7tFrOIuU2Rg11s3TKErgxG1IRkoRKUzWAxfuhLhEJFejdHMybJKzY/5YQP2b+uXJ0tAy9JvaOQLs5KB5+oh0boVMMPqv1w8+uQ0WXstGubcX6vRJcm5XPKckkUeCDFB1w== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN0PR01MB9351.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:108::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Tue, 25 Feb 2025 11:08:50 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8466.016; Tue, 25 Feb 2025 11:08:50 +0000 From: Aditya Garg To: "airlied@redhat.com" , "tzimmermann@suse.de" , "jfalempe@redhat.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "simona@ffwll.ch" , "kraxel@redhat.com" , "javierm@redhat.com" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux.dev" , "andriy.shevchenko@linux.intel.com" Subject: [PATCH 6/6] drm/mgag200: Remove redundant else in atomic_check Thread-Topic: [PATCH 6/6] drm/mgag200: Remove redundant else in atomic_check Thread-Index: AQHbh3WmZ5+JflMfmkqJI8IWSsKY7g== Date: Tue, 25 Feb 2025 11:08:50 +0000 Message-ID: <2E60927A-15DD-477E-9533-3256D384D984@live.com> References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|PN0PR01MB9351:EE_ x-ms-office365-filtering-correlation-id: 10358f6c-948f-443c-1c06-08dd558cc881 x-microsoft-antispam: BCL:0; ARA:14566002|461199028|15080799006|7092599003|12121999004|8060799006|8062599003|19110799003|3412199025|440099028|102099032|41001999003; x-microsoft-antispam-message-info: kBKbCkOgK5f7L062xDhPfH314+3t9S/AQxXnu9wg4EVZs5ik8612VNvubqgF29NHvZ5RhIlOqstAZgk1Mwp9i9zUy5punQJ1wzhlB1NzBqu0AG6wl9Y8U9lLN8OK+19Io/B+bSIhJgwMIyKgUereIqsJOPcF04ZMzG3iMSXYUaJCsrfDXhf5lLP5xjYIZfGZWwfjS6P8hb9CQ1XHnMBG1yVaVyQZUiJ2SaFkpMVSa7hYwV/Vwn6SgIRV9AGr9kDKlAavnqDSWAvnO7c6S/4yWDrCSkBwiWskm037/TCa/6wu4BABLBuBT+xiYqS39maVRW6RwPc0TLc2q3bvVAHkGld89+BH6io1bzAg4NQfSGPDQnz1AQ8FiW8VFnnx/DVGhRrclpGD9pS/0E4qiW5cbDIlUNjzimm+4555ZayeDRPsjEKbRgUnkdlNn1x1u+XifDGaqGZ373rVlRF5oMzBIM5N5sI6sLwgO7NYyPhaV2vrxB4tqJwYk+eLPoRCRoZH1X6l0SWY15fPZBDMG6VxyTV4kFQ9k1u9PITA+N9amsDKYPNzdIwqtHSppbFQy0A98z5ApU+16tDLYpLKjJUqKmCsQmpKcwW2qGrJ7PbeEWECi5Qc8IqpSdaQ/xCQJQe7c35zdESfLcYVfIlwpaf5nLD/4dI6wcwbnphrw2AnOvRw489ykf6XSFcUCw+oxP6dGyjBTTrZGooc0QBFrrOFsBnC7VrkVYEvx6Og4Si9zCoEdE4y4ELLn8ybzlz5H1kcU3lCGvi68FmhAiBiY+P5sncrnB6gkqcbHlfEaYpi1PhXSR+3bibyGPnLz83NB/wG0btXJxhL8U1g7BGI4wwaLMpviDRT9ssKHnpCfZXuw/JN0LbEOvs/F0y4UYxpQ6NuqQ+opuBTpejVQUczVCzMYikBSKxT8Lw2ufXp7vh9ff78KjjAsqyo+B2r2x4CBpb2RZQmW/KCWZ+r77vzrR/QjxwSiWNhBp5lCPhLKzNTRfTyxeC4VWujrebcShBFtqbX5RQtLuuVfk/mMO18NcUQnHYsiK6RC6rrUGFvzkqyRLHeuNNchkH2PAPjSypxhmyE/QCAc/fOqC3/yOrIyhprxSF8boIw6xpluAjFPLKZ6y3ERUi86J5cUGq4WdIJ1Dcw1t9W/lokwsxkpbwRuBI1OQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: uI5jVrJWkGCl7fYYf9TVDsAzsiG5ZTjzPYshBdg0Rj1exXgoSQ0ip5Txj+utI2YHmt/9mkSXKxzlURwt7K5bz/OiOUujZDt/gEzjZkAGuEd72yNbEvd/VtXE15XezUCbFnRVcKztD3o92XHSJ49G5+vFotLnuV1W2zDUtkyk0dL7p1P2GQF1u9i3Ygtb2TU5VKbsySq4hczIi2I0EzkZ8na5b4wdYEmZb/0WOOC/g8Eie1tCE0+yvfgc+IHkLPnWIz0p40ARDOuBcGOcYcDXZbrBOg/KL16OzpwHn634jluZh/OsJVK5bi2+qJAvmizoMyV9FZiihd/NF+3c51FnvSY37mPjZy8Vdvj5/i+GE6AXr9PwpbSR3PO1KGKdb/B3yrNjlE6NBCqKPk2karfAF4P4QQGJpHQC5NhUl/HYRFOjYYyv0fwsTAhHy6Y1PDIYPC8qyjEVZzuCK7Gi+fYYquwEl7qd8q1in8UyR3l0PpFo8qFZbtTDr0ZKDNcpBPVPv37+/VN1Y31bnPSmT/hG0Nf+7090lUXpodgBVcuk4x3rjqPRFebubtJFQExdxoyvpmiAOKAY7eO9ZMcufVWpg0KB1A8mkAbTMbNlLAca+8T4zdJtM56YEwzpFvdG5yOn3TbD7ybplMGvratIMuviJA+en7zROghutqgMBVki9CB6P2P20n3XC+htbmWwObta6AGFPSZ3tth3kcZWNl+5Om4JT5zs1OhY8syVLSVKAC5a9ktWrxKWxlKC1ASptcUNHTBZ83NswWF+aDOBPrwgjCuDtgg9+UxZafJlGCqG8S0HWc5UXUn0tNEW6PD98f+pZuiNfF+JNzK9sd33BSNuTLyTeWA/6ExTuEbbS4oqb56VsAZWkuoIqzB5emCfZ2rAg8pFP6dM57c1i1n1LgqpuLV/aVSmnR/UAoSF1uG55JVyGBPwK9giu+temjwoAO/T0841+pxXBBeTuRzIqomZ1ggJnACfxqbg0Ux1EdjyLJHcWpZ5U6gSkPFMPE4Y9fENIGFJ1uXhbnHAxLimfoOrsNc1N75UhX5p0DjwARngYGqjTa/a5IZ8AMDtiIbwYIWTdtlFd+c3ShAUpC/p7VyLIUIwKUQ9WQugLRPRvzqvH1u7XrDTm16MGbqN2V0Hnr7AhUWNwgdhZB4NB4EyQisd+HsUwU3ixNptDLw+I3Ts7EtP0+VSCZ++sHoKt7tlNppmw4GdSPPy6hGaJsewP4+ew7Aifa3Cv6Zjscw0knfpX/TUK/rH9O9gUZ/iD1tZY5HVFSpU5FLObR5jd6obG4Xrp7s9IGhQ4O6i4s1qkklyWUPhMDzKrnwdKnUlrL44f0Of Content-ID: <428AB63721E8D1439BD7FAE9402CB210@INDPRD01.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 10358f6c-948f-443c-1c06-08dd558cc881 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2025 11:08:50.3965 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0PR01MB9351 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg Remove the redundant else statement from atomic_check since the previous if statement was returning if true. Signed-off-by: Aditya Garg --- drivers/gpu/drm/mgag200/mgag200_mode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index fb71658c3..e3e102374 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -483,7 +483,8 @@ int mgag200_primary_plane_helper_atomic_check(struct drm_plane *plane, false, true); if (ret) return ret; - else if (!new_plane_state->visible) + + if (!new_plane_state->visible) return 0; if (plane->state)