From patchwork Wed Feb 26 09:39:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gal Pressman X-Patchwork-Id: 13991870 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2061.outbound.protection.outlook.com [40.107.92.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC62A226D13 for ; Wed, 26 Feb 2025 09:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740562774; cv=fail; b=nqWSjPA0LRQafyKQhS9HRW4/ZQfYpEHWJ8T9NCrFTIPK5Ld8exAK88r+YrPrD1jAESOXJ1cQ+QJuSdtGfzH6yunh/bz7s3pD5eW58dD/Y1WPdg+27UwpDNn850JnBvnQIQE847DzUiLsLx1t2D/dR7mMSd8WxiQoDurcIWmQX0s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740562774; c=relaxed/simple; bh=rKDCUBXK5YiLq5Yr0Bod2+aRB2qCSSoeEW5UMiu5aWU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aRHBLXGnbZn6ME4Fsxql+vYApdaOPLsfIqKGjdaAyTDeEY+HFKIChn86z8Ut5CSA+ocNUNoXhv6BStpvlFOKqy4NH6iXa1D1x6n4WeniucL6jb7WusHkLu3Zc4lB2YKVZALxDp9CMtbL5N18d3sVldC7VySNALKE7IMMR7N+vMI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=r8x5zMHe; arc=fail smtp.client-ip=40.107.92.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="r8x5zMHe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ae3RDJvHlxUf0LMjNdbju0COktj0RFSXXebnzmlIDlYoh1MYsArR7lhqB0earJOw6/oWsZUemese97g/Uys/SFg/ShMCI6Hnm+v/NXcEX0d2c/5zh3dHZSNwBmQ3n/auqvcp9ESlkxeeNzkrdp2wdcVn+u/GhyQVrIJNRMOiE0WlJLxy2fNvHGwk3kUf3uNMU0ikc+DUjlFEGAgNhdrvyIjv0Dn23zv6SUbbpIJOh0tLqvgPF543fyAR3a9mdNGhqad22Z+qDbPk3/0nQ4TYnGeKH289h2hVMNdIR6j2vnpGqTMJn0IY9ra7jjgMTKvZ7yAb96TZwKTuVXF1tk+j4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ybX40IeuryRZKAdeDx3HVlIjyiZ/COXth7G6/qZl0+Y=; b=JUqJfgfMZBU+6s6I/LyR55ba1Xdir40W7ybD8NftDFBePe0j0fWyQpIe1/ZVXTXu45kjcaB8BTE41P7FzySSgFtLMEXH90pmOHcgRUnQVhnj8jfJ6VPcej8DuW7PMcTWci50IoDCQZjFb9NDu/IV0ayKeVe+BXP6a3Zp0tgXjNLs29sstoc4Bu3n1UI2tkT+4PSfcR4dVHZdKmXROpHa66y0Z1Hu9zFJirOtEI3fQyscxQAoamdV5C9Go72+rakbu1ltnXQRJ2O8V7IiJZD6HXrFVFlRh4I0Sd+5kPEV+nDwEYZH9IvW9Y/cZqfxDzU491LkhoAepWIHxhLhc0Llhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ybX40IeuryRZKAdeDx3HVlIjyiZ/COXth7G6/qZl0+Y=; b=r8x5zMHekJfP9BstNdyxeNuM1HOx5lOGI/53zcc/wIfS1jE+sdd+L/6OTrJFA1Id9TV7sII09YC20uJ6WCjKJagsTeHTi6g0l0EdQHlbQ7OKuGgsrFIeUxL11JxpRkE+NPyBrugBmJaIA+RE1oOtkQyFGyZVrRjkGHPOr+hwLZ7UQRScisJY33+sREnSq4hfyL8escYWaxmVjnTLyDf/KEtGNEdD+oep4FnfY+9lU5mVXuWsaCJvZFCqYab75ucTKzM3/8yVDTX71koxqAbIiXRofAsJModLP8Dn4l5dTlhkg46Tsz5sbJq9CDNHIWDaHsVkYYNEe1EjT7HPzwi8EA== Received: from MN2PR11CA0014.namprd11.prod.outlook.com (2603:10b6:208:23b::19) by PH7PR12MB6465.namprd12.prod.outlook.com (2603:10b6:510:1f7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Wed, 26 Feb 2025 09:39:29 +0000 Received: from BL6PEPF00022573.namprd02.prod.outlook.com (2603:10b6:208:23b:cafe::be) by MN2PR11CA0014.outlook.office365.com (2603:10b6:208:23b::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.18 via Frontend Transport; Wed, 26 Feb 2025 09:39:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF00022573.mail.protection.outlook.com (10.167.249.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Wed, 26 Feb 2025 09:39:27 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Feb 2025 01:39:17 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 01:39:16 -0800 Received: from vdi.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 01:39:12 -0800 From: Gal Pressman To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , CC: Tony Nguyen , Przemek Kitszel , Tariq Toukan , Edward Cree , Martin Habets , "Jamal Hadi Salim" , Cong Wang , "Jiri Pirko" , Simon Horman , Julia Lawall , Nicolas Palix , Gal Pressman Subject: [PATCH net-next 1/5] coccinelle: Add missing (GE)NL_SET_ERR_MSG_* to strings ending with newline test Date: Wed, 26 Feb 2025 11:39:00 +0200 Message-ID: <20250226093904.6632-2-gal@nvidia.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20250226093904.6632-1-gal@nvidia.com> References: <20250226093904.6632-1-gal@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022573:EE_|PH7PR12MB6465:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b4763b7-bb41-41d4-efac-08dd564976b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: xZifwLZokzR4sclfyoo2g6+LzcuI9mZc/DDU3lWjlS7pueX7wgPq9sVjk5mAyw0oKfkKRASGJkDlN3KVuOugoL5SCQKEwnVRa+g7N0IdYz4oZZ14kNkW4nJzadpUzV1gTCynPlBIg6HSs+ZO29NA9ui9MOAgaRsJNfrg5BH67JUtUzDKJ3Rj09ELk28a2JBlJ7gH8MlAVlU5p+ypQrsAVVuci6moZ9af2TBgiaZCpL915KyaRcHsBwAF4xBM2QiJDCghQiSz4mF5uE06iRn3U1srqvDP6IabT0WVniSKg/c4uExeMrkxLPya8tr5XYPpVQYt2/z8/PM4OZZGu8cEAwRcyWUumt+RvXTcnXTRXlmdincFUG9hHp0rj2nsbLCuVh25RaHxRv+kFdYo4myMQWdutxEbWr9Iwqm7qn3v4/lqX4kUyLU0v+OK1xcu4go97mg3xZeWUtrPaqmefm9lOAYpzIYztpV0v/sOTuzYnJsuGQtJcRDY6Afot/2rGxCKFGwoHA9U7/T/+n62wEDfPHmgWc3o5boiDaG4fkhnU+vNf/VYEYCxJBvgyoQ+2+fBpdaScoar1SNHUIxYMJ4TyvHQcCc2EmLhZA+xDIb7DVrKj5WzQUiJH5bpXgOkuV6e+ge/+z62SUJhx5x02mwRveY6Sthyftr4HYGErSfSpoiK8s0pBCVsB8jt4+RqEa2qlVAlhMLfkNu6UdeuvdapNgERCXujykCm7XZDfInl3x0iwPibQCMrtu1FH3VdERVLzhqkpm84wW60r8tk/9nleHlgm93YYieDxQ1zcFaAPMRsR04r2MyjqoKypNKzGwE+Zz78Pw7phtnDGdhMFq5udyjBu4n/AuhHMvCC36nP2Y6BcTTtYtFoTzvy9+SLfQvPOccSi7xO0ua3FR7LqcDZzxI24H5f0FllLTjv0sShXs9TKnko4AwrcTKhqjInK/erufo5A/Y3Vu1lbXqBO5h2/ooLPZg/pwltduMwn5MD2320yXLTzZUWM69wcou2/3df7Da++VRJH1eChqU4yiKc07pzH+7R+ucdgf5ugtCpHoqG7EdLhlsfNpbgeIVt4IOYgV+OxBZtDGbDPEpq19yjwZxMvbXxcXMdxL5R5UPVGpbRZ06UqghzhUsxKfxklQkbTRJniSSXJo3KZSUg6MdKjQF7xkp/25+LFUEx/4rZzNa2HnO4mWTGJOFOgYput8AIb28c8gNMbi1KZUtuMFVC077WGVGm2LD7FGP+74B2PvV9GfsE/ta72dQ8a6ZEb06abFf9IJCrxD+7B8llVuDfCyzkKZCbchrlwgYPmK2ny+qzgk8WZ7N5ptJqJCDE/Qr/x9XkiwcFm+rlSvs+EsGjgkZHqUwO3PPNtEVbpIf91LvttcJMlTvrNIKdQ3yuwxPUGD/0tTobF6Kd1PvAY6FlETyD7wAutMgu4ULCH/CgfxPDTRyfRUk3mDpD4LPAOfK9zMr1UeCUwSKhj7Ywyc6ZvY/5gjqgAXnN1BhLQeo4UgQ= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(376014)(82310400026)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 09:39:27.8995 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b4763b7-bb41-41d4-efac-08dd564976b5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022573.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6465 X-Patchwork-Delegate: kuba@kernel.org Add missing (GE)NL_SET_ERR_MSG_*() variants to the list of macros checked for strings ending with a newline. Reviewed-by: Tariq Toukan Signed-off-by: Gal Pressman --- scripts/coccinelle/misc/newline_in_nl_msg.cocci | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/scripts/coccinelle/misc/newline_in_nl_msg.cocci b/scripts/coccinelle/misc/newline_in_nl_msg.cocci index 9baffe55d917..2814f6b205b9 100644 --- a/scripts/coccinelle/misc/newline_in_nl_msg.cocci +++ b/scripts/coccinelle/misc/newline_in_nl_msg.cocci @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /// -/// Catch strings ending in newline with GENL_SET_ERR_MSG, NL_SET_ERR_MSG, -/// NL_SET_ERR_MSG_MOD. +/// Catch strings ending in newline with (GE)NL_SET_ERR_MSG*. /// // Confidence: Very High // Copyright: (C) 2020 Intel Corporation @@ -17,7 +16,11 @@ expression e; constant m; position p; @@ - \(GENL_SET_ERR_MSG\|NL_SET_ERR_MSG\|NL_SET_ERR_MSG_MOD\)(e,m@p) + \(GENL_SET_ERR_MSG\|GENL_SET_ERR_MSG_FMT\|NL_SET_ERR_MSG\|NL_SET_ERR_MSG_MOD\| + NL_SET_ERR_MSG_FMT\|NL_SET_ERR_MSG_FMT_MOD\|NL_SET_ERR_MSG_WEAK\| + NL_SET_ERR_MSG_WEAK_MOD\|NL_SET_ERR_MSG_ATTR_POL\| + NL_SET_ERR_MSG_ATTR_POL_FMT\|NL_SET_ERR_MSG_ATTR\| + NL_SET_ERR_MSG_ATTR_FMT\)(e,m@p,...) @script:python@ m << r.m; @@ -32,7 +35,7 @@ expression r.e; constant r.m; position r.p; @@ - fname(e,m@p) + fname(e,m@p,...) //---------------------------------------------------------- // For context mode @@ -43,7 +46,7 @@ identifier r1.fname; expression r.e; constant r.m; @@ -* fname(e,m) +* fname(e,m,...) //---------------------------------------------------------- // For org mode From patchwork Wed Feb 26 09:39:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gal Pressman X-Patchwork-Id: 13991871 X-Patchwork-Delegate: kuba@kernel.org Received: from outbound.mail.protection.outlook.com (mail-bn8nam11on2061.outbound.protection.outlook.com [40.107.236.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6462B1E1E18 for ; Wed, 26 Feb 2025 09:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.61 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740562779; cv=fail; b=PHfAsjoDxaocz80TAZ/SttYvtKpLPt2c3YdW5N5dk4k0IFNNVMcL15VvYQ3a9wmDrxqnYRQ4nEmV2WDkITZF+lY2tjboCiBNkb97qKYvfM3kQ3AQH11IDceYAJhWXebJpBVHlk4+C1WZOZtJSrq3X+MOH9loowhKY/Ipl2voPiU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740562779; c=relaxed/simple; bh=Qa+Lf9Hnga4VmYTTYQ86gyKtW+lYA4zc9blOsEIvD2c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JB7PjfUZu8uf5TLLs3ircnIeQKD7VcmDGrKY2cCeHdoD9nS8SMQ3NscxXw2aZagXsPNZcHPVjYMs7dwYIm4BZfdRdqcNPCDM1y95UgyMR0Z3sTeLKChn0YDcQBUA+/nlJ60SX8pCGdnBwRaVpd1WOB9FzlYHjERtcZ94binW71k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=bG1q05N0; arc=fail smtp.client-ip=40.107.236.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="bG1q05N0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RC7UiG4G1A2WK6P1yT0P7u0ZMxlTS4tpyrqYU0lQQ58/RHmmLBmC7YyPnZ/9ZEx1WHrsMBfM8wkhQAg26zXvAqoyJCDsr1V7A/JF12iOFCouAD8ZBQW3P2M7twEh++41Za1QEfLGV78MOTtRhQcKo6D+sf5HWNtC3/bT+kjAWr8CniENce88sS4S4iL7QDbCm4FLXmkACcE/R1/G8cleLQawtsLd/WA5CITZ2hBYB4SSTHsTsON2yVnDXQpffiloNA3Td5ap7LdLKBpwItZbWDX6GwJv2art78+J1og3K2TQx9MEW2wGaLsy8KkC3pYAZYv9P6qizpiEH/8JgI9wug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dknearg1mJysnVCV/jgPRkX0j2htz0hut7OggUbz4BY=; b=TfP7I2IuooE7DwCur7njBnudklhv4/6VPKiu/SHpAAlvsFgNFm0iMYa1JQeeoPjdTFJBAuqkjZJ/oeXRTdTxDT4jJeyHcNZIFZ7VsScffBgSPTLCaKi7OqaV77Jn6aFXZSxXrtPbmfkiQ1xMtc5kjaaFaQEItbIb4c+LuEdXpiB1WfIyBcR8P4or/Se1BWB5/i4KagIzkuccrYGA6dxm4K7IqZeGEQ9V3D0DM4PGnfNvJ0FIlcwrCa2COtiKFnItf9RQ/6pl08RVM5HgSDQaE4J07nfSf02mIOXfDWLa/z2Idd5RwuKs8sq+TTpZwabUDDeg5x3kzZFMDaon6x3wrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dknearg1mJysnVCV/jgPRkX0j2htz0hut7OggUbz4BY=; b=bG1q05N00Orm4LTMWKzftJfaP+IJq7vqpPVpYhUKgCkI//shLms02XKRyj2RO4IpzxO0OLYvA/UGkmGVhzob58Gc3s2Phsnwr7PwUErrmUv1n4eRe4Wf6N4n4r77EMOU1eV3qmWUPuwkZbNHomEcEQCUnuAi6K+p7yWsnLApgB3wJbpNUi1BHyxpEiKBt+EdldQjs4iQ8Z9B/jYVVile2GKl2nLrULRP/sXjaPvmOTrX/Gpqoyop22fcyhwBh42/8kms8OKme/HzxZZUWeOISvlj1DoEL8ZyL3uCYj8NmtlWsUAXQCWb/tkNXHKmqg8pe5+THxRCi0Zmq7vWHDqEXg== Received: from SJ0PR13CA0105.namprd13.prod.outlook.com (2603:10b6:a03:2c5::20) by CY5PR12MB6298.namprd12.prod.outlook.com (2603:10b6:930:21::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.18; Wed, 26 Feb 2025 09:39:31 +0000 Received: from CO1PEPF000044F1.namprd05.prod.outlook.com (2603:10b6:a03:2c5:cafe::6c) by SJ0PR13CA0105.outlook.office365.com (2603:10b6:a03:2c5::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.18 via Frontend Transport; Wed, 26 Feb 2025 09:39:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044F1.mail.protection.outlook.com (10.167.241.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Wed, 26 Feb 2025 09:39:30 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Feb 2025 01:39:21 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 01:39:21 -0800 Received: from vdi.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 01:39:17 -0800 From: Gal Pressman To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , CC: Tony Nguyen , Przemek Kitszel , Tariq Toukan , Edward Cree , Martin Habets , "Jamal Hadi Salim" , Cong Wang , "Jiri Pirko" , Simon Horman , Julia Lawall , Nicolas Palix , Gal Pressman Subject: [PATCH net-next 2/5] net/mlx5: Remove newline at the end of a netlink error message Date: Wed, 26 Feb 2025 11:39:01 +0200 Message-ID: <20250226093904.6632-3-gal@nvidia.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20250226093904.6632-1-gal@nvidia.com> References: <20250226093904.6632-1-gal@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F1:EE_|CY5PR12MB6298:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ef345c2-9b02-46bc-8797-08dd56497838 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: xxSJ4Bgla7VWC9CyKHzqLKMhm1sdziB+98deCmkSy/l44qsvUqyHEENKKfleKsAK8D0GM9xB2wHePlKcxSC9t9nQ3CZLOvf1f+di+lcMxchPyr1l1ye9TbGI/z0D4Ygyv4LuTSdrp8DlHJuTDDJ8CzkxVP7WNJJCnmpL+/5F90YYk83G49MdZqAPkPVQqxsGSRtGNk/OZ05OAwteg8MHMBOSQYwq+i3TljuzaOJA1VlpnwXrwRi9fEdmoneVczcYkarM/bc7TQVVCa66eYVtPJknXnlTYGV7EXD1Krdu3qaYmQql+AE5KekMvPsLAURf8yEoig5xjmxOQiFGaLTicjFhH2Mx+5xPc8n9YBn62zkyKAS0E6Y2wpJhhPEHaQ/7GGHvngf3lA5NM2whCJmWyG3k4eON8B4w3BZRxaOI9DOfenLGOZo7zQflL0vIyMQdRMU+WpD49bjMBlbgMCIDqyfVSZbZ+UXJ1G2UuQj5mBsA6kXtM+X7g1+ZG0ezp1fwJmLduGtRM2exi61IuLozXeG8tp2nCYe88mMjyxKWtnEVW/LLCMluks2QaFoQZ8/cH/Xlgss94GuyzpMPHPazOxCQiwQcicQzZW4NxbvfEQWgTn3CMezn4RjpxoV8MXN65dlubqYiYMKHmtYJuOBID2o4FiufeVyyQgq0YpIyWjkoDJfN67B0Ik5gwgqqnn7/Myw526i0QnT7ro/4NM1aRZyipwa3uBZs4KZ8RNVqbTGB9/4t5shVVB2W/f77Nn4eDpUgEF59b/eYVuTKAGwlPZcSUNL76s/xfBwZVevofSUlmTz2SrHhRQdLPgRMKP6KRudMvDOSyQ37NP6pv2Xrw6JWstH9qAzIBteYNXEvhAwkBoOXa74ksILrWv74sOjPsabsqFrINvri3si65Z767tDTO8OmsRC3/9aTq/7QWDk4MdQCVDsRbTA1G95dH4fl2erm4oRZ1xC6e7+z/yAAsffAAwVZYOOOHAiQsZLyCknI8g0IILHK3lBHgx6716Mt/eQfc35ypbQwNqEoWSERrbo2crG4KaiZZ1N7IUhQlOyqx0cIIfxsTzAxBW+xUQGxSDnHE1J5NPgWspm7SWfLl3erZQ4OqOUDva9yKHpgcudLdeUgFDZZtja4nmckcNYExNwhcBeNQvdmIrM7wSsB10u19nPF5i4msgyz2kxEWqD86oxnMepMuQ9CK65gY79v1YM3hcl2T6WSrMH2QyH0DPpoCH9pBsV37//aVCiKJxv5eea8zYS+kVfVXTt8zqoGP7rK/9gRe7SJzwCMWtLBUmh6E2nx32Nq5nZ3HJDTEjS8czqO+94jhPVqlcpzAm5pG9FVTOgsW9QFLIWKY06SUQO0DWAcAjQ3qC0voW3lJJ/GD4R50nrEnGpwjRN/7qQA2vbbPwuhGEUHr5yYd/3pLhp2YCXZu12NGSFFevMrK9ttClk4p4cxHRuJOamp8YetZx9TBZxq/PZppPdmOHzz/+wQCe2tuOg7Zz38gEC4QbI= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 09:39:30.4644 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ef345c2-9b02-46bc-8797-08dd56497838 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F1.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6298 X-Patchwork-Delegate: kuba@kernel.org Netlink error messages should not have a newline at the end of the string. Reviewed-by: Tariq Toukan Signed-off-by: Gal Pressman --- drivers/net/ethernet/mellanox/mlx5/core/dpll.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/dpll.c b/drivers/net/ethernet/mellanox/mlx5/core/dpll.c index 31142f6cc372..1e5522a19483 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/dpll.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/dpll.c @@ -242,7 +242,7 @@ static int mlx5_dpll_clock_quality_level_get(const struct dpll_device *dpll, return 0; } errout: - NL_SET_ERR_MSG_MOD(extack, "Invalid clock quality level obtained from firmware\n"); + NL_SET_ERR_MSG_MOD(extack, "Invalid clock quality level obtained from firmware"); return -EINVAL; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c index e4e487c8431b..5c762a71818d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c @@ -140,7 +140,7 @@ static int mlx5e_tc_tun_parse_vxlan_gbp_option(struct mlx5e_priv *priv, gbp_mask = (u32 *)&enc_opts.mask->data[0]; if (*gbp_mask & ~VXLAN_GBP_MASK) { - NL_SET_ERR_MSG_FMT_MOD(extack, "Wrong VxLAN GBP mask(0x%08X)\n", *gbp_mask); + NL_SET_ERR_MSG_FMT_MOD(extack, "Wrong VxLAN GBP mask(0x%08X)", *gbp_mask); return -EINVAL; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c index f9113cb13a0c..a4b2e57b3f80 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c @@ -2040,7 +2040,7 @@ static int mlx5e_get_module_eeprom_by_page(struct net_device *netdev, if (size_read < 0) { NL_SET_ERR_MSG_FMT_MOD( extack, - "Query module eeprom by page failed, read %u bytes, err %d\n", + "Query module eeprom by page failed, read %u bytes, err %d", i, size_read); return i; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c index 5f647358a05c..76e35c827da0 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c @@ -1863,7 +1863,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device *dev, u16 vport_num, u16 esw_ "Failed to lookup bridge port to add MDB (MAC=%pM,vport=%u)\n", addr, vport_num); NL_SET_ERR_MSG_FMT_MOD(extack, - "Failed to lookup bridge port to add MDB (MAC=%pM,vport=%u)\n", + "Failed to lookup bridge port to add MDB (MAC=%pM,vport=%u)", addr, vport_num); return -EINVAL; } @@ -1876,7 +1876,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device *dev, u16 vport_num, u16 esw_ "Failed to lookup bridge port vlan metadata to create MDB (MAC=%pM,vid=%u,vport=%u)\n", addr, vid, vport_num); NL_SET_ERR_MSG_FMT_MOD(extack, - "Failed to lookup vlan metadata for MDB (MAC=%pM,vid=%u,vport=%u)\n", + "Failed to lookup vlan metadata for MDB (MAC=%pM,vid=%u,vport=%u)", addr, vid, vport_num); return -EINVAL; } @@ -1884,7 +1884,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device *dev, u16 vport_num, u16 esw_ err = mlx5_esw_bridge_port_mdb_attach(dev, port, addr, vid); if (err) { - NL_SET_ERR_MSG_FMT_MOD(extack, "Failed to add MDB (MAC=%pM,vid=%u,vport=%u)\n", + NL_SET_ERR_MSG_FMT_MOD(extack, "Failed to add MDB (MAC=%pM,vid=%u,vport=%u)", addr, vid, vport_num); return err; } From patchwork Wed Feb 26 09:39:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gal Pressman X-Patchwork-Id: 13991872 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2042.outbound.protection.outlook.com [40.107.92.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3384238158 for ; Wed, 26 Feb 2025 09:39:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740562781; cv=fail; b=FDS5cUyAVeeOMHu/9Acyotaap7XpmiJ5joQBj9cVn+5uRGXwLKdDv+nSeYWijh8o4nrpq3PKgS54Gr/J0S0q1VKnGLi1BgRoZjlyT8QlboMdTsx8LShQalvz1LQDznwmFUJacVBM0PfrHNtwgM6xGY5RNELJHcuxMzKJEU/X1KI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740562781; c=relaxed/simple; bh=S8rS4EZz6jPesRTyUpz50IOHWeH1XjxrOxZWF94QwQI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=a8lEUiHoiaF1Rn9YF683liYk81ZIh8LDnXOB1vPjVmW0qb9h+6WwQxX+oELVjiSGd1rJowvq5NsCakJF41kYDoxZlm0vDbZ3jwv1vc9GiSD7AdWbcnIK7nS2aaFgGhZrfzUpF9EAfO4xuXvI9Wn378PUD4TOWxt6MTHlRcp0h4I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=KUqtTWm/; arc=fail smtp.client-ip=40.107.92.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="KUqtTWm/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QALZstf/NUcW+4WqrS7gK5PgNOmCoWDQnGT1J5zxCDTrMatL+pccseX5sYfq/rJMVPWeYa++aYjX8MGP3wVKdoIOaotkPwFkgaiBEgxJ76gLMZ3E2jaEM+nrBJB6eOsh2g52fK3eEF8g+0+U0+muZVAFx4euPeFCKScJ62xKTzVKyo6FjyNpB2OGbkjlHIyj+6XIHqqhh9kWohq9yQTSjSEXYkgomUC5eGTyKXCSXUf+TwoA316Ndz+6YsvBO0wlXyCW30U0/5ITvolHgpnsCzO8++EOYA44UrIAhl5w/7TyVDbgtNGdDalIHeOzcl1aUz16FIJeeBpikShjkiPGgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8m8cdwv4eF3m3AULLLLL787vIW7J+KioyWUs6HpEZ7A=; b=l1zLFxbxDzb5G7keFwZ2hI3f6LltIHHioUuEk6ibVj408b0HlFSc2RXv2WG8uhmU3484GHqWzYBrLrLHg/8p9fQOUwsXhpxpBElnoMl1cEsrioDWBT4yKoyEMUeiO1YTlriA3gCVJ1CmbHwpdeXERN/gn8LHwS06O1TDSZa+pI7jxfmElq3gxVQiqdkX2COguLQ5Zt37cVJxXerohZjqG73mrZCTgTCpco2drvVdeFGn18OfEDRIxsADLorytpvg9FyPDtdJqXelSJrc78mUdku3jebihf8HIHJKZpF0Xhto0/Ex1bc+HypZ7JnFKDVjcHoDc/HmFGM4VzcLRuOpOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8m8cdwv4eF3m3AULLLLL787vIW7J+KioyWUs6HpEZ7A=; b=KUqtTWm/aVPCbI3aaYkPc9BmC5XvH/+h1/21ihCFOmXNkDXO9ZXfMrD6CLnjjMafkmJDmdqku6iA2W9dlNDIcohRYn3pCai6Cw7jTWAQ/e1SzlOyrg/IO5m6FxN0dqDbz9duI+F/0wn5+tfEe484gLhhInSWQGPKZl3gBM3OY3Wc/OStk9T4/wG8ZcBG8yEIdwtE2fTXy4PM1ND6u5cpPwK69oPPfz22w/pyhyXFPz88HHhzx68IVhOfQq5a9Ppczoe5ue7oNNTCd3hAERr/nmWdpJFzcAfJjQ0eRmiq0LSn97lD8Br9oT0XQBA/Q4Z0iM6N7oi6Q/8NwNaUsGQsVQ== Received: from BYAPR01CA0045.prod.exchangelabs.com (2603:10b6:a03:94::22) by CY5PR12MB6345.namprd12.prod.outlook.com (2603:10b6:930:22::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.21; Wed, 26 Feb 2025 09:39:36 +0000 Received: from CO1PEPF000044F5.namprd05.prod.outlook.com (2603:10b6:a03:94:cafe::ac) by BYAPR01CA0045.outlook.office365.com (2603:10b6:a03:94::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.21 via Frontend Transport; Wed, 26 Feb 2025 09:39:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044F5.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Wed, 26 Feb 2025 09:39:34 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Feb 2025 01:39:26 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 01:39:25 -0800 Received: from vdi.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 01:39:21 -0800 From: Gal Pressman To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , CC: Tony Nguyen , Przemek Kitszel , Tariq Toukan , Edward Cree , Martin Habets , "Jamal Hadi Salim" , Cong Wang , "Jiri Pirko" , Simon Horman , Julia Lawall , Nicolas Palix , Gal Pressman Subject: [PATCH net-next 3/5] sfc: Remove newline at the end of a netlink error message Date: Wed, 26 Feb 2025 11:39:02 +0200 Message-ID: <20250226093904.6632-4-gal@nvidia.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20250226093904.6632-1-gal@nvidia.com> References: <20250226093904.6632-1-gal@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F5:EE_|CY5PR12MB6345:EE_ X-MS-Office365-Filtering-Correlation-Id: 5301bc6f-f1f4-4d47-1b3a-08dd56497ae4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: tz1Jcd1rlIB71c1JHjw5vSDjNGmMXKam0s5Qu8//nWRScgWTQXUnYOLnJee7GmXnPdCgOrDGdkS9ba0YE/o4WJ9WZe1v5efoLvoM/hKdZcwqWsFIkDu7l/LqaQCzPC8B0CUsSvqhC7jKPKd0oEhPLCoPXXnlBOcReV7Cido+wpb3HV3WMu8tLif8g1G/iYOR/Ko9B6hq/HLv7jTUdIYx1Xk/WODlDzK5CHY/qRbJ4mEJzmO8dZ7L/XI5TVoUnYXmjTFnDvaNKmMh/h6S6k2hNw633FPnaVTYoWz5TuMtOKx4HJtsZDGzgHerZPIDFiwdHJPx3XNVnDaSZRZ1e2cC5Rp7V1+XWFSnfrksw2YlK9SnGVb3cJ6zqK1dhpqDXGt0tjmXUR2td3cjiLzC2AVERe74at46/xGd98juGDjrjX73UGPqjS80Pcxz4DtY6jTsokDfHEk391hYP0XOUMFIwDQQJAU3BS73Xs6RKuCpiJDL2j5dD4qCxCRx7GvFx0IVUU+G2wfjLz64P86OK+G4Z1ALDo8/BXFcmk4A1WXY9nqwp79N2bd8JLJuouE+CtOLOiZA4uPv0LjIO+kuhGUC6M95vJnReLVU44yFeEIOCka9hHMLbGAVZLVrgaQdsFewXIpLrIMsHTuyF/zXOwJJzn4LjbE1fKgjtrLXr1wfIQHh+kj8XAfIozHIP/0YyHve+n49muIjOHAgwt9xMmRV+c0vbbq+jzwljf4ny2MZ4/MidkNv0RL6MxGAEqoQ7m6IU2JPTtnbb7yadvC/ybgL0wA4JDMb06e6unKyQyGka1vD6Je84SfLIcwuLs99yrs/tVIGWh9PVGFs0QU9TpeRoMJBk+r1CIIufDARaOWcazKJQLWR1YbZOLkXQLjhZcl6e/LCSMVOgu7bs+KN1EIbumv7Tyojpn8xahgaZdYdQhSTKLmsEk6oECgEUZGJANoVsoOYySL0p6JwmY9ZaCJ0apI7UMWFuenR81AB/upwokq/leSUlguk8LnmG9y6SbuEwKlkdulkdctwREn4WYB+SxM/f0w44Msj/jEYZsXuJHwLTqnDUosQ5oSfh+5NNC96cvJawMRVzu/P3FPcrsoREh/S9Pq9DPzFhVDBiKRXxNwDjU3MC1UPkbvrgNKRwBWb3c0dYlMvKFnBn4SwbV0/FeZZakUbfZ7C+YPlFMJRUzXRky0AXxWuzXEvVRiDyDNIKV++8rFELyYOv0mGOzpjmXHd4d3ZBS1zmbQ3KpINSjCW8/b0ezFqM6FZFUO01tNl6GEo06qSFtXYHzVg4McJBY5v+GMdjLPUUsgd5h/tsDwT6IQtLr6+TIGwdfxs2gyq4H2XPvqGXUY+7hgd190T3x97fwI2/sjaHTbFhjrc6u371buRcbbmGs51CWQPE8N98bPzBMRzkjKRp3APKpH12GLaL4UmHc6HqWOnNU97dBh/ZQRwtp3BBON5WHf8i5/Dog6E1JZyDXyD75ayL5Kxb3e84PCfA6/KCfCsXKyY/vQ= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(376014)(82310400026)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 09:39:34.9599 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5301bc6f-f1f4-4d47-1b3a-08dd56497ae4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6345 X-Patchwork-Delegate: kuba@kernel.org Netlink error messages should not have a newline at the end of the string. Reviewed-by: Tariq Toukan Signed-off-by: Gal Pressman --- drivers/net/ethernet/sfc/mae.c | 2 +- drivers/net/ethernet/sfc/tc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/sfc/mae.c b/drivers/net/ethernet/sfc/mae.c index 50f097487b14..6fd0c1e9a7d5 100644 --- a/drivers/net/ethernet/sfc/mae.c +++ b/drivers/net/ethernet/sfc/mae.c @@ -755,7 +755,7 @@ int efx_mae_match_check_caps_lhs(struct efx_nic *efx, rc = efx_mae_match_check_cap_typ(supported_fields[MAE_FIELD_INGRESS_PORT], ingress_port_mask_type); if (rc) { - NL_SET_ERR_MSG_FMT_MOD(extack, "No support for %s mask in field %s\n", + NL_SET_ERR_MSG_FMT_MOD(extack, "No support for %s mask in field %s", mask_type_name(ingress_port_mask_type), "ingress_port"); return rc; diff --git a/drivers/net/ethernet/sfc/tc.c b/drivers/net/ethernet/sfc/tc.c index 0d93164988fc..fa94aa3cd5fe 100644 --- a/drivers/net/ethernet/sfc/tc.c +++ b/drivers/net/ethernet/sfc/tc.c @@ -1043,7 +1043,7 @@ static int efx_tc_flower_handle_lhs_actions(struct efx_nic *efx, return -EOPNOTSUPP; } if (fa->ct.action) { - NL_SET_ERR_MSG_FMT_MOD(extack, "Unhandled ct.action %u for LHS rule\n", + NL_SET_ERR_MSG_FMT_MOD(extack, "Unhandled ct.action %u for LHS rule", fa->ct.action); return -EOPNOTSUPP; } @@ -1056,7 +1056,7 @@ static int efx_tc_flower_handle_lhs_actions(struct efx_nic *efx, act->zone = ct_zone; break; default: - NL_SET_ERR_MSG_FMT_MOD(extack, "Unhandled action %u for LHS rule\n", + NL_SET_ERR_MSG_FMT_MOD(extack, "Unhandled action %u for LHS rule", fa->id); return -EOPNOTSUPP; } @@ -1581,7 +1581,7 @@ static int efx_tc_flower_replace_foreign_lhs(struct efx_nic *efx, type = efx_tc_indr_netdev_type(net_dev); if (type == EFX_ENCAP_TYPE_NONE) { - NL_SET_ERR_MSG_MOD(extack, "Egress encap match on unsupported tunnel device\n"); + NL_SET_ERR_MSG_MOD(extack, "Egress encap match on unsupported tunnel device"); return -EOPNOTSUPP; } From patchwork Wed Feb 26 09:39:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gal Pressman X-Patchwork-Id: 13991873 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2045.outbound.protection.outlook.com [40.107.100.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53513238140 for ; Wed, 26 Feb 2025 09:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.100.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740562785; cv=fail; b=sbXLYLqRWQ5PxKnNfToawqtikuS8qreLu82JKwf0BWKqsmbIYFwdnqxmi8l+PvmAIWifsaxfpO3yK6wAuOLCBFoOWkXcd3vqzjwlketry9cYD/NJ1JwHZzqGSPU0o6t0t2D+1UM5qly55epW9oYdFw7QqT8WeYi3zf5O091FvpQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740562785; c=relaxed/simple; bh=y5grZed00anT5fp/ikxLS6sb0USZGwPipvyo/9ZGPfk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TdjzSAr14V12WXIk6G/hjkS/xdbRMI0XklQABnKkYsj1kiqO8kTcyaE+Zp1MpxsgwCz9ACd+MxUvj2iYiV2Or4SJIl4DbJI1mA+qQPI+ANhexLs/Uleb4+PnwllNKCHQY+zcRkE67+e4IBIjCPNUIJyhbCJq9auiOlN5PoNrvMI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=nojXmPUc; arc=fail smtp.client-ip=40.107.100.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="nojXmPUc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KZWDxL2UabRgQs6SdsV1BFbxuWY/qMdbeuJx6VVaWKuKuY9SipEVKppHxq/TFBH3Bv70EkagE1y1WUawH4bY+achvlyQ94hruJTiZjGVAL0FnSbAq6PhAzRwI0Mr9rAA8+xr8XB5iRzoURzlz3bkyUYZyE3pcqTTcjpQC23oG/NT0LnNG2egU18uKvDq2PMrQG/hGd9ZN/8vNM5qdAU8fFTBjN6z/VGWSmNSkga4Ylsh4rJQVLcQoG5xMH1RbnfCsiKiKqqAyW9H/BeCtK4JSyzKXi4CrZBSjiwmRBGXIYz8sKoT+N4pRPxyPRKiPVI1QvYO6FJ8uv7jBUCjh8/r+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zAz4DtHvUMMsiJM2n9ozP3t/c2d3M/1yQhv15i3YsFo=; b=SvV7OiCUl8vlqmIgJggQDNawFiwRjUJb+TbEd4CJf1nojB30Y2hreRLqDQLapXQAlcNQFSmXAH/mf8MuKC7DZcUceF8IhAJfWNGOcxAJRjkdkpskRTp1pmXP3uL85S+WH/ZnNy8SS9gtrfy8ctMhkgVrhnGJymXI78n1jC93m/wgWUzOwEaUbanYofObkvqMR/1bRubBXYYK8Z1d6zTlfOT4oSQQymHcNeEW43RohOmBLpTKAv9VWhw7/kKRLDsZ667f9d57sQTEaPIP/r3X2cDTcvcs/bymij/EoRnzXgzOsPfzollagErHkRmjs3tJYUSwxoiLQmkfeutfvzF75g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zAz4DtHvUMMsiJM2n9ozP3t/c2d3M/1yQhv15i3YsFo=; b=nojXmPUcX8XPb68x9fmSbqulnOHZRiEMD3NUuL3VeYs1BH6AF3487bBHv1S3+1HEWsuWIovEJuQiOtccWWO3R8o+lqZbOwJmqR6aLqVaOVvdN5ooSYYB/YtBqO3610p2feLgSLacsG6oqhCsIEQsTAp62TFp7Py1FHFOELrtqv97g5wD7eUT3QlB1pwuW0fR87zWqVKv2RBeCjRN9hlMbK3uD4nTVzYlkx8a9X2rHqhILhydbJfUCaZ7G7LL2WfpkHtEO/cZNUbM1luqvlabTcU32YhgGMILu84+fyoVcIbSSZIEQC3WQA3+rDYFCffV0E15xzT236GBy3T9VUKUsg== Received: from BYAPR01CA0052.prod.exchangelabs.com (2603:10b6:a03:94::29) by DS7PR12MB9474.namprd12.prod.outlook.com (2603:10b6:8:252::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Wed, 26 Feb 2025 09:39:39 +0000 Received: from CO1PEPF000044F5.namprd05.prod.outlook.com (2603:10b6:a03:94:cafe::b5) by BYAPR01CA0052.outlook.office365.com (2603:10b6:a03:94::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.20 via Frontend Transport; Wed, 26 Feb 2025 09:39:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044F5.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Wed, 26 Feb 2025 09:39:39 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Feb 2025 01:39:30 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 01:39:30 -0800 Received: from vdi.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 01:39:26 -0800 From: Gal Pressman To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , CC: Tony Nguyen , Przemek Kitszel , Tariq Toukan , Edward Cree , Martin Habets , "Jamal Hadi Salim" , Cong Wang , "Jiri Pirko" , Simon Horman , Julia Lawall , Nicolas Palix , Gal Pressman Subject: [PATCH net-next 4/5] net: sched: Remove newline at the end of a netlink error message Date: Wed, 26 Feb 2025 11:39:03 +0200 Message-ID: <20250226093904.6632-5-gal@nvidia.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20250226093904.6632-1-gal@nvidia.com> References: <20250226093904.6632-1-gal@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F5:EE_|DS7PR12MB9474:EE_ X-MS-Office365-Filtering-Correlation-Id: 55c8975d-c298-40ae-ad88-08dd56497d7f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: MjijYUGJLR86SVx+4tPQjGkac0RUhC8WlwCYswuaTEwP4DXILoonHvf3i0sOgRmh3lHuf3WNdFZdHmkOdor3fgz9dxar7Ck6ZSdZNTiUL27rZshuFGd9yJXGCJ5aLWqwjsZBOgYpexW9gW/7Rdee+FPxesaA4aNQ/ZRMJndID3ekJtIU+Efg3VlL+8Xcl9ljw1Br692SmAiUBXDrV04FJdAg6t6vbVKl7UVD1SXvL83p9luJzTJwC/c2LS/855XHEbsX4VL+cZDscza+He6tefGo3fsoLk/zn3aGDE63R9Nso5WqlUjp9Aw6zQ7gDh8SgZ4cw5waGnAYehPdUuHV6ZqgJgwAGqNxT++drDIneUY2QcNklMN13nbYq/WFjcJLX2qzRGCl4T1+QToxpb16a8S5a/saZJCS1MefQIyGSMrivNt1ApRbM55WSY3J6BSnKdxtLwTglGgUN8D4tbUzZNE/ir0jDglWQTPdCqFeUg0PppwUeLuvr4FsPevfNNkrqBBw+sR7iSbrmaiLYJNAuigNdNoo5fyIUV5IUZNZ5SyNlIT5wqrCTzl64zVXfvFNjzFlJOS9nYn83bL7R3R6wMMgOmrJslhLAp385aSRItxEeN0C/BY25WQNe2hNSTHaC6y3YUvC7ree29YaVYB2Fxr92mC10wkWd7kWSmJ84rGWd8rt8uTiGgYWNBfHgviUdg+1cRFryc0ja7bsr9l5Lr5g858gA7PwjpctkTXlVo76m5j1bqDT/oneD8Plejfkzre7dsM7I30GDVBIODH+LIKDP9UGM/Sm996sDAVig3/jTGcU/iCsAESBOYNNctCfWyRV0mw8Hp20gqhdyeAaQEMmNcRQPkJHdiW5WpZAZpHH9YGSk15GmxCTebCRU6J3M+zjliqaxRavb8cy650pZPcaXDX+b5H7NrD/A5eBldKRTuhblTE2ulDs/fV07eMtMM/KKNO9tkNGRgFT1KY2IW9HVU+LdDbBa2WTJ+KFJTMB7ZiYiZRrq6Ts/i89uGQZC3IBefusGuF/ezR7hNOufZaFJyaGxfGyT6hEmqcZf1Z4FO9StMp3vRy+tkanLASSGfQsVQ00arWODuV2GeqY9I73iyUwn4k4M5h8KyKnCQS7bJZgEdH+Fwts3dbmrQR2fKmPqkbvJxcdDBmTqQIHVXwEx7Rz2zHoWmoMsnwxs9GUj+SDIMtZKk1F4BBKzQN833321wqcbwk9ctbvoGPWtmPXizYtlQ/08VANX2cpPo9qGaFFfszt3Fm53RQmaGG7/FNYWg6jVnMOv1Z5XvAL1JoauoXHs6QgmOhGgEP6aEi7NLJaf5Pc8b3Ps/p2hqoScN1wxUhQECltQwSkCVaKD8gUxtYZy3abk8wKtujinqXMcY6qhbGl2GCqsj+sl9AuoHagzyQHqLqXHsujmTC0Fse+LwmsvgUMm11hSbAhO0db2JpFBwGbWgL0s96yeV5ZGnPqvpNA9baCkT//F5bm8IqnYP9rAS9WGqxlDuvMato= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 09:39:39.3974 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55c8975d-c298-40ae-ad88-08dd56497d7f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9474 X-Patchwork-Delegate: kuba@kernel.org Netlink error messages should not have a newline at the end of the string. Reviewed-by: Tariq Toukan Signed-off-by: Gal Pressman --- net/sched/sch_qfq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c index 6a07cdbdb9e1..2cfbc977fe6d 100644 --- a/net/sched/sch_qfq.c +++ b/net/sched/sch_qfq.c @@ -447,7 +447,7 @@ static int qfq_change_class(struct Qdisc *sch, u32 classid, u32 parentid, if (q->wsum + delta_w > QFQ_MAX_WSUM) { NL_SET_ERR_MSG_FMT_MOD(extack, - "total weight out of range (%d + %u)\n", + "total weight out of range (%d + %u)", delta_w, q->wsum); return -EINVAL; } From patchwork Wed Feb 26 09:39:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gal Pressman X-Patchwork-Id: 13991874 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2046.outbound.protection.outlook.com [40.107.220.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDEFE2459CA for ; Wed, 26 Feb 2025 09:39:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740562791; cv=fail; b=ccIZurekpYz81BGdgqOaWsLjK/r4fcyfzHAxo/cLT2WG42+lWn8bDhHtX9GBzilYtm89WX/NwsUj01xFAKN3KlYwNtBqI5o2MpuOFuNhSWDcczCDozD+Im91sOBSfgWsDzGQEuXEQYNqiKjqj2o7AfriOoOTvzEui/jJ0yjn1VE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740562791; c=relaxed/simple; bh=2YZ5mXyRbfXm5w5dF3nagO6ys6LYgjlsJUtumFMPZxk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Leo5RNeBxXe/mEAPCa23RBS58QXNlIfQdRXkOBbU+hffB/ZRwiVXRzwq/An0XBnuS7mpG+GDnSpRHdsnfY/QxGEkP1ah/F7oNsIo4CO5dwnz2GmMrRa0ivKYsB6P4BP+zQtTAIhNzH4FB2fYgk82WC9DNVyXaQ/IvEOiEncBW74= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=FUwQm791; arc=fail smtp.client-ip=40.107.220.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="FUwQm791" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I1Swdq4jsqA6z9KWg35viNtWGHnRQu5Jd2c/Ds7K96nwyjmLtx45loAFw/h3GaoHdAszsgeyw2b5kxPSs5WzlLgpFobKCxScOg+3x9Nr22p4eUuZkx9DghTvJx+DwmbFPsOSuDPoA1tknB9E94pLPNoV33vfyE7osEDCDJFjfEnXCNmgWQqPIxyP8dBgD8f7jYZNLBJdgGlL/Tdo40FxNVLuGIZ+cHJ7l5wtZpf9aSAXNwGV65eBUeosWzjNgL1o7gXNGE4Z8h1zxN/U1D3eOx65CPBSfQUEwxrMVdsk5imbMnX0lb3EFpeEH6E54lu2zXHxWSRqxvBA4UYP42PPvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UxecmR697fsmiXP7i1obhupNZo8zOUA2AsxlRmfPHHo=; b=kw3ZABESsZ+Ad0sJORo6HfPOHqLL9toAcKlW7fVYGlreqWq89XcjfH/AqGZQUmaTQmOE9RcQwXKyO3xFXE0FEnUMOkzKPTYdI1K/YMxv7j3LQfcgB6gjf5X0pt0PaZce9C7dh0eUxnz2jP1tdoS46QO4htabw+/zKi/oXmq3YaduSA+q4RRLihj59rCax3r+tXklqyvccNsaQKy4gFiD3LFD1qBBiK1mAaPPs3hARHUeRKaXLZFoBevCEC8NXflD7Yn8gUL2yrPMjJU+H1Ye8qz88z6nuSfsT+irXvo4ruRWLOR6+C6+fwbd6ohK5aBMG7PNoHn25aIwjeEl4E424A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UxecmR697fsmiXP7i1obhupNZo8zOUA2AsxlRmfPHHo=; b=FUwQm791Ygk3ny3UIn//71fD191Qt3RhfrEOZBk5GS5i/LzEt0uJbRYu7MWPY6Jgl15yiryMHnnAiinLrOnrtQtRiib1c+6pgSGp6bPC/AoQdFgxNfVx0ZDsarvaVxRjnpLvri+kOPJgnnWGQx0PaZIR19jAihUFrTSzrc7wEi9xZ1NzD7GmjSlI9vR1CH0nOR1QFqhFzymbKUEDzqDKz5Iljy7/1LTkrhSR3Jsu4OZUPoE5tlSdwkheYePo31KKH9DIhHaboDTBDtSxTgyLFH3HPiHFQ6AuyISgcXaJwV2T0VqrPc9ZlMdzFwQ2/4eO5cqaOAKoGHLTYPG6MCKc5g== Received: from BL0PR05CA0001.namprd05.prod.outlook.com (2603:10b6:208:91::11) by SJ2PR12MB8009.namprd12.prod.outlook.com (2603:10b6:a03:4c7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.15; Wed, 26 Feb 2025 09:39:46 +0000 Received: from BL6PEPF0002256E.namprd02.prod.outlook.com (2603:10b6:208:91:cafe::ac) by BL0PR05CA0001.outlook.office365.com (2603:10b6:208:91::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Wed, 26 Feb 2025 09:39:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF0002256E.mail.protection.outlook.com (10.167.249.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Wed, 26 Feb 2025 09:39:45 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Feb 2025 01:39:34 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 01:39:34 -0800 Received: from vdi.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 01:39:30 -0800 From: Gal Pressman To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , CC: Tony Nguyen , Przemek Kitszel , Tariq Toukan , Edward Cree , Martin Habets , "Jamal Hadi Salim" , Cong Wang , "Jiri Pirko" , Simon Horman , Julia Lawall , Nicolas Palix , Gal Pressman Subject: [PATCH net-next 5/5] ice: dpll: Remove newline at the end of a netlink error message Date: Wed, 26 Feb 2025 11:39:04 +0200 Message-ID: <20250226093904.6632-6-gal@nvidia.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20250226093904.6632-1-gal@nvidia.com> References: <20250226093904.6632-1-gal@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256E:EE_|SJ2PR12MB8009:EE_ X-MS-Office365-Filtering-Correlation-Id: 5fc45947-fda5-4a93-5573-08dd5649811b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024|7416014; X-Microsoft-Antispam-Message-Info: rxeSYhn0D9/pYWLaACiGormjIt10Mxez2n62/RwkShZImdFZhTkhDxjSNflKJUHJYtMOQfuesj8pwqyumylqC51IE68wGJwOfM0OjcNKPUP78Gc1xwUdhuQ/wcwF5mWfUNe5ELTwfT0uVAJJQjO2EP0Evu7RlEJR2VJ6bUu5WzdBqFx+jrEDb+JbodxES+evKInBqqoCeRfPRhdHGi2qKD1lAIMNuVqp9QdCTHQSUZpWyxk+Y1nkPxiyTrulwBHwRSPxOTC1g1+7g8isjGI0qiD7WeVNsQ8RDlnUTgTmguHYUiNr0Ty+6HZ8DqnQQTZc6r05/H3jPcMU5XHXrwjFhDgTWDRp0yuajLaoGsP5GgsR2pH1+KfCcs7fFiBTcQ597CRx+vKnRMe2Kj8AVB1mCr852UhII1fH2VI62J40xrrfjxKtoAgYtuKGBxhCMe4YMcWL5CZkviGVIJ1XF5SoI+21327BAzt/rm2KchEutfp/L1NcgVgPxDDUFeyNarRWl6Oq+eg/XJvWl1BHKWHGpv1DOwHBlWPu0K4zHqWarQz3LDUyUPcjTJZ544FL1uNiMKoNMSZz/jhG473tS0Nx0Q/XN5c+7mwXdwAHd4LxNwpGIykGnTg5yBYv5hiARdvnZqa4sfnmryc7N/YLfJWTmtTOHj4C/tq6lY0LWKpwzwHFJPz1vhGGN+V9tElzjMk0PJbrK/sGovntbZRpqdI4wZ435PThlyEnxpZSz1tetriR/yE8z4mpYB9COxMd7rQtfdiyf4AUt6SYIqluRQI8vMa444nx7BwD+gJK/Qc/T1tpGMU/mS2kND3YoF9CbO5L5g8wk8mIbs2pFVJySWuakMe+2QMsQy6aoh48gMJoEn+dIp3Yi7udNR/kf9lohuVjkKpdPN3jbQIisUuSPgFi9RQLlDLav/5PFIAq3tKmcLr7PumcgRf0Ia+RbeIIGTAdbvWiBFGKhHKm/i+4Hd3dITwamJAZlgQ5w3u0wcMztquHk57Ddx/vDTQdphzxaP3qlkmCciXgbs3Hh6WS81Y48EOF99S28IX/R6IY5iAspQ9Yci/O3bwtkT9mzbm8LmX+PfzHz3euGuSKTIr5KeJTZvl6GD6hNr0htE6NxQF44awDEQ4MTEHUEy0HGxe/kIcZizjKKm1K4nglNxIvvGsflaMd1BIPlxk6SppgSPdeMefDsMzWjfjYwWBey+XXlGUmTjvLFN6aL2ZUa/fvr88JuqoIQ4gSkUiaA+sEkIjOg+xt9jfRcaY/ThCO3dF6+JKBu/atGXHKO4XNhWl8DCQDa4mkhLGZ+/LJY2wRK7Am1X19DLC1mUyD3NqWeQuy2jMcFbVGV86tJDrWf09lnR/sTAlwZyt3sptJEycNVfvpwIAry7308F4mCkqVXbxKxXXTN5jIuzlHj6Gak8GkaOAqj/VhIb5sgs2dzcLHpQkwit3MBer0Ehu/YqwZt1E+o1byVg9dusFtuaz4q9qn9pUIro1ep0mfp92tBSCqsYp9Czo= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 09:39:45.2788 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5fc45947-fda5-4a93-5573-08dd5649811b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8009 X-Patchwork-Delegate: kuba@kernel.org Netlink error messages should not have a newline at the end of the string. Reviewed-by: Tariq Toukan Signed-off-by: Gal Pressman Acked-by: Przemek Kitszel --- drivers/net/ethernet/intel/ice/ice_dpll.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c index 8d806d8ad761..bce3ad6ca2a6 100644 --- a/drivers/net/ethernet/intel/ice/ice_dpll.c +++ b/drivers/net/ethernet/intel/ice/ice_dpll.c @@ -95,7 +95,7 @@ ice_dpll_pin_freq_set(struct ice_pf *pf, struct ice_dpll_pin *pin, } if (ret) { NL_SET_ERR_MSG_FMT(extack, - "err:%d %s failed to set pin freq:%u on pin:%u\n", + "err:%d %s failed to set pin freq:%u on pin:%u", ret, ice_aq_str(pf->hw.adminq.sq_last_status), freq, pin->idx); @@ -322,7 +322,7 @@ ice_dpll_pin_enable(struct ice_hw *hw, struct ice_dpll_pin *pin, } if (ret) NL_SET_ERR_MSG_FMT(extack, - "err:%d %s failed to enable %s pin:%u\n", + "err:%d %s failed to enable %s pin:%u", ret, ice_aq_str(hw->adminq.sq_last_status), pin_type_name[pin_type], pin->idx); @@ -367,7 +367,7 @@ ice_dpll_pin_disable(struct ice_hw *hw, struct ice_dpll_pin *pin, } if (ret) NL_SET_ERR_MSG_FMT(extack, - "err:%d %s failed to disable %s pin:%u\n", + "err:%d %s failed to disable %s pin:%u", ret, ice_aq_str(hw->adminq.sq_last_status), pin_type_name[pin_type], pin->idx); @@ -479,7 +479,7 @@ ice_dpll_pin_state_update(struct ice_pf *pf, struct ice_dpll_pin *pin, err: if (extack) NL_SET_ERR_MSG_FMT(extack, - "err:%d %s failed to update %s pin:%u\n", + "err:%d %s failed to update %s pin:%u", ret, ice_aq_str(pf->hw.adminq.sq_last_status), pin_type_name[pin_type], pin->idx); @@ -518,7 +518,7 @@ ice_dpll_hw_input_prio_set(struct ice_pf *pf, struct ice_dpll *dpll, (u8)prio); if (ret) NL_SET_ERR_MSG_FMT(extack, - "err:%d %s failed to set pin prio:%u on pin:%u\n", + "err:%d %s failed to set pin prio:%u on pin:%u", ret, ice_aq_str(pf->hw.adminq.sq_last_status), prio, pin->idx); @@ -1004,7 +1004,7 @@ ice_dpll_pin_phase_adjust_set(const struct dpll_pin *pin, void *pin_priv, mutex_unlock(&pf->dplls.lock); if (ret) NL_SET_ERR_MSG_FMT(extack, - "err:%d %s failed to set pin phase_adjust:%d for pin:%u on dpll:%u\n", + "err:%d %s failed to set pin phase_adjust:%d for pin:%u on dpll:%u", ret, ice_aq_str(pf->hw.adminq.sq_last_status), phase_adjust, p->idx, d->dpll_idx); @@ -1362,7 +1362,7 @@ ice_dpll_rclk_state_on_pin_set(const struct dpll_pin *pin, void *pin_priv, &p->freq); if (ret) NL_SET_ERR_MSG_FMT(extack, - "err:%d %s failed to set pin state:%u for pin:%u on parent:%u\n", + "err:%d %s failed to set pin state:%u for pin:%u on parent:%u", ret, ice_aq_str(pf->hw.adminq.sq_last_status), state, p->idx, parent->idx);