From patchwork Wed Feb 26 11:20:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anuj Gupta X-Patchwork-Id: 13992101 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C157214A96 for ; Wed, 26 Feb 2025 11:35:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.34 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740569748; cv=none; b=UOXASIu35Nd4hb16Ao5IHx8d2HRQ2a+uwbOfNihChCGVJNUe40zDtwvi4FA7u4AXURJl6D/9YtQEMmJe8lrgbQs6j3b5yvbU0uMgyEjcuNRzTrtzdNaVULt9fOXUxMJwu+80x8uG21Kbrk9bCBKRYx/i5Sw8mYWoPoT/8fX4jQM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740569748; c=relaxed/simple; bh=hC/0H+XPSDfmqpmp9/y2/J88WF/Us5XWrjHxl/QyHg4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=G5SJiBZlNdLmhA4Ze8Dg/9nkcmsJRBntkniUKthE84E6pCUq8pBaJoyJIhz6xUxncmRRezmHen/7UDWistg/Moboe9Q9DqKBdCHs2oa7Ng6B8qVk7w1eBRNPPFtpX9ocLO3oxl3Umhi8ioY4UUrZGCUXq4jn3GBGwi2+9jxE9/E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=CxNE4A4A; arc=none smtp.client-ip=203.254.224.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="CxNE4A4A" Received: from epcas5p2.samsung.com (unknown [182.195.41.40]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20250226112927epoutp04f25c94f0de4c24f76507f789d6ea60d1~nvp4yjuOi3115431154epoutp04d for ; Wed, 26 Feb 2025 11:29:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20250226112927epoutp04f25c94f0de4c24f76507f789d6ea60d1~nvp4yjuOi3115431154epoutp04d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1740569367; bh=5vbI71yMujXYkEGW8ngeGEGRX6ABcmrOjyoSmpUJRr8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CxNE4A4AbWUqx7fZ5ADxF8TGOhv0yjk8TjPU6AIB9u276UbsLzJvHAW1EjJKK84w3 eWDaHXb88YmTIyLmrSD1l+pYVne/xRzFiVBrKB2Wajv2M4c8k+qVq+aJyxCZ/8TNuc MO0g+hqn+bT3T8Vv+FVGUd+ig2wh/ctpYxoVdSqw= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas5p1.samsung.com (KnoxPortal) with ESMTP id 20250226112924epcas5p1d17df23d087611e70d97ed813c5773be~nvp1sxt_i2155121551epcas5p14; Wed, 26 Feb 2025 11:29:24 +0000 (GMT) Received: from epsmges5p3new.samsung.com (unknown [182.195.38.183]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4Z2sgk49zyz4x9Q1; Wed, 26 Feb 2025 11:29:22 +0000 (GMT) Received: from epcas5p2.samsung.com ( [182.195.41.40]) by epsmges5p3new.samsung.com (Symantec Messaging Gateway) with SMTP id 1E.E8.19956.21BFEB76; Wed, 26 Feb 2025 20:29:22 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas5p1.samsung.com (KnoxPortal) with ESMTPA id 20250226112857epcas5p1654e62b5fff4551926622f19269c6ff4~nvpcXpYku0435004350epcas5p1d; Wed, 26 Feb 2025 11:28:57 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20250226112857epsmtrp2791aed2b8ed4aaff9f58ff0f891162c4~nvpcW06o30959209592epsmtrp2W; Wed, 26 Feb 2025 11:28:57 +0000 (GMT) X-AuditID: b6c32a4b-fe9f470000004df4-33-67befb126755 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id AE.60.18949.8FAFEB76; Wed, 26 Feb 2025 20:28:57 +0900 (KST) Received: from localhost.localdomain (unknown [107.99.41.245]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250226112855epsmtip26ae1a3ed89ddfba8811322b56fea514d~nvparzCXT1116211162epsmtip2a; Wed, 26 Feb 2025 11:28:55 +0000 (GMT) From: Anuj Gupta To: axboe@kernel.dk, hch@lst.de, martin.petersen@oracle.com Cc: anuj1072538@gmail.com, nikh1092@linux.ibm.com, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, dm-devel@lists.linux.dev, Anuj Gupta , M Nikhil Subject: [PATCH v2 1/2] block: ensure correct integrity capability propagation in stacked devices Date: Wed, 26 Feb 2025 16:50:34 +0530 Message-Id: <20250226112035.2571-2-anuj20.g@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250226112035.2571-1-anuj20.g@samsung.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMJsWRmVeSWpSXmKPExsWy7bCmhq7Q733pBq+WKFh8/PqbxaJpwl9m i9V3+9ksFiyay2KxcvVRJou9t7Qt5i97ym7RfX0Hm8Xy4/+YLO5efMpssbP9GKMDt8fOWXfZ PS6fLfWYsOgAo8fmJfUeLzbPZPTYfbOBzePj01ssHn1bVjF6fN4kF8AZlW2TkZqYklqkkJqX nJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA3SrkkJZYk4pUCggsbhYSd/O pii/tCRVISO/uMRWKbUgJafApECvODG3uDQvXS8vtcTK0MDAyBSoMCE749qdz2wFl7kqZjzu YWlgbOXsYuTkkBAwkbi7eBdTFyMXh5DAbkaJHb93MIEkhAQ+MUo0LROBSHxjlLjQ380G03F4 128WiMReRolVT05AOZ8ZJe5sOwfWziagLnHkeStjFyMHh4iAtcT71+IgNcwC7xklXvd3gU0S FkiW2L50LRNIDYuAqsTJ1c4gYV4BC4ntkxqglslLzLz0nR3E5hSwlOhYuIIRokZQ4uTMJywg NjNQTfPW2cwg8yUEFnJIzH98gBmi2UVi+9T1LBC2sMSr41vYIWwpic/v9kItSJf4cfkpE4Rd INF8bB8jhG0v0XqqnxnkNmYBTYn1u/QhwrISU0+tY4LYyyfR+/sJVCuvxI55MLaSRPvKOVC2 hMTecw1QtofEk1mnWCCh28MoMXG73gRGhVlI3pmF5J1ZCJsXMDKvYpRMLSjOTU8tNi0wzkst h8dxcn7uJkZw6tXy3sH46MEHvUOMTByMhxglOJiVRHg5M/ekC/GmJFZWpRblxxeV5qQWH2I0 BQb3RGYp0eR8YPLPK4k3NLE0MDEzMzOxNDYzVBLnbd7Zki4kkJ5YkpqdmlqQWgTTx8TBKdXA xM5/IMppcn3D3zcd/00X9By49sjT5qzdhMLCCruCBStl/13YNPfaRAuuBSFpH4VMc+Z9v7t7 ksQRvlD3m3Vz5+y50fRPXofBbnJvfFF7150tjZ31+Xvf1i4RMAycExhz+MjstMDs2bN3H8mx bwhjYmmVSppzxauMQTQr3F777PWYv+0ei1mmv4/XNKiriwvTPhooxTxJLF3AK/KxoE6GmsCF ndu8WzWFVKL9WuM8Y7JNvj6pYnm3euYp/yrOwz2VE87+rPy13i+vQtojjctptSVbjUtH0ZHE L1/kKs9VqJ+Y4BDLm9Uqejoo6CiHx7/GWIUj/5uNJ8mKbDZPfDhzYlpoiCl/3efaDz/i8pVY ijMSDbWYi4oTASZKnehGBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFLMWRmVeSWpSXmKPExsWy7bCSvO7PX/vSDZo6mCw+fv3NYtE04S+z xeq7/WwWCxbNZbFYufook8XeW9oW85c9Zbfovr6DzWL58X9MFncvPmW22Nl+jNGB22PnrLvs HpfPlnpMWHSA0WPzknqPF5tnMnrsvtnA5vHx6S0Wj74tqxg9Pm+SC+CM4rJJSc3JLEst0rdL 4Mq4duczW8FlrooZj3tYGhhbObsYOTkkBEwkDu/6zdLFyMUhJLCbUaL54xRGiISExKmXy6Bs YYmV/56zg9hCAh8ZJWZsDgax2QTUJY48bwWq4eAQEbCXuPejAmQOs8B3RokTLdfZQGqEBRIl NuxsYgGpYRFQlTi52hkkzCtgIbF9UgMbxHh5iZmXvoON5xSwlOhYuIIRYpWFxM49W5gg6gUl Ts58wgJiMwPVN2+dzTyBUWAWktQsJKkFjEyrGCVTC4pz03OLDQuM8lLL9YoTc4tL89L1kvNz NzGCo0NLawfjnlUf9A4xMnEwHmKU4GBWEuHlzNyTLsSbklhZlVqUH19UmpNafIhRmoNFSZz3 2+veFCGB9MSS1OzU1ILUIpgsEwenVANTvlrxnQPqmow8/grWvs8UWqSLVrR4TrnwYK10x9Xp CQ+2qZXPPWr2TUMq5mhC7S7RD5ffGjCalV8xW1NikG9gcKv8e0/4kvUJrzIajhTH/cy5fMJ4 7etqTx+vf1mZaz35PWWNF60NydmczZ4vP2O1anRoyHe2fWZn/ywufpW5T/hk+p21fvcL3+5f pZmbd8G/bq7NsaJZG37Jp0qV8JU/vyriKhB0SOPuFJfEGO0HP/ZufzllcXjT4et6B00e7hBw te8M8ihbE2n7/s5XQe7Q71JB9qGzth/faSztdUHQQcDX3opXglnh+r134s9SeDjc7Xo/rPhi KMIjNS9ccMvF9xdnpec2O2xyCvc+s0CJpTgj0VCLuag4EQB3vle1/QIAAA== X-CMS-MailID: 20250226112857epcas5p1654e62b5fff4551926622f19269c6ff4 X-Msg-Generator: CA X-Sendblock-Type: REQ_APPROVE CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250226112857epcas5p1654e62b5fff4551926622f19269c6ff4 References: <20250226112035.2571-1-anuj20.g@samsung.com> queue_limits_stack_integrity() incorrectly sets BLK_INTEGRITY_DEVICE_CAPABLE for a DM device even when none of its underlying devices support integrity. This happens because the flag is inherited from the first base device, even if it lacks integrity support. This patch ensures that BLK_INTEGRITY_DEVICE_CAPABLE is only inherited if the first device actually supports integrity. Reported-by: M Nikhil Link: https://lore.kernel.org/linux-block/f6130475-3ccd-45d2-abde-3ccceada0f0a@linux.ibm.com/ Fixes: c6e56cf6b2e7 ("block: move integrity information into queue_limits") Signed-off-by: Anuj Gupta --- block/blk-settings.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/blk-settings.c b/block/blk-settings.c index c44dadc35e1e..8bd0d0f1479c 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c @@ -861,7 +861,8 @@ bool queue_limits_stack_integrity(struct queue_limits *t, if (!ti->tuple_size) { /* inherit the settings from the first underlying device */ - if (!(ti->flags & BLK_INTEGRITY_STACKED)) { + if (!(ti->flags & BLK_INTEGRITY_STACKED) && + (bi->flags & BLK_INTEGRITY_DEVICE_CAPABLE)) { ti->flags = BLK_INTEGRITY_DEVICE_CAPABLE | (bi->flags & BLK_INTEGRITY_REF_TAG); ti->csum_type = bi->csum_type; From patchwork Wed Feb 26 11:20:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anuj Gupta X-Patchwork-Id: 13992088 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA11721517C for ; Wed, 26 Feb 2025 11:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740569372; cv=none; b=UgidmYXRySfRtus6ayXyiWWNPs8gB4KpFu7SQArBbEvSrI/PlukQw1NkkPyTo9Blh3M6ZLukKpB/Jq5iLLQEdeAMNL2A5eR10piqpllwB9x/MH0zqme+AWTUPPOGfCnpsSv52jZPqKEfOTP0Xg+dFF/6Sq0eZUEHWeRhthHieDk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740569372; c=relaxed/simple; bh=OO22PG7Gvf9nzlzRb8I9FCyuwmfc+9U3YUKWUC6LDkM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=hPoJWMzJGjR3O8TLcIKPYI0Rjt+aNZa+06FmAfpB1ZEy08NzYnfHwT/hb+7+zr/ZBVZr+Cw7OEhBZKB77CNV7HceNYK8U32WBYuLKCsxllpiHoZ4UHIUTZ3dNo0z6JM/HQRUm937uW0hW36nMbVRv4caSBAp1kr/zdpyHxbwaTY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=GaVvvIbm; arc=none smtp.client-ip=203.254.224.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="GaVvvIbm" Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20250226112927epoutp030371cfdde19698d760dd3034e7ca79b0~nvp4_-Xzi0116901169epoutp03f for ; Wed, 26 Feb 2025 11:29:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20250226112927epoutp030371cfdde19698d760dd3034e7ca79b0~nvp4_-Xzi0116901169epoutp03f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1740569367; bh=mqgBPc87/veZwgYQ39rtpd2Wha3wUtr/2HbfNGY2nfg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GaVvvIbmGUbAH4niVnY4UHZ4xEEQALsRPQV9LYmD6bHDwqm66vSaxg0R031cI9+E4 d8H08xtWIdqG30GqCcY+ol+5EXDXHCFugGp+5rGK4KPvxhXbDqBNRnDOwQ+1tuTmD8 A5jPixvDhs9oV1vX6ekQisb1fxRZr7wibalQN86A= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas5p2.samsung.com (KnoxPortal) with ESMTP id 20250226112927epcas5p2cb70d4a075b7c2c496490ff391976efb~nvp4YM6Yf2550425504epcas5p2N; Wed, 26 Feb 2025 11:29:27 +0000 (GMT) Received: from epsmges5p2new.samsung.com (unknown [182.195.38.183]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4Z2sgn2ByTz4x9Pw; Wed, 26 Feb 2025 11:29:25 +0000 (GMT) Received: from epcas5p1.samsung.com ( [182.195.41.39]) by epsmges5p2new.samsung.com (Symantec Messaging Gateway) with SMTP id E0.27.19933.51BFEB76; Wed, 26 Feb 2025 20:29:25 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas5p2.samsung.com (KnoxPortal) with ESMTPA id 20250226112859epcas5p2b97647182f58b4c6514326cf497e3fdb~nvpeGCpGc0272102721epcas5p25; Wed, 26 Feb 2025 11:28:58 +0000 (GMT) Received: from epsmgmc1p1new.samsung.com (unknown [182.195.42.40]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20250226112858epsmtrp2f9555b3484131139f2b8cddbb06de9c3~nvpeFS6Td0959209592epsmtrp2Y; Wed, 26 Feb 2025 11:28:58 +0000 (GMT) X-AuditID: b6c32a4a-b87c770000004ddd-96-67befb15147b Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgmc1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id A0.C9.23488.AFAFEB76; Wed, 26 Feb 2025 20:28:58 +0900 (KST) Received: from localhost.localdomain (unknown [107.99.41.245]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250226112857epsmtip2b993069096e73abbc96687892d393a4a~nvpccxNis0945909459epsmtip2A; Wed, 26 Feb 2025 11:28:57 +0000 (GMT) From: Anuj Gupta To: axboe@kernel.dk, hch@lst.de, martin.petersen@oracle.com Cc: anuj1072538@gmail.com, nikh1092@linux.ibm.com, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, dm-devel@lists.linux.dev, Anuj Gupta , M Nikhil Subject: [PATCH v2 2/2] block: Correctly initialize BLK_INTEGRITY_NOGENERATE and BLK_INTEGRITY_NOVERIFY Date: Wed, 26 Feb 2025 16:50:35 +0530 Message-Id: <20250226112035.2571-3-anuj20.g@samsung.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250226112035.2571-1-anuj20.g@samsung.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEJsWRmVeSWpSXmKPExsWy7bCmuq7o733pBueW8lh8/PqbxaJpwl9m i9V3+9ksFiyay2KxcvVRJou9t7Qt5i97ym7RfX0Hm8Xy4/+YLO5efMpssbP9GKMDt8fOWXfZ PS6fLfWYsOgAo8fmJfUeLzbPZPTYfbOBzePj01ssHn1bVjF6fN4kF8AZlW2TkZqYklqkkJqX nJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA3SrkkJZYk4pUCggsbhYSd/O pii/tCRVISO/uMRWKbUgJafApECvODG3uDQvXS8vtcTK0MDAyBSoMCE748N+lYKTHBVHjp5l a2Bcyd7FyMkhIWAi0dQ0i7GLkYtDSGA3o0Rn7ylmCOcTo8TMiz9YQaqEBL4xSqztr4HpOPrq DBtE0V5GiWsTn0A5nxklHsw6yQJSxSagLnHkeSvQXA4OEQFrifevxUFqmAXeM0q87u9iA4kL C2RKzGo2BSlnEVCVaJrzDOwkXgELiebGc1DnyUvMvPQdzOYUsJToWLiCEaJGUOLkzCdgq5iB apq3zga7WkJgIYfEnf/PWUDmSwi4SLyeJwExR1ji1fEtUDOlJD6/28sGYadL/Lj8lAnCLpBo PraPEcK2l2g91c8MMoZZQFNi/S59iLCsxNRT65gg1vJJ9P5+AtXKK7FjHoytJNG+cg6ULSGx 91wDlO0hcfrqIVZIUPUwStxrOMM4gVFhFpJ3ZiF5ZxbC6gWMzKsYJVMLinPTU4tNC4zyUsvh UZycn7uJEZx4tbx2MD588EHvECMTB+MhRgkOZiURXs7MPelCvCmJlVWpRfnxRaU5qcWHGE2B 4T2RWUo0OR+Y+vNK4g1NLA1MzMzMTCyNzQyVxHmbd7akCwmkJ5akZqemFqQWwfQxcXBKNTD1 Ldne9J89bOaT99eP/OjT8Epv3/HnU2C2muVbz2chdqt+/lurHvrXU2GfmkLKs/M7w9drMyTW O5z1EWT6IuX8zWNGcgVbuyP330+L5h1xOF/Fp72c4XTM9XUel4SemR06t+3SzylK7EwnF92p nj67oCd644bi6n1mW1cr7PTafDTZZSnjX7H3CmXy8+/bX196TmHWrtJ0s4DtZ9cy7UzgtqwI WfHwmKqEWe6u2dlaCds235R5cOer+BOdXpsdjVZKFi1PtEIYlaz+p20+9HfO1hTNpVezQhoT vrT7uh03Vmj5yzvh7bWL7QsDzheFibJPi7j/jjXFu3QHc5cw70cTiQmp2copa18t7tbSfGio xFKckWioxVxUnAgAkgwUuEUEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRmVeSWpSXmKPExsWy7bCSvO6vX/vSDZY8NrT4+PU3i0XThL/M Fqvv9rNZLFg0l8Vi5eqjTBZ7b2lbzF/2lN2i+/oONovlx/8xWdy9+JTZYmf7MUYHbo+ds+6y e1w+W+oxYdEBRo/NS+o9Xmyeyeix+2YDm8fHp7dYPPq2rGL0+LxJLoAzissmJTUnsyy1SN8u gSvjw36VgpMcFUeOnmVrYFzJ3sXIySEhYCJx9NUZti5GLg4hgd2MEn8mTmSGSEhInHq5jBHC FpZY+e85O0TRR0aJmwuvsoIk2ATUJY48bwUq4uAQEbCXuPejAqSGWeA7o8SJlutsIDXCAukS l46cYQKxWQRUJZrmPAPbzCtgIdHceA7qCnmJmZe+g9mcApYSHQtXgC0WAqrZuWcLE0S9oMTJ mU9YQGxmoPrmrbOZJzAKzEKSmoUktYCRaRWjZGpBcW56brJhgWFearlecWJucWleul5yfu4m RnB8aGnsYHz3rUn/ECMTB+MhRgkOZiURXs7MPelCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeVca RqQLCaQnlqRmp6YWpBbBZJk4OKUamBLeN0Y/+rCrme9AgdPOorru4GUvDV6E9slxqxz50XSZ 98Tz7x++bMhhXbHoH6NkKY/CGVMnp7yn/x6uDZT22Gq0WfHuw80Tzp5Ju2k8V2vP762tMyJY NJJjlvdYPX7qtnfV7tvMnskcFmu3tB+ff/dcv5PkxZo/JXpCM+yVfQ86dIa86jmm4LXbMJqr 8N7MFV/vd/uWiG65HWzUOEH8QIqg5JpMiQUcMX+61i5gUVc2Liq+ODVvA/8mCVnTvasVJFe1 rLx8cM1sq1xr0ebly77K9HzTP33j9eyoctPDb5xWLH2n8K5835pZnHaHUjyi20rsKosubH34 UkXmw0+JN0yBT1QVmxOr4sOZd76TPKTEUpyRaKjFXFScCAC4uFMB/gIAAA== X-CMS-MailID: 20250226112859epcas5p2b97647182f58b4c6514326cf497e3fdb X-Msg-Generator: CA X-Sendblock-Type: REQ_APPROVE CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250226112859epcas5p2b97647182f58b4c6514326cf497e3fdb References: <20250226112035.2571-1-anuj20.g@samsung.com> Currently, BLK_INTEGRITY_NOGENERATE and BLK_INTEGRITY_NOVERIFY are not explicitly set during integrity initialization. This can lead to incorrect reporting of read_verify and write_generate sysfs values, particularly when a device does not support integrity. This patch ensures that these flags are correctly initialized by default. Reported-by: M Nikhil Link: https://lore.kernel.org/linux-block/f6130475-3ccd-45d2-abde-3ccceada0f0a@linux.ibm.com/ Fixes: 9f4aa46f2a74 ("block: invert the BLK_INTEGRITY_{GENERATE,VERIFY} flags") Signed-off-by: Anuj Gupta --- block/blk-settings.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blk-settings.c b/block/blk-settings.c index 8bd0d0f1479c..bee4007b2eeb 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c @@ -114,6 +114,7 @@ static int blk_validate_integrity_limits(struct queue_limits *lim) pr_warn("invalid PI settings.\n"); return -EINVAL; } + bi->flags |= BLK_INTEGRITY_NOGENERATE | BLK_INTEGRITY_NOVERIFY; return 0; }