From patchwork Wed Feb 26 12:25:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tariq Toukan X-Patchwork-Id: 13992265 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2045.outbound.protection.outlook.com [40.107.243.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B499C214817; Wed, 26 Feb 2025 12:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740572816; cv=fail; b=DvME0GAGOuYAMN2i3AadEIyfgrp83PCg1nnRIjPt6msHiEV8hp5U+xmFPpxtXvCmlppS6sH2/pg12sRcSbxVsuvSMlXgQCRGSZbESzEYsy2ANeDdIYcB6LwgI92zJA9UQSsZZXN9Ymnr6g0Lv4TqUlEFs8qKognlNQ9SNYHRPIY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740572816; c=relaxed/simple; bh=td9+L8B3Cl22co7LlEXwp5GN1HwdvLP3hU+LsvOfSEU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WaduveS2bn59ycJn9X7p4t8AiFEbUPRAU43niC88SnXDTcSE5f9CxZAzJlo00FZcOcjzMJ9uDTtEInTsFQR4fY8qmTGD9DVQdh1I8hxPbV39o9LbH09QSBXdSjkk1PRBk3WC9BpZG+EJsTZLm6rBoDKr6ueXTHYor/DSjeJnnQM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=HBGbK0Fw; arc=fail smtp.client-ip=40.107.243.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="HBGbK0Fw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YDuVkpAkn8uFdbN+5uRsO8As2y60XIooWb0LbwkDrN8lkckWtiYyu2UH5UoJfXXaBJgm4jw6/0yE418OJGuWTtSpyv4qRnYT27+1J1SVNTSSDPfV7gDOhbnkfTgtDuanGf9zXeOCTxFOnE41fLejGRy1DJCWML456qzEdx2/eStRx1htaqIWs5wpdqnDYIhECZAHDhHR3oh+FuHghaQ77Q9a2n/dIq+gC6PKwRncFdOM6EFGHAC07vsAqKK34i/5QWt07XfSDEPuBmIJ3pJ3qsQ0Bvqb5BhiYMq7jRxWWO6dSIigqTy+VtNn/XiRj8p53EJINzHYz5tRIBq0CMCrYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nSIhId/IHwWIv7HDVtZDmmQzYDlsG3OwKH8K0rj80p4=; b=mx2lSrvUh2/I4Wr6owJonl799ku7+a4UmDg0yOzLP4H4r0aHt772Y7pzYh3JbVvvlIAKkeAkHEB4mI6nmp0IHzYDW/QRPxaYksqQkCGIJXkGa2vEXximnCSQbU3m8grIc9pwk8Pooz3Zv6UIPih9R+1qmQDlmf+kErHGpQebYHsUZ+UnF/e+wEO1U3G1H2UbmcNyyJCmIssyW9/BPANY5DcOCrNlkXGL76DWyQVtgMvHK10zRKuLp7YwA3cpALJoBfjgSs9eCVcs0+aZ5nH2DvGMdXMWva5NwKCiKEiAErC7dcKS+muDlvKx/3dq4HRb1Ww3NtaxXw55UFRBHe9aVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nSIhId/IHwWIv7HDVtZDmmQzYDlsG3OwKH8K0rj80p4=; b=HBGbK0Fw1qFL6fHtP2U16d4pvkpdAGLddThwv+QYNhvkIu2ap8/Nq9ttB8k8GkEC6HK+eJZCWZyw0vjujq4Fg4STULksC/5JjOvbIo301JFGQwYuFsKNJA+gmrF0hsGHWn71bo3/hkDzRMNfnPEjsDovhBM3AhWdUL9NATyVOiNH9h7kxA2oUBRU0qaJKK0+TzY74b7j7xhLuK2NRK/wQu1TCzBo833OLGMlpiOAOxhwpFq7eczq8j6OdY/ZZS201o1+nSNsNfjA5lfr+a3ZrvRl6SevZagqALdMCKyj6aNIqSxAXNujdRRxvFqj1MrnUoeTdzWJFibNEIw6g5+58g== Received: from BY3PR03CA0015.namprd03.prod.outlook.com (2603:10b6:a03:39a::20) by SJ2PR12MB9008.namprd12.prod.outlook.com (2603:10b6:a03:543::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.21; Wed, 26 Feb 2025 12:26:47 +0000 Received: from SJ1PEPF00002311.namprd03.prod.outlook.com (2603:10b6:a03:39a:cafe::b2) by BY3PR03CA0015.outlook.office365.com (2603:10b6:a03:39a::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.20 via Frontend Transport; Wed, 26 Feb 2025 12:26:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by SJ1PEPF00002311.mail.protection.outlook.com (10.167.242.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Wed, 26 Feb 2025 12:26:47 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Feb 2025 04:26:39 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 04:26:38 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 04:26:35 -0800 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Saeed Mahameed , Gal Pressman , "Leon Romanovsky" , Leon Romanovsky , "Tariq Toukan" , , , , Moshe Shemesh , Shahar Shitrit Subject: [PATCH net-next 1/4] net/mlx5: Avoid report two health errors on same syndrome Date: Wed, 26 Feb 2025 14:25:40 +0200 Message-ID: <20250226122543.147594-2-tariqt@nvidia.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20250226122543.147594-1-tariqt@nvidia.com> References: <20250226122543.147594-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002311:EE_|SJ2PR12MB9008:EE_ X-MS-Office365-Filtering-Correlation-Id: bc195bc1-9bc7-4ca8-13a7-08dd5660d67d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: UoD7/KOs0AGgLS6gdH1urwCOpFXKu6a3FHrx0lsfzcEzEieAmPuW0Pc7N/dhHB0QWj8ouFwHU7Yr7H0m/YYoEfPQJm45EBF8c3o1H4Mojg5aolYxaAjZkB6E1uINVy/yTm0J6xTvHfnqZfkKIyEwetjnyFC2dMrYxCwhoc/zMjvI9pPpvSATk12wxhgQ2E0zPklHk+R+1x90ad6oSBIPiO5ZZycKKNSJtODAHPEx5MSfCW/mFVVHC5tHrvt3ECEMPI5ShkboiQNOXq72TBEE45449brkYVV4NSjoP/P/xJgZlcIYM6YS3OdsI/AWaZCwdW7p/p/DfrSnVtQZx7n8qgoZgsjD+U9DBUcT1jc5MNugoyCnnJuoVfxr0NkGrRQLKG23f/iTkBaipOpzDpWSG2cY8ZdQDa+fgdJOplPLj0XUwH2QY1psXHQAr4438Hz0DMhY268dijxmTtOgGk9Ib9vfV3eCNkZdyBOhb9VaVsoTeS7Q6trXrDuyZ4VGcTBRz7Lx2tYchmOLDgHBXpEE0dj3VZVN5H3tsMkmt/sI/A1aPQeeiX+HwJ6nUorQo+EUDRgK3RTrkJuesy9FKX2HmYOt47XyM38Au2zPK53XTTjXqPys62HPfQIoxztwV9uZwztEFcVM4yJMcBKnNjA6jb7EF4m33VzeJNVjia51RphBcjpCzjSbC+AUyBDzzF8tn+Mmth2S+YPxoZXSLJ2POU5vp2RpWtOIp9cyFGWukcmbipr479WGcS8qKsTgCTvo7nm6lGX1yxrcAyEF7/J/C8ESlr8wxnBBm+d5olHknCbUZm6Ujki8y3B1c413JWfltef5HCZKkPmejPSsYN1XpAS5V3R6Ugb820Ig2WSH3KpgtuGrJqUpWPRexlSR0n+laoEJymE/zDLns5xQVDnYk3tu5YGOno1vp2Z5oiV0Hvn3Rh7GvTOtJrRYilihpUabQ7LPzCJRZtqMlNw4SlqwHB49lO/jpNXXvtR+SiD8AN5pJha2V3490IeHKch/be4T7zHSThJMzlRkpx3EC73qWh7NFPFLA7ljaJivoVdyOzohtpcBXhbX3rKNjO436omSG4CJhtNcRKbQjuPm36CPb+smPC4mGpCE/lORder3E2xpedHr7R6B9stdOVUjVANUYqVo/VeJunegAIqtkIRMz1j1iGqfam3Lw7mZFP3i4k5CbK+jfjmfBuenSq6tELGISqancCNgQK+0IlmM3TdVn84lW5wvw6U7DOfpSBcZ6UHIyNpjwsYcMxiq0J3rm7OKGE3rRZOGcdJEl5LpwZHC9h/lV17Kt2no43O9p9iM7ewYEstUBvolExnevgFLcMWOyIUsxitZoqRx8aFVYnuttBwQKPoyunJL62HpWy/N0XpYOGqXgUEqA3FeytHu4A9FrSSAeveeKUjo4WUgAXeGuflAGRPG05QY61rxmaWWtvmLVQXe8A2LwBow9iPuf5nV3cqRM9Sb2SycLllY6hsB5M4mNprRu2R5cvrUyni8CVM= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 12:26:47.1692 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc195bc1-9bc7-4ca8-13a7-08dd5660d67d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002311.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9008 X-Patchwork-Delegate: kuba@kernel.org From: Moshe Shemesh In case health counter has not increased for few polling intervals, miss counter will reach max misses threshold and health report will be triggered for FW health reporter. In case syndrome found on same health poll another health report will be triggered. Avoid two health reports on same syndrome by marking this syndrome as already known. Signed-off-by: Moshe Shemesh Reviewed-by: Shahar Shitrit Signed-off-by: Tariq Toukan Reviewed-by: Kalesh AP --- drivers/net/ethernet/mellanox/mlx5/core/health.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c index a6329ca2d9bf..52c8035547be 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c @@ -799,6 +799,7 @@ static void poll_health(struct timer_list *t) health->prev = count; if (health->miss_counter == MAX_MISSES) { mlx5_core_err(dev, "device's health compromised - reached miss count\n"); + health->synd = ioread8(&h->synd); print_health_info(dev); queue_work(health->wq, &health->report_work); } From patchwork Wed Feb 26 12:25:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tariq Toukan X-Patchwork-Id: 13992266 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2049.outbound.protection.outlook.com [40.107.102.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5360F2192F0; Wed, 26 Feb 2025 12:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.102.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740572816; cv=fail; b=gkuGjp1Y3ayqBnIdeDWOH6jLkyQ9ms9RXrIRFabciIufIfcvJgR8HHaNErfvEkSaBeEQYnycKQ75OrXom2jADznwtBTdTOU+naggeIFKzZyq4++9rZFYI+pZZTk979rqlrfpmaxhMAZUQE335zM8wXsQVgPdDR4LJPONR0EYb8w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740572816; c=relaxed/simple; bh=8OESgjOG301uqCdCLVrfS10OIx/eBClDuyqiPaEbkg0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QOerlFLXqRy/u1jxVXIOooCtITVMoHBzGFr14UGNGZJvV8lD2p0oZvhZYEFUa7DtohMRGC1kPCcY6szjX03N4iHyPV8WoiVaRe53sbY/X2VPTIVoygXuOGvsvdsZhm0WkhWxgPoJZ26e+rdfV3XHRpm//jHrdExFccaTO07Ow90= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=tjZriNvj; arc=fail smtp.client-ip=40.107.102.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="tjZriNvj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uvdEHSd+LBruOwNY1tswuNqq34ZZ8JDn5JBuGsyU5HEy2m6B0Cx4vmGOlcjxEZBs3Y4lWDS5XQ+TWj90stAZwZszaQzsO4clrx8l4ovqtJaUMZMorwrfjG8ierYR+MUGKNQkixudjwDEOWltxuKfx/QtdcwSBXepAG923j4Yuocc18J1JtNFV1M6koTCtFTmh6S0OM/7NRJgK6j3LHT4w12COHJV1NrdwR7N+XCv5WSVrbHP0ZvBwO6YeorAr1zQprO0PhLg6dcR4L/TrNtaGAMDxRsPvIHmJ6gNtRwM6HnX3LGDrh81SgSfkziIg7Ae5bX4nHGO3y3TBFeRGUphzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P9Lyuh+dtQ1iJI1OCjrwDXSDa2xXpKzIUCedBsbIVRg=; b=v96TwOm09gW4cgf+KpP2jfez2DRnV4i1vsDszf4bYMUbrNE7HkQE0mk5TIcGjGVdHInm/wBuqjHvkYGo8LcB6i+cKsRob2r/tiFNxf9Vrnx2K756gh3AVwrRCXx5kWrPyOLMm44RBL0+BStkJYgCM5WKheMFHmKstbWqzM12Sy4PZeOY2LM6guNpidj7WGygnE+G+dPn1WnqCKgOP2sxN7jLJhO7770X6NA3lejGbEZAcYgaYpMh46v9xktu3l5aZnbD691xYYyqs9df8AMC/BGZjq8l3YF9LoFfDV8/xJfh+aznOtm9yrsi+rewPk/jKzKi8BvVKZo9K4ZtJujFnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P9Lyuh+dtQ1iJI1OCjrwDXSDa2xXpKzIUCedBsbIVRg=; b=tjZriNvj7z185N5Yo6b7gfGQU6mpWdUlAXBbI8FYeu+U0CM1MV/wU7YK4wmo0RM6F37GQvT3JswGaMU6SiBSptj+yWeVUIc/fI6Z1lOuPaOaOik6FMGTWNaLZitIQf1bVQokrzFJy1mKMml9xqnMF0Rit5BuJujZxoWZcogrEUU8pok8+7cBHKFM32ed1IRa8PfDSuhi4DJP10j4yw5x32XUY5tSt8NDboDIW1MZ0J1vYa3iwQQZIYnbTKa2y73LQKOJExVsQXuedYa6/LxHU7i+JPud0/iLClsvbjz+Q4RmuLE4XU1mNKVqCvYBTcTFlHg72LF8Iwnxfi2Oqj+w/A== Received: from MW4PR02CA0019.namprd02.prod.outlook.com (2603:10b6:303:16d::23) by LV3PR12MB9438.namprd12.prod.outlook.com (2603:10b6:408:212::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Wed, 26 Feb 2025 12:26:52 +0000 Received: from SJ1PEPF00002314.namprd03.prod.outlook.com (2603:10b6:303:16d:cafe::c6) by MW4PR02CA0019.outlook.office365.com (2603:10b6:303:16d::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.20 via Frontend Transport; Wed, 26 Feb 2025 12:26:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by SJ1PEPF00002314.mail.protection.outlook.com (10.167.242.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Wed, 26 Feb 2025 12:26:51 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Feb 2025 04:26:42 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 04:26:42 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 04:26:39 -0800 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Saeed Mahameed , Gal Pressman , "Leon Romanovsky" , Leon Romanovsky , "Tariq Toukan" , , , , Moshe Shemesh , Shahar Shitrit Subject: [PATCH net-next 2/4] net/mlx5: Log health buffer data on any syndrome Date: Wed, 26 Feb 2025 14:25:41 +0200 Message-ID: <20250226122543.147594-3-tariqt@nvidia.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20250226122543.147594-1-tariqt@nvidia.com> References: <20250226122543.147594-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002314:EE_|LV3PR12MB9438:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fe97dbc-35a2-4d58-97e4-08dd5660d8dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: 9i9iCxFquiNAJbQml1VB5tAlmZT9jNGbknwD2ycDnjipBXy6bnXoLt3nrguvdlBrLZD2NWArsV/o6qmmz/IMBIw3a+t525kcE+IEalobzYABJMdMFY6iYB3zdMNj1XEODaQAkOmjTQ+WIiehAceR4IV2mdI8n8Rfg8IrTE1osP8nkYkgq6hAoNuC1p6QHAR5D72o+vdIpL6ONo3aay4b098YUgZMl8d1ziH5jM6cOg6FwnUsYbWydxItq2L5bZxH7ZTLaZA4y/yaaGO0XZIp//+IMy0ZDJd8nNHcWwn2gWUrjFhq6PTo9kdpaBh3p0/RHJ6fRO/T/fOXm95Jy67/7QyTe3d/S4CcP6ULcho8uZ9My4/HoAsxFjb9BpKEDvMv6+qS84UiWUDjbH55NnqXTkEYOfdW5O+JxG63hYvZXAPE0TuMJs8ydgdgFziHtZlnJMlCzczz9U4cqoM1n46T2yrcVqzoElTrL846GoJqzl7QL9q9ykMYwyBJLyiro59nCK0rbhcDh36Hurp34+uALYdUxNKTUthPmFKScBe1proRuSDAwh4u+yTMXQASSUJX1D8OxsORycuWwmQQwcTsB34XyVFgPlWV0SjC58TtK4Da73PnXi7t7KQo3YYehfA4nEs0n/pbjuh9MxkB0fhFWvJkqvlg5hD8jFbBkS7hxjsS2NL3O8CR7SC8t4Oj1CSyLA0tpN8rhiPM5ptMK95EyOaGqmW65lSH6wRs8B9MdBDd5l7otXnGtPfYgbKYBxCJOqrUMEvYt1x0Zvnx5Y2VArZuqBQaQ+ebQQV6sX4/tLVAeiaE+6S7fnOqeXjF/udBCkA5yiLVB/aiOIUCDL+/l1QY0X07Q8MC/fRGTheRkw8+W3Ira7RD4k03zvRQCoHf+ufRGHhtDmQc9QzI1t/tk3LM7Rx8/OcNyZeRONdKgLRdqR1avRTVbyTXJQ3ITJ3QK5kUaa2z4qQrkxZOOzm/5h3X6fM9cvjS7Xagl4Lc2mlmZ6zY3U5H2JxEcEopuMxYLiUcYuwOGZ3nxHCi/8Q6kczWluDTwhijw2tJyca7chWBViYpVt9hL+P8TS1gAq586UwM33JWQBmfjQY4DluwnXlNq+qdlmPhvc/KFEi0hiKgirFyq3eIRUy/bBYP7X7empLHkXTXaCHq7QukmG5J02qqBIYnU1rwZxzibETa3KYK7+7UjrsP0C7B+RoyMMt2oBamFsEoaPapML+eWjvJdMr94yLAjrWtJBx/aIEgVP1L5Jq0Y6fli7vwMCDCzHNnr2Q2VvaUIvwkSz5NqGTUWx5HKnOCc2m8O04DPSdFm6jsjpGTdmtxBMzhbVabBl3sYRnej8Bab78daFEHIoHpbFspo5dKsQex0H4afEzfZwoFoIHbjcWvzP2wwUU38ERDb0IPxdPu7rVSK08XHN63ROu6bnhNYBHrDG6e/TQnjalWqkRWu1OCVwUK8IkmMRMdojLnTN0148/Q/ZZtofOjtYyapozCJNwGOuExnU5MEMg= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 12:26:51.1572 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7fe97dbc-35a2-4d58-97e4-08dd5660d8dd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002314.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9438 X-Patchwork-Delegate: kuba@kernel.org From: Moshe Shemesh Currently health buffer data is logged either when FW fatal error detected or miss counter reached max misses threshold. Log health buffer whenever new health syndrome is detected. Signed-off-by: Moshe Shemesh Reviewed-by: Shahar Shitrit Signed-off-by: Tariq Toukan Reviewed-by: Kalesh AP --- drivers/net/ethernet/mellanox/mlx5/core/health.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c index 52c8035547be..665cbce89175 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c @@ -806,8 +806,10 @@ static void poll_health(struct timer_list *t) prev_synd = health->synd; health->synd = ioread8(&h->synd); - if (health->synd && health->synd != prev_synd) + if (health->synd && health->synd != prev_synd) { + print_health_info(dev); queue_work(health->wq, &health->report_work); + } out: mod_timer(&health->timer, get_next_poll_jiffies(dev)); From patchwork Wed Feb 26 12:25:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tariq Toukan X-Patchwork-Id: 13992268 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2041.outbound.protection.outlook.com [40.107.243.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBAE02192F0; Wed, 26 Feb 2025 12:27:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740572823; cv=fail; b=FdjZW3gG8wCFZ1fDmW23juqEu61HlE2+S6QizeqzF230InmVqkvVOPW0CniufuZ89RENp/5TKiem2aMnhVLoCaAKXzuWU26zp5Mop6E1OzSYOvBW6yrQ+c/YTs2MkrBexUg3bWROpsGRNWXgAbo8OS9RqAWAPU/xW/EWnkCVWAk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740572823; c=relaxed/simple; bh=y3VJiONxsn/t3KhkNesvKxKWrH0VKgzNMYMt7+ppBGk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ho/6680ozgp8Cl73pz2du/i3K5eJP+r2KXExCJCI6ojK4tDFCS/tR1GhHDdCv+PyzrR5tP52v0E0vxaSfSZud0PMu/Od/EpwxL1DbXrYtSlLni+1D7lgWyBi/DztZewOSqKJKyEZNNE5P5nAdukU+4PCezqPQ9j5kAlfB5JLw/g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ibRDPJZe; arc=fail smtp.client-ip=40.107.243.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ibRDPJZe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P33w6ulJ+VziLaROL6c69mivYENDLHAG8qyEWNpU+9w460I4Ifdz7tgld6niLdUnEneTPsclpybfqkfEf4JufhOSZSPle8vwnMOlNUzPPZpd7TdS5Y9UEWY4V5sjI5jR+mtzyj/XKHho9SqJfOnMScMBUI4LnmEjVYu+URfD1z4Qs5CqQ3LDeUlniWs4P/yblDwXKwAXrcfHH+KT77WUW2SC5gawBKf6AavvUvsVMb0XtzSdSZ7qX5fbIDukaDlQVUumTT2jo4egc9bmLibVTkyWAWo65yp10Vm2pzYQlr5897rJWR0KNmBWAqw80MyoJpK/r4c4pA+B7Ce5sp+FfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QHUnOPf59BiFTZ+RmRs9Gu0/+QYSJY2niCh8yHfcDbw=; b=JsbuunBnjszsOTVjREoSsJxAnOb7mnAMVGUiIVgrb1tdqgHWvyruHFVPgSshYzhNv3vlBqtShboMQe1LDQY9talNCKlkZFgEHPu+32rpmayHL4x/+lf38McrBCwdn1ihJFJA74UB7/oinQXbdSaYXTMixeagCNOmLoIe/eM64GGzQuGMrJS9prgpsNNmeoB8XptDWFdvFFRkL6EAm2CGTyF7fhGcAv/f1zDfe+julO+HPIsw5gP4O60nuF2TKQBFI23a3oCOiVpx/qKS2MGdlqK1VherdMjyMAcY3JOV6nWj2DurKQA7hxbcuf8VAxIf99PXcHBFOTPCVmtoC1lJRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QHUnOPf59BiFTZ+RmRs9Gu0/+QYSJY2niCh8yHfcDbw=; b=ibRDPJZe/QCTwyE2j1gnYr15J56wV7lBaHS9WavNemzkpDkJnJcekVOBmdJQLYBiYp9ov/xpJ+TuQ0UGYyBpnLeVzI58NnbO1obkov5RTyuzMGqyDv0VOdbqZ2r05UHa5sT67p5Ul9uZFfIX/afDKxDmtvZPetmDcJa+MuKIESwhO/SBudzfbmte7Co5oXQSbyMuEde5REfRdIj0jLelg7Qet3VEDiqlUT5rtaWIQ9KwmBW+dONLQv9mR4tp9OY+5ZLZ+UsIZMCF3tQkvdmRYkvdz1gkfYa0mbRbzhMrdujbfFymvWn17JDJQj1nnSDtPVegkym6vo13tSt0VGs4RA== Received: from MW4PR02CA0017.namprd02.prod.outlook.com (2603:10b6:303:16d::24) by MW3PR12MB4476.namprd12.prod.outlook.com (2603:10b6:303:2d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.21; Wed, 26 Feb 2025 12:26:56 +0000 Received: from SJ1PEPF00002314.namprd03.prod.outlook.com (2603:10b6:303:16d:cafe::1b) by MW4PR02CA0017.outlook.office365.com (2603:10b6:303:16d::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.18 via Frontend Transport; Wed, 26 Feb 2025 12:26:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by SJ1PEPF00002314.mail.protection.outlook.com (10.167.242.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Wed, 26 Feb 2025 12:26:56 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Feb 2025 04:26:46 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 04:26:46 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 04:26:42 -0800 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Saeed Mahameed , Gal Pressman , "Leon Romanovsky" , Leon Romanovsky , "Tariq Toukan" , , , , Shahar Shitrit , Moshe Shemesh Subject: [PATCH net-next 3/4] net/mlx5: Expose crr in health buffer Date: Wed, 26 Feb 2025 14:25:42 +0200 Message-ID: <20250226122543.147594-4-tariqt@nvidia.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20250226122543.147594-1-tariqt@nvidia.com> References: <20250226122543.147594-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002314:EE_|MW3PR12MB4476:EE_ X-MS-Office365-Filtering-Correlation-Id: 90c5c931-d032-495e-142f-08dd5660dbe2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: LepueS3laHd799/jIR+qsljIXzwECbYpkrlUgfU46z6qohZVSNeo4ref+uHpdv+I0DPRyOJXZHeruz7AssAp54pMKT/XwLJl2U0h4wE+sseoHqvFPvCgvT8mumcjUJWSILVOtGGo9E0eY3zoA5Drye+s1afJRalkqJQe8ZrNm7AkvsK6M0Ftpuh6PlD/x5T9y/TbSDHnKQB7ptkemQ2lpCtG8kLMIBrVuaG6NasGIRyJ8T7Sp1mvwNXRb3fTiAcnY7I4dQMs/bl7a1Y3ghG6OlxRWVf9gMJnOs7/IXKjfd8f0qvM09bs9AaYZhDAyc6c3pd56u9LAkSmdzMoewbmElwFF/H/LRkfIzAEAI5Edh3VoytDgKUFzIgASifXAu9bCWFNgf5kpw5m7iMcjKPhi1cNj3alYVr3piMhRvdeMlZmnJ1q8ooNRSxlGt0kgKEZgWKmb6TUy2gdoQlnM4No71zwPiCIpBUN3JGm8Tp223P8WeMr9B1CCJFv3+Gl9ebDwkTyFrVBdF4TK91mYxspdZnmdcOhzEJxllv/NTSFtzv45h4fVpn+Fec09GUs1scey5HCC1OefKuU5lPYuNrBQN4puLPL2FUNSjNFjWYtLE4v+20bX79khEiqb99K6FuNzv68A34FcAhJClgG+hjcimAoatnRKFUZZgRJ3/r6dsSVfOgTkWSSass0vrGNp+HJTEeJlkMg5g4VFzGHvFHQ70+FT0TdIUCGTU/H+P/FCdMW58y8sTqh+2BZ6Q3AwAtMkuzG6NWunmOypOylLnvDQJu+a8EeAhrr5PoUy9KfQ4weQakFuDl81jNgOWuKQ2GJb7y1CVweIkMC+fUsWyFngemVkRJ49XyF3Sm2PbAJJUSZeY/Fw5KE1jpT0tfrUQTE6EjqAvZ64YU48EAohnD2vSXq49y40xz2ZLEJq/vxpp57HPGzb6oVGX+bkrunpxOHuWuWh/74ImmzgdxLH5GKFR8yMu2GAmgD7JqtrQldJHgreKsnqWUsZXRqPp5LiBMeRlFtomjfQLunSvo6cqVQzi0YIprRfRmQVA4bfoRsHMam+VA0ldA+w5hXWqCgeBW9ygbG7lYuW+DSd97VwGM5pnNwCt1Z0uvUOH4+UVr6u2qkhpry7/O/d0i5aimaoG6oiqsz0lhzp0CIspOvQEEovqXDG8lqhnsv4im1jKuiYGVdwhxCtXxuRhcYtJ6bXAQ+TAB4y8Puf+fS/gAf9RW8OuDnEP5yPRBE9LP/48t87F8Z5hWiu5guA4Jf5VxEnoaMLxtLjpiWW+bpl7ymzeR6oUTpH5YyQNTvifWG96DDfOhXT6dV6D5gPYvGQH5yBTb/16+z+TmjJADUz6NM9dSgcVNSEXMn9hVcEV01siLWZm/3BowdOvU7cpbVozJxyRwwcZa0sFtztWUIi9WBaWiCK+0vSFpMLe2br5IW9K4jJWevr5YRvhpt7Mx6kuxefWpbU6FJ07m4RvslTEf7Fhz0gyDpPLgy1laJtssRgI9QOlU= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 12:26:56.2197 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90c5c931-d032-495e-142f-08dd5660dbe2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002314.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4476 X-Patchwork-Delegate: kuba@kernel.org From: Shahar Shitrit Expose crr bit in struct health buffer. When set, it indicates that the error cannot be recovered without flow involving a cold reset. Add its value to the health buffer info log. Signed-off-by: Shahar Shitrit Reviewed-by: Moshe Shemesh Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/health.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c index 665cbce89175..c7ff646e0865 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c @@ -96,6 +96,11 @@ static int mlx5_health_get_rfr(u8 rfr_severity) return rfr_severity >> MLX5_RFR_BIT_OFFSET; } +static int mlx5_health_get_crr(u8 rfr_severity) +{ + return (rfr_severity >> MLX5_CRR_BIT_OFFSET) & 0x01; +} + static bool sensor_fw_synd_rfr(struct mlx5_core_dev *dev) { struct mlx5_core_health *health = &dev->priv.health; @@ -442,12 +447,15 @@ static void print_health_info(struct mlx5_core_dev *dev) mlx5_log(dev, severity, "time %u\n", ioread32be(&h->time)); mlx5_log(dev, severity, "hw_id 0x%08x\n", ioread32be(&h->hw_id)); mlx5_log(dev, severity, "rfr %d\n", mlx5_health_get_rfr(rfr_severity)); + mlx5_log(dev, severity, "crr %d\n", mlx5_health_get_crr(rfr_severity)); mlx5_log(dev, severity, "severity %d (%s)\n", severity, mlx5_loglevel_str(severity)); mlx5_log(dev, severity, "irisc_index %d\n", ioread8(&h->irisc_index)); mlx5_log(dev, severity, "synd 0x%x: %s\n", ioread8(&h->synd), hsynd_str(ioread8(&h->synd))); mlx5_log(dev, severity, "ext_synd 0x%04x\n", ioread16be(&h->ext_synd)); mlx5_log(dev, severity, "raw fw_ver 0x%08x\n", ioread32be(&h->fw_ver)); + if (mlx5_health_get_crr(rfr_severity)) + mlx5_core_warn(dev, "Cold reset is required\n"); } static int From patchwork Wed Feb 26 12:25:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tariq Toukan X-Patchwork-Id: 13992267 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2047.outbound.protection.outlook.com [40.107.94.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB1A71DF990; Wed, 26 Feb 2025 12:26:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740572819; cv=fail; b=ocnSILg3O6K3413M9yciZr+8bLZ9IJtpJKAZc/Y5dZSaxb6qFML9XLGY0x65U2lLq9obpi/MSTDSim/amevGIk+GQ0Q/eydCxBS6OHVVppZRYHDWgktz1JS1F7WDjttZnlLAyaiZBOjHzYVmKl59sRTt47SEYE74j554oEgjutE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740572819; c=relaxed/simple; bh=9Lz+ApN5fnMXNogXCrvKMmY2mNKJA9gsI1XmqQychwM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VDQZrCQtXCQjI6UWiaMpbFZN1Ss5laaesHT9vZjx1J7raR7Lz1Xbc2gYi/e29O326WCWZLjlQkoAOnKfdMf2J/EmQBxMdreVZ4WlKFoU/veL9ilBJQkdvCGisVbcT6dAk0vK3r9HsJVr8HP7PEtomTTuwpK8awlG1KfcR+PjwhM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=jxMrZl06; arc=fail smtp.client-ip=40.107.94.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="jxMrZl06" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PDYWXNXboWlF4DPCVkptG9bPQVOLjHbsrwTflCU8GuEdvuqq89Dk+C/tsGo98fVR16+fRQ/UQQBsvYGHoV875OjnX0EHFeS6nMRvpkH60Z03K/BFGvRMnbC2apvfnKMIpOi73r7Hhsy7qBURVLOR/by97AfSvY8uC5wgyK0TcUoyLzGo7Szuq8W3QRRNVzoho4EV+DDiNVR+uJ1aMhDEfCnDEA086/gvUPhfkvOaUJE+tUxpZccRmu+Jchei3p5/w2krWu+wj5Zf/VahVUo51UHf9cZpYgpbogOSJQrUfXLgWf+d/FCXC4ZVNppdrW66c+U3BQh4yg4RXMgSm1tu4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZlpiU/fFnaXwabi/mDKGM/p+l8Y7ZAiSa3gYfh22CN8=; b=Snmz1h1u1uIVXWMry9UYnOppjcZi3p0KIbkMUKa6v3fhdFg24MM87mNdsuT/F/lUJ7cuZDHoCncd7N/RDnamQ2HJiAJ86S8GPCJPoJzHPwf2afIWHOj8ItRVgbnzzj/xg+bJmBsvZu6c0sjvATodR4sActwK9DhXVCD9quS+B+TEDHmQFtEbC04zo7NTIojEDJU2955s2QntSGEogcz1vj4tvNMDW5yvAEzgSxLMkFLG/ppJ/B+UpkYbcOnOsoChkGYQuQZDu+IsYtLLMiB5Ik6hzA7xsjesGLblryyV1auM4f3dMbd1Is7zGzsxGtWIgb4S/WAy2FGWRkHpyOzi+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZlpiU/fFnaXwabi/mDKGM/p+l8Y7ZAiSa3gYfh22CN8=; b=jxMrZl06+E/SmtRXWsLbgf/fklmjr6j0wgg7iFbJZX8lxn7ATTBDj4MuFcxhf0xwEuC1xeQq7+08YYWwDUCz8/ln96hC0yhDBQDSPHTXgG+tNIIea0o/GHSBoBY6qBYx30rGd48GxbvOdQEpSqQlfr640kaeYOVxSP1QnjQL3BLti22otssZzvzPDif8A4uNNH2DjLEYnCx3hSKmAEhHr1yfehjr8zPRukwBUXx/NdFYfsz3ZQrM6CT+u19wso+Ml52w/I5P14nfEMHLGbdZ1jsuC7cqZ+yFbTeY+jGFGhErZkn3uak1/x01b3qx3QH4tRCgmSTzpf66opQ0XbD0Dg== Received: from CH0PR04CA0113.namprd04.prod.outlook.com (2603:10b6:610:75::28) by PH7PR12MB8123.namprd12.prod.outlook.com (2603:10b6:510:2bb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Wed, 26 Feb 2025 12:26:54 +0000 Received: from CH1PEPF0000A346.namprd04.prod.outlook.com (2603:10b6:610:75:cafe::15) by CH0PR04CA0113.outlook.office365.com (2603:10b6:610:75::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.19 via Frontend Transport; Wed, 26 Feb 2025 12:26:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CH1PEPF0000A346.mail.protection.outlook.com (10.167.244.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.16 via Frontend Transport; Wed, 26 Feb 2025 12:26:53 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 26 Feb 2025 04:26:50 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 04:26:49 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 04:26:46 -0800 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: Saeed Mahameed , Gal Pressman , "Leon Romanovsky" , Leon Romanovsky , "Tariq Toukan" , , , , Shahar Shitrit , Moshe Shemesh Subject: [PATCH net-next 4/4] net/mlx5: Add trust lockdown error to health syndrome print function Date: Wed, 26 Feb 2025 14:25:43 +0200 Message-ID: <20250226122543.147594-5-tariqt@nvidia.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20250226122543.147594-1-tariqt@nvidia.com> References: <20250226122543.147594-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A346:EE_|PH7PR12MB8123:EE_ X-MS-Office365-Filtering-Correlation-Id: 928192b0-84aa-4c97-00cc-08dd5660da80 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: J8l4giUrdnD8HGiNObwkYksJr07KAJkZt6QhQnl8XuB3KDQohcQ9ToOy3iLExtSnwyfGGxnUlRt7O4B6QIfgNgSw3JHzPOtzWgzOOLTHVF+u3r0DiLarWlGlPki2vVoMG8H6WgVOLXbJZKR9LZuLTJ2td6AR7Oq7qtqpGxfurFeJlMjCBnFkUo9DE7ZfUuQ3rjdGqe2WJhx4GnOZDsgjtWM4pbug3GVqZ2TVj0Hqo6RvW8Xj6D6exotDdZx2eiRQs+Ss8xOsjTC+WIdgzXtFuw6s3fdigVV3zT+nT+2BkEGffnbq3U63l5tczUlmsg5jcpZBZkyj1xTkqlwFmuZSlGZbqih5zwaYPYiJSfLT0Ow9kiwxzRxiD9M2AxpO15hr3mv2wSgyXnG/QHMYB8/0xIye9B1EbU/1ggzi9tICZVEBqim58kbkCwgdT8oUmhBqVbFHk8qLcgjU8gtJUZDc1S6AMCExh4EdvRJImskCiBjTIFSDm7FNQBpS3VchBnEr5a0wAhNyJL7Qx8FmGjZwfULkauLdXm/bF6yFT/0POxlCufIbxgSh0s+3kh8O4JXmqdrii2FNzbShuOHv00lET2Ui/nRUqgxuXZB82cdPn9MbsCtQIDiiEOTk/6tDp3uATxKVZ3sjfIB8DZDaD9OBhcq4vOWQmzCvPz7T/VL5qG8a89zE3AOvsoqV5U8H+aG7xTXCQkK+hfP8eQ6Z94vwYngKx276kxSLhcGoMutuBzMsWQ8Fu/80OMbOFwQFV/SBWPW04lJpYgk4j9HyX4ebCyNOP5VFN8bbVktXiOXVGBHdcu9UFE8TKT0qKkQLW3iYVKuml7PYJ+947Vsu0sQ3+wWWQtsPYmhq9LbNZM3H0EmqLJZIMAGVsrRXgUiYscNpI5ogsN76+b2FFc8IMeo2+BNxBjAAQJScTdRO3eET9IVpCLG0qCOV+WxqhSfgoJZbhR3itiO0repLj9jDPyzEZvblT/J8XO5xq4HfgZLC82xs5F8hW8e487UL4NiJtP54HU/AB4vjuWgqXvV8cl5nakQcr9wuaOjKoweWcZ1I1UO2MStW69deCBayMFlhzGw2Ror0Z1vQ/LP/rDhHbNtKkV9QpbLQmdkDIN2yx0OmVFKznn9cQ3qugwATKSy5jVnKzawIoyeOn4NjDPDywZXGb1r77TttXwEH9AOM4iipvtskj1rnoMOLAdWEiOL2AUvvsRsxP3ZsW4wCBwpII38atCwzRv/G7xOplPbfbEe5VT7UhLCZn3WudPx9/Mduc19GxFkWXeFw7icUsTY6UJFiGb1uMhzKzmm9+DY5uNfwHzpnCDW5+c97nEfZYumbSbKxH25m3d7jxXBCraRK9GtnCZAg7jWUZnn5xpThjj3LVT1qnE6TQyG27WWiXfe6YLw4b9xdLD9GDkE4umlOLaCrf1nSbKiGM1VfiPwAEuBf+OGrtijsr98RyjLru6Pad5zTYU0rNvPdrwE3RO1Rol3ZcONVdCeRJvjTGCHFiy73Noo= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 12:26:53.7743 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 928192b0-84aa-4c97-00cc-08dd5660da80 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A346.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8123 X-Patchwork-Delegate: kuba@kernel.org From: Shahar Shitrit Add the new health syndrome value to hsynd_str() function to indicate that the device got a trust lockdown fault. Signed-off-by: Shahar Shitrit Reviewed-by: Moshe Shemesh Signed-off-by: Tariq Toukan Reviewed-by: Kalesh AP --- drivers/net/ethernet/mellanox/mlx5/core/health.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c index c7ff646e0865..91613d5a36cd 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c @@ -380,6 +380,8 @@ static const char *hsynd_str(u8 synd) return "High temperature"; case MLX5_INITIAL_SEG_HEALTH_SYNDROME_ICM_PCI_POISONED_ERR: return "ICM fetch PCI data poisoned error"; + case MLX5_INITIAL_SEG_HEALTH_SYNDROME_TRUST_LOCKDOWN_ERR: + return "Trust lockdown error"; default: return "unrecognized error"; }