From patchwork Thu Feb 27 06:01:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 13993789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D808C1B087 for ; Thu, 27 Feb 2025 06:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rVX38OzyB8buiIktVdALjdZvLPNO7X5PMsyOM4l0Ik4=; b=s4wHvsUr0ghOzW URpnsBX+5keVKeKMUi4cMX4n/OKXQQMw33DSatdsIJ0+NyeAPV9YBG8UWsZtLpmu2yRNysrcnKbsd atoT8j99NrMXZdbtlqapp047QfIJwlGOWy7nIw0ws1Iexxo0GWoO42ubdfbfmKRMAB28+xSiUe8lu 2vi7bzSe8AtZ5Cw9rn0dALL5W/wVaKKKqhc8BFGAixv8xl73IcM4O4Po7WvOpxQ8VqMhB2leYR7wC pL5SOnIz6gDvpjLSQTS2rMFZiDGYzGdzS5gPIoCx9YdeWgK/a7UC2p3W0ONDw9W3FubzyU54wMQ+G O8h4YzXslxNREmmSB7cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnX0J-00000006Rcp-3bGk; Thu, 27 Feb 2025 06:04:15 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnWxw-00000006R7H-1l7z for linux-i3c@lists.infradead.org; Thu, 27 Feb 2025 06:01:49 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-22328dca22fso7467565ad.1 for ; Wed, 26 Feb 2025 22:01:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740636107; x=1741240907; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TbBWp8Gpp+tRkxfYN3BsRLi83MVsRiY+awmccSWrlIQ=; b=AxQUHYv3wZZNyDnWrp+PCmH5+5ZEdH1Ve3L9zCNUbSjZteF17NPK7IjgJ7MCc0kUuC vvN7j9zHMKH9KhxpzUUKHgnZxewdSU22Z5ON6+x5va3vKi2W+sQgLCpoJQQLQ6cImaPS UpZEe6HBC/a+ZqwcWh0czox8/cAAMAwXgHE24nP9R74h3RG1JM0KtzlvnQK55JKpdCZi vu7VRSmb61eG0k0468bTSCGCrpmQZsd873PW8eovLeFZVRvzJpl0G6WpwRLMjPl40KeN /oLAm83kJfHkXGUAcFnIYgzeQNtcH/JJ1XwcNT4rbkuAW+ap7phS2vGUomYarn4yCeYh +4qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740636107; x=1741240907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TbBWp8Gpp+tRkxfYN3BsRLi83MVsRiY+awmccSWrlIQ=; b=U5iTK4vpoPmIRN+OwrnfY0jzIz+18ikAse5ELUMPhmCzSiPgTLihog9tQBhT8PgeWf kkVMShLO5iZtg/C0CYVzI6I0sACeGHPl8HQDQFcD2cmIowf0uPjl52NeE9iNQqCzDwQt FqUIlFxREINTJwnmC+hVyKZnG82CIZ4uhdOItPH2A8qaiF4gb8SVn1CkfiaXiaMS5Z8v I2bgTnPk9QvVgzEQMbXtsA2CvjqaaEDkd2pw8Rr+zXvqriuvkH99TEHy9X/aCuzRgDpq DnElJAUx95g1/zMOpMM6d07tpMRzvbtZG2Cbd7YshsjfsolE+zooKxu68GNdcmHvl1Mj SbBQ== X-Forwarded-Encrypted: i=1; AJvYcCVwbiJdyFQKrD/b9TxD3NGgaytkQB24FnO6/EUsVsQPWDSmXM6Fpvdmf25ZQW1wxaiTfzFX4Jbkwn8=@lists.infradead.org X-Gm-Message-State: AOJu0YyILmSFkFZu1hZ6XYGwggKBprBxnZns0iEnCY1MpDo+axYyfdCW plYQAznzYmTc3pjPmvEDxBQkXPUjKMkqDS/MTf9g0hO5cQhozFbt X-Gm-Gg: ASbGncslVIEI5HnVagT3n2JTCNMf33uDwQKhw0goxAMknORyj6LGIKM3hzSkpay14aj uQRkDEV+m1PYif8wMxCd0JzbQeWULYuBUjMSsWr3Mtuw/lRsIIIKjh275SoG7wOLdvSQ+ZPyMFw iEGFE+oJI6LsTlX7bqOw3iuNslXq4YYqbqpL3bnhslqVndnUKJOATV5lF9uS7FrebviF6vZXevw 8qVBz4Co8irIcLUfN0cY5s2AdYSnnxupqDxZIb5aOeWrRNV2iRc0F7KoVFFGTe4vlr4z5rcZAE9 lj7ZA+iKPvsvCTW77gv80fV6dHXcGVgj13+G X-Google-Smtp-Source: AGHT+IFUBTM3E9ZUTYM/b7On4JzvSLZbPDNefBic4lp+FqFMQP4Iebm5RLt6/QZBY9X9G7Gd7D0Cdw== X-Received: by 2002:a17:902:d4cc:b0:215:a04a:89d5 with SMTP id d9443c01a7336-22307b33034mr151602275ad.2.1740636107465; Wed, 26 Feb 2025 22:01:47 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe824b67a1sm2728177a91.0.2025.02.26.22.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 22:01:47 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com, Frank Li , Krzysztof Kozlowski Subject: [PATCH v5 1/5] dt-bindings: i3c: silvaco: Add npcm845 compatible string Date: Thu, 27 Feb 2025 14:01:27 +0800 Message-Id: <20250227060131.2206860-2-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250227060131.2206860-1-yschu@nuvoton.com> References: <20250227060131.2206860-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250226_220148_456525_53AA394C X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu Nuvoton npcm845 SoC uses the same Silvico IP but an older version. Need to add a new compatible string to distinguish between different hardware versions. Reviewed-by: Frank Li Acked-by: Krzysztof Kozlowski Signed-off-by: Stanley Chu --- Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml index c56ff77677f1..4fbdcdac0aee 100644 --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml @@ -14,7 +14,9 @@ allOf: properties: compatible: - const: silvaco,i3c-master-v1 + enum: + - nuvoton,npcm845-i3c + - silvaco,i3c-master-v1 reg: maxItems: 1 From patchwork Thu Feb 27 06:01:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 13993790 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68B9DC1B0D9 for ; Thu, 27 Feb 2025 06:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9cSgWUyIXvTLSmdtRkb7ZgMVudOb77VJ06YojSjI9HA=; b=rq4XMNJ3CRsKEt 8V9miJ01eNXm9N2Ie8+Fh6EzQDRt7Jqwkg6IidK4J0Tg24EMipiMWqe5OFVNJPc2L+lQ92cNEiYfI gu+K2SpGs0pe7FN8Stn6Vc69XG2Ejfc6YQudCIkbBB/gc+fvo+w21NORk1aJ5o3pcp+mQcdzOJflT avf3IkWDSzeiVTpxkTGzv+z0wi8ywpyrPrxtoWM4cmIyTpl2+K8c5kfQCmz5OOM1K25tCFyzoiKMG 9PeirddDtGT+Q2xZx4EoR6PuWbFMBkPSSO7+4ZyjX27ec0R754AzAdCjv68SV1paJuj1utYa0jhw5 kBq6S4o5gMZwNmtW6iVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnX0K-00000006Rd1-0eN3; Thu, 27 Feb 2025 06:04:16 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnWxz-00000006R7g-1eJq for linux-i3c@lists.infradead.org; Thu, 27 Feb 2025 06:01:52 +0000 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-2f441791e40so964823a91.3 for ; Wed, 26 Feb 2025 22:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740636110; x=1741240910; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=okBbsi8R7J7tXxfGwTKtAERjRy2rLXaYUYDOVdToU2Y=; b=IX1TdMAZB1KoH8jTfHZXzTDB8U4+ztIwJhYv9Mck0Keqch1gXGWknKPY1FdGEfbep4 jAsVwf5PM/Ebh42ff0+1Ou4cIfszpZvHcGR80otmHScAtYb21pMpqTSoZXHeLndCTQ6R GYWqm3dqnDxqNX3rD0yLAXljbibWTJgP98OyFm+QNYm66liHX89G8StUwtEc12K2H4VV sey5dW8p1l8J4iLmg5GGHjPZeUXdhCYCwTOKXXlWJVhLKgG9+w6yuVPE5C0hsPFVmETu C8u/nRXkcxkylSfF1b8qpPKfrfdZEoXSccr5zAg8v/qTB3mAV/uXqYt52VxF0WOGWWuF q0cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740636110; x=1741240910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=okBbsi8R7J7tXxfGwTKtAERjRy2rLXaYUYDOVdToU2Y=; b=RY/upHLJ7LaD3YjlDoW9g1joakOj2e9sKUl+olJCJ5/gWCTfmqjyA3FADjXb1fInNs LiZmi8fEVVNhfEWsvZkDEoD1Lrx0geyFO7jSRiMg9NSHZYKYbZhU3qFTXbA9sz22J560 WoP9mO3cHTsIroOyXgvWNj4oBX8uf+KE746/i5S6144kxjtdp3eBKKcm+tdHnxCOhPqp OxQPxOl3DQtjnsY0JDnwXWblYgbuyda6HktWoleLrpLx7dxCzMFfHWwgI/myZvHffaZF yOIxlSpSAeUlwVioTtnWMeYVEks1i1X9O7BlWwt1dxfQV+7aLUV+rT4ut6gSNWKA9Kdv A00A== X-Forwarded-Encrypted: i=1; AJvYcCUkH1yBVksUlVSqFOAprSsl9wzb3IG8asKAO5mUiWxl/86n1El//DqyUh4pf+Zkqw4QTLrYsFAARU4=@lists.infradead.org X-Gm-Message-State: AOJu0YyZ/Wf2qOPv3r/CBnYlDL2JTvfJ0x/zjzE1f9w6Pm/SrkIgmZQI +hvtD7BSU4HNl7IHzsQJ/s319NmdvoglqCApeiOBVZ3PNkL59YeW X-Gm-Gg: ASbGncv4JzDQThTzGlDAZ39Y0K0eEYU7WSB/AQmwGMGeyb+d3V/7KGWKkeqVeamgfUk yApb39LhmSYVKqWChCmyuDk6wBTTJL5cxWBDSgfc43GV4nYRfNOXi8Zf5f1RJkrOFYV+R/fDIPU 2mYF9MeGhfNg8z5Idvpc/k78tDtG/MCTGXIImcm6FEDHzf9WsPszF5wMsVd1bDHEYPR0v9qCHv5 uGgV2TRZAc4LzPoVdSQpxuHXnXFGF8RUnTLqVhaPhZQyeIc/pLxXmJqUSwX9UbKQX+5LIBKe1Ev 47ltIN+5mvckZBnCT/FXj5Wgpk7Wyl0rRaxo X-Google-Smtp-Source: AGHT+IHTzGNN16mA3hpJreOiHYFjyZ3AeGJoP48E0laGo4020Qg/YZh8K/FYFaSVpFevtJH+vOQWPQ== X-Received: by 2002:a17:90b:5148:b0:2ee:c9b6:4c42 with SMTP id 98e67ed59e1d1-2fce86cf0ebmr42714472a91.16.1740636110407; Wed, 26 Feb 2025 22:01:50 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe824b67a1sm2728177a91.0.2025.02.26.22.01.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 22:01:50 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v5 2/5] i3c: master: svc: Add support for Nuvoton npcm845 i3c Date: Thu, 27 Feb 2025 14:01:28 +0800 Message-Id: <20250227060131.2206860-3-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250227060131.2206860-1-yschu@nuvoton.com> References: <20250227060131.2206860-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250226_220151_435289_4D995C67 X-CRM114-Status: GOOD ( 18.30 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu Nuvoton npcm845 SoC uses the same Silvico IP but an older version. Add quirks to address the npcm845 specific issues. FIFO empty issue: I3C HW stalls the write transfer if the transmit FIFO becomes empty, when new data is written to FIFO, I3C HW resumes the transfer but the first transmitted data bit may have the wrong value. Invalid SlvStart event: I3C HW may generate an invalid SlvStart event when emitting a STOP. DAA process corruption: When MCONFIG.SKEW=0 and MCONFIG.ODHPP=0, the ENTDAA transaction gets corrupted and results in a no repeated-start condition at the end of address assignment. Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 56 ++++++++++++++++++++++++++++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index d6057d8c7dec..9143a079de53 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -32,6 +32,7 @@ #define SVC_I3C_MCONFIG_ODBAUD(x) FIELD_PREP(GENMASK(23, 16), (x)) #define SVC_I3C_MCONFIG_ODHPP(x) FIELD_PREP(BIT(24), (x)) #define SVC_I3C_MCONFIG_SKEW(x) FIELD_PREP(GENMASK(27, 25), (x)) +#define SVC_I3C_MCONFIG_SKEW_MASK GENMASK(27, 25) #define SVC_I3C_MCONFIG_I2CBAUD(x) FIELD_PREP(GENMASK(31, 28), (x)) #define SVC_I3C_MCTRL 0x084 @@ -133,6 +134,32 @@ #define SVC_I3C_EVENT_IBI GENMASK(7, 0) #define SVC_I3C_EVENT_HOTJOIN BIT(31) +/* + * SVC_I3C_QUIRK_FIFO_EMPTY: + * I3C HW stalls the write transfer if the transmit FIFO becomes empty, + * when new data is written to FIFO, I3C HW resumes the transfer but + * the first transmitted data bit may have the wrong value. + * Workaround: + * Fill the FIFO in advance to prevent FIFO from becoming empty. + */ +#define SVC_I3C_QUIRK_FIFO_EMPTY BIT(0) +/* + * SVC_I3C_QUIRK_FLASE_SLVSTART: + * I3C HW may generate an invalid SlvStart event when emitting a STOP. + * If it is a true SlvStart, the MSTATUS state is SLVREQ. + */ +#define SVC_I3C_QUIRK_FALSE_SLVSTART BIT(1) +/* + * SVC_I3C_QUIRK_DAA_CORRUPT: + * When MCONFIG.SKEW=0 and MCONFIG.ODHPP=0, the ENTDAA transaction gets + * corrupted and results in a no repeated-start condition at the end of + * address assignment. + * Workaround: + * Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA + * process is completed, return MCONFIG.SKEW to its previous value. + */ +#define SVC_I3C_QUIRK_DAA_CORRUPT BIT(2) + struct svc_i3c_cmd { u8 addr; bool rnw; @@ -158,6 +185,10 @@ struct svc_i3c_regs_save { u32 mdynaddr; }; +struct svc_i3c_drvdata { + u32 quirks; +}; + /** * struct svc_i3c_master - Silvaco I3C Master structure * @base: I3C master controller @@ -183,6 +214,7 @@ struct svc_i3c_regs_save { * @ibi.tbq_slot: To be queued IBI slot * @ibi.lock: IBI lock * @lock: Transfer lock, protect between IBI work thread and callbacks from master + * @drvdata: Driver data * @enabled_events: Bit masks for enable events (IBI, HotJoin). * @mctrl_config: Configuration value in SVC_I3C_MCTRL for setting speed back. */ @@ -214,6 +246,7 @@ struct svc_i3c_master { spinlock_t lock; } ibi; struct mutex lock; + const struct svc_i3c_drvdata *drvdata; u32 enabled_events; u32 mctrl_config; }; @@ -230,6 +263,25 @@ struct svc_i3c_i2c_dev_data { struct i3c_generic_ibi_pool *ibi_pool; }; +const struct svc_i3c_drvdata svc_default_drvdata = {}; +const struct svc_i3c_drvdata npcm845_drvdata = { + .quirks = SVC_I3C_QUIRK_FIFO_EMPTY | + SVC_I3C_QUIRK_FALSE_SLVSTART | + SVC_I3C_QUIRK_DAA_CORRUPT, +}; + +static inline bool svc_has_quirk(struct svc_i3c_master *master, u32 quirk) +{ + return (master->drvdata->quirks & quirk); +} + +static inline bool svc_has_daa_corrupt(struct svc_i3c_master *master) +{ + return ((master->drvdata->quirks & SVC_I3C_QUIRK_DAA_CORRUPT) && + !(master->mctrl_config & + (SVC_I3C_MCONFIG_SKEW_MASK | SVC_I3C_MCONFIG_ODHPP(1)))); +} + static inline bool is_events_enabled(struct svc_i3c_master *master, u32 mask) { return !!(master->enabled_events & mask); @@ -1868,6 +1920,7 @@ static int svc_i3c_master_probe(struct platform_device *pdev) } platform_set_drvdata(pdev, master); + master->drvdata = of_device_get_match_data(dev); pm_runtime_set_autosuspend_delay(&pdev->dev, SVC_I3C_PM_TIMEOUT_MS); pm_runtime_use_autosuspend(&pdev->dev); @@ -1959,7 +2012,8 @@ static const struct dev_pm_ops svc_i3c_pm_ops = { }; static const struct of_device_id svc_i3c_master_of_match_tbl[] = { - { .compatible = "silvaco,i3c-master-v1"}, + { .compatible = "silvaco,i3c-master-v1", .data = &svc_default_drvdata }, + { .compatible = "nuvoton,npcm845-i3c", .data = &npcm845_drvdata }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl); From patchwork Thu Feb 27 06:01:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 13993792 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECE06C1B0FF for ; Thu, 27 Feb 2025 06:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QjaJzALrq325F/OaKREZHuZlLNinrGIETbxY7/c6pOg=; b=fbBJ6YHm6GqBnu v7I2msrGxLRH6+KryHet+BPmFPIKDj6+P1F7TVdyeha2NwNewiZD4CTase9tFkpJYE5jagSOMQPgj iMVyvKXqxAkXwYL6qWQcJoHnz4MQbxakmhyOo58+aOIx676xecCqfd618De8/HDXKE328l8izQLkb gDdLpAXcYPcyiYbyHzNdPHw9aJxwgpjq053IWmvxoW/nFDt1jr/vPJ6aqpHtUKabYg9kkfJDJHuwN guhFj8U667G7ThsUqq06b69afhK9uV6O/AkqRij8Lm7aGEbUijVSYg0ulANfCKGmQaWFxWhG1zAya 38g+GIK20gDsZNb3i/OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnX0K-00000006RdX-26Tb; Thu, 27 Feb 2025 06:04:16 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnWy2-00000006R8h-1dFk for linux-i3c@lists.infradead.org; Thu, 27 Feb 2025 06:01:55 +0000 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-2fe98d173daso983658a91.1 for ; Wed, 26 Feb 2025 22:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740636113; x=1741240913; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jkvj3L9bGHMjbRbwPbZT9vYFOnv0oJXGKH8ygdTiAFw=; b=Sju4ds40PYeRzVKJ/9rV6Paj4coTXQFi2PTnRiJ8I6nFqO7uy1/dn/VT3lK1vKVBhC HRs08Py1WH4UqKHuqCXt89iWOHmD98n/CeoPqnKQt00f/AahG9DLTmkAphO8ZmN9FXRW qpLtBrB+8EoaixhXxh6n/A6s7erwINYJm+8v3QzK6oRfsxDt/N/tKpT1KFScfsNu0c+h E+U6Cvjh3I/VivLTTWPgSLOL0pUDvWyBCuZxMZNImLEgNZh8VzHPgTkOFUMJ6uhstbrN +ftvVvH5PaI2EHEDz5zVYk3OcvfdPhmhvtaHkFAzbzqUKQcQG/BSPAxSnh3DEuwn3cbB HTdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740636113; x=1741240913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jkvj3L9bGHMjbRbwPbZT9vYFOnv0oJXGKH8ygdTiAFw=; b=ngFNcnQXmIXPW2sCGiYejRKCjyATIh1os7geiEMKEA9AsNSMg81EMSAIgIWpQZqdym QvEmancvPHgcCTyuxU16YIHNYEkZKOdE/ZXGs7GpnntPxQFYSf3Bea2FvfLE4r2IDUYn bT8AJwR0HozzY1tn3YfcF2lzbq7GK2MGsDDSxYenCUhGa6vS0+YQPwrNRNQ5zq0DdN6q vMpnbdowHrc4nyqmtyLTO0kRChnv11EfOBt2mY+U2/jnIkjGy0tplyxaIzitsGcJuUx9 Qj23VynMWxDHApeRo8fE1h5OwWv7B3RmGKpe1qZ2UfSjN6116O02NdMBkge/RUqM5CEq Yctg== X-Forwarded-Encrypted: i=1; AJvYcCU8J/ugclG9PMoFRGaz3e4LU5nqmAfEFxfPu3dU7PUJ0jw2aE6/0CgB31m2edcouroWbJyalJeOheM=@lists.infradead.org X-Gm-Message-State: AOJu0Ywz6uRWZf9roVqFtJLV0IoV5FixSk/rcqxnb8vFBx3jbT/9hVYi BOXJ6sWELJiMZLe0vtuEdVBPqFZ8+Ao8I3rrWIMypaxFATkAMTqU X-Gm-Gg: ASbGncsmEaXWljoeA8LPa2+CdlQ+wKHOZhJxZ9ZgptWrbrbGGGK512TMg3Cq7IDw786 WYAyEzAdbNmDNb8FzrkQ4dz3S3P6xT6Wz14s+GtPr10N5ZdK/c/bRRQ464VHKWMN6IjhfSq+oma BzMIvhBFGLsrkLImPQuZJOrwoP8PBU6HI8r4IFtTXRqm3o6HksOnPdEQagaTehnrpA7uDQL/ZiR KY/uiRIdcIwB3Ufc9eRYfDJN1RWKZZ/I09zDzFI0hwdZF8PLMBk/iIp/d9d8Dhzr6nciWS3Fdf8 DFrqXt5FyN4uakouVE8pv9EaDv7L9W8YZVSt X-Google-Smtp-Source: AGHT+IGJf1EprWbsXZ2jFkUl5sHahMq3HVyinxDfNpi1XqlJ5NGR7aG6ByojzGWqVWyAfi7gUIv7zQ== X-Received: by 2002:a17:90b:1f81:b0:2ee:d433:7c50 with SMTP id 98e67ed59e1d1-2fce873af2cmr32572563a91.23.1740636113433; Wed, 26 Feb 2025 22:01:53 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe824b67a1sm2728177a91.0.2025.02.26.22.01.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 22:01:53 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v5 3/5] i3c: master: svc: Fix npcm845 FIFO empty issue Date: Thu, 27 Feb 2025 14:01:29 +0800 Message-Id: <20250227060131.2206860-4-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250227060131.2206860-1-yschu@nuvoton.com> References: <20250227060131.2206860-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250226_220154_436669_FAD3B999 X-CRM114-Status: GOOD ( 19.28 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu I3C HW stalls the write transfer if the transmit FIFO becomes empty, when new data is written to FIFO, I3C HW resumes the transfer but the first transmitted data bit may have the wrong value. Fill the FIFO in advance to prevent FIFO from becoming empty. Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 52 ++++++++++++++++++++++++----- 1 file changed, 43 insertions(+), 9 deletions(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 9143a079de53..a0c6d8053a25 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -114,6 +114,7 @@ #define SVC_I3C_MWDATAHE 0x0BC #define SVC_I3C_MRDATAB 0x0C0 #define SVC_I3C_MRDATAH 0x0C8 +#define SVC_I3C_MWDATAB1 0x0CC #define SVC_I3C_MWMSG_SDR 0x0D0 #define SVC_I3C_MRMSG_SDR 0x0D4 #define SVC_I3C_MWMSG_DDR 0x0D8 @@ -940,7 +941,7 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master, u8 *addrs, unsigned int *count) { u64 prov_id[SVC_I3C_MAX_DEVS] = {}, nacking_prov_id = 0; - unsigned int dev_nb = 0, last_addr = 0; + unsigned int dev_nb = 0, last_addr = 0, dyn_addr; u32 reg; int ret, i; @@ -983,6 +984,25 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master, if (SVC_I3C_MSTATUS_RXPEND(reg)) { u8 data[6]; + /* + * One slave sends its ID to request for address assignment, + * prefilling the dynamic address can reduce SCL clock stalls + * and also fix the SVC_I3C_QUIRK_FIFO_EMPTY quirk. + * + * Ideally, prefilling before the processDAA command is better. + * However, it requires an additional check to write the dyn_addr + * at the right time because the driver needs to write the processDAA + * command twice for one assignment. + * Prefilling here is safe and efficient because the FIFO starts + * filling within a few hundred nanoseconds, which is significantly + * faster compared to the 64 SCL clock cycles. + */ + dyn_addr = i3c_master_get_free_addr(&master->base, last_addr + 1); + if (dyn_addr < 0) + return -ENOSPC; + + writel(dyn_addr, master->regs + SVC_I3C_MWDATAB); + /* * We only care about the 48-bit provisioned ID yet to * be sure a device does not nack an address twice. @@ -1061,21 +1081,16 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master, if (ret) break; - /* Give the slave device a suitable dynamic address */ - ret = i3c_master_get_free_addr(&master->base, last_addr + 1); - if (ret < 0) - break; - - addrs[dev_nb] = ret; + addrs[dev_nb] = dyn_addr; dev_dbg(master->dev, "DAA: device %d assigned to 0x%02x\n", dev_nb, addrs[dev_nb]); - - writel(addrs[dev_nb], master->regs + SVC_I3C_MWDATAB); last_addr = addrs[dev_nb++]; } /* Need manual issue STOP except for Complete condition */ svc_i3c_master_emit_stop(master); + svc_i3c_master_flush_fifo(master); + return ret; } @@ -1272,6 +1287,24 @@ static int svc_i3c_master_xfer(struct svc_i3c_master *master, SVC_I3C_MCTRL_RDTERM(*actual_len), master->regs + SVC_I3C_MCTRL); + /* + * The entire transaction can consist of multiple write transfers. + * Prefilling before EmitStartAddr causes the data to be emitted + * immediately, becoming part of the previous transfer. + * The only way to work around this hardware issue is to let the + * FIFO start filling as soon as possible after EmitStartAddr. + */ + if (svc_has_quirk(master, SVC_I3C_QUIRK_FIFO_EMPTY) && !rnw && xfer_len) { + u32 end = xfer_len > SVC_I3C_FIFO_SIZE ? 0 : BIT(8); + u32 len = min_t(u32, xfer_len, SVC_I3C_FIFO_SIZE); + + writesb(master->regs + SVC_I3C_MWDATAB1, out, len - 1); + /* Mark END bit if this is the last byte */ + writel(out[len - 1] | end, master->regs + SVC_I3C_MWDATAB); + xfer_len -= len; + out += len; + } + ret = readl_poll_timeout(master->regs + SVC_I3C_MSTATUS, reg, SVC_I3C_MSTATUS_MCTRLDONE(reg), 0, 1000); if (ret) @@ -1360,6 +1393,7 @@ static int svc_i3c_master_xfer(struct svc_i3c_master *master, emit_stop: svc_i3c_master_emit_stop(master); svc_i3c_master_clear_merrwarn(master); + svc_i3c_master_flush_fifo(master); return ret; } From patchwork Thu Feb 27 06:01:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 13993791 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15210C282C1 for ; Thu, 27 Feb 2025 06:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sqpgqmwzHE852tWECXes6y+7HRQe1DO4RZLTLuwR4Hw=; b=aV/D0BREXuK7Tr MEtDlcmNsoM8IuIpRcOW0eRIKLwZYrmVUOc1JX35xn8ob++MwlljfQCxl5UwA70iIIVuykoIbOYEV t2FCvSsTDtgOvupbPppkOlWJ9bDHJCQLSYD22q1dPyaFbS7CrVuyT0Pq2yJF+1pMOi4Mjyy2QMpZu 5ArZk/zXezYyJexS5iNd8056pkkBAXusSBJlEowvMtZzb2VndmgdK+xbBnYqfnz8bI0ZuztRjf768 EYfmflGi6H1e5vSAoR0vLZXk8LkiVrFRswb9gCPSz+phBsn6VlMN3gm0JeRunOt41msUxx/xu9FvT efwsYjEQxntuEOHCBKtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnX0K-00000006Re9-3W3b; Thu, 27 Feb 2025 06:04:16 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnWy5-00000006R9i-2Jjg for linux-i3c@lists.infradead.org; Thu, 27 Feb 2025 06:01:58 +0000 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2fc3db58932so932345a91.2 for ; Wed, 26 Feb 2025 22:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740636116; x=1741240916; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tfcsKyxsqqNF1ObsRkAL+Fr53iDPz5SE+sP10CWPKmY=; b=DZuyMJSXdvnQNtibm/7KEhjVxy86UgyRtEZGllhtX2ryRprR1bz/LfBgKkhPEB9dIY ByOYDfA/HfHcA+oZn2MXSCowTZuCRfmlsr+vPNYlsM+CU1El0Rdxh9boRCZWoWIvvJ0y SAFkpkejtLNfuIBqpm9AeWhjNH2rkUZtxYYIKDFuUfQjVWEU66UAlkKW77kDJvW3ovbK 16zJasu5QefEOpj1RF2oKZeunk7jJisuWJ59eSHJaJwRUrFDjm109j+Sg4EtfTor67oQ BG+2b0QMFWQ5gm2xDkgXWYGlMCHCY4aYXHIyBrqVQztRmxEyn7ZEoKRyDOK6XtQVhuHI ugFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740636116; x=1741240916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tfcsKyxsqqNF1ObsRkAL+Fr53iDPz5SE+sP10CWPKmY=; b=Fn0W+BXZduIdbqaZaMx3Yt5RRSDActhGSG/W9ND412I29ZRQtBShRTDG5zRkzFUCdW vUig2qEBKB9qLdzt+XMmu64fO3DAWzo2Hs3haodVViay4zawWmhRW3w5ppu28z6D2Sz9 AJSw1Ha6Q7EY606Au9J2A1mWOLseRty5xsXYAFf3bewyHl+mKmjl16nJA0QzIqOffAwk AZb2LPwkKgt7zj+s8aJj8dB8MuLaptWIBbPmKLs/ANaZ5sJyPoKANIyegx9AQxnlb5lO ANHJWE5fJ+6vM12qQ7e+DSM90yzgeH1byvuAKARwF/W4RmhkKaI/9X1LGX+M5fRZEvVz oosQ== X-Forwarded-Encrypted: i=1; AJvYcCVbdgOmH6eRP5G7tz0fJeubpK5Edqk6jLDJvnDA8T0U4H0gXvphbw+jzmbv3fwDdcp97Nnsz0NOEtg=@lists.infradead.org X-Gm-Message-State: AOJu0YwzwaO2dNCGGGvZLDMysj0SloqLsTeqN8gdFELMhloo5Xa3AiYa 9aYsZTebuArVeinbRadBdAW40sOb20iChZ0LsE+SQaB+4dcH2ZIU X-Gm-Gg: ASbGncseQB77gCyVhC3Va1RN2MUQSbNpPI3C3JMvSnzUqUkXplEWCfrVqHWoycMynN6 pIokonFvOq7Tnors7UegqYygDdGc+qwvil9UCci7AwEmbENPkswfEJ4GmYf8qfs126rgYH0cTb7 e9Vg+vcVza6+8OB2IhUtf2F2vUGXBzWiVlCvEDo5ZY9GHSYnZkRo/m/HoYDSv78RB7CQGgVrEUd dUXYeO29o7mLQhLsX4EtXkYqYx/nJ0iUjmh/ouhebnO8neYooBV5wwam818zpZ8FgYyR4exqEtr MAKcGkdfZ6srpO4g7SAYlZKHkA3rgE3XTaRg X-Google-Smtp-Source: AGHT+IE958nyxT/MQ1RXRPl3RO6BV1mQ+QuBOyNiN7aTAS3Jr7cbgeA5uuT5xa5jaBuU3GsTGvI1Fg== X-Received: by 2002:a17:90b:1808:b0:2fe:9e6c:add9 with SMTP id 98e67ed59e1d1-2fe9e6cb035mr4296027a91.18.1740636116626; Wed, 26 Feb 2025 22:01:56 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe824b67a1sm2728177a91.0.2025.02.26.22.01.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 22:01:56 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com, Frank Li Subject: [PATCH v5 4/5] i3c: master: svc: Fix npcm845 invalid slvstart event Date: Thu, 27 Feb 2025 14:01:30 +0800 Message-Id: <20250227060131.2206860-5-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250227060131.2206860-1-yschu@nuvoton.com> References: <20250227060131.2206860-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250226_220157_589895_FEDE66F2 X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu I3C HW may generate an invalid SlvStart event when emitting a STOP. If it is a true SlvStart, the MSTATUS state is SLVREQ. Check the MSTATUS state to ignore the false event. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index a0c6d8053a25..952afc75f6e4 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -59,6 +59,7 @@ #define SVC_I3C_MSTATUS 0x088 #define SVC_I3C_MSTATUS_STATE(x) FIELD_GET(GENMASK(2, 0), (x)) #define SVC_I3C_MSTATUS_STATE_DAA(x) (SVC_I3C_MSTATUS_STATE(x) == 5) +#define SVC_I3C_MSTATUS_STATE_SLVREQ(x) (SVC_I3C_MSTATUS_STATE(x) == 1) #define SVC_I3C_MSTATUS_STATE_IDLE(x) (SVC_I3C_MSTATUS_STATE(x) == 0) #define SVC_I3C_MSTATUS_BETWEEN(x) FIELD_GET(BIT(4), (x)) #define SVC_I3C_MSTATUS_NACKED(x) FIELD_GET(BIT(5), (x)) @@ -617,6 +618,11 @@ static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id) /* Clear the interrupt status */ writel(SVC_I3C_MINT_SLVSTART, master->regs + SVC_I3C_MSTATUS); + /* Ignore the false event */ + if (svc_has_quirk(master, SVC_I3C_QUIRK_FALSE_SLVSTART) && + !SVC_I3C_MSTATUS_STATE_SLVREQ(active)) + return IRQ_HANDLED; + svc_i3c_master_disable_interrupts(master); /* Handle the interrupt in a non atomic context */ From patchwork Thu Feb 27 06:01:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 13993793 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86067C282C2 for ; Thu, 27 Feb 2025 06:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s/3ayrnY/pshmgHNm0B59pvmsgJAlF/RdaTaEEDfSpw=; b=ITKud+QWguWLbI GULE0RpGcHhgGz2osKJjI56QoNAhYahhsBSw4QsOngi+I9vEw/EQEnsVLi1Os8n67UEQ28E6QhULA CY+R3DFHkjLuFD/N5GmdVq6M2w7P51eajMIICj6NUgbfeebdZHudU0N39Q2ojyKyqiefuswH7XWxw cnfiYrAs0IcaGrLlYt/EHHVV6c5P6jpYe6aH1xD+Pvy4/tD1fMYYO7AfZd6YVgAvYdhf2o/EDHoLc OFIrlXXNYaZwbu7PfhP2duC9vJyVjEmsN/TJc5K1bHDj6tGubRigaCgCYG1VoVIgH8yWRafTj2f47 7VWetKNJbGqy9aWo4kKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnX0L-00000006ReM-0csZ; Thu, 27 Feb 2025 06:04:17 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnWy8-00000006RB6-3C0k for linux-i3c@lists.infradead.org; Thu, 27 Feb 2025 06:02:01 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-220c8f38febso8876625ad.2 for ; Wed, 26 Feb 2025 22:02:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740636120; x=1741240920; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3OREH+iLC47dZ2hUuoqhiGCsdCQC5cRnPwerNbjmWOc=; b=b2dV0oARmmDPerY9f5XO8cQT2LxxXnwCueM3QCGUF3APR8DY6k17YvPE6D4b4m1Nv/ +FHq2vph4LKMotSlD6y0LNSUYVYZ913Z4r8uEZLD7fYvWQPDVb0KJQs/zI/5GlvnRSiH MZWkfUgRk3TT3YFKh47lb4mg4dG/2bdinLgLME9fr+eAjR5FrjDPpugLsk8iFY+4pl/G SWLzurN147Put3psNzv7Y1R/wxFde9CjR87TsTaZwfLh2HKcCH1Heud3yDsRgOVzP7c3 1+XI2sSv78BNQ8ATLdIW0cU5fzHvAEjbLRzQ7WOTe3xukApo5S2hs/tUSOW/1O/kuuKR /Iew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740636120; x=1741240920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3OREH+iLC47dZ2hUuoqhiGCsdCQC5cRnPwerNbjmWOc=; b=pabTCQaJvesOPKoSwz59DyIg0AKWa7EPRmDZNBeEM3p5ReR+F0HCj1tBedzPOPrFkC v95pzntwBZwfP8+FiRv0LpArX6CQ6/tCEgBx4vDhEqOJVTpCaoNstQ31s7iJk1Stxscb yuNMqvFTtENb9R7Z5E26cFX/+OFq9zTuyHCfsQOqD+ziepabWHLMMIa4Y+/0r7gYd9fH fTAR/KzeaFIt/mVExDzoYyAFKGdLJNwfvyI6v6MWVAHC3yb4UwXg8zCkVgjy/hPUc37D /YOVqzsppIXgCILv4dfSzI1fEKNLCy4nVoRAYY8564hRvOZy4LLFHY8GtY1X+PZPnMHo xb1w== X-Forwarded-Encrypted: i=1; AJvYcCXYLo3tnXzwkFyNRNN1ymx7mM998gJGizhLqwY4UDADrFBSjGZxkrwQ1iDWY02G1LX6roN+0tQK8oE=@lists.infradead.org X-Gm-Message-State: AOJu0YykUy3GS84TTMvv+rtselWc2jIvYr23w18ehfRvmblfzk1aYOU9 gry60GMGOLMSxzPZ+we/Qi7YxIqhnK5wTA0nlXpMxt5hI4YvQWP6 X-Gm-Gg: ASbGnctk7WK5ggLx3cEaEffyp3ZfF3f+9NtpD07TR61n/pPrmlnMw8ANArnUoTz0FQR MoiKFro10va2ZWKW8MRWo48wbsrlyeggafrtA/+Y4uMlQB4SoDLlEOXbksvATsz8ts4LCiFwswC U+/Zs4nzBG1hXbz0n/20hpwADQNHY/Bn2zupBQpxAusUmB26bF0ZmycvTKFf+J5awsSlbeVjRdt KhW6m69F3LcVsm+xywAncRsIgzL0uEalcFlL6ekpaV4Ym2EvQN0nP2O0F2utrCGS0K2Md4sGJ8J 0cdX3pOzMWkRuwk1nfJeAcUzr9VVeObZJhS2 X-Google-Smtp-Source: AGHT+IEqIBEjElcYfutyZm2+ie7egiFz7kMRAMyX+Q/RVxplxMI9mjXMEKkY217XYnf9eGB2wXWsGg== X-Received: by 2002:a17:902:d502:b0:21a:8300:b9ce with SMTP id d9443c01a7336-221a002afb5mr415841785ad.49.1740636119772; Wed, 26 Feb 2025 22:01:59 -0800 (PST) Received: from cs20-buildserver.lan ([2403:c300:cd02:bc36:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fe824b67a1sm2728177a91.0.2025.02.26.22.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 22:01:59 -0800 (PST) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com, Frank Li Subject: [PATCH v5 5/5] i3c: master: svc: Fix npcm845 DAA process corruption Date: Thu, 27 Feb 2025 14:01:31 +0800 Message-Id: <20250227060131.2206860-6-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250227060131.2206860-1-yschu@nuvoton.com> References: <20250227060131.2206860-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250226_220200_797144_89D10099 X-CRM114-Status: UNSURE ( 7.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu When MCONFIG.SKEW=0 and MCONFIG.ODHPP=0, the ENTDAA transaction gets corrupted and results in a no repeated-start condition at the end of address assignment. Workaround: Set MCONFIG.SKEW to 1 before initiating the DAA process. After the DAA process is completed, return MCONFIG.SKEW to its previous value. Reviewed-by: Frank Li Signed-off-by: Stanley Chu --- drivers/i3c/master/svc-i3c-master.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 952afc75f6e4..774f94ee761c 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1169,7 +1169,16 @@ static int svc_i3c_master_do_daa(struct i3c_master_controller *m) } spin_lock_irqsave(&master->xferqueue.lock, flags); + + if (svc_has_daa_corrupt(master)) + writel(master->mctrl_config | SVC_I3C_MCONFIG_SKEW(1), + master->regs + SVC_I3C_MCONFIG); + ret = svc_i3c_master_do_daa_locked(master, addrs, &dev_nb); + + if (svc_has_daa_corrupt(master)) + writel(master->mctrl_config, master->regs + SVC_I3C_MCONFIG); + spin_unlock_irqrestore(&master->xferqueue.lock, flags); svc_i3c_master_clear_merrwarn(master);