From patchwork Fri Feb 28 06:28:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 13995770 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D8BE1C3F04; Fri, 28 Feb 2025 06:28:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724110; cv=none; b=daViLffosBECh80UxfIRGbsg8TwUapN+0U+e05K1yJ3U4M9VNoW0803qrYX2AU4RvUiCFojkGjlwpCcd2I9gJGHmvm7J7HGhrDonoyXx0x57I06rBALks4ppKzBlqHVnDFDBmWrbwvoq9i6vXAOjWZGAmRVYqv63t9GIGS7Pr8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724110; c=relaxed/simple; bh=/m+iPWmk6kJV3QtWKryVvX1MLMg/lAVfhh9LHnQYHeM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=ByTD3xNDth1Sx/mqwMmo77XQCAyw79WvFQ1GRPsTnmFBh1drwcQl08JN/tHixV3YAABmxfX96VYfp8EKutTsxbCIrJgDN5QqljreXRc6ZWE/6WyNvXKh2l66tFJ0DjbdiLn3gdVlTuzC4mZjiFiXCJYGwLAqlkB/DnLk0LIrKXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Ol+CDSdK; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ol+CDSdK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740724108; x=1772260108; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/m+iPWmk6kJV3QtWKryVvX1MLMg/lAVfhh9LHnQYHeM=; b=Ol+CDSdKJX2hg9IRdDf+JEWKxSdvM0BudrhDFr42hH9OC5TZ7x6Z5jyA eSSIUqLG0IcA7U3qQPqmz9SMjQEVZcZY26TrBc370IQLIxRUsmmbqXHFe LDYOHN7pJov4jRCQKZCLeg/8sLCHebN1V+J7c592LtZlgiGq7nc1iR1pX XH4Pwq4HVMkTQrH63ZdLAcLcwr5Lpg9CimMkphKf1ZrChVf6GFfVt7iYS JiVKxfDATd2Wuz01hNYTZSsBq2YPwav5J/7feBKPoObYX8eT2JZXZ68lj ZNZzEgA0jumNYiuW412q9xnyZicRshDA23lZDUGKcMlzVRv+0den+EMoN Q==; X-CSE-ConnectionGUID: qMf+xPuOSHKfXzD8Hv95ZA== X-CSE-MsgGUID: WtTjMFCzStCZ3qJODaIMxw== X-IronPort-AV: E=McAfee;i="6700,10204,11358"; a="41560574" X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="41560574" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2025 22:28:28 -0800 X-CSE-ConnectionGUID: V8HVlAwJTKy2pOmvOgzNFg== X-CSE-MsgGUID: PyVto1ESQPWeZ2+SFMaQPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="122265233" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by orviesa004.jf.intel.com with ESMTP; 27 Feb 2025 22:28:22 -0800 From: Raag Jadav To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com, andriy.shevchenko@linux.intel.com, cezary.rojewski@intel.com, amadeuszx.slawinski@linux.intel.com, shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com, jbrunet@baylibre.com, neil.armstrong@linaro.org, khilman@baylibre.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Raag Jadav , Linus Walleij Subject: [PATCH v2 1/6] ASoC: Intel: avs: use devm_kmemdup_array() Date: Fri, 28 Feb 2025 11:58:07 +0530 Message-Id: <20250228062812.150004-2-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250228062812.150004-1-raag.jadav@intel.com> References: <20250228062812.150004-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert to use devm_kmemdup_array() and while at it, use source size instead of destination. Signed-off-by: Raag Jadav Acked-by: Mark Brown Reviewed-by: Amadeusz Sławiński Reviewed-by: Linus Walleij --- sound/soc/intel/avs/boards/da7219.c | 3 ++- sound/soc/intel/avs/boards/es8336.c | 3 ++- sound/soc/intel/avs/boards/nau8825.c | 3 ++- sound/soc/intel/avs/boards/rt274.c | 3 ++- sound/soc/intel/avs/boards/rt286.c | 3 ++- sound/soc/intel/avs/boards/rt298.c | 3 ++- sound/soc/intel/avs/boards/rt5663.c | 3 ++- sound/soc/intel/avs/boards/rt5682.c | 3 ++- 8 files changed, 16 insertions(+), 8 deletions(-) diff --git a/sound/soc/intel/avs/boards/da7219.c b/sound/soc/intel/avs/boards/da7219.c index 76078a7005b0..9507a96f26ac 100644 --- a/sound/soc/intel/avs/boards/da7219.c +++ b/sound/soc/intel/avs/boards/da7219.c @@ -113,7 +113,8 @@ static int avs_da7219_codec_init(struct snd_soc_pcm_runtime *runtime) } num_pins = ARRAY_SIZE(card_headset_pins); - pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL); + pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins, + sizeof(card_headset_pins[0]), GFP_KERNEL); if (!pins) return -ENOMEM; diff --git a/sound/soc/intel/avs/boards/es8336.c b/sound/soc/intel/avs/boards/es8336.c index 426ce37105ae..6f3c4f6c9302 100644 --- a/sound/soc/intel/avs/boards/es8336.c +++ b/sound/soc/intel/avs/boards/es8336.c @@ -109,7 +109,8 @@ static int avs_es8336_codec_init(struct snd_soc_pcm_runtime *runtime) data = snd_soc_card_get_drvdata(card); num_pins = ARRAY_SIZE(card_headset_pins); - pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL); + pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins, + sizeof(card_headset_pins[0]), GFP_KERNEL); if (!pins) return -ENOMEM; diff --git a/sound/soc/intel/avs/boards/nau8825.c b/sound/soc/intel/avs/boards/nau8825.c index bf902540744c..6833eebd82d6 100644 --- a/sound/soc/intel/avs/boards/nau8825.c +++ b/sound/soc/intel/avs/boards/nau8825.c @@ -88,7 +88,8 @@ static int avs_nau8825_codec_init(struct snd_soc_pcm_runtime *runtime) jack = snd_soc_card_get_drvdata(card); num_pins = ARRAY_SIZE(card_headset_pins); - pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL); + pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins, + sizeof(card_headset_pins[0]), GFP_KERNEL); if (!pins) return -ENOMEM; diff --git a/sound/soc/intel/avs/boards/rt274.c b/sound/soc/intel/avs/boards/rt274.c index 4b6c02a40204..f5caafc21861 100644 --- a/sound/soc/intel/avs/boards/rt274.c +++ b/sound/soc/intel/avs/boards/rt274.c @@ -98,7 +98,8 @@ static int avs_rt274_codec_init(struct snd_soc_pcm_runtime *runtime) jack = snd_soc_card_get_drvdata(card); num_pins = ARRAY_SIZE(card_headset_pins); - pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL); + pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins, + sizeof(card_headset_pins[0]), GFP_KERNEL); if (!pins) return -ENOMEM; diff --git a/sound/soc/intel/avs/boards/rt286.c b/sound/soc/intel/avs/boards/rt286.c index e40563ca99fd..1eb0399c0fae 100644 --- a/sound/soc/intel/avs/boards/rt286.c +++ b/sound/soc/intel/avs/boards/rt286.c @@ -59,7 +59,8 @@ static int avs_rt286_codec_init(struct snd_soc_pcm_runtime *runtime) jack = snd_soc_card_get_drvdata(card); num_pins = ARRAY_SIZE(card_headset_pins); - pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL); + pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins, + sizeof(card_headset_pins[0]), GFP_KERNEL); if (!pins) return -ENOMEM; diff --git a/sound/soc/intel/avs/boards/rt298.c b/sound/soc/intel/avs/boards/rt298.c index 94fce07c83f9..85269a3be981 100644 --- a/sound/soc/intel/avs/boards/rt298.c +++ b/sound/soc/intel/avs/boards/rt298.c @@ -70,7 +70,8 @@ static int avs_rt298_codec_init(struct snd_soc_pcm_runtime *runtime) jack = snd_soc_card_get_drvdata(card); num_pins = ARRAY_SIZE(card_headset_pins); - pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL); + pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins, + sizeof(card_headset_pins[0]), GFP_KERNEL); if (!pins) return -ENOMEM; diff --git a/sound/soc/intel/avs/boards/rt5663.c b/sound/soc/intel/avs/boards/rt5663.c index b456b9d14665..e3310b3268ba 100644 --- a/sound/soc/intel/avs/boards/rt5663.c +++ b/sound/soc/intel/avs/boards/rt5663.c @@ -65,7 +65,8 @@ static int avs_rt5663_codec_init(struct snd_soc_pcm_runtime *runtime) jack = &priv->jack; num_pins = ARRAY_SIZE(card_headset_pins); - pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL); + pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins, + sizeof(card_headset_pins[0]), GFP_KERNEL); if (!pins) return -ENOMEM; diff --git a/sound/soc/intel/avs/boards/rt5682.c b/sound/soc/intel/avs/boards/rt5682.c index 335960cfd7ba..339df0b944c1 100644 --- a/sound/soc/intel/avs/boards/rt5682.c +++ b/sound/soc/intel/avs/boards/rt5682.c @@ -102,7 +102,8 @@ static int avs_rt5682_codec_init(struct snd_soc_pcm_runtime *runtime) jack = snd_soc_card_get_drvdata(card); num_pins = ARRAY_SIZE(card_jack_pins); - pins = devm_kmemdup(card->dev, card_jack_pins, sizeof(*pins) * num_pins, GFP_KERNEL); + pins = devm_kmemdup_array(card->dev, card_jack_pins, num_pins, + sizeof(card_jack_pins[0]), GFP_KERNEL); if (!pins) return -ENOMEM; From patchwork Fri Feb 28 06:28:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 13995771 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 362DE1C3C0F; Fri, 28 Feb 2025 06:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724115; cv=none; b=LXoFvJbLDQgSReHRS/H/fg6/d9YQYlo75G8/8z6oL5lasbfDPGo7WCx5glTQHU0z/Pu1+MaY6hApa6e+R9gq225kTrfNVqIRVSZnbpbvPwOMYelnq/x2JjI9nkFddkw1/0KlT8VvLd7acK8dwBvQGaGDRFCbf7a7ru+P4VSWXPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724115; c=relaxed/simple; bh=AUJvMFsICvoCmVfWj5JN11a/sKwael8x29G4HCF3zLY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=H4op/Ta6DFHw1WBd9SCob4ssQpxL5J81+f7hfypDeH1tu4M4sTuSJUmnLJxOtSFde7MMh9t68nbYgGwLo1l+yJAbq6b/FwaL0zGv7T0ppwrAIlsEF3sq1+XHUaaCRn92aArHqVHZKFH39TCHxXqjPzUOilAa1eKhjSiThnHNAGg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Lms55KFZ; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Lms55KFZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740724114; x=1772260114; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AUJvMFsICvoCmVfWj5JN11a/sKwael8x29G4HCF3zLY=; b=Lms55KFZ8pzOq9lZYxuOb4+/G+fbmUHP2lXi6HBE7iz3IiNRmmIBtgvi Cp1Y5T9jz99sayvskDjrJy0O5fDfKlP+Uz0pAP3umHcWZE5MuAmANjkCb WmigQ8WAOymnrZWg7SM2y5GDSqbDBVgwidgGJndWB5wsCBgThS6oQKP6y 6RwQV36lhfy5wMbnQEyOJv+5XPnt8XfmWPtw9dvsqmJMjREL+eX9u+hPu jTO4I4het4CtCt9udXAcZOw9BVJJFkF8mMcZB3ggZWVRcr9WmoREE5dNY sSOUpzRMq3VCehRMYuiaZ+dWihxwAuPyOvxrO72aDNUTA2PhZf7UVYiZZ A==; X-CSE-ConnectionGUID: rhNPxpCLTESKcN0pDIccyw== X-CSE-MsgGUID: 79vTxGR8R7qmprp5OZ32rA== X-IronPort-AV: E=McAfee;i="6700,10204,11358"; a="41560585" X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="41560585" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2025 22:28:34 -0800 X-CSE-ConnectionGUID: iwnW2x5ATfyJwdWnnr8JBA== X-CSE-MsgGUID: djKSmC+hQfeb2rQ6oJ0Pbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="122265267" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by orviesa004.jf.intel.com with ESMTP; 27 Feb 2025 22:28:28 -0800 From: Raag Jadav To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com, andriy.shevchenko@linux.intel.com, cezary.rojewski@intel.com, amadeuszx.slawinski@linux.intel.com, shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com, jbrunet@baylibre.com, neil.armstrong@linaro.org, khilman@baylibre.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Raag Jadav Subject: [PATCH v2 2/6] ASoC: hdac_hdmi: use devm_kmemdup_array() Date: Fri, 28 Feb 2025 11:58:08 +0530 Message-Id: <20250228062812.150004-3-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250228062812.150004-1-raag.jadav@intel.com> References: <20250228062812.150004-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert to use devm_kmemdup_array() and while at it, make the size robust against type changes. Signed-off-by: Raag Jadav --- sound/soc/codecs/hdac_hdmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c index e1a7f0b0c0f3..3bea5d09219a 100644 --- a/sound/soc/codecs/hdac_hdmi.c +++ b/sound/soc/codecs/hdac_hdmi.c @@ -1017,8 +1017,7 @@ static int hdac_hdmi_create_pin_port_muxs(struct hdac_device *hdev, return -ENOMEM; } - se->texts = devm_kmemdup(&hdev->dev, items, - (num_items * sizeof(char *)), GFP_KERNEL); + se->texts = devm_kmemdup_array(&hdev->dev, items, num_items, sizeof(items[0]), GFP_KERNEL); if (!se->texts) return -ENOMEM; From patchwork Fri Feb 28 06:28:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 13995772 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA1011C5485; Fri, 28 Feb 2025 06:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724121; cv=none; b=rxAlBZwo8uOHn4XW7huJ6VPEmTP/iXEni+j+wt6byb85woSnzlBW8zxnOUeDbSWNxgfxlmDbh8fYudAMjHyOkTAA+e+faW89giF1KXfPV7uJFAqzQhphFwdelspwkZvH4m52CB4s7BM/AQKyLyF1ko8QQzMVOjwGkmHrkgNgz+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724121; c=relaxed/simple; bh=NSXN9VYfQFUizYJYR++h6usWkL8OeRS3X1QV/7FBf64=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ch9S3SajrKq7UBqVk57/CklwPvDML4ofeG6BcywT/yjZLxlrH4CCRnQqA8N7YgUQoDTZekHjSXaBBreznibZrTUcvAdiUCNtCn7QcvbcmqCJjSBbtljMX5c5v1LYPo6Na15MDLiBMEgbDMXqnIodgAhYEjbdGEYPRdrJw0jaMSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=d2snQm+p; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="d2snQm+p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740724120; x=1772260120; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NSXN9VYfQFUizYJYR++h6usWkL8OeRS3X1QV/7FBf64=; b=d2snQm+pMM+IHTToIwxlPqQxsHSxo7ZeWxmQHPTyHlvc4Jm46RgXWQJw b0uCcTxIFuaLyOcUh2CZ5PWMZ/l/XS+MVAezueNG02SUG/F/BF4EZvthr ABWLzGfTxUc352E/tmqOzEFOBeXubezrndO/olyxjBnDnmot/+MZR4e0i liGT3gyJlVahAjQwfgBjCUpktn6TrGTCJjU7lRhqdKSUn02y/rBgxL9u4 wauPKj/CQSr4o3YfD/f0D6SwSkBL72E8d/M69oo4TV3LILrfg7ko/I0Y3 2zQ5nlDZLxyfpiNE/dBm9ehb1k/tKQh/QRLcowVP4muEdaYOYCOFiVxUp Q==; X-CSE-ConnectionGUID: cqk+OFlETIqJ+xbQSVMjCw== X-CSE-MsgGUID: kT9+ZUdJQBWFY5Us1D83Qg== X-IronPort-AV: E=McAfee;i="6700,10204,11358"; a="41560594" X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="41560594" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2025 22:28:39 -0800 X-CSE-ConnectionGUID: lAVzdclkRwC1xcaXxpdT9g== X-CSE-MsgGUID: zlE0fJP9R+2JlmFwC4PWQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="122265277" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by orviesa004.jf.intel.com with ESMTP; 27 Feb 2025 22:28:34 -0800 From: Raag Jadav To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com, andriy.shevchenko@linux.intel.com, cezary.rojewski@intel.com, amadeuszx.slawinski@linux.intel.com, shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com, jbrunet@baylibre.com, neil.armstrong@linaro.org, khilman@baylibre.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Raag Jadav Subject: [PATCH v2 3/6] ASoC: tlv320dac33: use devm_kmemdup_array() Date: Fri, 28 Feb 2025 11:58:09 +0530 Message-Id: <20250228062812.150004-4-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250228062812.150004-1-raag.jadav@intel.com> References: <20250228062812.150004-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert to use devm_kmemdup_array() and while at it, make the size robust against type changes. Signed-off-by: Raag Jadav --- sound/soc/codecs/tlv320dac33.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c index fa46f51d4341..423b9264a205 100644 --- a/sound/soc/codecs/tlv320dac33.c +++ b/sound/soc/codecs/tlv320dac33.c @@ -1477,10 +1477,8 @@ static int dac33_i2c_probe(struct i2c_client *client) if (dac33 == NULL) return -ENOMEM; - dac33->reg_cache = devm_kmemdup(&client->dev, - dac33_reg, - ARRAY_SIZE(dac33_reg) * sizeof(u8), - GFP_KERNEL); + dac33->reg_cache = devm_kmemdup_array(&client->dev, dac33_reg, ARRAY_SIZE(dac33_reg), + sizeof(dac33_reg[0]), GFP_KERNEL); if (!dac33->reg_cache) return -ENOMEM; From patchwork Fri Feb 28 06:28:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 13995773 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 899211C4A3D; Fri, 28 Feb 2025 06:28:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724127; cv=none; b=AB1EndzQi0LMSUAc2xaSkopjtIq2O08jZJMgaYefpJCZYOC3vSvysXu5+kzfx4zS27ogIrgBKPCdbWupZM02E/uGLE4ZvKS66QSVaNJv/B1fhRQ0aRC0MKx74SfIW1RbgwJaS3g681vfa2DOD15B01wb0SkkcOtFGg6e/WCPJSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724127; c=relaxed/simple; bh=e7a2cCCwX7XNrpGn1XdJxR3IeQTxmfvf2zp8jE434LA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ee8z8hCWTMddmHMUjO0Zvda10XhjX0JYqwnWWU1P+qAYCjD/cL3cgUP8Nw0jmlugCN0U9EVBjs1NFsD/gJCvcumBpl1THonI6W1GUeFRPe28sYCVr0nbuIn8EI2GCIM9tfEyVONQ9opBQyAGn4gLwR526m5oa6viKQisv12p/AA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OV4NH9uG; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OV4NH9uG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740724125; x=1772260125; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=e7a2cCCwX7XNrpGn1XdJxR3IeQTxmfvf2zp8jE434LA=; b=OV4NH9uG68wzi17Bum+Ee2Ye47mnre5SR20lOZmkWtt4M88OOQG+kVfJ dOCgYmUtAgomkpJvYOWlhNDng8lErdu4jTcEbJU6xVNYO6LQvgoNiLRd8 +PJXQBIEwzcW/V7Fe/FEX5ImHNMVUnsL10RGZDwXWanhPX5EuTJDFWElV y2hKECkKg7DdJnzrdwxraxmcUkDtcxVdDlUrpQNRhJAcfyZYzqP6HwcGs TtWnsJK9S4J9AB9lyEmVYhg5cyxw3+KWZWVJppsdlT4YgjKxiPiafQEOI ieanC6bTwS7+cI07CFloxBCjcWHAZ8EkSrKfvln/EAaM39kgjcsry32RE w==; X-CSE-ConnectionGUID: 0MhFZWJZSpu9liSaKyFAiA== X-CSE-MsgGUID: cbvhgDK5TWSyaZdTpgs3rQ== X-IronPort-AV: E=McAfee;i="6700,10204,11358"; a="41560606" X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="41560606" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2025 22:28:45 -0800 X-CSE-ConnectionGUID: 96XjMWfTQb6L9luGeC+NBg== X-CSE-MsgGUID: Rln090DUSDuuM/IToxvhYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="122265287" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by orviesa004.jf.intel.com with ESMTP; 27 Feb 2025 22:28:39 -0800 From: Raag Jadav To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com, andriy.shevchenko@linux.intel.com, cezary.rojewski@intel.com, amadeuszx.slawinski@linux.intel.com, shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com, jbrunet@baylibre.com, neil.armstrong@linaro.org, khilman@baylibre.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Raag Jadav Subject: [PATCH v2 4/6] ASoC: uda1380: use devm_kmemdup_array() Date: Fri, 28 Feb 2025 11:58:10 +0530 Message-Id: <20250228062812.150004-5-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250228062812.150004-1-raag.jadav@intel.com> References: <20250228062812.150004-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert to use devm_kmemdup_array() and while at it, make the size robust against type changes. Signed-off-by: Raag Jadav --- sound/soc/codecs/uda1380.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/uda1380.c b/sound/soc/codecs/uda1380.c index 4f8fdd574585..c179d865b938 100644 --- a/sound/soc/codecs/uda1380.c +++ b/sound/soc/codecs/uda1380.c @@ -766,10 +766,8 @@ static int uda1380_i2c_probe(struct i2c_client *i2c) return ret; } - uda1380->reg_cache = devm_kmemdup(&i2c->dev, - uda1380_reg, - ARRAY_SIZE(uda1380_reg) * sizeof(u16), - GFP_KERNEL); + uda1380->reg_cache = devm_kmemdup_array(&i2c->dev, uda1380_reg, ARRAY_SIZE(uda1380_reg), + sizeof(uda1380_reg[0]), GFP_KERNEL); if (!uda1380->reg_cache) return -ENOMEM; From patchwork Fri Feb 28 06:28:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 13995774 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 445081C5D51; Fri, 28 Feb 2025 06:28:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724136; cv=none; b=SgyNC2Iw/G1KDoX3xH8YzhhGg7xlZuc+A8Ye+t4qubGgW7SO0kbSlJjJ/Zozt4+HnqL1JTfmngpD4vt6/kYbO4sAktIdMpmwcUDYwJwRTcVCOHElCycyD3Z7V/hyoTIeTMTyuEx780uERTY8Sac22LLXG6sP6tzSI9LPYemQf/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724136; c=relaxed/simple; bh=9jklcU8zXeb2fq/kZyVr5PcF5WyfIGqHTEgky7Oh+0o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UozHAsQ6oxhcqfiXJ+FsnBt7nNByjnYa7UzsAADfxaSAwpKUpzOR6k8tJZ8t0Raa+EN40xl1U/ZhesFpXfso+FW/8myR70xnSiYY6ScYbK445vyZkE6hsA8+wgFAuwx7SoenvU7cZI0ym6VLKz+nGkdCD4S5Rggpbsg/ODenFxo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=R4qbzyxE; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="R4qbzyxE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740724131; x=1772260131; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9jklcU8zXeb2fq/kZyVr5PcF5WyfIGqHTEgky7Oh+0o=; b=R4qbzyxEyZQXrUaNFnj7cNQU1zsO844mjRCW8eKNKY+uJiQeYded/jCZ IAy5+zv++4iWTMMkAxlNaei3a1bwKVcrOTIgplHeFaQQhWTgv2U1gfK4j acu55rzz/04fA5cIy89PbbjmMoJ002eAf2rxisewHdTzphNZlwgTAKl3M iq1PM7zzJm3c6qCIZbTREPRh4dICLL1h3v3XVr7S3p68oGIFQ+uxsgkBE hBGrlIRJY4kCBcZdaKu6AunRQLz42kb2nfUnlh0mLNAHRT+xQ0vM6QZYI L6xRl0Vdn5a1Ci0iJFLIyJwXhEcdDpbZ1ZJUZIl/xNzU59zbyR8OXryvD g==; X-CSE-ConnectionGUID: pZ1bp4OWSEK7OgkafmGBGA== X-CSE-MsgGUID: b5v4jTVdRRO3h9giBCqNiA== X-IronPort-AV: E=McAfee;i="6700,10204,11358"; a="41560621" X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="41560621" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2025 22:28:51 -0800 X-CSE-ConnectionGUID: BsSPXGf2QzS0uHcld8PrYA== X-CSE-MsgGUID: RoIU7F6UQPWWh8myrKEe9w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="122265320" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by orviesa004.jf.intel.com with ESMTP; 27 Feb 2025 22:28:45 -0800 From: Raag Jadav To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com, andriy.shevchenko@linux.intel.com, cezary.rojewski@intel.com, amadeuszx.slawinski@linux.intel.com, shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com, jbrunet@baylibre.com, neil.armstrong@linaro.org, khilman@baylibre.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Raag Jadav Subject: [PATCH v2 5/6] ASoC: meson: axg-tdm-interface: use devm_kmemdup_array() Date: Fri, 28 Feb 2025 11:58:11 +0530 Message-Id: <20250228062812.150004-6-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250228062812.150004-1-raag.jadav@intel.com> References: <20250228062812.150004-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert to use devm_kmemdup_array() which is more robust. Signed-off-by: Raag Jadav --- sound/soc/meson/axg-tdm-interface.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/sound/soc/meson/axg-tdm-interface.c b/sound/soc/meson/axg-tdm-interface.c index 09103eef2a97..421b5d719fb3 100644 --- a/sound/soc/meson/axg-tdm-interface.c +++ b/sound/soc/meson/axg-tdm-interface.c @@ -529,7 +529,6 @@ static int axg_tdm_iface_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct snd_soc_dai_driver *dai_drv; struct axg_tdm_iface *iface; - int i; iface = devm_kzalloc(dev, sizeof(*iface), GFP_KERNEL); if (!iface) @@ -541,15 +540,11 @@ static int axg_tdm_iface_probe(struct platform_device *pdev) * We'll change the number of channel provided by DAI stream, so dpcm * channel merge can be done properly */ - dai_drv = devm_kcalloc(dev, ARRAY_SIZE(axg_tdm_iface_dai_drv), - sizeof(*dai_drv), GFP_KERNEL); + dai_drv = devm_kmemdup_array(dev, axg_tdm_iface_dai_drv, ARRAY_SIZE(axg_tdm_iface_dai_drv), + sizeof(axg_tdm_iface_dai_drv[0]), GFP_KERNEL); if (!dai_drv) return -ENOMEM; - for (i = 0; i < ARRAY_SIZE(axg_tdm_iface_dai_drv); i++) - memcpy(&dai_drv[i], &axg_tdm_iface_dai_drv[i], - sizeof(*dai_drv)); - /* Bit clock provided on the pad */ iface->sclk = devm_clk_get(dev, "sclk"); if (IS_ERR(iface->sclk)) From patchwork Fri Feb 28 06:28:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raag Jadav X-Patchwork-Id: 13995775 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECE8F1C8617; Fri, 28 Feb 2025 06:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724138; cv=none; b=efyc2kp36spBLhwbaPzuc0Jpki9J67P+aEf8dDjr5IiKw2HHRBnliATKm3iK8vB3dn3VLJN+vobFtXvzyr3LAdUZmR0x7mkpTHuTcSuKR61fCfPPBcQPuZO5/FuvT2jn7Aei67zaLb2WEOHFHggr4rdEVwEXQ4iSwzQdb0+oSVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740724138; c=relaxed/simple; bh=rmG5AJg763QuUwHiI4zIJ8TFRtKX3Nej46Hu42LYCJw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uyhJLWwxNLEksQ15zBI0ouNA9hdaFT63Mm9uxB+4kRG0CU0No/35HPMiz4iNxnBnejhz7gPXo5e11J+5uqYpqlHiXReS1ogihO3eC+HgzmjNAjlMV+8Rn2FHw5LZtTTuNLIqsruJankrmkSLdBpmqM70XtCofobWfjooJtxuElM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hV85Cdfq; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hV85Cdfq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740724137; x=1772260137; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rmG5AJg763QuUwHiI4zIJ8TFRtKX3Nej46Hu42LYCJw=; b=hV85Cdfq8zejDqpnk1Btu6Rde3UHhegnJ6gEiKeiwYqanvhIUZ3LB6ZL uf3aJ/4HDWX5m38V3jXxtbVVp5gNw15cW5D4n1n3WEfYFth1HXiysvBQE Jxp0HVf6aQnS1ncVDEwpAcjCZRVSre33thkaVAcv6OFiY8Tc6hN3l6IGT fNKv7sdjPXOhyypJxfGG/NU9beKkz+TtEtO7h4UIlI39uOVTqaci/lfti KqWGwaonjcijdBorv8IY6u4rL2JLzqbizqZVwRzW/jYnQvqFQmxKgLCVQ 6VkIss6HNUraXB30CJraA0E+M2C5G50ULZYSQPBy/gWvAjAN9KHNbYMVS g==; X-CSE-ConnectionGUID: foJAtLvkRWeBEF/Snrxf4Q== X-CSE-MsgGUID: pFLkqEzBRh+gSkRQJs4RsQ== X-IronPort-AV: E=McAfee;i="6700,10204,11358"; a="41560630" X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="41560630" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2025 22:28:57 -0800 X-CSE-ConnectionGUID: snnp9cdgSBGIN7HAUlvi6w== X-CSE-MsgGUID: wUo0Lp6XQW6Zcl2fymuOQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,321,1732608000"; d="scan'208";a="122265335" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by orviesa004.jf.intel.com with ESMTP; 27 Feb 2025 22:28:51 -0800 From: Raag Jadav To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com, andriy.shevchenko@linux.intel.com, cezary.rojewski@intel.com, amadeuszx.slawinski@linux.intel.com, shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com, jbrunet@baylibre.com, neil.armstrong@linaro.org, khilman@baylibre.com, hayashi.kunihiko@socionext.com, mhiramat@kernel.org Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Raag Jadav Subject: [PATCH v2 6/6] ASoC: uniphier: use devm_kmemdup_array() Date: Fri, 28 Feb 2025 11:58:12 +0530 Message-Id: <20250228062812.150004-7-raag.jadav@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250228062812.150004-1-raag.jadav@intel.com> References: <20250228062812.150004-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert to use devm_kmemdup_array() and while at it, make the size robust against type changes. Signed-off-by: Raag Jadav --- sound/soc/uniphier/aio-cpu.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/uniphier/aio-cpu.c b/sound/soc/uniphier/aio-cpu.c index 470f129166a4..3224c11a527f 100644 --- a/sound/soc/uniphier/aio-cpu.c +++ b/sound/soc/uniphier/aio-cpu.c @@ -762,14 +762,10 @@ int uniphier_aio_probe(struct platform_device *pdev) return -ENOMEM; chip->num_plls = chip->chip_spec->num_plls; - chip->plls = devm_kcalloc(dev, - chip->num_plls, - sizeof(struct uniphier_aio_pll), - GFP_KERNEL); + chip->plls = devm_kmemdup_array(dev, chip->chip_spec->plls, chip->num_plls, + sizeof(*chip->chip_spec->plls), GFP_KERNEL); if (!chip->plls) return -ENOMEM; - memcpy(chip->plls, chip->chip_spec->plls, - sizeof(struct uniphier_aio_pll) * chip->num_plls); for (i = 0; i < chip->num_aios; i++) { struct uniphier_aio *aio = &chip->aios[i];