From patchwork Fri Feb 28 14:07:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996478 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52494C19776 for ; Fri, 28 Feb 2025 14:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PxV5ubkQILRDTTOOiWiVBaTKuCWcjZ1klG/odToLNLU=; b=eMujRjjap0RefPmyojJeFb7cR2 qBQ/dEPwxPFWIGDVGpfoDgANPNWy+iOiJ6NbilGWmUtOdqmxVHZvHfg62q1JDWFM2WfSbRhECPOa8 QEWaCFtCyIKaulbvvTHmZg6s9NZwwwZDRFpy7EourdyVyRmXgBxYnzgFCHdQEDH3arEf7jGTeW785 8JtP1DQANcnlONsuyCELitfuV8NBg2ZT7VgRYusdWrCwQ/uJtERjvwc22uPIG1otM1mdduww251zR 3mms6SwR1RH/soh99VwI2fZvAwhvoGiM2V7X/P+6O8T+zGq8R9Wl0VB3MviB+wcWKJN4T3ZZ40v4j GgvnRWIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to14j-0000000BCDl-1vY7; Fri, 28 Feb 2025 14:10:49 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11Q-0000000BB3D-2UTQ for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:26 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5ded6c31344so2706000a12.1 for ; Fri, 28 Feb 2025 06:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751643; x=1741356443; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PxV5ubkQILRDTTOOiWiVBaTKuCWcjZ1klG/odToLNLU=; b=GNwV7WePBwGhEVUrY8wkOq3dzITnF6bXyqJEur34Z1CIW6s4R9vz3QrmoEhjsA04eg 7kbBYDcHmMpkZ3JLtdArC03chuByeVy/vLIRGi7eZfpNV70nu6O3sdU6h5YDnemgokMK dT0q24KtC5t2eUsgOPzFWhSPAjNpkjhXEYvoT+g8bNDBoRzfm592WkRpnWNNAxVTPD2d D+5n/qz/PdRNzu6HlbjGIVW08hDsvXXfv2MHhEBVKhDMZSnlGGtlYYnydpY0jp41vELK eEvnZrF7mM8WY5uj2u8cSCmlVzD4DrV2uK+5bWMpLfnz0L4q0zFdGInPZZtEY429l41d HZMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751643; x=1741356443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PxV5ubkQILRDTTOOiWiVBaTKuCWcjZ1klG/odToLNLU=; b=LUl/lQRNGhjctEOCShaHIdwol0I5YP6qkGGtxUZV4G2pKwfIiP+MHxSSw9uwufMCxX iLhRkI1LyD4tdx5reRPXDmiZ2FVeNpgJMtxJIdwnxdHEfQhQNrLtNUoDc1Gys83ZmLh6 vBcF7SVMJbqV0GxnKtJw+1+DfZX/AvFDWq/6/RLdGfQJkd2vto8+1RGz7vpESKx2J1Sq J1L7/hEHir046vkIcqe9DmGxhknsZfth8+hJ14WosAlvSt0myQw3HEH31Xg5v4NptA7w bR4lpgWHDfiyA1LSpUcVOndV2Gwp3U5fHHZoFpCPoDPk1cudKnuAnwriKsSXrmmiBwNU 8hRA== X-Forwarded-Encrypted: i=1; AJvYcCVC3Hpa6BcYldIm8p7MxjCxlexaxD/josZEV0bs1dtglBZjbs52f5w9iS7IOKTlGBo/WmiRnwNX9IJBqjE5acFq@lists.infradead.org X-Gm-Message-State: AOJu0Yz+dcCd06HtYCrh0j8pnpVlq+TzZXrg8l1wSKcdoUGcMeYrwv0n 3V3fxDRyra0XrP8L7NN1qK46YLmj/esV9xrThq6LBeBgpBWE5KaZv3mFSLFyIbg= X-Gm-Gg: ASbGncuqUfHScTXpZIgKKyFgOwjXsEg10+m8/8aC4l9yjK6iT5kaAXWO0wGiFAi8Rgw XTx74Kd+3ZRKRdEdBI+mFJuEXwHO4tB2kkn2V47wxWxvGzZU5cD8VaLRV4a3b8Hn8tgvA0Ih4iz WTaOLTKSxhpIhW/M14nZ2+VjQtyjp06tVSlc1WjUpcANH0QEs5Fu3cRJkgSFe+yaikZVwRkS3GL dY8llNYhH7ytTd6FTvdG/wyAvtSjJNHRJ/cf9qM2TO3eObShkH0C9p9koon561aTUHDHWT9hHY8 3NgJcPXTTA9b2/1Lxa2yFDWt4OePkhkdPWRUawrdw+IGqrs/mHmZ46ydvhCXXUFt5kYWsYeqA6/ J901KmCnGDg== X-Google-Smtp-Source: AGHT+IFUL7DUuq/VqTU9dmynPShF+8aK2RXF+k+UR0pl4bWqZxWvS8VoSsjq66EWlcydyD7uTG7tww== X-Received: by 2002:a05:6402:1d4d:b0:5dc:796f:fc86 with SMTP id 4fb4d7f45d1cf-5e4d6af436amr7325207a12.16.1740751642551; Fri, 28 Feb 2025 06:07:22 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:21 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:14 +0000 Subject: [PATCH 01/18] rtc: max77686: drop needless struct max77686_rtc_info::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-1-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060724_631832_5C967ACB X-CRM114-Status: GOOD ( 14.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When this driver was converted to using the devres managed i2c device in commit 59a7f24fceb3 ("rtc: max77686: convert to devm_i2c_new_dummy_device()"), struct max77686_rtc_info::rtc became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-max77686.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 7bb044d2ac25aeaaf2404b47b7e7bd485ae3d39e..6b0d02b44c8097453f704cbec9f02580fb869ca3 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -85,7 +85,6 @@ struct max77686_rtc_driver_data { struct max77686_rtc_info { struct device *dev; - struct i2c_client *rtc; struct rtc_device *rtc_dev; struct mutex lock; @@ -691,6 +690,7 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) { struct device *parent = info->dev->parent; struct i2c_client *parent_i2c = to_i2c_client(parent); + struct i2c_client *client; int ret; if (info->drv_data->rtc_irq_from_platform) { @@ -714,14 +714,14 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) goto add_rtc_irq; } - info->rtc = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, - info->drv_data->rtc_i2c_addr); - if (IS_ERR(info->rtc)) { + client = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, + info->drv_data->rtc_i2c_addr); + if (IS_ERR(client)) { dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(info->rtc); + return PTR_ERR(client); } - info->rtc_regmap = devm_regmap_init_i2c(info->rtc, + info->rtc_regmap = devm_regmap_init_i2c(client, info->drv_data->regmap_config); if (IS_ERR(info->rtc_regmap)) { ret = PTR_ERR(info->rtc_regmap); From patchwork Fri Feb 28 14:07:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996479 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6888FC19776 for ; Fri, 28 Feb 2025 14:12:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NEusmS+5iWAG1jDnjFt/eyKJ89b8w4e+6UytiCX0MQA=; b=JwiETq3ucemoq/7WKS27MynBih 75Onr3CM5bd9A2NJmQ+jgTMZErx+IGyIQGdxMsahdtgjyVrnylLHKWfmDDQFy3Yo55nK9QlAUUDQD g475NW2XWUi0F+DXd2s5jTb+MvHqJVrkZZZKEsa8A3uaaIuWWZlF2aUq/WVrbPzoiix0fYLMcwbqg 02OJBRR7cIkxk8Qv6VKckivQGdyGyBK+8KbXmiJk+OrbL5jggqwRSqAQESQtkCEnil98qS1hPpeBz meMhGvg9iBfTP1UXfG/mVInhn5qRhLIELWql33Zc2RnurX/LfIUM6t+tk08rzJG9zauYx4SuTGaWB O7kCehqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to16H-0000000BCZV-0jkq; Fri, 28 Feb 2025 14:12:25 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11R-0000000BB3e-0fFh for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:26 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5e0939c6456so2923101a12.3 for ; Fri, 28 Feb 2025 06:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751643; x=1741356443; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NEusmS+5iWAG1jDnjFt/eyKJ89b8w4e+6UytiCX0MQA=; b=cRR+sLzvYmRpnUm8TutgPqD8mFWYqWuH2uzh48t0dexjeT9733sszbXz/8Y0v99P60 EILafaEk2Geen28LLpCTLlcV1vaZ4itBLoy8SH6Hd7VtOFdKKOXHpd4S/xQ/IOzTh/S8 j9+P9hKUXVI69aJdlXjjBJpn+6NW5A/6PPDX8i1IxDwFl9kzXuoaU+7R5Wop44zgcKha ZVspKwFr0SXsQQO/qVdC7KkgPv+PE5yDi1zOf5qHs/rRrXhvMo4sEkN0ztRBaLpW9977 43bXPqCOoG5cg4kMBgFum2/vg6TWSu44VShcYLdD5Q7U/taTUpWThtoz5oj5KWo9ReiE gdhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751643; x=1741356443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NEusmS+5iWAG1jDnjFt/eyKJ89b8w4e+6UytiCX0MQA=; b=o3NFwyhSfvrDCWMcpTEk44PKsUO0bdnlQdXEbeHi1/lJPGSqtsWtlDr6A0UL5kFszU jyovkodERIRyp5mTNd/Q4RFB0pkWpByWzvnPo29S5x+DDPfgqunxS78APGY5FNnZ+/Zi g6jqArzjihP+RMyqlvkui2Z2bT8I6WBvhqGdUpyRPbZY5IBXHJllWBrV3FjqQX7jP3U2 fHwPArOVPygfm28DRT1btR/VaDpSTuW5/hVflMGQ07qgrrPwkDVVX+hSbSpDQRTtzQwA BLZY/J3wul3DxqibCybJe5txtb1IDGM0Ofepee+Kj2hWUNEDpMUdJuzy40h9nEQVXHz3 MWnA== X-Forwarded-Encrypted: i=1; AJvYcCUaKMz/S1u8NC5etnWLdXwd2fFFA55NOPpaw1OJ8y3xMyRkjfvSc11jhf86KCw3wPG3YJh7tKgbOjH999JypDIi@lists.infradead.org X-Gm-Message-State: AOJu0YyFAodc9fFo/IlMnjnq25MxpRo6K9iy0Pyy+BViPcOHYy/i2fi6 GMDRYDjLbbr9zZlQn9Cft53Ae1edpatuieYkrrfac1GAdIy4QQqqopPiPBEBc6g= X-Gm-Gg: ASbGncvnqSS3tzHe3O10cHmPMOaoAHnhakVyVDoimaBzEI01sVHTMsvIMct/0ydg2c5 g+Synu3VKeGy30bmwomoYITxVSwTzLsx3/YwZsj8Gga7TcS1CF3LLCb6v2Nwb9O/BiKeJhUWZG+ fqZRW8QxNp+YQohL7hTeOUIgmZUqt+dQSG2mR1jPJgqdgIyoysPj2FMCgHudYszosGoNgoVaBG+ RT1ndR/oZKw2v8BiD/yppnPnF9Mymj0tDoT3pQMGqBRDv8xmJuDSd7E7HstjnZBzbbQtkw4JPht dlE7+jHTbtQ4nTpSlnLeAqKK9bC8oWrWH0z5PUzDtaEVJaJ5X1LdtgRrKUP81Aq4bmG1nJndqtt 0P+QT2mm3JQ== X-Google-Smtp-Source: AGHT+IHzPJx5i3RI7O2yaVdHtPJ0az692A2jfkouiK94jhHcaAYqi/2J0zpg5aMdk74cXIZT8BcCug== X-Received: by 2002:a05:6402:42cb:b0:5d9:a54:f8b4 with SMTP id 4fb4d7f45d1cf-5e4d6af0565mr2697422a12.11.1740751643440; Fri, 28 Feb 2025 06:07:23 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:22 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:15 +0000 Subject: [PATCH 02/18] rtc: s5m: drop needless struct s5m_rtc_info::i2c member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-2-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060725_218100_054EBEF8 X-CRM114-Status: GOOD ( 14.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When this driver was converted to using the devres managed i2c device in commit 7db7ad0817fe ("rtc: s5m: use devm_i2c_new_dummy_device()"), struct s5m_rtc_info::i2c became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 36acca5b2639e272dd9baed06ea5582f635702b0..77dd61c30681b8f0a2f23063ad5f7eb52f5b7158 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -146,7 +146,6 @@ static const struct s5m_rtc_reg_config s2mps15_rtc_regs = { struct s5m_rtc_info { struct device *dev; - struct i2c_client *i2c; struct sec_pmic_dev *s5m87xx; struct regmap *regmap; struct rtc_device *rtc_dev; @@ -640,6 +639,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) { struct sec_pmic_dev *s5m87xx = dev_get_drvdata(pdev->dev.parent); struct s5m_rtc_info *info; + struct i2c_client *i2c; const struct regmap_config *regmap_cfg; int ret, alarm_irq; @@ -675,14 +675,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) return -ENODEV; } - info->i2c = devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, - RTC_I2C_ADDR); - if (IS_ERR(info->i2c)) { + i2c = devm_i2c_new_dummy_device(&pdev->dev, i2c->adapter, + RTC_I2C_ADDR); + if (IS_ERR(i2c)) { dev_err(&pdev->dev, "Failed to allocate I2C for RTC\n"); - return PTR_ERR(info->i2c); + return PTR_ERR(i2c); } - info->regmap = devm_regmap_init_i2c(info->i2c, regmap_cfg); + info->regmap = devm_regmap_init_i2c(i2c, regmap_cfg); if (IS_ERR(info->regmap)) { ret = PTR_ERR(info->regmap); dev_err(&pdev->dev, "Failed to allocate RTC register map: %d\n", From patchwork Fri Feb 28 14:07:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996480 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AF49C282C1 for ; Fri, 28 Feb 2025 14:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=tr3ZBYjY3GXdyL+6ZaaS0nKCDl 9LVKvYthLmzyUzhSE+BH/Lc0wulRp7YmZ403295y6XnexFiqYQ5e0EhUkUXBKIunClljXqUGetHNR o0OWhD8bwkHL+0ry84a2N660jmNcgPPansRhhCvlZyecZ2htz6NFopovzfhIT7/n5wUp4bMLZfbEt uJ/b7A+plbNK4nMVfHp7qTgMWQ43g9v/jHXg+nw3maTCBiInqOIjCqE+mwEtM2CyYtro5944BAWrq ucD1OPPtfzDtBS161sR0HjmE2QZIFuZCJyXnwcQ1eLcOGfgZqKy+N53ZNCbdzSIZlKUwUidJTba0e k2XpTk5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to17n-0000000BD1V-2LEK; Fri, 28 Feb 2025 14:13:59 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11R-0000000BB3z-38iT for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:27 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5deb1266031so3678794a12.2 for ; Fri, 28 Feb 2025 06:07:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751644; x=1741356444; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=DIg1kgLt5Oep0o5v4ZjEl3Pao9VvKZWVV1m+kaGGsrYTSXSaODXr9+3PsbZ5X255RK EYbFZIXdL0DmN93CzpY7HYqYxJzBSPhCNJjwEs6nwmGXcpexH6WTiJIBWfxd0YHqsxID M9Z6PmJsWny0nkQU7S/Tf95w5n12qsqwZDsPokW9AaZz6OlrcQqY1G51T5wChPQZKLkz 32TKsVSriRYEjPReQ7yYail1oxJ5l/wyMi3eZPEgKmiI0SUxD84Sc2PFUC99ukHJkfHd 7JPrj+xazWkJQjrfPlzupoEdxlSk1lXBhdT3kpYHcHTvbB6zJwe7G+L9nO6vuUMdtcXK iRLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751644; x=1741356444; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=wit4JwOku588myBgr666tRGWTtkkHZS0pPvA/ljLPM5QDLVNIOWHa9O6EwM4M0plca ZiyggMn2KRuuXqoJrsHWwY1nDpxhL1+mk2WwspCIP7PcznlocvMahKOUWTypBrQq/OiK f8Dz2G8rfy3vjUqPmzqcE5yKX5Oq1NBcGaGqfzyC/VQWSHfImfxoXMoVx7wB7MinDF5P yI59Noj95isB2bBWN/wRNWHDbR7+xk4ucEyMcF1kz1J+VZc0agvks0ZSo17fqZqwi0GD UvDpd0Pro0UmE9Zg+M1MfD3YTSmDQ6eDnHjONlqmkAEipSutll9s7zeJhK1r/ZjT2fqq fNQQ== X-Forwarded-Encrypted: i=1; AJvYcCXkU+6PyuuLBe76H1a7LjH+qgmcEmgoKps7T/rVWo3iGk5aFTVdBP+EvKh0Sk/CEbcpQecGFopOGMQLaO/UQgvo@lists.infradead.org X-Gm-Message-State: AOJu0YyUkXFKSozMAjNEOffNx1wWyAhRiQGzJY4UepnYNx69ggs1wAre m4Qyvi79R/0QQUB44qROy9w1b42pqGaZm8DKZO5vF4lLE8JWAW2VkhyXCkeMbVg= X-Gm-Gg: ASbGnctllMUPzLyUoKunBspacm2Yds5xtQgFWweaGLX/En+o7V4t6qia41WVYs0lSRO uX1DvHAZqotD8UEF6fZdsq6wbyNQ0yN2faje3uYIAlOWlRZ/zVvDhCMMbjd3qqRtJQqU6nfk6g5 c7fvG9f9xgShTcpsxKBoVGQXyD0Vhh1mlfxqe0EMgAyCkRYwVxIN8XRY1oZFssrPn4NKcHneGF3 cr7EQHzT+CBiRUd+5o7QxPnSJBCmfN9FzhjYArYgiV7KSDv5Ocdlu1wQWsYeLdVEdI/bJcGI8/v 97LjWSFAC7ecH9Kdc8U3xuj12pwLwGKe5N1x+qoX6BvQU7yYhI/TWYVfl9VaWqq4GDGMFOdWJUZ hF4SWkgKBEQ== X-Google-Smtp-Source: AGHT+IESLHMD1ALp0fl5UNtQkvu55XFyzsWGAW2ARn4G0KwygGU8Ail6xNyHqVhAMNH9i4466iKXaA== X-Received: by 2002:a05:6402:848:b0:5dc:d10a:1be8 with SMTP id 4fb4d7f45d1cf-5e4d6b0e6c9mr2959043a12.19.1740751643974; Fri, 28 Feb 2025 06:07:23 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:23 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:16 +0000 Subject: [PATCH 03/18] rtc: aspeed: drop needless struct aspeed_rtc::rtc_dev member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-3-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060725_820616_6261A593 X-CRM114-Status: GOOD ( 15.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-aspeed.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-aspeed.c b/drivers/rtc/rtc-aspeed.c index 880b015eebaf796f68ed82c29998f345e1fd418b..0d0053b52f9b90a61725bf29435bfc8071977f9e 100644 --- a/drivers/rtc/rtc-aspeed.c +++ b/drivers/rtc/rtc-aspeed.c @@ -8,7 +8,6 @@ #include struct aspeed_rtc { - struct rtc_device *rtc_dev; void __iomem *base; }; @@ -85,6 +84,7 @@ static const struct rtc_class_ops aspeed_rtc_ops = { static int aspeed_rtc_probe(struct platform_device *pdev) { struct aspeed_rtc *rtc; + struct rtc_device *rtc_dev; rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); if (!rtc) @@ -94,17 +94,17 @@ static int aspeed_rtc_probe(struct platform_device *pdev) if (IS_ERR(rtc->base)) return PTR_ERR(rtc->base); - rtc->rtc_dev = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(rtc->rtc_dev)) - return PTR_ERR(rtc->rtc_dev); + rtc_dev = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); platform_set_drvdata(pdev, rtc); - rtc->rtc_dev->ops = &aspeed_rtc_ops; - rtc->rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_1900; - rtc->rtc_dev->range_max = 38814989399LL; /* 3199-12-31 23:59:59 */ + rtc_dev->ops = &aspeed_rtc_ops; + rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_1900; + rtc_dev->range_max = 38814989399LL; /* 3199-12-31 23:59:59 */ - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); } static const struct of_device_id aspeed_rtc_match[] = { From patchwork Fri Feb 28 14:07:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996481 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54B9CC282C1 for ; Fri, 28 Feb 2025 14:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=tHWQqMFEnVvoCiCK0O0iGi9wnQ o0Eh4JU9YilNTpMkeF4khe63K53qIb1KWrrTMX43mGz5NBdQmrzPg8t0VqaxQCoOyJb2kTDWRrB29 aVw6T33CCM3wxuxY/LuTVqFt7LkW15oULkAvPYrI93Q1l6UslkywMkdwyPJW0II2S8Tu4ebDE7vug lcvP5VaR2DwVcl7fSHdmjXp9/KgnAOuC8zpzhCWpBFmv2Ug1kiwv6+6n13/4vhDd/uly4/yIOVOKm kl/8/FcQ7pN7T0R9x9v48kuG3/Jn49250o+Ch4VHiGkpvjSWiGmq2y+DaekBb20rfgfBv1vNSMrTH OBWSGGFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to19L-0000000BDWQ-2dbp; Fri, 28 Feb 2025 14:15:35 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11S-0000000BB4k-2Dyt for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:27 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-abb90f68f8cso416850266b.3 for ; Fri, 28 Feb 2025 06:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751645; x=1741356445; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=G4PPb6eSOqQsfGd5jw8KZtBIDlaZ46OUx8WEWGYE7MpGMr2pdIAXJto70kQmyhvaka JutkpevsT0A/Grz9sf3a+6xhtTMiKdIF9OQNKxZKIR81IAGOopAh0oSkIA74wlMoJcC+ jixqNRFWE4Y7AKLZyEaCsClYmR+D73eHprAbmcXaE9wb5TtkDaRAmlgrloYZk1aFQEs1 Kx+hVJZIfoHXakIEdS1385F4XGH7yECRxrQm0JeVRb/9h1akck80j2vrCQ6C0F8Bpdva 1Ku6vhqnK00EznVTbKZK2T+SwFXIg+9m9/NLobkL5bYPzdHCvQZb8ErvodJ5vBT2Wlmm 2CTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751645; x=1741356445; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=UcR2wC5KDkK38C5RWHS4FM8JcZEsmZHnSzgovup/SnXIpCugKXTSD6N8ZCyVIUgRyS 29OiYbVa058pewsmRa5d3fHWm3lx1RA/i+0dlZ0+54Cn4lxRXRXyrQq0IaKOhZGM53jO 5hHr0aT+mmdtzL2dLQQLwEhILU+OmpET9R+Euta9LjU+1hE7930tyCi6pJDlR+i9qZdU nNaFVNco77PnKbsSe36bqeBiBAx/QJjiHfMq++aoh6UHAqfjORXWjPR4HwpdAhhP2FcC G8zke3UXGfFSkM5p5adW8bAiTj1joiGFOy9owCAh4rAOl0v4ZAINYMx8amAhqjnIFaco LGPA== X-Forwarded-Encrypted: i=1; AJvYcCURZPD+/EeIaNExzSPvpAWSqi9JGoUvQ70jnit+6KUBTJWMQdEtjiONpCi/bU2Qzum/Ghveklk0PzCumTjDXW0o@lists.infradead.org X-Gm-Message-State: AOJu0YzLD5DUWMe0YA+w7JKR3pTYKMTutQTucPVwAw2LB+tnm+MkKADJ gkcfglHCUPg4YMrfh9tJLQShwAZGPnurrU3KA8yv2Men8HfVQrBEhf3HB9sOHaY= X-Gm-Gg: ASbGncsPfF9EjrBf/yqp1oqb0BPZyrw49vGbL3wbSiHx6UthucqMemvVrhV4OTcdJMO QwqSDSS1VO4LmAp7RWBP01y7lUcJ6acXqW0TUJaFNjmGFnthSn5MWsFho+zHaLTyvrqGnXmb9/X HZL9U0iuYtfu1oVcREShBpYkAtAs+3vdz5wPvOUJPcSElF1jtURYual+YEtYcr6sNt6skHh6I/N uzI8IUzhOowZdtlf8PPHkRs9oQ2rNl1s/JTodsTdLcvkdENktnY+SKzQtJZ5i33pwE3LrdYSjLN kR2UR/HUVWEGavmSCEYvVrMljAzerYyVg/Xw9HKaHnyVoDIBVXD6CmkcR83/tnhULj4bSheOcYW EJSjEA7wQ3w== X-Google-Smtp-Source: AGHT+IFpdib5eLXvAKlYp3fUyW87rQ1IfZ8GEMoJsXuLGkDw56XS2aTZMwaUmenZ5apuVJAYF/Nggw== X-Received: by 2002:a17:907:c018:b0:ab7:fc9a:28e2 with SMTP id a640c23a62f3a-abf2681f8f2mr377695266b.47.1740751644708; Fri, 28 Feb 2025 06:07:24 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:24 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:17 +0000 Subject: [PATCH 04/18] rtc: ds2404: drop needless struct ds2404::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-4-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060726_571422_AE3D04F1 X-CRM114-Status: GOOD ( 14.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-ds2404.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds2404.c b/drivers/rtc/rtc-ds2404.c index 3231fd9f61da49bdaf00e46486fc34836094ee78..217694eca36c3432a8db3b874374e347eeb802d9 100644 --- a/drivers/rtc/rtc-ds2404.c +++ b/drivers/rtc/rtc-ds2404.c @@ -31,7 +31,6 @@ struct ds2404 { struct gpio_desc *rst_gpiod; struct gpio_desc *clk_gpiod; struct gpio_desc *dq_gpiod; - struct rtc_device *rtc; }; static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pdev) @@ -182,6 +181,7 @@ static const struct rtc_class_ops ds2404_rtc_ops = { static int rtc_probe(struct platform_device *pdev) { struct ds2404 *chip; + struct rtc_device *rtc; int retval = -EBUSY; chip = devm_kzalloc(&pdev->dev, sizeof(struct ds2404), GFP_KERNEL); @@ -190,9 +190,9 @@ static int rtc_probe(struct platform_device *pdev) chip->dev = &pdev->dev; - chip->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(chip->rtc)) - return PTR_ERR(chip->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); retval = ds2404_gpio_map(chip, pdev); if (retval) @@ -200,10 +200,10 @@ static int rtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, chip); - chip->rtc->ops = &ds2404_rtc_ops; - chip->rtc->range_max = U32_MAX; + rtc->ops = &ds2404_rtc_ops; + rtc->range_max = U32_MAX; - retval = devm_rtc_register_device(chip->rtc); + retval = devm_rtc_register_device(rtc); if (retval) return retval; From patchwork Fri Feb 28 14:07:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996486 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23441C282C1 for ; Fri, 28 Feb 2025 14:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=DaQIgGaZHO4wg8uF9zsJbVjbEO YqFdUiwN1kAKDMKgoE1fatzxlMUJB6cO8+U5iguIdNQ4mq1clGHffsO9wJanIqbXoisX0BlGDvzGW BdwK//bvROCsWfqtReJi+6vVeYCC6E/DNnpgL6N+mSAGiEnjxPjkf5RFK9iwtqb2nuV6QmPNXbhru 1gODZyIPzJtfl+kF/cGuEzqD0zdcQXYUS4WfKPIMH56gc6jsPeTbaO5TqOo6LtQd2AxszBk3YRsCw d02oq7oW+YpRZ68JSGRDpIorXTk2Fg4zeLLknRH7BAdtj2KJI1qVeHXjZfS6JkyyiVWpJrHao7ofZ buPDbBvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1At-0000000BDqT-1EXo; Fri, 28 Feb 2025 14:17:11 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11S-0000000BB5K-2naS for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:27 +0000 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5e05717755bso3097484a12.0 for ; Fri, 28 Feb 2025 06:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751645; x=1741356445; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=jeU2JtskMdAYZtNYJ8cEX2hQiiFRABy15ZOpG+7C3G+2Brg3oejPx1FemRGjnRXTyc 3G5Q0LpfOvREynm1O7rtv9W7qI/CLpTONiHzThsbP7FmYuTWPy29Kh7N94ezawSEEXMh hd3oljXol9S1QIasSrTRyappJOVYuONc6uAwL2iknvlJCW4ypE87hKuncG+ui1i4TEQf uhPH2T56QzfZyHYLqvN/6wc3WPsEBxZ/sX+gEoUO9SQhrflkdO7XOuetK8F91hgxtzQ2 BwNGPu2ikkxKOPYHVclXI1spoVBWtHfH/fLnq2mdeOkHJlEGz+gq3EyUQvXBSxZ5UVE3 IKiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751645; x=1741356445; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=AIqQ9vUugQ+hX/3bVPbznv0XTy3ir+cL+RuK//LYj0OdLwC1DYV4147stDEPkzqMS6 fy37WxKKOoj0wVy1hnM7UHt26i22EFckQk0IZkYOOBExZJEuJ1QbD0ty4lL5BvHduvH6 OYxiHrXtw0d1NC0DhKtrvSYED72kcYBhN4XtlP1JK6gC0rP1+bUUy2L00FkB7DDvF0lh VCjwVYXeQar5+eIebEtJ7nJSQaFKY6TLorRZTv0rkHZ3Xaa+Wgnk8wjR+LwS0Sf1hkjf hHhP7Em9Gca0pfXEsB2y98aUX77Qxbf8uZAlF8vu9Amlety8GM35ZjGfewFOg+OmQjEy nDmQ== X-Forwarded-Encrypted: i=1; AJvYcCXE8rXUHHYjtfIPrwjEPechzUHp7+vU7Iy7AobvOCKttNiQiMSgU3ix51xTIfCLU7V4o7vNcbDiLL6AKwc9Ozdv@lists.infradead.org X-Gm-Message-State: AOJu0YxUxNRukkuJVcNDflGNxb2KhsWuzz8eBJucWWqu3EjdT/FlQ4mM vUGPaNO1TjnjoT8hg2SIyIjAAny0tHAxxyJltpBzIYXjDN9ZI1i5eJTKSdTJLcE= X-Gm-Gg: ASbGncscFH9uFjp0Ixvu/eyqCm+QZjBk6ttdwWtOT0x5KvxinXgjU/eKhxoyr+3xRaf Enf4hA7N3mfRTLFr+YaxkPVEIivNGa66UC9jEDteEgJEIZVPvPwT7Ti+mHcENNRZ359+v+blvHU mbfEfz3M5rhpJENlHt2EuC3qvaaHsrhHhGYAzOZgeHVhCDmx8roGhkeznDonGwno40BciAJiJ88 zqyW9VD0ZG6Qe+MtXScBz8du52HrHbTY0PuVXcXR3P8dckEgaESgDWvAOBU+A8he6fUJX6/BD85 XkjB64YFXRg+EhRJzl1ISEwFUmLy+GLigwtQTNR8SH2vAwjr4UKD89Xn4sZyD1ZEEdfGiKIUvl2 yMS4HOKGskg== X-Google-Smtp-Source: AGHT+IFjP5A5it0oOhAqjGMiq+zBlLn6/wyStXZ9TEpg3CsfQx18Ux73fzaAw5ZlIGleu7roV3QB1Q== X-Received: by 2002:a05:6402:84d:b0:5df:5188:11cc with SMTP id 4fb4d7f45d1cf-5e4d6b702a7mr2552045a12.20.1740751645245; Fri, 28 Feb 2025 06:07:25 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:24 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:18 +0000 Subject: [PATCH 05/18] rtc: ep93xx: drop needless struct ep93xx_rtc::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-5-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060726_710241_7CD86F77 X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-ep93xx.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-ep93xx.c b/drivers/rtc/rtc-ep93xx.c index 1fdd20d01560ef4fae2b996cf366b4f812329225..dcdcdd06f30d1ff6d0939f6bcad2c17c03c5a65e 100644 --- a/drivers/rtc/rtc-ep93xx.c +++ b/drivers/rtc/rtc-ep93xx.c @@ -28,7 +28,6 @@ struct ep93xx_rtc { void __iomem *mmio_base; - struct rtc_device *rtc; }; static int ep93xx_rtc_get_swcomp(struct device *dev, unsigned short *preload, @@ -123,6 +122,7 @@ static const struct attribute_group ep93xx_rtc_sysfs_files = { static int ep93xx_rtc_probe(struct platform_device *pdev) { struct ep93xx_rtc *ep93xx_rtc; + struct rtc_device *rtc; int err; ep93xx_rtc = devm_kzalloc(&pdev->dev, sizeof(*ep93xx_rtc), GFP_KERNEL); @@ -135,18 +135,18 @@ static int ep93xx_rtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, ep93xx_rtc); - ep93xx_rtc->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(ep93xx_rtc->rtc)) - return PTR_ERR(ep93xx_rtc->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - ep93xx_rtc->rtc->ops = &ep93xx_rtc_ops; - ep93xx_rtc->rtc->range_max = U32_MAX; + rtc->ops = &ep93xx_rtc_ops; + rtc->range_max = U32_MAX; - err = rtc_add_group(ep93xx_rtc->rtc, &ep93xx_rtc_sysfs_files); + err = rtc_add_group(rtc, &ep93xx_rtc_sysfs_files); if (err) return err; - return devm_rtc_register_device(ep93xx_rtc->rtc); + return devm_rtc_register_device(rtc); } static const struct of_device_id ep93xx_rtc_of_ids[] = { From patchwork Fri Feb 28 14:07:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996487 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD15CC282C1 for ; Fri, 28 Feb 2025 14:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dZH0eiBnc3WyY94yEis5FUZqmpsbyvfcyDb3myV5OX0=; b=N/emsRT2Zqhro0u2cQ8et/9213 3ZuJgIae48fIoPRjY+dafTtW6vVyicSw1eRT/sNbU+1tY1Gxv2NZAKR19X+5WiV2yW2p3+ci7cp9F IsXsbK882G8zwc96JhBuuoesvDyd8zaRtqJvVE0L9+Rr9PhSvqRBV0s2HlV7AmJyx6lg/gorbE2C2 brxatMKqFZPw0VA9aecj48+fj7Nzdl5lur1KOWFjgMBfXZFrbIs+x83OMrotGfh1hJUS8ylK6kPPj r0xN8QbbytHZZ2XO69E8+DH4eZdfOK4iphSWZOe5/ZgLr78x4FsixYFH5K+5ybvGDp2tpZ52BJAQF 2675dKSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1CQ-0000000BEJe-1gw3; Fri, 28 Feb 2025 14:18:46 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11T-0000000BB5k-1Biu for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:28 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5e4bed34bccso2990135a12.3 for ; Fri, 28 Feb 2025 06:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751646; x=1741356446; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dZH0eiBnc3WyY94yEis5FUZqmpsbyvfcyDb3myV5OX0=; b=Tete8FJrRmJOVMYDzdfO7FOg3YK6B8VAh+fDA3yTBC6G623oCWjYNz4cNn6uxg9GeS Y7kq2HgqXo7qFWMXM7O2RaY35+/Zz0tqKDWBQYBrUwJ3AUVmzjlqXk8uCZgskXhzyjII m0ssSIwhTxK3EW6e7seGS6Y+2NuQIznXJ7CWX2DPDnB3Cc+VrYgMwfBUsG/zNJby6CDC Rr7PsmHPYGZuL9//Z+2Jd0edzBWRA0pf7UiZZKK0o7tV+iB8lFLGsfXRhtYWhjkPEHUL kLD4vMhKR8OGzxGk6C+FG8zLcDTmgyM0w0cpDxBL/NOmZvaeNpyFkIucf6R3jVjdSmb3 TarA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751646; x=1741356446; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dZH0eiBnc3WyY94yEis5FUZqmpsbyvfcyDb3myV5OX0=; b=wmx5Y1mvd82GwFot7wFL9fqSa1P4aB1VMZ2RiOcgYkNczs8d1/RtPaFwaCXp21STH6 ACE5MPNxRkAQebCRLdMifv8YBhjV4+Ql0uQKuGpRmAXgJOOnPL5C7Xmygle4YT63TJYo ebwVtlgzhyPDV30ePggskOf6wHPtgAhq2yBZnyXEWYbyAWZ1zE0y0oI+oKqHKMOsUrFM l44crONyTzOdwElMHZGsufuT73WfWXmqqJnuubmG7HIgXjaq9y1VjTh38KigkbDMn4OB AMbD36hnM1yeiQrSzsvgXys+aE4fr+/zbinx+zlEI4iBhNlnuIz9Y30VBwj8QYuCYcRB tZfg== X-Forwarded-Encrypted: i=1; AJvYcCXXbQqDjsgbYDsdyOQxB770IUqsksez6Gb2sgKRDq3MVzyCFb0kwftIt7BNmJLvrozoTaTZ1TGmHd5J9/mtATV/@lists.infradead.org X-Gm-Message-State: AOJu0Yxj/nvuh+Y0vWq03Gth5FUCrhsaLi/WG31nFqCv0VPYglEmKiUi C6eaUCm9UU3qNOYkfffTcfQejdjZirMASbl/tk/qNJa2oBYSoaI61qIBXFh5rwc= X-Gm-Gg: ASbGncviPUL2/ZMzs4B+cf61nYm2OsXgh+Uee7lTSlAieWrDq1OW2PUebaI0zB3emzy ODZhQISbSdVF55Lnv0rFtQNLIzHIE87dB3l433HtUnewvyC1P+yKQDMXP3M8/8v+lfsC56xDhCg tCO6hgrmdjBVtXKdrWkn8haF4b6vaUCBnjdL6iZiU9toiE9ukatsSVFlHpA7TF7Nqycaisi9281 LvNdy4i6nTtobZ5qcOi5gNpDnUQTUKfyyGi1Km5NjxAtD6a/L154iLolOYJUcb93+sA+AI2ivX0 DqVEYocYbZgD9ytX9kaYmVtRIijeTpzRQMdf8sBCU8Y00z3JplJLClFuogdFuEgytjgmzxBCPwF 1boBMAlZKCw== X-Google-Smtp-Source: AGHT+IFbzXWayjdSMfWjy9cwjYueSFy4YBp7IQ8OjzR2IKI5f4QLOeDnV9cvNi5W4D61UevFMTrZwA== X-Received: by 2002:a05:6402:239a:b0:5e5:552:32a8 with SMTP id 4fb4d7f45d1cf-5e5055238efmr931950a12.8.1740751645786; Fri, 28 Feb 2025 06:07:25 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:25 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:19 +0000 Subject: [PATCH 06/18] rtc: ftrtc010: drop needless struct ftrtc010_rtc::rtc_dev member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-6-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060727_318473_8283F34D X-CRM114-Status: GOOD ( 14.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-ftrtc010.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-ftrtc010.c b/drivers/rtc/rtc-ftrtc010.c index cb4a5d101f537e20a685bb022e6f6516b0df8271..02608d3784958e69ec0ecbdb9fcc8b333b19e7cc 100644 --- a/drivers/rtc/rtc-ftrtc010.c +++ b/drivers/rtc/rtc-ftrtc010.c @@ -28,7 +28,6 @@ MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:" DRV_NAME); struct ftrtc010_rtc { - struct rtc_device *rtc_dev; void __iomem *rtc_base; int rtc_irq; struct clk *pclk; @@ -113,6 +112,7 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) struct ftrtc010_rtc *rtc; struct device *dev = &pdev->dev; struct resource *res; + struct rtc_device *rtc_dev; int ret; rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); @@ -160,29 +160,28 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) goto err_disable_extclk; } - rtc->rtc_dev = devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc_dev)) { - ret = PTR_ERR(rtc->rtc_dev); + rtc_dev = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) { + ret = PTR_ERR(rtc_dev); goto err_disable_extclk; } - rtc->rtc_dev->ops = &ftrtc010_rtc_ops; + rtc_dev->ops = &ftrtc010_rtc_ops; sec = readl(rtc->rtc_base + FTRTC010_RTC_SECOND); min = readl(rtc->rtc_base + FTRTC010_RTC_MINUTE); hour = readl(rtc->rtc_base + FTRTC010_RTC_HOUR); days = readl(rtc->rtc_base + FTRTC010_RTC_DAYS); - rtc->rtc_dev->range_min = (u64)days * 86400 + hour * 3600 + - min * 60 + sec; - rtc->rtc_dev->range_max = U32_MAX + rtc->rtc_dev->range_min; + rtc_dev->range_min = (u64)days * 86400 + hour * 3600 + min * 60 + sec; + rtc_dev->range_max = U32_MAX + rtc_dev->range_min; ret = devm_request_irq(dev, rtc->rtc_irq, ftrtc010_rtc_interrupt, IRQF_SHARED, pdev->name, dev); if (unlikely(ret)) goto err_disable_extclk; - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); err_disable_extclk: clk_disable_unprepare(rtc->extclk); From patchwork Fri Feb 28 14:07:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996488 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9A70C282C1 for ; Fri, 28 Feb 2025 14:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=AjKfnR+Q/3IjbU0BZixMrRX7u/ F4ey40uh25b6axXQkbHl4y14jQu5B+1GttEIIt6j26chEadVgqgrixcSn1s0+94aT9y0JIc/jI3mw pp5wM14sxHDwOGjZEZ8wHgKUcaX5nsTZa+xf6t+aj9N3kV8K6Dw8uw1F6ByDfSDBaHZIg3+f9Pm3D R29oB9C3irJxQlGfyPodCHr1krJsP3atvt4rhoW9NAfFO7WcCOKWIwbmyEuKceK6DEmQ6YSzQCcxr nTxX60yfq9wRwuYeoISMwr+AZ8gesJ4FBoG2g8P3WHvZ4kWnsNuZPwB0IVivYBaanTAM4tBfwcTJr 3NeUPBMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Dw-0000000BEe3-34hb; Fri, 28 Feb 2025 14:20:20 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11U-0000000BB6V-0YCm for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:29 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5e04cb346eeso3601930a12.2 for ; Fri, 28 Feb 2025 06:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751646; x=1741356446; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=p4yVOAy3csOTsWpp6mGDNtxmnTrMNFqbdiNd2nBPu2gbRkRykRgqC1KBGPpAPkbz4m y17/r+/cbsmh8MzeSUWVINhjhZmzDmXPLP6dkfn5e2C0Uh9necSCION/UxbxGqkhjoqj rDHetFl2PR3Hcf51CaG+fmNEOVgZFaijYVDonqVybwN9zwwiIqDtwyitpKlcjM05vLNg QeZ7T0MB4OnYWtRAxyEJefo75iRKz6G9n3GUikY54BMUlw6zmngcZmbDhtX1Iha6+ZWF 6n4mCOOL5XWssG0OPObszW5CNbIyuBbZFVgJqNKA2aWhge/nS98lGd0TEil2M+XlFaCu ENGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751646; x=1741356446; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=MZN/L9dBg9qhQKKcoduKIOHUyq7x4DOxErIeH5hNyzymxpnItL0Mmw7oMhD/Gyiq9x 30yPkARqlJCkH5KosiSEM67nFXzBEx8h+bn4pGXMackicrIA7rcuiqSyQ/bfGtHnrs9X j55JZzwdtXbSnURTYRIiHQtBmWVSRiPBQ6a8GQv5m8or2xg1rReeH41nzua2Noodk1eq dHKfNzooEbv1YLg8UcwtD4F9SY+tvSHMWv5P63K5BvydgCrPWFRrU+j+SC1E1BanNdt/ eiGQ3LLPQWq7aWn7msfBewHFceDKZynE2U/mnLiXwoMfv4hkWbOBJTeXzzZzy/7Gs0yB DLxw== X-Forwarded-Encrypted: i=1; AJvYcCU4TQOXfaMib9cvS/R+4ObBNBPKNzOfs2AdtuWjfCJkB8KLabaAnZAclsoHl4CME7mlY2jb8DcJpFmCztERAeOv@lists.infradead.org X-Gm-Message-State: AOJu0Yx8vsbHyiyHZKm287ofkw1DSXPUrSbwd9jiA1BNOjCO26AEeIVn NlPI2kjmOtE9uq31IYnV76TDYtMEUn9fkMXdecI+p3T9JeVibvfvNPKhlY7uGMw= X-Gm-Gg: ASbGncsH9mlLxf+nKgEJcyJKlFwhqy+/yc8qeFBRvhv29/GqB0A5CG5t++7dziU6CwJ 4m9qTUxcyFRfINn8t0Ko0FjW7sn5VeHIRIlUUeAFQfLtazYVGXphEk/Z6Ovij+xuIKQNqmQekJM TF6IyFva73RaMse7TgoI4rV2qNarrYB8BK4lbl+eEk8G4khei7IrKeVsbSCFTCGjo1xjP9Qjk6c l9Ymdx5VYUQAdBkLNmUz6hNEIliyLdVmPZM27ZpA57J2YGenGHUjZsNq2rsxEOnWdseeW02RXOH yggupaS4C8AW0/5SIiVx+uOh6PJgzPXghSHnIBQA/Wgqer0Wmkw1aeKXO6WK/1p8eBRgvKMsdyI jldkRw5SokQ== X-Google-Smtp-Source: AGHT+IGw8/Em8B8f2s0ytjmI+eWh2dyA3vFh7dmQ8lnXofAka3id8ECQEXS4gzzEIESeh9rUlyHc/w== X-Received: by 2002:a05:6402:270d:b0:5de:5263:ae79 with SMTP id 4fb4d7f45d1cf-5e4d6adec08mr2881207a12.12.1740751646341; Fri, 28 Feb 2025 06:07:26 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:25 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:20 +0000 Subject: [PATCH 07/18] rtc: m48t86: drop needless struct m48t86_rtc_info::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-7-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060728_172342_1663F9C2 X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-m48t86.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-m48t86.c b/drivers/rtc/rtc-m48t86.c index dd4a62e2d39c73b1c8c3f50a59fd4fffc0b45105..10cd054fe86f9e6be74eb282222b2751dd91cc7e 100644 --- a/drivers/rtc/rtc-m48t86.c +++ b/drivers/rtc/rtc-m48t86.c @@ -41,7 +41,6 @@ struct m48t86_rtc_info { void __iomem *index_reg; void __iomem *data_reg; - struct rtc_device *rtc; }; static unsigned char m48t86_readb(struct device *dev, unsigned long addr) @@ -219,6 +218,7 @@ static bool m48t86_verify_chip(struct platform_device *pdev) static int m48t86_rtc_probe(struct platform_device *pdev) { struct m48t86_rtc_info *info; + struct rtc_device *rtc; unsigned char reg; int err; struct nvmem_config m48t86_nvmem_cfg = { @@ -250,17 +250,17 @@ static int m48t86_rtc_probe(struct platform_device *pdev) return -ENODEV; } - info->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(info->rtc)) - return PTR_ERR(info->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - info->rtc->ops = &m48t86_rtc_ops; + rtc->ops = &m48t86_rtc_ops; - err = devm_rtc_register_device(info->rtc); + err = devm_rtc_register_device(rtc); if (err) return err; - devm_rtc_nvmem_register(info->rtc, &m48t86_nvmem_cfg); + devm_rtc_nvmem_register(rtc, &m48t86_nvmem_cfg); /* read battery status */ reg = m48t86_readb(&pdev->dev, M48T86_D); From patchwork Fri Feb 28 14:07:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996493 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90020C19776 for ; Fri, 28 Feb 2025 14:22:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=FcQzl3grsXOiVc1RdoGMCeyXrT JycWBIh+7ZI0+8WklQMLSG9HFGXaHAo+PjHhmhme0p/rJG5kqeE3/r7PPp5+mxBS8VNre9rxZj2s4 f6iu7XACAiBq+HuQ6AKrq/VBJVCFB/+Z3J7nFwxEWLjlW6e+uK0gYW0/3xEOlkAQf36fHPIkt8w33 RPRdA420vMqJKM1EgCtkayIP3cWurBk5hNlQA6Fxm18RgIi5zwmIIU6FLJk35rkUVCioPSk2YsHZ0 H80Ad/nKcWkk+etQb7xKjVV5Occ+i+OY5FPA+XKvbwdueDidOFajL8zxnjInZoLiy0uJLg3z3igPG CmTNo+5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1FT-0000000BF56-3FQl; Fri, 28 Feb 2025 14:21:55 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11U-0000000BB7I-1bNn for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:29 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5deb956aa5eso3239658a12.2 for ; Fri, 28 Feb 2025 06:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751647; x=1741356447; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=aVcetOIQHsUcyIeSUA7ovu5xYQAymhLIBjvDdHoVM4DkeqHws9LSRYQFQLjDA2RxDI 0lAMT0wfcc0y8jYudqXaZUGp3QIGN7gEkoKxUgA1F+wJik1kNXEiklFkzzD0h6MgZeLN 13mGxVQ0JEMOBsdjCuews3QsPBzwWyzo06O013+An7I5FMoaAzc4gUhPd/UYJnhFLy1c Ef30Q6cQzE+nrLNB5sSrhNateSfrbGOFsmuEI4FbofAhbx8Avk1jWarjAOrHGIW2EjTd /Lob8Uviw9gas12/0pCMA9MJFNfxWcIgjBGk1ECjHR/C8MNVp0u/aexZpBaZUPalOMvM 74/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751647; x=1741356447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=m5nhDVjEvyWBvNeY6boaWZXOXJx1F5MIn7/x6qYguPM9hpzSQcLMh4f4t6wy6p+pr/ D59Sq2y7JcmDlrw9R40GDFzEj7ToQ9eWEiOFwu4H8jIZpZtAnUeg9YOQUM5WsES8SEpC 75t0alup+cuPq2QIlmU3HJgsF1XK/h2ZaOXS1tVjas6I4FB4ZJt3umbIlnCGhRyLrkKs ItOYEySR9JMCG9TiNl5+u8fwLkZ25kG9ecfasG2f5yD4r4BQ0rpjzHcJoAivoiiSF+XS +dRkAm+rvxfLS+zHQNhHUF2Ah9LW5t/nWLOjZFeakmJRBLg6ZR6ynC4jwnz8rk3AE6lY GTsQ== X-Forwarded-Encrypted: i=1; AJvYcCUELQ6euQZLh/guq28hxMuOhMdRI+HixdmkwmIQUic5Q2oD2cAYhr5z6CTJA+bKIw1kmKh1FF0Y146XbIi9K/1N@lists.infradead.org X-Gm-Message-State: AOJu0YyjR54cx3+3vdbq+77bpnR768jgZbuvAQFT3OqQyDcBBPOQzQFj v1FAkZGiaRm+Xb0y815eJa1zUaiw+OxuN3mPjsZIbFnvVK4sn9Kl5w4N5j4mwxc= X-Gm-Gg: ASbGncuwJo0Mb0mkLJ61vVeqvXY7sE228F+XFsGYO9nNJ5bUnKYvYRa+tF//0tWqBn3 +gnuj/xXWBoAzCYK/gr2jqVzm/jAkZai9q0PcL8CjeE+giudXZyj3rz5uzt/Ed0YOMhjhTN7S+H A0pQRGkq2LLL7jI5JAPUEb94ndKOg30nEd46F2wSdxMbfE20hdpy/pGNfmJG21ska9ch3MIV+Hd 60qPCOSnX5WExm11xM49a4m0apiSLnPVdqHPA5txsyzVe28BktRI+hWG7BN+VEGtO9ki3YMmbYP h/MqPneKLfx5pMwtvUoR/ozPmpTzDupvK0qajz/q/z4zYVjWSzr1sHOJBBhRA5r8U4a5/djXyAx caOYwV1i5UA== X-Google-Smtp-Source: AGHT+IELhJPOd4W0qPAgNgABcD5moXsKlcKW8ZKlMd0/6RuVXfSWqRkHz67gqaNmak1AZcnDjWmnpg== X-Received: by 2002:a05:6402:50d0:b0:5e0:818a:5f4d with SMTP id 4fb4d7f45d1cf-5e4d6b628aamr8322653a12.28.1740751646827; Fri, 28 Feb 2025 06:07:26 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:26 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:21 +0000 Subject: [PATCH 08/18] rtc: meson: drop needless struct meson_rtc::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-8-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060728_433054_B81996D9 X-CRM114-Status: GOOD ( 15.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-meson.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c index db1d626edca5fbb590f26c1cdd0774d350244a99..47e9ebf58ffc2f2b6c65932f8ec3773a213a62ef 100644 --- a/drivers/rtc/rtc-meson.c +++ b/drivers/rtc/rtc-meson.c @@ -59,7 +59,6 @@ #define MESON_STATIC_DEFAULT (MESON_STATIC_BIAS_CUR | MESON_STATIC_VOLTAGE) struct meson_rtc { - struct rtc_device *rtc; /* rtc device we created */ struct device *dev; /* device we bound from */ struct reset_control *reset; /* reset source */ struct regulator *vdd; /* voltage input */ @@ -292,6 +291,7 @@ static int meson_rtc_probe(struct platform_device *pdev) }; struct device *dev = &pdev->dev; struct meson_rtc *rtc; + struct rtc_device *rtc_dev; void __iomem *base; int ret; u32 tm; @@ -300,16 +300,16 @@ static int meson_rtc_probe(struct platform_device *pdev) if (!rtc) return -ENOMEM; - rtc->rtc = devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc)) - return PTR_ERR(rtc->rtc); + rtc_dev = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); platform_set_drvdata(pdev, rtc); rtc->dev = dev; - rtc->rtc->ops = &meson_rtc_ops; - rtc->rtc->range_max = U32_MAX; + rtc_dev->ops = &meson_rtc_ops; + rtc_dev->range_max = U32_MAX; base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) @@ -365,11 +365,11 @@ static int meson_rtc_probe(struct platform_device *pdev) } meson_rtc_nvmem_config.priv = rtc; - ret = devm_rtc_nvmem_register(rtc->rtc, &meson_rtc_nvmem_config); + ret = devm_rtc_nvmem_register(rtc_dev, &meson_rtc_nvmem_config); if (ret) goto out_disable_vdd; - ret = devm_rtc_register_device(rtc->rtc); + ret = devm_rtc_register_device(rtc_dev); if (ret) goto out_disable_vdd; From patchwork Fri Feb 28 14:07:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996494 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C9FBC282C1 for ; Fri, 28 Feb 2025 14:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=oydoyuIRAlDNKJAv3/xPmEvr5c VpFafmb9SiIW9pHxYZsqpLno13G00/EJaXZJOo9PL3cKb4R6Xx4w83+hTHugUzV6gEAOsWFhtgV23 MYyN2uxqfNiYB7K/c+HR+fwaA+swosfpgaL1JmVga2ytqIM1zAWaiI6XzteIk4v406XF+z7TwCiYU tTlKckULaM0aL3mG/DGQoL0Lc1uAYIBmsaeh+JxgwOAworFUqtGTw+INxKwQS5RbynzNXMdgpIRBT qdmkmS6niDH0yvOk4BBiAzW3kiNTIeFyaHOkO5g7hiw0DEu94Sx1mSfFUDGN9w3QFhTaonrkjNmIA 2kxaX44A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1H0-0000000BFMF-3CfL; Fri, 28 Feb 2025 14:23:30 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11U-0000000BB7x-3A57 for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:30 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5e4f5cc3172so933672a12.0 for ; Fri, 28 Feb 2025 06:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751647; x=1741356447; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=Skmg0PDZ6aTEM1UQM2YOYOU4KpBZIBFqyoOQ5W5ch3JCED4Sw62F9ujqUT0TZE+lf/ 9zoRCEezZiJ8Ja5hhMhtbjvGTZfhOAu0IpQjlCMFOLi+jh5kQ8FaHhOw1snclIBL1v0W aooVUH8fn5+R8Qji2X6xLdaS2TbVyRl0TE8qrlfAjtUkYhh35/MAZDYLJp/zoOZP8xrw oYtIOK9sbLjLS3PTHGd+bBaKG8AqXS/Iu/8GNpBfZLixMrHonhL++ifyPGTC5gT2oqKU wJgFeb3YhxIn02RDelaltOnsOMLI2CGKuZ2N/WtlJhe0rk4zoW8isBn8mtY/yoSKhJSp +aaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751647; x=1741356447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=KgimeBMtSHl4RGUCz7S251OguQk++u91xaJ0KZQ8PCq/OmWzb+EEfoCFL3Va/1zn/0 IWNT0qiwvtNRoj67Szm6oAiMuUDcWrYil1nn0gxhgOJ7LlEN4eV5fn8exanSmIggdpAu t5lOD8cHNPeb/Gh2Qc+rien5T2Z+wSv0subvB/bet61EyLzlX7B7igHQiKwFYDirMuIH wie2CewpblbDv7tTum0lmZ7bIWg5JTbzA9k/v6GAvHfI25YCDTrnpBxG0aMjObJq42Rp LofBDvPEXssVOz1nX09DrcCYn6Il0VBzN6bu8puqHphuoJhPiGvLq2+6GI4fC8HklG8Y 1zhA== X-Forwarded-Encrypted: i=1; AJvYcCUobtHrLmrfu5kBBsaw5khyq5daiFUmfwAk636AeHmYEpmIxNWbBRzJFeTbFIBKFKGjkwvI+dM9f8oPAcGVv3pd@lists.infradead.org X-Gm-Message-State: AOJu0YzDL7LxyOLvVC7s+nXdA66rSkJFtCWG8meduNfxc7KU/mcnWYh9 Ip20ykhlXSe9GYiNywaimtd7ob166zB9nYBlkcsP5qASvN8J2ewYJTI9WOmEdSg= X-Gm-Gg: ASbGnctqeMqcviSCxBAjvGQsOcYzqYmIEPOy3rSxSAA4qCFfwhT9WKutrAK27FI9yHf s0Mt5S88g3vCBomjH4psY89eHYzy1os760VKr1vN7bIhJwkbhdWUJldZKZlYuzQCWA8YlIIWauu vLWVr+CpnpGEvwUlgOZLmILyNuEZxItJXb7npHb++v7ur/VgNADcfECiXdJZsuYQUdDjWrQdDIO N2bdFyIArhYvKZZWk5vdxt5yjGK+yUw5/p4fmzm/0nZZDatRIdIrPshUZLFscIJ5sjUwRrciBH9 zEqFVU209v7Wkdtqw4ecdYS0deIxPcWmePJk3hqv/EE/QcVoVwMMio64fWGN7yRYW+6Y+DlNiaZ YrKer59HvHg== X-Google-Smtp-Source: AGHT+IGZCKi+h7liDGF2k254zFpRo0bnTt6a/BEgRPyIDc7kptNekspya74S4whe/rs/kwdpZDQeGw== X-Received: by 2002:a05:6402:27d1:b0:5e0:82a0:50ab with SMTP id 4fb4d7f45d1cf-5e4d6b6240bmr2836488a12.27.1740751647311; Fri, 28 Feb 2025 06:07:27 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:26 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:22 +0000 Subject: [PATCH 09/18] rtc: meson-vrtc: drop needless struct meson_vrtc_data::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-9-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060728_807972_F98BC78D X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-meson-vrtc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-meson-vrtc.c b/drivers/rtc/rtc-meson-vrtc.c index 5849729f7d01d7ec7868ff3bbdc5ed599aaa8238..7d38258cbe376e5a1b2af6250cb6d04c313175fb 100644 --- a/drivers/rtc/rtc-meson-vrtc.c +++ b/drivers/rtc/rtc-meson-vrtc.c @@ -13,7 +13,6 @@ struct meson_vrtc_data { void __iomem *io_alarm; - struct rtc_device *rtc; unsigned long alarm_time; bool enabled; }; @@ -65,6 +64,7 @@ static const struct rtc_class_ops meson_vrtc_ops = { static int meson_vrtc_probe(struct platform_device *pdev) { struct meson_vrtc_data *vrtc; + struct rtc_device *rtc; vrtc = devm_kzalloc(&pdev->dev, sizeof(*vrtc), GFP_KERNEL); if (!vrtc) @@ -78,12 +78,12 @@ static int meson_vrtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, vrtc); - vrtc->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(vrtc->rtc)) - return PTR_ERR(vrtc->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - vrtc->rtc->ops = &meson_vrtc_ops; - return devm_rtc_register_device(vrtc->rtc); + rtc->ops = &meson_vrtc_ops; + return devm_rtc_register_device(rtc); } static int __maybe_unused meson_vrtc_suspend(struct device *dev) From patchwork Fri Feb 28 14:07:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996495 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66A7CC19776 for ; Fri, 28 Feb 2025 14:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e0FEi4ElpfP7bsjHYl+IPy7QOEVjafD0mk0qg+EAmzU=; b=O/kHH53p+6jHsDdyhft6VQE/xJ RJWXm7zcU+yAkCdZMY6LWYGgoFRnLmjhLBsf+4iJBswOVO259B8a68N8nai6/mS8jcTvVIgzC3u27 ko1UeUbJXmK8k9swiYDMh/ZeGrlj+CMB6G+nRl5DclziqRoZMAAGpDlsHSYkhdvJnhIh6R/nKGG/y +xXkDKMQgRHBQ9pw/WWEeowZ7nnAvLK9VpzqZWAV8vzmcYK7sj+UZO+Pz2/zs7VgwznlTCf4Ghsv4 rdV4YA3b7lwxcHvBgztm991QsBNg9GDQQcazsak6+OaMn1hI/W73B4QGv6o+xfBVIvxHTHhRMaX7S o1oeXZBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1IX-0000000BFjr-3klo; Fri, 28 Feb 2025 14:25:05 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11V-0000000BB8l-0pVl for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:30 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5e4f5cc3172so933687a12.0 for ; Fri, 28 Feb 2025 06:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751648; x=1741356448; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e0FEi4ElpfP7bsjHYl+IPy7QOEVjafD0mk0qg+EAmzU=; b=rSrf8/d8uc8mn1pQwKYXTj5/VzZDMToUwpAawpOtroUC5mgEaTidwjRN1vvSxF1Z9B /31zNJIB0jeRfO6MKmXWapI9P7YQPo2juPOQ4hx/mk4pFbFNuZsJ7cv8hYUGlr55krto 85Tgc1zu4rSaEcwmR43brfrbTgqL21/taFaZjZZr0EyqfsvzhwjKLSKVWP+L+LZO/LFB /UcVXuKxiZ/rAwIi335Rk1n85DMjqlFczwbMCgtGUJjWtI7SZ3hFWjyLYBC9rl6NDIpq OkJ26yk6QrjBbbp/GbU82SQKT4RbRc3Fs8A1RnQVf/qJ3rub4eO3wTRIFvVSRVlUuRKu ChWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751648; x=1741356448; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e0FEi4ElpfP7bsjHYl+IPy7QOEVjafD0mk0qg+EAmzU=; b=ub//9XoUgrBtnlh0pBVZU4G82PAL86+8LLhCWEXhhJjP3RaFtCbf8MxDnb6+EXiVrm WQnkHLAerDKI3avpmwOJAOLm0LlvOV9XDPK6qYTWrHKEnJIfnFIA8cfO5aSdWuGU7Pj6 BKVn8HSl9zVCtq732TYO2wAKYC1hDFKoal4xHi5EqrkXM3tVB3xIuSAVs7S5OKPhwuf3 jeyZc2/I7e1dz4/lKyTFTSOZERufOrys8Lfq5j1kF6BZvblf+lOnA4+ogoNZEixFqfn3 5Tl54GIGXSO6xwbDWGgTcXnJUokIBVgQgawMshy13XPm4AmCO2LpE0uL+XZYVY6/Sm6g 9qmw== X-Forwarded-Encrypted: i=1; AJvYcCXsZ42q0imRpm1KBrd44SHxAF9uKVJ3Ogy1KeMJMo2gLbGiu5+ddu2PdVWs/wFofik1gZOEOqpusw2IlYnMB6RW@lists.infradead.org X-Gm-Message-State: AOJu0YxrCmLRrfJTb2CVl4Xj3M0evjkZEy/Rw64cU+KUQbCXEFPPVMSE FV4nAwqLVXD1NcxEkSy3XT0S+nVGPB5pt/hWr/Pr6dhB+0rXstDpMnRMSfWLwRk= X-Gm-Gg: ASbGncvzXs6yCxORnUpqPU5U5RmYlNS8iNuNZ8T4sYsfk+uTcmXlm7724Endf0eBhD7 Z756+sPCV9tpPJjW4wX98QjbChAzjeuSTmNWkrm5h96haVHQnvMl9LLIlWvyfrE4YfUtgwRyNbl l0S4XbfoQrKmvNPY5K3oqyhb7tA+/Lu1Ljp6FtZGEZsppHDaJvWre0E4fgYJU91tQe+nZgxMqaZ XL40W1oaR955eaCXn72tBdeFJ+dEpkgFv2mBAkiVsCGGqlOZxotW6bzC82OaXnst5pDYa0H/zoo WfosezXGog4zQt7twdz+GgFL5klA92o+WDH4S5WROTe7wN7ToaA51mMJP4AIpcCt/OfnY41HYdO x5ruFzz2FXQ== X-Google-Smtp-Source: AGHT+IFd5qkPHWKs7u0kGQaxuAKFWYEyb+eqqsQgE6/A1ZcU9oZLI/LHqjeh9PQlI3f0EWIivI7Brw== X-Received: by 2002:a05:6402:26c2:b0:5db:f423:19c5 with SMTP id 4fb4d7f45d1cf-5e4d6ac4066mr2619097a12.5.1740751647799; Fri, 28 Feb 2025 06:07:27 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:27 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:23 +0000 Subject: [PATCH 10/18] rtc: pl030: drop needless struct pl030_rtc::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-10-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060729_278938_C87051A3 X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-pl030.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc-pl030.c index 39038c0754ee55a952e5986afe711cffff35840b..e7c81740061bb60c4d8447d6522819685bea9180 100644 --- a/drivers/rtc/rtc-pl030.c +++ b/drivers/rtc/rtc-pl030.c @@ -21,7 +21,6 @@ #define RTC_CR_MIE (1 << 0) struct pl030_rtc { - struct rtc_device *rtc; void __iomem *base; }; @@ -86,6 +85,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) { struct pl030_rtc *rtc; int ret; + struct rtc_device *rtc_dev; ret = amba_request_regions(dev, NULL); if (ret) @@ -97,14 +97,14 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) goto err_rtc; } - rtc->rtc = devm_rtc_allocate_device(&dev->dev); - if (IS_ERR(rtc->rtc)) { - ret = PTR_ERR(rtc->rtc); + rtc_dev = devm_rtc_allocate_device(&dev->dev); + if (IS_ERR(rtc_dev)) { + ret = PTR_ERR(rtc_dev); goto err_rtc; } - rtc->rtc->ops = &pl030_ops; - rtc->rtc->range_max = U32_MAX; + rtc_dev->ops = &pl030_ops; + rtc_dev->range_max = U32_MAX; rtc->base = ioremap(dev->res.start, resource_size(&dev->res)); if (!rtc->base) { ret = -ENOMEM; @@ -121,7 +121,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) if (ret) goto err_irq; - ret = devm_rtc_register_device(rtc->rtc); + ret = devm_rtc_register_device(rtc_dev); if (ret) goto err_reg; From patchwork Fri Feb 28 14:07:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996506 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D972C19776 for ; Fri, 28 Feb 2025 14:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7nzHwlkUM09BG0CuM/bA+EpIQxILewT/ffWeXrAz77U=; b=THZFPXMEy2XstZlaT4rpJNy7sZ MX3F8dIohmm7QzGv29BgSYPt+9374uMB4OqVoM8IzUS/Q3f/rAbt69JtrFTgUrJiJnQJ2vHgmZR1G OerKoNbDfyzdfKyjDG/zp62O0/IJu78L5yuACW3Whsw9y1qIUwxAS6ivdJktP//Jt0JQyRMmG2Z8t LMVDW9KBZ8JI4Fj3bpcSQiTvxDZBDDGuJiQsrARZBZB6I/OabhBRtbLkbh6NOI7ogk2kyoe6wxq64 FK0bCUpLnXH9dtZPe8rmRt5uvh6ZXgePeiRc5J2NA5qPNGlgFO84ULKaqMe0D9RVYyAErIl4+1VGY P7y/Q0Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1K5-0000000BG5u-3qrO; Fri, 28 Feb 2025 14:26:41 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11V-0000000BB9O-3Gn3 for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:31 +0000 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5dccaaca646so4075424a12.0 for ; Fri, 28 Feb 2025 06:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751648; x=1741356448; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7nzHwlkUM09BG0CuM/bA+EpIQxILewT/ffWeXrAz77U=; b=Gf4Kp7HassYmg1Bt0wmPC5X8yp8JsSeJuFeavsXBwKns8Dt33e/hV7STgjF+RhUxAG UUJtDJepClki3qSKqnzPonVliB3Q2dZRJmPWiMTNp8wh3C2zZ+toklLQmHZ2aDs+nOWc gkJZ3vLHXSYt+YKTK7RmeOjPiKXFG+KWT/bKHuj3he7mvrYSLde3C2+nj5xgMF18xsQU GnExY6EWhdna/LYH0vlpzpBF5cTqEeODZgaCBYUcNS1lFrd8mE8Qd6YgJ2xs9ndQKgw/ 7mYTLzwiDM2KJoioygrXw38GuInbmPej6hovLu7PpEAZ90mYONIVI+odTHofvzKrLOxF uEvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751648; x=1741356448; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7nzHwlkUM09BG0CuM/bA+EpIQxILewT/ffWeXrAz77U=; b=w9IfEo1p0ldtRLv8wyG0PUen3xnuJQhyh7FKNnRnfdbNR27vwXj0mzEz0CwDo1bmSw o2KX/R71qQN6KK1QsIjA59A3QXGihc3uPqSc6FjRx+KxiQOsT3uMjgIKi3trhvh6biT9 tiA6+QMxk9vCqwZJ0jP97qoYVnX4oBbp8JD4+rRVPmrSZbTgzZFu2lZCMsoYK9vdEuiP cyk69w7TQG5//7OQb8EvYQDaCH4SEbgy3aO4ma9sQspaPpMXy/zwE0rulYFlre1WqLhk 84I5PJOxAGkJGh7WwSGmJoggHyHk1G8DGp2X2gSUPdK2ZcBN2PDr5JtEE8fVZEAKnUdy Dk5g== X-Forwarded-Encrypted: i=1; AJvYcCUH18fQd2oX1jcYdplhcoBwULi71EvskWvfULxcPXrmrqN5kL1QDmuQW8mpUuIbGS7NyeGRAG6L2jnsCwowTlDZ@lists.infradead.org X-Gm-Message-State: AOJu0YxJJKHJcTziz3zVkAxAfHeBNuc6FFLsr7efRLBqJv/8va3sWTG9 mthcr3lYDH63F4SzTIWG3sn619RnHW4TM6WQWHzy83fmBj+RPn88IfPEB0gML88= X-Gm-Gg: ASbGncth3NgOQGAONXQ/RaDF3GWHP5bneysEROxt3L2B+sBmIdjesarlyxMYHCuYo7Z kjgXenlrO24DU/IArxAz8nk5qq39VOOhOhcy/LpHzIxFwSKCzpbK8saBoUighlNP2M2BNw/MnjD HtIO20EaF0IkfTBz+OteZkVwTXiFqMHZMDH698IXMGvOOuV2stv7vWPvjd/R+t2SkQj/vHkOWbZ lyZW3EG1AE4E91X+jNYN4WUPNZNY6GazWBj3Gp+Ma+1MF4DGmPQovPEDrD+p3DXD2vr4GN7CJgg m0aJlWjxrmGQ7TthBNOMhZR4fj8Rhr5AuhZIXcwHPSFLExZj95fAyg0PRxU/FtgUjBXfs9L9fqf JzuBFj+ejZw== X-Google-Smtp-Source: AGHT+IGquByOTAI+pOBsMihZmYnZaIy5p2XitRnKkTWDJg07k5RO868wRYsHEejBUavy8mEmWjqo9Q== X-Received: by 2002:a05:6402:13d4:b0:5e0:8a27:cd36 with SMTP id 4fb4d7f45d1cf-5e4bfacb0a8mr8959084a12.8.1740751648271; Fri, 28 Feb 2025 06:07:28 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:27 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:24 +0000 Subject: [PATCH 11/18] rtc: rx8581: drop needless struct rx8581::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-11-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060729_811293_9A9C114E X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-rx8581.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c index b18c12887bdc3705ea4cee9b8d75086a05b24e71..785ebaca07ac971eee34559f8d1e0a8a872cbba9 100644 --- a/drivers/rtc/rtc-rx8581.c +++ b/drivers/rtc/rtc-rx8581.c @@ -54,7 +54,6 @@ struct rx8581 { struct regmap *regmap; - struct rtc_device *rtc; }; struct rx85x1_config { @@ -252,6 +251,7 @@ static int rx8581_probe(struct i2c_client *client) struct rx8581 *rx8581; const struct rx85x1_config *config = &rx8581_config; const void *data = of_device_get_match_data(&client->dev); + struct rtc_device *rtc; static struct nvmem_config nvmem_cfg[] = { { .name = "rx85x1-", @@ -286,21 +286,21 @@ static int rx8581_probe(struct i2c_client *client) if (IS_ERR(rx8581->regmap)) return PTR_ERR(rx8581->regmap); - rx8581->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(rx8581->rtc)) - return PTR_ERR(rx8581->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - rx8581->rtc->ops = &rx8581_rtc_ops; - rx8581->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - rx8581->rtc->range_max = RTC_TIMESTAMP_END_2099; - rx8581->rtc->start_secs = 0; - rx8581->rtc->set_start_time = true; + rtc->ops = &rx8581_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->start_secs = 0; + rtc->set_start_time = true; - ret = devm_rtc_register_device(rx8581->rtc); + ret = devm_rtc_register_device(rtc); for (i = 0; i < config->num_nvram; i++) { nvmem_cfg[i].priv = rx8581; - devm_rtc_nvmem_register(rx8581->rtc, &nvmem_cfg[i]); + devm_rtc_nvmem_register(rtc, &nvmem_cfg[i]); } return ret; From patchwork Fri Feb 28 14:07:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996507 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA5C5C19776 for ; Fri, 28 Feb 2025 14:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=0s5siDOKt5YVc8K6BhOwtVjiPs zlcMmBuAldIYf3VSSXCG6+9Ccs34SzGE1sWovYn8aCpzi+iOQYlMWLB+Py7r0xfx07W5qj8L+txlm 1umwbJqnDH6xPG9ogbFGHmOMATIIBhLbXkKFhjFmZX2VJgT0l+l3uWkcAkiz0qOPcvt2HJZtlUWbj 9F7EjXx/aOk6iM0QeBtKinBvpABk6F6UprJqRHLRbNY9iWpv+OzQ0pMcXErZPwILYYdHO/wVNJPT0 7O0UlK2h+duhm2UYC1bIcVLXuyjZoVzreopMXII9shaGt5NdUHdG2t8SBj6Qv4sNFTwtx0spMtV3J tPH3Oc1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Lc-0000000BGQb-2iVa; Fri, 28 Feb 2025 14:28:16 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11W-0000000BBA5-0eje for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:31 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5e04861e7a6so3512928a12.1 for ; Fri, 28 Feb 2025 06:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751649; x=1741356449; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=I2QDvE9wN+g16Z7rKZjQU/K6ZyJAh05OKQtvnHRRZ/NX7Qo60eGE+dm8BKfzrU9iKF H4VtWcTaPRD6eL+CY91buxH7GcwnUrBJZ1sOvxJMOMk8bNMMlsPmkuULMQYZ8SfeDwAh YgMjP+C0daE8bbGNhggoSugyqhKMATjHZjaqz0aakz1z7gaFYEelDwo2P+Hk1MMenrlT BLN9w8ax0XNQ/NJGxcVsK2GrHXMq+tqrqKdG0uHBUg0Ylrs8u4l2Gr/qGb0VWM0hsO1n avp4lz4rxyTa1oxLElHNz+pDNz2jCIaGgtuNpqbUP7228REVsO3bsVrsDOdwKr46u5NJ B/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751649; x=1741356449; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=NttMsYCvvbFvd6h+Em2kdjPKqtWQ93SYNoNHCjQkcVE1ZwTeydSz/5zmEIJmIXrjZo +l7lRuhtL/tpN5L7Fa1z4k3xSsvwGH8yTbITTqzQ8TT8kSK6FnlrcAGcseBdEG49FmMI 6jH07dFc6MMeMZ82lsT2kN84WjemINvo9wIobcQVQqMtC+5rDxIojBvod/xKalE6bvOQ KejxTPAmhBf7MbmS2n/dD50I5Qe1ou4SJrwA1niFS6QEFJrpYPjPG6mEq3NoFceOuhz5 ZxQR+DTTkn5k39sO+jga8MNbhY0toA9DhPj/03oPcsB6cIt5RMRwpKnqFkcadfWjIZRN X0pA== X-Forwarded-Encrypted: i=1; AJvYcCUjxAZz98MS+TulOltKlDzZycMyH8tmzGnOMZhbrB3IL+QsU5Xpmcy2jUKHhM58Iq7daTNNvHqeJUlmsfCsPLOI@lists.infradead.org X-Gm-Message-State: AOJu0YxmFBmYtp9MtxMzIMW2HKUXdIvcuwOM4bcWZdmLTD1A6bu+tJct 8Hxk6l3eg8PkIosS0qldEAIdPMblBoxtJ4gKllzd9VyZj6z2kT1ZeK1q7C4ViSg= X-Gm-Gg: ASbGncv2nNJNuTu3lMWjNxqjELf94PwmLzefNgBoVOKTI6p73GGFsEnQ02GfCDPpcNz ky7t4M6eQMc5J85lVPkT+w/LoDox/tCvNLFN4zZo3/g40hoF1L2X8MhcHhvKw+YWlnfWtFaGo1p eqciQKAeNjxKA1zLyZ0R6/6cme7/RrjF4yOOv781TOqIZOFdEpnxtyzvh0hf/99F/M51t+8xHw4 BJqSf7zNsS+H8uAy7GRKXCmD25FVrHoctXcszyeKodWXz0TlhT3O4Pqv39mgybkFwuGYXojhhrM w+gqtPl/+olCm5k9db38P1d02EQpGI8UDCTznKEU4I1LVH+g/9dBjrZKJ6RodZrRhgoqQcepEI5 pedRhoUEaLQ== X-Google-Smtp-Source: AGHT+IF1zdUSX6ZhtbedenD60jZMcHzIIU2NhAe4k+oRQ6Wt3d6uE7nze1qy/Ap2/A6npGSF7Q9PVw== X-Received: by 2002:a05:6402:348a:b0:5d1:f009:925e with SMTP id 4fb4d7f45d1cf-5e4d6b1869bmr2990380a12.16.1740751648743; Fri, 28 Feb 2025 06:07:28 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:28 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:25 +0000 Subject: [PATCH 12/18] rtc: s35390a: drop needless struct s35390a::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-12-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060730_216115_ED44122E X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-s35390a.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c index e3dc18882f41445c41fbea56edbd5c869514880c..3408d2ab274194e39cde38a83567d37bd53f6632 100644 --- a/drivers/rtc/rtc-s35390a.c +++ b/drivers/rtc/rtc-s35390a.c @@ -63,7 +63,6 @@ MODULE_DEVICE_TABLE(of, s35390a_of_match); struct s35390a { struct i2c_client *client[8]; - struct rtc_device *rtc; int twentyfourhour; }; @@ -422,6 +421,7 @@ static int s35390a_probe(struct i2c_client *client) int err, err_read; unsigned int i; struct s35390a *s35390a; + struct rtc_device *rtc; char buf, status1; struct device *dev = &client->dev; @@ -447,9 +447,9 @@ static int s35390a_probe(struct i2c_client *client) } } - s35390a->rtc = devm_rtc_allocate_device(dev); - if (IS_ERR(s35390a->rtc)) - return PTR_ERR(s35390a->rtc); + rtc = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); err_read = s35390a_read_status(s35390a, &status1); if (err_read < 0) { @@ -480,17 +480,17 @@ static int s35390a_probe(struct i2c_client *client) device_set_wakeup_capable(dev, 1); - s35390a->rtc->ops = &s35390a_rtc_ops; - s35390a->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - s35390a->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &s35390a_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; - set_bit(RTC_FEATURE_ALARM_RES_MINUTE, s35390a->rtc->features); - clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, s35390a->rtc->features ); + set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features); + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->features); if (status1 & S35390A_FLAG_INT2) - rtc_update_irq(s35390a->rtc, 1, RTC_AF); + rtc_update_irq(rtc, 1, RTC_AF); - return devm_rtc_register_device(s35390a->rtc); + return devm_rtc_register_device(rtc); } static struct i2c_driver s35390a_driver = { From patchwork Fri Feb 28 14:07:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996508 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92AC0C282C1 for ; Fri, 28 Feb 2025 14:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IKZrDxBZwKYSSWAqYI1nyzOGiPZfFb6S25OWnyP8uMM=; b=rBbauxEUktinNMtz67ABIP2F8N u6jJg5be0AXv2oGlswNn1JI8PMz3W+kqDza5tKnVa3vZyO28VF+VoxdymdDflTk37HeJZDG7FQWW4 FRbmcYBDN3ZZnGS3grP/MTWviW4R+KHiHf/Pqppsb/ho1jpuUPNhj3DFBau3dgI6y4TbZZ/YgJckV Zhiw8aRH88yYijrtvk5HqNYRqJnCjRCqjoOsqInvEPeJdI7TFvoyMpt3SVJV2zsbB2oxsX6ZSHBm7 AFKJUhbXTTiaq1u9wRkS0paL6JaKU47QKQeDWIJSbX8rn2x22ztMlDR4YKNb8r3rgycfST6Li2YIs oe6QTErQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1N8-0000000BGdU-43pS; Fri, 28 Feb 2025 14:29:50 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11W-0000000BBBM-44PY for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:32 +0000 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5e4d3f92250so2082526a12.1 for ; Fri, 28 Feb 2025 06:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751649; x=1741356449; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IKZrDxBZwKYSSWAqYI1nyzOGiPZfFb6S25OWnyP8uMM=; b=xvns22eqJsqG2Gl+DOBly4VUdih7jhlWc5oKSQYKcXdP+1AirS7tkIXy7iIijS1mJr qDpDnqAX9snAsF1OwQOI0OKUQzCTDFU78FNd5KBYO6vXB5bdIsg0XXEyamhZtst+yUVU EsKspYjRA9nii9d99C774PlUzMbHKMxtrlPEfyk3cI0jUir+zfsq1ucnKhnARK3NgBwZ KzK2RT5ruU9tCDN6Eh8o5SFjp89pZVyJqDn1EvbV7EATSsEfLLzN1ebczVaClz6rnGKD 5g5I8wCWUu7mZ+mLPaJQ5GR2jKkuJImzq2L6NjizXMuMmAQw999wkmWtb2YbP6OdsZ/b oIQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751650; x=1741356450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IKZrDxBZwKYSSWAqYI1nyzOGiPZfFb6S25OWnyP8uMM=; b=a2ESxrQDarPextVpE5iF/QD/ELrQH5jZNcLxxJqBBikLX3er/ticrjlhX4vV6hR4I9 FliO4NVJ/KtYkXowkWk2YJikccYs2E1jLSEr6u/UH3fE4CFKx8WeVNL4viX74DMztBzW C2y03a+oUP9sOaY6n7LyJxdcR/Sh4oZGKvVwTGMwNYO8kq3+eXOxp2hzF7ViP7Fdq7VP ejus+QgH+CvAGGPhVHNfnCibzgCm1zfqmZLt8o3knyQiUsV9P80/BDOkTnUirfdtUtL7 bHl4eAQpjYy2jk9yf4YvlrmZDhZ9wHNiAa46i9kqNj3ZvggfT1S8pf7lClg427oWvtM3 p+ww== X-Forwarded-Encrypted: i=1; AJvYcCUXqbXqfWXLpZ9dzU5K/3vKRPLXO6DUIjfm+LecmfgzIbNuUeIs2n4m1+bMPiuHmKUEGMQfJ39UrfWWxYkBOvdj@lists.infradead.org X-Gm-Message-State: AOJu0Yxz0WGCV5PDtag5IZx5EV+nYHWPHfFjdHH/wMD3iWOiAeR5QNl3 h8DRTD1otBZ+xsu9PqUwG2akRpvuf+X772m6V89LvGvA2hpG9dKLFNy6AbPfWnY= X-Gm-Gg: ASbGncsk0uemqW4I8S3xtH5UtVFDjBQZEPIBcX9O/CDOqul7eK5IlX34VddmvDg6REV wl5erkocZ9BfXNw4nfUcAdY/e3fY59J/51znLZ1KYv8ddVnDuK9CoPWyX4ZjfpL6+3xlR0sxZAx baQAKiRW3c+CTN798Uq9i0lrDmQf21PCV8Jo9+6n62G0/Gh1dMsBNftyJsTDdNAKjTaqgaEsmHd YgoAP5eHT4mkXyg2/PSlJBY/+sEzAYV3wADNxDmKExsnr+fOk0UcoCvgIil5qbHiLGEVTYDzLWf ZU5uxWLZswPgPda5ry9q4qPQUyJHqjqlstvsj/9uDhe3lRobWI/Qd5jHcmGrTDbBY0olwrPWYYV anzThzFZhXg== X-Google-Smtp-Source: AGHT+IHq59q43U3ESaHrkdTJX61FFZSQWYbph+vbGLJu0Eb0VqRkvBLNVX+MfvKgdS008nj52Al/2Q== X-Received: by 2002:a05:6402:5188:b0:5dc:c531:e5c0 with SMTP id 4fb4d7f45d1cf-5e4d6b83d0emr2632501a12.27.1740751649255; Fri, 28 Feb 2025 06:07:29 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:28 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:26 +0000 Subject: [PATCH 13/18] rtc: sd2405al: drop needless struct sd2405al::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-13-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060731_002666_B7D89251 X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-sd2405al.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-sd2405al.c b/drivers/rtc/rtc-sd2405al.c index d2568c3e387659dfea598cd2ef6bddc5c076cbb9..00c3033e8079b5f10aaabcc7a1d3f19771263a02 100644 --- a/drivers/rtc/rtc-sd2405al.c +++ b/drivers/rtc/rtc-sd2405al.c @@ -42,7 +42,6 @@ struct sd2405al { struct device *dev; - struct rtc_device *rtc; struct regmap *regmap; }; @@ -167,6 +166,7 @@ static const struct regmap_config sd2405al_regmap_conf = { static int sd2405al_probe(struct i2c_client *client) { struct sd2405al *sd2405al; + struct rtc_device *rtc; int ret; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) @@ -182,17 +182,17 @@ static int sd2405al_probe(struct i2c_client *client) if (IS_ERR(sd2405al->regmap)) return PTR_ERR(sd2405al->regmap); - sd2405al->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(sd2405al->rtc)) - return PTR_ERR(sd2405al->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - sd2405al->rtc->ops = &sd2405al_rtc_ops; - sd2405al->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - sd2405al->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &sd2405al_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; dev_set_drvdata(&client->dev, sd2405al); - ret = devm_rtc_register_device(sd2405al->rtc); + ret = devm_rtc_register_device(rtc); if (ret < 0) return ret; From patchwork Fri Feb 28 14:07:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996515 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04D0CC282C1 for ; Fri, 28 Feb 2025 14:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wVgVdQhbC2YyNwH7K95+EhEh/kAvax64uDHN7A2amTM=; b=lkafD4HEL4/b5/XGNYPu5py7LC OXNGrn6edLVo/J0gOZM9udM0D47w2xmqTnUCfZMclKUZ7E+AymPk0x2uo6x4wHBp9kWhS6EhIZ4ix 0AipFMkQVhnaFpfhtZuSZMJy1S/r6454qAN8kKOb2exvPesQKh8zRsMZF3y/1tzTfpJ9PniIhgNil Tntvmuulvu0Lag4+UcuSgSIIRPt5LicH+SNFgTN9K5nIisBNqDEYbR6s8W7fKvWbbAM3xNUanVr76 Yk5I8WHB9a0Lv+q8PMSD807vkhbKyGCS1omo9ElDhMfMMs16KznR9u+8PLGfLuA7aPZpywZ3svv48 795AqZsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Oh-0000000BGyk-0Y46; Fri, 28 Feb 2025 14:31:27 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11X-0000000BBBc-2oXG for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:32 +0000 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5e04cb346eeso3602129a12.2 for ; Fri, 28 Feb 2025 06:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751650; x=1741356450; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wVgVdQhbC2YyNwH7K95+EhEh/kAvax64uDHN7A2amTM=; b=Tbt1ZyYbw0fhZvWj/Jp6/ghf3SHPTn23gLzNSV4wEwbD4MLfoCMmkkjoOMhnXsetx+ p4WxGnqMOt9LaAsXXzXbhW/r7TKvzMiZlxhnOe3cQ0U4/LUH8ulUHahrMp5tNuRunADt u1pclU0GQJ0X/T0tLk/8vlhl/E1j91woQDuRjb6x4r8i7fxsFtogFncr/FA5W6WTY3Ai 0nJOTx2ta57oFenNKDSD++kiyyRT1AVE5YuYs2j1JpsqAK6a9TPDdi2I7jFj9IQU/F4C PC+OnA92/AYvqX3TYmE0rWpPieJiWp/5N8lW/Tx7NXLclt8NHCDMP0Buolk2Zx4DPkys be9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751650; x=1741356450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wVgVdQhbC2YyNwH7K95+EhEh/kAvax64uDHN7A2amTM=; b=q9me72gONbIzuFkXEE2pfwWOYGIDdH8tHhsxcn5NPqQ0dPx9E4qnx/xuR0ExwXAr2L 7HIYaMEKsKrrqzV42e/myIi2Wl21prGqbegprItxl3KzPihAUaqJsjzF12AMTqQGFMGr WQXZ3pacX/qKb7wVWoe6hkX5+YixMOxpC1uBrmphNqTitT/laiTew4AHRz2Roebyz0z8 DHRD5IXkwzKcZK2nEuOXsLcj/u8AV9GQtiTS1fzypfBao/sMUOcXxVFcCWoAqzj0Hw9Z zhz9T43dRHCyKXrnStnuNDJuh8U5HhempWENNdmQQpJQHzj9k+8Snw0gpV0V/+jfun6h RFTQ== X-Forwarded-Encrypted: i=1; AJvYcCXABN661a/mqVn0NpkiSn32WseZSX/wEPqqKrR1YRkfZ0sqZxuz9+A5LI8RTUt5KTr/5j8mtro8KK1axUcWuOpg@lists.infradead.org X-Gm-Message-State: AOJu0YzcbqsLE0FHHKtIDcYG2a3XuqKQmynwwHAWP3HzAzddG6VcC7su c3SDdbMu9xvw+Ic1m+kvlfTWXW0kZKIwKyfn5Vj/15bKia6mfvx1NDORwcNQ+Ks= X-Gm-Gg: ASbGnct+usPmRtyaRn2LQV5InSpEfCf127LxdW8sqvZgoG8qZ288xb0+XTDgguVf5vt N0UrUyFzP9Imyh22o4+S5XJas5LlaJ1tmTS5uljYW2WMWqsi6na0pBcsxjsLSj01b7mGQtauLqM D6VLit2b4rJ8sLDEtIh1y0k+7m5XBPxYKBOi7l9gKhb3zoOoOztQvvsYYz28zCyYJu/w1c06Shm nJZ55vpRDQCr2jtS10xC0QpkLVulXOqU7U3gzjrbsu2iG4hagbr/R3aDrTYOOp2dDLlOhpnVK9v 6V/2I0ka/obxLsRy7vCttsxa3lZviMlwTCF1mdImYPCXMqVDg/rCFPDOt3bypnF8rUtu6YpFGxa BapKJgq2RMg== X-Google-Smtp-Source: AGHT+IHCyDQzEJ6kBhW3v4N+pYx5F1W3SqfuZOszPC9Ixk4jqjoqtVWckx72H2jiEWEF9nyPWj82Qw== X-Received: by 2002:a05:6402:254d:b0:5e4:cfe8:3502 with SMTP id 4fb4d7f45d1cf-5e4d6afa314mr2938285a12.17.1740751649850; Fri, 28 Feb 2025 06:07:29 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:29 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:27 +0000 Subject: [PATCH 14/18] rtc: sd3078: drop needless struct sd3078::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-14-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060731_703832_E158DCBD X-CRM114-Status: GOOD ( 13.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-sd3078.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c index fe27b54beaad1c06b70bf7f22e44c3f6da087267..ebb4d45ce2409982880affbc7a85d5e7410c8f42 100644 --- a/drivers/rtc/rtc-sd3078.c +++ b/drivers/rtc/rtc-sd3078.c @@ -37,7 +37,6 @@ #define WRITE_PROTECT_EN 0 struct sd3078 { - struct rtc_device *rtc; struct regmap *regmap; }; @@ -167,6 +166,7 @@ static int sd3078_probe(struct i2c_client *client) { int ret; struct sd3078 *sd3078; + struct rtc_device *rtc; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; @@ -183,15 +183,15 @@ static int sd3078_probe(struct i2c_client *client) i2c_set_clientdata(client, sd3078); - sd3078->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(sd3078->rtc)) - return PTR_ERR(sd3078->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - sd3078->rtc->ops = &sd3078_rtc_ops; - sd3078->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - sd3078->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &sd3078_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; - ret = devm_rtc_register_device(sd3078->rtc); + ret = devm_rtc_register_device(rtc); if (ret) return ret; From patchwork Fri Feb 28 14:07:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996516 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4D1AC282C1 for ; Fri, 28 Feb 2025 14:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XNaBzsv98dZxOnoY4pQ3hhfyEv1+PH+c26jk5v5UbcU=; b=v3opXAZq0d73GaGw7cn68txmd7 bM/joKTG79O0VIUkUlV1xH6cULmJoNi4OtF9BB+qhBXcCo6psKORvl8n0Ng0pMO0iG66A9xsaD73K JFnkBnD6dmjQOk7nfrXV8aLItUr92DSFjEdRLLPuYffPBDW/pVNoChXdJ7iakZuqSiRhDNjpR7dPg u9OO7noPDH0CGQdHukFhbP+V+95gUt+rDiu6QQYngvMs4Pii941OLXRGsztSaOF06A9Nb/Vkl3TDC yAEcaruWk9qpJUV9pvoLerdfxvbADnoJcf5Di96hvax9Kz4NjkEdyKPSdizISZz8HF/hVEDf7OgkM a4TUjSQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1QF-0000000BHKl-0SfU; Fri, 28 Feb 2025 14:33:03 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11X-0000000BBCB-3DyM for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:33 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5e04cb346eeso3602149a12.2 for ; Fri, 28 Feb 2025 06:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751650; x=1741356450; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XNaBzsv98dZxOnoY4pQ3hhfyEv1+PH+c26jk5v5UbcU=; b=ZgS6e0GKv+m/lKIV93gmZPpi2slR7/n0yAnTzu31RvGbvRU5xV8/Crs7J64JipvQrA CmhAEmzItp+D0dQlIo1AACX2836YoYhWLnkx/rWd++ch+Ipl9mhSdXwPuqzs8AOZpRLZ 11+T82kuh9KwO3AVUQW/1A17rEKms9GcixvtPt3f3ORTNpZ8Ri6isW6X5G33SUyJhi5P TEiGeuiC82Im3Tm8O9oloGb7sy1Z9mL+ExSDGFEYcnWeR80O+LZCJ8cByv0eWfnMOLRi GiS2bYB8Ymu2FoKj7pqp8PC4bU1D2rzFHBOrYh+esuL5xcSs0EFJ9PODNryrODambezR 6WcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751650; x=1741356450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XNaBzsv98dZxOnoY4pQ3hhfyEv1+PH+c26jk5v5UbcU=; b=omxZI/QjvvjAmtgltYWCu3VUGRk6pKmN3/ToNb1D53OaJs4WLCDZdOWEIKWHZqSiHY BJs4BQgVFDzg3k2zReDffSO9XCzjlQ6QFCaHog3zSoz6yIK0VNJ6scnr5fMfGmrV/Dqa o4JWdwCNGT0wULKZXNB4zLq7WeH8DCIlPQXEm9IW7hqI9RazTocpjv20VmfD+l7EwBzN +NtZhfP8ysLdSK0mJA3ZLGek7HuAN2ZDo2w0P1ma02Dv9NsdlTri6ehFBCNe/i8tB4QJ Ss1+vegaVYYKsx8mF8OhDA5PFtoAt4cELRL9FMkUVq1Bj+S3PHADoUhMgjOmGXeVyHs2 SYfQ== X-Forwarded-Encrypted: i=1; AJvYcCXUjw8RxXmBBi3e/9rfe1GYbc0XpxvPcjhSCs+in4PklMAbRNTmVtW6uw88/7DItE7WKeXR4/5pUmi65QF5mIGU@lists.infradead.org X-Gm-Message-State: AOJu0YyP4W35RN6r1vCAqwS8rODjACO5fm8R3PMhlY8nP21Mhx1oxkEP VMsoj762CVurWR/3fYz5+Pa3Lpa2lYwRxtiyskpap8vaYMxrNnHpFqYuIGphsPQ= X-Gm-Gg: ASbGncvKWRmFccppKc5KUw8Me6E/H/0642fdOIN/Yv35PJvdzIEreThj5QsTMInJQjE RDNBuV0Vcs4ft205h7Yve25Scvp8fCWWXEb3RvRjPG2NyKjNQE9g01hhqTTxlrrAtEjWVT8A0/r Cq5DsZ3aWvYhHXdovzwYHfZIowsv/MWOn06Irk0idD3ov40VkLmWw2ApNC5MpVQNod78urAMfbP KF5T5biKGDA0w89hIaDFKOvTipimNfBsY+JcBwUuvf9/bq9V6voOLXuHUIo/sEjDEXA3GEpLaLF 5SZtQ8+eR0Olnc5QJAFCSfnV/hGd/FRU2rBrpOPDnv4jen4hNI2rPYBocWH4eNBtEP9ARkLyEjo cQ30Q4wzPHA== X-Google-Smtp-Source: AGHT+IHJgHIb94bIAN1OxpmT/CmpG5hxROPCgFLfrUaKlqlLkHckO5CTYjuy4Kdl9gpiKvePvUPO6w== X-Received: by 2002:a05:6402:35d3:b0:5e0:9959:83cd with SMTP id 4fb4d7f45d1cf-5e4d6b70ef7mr2396243a12.21.1740751650375; Fri, 28 Feb 2025 06:07:30 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:30 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:28 +0000 Subject: [PATCH 15/18] rtc: rx8581: drop needless struct rx8581 MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-15-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060731_827887_DC5E3FA2 X-CRM114-Status: GOOD ( 22.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This private data struct has one member only, there is no need to allocate data for it and pass that around via the various callbacks, just to extract that one member. Instead, we can just pass that one member and avoid the extra memory allocation, reducing runtime memory consumption. Signed-off-by: André Draszik --- drivers/rtc/rtc-rx8581.c | 63 +++++++++++++++++++----------------------------- 1 file changed, 25 insertions(+), 38 deletions(-) diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c index 785ebaca07ac971eee34559f8d1e0a8a872cbba9..20c2dff01bae833ae4e100cc38cd5f030017be75 100644 --- a/drivers/rtc/rtc-rx8581.c +++ b/drivers/rtc/rtc-rx8581.c @@ -52,10 +52,6 @@ #define RX8571_USER_RAM 0x10 #define RX8571_NVRAM_SIZE 0x10 -struct rx8581 { - struct regmap *regmap; -}; - struct rx85x1_config { struct regmap_config regmap; unsigned int num_nvram; @@ -71,14 +67,14 @@ static int rx8581_rtc_read_time(struct device *dev, struct rtc_time *tm) unsigned char date[7]; unsigned int data; int err; - struct rx8581 *rx8581 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); /* First we ensure that the "update flag" is not set, we read the * time and date then re-read the "update flag". If the update flag * has been set, we know that the time has changed during the read so * we repeat the whole process again. */ - err = regmap_read(rx8581->regmap, RX8581_REG_FLAG, &data); + err = regmap_read(regmap, RX8581_REG_FLAG, &data); if (err < 0) return err; @@ -91,20 +87,20 @@ static int rx8581_rtc_read_time(struct device *dev, struct rtc_time *tm) do { /* If update flag set, clear it */ if (data & RX8581_FLAG_UF) { - err = regmap_write(rx8581->regmap, RX8581_REG_FLAG, - data & ~RX8581_FLAG_UF); + err = regmap_write(regmap, RX8581_REG_FLAG, + data & ~RX8581_FLAG_UF); if (err < 0) return err; } /* Now read time and date */ - err = regmap_bulk_read(rx8581->regmap, RX8581_REG_SC, date, + err = regmap_bulk_read(regmap, RX8581_REG_SC, date, sizeof(date)); if (err < 0) return err; /* Check flag register */ - err = regmap_read(rx8581->regmap, RX8581_REG_FLAG, &data); + err = regmap_read(regmap, RX8581_REG_FLAG, &data); if (err < 0) return err; } while (data & RX8581_FLAG_UF); @@ -136,7 +132,7 @@ static int rx8581_rtc_set_time(struct device *dev, struct rtc_time *tm) struct i2c_client *client = to_i2c_client(dev); int err; unsigned char buf[7]; - struct rx8581 *rx8581 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); dev_dbg(dev, "%s: secs=%d, mins=%d, hours=%d, " "mday=%d, mon=%d, year=%d, wday=%d\n", @@ -159,25 +155,23 @@ static int rx8581_rtc_set_time(struct device *dev, struct rtc_time *tm) buf[RX8581_REG_DW] = (0x1 << tm->tm_wday); /* Stop the clock */ - err = regmap_update_bits(rx8581->regmap, RX8581_REG_CTRL, + err = regmap_update_bits(regmap, RX8581_REG_CTRL, RX8581_CTRL_STOP, RX8581_CTRL_STOP); if (err < 0) return err; /* write register's data */ - err = regmap_bulk_write(rx8581->regmap, RX8581_REG_SC, - buf, sizeof(buf)); + err = regmap_bulk_write(regmap, RX8581_REG_SC, buf, sizeof(buf)); if (err < 0) return err; /* get VLF and clear it */ - err = regmap_update_bits(rx8581->regmap, RX8581_REG_FLAG, - RX8581_FLAG_VLF, 0); + err = regmap_update_bits(regmap, RX8581_REG_FLAG, RX8581_FLAG_VLF, 0); if (err < 0) return err; /* Restart the clock */ - return regmap_update_bits(rx8581->regmap, RX8581_REG_CTRL, + return regmap_update_bits(regmap, RX8581_REG_CTRL, RX8581_CTRL_STOP, 0); } @@ -189,29 +183,27 @@ static const struct rtc_class_ops rx8581_rtc_ops = { static int rx8571_nvram_read(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; - return regmap_bulk_read(rx8581->regmap, RX8571_USER_RAM + offset, - val, bytes); + return regmap_bulk_read(regmap, RX8571_USER_RAM + offset, val, bytes); } static int rx8571_nvram_write(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; - return regmap_bulk_write(rx8581->regmap, RX8571_USER_RAM + offset, - val, bytes); + return regmap_bulk_write(regmap, RX8571_USER_RAM + offset, val, bytes); } static int rx85x1_nvram_read(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; unsigned int tmp_val; int ret; - ret = regmap_read(rx8581->regmap, RX8581_REG_RAM, &tmp_val); + ret = regmap_read(regmap, RX8581_REG_RAM, &tmp_val); (*(unsigned char *)val) = (unsigned char) tmp_val; return ret; @@ -220,12 +212,11 @@ static int rx85x1_nvram_read(void *priv, unsigned int offset, void *val, static int rx85x1_nvram_write(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; unsigned char tmp_val; tmp_val = *((unsigned char *)val); - return regmap_write(rx8581->regmap, RX8581_REG_RAM, - (unsigned int)tmp_val); + return regmap_write(regmap, RX8581_REG_RAM, (unsigned int)tmp_val); } static const struct rx85x1_config rx8581_config = { @@ -248,7 +239,7 @@ static const struct rx85x1_config rx8571_config = { static int rx8581_probe(struct i2c_client *client) { - struct rx8581 *rx8581; + struct regmap *regmap; const struct rx85x1_config *config = &rx8581_config; const void *data = of_device_get_match_data(&client->dev); struct rtc_device *rtc; @@ -276,15 +267,11 @@ static int rx8581_probe(struct i2c_client *client) if (data) config = data; - rx8581 = devm_kzalloc(&client->dev, sizeof(struct rx8581), GFP_KERNEL); - if (!rx8581) - return -ENOMEM; - - i2c_set_clientdata(client, rx8581); + regmap = devm_regmap_init_i2c(client, &config->regmap); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); - rx8581->regmap = devm_regmap_init_i2c(client, &config->regmap); - if (IS_ERR(rx8581->regmap)) - return PTR_ERR(rx8581->regmap); + i2c_set_clientdata(client, regmap); rtc = devm_rtc_allocate_device(&client->dev); if (IS_ERR(rtc)) @@ -299,7 +286,7 @@ static int rx8581_probe(struct i2c_client *client) ret = devm_rtc_register_device(rtc); for (i = 0; i < config->num_nvram; i++) { - nvmem_cfg[i].priv = rx8581; + nvmem_cfg[i].priv = regmap; devm_rtc_nvmem_register(rtc, &nvmem_cfg[i]); } From patchwork Fri Feb 28 14:07:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996517 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9F1EC19776 for ; Fri, 28 Feb 2025 14:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/r1ypkbSjtebcdcKcBz70+d9/hPyy6PTiaBKA6Wiwh8=; b=EwWeIpGQUrDg87yG+AX7gllSIO 0nbBIB4FWgsENsXIs0QL0sgU/90zH1bnex5yu28dr/SPdUXd17M+H0lRV68Fzz4RJHpiy7jBkexvr DGVyvyLjx/eF87Xp7Bb84dfPB9Av/MdbjDDvatA995Q+tHQiIirscLiM1lSrIM3l02KL/h+iJ2Q8a TidtxpCuxEbaC2orHE61/ctY9NnKNst/psc9sniXPIKGGHLLRNXaZOi217b08bhZdEjdyYVubY+Pz W/waQjoFTbSTNfjCH4hyHxvL/ZJI8dQ08cUyzOHmrfzwmq5bgLHBCrEVga1xzFElBhQxB23Xajt+C ZNByILFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Rn-0000000BHhA-0UH0; Fri, 28 Feb 2025 14:34:39 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11Z-0000000BBDf-0ATc for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:34 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5dedae49c63so3851921a12.0 for ; Fri, 28 Feb 2025 06:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751652; x=1741356452; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/r1ypkbSjtebcdcKcBz70+d9/hPyy6PTiaBKA6Wiwh8=; b=POfb3kHTjaP0qetIzzS2SKTbQakW3Hidsm0f//c0Qr9nINCTKcS88z2BOGJ0DzliIL 4GKr/6Xvo5XsM8YtdpgckgmfRr84vuUlg0qdUUewyMe19k5HHeSGrpPYd8Vi6bRSTdXk fItNQliWE+akw06JYAUNw8Of8ihQf4kHhcXNTNYcYgMEFCgfw/RU695N0Qmz7lNkSYF7 kWQjmQHVCD3f5hUK8WlJKJRrkjLpQwvGxeSiVYkZ1CahXAmHlfP1HXEU4TeaxNgeTbj8 lCeEudYSDT0yxYyo8b7YK19UnEP9DEB/oyaX9Ge0bRE83GmYUnV5Z1BJquZQHwldw4o6 7wMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751652; x=1741356452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/r1ypkbSjtebcdcKcBz70+d9/hPyy6PTiaBKA6Wiwh8=; b=TOykdqG085zQeK0teFREuFedLYQN4Pg1AuSc15d3feBxmXAeYmv7vpP9c4ilpgqY0S GNsENiAP+tcjX417q8ofJ9F/Q8KU0nHpYro87SA+LNwyav4DCPXDH14dhsnESHQv1TMg zyJXAWKA7eCklyFsOHtUgInAiUk/ZeWyir8upyyyvhtyMSwUy9AixsdXGnTugD2sPNOG fDh4H7Hd00jz2yOzMtEdXiIazRsjIv0Xp9PRkN9npNrtFJKcCxsreKy4WRp8XURhPpk+ wPKAoNXmUNPjhbwQfoUC0xpIDXQj1hv9Do0kK6dgbIrKlLWjIAORq/x9hx1tH2f82C5m 9+zw== X-Forwarded-Encrypted: i=1; AJvYcCVFKJsjgC/pAtJLuJlXwoDw4Cz6SrgOLMOwd+xNGnaceAimSqAuirsCVPOTDW+n29P5XIhv0An3FdxHkEGZsF9h@lists.infradead.org X-Gm-Message-State: AOJu0YxLKM/xqOc5utdjUTyiCrxp8uz3OL1wFoIm5b44RdK0g9mtADz1 j7hinI5Wx2FT4ldVukEwambTWkFlueBpBmb9k8KAt7vcElJRZ/nW+tEbQBnzBTA= X-Gm-Gg: ASbGncsPSXoHGe9TTjOiySB2ryUXdOKnY3FmCG7jp4ayBkf1+jsPgfHJ0llyw2M6Sqc vgLZCOeV6g/SyJf7naz5AFjsbpZcvpvvOX//hYZCpBxpu1PiPVtlhbdD6tvwQ3sKug2Sig1oCpX R9UlUq9Lzoxi0/vsoORmDuWl8PNvs6+HkbkejjNGgJLhf7YAJy60NywmJPVx4NcQSJgRneLUZR7 CSWyj8C0Bi0lA/ipqlPEXHeGPRiQW2EFRc9lJyvC5UstnNaEp51sLwBvqnDvdfUpp4OV1X9GmLu csjxHCxJXZ7n71g8zh7OLTKRgYRjXhH9Af5+FEMfjIC4+x0XDJfounge3sYPsKrX3R8Rz9CL1OE 3troK9qB/mQ== X-Google-Smtp-Source: AGHT+IEmNzc9psOsG8S5U8hQjyEGUEZtM5fJSHlUXxz0d+LoEipOpq1K+57NoVXqKGgpzCnWIQsf3g== X-Received: by 2002:a05:6402:2711:b0:5de:dfd0:9d22 with SMTP id 4fb4d7f45d1cf-5e4d6b6ebf3mr3156214a12.22.1740751650904; Fri, 28 Feb 2025 06:07:30 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:30 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:29 +0000 Subject: [PATCH 16/18] rtc: sd3078: drop needless struct sd3078 MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-16-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060733_079495_0BC666ED X-CRM114-Status: GOOD ( 17.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This private data struct has one member only, there is no need to allocate data for it and pass that around via the various callbacks, just to extract that one member. Instead, we can just pass that one member and avoid the extra memory allocation, reducing runtime memory consumption. Signed-off-by: André Draszik --- drivers/rtc/rtc-sd3078.c | 55 ++++++++++++++++++------------------------------ 1 file changed, 20 insertions(+), 35 deletions(-) diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c index ebb4d45ce2409982880affbc7a85d5e7410c8f42..10cc1dcfc7748144f51ef674939506feee1fb471 100644 --- a/drivers/rtc/rtc-sd3078.c +++ b/drivers/rtc/rtc-sd3078.c @@ -36,10 +36,6 @@ */ #define WRITE_PROTECT_EN 0 -struct sd3078 { - struct regmap *regmap; -}; - /* * In order to prevent arbitrary modification of the time register, * when modification of the register, @@ -48,14 +44,11 @@ struct sd3078 { * 2. set WRITE2 bit * 3. set WRITE3 bit */ -static void sd3078_enable_reg_write(struct sd3078 *sd3078) +static void sd3078_enable_reg_write(struct regmap *regmap) { - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL2, - KEY_WRITE1, KEY_WRITE1); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE2, KEY_WRITE2); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE3, KEY_WRITE3); + regmap_update_bits(regmap, SD3078_REG_CTRL2, KEY_WRITE1, KEY_WRITE1); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE2, KEY_WRITE2); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE3, KEY_WRITE3); } #if WRITE_PROTECT_EN @@ -68,14 +61,11 @@ static void sd3078_enable_reg_write(struct sd3078 *sd3078) * 2. clear WRITE3 bit * 3. clear WRITE1 bit */ -static void sd3078_disable_reg_write(struct sd3078 *sd3078) +static void sd3078_disable_reg_write(struct regmap *regmap) { - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE2, 0); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE3, 0); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL2, - KEY_WRITE1, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE2, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE3, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL2, KEY_WRITE1, 0); } #endif @@ -84,11 +74,10 @@ static int sd3078_rtc_read_time(struct device *dev, struct rtc_time *tm) unsigned char hour; unsigned char rtc_data[NUM_TIME_REGS] = {0}; struct i2c_client *client = to_i2c_client(dev); - struct sd3078 *sd3078 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); int ret; - ret = regmap_bulk_read(sd3078->regmap, SD3078_REG_SC, rtc_data, - NUM_TIME_REGS); + ret = regmap_bulk_read(regmap, SD3078_REG_SC, rtc_data, NUM_TIME_REGS); if (ret < 0) { dev_err(dev, "reading from RTC failed with err:%d\n", ret); return ret; @@ -122,7 +111,7 @@ static int sd3078_rtc_set_time(struct device *dev, struct rtc_time *tm) { unsigned char rtc_data[NUM_TIME_REGS]; struct i2c_client *client = to_i2c_client(dev); - struct sd3078 *sd3078 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); int ret; rtc_data[SD3078_REG_SC] = bin2bcd(tm->tm_sec); @@ -134,10 +123,10 @@ static int sd3078_rtc_set_time(struct device *dev, struct rtc_time *tm) rtc_data[SD3078_REG_YR] = bin2bcd(tm->tm_year - 100); #if WRITE_PROTECT_EN - sd3078_enable_reg_write(sd3078); + sd3078_enable_reg_write(regmap); #endif - ret = regmap_bulk_write(sd3078->regmap, SD3078_REG_SC, rtc_data, + ret = regmap_bulk_write(regmap, SD3078_REG_SC, rtc_data, NUM_TIME_REGS); if (ret < 0) { dev_err(dev, "writing to RTC failed with err:%d\n", ret); @@ -145,7 +134,7 @@ static int sd3078_rtc_set_time(struct device *dev, struct rtc_time *tm) } #if WRITE_PROTECT_EN - sd3078_disable_reg_write(sd3078); + sd3078_disable_reg_write(regmap); #endif return 0; @@ -165,23 +154,19 @@ static const struct regmap_config regmap_config = { static int sd3078_probe(struct i2c_client *client) { int ret; - struct sd3078 *sd3078; + struct regmap *regmap; struct rtc_device *rtc; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; - sd3078 = devm_kzalloc(&client->dev, sizeof(*sd3078), GFP_KERNEL); - if (!sd3078) - return -ENOMEM; - - sd3078->regmap = devm_regmap_init_i2c(client, ®map_config); - if (IS_ERR(sd3078->regmap)) { + regmap = devm_regmap_init_i2c(client, ®map_config); + if (IS_ERR(regmap)) { dev_err(&client->dev, "regmap allocation failed\n"); - return PTR_ERR(sd3078->regmap); + return PTR_ERR(regmap); } - i2c_set_clientdata(client, sd3078); + i2c_set_clientdata(client, regmap); rtc = devm_rtc_allocate_device(&client->dev); if (IS_ERR(rtc)) @@ -195,7 +180,7 @@ static int sd3078_probe(struct i2c_client *client) if (ret) return ret; - sd3078_enable_reg_write(sd3078); + sd3078_enable_reg_write(regmap); return 0; } From patchwork Fri Feb 28 14:07:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996542 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9C3CC19776 for ; Fri, 28 Feb 2025 14:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J1wrjOZ25AMEbbC5RG2Bl34Xp7n5uiu5eMlW7fz5kxo=; b=Q5ngj6aMDZOip80iAWYjaI6pqc 7iweKXJU59QdwgQoSElnJnTd4cXlWXdJgc0Wz0PoOvEu/MSk7u+1hJi7TdfwJ4S3JxL6nu6z6OX3f KwsOA/7zndBKpmA51V1R+xo7JbSb2oTXDyEG9nTSVi9RLhCv3n+21rFk9SvecfwRdSeU95oV1LtD8 O6ngc+K65CEOVRQjKIgSUiAw7+o4rZ4z+6m66hFqu9bmeXtzXhK56JtFwKmPlm0yphpN8yYrjj2mk avQa8NAgoODhayIvfoiNF3elMS5B8joZjGC6CzCupAOfqQ+C7Az8d0U0fKyF7rikq6hdbe2OR1ch9 OFprnDiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Us-0000000BIB5-0ibi; Fri, 28 Feb 2025 14:37:50 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11Z-0000000BBE1-1WFL for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:35 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5dedae49c63so3851943a12.0 for ; Fri, 28 Feb 2025 06:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751652; x=1741356452; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J1wrjOZ25AMEbbC5RG2Bl34Xp7n5uiu5eMlW7fz5kxo=; b=YZeC+M6Me/z7YSpmh9nb/WtaJiOnbiAHHqVPoMHfTiaJimq7IBVjsEOfyOlzSke1vz CTJxfsyDshy97kPS1Sn5UpjhVWLxNp9CsQb9UR5faqU75+o6H9UHJxngthiTcq5kCrub N6Bzqt3DdKyWyqladqyu8NT4r/sdUyn4K5PmHhmJNoUtg19RMj7K+yidAJ6ej76WKjkY /F8xvTz/As3Ai4brgJBwXo8i0mzQE1qCsOPn5FCWD9J6rO7eXCTe01/jWwlkGOnWsJrq YBxVWbhAMcUjnmxcqNkQhkQcKEf4UG4nw9xC/RAlbJmyUOCqaNlPgPKCKKW+zsoBBWgI CdRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751652; x=1741356452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J1wrjOZ25AMEbbC5RG2Bl34Xp7n5uiu5eMlW7fz5kxo=; b=HYErFgP1N/1rssw6eM50QAKs1nApidOAoYGzqI0m+fWP2i5gQ4xzntfOFQbVvRcClF Vr1IDE2o/fE/gLKXpX4YxvKBBpMvTW7+pt2ZKu5LXiQ8kIUeXLQuWrE3adohtHP+BPVs 6TR+ZyC38X/YRZJ08FSUdmjsspd2CS4WVHCGM88U3IVMvlIEQ8ggY81PNYtVOc9pRHiN 1wTrA8MJReX5OYGVtuUOcAT43J/sYmp2J3feE802IyoJSUE60zQHE7x6QrcRGLW5js8P 3wMu0U2cdv32Zf9M8ldTjtlVQb7d0d7w7jo+HB2xSuk9zlNMQscfykS/E5YcgEE5jelO 7XDw== X-Forwarded-Encrypted: i=1; AJvYcCWaMpoK5Bh/B18m+L/8EqShPh2V/UwFCDXURidTGqp9bRpZmoQZ8524J9GFWPdE+sBIcTE3An8VM5y3IGp+emA+@lists.infradead.org X-Gm-Message-State: AOJu0YxnamG+og/D/Sib4dUvYCR+q8QETXiECPTzaFLkLI5GnmkeOMXL C3HhG1FQ8xWYvuwkyzEkg9EbtOx/65BQt/sA30xiCW/8HDkgTSukT7hfP3WB294= X-Gm-Gg: ASbGnctPouDxOMRrbRW5mkMhLIFDennnWaGrNRre2hB2yD46UMiFxVuCXWrFKq57k+S EyfEyWqYR9dI8o2ZhaSY3zI9e2+QUxbb9BoqZrxtu4ohgWRvZ0SXOuvHmKMG3CaDvh2F52/uyEI XnhMMnesU4oonP1ippoZcNvH63EGvQms5360kxk0KFkXhiAe3hDCRzm/3JF1WBDelQBMI4V5j6+ BF5E8nalIJu15VwMDbDVfEXH6VY4WdgqKl+NCG7gQp8iQn+qedprBftG7AcbL5HnzLPiqn/QngY XaLxHfLRSYhGwwUH7VjI+sunrLNgCt8wDpkBq7czcLD3JEXqJzCDbay8B6wNv2KrKzubjC5pkJr km9tku1VMFA== X-Google-Smtp-Source: AGHT+IH8oBqlrNujitdioxAVXjdPgLAryRZxpXTnrztyLFYptlh+GD/CB4rbFiDA0RhEFxZK1lBu3A== X-Received: by 2002:a05:6402:35c6:b0:5dc:c943:7b6 with SMTP id 4fb4d7f45d1cf-5e4d6ad4a6amr2900190a12.3.1740751651952; Fri, 28 Feb 2025 06:07:31 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:31 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:30 +0000 Subject: [PATCH 17/18] rtc: max77686: use dev_err_probe() where appropriate MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-17-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060733_398974_9A1ED663 X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. Signed-off-by: André Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-max77686.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 6b0d02b44c8097453f704cbec9f02580fb869ca3..69ea3ce75b5a5426d4a56b979773be71c4ee7562 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -704,10 +704,9 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) } info->regmap = dev_get_regmap(parent, NULL); - if (!info->regmap) { - dev_err(info->dev, "Failed to get rtc regmap\n"); - return -ENODEV; - } + if (!info->regmap) + return dev_err_probe(info->dev, -ENODEV, + "Failed to get rtc regmap\n"); if (info->drv_data->rtc_i2c_addr == MAX77686_INVALID_I2C_ADDR) { info->rtc_regmap = info->regmap; @@ -716,28 +715,24 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) client = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, info->drv_data->rtc_i2c_addr); - if (IS_ERR(client)) { - dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(client); - } + if (IS_ERR(client)) + return dev_err_probe(info->dev, PTR_ERR(client), + "Failed to allocate I2C device for RTC\n"); info->rtc_regmap = devm_regmap_init_i2c(client, info->drv_data->regmap_config); - if (IS_ERR(info->rtc_regmap)) { - ret = PTR_ERR(info->rtc_regmap); - dev_err(info->dev, "Failed to allocate RTC regmap: %d\n", ret); - return ret; - } + if (IS_ERR(info->rtc_regmap)) + return dev_err_probe(info->dev, PTR_ERR(info->rtc_regmap), + "Failed to allocate RTC regmap\n"); add_rtc_irq: ret = regmap_add_irq_chip(info->rtc_regmap, info->rtc_irq, IRQF_ONESHOT | IRQF_SHARED, 0, info->drv_data->rtc_irq_chip, &info->rtc_irq_data); - if (ret < 0) { - dev_err(info->dev, "Failed to add RTC irq chip: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(info->dev, ret, + "Failed to add RTC irq chip\n"); return 0; } From patchwork Fri Feb 28 14:07:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996541 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 793DFC19776 for ; Fri, 28 Feb 2025 14:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ucCmymGJlfsI4F5PNnMG7qiqKtfzqtFmwv0m9GhXqKs=; b=PwLAnrWWQxpc2VqCVCn5S1p8F9 vhecoc07eg/w5wTsJkzNKNctr6Sd6i51N4x2iBjFvbEyiAtkArSBl7HjNecIjQJZgF+HTWaQY1F+6 VXtI3WiRVTJyPX3dOi9kvHp4OAuZ7YepG1+j/xbjyDMyGrtRBYCVBH9wG9MEc+ZwMOAxCc/jj12u6 WyVYARqUpGLinUOkQ1I6G1NU4XqJSmXMGPoPSCYMljhYX5HWi5TU66Zrkmsm/Wvkfjf356i1esSVV oVn2I9n9SjgsfCoXJ4lgJVZGhrv4E872tBVZOGDdqs1jNOUZmInNztRQxeICTsQC20zdmwq9Yy75P 3eLhueVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1TK-0000000BHvj-1tg3; Fri, 28 Feb 2025 14:36:14 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11Z-0000000BBEH-3Q4X for linux-arm-kernel@lists.infradead.org; Fri, 28 Feb 2025 14:07:35 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5e08064b4ddso2800598a12.1 for ; Fri, 28 Feb 2025 06:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751652; x=1741356452; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ucCmymGJlfsI4F5PNnMG7qiqKtfzqtFmwv0m9GhXqKs=; b=oU+GIRwMvYl1Jj98PGNUWsIeEfT8gDu1c/ELNwP1z82DC8+yZcKG9KhP82pTWOVAC9 lFKAtNpvoCNFGsHOJ8xYglTbY43BIeQqxfp1TxWB1ixtEdkb6fBViI6Ugc6izyNM5+C5 skvp27d/cPeCvReeCC7lLU3Jb52GfiBq3Uow0ldLy7zMpVMGW3Jq1QyisB7DaAOHkDCI Xzo5i8RnIGEbnOgeBJAyLsgdHtHujBpY4Z18RVBZ3/hlmSXUcUtNMKwQq0WXtiXeX/yR MtjvedvfxB54utRnzAxp3IcSuAjY4hrug9hrGRE8/OuHxh0w2Wr1WxiLxkonOkCL9Sm1 hwDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751652; x=1741356452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ucCmymGJlfsI4F5PNnMG7qiqKtfzqtFmwv0m9GhXqKs=; b=BZ+EHqaJYOQDJbjh0gDa4LRS3c25GX3vwyMqBbfkvOhxt+2BIsHK8kKzbiJzGpbCoj mtn3LtD3LnJ4GjHOn2d42yTw9O9HfA5isdnZ7eiTN35KDcc77ICOdjnFmeoOWFCyz2iY 40sVaOvY51SzS4XwHZ4+YK9zvj1px9Kww+pC5ful9dWaoRXh31ZDeJK/kmybJ1u21Ewy HKRqNfHMbAWsuiF3XCzOVI4rJxBBGLKGU7d/RCup+WKH07tpP4uiCE8HG72LXbsHVgJN 12fFpBRVCdL65tpNjHwj4BP6SlgFjSnOsBjmVKAh+pCGy4M13JorjG+mEk+ffq0VpLVB Bf2w== X-Forwarded-Encrypted: i=1; AJvYcCXDt037CQRp5WxLOiRcG6WXFJ1l4LN0u6k1fURyhaIO9zSvByQrDoDHUnJy0pCvv+P8c4v89oaEuvrzmy1UIZjb@lists.infradead.org X-Gm-Message-State: AOJu0Yz3orZm2Fl5/Fk9dkVQit1iq2NgCDTLzs0aer2dBe+URxQLLN5r jmHniVmzqYf51vgz1XBvr/BNVcV72lrV7PcQ2An/GqmLpkGdDNXxs4sqbx4tcuA= X-Gm-Gg: ASbGncufbPIIn2qzwmhBi/NF0o0ijPVQh+x50VfrclJ3JPZLMjHDrcP01k8BQSCAlcj tFVEVARI844KZzCuLAXNbYKZmCrP+cFWio+7cbuOxBbC+XCKjpN6ObR21e2umtC7OhdDK8Pf+Wt KINEMiuti7Psxj+cQkXVGfZERSxBUnlHb/WI4QAfm/ZleV4bdbpD4VjGHC0/GoKdoY2l1qPLdsS cR6QwvhiKH03hquMlr3pNGoRT35M/VvVDpp5fXdouuh6gD4BSVm4K0aCuyUU1AtsNcgY5jplVuH tPw9cZVMFEy0XuBT/R4mv+7VeZmChleU5iZFzP6OC+V5QPJ+ljEQiRkuwo7gl1xp1W5bvPkklgf BfDyOJQ71HQ== X-Google-Smtp-Source: AGHT+IHUtKBxx/Kb6wMivayuykLjA27f1K+WzySysSQHyW8EvpaAIClZC0PRyUOpjP+2MS95jX29jw== X-Received: by 2002:a05:6402:35cd:b0:5db:f5bc:f696 with SMTP id 4fb4d7f45d1cf-5e4d6ad3e14mr2592499a12.5.1740751652457; Fri, 28 Feb 2025 06:07:32 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:32 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:31 +0000 Subject: [PATCH 18/18] rtc: s5m: convert to dev_err_probe() where appropriate MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-18-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060733_848616_2B59D9C2 X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. Signed-off-by: André Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 50 +++++++++++++++++++++----------------------------- 1 file changed, 21 insertions(+), 29 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 77dd61c30681b8f0a2f23063ad5f7eb52f5b7158..4c66e38145b02638c48685580c7943bdf79bfbd4 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -626,11 +626,10 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) } info->rtc_24hr_mode = 1; - if (ret < 0) { - dev_err(info->dev, "%s: fail to write controlm reg(%d)\n", - __func__, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(info->dev, ret, + "%s: fail to write controlm reg\n", + __func__); return ret; } @@ -669,26 +668,21 @@ static int s5m_rtc_probe(struct platform_device *pdev) alarm_irq = S5M8767_IRQ_RTCA1; break; default: - dev_err(&pdev->dev, - "Device type %lu is not supported by RTC driver\n", - platform_get_device_id(pdev)->driver_data); - return -ENODEV; + return dev_err_probe(&pdev->dev, -ENODEV, + "Device type %lu is not supported by RTC driver\n", + platform_get_device_id(pdev)->driver_data); } i2c = devm_i2c_new_dummy_device(&pdev->dev, i2c->adapter, RTC_I2C_ADDR); - if (IS_ERR(i2c)) { - dev_err(&pdev->dev, "Failed to allocate I2C for RTC\n"); - return PTR_ERR(i2c); - } + if (IS_ERR(i2c)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c), + "Failed to allocate I2C for RTC\n"); info->regmap = devm_regmap_init_i2c(i2c, regmap_cfg); - if (IS_ERR(info->regmap)) { - ret = PTR_ERR(info->regmap); - dev_err(&pdev->dev, "Failed to allocate RTC register map: %d\n", - ret); - return ret; - } + if (IS_ERR(info->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->regmap), + "Failed to allocate RTC register map\n"); info->dev = &pdev->dev; info->s5m87xx = s5m87xx; @@ -696,11 +690,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) if (s5m87xx->irq_data) { info->irq = regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <= 0) { - dev_err(&pdev->dev, "Failed to get virtual IRQ %d\n", - alarm_irq); - return -EINVAL; - } + if (info->irq <= 0) + return dev_err_probe(&pdev->dev, -EINVAL, + "Failed to get virtual IRQ %d\n", + alarm_irq); } platform_set_drvdata(pdev, info); @@ -724,11 +717,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(&pdev->dev, info->irq, NULL, s5m_rtc_alarm_irq, 0, "rtc-alarm0", info); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", - info->irq, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "Failed to request alarm IRQ %d\n", + info->irq); device_init_wakeup(&pdev->dev, true); }