From patchwork Fri Feb 28 14:07:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996451 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78A63C19776 for ; Fri, 28 Feb 2025 14:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bUV1yTqDeHPfV5uD2/nfl0oDY+7MDFc9tsIudcw4Q/E=; b=R08/bKbnm8q4fQ wzj4Wk5mqiXczzZ6IkJELKgdO0Nj0mW3GrGgZaXUMSoeesrToT/JMOUXPab6RHl/2rgTGFtnRNFeb Aa8M7MVMq7wXKcSBFvUn9zZgKuNop1AtkBdRLFbYLsNVyS3SfZA2b30vfiKIRUXDffYRQi+c9pqwX RI+ysZ62MTBjuvl0An9Q8OX2NiYa7tl/Cy/8+mmrHrT29Ts/2uTaXz85Il9xRTpTai6wbF6YZUACg dlvzr+59rnmQlYNLFmu5w3SwqF00Z9SknUKaSplpucN3v24zj95Mnr9lIfjbpZrr92hRz6JYHA0O1 2iiml9roGK2CvQN5EvcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to13D-0000000BBlR-4ABZ; Fri, 28 Feb 2025 14:09:15 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11Q-0000000BB3C-2UFz for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:26 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5e033c2f106so2449561a12.3 for ; Fri, 28 Feb 2025 06:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751643; x=1741356443; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PxV5ubkQILRDTTOOiWiVBaTKuCWcjZ1klG/odToLNLU=; b=GNwV7WePBwGhEVUrY8wkOq3dzITnF6bXyqJEur34Z1CIW6s4R9vz3QrmoEhjsA04eg 7kbBYDcHmMpkZ3JLtdArC03chuByeVy/vLIRGi7eZfpNV70nu6O3sdU6h5YDnemgokMK dT0q24KtC5t2eUsgOPzFWhSPAjNpkjhXEYvoT+g8bNDBoRzfm592WkRpnWNNAxVTPD2d D+5n/qz/PdRNzu6HlbjGIVW08hDsvXXfv2MHhEBVKhDMZSnlGGtlYYnydpY0jp41vELK eEvnZrF7mM8WY5uj2u8cSCmlVzD4DrV2uK+5bWMpLfnz0L4q0zFdGInPZZtEY429l41d HZMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751643; x=1741356443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PxV5ubkQILRDTTOOiWiVBaTKuCWcjZ1klG/odToLNLU=; b=xD5nkP9V6y7OyzaMuuN9fzQKAYiMuNA4zVtTeEhkTPzoi2/LcQU5lLt7nVL4dOWpgw bFPhEMa68iNNbEcaHqCjvsJfDF6cPktVUPUzsIqHK3CwtzjEps7nl24EJmRbofxt47gQ x4/qo/cP3qbDearM1sTKqMuTBdTueKnTUFlQwNYhnRquOG4GgL4Peg0AXULjiTUETiVi KBSA4BqPwtPfn0wwM129O/xaTsxbTuDqTLKElRDMb7pZHNt1HZzrCJ6ZXC1qxCpdRfEO 1AxOahZj/Rf6nR5m0KMJnDH4Dat+9wUY+z8Tq2jWuoYKC4lyPk1u+hutuuGW5qDNUFQM cbgA== X-Forwarded-Encrypted: i=1; AJvYcCVqLfMMibzks1LuzfMcoVkDEhyOKVTRh2yql61kZd1xWVK/Ac+XpFxb38gK7/I1DdkNuaVvWCGsT0nUZzmA@lists.infradead.org X-Gm-Message-State: AOJu0YwUPU8m+W8ta3623aCq8cm2aBMpL0EM7qo3HdOu0+1WfEINFOVW pqmUkiCbjkuIz7PLHU4nnrqxfrrDwWey0492TdJ0uaQRaYTpo9L6C3CnmkTeAg4= X-Gm-Gg: ASbGncskYMl/7ZszHLqRZn3/6MbYxa0+D/HL93nBzH0qOLIlf9T8PGiC1/6VJi+7fTW zvpVK3rM7Yr1lpzsYzkDgn6YnpQGeagFq6n29rJxq0xetf6h7XD6nSAoDowwcjG5Y3GGJfqjpa6 frVj25lZ8jrguEY2bWOphXRQlzX8MEe+K37YD5x45YMHO8xCmUxacOjwIXElcy9h8FnItiCSlSL HRAHVJ+dYp9VBgeTLJf2G/9Ugtu/Ld/N20YgvGVy1T4ybWzGXhpJFl/bL06G4N8nyJcxq36sOaL DNksK0/xMpRFgF9wq+jNYxmurL3nUJrQ6eYfY1TKFAtYfNqhzg8muBdBeeSQ4+BWRvLf006HEkw KqQqUQv22Cg== X-Google-Smtp-Source: AGHT+IFUL7DUuq/VqTU9dmynPShF+8aK2RXF+k+UR0pl4bWqZxWvS8VoSsjq66EWlcydyD7uTG7tww== X-Received: by 2002:a05:6402:1d4d:b0:5dc:796f:fc86 with SMTP id 4fb4d7f45d1cf-5e4d6af436amr7325207a12.16.1740751642551; Fri, 28 Feb 2025 06:07:22 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:21 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:14 +0000 Subject: [PATCH 01/18] rtc: max77686: drop needless struct max77686_rtc_info::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-1-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060724_631262_2A2D1747 X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org When this driver was converted to using the devres managed i2c device in commit 59a7f24fceb3 ("rtc: max77686: convert to devm_i2c_new_dummy_device()"), struct max77686_rtc_info::rtc became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-max77686.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 7bb044d2ac25aeaaf2404b47b7e7bd485ae3d39e..6b0d02b44c8097453f704cbec9f02580fb869ca3 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -85,7 +85,6 @@ struct max77686_rtc_driver_data { struct max77686_rtc_info { struct device *dev; - struct i2c_client *rtc; struct rtc_device *rtc_dev; struct mutex lock; @@ -691,6 +690,7 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) { struct device *parent = info->dev->parent; struct i2c_client *parent_i2c = to_i2c_client(parent); + struct i2c_client *client; int ret; if (info->drv_data->rtc_irq_from_platform) { @@ -714,14 +714,14 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) goto add_rtc_irq; } - info->rtc = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, - info->drv_data->rtc_i2c_addr); - if (IS_ERR(info->rtc)) { + client = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, + info->drv_data->rtc_i2c_addr); + if (IS_ERR(client)) { dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(info->rtc); + return PTR_ERR(client); } - info->rtc_regmap = devm_regmap_init_i2c(info->rtc, + info->rtc_regmap = devm_regmap_init_i2c(client, info->drv_data->regmap_config); if (IS_ERR(info->rtc_regmap)) { ret = PTR_ERR(info->rtc_regmap); From patchwork Fri Feb 28 14:07:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996483 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13ED5C282C6 for ; Fri, 28 Feb 2025 14:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Q0DUtJQayzMji9fK8ZIB26oXtujUBPjujfnaGO2QKQ=; b=jySHxo8N7bLQpa rPzaOR0preRifIOs+s0uD2zyDtYwTd0TJ4qqtS6C1NmO9Aiw2ZLLkEdRCzlJmCRFttOj7itI7AXtv /7pLTrYz56ndWTjb1ssNTjvigWr04ydzmZ2f4RgUdEV0OfB7KI/5y7a6AXiOEoJBDlMx+KHX7IFNi kKfZzLs3DqcRa1VwhrYXZIA6GYj/GJYp0TvCivd41IQg6YvQD2yIH/yW7G/3UZIFGX3/+DIoKIZbB n71JyOAX4ZS4GKDEZwZ5ejJ5+kffNNLuRZmllEbTAQGASIaGXEtJU/5RYfPa3gg/mhiPQnXcvBTtG IbqgFVxP9cHm1yzqP+Bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to16H-0000000BCZv-2sc6; Fri, 28 Feb 2025 14:12:25 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11R-0000000BB3g-0gNH for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:26 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5e4b410e48bso3226213a12.0 for ; Fri, 28 Feb 2025 06:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751643; x=1741356443; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NEusmS+5iWAG1jDnjFt/eyKJ89b8w4e+6UytiCX0MQA=; b=cRR+sLzvYmRpnUm8TutgPqD8mFWYqWuH2uzh48t0dexjeT9733sszbXz/8Y0v99P60 EILafaEk2Geen28LLpCTLlcV1vaZ4itBLoy8SH6Hd7VtOFdKKOXHpd4S/xQ/IOzTh/S8 j9+P9hKUXVI69aJdlXjjBJpn+6NW5A/6PPDX8i1IxDwFl9kzXuoaU+7R5Wop44zgcKha ZVspKwFr0SXsQQO/qVdC7KkgPv+PE5yDi1zOf5qHs/rRrXhvMo4sEkN0ztRBaLpW9977 43bXPqCOoG5cg4kMBgFum2/vg6TWSu44VShcYLdD5Q7U/taTUpWThtoz5oj5KWo9ReiE gdhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751643; x=1741356443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NEusmS+5iWAG1jDnjFt/eyKJ89b8w4e+6UytiCX0MQA=; b=mxAJ8zlYMnatdN3YLRz1Lfz1Q+5w4bCDcTAUeeZSl0uIktHEN3e8hDbV5F6h78IIK9 flUAF/366LItZ3jzGrnDvWLR4tgtyTi3+h6htW+875NehSWU9cztpNDqkSxj4+7f/eme RdVphEhHdekQEYbaPvoo+nqPMwQPfLAVouUV09Uj/lyYhAyFuxgzrkSlq/KsBrUNUvFs Lx2Ot3KnCAKl4bszqnJ3B+lhFlXT9wRMEj7Cvwa+YpKQ3o0j6aEUqcm7EfcoaQk1cuU/ B3igtm6Z+bcN07oMA6b1lEG/QjInMPqmc5DZ22kh4W1zCF5No9uWWDQ9qCEZzUo5Shve jbIQ== X-Forwarded-Encrypted: i=1; AJvYcCVXNjAVv42U4c5PQsHTBGwu7+oXAi/63LrrzAQRROYt55ANP1xiUslOABZmWS6e8uckPyZPunn2WN30gY17@lists.infradead.org X-Gm-Message-State: AOJu0YzE2iHlYe9qm8Oy3nFMZypvGxj87WDrc8NzYiuuqjF6iD7Ren5n k1yile33ZO5EI1GWYQVi95yZJuaaGi/DM08uH/jVyiYynmcAxTfVS1EBsPE15bY= X-Gm-Gg: ASbGncvR04+LBS5XEVhurZUopVCi12SDkIKGTZdbH/zQXQ7MgFsp/9ruC8J300EzfEn zeLo1Pt2r7f9rQtcDE5DIt81kHmiFgrGerMTt7PktP6SXawb66hk2jolN8V31uXnsiHUIOVbX7J pZkuAa6hcvO35gwCNawiabYazRxJ/9S4KMYOs/pcvaQkw9uagjoSFdm6KJ1szNJc5zNE2/rAkVV rBTP9z9H2vNME9Cian1KTe6OKRJ1213A2E+QbNJ9sYOd3X+raq3q0DcmI0NWn5FHMiLqFrPGFCn 3oz1VwQw9AeUQy5c8SMOKEfFkuItVJiKBp0POfghbQ3xE4yGrZ/g2QFiWSLmtt0MzQhU5iP3BjW VBN3lhQBJ4g== X-Google-Smtp-Source: AGHT+IHzPJx5i3RI7O2yaVdHtPJ0az692A2jfkouiK94jhHcaAYqi/2J0zpg5aMdk74cXIZT8BcCug== X-Received: by 2002:a05:6402:42cb:b0:5d9:a54:f8b4 with SMTP id 4fb4d7f45d1cf-5e4d6af0565mr2697422a12.11.1740751643440; Fri, 28 Feb 2025 06:07:23 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:22 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:15 +0000 Subject: [PATCH 02/18] rtc: s5m: drop needless struct s5m_rtc_info::i2c member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-2-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060725_223673_98E72595 X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org When this driver was converted to using the devres managed i2c device in commit 7db7ad0817fe ("rtc: s5m: use devm_i2c_new_dummy_device()"), struct s5m_rtc_info::i2c became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 36acca5b2639e272dd9baed06ea5582f635702b0..77dd61c30681b8f0a2f23063ad5f7eb52f5b7158 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -146,7 +146,6 @@ static const struct s5m_rtc_reg_config s2mps15_rtc_regs = { struct s5m_rtc_info { struct device *dev; - struct i2c_client *i2c; struct sec_pmic_dev *s5m87xx; struct regmap *regmap; struct rtc_device *rtc_dev; @@ -640,6 +639,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) { struct sec_pmic_dev *s5m87xx = dev_get_drvdata(pdev->dev.parent); struct s5m_rtc_info *info; + struct i2c_client *i2c; const struct regmap_config *regmap_cfg; int ret, alarm_irq; @@ -675,14 +675,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) return -ENODEV; } - info->i2c = devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, - RTC_I2C_ADDR); - if (IS_ERR(info->i2c)) { + i2c = devm_i2c_new_dummy_device(&pdev->dev, i2c->adapter, + RTC_I2C_ADDR); + if (IS_ERR(i2c)) { dev_err(&pdev->dev, "Failed to allocate I2C for RTC\n"); - return PTR_ERR(info->i2c); + return PTR_ERR(i2c); } - info->regmap = devm_regmap_init_i2c(info->i2c, regmap_cfg); + info->regmap = devm_regmap_init_i2c(i2c, regmap_cfg); if (IS_ERR(info->regmap)) { ret = PTR_ERR(info->regmap); dev_err(&pdev->dev, "Failed to allocate RTC register map: %d\n", From patchwork Fri Feb 28 14:07:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996482 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C959CC19776 for ; Fri, 28 Feb 2025 14:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=16HDefQ86dUJ1JePUj4n0nncHDtCrM8UMCJx6SVQJII=; b=qFi5oQFYoH5HvH h+dYjVSdJIumbcUipuUqP8aIZ/wllqgVH1CpvnnssbgNW5sJ4cDkkzB0g62g7UDTOpRoi/ybKrJ10 ClTNb5xybbj3BnYj2hOd5I/KCexv2SwxZO7tylq2DR6o+qg3vMtuXam+lZIVa2/+8VJZMDXyWqlFv 6b14ovXM8spjEgSOqlkPtXoTaQq/CPNArKzQtjApJTXK+Zu9VfylbFCTH8kjoEny9tHk9dpfEdkXx jesDGKU5UeNBuHiJtfvf1QJaKnO6DvxC2vq2E8yFAV7+c7rd3QtiZtTs7oIdJBhGGUgNljay3NLfU e0g2i+9opmVvwnc8ljCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to16I-0000000BCa0-0KdM; Fri, 28 Feb 2025 14:12:26 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11R-0000000BB3v-2BXQ for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:26 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5dedae49c63so3851603a12.0 for ; Fri, 28 Feb 2025 06:07:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751644; x=1741356444; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=DIg1kgLt5Oep0o5v4ZjEl3Pao9VvKZWVV1m+kaGGsrYTSXSaODXr9+3PsbZ5X255RK EYbFZIXdL0DmN93CzpY7HYqYxJzBSPhCNJjwEs6nwmGXcpexH6WTiJIBWfxd0YHqsxID M9Z6PmJsWny0nkQU7S/Tf95w5n12qsqwZDsPokW9AaZz6OlrcQqY1G51T5wChPQZKLkz 32TKsVSriRYEjPReQ7yYail1oxJ5l/wyMi3eZPEgKmiI0SUxD84Sc2PFUC99ukHJkfHd 7JPrj+xazWkJQjrfPlzupoEdxlSk1lXBhdT3kpYHcHTvbB6zJwe7G+L9nO6vuUMdtcXK iRLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751644; x=1741356444; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=I8eLd311vvL1IIOPvY8+zhlE2VhbbHDG9wmf3ZBAptJ+YdCxs+Ju0i+vOCSmD3Mbyy BoNCK2Tpt2f1GHTksAeQQjV4azEwOk3DRC8DYdMLMS5F3ZLcl0A2YIg13VR4DI4kqZEs ZfsUIBK1Gyea6gI1nypwzMtPPqCdl7Tc5H7kRXM5ahn5zLtZgsHGPA58z7Xt2VVAKKQ5 mp1yZMHdRHTAuA/Lg0RJv/yAlSekMytndiUqCL9adccIXEmyLroA0Pi1GyXn+1NXTwJp OHAO+N2V/n6va5tTYhSmuTw5PD7oGz3u8KIbIjK31xZ35vqQIAFN5RZBpdJeKpeoTWKP lyzQ== X-Forwarded-Encrypted: i=1; AJvYcCUJIlY/7W3rogUjh4f8eiPDbzvs4zXqeTuy/PY5rcI9ZaRK/NSYKNCuHodOpBTSHiNMw6fpkFcDwH9gJPX/@lists.infradead.org X-Gm-Message-State: AOJu0YyxCnVk+bVGcxg098dcbUGWLanz7Vx2YzUhq98j0q1Kxgso460O wI3pW5ospICv12Iph0Dgj3atnHaGjj/OaADsyNcyaReoPD4W4ziiXXiJQVnGJo4= X-Gm-Gg: ASbGncukeOArTYRVP0im5jH8HdVO4JsCknMqMbdSKEfSkd1HD+t+9KB1Z1ulgUiOtI/ LCv9kgxYeRCZmZe9xWtU7HU8ldTjgt39qPIKOgaUGSkAsiiNkc6LjwFVyAQ82jLZcWGlASnHXup bPZiz1QxqX9cH08w9pygyWyPdaGe5siymPOg9WYRaLTTCKTtlAnvC+q6jL0fgpr/MaOPewC4s8Y M+QhbSY3xz/3DReo4qLPoBFywesEzLQE985CF2b9KSKbAcVOq5r4s8m1SZHXV8zVa1W8t6lafOQ eJtVimf6wQ5unWiiITZSHxeVmSxZpDDaY4lK19H6PqBpwG3iO57RDIpBZuG98XLVhdjmcRTZTF+ PdJlscIFABA== X-Google-Smtp-Source: AGHT+IESLHMD1ALp0fl5UNtQkvu55XFyzsWGAW2ARn4G0KwygGU8Ail6xNyHqVhAMNH9i4466iKXaA== X-Received: by 2002:a05:6402:848:b0:5dc:d10a:1be8 with SMTP id 4fb4d7f45d1cf-5e4d6b0e6c9mr2959043a12.19.1740751643974; Fri, 28 Feb 2025 06:07:23 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:23 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:16 +0000 Subject: [PATCH 03/18] rtc: aspeed: drop needless struct aspeed_rtc::rtc_dev member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-3-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060725_556133_AC038FDA X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-aspeed.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-aspeed.c b/drivers/rtc/rtc-aspeed.c index 880b015eebaf796f68ed82c29998f345e1fd418b..0d0053b52f9b90a61725bf29435bfc8071977f9e 100644 --- a/drivers/rtc/rtc-aspeed.c +++ b/drivers/rtc/rtc-aspeed.c @@ -8,7 +8,6 @@ #include struct aspeed_rtc { - struct rtc_device *rtc_dev; void __iomem *base; }; @@ -85,6 +84,7 @@ static const struct rtc_class_ops aspeed_rtc_ops = { static int aspeed_rtc_probe(struct platform_device *pdev) { struct aspeed_rtc *rtc; + struct rtc_device *rtc_dev; rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); if (!rtc) @@ -94,17 +94,17 @@ static int aspeed_rtc_probe(struct platform_device *pdev) if (IS_ERR(rtc->base)) return PTR_ERR(rtc->base); - rtc->rtc_dev = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(rtc->rtc_dev)) - return PTR_ERR(rtc->rtc_dev); + rtc_dev = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); platform_set_drvdata(pdev, rtc); - rtc->rtc_dev->ops = &aspeed_rtc_ops; - rtc->rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_1900; - rtc->rtc_dev->range_max = 38814989399LL; /* 3199-12-31 23:59:59 */ + rtc_dev->ops = &aspeed_rtc_ops; + rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_1900; + rtc_dev->range_max = 38814989399LL; /* 3199-12-31 23:59:59 */ - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); } static const struct of_device_id aspeed_rtc_match[] = { From patchwork Fri Feb 28 14:07:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996484 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79168C19776 for ; Fri, 28 Feb 2025 14:14:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vJAON7D1Gj9k3moNB5RYkJChkCKD+29oGk+cGwhd8I4=; b=wM3z7hu65Lf8vC aL8N6ri5nStwWLCulj7wHG2JE4PEACmSyTFPQe3gNYDYdLUJEFPbu1mIPjoiClseSISD51MqynFqP pUFYVP0ceYwcL7eeG7g0EWRczKt7gmwbEUSYa5Hm3vOIDOa2ZyVCt4/Yw43eK53AYF3RbYPx913gP CXuqKVICAQ7bKyo66LQgp+l+UhiyFV8JHNMh0IH1JAAJqKs6H+Zh//+KB6cFDYxy0PqBHZuDMV0xb AzxL3FMHZZFJDnKwzIHCqAZPkkpioSWNdhybgbfwUl2g9kH2NxNqyk/TwCbtiRFLgU30/OtdqsmEQ /4UlB5q3JtQoE1sbYDFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to17o-0000000BD1z-0MWq; Fri, 28 Feb 2025 14:14:00 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11S-0000000BB4l-21w2 for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:27 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5dedd4782c6so3925559a12.3 for ; Fri, 28 Feb 2025 06:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751645; x=1741356445; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=G4PPb6eSOqQsfGd5jw8KZtBIDlaZ46OUx8WEWGYE7MpGMr2pdIAXJto70kQmyhvaka JutkpevsT0A/Grz9sf3a+6xhtTMiKdIF9OQNKxZKIR81IAGOopAh0oSkIA74wlMoJcC+ jixqNRFWE4Y7AKLZyEaCsClYmR+D73eHprAbmcXaE9wb5TtkDaRAmlgrloYZk1aFQEs1 Kx+hVJZIfoHXakIEdS1385F4XGH7yECRxrQm0JeVRb/9h1akck80j2vrCQ6C0F8Bpdva 1Ku6vhqnK00EznVTbKZK2T+SwFXIg+9m9/NLobkL5bYPzdHCvQZb8ErvodJ5vBT2Wlmm 2CTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751645; x=1741356445; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=t633fLBLM1kAxvRH1XX7XbCdkLkq4EmIpOobLAGN7m1HW7CnYFFcE3QG6f7bKKJS/x So+HVyXNKkLmwWhJffmtArhV4+Tsn/twj2Y07B5smsDMwkHennEBOjW+sGvII11/dKli Gtur8ZZqqH20Ewx+IvFJSzX0fCL+ZGUd7MsRQIlNXLcp46gty4jlcZfrTG6AObvR2XB7 fR7VOYJ0UhtzbAGyB6kFMZop26akrs3wiXPiMX18/jh3MIccFwy6StfswKvaXwgWWuq0 P9h6ZUVF9ImOU0oV0IntlMPv5yUHBNJLXb9MeY2Kb5CAzddnDPa+SbL6fKY5hdQ39tr4 fyoA== X-Forwarded-Encrypted: i=1; AJvYcCUCjgZwEwfG48Ct8lQ153ZWQTe7UL4Ms/De3HUXgOxCpBv5vDTN+K+cIsOh+Cjb/DmKzAbc9R6/xgSE8yFP@lists.infradead.org X-Gm-Message-State: AOJu0YyZjIzuxirBStRoZGbA1sNgFpqAGpGaO2PQv+M2Rut2pfgjkQrm grlqJ2Bv8aj1hiRMSTnlkcoxMS5xpEfBlsljXrsjkEYXXJVu3XH17Ozrys9HRZY= X-Gm-Gg: ASbGnctllWQMfodc6H3jKSyfMrqYvC1/WYXiQB0syBoM7AyZAVj7GvRbOYDlslcVM1d uP5ulW6x5cnuGL4QLg7rkQN5wD9L5r3rWrCR6idEsOiTMBdnh/QFB2ozp0kAORLQQiVYNCn4nXc HnTAk1EP6LX4a8Ua3roELTHjpIfx3Vpo+myjd/NpJktS4lUyMA70J4k1rRga1pW53y0XsJriVSC O7hTMLETv6eHhRDafVYALqyCUlD7Qw2gVmJsrFGeoSGSFS4B6BT4ZUfmOvpI2bYbw3sLFn4bCuA 4D9tota7briNG2pEQPcas/j0uLWejTEkUxhXD7AG7eP2CBrcjDw3lHILVmtURWNRsC1J8X/emnl wGsl/nUz4Ig== X-Google-Smtp-Source: AGHT+IFpdib5eLXvAKlYp3fUyW87rQ1IfZ8GEMoJsXuLGkDw56XS2aTZMwaUmenZ5apuVJAYF/Nggw== X-Received: by 2002:a17:907:c018:b0:ab7:fc9a:28e2 with SMTP id a640c23a62f3a-abf2681f8f2mr377695266b.47.1740751644708; Fri, 28 Feb 2025 06:07:24 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:24 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:17 +0000 Subject: [PATCH 04/18] rtc: ds2404: drop needless struct ds2404::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-4-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060726_519484_0DBBB6A5 X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-ds2404.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds2404.c b/drivers/rtc/rtc-ds2404.c index 3231fd9f61da49bdaf00e46486fc34836094ee78..217694eca36c3432a8db3b874374e347eeb802d9 100644 --- a/drivers/rtc/rtc-ds2404.c +++ b/drivers/rtc/rtc-ds2404.c @@ -31,7 +31,6 @@ struct ds2404 { struct gpio_desc *rst_gpiod; struct gpio_desc *clk_gpiod; struct gpio_desc *dq_gpiod; - struct rtc_device *rtc; }; static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pdev) @@ -182,6 +181,7 @@ static const struct rtc_class_ops ds2404_rtc_ops = { static int rtc_probe(struct platform_device *pdev) { struct ds2404 *chip; + struct rtc_device *rtc; int retval = -EBUSY; chip = devm_kzalloc(&pdev->dev, sizeof(struct ds2404), GFP_KERNEL); @@ -190,9 +190,9 @@ static int rtc_probe(struct platform_device *pdev) chip->dev = &pdev->dev; - chip->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(chip->rtc)) - return PTR_ERR(chip->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); retval = ds2404_gpio_map(chip, pdev); if (retval) @@ -200,10 +200,10 @@ static int rtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, chip); - chip->rtc->ops = &ds2404_rtc_ops; - chip->rtc->range_max = U32_MAX; + rtc->ops = &ds2404_rtc_ops; + rtc->range_max = U32_MAX; - retval = devm_rtc_register_device(chip->rtc); + retval = devm_rtc_register_device(rtc); if (retval) return retval; From patchwork Fri Feb 28 14:07:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996489 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FC02C19776 for ; Fri, 28 Feb 2025 14:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3YUs05DhFs+LgAiWCc16LXWwILhsHrllKlQ8YfVHzKU=; b=y9m18JkR5VeRoI 2AIbpBwSG9DAvYAWZ2osP7X6zHTIpTafB+/ztfYgbgeLqdMsNhaP24F11uT7eSPVkTROIdKxWGiRt wkl+goCZlYM5P51dLWAcJMOJUlXjMEFnuicHgo/Z+zurFcMgyoelroyRiFvFo+Y4lx6PQwFGGmQOw LE5zXksg1b2kJZZRJ0npGBTCBxJEESOxSJGrsAMVR18MYLJ6AXRNlkjU42hdPdAL2aNESamOLdqRI vzjD1wwh9C1dP+iftPvgpix5IFLPg6UgaN0AT7J4m9iCxTXX7/aC7X9L7wggZkE+oy7/hcMXiV0Wx P+m4Nw8eC32CinNamkzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1At-0000000BDqy-3P9y; Fri, 28 Feb 2025 14:17:11 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11T-0000000BB5L-05IE for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:28 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5dedd4782c6so3925584a12.3 for ; Fri, 28 Feb 2025 06:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751645; x=1741356445; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=jeU2JtskMdAYZtNYJ8cEX2hQiiFRABy15ZOpG+7C3G+2Brg3oejPx1FemRGjnRXTyc 3G5Q0LpfOvREynm1O7rtv9W7qI/CLpTONiHzThsbP7FmYuTWPy29Kh7N94ezawSEEXMh hd3oljXol9S1QIasSrTRyappJOVYuONc6uAwL2iknvlJCW4ypE87hKuncG+ui1i4TEQf uhPH2T56QzfZyHYLqvN/6wc3WPsEBxZ/sX+gEoUO9SQhrflkdO7XOuetK8F91hgxtzQ2 BwNGPu2ikkxKOPYHVclXI1spoVBWtHfH/fLnq2mdeOkHJlEGz+gq3EyUQvXBSxZ5UVE3 IKiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751645; x=1741356445; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=jOr/7tR0Myv60gqda95AoMcA1ozDmhaki/+DLfGHwuWT1XWUj1C30xJKuJerahCi9s mmdF5rgW0j7Qpqu4ocjhl5+1I0UPL68Jd+NzUPEw3QJvRGS7vwjyIpcw71e4of/ffDHQ 1RvH/76M3h+JxIwcbJobC9fDbkhLc86mi1EIeRQ1etsXrWsk8GmmpGwBXJLqkphY9kL1 Xkpai676ut5xdSUn860JDS/fgj8dYb5Hs4YEIlMZ9SGjb3kS9S02Vus0pJG72cFeQMHY vD8Gnhzy/hTg8zNUFzkO7REZ/nMfEQNLkXkZsKqyRrZQu2NloCbwAgSt7tSdGXbZj1pc Qmzg== X-Forwarded-Encrypted: i=1; AJvYcCVeiYzX4NEB4m6rvJYOxjhukgyWe+bk0fKiYt1ryzLeR4Zt/I2Bt19auObrxuCVq9eou0Et+rlNpkO6OmJt@lists.infradead.org X-Gm-Message-State: AOJu0Ywpses8nYimsBO70VEg0UB0A/ViT13KrjRYx4p7W1Ew9Ha31VAt A+P47uZOUOBKv66+wqt1VOZtAp6+mALTtHI+4jAm2MiuORcpFTUFUg2rTl4rHfY= X-Gm-Gg: ASbGnctUvXKop+w7ZtYleJkNxFArqLiJ1AZjt6K1KWI4HUg59eP/Z1+LsLAv6dKtbtY unk0+Lh5Yo+sPGdeHvMh8rG++Ffrh8658X9nUGkHjJ7Nf1GbQ6gVrxD6LW2mQW2rIIZDgb/G5WX JXsaylaYZLzuNaDC+RncYxppUcvvKXFU8dEMDhB+g1VkWkBlmHrQbf9gycOEueDsagUe84rxbYs d5sukBRDjSVZNYgOZAY6EoTVPINy/loio2aA6iURHQChJAIR111EJCII9vBSgZmnvYkuoTqBFHL 9Jxu+qg0rk9qc5fRM9/riY9eQsnfAb5z135sqIUfcv2ty3aI8B/PBcOTkxT6q57TFreS9qw/uDw HVsPrZBSO/A== X-Google-Smtp-Source: AGHT+IFjP5A5it0oOhAqjGMiq+zBlLn6/wyStXZ9TEpg3CsfQx18Ux73fzaAw5ZlIGleu7roV3QB1Q== X-Received: by 2002:a05:6402:84d:b0:5df:5188:11cc with SMTP id 4fb4d7f45d1cf-5e4d6b702a7mr2552045a12.20.1740751645245; Fri, 28 Feb 2025 06:07:25 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:24 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:18 +0000 Subject: [PATCH 05/18] rtc: ep93xx: drop needless struct ep93xx_rtc::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-5-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060727_055885_5F024762 X-CRM114-Status: GOOD ( 13.32 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-ep93xx.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-ep93xx.c b/drivers/rtc/rtc-ep93xx.c index 1fdd20d01560ef4fae2b996cf366b4f812329225..dcdcdd06f30d1ff6d0939f6bcad2c17c03c5a65e 100644 --- a/drivers/rtc/rtc-ep93xx.c +++ b/drivers/rtc/rtc-ep93xx.c @@ -28,7 +28,6 @@ struct ep93xx_rtc { void __iomem *mmio_base; - struct rtc_device *rtc; }; static int ep93xx_rtc_get_swcomp(struct device *dev, unsigned short *preload, @@ -123,6 +122,7 @@ static const struct attribute_group ep93xx_rtc_sysfs_files = { static int ep93xx_rtc_probe(struct platform_device *pdev) { struct ep93xx_rtc *ep93xx_rtc; + struct rtc_device *rtc; int err; ep93xx_rtc = devm_kzalloc(&pdev->dev, sizeof(*ep93xx_rtc), GFP_KERNEL); @@ -135,18 +135,18 @@ static int ep93xx_rtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, ep93xx_rtc); - ep93xx_rtc->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(ep93xx_rtc->rtc)) - return PTR_ERR(ep93xx_rtc->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - ep93xx_rtc->rtc->ops = &ep93xx_rtc_ops; - ep93xx_rtc->rtc->range_max = U32_MAX; + rtc->ops = &ep93xx_rtc_ops; + rtc->range_max = U32_MAX; - err = rtc_add_group(ep93xx_rtc->rtc, &ep93xx_rtc_sysfs_files); + err = rtc_add_group(rtc, &ep93xx_rtc_sysfs_files); if (err) return err; - return devm_rtc_register_device(ep93xx_rtc->rtc); + return devm_rtc_register_device(rtc); } static const struct of_device_id ep93xx_rtc_of_ids[] = { From patchwork Fri Feb 28 14:07:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996490 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45DEDC282C1 for ; Fri, 28 Feb 2025 14:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FQNc7jsOxspIZyBnQi4vNnsDnVZv4mH2lW7IFI5pJHY=; b=S70rCqTDsFlzMD H2qHHVMEhxkml+K+xfi+0hUiN19FSZFX98lI+LfLa8BM+ogb1EUUtcOkjMJNNit2BLaF433troT7q G1mv1uQ4KGJRJ9HcSG7+o4nwrgYDHNkWyX3PEeVpk5MvRc6gQefNSPxCn3emFMc+MP8LNRqgg5gC5 kWTO8EKVSPUNo/y6rWmIk9roS2gN75Ezp40539clvd1BDTVzEJtvr2GbMVZ1vmTmo+gWq4gOeQJqw GwwxEBjUHEKiJSuwzFb7WiV8UjgSbrL7xI2zkDwToTwC45Jya+Mj7l6X93tvrvAIic/+TKsSA3HqH AJFV5JPVK4Q2KsC66HVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1CQ-0000000BEJv-3qjJ; Fri, 28 Feb 2025 14:18:46 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11T-0000000BB5l-149o for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:28 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5e4ad1d67bdso3214419a12.2 for ; Fri, 28 Feb 2025 06:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751646; x=1741356446; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dZH0eiBnc3WyY94yEis5FUZqmpsbyvfcyDb3myV5OX0=; b=Tete8FJrRmJOVMYDzdfO7FOg3YK6B8VAh+fDA3yTBC6G623oCWjYNz4cNn6uxg9GeS Y7kq2HgqXo7qFWMXM7O2RaY35+/Zz0tqKDWBQYBrUwJ3AUVmzjlqXk8uCZgskXhzyjII m0ssSIwhTxK3EW6e7seGS6Y+2NuQIznXJ7CWX2DPDnB3Cc+VrYgMwfBUsG/zNJby6CDC Rr7PsmHPYGZuL9//Z+2Jd0edzBWRA0pf7UiZZKK0o7tV+iB8lFLGsfXRhtYWhjkPEHUL kLD4vMhKR8OGzxGk6C+FG8zLcDTmgyM0w0cpDxBL/NOmZvaeNpyFkIucf6R3jVjdSmb3 TarA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751646; x=1741356446; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dZH0eiBnc3WyY94yEis5FUZqmpsbyvfcyDb3myV5OX0=; b=tBYvnWxl9wW0xMGR6b4uZCf0rQ1zWpPHHUjzbmz7QAWv0bxNMjSEsiHwJiwIobQXVw ArHVjRs/pfTxuJIbGoScXf39HUAyt5KFjXlOtc1OpudMyGEILnqbtjpVu0yUvNutv+Kp FIxYI/lTcKOve7PtiPahBNX571dWw/PyfgVcZe7RViyO0Sbo0V/8t78+OxhHy6KG5DaE l+BHoYME+sAAonwRFXITg9dpgQYAf7BiZnj4gKdr1xr/0BeYv3/y+NlGM+qEfki+MF6c 2y5GQcb7neVJF0EtePlZUHJAByxrx7xd+7tWWUz+qFjK2n5ZxaHRMWJInEqIdT/hEuEG 0Czw== X-Forwarded-Encrypted: i=1; AJvYcCXyKGeGvocU5GRiSGcP5t4tWaJSkFUZFuQzCYyfgvX4gOifzidckQ6EjrlvVRMpvRaB3EibJBOPSv7lvmF9@lists.infradead.org X-Gm-Message-State: AOJu0YwNy/4Ek7l0SO/ADha11Zv+nAzG5sUMHStiQ7TLZ2k+MZBIe1rl MRZlbD2YM1L6+Oj+TtiK35WqfsXYfNyEjq2hSKrWN1gz/tbx5qgH/uM09DjaJ44= X-Gm-Gg: ASbGncs6yYDq02a940E7KMZh6b3J9TR/ky+Xf0TbHvJoFu6Yhnp7C0wT2Ps/SM8wz1e Ke80XwZztD4P0BAnNvb3fKH4tb0cMmDDMlEWqAJc30hyIjbX73qTJysPwwFUWOFWyWlZyacrDU7 GWxNP9V0dXMooIg6gznlDOa+Pl27XW2KhLEeEeBTVpja78N045F1thwtWpNKJjK7iGBNg0ivYpp Dk80kN5Uj7DvIxLD1Y8y8pEc4OCZqlwuWegPkcknuMBfvuQljpWhyi14DLLacfZ05f9Y84lJRVY sePDBtPWmX41LaTFVsXJTPtJ7nOYhlydfzkLFsjNGraixqW0cUIEsivagRCL3kg8Tv/sjEXHR5l cDsUcJHpH6w== X-Google-Smtp-Source: AGHT+IFbzXWayjdSMfWjy9cwjYueSFy4YBp7IQ8OjzR2IKI5f4QLOeDnV9cvNi5W4D61UevFMTrZwA== X-Received: by 2002:a05:6402:239a:b0:5e5:552:32a8 with SMTP id 4fb4d7f45d1cf-5e5055238efmr931950a12.8.1740751645786; Fri, 28 Feb 2025 06:07:25 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:25 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:19 +0000 Subject: [PATCH 06/18] rtc: ftrtc010: drop needless struct ftrtc010_rtc::rtc_dev member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-6-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060727_330100_CA64A186 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik Reviewed-by: Linus Walleij --- drivers/rtc/rtc-ftrtc010.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-ftrtc010.c b/drivers/rtc/rtc-ftrtc010.c index cb4a5d101f537e20a685bb022e6f6516b0df8271..02608d3784958e69ec0ecbdb9fcc8b333b19e7cc 100644 --- a/drivers/rtc/rtc-ftrtc010.c +++ b/drivers/rtc/rtc-ftrtc010.c @@ -28,7 +28,6 @@ MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:" DRV_NAME); struct ftrtc010_rtc { - struct rtc_device *rtc_dev; void __iomem *rtc_base; int rtc_irq; struct clk *pclk; @@ -113,6 +112,7 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) struct ftrtc010_rtc *rtc; struct device *dev = &pdev->dev; struct resource *res; + struct rtc_device *rtc_dev; int ret; rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); @@ -160,29 +160,28 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) goto err_disable_extclk; } - rtc->rtc_dev = devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc_dev)) { - ret = PTR_ERR(rtc->rtc_dev); + rtc_dev = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) { + ret = PTR_ERR(rtc_dev); goto err_disable_extclk; } - rtc->rtc_dev->ops = &ftrtc010_rtc_ops; + rtc_dev->ops = &ftrtc010_rtc_ops; sec = readl(rtc->rtc_base + FTRTC010_RTC_SECOND); min = readl(rtc->rtc_base + FTRTC010_RTC_MINUTE); hour = readl(rtc->rtc_base + FTRTC010_RTC_HOUR); days = readl(rtc->rtc_base + FTRTC010_RTC_DAYS); - rtc->rtc_dev->range_min = (u64)days * 86400 + hour * 3600 + - min * 60 + sec; - rtc->rtc_dev->range_max = U32_MAX + rtc->rtc_dev->range_min; + rtc_dev->range_min = (u64)days * 86400 + hour * 3600 + min * 60 + sec; + rtc_dev->range_max = U32_MAX + rtc_dev->range_min; ret = devm_request_irq(dev, rtc->rtc_irq, ftrtc010_rtc_interrupt, IRQF_SHARED, pdev->name, dev); if (unlikely(ret)) goto err_disable_extclk; - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); err_disable_extclk: clk_disable_unprepare(rtc->extclk); From patchwork Fri Feb 28 14:07:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996491 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AD83C19776 for ; Fri, 28 Feb 2025 14:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=honpLzeJN9HARrQ1SV4QPdzugwa15bIeIM+VCyykdk0=; b=u4f8518K9Mpnmk 8W+gLHKccryP8ZdxHPHUx827oXuvwwQgUL4wW8A3BNBpsrjAA0gqS3JGc+7lUfAYaTX+gASI7VbCL +V7ojOuV8643iBvoJUU+bXBR2lpZrmpQKqBb2VfaccAtTt6lgT3tLfyj965T4aYb27x5UkHNXo6g+ RFMklxRb4j5xwhdZnk6GD4r9W9DxONG5OIcfxBtLkad3cEUUeM/acYZJCzA+iGB9gu0SXSXkh+Ak4 MJA0NMvhhK4LB7cOo31+jMVL2Cwru5/0uBkwLN3bnQ7MH28PGn/rdJ5vmeL7dqWI9pyleUAlZTG0f dRp3mZVG6TGnTw7CnFVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1CR-0000000BEKB-13do; Fri, 28 Feb 2025 14:18:47 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11T-0000000BB6U-3Ap4 for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:28 +0000 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5e04cb346eeso3601927a12.2 for ; Fri, 28 Feb 2025 06:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751646; x=1741356446; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=p4yVOAy3csOTsWpp6mGDNtxmnTrMNFqbdiNd2nBPu2gbRkRykRgqC1KBGPpAPkbz4m y17/r+/cbsmh8MzeSUWVINhjhZmzDmXPLP6dkfn5e2C0Uh9necSCION/UxbxGqkhjoqj rDHetFl2PR3Hcf51CaG+fmNEOVgZFaijYVDonqVybwN9zwwiIqDtwyitpKlcjM05vLNg QeZ7T0MB4OnYWtRAxyEJefo75iRKz6G9n3GUikY54BMUlw6zmngcZmbDhtX1Iha6+ZWF 6n4mCOOL5XWssG0OPObszW5CNbIyuBbZFVgJqNKA2aWhge/nS98lGd0TEil2M+XlFaCu ENGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751646; x=1741356446; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=JepL5gisFFTK3X2w7NBYJO1uq+LZx3keQw4RAMNU0kbDBvSlq4KCa0Z5d8ptBVJm/i 2UwQae5L2RayxyRsb0bqWUtLUm4RPPRCIq0eaTq/imcOyH3mUpq90GjPzwuM5o4VPCRf dp/z5O0OjSTHssQXCWAcVae8txYU8ViOlzpKTv3eXDu9WHeCY1T8h1WfDScimwkLn1LP u8L3aImY4KH+89Olb0Wlf0jSkE525UO5ISSavUoVeteTXFS8BLBNeG8yvuDczx/PX9Xr XAbP+qv5beffKzyKyy+vmYnzZitdqhjDzlnRDwFDH/VQL4DdaNRZTm9oEzkAmx8mXv4z rsFg== X-Forwarded-Encrypted: i=1; AJvYcCUFuA4yQ8pD5xzoczX6WgTkKysp8E9kpfEGwrWjriGUj4YR8cMp0494hG8MwWcSnlm624yNBh2mZAQWhZVV@lists.infradead.org X-Gm-Message-State: AOJu0Yy57y38TxDXV5RSMt2H73GfAnrXoYqwWsERpiduUMlxJpaxJIoW oMfsK+yzZqaWdVfn53Wxe1JOE2i/zhhOFuZHCjY2OO8YxIrEHRAvRwwr/JPEnAQ= X-Gm-Gg: ASbGncur7M67XZRaOCjuYeds6dWq2i4cv5wxFVgDe2EH+l6cb3pZ+piOJGnoClc6hUa kCRTTmAtRm/SMiO8jLU3SlloYqhUCFlNJxyMuLGhUxFiKapJjTayLPp8tODvpWs6aXWCF08lrEa Bi2eijgl4+y9DlPRFKca9GNurLTR+6X9KdrusxcTlgOC8JCZ+a7xjjB/qQc62LlSNissQCtWEkc tlHNhJz7/X1BNaTpanTaCbeGa7fgPW+VHU8F15txGITbUsYANBLjMZqX9V/DbjydKNzjPze8sRt 8qF35ldX6iqzDdo6JsbsJ2wVM0+PATT8XfZhfSrk8uxU0vs1G/u2Rz0jTJAO5E8ACZIq88nBZL5 biOvC26f2Qw== X-Google-Smtp-Source: AGHT+IGw8/Em8B8f2s0ytjmI+eWh2dyA3vFh7dmQ8lnXofAka3id8ECQEXS4gzzEIESeh9rUlyHc/w== X-Received: by 2002:a05:6402:270d:b0:5de:5263:ae79 with SMTP id 4fb4d7f45d1cf-5e4d6adec08mr2881207a12.12.1740751646341; Fri, 28 Feb 2025 06:07:26 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:25 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:20 +0000 Subject: [PATCH 07/18] rtc: m48t86: drop needless struct m48t86_rtc_info::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-7-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060727_810907_139C704E X-CRM114-Status: GOOD ( 12.67 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-m48t86.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-m48t86.c b/drivers/rtc/rtc-m48t86.c index dd4a62e2d39c73b1c8c3f50a59fd4fffc0b45105..10cd054fe86f9e6be74eb282222b2751dd91cc7e 100644 --- a/drivers/rtc/rtc-m48t86.c +++ b/drivers/rtc/rtc-m48t86.c @@ -41,7 +41,6 @@ struct m48t86_rtc_info { void __iomem *index_reg; void __iomem *data_reg; - struct rtc_device *rtc; }; static unsigned char m48t86_readb(struct device *dev, unsigned long addr) @@ -219,6 +218,7 @@ static bool m48t86_verify_chip(struct platform_device *pdev) static int m48t86_rtc_probe(struct platform_device *pdev) { struct m48t86_rtc_info *info; + struct rtc_device *rtc; unsigned char reg; int err; struct nvmem_config m48t86_nvmem_cfg = { @@ -250,17 +250,17 @@ static int m48t86_rtc_probe(struct platform_device *pdev) return -ENODEV; } - info->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(info->rtc)) - return PTR_ERR(info->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - info->rtc->ops = &m48t86_rtc_ops; + rtc->ops = &m48t86_rtc_ops; - err = devm_rtc_register_device(info->rtc); + err = devm_rtc_register_device(rtc); if (err) return err; - devm_rtc_nvmem_register(info->rtc, &m48t86_nvmem_cfg); + devm_rtc_nvmem_register(rtc, &m48t86_nvmem_cfg); /* read battery status */ reg = m48t86_readb(&pdev->dev, M48T86_D); From patchwork Fri Feb 28 14:07:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996492 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7A50C19776 for ; Fri, 28 Feb 2025 14:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UOnYn67i7kGRJPmH/AAZGgDfaBJkjIWhqsy5ZITOdOA=; b=fwxIIePohyBc1V KuG3tCTvddMaSFU8PanXlRMQUdPRFO5c+jAuGG/3L5hhWnk/WK0Uy9OdNTAAI7eqDY/LkB6IvIT9S h3aKq69s9ceqhOyIhMZqmqF3m6TkzQNOoz7KrlD969O3gpi7nEnSGdA01laL0d/JvHt3MYxP6Yrig fxqD+tl5t5XGgQ5eRBERkhLfnKcoPtX4MPo0SxtZCvhHLhCN+NinrtIjmAFQPdf9HDPmtPdqcCPkQ TiFZZ2zEWJIlgjwxc384JznXi5OE1dPrcLx9bxBJNZ/8/il6bWZkBlavWYRwMMeFG9C8qjPINxOaA YFjFNIQ7yLTfoNfFIU1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Dx-0000000BEeq-15yR; Fri, 28 Feb 2025 14:20:21 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11U-0000000BB7J-0uTR for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:29 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-abf3d64849dso62140966b.3 for ; Fri, 28 Feb 2025 06:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751647; x=1741356447; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=aVcetOIQHsUcyIeSUA7ovu5xYQAymhLIBjvDdHoVM4DkeqHws9LSRYQFQLjDA2RxDI 0lAMT0wfcc0y8jYudqXaZUGp3QIGN7gEkoKxUgA1F+wJik1kNXEiklFkzzD0h6MgZeLN 13mGxVQ0JEMOBsdjCuews3QsPBzwWyzo06O013+An7I5FMoaAzc4gUhPd/UYJnhFLy1c Ef30Q6cQzE+nrLNB5sSrhNateSfrbGOFsmuEI4FbofAhbx8Avk1jWarjAOrHGIW2EjTd /Lob8Uviw9gas12/0pCMA9MJFNfxWcIgjBGk1ECjHR/C8MNVp0u/aexZpBaZUPalOMvM 74/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751647; x=1741356447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=RVJPQiWkG65L2WbDor4x16uoVv5Pu6XzDdvyvxegVYOe/swLTm0M8oE3VWAyiIGh96 VRLPrb3WGs5e4xaHRmuZGaUwmzRcZEf7+WTfsz1l6AIMLexUq9UFE4/xsbKW9BS3FCQi e5m3wX7wzjU5zavLPfrxTy64lnlfg/xZF1/ChgcVhXkrLxy1BWPfp9RbonNFtUY9doKB 4p5xnjMITiVXECIQLPYY9QsOWDl3Ws59UyGFGX5ECQcpLKPR31AfiJHFuPAY8ai6cQBb 9LwlaLqR6BlT8mrwrqUMlwRZYVMh2KFOMS/R85mptRiCAg/xssqN5+y7Ro4BWaYMnXA/ wiDQ== X-Forwarded-Encrypted: i=1; AJvYcCWIKwi3zL+EVQOJ36MHun3V5EzFosvFG5ZCReCdbC13ue565LO4yfb2RA1o1XiLxrH4Nuvuz4DXWVi5924d@lists.infradead.org X-Gm-Message-State: AOJu0YxNGuwHaKy9wxSEWqUssep9ECpac/7H/iOr/bo7sufgwxbF97EQ q2cKI43oEn1qUKmtzNkhMpQJHjOf4IwB8f5y8uEXTbcBgZNyOthgBL0XR+2epwZdru4PSCfMptL Fczk= X-Gm-Gg: ASbGncvzOXTDeHMazHrjnfupfbA7C31TeWTV/wKG2RiQRzAK+oTucXm18sxTYuibr9/ e/iuMpJwRjhCIOu6ahlyr0cyWxB7sWFTpgIez14kzXBbkdweebcGBVA0X+5q792t22VeruaHz6b mjT2r6p2VC5IY+ZwfsvwV+7/Xz3Dm2SfyxmeNtxV5r7icBLCfEGPJSn2IMXZ1wlm6QhrXTJLZWU GATrFmpwUH0sWl77KhPv2jobV/9TfMlZ8r+9Riy2aUeB4tPQDfRRQFqPrg2RZ6PZOyJkE2lEztG NwmCE1xTq2fdZN2iL0RxkEoFdtSfd31UvMpwYooGG/RfYUcVy+Ia3xIvaqopn/2mJRAWYleadwu FkM8VtiptsQ== X-Google-Smtp-Source: AGHT+IELhJPOd4W0qPAgNgABcD5moXsKlcKW8ZKlMd0/6RuVXfSWqRkHz67gqaNmak1AZcnDjWmnpg== X-Received: by 2002:a05:6402:50d0:b0:5e0:818a:5f4d with SMTP id 4fb4d7f45d1cf-5e4d6b628aamr8322653a12.28.1740751646827; Fri, 28 Feb 2025 06:07:26 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:26 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:21 +0000 Subject: [PATCH 08/18] rtc: meson: drop needless struct meson_rtc::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-8-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060728_269937_3AB75358 X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-meson.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c index db1d626edca5fbb590f26c1cdd0774d350244a99..47e9ebf58ffc2f2b6c65932f8ec3773a213a62ef 100644 --- a/drivers/rtc/rtc-meson.c +++ b/drivers/rtc/rtc-meson.c @@ -59,7 +59,6 @@ #define MESON_STATIC_DEFAULT (MESON_STATIC_BIAS_CUR | MESON_STATIC_VOLTAGE) struct meson_rtc { - struct rtc_device *rtc; /* rtc device we created */ struct device *dev; /* device we bound from */ struct reset_control *reset; /* reset source */ struct regulator *vdd; /* voltage input */ @@ -292,6 +291,7 @@ static int meson_rtc_probe(struct platform_device *pdev) }; struct device *dev = &pdev->dev; struct meson_rtc *rtc; + struct rtc_device *rtc_dev; void __iomem *base; int ret; u32 tm; @@ -300,16 +300,16 @@ static int meson_rtc_probe(struct platform_device *pdev) if (!rtc) return -ENOMEM; - rtc->rtc = devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc)) - return PTR_ERR(rtc->rtc); + rtc_dev = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); platform_set_drvdata(pdev, rtc); rtc->dev = dev; - rtc->rtc->ops = &meson_rtc_ops; - rtc->rtc->range_max = U32_MAX; + rtc_dev->ops = &meson_rtc_ops; + rtc_dev->range_max = U32_MAX; base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) @@ -365,11 +365,11 @@ static int meson_rtc_probe(struct platform_device *pdev) } meson_rtc_nvmem_config.priv = rtc; - ret = devm_rtc_nvmem_register(rtc->rtc, &meson_rtc_nvmem_config); + ret = devm_rtc_nvmem_register(rtc_dev, &meson_rtc_nvmem_config); if (ret) goto out_disable_vdd; - ret = devm_rtc_register_device(rtc->rtc); + ret = devm_rtc_register_device(rtc_dev); if (ret) goto out_disable_vdd; From patchwork Fri Feb 28 14:07:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996496 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED4B2C19776 for ; Fri, 28 Feb 2025 14:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XyVr5izLhXb/sSx/VvXcr6KZhXbVONdp3aaTrSadVp0=; b=xctO9elbZ3Cylr SuRXLtGYET4xNRKZD/BBWbmqeXKYqBCtSaDu1S2UgGPdB1tv3JmMg9nXJmw1xv+xaG3+/s+x3X080 V8elmpJUVNHWuZlTum5ckhKy6Zkdsbj1uDBcsmbnJVAZfYtinIUibrs+UCVy5R1hPyNga6d+00I4D AAulpS9i5cRQJs8qA+P/aIASixOYYPYNtFSuW+p7rYnJ5UpF+/gg/HijaPuZ/zru8XxtrbhEOAy1f EA4oG6i8yDCsre3ARNZPZHdRndIE893XH38W79dDiMv5fLuYj5Ob/nF2fL5wcVuzM+4rajzaJnMhT aalt+p9nJMRfS+kWgR1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1FU-0000000BF5O-1FbV; Fri, 28 Feb 2025 14:21:56 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11U-0000000BB7t-3BEp for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:29 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5e4f5cc3172so933670a12.0 for ; Fri, 28 Feb 2025 06:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751647; x=1741356447; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=Skmg0PDZ6aTEM1UQM2YOYOU4KpBZIBFqyoOQ5W5ch3JCED4Sw62F9ujqUT0TZE+lf/ 9zoRCEezZiJ8Ja5hhMhtbjvGTZfhOAu0IpQjlCMFOLi+jh5kQ8FaHhOw1snclIBL1v0W aooVUH8fn5+R8Qji2X6xLdaS2TbVyRl0TE8qrlfAjtUkYhh35/MAZDYLJp/zoOZP8xrw oYtIOK9sbLjLS3PTHGd+bBaKG8AqXS/Iu/8GNpBfZLixMrHonhL++ifyPGTC5gT2oqKU wJgFeb3YhxIn02RDelaltOnsOMLI2CGKuZ2N/WtlJhe0rk4zoW8isBn8mtY/yoSKhJSp +aaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751647; x=1741356447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=bO8w4pLLHPc6i6BrKOayWG/euzpfzgvduDD0muKb4Dw+07PWeFVbzpAS5kG8QxZ4w7 hV1PezTuOqTKOhQ8565hBPdu3+2mSwF7sscgPZk0YKinqewSp7gKSxJFWCSqjsw7Rlel lvM2/77HWrgj+18SLh8AUyJLpMFyp+YsArRs+AxlSSVO2c67RraylqG+cojOIqrFUNg5 at9rI0ANLxNkHLVNi9rQc4tOrgyDjfsD/6zBNHA/kIdunv9DMvxNZNDkZwNKjj451/tR dhcIcs/qCHC8m9Fb2I9vuy5N0noUNRpLagzFOAuGswneuipQoOQeZqCLWAA/uMqs/iJw DD3g== X-Forwarded-Encrypted: i=1; AJvYcCXCxMO9P1OY5wpyHk/e0cg+kMr/25SafmNlUF0GqWZ3ZrQEHclKDgz363WJarLi31OT06v/YeNFPlxr6zNG@lists.infradead.org X-Gm-Message-State: AOJu0Yzy8iP4UPPcLMn3vocmBmV2bwDdhd+I34Ju7MROOhBuPs3Rfb9f KxaRJeNiLtv+IUsHTXVIT9BmceRqa2SYHkKfqhGAJU77j9nPu402bpGplSd84G8= X-Gm-Gg: ASbGncvrqzRg7WO48vW/NXZ/QVDjXkSy+fSpnQtPbQWcRDkVpPei6NN70XP2TQ5BZHj aXIVP5hikGsM7c5ilOM3aDKY16NZRCIVtRsmY+RRlNIj1NNDs1U0zWbxMyvLooiUai4Ee3l9Xnz QCVpPV0i83eMWeHFORNnpQOIU5B3d7mWlJ+s8XRdnJukvEmDgdP3RHo0FigGQv3Hs2K9mTs69M7 FYk3R6K2SSifKkRxU4a32f18k9SLFDZ/qeqzC7UYmAGByJu5HHD38S2+GJXcmDoHKOZqJmMq0mh KsEPH0JmWCjlLSp9jOdbcl0MDgyTOCMFr7U7XcFg9ngz5UZa0QX4qPzlybtcE/0CL9gO3jHYBGU kYOvU8RSm1Q== X-Google-Smtp-Source: AGHT+IGZCKi+h7liDGF2k254zFpRo0bnTt6a/BEgRPyIDc7kptNekspya74S4whe/rs/kwdpZDQeGw== X-Received: by 2002:a05:6402:27d1:b0:5e0:82a0:50ab with SMTP id 4fb4d7f45d1cf-5e4d6b6240bmr2836488a12.27.1740751647311; Fri, 28 Feb 2025 06:07:27 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:26 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:22 +0000 Subject: [PATCH 09/18] rtc: meson-vrtc: drop needless struct meson_vrtc_data::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-9-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060728_800939_3F91CA27 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-meson-vrtc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-meson-vrtc.c b/drivers/rtc/rtc-meson-vrtc.c index 5849729f7d01d7ec7868ff3bbdc5ed599aaa8238..7d38258cbe376e5a1b2af6250cb6d04c313175fb 100644 --- a/drivers/rtc/rtc-meson-vrtc.c +++ b/drivers/rtc/rtc-meson-vrtc.c @@ -13,7 +13,6 @@ struct meson_vrtc_data { void __iomem *io_alarm; - struct rtc_device *rtc; unsigned long alarm_time; bool enabled; }; @@ -65,6 +64,7 @@ static const struct rtc_class_ops meson_vrtc_ops = { static int meson_vrtc_probe(struct platform_device *pdev) { struct meson_vrtc_data *vrtc; + struct rtc_device *rtc; vrtc = devm_kzalloc(&pdev->dev, sizeof(*vrtc), GFP_KERNEL); if (!vrtc) @@ -78,12 +78,12 @@ static int meson_vrtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, vrtc); - vrtc->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(vrtc->rtc)) - return PTR_ERR(vrtc->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - vrtc->rtc->ops = &meson_vrtc_ops; - return devm_rtc_register_device(vrtc->rtc); + rtc->ops = &meson_vrtc_ops; + return devm_rtc_register_device(rtc); } static int __maybe_unused meson_vrtc_suspend(struct device *dev) From patchwork Fri Feb 28 14:07:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996497 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07476C19776 for ; Fri, 28 Feb 2025 14:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yQ0JGMSfI+1KFmM257fBJRG01zuKrEyTSxARsLB+XtI=; b=b8FUozpqBQs4nU I3QXyFct2/g0xt/k6pfTqGz1MtacTEbkZtuO7gM/6bChFXMfKuDVkK3Jz69sst8CsUVlI7llydTXd SkeyFItY+aiiQbfb/HPugY1HDRY3IRhbeeaRRQHWyizLFGG8BmJ2su5EvrNKRQg1W43PJtA+cY3x+ 7Bya1JZgxqbqGsqyxY35h/d3o78sOxcc/+CiucOWUumBMMDlhKE2yy6B8Cr+HODDE0gA/lv+EOFSC 3Ynb+YtMDqjYkxuZjKx3iS553y/8UVbkx1rxSTBdZnuk3jNn5fdjQMbKow2CuOzfaSYPo73EsIDPh QHT2PJD1NrtUsxjD7qew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1H1-0000000BFMY-1DfL; Fri, 28 Feb 2025 14:23:31 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11V-0000000BB8h-0oxM for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:30 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5e5050d19e9so1068057a12.3 for ; Fri, 28 Feb 2025 06:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751648; x=1741356448; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e0FEi4ElpfP7bsjHYl+IPy7QOEVjafD0mk0qg+EAmzU=; b=rSrf8/d8uc8mn1pQwKYXTj5/VzZDMToUwpAawpOtroUC5mgEaTidwjRN1vvSxF1Z9B /31zNJIB0jeRfO6MKmXWapI9P7YQPo2juPOQ4hx/mk4pFbFNuZsJ7cv8hYUGlr55krto 85Tgc1zu4rSaEcwmR43brfrbTgqL21/taFaZjZZr0EyqfsvzhwjKLSKVWP+L+LZO/LFB /UcVXuKxiZ/rAwIi335Rk1n85DMjqlFczwbMCgtGUJjWtI7SZ3hFWjyLYBC9rl6NDIpq OkJ26yk6QrjBbbp/GbU82SQKT4RbRc3Fs8A1RnQVf/qJ3rub4eO3wTRIFvVSRVlUuRKu ChWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751648; x=1741356448; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e0FEi4ElpfP7bsjHYl+IPy7QOEVjafD0mk0qg+EAmzU=; b=g8WoCOBvtqZUu/aV3X+SGWB1hHuUDH94okYMHk0VQ8AIbKIAGLblx5x7u9tcBgIiLc RIol6kojwymLWkT5Cuo4eI4ONk0956/6OYXZdDSaI2O/gTPs2M+cs3HdE2nE5wCQta/p 3IaO8ZS9NvugL69V0dX7lW63TcSgd98dQYyBHlymsJpevLHo8rSpOZywzXd1XL1BZcyn VdSzLrsrunQI1dcNzDU8Q6gsiLMgk5rfdTlaAmF058L4AK0mA9s6ZHvYSeWHOfDEHOFO JXvIip76tPJ/Co4KbC7sBJMKj26Ub8IwHFVfJ3kvM/+4jd1M04dLWxfMm/ehObBBRvU6 9c8Q== X-Forwarded-Encrypted: i=1; AJvYcCUT16NTJ+5KyHHnUQt4UhSwq3h+f9X3CM6gMDd/N+8ufPUB08NmOxBvhBzeIfMkcCTSJkT7w04wN2FjX5bG@lists.infradead.org X-Gm-Message-State: AOJu0YyNT5ot32f2CcdE4gxwhpumbdVXgk9aeMkQXw+BHug7OjZnfj3D xB+nGy9p/UH+Ayjl+iHPj6FqIQFj9Wb10s9APg3Ym7y2Qf7IvW6F5X6L104rBcA= X-Gm-Gg: ASbGncsyq7g0v9bAD/XmPQqO+0OH7xdpRpBHBUNJrXAln0nsjANkil8fKm6549091KZ hi0qzidyeyaBgwDKKC8Wq82/C7qEvfZQ2gIJelwJBdCXhFs6YRX6B4QF3UvFS9HtrzZzztzqHVw l3SFRUKB/QXtHiwGMqZGsH/1vDyC0El44YdjdQDykqn7iI/o2BOcusZ8FlCgifAVf9Ff79DIuNT UZcLOVGqZHhmlKcwb2pMSQ5PmFBYEbqzmCgtuhHjwNl7TVpzgWjDg7/dumSHECdxHXPMBXTjUYa FMlsVL1vK3yQHtaAIpKSLKD97TD4h2yASfP4ChvGVNmL/YzDRG9LWuqKDn3u0qgWSBe93h86JeP FdszcsrwPdQ== X-Google-Smtp-Source: AGHT+IFd5qkPHWKs7u0kGQaxuAKFWYEyb+eqqsQgE6/A1ZcU9oZLI/LHqjeh9PQlI3f0EWIivI7Brw== X-Received: by 2002:a05:6402:26c2:b0:5db:f423:19c5 with SMTP id 4fb4d7f45d1cf-5e4d6ac4066mr2619097a12.5.1740751647799; Fri, 28 Feb 2025 06:07:27 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:27 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:23 +0000 Subject: [PATCH 10/18] rtc: pl030: drop needless struct pl030_rtc::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-10-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060729_259399_26261716 X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik Reviewed-by: Linus Walleij --- drivers/rtc/rtc-pl030.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc-pl030.c index 39038c0754ee55a952e5986afe711cffff35840b..e7c81740061bb60c4d8447d6522819685bea9180 100644 --- a/drivers/rtc/rtc-pl030.c +++ b/drivers/rtc/rtc-pl030.c @@ -21,7 +21,6 @@ #define RTC_CR_MIE (1 << 0) struct pl030_rtc { - struct rtc_device *rtc; void __iomem *base; }; @@ -86,6 +85,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) { struct pl030_rtc *rtc; int ret; + struct rtc_device *rtc_dev; ret = amba_request_regions(dev, NULL); if (ret) @@ -97,14 +97,14 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) goto err_rtc; } - rtc->rtc = devm_rtc_allocate_device(&dev->dev); - if (IS_ERR(rtc->rtc)) { - ret = PTR_ERR(rtc->rtc); + rtc_dev = devm_rtc_allocate_device(&dev->dev); + if (IS_ERR(rtc_dev)) { + ret = PTR_ERR(rtc_dev); goto err_rtc; } - rtc->rtc->ops = &pl030_ops; - rtc->rtc->range_max = U32_MAX; + rtc_dev->ops = &pl030_ops; + rtc_dev->range_max = U32_MAX; rtc->base = ioremap(dev->res.start, resource_size(&dev->res)); if (!rtc->base) { ret = -ENOMEM; @@ -121,7 +121,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) if (ret) goto err_irq; - ret = devm_rtc_register_device(rtc->rtc); + ret = devm_rtc_register_device(rtc_dev); if (ret) goto err_reg; From patchwork Fri Feb 28 14:07:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996498 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4F9FC19776 for ; Fri, 28 Feb 2025 14:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YVE6+V8ewMiQrmq53tV/nHnnlJ5Zij7gyJzWLYeuBnc=; b=kqy7LHPAdG5XBk wkOmY0BeSnbq+IyNWLmzkIJi/OpzTvhhpy6AxRDXp/+cx0CpXmF6666LIrZuWbe9wwo7MHg6Tyl+U zu6GaJxnVR8cNFIz3qO/u7odZFa1bDbN9BMs5JCxAau6O68lFGMJKWeu57DfQ6YORplnRx+Uqepka tT3hqX/PSCXngqJ35JDwMLK6jk6ksx3JvE06cJ9DuaEufXV91XszmgYx080XSAFjARU9SQGT+S1Cb t3TM526+MI0Zp5Jum7tulmFyfVfQKrniqDdZMSKHdHFtE6F34qV/k0t+4BzCD43CB609CUnBTtA6G B83JEnJzmQqqCVpytqiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1IY-0000000BFjx-1iEV; Fri, 28 Feb 2025 14:25:06 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11V-0000000BB9P-2Xue for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:30 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5dccaaca646so4075425a12.0 for ; Fri, 28 Feb 2025 06:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751648; x=1741356448; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7nzHwlkUM09BG0CuM/bA+EpIQxILewT/ffWeXrAz77U=; b=Gf4Kp7HassYmg1Bt0wmPC5X8yp8JsSeJuFeavsXBwKns8Dt33e/hV7STgjF+RhUxAG UUJtDJepClki3qSKqnzPonVliB3Q2dZRJmPWiMTNp8wh3C2zZ+toklLQmHZ2aDs+nOWc gkJZ3vLHXSYt+YKTK7RmeOjPiKXFG+KWT/bKHuj3he7mvrYSLde3C2+nj5xgMF18xsQU GnExY6EWhdna/LYH0vlpzpBF5cTqEeODZgaCBYUcNS1lFrd8mE8Qd6YgJ2xs9ndQKgw/ 7mYTLzwiDM2KJoioygrXw38GuInbmPej6hovLu7PpEAZ90mYONIVI+odTHofvzKrLOxF uEvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751648; x=1741356448; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7nzHwlkUM09BG0CuM/bA+EpIQxILewT/ffWeXrAz77U=; b=ncbXzUUwgbTtkQGzLFXFCzqUx9847W1kIgz6Sq0STl5e/Xl4Ynr7fwJRXeo+uSMcpo 9WaH2lgLe3ak7ck52ERgQYbjcv7TY4eiljYbb1uyLdkKgnp7EpJe31ojnvWgH6gEGZL0 39clQ+Ee9c365BaaGGKTLs4osl30ScY/a6WjV1/L9QQdmauXLSE4xWzjuPEWGCnvR+be JrYdrpiDTPnot1yLp2dPiKSD8APnQYAZ8acPEEy22QLqRlUuqYpn7hs0nU+kly8qlQdd bw8nG0oRs8Lkhs3hEXxWA2WHhTyz3+Gnj09TIkHjQoQgpEJPSosJMQDh6aj2g9LMannh lpTQ== X-Forwarded-Encrypted: i=1; AJvYcCV6HtGoMp3kzUpsm5ZCcz76XCujAFRCn85/hMujN+Gc5n/RDBGc94DCTpp62lQyPJ4awrTD14eIMXq8dIdq@lists.infradead.org X-Gm-Message-State: AOJu0YyuUVFyytCITfsl8IqFrZ9GnvCcTurwsO++BDF90gWUiwcR01Vc AVWpPzl7L3bSLHvXWoPLJ/+0v8fJkGFLRnbw3JGrurWuvsP+SEroo+2i0U00yBc= X-Gm-Gg: ASbGncutDYX3UCKLTcs8j2d3XTtOit2N+aQy1gwMb8/IbYw4i7YInTQKfDmCehixcKs 0BR7Ia4JCKb0O2/JQMAC28xD5SmwdRBEkxFW0hBKbiIkBmnnTk7pan0Yk8XzQHBiQ0gGelwn/v4 lo6xD1zSSfYPcQiFLnQPeuXJzox3PU2A/lQbx4SVPvJM8JtWcwCJ9Q3EXRjSrv1Q/KF1tqPbX/R bs77wRfUOLlNM7dYOvDQcgex9ZJnjFuhXIk6q3s3JTwJZRhcO/Q2RrsDzfypFgq9E9iW+APf9Y3 QrmBtJEamTRmqQXcvQffaIeipn3qYp24D30cDzE0R2H+gkmXOdA63dgGYxu5XAviq7PBamYo76A ktbHpQmSYAg== X-Google-Smtp-Source: AGHT+IGquByOTAI+pOBsMihZmYnZaIy5p2XitRnKkTWDJg07k5RO868wRYsHEejBUavy8mEmWjqo9Q== X-Received: by 2002:a05:6402:13d4:b0:5e0:8a27:cd36 with SMTP id 4fb4d7f45d1cf-5e4bfacb0a8mr8959084a12.8.1740751648271; Fri, 28 Feb 2025 06:07:28 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:27 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:24 +0000 Subject: [PATCH 11/18] rtc: rx8581: drop needless struct rx8581::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-11-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060729_646337_F6429FA2 X-CRM114-Status: GOOD ( 14.74 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-rx8581.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c index b18c12887bdc3705ea4cee9b8d75086a05b24e71..785ebaca07ac971eee34559f8d1e0a8a872cbba9 100644 --- a/drivers/rtc/rtc-rx8581.c +++ b/drivers/rtc/rtc-rx8581.c @@ -54,7 +54,6 @@ struct rx8581 { struct regmap *regmap; - struct rtc_device *rtc; }; struct rx85x1_config { @@ -252,6 +251,7 @@ static int rx8581_probe(struct i2c_client *client) struct rx8581 *rx8581; const struct rx85x1_config *config = &rx8581_config; const void *data = of_device_get_match_data(&client->dev); + struct rtc_device *rtc; static struct nvmem_config nvmem_cfg[] = { { .name = "rx85x1-", @@ -286,21 +286,21 @@ static int rx8581_probe(struct i2c_client *client) if (IS_ERR(rx8581->regmap)) return PTR_ERR(rx8581->regmap); - rx8581->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(rx8581->rtc)) - return PTR_ERR(rx8581->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - rx8581->rtc->ops = &rx8581_rtc_ops; - rx8581->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - rx8581->rtc->range_max = RTC_TIMESTAMP_END_2099; - rx8581->rtc->start_secs = 0; - rx8581->rtc->set_start_time = true; + rtc->ops = &rx8581_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->start_secs = 0; + rtc->set_start_time = true; - ret = devm_rtc_register_device(rx8581->rtc); + ret = devm_rtc_register_device(rtc); for (i = 0; i < config->num_nvram; i++) { nvmem_cfg[i].priv = rx8581; - devm_rtc_nvmem_register(rx8581->rtc, &nvmem_cfg[i]); + devm_rtc_nvmem_register(rtc, &nvmem_cfg[i]); } return ret; From patchwork Fri Feb 28 14:07:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996509 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7831FC19776 for ; Fri, 28 Feb 2025 14:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HZ9E/tYiSXFAfGwVx4cfk5cQiNGThrehz3hqLTFApNA=; b=YYfBt1gaQ09YCr b2iUIPC/zgQHIOQwy8y/8YRvdA+l0cOE0lNemb3wxWKEei5YkJbqfdDBGJ4VEkOSbnj/0cT0OuXdi KPKaXBezT7Bd5y9qFCsCoh7ffYKMc+cLHqpi9NlC8US05W82GTm3J7+DaUz9bLfgXfnK/ih4h3PpR aMrFZs/jCd/Iq5yNYoFPdDFLcKy3tZwQKcJF+b6C2bwvafW6603pSUy+QLV5T14U14V6Q+ZS0I62r OC2nkF553G8UqkArvxZU30vC+ZmMJyFPWLnsxGBWv8ymPvEchQ5sQWN960IoBJZKQ37ABZ7MbbkAR ITwzEYqwG8S+bDIWkcnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Ld-0000000BGQu-0cX2; Fri, 28 Feb 2025 14:28:17 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11W-0000000BBA6-0kOj for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:31 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5e04064af07so3923190a12.0 for ; Fri, 28 Feb 2025 06:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751649; x=1741356449; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=I2QDvE9wN+g16Z7rKZjQU/K6ZyJAh05OKQtvnHRRZ/NX7Qo60eGE+dm8BKfzrU9iKF H4VtWcTaPRD6eL+CY91buxH7GcwnUrBJZ1sOvxJMOMk8bNMMlsPmkuULMQYZ8SfeDwAh YgMjP+C0daE8bbGNhggoSugyqhKMATjHZjaqz0aakz1z7gaFYEelDwo2P+Hk1MMenrlT BLN9w8ax0XNQ/NJGxcVsK2GrHXMq+tqrqKdG0uHBUg0Ylrs8u4l2Gr/qGb0VWM0hsO1n avp4lz4rxyTa1oxLElHNz+pDNz2jCIaGgtuNpqbUP7228REVsO3bsVrsDOdwKr46u5NJ B/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751649; x=1741356449; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=UD8xjMXcrSjSErYwCVLsyzy8I2+NE48ZuM151Z4gcmXRizGh7itgc3zCskzvmY7eUH pJwU6x5TjK5AB8kZYoRtZU8N4oirHzqfSclk/M79oc0vLr9031p7wK24WtU0tb6ndTft naTihqqIIQAVsum1JFBHdsusFVFlXwi87CQbaqtG+Jcg1kkoXBzYT86ICe6RCTNMvsc4 c4Uvc0lWauZjiKuepNY7D/dRanqMyXrfTuaHL4paoHBpWn0xsRgKSnojqRdcW1N2qndE XqbUFKJw/Vz0SjHuPbfhelIk32l7iTa4YNfwDK3Fx/V/gEAWDTKk6/6D0dCcxfDX2exI mpMg== X-Forwarded-Encrypted: i=1; AJvYcCUh6szUGan2JqewTl5+l65pMLp6BrQ7jYYib4teWA+oQmeDg6QT7uRG+Gze9RYy9vJy36OE2NzCQ4JaxEsc@lists.infradead.org X-Gm-Message-State: AOJu0YyMw7sRp61SQpCXgnDwlMnYu64ErJm+QXHDomo3HO2VQYTyaEvj Q/05aFNN5HDiLZ0eD6UVq56p2yP0ZJKDJl1X7BiUC+DqWfY/kxdNMkYcqZfIZ1c= X-Gm-Gg: ASbGncuYFvm6xsH3AOeR69SnHHrcZfJ6OfsEjIH9/rxlTTl4TbuhDmuwKN283+xZ7r5 kJAnH2JdjxvR6iGwAoAG8xZE8NW7WRLrsxumoRHZGkfXEEptl67IOLJVBmwM+qTIA030PjLFBZp Ei/BGvOtM3Kka+eOqIJPvh0ged3G3FY/FHmFFN/GXqTfvc0RI+44A6b5tuc7YX2VSmiTScYB/1s rm5D5IE88KX29eRh4ier66IHIZq3QNqJLaGxXgXgfrVlSeyj63mOXeU5N1t3hTv2PZ4c9fYYK2W FDv4BEuA5QkAlwVuZ/ds0CPHTbhns4lv5rW6mtRnXT2vhBlMm3NTqedqTA2vO++Gf9MbmEU0KtW 9Ze/2XWx+iA== X-Google-Smtp-Source: AGHT+IF1zdUSX6ZhtbedenD60jZMcHzIIU2NhAe4k+oRQ6Wt3d6uE7nze1qy/Ap2/A6npGSF7Q9PVw== X-Received: by 2002:a05:6402:348a:b0:5d1:f009:925e with SMTP id 4fb4d7f45d1cf-5e4d6b1869bmr2990380a12.16.1740751648743; Fri, 28 Feb 2025 06:07:28 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:28 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:25 +0000 Subject: [PATCH 12/18] rtc: s35390a: drop needless struct s35390a::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-12-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060730_216173_7F2CBCC0 X-CRM114-Status: GOOD ( 14.24 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-s35390a.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c index e3dc18882f41445c41fbea56edbd5c869514880c..3408d2ab274194e39cde38a83567d37bd53f6632 100644 --- a/drivers/rtc/rtc-s35390a.c +++ b/drivers/rtc/rtc-s35390a.c @@ -63,7 +63,6 @@ MODULE_DEVICE_TABLE(of, s35390a_of_match); struct s35390a { struct i2c_client *client[8]; - struct rtc_device *rtc; int twentyfourhour; }; @@ -422,6 +421,7 @@ static int s35390a_probe(struct i2c_client *client) int err, err_read; unsigned int i; struct s35390a *s35390a; + struct rtc_device *rtc; char buf, status1; struct device *dev = &client->dev; @@ -447,9 +447,9 @@ static int s35390a_probe(struct i2c_client *client) } } - s35390a->rtc = devm_rtc_allocate_device(dev); - if (IS_ERR(s35390a->rtc)) - return PTR_ERR(s35390a->rtc); + rtc = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); err_read = s35390a_read_status(s35390a, &status1); if (err_read < 0) { @@ -480,17 +480,17 @@ static int s35390a_probe(struct i2c_client *client) device_set_wakeup_capable(dev, 1); - s35390a->rtc->ops = &s35390a_rtc_ops; - s35390a->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - s35390a->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &s35390a_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; - set_bit(RTC_FEATURE_ALARM_RES_MINUTE, s35390a->rtc->features); - clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, s35390a->rtc->features ); + set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features); + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->features); if (status1 & S35390A_FLAG_INT2) - rtc_update_irq(s35390a->rtc, 1, RTC_AF); + rtc_update_irq(rtc, 1, RTC_AF); - return devm_rtc_register_device(s35390a->rtc); + return devm_rtc_register_device(rtc); } static struct i2c_driver s35390a_driver = { From patchwork Fri Feb 28 14:07:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996510 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82875C282C6 for ; Fri, 28 Feb 2025 14:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X12r6SjqMrk1vGTbCo6MKfEk6NoKQAO8AOBGlsMADJ0=; b=WKE+61vG9szVTq WSmXqSKloG5e9yMNqJad9uoQxPaF5Vv+E7ul4un8fGsykveBz4CHTvT5MC1yifDWDyNCMC+k5YGA1 09QJ5GUXOg/TF1IdpRVHXrLVnjDPVkKnzDHdsBMIfRpLIhSkW/e4qAQHtBlvqocmcYPrch6ZVeZAk NjFDf203KymVePISRtkYi7lIXnpxbRK4PGgIhvLMc+PIpHPg6/KgnA0NfWjT01Juy6SOgjmRBg8r5 ivG6UVFo+1CwgOgl9FcyOI+l/Tz/OrZ2lfBy9Teqty4bNH2ul8Z0c9NRjeOdrAtte20VEEzxmnmdm LDagDS2ZeyB+FSpG1Ylw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Ld-0000000BGQz-21V1; Fri, 28 Feb 2025 14:28:17 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11W-0000000BBAw-3lnN for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:32 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5e4d3f92250so2082520a12.1 for ; Fri, 28 Feb 2025 06:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751649; x=1741356449; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IKZrDxBZwKYSSWAqYI1nyzOGiPZfFb6S25OWnyP8uMM=; b=xvns22eqJsqG2Gl+DOBly4VUdih7jhlWc5oKSQYKcXdP+1AirS7tkIXy7iIijS1mJr qDpDnqAX9snAsF1OwQOI0OKUQzCTDFU78FNd5KBYO6vXB5bdIsg0XXEyamhZtst+yUVU EsKspYjRA9nii9d99C774PlUzMbHKMxtrlPEfyk3cI0jUir+zfsq1ucnKhnARK3NgBwZ KzK2RT5ruU9tCDN6Eh8o5SFjp89pZVyJqDn1EvbV7EATSsEfLLzN1ebczVaClz6rnGKD 5g5I8wCWUu7mZ+mLPaJQ5GR2jKkuJImzq2L6NjizXMuMmAQw999wkmWtb2YbP6OdsZ/b oIQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751649; x=1741356449; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IKZrDxBZwKYSSWAqYI1nyzOGiPZfFb6S25OWnyP8uMM=; b=tZDVQ1LjkOUaUhPzRJC4jb66BeFTcX2YDpAFl30ACzTCP4QFTC8VGeY3IlY2s3sELU wx3Q46yFFs5ysgMffBJrHZp0b5SKPQh5Geqn1NaICagCPG283ttZLr84K2wxPtoX+pRB 7y7s/u9GaoFKMvH2KbQP7bwi1DI2yvDDcNER8+RAwdRDG158vkhU78u6RhUOGdBMRXrn V6VAPZ5pmTY7fjuFlj3k6NcgwVXuWa9Aj9fJqktwOal8CaD9/sfg9jRA3ANuLExA2F4m A3MDGm1y/XNlxZo9BkWycJRXAl54VL5xU2ke7AqM4HVQqtpY1rM/frqT2zFKxafVFI7l oJig== X-Forwarded-Encrypted: i=1; AJvYcCUtHg/aGfP/t9zvnosalIN37ObCZWmJjXaD4gWEk0EyNzWnS5iWGzj5A26z+oOZqBDCrd9+4iwkrwRR1ptk@lists.infradead.org X-Gm-Message-State: AOJu0Ywe+OxhlSQradchT/ZAK7Qq/gaR2JD7QLPLTzfqPobreAVDwQx3 7ttQZQbgw5KyIf5eo4M1aIlhWE1SOGSvGh9FswhzD7VTx1tjXsUvwy2xODNUB5Y= X-Gm-Gg: ASbGncsWPVjbPP8BHwtahhnJxUNpytgYyQcWWtFZNfmlZoyvKFG8hN74auXRGsR4FgV PwnCt93sWAjW5TIvaajk3IUZGWhNtEGdzJilRzBQZvX3UWGKZ0TFjegA42CEPP2EEH0h+/yHvvW 515D6tIWW3JT+E2mhjST6sB38bDFYlsG6arC7ebiRBpuhiGGZSVPo/Fw26KjNAVaSeluocd6qYY /zd0l8bcgSFlwz8DZmBx8dboHSXm9/idQiTmmeoK1xVNS07SIqU3dWdW/IY9BGQAsBCz62YplYs W3w8N7PAzhRvzpyRPvjkW5++KeGRsLYUK5zk7DWiftnfN5LhvhF+ytuoTu0HybHym8mCsseCeYd GXAutQtng4w== X-Google-Smtp-Source: AGHT+IHq59q43U3ESaHrkdTJX61FFZSQWYbph+vbGLJu0Eb0VqRkvBLNVX+MfvKgdS008nj52Al/2Q== X-Received: by 2002:a05:6402:5188:b0:5dc:c531:e5c0 with SMTP id 4fb4d7f45d1cf-5e4d6b83d0emr2632501a12.27.1740751649255; Fri, 28 Feb 2025 06:07:29 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:28 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:26 +0000 Subject: [PATCH 13/18] rtc: sd2405al: drop needless struct sd2405al::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-13-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060730_936458_E429486B X-CRM114-Status: GOOD ( 12.84 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik Tested-by: Tóth János --- drivers/rtc/rtc-sd2405al.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-sd2405al.c b/drivers/rtc/rtc-sd2405al.c index d2568c3e387659dfea598cd2ef6bddc5c076cbb9..00c3033e8079b5f10aaabcc7a1d3f19771263a02 100644 --- a/drivers/rtc/rtc-sd2405al.c +++ b/drivers/rtc/rtc-sd2405al.c @@ -42,7 +42,6 @@ struct sd2405al { struct device *dev; - struct rtc_device *rtc; struct regmap *regmap; }; @@ -167,6 +166,7 @@ static const struct regmap_config sd2405al_regmap_conf = { static int sd2405al_probe(struct i2c_client *client) { struct sd2405al *sd2405al; + struct rtc_device *rtc; int ret; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) @@ -182,17 +182,17 @@ static int sd2405al_probe(struct i2c_client *client) if (IS_ERR(sd2405al->regmap)) return PTR_ERR(sd2405al->regmap); - sd2405al->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(sd2405al->rtc)) - return PTR_ERR(sd2405al->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - sd2405al->rtc->ops = &sd2405al_rtc_ops; - sd2405al->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - sd2405al->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &sd2405al_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; dev_set_drvdata(&client->dev, sd2405al); - ret = devm_rtc_register_device(sd2405al->rtc); + ret = devm_rtc_register_device(rtc); if (ret < 0) return ret; From patchwork Fri Feb 28 14:07:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996511 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2252C19776 for ; Fri, 28 Feb 2025 14:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JthkRTW1yUhrJAt4EcFWebKqVByFcoFtNeYuyKteFBg=; b=Qe5rE6AQW+SLKR 8BFtWX+1zcA12WTBgvhteDgsS+NocoUHrD0X6QbfEJXH32oHaD270p1I5SoP1TtTQ5F+MbuNC7hCS 5AhSbFTK+vzvJ0XNMmyyDTV7CwxSDlPjnO177ePQY2ZrmntZ6VO9OwpE/2z1B72C8kij9VTCzpxYD LgEnc1TjPlgIm4FlaFsuto0WGz/VMftJ8OawyNDH9z/bLThwQeMFeN7Oz0WSJVKq6TzX+OGT7V20u 3v4bNMQYukuDcG1ukly2jxZ5b8Ypm6ss9ZOlvAuDDGN0VLEN+mcdsSHsoNCcBmLZVvIAUeGFMWani 1nqMSZRp9AJ/FYLZ2iGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1N9-0000000BGe2-2366; Fri, 28 Feb 2025 14:29:51 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11X-0000000BBBe-1YDY for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:32 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5dee07e51aaso3821085a12.3 for ; Fri, 28 Feb 2025 06:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751650; x=1741356450; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wVgVdQhbC2YyNwH7K95+EhEh/kAvax64uDHN7A2amTM=; b=Tbt1ZyYbw0fhZvWj/Jp6/ghf3SHPTn23gLzNSV4wEwbD4MLfoCMmkkjoOMhnXsetx+ p4WxGnqMOt9LaAsXXzXbhW/r7TKvzMiZlxhnOe3cQ0U4/LUH8ulUHahrMp5tNuRunADt u1pclU0GQJ0X/T0tLk/8vlhl/E1j91woQDuRjb6x4r8i7fxsFtogFncr/FA5W6WTY3Ai 0nJOTx2ta57oFenNKDSD++kiyyRT1AVE5YuYs2j1JpsqAK6a9TPDdi2I7jFj9IQU/F4C PC+OnA92/AYvqX3TYmE0rWpPieJiWp/5N8lW/Tx7NXLclt8NHCDMP0Buolk2Zx4DPkys be9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751650; x=1741356450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wVgVdQhbC2YyNwH7K95+EhEh/kAvax64uDHN7A2amTM=; b=ir1YYlfkVJqga4kzwFIQ3RXBR3e5HVy8HpKPB4qHxy2WGG+txIPoevvhyzcg66zUwY NUa1p91jWARU+dVzaiztcMSFAMNCtnccVRUfr3ddFKFDvEJagVD2C9vnBPxTRgjxLmoY QRvgRlbOJBoYihsk1b3qI19sJvhcxnYqTDPQ++4lB0AlBa1ZVGiBxU/7Atdh1sHnuy4T mbMlonpDKKqs3zRPpv5wvxs66wDBIXTq4sRGNXsItQzMc3EJZKdkQ6XFmMUYhY4iEXEl bRCYv3Vo2qJAHaOAFe2ohjEz0Pn9n7tPiKKPubNdiheXoHL5OvaNcgbC+yHcYImR+ymG PIhw== X-Forwarded-Encrypted: i=1; AJvYcCWicBmuAQWkFdCRXHcYL16NiW8+oqD+tx9aD/7xX/C836o5uabwQUELeNFra8667m2NxaySJd0J335tqXFb@lists.infradead.org X-Gm-Message-State: AOJu0Yx9NVmpqmXC0o99ERd2079br3KPcJYhQB/JzyUoatYyD1FKBiYM wqGM6YICaFfE9s08bUPCv4c27f60o1md7L5uDsvDWdOIWhpyRRi/dgzf/lR7T4c= X-Gm-Gg: ASbGncuQ0WpFY+waSWw8liiaoptp/s+UmmwzT+EakdS/n9/g0ukbSQ3S/VvMxlC9X+9 g0KaK+BHYyI/mzcNgJ1UpqQrOGExgSTauFjORokVxnvwR8zv8q/cPqziHJMyWX2llBYyyEb1ERc fqqbxuRpravQAGIUI9MEoWx3ryYt7GKJtccY2bz3beiPF9a2dBU/DSDlusXWlhy00zBiOMBFtpg ub/o3slpRJsdLg2gSwNn7VhzJIJxqx1Bgu4zQDvemA4OL3ia0J2D3aIqfi/6da7BX30KR1SfJb5 Hsy8DDmW6ErvbxHrGysMjNiw9wCe/cX7C3WJuMaZSgS+5xoIgVDPnoPNOKtiakUJYQI2O7FY5Ie Q8Eujo324CA== X-Google-Smtp-Source: AGHT+IHCyDQzEJ6kBhW3v4N+pYx5F1W3SqfuZOszPC9Ixk4jqjoqtVWckx72H2jiEWEF9nyPWj82Qw== X-Received: by 2002:a05:6402:254d:b0:5e4:cfe8:3502 with SMTP id 4fb4d7f45d1cf-5e4d6afa314mr2938285a12.17.1740751649850; Fri, 28 Feb 2025 06:07:29 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:29 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:27 +0000 Subject: [PATCH 14/18] rtc: sd3078: drop needless struct sd3078::rtc member MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-14-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060731_413247_0D4FAD4A X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-sd3078.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c index fe27b54beaad1c06b70bf7f22e44c3f6da087267..ebb4d45ce2409982880affbc7a85d5e7410c8f42 100644 --- a/drivers/rtc/rtc-sd3078.c +++ b/drivers/rtc/rtc-sd3078.c @@ -37,7 +37,6 @@ #define WRITE_PROTECT_EN 0 struct sd3078 { - struct rtc_device *rtc; struct regmap *regmap; }; @@ -167,6 +166,7 @@ static int sd3078_probe(struct i2c_client *client) { int ret; struct sd3078 *sd3078; + struct rtc_device *rtc; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; @@ -183,15 +183,15 @@ static int sd3078_probe(struct i2c_client *client) i2c_set_clientdata(client, sd3078); - sd3078->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(sd3078->rtc)) - return PTR_ERR(sd3078->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - sd3078->rtc->ops = &sd3078_rtc_ops; - sd3078->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - sd3078->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &sd3078_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; - ret = devm_rtc_register_device(sd3078->rtc); + ret = devm_rtc_register_device(rtc); if (ret) return ret; From patchwork Fri Feb 28 14:07:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996518 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78655C19776 for ; Fri, 28 Feb 2025 14:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3QqT5hKs1ZZ3EyfxS+Rp3Uj2oTY4Kn1kAedLMgDepY0=; b=ZVX/xhY/nEu+3d 0cq1vtUwPZCkoE1b6BgLgsoxpjH1+hKV3d2XW0yrRU+GG34duDAYkvaTSqa0XnJZooQPZHpPl2plj 7bwfgruVH+crsE1EImUSLmmQzQFI4sKoWd0n/AEEwRKD7yZWPlkvEZiR4JSxu5E2RBdXP9Dl4NlCF l2UkU/h/7OAFh5JsKks+SDpkXx3OTwWvAx7EWH6P3bSs/D5fB4QYSZyE8zQPokT0rm/KA9ZkU8lr8 8Pb5pbnEEgN9YGU09pGhXbgeUp9gvVkFaY/CScg3LQywyoYvder5tu4Bbq0PPej5TO+Ak6MuS7xEd xQVMgd+EKmRsx10n89jA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Oh-0000000BGz1-2iZa; Fri, 28 Feb 2025 14:31:27 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11X-0000000BBCC-3G5a for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:33 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5e04cb346eeso3602151a12.2 for ; Fri, 28 Feb 2025 06:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751650; x=1741356450; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XNaBzsv98dZxOnoY4pQ3hhfyEv1+PH+c26jk5v5UbcU=; b=ZgS6e0GKv+m/lKIV93gmZPpi2slR7/n0yAnTzu31RvGbvRU5xV8/Crs7J64JipvQrA CmhAEmzItp+D0dQlIo1AACX2836YoYhWLnkx/rWd++ch+Ipl9mhSdXwPuqzs8AOZpRLZ 11+T82kuh9KwO3AVUQW/1A17rEKms9GcixvtPt3f3ORTNpZ8Ri6isW6X5G33SUyJhi5P TEiGeuiC82Im3Tm8O9oloGb7sy1Z9mL+ExSDGFEYcnWeR80O+LZCJ8cByv0eWfnMOLRi GiS2bYB8Ymu2FoKj7pqp8PC4bU1D2rzFHBOrYh+esuL5xcSs0EFJ9PODNryrODambezR 6WcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751650; x=1741356450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XNaBzsv98dZxOnoY4pQ3hhfyEv1+PH+c26jk5v5UbcU=; b=wCVKuAc90NlAeSj7X08ECGcVNhrvnANtbwsTGhg5YcYrQJ3aja4YvfpICJ1Iv3rARU hsAZwHe/HB7/TLZEpQWxcx9WenjknhQ9851nNoJ7Yb/psZg4upxK0sQsAAY1x5wbwwML HVdcvc08UJOsf0J5umxc02puA/Eq9lw8D0mi394viOW4SGMp4ZcPELEENlPz3vkFg8Ba zkPiY7HMQpge6oSTtNfjsCNMqw3ZfZydLkhmE9RbIfFHCvdTrMttZ+JWH5xxyWU3K1Og afA/2l9fd1uARK14dXtyUk7Q1DdAey8mkgMhWT3FY0ejyMjJ+sSZse5vCDltxZoa+yiz Cbsw== X-Forwarded-Encrypted: i=1; AJvYcCXH+hbV1X7OgZsSbAq6VspaRtsks3EC9oc2JpqL+Mr0YtIRp27J8z1eyJl7jMR8TehXMFb9o5h+/2DhL8zA@lists.infradead.org X-Gm-Message-State: AOJu0YzmnjXibJ69QGm8UjzZdTHby5ZhE3gmKl7F31NeEestaAm1Ekjm kSWvG2158yz1RmVUH7SqRA3wUVf37Ot4iPLvXisDzlY3BIg7qF4b9UxgvAXSOKI= X-Gm-Gg: ASbGnctoyNZWMcZOTvK/kCqBO8dI2bJ6aNFE4ZCbYT0H7zwm8Gpp+0NbfNrtxWPWlmB Z6Xe+y8mFhgHNQsCLtsE4dob2uN2W0EzB41awbDJzMtVAoYFlJpAK9/IAy+yUpGvbABrDHQHDUz KNfcmdJk4j6kkY3amxsoR5PKsBnclvVZEkmtXU45nnjSIzLHjeIi3xeYnvfiKIaWdQNjOFSC+Kr RpgkdvyJtbPUUPae6c4SuCAsrjUOsrpWJQ1PkRWZTtigzxK+aKcNAyOAfCkdu1DRk+1PfXbFmWv WXwRGpGrWSTteMK3sR84E8UHii1NrhJomUSXTIWQXeVsR4YomSNpapj/cVJqAzNSE10544EYHun m4LLCgoTyDA== X-Google-Smtp-Source: AGHT+IHJgHIb94bIAN1OxpmT/CmpG5hxROPCgFLfrUaKlqlLkHckO5CTYjuy4Kdl9gpiKvePvUPO6w== X-Received: by 2002:a05:6402:35d3:b0:5e0:9959:83cd with SMTP id 4fb4d7f45d1cf-5e4d6b70ef7mr2396243a12.21.1740751650375; Fri, 28 Feb 2025 06:07:30 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:30 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:28 +0000 Subject: [PATCH 15/18] rtc: rx8581: drop needless struct rx8581 MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-15-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060731_830720_01DF5AB4 X-CRM114-Status: GOOD ( 20.66 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org This private data struct has one member only, there is no need to allocate data for it and pass that around via the various callbacks, just to extract that one member. Instead, we can just pass that one member and avoid the extra memory allocation, reducing runtime memory consumption. Signed-off-by: André Draszik --- drivers/rtc/rtc-rx8581.c | 63 +++++++++++++++++++----------------------------- 1 file changed, 25 insertions(+), 38 deletions(-) diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c index 785ebaca07ac971eee34559f8d1e0a8a872cbba9..20c2dff01bae833ae4e100cc38cd5f030017be75 100644 --- a/drivers/rtc/rtc-rx8581.c +++ b/drivers/rtc/rtc-rx8581.c @@ -52,10 +52,6 @@ #define RX8571_USER_RAM 0x10 #define RX8571_NVRAM_SIZE 0x10 -struct rx8581 { - struct regmap *regmap; -}; - struct rx85x1_config { struct regmap_config regmap; unsigned int num_nvram; @@ -71,14 +67,14 @@ static int rx8581_rtc_read_time(struct device *dev, struct rtc_time *tm) unsigned char date[7]; unsigned int data; int err; - struct rx8581 *rx8581 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); /* First we ensure that the "update flag" is not set, we read the * time and date then re-read the "update flag". If the update flag * has been set, we know that the time has changed during the read so * we repeat the whole process again. */ - err = regmap_read(rx8581->regmap, RX8581_REG_FLAG, &data); + err = regmap_read(regmap, RX8581_REG_FLAG, &data); if (err < 0) return err; @@ -91,20 +87,20 @@ static int rx8581_rtc_read_time(struct device *dev, struct rtc_time *tm) do { /* If update flag set, clear it */ if (data & RX8581_FLAG_UF) { - err = regmap_write(rx8581->regmap, RX8581_REG_FLAG, - data & ~RX8581_FLAG_UF); + err = regmap_write(regmap, RX8581_REG_FLAG, + data & ~RX8581_FLAG_UF); if (err < 0) return err; } /* Now read time and date */ - err = regmap_bulk_read(rx8581->regmap, RX8581_REG_SC, date, + err = regmap_bulk_read(regmap, RX8581_REG_SC, date, sizeof(date)); if (err < 0) return err; /* Check flag register */ - err = regmap_read(rx8581->regmap, RX8581_REG_FLAG, &data); + err = regmap_read(regmap, RX8581_REG_FLAG, &data); if (err < 0) return err; } while (data & RX8581_FLAG_UF); @@ -136,7 +132,7 @@ static int rx8581_rtc_set_time(struct device *dev, struct rtc_time *tm) struct i2c_client *client = to_i2c_client(dev); int err; unsigned char buf[7]; - struct rx8581 *rx8581 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); dev_dbg(dev, "%s: secs=%d, mins=%d, hours=%d, " "mday=%d, mon=%d, year=%d, wday=%d\n", @@ -159,25 +155,23 @@ static int rx8581_rtc_set_time(struct device *dev, struct rtc_time *tm) buf[RX8581_REG_DW] = (0x1 << tm->tm_wday); /* Stop the clock */ - err = regmap_update_bits(rx8581->regmap, RX8581_REG_CTRL, + err = regmap_update_bits(regmap, RX8581_REG_CTRL, RX8581_CTRL_STOP, RX8581_CTRL_STOP); if (err < 0) return err; /* write register's data */ - err = regmap_bulk_write(rx8581->regmap, RX8581_REG_SC, - buf, sizeof(buf)); + err = regmap_bulk_write(regmap, RX8581_REG_SC, buf, sizeof(buf)); if (err < 0) return err; /* get VLF and clear it */ - err = regmap_update_bits(rx8581->regmap, RX8581_REG_FLAG, - RX8581_FLAG_VLF, 0); + err = regmap_update_bits(regmap, RX8581_REG_FLAG, RX8581_FLAG_VLF, 0); if (err < 0) return err; /* Restart the clock */ - return regmap_update_bits(rx8581->regmap, RX8581_REG_CTRL, + return regmap_update_bits(regmap, RX8581_REG_CTRL, RX8581_CTRL_STOP, 0); } @@ -189,29 +183,27 @@ static const struct rtc_class_ops rx8581_rtc_ops = { static int rx8571_nvram_read(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; - return regmap_bulk_read(rx8581->regmap, RX8571_USER_RAM + offset, - val, bytes); + return regmap_bulk_read(regmap, RX8571_USER_RAM + offset, val, bytes); } static int rx8571_nvram_write(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; - return regmap_bulk_write(rx8581->regmap, RX8571_USER_RAM + offset, - val, bytes); + return regmap_bulk_write(regmap, RX8571_USER_RAM + offset, val, bytes); } static int rx85x1_nvram_read(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; unsigned int tmp_val; int ret; - ret = regmap_read(rx8581->regmap, RX8581_REG_RAM, &tmp_val); + ret = regmap_read(regmap, RX8581_REG_RAM, &tmp_val); (*(unsigned char *)val) = (unsigned char) tmp_val; return ret; @@ -220,12 +212,11 @@ static int rx85x1_nvram_read(void *priv, unsigned int offset, void *val, static int rx85x1_nvram_write(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; unsigned char tmp_val; tmp_val = *((unsigned char *)val); - return regmap_write(rx8581->regmap, RX8581_REG_RAM, - (unsigned int)tmp_val); + return regmap_write(regmap, RX8581_REG_RAM, (unsigned int)tmp_val); } static const struct rx85x1_config rx8581_config = { @@ -248,7 +239,7 @@ static const struct rx85x1_config rx8571_config = { static int rx8581_probe(struct i2c_client *client) { - struct rx8581 *rx8581; + struct regmap *regmap; const struct rx85x1_config *config = &rx8581_config; const void *data = of_device_get_match_data(&client->dev); struct rtc_device *rtc; @@ -276,15 +267,11 @@ static int rx8581_probe(struct i2c_client *client) if (data) config = data; - rx8581 = devm_kzalloc(&client->dev, sizeof(struct rx8581), GFP_KERNEL); - if (!rx8581) - return -ENOMEM; - - i2c_set_clientdata(client, rx8581); + regmap = devm_regmap_init_i2c(client, &config->regmap); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); - rx8581->regmap = devm_regmap_init_i2c(client, &config->regmap); - if (IS_ERR(rx8581->regmap)) - return PTR_ERR(rx8581->regmap); + i2c_set_clientdata(client, regmap); rtc = devm_rtc_allocate_device(&client->dev); if (IS_ERR(rtc)) @@ -299,7 +286,7 @@ static int rx8581_probe(struct i2c_client *client) ret = devm_rtc_register_device(rtc); for (i = 0; i < config->num_nvram; i++) { - nvmem_cfg[i].priv = rx8581; + nvmem_cfg[i].priv = regmap; devm_rtc_nvmem_register(rtc, &nvmem_cfg[i]); } From patchwork Fri Feb 28 14:07:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996519 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3090DC19776 for ; Fri, 28 Feb 2025 14:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OryWiZaTV6UapOy0FhtwfVlibKlGQE1Za3rpdAoGVfE=; b=aUFl+xJM2Gv8pX vFxz7V3iialmxPFaZboKwUBiDamOsTmToO3gjGfCYRdXTXev91L3YHi/Dk2z5TCB8A/cdh7via9IE i+O6BDFrk0hkbu96FbJKmL1q1528/onHo3jsfGWGQ8ip3tle0FA+dYZaGxkTy0epACvDdbcluL2aV 5N/FV2Pa3G0BgudyM5Gdjrbhq1yTtiBkfJLSeGLn25FPOtFkHab6fQ8avvMIHniH1XutqnnIEbZzF E+tfHclJW/NtQ8xrom3A6qEFky9GTbcRGu+9XG7VlHTBmDmurcb3RaZg+ZLjcHVQ0IJ+7O4jpbMKk llCJYyxiqPnJ1A1QNn7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1QF-0000000BHL2-2f2U; Fri, 28 Feb 2025 14:33:03 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11Y-0000000BBCx-1zD8 for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:33 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5e058ca6806so3334664a12.3 for ; Fri, 28 Feb 2025 06:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751651; x=1741356451; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/r1ypkbSjtebcdcKcBz70+d9/hPyy6PTiaBKA6Wiwh8=; b=uDAW3GLnbrAOQLZ5OnE65s070o6G9uX+ABQiG/1M6errgVE8AN1q+HNfsHpFTq1yUU 8jXpdzx69Bib2RNZSBIESad3afM6yTwMkiZtpwqqZM27cijA/4lFiGcgSgStgr7rovrz sEzALMQGFeEXwMURA/wXfdlE3sKivTQAlallMjYO5HCTYxSvC36PyE3M7RGbjFA0X6A+ ORkuQuzvudKaNpMadQquMlk/yRHZMgQyPq1bG0/aWU125zoZBqHG/4WKMbbdKQXvmtN5 FY0HidUsyl9SZGHfV7sbxGN9LFKnTucEZc3ppHRGM5UYmkHJ868vELSlCen96I099j6/ myWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751651; x=1741356451; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/r1ypkbSjtebcdcKcBz70+d9/hPyy6PTiaBKA6Wiwh8=; b=GpF/N+IxUFSOPzWnug4gW3oJxnjItj5Gk/oC1LqaAIOTs/Iipi6uPhtGl3YwuDwNZd z5XoY+2PrrtpJi3Cn6lv/+toy0GubtMzC5Iuj00/hCQiF63WFKZvZQrNAk/d6KD6GXbE zvQl8CIBuKmRWjUnb9+ee5oMjFK1Bbd4UYBy7TPoDcFABbE01Lb7IxfK4JZf9K7VaA2A gQ/RsCu7O7ezSa2gx6Ry7Rihm416zSns++T5pQDJpY6ZNHmrzDYT9dC2KcnaQAWIHzSr nIxy3b+Rx7C6g0AiWl+Zt/t2QI8wzKq8TeqpLLVDmW3y90cR6XWXnIHX2Z67r+LemSH0 ykHA== X-Forwarded-Encrypted: i=1; AJvYcCXurEv3xw8p+sHLagdAhodWoLUOAMNm735m+fEvszBr7FDFX+2j54DqwYiQdBxBmBjgeySFhr0QSs13qi30@lists.infradead.org X-Gm-Message-State: AOJu0Yz1LO+7iP/qbi8/UDLV3ZMtmyH3DEqGLK8K1iFokSIHRHOCJQ8j xhySgj7SOiZjkLe1MgFOFC/ruWHJPBCykIcHujjqChXTtaywI6auafGzhQ5e8t0= X-Gm-Gg: ASbGncsw4n9dnX5V0XXq1+/EYeVS9za8tNBfwp1BQ5P2OckhU+N8X8W4VK58F9OrhID Lhcfe3XzXsipmJztZFB7NOHthckT98PrCxReGT+wxPtgO0wH0Lif4QBb+qEvaey9+ebaP2wIIjm /IC99zCG7dwcqer5lyjZI7B6q92drVUfNoGeG2nCjU5vGahSgQ0HLnO/q0qBTo3/DTG8AMgukyS mIQLEyrAMtEFwHKdDs7MLq4fYjUFpUv+Mv2cOLLYQVG/rT2mlOt5L/WoWTMt0DwvU75UyjezqkI NWyVDDO+nz4OFtsOBQVJKscj8I9oofE96XlfS1S67zdXq2QWrKbDR2nTmY+zTRALX85JZckwdio /f9U2G3hQZw== X-Google-Smtp-Source: AGHT+IEmNzc9psOsG8S5U8hQjyEGUEZtM5fJSHlUXxz0d+LoEipOpq1K+57NoVXqKGgpzCnWIQsf3g== X-Received: by 2002:a05:6402:2711:b0:5de:dfd0:9d22 with SMTP id 4fb4d7f45d1cf-5e4d6b6ebf3mr3156214a12.22.1740751650904; Fri, 28 Feb 2025 06:07:30 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:30 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:29 +0000 Subject: [PATCH 16/18] rtc: sd3078: drop needless struct sd3078 MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-16-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060732_565186_D2720728 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org This private data struct has one member only, there is no need to allocate data for it and pass that around via the various callbacks, just to extract that one member. Instead, we can just pass that one member and avoid the extra memory allocation, reducing runtime memory consumption. Signed-off-by: André Draszik --- drivers/rtc/rtc-sd3078.c | 55 ++++++++++++++++++------------------------------ 1 file changed, 20 insertions(+), 35 deletions(-) diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c index ebb4d45ce2409982880affbc7a85d5e7410c8f42..10cc1dcfc7748144f51ef674939506feee1fb471 100644 --- a/drivers/rtc/rtc-sd3078.c +++ b/drivers/rtc/rtc-sd3078.c @@ -36,10 +36,6 @@ */ #define WRITE_PROTECT_EN 0 -struct sd3078 { - struct regmap *regmap; -}; - /* * In order to prevent arbitrary modification of the time register, * when modification of the register, @@ -48,14 +44,11 @@ struct sd3078 { * 2. set WRITE2 bit * 3. set WRITE3 bit */ -static void sd3078_enable_reg_write(struct sd3078 *sd3078) +static void sd3078_enable_reg_write(struct regmap *regmap) { - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL2, - KEY_WRITE1, KEY_WRITE1); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE2, KEY_WRITE2); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE3, KEY_WRITE3); + regmap_update_bits(regmap, SD3078_REG_CTRL2, KEY_WRITE1, KEY_WRITE1); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE2, KEY_WRITE2); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE3, KEY_WRITE3); } #if WRITE_PROTECT_EN @@ -68,14 +61,11 @@ static void sd3078_enable_reg_write(struct sd3078 *sd3078) * 2. clear WRITE3 bit * 3. clear WRITE1 bit */ -static void sd3078_disable_reg_write(struct sd3078 *sd3078) +static void sd3078_disable_reg_write(struct regmap *regmap) { - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE2, 0); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE3, 0); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL2, - KEY_WRITE1, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE2, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE3, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL2, KEY_WRITE1, 0); } #endif @@ -84,11 +74,10 @@ static int sd3078_rtc_read_time(struct device *dev, struct rtc_time *tm) unsigned char hour; unsigned char rtc_data[NUM_TIME_REGS] = {0}; struct i2c_client *client = to_i2c_client(dev); - struct sd3078 *sd3078 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); int ret; - ret = regmap_bulk_read(sd3078->regmap, SD3078_REG_SC, rtc_data, - NUM_TIME_REGS); + ret = regmap_bulk_read(regmap, SD3078_REG_SC, rtc_data, NUM_TIME_REGS); if (ret < 0) { dev_err(dev, "reading from RTC failed with err:%d\n", ret); return ret; @@ -122,7 +111,7 @@ static int sd3078_rtc_set_time(struct device *dev, struct rtc_time *tm) { unsigned char rtc_data[NUM_TIME_REGS]; struct i2c_client *client = to_i2c_client(dev); - struct sd3078 *sd3078 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); int ret; rtc_data[SD3078_REG_SC] = bin2bcd(tm->tm_sec); @@ -134,10 +123,10 @@ static int sd3078_rtc_set_time(struct device *dev, struct rtc_time *tm) rtc_data[SD3078_REG_YR] = bin2bcd(tm->tm_year - 100); #if WRITE_PROTECT_EN - sd3078_enable_reg_write(sd3078); + sd3078_enable_reg_write(regmap); #endif - ret = regmap_bulk_write(sd3078->regmap, SD3078_REG_SC, rtc_data, + ret = regmap_bulk_write(regmap, SD3078_REG_SC, rtc_data, NUM_TIME_REGS); if (ret < 0) { dev_err(dev, "writing to RTC failed with err:%d\n", ret); @@ -145,7 +134,7 @@ static int sd3078_rtc_set_time(struct device *dev, struct rtc_time *tm) } #if WRITE_PROTECT_EN - sd3078_disable_reg_write(sd3078); + sd3078_disable_reg_write(regmap); #endif return 0; @@ -165,23 +154,19 @@ static const struct regmap_config regmap_config = { static int sd3078_probe(struct i2c_client *client) { int ret; - struct sd3078 *sd3078; + struct regmap *regmap; struct rtc_device *rtc; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; - sd3078 = devm_kzalloc(&client->dev, sizeof(*sd3078), GFP_KERNEL); - if (!sd3078) - return -ENOMEM; - - sd3078->regmap = devm_regmap_init_i2c(client, ®map_config); - if (IS_ERR(sd3078->regmap)) { + regmap = devm_regmap_init_i2c(client, ®map_config); + if (IS_ERR(regmap)) { dev_err(&client->dev, "regmap allocation failed\n"); - return PTR_ERR(sd3078->regmap); + return PTR_ERR(regmap); } - i2c_set_clientdata(client, sd3078); + i2c_set_clientdata(client, regmap); rtc = devm_rtc_allocate_device(&client->dev); if (IS_ERR(rtc)) @@ -195,7 +180,7 @@ static int sd3078_probe(struct i2c_client *client) if (ret) return ret; - sd3078_enable_reg_write(sd3078); + sd3078_enable_reg_write(regmap); return 0; } From patchwork Fri Feb 28 14:07:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996521 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA635C19776 for ; Fri, 28 Feb 2025 14:34:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aranpZdSt1cw12y5/jrCsTV+SO1rjCNIp6bxUFqMqX0=; b=i2Pq90VFasiUvL fJhvcNwaPNE+dPQ9qxv/Uz04+wIGDSl9MzY8g7aii0tXjKkHC6TRJSMJCzpogb6MhkkYcvwuVrE0M 9gVy5vAN4/xV8C00Sh3Ie6o4B4gK4j9iQrIXbtyaVtF5BbdeiyT7klIgQwJqMlp1bHA7ynA+bXc+I VIFg/8JnBvNse2wQ4rOvD+Rmm6AxDyRWjaPZ32Dg/TIoGkm8uTBuH8/1Ngq2TiRi3Gfs7jRHVwknP axo0DzUYdkOzzC3SUfydVvGdnUD8jDVIixxB8CcB2aJTbWCZu7Dzei+BGzGDOzj7Y6LJbpNq2LiCn 9AucRmAJ//kynNdkaHkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Rn-0000000BHhX-2iF1; Fri, 28 Feb 2025 14:34:39 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11Z-0000000BBE3-1lHt for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:34 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5deb1266031so3679101a12.2 for ; Fri, 28 Feb 2025 06:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751652; x=1741356452; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J1wrjOZ25AMEbbC5RG2Bl34Xp7n5uiu5eMlW7fz5kxo=; b=YZeC+M6Me/z7YSpmh9nb/WtaJiOnbiAHHqVPoMHfTiaJimq7IBVjsEOfyOlzSke1vz CTJxfsyDshy97kPS1Sn5UpjhVWLxNp9CsQb9UR5faqU75+o6H9UHJxngthiTcq5kCrub N6Bzqt3DdKyWyqladqyu8NT4r/sdUyn4K5PmHhmJNoUtg19RMj7K+yidAJ6ej76WKjkY /F8xvTz/As3Ai4brgJBwXo8i0mzQE1qCsOPn5FCWD9J6rO7eXCTe01/jWwlkGOnWsJrq YBxVWbhAMcUjnmxcqNkQhkQcKEf4UG4nw9xC/RAlbJmyUOCqaNlPgPKCKKW+zsoBBWgI CdRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751652; x=1741356452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J1wrjOZ25AMEbbC5RG2Bl34Xp7n5uiu5eMlW7fz5kxo=; b=CoH9/hOmkONsd9YnXge3iUSHc/BXGCZWVVqNG74sQ0K/T2zcG9YEHkSMr7LdVB5Ajr g/QdT74clYuEcYK5XLKgKA0XXc+e9qsHxfU/0eS5nNDDblyUjMJlQ51cwRHB+uoNinS1 ENn7AoZFXzaDX7av3IU0MwvX4B0OYlqpo3K7SjpbgnxXpF5EbSP5ZudZsnWWcaMHZ+dg ++QNTg06lGtdqYljVWjB/Fe5zq/TLr1BROiwWFp9PZughRieASfLs7EW9X3/tXEVDIog 7US/tLDERkGs6O0Z5gnp2TNp7IbJtzVzb4Ob1dYPyjToTBdaXFUO93y6pJACIMDyD6BH F0zw== X-Forwarded-Encrypted: i=1; AJvYcCVZv7PGWn8b0hva89qVYajY0D8+J/TjWeG88ywsrvmtFDcMd8LU/6LdBTg3lA3DlZ5erjfurW8OCdKE3KqW@lists.infradead.org X-Gm-Message-State: AOJu0Yy7pYQlNJJ6DsxYOsaEC/B6a5HU6bEEWLlxSuDlzDzZwhboBTUY 8dUjpoNGW0maurrZmOozOUmSkpnogcZGUJkTA9TwONap4ukhYcI55b4QUa5dwvk= X-Gm-Gg: ASbGncshrmQLgmym+6qYA7vY/f3rwkFs7vA0sqgsHEviQnN5cV+2van2uJInyCgzpwP PMi1efR5ImqpbCvsv3DWKyoXqt3Gg9OTdvdfzst0F/c/LXzxOvCJPevA9TUfOJCoKJpx0OBFj73 UfJDx9CnVkCXZsDoiAUITJF+yxW7yyUvgw0+WjqAyXZuL/Yo0QpfhhEeKuXmtlpiKAtvD3x8e7T Bbqi4H3EH4ujxZ+jZZSZoqgInPYp6bP6xpvMkg47llTJywbmb2aim0R3SFhzfEIDfjNPdWANZJK ti3RQxY+XmZs1cRagAMtgzm1gt8+RJ5FmtVq7kWF52hJRshNq6UP9pD/ayRlm86dOKZjh2eFP0y pVOip15AxsQ== X-Google-Smtp-Source: AGHT+IH8oBqlrNujitdioxAVXjdPgLAryRZxpXTnrztyLFYptlh+GD/CB4rbFiDA0RhEFxZK1lBu3A== X-Received: by 2002:a05:6402:35c6:b0:5dc:c943:7b6 with SMTP id 4fb4d7f45d1cf-5e4d6ad4a6amr2900190a12.3.1740751651952; Fri, 28 Feb 2025 06:07:31 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:31 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:30 +0000 Subject: [PATCH 17/18] rtc: max77686: use dev_err_probe() where appropriate MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-17-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060733_452385_76F31734 X-CRM114-Status: GOOD ( 11.26 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. Signed-off-by: André Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-max77686.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 6b0d02b44c8097453f704cbec9f02580fb869ca3..69ea3ce75b5a5426d4a56b979773be71c4ee7562 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -704,10 +704,9 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) } info->regmap = dev_get_regmap(parent, NULL); - if (!info->regmap) { - dev_err(info->dev, "Failed to get rtc regmap\n"); - return -ENODEV; - } + if (!info->regmap) + return dev_err_probe(info->dev, -ENODEV, + "Failed to get rtc regmap\n"); if (info->drv_data->rtc_i2c_addr == MAX77686_INVALID_I2C_ADDR) { info->rtc_regmap = info->regmap; @@ -716,28 +715,24 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) client = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, info->drv_data->rtc_i2c_addr); - if (IS_ERR(client)) { - dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(client); - } + if (IS_ERR(client)) + return dev_err_probe(info->dev, PTR_ERR(client), + "Failed to allocate I2C device for RTC\n"); info->rtc_regmap = devm_regmap_init_i2c(client, info->drv_data->regmap_config); - if (IS_ERR(info->rtc_regmap)) { - ret = PTR_ERR(info->rtc_regmap); - dev_err(info->dev, "Failed to allocate RTC regmap: %d\n", ret); - return ret; - } + if (IS_ERR(info->rtc_regmap)) + return dev_err_probe(info->dev, PTR_ERR(info->rtc_regmap), + "Failed to allocate RTC regmap\n"); add_rtc_irq: ret = regmap_add_irq_chip(info->rtc_regmap, info->rtc_irq, IRQF_ONESHOT | IRQF_SHARED, 0, info->drv_data->rtc_irq_chip, &info->rtc_irq_data); - if (ret < 0) { - dev_err(info->dev, "Failed to add RTC irq chip: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(info->dev, ret, + "Failed to add RTC irq chip\n"); return 0; } From patchwork Fri Feb 28 14:07:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13996520 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD74FC282C1 for ; Fri, 28 Feb 2025 14:34:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OLIJqLZw5Ov8NVcIuXN/A4NqJfqK1+Qtfb4NRTQ1R2w=; b=mJHxPF8n7L98tf TryqL91e2ALN9X224HLiwrsJtdMHHm8y+R+RfUDWd56DJ7eddFbSVjSYsOd+NRLbKdvp36pSKtCFM N3sxk1djkvQrbcrbHQSnSuG3Us/KJQeN+gQMVC0Y8CCdHReQofm5ZYuYZn8WRSAL6o+RIv/npGFHo Y7/K9Cik7+Cx4I3zeBMIUeaqn323Re2VRXSrgcuIHNWGp1Ek8tLC81Etp5UEao5FTbHnat132UL+6 jbD9rncGC02CVI2WYzS5y5yy579eB7cyhsR+A0QSMqhbNDnj/dtWC5InfTwjQSj9D6QRLGZYoHuBH vlTD0PlzNzrBkufpc5dA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to1Rn-0000000BHhf-48p5; Fri, 28 Feb 2025 14:34:39 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to11Z-0000000BBEF-3N6J for linux-amlogic@lists.infradead.org; Fri, 28 Feb 2025 14:07:34 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5e0573a84fcso3088457a12.2 for ; Fri, 28 Feb 2025 06:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740751652; x=1741356452; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ucCmymGJlfsI4F5PNnMG7qiqKtfzqtFmwv0m9GhXqKs=; b=oU+GIRwMvYl1Jj98PGNUWsIeEfT8gDu1c/ELNwP1z82DC8+yZcKG9KhP82pTWOVAC9 lFKAtNpvoCNFGsHOJ8xYglTbY43BIeQqxfp1TxWB1ixtEdkb6fBViI6Ugc6izyNM5+C5 skvp27d/cPeCvReeCC7lLU3Jb52GfiBq3Uow0ldLy7zMpVMGW3Jq1QyisB7DaAOHkDCI Xzo5i8RnIGEbnOgeBJAyLsgdHtHujBpY4Z18RVBZ3/hlmSXUcUtNMKwQq0WXtiXeX/yR MtjvedvfxB54utRnzAxp3IcSuAjY4hrug9hrGRE8/OuHxh0w2Wr1WxiLxkonOkCL9Sm1 hwDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740751652; x=1741356452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ucCmymGJlfsI4F5PNnMG7qiqKtfzqtFmwv0m9GhXqKs=; b=HN7RZsn+AX5wPBbULdxgq/nQiXCgBewX0muKwX+vjR8DgkwV/cPcfVCtW3Htt60Kzv egnCyy+tsQQAS4WOH+GTl0ADr6bPKSooEjiZEEVv8PqVnIP0pjEirKs5enSGJ0OwUhdH bcn728lS6WoWwglap7rc5AM+FzoKWzDVCfx6pfJWQFPdKhosAAkpCripXtEneUioLiBj PudmgLnxJ6JH0Y+S4AwAXGMAAPTFkB1fsciew9D/dg9eQNijln9hnxMJKBfFJ/3LtxYx BGy9Z9faJYaYiZCdI5nf8v8Vg960ekDy2sRpBABgJA8rZDDZNTXu7bkGQzDQYeTaNqmZ DfRQ== X-Forwarded-Encrypted: i=1; AJvYcCW+2NJhHMMPnQYRhYYq9xWzj4M3WkVmacf0O8ch/osOBM1reF9XzZOTT7C2BxuHTtcvKtGJepQlqyCFOEaD@lists.infradead.org X-Gm-Message-State: AOJu0YyEVy845KhnIVI51Js0u96w/cLZN5R4yX41apt2S88QA+RVkkxt 6XWpmw+hkhDJJswBi3DTrisuH2bQdKYdIKgPsYLqNSgKVGQTPVbUD3qUnJUBJmA= X-Gm-Gg: ASbGncsfyua3qhpePlVa+u4bbP0zzW46IqlYD5NFfD8dFYNwL3gucJErixiKUrDO3ZS 9/VzfS41krRcrYTVg18ubJslsDknZ62faYCeRkuB9JE/lA/cUuCmL8edsvuOvmh/nIT3tgXha6Q L8o6AjRCQwWCfJiWhLTd8FD5jv1Ljo0Ua95WG1GVAzLRAwjzmxySZe0w7zAynzcPO7DwRU7QP/t MVf6nPFebugbPN07702jEapPGOzs7Inmeky316cqf0D8BeO8pe+iQbDWnVGgBR2xqDSXwyynBoL MhobpEdDcGipgVVN1OGQdYkXb7KN7c1lR09TqdqK3yVSphKSsiyNCQdeYaBEhOkSe0W/oHAZqkN Bjgg8z/e7uw== X-Google-Smtp-Source: AGHT+IHUtKBxx/Kb6wMivayuykLjA27f1K+WzySysSQHyW8EvpaAIClZC0PRyUOpjP+2MS95jX29jw== X-Received: by 2002:a05:6402:35cd:b0:5db:f5bc:f696 with SMTP id 4fb4d7f45d1cf-5e4d6ad3e14mr2592499a12.5.1740751652457; Fri, 28 Feb 2025 06:07:32 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e4c3fb51f9sm2550839a12.55.2025.02.28.06.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:07:32 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 28 Feb 2025 14:07:31 +0000 Subject: [PATCH 18/18] rtc: s5m: convert to dev_err_probe() where appropriate MIME-Version: 1.0 Message-Id: <20250228-rtc-cleanups-v1-18-b44cec078481@linaro.org> References: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> In-Reply-To: <20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_060733_843122_19C480B9 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. Signed-off-by: André Draszik Reviewed-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 50 +++++++++++++++++++++----------------------------- 1 file changed, 21 insertions(+), 29 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 77dd61c30681b8f0a2f23063ad5f7eb52f5b7158..4c66e38145b02638c48685580c7943bdf79bfbd4 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -626,11 +626,10 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) } info->rtc_24hr_mode = 1; - if (ret < 0) { - dev_err(info->dev, "%s: fail to write controlm reg(%d)\n", - __func__, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(info->dev, ret, + "%s: fail to write controlm reg\n", + __func__); return ret; } @@ -669,26 +668,21 @@ static int s5m_rtc_probe(struct platform_device *pdev) alarm_irq = S5M8767_IRQ_RTCA1; break; default: - dev_err(&pdev->dev, - "Device type %lu is not supported by RTC driver\n", - platform_get_device_id(pdev)->driver_data); - return -ENODEV; + return dev_err_probe(&pdev->dev, -ENODEV, + "Device type %lu is not supported by RTC driver\n", + platform_get_device_id(pdev)->driver_data); } i2c = devm_i2c_new_dummy_device(&pdev->dev, i2c->adapter, RTC_I2C_ADDR); - if (IS_ERR(i2c)) { - dev_err(&pdev->dev, "Failed to allocate I2C for RTC\n"); - return PTR_ERR(i2c); - } + if (IS_ERR(i2c)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c), + "Failed to allocate I2C for RTC\n"); info->regmap = devm_regmap_init_i2c(i2c, regmap_cfg); - if (IS_ERR(info->regmap)) { - ret = PTR_ERR(info->regmap); - dev_err(&pdev->dev, "Failed to allocate RTC register map: %d\n", - ret); - return ret; - } + if (IS_ERR(info->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->regmap), + "Failed to allocate RTC register map\n"); info->dev = &pdev->dev; info->s5m87xx = s5m87xx; @@ -696,11 +690,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) if (s5m87xx->irq_data) { info->irq = regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <= 0) { - dev_err(&pdev->dev, "Failed to get virtual IRQ %d\n", - alarm_irq); - return -EINVAL; - } + if (info->irq <= 0) + return dev_err_probe(&pdev->dev, -EINVAL, + "Failed to get virtual IRQ %d\n", + alarm_irq); } platform_set_drvdata(pdev, info); @@ -724,11 +717,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(&pdev->dev, info->irq, NULL, s5m_rtc_alarm_irq, 0, "rtc-alarm0", info); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", - info->irq, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "Failed to request alarm IRQ %d\n", + info->irq); device_init_wakeup(&pdev->dev, true); }