From patchwork Fri Feb 28 14:18:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu-Chun Lin X-Patchwork-Id: 13996485 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF30CC19776 for ; Fri, 28 Feb 2025 14:19:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24111280005; Fri, 28 Feb 2025 09:19:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F16A280001; Fri, 28 Feb 2025 09:19:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B9EC280005; Fri, 28 Feb 2025 09:19:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E1C23280001 for ; Fri, 28 Feb 2025 09:19:16 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2ED131A0C73 for ; Fri, 28 Feb 2025 14:19:16 +0000 (UTC) X-FDA: 83169560712.27.79B5B64 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 4664F1A0011 for ; Fri, 28 Feb 2025 14:19:14 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=a8JWQHwi; spf=pass (imf19.hostedemail.com: domain of eleanor15x@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=eleanor15x@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740752354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=aoJDksZR6tO0VRWqVMeDuRMJYfUAl7CjDy1BbxZ4cR8=; b=KNfNN/V8/ha2SRG6efwCAr4yxjhSUKVxUlP+66GBcBQzyqhuSIPXJmOymOzV4uJ4hiGk+w pIXN02qKYJxtcnY79YnTHZLq/WmG24sCC49h74zN6SK5yBZ9iYV3K1TnpfMuqQnjq6zYVd GaAFgImOxq6sc0y2BSaj8Lf9J1R6AV0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=a8JWQHwi; spf=pass (imf19.hostedemail.com: domain of eleanor15x@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=eleanor15x@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740752354; a=rsa-sha256; cv=none; b=4yOPmf91aRl9HUPpFok/vZ1Z4tE9UnYdNapDMhPVW3CK3XT+HezYgiSeKgHonZUN4Weq8N LJLySVhA9nGka2C/UisM3/eAC1zUVQFJ16l2zsyRnhf6Jg6s9jOAycbhYNtHmf+98NkaK5 EIfTOalBDrt0BRLhU0y34at7SA5RMrU= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-22337bc9ac3so41700155ad.1 for ; Fri, 28 Feb 2025 06:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740752353; x=1741357153; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aoJDksZR6tO0VRWqVMeDuRMJYfUAl7CjDy1BbxZ4cR8=; b=a8JWQHwim2I/c4cDOfTr86fJV6Z9r/kSvLoXDyLH7G5euQv/BVhmHZl7sUgoEe+++g PaoErvqAPu2yMa31NSGTw5paSD8qogYfsBLmAXw+hBmh7wMxSeFbxfPvPejdFla9EYk/ 5OroMaZuXqo2mvcGPMyWZRBdHM7EZBqLP6eRzMjZPWZhE8ZNmiLyTla8/q4rzVe7IhD2 R6cCc3haQoBm2sd91SkWTlrF1KL5DKUiwodTT+5H6WXRKrgVwAtrKUxSlexGKIszTgnl DlBVlIYvC9pD/vQeOmGkPGV41Q/SBaePiL/+7TtDHSxK3yyEPXiBdq9pE8qkTJxWejdI +NvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740752353; x=1741357153; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aoJDksZR6tO0VRWqVMeDuRMJYfUAl7CjDy1BbxZ4cR8=; b=GYNDjfhsw59X3s8PssNUwZewhS1gNjGYVJIXFwOJ8B29JPvt+Mm1regIZzIz/m0iDd N1TcBgogwb7/r7ZGaZHk18dDvjMd5DdgVzPyB3+GJ6FXwzD2bAPBYm0WuzZktevDqB9h 3EWRKXFbwIpUk0GaaBQgU51XP7iCnD4SrgPrXy652Q4zunr9JH0zIJe/9PNjxdSs2tzG DKOKxYsrFToK0CYfB2jB7rAtVZxcg7NixF76kJHQCWH3dShpi1qGya9miS7XR7a1qIn5 DyWgVmHznQywUvogENIaHoDSpAzdDww4X8fEA6y2vt5nkJekYW5R5HPmR+onCEy2aEn4 tQdQ== X-Gm-Message-State: AOJu0YwCZzrc+jUzKfSNim2YV6ftNTuNV6MZyCHQdyS33I6jd48uJaq2 YOEBFu+BwvooRt8GvWeMm4iHMJmO2HZJilOHEP1jHbNUR9bq8qCx X-Gm-Gg: ASbGnctbNUZVKSQE021NAn+eLPP6ZN17iDaJhf5WUfims5gFEt6ZExfCZbLWtV023Dl SL3EqUoy2MKKDMD8jgmnHRw4+8WDK5//wUJgQc2hST0z84ToFF467C02Avi/jTokaiZY9+gVjf6 VRE95pvUOeepcJ0RK2K7sx+dWlxDTUug38+fHBjlrPltN/pCGplLD8t37oBBsOpe3IELdo+49Rh 2qnKNqGWTUPwbzbSyXiAx0qI6yyt7CTuaKeH7mzkH1akamqtVZgglaCFJ/0S5i8plJNtQdUZSVv 69lMY2+uugTP5qOroswlH4ozhbXXrPs= X-Google-Smtp-Source: AGHT+IHFSmSa4md9rhHEOa50nd9mwN3EuatCTZt1vLAkmwAwsRiyM9/rO8rQZte7QK0f+7NJZz5kGw== X-Received: by 2002:a17:902:cec1:b0:21f:592b:b4b6 with SMTP id d9443c01a7336-22369244244mr51845345ad.47.1740752353061; Fri, 28 Feb 2025 06:19:13 -0800 (PST) Received: from eleanor-wkdl.. ([140.116.96.203]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223501f97d9sm33669745ad.62.2025.02.28.06.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 06:19:12 -0800 (PST) From: Yu-Chun Lin To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, jserv@ccns.ncku.edu.tw, visitorckw@gmail.com, Yu-Chun Lin , kernel test robot Subject: [PATCH] mm/list_lru: Remove redundant NULL check before kfree() Date: Fri, 28 Feb 2025 22:18:56 +0800 Message-ID: <20250228141856.730825-1-eleanor15x@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 4664F1A0011 X-Rspamd-Server: rspam09 X-Stat-Signature: afi6d8nkae8r14fa1k4xttfak1sxsuz4 X-HE-Tag: 1740752354-37985 X-HE-Meta: U2FsdGVkX1+OhIxVqi9PKbvHw7DiwnDmgrKlarax9efMYnKbrjxVhgeD+GfIrD+YheHppnhLaywfkhV8f95NhYVInb3h9MnT8X9U62QECLNCTnwKlGVKURr1lFjVderMDq+XLt7cWt0lG8TssqC7ykC30oAj5jGii9Bc6EerdEOK/fjjXsW6hVMmR+G3rHKG+sbADplkFSsEKwJn2kP+LImIOIcpVl4SZ7Veb3dFEbET8Adlg8/ahM6oDVnk87V/7qvuCEr5gonMVMP25g52HakEh3Yslo5cLi5veoUZjYv0GHy02+iNfKEjOOsqg0DK9NFo8MkLXGaqjjKs6w0dzEuMrqQ8LV2hdB7HhoIhrohlNopu7raPlOkh2TzSdoJRggmDz7NWHozrZVoUdG+04HN8zlgkXvUyiiTrrIy+WEldnlIxduH/NVtLEbsqX6sG/p1mnex1qdk0zWk9Buu0atFNrPz1vdxwCKfk+Jmc+y12vwG0Mc9s4eENncbkc1EFNf26+s3xKxHZFiJ6rNS7zZWdSok3xLJSPEk4hxxAc9mIBJ265ulVU9xP8QvWHvufjHqljWuQVW8+i7I+vAj+PEwG0LICMOt0RB345Z1P08WZTtu/dOF2qO0ojygVIQp6nnoQOySSlLh+g84/OTyOB42lGmOFweM6bc7TGUDNuOPJPfWM1I/OsWKAfUL2q4bokCPDKFrLvOI9sJK2WnmwcyJYy9wG3wJuiuPSid49efdmJRzyfQk611ExrtzmZgxVw+WqXHJkkSjW0r8CHYk0kgfaqtMtpgsyccZKfW3Kmeo9crBuVG6o26CWSmPd6c50H7A6O5CvN/dD3T7CbAE/yCq3MRXW5BjZouAMMKI2l+lujsCZmtqYyBTXa7Vh2o+Sw6NVnYZjzYnSdBgFygaq1QxX7s7L/WyJPidImokwp2MZ1bfnfHgyQNTrSTOzELrYMfiXpEjAzWbPlgr1vbS CVCH/Ssp 6MABYcZq/cDFN0RrfceUwZgmVabY1WkRZgV8QycNWPM/88+TdUy6dx0EMecl7lV6gOey1uyh1W/0ucI3O63dBaVP3ukS9W7KWHwNxGA32eMG8SzRAz987TAR7B33s89Cjs9TzHO3vDDfRO6tiaevyGCYpAYE4sNsyplHnGk+Z0NIIg2wrYdymOixv7I0ZdlD6ssf187wDdVkT6F7VbgEdxv9Q9bZsNkUyArlBNOPtrIGTNQZhPSHoWxlX/39a2HgknB628J8oN9goED/TUE4VFVHlPaZMV7ctyYE2OJmbleeaTP0FAxLVbZclRNyIwQdsLwSIzPGITlb5sOBXq4Ao/l++7v7RQD9cMMXDQLMO2sG3ExBrYlSKWzNv2bF9+HPJXGYdLKuCAS8ieuVZPZLHP/SRYzVNa2Ak/hr9VaVuPGyCz3DsYPcvTXxgJAvLoPboBWVCD4XwScTpzcyBUMS/MChBnHpkkQWrc+qQUNo/LhwdiKU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The kernel's kfree() documentation states: "If @object is NULL, no operation is performed." Remove checking for NULL before calling kfree(). Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202502250720.9ueIb7Xh-lkp@intel.com/ Signed-off-by: Yu-Chun Lin --- mm/list_lru.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/list_lru.c b/mm/list_lru.c index 7d69434c70e0..7c8fb17d9027 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -548,8 +548,7 @@ int memcg_list_lru_alloc(struct mem_cgroup *memcg, struct list_lru *lru, } xas_unlock_irqrestore(&xas, flags); } while (xas_nomem(&xas, gfp)); - if (mlru) - kfree(mlru); + kfree(mlru); } while (pos != memcg && !css_is_dying(&pos->css)); return xas_error(&xas);