From patchwork Fri Feb 28 16:54:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A736CC282D2 for ; Fri, 28 Feb 2025 16:55:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE2C56B009D; Fri, 28 Feb 2025 11:55:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D1E096B009B; Fri, 28 Feb 2025 11:55:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6EFD280001; Fri, 28 Feb 2025 11:55:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 906456B009A for ; Fri, 28 Feb 2025 11:55:16 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C355780EED for ; Fri, 28 Feb 2025 16:55:15 +0000 (UTC) X-FDA: 83169953790.10.E2EA6B0 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf12.hostedemail.com (Postfix) with ESMTP id 222AD4000B for ; Fri, 28 Feb 2025 16:54:58 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VrBo4sPO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of 3YerBZwgKCIIpgiqsgthmuumrk.iusrot03-ssq1giq.uxm@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3YerBZwgKCIIpgiqsgthmuumrk.iusrot03-ssq1giq.uxm@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761699; a=rsa-sha256; cv=none; b=J3gEqQWOnRLFCFeHzwhOLEmSpg9dRNK32PzcYjCBbUesKyzUp4PVjXE/sC3O9FqKFrY+DQ 9Hij32D8MxW5IkZ054y32Cp6pUb0FBrwfhDBcC1iU+5J0hgHnsdnza52UZgJj79OjTGi98 V04c0fn8LUNhjtB5OnGKEJ5UjzNPSNw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VrBo4sPO; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of 3YerBZwgKCIIpgiqsgthmuumrk.iusrot03-ssq1giq.uxm@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3YerBZwgKCIIpgiqsgthmuumrk.iusrot03-ssq1giq.uxm@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QncY2yvGTglAf/0LuL4dyh3O1wXM9xZ09WdsenWnBoE=; b=1qG3zmXsQuAy3O8EuLFy6gDMX9WVgL72Qoj6jzbLjML1ojCvYxGJCr9WQA1iFm18DOdLGA TF6pzy0oU+aaILheLONtZK7mvgtSjAxPg5Bg4b3KG3gkJvF4/miqqQ1z8mP3QdSEYWCe5h jPIGUHd6dISOa6YP7ZzwVB49Uxu+rLA= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4398e841963so15730895e9.3 for ; Fri, 28 Feb 2025 08:54:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761698; x=1741366498; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QncY2yvGTglAf/0LuL4dyh3O1wXM9xZ09WdsenWnBoE=; b=VrBo4sPOiZjOG0BVaD0xaUFaffR3991c/1Yy+dP03+RZhB0to3Z7NnC/n+8p31Mdna PFkukbYqdbLr7/QBicigYQkpdaJl9b98nbAubCZxGDhz0+/NLmaKB4xcDuvgiLrMFFA9 vi/EjT/xR9mr2wxtT+lQWJfh33k4GRnuNYoA0vsRJwbW/qNI5JkNbZ0izUisy1Onxk9k NpCgatG0UKXYGcTgAx9cSOGkYe1iBm4v6nvXfxmwxA2ONKQrdiIs5JHLSK3cqNs5e3pG 6gJoSJFImlJdB4+PRGQ2vor1mNVk5XPpMS0gjNLlL0sWJ2Ua0kDytr/it0YcV7gazU9J m08w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761698; x=1741366498; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QncY2yvGTglAf/0LuL4dyh3O1wXM9xZ09WdsenWnBoE=; b=TyQMgf7RJP/k9lL4TQMRcJYVgvzGOfEHESf57WNLSnv1Q3mbrwcee9HBUW6A4zWuRP +mr2oShTr7XY61CoLUV11sMqLe7lOmxj3v5JAVUGqW8Xqk4L7i6/IGiJWfURfyx+zXSY gkgR89+k0k3cyk11V4aXTMTKAT6pCHHCTPe9Vf5OqGlIkRiGoJWagssxumhIp3iBpZY4 T9eWmQk/od+7Q5eg9TKbgc42agUJRnFspEtSLpZ5+eun4lNKuv6UFNRiSc+0lYl88TF2 mSGg8gVt548JBYS/BP2/We+vziIKj16hJsqyR9oCT5dv9rIFkYMP+SUJZScypZ9V8GCb 7aJw== X-Forwarded-Encrypted: i=1; AJvYcCUR04tTUcg8aVEvhd65AynDV1LYo729RLFPXXfaB+SyWaknl21a3r17EJ5z+gfGmu+EG38lMq32YA==@kvack.org X-Gm-Message-State: AOJu0Yy2qZCmiFwgyZORJT/0gzA1tto6sgzLaF8E4Bv9GBxF327LGBDS bW4PIfkSAlJpb82UHeD3D1HNNaEN0g5FjPzmKVRerzwSBTHfqG1CLhEgHfVNMw6eOaZhnDKep9I ZypeSvg1paQ== X-Google-Smtp-Source: AGHT+IHicUU5z+iWE2KYovQO/NyD9BP+fwXrc9YK1TI1vNtv7VrgMEVzfL9fF+5H0fCQp7q+fQoKvN3hnL1mpQ== X-Received: from wmgg6.prod.google.com ([2002:a05:600d:6:b0:439:67c6:5642]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a47:b0:439:969e:d80f with SMTP id 5b1f17b1804b1-43ba6773869mr38269205e9.31.1740761697834; Fri, 28 Feb 2025 08:54:57 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:49 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-1-958e3b6f0203@google.com> Subject: [PATCH v3 01/10] selftests/mm: Report errno when things fail in gup_longterm From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Queue-Id: 222AD4000B X-Stat-Signature: 5an9b7psioa6au4re6adz3h4ky3f5gir X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1740761698-398039 X-HE-Meta: U2FsdGVkX186ifZqY6kjZFOHfihSPRn4Mh8tQhohFci9Cx/a16eQo4prsNOrzT1rupBykptDaielc5ag7Sw+lj/YdjROlFKPzJhEG4YD3GD/fkm8gC8Cp3QYgXFEd+Z4kHyrtknIGr5sh6CuI8dEeuJoonKBBXVgu2KdcCWh8Og3Milf3sHgBFII/GPpYDko9znJt1MtMd3vymIwQZuSQ95wfrsVyWs4HknlVUr7D4zlF85nXk7bcGYEGLq0Xtgv4VGS/zPbeJe8X0ZzkQaIZxf4lzRWQxWNKy1kuSmS21drNKE2rYbLDKAXWvBpW7nzb4RdiIzulbw+YxEqTsOPeJQ0ZZx7zcs8NchfE0mxvfwsaMwDYRpvP4CA7t9XI+f7Qj3Ekd6KrWohjXI9I1l9XMqDN4lqd1AtAs1FtrBSq0qQMgNAgpi91nDrhbpxURQMCGcEdywn1jONBNslA6/8UCEEZhqQSGlWIb57bqcu7ZyorC/rtcHEWklK0Vev/PP7egq9FbmOPNKh2GMs/Tp8HbOwzC3I0M7+L7TDSQLkVPTSGVr2PBST5QFhizX53JWQl/92EZxbJhgXqG+579irxJ0E9P794qeSi5x9xQW1V83Z8b2bC2JphcVYJ6WfceGYFcr6rzZQ1+Z/D7qyp5y/12gzU6oqh2/I+omT3T/kqmPwsopbtMZqd2TLysAHoNXN9Qz/WJwZp4GTEsTgDVDQc+BpAGoe8yYxR/EoFoalMluSeJI5XF9n0aWCYDzHY/MuM7TipkGaVI3kZBUELq1EoO7ICpE8+bHJICvEzIEPuhtlO+F8LHejgExn/wHGIn7B/X822Bg4xcsL1Ed1B7QDcr2bnpbDgIBHrmamwICoQplmzbcXn00rFEFed4BzT7S1I4aF9TP4FEY2Iq4p5f5dNTpbbt0fEXFFMtw2APEwS0ATljdKKPpyHzTg0A7mLscnma7/fiMZbe5R8ASSqRk jryblwHn ww9Ldx6nwMMy9eDTzdRMHNTtFk75xfbSjGqV9XAKsZarijC/iW68ickUHJIYwWAB1fJDiNWCHmnGOAOVpPikL3lKrQULknG8rFzqbywezBLnQRgpiCjwkF8W+KcAoLzGMBcaZHlbYNxPQFg3Rvq+/TEM/6PeFv0lLbdhXtUs8IrtJ2avG/pBN6NJRDyunb7xrs6YDPHcOJnUr3WJgz6a154F65PxFHRuvAjGSoduYGGMZP5cFYUR4me6oLbRvM6e8CX46ACgu7rzTyVd9/RcAu1bez4Vg5W9BMmcVvG+fwYf3W+pBI+yXcnh72FqFibZr4IdemyZ2nzNFPGOJKuP3CLPIYtyms2uPUPbzyzWZ0/mSschMcD4Dlfe8AFqXjnABaVrARfpUUvyqHoduWXmrIKFnAKysj8CMIzM5HaxpGhN3DoFWfYLmQI7zGMDjbN2y766rMmQ8DCpm5a2kBA0i6FNJ47KdFB0cFE99Ruvy1jbBc7D38/r555LbTjYE9AQVkm7KPLpAet4RSnM+tLw61LNvpCdy++x4lnWRm7WMIwSCkYgM2wd3bSiIExMA5wg8C2ySoiW1grkTA3IN8xvVcMaAASC1eEJsYR3/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.010599, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Just reporting failure doesn't tell you what went wrong. This can fail in different ways so report errno to help the reader get started debugging. Signed-off-by: Brendan Jackman Reviewed-by: Dev Jain --- tools/testing/selftests/mm/gup_longterm.c | 37 ++++++++++++++++++------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c index 9423ad439a6140163bdef2974615bb86406a8c14..879e9e4e8cce8127656fabe098abf7db5f6c5e23 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -96,13 +96,13 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) int ret; if (ftruncate(fd, size)) { - ksft_test_result_fail("ftruncate() failed\n"); + ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); return; } if (fallocate(fd, 0, 0, size)) { if (size == pagesize) - ksft_test_result_fail("fallocate() failed\n"); + ksft_test_result_fail("fallocate() failed (%s)\n", strerror(errno)); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -112,7 +112,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) shared ? MAP_SHARED : MAP_PRIVATE, fd, 0); if (mem == MAP_FAILED) { if (size == pagesize || shared) - ksft_test_result_fail("mmap() failed\n"); + ksft_test_result_fail("mmap() failed (%s)\n", strerror(errno)); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -130,7 +130,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) */ ret = mprotect(mem, size, PROT_READ); if (ret) { - ksft_test_result_fail("mprotect() failed\n"); + ksft_test_result_fail("mprotect() failed (%s)\n", strerror(errno)); goto munmap; } /* FALLTHROUGH */ @@ -165,18 +165,20 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) args.flags |= rw ? PIN_LONGTERM_TEST_FLAG_USE_WRITE : 0; ret = ioctl(gup_fd, PIN_LONGTERM_TEST_START, &args); if (ret && errno == EINVAL) { - ksft_test_result_skip("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_skip("PIN_LONGTERM_TEST_START failed (EINVAL)n"); break; } else if (ret && errno == EFAULT) { ksft_test_result(!should_work, "Should have failed\n"); break; } else if (ret) { - ksft_test_result_fail("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_fail("PIN_LONGTERM_TEST_START failed (%s)\n", + strerror(errno)); break; } if (ioctl(gup_fd, PIN_LONGTERM_TEST_STOP)) - ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed\n"); + ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed (%s)\n", + strerror(errno)); /* * TODO: if the kernel ever supports long-term R/W pinning on @@ -202,7 +204,8 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Skip on errors, as we might just lack kernel support. */ ret = io_uring_queue_init(1, &ring, 0); if (ret < 0) { - ksft_test_result_skip("io_uring_queue_init() failed\n"); + ksft_test_result_skip("io_uring_queue_init() failed (%s)\n", + strerror(errno)); break; } /* @@ -215,13 +218,15 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Only new kernels return EFAULT. */ if (ret && (errno == ENOSPC || errno == EOPNOTSUPP || errno == EFAULT)) { - ksft_test_result(!should_work, "Should have failed\n"); + ksft_test_result(!should_work, "Should have failed (%s)\n", + strerror(errno)); } else if (ret) { /* * We might just lack support or have insufficient * MEMLOCK limits. */ - ksft_test_result_skip("io_uring_register_buffers() failed\n"); + ksft_test_result_skip("io_uring_register_buffers() failed (%s)\n", + strerror(errno)); } else { ksft_test_result(should_work, "Should have worked\n"); io_uring_unregister_buffers(&ring); @@ -249,7 +254,7 @@ static void run_with_memfd(test_fn fn, const char *desc) fd = memfd_create("test", 0); if (fd < 0) { - ksft_test_result_fail("memfd_create() failed\n"); + ksft_test_result_fail("memfd_create() failed (%s)\n", strerror(errno)); return; } @@ -266,13 +271,13 @@ static void run_with_tmpfile(test_fn fn, const char *desc) file = tmpfile(); if (!file) { - ksft_test_result_fail("tmpfile() failed\n"); + ksft_test_result_fail("tmpfile() failed (%s)\n", strerror(errno)); return; } fd = fileno(file); if (fd < 0) { - ksft_test_result_fail("fileno() failed\n"); + ksft_test_result_fail("fileno() failed (%s)\n", strerror(errno)); goto close; } @@ -290,12 +295,12 @@ static void run_with_local_tmpfile(test_fn fn, const char *desc) fd = mkstemp(filename); if (fd < 0) { - ksft_test_result_fail("mkstemp() failed\n"); + ksft_test_result_fail("mkstemp() failed (%s)\n", strerror(errno)); return; } if (unlink(filename)) { - ksft_test_result_fail("unlink() failed\n"); + ksft_test_result_fail("unlink() failed (%s)\n", strerror(errno)); goto close; } @@ -317,7 +322,7 @@ static void run_with_memfd_hugetlb(test_fn fn, const char *desc, fd = memfd_create("test", flags); if (fd < 0) { - ksft_test_result_skip("memfd_create() failed\n"); + ksft_test_result_skip("memfd_create() failed (%s)\n", strerror(errno)); return; } From patchwork Fri Feb 28 16:54:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996774 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8968C282C1 for ; Fri, 28 Feb 2025 16:55:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DAA06B0085; Fri, 28 Feb 2025 11:55:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 689F96B0088; Fri, 28 Feb 2025 11:55:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52BA16B0089; Fri, 28 Feb 2025 11:55:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 328B66B0085 for ; Fri, 28 Feb 2025 11:55:03 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D978F160E79 for ; Fri, 28 Feb 2025 16:55:02 +0000 (UTC) X-FDA: 83169953244.06.6F0B452 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf09.hostedemail.com (Postfix) with ESMTP id EA82A140020 for ; Fri, 28 Feb 2025 16:55:00 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T0CQcs8F; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of 3Y-rBZwgKCIQriksuivjowwotm.kwutqv25-uus3iks.wzo@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3Y-rBZwgKCIQriksuivjowwotm.kwutqv25-uus3iks.wzo@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761701; a=rsa-sha256; cv=none; b=PcilQGASQEMNHay14D+99DXlYdX22IiPo0hrE0nUSdkQAQsLzeEbFZ7M8JtcMBEXhncgG1 /NrUFi/o4O1WHHPlLk0BCIwoGddrFMjh5zciKw4Cmlnlb00mcNw3Bli8CEwiYIsN8l2mK2 FEnpn9crAZ/uOa6TziCddZJqsA2ajlk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T0CQcs8F; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of 3Y-rBZwgKCIQriksuivjowwotm.kwutqv25-uus3iks.wzo@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3Y-rBZwgKCIQriksuivjowwotm.kwutqv25-uus3iks.wzo@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iBiyc3H23svJ8vFmdmR1EW1tSRVU2LGHBr3dzguiiSU=; b=jrhZ6V/q8EFGqlx+dDgwLg+P+/SGq2jOMSFJQ0NfDpt77EH18EXEjfuutJnBYZuJTbduaE untxmdEa2eZzBZPJeAUlWUcpYd0aP5+u7PEQuL43ruZI42o3WRv8KrF1eOFW2tYAcYgUiR 7tJ+/+B72biXQXQl9LfdxGYnedrMGeA= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4398a60b61fso12913505e9.0 for ; Fri, 28 Feb 2025 08:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761699; x=1741366499; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=iBiyc3H23svJ8vFmdmR1EW1tSRVU2LGHBr3dzguiiSU=; b=T0CQcs8FcrIWH/lhlvxBOyJQQDTzg+CHKJhiqYm95L0PQi4JjueDhofL/wZqFoxWVM KTB70ns/+BXttZxj+v/DgPOE29eMEwpflGkVd2piF9mtz9AbDbY4Vc3wPUeAZhG2nBvz eH0d+Qkj51uqaOXu0YqoBB+3MUrHCIjdTKu+gbpckIa8Hxee/EBod+bLsuxU1zDuIbb3 U3UBcEHYHGT2OpqkFPpDf9szwsGwM3tKF9NJPqBpHX2uO5L012Flx/r7wPaGXzQZuZv7 lq1GalPZ/vcmia1paLyIIcNesZY4Sey8BvoXeJzqrTTGqy9/3KQAQD+CkQGYB20HMDiU UY8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761699; x=1741366499; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iBiyc3H23svJ8vFmdmR1EW1tSRVU2LGHBr3dzguiiSU=; b=smywx62Y2l92swF7QnDXYG/XpdZukcABiQTz6EUcP+avdWP2zkdvh5o9yqGvjIUa6y 1okhC6doSkdq4KeIxUAENMwp95QFOo/o71/fRRcGFDGd7MYONMjPMJsTr3J088einLDs ExCpwg5BhZSwaUqD4X5Fzulbya1c8q5vtQOYndMG1YCUZR22WTUq77lKotJ/UqCbuas3 CJTMZktL0WvFZLWJh8lL9JTu/6g63SZZCAd2pvW1FpgRWyYV6MUOV6UTN8M1BV56OmIb IzNHcri99OKYOcCubQS7HiEyMfuwOrnbebbNNAIRnklduMPQRmQiWBK68mtQpPChlZqi NrbA== X-Forwarded-Encrypted: i=1; AJvYcCUNMoIHxwBBc/ZRBB5k/mRgy8/tjDPPX/8JZn2UYAOvNvtCCW3YACq9DDBP5HXhPIvrKFccrO7zqA==@kvack.org X-Gm-Message-State: AOJu0YxmtTLoI3mbS/KbXgBHwWxoYYtlQf5w1+teMpFgdhn/SAc3ix5T mT3gfMAKs3AMbXj8YDSiYEwZlg1cDruTofA9qbzJTSQ3Iefps6v9DHs1717F7EdcRu74ApEWZcY vuJZZlDVFAA== X-Google-Smtp-Source: AGHT+IFI4L13fHbxgZZEec4SUfw5Itwe110pr8uhvkmoWV4jeH6QyQe/bJoYmx708YRn7IAUip5ewSWoYEH6mA== X-Received: from wmbg8.prod.google.com ([2002:a05:600c:a408:b0:439:846f:f9c8]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a03:b0:439:9b19:9e2d with SMTP id 5b1f17b1804b1-43ba6702becmr40505965e9.16.1740761699715; Fri, 28 Feb 2025 08:54:59 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:50 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-2-958e3b6f0203@google.com> Subject: [PATCH v3 02/10] selftests/mm: Skip uffd-stress if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EA82A140020 X-Stat-Signature: ataj3317warr31yosfbk4rwjsdxnrkhh X-Rspam-User: X-HE-Tag: 1740761700-594550 X-HE-Meta: U2FsdGVkX18vEB16aeMIwsKcWEEBn/O8R+k9hJ9kEi/EwOZP5L/UTTUN+EOIN31kNlopnk2aVPt9ZnRyrXKrpc7rlyQz9TXHrOvWY1ExKRD25SRbbupoGG/5S4TFh8HRxwQXtJZV/abjxD5n14GC1ddr6SDu/wRua16DmvLzBW3/L7cBHVnyju2jgxRtpc2JcARRtptSp1Zj+2sDdA8N7quwd0/A8uTA4a0O4IMxmkX9mInp8PtotoXIjXKeG7t2qtXOgdXkgCch39bhZ0tEDqa4fxaXyIkWO1aC6gw6X3uB2QxUMhq2eyOMsumEbUgyv+AG/YbVEmJgVJbXf7qHanrnoNT8Tr34egyDx763Iz66PChLsDGtaotskb2nenBnI60lO7w44GTaP6tBk0FwPMa1jq1bBVwI+IHSXlde0u96W5qI+A26RdB0AY5aHUj0cFrFBkvr0PsstyEi9glhu841T3QKoOGIifKATTs1dW1vFpz+qKoqptdwlQjZ5pK0v1xu108Li5V63J0wDjjGyknOSUimrGAygIiO6Ib2clFxyJ72J97bFn2kPHRYuzQK8S0+eccVKLgekAx+L+yzPSS7MLnCtrIbAdVgJjEtlH+2kwwujMJZzBuuW0uar4LnACV2FOiMqaKH2xTROrGcIxje/DzHCenLuM15zxJ2nO08TOJDWgsCI0TEsv9IS6JpIgo8lyXzGwSOwp0ypFTD0RtbKCcuq6SJfFuaCwcKDgq3XwOVFZcltXJPWtYVtcBBGyed/Y1u+OrSYGnTEqQ5K2vPtfYmP+N3ntUl6gDmiTDR3xbjXIsaZgGXGFfjgG6mET3gDJmAiCZvnrTVoLd/hEOxjsjEt0ZoSLjpSdwotNvMC5W8FdexXPo55pXS/GwOVdYrQzQh5Y7Fns4XpdhI6NfG1S2+m3P85CxFYLIY1tAdH5q4JNEn0Pf4HKcCKz7PCd0CZDWnJGDnQKkrGq6 6Nr+Ebr6 aMu1pCL8TRsKMixf3c8Fon6k5k24zHBDNm+z7Qt0Viq1HCaf3g/ZJLmgxe1iwNp5arWD57hf9ZQouqAlTkQoaQNWB/OODtXzPqjotilF5ANg7T0z0CE2lkXyBWlcGtJOEETW9W8mamYdloQSvsLYW/lQfvTg84FnGeP4tf9gDHQOZQ7QE/aIWwaXj2wc/5oezUI6x7Pu//hRc8QKiAO7SoUXZMU3Hf5UNKH5LMmqTiJdk18SXcduYtMuXljhYIsvrWPB68m5crIyh0SJprDZV8bsX91e1YJYwDpdfkyprgKXA4QbkSu2J11mKgELv6Vq862fB96wthvLvOsgJWYpYWbmJupxP2ecgXpqFFku+pTZr3Mm4lJoz8ExP3rdi9KenVLGUqOM/MUNbXzHJngKA5On5m85uBAZrWxinlntttDuoQLvRwM9OGN3/7dO3uVs/8CiWYLGMiKaZWvQjoZFIne4bLCNIFBOKPu1exj0B+dKIuM+f0BGrcFUa5mUt1EsUFwnUyfW4FPDY08Ut/DzRaHfjCGIEJpijg3XuuE1cSqa7r1KqbOLLkpZdOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.182680, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's pretty obvious that the test wouldn't work if you don't have the feature enabled. But, it's still useful to SKIP instead of failing so the reader can immediately tell that this is the reason why. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index a4b83280998ab7ce8d31e91d8f9fbb47ef11d742..ed68436fac62c76e2ca7060c661487f2f8a6ab45 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -411,8 +411,8 @@ static void parse_test_type_arg(const char *raw_type) * feature. */ - if (uffd_get_features(&features)) - err("failed to get available features"); + if (uffd_get_features(&features) && errno == ENOENT) + ksft_exit_skip("failed to get available features (%d)\n", errno); test_uffdio_wp = test_uffdio_wp && (features & UFFD_FEATURE_PAGEFAULT_FLAG_WP); From patchwork Fri Feb 28 16:54:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996775 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03925C282D1 for ; Fri, 28 Feb 2025 16:55:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 814D16B0088; Fri, 28 Feb 2025 11:55:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79D626B0089; Fri, 28 Feb 2025 11:55:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A2426B008A; Fri, 28 Feb 2025 11:55:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 355296B0088 for ; Fri, 28 Feb 2025 11:55:05 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D4D691C7A0C for ; Fri, 28 Feb 2025 16:55:04 +0000 (UTC) X-FDA: 83169953328.21.212301F Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf20.hostedemail.com (Postfix) with ESMTP id D0F741C0005 for ; Fri, 28 Feb 2025 16:55:02 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NwA8+IDT; spf=pass (imf20.hostedemail.com: domain of 3ZerBZwgKCIYtkmuwkxlqyyqvo.mywvsx47-wwu5kmu.y1q@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3ZerBZwgKCIYtkmuwkxlqyyqvo.mywvsx47-wwu5kmu.y1q@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eQTzwm1/YTgiCDgIJd4mGLtlXGG939iT/ah2c/DG9us=; b=eUyK1yb2JLa54UOj82SHTKhDi1lowQ5oz4fgqljHnywlFP1SO2t7cStSSt0CUo6A4LFSgx NWMaIW3wAan9AOIpV7n/bM8BIAkjuu8itqEKyoMIBpX2Nj5Ke5g3NnYPCJ90KmEmTmYMD5 dnEvjipGXLDjSXnwXdocDJKs/PJhCKY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NwA8+IDT; spf=pass (imf20.hostedemail.com: domain of 3ZerBZwgKCIYtkmuwkxlqyyqvo.mywvsx47-wwu5kmu.y1q@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3ZerBZwgKCIYtkmuwkxlqyyqvo.mywvsx47-wwu5kmu.y1q@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761702; a=rsa-sha256; cv=none; b=yGAEzAPkQUbLKzet2CYJEf2CLZgMh/fRYEc//C5nBqJvTx2UsCkHsfOh23wFg5/y11WOPm 2XXIGYxuOtuaYVczGoW14evbmN0kuxbQL3GI8+KT/15Aq+ORK8K3x4jI1rvNfESogHh/mm oTc/YIpLCN9Vic2aGFtBEj8s1Am4o88= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4394040fea1so12371355e9.0 for ; Fri, 28 Feb 2025 08:55:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761701; x=1741366501; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=eQTzwm1/YTgiCDgIJd4mGLtlXGG939iT/ah2c/DG9us=; b=NwA8+IDTJcQNlbBV6uAxcLHtT+eD91L+VrGZqG5vps9v6uI5WcfgQqOf2FItvN9GSH tXOc7YJSUrALI2x4bgOCONzup89RX//PoA9nl2UjSGpQ5qNO9JDEcq9Qq37JVBFxhCmb /veWOvFTCLfDN0FYZeZroeeGtCLEF/msiYCtbVMKm+LPAUmSChuyEpDy5hhkV7LMDG2Z Z4NU+vNxPeLs74xi/QVvHVyh76clzZBu/MNvXZ7LzJLiKfSIsG3y4XBNLG9ngjL/5i86 zCk3EPlvBOP4/eXr7gHN4qpitfP4+2jaZIejNOWt1qZn9eYw3XZ+9/NWs7IW5PsyXGMG nerg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761701; x=1741366501; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eQTzwm1/YTgiCDgIJd4mGLtlXGG939iT/ah2c/DG9us=; b=r5IZ00IEhIBJYOc6U1xAfTFgSuFbcy5uBWvxdDSaetcEM0aNC/3xad6OOP80RXJCTz 2T+2xImCi1fL/ALsuP+teiIa0Sk4q0B7ZEF36xOeKO1AL5jQvLtQBg3mk9TgFGbFY+j2 QNz0ZZ1D2vyrngcqcfElbU4ul31pO91Bt22ZZ+zOTF+l/emRknPW38JVT8c8vFr4x0Rl sFKJpTpfttSIquqTHXmPXHY9lewOUxiDVxccyx0UXUWP4ek0pxPQugKNbvT/FEKxwRFp bE+PUX7Vip8zT3mtBMn0kAHULvKzEfMg/Jh/3jziRiqrblXDArnBppEI2P3bPZIr+9nY XzjA== X-Forwarded-Encrypted: i=1; AJvYcCW112ci/cOKqqLz2vkMaHa5loMHPjyNHuEFgrGfiB/fZ4WB83/PeDgCM5FSHIorqvWXa3f7xB9IJA==@kvack.org X-Gm-Message-State: AOJu0Yyz0n3Ptw68ulFZPtlGDVGTOjqYEyDKImas6fFjLz9B9ATKxZXG QnI7WhD7NgXyKdF2EfDmcl77cG0WNJVJSc4kjd+/F4ZQzPnAqkuVPLsh8gdZ0piB2KXhQ+M31+5 D7un+uLsDcg== X-Google-Smtp-Source: AGHT+IHS4r5KyEGEE1SEHcuK3lpeYK/As6O/YHl7os80gLfqDAlqf9ZMUgi8r5sMn/f3nJljGpIwhadvxYAUWg== X-Received: from wmbfk6.prod.google.com ([2002:a05:600c:cc6:b0:439:94f1:365e]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1c23:b0:439:892c:dfd0 with SMTP id 5b1f17b1804b1-43b04dc361amr70383245e9.14.1740761701615; Fri, 28 Feb 2025 08:55:01 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:51 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-3-958e3b6f0203@google.com> Subject: [PATCH v3 03/10] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Stat-Signature: hr6p3ujoew7k6sto69358c4h36k5iiao X-Rspamd-Queue-Id: D0F741C0005 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1740761702-199299 X-HE-Meta: U2FsdGVkX1+Ca5/MLwfupHas3cMPSoB6px7zSZXCTS8qw7PkuN/tGpjIUhns3uRWZ2Ev+JJQ2cKgiiGc1+9dd/+Ne2gt6dLZ/X8SQwS6EY3Tt8UNrQLmt1t6qyIJl+ap7Ig9eYw6qgNDCovvVpozstAcarfbnJayEwpe+9v5U6zWHN8AdHkDZ8RHvD7S7G/8ccWTkFHKZ616EOj6ziJstKtmfN4wzomHgZAgP1uA6z7P/XFND2rL8zCMvZczqzkxSbRs4l2IPTFmZJxe6Zx2IqV1jUG8pA+W1PWqJAB+MWqhpGB3lBl9SSf626CdSp5W7++1gqLaitraumC+umEPxuks8CqtypLWbTmU7os1ESp/JMTYT6skLgLYMo4OzzF0vnShNeKcM+TOyIKJ/2SwQKw673Hs6JvJRzzkwElfGaouerUmWbyG1Wq19AH9Eize+6RenZa0I2z0lRB59xnxDahFTat8Rk2VONFx10BaRlYuffZiErx5QKwKhfcuvu/M33TLZ92A0LGBfqC3d+YYdwzKBlW2x15QD3X3aUIYUuuCwyMIzXL5hL4U3qQx3DPt7ZfXSqDJedspl0BYhG8UvHbMCVu85ghgwnGjyKjCLQQkVWf4/ZdbhH9/Imf8fJZTcCK1GFBdKXtIRyIzkolkHieYKXR9D9F7MOqfNKqJ+nhneQZmF/O2lCieBxXjCfUHWdS2tJJoa/Y0kvW6QiJqn5rnydarSlUZrtkSzhNx4ecNsoPd5xTPtlddfh7b1hAoFDn60vEFlKn1CjFGmOrxSCbZ9QiAxn27r0gF17jji/QQ+Y6IvwfYdwrjltOEcVXOJqBxR7tOQNKj6OZ2sigg0FXjHPE6OjWIJ9mtgXbx5r1PZ/0mJgz+zjHYjQ/3oykj+p1Aygr0hYkZ2ZqVydsnMRaWY6GqVs59GxK101SVoCj168966/nkXilFRnbhDl5u8mYV8I2CsOm1nSiSuvd 21U18w1R 7OwkLsnw7D899LBXGZM42PyKCliL+oJNQHgv2wp/P/SzXRSOwKCkw1IMAVlZ+48sSsQDnHxSKkgQmj+vjtYoENC6KtV0P47VT+VPB1/gTkTJBh7tmipB5gzIt4Jqh9DExpRnkqPL3AuAoFeRGd9fLGvdo15fo2R6tuXeHg/SSdhUJ4ZvsMggUnK6IC5d9GwOljtO+34jBV89TO7cykjMSxL5DV62i8/p2m3evyNSUqqGyvp5qOdxsyr5dG3pLlggjQF/NSfWUESuUtD9Rimg2yDdVxpxZDru3MORMcJbAz87LEJe6TWzblfHNcxnvIa/YzkqyMiqfiwrp5yoHLR9Dp9n/ikPt/G8Pqkqjrq8e2LmswU5mZuRBQMhX1o5knek0FZJgE1ZJo1tz9bNtgjJ4HafyyszWUWJN8nGEtrFN2HpB/HyrmeG/8gqvrMkxATdQrBApor7XaMbYht/poo4sR0+aUFsoGLXIo4WXiyB8md6EjQpyMpCdXt8vsaU0vBnNHM8eGpK0/F6h36yIK88W8CXNrw+ew485Ni0m8Aq6SoyyAfSEVwjoNLgpKg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.306845, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's obvious that this should fail in that case, but still, save the reader the effort of figuring out that they've run into this by just SKIPping Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-wp-mremap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-wp-mremap.c b/tools/testing/selftests/mm/uffd-wp-mremap.c index 2c4f984bd73caa17e12b9f4a5bb71e7fdf5d8554..c2ba7d46c7b4581a3c32a6b6acd148e3e89c2172 100644 --- a/tools/testing/selftests/mm/uffd-wp-mremap.c +++ b/tools/testing/selftests/mm/uffd-wp-mremap.c @@ -182,7 +182,10 @@ static void test_one_folio(size_t size, bool private, bool swapout, bool hugetlb /* Register range for uffd-wp. */ if (userfaultfd_open(&features)) { - ksft_test_result_fail("userfaultfd_open() failed\n"); + if (errno == ENOENT) + ksft_test_result_skip("userfaultfd not available\n"); + else + ksft_test_result_fail("userfaultfd_open() failed\n"); goto out; } if (uffd_register(uffd, mem, size, false, true, false)) { From patchwork Fri Feb 28 16:54:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996776 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFC19C282C1 for ; Fri, 28 Feb 2025 16:55:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6195F6B008A; Fri, 28 Feb 2025 11:55:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A1706B008C; Fri, 28 Feb 2025 11:55:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41CB16B0092; Fri, 28 Feb 2025 11:55:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1DB7B6B008A for ; Fri, 28 Feb 2025 11:55:08 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C4984B3B76 for ; Fri, 28 Feb 2025 16:55:07 +0000 (UTC) X-FDA: 83169953454.20.02606E0 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf25.hostedemail.com (Postfix) with ESMTP id E2A5CA001F for ; Fri, 28 Feb 2025 16:55:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="4RP/f1js"; spf=pass (imf25.hostedemail.com: domain of 3aOrBZwgKCIkwnpxzn0ot11tyr.p1zyv07A-zzx8npx.14t@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3aOrBZwgKCIkwnpxzn0ot11tyr.p1zyv07A-zzx8npx.14t@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S9QxBMT1dy5QbhO22yQnX/sY19xHXMzPESl6Emh05kM=; b=D0zkpm+S8OyB0hsMmDSWvabHXwsjChi2D1c4wxuiIU/eyKJEQlTlpeVZQMy/QQOi5r+TAM 23nPPq8SVYoCZvsLvGo5WwJ49ENLWOljO6PRuVukt31/CAVzGMh3Lw0htzny7vto7kM5xt Ix7WBbfMDdA5ef/CwOpP+Ycv4ujew84= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761706; a=rsa-sha256; cv=none; b=WP17ZTqMyJZFO7oQ32Tgx4TWyLKZyx1FWpj7s4ySEKErAyv2wfoX1tLE9sJFZnImcE0dIS ju5p+tE/C4kh77J+CE39BgdJIkzUfnZH4C2qXpowhwzDhgUOQfXBYQ/I6vjCZSG4s4/9YC RGoM1NaxPzrVtRenfrunlC8t783G8qQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="4RP/f1js"; spf=pass (imf25.hostedemail.com: domain of 3aOrBZwgKCIkwnpxzn0ot11tyr.p1zyv07A-zzx8npx.14t@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3aOrBZwgKCIkwnpxzn0ot11tyr.p1zyv07A-zzx8npx.14t@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4394c0a58e7so15890115e9.0 for ; Fri, 28 Feb 2025 08:55:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761704; x=1741366504; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=S9QxBMT1dy5QbhO22yQnX/sY19xHXMzPESl6Emh05kM=; b=4RP/f1js5xQVx3KPki5W7TmhUe373uBDv8IT8ehwu4QD4wqJ2XKYzAnJwHwS5IFBjB qKM1Osu24TU0yiu/sv6guw1axrbQtfJEr2MAhW3VLYrsXAKxj+NYr0NPQSMwuMthQan6 sZm7rrS4NvtrtypyP0yLV2co4AKN3QBx/1Od9iINwVFWUh1LLSNe6OHJP0D26HW5Ytfz hNeBYBt3GvrTSETKga1E/ypxjP7JzVxturH+fL7ByXu0lk+W+YfAQaUaYFO24LLYtyTp sSJz4GVsn4buKnuaA+YosnddziXTsRMrwzAKjaoUX9OPY5x/NES22Evzn5c5Z2vVcLea crXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761704; x=1741366504; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S9QxBMT1dy5QbhO22yQnX/sY19xHXMzPESl6Emh05kM=; b=fTYV9dSkHTnEyIWi3deZR9DMDBHNPtCWQzsypfVEy4HfSOjpEzXdeq6tPQTHWqKPSa GzziMLsiJ363a1kBCorl/PWdevOmpsVj5mf+QXxWL5NFsJoF8RP6d8BT3ugsxy9g/nQm yYc3aRHG8JMvI4TotLsrlO/niHDgqjsxH+qAolgnEHUt/zGm8bLeM7a5Kz6GdG67hgFt hkP6dYVqOpnGsB2gAz//s/5gd6tk7GbIXLcUBBs59lOq9cZaf2dj93uwWSC998TLvB0L nrDZjUuQKswJl+0qZF3jTjtMUXohdHAAQ+NENk9RLG0ppcZeYuo0tqvh9kIqzMGLZERu YCzw== X-Forwarded-Encrypted: i=1; AJvYcCWBIZFdGJtkP0eyXeel/m3gktsoZS2msAkhA+eBJV8YKskXuaBv+E+nweZbi8tEPnaH8pHpoGZc2g==@kvack.org X-Gm-Message-State: AOJu0YxTHBgd5BfGASNpONR+z1q6mieQF1meElM7aHhLmHZnuBwsqwCt IGoy50WJc7P8jOefpKC0shtknZ0swfahCftfy+/BPm74NGksilQGKikQYc8ji1/xRLuo/8a+sQD wWbrp+gsI/w== X-Google-Smtp-Source: AGHT+IH0IbPgf0WZB4YwqpZ6IMtQ3dgzowLYjozZVKkhVKhCwE0plHrNAT013hhx4TNDxRckM/EIsEy0iSzC0A== X-Received: from wrbfy2.prod.google.com ([2002:a05:6000:2d82:b0:390:e463:27fd]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:2c4:b0:390:ec10:9dca with SMTP id ffacd0b85a97d-390eca414e4mr3842391f8f.45.1740761704683; Fri, 28 Feb 2025 08:55:04 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:52 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-4-958e3b6f0203@google.com> Subject: [PATCH v3 04/10] selftests/mm/uffd: Rename nr_cpus -> nr_threads From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Stat-Signature: nakcjqjp1xredw9qawqyrtxezexpc6sn X-Rspamd-Queue-Id: E2A5CA001F X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740761705-133423 X-HE-Meta: U2FsdGVkX1/9cTieG+9MqE+PmYUOVg0Pd88iMxyZxx2qvW5fC7rB5bSdK35I++llRgPz9aCTUv2YaZ65LmZtjQEO+J7DYR1lgcrbPjj5sfFHrbQUevp4wIqa1RfqPKG+u+LMNcQEUvX7EZddjX09Q2tY2F2eUNLpBlDbcjIgaWdBdtnvwcbFTwGUQJTDVDiDElD5Ak0iLy5UQ3yXqjPBsl+mu6tDTwgYUvbxgJWyXlpnfyK+saAOVpy/2cVSznqImj4eFE8mVvuEbKjcV1DgU+t9VePLRJZIUA0Qjge3pSjkHqrOkgbvcWekhPWChFb1Jr3SzavIsBZFC8nlCVxhFnReTl5N7zEcCYESs3AAtCpKSX8hOmL5xXeKkUZNs30FLPZWqioOeJJ7+CkS/LRuDbuIcBlx/qtbZXANd+6Sj5y1/bk/3fMt/ypMxp4K0yCUf6tX7sYjF9IzYVEHCMkofrGNvZ4La5Ri6M0Bswmd2BBVasqEmaV/P9g2oRncDF76p5GLgSilLu0fqW1bXlHTdrWWMc9t1ygjEa2Zn+iYQFArYKUy/q2uAhpWXx4Fp0JVHrAh80DfS6nHXalQPFWHR3W+HCxYNuLQOGhiFJrWFiZweheJ3t2HfIVh3ayG368kh/pH5bePsAIoDbDf4D2BoeKFqki1119Iw29Btk2jRzc0OM2D+d8NXcybV0uEjyEZk6EZNpj9ArmkTcKgKw/P3jIHYcSLCQTYdiRJsRKQVZPFAD2+oqFPdBpKsWwno+4JbqpcVAaSq8FH3Ztzn7/kcJUr04QHKM43QwJNbQoVd745bBemO53Hsg9JeBrcSownFbHXD8dqrAHJIR6B/yuVHkdp+8192tnBwBa9poS/PJcY6QgQaIS9AqO2a1IfVkX1X5LLs25fglPlzqaLuuZpPbRUouUNEODzSaPK8o7AKHbwhzl4Bmf1lffgFb1xjZj37tl8mDkRFLJbXK187pW i5R59jp2 9H0cb3t2apK5AKaJkYDbMnoqYvbiuPI8bhxGWAaurzwDT4xp71UfOzoBJk+0/n/yC+nBon3rB2zgYKqh/FKuf+NuPu8R/VCfEHrlV0BBv08WjFQSOF9rRt19bKqnZ/YsVBV3WV3IqaP59Q+miE1XDh+KMJV5VE6dDlu+siMS80McOdeMWKnQwex4q2eusLg1FU0Z2POjiwi7I0jluH6xPqUVyyfrSTjbEvSl1hqhZm+/dtJtyApjPqZM4bg1PxyfDkzfiV9OPUhxRDdaJOb4HNsSkzsoY3mQre9bdk4CaJzrS1i/0M/hXBsv4v6YWWjNxzDg5Ru4HmpO4LY4T7uoAM3eeNt4U6GZ0Qeb4TK3P3JED9pJSJ0CY3C2E8YsdPC7jJ5go3I8V5d+1BzO/uEIg8+omj1JDvTnHIRAM4ZGFhEojWEGB7JWmXjX33hmmwJCrkweIJmU50tldNWMmDGRJi/mRyHolPaFxBvvTHmV9Q843Y16EsdGT0R9sZyx/o+IB5QPZy8U3eR/fdDYg4nvg7Aaa0dNTuNW08vX5NA2egdqUP1Maz9n0SRPc1oKqrjHyLvfTqPC9plm2XFgPwTBa5FmF3Io1FuG4KmDg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000039, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A later commit will bound this variable so it no longer necessarily matches the number of CPUs. Rename it appropriately. Signed-off-by: Brendan Jackman Reviewed-by: Dev Jain --- tools/testing/selftests/mm/uffd-common.c | 8 ++++---- tools/testing/selftests/mm/uffd-common.h | 2 +- tools/testing/selftests/mm/uffd-stress.c | 28 ++++++++++++++-------------- tools/testing/selftests/mm/uffd-unit-tests.c | 2 +- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-common.c b/tools/testing/selftests/mm/uffd-common.c index 717539eddf98754250e70e564cd9a59f398bd7ea..a72a2ed5e89480ed06c81b034967ed5ae5f8cad5 100644 --- a/tools/testing/selftests/mm/uffd-common.c +++ b/tools/testing/selftests/mm/uffd-common.c @@ -10,7 +10,7 @@ #define BASE_PMD_ADDR ((void *)(1UL << 30)) volatile bool test_uffdio_copy_eexist = true; -unsigned long nr_cpus, nr_pages, nr_pages_per_cpu, page_size; +unsigned long nr_threads, nr_pages, nr_pages_per_cpu, page_size; char *area_src, *area_src_alias, *area_dst, *area_dst_alias, *area_remap; int uffd = -1, uffd_flags, finished, *pipefd, test_type; bool map_shared; @@ -269,7 +269,7 @@ void uffd_test_ctx_clear(void) size_t i; if (pipefd) { - for (i = 0; i < nr_cpus * 2; ++i) { + for (i = 0; i < nr_threads * 2; ++i) { if (close(pipefd[i])) err("close pipefd"); } @@ -365,10 +365,10 @@ int uffd_test_ctx_init(uint64_t features, const char **errmsg) */ uffd_test_ops->release_pages(area_dst); - pipefd = malloc(sizeof(int) * nr_cpus * 2); + pipefd = malloc(sizeof(int) * nr_threads * 2); if (!pipefd) err("pipefd"); - for (cpu = 0; cpu < nr_cpus; cpu++) + for (cpu = 0; cpu < nr_threads; cpu++) if (pipe2(&pipefd[cpu * 2], O_CLOEXEC | O_NONBLOCK)) err("pipe"); diff --git a/tools/testing/selftests/mm/uffd-common.h b/tools/testing/selftests/mm/uffd-common.h index a70ae10b5f6206daecc8e19ed3e3bbb388e265aa..604e3572fe17280ae346b031e2e867e039578f95 100644 --- a/tools/testing/selftests/mm/uffd-common.h +++ b/tools/testing/selftests/mm/uffd-common.h @@ -98,7 +98,7 @@ struct uffd_test_case_ops { }; typedef struct uffd_test_case_ops uffd_test_case_ops_t; -extern unsigned long nr_cpus, nr_pages, nr_pages_per_cpu, page_size; +extern unsigned long nr_threads, nr_pages, nr_pages_per_cpu, page_size; extern char *area_src, *area_src_alias, *area_dst, *area_dst_alias, *area_remap; extern int uffd, uffd_flags, finished, *pipefd, test_type; extern bool map_shared; diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index ed68436fac62c76e2ca7060c661487f2f8a6ab45..ec842bbb9f18e291fa51de0ed8d1fbf9aaf14372 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -179,12 +179,12 @@ static void *background_thread(void *arg) static int stress(struct uffd_args *args) { unsigned long cpu; - pthread_t locking_threads[nr_cpus]; - pthread_t uffd_threads[nr_cpus]; - pthread_t background_threads[nr_cpus]; + pthread_t locking_threads[nr_threads]; + pthread_t uffd_threads[nr_threads]; + pthread_t background_threads[nr_threads]; finished = 0; - for (cpu = 0; cpu < nr_cpus; cpu++) { + for (cpu = 0; cpu < nr_threads; cpu++) { if (pthread_create(&locking_threads[cpu], &attr, locking_thread, (void *)cpu)) return 1; @@ -202,7 +202,7 @@ static int stress(struct uffd_args *args) background_thread, (void *)cpu)) return 1; } - for (cpu = 0; cpu < nr_cpus; cpu++) + for (cpu = 0; cpu < nr_threads; cpu++) if (pthread_join(background_threads[cpu], NULL)) return 1; @@ -218,11 +218,11 @@ static int stress(struct uffd_args *args) uffd_test_ops->release_pages(area_src); finished = 1; - for (cpu = 0; cpu < nr_cpus; cpu++) + for (cpu = 0; cpu < nr_threads; cpu++) if (pthread_join(locking_threads[cpu], NULL)) return 1; - for (cpu = 0; cpu < nr_cpus; cpu++) { + for (cpu = 0; cpu < nr_threads; cpu++) { char c; if (bounces & BOUNCE_POLL) { if (write(pipefd[cpu*2+1], &c, 1) != 1) @@ -245,11 +245,11 @@ static int userfaultfd_stress(void) { void *area; unsigned long nr; - struct uffd_args args[nr_cpus]; + struct uffd_args args[nr_threads]; uint64_t mem_size = nr_pages * page_size; int flags = 0; - memset(args, 0, sizeof(struct uffd_args) * nr_cpus); + memset(args, 0, sizeof(struct uffd_args) * nr_threads); if (features & UFFD_FEATURE_WP_UNPOPULATED && test_type == TEST_ANON) flags = UFFD_FEATURE_WP_UNPOPULATED; @@ -324,7 +324,7 @@ static int userfaultfd_stress(void) */ uffd_test_ops->release_pages(area_dst); - uffd_stats_reset(args, nr_cpus); + uffd_stats_reset(args, nr_threads); /* bounce pass */ if (stress(args)) { @@ -358,7 +358,7 @@ static int userfaultfd_stress(void) swap(area_src_alias, area_dst_alias); - uffd_stats_report(args, nr_cpus); + uffd_stats_report(args, nr_threads); } uffd_test_ctx_clear(); @@ -452,9 +452,9 @@ int main(int argc, char **argv) return KSFT_SKIP; } - nr_cpus = sysconf(_SC_NPROCESSORS_ONLN); + nr_threads = sysconf(_SC_NPROCESSORS_ONLN); - nr_pages_per_cpu = bytes / page_size / nr_cpus; + nr_pages_per_cpu = bytes / page_size / nr_threads; if (!nr_pages_per_cpu) { _err("invalid MiB"); usage(); @@ -465,7 +465,7 @@ int main(int argc, char **argv) _err("invalid bounces"); usage(); } - nr_pages = nr_pages_per_cpu * nr_cpus; + nr_pages = nr_pages_per_cpu * nr_threads; printf("nr_pages: %lu, nr_pages_per_cpu: %lu\n", nr_pages, nr_pages_per_cpu); diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c index 9ff71fa1f9bf09b3ae599250663a25bbe2c13b8a..2f84fae5642c6f91b75fbf5f5d59ae64a1c15f92 100644 --- a/tools/testing/selftests/mm/uffd-unit-tests.c +++ b/tools/testing/selftests/mm/uffd-unit-tests.c @@ -197,7 +197,7 @@ uffd_setup_environment(uffd_test_args_t *args, uffd_test_case_t *test, nr_pages = UFFD_TEST_MEM_SIZE / page_size; /* TODO: remove this global var.. it's so ugly */ - nr_cpus = 1; + nr_threads = 1; /* Initialize test arguments */ args->mem_type = mem_type; From patchwork Fri Feb 28 16:54:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996777 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 036F8C282C6 for ; Fri, 28 Feb 2025 16:55:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41C716B0095; Fri, 28 Feb 2025 11:55:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CBF16B0093; Fri, 28 Feb 2025 11:55:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21ECB280001; Fri, 28 Feb 2025 11:55:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F3B416B008C for ; Fri, 28 Feb 2025 11:55:09 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A8EE51C6595 for ; Fri, 28 Feb 2025 16:55:09 +0000 (UTC) X-FDA: 83169953538.03.A4306FB Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) by imf17.hostedemail.com (Postfix) with ESMTP id CD22E40002 for ; Fri, 28 Feb 2025 16:55:07 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zdmw1WB6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of 3aurBZwgKCIsyprz1p2qv33v0t.r310x29C-11zAprz.36v@flex--jackmanb.bounces.google.com designates 209.85.221.74 as permitted sender) smtp.mailfrom=3aurBZwgKCIsyprz1p2qv33v0t.r310x29C-11zAprz.36v@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761707; a=rsa-sha256; cv=none; b=yc8PRzPgKI6zOzJPAKvAE92JoSMsNL83Pi6+6RQcCsB1Zh0oJVOpZmb/eQarTHpsLg469k iarK9R4/dRMZkiZ3ymRo2reE+bX1VTWYhHphjwCOb8jlehJNo6vKbqCCUtkCT55CYzfWmP FoEURkX1eFcitwwVAlWq6OzF0S+9gSg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zdmw1WB6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of 3aurBZwgKCIsyprz1p2qv33v0t.r310x29C-11zAprz.36v@flex--jackmanb.bounces.google.com designates 209.85.221.74 as permitted sender) smtp.mailfrom=3aurBZwgKCIsyprz1p2qv33v0t.r310x29C-11zAprz.36v@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9d0/khHAO5zgmsRDUqio7iG7quhZmE2f4ksjxnf1MHE=; b=SWaBSCnbkattqrku3Ac6uYrLcDQedOAMKU84avHAIvz/873uG5tamn6oRSsxZCEfDKpPg3 0ANquCbMWQuInb8c/RDBvS+RLR9W/NHEIjLu9XzlYMXSZWZvw2RmUhrDv0pKHNfmdMPKO5 bz+dp6+J/aFp7wYaP0kPvZSUxn8c7P4= Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-390f729efacso32764f8f.0 for ; Fri, 28 Feb 2025 08:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761706; x=1741366506; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=9d0/khHAO5zgmsRDUqio7iG7quhZmE2f4ksjxnf1MHE=; b=zdmw1WB60NfZOtPnQ8LSPK95IWau3gLtkzPtsCxwvh+oEaY7jzThnQ3D/wTYHWS9Qd K6HyWANp2wZywmRX1M+itAgPDhtaG/kHw6M36Q3Ueft1guBh+x+wndm5OE9gzb3qXjzm Uv0VrZpQgN1jgdT7oOBD9BhQcegituuGexRkYSSOQAQQAd+TNP90qQMFEFBvjyW+WhNL 6L+pCBeCRTqpjq5hFUNJfQkoh5FfuDRAAdpE4ZzE9DWuKalmJtAyWtfJoaDWS+ArN9vS KefiqN9oDgyPCU+iqi5436l0qHDF/dqEPgYpjHrjEXu9ulZV2MdFt5YnvYdUA6yL0EZj H4lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761706; x=1741366506; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9d0/khHAO5zgmsRDUqio7iG7quhZmE2f4ksjxnf1MHE=; b=cJpV2HfDGZt2lL+OhJuH+YCaqdliyzfz1cDWypcMUpERgSPFSzgDuCGfFGFG83jjIT 4jICcxAbA2dOSjWzW0FzBcKa3uFN04R/Nnv/ORjkOBLCeZ15hXOJT8+E4el4k/aFjWeN 5mNMWeoicbRhYSkJCX2fNLXPsw6HUc/gAR54yGdZ+W/hJshQY7l8y6/EB2vZ6vDlWm64 d6vjiL/5ophGOdhZS26zY7ZLfwekogvpI2XNUKR1GnBiHpJxa0UJFFfzElffgok9jSMT E/4Q0HRH8PQVc9KQN9Xqo3aQCsES0l0/n5gJmzak7X91lKB1FV4ppvQXBeb9xiUk/VGW 3DWg== X-Forwarded-Encrypted: i=1; AJvYcCWHBJSg3rADUN8gKGq/Ix1CUbK9LSXldJpiyd7KYAjCf5PTozY2O41VR0SVVuPBG1kChi7qBLOhVQ==@kvack.org X-Gm-Message-State: AOJu0Yzj83cO3qILdR9AbpR/TvSHJqdFTdN6xT64jaZqY4jct+HJpH+G OAJKn2IK0+dj10voS9ESTHPbZy08G+/F4eFfuLAY9Fs3reypkOOQbWANOXulkWq54zyqZCf/x4I fzSemR3+5og== X-Google-Smtp-Source: AGHT+IG11sEYt2OnuCbnie6xNgIUE5IX6nCNDcxXVlZV0z0FMYzaNDcNJwgRdo42mUkZXMNKwRZc5xmL/K51cw== X-Received: from wrbfy2.prod.google.com ([2002:a05:6000:2d82:b0:390:dd74:bc9c]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:2a10:b0:38f:4d20:4a0a with SMTP id ffacd0b85a97d-390ec7d1dc5mr2770264f8f.28.1740761706596; Fri, 28 Feb 2025 08:55:06 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:53 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-5-958e3b6f0203@google.com> Subject: [PATCH v3 05/10] selftests/mm: Print some details when uffd-stress gets bad params From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CD22E40002 X-Stat-Signature: 1xxyx5c8y937kqa3wcu5sb61pr1bs4gg X-HE-Tag: 1740761707-71235 X-HE-Meta: U2FsdGVkX19JfzCdnZE2doD119YrLKZnaQI8pY573aJyA76IUw8lTK9sgGdrHdIwW1pK0aLSWZq6nbYO2VZ6ApZAYT1BBnKhQY3eng5q5zz2MeYrLt0R+PxK5sFbq6y/SPvGpdneccc9th3yn3lNke3iptk8d2hDo6mSpDHwtvoTKrV24Ur2fvS1I1EQ6EmHXpq0D8He7znrwcX88kyxYjfFzWdBs3FpMc3hssDj5w/0K2hSHwmbcI28+jETXinyICcYBrGBDDCIcFMpUpy0Fy8FArXKNa8+O57p9u8ys9xDapYGWtfv4A93ZZTBroJVhBZ9Axpm/gEv5QeJ6roN5eFIfy/AeUcMHd8jUKUUs5sUHptSMEFENNM09hFiqZvkf9gYCm6ma0hHtOM70yEQtYBLvLAX+CjepjLb/VmV8+Rap/a4chJjcJ8yPLZoI6W/aL/U56aEyK9BPPEkP01KM1QzYMLh72dQrSeeCrrNZNU6+nsSmmSho+JQ/XVlx9I3NDBVoYLNICGrBYOWAmXeafx9JsoHVKgU0DC195Kji1Qjed873/HwZds87fPT3dSzvHQvOOEzuhAmJdXFb2TVxY9YmhLlCIEe27Wzo6ZYG4uwGXywFrxExC0sGoVV3U1VlWDlrqYnSXBosqukyicx++YwtXqcgGJEolEAkTT2+Km3ujAaXr4ckl6mhYEDBW3sUv1SwkDLSD0ScB2l88HjfV4p8LAxKtkFsu3l72S0gHTansYa7Rybo5t2dYz0z3cHpwsFAtTypeEsuW1g4RGolGMDn4Eevd8VaOMfuM0c2XZS2BBCjUMe4GjV4Uck6lHTIRK1pnnTCFyK1rLXLLhTNbt8CX1IFVKq06aLSmaC2O+UY0pGvUCz7uGB7kUefb8BZSC6aZkngl1lqDJ9c2baiIfTiDWosoTneuRzjP7h8l1y+/3T3qe8Gk6GIAheG15KOjFi38COB1d4wyioY59 /eBPtvqU lSavJGMM0lEYQJ+ZSKHI1igrzVSakOQ7QYL/miuyFWqUvlJIMafcjA2D9SCuVopLUfKaedJ2nmlqBlgzZi9pVeY2sYBqpkYw7NwFFZnlS4e86+TRn4xKXvmaVgXPeESjZUBPhUAu/HuSw/jHy5eTZSfoQ/q+Z3GJzcWa0tZU8TqHfSmB0OyJTxeZuPa12WNWqjukth/I9ftMA6HzyXHVRELAVw/0s9LLIDcCB7huHD1kNWU1GHJnLew5pFHbTPAlJ0iTSMlTv2DlxwH/uipcwPgr26xv+BXBHYdpdM5dGUQjq7cy0JrJm2j4kAfb20r0vAhpl6TyZpOgVzcwM8rlAb6fBqtHYIrbhY+pDbnRyWlFReOS/OAzdEdCshTnNGaTynYVKW2ewpUaI4IA3lge1Y6Wv7/pm2+KEJH7LBQPih60X7oytscAaRRUIkooTZYICw6GOp6HLgDO1Db/5xJLK9W15b8WlDnxV0OUqFI8/VpG8skobvpe5EERujyJnL1itTHz1+dq4NTPU+L3NjGgE6MJ0mpSbGM4Mk1Rio7XCNxStKH96tHbYsa6waA== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.454104, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: So this can be debugged more easily. Signed-off-by: Brendan Jackman Reviewed-by: Dev Jain --- tools/testing/selftests/mm/uffd-stress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index ec842bbb9f18e291fa51de0ed8d1fbf9aaf14372..efe2051c393096e237d942c04a264b6611a6e127 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -456,7 +456,8 @@ int main(int argc, char **argv) nr_pages_per_cpu = bytes / page_size / nr_threads; if (!nr_pages_per_cpu) { - _err("invalid MiB"); + _err("pages_per_cpu = 0, cannot test (%lu / %lu / %lu)", + bytes, page_size, nr_threads); usage(); } From patchwork Fri Feb 28 16:54:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996778 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA6CC282C6 for ; Fri, 28 Feb 2025 16:55:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50AD46B0093; Fri, 28 Feb 2025 11:55:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49157280002; Fri, 28 Feb 2025 11:55:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2979C280001; Fri, 28 Feb 2025 11:55:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F3B566B0093 for ; Fri, 28 Feb 2025 11:55:11 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9C996C0EE8 for ; Fri, 28 Feb 2025 16:55:11 +0000 (UTC) X-FDA: 83169953622.27.7519E53 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf23.hostedemail.com (Postfix) with ESMTP id C683214001B for ; Fri, 28 Feb 2025 16:55:09 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PY33vEU5; spf=pass (imf23.hostedemail.com: domain of 3bOrBZwgKCI00rt13r4sx55x2v.t532z4BE-331Crt1.58x@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3bOrBZwgKCI00rt13r4sx55x2v.t532z4BE-331Crt1.58x@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6xd35kCXpRSECxF8AHgzbuHae7VKgf19dDjA8//S6B4=; b=0X+2AXQuGo/AQGx2WFxcMycOWEuq+Ugu/95Q7oSUWt5Iedv2zZVFKDmquBVx9Pb9z6hmff 7IUOMdhe3LEZ3YpQEYMgESQDv+X8diVLOICj+AqbLPH2apS2hEtMf03gwxYjHWShvLA5qn qrLzvHgCZfun/tU/ggciMNfkHidyx+w= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PY33vEU5; spf=pass (imf23.hostedemail.com: domain of 3bOrBZwgKCI00rt13r4sx55x2v.t532z4BE-331Crt1.58x@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3bOrBZwgKCI00rt13r4sx55x2v.t532z4BE-331Crt1.58x@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761709; a=rsa-sha256; cv=none; b=wbrh1fS7gRKUS1yQXjoRKucOaNvHKvnpVCVi2d7SNKuGrr6fkD9e1edT0rNLIZjPvZqpo3 n25rvA4kWjUC/AyMzX7GQPb4QfSvd5dRgB6TK0dkmcsqyN+NoUQDx7pyJ0irlJODsaWnNP xZbUPHA6jWDlLXn9u418yxxPCHf22j0= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4393e89e910so13767985e9.0 for ; Fri, 28 Feb 2025 08:55:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761708; x=1741366508; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=6xd35kCXpRSECxF8AHgzbuHae7VKgf19dDjA8//S6B4=; b=PY33vEU5R/L8IfcYR8S/YZebRfAtU67WzVZ8PtnOg8ZByxFlQc2HyVKqM7cOXI6eav BE519CR7IKNAqR8edKlCuAzXLazHMySJGJDHxuDWFrqBY9ejQxQAaFAPlsTqeBAhxEqI 4VjnhMVFcFcj/7WBzYDD29bMyFT6O8sTuzWiOwVD71+QQGfZGofrdUmA+kFMzKwYqOfa j/PnFGBp3uEHfMS17L1SekQwqnp6sjAYmj2PqFoOWl9TFu3FLonT3r/tlvghyi5V0YYz GzjjOXAgrBJma2Ab0okYavHancbUVqpYetU0p4FMdV2EkkehH2Xta7Fr8qWgzVesxZUA G5vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761708; x=1741366508; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6xd35kCXpRSECxF8AHgzbuHae7VKgf19dDjA8//S6B4=; b=HGMo0jBsiPDfaMoxZfz23ayAWoitIYwNtScdLcS5JI9t3zUwg4b+Yygcfl/CVZg/i+ /H6MZWmK578FtQgwThXMmqFrQwLIVj3961ieFtq1Rj1GV8cb4o/CJfeXfUH9pSIsw+je +/nMPLpCULXA665yG7BO9kxmjbBMWcaIqy6pNIGCmS+m+v9BYPUfMtFa+8oCpyutnPxZ hvhLisIVEED0qmmz4YCr/7jMZ4xUYraeJWYFugXkeDIPrZ47mI2fDszngKhaTFn9no+w eyTx3e2Xy5uZpBZ2RJmcCPYP22bXMUsGNyijfK5PZ13Vi81BbnkZ/fArtrUe4fUFUmvV QpuQ== X-Forwarded-Encrypted: i=1; AJvYcCW9QiGSNx+M3uTHje84bJj6gIXRJyl7IsI7wYMrLxPlQlOVkRgA0I38pPu3e8Gm+ochRGu4r9rH/Q==@kvack.org X-Gm-Message-State: AOJu0Yz+eEfG/zhWRvihWdSJQBw80wesByrFJapXQosGukF6JeRAFQin +/aPFQ/ldtYA8whgUIh+s9DBbn1+HtfJK/pXj7PmDALozqAVj8ZqvhHZHrv0zw/zcFvE0gtgyfA 16uNt7FbBSw== X-Google-Smtp-Source: AGHT+IH0ZM4UbMAKoXYRYVdsI8CLX+kx9xcCfgVmPw0K5PMtIeLgyJejHV/DAB6TfrrXG9WhtZl/va8I0oxrQA== X-Received: from wmqa14.prod.google.com ([2002:a05:600c:348e:b0:43b:6943:f013]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:444d:b0:43b:8198:f6fc with SMTP id 5b1f17b1804b1-43ba66e6d07mr42105885e9.11.1740761708569; Fri, 28 Feb 2025 08:55:08 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:54 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-6-958e3b6f0203@google.com> Subject: [PATCH v3 06/10] selftests/mm: Don't fail uffd-stress if too many CPUs From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman , Mateusz Guzik X-Rspam-User: X-Stat-Signature: 7zi5y76jmohtaqqs8agw8zn5fpa5fwsb X-Rspamd-Queue-Id: C683214001B X-Rspamd-Server: rspam07 X-HE-Tag: 1740761709-733720 X-HE-Meta: U2FsdGVkX19sTFpFu2gbh0J7XUfkiw0z/tpjEhVe/UKhf38EDwfeLrl9kwBf6yD13IvDgohv9+bPpLN1jx74vA79RV95qi2Fl+xP7M3saMn8b8MMT7RogZTWpRCuvSdoOjeZ3QWH2EuFgSX2yAwiypEHeeWYIMyFhGrqS7V3c4wFzo9b/BBgbYnHk0XxIJq5gnP3rtFdSQNHho86x6dw5OlAvWPFLbDnf3wMaISnlIv7XELh8fNo+ZhGxGHLCnzOciqORZw4+AGgs6lNQnZiYJ1tj7RYI7CflUdnKL4S7kvb8q1guys4/WxhXnLJnS4PNukeYgx/GK25tkQqCZhw5f3gY1OeUbJajhplWfrWh/YT7mAmZtWdq0fELiDxHZoU88EqChCgpAn7KQkR57uu9EHWy/DBSUrQo7xT3D/WVUTX37A5A/BZWEuAnA1GGr+IY4NXiTTCEa0sT6zPt66lqjNOFCi0nhOA8aJV225ZEdnyigU9X6hCHJnN0lgvJZxxHoZJCUhs2I+oEVS8eMyVqjYpPM8k9ZmUpbQCpozdq80ArWRWTudL0X/eKYGSmTR//1aUmRf3pFoKJYV7TVanTKG7+jva/mb0CPDVwbvsNxQZphf97cuB4gFWhsQdj/whZpdnyqY13BQ5MpbeEvd0CBFZBDQJX5Nj0K1KfJX6sLFN1/6eeoRHQGKn7I3k6zJLJJINj4RBjZLyOb3j+s7geQLCLA0hd+tbsA19/uXwokUZDAyV/6z1gpquqAnKs5rokAqlFihOkARL1J2nX7fiDYNQSxvM1Q4+97xeUWQJipLw1bq5Wjf0/kXltgpZFfVwkVsCoV8PnTzp0yZQ9g4gdPmjWkOTzUkgfPiY2A+No3Vj4Rq6J9dWkFPTWxuRAEERZCjOKRcUQn6HCbSFL+i3tvaIlUsbARE0POqWKa0r3epl6NL2VXxkItApQ6QYMp8orFZbe/LVJRhOr1f5oPN kTpKUrvJ 0RqE7BuyJh36Pgmxm+e80PjPkeCh+b3ZWkQn8OQgbNBixKSuboX3LXw1ns+J/7KY7i9On9we46NLA+E5zTsAxnN+TvTCkIz31sgDqdD2dDNBe4+PC/oZA5ZREeJugRxTOrWnCMK0g9UbQ1de1QeVNjmzcUb6EYGT70mpDHG2yfkHexgDg6VQn3CYalNY+7wK6GxEDMIDinR1TcpWHCTFURym8IfBwCGwy/8l9vW4AvyibgQbDhaX8O0VKKKb8C2rGAHA2m0FrULNaLClA0NIuJOK4itr8Znx3E8AL5uupE3btG/Gxfx0InCDpm2aVK5ri6cY+pvnAyzSFmHKkzcTPphqzdp8CMb5N2ZKcd/0CZ3AWNCbwK4qlATqaWKKoPIi6XwiAxZ1P8gJvwoVTHgx8SJ+AyRkP+21k/aXtNXtFg/oxGEZb6MVW0aoF9F5iAcfxR5nL/6aDPORrwQRkYrWZbVuUbREH9dWxvHeivDDnOKbB7m8UUEYqNnAZAUxfGnU+OiyjvQD5KNiTTCAr2SOy6iACtbwc1HBQQYgQt4+QkXjR2Pbel07oJ68RKTddzslrmgjerGhAaWIaH18= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010455, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This calculation divides a fixed parameter by an environment-dependent parameter i.e. the number of CPUs. The simple way to avoid machine-specific failures here is to just put a cap on the max value of the latter. Suggested-by: Mateusz Guzik Signed-off-by: Brendan Jackman Reviewed-by: Dev Jain --- tools/testing/selftests/mm/uffd-stress.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index efe2051c393096e237d942c04a264b6611a6e127..5656128590373ed376b3b5d9259e5ca3867a4099 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -434,6 +434,7 @@ static void sigalrm(int sig) int main(int argc, char **argv) { + unsigned long nr_cpus; size_t bytes; if (argc < 4) @@ -452,7 +453,15 @@ int main(int argc, char **argv) return KSFT_SKIP; } - nr_threads = sysconf(_SC_NPROCESSORS_ONLN); + nr_cpus = sysconf(_SC_NPROCESSORS_ONLN); + if (nr_cpus > 32) { + /* Don't let calculation below go to zero. */ + ksft_print_msg("_SC_NPROCESSORS_ONLN (%lu) too large, capping nr_threads to 32\n", + nr_cpus); + nr_threads = 32; + } else { + nr_cpus = nr_threads; + } nr_pages_per_cpu = bytes / page_size / nr_threads; if (!nr_pages_per_cpu) { From patchwork Fri Feb 28 16:54:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996779 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F2EEC282D2 for ; Fri, 28 Feb 2025 16:55:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30B946B0096; Fri, 28 Feb 2025 11:55:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2956E6B0098; Fri, 28 Feb 2025 11:55:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E85C6B0099; Fri, 28 Feb 2025 11:55:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DFC7D6B0096 for ; Fri, 28 Feb 2025 11:55:13 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9AAAC160E99 for ; Fri, 28 Feb 2025 16:55:13 +0000 (UTC) X-FDA: 83169953706.27.4B5A619 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf22.hostedemail.com (Postfix) with ESMTP id BBCF1C000E for ; Fri, 28 Feb 2025 16:55:11 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0dG2Xuoh; spf=pass (imf22.hostedemail.com: domain of 3burBZwgKCI82tv35t6uz77z4x.v75416DG-553Etv3.7Az@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3burBZwgKCI82tv35t6uz77z4x.v75416DG-553Etv3.7Az@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y083FvFOZYoCnUIFRlzf3KdIVhM7Xy3dpgrJnz1PRMA=; b=q9qQtNjKiM3pEALUm3GXvA53R3l+PVbe72llbNR/3zXx4nzdkveawBDYGgEYUC7JQvUwUf 1yUQ9hsQPMcjsfeD7k/BkUcttY5Y6OKYSSR0iiUA5i/IdGunq80TT3zBReXN5g9EIl6lxy 2rlVkmvgK/M7uhFI1qTHZP+NudqqQKE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=0dG2Xuoh; spf=pass (imf22.hostedemail.com: domain of 3burBZwgKCI82tv35t6uz77z4x.v75416DG-553Etv3.7Az@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3burBZwgKCI82tv35t6uz77z4x.v75416DG-553Etv3.7Az@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761711; a=rsa-sha256; cv=none; b=13/RivAF0LfZmIIyHPIHHK9cP4Iml2N2o5iCbWHr47HgpQ7lEyEjyy483o64VipcFdBUEc xZMItfhPEi4MIXqBFDusx854kKL3TnhbUoL9NXD8/PyQOM05YMc3iYbFaMGJRLCqQTo6y4 CPcTcb9r3qe6STt2huUItM4PENeTr7w= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-438da39bb69so16883745e9.0 for ; Fri, 28 Feb 2025 08:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761710; x=1741366510; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Y083FvFOZYoCnUIFRlzf3KdIVhM7Xy3dpgrJnz1PRMA=; b=0dG2XuohT0O4zF+FXrjvSF5lZbYe4GWo/F4Dw4Hmpn1GD+QPsA2x7Y46WKO0TlI+Ci X6v4LBXBNWY2iLjE0NiM+wTdUt10JdhXGrvUT7aYHHLQ8pas77sXf3eNeZ0SirV7ClWU cjosBjbdvlXqSkrIGLk8yK1NRE23eM8PzvcUh+kCpqog/N6r5kaXIQS/SG1W9U17bZmb lztiLv5WoCaRs+Bw+CcfFaaucNIeTl3aHfcEq0Dpi/wHrJ5TujvDBqVjBWdTBAF1bKFK VueTYZ0O28ci7JcsPFilj3LUA/G6I/6KQp3cW4zRnr5K4rsg9NQIi7W1Vd2SsovYNizK z5Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761710; x=1741366510; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y083FvFOZYoCnUIFRlzf3KdIVhM7Xy3dpgrJnz1PRMA=; b=VO1ipGbaptadkD+NhmKp40GGTnhVZedhVsXxexrsBc+V/vYVdKD1vTX3KUpUr45HDx xy6p/MG1xnF1SyZWcQh8JCwNDHs3eL0EApFsITcWHDNg7UbW58DU9s8RqDU5IoM6ReyG o4BGDi2ipnZRiXgaleUwtGh7nJhk3HqSXqVHYgyo97u5UwJ4yq+vglEExq2ncSVF3BVp 5wpuyFcBcuFO2dTYMFrek0OYd0xj8TZ3/e3iBsYIXuhJIeIM4dJxmUPjmprNB4ks/dUi G+Xu5bILb68ZSJ4uVyYeZQ8oZHtndvOtLaWNyAKHu0W3t0/mRBj1q2SWoVyMdcQPdxgj lKug== X-Forwarded-Encrypted: i=1; AJvYcCWAzkSS/intmQPLrpM2GXUVhOoBPHgFkHC9VJeR4r14PWUfxkypTtmdAGJfMTBSXGRxzzCNXVh96A==@kvack.org X-Gm-Message-State: AOJu0YyBMplV7dQMuJe+HLZYi68YcYSjHa36Bzye9i/8BUNltjKsuxhZ cHyp2hPM/Jk5ycjKkLLeqDBpMGZXoxLWb5DInp8KHyjk9zGCxnJv0TtiPlq/xM3keEiFJoaN3Ir b/GvTAZR1+w== X-Google-Smtp-Source: AGHT+IECfVJfBnP7dSUDnPjhj6/A2ktPEKiVIkWG9TWFGAz0YIN0dg2dmHqMiFJ6AA8ejEBgQ+HIjLpWvE2+0A== X-Received: from wmbfm10.prod.google.com ([2002:a05:600c:c0a:b0:439:81e4:9ca6]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:154e:b0:439:6a7b:7697 with SMTP id 5b1f17b1804b1-43ba670fb9bmr36911975e9.14.1740761710535; Fri, 28 Feb 2025 08:55:10 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:55 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-7-958e3b6f0203@google.com> Subject: [PATCH v3 07/10] selftests/mm: Skip map_populate on weird filesystems From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Stat-Signature: 5iihxqku66jc88n55kcyu38xxb5iybt9 X-Rspamd-Queue-Id: BBCF1C000E X-Rspamd-Server: rspam07 X-HE-Tag: 1740761711-657374 X-HE-Meta: U2FsdGVkX19Q3Bmt4Tihn7DDTPUIsEZDzs4z3DDNontcMLnuy0e0v69VcsENzncKQbyLoWnCH0TqTKguL0G4mb5yESe92MBe4WZbxUkKsiG1VtMpW+EsQkDnSnvb1KQrAuueyQ2LwvN04PZycU+3QmEXacWJcwu5KbEDOLgz0sEi7EuqTjrz41afwoLM/tfpufHM1gLugd3FJhFBKbEuMxd3ipQqPFXXKHSA5FY+Fmor+bdfr+EFTK/Ji7hhru45mYpx9agM4Gn1U+OcGjf453qjrJb2BTL6GHrjt332xOHtyd6Rl6V1ukR6/6buUNeAGPYz/rEXwf9u2F8oyNGEXNDgkD1cyn1QKZJQ6htgmjWQ2OhlTuCsFQTlHj1kgzl38g8+WGlTtHxfzQgL3kTBKKGcbBI1lHpxSeNLfY20klDME+DmZoezycxbYMvxgIpeVX9L8hv8fzXYOV8PL8xO00F02BQO/qR3MFHQ+xLIQ2cArGwqgr2sP3wPE0nhM5Yj0gRHUkdDbNoeitnw9QIGVTrKCvKrF8o1XORuH6Qbg4byur7UdPbMHKS3zWAffZeIn9E0sRJHcCbka0D07vVahKNxmkP3nyzxxVSES4WoUbqzXWkZEINSgbyJZaXwaJCwOCnWI1SiEzXgMIcg7PYnsxrgqCj7YudRsrueGgSVkKw6xCpH7TxiVIkv4kEs+ZQeGNas+hkIH4QArltJvoaumUC4EvEH+HXrVI4xH/R5khNyNXEotdstrUFpItPAZ7+le0Az7otwdW21VhjSFe6cdSB+5SBo3mk8/NhIngcfFu68aQgtLHYvJm8ZaVCUe6szKVKw5t8GW/hjXqEo8q7QjQaDy+gv47Kyl0CfpfpWq90l7ai1L+1JPO+mHF94g9+d3FdLOr1iyWKn2vDNsA71IUC3zjh7HaML5ibWMMiR17iVzkUIbki4kaAM/isGcwtvJ4kSha7mc0EW3feeetQ QCoHkuXA E3WCsIZ9w8CvxCJ0q7DttCNL5X896LiGOfLS+Ug8jqxK7NtXRCi0uB7DoUpVpHkBNk7ikwj8HFxrBaCWPNCkyKOAj0p/OnTGMWoW905x11WPT0ky6y52gyBmRSKoT4s/91KdYVqHSDgBOeNJuy5IL5pIcxDCKUrajrVNAUFfTGANxAZiRyGLbkZ7A36yhmRCU86aR7g+k84wrYHAOVSw7euegIIt3BzOaikS6w1ph+okmWEtE+SLvMgaB0ZopiG9EgBGtd6q9eEHGLVQYpa1F2COXQ7bDEdhDIff6AqvextRIcuGhJIjBjD7hAZb7pT3PEz/DBNJ8ArSKZIS2wrqvp0zj/WeRVTTpQWhf/UzGoAwB6rSsYdjVcA06LVPEnCpd1tXkMFkP7r2lQOGxT4gFK0XbKk43LxAL8CAcMVnK8y5dvbyr3bqFLolE9tTPBfu61N9UTPcxJLzyYI3IfHJZqiS4qYoSEN9wJfG7PrBkP8UkKf81zkJ1w9m56egXBB9+pURILG5pAT7pOY96OZXAT+00sqnIX11ZXCIcsC2vImS2iFrb66dQrbUgjckZCHfAyYFInzOYIjUVRsr8mB7WSeaWvy4OlRBWWhIxanajKOndWKw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.162664, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It seems that 9pfs does not allow truncating unlinked files, Mark Brown has noted that NFS may also behave this way. It doesn't seem quite right to call this a "bug" but it's probably a special enough case that it makes sense for the test to just SKIP if it happens. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/map_populate.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/testing/selftests/mm/map_populate.c b/tools/testing/selftests/mm/map_populate.c index 5c8a53869b1bd287b09a250edf628a66c25c2439..433e54fb634f793f2eb4c53ba6b791045c9f4986 100644 --- a/tools/testing/selftests/mm/map_populate.c +++ b/tools/testing/selftests/mm/map_populate.c @@ -87,6 +87,13 @@ int main(int argc, char **argv) BUG_ON(!ftmp, "tmpfile()"); ret = ftruncate(fileno(ftmp), MMAP_SZ); + if (ret < 0 && errno == ENOENT) { + /* + * This probably means tmpfile() made a file on a filesystem + * that doesn't handle temporary files the way we want. + */ + ksft_exit_skip("ftruncate(fileno(tmpfile())) gave ENOENT, weird filesystem?\n"); + } BUG_ON(ret, "ftruncate()"); smap = mmap(0, MMAP_SZ, PROT_READ | PROT_WRITE, From patchwork Fri Feb 28 16:54:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D8FC282C1 for ; Fri, 28 Feb 2025 16:55:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 136B66B0098; Fri, 28 Feb 2025 11:55:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BF546B009A; Fri, 28 Feb 2025 11:55:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E06F36B009B; Fri, 28 Feb 2025 11:55:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BC3296B0098 for ; Fri, 28 Feb 2025 11:55:15 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 870FAA31A4 for ; Fri, 28 Feb 2025 16:55:15 +0000 (UTC) X-FDA: 83169953790.24.646BAB0 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) by imf24.hostedemail.com (Postfix) with ESMTP id 9EDB1180007 for ; Fri, 28 Feb 2025 16:55:13 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NZ8POj55; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of 3cOrBZwgKCJE4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com designates 209.85.221.74 as permitted sender) smtp.mailfrom=3cOrBZwgKCJE4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HglWqqIMp4q4cEq0dB/S4fjKGgd6pGq+F619sE0ZgpE=; b=3vgGI3gRAvqzKl+f7FY1chvSHyBd3pNH/BBWTD2bBgbwDz0MMA94EnhLBzuyb0DBrw0Xuq Zo/h0uWtW1ggv0/jqSFxKvfsENcxpjH8F2GOhNkjvF57p19u6lEHamJjIV5fHbxz166akJ /kDOH3EmxV/NGZyGAKuSecyPSaX/lbA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761713; a=rsa-sha256; cv=none; b=XWrFJI/C2v6GufFeJP9A3c0MlsSuqxwxNOh5REIUFVmnp6QsiKOdQcaWvz8ZFuWgyvwtdc GKlFOGBlG96pNKU3Whk4A8Y1S8I/8Pp9GrOV/khQp8Boi304JjYs/LkDH5co4/2JZVb+UW xdclFWP9SLSru5OfBEuoz31xmujWpnE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NZ8POj55; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of 3cOrBZwgKCJE4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com designates 209.85.221.74 as permitted sender) smtp.mailfrom=3cOrBZwgKCJE4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-38f28a4647eso1123712f8f.1 for ; Fri, 28 Feb 2025 08:55:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761712; x=1741366512; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=HglWqqIMp4q4cEq0dB/S4fjKGgd6pGq+F619sE0ZgpE=; b=NZ8POj55/kyMRbHppPAVbXYwkhMSunugw6s43JM1tFj/xdm4R6/vU/vssuNhENJ1WR 8kJPMAoFZIpOtvRwf1hja36hh8p5nTkMKexLNZ6I+6qJWgDFcj4fc8XOQy06IHq7ORyy J27iWj96M8NWmggD0SU8Djm2kgxpuA/Rk/yy/gFBssV3pFrxVojCnc5OGtxD/LL0RfK8 1/ZicFb/Ab6vlU/sgKS+ufNfH6A5YtBCnJxE+qhE6LNoVSr1K1KYNDQv/AXZp8GzCnuQ ha86EOpJs0QE7dPbubAWgI3QNhsPzJsy09hhdyDhCRmXlMRdwF/A3n0OZ2lHO5f/l336 N6VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761712; x=1741366512; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HglWqqIMp4q4cEq0dB/S4fjKGgd6pGq+F619sE0ZgpE=; b=rDxMhH6wTlyYOuPsln9O1soK1fMH4gqcpLqEKsPrpnAPbxymY9bEYAdfGsVMUTIh7S PUiCawfwtqwHuoBMr30uYjOMCEsXp6kzn9zI4+ZsGKG+LdMlN2bpe3kDDihgOfzh0981 xVgqVtuw/o1c//X5huM3wFe1Pw9hukVw8J+Av1L3+sccYaBKW/UWBmCRZlRx9gVb8UJ0 BauBGqYkK7zkRnxBQHuCuGGYaZp9l0CU12UYNwneHK/F56FTGvnwDnhqFKqvKCbHDYVX ZXsXpD1ZGI2bJGwUtSIHcYjHnEsv7BcAVddxp/SovI/l8VLANRgo+U6i9HGkZTeGnmt2 97iA== X-Forwarded-Encrypted: i=1; AJvYcCWCT7aIxVGUCpWQMLSZ0ytQJFDeop5zI9Fpqn54jIfoeJVHHsIUn4LwDjRgBtQzq0dUvDwjurKEpg==@kvack.org X-Gm-Message-State: AOJu0YzxkHIEiakTMe4rbEFOUi+g9BLFTq+Xg5z3N2U6y6HT6B5ZjIFj ZYfsDwGDRK01qJ6yPGZCiuOKpftYt7oLgljRhDWH6YLRBvNM0Dofv9R7FF2/VL79SEYb3ScI96s uKEME5oy+wQ== X-Google-Smtp-Source: AGHT+IGyvxBXVKudgTqQT/Sz/ZVkUrhVlfUf3CFkBBjkljVRcLXxIDlIjwfcGDVpOf7sFqUfT+P2WC7Tjqu3bw== X-Received: from wmbbi6.prod.google.com ([2002:a05:600c:3d86:b0:439:8688:5f9]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:4409:b0:38f:3b9b:6f91 with SMTP id ffacd0b85a97d-390ec7cb9bemr2080325f8f.12.1740761712441; Fri, 28 Feb 2025 08:55:12 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:56 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-8-958e3b6f0203@google.com> Subject: [PATCH v3 08/10] selftests/mm: Skip gup_longerm tests on weird filesystems From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9EDB1180007 X-Stat-Signature: zgb691xrt7mpog78py4itf1wtnhwcih8 X-HE-Tag: 1740761713-858811 X-HE-Meta: U2FsdGVkX199qGZ1HbXUbPZtmD//EV/xt5vbTvZLtsfk1BnM4OWmyExRV4esPSsoanJ/d7MBCoNVO+wCn5ZQbUCnFLxB5r0+VlpRcxQUfv02RovtAHGgDtsao6uU0ja2+kGTLQRSHHtWPg2UxS5FxWtmr+I4GOD16RpV7SeetEUnkdzyRmeZyE5MgXeikhfIpKnrMZC+uX/kybnPw8tle9cm2LH6jvbjSJ5IqgZG157TiCdQmPRPU3QmyNcyNKIBf7ku04iHodtNbLY3b+thKy8Tj/ILRTsw5l4m10VFakwZwXBiAMJaSTVTRjk4TEOvYaZ+Q7JNLsFVXsfma3UP0pX5Fu0c8t7upjb563o8s7S/Qw2OfHJc5qQHY8/oPMWEfTYZvCqKBgaW6Onk74VzaeI7oMuysejFMgyWNqVUZKY3BZk75Aczp9scXQH5L5M3WrEsvPTD7mJYgtyf8hdiJyzH4TBcHye6ZnJLSCc5RgpDh4e4NkN9ZFhfJ/wLortdfh0b64mTwEP60LZ7eSt6J11ex/pzhs0aoLv0fYyJkpDyxi/HUx2w8YHAeIkIShTSc5PXQ/VKJwqU9/yQBFRC4RtNx73BXfMcG4AI0B9n1tDIHZkz+VbB38OqcfeDCytijnvuKjWabVXGL5Py27l+PlMJE0B7IqerG5PRZUOl86zso+cS7Et/ux/iWTRvdWAD4mf2lObr5282AMK0gmOGqCK0IGsAh048eXVVWMUH5bGTgyV3USJWvnaX5BBXOqcbApenmkFrSTvBlG4+cVcZLYnMGOMVSw1JY0ut/cZNpAhh+eeTJuM3dBTmN1P8HDmSgzoqYqnkuzQGiwp8w3Cf+uGSIczgR2WmPBdK37deQZPG0D2Gc/No+/HTBWacqlch9c0fRmuGaetxh1Qdib0WiHPZDeNN5Pa2A5uyYj8Zm8z+mRQ8WjwMsapjQFOH71RiUlxYdHfPTlI3I+4hMH9 rTlwWY4x ohGgscp08YVzmDe9k7/XMsTYznXLOIYB0oIpLgO9FDsrnESpJQ7eSItz9ek9gOeBbOMl4iZa++sqx0CmB1rUNtUL2sJsBMS0CnX+/B3rnOULQQcSmaCZG40rRs6FyGDdURvjKoVxpuIB4/XebFgCg2NFWyIoVNUmfVXkyIjnIRNtY2Dj2WIwB4QR/uw6CjJVtrlm1XhezEzDqXNs5XSf3i2NoTZ3DqelT7CjRCo8ftn9bwu0K0doOMi5DassjrFSKA894EkkcP9i5btauDaU6j0/iu6dt9v8O/ZgoiI0QGDlAjRHdOMfv6vAjVYQYoPki/4Ah7IaQRHTXUF4yrUdKapMb2WaWclJJRdezteKpFaT++uTwNLV8jJspBMX1/0IL/keruqdOdxHQ7o0izPUlDZ1lXyBHuFRujg/uue6FYi1mXgkitX0Th9aymG7oTYRABTqCFetP0Ow09LsSUFXacEqd9nXWXSk1Hd4CuM0eaRi9JrmV1I6qGCkkqKVlmraoO3nfu1Dfmpljw9178gG4UQargsbVD2GB89Y86dYB2le3dXc8jks3/4F8xgutzXRpOXTTjTHJsKWl7Df5qqAGENcz/xTSXusG4AqX X-Bogosity: Ham, tests=bogofilter, spamicity=0.275937, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Some filesystems don't support funtract()ing unlinked files. They return ENOENT. In that case, skip the test. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/gup_longterm.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c index 879e9e4e8cce8127656fabe098abf7db5f6c5e23..494ec4102111b9c96fb4947b29c184735ceb8e1c 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -96,7 +96,15 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) int ret; if (ftruncate(fd, size)) { - ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); + if (errno == ENOENT) { + /* + * This can happen if the file has been unlinked and the + * filesystem doesn't support truncating unlinked files. + */ + ksft_test_result_skip("ftruncate() failed with ENOENT\n"); + } else { + ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); + } return; } From patchwork Fri Feb 28 16:54:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996782 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC390C282C6 for ; Fri, 28 Feb 2025 16:55:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 888FB280002; Fri, 28 Feb 2025 11:55:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83892280001; Fri, 28 Feb 2025 11:55:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63F79280002; Fri, 28 Feb 2025 11:55:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 35A27280001 for ; Fri, 28 Feb 2025 11:55:18 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D45DBA31C5 for ; Fri, 28 Feb 2025 16:55:17 +0000 (UTC) X-FDA: 83169953874.02.8EF3400 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) by imf30.hostedemail.com (Postfix) with ESMTP id F1E0380005 for ; Fri, 28 Feb 2025 16:55:15 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nq6OrHyg; spf=pass (imf30.hostedemail.com: domain of 3curBZwgKCJM6xz79xAy3BB381.zB985AHK-997Ixz7.BE3@flex--jackmanb.bounces.google.com designates 209.85.221.73 as permitted sender) smtp.mailfrom=3curBZwgKCJM6xz79xAy3BB381.zB985AHK-997Ixz7.BE3@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fG1J0iA3fwqq4X8OYjBfR+jqU6ued6Ezuk5An36D2os=; b=Wgzj8GsTa4D28Bgv2BUsI2rdAZ84cqKyvtJihN+RDnIR3s2qgYWOuke9dbYvztmvV/vAFA GvgBhbz+5uW7Ab4IirDbAHoizhaMmh90Wy2hmbXBDYUDMKArQ+zjhvUB/O7SuoQqElJL56 w/u2sEnHIxT4z01hRHpii0bR+6dJzg4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nq6OrHyg; spf=pass (imf30.hostedemail.com: domain of 3curBZwgKCJM6xz79xAy3BB381.zB985AHK-997Ixz7.BE3@flex--jackmanb.bounces.google.com designates 209.85.221.73 as permitted sender) smtp.mailfrom=3curBZwgKCJM6xz79xAy3BB381.zB985AHK-997Ixz7.BE3@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761716; a=rsa-sha256; cv=none; b=MfiwV5kwjqLJGfHE8puMQMc9XiD0twuZmn2H/Ezhq1FrH32P0ZmHzlafXt9FfgGhnKn5xC nNDsVVEbT4XnCpu+TdcC2wj/K32QNzD1a889z0CWPZcBHCgTTQouOHtxHvz/h4sHtuH3e8 X7c+IDfothQ8rxYW/mkUT3VijRi8Trs= Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-38f55ccb04bso1437004f8f.3 for ; Fri, 28 Feb 2025 08:55:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761714; x=1741366514; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=fG1J0iA3fwqq4X8OYjBfR+jqU6ued6Ezuk5An36D2os=; b=nq6OrHygEGCJ5kYqUpL44BkOVnZdfKvJa/lE0FCeTOKsbdFo1/esRU71z5LbDt0M9k HuoMJ3UwYu8S9WuYa+9ashsAcFaPP2xBt0OoB7tbromXHDCKrqM/NdarO1RTEr2XuIjF xtLQ1q4uR7GfjMWkcKqMLyXXAnPC/lypYNup+5QEKu4yUnkPuTDzuTi+vpjJgG0feAwc /+vq4X1KiTGA8u5KBR68shuzNs5GeDNY3qSzN0hr+xuYyu1L/rybHIxdgu3cBcq4BY2+ J1SydOAN9lawxdMcjjjkmdL2Go20i4Fv/3nOgN/p1vXUlZZHzUciAJ5ZEe99lbcrE5UG lIqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761714; x=1741366514; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fG1J0iA3fwqq4X8OYjBfR+jqU6ued6Ezuk5An36D2os=; b=knAtCZzTlpfE9gR39UGvwreR8mI8N/rK8bcFtD5y5K4wClDX0vSEcM7fkoUho8AzGu lCu+VAhsd32g4gnMNA3gSKY1QHwNz/S4k5LOk1Mpo0g7KEptJjYXCuWZduk+tO97xVbe rsqFMSjR/Ti8sWgmuK/hLGjkiMdWvN8C++EVQDlEgZBbZ/yqNuqBIg0HF56e8O3t3FjL /JGAqQ5nu8+9yy2WEehpQ7lGv+whbVFho6brbl1ijJBlpodoNKhqgdErNztIH7fcsXGZ SLZ0P5Wcb8gGr86Z9qDOpL/JPp5QsYocRRTMVDqL3iaEGbRWvEFg++3/2RH2HEXcvBeJ K4KA== X-Forwarded-Encrypted: i=1; AJvYcCWIDxbrMT8A56YYnOAQ3zoPnMutlIm8ml6xTiVkfBRyJazpvkeYYCDusmzQlpW8CRgky1QNQ+++TQ==@kvack.org X-Gm-Message-State: AOJu0YyhW7o2sB4lgN4SRqHKeJtL7ppNG6hJzSByl0CHNCSDkkZeaeei 4MWQZS9DyoCV0ZMBfXq4fR5Ndh4NnUtOHgKjJG90IViSPEZaE5RKNG15BlqazGvOMZ8a7JeftbX 0ssGuO12esA== X-Google-Smtp-Source: AGHT+IFhLHMyiWVhCEV+u6n15NyZd6uFVbQzk9eeDskhG0wjSB0nxk6Q1iAAywBZ/+yofpbEhpMwmSUf+cMMTQ== X-Received: from wmbg22.prod.google.com ([2002:a05:600c:a416:b0:439:82a0:5431]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a5d:5885:0:b0:390:ec1d:7e4e with SMTP id ffacd0b85a97d-390eca63baemr3464099f8f.49.1740761714665; Fri, 28 Feb 2025 08:55:14 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:57 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-9-958e3b6f0203@google.com> Subject: [PATCH v3 09/10] selftests/mm: Drop unnecessary sudo usage From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Queue-Id: F1E0380005 X-Rspamd-Server: rspam09 X-Stat-Signature: e4uacbwrqfytedk1x5kqmcp9sc19zwto X-HE-Tag: 1740761715-958479 X-HE-Meta: U2FsdGVkX18SiGDBx9RPv7C0X4MzY2jqGmRlhMHrgWDCJtLVUv7+XTMgc6RHF8jwPQAmfYbHcXQKsqalGdz+45y2C4w8s8x/ylIfmqkPJ7Jm9+M3ndMZk8ZyY1KFuMYV/kHRRBwpdqjvLsZ8M+q1rm4rzm7iUDx6JWfZ5Ekmeorv59VDW4YvRaN5UFn/FaJh3fY55g8kBGCMJHheab2Eaz2TV8pMpjiXt9UdmO++/tcNqTLVkGcTuNqscT2vimI7KN7gzvc27oALCDbC0hbf4sNt2M72GxGcDIR7KMrYaCo1J4f7u8C4CsT3XJL5NxyRm0qRoPi1oE7AWiw76+b6ubBOd0gUTcWjsla/dSGD5RjaS00e73qCfnL8BuISHdXyLNHTwgX1Dmrdkpf9ah0S5DGDQ7BjculDQX8SEhU92yZ+cSlPaQuVjkgm9n5Fu/Noc1iD91H8BWdhR6A9XwYlW+OsTByaRzKaBxtHTUAAfEvmMgg2Gnb+va7iPv6s5bbXEAoBz3FO4yGe5ihO5YDv6ZtXy8lVwFQi0DBVSaUh5v0Ejf02fmSdL9qloO9m9V3EzogHEgUsYtB3dYAeZzE/QmfFigB+hl4+l2XsS3cx17ZgOQ3xedj9hlR/QQT0KNpKrkQWOqblqHWLMojfPwMrqOkFFZVLQpgUD2vSB/LbCDbF4WDC6QiagmL4PA6oNbx9//qnOcQAeGuO8CQZmdlb7ib13ECHqLe+jTVCBA1fvHUBZmCE/mJOPGY2NDoKFPhaC4U1gr3wjJY9cbDufNxW8hFfC3plCk6sJI9tLCoIbI7gU0GDMd8vWBjPf+2UJzCXszHmXYbYiay5PO/5kUcjuI8/wI3dHoxB9F874tdEJdI7G2cNtuXVE8ybM+vTvPsvzt3aM/stzwZS/LROrA3LCADmi0Sdyidv12ftpazHWhy4IEFqBGzEoQhBdfr758p3f6kLMstLn5NCtr2AbnQ UcVmSJ3k zLZiArWI00e8grd56ekAMiYBz9Ucgo1KRfrmFYImLPafJMqXiL0glDT8w6OMIT3ooaiFQ6RQkWzsdj3xbTnylmWlQ7Sx67S+D9bNkm3mBPGbyLveLXjonqZ1WZQFo5P2Efo7HqvDUzjW3vACoAuWlpKnH7kOYzTJEjftSMWD9vn7t+Zk4sdfyJ690nwM5guZTv3+/wR9vXoFSeVc4b2ZOs6vgPpssVKMtnHdROpPMNeE/5sEqzHjVoVqTgMEy54nNe23gv1QXQ4L2VZGMPx76v9PTeFg/Y5gqViGtREXGNWKhEdt+BeaCkLJfaiZh/KVIXeO/cLInBzDOUggwiexh5FRs/SLKfiE/An9tDoVF3tUbypFr2hUIi/zklHawbtigRb6khnto/gLfMvWVwIeFcRFHND2uKIvEX1Sk25kZhcYpL/yOQTarzQ8+GaYQdcHy5oyNczpET0xT+MMiQOk0PczC/Bh5lxoxgjqUwD6W5l+WPkHCUNdqTRJlo6ZjwXyvMY2yCHOS8P8bv3WpyYeampsRW6EbL/JqsoJxPBW0REpftjkQCQKgjR6VgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.091170, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This script must be run as root anyway (see all the writing to privileged files in /proc etc). Remove the unnecessary use of sudo to avoid breaking on single-user systems that don't have sudo. This also avoids confusing readers. Signed-off-by: Brendan Jackman Reviewed-by: Dev Jain --- tools/testing/selftests/mm/run_vmtests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index da7e266681031d2772fb0c4139648904a18e0bf9..0f9fe757c3320a6551e39b6d4552fd4874b0bf43 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -386,7 +386,7 @@ CATEGORY="madv_populate" run_test ./madv_populate if [ -x ./memfd_secret ] then -(echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix +(echo 0 > /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix CATEGORY="memfd_secret" run_test ./memfd_secret fi From patchwork Fri Feb 28 16:54:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13996783 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A8DC282D0 for ; Fri, 28 Feb 2025 16:55:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41BEB280003; Fri, 28 Feb 2025 11:55:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A6A7280001; Fri, 28 Feb 2025 11:55:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AE61280003; Fri, 28 Feb 2025 11:55:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E0609280001 for ; Fri, 28 Feb 2025 11:55:19 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A0DF2140EF6 for ; Fri, 28 Feb 2025 16:55:19 +0000 (UTC) X-FDA: 83169953958.24.C4CD77B Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) by imf23.hostedemail.com (Postfix) with ESMTP id CCDE7140017 for ; Fri, 28 Feb 2025 16:55:17 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nop0UeSD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 3dOrBZwgKCJU8z19BzC05DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--jackmanb.bounces.google.com designates 209.85.221.73 as permitted sender) smtp.mailfrom=3dOrBZwgKCJU8z19BzC05DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740761717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Ql5hc6LJFV7jS99QKiJbBHefyQj7jLlsETMiqi11w8=; b=iLeBJt4E99ck//CmrqWUjb6smk+8URolI6Jk9grMHL3pNnRbByOWBWRJdMEFPlsIrUyzLV AKDGYZdg1dd05YNQS79gXxWgLKV2d4/p8wUPWGoSo6KDPtTnBUCq6Wb4tNmCKa/XyXOjwb 6gESaWj/UqTj+YO3WmyyjFAWXbInND8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740761717; a=rsa-sha256; cv=none; b=e7dwrrVASRdt+/4qHFRuNaK4bnOEGUTG0qouadGEwVYpKLVn0otfX1iszRRmsQzV3c0k4V eY2kTju2YHNdzjouuEhgAtquvBEKsgsL/19T6NX060VHEjU9ZygzazbSONhqaFH0mRoJ2T PuwuzMhPKQA84/y9R9t83N0iyplUdj0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nop0UeSD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 3dOrBZwgKCJU8z19BzC05DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--jackmanb.bounces.google.com designates 209.85.221.73 as permitted sender) smtp.mailfrom=3dOrBZwgKCJU8z19BzC05DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--jackmanb.bounces.google.com Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-390f729efacso32885f8f.0 for ; Fri, 28 Feb 2025 08:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740761716; x=1741366516; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=2Ql5hc6LJFV7jS99QKiJbBHefyQj7jLlsETMiqi11w8=; b=nop0UeSD8EWzHYlWzYC7hAf6I1awo7cjr2MeCAPoct7o2162WGsu6vp7JIHMkVTHvh v1xhJmGShvCbceS16DF7Ev1KT9ZTVJU0Q/T6+1NuMbCxwgLt8YhICXKK2BD/LBVhH8tQ p+Xqshxowivk2e2zCvpE/ziNb6QIwYNOrvAwisLkvwlbOoB6Df2vHaJejrA6I2aVIOgB 4nH+qr2wJMaR1k22MltD7WvXOttcPYITX3k/Zeedq/9rMXatFlQm5pn6JxFT/ctg0dhf 6o7Eid1P4NsTvKVVv/ydWp36KYS4s76h/pPotVV/SsadqE0uE69F2UPlkuKgDRMqcIwk WQ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740761716; x=1741366516; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2Ql5hc6LJFV7jS99QKiJbBHefyQj7jLlsETMiqi11w8=; b=WESxYiuOkejaq8Vx7gnlzmLOpjNeuFANvoRsrxEdRzEGxKN+MKndo9oWIfZTczQXkC borFj8+r9ni65xNmTa4hpV6kHEhddt0W7ovtmrQleVk6DpsU4CkcvDEFtSb6OT10xi3n /dysp8XvAxbVWNDBAJAzrkvLsfBp39gjg8hmMRhbD5ril7jP7cmx/0AASkUMuoRRJsz3 sRWJjYD7KhAZy/3zOSAWh5tGMwwUZQj7QJZPNHh1uGx8/bS/qUBjKFZT6ZafhlP8Samq DJqHJZVxyplAPmch/KVSn1cEGq/7s1ij1uoBDxGCzUGzidzusXBa7ATN6hAO6LvJmRGe No5A== X-Forwarded-Encrypted: i=1; AJvYcCXQOlTkrqel2/aZLhW53EgL9h6o7yXXDZ7q6Anz/mV73d0BEryYy/sva9uXfIf/9FJK2q7QKCKhYw==@kvack.org X-Gm-Message-State: AOJu0YxbmOjhHd1Cyp1JHWNcYWk8/zYMR5osQPWbQZ6SDwWh7yYkKdez 4vX8hZrbUtzvXpjUwDStw8JddMjUKhw7LCspLvyqpAndPyk6ypVYAaZ5kLQjiG8G9vRQAc1Viki FPtdQ7Rv1bQ== X-Google-Smtp-Source: AGHT+IFB7nITz7U/iMU0tPl/bO9xV6X55cC7dWX52NbyH2lvSNR7sagUxaeaf3fhuxPU57nHGgdGlD6quABXnQ== X-Received: from wmbbh15.prod.google.com ([2002:a05:600c:3d0f:b0:439:9fd1:8341]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:188c:b0:38f:3224:65ff with SMTP id ffacd0b85a97d-390ec7c6a8emr2890522f8f.5.1740761716612; Fri, 28 Feb 2025 08:55:16 -0800 (PST) Date: Fri, 28 Feb 2025 16:54:58 +0000 In-Reply-To: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> Mime-Version: 1.0 References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250228-mm-selftests-v3-10-958e3b6f0203@google.com> Subject: [PATCH v3 10/10] selftests/mm: Ensure uffd-wp-mremap gets pages of each size From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CCDE7140017 X-Stat-Signature: ppjg96gandqwkwsfh3ebdr96o1e1yf7c X-HE-Tag: 1740761717-631225 X-HE-Meta: U2FsdGVkX1+KBF/qa/RkXpz1aT4flUa7AIC33ajUjitxQCKDQESBXptX1HWAs6fbFS+xmQZPFSlLHT9l5zeEXlrlk5GytbIG0B0Fu2bRklbCw4OwqS7fR9Hcd0br2aVmIz13R1oRodVbSAb2K2gLLzGqCN2sOyORumSltEf8KBlO27vIZ7WwPwF3Jyg+W+JFisYXgNhUPz34yACkJBsaSazIgnrVOQTeOvWjfXwDKmiFomKNLV8RrlK0xVKUnRCsCkNoQq6OIezPlEdF+aEzSeGAGLia584KUgYEeTexJkZlBqVLBAAXaC5LAerKVh7B1W/0UrjL2O5kMh+VUSEgZL4844bJyH0QA92O73viMIPRwB5aS4bBw7kY1j0dDfP3byrl0fFMjbVGPmVuSWCSxpBIpGhUKiCdI4YdnVt9zHwBR3V2cC9764rxSC9ySAAVfqEuoPUv1Q3Rb/plCRLIQhyefPaDeLUNfkRqtPQ3ntrILTInKG8vlADmqjWxDGE3DKCmOA9ZMGaHhuAEOomHn6D5PbDT9cLHf/LRoUIhXtAOw1VWVukuV3LLwk6jUUo0q0VX8+5un5zhEeYuPCPxJFXbf8Bp8ldN5DciKaJsexFLMDy9GNQUbs9pGfZmwcXW7SZnUDrPlI6VhghJMWYSisDo2bCQehDtAYh9x3Ec8I1JeuNqZBGdGIbN+rGEDuJdaZh/w+nsfSCMi+Bh92CmB+V54lRHKxnr3neltPmEemsQbTxnqETCdtDfioSZh6cETmAgjwRhRIingCMRsW59+p3qDyv/kqpOLs1TQsc4qmPWpZRjXFIO8WVa60ngDoRp9Ts2gDxCeiKh3GLJzjCc4O5ycGC+P0jiqUaKvolP8TuNLiWLa/Tft+sLcuGVL83ayONXFAuU43VdEQhcp4IbYL8jMLRLXU2F3tWy+aEtIT0SJ13dXrNLzhvGam+gMH7gqislWmgeea1t4DF7uGY pf98KgVj 1B9huO0A3oXL604ex0r+18lS2mWpGstNxeUWSxgFFrrlHP9DjxmYUYDTgdaNj9gxY3Skxm3+sNE2snW1Luw0iMa4C33thP6IUTFVBHI4yWORcnzxamkELQobx3wBTJaK0/lhmtjz7BwXUJFXkalGqSnfc2LbobNIkwGg84plT7X6fOwurDcwlHlts1TMuSKYMiGMtDmgYefGBQc4hl2KpRik7d0Lelz6GaA2jrm6oZWILMxnrMaYn7n20+kD5emOxtrhy7Oee/WaSZvFsbjGhggGXu2cafPz6M+0+mxwjOarsQPDGlbYH3Rbsa7SVS+1uqX7bf3+2VHhsUF73F3ul/6Oxy4Zdw62QioaNrqssHds/B/1HwBV+Hsl7+wgq5E+/Hw3leMYX3xbUpM8ViLR8mv1+4Htc6aceJ4jt5jW7p5emfJmpPfE6LKdqP8po50///CM+HsYLWYVxIqeLoT3OOtXBPLxS3ZQORW+BLC6A65uJS49sQz7eb8G03PR5hFYp2EOTQCIlaELE/zh7SI1uHPlAjwxLb6G77rfJthf3qBkKB7SOjRxq+jVnTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.269248, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This test allocates a page of every available size and doesn't have any SKIP logic if the allocation fails. So, ensure it's available and skip the test if we can't do so. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index 0f9fe757c3320a6551e39b6d4552fd4874b0bf43..e86ef8cb37d00e572be8cf0ea9cc8246d4eecd7e 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -309,9 +309,30 @@ CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb "$half_ufd_size_MB" 3 CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb-private "$half_ufd_size_MB" 32 CATEGORY="userfaultfd" run_test ${uffd_stress_bin} shmem 20 16 CATEGORY="userfaultfd" run_test ${uffd_stress_bin} shmem-private 20 16 -CATEGORY="userfaultfd" run_test ./uffd-wp-mremap +# uffd-wp-mremap requires at least one page of each size. +have_all_size_hugepgs=true +declare -A nr_size_hugepgs +for f in /sys/kernel/mm/hugepages/**/nr_hugepages; do + old=$(cat $f) + nr_size_hugepgs["$f"]="$old" + if [ "$old" == 0 ]; then + echo 1 > "$f" + fi + if [ $(cat "$f") == 0 ]; then + have_all_size_hugepgs=false + break + fi +done +if $have_all_size_hugepgs; then + CATEGORY="userfaultfd" run_test ./uffd-wp-mremap +else + echo "# SKIP ./uffd-wp-mremap" +fi #cleanup +for f in "${!nr_size_hugepgs[@]}"; do + echo "${nr_size_hugepgs["$f"]}" > "$f" +done echo "$nr_hugepgs" > /proc/sys/vm/nr_hugepages CATEGORY="compaction" run_test ./compaction_test