From patchwork Sat Mar 1 16:57:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ethan Carter Edwards X-Patchwork-Id: 13997622 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A7BC021B8 for ; Sat, 1 Mar 2025 16:57:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CB3D6B007B; Sat, 1 Mar 2025 11:57:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 853C66B0082; Sat, 1 Mar 2025 11:57:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F4866B0083; Sat, 1 Mar 2025 11:57:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5073C6B007B for ; Sat, 1 Mar 2025 11:57:31 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D2538B79EE for ; Sat, 1 Mar 2025 16:57:30 +0000 (UTC) X-FDA: 83173588260.12.B75F898 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf17.hostedemail.com (Postfix) with ESMTP id B69A14000F for ; Sat, 1 Mar 2025 16:57:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=ethancedwards.com header.s=MBO0001 header.b=HbrJfcYq; spf=pass (imf17.hostedemail.com: domain of ethan@ethancedwards.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=ethan@ethancedwards.com; dmarc=pass (policy=none) header.from=ethancedwards.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740848249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=RPlJyMQSOJ2wMYTmAfyfebLAl5Ru+/PjDjFutvpbEog=; b=m0wVLtk0LmPypBj9qJd4byoMuwureQVvNE8DfNTa5yysFU3X9giVzBoIEyAkqAhSf8NaO4 0icL3A1vqheKmFMniSIP94Q34/8/iXY4Mik6KqG4ExQJeW2Vd0O6DkmQLkybc3LGNxFcSA nYfJKSP1SzYMtddNGiaVAryG3a4l2VQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=ethancedwards.com header.s=MBO0001 header.b=HbrJfcYq; spf=pass (imf17.hostedemail.com: domain of ethan@ethancedwards.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=ethan@ethancedwards.com; dmarc=pass (policy=none) header.from=ethancedwards.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740848249; a=rsa-sha256; cv=none; b=VzXV5UGx2uWGGoPZs7pcsXDT+pX+GLF8EnWvGMsUh9i6fvyUu1y/pk34fiC8moZcd87NJo kXnWbV280lMgrG8Eze4fxd+t0R7w66wkwUKaCXvpCUHaYzgaomwm4/EsC8KCQI6IXJRIgG 0v/p0oqozi2omVLn7UyRpL1GYkrtlIs= Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4Z4rpq6l8hz9smn; Sat, 1 Mar 2025 17:57:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ethancedwards.com; s=MBO0001; t=1740848244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RPlJyMQSOJ2wMYTmAfyfebLAl5Ru+/PjDjFutvpbEog=; b=HbrJfcYqmRqIaAv96HLJvK25k+DWJ98fobbKa0p2903dojUzCgifi/KKZiCEVWrGNqL5Hp G2CA5kn+9O/jrtG/9wCFvJE6VAgy6jDtK0qoeaL75SQGPwjVhgeT3fTefdWkHvTDMQOU6C AKz8tuEdUNZqRq2Tcmhh2nbA+vMiXbehLLZUd4r9sL6a1YJfp12T6RilkdeD0eBeJgg5+R z9LR8YqTLoA4pL1Xzz8uGZg4uuRyYst3ALIDxndCqbTOSjypvnwJwH0wogwl2XLMn/M2rO ysin6aY/dyHYky/b0viqRQW7N5vJjiXZEiaiFgTsoH798CjZZ7TpX/SlrQyuxA== From: Ethan Carter Edwards Date: Sat, 01 Mar 2025 11:57:19 -0500 Subject: [PATCH] mm/shmem: fix uninitialized scalar variable MIME-Version: 1.0 Message-Id: <20250301-entry_order_uninit-v1-1-3543b4e3fb28@ethancedwards.com> X-B4-Tracking: v=1; b=H4sIAG48w2cC/x3MPQqAMAxA4atIZgtNpYNeRUT8STVLlFRFKd7d4 vgN7yWIpEwRmiKB0sWRN8nAsoBpHWQhw3M2OOu8rSwakkOfftOZtD+FhQ+DrnYeRxymOkAOd6X A9z9tu/f9ABOc159kAAAA X-Change-ID: 20250301-entry_order_uninit-129251b1ac9f To: Hugh Dickins , Baolin Wang , Andrew Morton , Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Ethan Carter Edwards X-Developer-Signature: v=1; a=openpgp-sha256; l=1211; i=ethan@ethancedwards.com; h=from:subject:message-id; bh=861EVDC7x+OyGKwSipHTxhIzgg06WFsS/lrp6j4vdXQ=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0o0bkp2QXk4ekFKWGJEOXFoNThlVGp6e GhQcXlVeHBCKzJLV0M5dU1XdTdlemIwOG82SzhxT3VxaHRpdC83CnArZ1o0OGJBTXdmNTV1ODl5 cHZhVWNyQ0lNYkZJQ3VteVBJL1J6bnRvZVlNaFoxL1hacGc1ckF5Z1F4aDRPSVUKZ0luOEZtSDR aNzMxdlorZTZ3M0R5d2VxQlF4VXpNS2VMVjZlMnJxblFmZHJiTkZjK2ZuUlV4bitlNW03M21YcQ pES2lUSzFsNmNmbjg3QVVDTXNJemprN1ZjREZoL0xxa28rb25Nd0RPc1V5bgo9RFdQMgotLS0tL UVORCBQR1AgTUVTU0FHRS0tLS0tCg== X-Developer-Key: i=ethan@ethancedwards.com; a=openpgp; fpr=2E51F61839D1FA947A7300C234C04305D581DBFE X-Stat-Signature: jhymai5d7qaf6eebcp3m5jdp8n8tmepb X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B69A14000F X-Rspam-User: X-HE-Tag: 1740848248-672526 X-HE-Meta: U2FsdGVkX1/c71R2XdmNHRUbSOXZ4/Gjgh6uWxAtkuo8NZQPdP6+3Fx9I2WfEwxM4aTLOFHVnjw3R+oeL9V0nQa/vnH95qU3WK4Q08z2ANzNYQ0NicpffcmRAS9jtg7gBpfpqhCskpQjWyT0iCw7QoFeMXNTB+nPF0p9Hj+Kx+FOYQ9lDhMUWkWIC40ZM5FW+yXD6XAlIaIoCZzM8B12O4k9TqD7hn0OU1A1JH2zFA/TEWKd6GpgRJjnM2RUvjoAcjWU0XZ+HcIUhBGko4a00rppaK12+NolgQ24PYsF+tnRVRlxuohqEoGdeTUz5DK6NCKm3pBBa9qf4yAYQFCwImEt2u49CDDqmZE+D/n0v4tIfdvYQT4xXgF+sap1AQeeG1vWCuVe72KJiDkwnHpisNKf3cqYv3o7XuPDcKr2HAJmBLQ9ylF1ka9816NWjH1/b1PxRvmwiRT6bxR2iCBRJHwTjxwX+MPQOori2hTY9PPc21xS8WHKzgZl8KpnlBCSlB0ylitG2fx9ADy/kJaaQ++EdrojqTulRUIW9vl47Qd+S9HX/eQwHLShFiezTAUtCMdh0SF+jjlnMc3fSMQwVXZCRNbEGgVx2RLulpl5OjK/xVDpOjDvHtjWawnK/Qmuu8E/1BA/qUTIPQ6Zc1JbkHi5kSoIhwtZvhlVUR6VOaDdqrbUAFR5IcaCnlIbk8+31H583glzrvZGMvViv89EhHGjcOBAg0KKawApkhAqFSyq5Esm8vahm71+cURXNjqM3rDp+m/gWYZ4jSzUsxSryC0Sjxam73431UHZLOXotu4zbty9WPij1TzBbPptpGl/874C8t0sMcR6T0fVJOZVaCoYEz24rYdWS6JQT1WDRYP97qOcItQU0DDq6JLw4tFOUarIARx7aylgO4nH+gBttiMgZ4wuvtpXX59kf/FO+Qsq/5aHPBln/ZQP7QzLVyZr/HhezOzckAOV9fKvUaK kW/gkNwf 5bDGLlF8E7epkCP3GjzTRD1GSZq4YKbKCQeb153GD0vpI710tH5v/99uHQ008YEt8ikgHSNlD5WJ6FblZeaLoilhPMqMmZP0yXmV65+t80iL2XaxjqD7KBb2FHe3ykWRq+j9z1SiVz7VXbCJiTG52IMoqTlY4mh/UyCr2jWLb1hAWFDyG1aThK7s1C+E7UQ3Oi5IYb3KwkX5rJUfZk+/9Ne3h18+UxWUnhQsdLi5vHDBesJw8yg6kEfp7UmcpJn4+dJ3pEogGaHact3ZVvtrVGbgdi4nS2BYTEGb9cuEw2jE51rlGCcmnRyAgobEEQzEw6UipOo4gEjdXm890YTaIsVGArcf+orx3G3ALglk5vsk19OMsF2tiKPDLCNJE0jSEePAQ458b1o/Cyd0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.018994, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: int entry_order has the possibility of being uninitialized when returning. Initializing it to zero at declaration appeases coverity and reduces risk of returning nonsense. Closes: https://scan7.scan.coverity.com/#/project-view/53698/11354?selectedIssue=1637878 Fixes: 6dbc440b79b6 ("mm/shmem: use xas_try_split() in shmem_split_large_entry()") Signed-off-by: Ethan Carter Edwards --- mm/shmem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- base-commit: c0eb65494e59d9834af7cbad983629e9017b25a1 change-id: 20250301-entry_order_uninit-129251b1ac9f Best regards, diff --git a/mm/shmem.c b/mm/shmem.c index d19d33e98320d5e0ccbc86616bb3ea30d29f0cc1..3718c71aba9304dd3ca8df137a19e0564b8aadb2 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2153,7 +2153,8 @@ static int shmem_split_large_entry(struct inode *inode, pgoff_t index, { struct address_space *mapping = inode->i_mapping; XA_STATE_ORDER(xas, &mapping->i_pages, index, 0); - int split_order = 0, entry_order; + int split_order = 0; + int entry_order = 0; int i; /* Convert user data gfp flags to xarray node gfp flags */