From patchwork Mon Mar 3 08:56:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Orzel, Michal" X-Patchwork-Id: 13998382 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25FBFC282C5 for ; Mon, 3 Mar 2025 08:57:14 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.899952.1307881 (Exim 4.92) (envelope-from ) id 1tp1bk-0003HA-Ha; Mon, 03 Mar 2025 08:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 899952.1307881; Mon, 03 Mar 2025 08:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tp1bk-0003GS-D7; Mon, 03 Mar 2025 08:57:04 +0000 Received: by outflank-mailman (input) for mailman id 899952; Mon, 03 Mar 2025 08:57:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tp1bi-0003Dc-NB for xen-devel@lists.xenproject.org; Mon, 03 Mar 2025 08:57:02 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2061d.outbound.protection.outlook.com [2a01:111:f403:200a::61d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 777991d9-f80d-11ef-9ab2-95dc52dad729; Mon, 03 Mar 2025 09:57:01 +0100 (CET) Received: from BL0PR0102CA0025.prod.exchangelabs.com (2603:10b6:207:18::38) by SJ0PR12MB6759.namprd12.prod.outlook.com (2603:10b6:a03:44b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.25; Mon, 3 Mar 2025 08:56:56 +0000 Received: from BL6PEPF0001AB4D.namprd04.prod.outlook.com (2603:10b6:207:18:cafe::b5) by BL0PR0102CA0025.outlook.office365.com (2603:10b6:207:18::38) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.20 via Frontend Transport; Mon, 3 Mar 2025 08:56:55 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BL6PEPF0001AB4D.mail.protection.outlook.com (10.167.242.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Mon, 3 Mar 2025 08:56:55 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 3 Mar 2025 02:56:54 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Mon, 3 Mar 2025 02:56:53 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 777991d9-f80d-11ef-9ab2-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vEYjS1c+JWtBfF765rbGRaNCNN7onW5C78ja+aJgZfEhyWXzZ3Puz5LAGJuwPBrEzssT1rJfTkgmcBC/wHxiykw+KARlqNgA4Ke5A8mkydoU1sq3Yw9cUAEqh97NNSVgnd2UCIsusWkoGiALPm6UHOT81KPiorQGEN9a6+tSXQr08th98ERgQoXlVNMTPjtnHzVxcneWbhJD9pPXMtwt+uWZorczExwdcGRnpwDlbaS4WxpwYaE4fGMyXVE318YZdSAnzr17i8GloHteo/har2NeKpDalKpDRHROVDtQsnPmfvl/lSQJJJ+IUoJcG4Axwu5FqITOUC68c979dd02rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QNJtj4GaA/ZHBC8mq/llWZAHZbNtifMc8lhwMOPIjDA=; b=LAitw6zphPQyLjqY1LTSF47Zpw9Ja9EhJDjDipFeLWJmhOkNzlw5M1sdLF/Gtxvpy7cIKCl6mx43Gxf7grvgtkKadH6nsF2iv1/H0nMo79ocVylXX6WNLYsImDEh7X/1kY3Be51fTGRqzO2pTAQYtZhbhi+KgTuqyDNT7fsZL5v4Qod+7v2AncUIiFv5h3WXdESRlCE8HHt1nlrDYv9owTdpaje6udHIiPhZ81xE/PgEylcbDzudWf5T5tAmQsHIPT0k7vU6/h/i8Kyd45T5A899Bx2syq524Jp020hyTBsKhQJvxmJhaNCkVM9Wnt7xkahsgn9IxJ6yqYvq9ibXWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNJtj4GaA/ZHBC8mq/llWZAHZbNtifMc8lhwMOPIjDA=; b=Ct75Kiq2lj5xjqljnVLQCCVRUiqCQ+kGqnxCZlb4FYzg7FWoWkisI4LQeLzv5a3b9g0GWbu4sZyJ5JTUg/jbhWU41wRDKJ6DJuwRag9sPX5bX79S0zh3VDMsPoBtu5G2CURgILwcCiJlBjww/JrZOnLSt4JN5VbOYNopv/qrn5E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/4] xen/arm: dm: Bail out if padding != 0 for XEN_DMOP_set_irq_level Date: Mon, 3 Mar 2025 09:56:47 +0100 Message-ID: <20250303085650.74098-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303085650.74098-1-michal.orzel@amd.com> References: <20250303085650.74098-1-michal.orzel@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: michal.orzel@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB4D:EE_|SJ0PR12MB6759:EE_ X-MS-Office365-Filtering-Correlation-Id: eafa3283-0eea-4c06-b2a0-08dd5a315937 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: LZ3V5Mu62SEglpJqaxZzBKB7VbTR6rm2Yo/4NKdNeKV1GpwAUiSRZVEdJAbgrPELB7MTpFaTjrNmkPB7p9KaL2hINJO3Rmb9xnwQVJsSJFYNFzPD8ebQrJpjuKXBCOXwjLud2W5ilqh10VoNnP+wSkfwv6h22+BPUap+5tHStrgRfGPpm3cUFBcFKWCGscbmNq2/AzZIS/wCaXUjej0KYwvz9qx+kKfR6Qp1yrgIa30fSzUhVZs4HSyFhMIkdHclNtg3oIMvKapc6buxHyvM1UGMuXO3+aFhevjN8EeKx8W5QHC0oErKYTvmzVnvyfdJntstoxb06cFCk02WpdxB68QG8OCO6bN/ZudCwn7oQB5LnINlRRrw46v9768vJEp++SnBmGqwRVfG0oB5gfa2orWu5jlzR5VuaPzTWhmNl1sBtm6Rlt7crsWg2EB+uo8BOmmkdKO28CQKp8NCq+cFnooc0RQxwH9844eiiTPebc2V6rfuYqmXMnrmOm294wmXrMOfal15NYhAPiUOwFFJdiWD/vxh27fbi+UJvQ6plyfTyXjtcVLO0oYFFUwYRo+wTNrhGYmnMi2yG75kroSZf5y6WlX+PKezteetgNR1FAdjcIO9e9GQvodxu3Sa7LjoPAFlQKXPTX4tGcnMFH2O1s6gBWuDqyZLzfwmZGaPa7W2tj/Cdfee3NiIC/NEvhy0zuxpT9h3l4v9EtT9yunXfeBPtHHXzIvCPQcv0RzeFeLmDxaCtE9+gmwqWyMrnH428uPc/Dfvf4WiaJiERPqEu6D5eH8ZXIXJNEC97cI0AexzrlZ4nhh7CICMNkpKRWchTfLUEcXwCXTWxsnuAP082yhGWaD/2byrLfNCJ2jQyVqD4VN1a/p2W62tLij/tAO0bRdmm4mZObhXl7nIdqpa4A8ZkSpg/8aKtB3swPJdrrjSuqEvIMHiAxe3MDQOkUbmyOZTuGKU6LAso41A8yZbeEpj147cBGo5UqL6BINGgOnisZwOr8DZxXj3WynqGcjc8/1grSNXoXqUm/IzFWGSaSjqXbcyllF1myytQ4lFSxQIcurN/USikHPU2WWgwd9+0iVooII9zLyC02X0Kt0hbC5R4MuhSNlUJlkMkDFYtNNLglhBSUmFQKOo2nGyJ53MEgdNyRThdGh29ky2cKx5sTsdQexv0lDHpa3nk/bF1GtVTG9w8LIt259br5mrup3IyfW9iGdDgUUOtlZbyNMlBprfHPVFUTqIeLPs+I0Fnz4Db+xZk3pvIIgL95g4+iwosnlZJpeMsm4jleJJZHtEr1pBe22Yxex0ltoBTgEoo7i/355xTeLY5JhncYGu75SculAKo8iPN/6p/s+KaU860QZy6OIwt5AczyD8x1oAstZUzT0VKwkNf/wsRffFO+vPVJ4wksCYRgSBcndWFhcj5h8UPaZoJZ+RlhdFy9XSTH+ss9yzuZ7+K0Pahhe2MzuxQAdUOkPlhsJUmgJhS3WsFxySdVAwS5Uqc3SDp3BUEmg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2025 08:56:55.2729 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eafa3283-0eea-4c06-b2a0-08dd5a315937 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB4D.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6759 XEN_DMOP_set_irq_level operation requires elements of pad array (being member of xen_dm_op_set_irq_level structure) to be 0. While handling the hypercall we validate this. If one of the elements is not zero, we set rc to -EINVAL. At this point we should stop further DM handling and bail out propagating the error to the caller. However, instead of goto the code uses break which has basically no meaningful effect. The rc value is never read and the code continues with the hypercall processing ending up (possibly) with the interrupt injection. Fix it. Fixes: 5d752df85f2c ("xen/dm: Introduce xendevicemodel_set_irq_level DM op") Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis --- xen/arch/arm/dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/dm.c b/xen/arch/arm/dm.c index 773a0a259272..fdb3d967ec98 100644 --- a/xen/arch/arm/dm.c +++ b/xen/arch/arm/dm.c @@ -93,7 +93,7 @@ int dm_op(const struct dmop_args *op_args) if ( data->pad[i] ) { rc = -EINVAL; - break; + goto out; } } From patchwork Mon Mar 3 08:56:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Orzel, Michal" X-Patchwork-Id: 13998386 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9753C282C5 for ; Mon, 3 Mar 2025 08:57:18 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.899956.1307914 (Exim 4.92) (envelope-from ) id 1tp1br-0004GV-7G; Mon, 03 Mar 2025 08:57:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 899956.1307914; Mon, 03 Mar 2025 08:57:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tp1br-0004GM-3u; Mon, 03 Mar 2025 08:57:11 +0000 Received: by outflank-mailman (input) for mailman id 899956; Mon, 03 Mar 2025 08:57:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tp1bq-0003Dc-AV for xen-devel@lists.xenproject.org; Mon, 03 Mar 2025 08:57:10 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20621.outbound.protection.outlook.com [2a01:111:f403:2412::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77cfd9d9-f80d-11ef-9ab2-95dc52dad729; Mon, 03 Mar 2025 09:57:01 +0100 (CET) Received: from BL0PR0102CA0004.prod.exchangelabs.com (2603:10b6:207:18::17) by DS7PR12MB8274.namprd12.prod.outlook.com (2603:10b6:8:da::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.23; Mon, 3 Mar 2025 08:56:56 +0000 Received: from BL6PEPF0001AB4D.namprd04.prod.outlook.com (2603:10b6:207:18:cafe::92) by BL0PR0102CA0004.outlook.office365.com (2603:10b6:207:18::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.24 via Frontend Transport; Mon, 3 Mar 2025 08:56:56 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BL6PEPF0001AB4D.mail.protection.outlook.com (10.167.242.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Mon, 3 Mar 2025 08:56:56 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 3 Mar 2025 02:56:56 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Mon, 3 Mar 2025 02:56:55 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77cfd9d9-f80d-11ef-9ab2-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VFcLwWoBsGkHznhuNS592/YvGst0L8lQYXGjQkf79yHfk/W77blGRcgZ6cZgGPOAdIroIXSnJTPGWOypNjIPnhGb8zfozj6szve/K/qXYoRCxc8+iOtjyBz6skRNai6O/4GYMRQouZmA8hiXu6TAiben+m9XpLG53SZidL0i8EOcDICmI2+FjCMyRxI/QZyGoeWZRcvSufxCesktUdeSI2VXDQ5gVE0UeBLJqUDa1oTg4IwnMRxRw2P2T3DEnhM+gmeQjPIJpO6UTe4TxLRqxWzJy7J7R16JHuU9+D7xo8rYRgd+sUEtReizJYFyDoBzzn/y1OPJGqYBi8AKdfiWCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OufWKULnetNUAK9GTpERGyY8WgmttM8kb3z75tr7XYs=; b=tuCTZJpt2z4NZqj2j7Xv8ioAIww+4hLRMjtCjt2SxoPOfYpolyA66GyGkHRqW1smqv7e3PC+I+GgO6CZ5gwdDYSAlOW+jzrJJ1plf9j4E7/RndBLON+fMtX68bbCLU/jK+xR/S9UeiyY1Qc75dDZ+VRl3qgoe4sM608RNsErptye22YK0DAnXqw/frYcDbMWoL7xoVienumViR760ThPMkE/74KrVbuA9vMYlZAcmeXr82DVPGDp/ylCytcoyTGzgBWfX4E3qc4gsxqNWxIOo09l3GJD2lADYIrjUI+axYHQeVQ5mSqNUdm+W+H5I9tMRycTOQETw/SqvYR4REsgsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OufWKULnetNUAK9GTpERGyY8WgmttM8kb3z75tr7XYs=; b=psLWLcBTkvCAXM+zq1fxlLKwsqLVbFgeiUvzq62DYWf6LXpWsyiPtL6ceMR+tYzkqDUOGmtIZbhrorVeXIwrDe9c3WfTHuNe3rGvIHF3oWwg+EyCAz0iAK3XkGSXGocLczlt8YgSKCdRjtcH1D2aqJ6PL54k+h+2YAAOj8h7j2g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 2/4] xen/arm: Check return code from fdt_finish_reservemap() Date: Mon, 3 Mar 2025 09:56:48 +0100 Message-ID: <20250303085650.74098-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303085650.74098-1-michal.orzel@amd.com> References: <20250303085650.74098-1-michal.orzel@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: michal.orzel@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB4D:EE_|DS7PR12MB8274:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e14ef30-ca63-4f2d-81fb-08dd5a315a09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: UiS0ef3HGig3nCEWAVNCNgzPIFn8lzoQXbHedXjtnuYAYTJUHQ8TCohHiLgTXqSaIIXOkUHxxHqn8IYlaPdswyqD3ejeNM7ywglVXy4r9WHvC57zEMuy1XH5UePlqsqkDoRk0LrzuEp3bOLClmRDGjgv+vxAbYgrL5RHfj92ZbwyIJoMCWO/9xErRBeVzVpBwmPT3MUoKzQKBwgQzAhmg0Oah9PdEk4Lg09scKgHhU/tMJytvxonSEX8MFCM8jyexpxFuyM5SuPcF7gpKHAWfu5HizzdozV/W2z/gPk6dLvK10cIlGLa1f2jFFdJMVrFPU7M4CrNVVOdZx7ViZ1pswYu0AuUbjLUzux+XIJ35Cys3R/j4DqZtdY/da1R3RiL8dViU900vBs1sBMbFlCbK/nYVRFPr5+3wMIBKdniKt9UL+yOJyQM7e8odWIUB9Lw0Jo9d+7i9hK5yGEOXkqqnhduyjqSzUNqmhJgdPGI6DWOWSRdVy0NGg8gs/saZUtqH2dxaKQaL2BNMuaWt2iqsZQwW3bBmhSSs6aExfqa5qrr/zBQE1wRJ3Qa2UBaTepC3p7mzxQ025YJMQJJFfID6/j26CTGK8iTP6Xf/MpPHMvid9f0Ebct9vVXW2IpLXxOHGPbBtHHQ/3lY5nV6aYZ+8H0QDkO2ELeFUdKIgEKUJsHWk3+vsnrUgJDJgYVE0c0moRz42h/rdCSgIATnftdVXWEj0++3hw/nu/tsyEGvx3Q5enIwycz/+Zifk49jaNLULf7/U/ktHC4xxBA9yttgrBIEdh1UOT+Ff8MvibGy0thvIiQnM05mnZHP1HsxtNTBJ2PTOHtEKFG38hpN77VZ7jvrBQM3BYJn2HJZgjZHT3Xwzrre2GrcgpaoQYA9bwGSQmydzTqfPWEoycRmWk97FBYdouKC/Yb0tsUL0FaAmlZ+u2WxbdCKZnn5qh92w6+EAAfgqqbrcj5x5pdfqvycsgqYR7PqLQz/ZkCC7Lhx2ivDy3lneWMuIzePZaUFtRoRUYSbbEJ6Zymi8rNkfUkqrfcBDvBHr1zLfM6bK8Tpd8cc7EGHfsdiCriygKg8QE0Y3Ac2q/UrQM0FWdgZI2jbHljegMmjwU3UbG7+S+pyG6S0lnUBoUDoKy4ZEtZGD80jvbiVM6WDWQwEERpJ5TSWWEpEaoHNgdZbgF9/jpMaSOw4msRmVdW8NChBEJoKrPj5wC7ndtn5F5Y41irq52JdMUECbfNg/PpLhOf0AgUcOkW6N2XwF2CCPE8+6ehMRpX/mQ+ybZ7udQqWIKggGtxzKJSaS6vt6NFrIWHpIwuIfSPQkfz5pgUaHG1ltUFPekeGEBZLpMMuSP+ewUWdh/yDKIfzEYHbbSmT02fe1gklYdYE9pIo6nQQU8uzVRuIiVVAkQM5GbjWpXSeAd3ni3IZg4uNGvipgZt7uv5q7vgJPrCPmhLDbuiVo662oII1+F6uJ61F8gpkJpXjAV8SD+fDxqETFKle9T/6XaDpSXSaQg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2025 08:56:56.6479 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e14ef30-ca63-4f2d-81fb-08dd5a315a09 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB4D.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8274 fdt_finish_reservemap() may fail (with -FDT_ERR_NOSPACE) in which case further DTB creation (in prepare_dtb_hwdom()) makes no sense. Fix it. Fixes: 13bb63b754e4 ("device tree,arm: supply a flat device tree to dom0") Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis --- xen/arch/arm/domain_build.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 7b47abade196..fe05cf6d855f 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2033,7 +2033,9 @@ static int __init prepare_dtb_hwdom(struct domain *d, struct kernel_info *kinfo) if ( ret < 0 ) goto err; - fdt_finish_reservemap(kinfo->fdt); + ret = fdt_finish_reservemap(kinfo->fdt); + if ( ret ) + goto err; ret = handle_node(d, kinfo, dt_host, default_p2mt); if ( ret ) From patchwork Mon Mar 3 08:56:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Orzel, Michal" X-Patchwork-Id: 13998385 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B58FC282D3 for ; Mon, 3 Mar 2025 08:57:15 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.899953.1307895 (Exim 4.92) (envelope-from ) id 1tp1bl-0003g9-Qp; Mon, 03 Mar 2025 08:57:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 899953.1307895; Mon, 03 Mar 2025 08:57:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tp1bl-0003g2-Ms; Mon, 03 Mar 2025 08:57:05 +0000 Received: by outflank-mailman (input) for mailman id 899953; Mon, 03 Mar 2025 08:57:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tp1bj-0003Dc-Lr for xen-devel@lists.xenproject.org; Mon, 03 Mar 2025 08:57:03 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2061f.outbound.protection.outlook.com [2a01:111:f403:2414::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78df5126-f80d-11ef-9ab2-95dc52dad729; Mon, 03 Mar 2025 09:57:03 +0100 (CET) Received: from MN0P221CA0010.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:52a::23) by DM4PR12MB5817.namprd12.prod.outlook.com (2603:10b6:8:60::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.24; Mon, 3 Mar 2025 08:56:59 +0000 Received: from BL02EPF0001A100.namprd03.prod.outlook.com (2603:10b6:208:52a:cafe::7c) by MN0P221CA0010.outlook.office365.com (2603:10b6:208:52a::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.28 via Frontend Transport; Mon, 3 Mar 2025 08:56:58 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A100.mail.protection.outlook.com (10.167.242.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Mon, 3 Mar 2025 08:56:58 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 3 Mar 2025 02:56:57 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Mon, 3 Mar 2025 02:56:56 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78df5126-f80d-11ef-9ab2-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bVeYnvzewCGbDnShfsZytjwi3dG7GNDBUwZgVCWXgni8NKbdjHgNg6xAmUZZewDYNjEnlkbkcTzpFTdBtsKNFfHZh8rJCTu2w27e+hY+cLUS0frDiDjk2bK4vzUZLuCpKMEtK/MIkeU6uw8rC8v3blCkzhuILXpKW0lpSvYVM31i9YM9on4KkLX8vGwFq3Y50+t4os95QnwqZZPxZ31Ul6nQaCbfxx+WzA1LyMQbSCCC73ZY2LgE2UIF3nfk6FVmlW7GEizLG2V62IbJcFtwiSiXiv5Pshl4ALCc7voEPiMvWWI5AEIkzLNYWnFVat3TTd6VthhEyMx8oIiQ6354Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yQmOEy7gXJx+DP+I6vy84CUACXTTBew/gftEYl44aIE=; b=qsJMYM3qp4NfI22CWqJTd3z15VU2m5OKXWPAE7wh+XFi5gv2ehGIddrgi/M9fTlrU+cJ/gO88skqbnhJwRqB3Tqoo3zNPpFVpsNqLCFh0AmTlAYEjIzsHKHVw0VI+9wG8+opkaCAV6WmpYxMweIChU59VhZ2K9uQOQhLy2xyOiCXILuFtagGzaC0GoFv3uRzwATaIP9YbphdZ+++PKA8XdJy5XhX28K2qfkPqdHWiO3ypnM8RmaLBqr/N34gJhdM3hy8u95+sTpHoDWIPvCAk88JDSGdvmF1CuvqBfXV3CssjcDvv5v1eQM6GhGgdczvUjiU2Zg7V5IDHvwEXHCVQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yQmOEy7gXJx+DP+I6vy84CUACXTTBew/gftEYl44aIE=; b=ArIFeSMh+v+GLQJduuw5/HcihjeTRL22zqWvYJ1gX3NLi7V8FMHxezCbIxptCkDnv7dpwJpfKk9joF1DBtDqri1MaxJPh2a0tfZTi+TH5BjX+QdyMZ201kw0p2EFRIGMd1wc/0X4oFlrIyg+Xqvvnhx3O6VI+6Rp6Xx9scvyc2Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 3/4] xen/arm: static-shmem: Drop unused size_cells Date: Mon, 3 Mar 2025 09:56:49 +0100 Message-ID: <20250303085650.74098-4-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303085650.74098-1-michal.orzel@amd.com> References: <20250303085650.74098-1-michal.orzel@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB04.amd.com: michal.orzel@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A100:EE_|DM4PR12MB5817:EE_ X-MS-Office365-Filtering-Correlation-Id: 22eb8960-63a2-4a9a-e0b0-08dd5a315b04 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: SGqCdXH1UqBB/Qwtjk8ysa3bd6STpxF4sMRjT2HZ6HrqIZnqWDKSzX5tUET0vlJrnUAvp3sPy4LWUTHB6T8CoDIAmn/b/Nu3nTcLKEYP1LR1ppAe83pa7LWbDBXCgogiFoy3gFAHWO9jlfmX8aqQfn8q7qyL9lIwiojoRp8LsVgFkHftt+XUX5H6whBIsjL7SsbNZjXnUWAIhg5VM3llmDSYW3Aw9Na6BQHW7bxUiQ5FyI3uyhtjAFCc3shWMq5QT3S3KavZCUqeHsmn5w2j+4ySCSyNp3cpNeuLI+DfEsHEMDvHSs6/k8pYiXz9viAAtlmu2XNnOAIh/1LRSPHhwleoOyvlS6F4l0kUv+WvLV0QEP9errSOvXrHorzmJ8p+fyPwiyQ1bWy4/UJohLvOchcWHv2GeSMfn83E81i9DcXqFjVX7IA2mTAV66mZT+CuSnMpJrdFj/apKntZjPkw04tzuoJYSkAc5v2/f5GCKAWXP+Gqv7Z7d6Zx7El+MU1g8IIyb65x8mg7Qd0uh95Ag1NY2Nm9Ck+SFkLpE8zrw62tADghvvIACEr6beTa6qsqEMtOe1FQSvx3LcwYKtKx+N5y2pqWFsAS2lUfqWLybwouuRI5E2WtQdRQzwRrgXcGWYkkLYy2CzMCE/iS9OT1gfSE922JjbQaNagvDi+5nCQk1bWC8ixstV5eJUp+pPYTk/Y5FyCH1+tQHmUr1kN1OxedYhrQq6+JdiJ+PPnV390c29rDPbVDrbJO3ov3eeGPcC9uu1nZ5TsBXsQa4szxfqq1AaCnx7FG/sx+PEhkDNOW2g0UQ4vfKcpCRDrAADkA3Plv992gQ/wcFDTA3ePWuGiLMwlxXSY5sVV69GPfjyBm4Ak2iI6jLptIpv2jOr+GBDT5aC65qdOMREW+pZmyHp2JurtvI4En3SsEoQRc+CCgIhOPjkuAglKqkNQ9hG7Q7XnnODr561pFDn3hwQqv9UKXuUqUbVHeLx6oAoXln1SJzr631tpKu8JtFUWhvOdkxKaoIEhEOtumpfFHv6pqXtaKhONst+KA6JwiTY7S0/53WLH944Scu0WgeRTMW0AG02NekDPnfLDTLlsV8Kbs2Da2kiQ8GE10IcL7B17BvbarxeDBsZkXIQU3uNWj2gB4ZS9bsgnJ/IhloLQasZowSZ4nXW3lgqRvJ62xTuAePirAhv5lNfvLCTQAOeqNalv93THJ39qf9M1W0OETY0Yr2ddAgXm9S0gTXNg2aQNfASpFoysIuDvRzpvMTWsiQ5tIDoeEeukBsxjXbkBI+lsI2zfzi3hM+MkxUOs1Mqv1mO1aRzBruqIr96u2/pIyyiZL7K4SqM66SFL2EzzEowyxeJCJMW1AW0Pnz2OY2DNAyz9II+9lDtqHy/qvSe0RAyW1Frc4QA5TthzLeZWJCEIO8eughHBOSQuHhGfuZhJW/LuoBiz1pxgGYtythEK/ogJI4QI2Odc8WxcSzUuts43IKtIAMq04YxGDgALGzgGe0ko= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2025 08:56:58.2953 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22eb8960-63a2-4a9a-e0b0-08dd5a315b04 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A100.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5817 Value stored in size_cells is never read because we're only interested in retrieving gbase address of shmem region for which we only need address cells. Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis --- xen/arch/arm/static-shmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/arm/static-shmem.c b/xen/arch/arm/static-shmem.c index 8f87154c3587..c74fa13d4847 100644 --- a/xen/arch/arm/static-shmem.c +++ b/xen/arch/arm/static-shmem.c @@ -302,7 +302,7 @@ int __init process_shm(struct domain *d, struct kernel_info *kinfo, const struct membank *boot_shm_bank; const struct dt_property *prop; const __be32 *cells; - uint32_t addr_cells, size_cells; + uint32_t addr_cells; paddr_t gbase, pbase, psize; int ret = 0; unsigned int i; @@ -338,7 +338,6 @@ int __init process_shm(struct domain *d, struct kernel_info *kinfo, * pbase is optional. */ addr_cells = dt_n_addr_cells(shm_node); - size_cells = dt_n_size_cells(shm_node); prop = dt_find_property(shm_node, "xen,shared-mem", NULL); BUG_ON(!prop); cells = (const __be32 *)prop->value; From patchwork Mon Mar 3 08:56:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Orzel, Michal" X-Patchwork-Id: 13998383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D6F1C282C6 for ; Mon, 3 Mar 2025 08:57:14 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.899954.1307905 (Exim 4.92) (envelope-from ) id 1tp1bn-0003vS-1H; Mon, 03 Mar 2025 08:57:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 899954.1307905; Mon, 03 Mar 2025 08:57:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tp1bm-0003vD-Tl; Mon, 03 Mar 2025 08:57:06 +0000 Received: by outflank-mailman (input) for mailman id 899954; Mon, 03 Mar 2025 08:57:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tp1bm-0003Dc-0s for xen-devel@lists.xenproject.org; Mon, 03 Mar 2025 08:57:06 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20627.outbound.protection.outlook.com [2a01:111:f403:2417::627]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7a515d6a-f80d-11ef-9ab2-95dc52dad729; Mon, 03 Mar 2025 09:57:05 +0100 (CET) Received: from BN9P221CA0004.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::12) by SN7PR12MB6837.namprd12.prod.outlook.com (2603:10b6:806:267::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.25; Mon, 3 Mar 2025 08:57:00 +0000 Received: from BL02EPF0001A0FF.namprd03.prod.outlook.com (2603:10b6:408:10a:cafe::1a) by BN9P221CA0004.outlook.office365.com (2603:10b6:408:10a::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.27 via Frontend Transport; Mon, 3 Mar 2025 08:57:00 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A0FF.mail.protection.outlook.com (10.167.242.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Mon, 3 Mar 2025 08:56:59 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 3 Mar 2025 02:56:59 -0600 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Mon, 3 Mar 2025 02:56:58 -0600 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a515d6a-f80d-11ef-9ab2-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wvy1xcBad+iO+imkR1o+Pzl9v+7aMTTG1lbT7cOPMiRBgpPhmvWs0/IfgEqba7h4Jzh1Mkv+8xWrLx2le8CdevVaVTh4qEcQK6uG6290TaDYoUqnk1b/G+a63J1o+akdHnMJbzl15DF35b5/smx5L9qeiBydz5Y/sgu4MLf7IpFKmzQWkhsVkwnrftE057i6pZY1NfFXV698dOm2Tp8Q/zjIIU19qCkhFLtS9KUr6rf4pEqd6y6Hak/hKk3aa7JleHcWsP4OwxVpKFX59hyPb3AjmoqSgX3cXiQoQ1PzvPeIZQI48i4kiauQsxZl1Yml8MpTIpxEhiO0Xq79ML2Flg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2/bQ+H7J+bTS7mkQRIITAqEiowFLxZYtUi8lKZ2cQbE=; b=KmElTPAQYnXhUg5ChlEhXuR2Bo0CLiJwiPJK5+grlBj7Hx4yXYUOJLLckl31AOS9qY1jtoLa88QvK6gwVbSUZ/4YNpxi4YTZ0B45hVzdyz+XMD74RVAKLdweEaZmSnmsM4Jw7KYS9Lc8vCqN8TVVwY2NLU7lOTEv/9e4wVLgfQprCU3J7GvV5+ov9ALYOrIglFwll4G3pTf+9kEHLhZFITWxxNq5EFRaYbXtECXHoEASyNfIZpK17Txlc9KvDgO5IH/Ljivmwt5O1GUCxR2T4n7E2T89h1Bjq8Kc0wuPUkZSZwN2tk+C18d8eIFcCL9+LtDSf9q4Vs9fqF4nGhB36Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2/bQ+H7J+bTS7mkQRIITAqEiowFLxZYtUi8lKZ2cQbE=; b=wo1s2kbCKarijxgOrMNJNX1PEYGp/Sflbo5c5t57k68E4FV1qQEE6KMj/348hEurgqWRU/mdc8VCg8QgueoDU1zXLdRRbv0kgn8Ykc0txTFhX8JCcLvGwevxAkO+nYDoavkNGMY1zzeK2YIeDO0qfsiOAOJ2yIUyAUe/9lR2MuU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 4/4] xen/arm: Don't blindly print hwdom in generic panic messages Date: Mon, 3 Mar 2025 09:56:50 +0100 Message-ID: <20250303085650.74098-5-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303085650.74098-1-michal.orzel@amd.com> References: <20250303085650.74098-1-michal.orzel@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB04.amd.com: michal.orzel@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A0FF:EE_|SN7PR12MB6837:EE_ X-MS-Office365-Filtering-Correlation-Id: 5a317e7b-4e47-4eb3-57aa-08dd5a315bee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|1800799024|376014; X-Microsoft-Antispam-Message-Info: /bGMkLobgP1UIkvX9In49fSxyEa0duhwsuaGSEwKjGSmytFY/PRwk03rzo+LbUpxfb8rIX9wlF/HFy15LFumbBZqm6y96atm6V6kunxpE8OIe0An0bl2EGlOznhMC/cfHEs2qWJmC+rxa3eAItoLyU5KatgrxUrcgmJ02xqCWZD1VLiunwKPAWapp8sQzbESh7Sm869NIZFC71NqR7o1UmqJSD0dvixPYyigDRiPHsIH961vFjAe4TvQ7KJHzMbx8woqw/qCohRJ8ZlDhkMomQd6w1IlJccA7B5On63+35WBm47X9AKlLV4Awr2PFkkA6uQzpiHD9Q8dK/xavTGNFQ9UlFHaWSxrm2K+VN4yI1TuYeF/d0v5veSDc8zfGSmA11mU6zTiPGYpSbmxCZmd9msovuNp484aweWx2xupnVrbOw8DQ4+nc4dN5x+ZqZXSvYuhsg1Ur7U+gVlJq1dJfZx1Xtg1jG6Ke3nNUYYE/VJo1UEwUlyP39+y8wcHTw2V+3koi3+3MSChlnpSGcoeesido0ZmIrinbMRG4LlHxgd5fH/xA8BAd8UwQjWRoC8U79v09dsSW7hTTjWkeDN9z7rCeeKvSsvKNHnyjIY4int1h5XXtuFlAfgmPS02Vbt/CrDOd5m7IielzUUfPJGR/sB0vSUSaRbtbG1F/rDeK3WD2TQsce9ZplXu8QwoXBhTGHwXNWCxXkMAA5vgmGfjjneTy/r6j08Mzy2Pd3R9oeTC3CK6vgjpqlfgANowtrXJ+bvpcr489MRVCBMxS8UtX111my0s5Ms7p+YWC5JmqMqUYLPYLDLvYCfYaORuT6Pkj0Z6QUWa+CDE9ABgJxIprXsx1H2PCBdIMsFpqhMmrgaTUC+G9qEt/TxahbKMuD5kK9izcI/UP6COGhqj/eUj0h1Znb0b2Fog+1eOxDP5fmRszr1UwUjEnXWHVseovVnYM5+4DsrVpze/82eO1ana8UKM5j0w9tXedKzhO7VAx+YKRsKNHFTWIsnF2M83uOt8KOHrMy9uAGnvwy9cXdZPlPcjLuOYCcdtBfcZaES9icQDJ/TOHZ8QCoYQ/lGuXkGopAofgreRWTBAyVVkmSKSxdqT3DGehJpDGpOfM58T+cfWHg2UB4XsyZkd46cfzuPvD4X8snOXJTJXkGmUehwLBJx+aqDLv4wRkYnzEjocDFfDt2VhFuWIKBhYIFqEmBz0knBLxODCewZOZEnr/y5bbwpzG1qhXfoXrnBLycL7tEQ1DQ2qlUO8B8SZ7XPGJ6/1C/ncSPXnvtL65ZYJwC3p4l2OOX/X6a3hugqA7vwMet2kFIttwYFeRikSq3iaTIDsihweaMrYHfOYOX27mMw1chulxLrwc4xQwh4SNIzOseSF0M9/xTg9Msny4QN/zxHg3keuGO65lKHXugu4GL1aCKI2qID4s3RVjQar44htT//5dCfwgVlfFLqQdphIfmAWxAYVxPMxT1/Pl3MSBwfSETHaK5tf6b34Gb47zc4yv20= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2025 08:56:59.8253 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5a317e7b-4e47-4eb3-57aa-08dd5a315bee X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A0FF.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6837 These functions are generic and used not only for hardware domain. This creates confusion when printing any of these panic messages (e.g. failure when loading domU kernel would result in informing a user about a failure in loading hwdom kernel). Signed-off-by: Michal Orzel Reviewed-by: Bertrand Marquis --- xen/arch/arm/domain_build.c | 4 ++-- xen/arch/arm/kernel.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index fe05cf6d855f..6531fe019f79 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2112,12 +2112,12 @@ static void __init initrd_load(struct kernel_info *kinfo) initrd = ioremap_wc(paddr, len); if ( !initrd ) - panic("Unable to map the hwdom initrd\n"); + panic("Unable to map the %pd initrd\n", kinfo->d); res = copy_to_guest_phys_flush_dcache(kinfo->d, load_addr, initrd, len); if ( res != 0 ) - panic("Unable to copy the initrd in the hwdom memory\n"); + panic("Unable to copy the initrd in the %pd memory\n", kinfo->d); iounmap(initrd); } diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index 80fad8b3362c..6eaf9e2b06b3 100644 --- a/xen/arch/arm/kernel.c +++ b/xen/arch/arm/kernel.c @@ -150,12 +150,12 @@ static void __init kernel_zimage_load(struct kernel_info *info) kernel = ioremap_wc(paddr, len); if ( !kernel ) - panic("Unable to map the hwdom kernel\n"); + panic("Unable to map the %pd kernel\n", info->d); rc = copy_to_guest_phys_flush_dcache(info->d, load_addr, kernel, len); if ( rc != 0 ) - panic("Unable to copy the kernel in the hwdom memory\n"); + panic("Unable to copy the kernel in the %pd memory\n", info->d); iounmap(kernel); }