From patchwork Mon Mar 3 09:44:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ye X-Patchwork-Id: 13998443 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2321C282C5 for ; Mon, 3 Mar 2025 09:44:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2DB6280007; Mon, 3 Mar 2025 04:44:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C66B2280008; Mon, 3 Mar 2025 04:44:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB880280007; Mon, 3 Mar 2025 04:44:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8B21C280008 for ; Mon, 3 Mar 2025 04:44:28 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4664550576 for ; Mon, 3 Mar 2025 09:44:28 +0000 (UTC) X-FDA: 83179754616.24.FA251E6 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf15.hostedemail.com (Postfix) with ESMTP id 9E1EBA0012 for ; Mon, 3 Mar 2025 09:44:23 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740995066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OszdINdSjFBDjQLO6V8I1VjdRXIokv32vD1Jo9AGNR8=; b=EgGI1S8AF9mRxssxy3UIYcXsFSB51XtnuqlNmIjiokW72K/TPbKq1tsHjg1ibbCtyO2LIW Q4Mbo/LWkVsJLayIwkrVQhP9gVDkya42iwqXSmd2l9zRvR5p3rX/NACKc2EenDlvvL3l8x rfEMgYk4EKUwbFM8oNIDyHqpTG8QaFk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740995066; a=rsa-sha256; cv=none; b=pd3VB2MdwwUGYF5qjW5JwH9ON4RETs42n6nDxeTfhQayGkXlIwKizvbxcU68k4AEnfPxlw DD/LSm+gK3P8LBZruvZvRIuZFI5lPtnQ8rW1zhF71xfJlGB7csX/qVVD4D4zZILjeGx586 I4dGKEJ0/5v30ujoWcCboPcnvQVuODg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn X-UUID: 1275c6aef81411efa216b1d71e6e1362-20250303 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED SA_EXISTED, SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:ec3fcc8f-aa44-4f71-894d-eccf03347660,IP:10, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:20 X-CID-INFO: VERSION:1.1.45,REQID:ec3fcc8f-aa44-4f71-894d-eccf03347660,IP:10,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:6493067,CLOUDID:4081698c0a2419bf5e3690921fac3194,BulkI D:250303172844BQY8HYXC,BulkQuantity:2,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS:nil, BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 1275c6aef81411efa216b1d71e6e1362-20250303 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1108455076; Mon, 03 Mar 2025 17:44:16 +0800 From: Liu Ye To: akpm@linux-foundation.org Cc: urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH 1/4] mm/vmalloc: Remove unnecessary size ALIGN in __vmalloc_node_range_noprof Date: Mon, 3 Mar 2025 17:44:07 +0800 Message-Id: <20250303094410.437985-2-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303094410.437985-1-liuye@kylinos.cn> References: <20250303094410.437985-1-liuye@kylinos.cn> MIME-Version: 1.0 X-Stat-Signature: akcbdha8phygcaqza3zkwb6r5omo63e8 X-Rspamd-Queue-Id: 9E1EBA0012 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740995063-751669 X-HE-Meta: U2FsdGVkX1/KRMdAxEbgGT0zWizmg0liiFE3wvcadoyGTNspRUqOL3tiTBOGJrIjniXt1579RigiXrRpKxpLGwa69bnDRrc+Y3ngFRoNHSzhsu9QCusaC0glbxNh2dGfJ3JLvoYp9RxjDYQ5d5R8939pDOJTwEnrRv6Jb60dwbst6doeeL/rgHOHoQebQd9zYnZpUOhSisBR/FLRdt3tNyui3x1SxLGVxSQ/WyntPtortfXoee40WgvpOTTidCKdf29tBOBweosvGBryBT2jnT+qe+o7MbA0U0lNuHKEU98GNEaJ+1LPvy3Y2EvzUds+Kpp3f6DBvi7KTgrOHl5MGApdCY9ptaIK6MdxARBXu1H/V/RR6SeQoqL2shFcYM88fmTz2f28mBvKDy/R8Dyvi3OQG16n9xE8Q88KuJvYabzo8xexxHsgnfGcx7ALliTujP54K+C3muiNl1Owfsxuu9+j8wZc5YtpCIoe/DXJNrF01369j0gzFT+r9WwG5R5mmrbGNFyAh+Rp8ZZYULGf08+d62w/effooEzwfggeXY8D6cYuKBiKt6x2G4lQKqSgyy0BjATW5O8pWzJCal+3OwODbSnCFkwp9kg6+kKt2ce3lznHerh53p2egqwPuelDgg4y74iTkS456o7do+BmWxEw5Lc2rAYsM3mfhlI4HhlGNEC7YaD/dtKb/tIckKBwPGtiGiPdrnqqC7GcalC9W2KeuEU092AIfaysVfTGm9njPvxlfG7i+wbFwvAh1SrKga3ybiCK9x9lwd+n5d2T4LZvbJcS6wXghwaL8oeQNkS87lzGvXLsrzwBDIrDJjf1OD42hzOboRLlw3K71MpDoHDZR05BLuNLTCZAXW2fG+KBybpwteyT/P31Sg2gyZUrOGG3D16Q6yFP8qBgOVlrj7W78WYUiUkZ1xYpSDO1JsjiuN3d+fPRVu+O5rMGDy8EUXcbgDZW7klEIS/HgaU 8NQuU06Q 8ucaVfF9WinUhf6/YXQb8VapFeZ4JzR6xfWE5OikqG8YwioL9OESKZhCjUlOotEgrWvHOd5tBWd+BogM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The same operation already exists in the function __get_vm_area_node, so delete the duplicate operation to simplify the code. Signed-off-by: Liu Ye --- mm/vmalloc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index dc658d4af181..20d9b9de84b1 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3798,7 +3798,6 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, shift = arch_vmap_pte_supported_shift(size); align = max(real_align, 1UL << shift); - size = ALIGN(real_size, 1UL << shift); } again: From patchwork Mon Mar 3 09:44:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ye X-Patchwork-Id: 13998441 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD00C282C5 for ; Mon, 3 Mar 2025 09:44:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1446C280006; Mon, 3 Mar 2025 04:44:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F488280005; Mon, 3 Mar 2025 04:44:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED73A280006; Mon, 3 Mar 2025 04:44:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CEAD3280005 for ; Mon, 3 Mar 2025 04:44:27 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 889881A05AE for ; Mon, 3 Mar 2025 09:44:27 +0000 (UTC) X-FDA: 83179754574.18.07AFF43 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf30.hostedemail.com (Postfix) with ESMTP id B93DC8000B for ; Mon, 3 Mar 2025 09:44:24 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740995065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l2THEL19TddTGBXsO8FqHZxL18yZkTQmha+67cL/7Zg=; b=jLNJfrQOXr5xe4GahSJS5PNumtA3MRqqTNEhD3vqURcWD3cz9NkhrLqxsmDFbibfte6jPa G8lbFRqK8JStgucu2/S0+osgvlPrhvTz51kbKZ+35PGl8lYYWmW1J1RfpYaZIRAWkxTJ+9 jS/FSXQkL8hiEnYAzIoX0dS98poHdGY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740995065; a=rsa-sha256; cv=none; b=Ge35nFl28YNaGOrfFd9SmXZC6RKQ0V8jEAh7X2PLNPjSzOiONLmNhK89YvwEPxydfEQgkN yxY1k8k4CMAvywiIUIM93xmaVszNDmSm3atC7CSxlfDyI8hmJZn5pJ50v5J0khqxTuvxZb CuzRXumMjfHQKJp9dxRhN7caNo7OeDo= X-UUID: 1304a892f81411efa216b1d71e6e1362-20250303 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED SA_EXISTED, SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:640f4a1d-b6e1-4b54-99b6-4f59c703312a,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.45,REQID:640f4a1d-b6e1-4b54-99b6-4f59c703312a,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6493067,CLOUDID:b8ca024c1d5b539e7fd0599ac9ff1127,BulkI D:250303172843XSIG1O9W,BulkQuantity:2,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: 1304a892f81411efa216b1d71e6e1362-20250303 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1306028357; Mon, 03 Mar 2025 17:44:17 +0800 From: Liu Ye To: akpm@linux-foundation.org Cc: urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH 2/4] mm/vmalloc: Size should be used instead of real_size in __vmalloc_node_range_noprof Date: Mon, 3 Mar 2025 17:44:08 +0800 Message-Id: <20250303094410.437985-3-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303094410.437985-1-liuye@kylinos.cn> References: <20250303094410.437985-1-liuye@kylinos.cn> MIME-Version: 1.0 X-Stat-Signature: htcb9kpbfq3a4ixmo7izi7t986abkmx6 X-Rspamd-Queue-Id: B93DC8000B X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1740995064-357966 X-HE-Meta: U2FsdGVkX1/I07t0WHPAW+WQi5hqifpIu8/k1ULIN2CbKEGcWiiPl6ro6aCDkaBIUmxp0Xp6QNCj5hL6+OMLotKNzmfGnnI0B9iZsxzSeHvH0jgnjghsYYbOucmw2o4MATkczsX+MRVdf4K56eKGpjVtqyQ+evc9MpaZmVy7HKpzOMklEdsqs1ch0HXIk97Yfib7GGmti2LfLtzFoLVSgPtgpxqIE+3bIFGCQ5ZDFzk9WOwdHUZFuaeEnMlxpOlDgPT3JESj/r7mnFrA/R/xihwWczTe3qJ9b1hnLM48bXajJt1LcfHxMcYQJ6pbRlR7+krQhYrbDgZfgU5DdMc/uVDaQ79otdJND/9k/U44nTzpichQR9cCrVjl4CqpHEwZxoXdQSTBqdc6eWe0j7qrI7D1qWWsam7hyFuQ3ocZGwz9ysQepjxemoyGCEAdzZiXB3Aaqy0IJeoTJlQCCf96VNHq4nTbCs1woL3HGzxDY9tipvWeIo7P8hNUNHyWTE8nQIZO2QkQpsg2dT+RY4px50HC2QC0Wa60PNthILYFI8L+H9ZypXD5GzSnitQZs4wW5LEPMZB++L7PkIDLSZPHeOyI7ipxPD8lK2+xmCduvXBRpfOk2unHQ9HiPh38rl6x+Kah/QypaCfvnvE9GFBKwrU2JhrnmIx5hMY2U2h5VWY8F4Szb1W16nwNQuynQgMgdK2N/nnH65ZlCfeezwdyk2n6Hygoc0gk5WDBBCxK0J/PgSzr09fE2Oyi0xXGs551LRf6YzuTgaPAdOsr8En9HDZ54LG9nW5qDmkT4yY6Zeo+E/fH3TtrxCIOlehteERz6n+IfhjiLbEv2Qs2ILkGSZdtHeSPyifu1C/CUjg/O9HxuDMu5tkdHPVVcU3SjyHhNhwHK5mJduHionucRCT1TcbgnNZo+9PaPJMhJnjsHbaelJ7krTaW8yC2m9TeEcw/u4LkyxvdBWJJ8O04Otl fy4GwXoy 0yyUhpLKONQna02IVZZYkim23VOGUGh6Y1QEgBrekzFN0f2jA5nbYrBMVwMEeaUMIEvr4wQVWBg0c4k8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: According to the logic of the code, this should be size instead of real_size. Although there is no functional problem at present, it is recommended to modify it to enhance readability. Signed-off-by: Liu Ye --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 20d9b9de84b1..e311ee33f9ef 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3801,7 +3801,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, } again: - area = __get_vm_area_node(real_size, align, shift, VM_ALLOC | + area = __get_vm_area_node(size, align, shift, VM_ALLOC | VM_UNINITIALIZED | vm_flags, start, end, node, gfp_mask, caller); if (!area) { From patchwork Mon Mar 3 09:44:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ye X-Patchwork-Id: 13998444 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7739C282CD for ; Mon, 3 Mar 2025 09:44:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1859280009; Mon, 3 Mar 2025 04:44:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC98B280008; Mon, 3 Mar 2025 04:44:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6737280009; Mon, 3 Mar 2025 04:44:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A6BC0280008 for ; Mon, 3 Mar 2025 04:44:30 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5BEB6C022E for ; Mon, 3 Mar 2025 09:44:30 +0000 (UTC) X-FDA: 83179754700.16.2216370 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf05.hostedemail.com (Postfix) with ESMTP id 8FCFA100008 for ; Mon, 3 Mar 2025 09:44:26 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740995068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KhezJuwbDZatLoSSC+34bGME7oqW3izunjlzgVLtnkU=; b=xLmzvSIQJP9M0lMRnkFqHEHagWJc614T+YBb50Mn85jo67YS7nwj0bZyuNs1sbKEqdSltl k6veRJo91xcI3imrkpub281k8WkWwefpKCQLYkbBvpqxJcDEWHwCxHo8uB/P2PAiVrNB0J WRydZvBWvENxgUTyvGfQkWxSHfhnRQQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740995068; a=rsa-sha256; cv=none; b=0JIduw5BTKFIHHGeNUg9Wms6f/E1RVn12SsvXji/UK/u+zpnhrxSMHk+pCiymAm4V27k9q zGNmt2LIP/DRRFgVDxU83IqPiOMIc/m65bNGUIMBXcP1sx7Lx8uPSYhXlDdWE1tfhXRtwT /tLbHjS7sUDiVmHoXEYP4ujv+0OQQ+0= X-UUID: 138b381cf81411efa216b1d71e6e1362-20250303 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED SA_EXISTED, SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:5383d249-2c70-42eb-b87c-0d7c4c43adca,IP:10, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:20 X-CID-INFO: VERSION:1.1.45,REQID:5383d249-2c70-42eb-b87c-0d7c4c43adca,IP:10,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:6493067,CLOUDID:25d1d2012f27b339e62b923a1ac414a9,BulkI D:250303172846IT4R4S2D,BulkQuantity:2,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS:nil, BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 138b381cf81411efa216b1d71e6e1362-20250303 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 154557428; Mon, 03 Mar 2025 17:44:18 +0800 From: Liu Ye To: akpm@linux-foundation.org Cc: urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH 3/4] mm/vmalloc: Remove the real_size variable to simplify the code in __vmalloc_node_range_noprof Date: Mon, 3 Mar 2025 17:44:09 +0800 Message-Id: <20250303094410.437985-4-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303094410.437985-1-liuye@kylinos.cn> References: <20250303094410.437985-1-liuye@kylinos.cn> MIME-Version: 1.0 X-Stat-Signature: 5k8f5y86zo9hk9my7ynwgu5kczcsqd4j X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8FCFA100008 X-Rspam-User: X-HE-Tag: 1740995066-780004 X-HE-Meta: U2FsdGVkX1/8VL3h/TQRdzl85BKUen7ND7uAclYoW5LTPtC5jaJrV3+7On1gsxtbXHjCiCZ9tdbdzCO40okUuGZyV2nI9sHJnFLxHYGfOZK1fz/Og2+BSyWcsz95UhpprSzZaC38Mp+sc32pbiumjb+ejcUEAT6QwakG94WodS6gf7wRWhIdbhVhExN6xgxYiIn/OjW+ZTEjwhorBj/81mbEK58vQhllbBpkwgsDAjZw7sD4oJJ6DhZkBX+WC0ZJ9n3IuziflPv0QRY8k2+j8U1PuytEYvKqemnaa3sOTB74FuEMTXuBqW8Pbq9LHmpGwY1czy6Q0GAlOF5xBP6unhyV/Z93VQ45yC9PuE9Sm70W1vK0ZGzCXxYaO2rhpWRMoRy15ST2Blb300YLWyURvO7fVHEFZzdMkBqU7lHOdwwMdeZ6h4CLoQErn2KhLID4ZNI9NIzuh0q0S8iNn3X1nQy+r7bR73J/DnsAmJ4NyGpWqYRlPSMPrRzDeJJdJOG8XsZt58gMRcIbM2iQLguCsWE+3s9/E2gOluQ2EXyc0gAq4A6VDGKl8upQwgWvOaSAHIZu2Buu8W2HOSktyzBD4582AKEabsl89AmLkWvT21yN9Q9TTsTDm8ds/qgWLdJiOruYQc56sBdre/kQo69dqZT2lasl4XYRT7PGEdwPWmC3fzFsvFab6WjMvcRJwTnyx+6/n3eyoXcqm89omcsWznOrOeORh2vZeEOF/TupjS1jwMOntO0AtwjUxesWJN8bw2Nyu2txzL0Ac5MBGcoA363SBjO/xSLvUWdsdEd3C+Wf6Tky3xlHvequXyML5Cmrj1Dc/lTVegSo8iapu3QCWdAjq2xYJzLZYrx+CbatO8wJvGSx/E9tM2jhdFPcE+pbxLQKtib6cj/MUMMZi+ejZzzu0h2D0OKw1+5sMSve4Es3eCH53I+/nWrvW2zfQeA001YzGcdaCZ54ySwJp/b YS60rF0c PgNehPYRQ2Hl2q4uCDhlKl+t9TH1uQRrf7n48hWe6/qiUNRAIEg4HyspIo0QYrpP/K2TmdAIRiglOfyw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The use of the real_size variable causes code redundancy, so it is removed to simplify the code. Signed-off-by: Liu Ye --- mm/vmalloc.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index e311ee33f9ef..b4d2010e5105 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3770,7 +3770,6 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, struct vm_struct *area; void *ret; kasan_vmalloc_flags_t kasan_flags = KASAN_VMALLOC_NONE; - unsigned long real_size = size; unsigned long real_align = align; unsigned int shift = PAGE_SHIFT; @@ -3780,7 +3779,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, if ((size >> PAGE_SHIFT) > totalram_pages()) { warn_alloc(gfp_mask, NULL, "vmalloc error: size %lu, exceeds total pages", - real_size); + size); return NULL; } @@ -3808,7 +3807,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, bool nofail = gfp_mask & __GFP_NOFAIL; warn_alloc(gfp_mask, NULL, "vmalloc error: size %lu, vm_struct allocation failed%s", - real_size, (nofail) ? ". Retrying." : ""); + size, (nofail) ? ". Retrying." : ""); if (nofail) { schedule_timeout_uninterruptible(1); goto again; @@ -3860,7 +3859,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, (gfp_mask & __GFP_SKIP_ZERO)) kasan_flags |= KASAN_VMALLOC_INIT; /* KASAN_VMALLOC_PROT_NORMAL already set if required. */ - area->addr = kasan_unpoison_vmalloc(area->addr, real_size, kasan_flags); + area->addr = kasan_unpoison_vmalloc(area->addr, size, kasan_flags); /* * In this function, newly allocated vm_struct has VM_UNINITIALIZED @@ -3869,9 +3868,8 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, */ clear_vm_uninitialized_flag(area); - size = PAGE_ALIGN(size); if (!(vm_flags & VM_DEFER_KMEMLEAK)) - kmemleak_vmalloc(area, size, gfp_mask); + kmemleak_vmalloc(area, PAGE_ALIGN(size), gfp_mask); return area->addr; @@ -3879,7 +3877,6 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, if (shift > PAGE_SHIFT) { shift = PAGE_SHIFT; align = real_align; - size = real_size; goto again; } From patchwork Mon Mar 3 09:44:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Ye X-Patchwork-Id: 13998442 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01BEFC282C6 for ; Mon, 3 Mar 2025 09:44:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EADB280005; Mon, 3 Mar 2025 04:44:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69C53280007; Mon, 3 Mar 2025 04:44:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53B0B280005; Mon, 3 Mar 2025 04:44:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2F856280007 for ; Mon, 3 Mar 2025 04:44:28 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AA2BF8055F for ; Mon, 3 Mar 2025 09:44:27 +0000 (UTC) X-FDA: 83179754574.09.4419DC0 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf08.hostedemail.com (Postfix) with ESMTP id 64DE016000E for ; Mon, 3 Mar 2025 09:44:24 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740995065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xu3XcT/q3ZUKEZJzSAlmr1efgsUu5/7thCXncPjozCE=; b=VHRAeAK/BBwoSOlL6a5tAbFXUs0WilQn7s20XnnGaEtX7yXMr8csH8kmdxEM9e5frv4n7V miarKYlCQErierodgC5z3GDdoa6oBH6M5Lppxbu1A1lbAAVs6ZlYaT8zUD2gD/5aLoOane 7TBQ06CGCHwVPrdrbtqhSdUANwTsXb4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740995065; a=rsa-sha256; cv=none; b=PhhyuBOvgduEmLHIngm1q0FXL88sQQRl4i7Bdp5kE36n9eaYqrWIii1WfmtE8crEb5u/4s z21Kr6zXhpnGHL856haHMMPPEz+cnvSVxvEjPpgtwg8rL9MmRHgqxamSG9In1h1WG3sO3j tqWWQKIbwsxIoFXExdRWK/6XbO5YCqY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn X-UUID: 1414a804f81411efa216b1d71e6e1362-20250303 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED SA_EXISTED, SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:6b2933d0-3783-4a12-99a9-67185eebebbc,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.45,REQID:6b2933d0-3783-4a12-99a9-67185eebebbc,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6493067,CLOUDID:9825fa440eeca6b013ca017a2ce8db47,BulkI D:250303172846P4IK2XY7,BulkQuantity:2,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 1414a804f81411efa216b1d71e6e1362-20250303 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1860039833; Mon, 03 Mar 2025 17:44:19 +0800 From: Liu Ye To: akpm@linux-foundation.org Cc: urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH 4/4] mm/vmalloc: Rename the variable real_align to original_align to prevent misunderstanding Date: Mon, 3 Mar 2025 17:44:10 +0800 Message-Id: <20250303094410.437985-5-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250303094410.437985-1-liuye@kylinos.cn> References: <20250303094410.437985-1-liuye@kylinos.cn> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 64DE016000E X-Stat-Signature: 6y41u5hhorqrf7qhg5h9focjene1si8m X-HE-Tag: 1740995064-445477 X-HE-Meta: U2FsdGVkX1+E+69NRPJGRVIhfSZRPEp3LqJ2+Xf10ngdxgE5mtgGoy2pHFBxcsboHGJzjRK9F4ownTM1WHszw/3HCyuIpxIyEwfQPsR4DCtL88R3wSgjvxJ/nwVn5TRobb01/Gz24KR3AmuRgRdhjx/CC5Iaqy07QU9koqGMBMi3TwgPt+qlVRhnShH18hWJ0UsTH6UwspYzQXIb6btC/bdHF/Fj0eV3a6FODHGfzC9Mnf87JY+mAFHx6bI34u8fBPwcqQ6UjlYJM/Vp+cOV6ro5305IvBQQ2qigtv0zAiNWZ3znq5r0mC0kVc8CzIvoVpY+5yDLT/QsKVEcrEk28iFx7glX4sapHxv52ulzE37I1YVisXm6rTgcuAfkCOQCDMvDiuSZCAnPkgL/e3X2j2ZaQXL+6V/5cfxnZhae7ByugcDTW7YLD8NLw+lsTl2Jhq9aflYDylaU84jT+oV3ULARjmoPaW+BMpeRrHIrzqevXPWq9llT1AeZKzX79Vp/20UjZZTEpBz3z8B1iCoX9W1prEJQbmD4oeCmHjbpF9rviwHgbuW34EZajLOY85L8xAZYUOWaP9qJup0YhBQMXzNfFwRxE4nYyxEYt4lJK4ORR9Kkz9Zjqe/Ng47F4gqrb3LEmVUmeMzjFBC8gpNGwRUh44KyN791b7avsuj3rWkZ44TNwF9cOCepdft0CuH2aYIYdaVD6JJKwfRKTHeSkIoXn10VTG3thB9OP/u2U1KukzfNXEdmZ4D3/mHLcF6FnXgXKX2YQqeEjqkDR6JnnuT56X+eD00zz2OxJoH5Cw+xSHqY1pmIXGoLG1z/yP9zKyjX6rEbxpkBHQQTpbkXgJ4Uu3klp1ipkIw1GLpSJI9STTqPdXYa2yUdqzzQLXbjz0fLaZgR6LUGmYRMpIkRn97zZFum/FtQORiNmOeE8B8sBMVBJC3vnEQ3hXX+jbR1gFAKXz2Ip72RxYdJES7 XNHViLqE MBvulPCM39vUHHVosUTZd2FLkeeOUilQi1fRs2dmyoh1oRrm8UbhBssmBZhbLbJAOSi8zXkVdoD0mSJk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The real prefix is generally used to indicate the adjusted value of a parameter, but according to the code logic, it should indicate the original value, so it is recommended to rename it to original_align. Signed-off-by: Liu Ye --- mm/vmalloc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index b4d2010e5105..a8488452b70b 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3770,7 +3770,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, struct vm_struct *area; void *ret; kasan_vmalloc_flags_t kasan_flags = KASAN_VMALLOC_NONE; - unsigned long real_align = align; + unsigned long original_align = align; unsigned int shift = PAGE_SHIFT; if (WARN_ON_ONCE(!size)) @@ -3796,7 +3796,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, else shift = arch_vmap_pte_supported_shift(size); - align = max(real_align, 1UL << shift); + align = max(original_align, 1UL << shift); } again: @@ -3876,7 +3876,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, fail: if (shift > PAGE_SHIFT) { shift = PAGE_SHIFT; - align = real_align; + align = original_align; goto again; }