From patchwork Mon Mar 3 19:04:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Werner Sembach X-Patchwork-Id: 13999363 Received: from mail.tuxedocomputers.com (mail.tuxedocomputers.com [157.90.84.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4B822135B2; Mon, 3 Mar 2025 19:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=157.90.84.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741028701; cv=none; b=j+VBD6fG1KZmQNBPn2V2wxaTa+E+24yqHedIPp8AN1zI+mPBGrqpqyK1ThqBR2KmtPrj2qxDQHXjmTADQnzVTp/Y57u7CQxvGyK2qr1TX5GkzB/A7ShamH4FwjXUfgXcix3gnZtkTrTBM3Ig8G6karAfY7drpef1AWncZfyhIe8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741028701; c=relaxed/simple; bh=G/8JHaLqLPxmD3jusS29l2CkP905JdaGfKl1ipmgIvg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SSKA8c38UROIKc0aE0p7mYBXEo4Zt0jaZtXkHXw3UaCI17h6hxS1yvc7Kc/1X5AOXB2SVXbdrLl0ZvLMt87p1HB2qdHSn0yQz+CSocl8+SptjEtBJEIObs4tUf1zoYRM+ina7EiaOJMq054skG69vZT0dEwqwFVBYkm5WAGYDTw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com; spf=pass smtp.mailfrom=tuxedocomputers.com; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b=V2j29dxn; arc=none smtp.client-ip=157.90.84.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxedocomputers.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=tuxedocomputers.com header.i=@tuxedocomputers.com header.b="V2j29dxn" Received: from wse-pc.fritz.box (pd9e59f4f.dip0.t-ipconnect.de [217.229.159.79]) (Authenticated sender: wse@tuxedocomputers.com) by mail.tuxedocomputers.com (Postfix) with ESMTPA id 1E6BD2FC004D; Mon, 3 Mar 2025 20:04:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxedocomputers.com; s=default; t=1741028695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tBMdKiqoGjVHhQJLFKOiYCm8fAftQOpA414Y4wTl5ik=; b=V2j29dxnasiu6szjdlC0ly7dMTQ9BUBSuwu7s8P49LBdc0LMIttPjU5WP+eVaoMClfkG00 MmRHOiAYit9PlKAtweOY4pKXMIP6G4Tga5/aglZwln4p78R5dYI4+pIegeRLGiyUix8TNY 6rPZxWQC7BaEDQmbJ0VwoZoyOSsjsg0= Authentication-Results: mail.tuxedocomputers.com; auth=pass smtp.auth=wse@tuxedocomputers.com smtp.mailfrom=wse@tuxedocomputers.com From: Werner Sembach To: mario.limonciello@amd.com, Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Werner Sembach Cc: dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v2 2/2] Input: atkbd - Fix TUXEDO NB02 notebook keyboards FN-keys Date: Mon, 3 Mar 2025 20:04:35 +0100 Message-ID: <20250303190442.551961-2-wse@tuxedocomputers.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250303190442.551961-1-wse@tuxedocomputers.com> References: <20250303190442.551961-1-wse@tuxedocomputers.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This small driver does 2 things: It remaps the touchpad toggle key from Control + Super + Hangaku/Zenkaku to F21 to conform with established userspace defaults. Note that the Hangaku/Zenkaku scancode used here is usually unused, with real Hangaku/Zenkaku keys using the tilde scancode. It suppresses the reserved scancode produced by pressing the FN-key on its own, which fixes a warning spamming the dmesg log otherwise. Signed-off-by: Werner Sembach --- MAINTAINERS | 6 ++ drivers/platform/x86/Kconfig | 2 + drivers/platform/x86/Makefile | 3 + drivers/platform/x86/tuxedo/Kbuild | 6 ++ drivers/platform/x86/tuxedo/Kconfig | 6 ++ drivers/platform/x86/tuxedo/nb02/Kbuild | 7 ++ drivers/platform/x86/tuxedo/nb02/Kconfig | 15 ++++ drivers/platform/x86/tuxedo/nb02/platform.c | 94 +++++++++++++++++++++ 8 files changed, 139 insertions(+) create mode 100644 drivers/platform/x86/tuxedo/Kbuild create mode 100644 drivers/platform/x86/tuxedo/Kconfig create mode 100644 drivers/platform/x86/tuxedo/nb02/Kbuild create mode 100644 drivers/platform/x86/tuxedo/nb02/Kconfig create mode 100644 drivers/platform/x86/tuxedo/nb02/platform.c diff --git a/MAINTAINERS b/MAINTAINERS index 4ff26fa94895d..d3fbbcef813b0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -24178,6 +24178,12 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux.git turbostat F: tools/power/x86/turbostat/ F: tools/testing/selftests/turbostat/ +TUXEDO DRIVERS +M: Werner Sembach +L: platform-driver-x86@vger.kernel.org +S: Supported +F: drivers/platform/x86/tuxedo/ + TW5864 VIDEO4LINUX DRIVER M: Bluecherry Maintainers M: Andrey Utkin diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 0258dd879d64b..9b78a1255c08e 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1199,3 +1199,5 @@ config P2SB The main purpose of this library is to unhide P2SB device in case firmware kept it hidden on some platforms in order to access devices behind it. + +source "drivers/platform/x86/tuxedo/Kconfig" diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index e1b1429470674..1562dcd7ad9a5 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -153,3 +153,6 @@ obj-$(CONFIG_WINMATE_FM07_KEYS) += winmate-fm07-keys.o # SEL obj-$(CONFIG_SEL3350_PLATFORM) += sel3350-platform.o + +# TUXEDO +obj-y += tuxedo/ diff --git a/drivers/platform/x86/tuxedo/Kbuild b/drivers/platform/x86/tuxedo/Kbuild new file mode 100644 index 0000000000000..e9c4243d438ba --- /dev/null +++ b/drivers/platform/x86/tuxedo/Kbuild @@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# +# TUXEDO X86 Platform Specific Drivers +# + +obj-y += nb02/ diff --git a/drivers/platform/x86/tuxedo/Kconfig b/drivers/platform/x86/tuxedo/Kconfig new file mode 100644 index 0000000000000..e463f92135780 --- /dev/null +++ b/drivers/platform/x86/tuxedo/Kconfig @@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# TUXEDO X86 Platform Specific Drivers +# + +source "drivers/platform/x86/tuxedo/nb02/Kconfig" diff --git a/drivers/platform/x86/tuxedo/nb02/Kbuild b/drivers/platform/x86/tuxedo/nb02/Kbuild new file mode 100644 index 0000000000000..8624a012cd683 --- /dev/null +++ b/drivers/platform/x86/tuxedo/nb02/Kbuild @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# TUXEDO X86 Platform Specific Drivers +# + +tuxedo_nb02_platform-y := platform.o +obj-$(CONFIG_TUXEDO_NB02_PLATFORM) += tuxedo_nb02_platform.o diff --git a/drivers/platform/x86/tuxedo/nb02/Kconfig b/drivers/platform/x86/tuxedo/nb02/Kconfig new file mode 100644 index 0000000000000..bed56276b9b36 --- /dev/null +++ b/drivers/platform/x86/tuxedo/nb02/Kconfig @@ -0,0 +1,15 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# TUXEDO X86 Platform Specific Drivers +# + +menuconfig TUXEDO_NB02_PLATFORM + tristate "TUXEDO NB02 Platform Driver" + help + This driver implements miscellaneous things found on TUXEDO Notebooks + with board vendor NB02. For the time being this is only remapping the + touchpad toggle key to something supported by most Linux distros + out-of-the-box and suppressing an unsupported scancode from the + FN-key. + + When compiled as a module it will be called tuxedo_nb02_platform. diff --git a/drivers/platform/x86/tuxedo/nb02/platform.c b/drivers/platform/x86/tuxedo/nb02/platform.c new file mode 100644 index 0000000000000..68d83b9b4c2f5 --- /dev/null +++ b/drivers/platform/x86/tuxedo/nb02/platform.c @@ -0,0 +1,94 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright (C) 2025 Werner Sembach wse@tuxedocomputers.com + */ + +#include +#include +#include +#include +#include + +static u8 tux_nb02_touchp_toggle_seq[] = { + 0xe0, 0x5b, // Super down + 0x1d, // Control down + 0x76, // Zenkaku/Hankaku down + 0xf6, // Zenkaku/Hankaku up + 0x9d, // Control up + 0xe0, 0xdb // Super up +}; + +static bool tux_nb02_i8042_filter(unsigned char data, + unsigned char str, + struct serio *port, + __always_unused void *context) +{ + static u8 seq_pos; + + if (unlikely(str & I8042_STR_AUXDATA)) + return false; + + /* Replace touchpad toggle key sequence with a singular press of the + * F21-key. + */ + if (unlikely(data == tux_nb02_touchp_toggle_seq[seq_pos])) { + ++seq_pos; + if (seq_pos == ARRAY_SIZE(tux_nb02_touchp_toggle_seq)) { + seq_pos = 0; + serio_interrupt(port, 0x6c, 0); // F21 down + serio_interrupt(port, 0xec, 0); // F21 up + } + return true; + } + + /* Ignore bogus scancode produced by the FN-key. Reuse seq_pos as first + * byte of that is just the "extended"-byte. + */ + if (unlikely(seq_pos == 1 && (data == 0x78 || data == 0xf8))) { + seq_pos = 0; + return true; + } + + /* Replay skipped sequence bytes if it did not finish and it was not a + * FN-key press. + */ + if (unlikely(seq_pos)) { + for (u8 i; i < seq_pos; ++i) + serio_interrupt(port, tux_nb02_touchp_toggle_seq[i], 0); + seq_pos = 0; + } + + return false; +} + +static const struct dmi_system_id tux_nb02_dmi_string_match[] __initconst = { + { + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "TUXEDO"), + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "NB02"), + }, + }, + { } +}; + +static int __init tux_nb02_plat_init(void) +{ + if (!dmi_check_system(tux_nb02_dmi_string_match)) + return -ENODEV; + + return i8042_install_filter(tux_nb02_i8042_filter, NULL); +} + +static void __exit tux_nb02_plat_exit(void) +{ + i8042_remove_filter(tux_nb02_i8042_filter); +} + +module_init(tux_nb02_plat_init); +module_exit(tux_nb02_plat_exit); + +MODULE_ALIAS("dmi:*:svnTUXEDO:*:rvnNB02:*"); + +MODULE_DESCRIPTION("TUXEDO NB02 Platform"); +MODULE_AUTHOR("Werner Sembach "); +MODULE_LICENSE("GPL");