From patchwork Tue Mar 4 17:05:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001251 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 195D5C282D9 for ; Tue, 4 Mar 2025 18:31:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M1Zs+DHu4keoQ7nH0HfotkX9qiVtwoVoQvIhvtnI4DA=; b=bgRDcQFS2HWNxoPCfr5+kdWVRO PIZFtqYJIKVyFbEslYaxhjokxa31MJB1d+vBNRlmzJ3usIXdzJBH7WX/Lw06reE9fi72Mqzo63ZgB Mvo7XVYZrEFbbqZn82vliu+o/u1xuiYVM0hDJPR8GZgh5ypE+2LH2QIGQSuci5GcQIG88OC07zANw AFkmUnzR2+is0SY71DEQS4QFSvN5u+mr6B0nStrNuPnwa4Ue822TC+nJGPlPl4cNmSV80JF5Hx8l4 luti63B6i1zIDq8MXF9wiVOdmAjWz4BMtJRUQTRbxujSg0sNAZW9Nlit9am2acZR/wMeXPBYqZbbA qNN69cPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpX2Y-00000005r8R-0EPc; Tue, 04 Mar 2025 18:30:50 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi2-00000005Y8b-1JrQ for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:36 +0000 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-390e3b3d3bcso6933930f8f.3 for ; Tue, 04 Mar 2025 09:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107932; x=1741712732; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=M1Zs+DHu4keoQ7nH0HfotkX9qiVtwoVoQvIhvtnI4DA=; b=hC8DY/E0iJrbQ6B5sTX1MfLAaFia3ogm1eHufZbXq18YcJ9qsGdMLGPvP4CEqmkqXY rKme/EqkXuJhx7Cv4yx/2/Cn7a+JiJIPULm+7LpRXf5eipc2lmMvE+uTdVNiNj80RsSJ I2z44wv2KvYsDfSB3MPdpIySbPi90bmTkLlQnCMUCrnnmh0KHVbqB/l+KAmcsf8ZsF04 IDWm4umDTBORk6jDIA44SsSdFIoY10YFpcpXiOnJMXAesJ3yJsyd35kcX3tfPjTisyt4 zP4YCqJy042ThfWYAoMrRkZK/Co4vXGfKjPgfN3QQKuS6aruBTCq7vCn/Szjz/Xt0E0x EKdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107932; x=1741712732; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M1Zs+DHu4keoQ7nH0HfotkX9qiVtwoVoQvIhvtnI4DA=; b=vKT2vJQW2l1IyATF7uGof8f2VCi5y8htXAKnPO4Y9zEx8aOeZt9f/3mmuZ9r+53STm ERDvVUWLQ++UP3cJpL98RYM1JcjOJm2x8uCWP8Ul78YZsoH0GH11o8NN0bO8gXp2ff2W NBRfUBlei2cG+am8QAeiG+0naQ0Hy/79vD9jwj31Kjtrd2BtziDr8rH8Bu47EYrGK5KA rSHJJpLC4JIcBPng0we5Yb0+PDSIL4K4UApkmto+sfqAryhb+jjO2nvgsSNLnNx2IwB+ 7MW3Kjp+WIxrTIHxwHnVFuOgPp+twfQVQ3OrfSjfAY90BYTZnsq31thw+wr/7Uiv+LxW vZdw== X-Forwarded-Encrypted: i=1; AJvYcCVkH+TElnHjzQ17aKDz9NbTG2UafwySYcZUYDL7jjd3z8xjvyjxXrlRPPj/HkUurRM2bzvDA8X8L9fRunKNPRA4@lists.infradead.org X-Gm-Message-State: AOJu0Yzw3jmaagz8ClPEdYBrdeoEPk69QvnaukGSWG8cojOGICTykUiR Y5RuvbKmCHdp/KaKx2xaobcCDzHfJYn2zL2jAbo4sbrWky4aj+qcB02WB7TvaS0= X-Gm-Gg: ASbGnctBTwxWbVXS2BHtlT2R6Z4DIiGWJhLJndUjNBpU+M/O8wB7q/P0mhc7gzjsiHp w7TuoqYsjoxbsvF2jNgYnOPbRyTF33uI21mpmhXHNKl1B80MUzUxNO8Xx3TzYCYvLdnQfGLEdF8 cGKn2m4e7c3HaqkVO0+u9KuKVqHau7apnpZp/9Zfj9vvEJKZ+/xXCZrHE/1QxDkkisXYiU28E5e SSqQKpVQs7xI9ys9dB5gwy2ppSoU3tA+PXj9lyokmhGQD7w2B7wLEYYxhg9ZVqlA+Qs282JgX7a U3CLOP2oYTZwbiVupoYRZc7/GuDcbkmPrf2aiTuxRrQeuxz1BNyBDLaQVDlRw62Y2sSzjVsYf9b nwuilGf+kK64AOIJ6j07K+6101nvU X-Google-Smtp-Source: AGHT+IHSc8pjwattEBJyeHF3OjOkT41+G9Y/Rh1pozPSubIjG3eC8i5kYIqu87xMZCHZm4ULB7j+yA== X-Received: by 2002:a05:6000:1faf:b0:391:888:f534 with SMTP id ffacd0b85a97d-3910888f656mr7939190f8f.20.1741107931986; Tue, 04 Mar 2025 09:05:31 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:31 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:29 +0000 Subject: [PATCH v2 01/16] rtc: max77686: drop needless struct max77686_rtc_info::rtc member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-1-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_090534_359716_4DA9CE28 X-CRM114-Status: GOOD ( 15.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When this driver was converted to using the devres managed i2c device in commit 59a7f24fceb3 ("rtc: max77686: convert to devm_i2c_new_dummy_device()"), struct max77686_rtc_info::rtc became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- drivers/rtc/rtc-max77686.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 7bb044d2ac25aeaaf2404b47b7e7bd485ae3d39e..6b0d02b44c8097453f704cbec9f02580fb869ca3 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -85,7 +85,6 @@ struct max77686_rtc_driver_data { struct max77686_rtc_info { struct device *dev; - struct i2c_client *rtc; struct rtc_device *rtc_dev; struct mutex lock; @@ -691,6 +690,7 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) { struct device *parent = info->dev->parent; struct i2c_client *parent_i2c = to_i2c_client(parent); + struct i2c_client *client; int ret; if (info->drv_data->rtc_irq_from_platform) { @@ -714,14 +714,14 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) goto add_rtc_irq; } - info->rtc = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, - info->drv_data->rtc_i2c_addr); - if (IS_ERR(info->rtc)) { + client = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, + info->drv_data->rtc_i2c_addr); + if (IS_ERR(client)) { dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(info->rtc); + return PTR_ERR(client); } - info->rtc_regmap = devm_regmap_init_i2c(info->rtc, + info->rtc_regmap = devm_regmap_init_i2c(client, info->drv_data->regmap_config); if (IS_ERR(info->rtc_regmap)) { ret = PTR_ERR(info->rtc_regmap); From patchwork Tue Mar 4 17:05:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001253 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FAE1C021B8 for ; Tue, 4 Mar 2025 18:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VXesqtK3A8i6ZSMFwP8n6Z6kZDUFNsTogrZxF0Gh9Ac=; b=xi1oKGolvWLoq65u8Uy4vY0Tjo SV3Sxreu4fFh9j9WXbDHcMpvAuqrSSVAziU7v6DUFthHKUMYbvjIU2Dj4kZtR31YuOmDxRpkmZdXB wdVPGE+8xuyT67uPfqFKh557S6y/EttfPI+uTjFN6/QrQrHZA0rHZG/als2XyIHxkt6P65j5KqMbf 9pL5j6ghQPeND91OTxhj3Iy3c+P2cdFh6FPm9jNheDTR3CE2jc9FjvUH2UYBUd0bbRM+jpICbhP9+ ebgvBFCDlL4ayiKrxG/BCA31wPc6BPy7AyjksbpcNgJrkJrpOjnJmPHXlw3PmtKffjysV0RfbSJSQ sT2dfPSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpX5e-00000005rle-0WDk; Tue, 04 Mar 2025 18:34:02 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi7-00000005YCC-38Gh for linux-arm-kernel@bombadil.infradead.org; Tue, 04 Mar 2025 17:05:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=VXesqtK3A8i6ZSMFwP8n6Z6kZDUFNsTogrZxF0Gh9Ac=; b=OesPi/4ZRbyYcG+bra1pr/zvJY xxg0WQaB/ZYtKV5nT/zGLUy/w3D5TB6VUsV3iP9LJrtGEmokEYHa8zeP4EEjzAOVOv/37HWtgR99/ VBxpW5tcqUB1hxw0cmOrllWJwoStu3ejY+l2JtBb7ccCII9caOpbbVy1VUXe+x4w3N41ygDbDOiXa BvNHrEVlprbH2cT2gnqzGvtv4UgWkmEgfoK8+TozMOZWcPyoZZojVZLqWNrjTwMq62szS0EMikVt2 0uot6rq8eN3JlOTmSE8vwss6Ge9GDk7Gyn78ic26UMHeeW60Q9eNozt6y3AURxvaC1pZ5LQto1TGa lj2Ntxug==; Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by casper.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi3-00000002Cwy-3NT9 for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:38 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-abf57138cfaso615817766b.1 for ; Tue, 04 Mar 2025 09:05:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107933; x=1741712733; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VXesqtK3A8i6ZSMFwP8n6Z6kZDUFNsTogrZxF0Gh9Ac=; b=Tv+6R42k9+VdSPd0W031MI4Ake7pCBNw/np5w+TFhNNnH3KEfHG2047cYBtMysqwo4 M+sYPr1LaXMNmAGXDWAAwhw6Yw2ohfJSMhPxROG9uaNdfrJvC8OE15yW/fL3IUL2w5PJ Oc6KxiGGzj5b+L6G5KSVEG4JE5eqfetlyZXvJek1pYV5zI33mUOwdEvGWbi+0mY9PBoR MeBBxb0R+gmWCmxNXeqI6i4r4AvhU7DTtY06C85kaPo6c3ZPp4OYSgq9Pc6NZTlj+93y L6E/ogHM5WB8h2yqxiet7s6KSx/v8VamxlZsV6M7eNX6XrqjwCloKwDZ6zW10peMNmOy jWFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107933; x=1741712733; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VXesqtK3A8i6ZSMFwP8n6Z6kZDUFNsTogrZxF0Gh9Ac=; b=EVBNtG6ptYkgWJj3OYOLuouX1x7RoGxwEGcIt3Pw+6tnfKe+/eku/FpR0moWMwRFYs 6rwxjvHJujtL+2DWPF0S7DeE1sARnzrtA/Z5Xz7dnQ/TJZYCEmFR/BnUpHPOKDE1d4Pz bSwJPcauPyk6D/TITosIDx9WRWQ8UHO9IZ6oWFfTk9xbzUmQh+/Yj2fqZ+126fS5YZ/z 2RCBEhbJEHVlPXzVREyvi8y4GdfreLI+I7IOBdsD97MjE58PwOKKVxTgAjgKkZOAEU/H 9PhcKnhl42OQHdHVwcpiz9pj2YuyEjmNMRFyfD5Tv3Su20Czq4/m4xEJ6ilAcqEPTJF4 y1+A== X-Forwarded-Encrypted: i=1; AJvYcCVaFsTj82/q3q49sByTnVLLipAariAxiXnNMg20RVcMr0iKOIn+daGJktEcATqFllHu8bjYezqoLrelGu7NYRRg@lists.infradead.org X-Gm-Message-State: AOJu0YwYR4jcteG7teJTtXH6jZB83iUMg3fCMNEgIriWTrvL+I9ZdPbL 3mM+DVT1KRBCsR+LymQ9F/mI2YHVZJw3pSDRjmyGgx+Z7PUXsBYmUAFQlus7BZE= X-Gm-Gg: ASbGncv72us4MsN8BJMQwEebx9HxYKiXfzH+paoItvBG2lpbX9yFaVP0wWW3bT08PQ5 ROUNwDjkDktw46hmvVq3A+8Tuqu2Hd+5pZQWqFXiplFZWjU9P8eLJpgCvixT7gLKbQI48MUc9BG 3xd23G5G6wxmkL76br0sZFY972aDP71brlu72r4RbfuWg4/sVm9IE69G5SMz+f5aueO8kcA5LZT peP8dTYRbKpPeX6dZ9BQPML5wj0WFy5/0SyE9IhipFzeINuTvL0adVXEz9p0xoWLpqfx+jOCO5x +Az6NYMLIFKqkqeDg59OAsebOiTvzN/kH4lhyMon/nWqFTIzukI+B7ufd7zrDzkeKjkqmCTFHJk x++RZpdVspYF9uxPfshM+qNL4L6uK X-Google-Smtp-Source: AGHT+IHVbcY6l9+JTAHHIw3fmIWanoQo+sapqWdolutCogJsq5sGcHSbYPT4D1lGvFYrwfxZJsMGVg== X-Received: by 2002:a17:906:f5aa:b0:abf:59a3:df19 with SMTP id a640c23a62f3a-abf59a3fa56mr1580793966b.57.1741107932647; Tue, 04 Mar 2025 09:05:32 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:32 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:30 +0000 Subject: [PATCH v2 02/16] rtc: s5m: drop needless struct s5m_rtc_info::i2c member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-2-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_170536_009651_D545FBAE X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When this driver was converted to using the devres managed i2c device in commit 7db7ad0817fe ("rtc: s5m: use devm_i2c_new_dummy_device()"), struct s5m_rtc_info::i2c became essentially unused. We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- v2: * fix arguments to devm_i2c_new_dummy_device() - too eager sed //, and gcc didn't notice, only clang :-( --- drivers/rtc/rtc-s5m.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 36acca5b2639e272dd9baed06ea5582f635702b0..88aed27660348a05886f080a2848fcabbf9666d0 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -146,7 +146,6 @@ static const struct s5m_rtc_reg_config s2mps15_rtc_regs = { struct s5m_rtc_info { struct device *dev; - struct i2c_client *i2c; struct sec_pmic_dev *s5m87xx; struct regmap *regmap; struct rtc_device *rtc_dev; @@ -640,6 +639,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) { struct sec_pmic_dev *s5m87xx = dev_get_drvdata(pdev->dev.parent); struct s5m_rtc_info *info; + struct i2c_client *i2c; const struct regmap_config *regmap_cfg; int ret, alarm_irq; @@ -675,14 +675,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) return -ENODEV; } - info->i2c = devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, - RTC_I2C_ADDR); - if (IS_ERR(info->i2c)) { + i2c = devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, + RTC_I2C_ADDR); + if (IS_ERR(i2c)) { dev_err(&pdev->dev, "Failed to allocate I2C for RTC\n"); - return PTR_ERR(info->i2c); + return PTR_ERR(i2c); } - info->regmap = devm_regmap_init_i2c(info->i2c, regmap_cfg); + info->regmap = devm_regmap_init_i2c(i2c, regmap_cfg); if (IS_ERR(info->regmap)) { ret = PTR_ERR(info->regmap); dev_err(&pdev->dev, "Failed to allocate RTC register map: %d\n", From patchwork Tue Mar 4 17:05:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001276 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77D45C021B8 for ; Tue, 4 Mar 2025 18:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=tlM6qlJvDbB399QfH8my6m79aS 6ftZWVN2pGMaqZaqTbjuTSzmbJNz1QaJItskozfdN/sVHwva/stNhXtxOsHtL723ybcpsU5nMKDwN UD8rzme0/gO+GIizGIrsQU9/1h65TU9OLuC42mML0qAdM0qMu9IUfGtsYpA+WLB3qoJOCF8eNPWcf KAiUWrwlYP8nJa7C9Xzq1mYkqUYdYSUqPVrzJlVK2d064PfPXNodtQZyGzcuYs7JmxRnzWryn8ZXe f79x56eSNzebt5D7Hz4pU4b6SlZMvYZKPrFncr5B5yQmwBeZnMpwIcEr0cGfiq9yxNA17XnUmfv0f Pgy74ZBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpXI0-00000005tXy-15z8; Tue, 04 Mar 2025 18:46:48 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViG-00000005YGd-3Hbn for linux-arm-kernel@bombadil.infradead.org; Tue, 04 Mar 2025 17:05:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=keYM+f65vDh+BwPeCuIDv38QRE nOTg3qv16kkH/X/UQDV0sn683ixzcqGaILoxXUPPltGF+ItpDfFm03b411QYb6UAon3sYFa+nJFF9 Ag6TQFpCx++By6/zG6yoJsudy1+o56OLSrmv086EOg1wbvs1JyYujZvuMooh8o9r3hKYo4ScRvUpH x65rl5ycrGkD9v4a0rbgiJ4D0DcZ9wKyPEHIBOHUe3AdWGsYlZVkNPyeEsSL+jdGNvRiVHLOaBaBW 1DYlYxYCrS779pj3fZoAGwifh/U9uwUbQS23dpQTj5aeUVWt8faG0Xv3laNvPzEsuIMXP+1dliAOO AhMJjjwA==; Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by casper.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi5-00000002Cxl-1uKy for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:44 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-abf628d653eso467227666b.0 for ; Tue, 04 Mar 2025 09:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107935; x=1741712735; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=LE+eh+IMTG1vJanP3LeJtNRN7CWgGUjkzdTVt1r9Iw3iQAOkp5QtV0hoIAaDH9ExHM 0+EnJiQ5WpFuRx5zc5yyAXOH5/EemTAnI8iMsCALshbLOwBwO0oBihjBPxLm63lBhwEV JNTEn84o2CwyM9mYUxR7swcde0Zq90LnO0BQQD8LmN8YgeNamX6qf7/eaijiVdaA2jkN Jw/oQ27HFXEhoRt5X9zBhw41j3wXcMnYjqbE3arsCReRyx9PnbTVx4sw2Olg6wFoRip1 +SiHu7X6OQO6fosBb1G/wWaNKNvjUov9YqszJIbrhW3oNvypKfcvQtdhFhI4LMW/A7dd W37w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107935; x=1741712735; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MzZ6ILzSkM4BJ8jDBuhIko6B+Jnu0p3f7pMZfR82Jo4=; b=qRskdGZqxFOZjSmmoDviYDsnyHaiR++5utsf93pJuJ7VzLwfxgOHbSYB/IGluoakqs 3Kxgbt8yLsji3R213KHgnfxClMbJQavWCPK594dIexQV+nij1UPgQXlGTdU5ucUOsIc8 ZoFbOD3IVtDrnVqakDWtStr8ACC148h8u50VEnvKXngXFZmHP+aSeqHy2MJNtUb6uO1j ZyYGKdu3I6sqXo44+PY/jWvejpdttCkA0pVLGfnEiV/ETHkwZJ4Dv4tjlTgWAgyVNGit UwFy1sQpPHNXcHoBW2r0WZHAviljQVkqzRn2F37C0qcIe6M5VpqSXM9T3HjLtPgSczso /QSA== X-Forwarded-Encrypted: i=1; AJvYcCUvLCembhPOq4eSlBms9qqdBnhr1rabyvQnGlR778s7q+1Xkr0bHyW01W9vXvSYVPFnjZp9sSTxwdoXnCdd3V5X@lists.infradead.org X-Gm-Message-State: AOJu0YzDkEzprA6A1RZMAFr4Mqe/1qVnGsnHhfZQE1gAv78JvJKHzmkl ccOLBUUD84nWL+GCeoaJUj7KVRIwH2nlChalAzFt9AzXRAKB34Jkd3ehZRzmYms= X-Gm-Gg: ASbGnctcssbWsggHnspkTXlSplzH9rV1hB3IQTskAP+pHurxo/d3DF1707mCdZqb1iC uG8o90kN8tMsK7sSn/X8r3BZrGJGBgqpgY8T1jg+8e/puv8bVCzMcSjPFkTH9UD0XGNXLyeRkvg Gmox5egKhMBTii/4pw+ojA7EPOBCOE9Uaxpn6uohvSgO+okuwjGD5cunPE8n+wL/wDKYsFQutk/ lfi4fTrwYUjjzm8BDavtxeEmfGq6OrY4WfDCc3Spo90YT+lq4Ekm8l9Z9v14ETw4LhcjcVAvJgs DsXwMZhN5XlhQmtWeEmWtHhrGr3uLmJb9mILCX2KX6WkT3uGQ5Rcpr66+DnNuvzVtW6w6rU1quS e2a3m8XuNgqlitWfNJ6GTEG40US5P X-Google-Smtp-Source: AGHT+IFwDsDh5i25qijWXwIP4x1jml1OHqbOIRoS6nzVQBGxqFZ6SJJ2B5idZS+kqD7e/PzkpEaGBA== X-Received: by 2002:a17:907:9490:b0:ac1:cceb:d9b0 with SMTP id a640c23a62f3a-ac20d8bcf0bmr3896666b.16.1741107933256; Tue, 04 Mar 2025 09:05:33 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:32 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:31 +0000 Subject: [PATCH v2 03/16] rtc: aspeed: drop needless struct aspeed_rtc::rtc_dev member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-3-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_170537_952667_7971A7B5 X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-aspeed.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-aspeed.c b/drivers/rtc/rtc-aspeed.c index 880b015eebaf796f68ed82c29998f345e1fd418b..0d0053b52f9b90a61725bf29435bfc8071977f9e 100644 --- a/drivers/rtc/rtc-aspeed.c +++ b/drivers/rtc/rtc-aspeed.c @@ -8,7 +8,6 @@ #include struct aspeed_rtc { - struct rtc_device *rtc_dev; void __iomem *base; }; @@ -85,6 +84,7 @@ static const struct rtc_class_ops aspeed_rtc_ops = { static int aspeed_rtc_probe(struct platform_device *pdev) { struct aspeed_rtc *rtc; + struct rtc_device *rtc_dev; rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); if (!rtc) @@ -94,17 +94,17 @@ static int aspeed_rtc_probe(struct platform_device *pdev) if (IS_ERR(rtc->base)) return PTR_ERR(rtc->base); - rtc->rtc_dev = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(rtc->rtc_dev)) - return PTR_ERR(rtc->rtc_dev); + rtc_dev = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); platform_set_drvdata(pdev, rtc); - rtc->rtc_dev->ops = &aspeed_rtc_ops; - rtc->rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_1900; - rtc->rtc_dev->range_max = 38814989399LL; /* 3199-12-31 23:59:59 */ + rtc_dev->ops = &aspeed_rtc_ops; + rtc_dev->range_min = RTC_TIMESTAMP_BEGIN_1900; + rtc_dev->range_max = 38814989399LL; /* 3199-12-31 23:59:59 */ - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); } static const struct of_device_id aspeed_rtc_match[] = { From patchwork Tue Mar 4 17:05:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001270 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E81DC021B8 for ; Tue, 4 Mar 2025 18:43:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=x7XUHtgUzASA1FelmBZNEeOv3j vCOlRpHxDh97kltR+0DPgcxJ3bhASb+GVUWHbFz4OxvbgCIcegH1TfBihNZ7NfhOJdmLR+5PEorjN sojNgxVj7qnG5roK/OZfUelqrw8Ei2So2F70vkAW+RJoxRLLze2Lp/jpjK/xFhNb5lHi3pHEcTB9R 5pxbopsqv5Uwk1KpDyGxRjccE27vfY4Ru20BgXG+2vJDmZ2h4ZZhSJgGKh0D6AOu71javWbPnbnsZ J9C5vYsAbjdfz32vrZiObDOim5OLnN8CALwtf2d82HpOMdsEl6eZrMOBVkHghqbvgpx0Xh5CFPY/6 2mCQI1uA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpXEu-00000005t6L-18Pe; Tue, 04 Mar 2025 18:43:36 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViD-00000005YGF-43v2 for linux-arm-kernel@bombadil.infradead.org; Tue, 04 Mar 2025 17:05:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=bQQszX39yxgp3p66hYi440F0zx cZzrOlsldi3Q0JskZa0xOJo4o5uxiZoKleaoJPOicRAxnqotXibsK/0kOZQUWZseLqZ2lL3lztkkr Mfh++TpNeFLGMcR6TIQtmfEmO2RIerJGyUwi2EUjgFGSYLlGbcTVQuBRDRKevaM/DvUsC9NXmi8cU P0oTnXON/WSRHvL7Cca7Cc9vYaxZDYTg8aKIT9l3zIgi7MskaVc8Bh1LkzN1H8iDXQlqtSY9sfs+4 rcnO6TYy7SeU+jI2NA5LZOEHU9ahr4EmsK4hNIdIo7IcaWZMb5Y7UwZVcpkMUImuUh8abvKcZqClH GlXtvQyQ==; Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by casper.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi4-00000002CxN-2cgg for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:41 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5dee07e51aaso10982786a12.3 for ; Tue, 04 Mar 2025 09:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107934; x=1741712734; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=kuAd1/dKo/4AHvwOMLmrfBaSb4+a05OJVDllMApD/dEdL+qY5LNLHXnRf4FOjXnVUE cZhUm/IDYhzVIioNL66Qv5rl3GVA3qpzDD3cSyXrnsIuIITtv5hOO16wjdCyLUQJSUrV uWMDrONpTjN83pe5ylwRKKpHMYVF0FKCMwGVGdpAbWaXCrbfR9Kmc7mFIxN0ZImLSr07 HR6k27foVimjCSvhrSPO3+L3+9kbhQI3sQZ+dMtRpRTt7izhp4Qpvly/6mGcyyUh7DFK 2/fX1GfmWJawjSu5KB6BsCzCCtwjDyl91NfXbA+A8ZTVOYpWa3ZDJxmxnazveCiCvghb rj8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107934; x=1741712734; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PnUvUu9cMY/Mxw4Q1sllPthcln3NtgGY7cjKJANyPvk=; b=P79rhSyJ7wDdW76A5/5m1U0unx3vvIZEFaCSfQ/juL5zSTGIES84DOXmfLGTLnykF1 n8+o8l5PoRO/n5FzrTuM7fOi6Q7bkghDAU1DHidYTkq+Hn7VZVR7Na0vLo4l+oNmyFnV PnYLtFpkCHbtwSSU1x4bLwSIkylG+Z1pbcgvau3Uf8YJd7areSQyXS6oZg8Fg7kOQfxp Rd+Gha++aKn9lvH//Oklocb1mp5AXmxaD+SAsG4IdG7jg4umI/9AESSz3HH6/Yl9FVZB YPlENrDkb5MnPN0uIxV+isv6giLdA84GJzBYOG70VMSBdh23LxTc2g8C+kDgy+Yes3m9 i1qA== X-Forwarded-Encrypted: i=1; AJvYcCXjpV5M7nT4JlGMjIF3Ku0m07YYxB0bvRSkQM+u7SwSh2LOLux+tBdk1LyEQipVg8hy4qem+qjQ3q9ZtRPgSfx7@lists.infradead.org X-Gm-Message-State: AOJu0Yz2pz9fazhze2hc1Q+KHIF3vf8ObNgh3Dcfpfrs4thLcYbx4U5C r2HVnCJoDmbs91Dai9vXgxQDho2KrZbrsZzWjaQj/3zOMG/V7AGdtvOU0dClvbA= X-Gm-Gg: ASbGncviPiZ6yOHzNcpqm1VkOKEPNcf+f8H4jLMUfYggYhpN2G2TbyCGIaNf4z/KrN0 x5QRt1Ln8xURrV9rzwUlvs6cNJSPns1dzwp/OOoLpEHvcEVxjAebV1awN2KSrWPLNR4OWN2j3iJ yokKHSVYAMoyZvyJri5E9JmVYyGurb6Wl/YHAha6gWF7o935N03bwq5NP+cqL4UjJUmCJCP7999 tCRwqgwh58xEZCqEiCCisSy866+cg/egff0Mg+b7HlplfWRRV5nt27ZrGbU3I5bLqIc+Ii7Q/jh HO+BWzL6vkfQcacA/6nDMqssHwrB0quz+lVWWf0NMsDTZLPk9oC3JsyZRiVn7U4ozAWCWsnS+Sj zxrVIlePwlop6gM6kMR2//kEEw68L X-Google-Smtp-Source: AGHT+IH7IWkH6sGgCqXOqo1X+qUMKDFtMNOejwKoQaGxlKvxwXw1Icl3WBZaF1ebexseFdyLVEv5Qg== X-Received: by 2002:a05:6402:847:b0:5e4:cd5c:50f6 with SMTP id 4fb4d7f45d1cf-5e4d6afaf1dmr21403911a12.18.1741107933866; Tue, 04 Mar 2025 09:05:33 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:33 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:32 +0000 Subject: [PATCH v2 04/16] rtc: ds2404: drop needless struct ds2404::rtc member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-4-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_170536_937720_FAE09868 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-ds2404.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds2404.c b/drivers/rtc/rtc-ds2404.c index 3231fd9f61da49bdaf00e46486fc34836094ee78..217694eca36c3432a8db3b874374e347eeb802d9 100644 --- a/drivers/rtc/rtc-ds2404.c +++ b/drivers/rtc/rtc-ds2404.c @@ -31,7 +31,6 @@ struct ds2404 { struct gpio_desc *rst_gpiod; struct gpio_desc *clk_gpiod; struct gpio_desc *dq_gpiod; - struct rtc_device *rtc; }; static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pdev) @@ -182,6 +181,7 @@ static const struct rtc_class_ops ds2404_rtc_ops = { static int rtc_probe(struct platform_device *pdev) { struct ds2404 *chip; + struct rtc_device *rtc; int retval = -EBUSY; chip = devm_kzalloc(&pdev->dev, sizeof(struct ds2404), GFP_KERNEL); @@ -190,9 +190,9 @@ static int rtc_probe(struct platform_device *pdev) chip->dev = &pdev->dev; - chip->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(chip->rtc)) - return PTR_ERR(chip->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); retval = ds2404_gpio_map(chip, pdev); if (retval) @@ -200,10 +200,10 @@ static int rtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, chip); - chip->rtc->ops = &ds2404_rtc_ops; - chip->rtc->range_max = U32_MAX; + rtc->ops = &ds2404_rtc_ops; + rtc->range_max = U32_MAX; - retval = devm_rtc_register_device(chip->rtc); + retval = devm_rtc_register_device(rtc); if (retval) return retval; From patchwork Tue Mar 4 17:05:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001271 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89D44C021B8 for ; Tue, 4 Mar 2025 18:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=OUaiMuYInOQN4Jd2uteWHgJkdd thL7CdIN11Z07MA8S9zw5Yi6TXFbF8KPnFDdzj7igSP7Wk1HiWiAiV+XH9gXN6IFWt/ZH01VM82tF iSI6Yf5z/fvqd88VQDgKlZG+OqKwan0cUDXD69OsO2BuDdim5wuQv/3jWLq4E1kIB1PNe/r6oBxzx E1OGd8vodSZtPU6ZKEq4V7MlZqGjgkEyi8JLu+W5o65F/0bqxzQgV/a/cEGnCzH+ahaQDcuIEGuVk Xcab8syEHR5SMLMoncgJZp48tiJhZqA9G0bCmcGbyw+EhxChxEaQkr7GgeEpp+cFqBlEfFHBggOwC +I4V+xMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpXGS-00000005tKa-2VhC; Tue, 04 Mar 2025 18:45:12 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViG-00000005YGc-0bYW for linux-arm-kernel@bombadil.infradead.org; Tue, 04 Mar 2025 17:05:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=a92QYQKHhg1ZCOQDQpHjVTQsby qxVMOBS3v16UCiKJRR2D7A+3LZd3xQEKF9qkBPSYV02/Bqnrxwqr9Y56eptHt+grBNAzfCETrt2eh q3Tm3QKg6VD3USR4BqiUx++b5sPp+xGt6hLM2rr36bpKna4mgF39mUI/Nm7FWolv1KfdQwwiIcdOk Odx3xR8X80krg8Yz7YNBz+qGFiTFPCWqRMwlIAAE/57kYkXyPfKU3B4L1f5FOSEEsFLzptFXd+Fn+ p+wWYdX3eGOoVyI6yNtrWqnhLu/be9WLwk6GX9E6/+ROfOTzb/S3osiXTE8UphTsWjlgHHjzWf7bX VmOEEJOg==; Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by casper.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi5-00000002CxU-0z9i for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:44 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-abf4cebb04dso643803666b.0 for ; Tue, 04 Mar 2025 09:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107934; x=1741712734; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=HTuCJfvYaW9iA83wrLWbMwOiDuSHeyh5f9M/YtpHhTlbmmxFU7cwQAzrGRKrd6Exy2 y0vqpA0FEy+S/s3m7J55BNJYwvfWbfswWokElsu2AZXYM3AsI/hRSPBMd6uIOxQrMVcF Lyau/ot+g1MEs1OEp0DK36K7/Bfx4PLVVyvsY2iqS6AqvjVsaSknz6dAJ/hNyvLvuc8p fvp/dQqE9dr9uy31S8RJlbyfHg9XIDR8ewJRxNHfo73Q8Vy7ehEc9SthUahmTF0o9EHC LTR5BbZxcrnaIBbmnY0ZEx4qDXt3/dunkL3ZkIM9c1N4SNmMPqpzlm61GB/0gUWxtC3u lDrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107934; x=1741712734; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D0DbxfKxGvd2WW4HNIqxG+j4XJyJfuCMmLSYkWj7Rsc=; b=XPxQf/EM+MiwhmV7Ugw44CsbHDd5sJC9qZ1G+/Ldzxsor8wMMhphLcBsXYzs6pzog+ Et9IX7hPWzHbkMUIiZe4mEz5gvbVnoLDV0VQzZ7Y25c7Yz93DL+2XvTFeuAWKkgA9XpE XIIKId6wnsdS9doe9nNqbuzMfL2Y7u7NlPqc1uk87Q+k2Vsw7UYgFGfdE8D7+2Ddwvqz rgPszHwY0i6tVWezgJACJR/jI8NqL0ltA+mFytw9lm9pwkCgdZN6W5wkQYhrhMPIB8eP uMQLftz9winH0O9gND3iJP+FYL2qq4+ozjjLNXoWdiiPpCgEmDMSc2x88/nNqmC7arKE GbNQ== X-Forwarded-Encrypted: i=1; AJvYcCUcCByahVjmgUHxT/P/9ojRDxEM4Rzp7mt7Jp5slbzTsaCmtSMka6XmKD1pRebvOd2tqUOnILt0D/bZ6tDE/PBu@lists.infradead.org X-Gm-Message-State: AOJu0Yzfydz9G8fb/iQrh1H/CwDAkg/cznYa/6MPHMhyJ+sgciqk8t2q Th+lvW+ETp8nYvt18PZ74M/RzT5BVPnOeu1KGD0SnNsE4UTYSgC3kLVqr+359Mc= X-Gm-Gg: ASbGnctrMBBa+GMVuTbFNJXprYl2ZGNHnyQTYI5nsZX2z7I4YhEptAVCVzn9jW4qzMh mOYQJiuU+hZCpRNv5wh/VuW5vr0wwXjTHMsvX9ef6iBImlEzfoJngQaGGXphblk67t7hreWZV0h ZCxQYdSKn/vrh9AfLzjS/dIUegk+fmhdub40JU1iKmXxtkPgntkOrl/E2oxDnHOeaFEDq4V7FId AOEElPvtQKT8NrN6ZFScRBzJaIgbBmDWM4BtdPIwfgAUeRqMRPQd6QtI00xO9nctwFK5rKE6No2 HnES+kaQ8UZquggeZUPuWeBiPZOROO3pmqylo/ewxcYLPD+Ey4PLcsV/rOqxsyQG5SLrU0cbmcG nO4n19u4IEDUjpwTIxQEGvjuHOJoE X-Google-Smtp-Source: AGHT+IGsdjvAcycMp31oFEdsdwWFqJQmXbxtDBoL5DRz6SC3HgSNRmbkL1ZXNDzmFm2b5aF1OyYNnA== X-Received: by 2002:a17:906:c150:b0:abf:4a62:6e5b with SMTP id a640c23a62f3a-ac1f0e60023mr427555766b.5.1741107934486; Tue, 04 Mar 2025 09:05:34 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:34 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:33 +0000 Subject: [PATCH v2 05/16] rtc: ep93xx: drop needless struct ep93xx_rtc::rtc member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-5-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_170537_733674_93DA2774 X-CRM114-Status: GOOD ( 14.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-ep93xx.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-ep93xx.c b/drivers/rtc/rtc-ep93xx.c index 1fdd20d01560ef4fae2b996cf366b4f812329225..dcdcdd06f30d1ff6d0939f6bcad2c17c03c5a65e 100644 --- a/drivers/rtc/rtc-ep93xx.c +++ b/drivers/rtc/rtc-ep93xx.c @@ -28,7 +28,6 @@ struct ep93xx_rtc { void __iomem *mmio_base; - struct rtc_device *rtc; }; static int ep93xx_rtc_get_swcomp(struct device *dev, unsigned short *preload, @@ -123,6 +122,7 @@ static const struct attribute_group ep93xx_rtc_sysfs_files = { static int ep93xx_rtc_probe(struct platform_device *pdev) { struct ep93xx_rtc *ep93xx_rtc; + struct rtc_device *rtc; int err; ep93xx_rtc = devm_kzalloc(&pdev->dev, sizeof(*ep93xx_rtc), GFP_KERNEL); @@ -135,18 +135,18 @@ static int ep93xx_rtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, ep93xx_rtc); - ep93xx_rtc->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(ep93xx_rtc->rtc)) - return PTR_ERR(ep93xx_rtc->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - ep93xx_rtc->rtc->ops = &ep93xx_rtc_ops; - ep93xx_rtc->rtc->range_max = U32_MAX; + rtc->ops = &ep93xx_rtc_ops; + rtc->range_max = U32_MAX; - err = rtc_add_group(ep93xx_rtc->rtc, &ep93xx_rtc_sysfs_files); + err = rtc_add_group(rtc, &ep93xx_rtc_sysfs_files); if (err) return err; - return devm_rtc_register_device(ep93xx_rtc->rtc); + return devm_rtc_register_device(rtc); } static const struct of_device_id ep93xx_rtc_of_ids[] = { From patchwork Tue Mar 4 17:05:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10DA0C282D3 for ; Tue, 4 Mar 2025 19:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LQ1rnmYNsg12IhA38qEJtyyMHRjZg5dsRkHMsIbiHfY=; b=M7kO4/71N5qWT5yay+DnjNMdjz SIstktYf5Evg7YznPWbAQjEcSKQ8WblAfeVAEnR1Ur/E8ZvGWcPk6kW4l9tOeXnXIXeIB1Ec72J5g 3g38HM3J6nczxfDWjvkuTqinz7J5puThEMLBd+a0OjKC5zp9PFaKbUVglD8i+vNtP3hCEe2oCpCj+ SlrC0JXArTUvbap8ypvUTYJwVnOn+gWbussxI63dHoa2u1tzRdfSjLqwbGSaKPsV/loMU1787p3kq gF1FqX4uyc9hYK1D504asETQAaBv9GP/bIMHVPI45gZ9vTLf5ifgHSwaqIl01Ee6v7EHLn0J109yd FyMX82Gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpYQc-000000068JO-23sq; Tue, 04 Mar 2025 19:59:46 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViJ-00000005YHX-2eN9 for linux-arm-kernel@bombadil.infradead.org; Tue, 04 Mar 2025 17:05:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=LQ1rnmYNsg12IhA38qEJtyyMHRjZg5dsRkHMsIbiHfY=; b=o10Zj/sVM8UMTO6ahPhjFH1xrl zRR36Gmq7lg38uwhtu7lyNPLDtDPUibLU+5bvgKO3eURiqYVm+DfpNqpGifzx5LJL/FlWS7xSTohI U4XTbaaToqvachUzuw6TBYUjTc/BQKpxtW7Py1A3GKg71JJ7aOX/ivzV4gfcP8VZ468Ri6I/c7wfz A4RHc7iDxWwyFOx8hhDnpKLZzYdNsLpJ0X1VAZqGENtXNJLlgTA9qzOVMgRZHkeErL4k9Osbn40ZL 3p6OU/B8W3GC01WDxgiZLzy22fQL6q+TeZK9aboZhotdzt/VafDtnVarAfxP3MByOGZ5zzOihgbof BjM/pNmg==; Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by casper.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi6-00000002Cy2-055V for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:50 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-ab771575040so1214217066b.1 for ; Tue, 04 Mar 2025 09:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107935; x=1741712735; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LQ1rnmYNsg12IhA38qEJtyyMHRjZg5dsRkHMsIbiHfY=; b=D2IHIbWXDPORjcb/qb+xsCxCoeS/0og4zCVqNBN+7G2HcnMs0iY/LKiu+ct5kzsNcC r0JJtmjgmelZaOFMflOXuB0a0YlGUq3GuKTPXHagDctR44wK5Nm0D+dxfWDfA7Vu53gU gxRxKx/a1ucDelKcxtX0CG6ccbLHIHUjjf7GWq7PpZbW5Vb95zX6BCh+0c0cfIcqw6TE SbhCVIp+bUAnmQd4dAsERfaSzYpvajCrgG8E0kLkFN/suQwiIRYsSKNQop35MtNse9d5 yJeoIUoXysT5KETflPZAKBpZ31ldsMuXSRjw+xw4/8c8onTt0gubwNAOQElOfd64si/T FG/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107935; x=1741712735; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LQ1rnmYNsg12IhA38qEJtyyMHRjZg5dsRkHMsIbiHfY=; b=WvjRdCumoOF+N/2VBsiustMOGBua2ss0etg7gGPyQgFJp5bUSAlJ/fYIV3Iq/i1h7d vU88Qpsu/2Y5D+JRW/QbDRfGooIkJ+LLfDbNW5jybzIAhQUbGzzN5GbzghPHAeZBUU6B PWIIofQw4BgVGgJc2lbbvPDMT8GjXEDZ+gctHXMaMtMGGNDxSy66kUwpzbsXW/++lyYC tcrZl5XSWxKAAscCnNqHWn/FoVHbbt7eI46aR+jRxHBBLOHtUaGfzwqKq2lu3BYx5yJg 7mKcJFaJYUirSBX//92twSZNaUPT8z+PHEVfz850qdXRJNP/ye8/er/t/zyRPSD6LWyP EsQQ== X-Forwarded-Encrypted: i=1; AJvYcCXrFozpC6mP2WABwWRE/WQJiRHgwkWHLHTjibkucjXSpdg1ge2Hoj5gkZOuUP0TmxWXmeO7tfE9FnLb3gzwbsat@lists.infradead.org X-Gm-Message-State: AOJu0Yyl3zjIUv+w5q44SK6Lr92zg044lndUEnG43Peu42GkuoxK5vWg o88qP5TP87i/xwOW43fctF3iYMl4Yr4vHPS8va+2Ge7unfriapsJaH0yZffb3Cg= X-Gm-Gg: ASbGnctotFKfWaFiFJyYygm/HyCtlf35Iywm+mmC0vpt5J+xxcN/v8S+1y9QiK1QaCM 0GEFiVZbgCk48w6zf964cIsiYnl0h50JE0N/YokBJ5UI7cr0bBG3deLJrUDS/wptJkA1pNcM6m/ QQ2JUS8zVkYsVRKdokMsd+MnfzsfOC4r3vyMHpIdM6uSkY2r8ZkjfrC87PKw1KVVsfVnWcKpCLI iMZuXrbKnsYzf7vUj+KJ9rjSz5i9qGlQ3KTXkttcmGi+XUxdj+1Dgv+pCsw+JPvUYqsl/+wCO/l MGpKZwGmgvTl+hUIgHcEFZshzFY5Qqvg6Axq46LPOGOodquwvkJl+m9dxqm6pb5O2hcGFPiz6ZK vvhZWrNmlcItxep1LIA0bxWhyQdrr X-Google-Smtp-Source: AGHT+IEctYzZlVVwQPucj8CUHKEVuZPV8n583Yq6QohmEvkW8JU3S9SRTA4/uuDakASHnMKJ8bAleA== X-Received: by 2002:a17:906:3814:b0:ac1:17fe:c74f with SMTP id a640c23a62f3a-ac1f11e6c1dmr291303166b.21.1741107935167; Tue, 04 Mar 2025 09:05:35 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:34 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:34 +0000 Subject: [PATCH v2 06/16] rtc: ftrtc010: drop needless struct ftrtc010_rtc::rtc_dev member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-6-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_170538_174166_DC27198D X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc_dev member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Reviewed-by: Linus Walleij Signed-off-by: André Draszik --- drivers/rtc/rtc-ftrtc010.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-ftrtc010.c b/drivers/rtc/rtc-ftrtc010.c index cb4a5d101f537e20a685bb022e6f6516b0df8271..02608d3784958e69ec0ecbdb9fcc8b333b19e7cc 100644 --- a/drivers/rtc/rtc-ftrtc010.c +++ b/drivers/rtc/rtc-ftrtc010.c @@ -28,7 +28,6 @@ MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:" DRV_NAME); struct ftrtc010_rtc { - struct rtc_device *rtc_dev; void __iomem *rtc_base; int rtc_irq; struct clk *pclk; @@ -113,6 +112,7 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) struct ftrtc010_rtc *rtc; struct device *dev = &pdev->dev; struct resource *res; + struct rtc_device *rtc_dev; int ret; rtc = devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); @@ -160,29 +160,28 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) goto err_disable_extclk; } - rtc->rtc_dev = devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc_dev)) { - ret = PTR_ERR(rtc->rtc_dev); + rtc_dev = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) { + ret = PTR_ERR(rtc_dev); goto err_disable_extclk; } - rtc->rtc_dev->ops = &ftrtc010_rtc_ops; + rtc_dev->ops = &ftrtc010_rtc_ops; sec = readl(rtc->rtc_base + FTRTC010_RTC_SECOND); min = readl(rtc->rtc_base + FTRTC010_RTC_MINUTE); hour = readl(rtc->rtc_base + FTRTC010_RTC_HOUR); days = readl(rtc->rtc_base + FTRTC010_RTC_DAYS); - rtc->rtc_dev->range_min = (u64)days * 86400 + hour * 3600 + - min * 60 + sec; - rtc->rtc_dev->range_max = U32_MAX + rtc->rtc_dev->range_min; + rtc_dev->range_min = (u64)days * 86400 + hour * 3600 + min * 60 + sec; + rtc_dev->range_max = U32_MAX + rtc_dev->range_min; ret = devm_request_irq(dev, rtc->rtc_irq, ftrtc010_rtc_interrupt, IRQF_SHARED, pdev->name, dev); if (unlikely(ret)) goto err_disable_extclk; - return devm_rtc_register_device(rtc->rtc_dev); + return devm_rtc_register_device(rtc_dev); err_disable_extclk: clk_disable_unprepare(rtc->extclk); From patchwork Tue Mar 4 17:05:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001252 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64464C021B8 for ; Tue, 4 Mar 2025 18:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=rOaOFdkLyUTfdkkRsJZwqhzUAj 7q2H+x9BnVZz+DKk9OchyYXHS8Wc6jDppVaIEZwh+yon/oBKSOKoM8tEG65sed1fodnCRSTI379Jf 7/pMllyyre1cLWclFeM6LCraG7OlRVpijlJtfUw4sE9PqWNfTGPUi2cz5m6TgWuZ60gIgepaK/7MV 3iYGrDCLB6ome05zn2nwNoXQdeogdEP6/wDwGhrXCy1xL4DESJMsCYzqqYvjf9dPgBiAosCqwwYqU 8l8yVuW6TVFaZhW9GajvH8YD9/SztMEX83+M2NBNMvWRFWLO6ObiRJnirpgb5qAOyXOAIENskJ1Cd xbUC3y0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpX46-00000005rXD-1qxN; Tue, 04 Mar 2025 18:32:26 +0000 Received: from mail-ed1-f41.google.com ([209.85.208.41]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi5-00000005YAv-4AbO for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:39 +0000 Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5e095d47a25so10385520a12.0 for ; Tue, 04 Mar 2025 09:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107936; x=1741712736; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=LpeJEz0R5X8T2QR7pofOV8gJkBUXWjwn/cXKloeQc/IAeyCvcl3y/GyhTz8iC+6XWm 7vlmZDl96pjxW07cDgJQpnC+ZC0omY4n/9vZ4fxBMiuQesFE5wOvuFjyf6a6H56tlTwi 03CQJqSfZX2DUVV4Wx3TDJjhq+INjqauYZB8OUE0jHg2xbuHl5DCtzYydLY3xX3ilmc9 u6ciP35/VbpUtmGDCE+OUA3gkaqPpcFG+/q9zWyE1ZwLKXmwtwyZpRrk1OZol6J04aWN BIJ5kVb5fLNeCaoevFCD5UENx5zqf+Es5adMIqUIVLirE9Ov1UL177i5jBlJ3sjNRLez JT9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107936; x=1741712736; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IgG/ZB1ufhyJ5LLnH+TbRO+Ff9QR7sb5p8sH4cYGYcE=; b=YXErncJEbZzB1AnnoSyfmHHFyX1SrZ4P3agiclQQdjgEzF5Z6Q26tWKf1W7wztg5oN 6SOJusxNKMvfYalmu3st+x/dxXgJH2PQ0Ta47o+2HpERtz8pJTjDt3p+ZUJPoDsby1dO RT3CdCQuIwAcXaOaotdDydes4yS+2sCPYQq8MT/1MJ0tNBt4jWQswMkpLQ+QBXxRQBBg NBYJuHvu+oRtB5tDfjHKjB+PMvIwmrka/TuIHsXbdC8ikljF/JBixDTI3izKmD8NEStU MeBWGaPh/g7kUOtvO6EGPccBjCFihuqa590PHcQhtVaw/OKRie0G6vSF0WK5y0N0PMws 0mpQ== X-Forwarded-Encrypted: i=1; AJvYcCUr4J2ODQdvCHI7iHXlAsdr+TSJp0HabWwhDJK7XgGccefgDq883wga8xBenTaw6SbaQ4313sgsFH3DpOuAcB2E@lists.infradead.org X-Gm-Message-State: AOJu0YzP3tdJGryTxYABYHRMOIdkUn/P32ul8pMF+QILNM3tCLbBq/e+ qbPGt0Kq9WDaHLGPC/v8+RlDey1hvdWgPfx63iX/7fQ+5bi1VMwT75NUyQ4HPgk= X-Gm-Gg: ASbGncuzhtFAlIj36B4S7rqlhJzQEWLdrUvaUFHgLKE1lOyZWdRJRbxhtCQxG7LK6/0 VQlHdOO8rJmsUkxP4i3Hzpiq/fIq4bw5/8WOhdX0srLwq0qLeAdecN+vpkX888TDwQYHbdPtelt 4zRtl03X+0qkaGyTPGXCV8ZkCmOOSSN0yUXcMjtP3dDj+ye/REkuCV1gL9bLUovU7iHO8ZATx0n pA8kElP3amcphmMvwXmrC2gbTV2y25p9n6j9M+dm6QTUQwmzPhFDoba87SXy2exiPwCES0IF916 qKE74pjM9WPuwhnOp0wlCsEKrL9TDG8WTsNywbufxVFCu0npPSs5kPrOpHhR/nR79Ag/+3ofQag i1zwm9ahMRN780rHDQF+Qh7BPXJAw X-Google-Smtp-Source: AGHT+IEZSM7e60umftuoTA+5yHKxOw5bEfyTXKI9tFiIm+4qyPCIhcf70tbw/wLp28VjnQQVfyBtmQ== X-Received: by 2002:a17:907:c2a:b0:abf:6b30:7a94 with SMTP id a640c23a62f3a-abf6b58f60cmr1276559166b.45.1741107935884; Tue, 04 Mar 2025 09:05:35 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:35 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:35 +0000 Subject: [PATCH v2 07/16] rtc: m48t86: drop needless struct m48t86_rtc_info::rtc member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-7-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_090538_034513_1B16F9AB X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-m48t86.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-m48t86.c b/drivers/rtc/rtc-m48t86.c index dd4a62e2d39c73b1c8c3f50a59fd4fffc0b45105..10cd054fe86f9e6be74eb282222b2751dd91cc7e 100644 --- a/drivers/rtc/rtc-m48t86.c +++ b/drivers/rtc/rtc-m48t86.c @@ -41,7 +41,6 @@ struct m48t86_rtc_info { void __iomem *index_reg; void __iomem *data_reg; - struct rtc_device *rtc; }; static unsigned char m48t86_readb(struct device *dev, unsigned long addr) @@ -219,6 +218,7 @@ static bool m48t86_verify_chip(struct platform_device *pdev) static int m48t86_rtc_probe(struct platform_device *pdev) { struct m48t86_rtc_info *info; + struct rtc_device *rtc; unsigned char reg; int err; struct nvmem_config m48t86_nvmem_cfg = { @@ -250,17 +250,17 @@ static int m48t86_rtc_probe(struct platform_device *pdev) return -ENODEV; } - info->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(info->rtc)) - return PTR_ERR(info->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - info->rtc->ops = &m48t86_rtc_ops; + rtc->ops = &m48t86_rtc_ops; - err = devm_rtc_register_device(info->rtc); + err = devm_rtc_register_device(rtc); if (err) return err; - devm_rtc_nvmem_register(info->rtc, &m48t86_nvmem_cfg); + devm_rtc_nvmem_register(rtc, &m48t86_nvmem_cfg); /* read battery status */ reg = m48t86_readb(&pdev->dev, M48T86_D); From patchwork Tue Mar 4 17:05:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001254 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 190DDC282DC for ; Tue, 4 Mar 2025 18:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=l5jXqwjE++tKBywfyBBhs/i35u HJvG+qRdtvlGscyhvtVlXlnN5Zp6K42/3WYnBbihUy21J3rq5X2k5+sexAQFsWAwHcEU1qy9sIMQc AGEhNBrdHn6cAtRd4rEfUUrcA5+YxO67c4uVzRlOOyUkE8l8KXwIG+hdLLBhS0HtGHrCtOMwDB4x7 JsqoH1SHF1+isJXM8+hdRih2RlbZkvFOytZDL6R2en8UAI97jPOTPC5q01LA9lUffSgbX1cyXoTHa JksXyuu1VseTxGLPxM8cHjIkwHEr2UgD/OXl3L2uXZqmW4dCRR3WTQmueKxUCb+urAYMTvtbDOHk4 5ir39MnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpX7D-00000005s7v-053i; Tue, 04 Mar 2025 18:35:39 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi6-00000005YB2-2fFt for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:40 +0000 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-abf57138cfaso615833566b.1 for ; Tue, 04 Mar 2025 09:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107937; x=1741712737; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=ZTO6hmwCTp1YpKlqKax098pS5kZUJQHyYPWj+h3D/hz7WM4xSm6PkQuouMdOxF3usB i320238+yKxF0X9yQGc51F88qHAvEhax5SeDeEQQhZse/S2se+4UMtn3Eaz9D0r01NiO 3kbPDJjTx0xet3Lg1dOtQ61N4lp9h66+9OGKbZzS1vj9Td0Mfs0AsWC4c1Dv8ZwxeW4x VzAeVlxO+3zTAyHpATi8j8EmQnKRA2c66EpI7u5IGZss+1uq7zujq6ArjujQgukzJwn8 xVXAGVgBg/FsCF1e5fwBBTQ3RIfG0A7edfMlazDdPZPCosGX3utOf/JCHoi7zr/yPjdx sYhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107937; x=1741712737; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfBBNFFxoATgsY5PG9x5TDiO1XW3it+ha4dH0f4d6kY=; b=Sx6HPI4h/4DHO46K9c21biVa0jXzmkUfYp8QQRes5AsZT2D46og2Zyx/JY0+U4kGOb M7FHv9whyGcjskTqZOQXKG5jBhp8rZ2R+6twAPyvHJcyN6PfVRgDw8fmGuabbXQ6Zpx+ fGPCKrdHxPLkhv2kxsgh95FSthtI4O2zHgUutfYyLTG2aWVcnQbAflbZqvz96tHnLySj STjBQ5WXyqcoFKXObNTtEqvOiAH/xXewJJiiryjToU7pDZ0gfksmYqX9D/lfWKoME6+k 5fvEMvJBziCEQUIP7566w0Yt2C8G6YHQK0uniZCaXaDpTaPKxo9lalXaUJAYt/3FFFJ1 /mSw== X-Forwarded-Encrypted: i=1; AJvYcCX6YurJum/rBzd6TwPnEUAzrd/QblipRkK5t69q7sQLc5L7rCiJvU3CatJ92+KX3QH/jd7vBBOQC3/acacAvWOk@lists.infradead.org X-Gm-Message-State: AOJu0YzeIdT1qr7qI3CBGaGl5BDaxsS0l4loVt08S4ec6pytLk3RKmkK EhIVqWyzuaHk4Vt1tAZ3k2IgcXJuS8pt6SC8icIqhInGQC8GGJl5jl5KAqXznXc= X-Gm-Gg: ASbGncuj74YywlGuR1WsyGi4YNTm7P5QgglDERN34I/3f6GsWrYnkqu4AoBWHRUAd/o nHTM9XoGb7BTC/eAPMHmqKjfqD9IYsFBb2eDnBvKuAJHYtk79eN9WugOmtWGCrUplrWn7iGxFxL NKp5+h9vrd1D17sq8L69ks0rFM+Qre8DLu850pufpsZxPK9URV3EEDHhMXLyvoMVD1saxXeCtas xLylNeiHSTzCqJhED6Um/e6YPdqWp+Uq4bNftoGfEyVc4Y7tpcuf7ck8yA1mwbfE7ptdcAFPoo3 nqK8WboLLjZoEG25Oy3HRBlblXAXHOH5ZYdVqY+CqOGDMxN/hrYNOexwo62T0ctmHStKNDLVKFT BJEddwH+JRONht0/5xLnSfIUr5jfy X-Google-Smtp-Source: AGHT+IH4UfROsxQRuhFhpuKVUGIkJvl9GfdlUj4CrGm+kiSC0tb2f0MQezXBSz1TfcCGXXToQh+ymA== X-Received: by 2002:a17:907:7210:b0:abf:778c:58c6 with SMTP id a640c23a62f3a-ac20dab329fmr1852966b.16.1741107936481; Tue, 04 Mar 2025 09:05:36 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:36 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:36 +0000 Subject: [PATCH v2 08/16] rtc: meson: drop needless struct meson_rtc::rtc member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-8-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_090538_671142_45554775 X-CRM114-Status: GOOD ( 16.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-meson.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c index db1d626edca5fbb590f26c1cdd0774d350244a99..47e9ebf58ffc2f2b6c65932f8ec3773a213a62ef 100644 --- a/drivers/rtc/rtc-meson.c +++ b/drivers/rtc/rtc-meson.c @@ -59,7 +59,6 @@ #define MESON_STATIC_DEFAULT (MESON_STATIC_BIAS_CUR | MESON_STATIC_VOLTAGE) struct meson_rtc { - struct rtc_device *rtc; /* rtc device we created */ struct device *dev; /* device we bound from */ struct reset_control *reset; /* reset source */ struct regulator *vdd; /* voltage input */ @@ -292,6 +291,7 @@ static int meson_rtc_probe(struct platform_device *pdev) }; struct device *dev = &pdev->dev; struct meson_rtc *rtc; + struct rtc_device *rtc_dev; void __iomem *base; int ret; u32 tm; @@ -300,16 +300,16 @@ static int meson_rtc_probe(struct platform_device *pdev) if (!rtc) return -ENOMEM; - rtc->rtc = devm_rtc_allocate_device(dev); - if (IS_ERR(rtc->rtc)) - return PTR_ERR(rtc->rtc); + rtc_dev = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); platform_set_drvdata(pdev, rtc); rtc->dev = dev; - rtc->rtc->ops = &meson_rtc_ops; - rtc->rtc->range_max = U32_MAX; + rtc_dev->ops = &meson_rtc_ops; + rtc_dev->range_max = U32_MAX; base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) @@ -365,11 +365,11 @@ static int meson_rtc_probe(struct platform_device *pdev) } meson_rtc_nvmem_config.priv = rtc; - ret = devm_rtc_nvmem_register(rtc->rtc, &meson_rtc_nvmem_config); + ret = devm_rtc_nvmem_register(rtc_dev, &meson_rtc_nvmem_config); if (ret) goto out_disable_vdd; - ret = devm_rtc_register_device(rtc->rtc); + ret = devm_rtc_register_device(rtc_dev); if (ret) goto out_disable_vdd; From patchwork Tue Mar 4 17:05:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001277 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 333ADC021B8 for ; Tue, 4 Mar 2025 18:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=tChB1WjsNvXCH4Sf/wdw1fwkEk GopnoSfImqpd7+k7VftwTyQ4Wd6KvWpdxW+8wQ7U0ulNsN1YhRxHpK/YUBxrthP0TJsrQmRQEojDw xToS4/8YF709XGwFf/LhhZbOPRwA3u98Q1OKOi3KSGnLiyT9jt4/pKsXRf9p8GTjAqejYs9/w9Ppm 3ogKwZPD4ypCZ+frMCd+L5Y5AZFidA7spBlbArgb2s1udZ6P/uDj41OMF9vgtP5U/76uE4xFnAaYo zL2d6KAnTXlvnZNI1jgMoI8I+ml7ef6ZlZvrxgnMCET4cs0ej8KzL00VRblpxvRWnhbnWc+YqkXX/ VBzoP0jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpXL5-00000005u5Y-0flR; Tue, 04 Mar 2025 18:49:59 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViJ-00000005YHC-0fvn for linux-arm-kernel@bombadil.infradead.org; Tue, 04 Mar 2025 17:05:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=napQinlwywe07Gm4w2oBDTqrI5 XH122OPFtcrNb8PftOna3SjhELtto854hZtn/uQH/HQp2Hobl5qsLdZr7dQXSlhWCVgqrJ2FTAsAP bVTqNHBqGtbP+oC5Bw2y3o17h+yPfqVKG+chEIenYOQ0JexnHmqKXDnlIG3OyRuCxpNnSJDlxYee+ LxbRlcMsnNBYt/DER8AWqw9ur3RpPHvtu9kU8C3xQJzagN+9ySx/OgOgourlcp7s6HIvs+6GeIMZ7 8Y86JguVvxcFRGyfY2Sd+VOQIA7m+9CZuBxyhtAamh7d08Nrqzt+o4mXv+iXO9RqEbrBadEq/41wp qZ2RhIZg==; Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by casper.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi8-00000002D0N-0S8l for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:49 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43bbb440520so28438915e9.2 for ; Tue, 04 Mar 2025 09:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107937; x=1741712737; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=l0sLJdaNaUCZBYSodhVO0/bzhRM6hrtSECo6RonPz+NKsMR3D8JAunIWrid5sle7Eu vsscEsMjIYtr/R1QBFNDkI+iNjaRWCPYbqkmoytXvM8vm/h33uKoSI8uF7AHzXXIllmV 9wSclqqMvq2258JIUzYcJNcifiaC+y7+f3gPzqtr4J4b8maGTTHM3MO5q4fhG+RApX7h IIuvrbZwFIjGhlY+jA0JC+E/RaK7F/cA4KtyMth+p8qpwsyRuRsQreuhhkLOltFwYG5u DnminasEHfIC+9ENen1X2yW1NPh3INPlEhLc4A8Kwk1rbwgwGzErYGKZfI/DYiIDGovU mW8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107937; x=1741712737; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NvWUKPp3Qf/mJMvtGf6kleKwT9jTpA0O53gNmEgl49A=; b=EDgGlEAl7WUWnRfoI4IOvXR5U1UzAz366vlT9pzoiVcdNlxk08R2vwjUxschqn+GTv KsuWkpQaI0WTyX4NB7acgAvTOTlnUY4wOlv6hlyiJNPMP10BPf/UjXgE4XR5o+gdWuzM ipdrhaeBfuJFPT3Z+DokQDyGjxfGvtxEUSXzzmkwuT903BbhlwgtG44hTpTa0crNUTiB Xqpa2a4ZtMyXvifC3Yx+pLLIP+Phj7P1t3r/jb+MJnWbU/mJqnMPnWmNw4NE5P16s88i IBa6GMIYK6wLHyQkv3+AOEca/PJDDlGhCx31v2fufCM65M9jAC3+Uf1t8Mqd2UUkjDsj 4Ocw== X-Forwarded-Encrypted: i=1; AJvYcCW6O3UP8wVt0h9CG63DP7s3+Y1P+m3IF8EqpxBwCTpaK0aPcilpSq+updpR3e39jr9G0L9SZ2qtD/xcLDWER0W9@lists.infradead.org X-Gm-Message-State: AOJu0Yw/2gMDhru0IpVL7D9qUQtGb6t3GTA9wTnhpcS/DXpXmSnaWD36 /O6wZ1VQ2WQG/31n7xWDTJxw/zxHfRyv37rXlcsG7438PM8BWzhtvfh9H/6ByTU= X-Gm-Gg: ASbGnct4m7pxX5lXufNR0N89YKcPZH/ME9igwJ0R5paoQiD4zsTaQkXLHJ4XuTgKZzm 9uI8CbGiqXHA3GnukdpkKAwsOwRh8UUdG/yar3OD14Nh/m2aH/i0buImDnazEJgrjfeWOm5unfO qCOYGs6j9NqkaRJZLXXGMWHzpLUCWeoZXmSoCi2HkTwNKn+9FvT705Dwp3sGxxy8PySI3dH4heL pkiIJvezUOkcNKhfMRx24wOmhG/1miGfnVu7U7H/8OrlLs+jTBphQ+3rbas/idoyTwy/ofQ4jnx vU/se+ycBCS9JsJhv9ou91EgymOqAiTt4ezc+2bP8uNIR62nhIrVf+i9K4IdJjULliMTCs3uRvE zvTxrDGOpH7xsv/J+PraI3gP1nFnR X-Google-Smtp-Source: AGHT+IHZdsv7jYfFsjyY3TIB4euke/dHgzMkeAeSorD4HntlJXvk76kkhxE/lHiggYkJdsJqp3nEfg== X-Received: by 2002:a05:6000:10c1:b0:38d:df29:e14f with SMTP id ffacd0b85a97d-390eca069a5mr17165829f8f.43.1741107937298; Tue, 04 Mar 2025 09:05:37 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:36 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:37 +0000 Subject: [PATCH v2 09/16] rtc: meson-vrtc: drop needless struct meson_vrtc_data::rtc member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-9-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_170541_273239_CA16BC16 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-meson-vrtc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-meson-vrtc.c b/drivers/rtc/rtc-meson-vrtc.c index 5849729f7d01d7ec7868ff3bbdc5ed599aaa8238..7d38258cbe376e5a1b2af6250cb6d04c313175fb 100644 --- a/drivers/rtc/rtc-meson-vrtc.c +++ b/drivers/rtc/rtc-meson-vrtc.c @@ -13,7 +13,6 @@ struct meson_vrtc_data { void __iomem *io_alarm; - struct rtc_device *rtc; unsigned long alarm_time; bool enabled; }; @@ -65,6 +64,7 @@ static const struct rtc_class_ops meson_vrtc_ops = { static int meson_vrtc_probe(struct platform_device *pdev) { struct meson_vrtc_data *vrtc; + struct rtc_device *rtc; vrtc = devm_kzalloc(&pdev->dev, sizeof(*vrtc), GFP_KERNEL); if (!vrtc) @@ -78,12 +78,12 @@ static int meson_vrtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, vrtc); - vrtc->rtc = devm_rtc_allocate_device(&pdev->dev); - if (IS_ERR(vrtc->rtc)) - return PTR_ERR(vrtc->rtc); + rtc = devm_rtc_allocate_device(&pdev->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - vrtc->rtc->ops = &meson_vrtc_ops; - return devm_rtc_register_device(vrtc->rtc); + rtc->ops = &meson_vrtc_ops; + return devm_rtc_register_device(rtc); } static int __maybe_unused meson_vrtc_suspend(struct device *dev) From patchwork Tue Mar 4 17:05:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001285 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D390EC282D9 for ; Tue, 4 Mar 2025 18:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l1dbxTlHkaw5uSKNsqDfe9Jgr4Kg+vWUXd+ullz5kUQ=; b=BL01In6AaB2aycioW0Xts+jyqm fdw5hVgs/8DrX1w8tKJ0mkWlSOLOS7T3UUwVHoy4fh6ihTIOvwQjiMP0p+5t6JF/1/+UIVdgP2jql Do4wNYWsHaaxLGy/k7xAo6+eyNxifp1qinOwHr0HhWyByrabV4b/3WvxY/YEpUw/C5iQLe9Enz+vn IbctlvBHcCPXtdkZuTyR9dFx/rwlZPlWWrEizLv5PA8L1vvVpkjzcCLhd8nmxTuAG8is9X+dU0Ikt v3qxp2vqofaVbg24UaC/NmlTxwx2sUf0sOsA1Sm30GwGfOpadH1BOrNKG/ARM+1P7ew1T5775v4Mg Ww9KPFzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpXPl-00000005vG1-0Tab; Tue, 04 Mar 2025 18:54:49 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViM-00000005YI9-1Wvp for linux-arm-kernel@bombadil.infradead.org; Tue, 04 Mar 2025 17:05:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=l1dbxTlHkaw5uSKNsqDfe9Jgr4Kg+vWUXd+ullz5kUQ=; b=arwdDrJ5nxUaqiXcnprFNMi6rt NyiiJeRBQOQwZ19lYuYOvgMngKdIa2acf8681Y/r0CyLZQubERvC8mOFr/9XaN9TOTWM2IEtJlj6v SsHlz9ELkiLES5kCsbbe77RO2s8LacXeaGG0H+uxoMAV+ny5EySQSCE9ufGpS3RYohhpdbt5BQU7b w8V9r/xCHs0/nwtVg6c8bUu27Dpve/jJeOIWMBhmjWrEn7Rpzhwg9i63EEwkfo6r/2HQGe4O6r+/f 4D6QBUrc6xg/fJg0ytuC0yscacn2GQEfUNCwX3Cor7m/+raFecyTjn4fHRZih41025ZxmpJNMLzAS 8LitMknA==; Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by casper.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi9-00000002D0Y-0TjC for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:53 +0000 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5e55ec94962so3638544a12.3 for ; Tue, 04 Mar 2025 09:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107938; x=1741712738; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l1dbxTlHkaw5uSKNsqDfe9Jgr4Kg+vWUXd+ullz5kUQ=; b=j3Um0OTITg7odN79pu3s5Us+3s8CK0yWy6ssNGqA9JvDSIfcW+qG5HfzEAf/PYTAzm J0rhEInhemNDMXWaoRFGoBKjXEwgZ9LjNe5eZndPQvUsRQWF56SBptOKJ67iUCLiDjuU DaTnvdGM2oIxyZzkOqO/Ld8d5j8AK3N2UV6lcO0XaD871Ets3iXFyzFYADSYUNBReOOX H68KDwO25ZCfy24fLvOOcfBgMM7/KixNVpfGp646dDyQ8cmGhh7y/uY0Nd8h1S3i/fXS CRnJER4ybjfBzwcZwsGpKOMztwWDco103srIVBPfGDALtf+l8CWP/N08uo8LtpxXZ9IX oZog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107938; x=1741712738; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l1dbxTlHkaw5uSKNsqDfe9Jgr4Kg+vWUXd+ullz5kUQ=; b=mPmlyGbiNEDGVKHumvVVud66uvNCNufrutDgHk0I1Zgk0PcDGJRbJowBMwc+DforDf 9P9iMSGcnSjPeYFxz7+YNcRyUHQLgwXoO3fDXVuMSMDC9MzrwojbE5ybxLdCioprO74K qthdF18XJ/XxPqvTdCrRQHI0FEdFnZKS3lnZiqHi8x7FggWpoDfuiIkcN84rzPsAieet CTfKaBwlXL9wZVM0LPoqY7XRqnF9xIyXIWyXVTBxtsORfR1lXvTqYJkb7REBv8sg6SNa FVhxO58ZRxTBgZhlkunlastLLlPH0/dRvG4ZJoqKjRteONntf7mJCPvaFE8BKfX8Wqw6 nx/Q== X-Forwarded-Encrypted: i=1; AJvYcCViycQIGKGQmi2ManIeAuL28LVc5Ord/TlrL1g7Gr5Or0GrtOgB/Ct8Nt7hFx748rEo+HHunWM+fkMmu6rEnrxX@lists.infradead.org X-Gm-Message-State: AOJu0YyS6Frih3SNSM4aAgHrd3nqiSBv3bYG2IV8y6BEk9cYRmUUFRJn y5iFBVK/ru9uryaIZvGniqp9LOHGFG20cQUtmjW583Wsm5C/T3F9FDiUHagSwNk= X-Gm-Gg: ASbGncu8q82d6pT+dyayryYOwvtDdT+3R/FYagLqet55PzBWgeb+8hNhweFsBERv0VB vSXCaVFHPCCzoe+NpFFIr9TUFbWeKldv4hNlJxaDm28CCdZcLtYPKE/CyRhf0LDOACl8s8jcg2J 5h/L25Tx0uIcfZkT3CZLolO/pQwqAfq/QYKLkILgXRZgVfChpoWKiBHiOuFHnrOdODqX3C3P2wK J9zdF/MKwJN3Vzor2u3l8900ccOBbq4K4vT8e6IvSKm89bt6w4TNbZLRHGhHl1P/4eY2v1rpnnB rYExj2HZq4xEwuZImKNqi5IPE6ds3ucxRzjMW83+FXP+6cgGM+PVeS4/K1QjpE7GvjotW0gRHpv Q8zPbGxTTVbcv0oWxFanTj4koZjwb X-Google-Smtp-Source: AGHT+IHF998NpSXE/Qa2EdiSn4vtx17I0lnFV/wyKnxAJsCHaDM1j6HSEMvcUwtHdnvoXlFd/CgYog== X-Received: by 2002:a05:6402:d0b:b0:5e4:c532:d693 with SMTP id 4fb4d7f45d1cf-5e4d6b8535fmr16782448a12.31.1741107937989; Tue, 04 Mar 2025 09:05:37 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:37 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:38 +0000 Subject: [PATCH v2 10/16] rtc: pl030: drop needless struct pl030_rtc::rtc member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-10-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_170542_943443_4A6B3C59 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Reviewed-by: Linus Walleij Signed-off-by: André Draszik --- drivers/rtc/rtc-pl030.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc-pl030.c index 39038c0754ee55a952e5986afe711cffff35840b..e7c81740061bb60c4d8447d6522819685bea9180 100644 --- a/drivers/rtc/rtc-pl030.c +++ b/drivers/rtc/rtc-pl030.c @@ -21,7 +21,6 @@ #define RTC_CR_MIE (1 << 0) struct pl030_rtc { - struct rtc_device *rtc; void __iomem *base; }; @@ -86,6 +85,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) { struct pl030_rtc *rtc; int ret; + struct rtc_device *rtc_dev; ret = amba_request_regions(dev, NULL); if (ret) @@ -97,14 +97,14 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) goto err_rtc; } - rtc->rtc = devm_rtc_allocate_device(&dev->dev); - if (IS_ERR(rtc->rtc)) { - ret = PTR_ERR(rtc->rtc); + rtc_dev = devm_rtc_allocate_device(&dev->dev); + if (IS_ERR(rtc_dev)) { + ret = PTR_ERR(rtc_dev); goto err_rtc; } - rtc->rtc->ops = &pl030_ops; - rtc->rtc->range_max = U32_MAX; + rtc_dev->ops = &pl030_ops; + rtc_dev->range_max = U32_MAX; rtc->base = ioremap(dev->res.start, resource_size(&dev->res)); if (!rtc->base) { ret = -ENOMEM; @@ -121,7 +121,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) if (ret) goto err_irq; - ret = devm_rtc_register_device(rtc->rtc); + ret = devm_rtc_register_device(rtc_dev); if (ret) goto err_reg; From patchwork Tue Mar 4 17:05:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001262 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC59BC021B8 for ; Tue, 4 Mar 2025 18:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IaB5zKXHk0fgCsI3Zx6BuQOTGpJ5CFC8NMnIRZG9Bxw=; b=PzwpBnaGYm6N5kNJtg1OtVOIRz zb5flIGxj8oAKeqIvIRzkBeQuYuSWYws5Dta8EPl6kRF7gpwG15pxrwtCsieNeHx+HpF40FT/81cF tHdJmOXvUMXISgjakmAewOuzc3bUvgqwhDcEc9PBIh7B8kuIZ6rRly2ZDI0fjl+WU6rhnnRpcCJZb q45xxCmozHFLf3tsPSGFR2fZt/vOE5so7ZCywfG9mbQKLrKX46CamvwHAk3enrmSHAEJksTVM3tWl +/nzAZMqMHCoTXGLDG9z32EtGSIjO5vuTqAfwygGQ7OXCaef2nMbLPtNTuJNG75UJZmu1ke0LSC7b ymoCTvLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpXBq-00000005srB-06IC; Tue, 04 Mar 2025 18:40:26 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViC-00000005YFC-1Tn8 for linux-arm-kernel@bombadil.infradead.org; Tue, 04 Mar 2025 17:05:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=IaB5zKXHk0fgCsI3Zx6BuQOTGpJ5CFC8NMnIRZG9Bxw=; b=DzXZHgjhAPHBgSKNQKmmi9mGK+ a2plFTsASA4kXlPtE5zYSr5pFubqIar8cAtGINMj5KYQUBQsDJDMnnqlU8jJbAN5kzX0HqWyV7vQI lmOtYM/cFooNH185oThUYqeGZWeZvDe7GBR/POj/aeLK9xU61n/pt1nf7craC7hpfaBxkelYksyLH 9TYqiCEGwgeUGA8/3BTxHrlLNtFCcluEQl6nHXT+HwDOiWvszwLDMGWo1SIcBfRtR4lKgR3uxEbUo 6FFzW0IhHmX6cIqeoRiFRF+CqtzVjE3cQqtZq8EIhTKP5/xcYRDcP2RfpKikiIdGcafmrRFDNCFGd axKC03lw==; Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi9-0000000074X-0vcc for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:43 +0000 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-ac202264f9cso95927266b.0 for ; Tue, 04 Mar 2025 09:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107939; x=1741712739; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IaB5zKXHk0fgCsI3Zx6BuQOTGpJ5CFC8NMnIRZG9Bxw=; b=vMji8IKAOXSGlR73nfxs0b6zaDG0YwmVpnF4ql+TdfEQyHRADixf1vFGILhT/MAXrW mJipibpfGh7Lxg9Hb+MtNEV1Z6Y6cUd6BbZmHiveGg99qh24oimJCdm/Z1MWLeZu9PQs axqVnLMfIsDA9QIct6VG4uV63x5r4gjQF92RXHwjykm0eEzv2gQAhxPwVBqNUtA705Oi Xq6vWpS5UjiIDI/BYaNu7oCcDrxqmYqzIs+Ry7/mWVhXcI7F3qAMN7xxz6XDTcy64+87 hFRo0hoXf7e8MCPWoBzE/iSlzL8/vHR/keeaDf8NPurzEDEPQWjFuZT77+9S0RYpIhiW 8rkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107939; x=1741712739; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IaB5zKXHk0fgCsI3Zx6BuQOTGpJ5CFC8NMnIRZG9Bxw=; b=MwrOPHLFyQWDiZPdolyJj1gfYnTTklgP8gBB3DJU2dHJkvQ5mwUugHyWiP4tqq8T+3 cODi+i7JBXQDTnmKY2xK8fr1ONjPT0PHhrSdKcA+rh2hL4k9GCEzmJ/tQJICTGOM/J2j xU4T6nLq9ZFYMRHDngOVnui9YUHPD5xut9PcOoeLtH39pgPnsDDWSIAMAEV6CUS5L680 U6wBfpvIxiOh1BW55kenKKYOOqw2TSzuYbrAI9nO4V5weIdGT60NPb2aFH9+BdedjP5/ JbwlPrbkgWXLLKhml1Ms6i991amFvI7AQK6mzdCunbTh1mjVUcTT8DEDJf3tcH7Tmf8c 2Qug== X-Forwarded-Encrypted: i=1; AJvYcCVY1LUJeGX9yytpyMCnED39728GoTJ8QT1RhCvAognZy+1qZ+mOG68RMHPLWeNmZ6woxx15/a1sPeLQIOLngIve@lists.infradead.org X-Gm-Message-State: AOJu0YyqNpbcFZcpNDfnn1YPdFGJWdcbt7v1+nDKKq4V+vg2pjC3mVHD hwt+8chprnIo4UF1L19BfsSnPILuw/Tz94385XegNACNpMzX97fPdO4Wi6fsmU4= X-Gm-Gg: ASbGncuRAmag6tfMAByDlAO+9mOho1vjQnVOXhyM9MF9/m+nQqlM+lsx0COpHha6UDL r2szb8zI8RQJaWLUr1EraWM8rxX5xkniBjCe2A/R13vBgvWjjoqqxPqDy4rdYCHl+ZS6Sg6gDua bXQU6xkVRACfh+qPdnbDL+0CfrV/0CqngL/onBBfFJd5FdAqsAcwDk51AIvtn04zKBXHQz6M1dw lQAZ4gvtMZ/FH9SlkzQXey5gYW0g/ohWh52XpMrq8bsCjdi9r4UlWSpxWz/SGxQBIQC1SRpLy4c pKNgqhKm31t8MezinoUMWOIvC0rKASV/hM/1GsTOSkIUwo6XZFQd4zVKxvjQbqHM1A50S9mxloS n6sHWvEBkLuSGpsPuDR5hUMeeercR X-Google-Smtp-Source: AGHT+IEthaeTae6V+bsrtEeJOclicWZ8u/xfJHzWX8LHXk81mGbjX6FsBTkNnwrP87t1Gku2pvbmyw== X-Received: by 2002:a17:907:6ea5:b0:ac1:e1a7:44af with SMTP id a640c23a62f3a-ac1e1a747c4mr790541466b.49.1741107938652; Tue, 04 Mar 2025 09:05:38 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:38 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:39 +0000 Subject: [PATCH v2 11/16] rtc: rx8581: drop needless struct rx8581 MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-11-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_170541_527895_829CAA25 X-CRM114-Status: GOOD ( 24.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Since this now means that the structure has just one member only left, there is no need anymore to allocate data for it and pass that around via the various callbacks, just to extract that one member. Instead, we can just pass that one member and avoid the extra memory allocation for the containing struct, reducing runtime memory consumption. Signed-off-by: André Draszik --- drivers/rtc/rtc-rx8581.c | 85 ++++++++++++++++++++---------------------------- 1 file changed, 36 insertions(+), 49 deletions(-) diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c index b18c12887bdc3705ea4cee9b8d75086a05b24e71..20c2dff01bae833ae4e100cc38cd5f030017be75 100644 --- a/drivers/rtc/rtc-rx8581.c +++ b/drivers/rtc/rtc-rx8581.c @@ -52,11 +52,6 @@ #define RX8571_USER_RAM 0x10 #define RX8571_NVRAM_SIZE 0x10 -struct rx8581 { - struct regmap *regmap; - struct rtc_device *rtc; -}; - struct rx85x1_config { struct regmap_config regmap; unsigned int num_nvram; @@ -72,14 +67,14 @@ static int rx8581_rtc_read_time(struct device *dev, struct rtc_time *tm) unsigned char date[7]; unsigned int data; int err; - struct rx8581 *rx8581 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); /* First we ensure that the "update flag" is not set, we read the * time and date then re-read the "update flag". If the update flag * has been set, we know that the time has changed during the read so * we repeat the whole process again. */ - err = regmap_read(rx8581->regmap, RX8581_REG_FLAG, &data); + err = regmap_read(regmap, RX8581_REG_FLAG, &data); if (err < 0) return err; @@ -92,20 +87,20 @@ static int rx8581_rtc_read_time(struct device *dev, struct rtc_time *tm) do { /* If update flag set, clear it */ if (data & RX8581_FLAG_UF) { - err = regmap_write(rx8581->regmap, RX8581_REG_FLAG, - data & ~RX8581_FLAG_UF); + err = regmap_write(regmap, RX8581_REG_FLAG, + data & ~RX8581_FLAG_UF); if (err < 0) return err; } /* Now read time and date */ - err = regmap_bulk_read(rx8581->regmap, RX8581_REG_SC, date, + err = regmap_bulk_read(regmap, RX8581_REG_SC, date, sizeof(date)); if (err < 0) return err; /* Check flag register */ - err = regmap_read(rx8581->regmap, RX8581_REG_FLAG, &data); + err = regmap_read(regmap, RX8581_REG_FLAG, &data); if (err < 0) return err; } while (data & RX8581_FLAG_UF); @@ -137,7 +132,7 @@ static int rx8581_rtc_set_time(struct device *dev, struct rtc_time *tm) struct i2c_client *client = to_i2c_client(dev); int err; unsigned char buf[7]; - struct rx8581 *rx8581 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); dev_dbg(dev, "%s: secs=%d, mins=%d, hours=%d, " "mday=%d, mon=%d, year=%d, wday=%d\n", @@ -160,25 +155,23 @@ static int rx8581_rtc_set_time(struct device *dev, struct rtc_time *tm) buf[RX8581_REG_DW] = (0x1 << tm->tm_wday); /* Stop the clock */ - err = regmap_update_bits(rx8581->regmap, RX8581_REG_CTRL, + err = regmap_update_bits(regmap, RX8581_REG_CTRL, RX8581_CTRL_STOP, RX8581_CTRL_STOP); if (err < 0) return err; /* write register's data */ - err = regmap_bulk_write(rx8581->regmap, RX8581_REG_SC, - buf, sizeof(buf)); + err = regmap_bulk_write(regmap, RX8581_REG_SC, buf, sizeof(buf)); if (err < 0) return err; /* get VLF and clear it */ - err = regmap_update_bits(rx8581->regmap, RX8581_REG_FLAG, - RX8581_FLAG_VLF, 0); + err = regmap_update_bits(regmap, RX8581_REG_FLAG, RX8581_FLAG_VLF, 0); if (err < 0) return err; /* Restart the clock */ - return regmap_update_bits(rx8581->regmap, RX8581_REG_CTRL, + return regmap_update_bits(regmap, RX8581_REG_CTRL, RX8581_CTRL_STOP, 0); } @@ -190,29 +183,27 @@ static const struct rtc_class_ops rx8581_rtc_ops = { static int rx8571_nvram_read(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; - return regmap_bulk_read(rx8581->regmap, RX8571_USER_RAM + offset, - val, bytes); + return regmap_bulk_read(regmap, RX8571_USER_RAM + offset, val, bytes); } static int rx8571_nvram_write(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; - return regmap_bulk_write(rx8581->regmap, RX8571_USER_RAM + offset, - val, bytes); + return regmap_bulk_write(regmap, RX8571_USER_RAM + offset, val, bytes); } static int rx85x1_nvram_read(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; unsigned int tmp_val; int ret; - ret = regmap_read(rx8581->regmap, RX8581_REG_RAM, &tmp_val); + ret = regmap_read(regmap, RX8581_REG_RAM, &tmp_val); (*(unsigned char *)val) = (unsigned char) tmp_val; return ret; @@ -221,12 +212,11 @@ static int rx85x1_nvram_read(void *priv, unsigned int offset, void *val, static int rx85x1_nvram_write(void *priv, unsigned int offset, void *val, size_t bytes) { - struct rx8581 *rx8581 = priv; + struct regmap *regmap = priv; unsigned char tmp_val; tmp_val = *((unsigned char *)val); - return regmap_write(rx8581->regmap, RX8581_REG_RAM, - (unsigned int)tmp_val); + return regmap_write(regmap, RX8581_REG_RAM, (unsigned int)tmp_val); } static const struct rx85x1_config rx8581_config = { @@ -249,9 +239,10 @@ static const struct rx85x1_config rx8571_config = { static int rx8581_probe(struct i2c_client *client) { - struct rx8581 *rx8581; + struct regmap *regmap; const struct rx85x1_config *config = &rx8581_config; const void *data = of_device_get_match_data(&client->dev); + struct rtc_device *rtc; static struct nvmem_config nvmem_cfg[] = { { .name = "rx85x1-", @@ -276,31 +267,27 @@ static int rx8581_probe(struct i2c_client *client) if (data) config = data; - rx8581 = devm_kzalloc(&client->dev, sizeof(struct rx8581), GFP_KERNEL); - if (!rx8581) - return -ENOMEM; - - i2c_set_clientdata(client, rx8581); + regmap = devm_regmap_init_i2c(client, &config->regmap); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); - rx8581->regmap = devm_regmap_init_i2c(client, &config->regmap); - if (IS_ERR(rx8581->regmap)) - return PTR_ERR(rx8581->regmap); + i2c_set_clientdata(client, regmap); - rx8581->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(rx8581->rtc)) - return PTR_ERR(rx8581->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - rx8581->rtc->ops = &rx8581_rtc_ops; - rx8581->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - rx8581->rtc->range_max = RTC_TIMESTAMP_END_2099; - rx8581->rtc->start_secs = 0; - rx8581->rtc->set_start_time = true; + rtc->ops = &rx8581_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->start_secs = 0; + rtc->set_start_time = true; - ret = devm_rtc_register_device(rx8581->rtc); + ret = devm_rtc_register_device(rtc); for (i = 0; i < config->num_nvram; i++) { - nvmem_cfg[i].priv = rx8581; - devm_rtc_nvmem_register(rx8581->rtc, &nvmem_cfg[i]); + nvmem_cfg[i].priv = regmap; + devm_rtc_nvmem_register(rtc, &nvmem_cfg[i]); } return ret; From patchwork Tue Mar 4 17:05:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001260 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DC8EC282D9 for ; Tue, 4 Mar 2025 18:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=0wjtnttzQHPwLM4SWWcv77YUQE DxK0UwM00NVTWk2brnPydlN8o+Z/sxA4UTR6zqj/S1WQJY5+KIkCRenaCZB7arf1i2sGjU/2gN7pU 8SKiMqZgzdBnGQA7wxNlMGZ7Ff+xW/QIc6jiBjWVI7MCY6HgnLFnhXaiAKdBxUe/O9oqGQeTjXzoq 9zwFUSUQ8pUr9/WLTbjyyrfGzXhWtmdOdlyPY1roLljA58gJeZr61cu7Sh38epFpVFMxpepWsLjxL 5BOS/o3iWA4DDm16LwSDp/KlUrIR2ERUSFOL396mL8cXim4uUDlqDTJu+AIRnGws3LW9MRGQbWadw 94KmgOuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpX8k-00000005sPj-1Njy; Tue, 04 Mar 2025 18:37:14 +0000 Received: from mail-ej1-f45.google.com ([209.85.218.45]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi9-00000005YD0-1Q0I for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:42 +0000 Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-aaecf50578eso1120079466b.2 for ; Tue, 04 Mar 2025 09:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107939; x=1741712739; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=TxTakxzn4+ieuy3yrgAQY02mLpP6hHO5wb62C9klvyRR4MiONcN0W5txAb4R3LIU1S smWOhA3tBWoBpXxJ5zQQ06VlBa/wrzozOCWvhKzViJ3IDSFtYOxv18jBLdbNKZTEH4Eo e6HZm+IEjG3NBiILbhr6QfifJwl5DiO58fjW8Gea5dzIqYekFzSy1Zx+Z7qtcrmueyH4 ourVym4BgHjte6mvd/lYilGzV2LuoXLVhq379lxgm9/eKBKU2iss+0sbpRe7FOerZUze eG9qVF0acWqgvxM/7Uph2lmwyKqGsny7043/ZdodY4vXJccGMnkPGN7tPvDNo2fdDUQh DDDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107939; x=1741712739; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ka86PnTxcRg56Z11OHXTxcAKX5oZrUWInphsB9KYtsw=; b=uuuppS8LS6QT1aV6QWpTMxdEs6IV+gzaiTsO/YfYZDi6aG21Z1WBBz87N38/L3aMY9 J7aEP1s9pMw+dZJsQFB/u7BiPfkQWsPiY6A+fgpqRHaRD3HwOKVI9aJa9dgU9j86OKL7 lQX/u4qABSppzFLvZaMExUhlZQBXI3eiPbHSbGjNtobwQTV/F3f4gcu6aGJ35Rz5OC5A HV+yORgOVNTNugW2mCJr+IjWYECpYLBCOQXcO8p08YTqMBO2TJVvtNp5sq+W+ZSKhpId 26khVqVgQP3Q1o2bS2LnBHVMQbupx8rsy3ru2eIlL5j6IO12j9QCAbbxReLMGwjXi7Vb BMMA== X-Forwarded-Encrypted: i=1; AJvYcCVDSX5LToF1XlDujEUOl/3hTtQtoQwHg+s/szlZqDiVr/VLWp/jmFOtfX0ocg67pOgjROYZdvrPY4RvYa4GzscR@lists.infradead.org X-Gm-Message-State: AOJu0Yx/j+8zU9g7L8Zb7hbrDOw9YUIXJrLZ3uCPHo1XX0skfy58v7aH MLDWpX3EJUkDV86amA1YqoBDrUw8if7IyXFgR2+GtW3tvP6ulcIyIlRv7RfI3Pg= X-Gm-Gg: ASbGnctoWXfMaZVTHN7g/KGJ+a3dbCYSADY0tzkTiDPItRhCa3iaotlUaJio3dEpRbh W2shgZypvMG1MEEGTMuQCuBnaueP049wkJEi27pzWghfal7N+SlNwqyLpe6byV+mRnuxKpHCxn0 bBGrt8w3Y01EUSFRWhqno13FYJbgG2Fqn1oCs9V2qDHHpUace7PdLYzbVn2m57vqSQh0czP62Yt /Z8vVX/p9eSlx/rVPgGJFEP0g4fSmK0EL3O/DJBxLT+B4NYgAu6nxx/o82CfiOaWLgyVX0zBneR ntuVJm7aG4CavyOa4sENazBxdsFIejHgkP2fRNNsDJs8IiUjVHaCfJojwBn1Q6JjBHTqYgaLCaX Ni85kQ1cIeT7o9kmTNQ12IpWvZUZP X-Google-Smtp-Source: AGHT+IEZqUVJFopMcdCw0Fa6138jis8STGfKBc9DN3g8sZLmJaNDRTq42x6nu+WBoJl/BXVMQfaxGw== X-Received: by 2002:a17:907:97d5:b0:aba:246b:3954 with SMTP id a640c23a62f3a-abf268263f9mr1810089466b.47.1741107939344; Tue, 04 Mar 2025 09:05:39 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:38 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:40 +0000 Subject: [PATCH v2 12/16] rtc: s35390a: drop needless struct s35390a::rtc member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-12-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_090541_375126_C102A255 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Signed-off-by: André Draszik --- drivers/rtc/rtc-s35390a.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c index e3dc18882f41445c41fbea56edbd5c869514880c..3408d2ab274194e39cde38a83567d37bd53f6632 100644 --- a/drivers/rtc/rtc-s35390a.c +++ b/drivers/rtc/rtc-s35390a.c @@ -63,7 +63,6 @@ MODULE_DEVICE_TABLE(of, s35390a_of_match); struct s35390a { struct i2c_client *client[8]; - struct rtc_device *rtc; int twentyfourhour; }; @@ -422,6 +421,7 @@ static int s35390a_probe(struct i2c_client *client) int err, err_read; unsigned int i; struct s35390a *s35390a; + struct rtc_device *rtc; char buf, status1; struct device *dev = &client->dev; @@ -447,9 +447,9 @@ static int s35390a_probe(struct i2c_client *client) } } - s35390a->rtc = devm_rtc_allocate_device(dev); - if (IS_ERR(s35390a->rtc)) - return PTR_ERR(s35390a->rtc); + rtc = devm_rtc_allocate_device(dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); err_read = s35390a_read_status(s35390a, &status1); if (err_read < 0) { @@ -480,17 +480,17 @@ static int s35390a_probe(struct i2c_client *client) device_set_wakeup_capable(dev, 1); - s35390a->rtc->ops = &s35390a_rtc_ops; - s35390a->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - s35390a->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &s35390a_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; - set_bit(RTC_FEATURE_ALARM_RES_MINUTE, s35390a->rtc->features); - clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, s35390a->rtc->features ); + set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features); + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->features); if (status1 & S35390A_FLAG_INT2) - rtc_update_irq(s35390a->rtc, 1, RTC_AF); + rtc_update_irq(rtc, 1, RTC_AF); - return devm_rtc_register_device(s35390a->rtc); + return devm_rtc_register_device(rtc); } static struct i2c_driver s35390a_driver = { From patchwork Tue Mar 4 17:05:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001261 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E0C0C021B8 for ; Tue, 4 Mar 2025 18:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hsaGEw76ofDXd3Q1RIPfSv8CJUvwC0w+ueATTj/NegM=; b=Y/JOHP/DPQXIY4dH1NoOg4z+ba rrqhFSiJ8jpREDKYH5Y9b+rVnD6Fu1KsoxmJ5plwn8VomEqL8KMJ0m7xCnowHWK6yRE+X8C1GOaMC 8I2Gix/yh1aEFAnHOvH90Z+Qu/wiPfJf0ervKN9/rYVzLwZJHrvWdtaqBlSVdCVYFpuG99BsaElwb /r0ExlvI7SsTaDEmsT3kYAn5uRRtrIuyNqZ2B9t2IdAnRv7LMhxJogW6BKPI4ctwUmbKC1rhsYVB0 nN2bGHOtwd6foPPSzSiso0+NYhSpCvIJyWmRvR5jtkMzZeKQqJ6RDZRU8GutCgD8EeMk7OmUbO6G4 pd5NMFVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpXAI-00000005scC-1LEq; Tue, 04 Mar 2025 18:38:50 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi9-00000005YDQ-2ecI for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:42 +0000 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-abf5358984bso537639466b.3 for ; Tue, 04 Mar 2025 09:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107940; x=1741712740; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hsaGEw76ofDXd3Q1RIPfSv8CJUvwC0w+ueATTj/NegM=; b=n6wbLd0c8dLsKU2yPCDre0PPGnFUIbj5o/OMuFvBxxQIbQpP5dAlqCKmUoJFatmEul /7L1zj7Kyn9bs+YtgN9usgaVfaBlAua495QOE8ZZjWe999FOfJKC4Blma65r7cEbGUGV 7YW36FUt3S5cK2wZrMtilVDmmlT+XdTBlEdGBxmv7eOuEvqfiAeGhnol7nGO5QQ5vs96 6ZfaJZJrXn9ZAL0VsOHLoQjCdGRPOzqErqI8WWrcczagkdXciCxB+qR5hwKcqAv8Qr+s DLNsmACwmdlfNC/6y6CrAaD65eSvInAabFJBxjD4ZYE1Ot+eQSYMaN7pzOUJAYysBkjK fXXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107940; x=1741712740; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hsaGEw76ofDXd3Q1RIPfSv8CJUvwC0w+ueATTj/NegM=; b=i5+zm6LidfNUjkcbzymmyQlJTx8XWVdx7ruDHSaPErCDZ2yEX618pbbyrKI/Rz4V4q LmEqaz073LXfB3SF0n/jk13nQP4sis3cYyJSJYbJFhzujekVFES0z1CdQ9l2MV3gJPYj GY55Arskqzun17Tvro8xSV2JoKqf/PEWoTkh4epD2tBIOEIqQgek4V/VecBvfnmASbGg 85EHTqFpt30+4wGxYmekj9ucZwTNXQZn25BWt/n9ym71anbzj7STOVBQNrDbPQYhwrUw utEON4aW4yNXBNkTSQyPxagrUyWr0EWlEfImF47jVqn7N/jdQ2ByVoWUB8ah4v+K8InM 1j8Q== X-Forwarded-Encrypted: i=1; AJvYcCV5w5jUke8c2WQTia9M0Qg2qCi/zcAAF7wtfgXe8SP/juvI0XazkBalhmxqgVG5psjGywrh/3OYVn3nI+drVub+@lists.infradead.org X-Gm-Message-State: AOJu0YzQYd+TPs/XhCBgrQ0nKR1wgFNT7OgiarDvknrNdtOZ/qSztWat 10fIvnAczN1TK/USwp+40cVJjWwKxLweksFjewKMIl8bUv4MSN+vp6D67c36VpU= X-Gm-Gg: ASbGnctApH+WiiqKdy0nAwXWcKxz+WD89+K0VFrJ5VXKrQQKdCd7IHNWxuIxgrca13s 13FjLlBC+R0J0ewfcERfQgBFaBSwhKVGw/e55si5zG0uI2mn14lPA4ZwUih4MqUSg+XJlE5829m yiLKSTMpxMpWNN97KMm2vr67xF1ayAT1qN2JrLMBqovOcZz1nfwsNXj1CDTrJhv7VKuOiEtWgHx QobkHOQY3mScLx/wqLdXQZW3i97ESvO1sUEZq8rCpOqbbdT5f8It3+5CW1q3ZS7yup3gn5N1uLQ /ykw7KuxN+pRTv3NLzn3VY3sM2XyBPaYE6nhkwBvu0D9Di8OZfA4nEH7HUl+4d6hveQsYaNhqmL HCgsOMiNCmBGwzHU2aqzNHu0PrhOS X-Google-Smtp-Source: AGHT+IFl6TTi8U8Sph/F6W/xnjfer4H7R9+DXzK4OCCEVcy7pkMVR63rOrht0Su/bmOb+eKFGQTbhQ== X-Received: by 2002:a17:907:1c8b:b0:abf:38a:6498 with SMTP id a640c23a62f3a-ac20db16fb1mr2300366b.55.1741107940186; Tue, 04 Mar 2025 09:05:40 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:39 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:41 +0000 Subject: [PATCH v2 13/16] rtc: sd2405al: drop needless struct sd2405al::rtc member MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-13-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_090541_699865_E46160C4 X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Tested-by: Tóth János Signed-off-by: André Draszik --- drivers/rtc/rtc-sd2405al.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-sd2405al.c b/drivers/rtc/rtc-sd2405al.c index d2568c3e387659dfea598cd2ef6bddc5c076cbb9..00c3033e8079b5f10aaabcc7a1d3f19771263a02 100644 --- a/drivers/rtc/rtc-sd2405al.c +++ b/drivers/rtc/rtc-sd2405al.c @@ -42,7 +42,6 @@ struct sd2405al { struct device *dev; - struct rtc_device *rtc; struct regmap *regmap; }; @@ -167,6 +166,7 @@ static const struct regmap_config sd2405al_regmap_conf = { static int sd2405al_probe(struct i2c_client *client) { struct sd2405al *sd2405al; + struct rtc_device *rtc; int ret; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) @@ -182,17 +182,17 @@ static int sd2405al_probe(struct i2c_client *client) if (IS_ERR(sd2405al->regmap)) return PTR_ERR(sd2405al->regmap); - sd2405al->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(sd2405al->rtc)) - return PTR_ERR(sd2405al->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - sd2405al->rtc->ops = &sd2405al_rtc_ops; - sd2405al->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - sd2405al->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &sd2405al_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; dev_set_drvdata(&client->dev, sd2405al); - ret = devm_rtc_register_device(sd2405al->rtc); + ret = devm_rtc_register_device(rtc); if (ret < 0) return ret; From patchwork Tue Mar 4 17:05:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001284 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3F0CC021B8 for ; Tue, 4 Mar 2025 18:53:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jDySvxIgslRZrTqVd7bcfGaor7CHMjwsKayUWf5uR70=; b=iSQEYCX2jbE7A2OoUeblq1/icF kGPDTGnFGlWICasC0ejJGEWLwPBZjA6JPJi3z3U+NE5b7izkGJ9Xyvfy4xx6iTr7kdy2st7UjKF4I v2scxOFe/B0O1UQM9lTzWzV6HkVun7JxpVDXwGlYe4BMjskcn1hM0hVrN7zRCbydolV4PsrQbZqFx qY7gdf3FpLG1iTeudYQsL0oK5nMBqfExj1kJYM4nTbYsoXpyYgGbiw9EduvkcPazVDA6kt1aT/+z7 6pwV0i8tKOFg2nkIkitfQEAVwzbSeRs/782iB3Vt5Kv1eoq3mF5CJs0056gOqRVQL9QeQ77griZLG YwSIR4AA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpXOC-00000005up2-0HcE; Tue, 04 Mar 2025 18:53:12 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViL-00000005YI3-3kAw for linux-arm-kernel@bombadil.infradead.org; Tue, 04 Mar 2025 17:05:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Cc:To:In-Reply-To:References:Message-Id :Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender :Reply-To:Content-ID:Content-Description; bh=jDySvxIgslRZrTqVd7bcfGaor7CHMjwsKayUWf5uR70=; b=MTQBdKZXbR0HVBdKhmKeVdWH2g 35FpDic58Uqo4DTVKm318uIYAnhK8rs3EeyOKC5zfmivqILHp7gZ1EiK0NMxFxjDwr6ofdJfYCDQE Cwih5kBJ3obuHf09L+fDD3YDyEwn9bizsd84/quGGYJESJ/9DQnKxU1vXigTm03ksO8r/ST++r40b FUIQSBgWwaVy0DzSgZTxkB/EOhLOYjyHHX86JIFe0e7B7OZt/IDA8/geEbZwvB0qGsl7qcphH9m0b gfofbRIo02/c2ljiev63OzwcXLEG1G1xERZkB0/VUzgCQB1XaJkqSDOMbnvAdWhLEk5R6LqnZTNWG rLyifI1w==; Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by casper.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViD-00000002D1j-1g5O for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:52 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5e539ea490dso3607383a12.0 for ; Tue, 04 Mar 2025 09:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107941; x=1741712741; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jDySvxIgslRZrTqVd7bcfGaor7CHMjwsKayUWf5uR70=; b=fIVFRFcTOlTcsXQITbuSZPKycKETPy6etpRNYPmYcYMdPGyVD/iQn5MbbfQiay1UPZ FFu2z2tEk1YJHlVtAMi82nvxmkCJ0TJz/e4wsHkgzt+IFzxsZqM1eYSa/Mx1Azaiu7Og zLDMsPnfKH7vbvX9HfuljultEvLmZrvQiwrSkm7Pn5mCyWwUKKoCkzeRdhZRTVAKqVwe gW7FtEcB+0gEEUeEJESG7WWiiZYcKYxRCFRMFCZJtwO+1N10troJgKaG7BrMY/4LJ0mq FKAXFgZizKTVzQRlCzb+aB6pmzPlBak8HNgH8HHJFMjNxRfgGhyAluIERb8gSir9vWeD 43VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107941; x=1741712741; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jDySvxIgslRZrTqVd7bcfGaor7CHMjwsKayUWf5uR70=; b=AD7GDVnpEcz4L+XwDECbqLRLHcePYg7yMJQQwAqnNLFM4XWPIyF+eN0VRicc6SsAGp 0Zl4Kp3MkvGHJ3/WTnY6DTT84cP0or+aMTC8hBp9lydHiiBPoWwdpU0KdUq4oo2yXNfR AopbmouAhn0cSQvSYXJI26XRfhNf5YGkX49gzFnVGlVC8WHH/8LHmBhFSHwM69YUH5nD dZeRcpRAyFCLmW9ERXXBHbrj68j2naeoVp00/4E9Tu4Q3LNoh0Ehdti+WjoodlPMktKf NorA5ljB/zek+VVwxhj5TbXg0M34PqVq2sG+nrEJYhaFk/83JWMCTSpqVGJ6HG0Gf7Wf dYSw== X-Forwarded-Encrypted: i=1; AJvYcCV4DKtp1DSSWKo5EOpqTrAEvJZA7vZNVs6TUlMrCPTcOvSiFyWFB5ewvOu54PSU422ElmlxV+mer/W3sgxzCcmW@lists.infradead.org X-Gm-Message-State: AOJu0YxzbdO+PwJbbnIcfhN0Le9ssmZj5mn4CBZ5EwLaaLLh9sgNE9JU kPEx0YFehphbDv/ue2uDnpyzhmSspcm+qnHYB+PkkqYDqh28c9085NEcsZhEGfA= X-Gm-Gg: ASbGnctr4KL/oUeQmMkmDnuX5UWD1DfHgpU7nJJ1o50JBFBv5UnfZq7WjPW5+w3hbv7 Xdo8h4NjdcLgn04AmEuhPntv1pB7FsOaHP2PS5emuc2XLNA/JXQsfKdIffARZyGFQWPQDJKenSR a7O21dmkYPXJAP/QKhmdFPQir6FATd6wMvjmG+4H3Ovj24916xNId8Qsoqn13RWI+zZ0xTLEqr1 erI63d3p6w+rpwtn8WLfB9XJZkNKlq0uMhyIOdkPqX+93DmPZhokC/N9yvIF5VH+n5ww+65ftfi 6n2qwKkUBWjIO6XWzkFPbuwBgp6VP1c1NHhKNac4UwPD1O80YDDQNg4V5+S/IRmG94nXbLM4LLT QAExFdKbsS6x7PSDctXxb3f761xv/ X-Google-Smtp-Source: AGHT+IGw6DMujSSlMe4X/Gi0vjiilArq9AgwOJMWr49ZazH2bLzcdxFw+AmPTscolQ+3wmW3ZQIPiA== X-Received: by 2002:a05:6402:50d4:b0:5e5:9543:fc0d with SMTP id 4fb4d7f45d1cf-5e59543fd82mr4097180a12.31.1741107940802; Tue, 04 Mar 2025 09:05:40 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:40 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:42 +0000 Subject: [PATCH v2 14/16] rtc: sd3078: drop needless struct sd3078 MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-14-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_170546_655489_DF0F37B2 X-CRM114-Status: GOOD ( 19.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The memory pointed to by the ::rtc member is managed via devres, and no code in this driver uses it past _probe(). We can drop it from the structure and just use a local temporary variable, reducing runtime memory consumption by a few bytes. Since this now means that the structure has just one member only left, there is no need anymore to allocate data for it and pass that around via the various callbacks, just to extract that one member. Instead, we can just pass that one member and avoid the extra memory allocation for the containing struct, reducing runtime memory consumption. Signed-off-by: André Draszik --- drivers/rtc/rtc-sd3078.c | 71 +++++++++++++++++++----------------------------- 1 file changed, 28 insertions(+), 43 deletions(-) diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c index fe27b54beaad1c06b70bf7f22e44c3f6da087267..10cc1dcfc7748144f51ef674939506feee1fb471 100644 --- a/drivers/rtc/rtc-sd3078.c +++ b/drivers/rtc/rtc-sd3078.c @@ -36,11 +36,6 @@ */ #define WRITE_PROTECT_EN 0 -struct sd3078 { - struct rtc_device *rtc; - struct regmap *regmap; -}; - /* * In order to prevent arbitrary modification of the time register, * when modification of the register, @@ -49,14 +44,11 @@ struct sd3078 { * 2. set WRITE2 bit * 3. set WRITE3 bit */ -static void sd3078_enable_reg_write(struct sd3078 *sd3078) +static void sd3078_enable_reg_write(struct regmap *regmap) { - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL2, - KEY_WRITE1, KEY_WRITE1); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE2, KEY_WRITE2); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE3, KEY_WRITE3); + regmap_update_bits(regmap, SD3078_REG_CTRL2, KEY_WRITE1, KEY_WRITE1); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE2, KEY_WRITE2); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE3, KEY_WRITE3); } #if WRITE_PROTECT_EN @@ -69,14 +61,11 @@ static void sd3078_enable_reg_write(struct sd3078 *sd3078) * 2. clear WRITE3 bit * 3. clear WRITE1 bit */ -static void sd3078_disable_reg_write(struct sd3078 *sd3078) +static void sd3078_disable_reg_write(struct regmap *regmap) { - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE2, 0); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL1, - KEY_WRITE3, 0); - regmap_update_bits(sd3078->regmap, SD3078_REG_CTRL2, - KEY_WRITE1, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE2, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL1, KEY_WRITE3, 0); + regmap_update_bits(regmap, SD3078_REG_CTRL2, KEY_WRITE1, 0); } #endif @@ -85,11 +74,10 @@ static int sd3078_rtc_read_time(struct device *dev, struct rtc_time *tm) unsigned char hour; unsigned char rtc_data[NUM_TIME_REGS] = {0}; struct i2c_client *client = to_i2c_client(dev); - struct sd3078 *sd3078 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); int ret; - ret = regmap_bulk_read(sd3078->regmap, SD3078_REG_SC, rtc_data, - NUM_TIME_REGS); + ret = regmap_bulk_read(regmap, SD3078_REG_SC, rtc_data, NUM_TIME_REGS); if (ret < 0) { dev_err(dev, "reading from RTC failed with err:%d\n", ret); return ret; @@ -123,7 +111,7 @@ static int sd3078_rtc_set_time(struct device *dev, struct rtc_time *tm) { unsigned char rtc_data[NUM_TIME_REGS]; struct i2c_client *client = to_i2c_client(dev); - struct sd3078 *sd3078 = i2c_get_clientdata(client); + struct regmap *regmap = i2c_get_clientdata(client); int ret; rtc_data[SD3078_REG_SC] = bin2bcd(tm->tm_sec); @@ -135,10 +123,10 @@ static int sd3078_rtc_set_time(struct device *dev, struct rtc_time *tm) rtc_data[SD3078_REG_YR] = bin2bcd(tm->tm_year - 100); #if WRITE_PROTECT_EN - sd3078_enable_reg_write(sd3078); + sd3078_enable_reg_write(regmap); #endif - ret = regmap_bulk_write(sd3078->regmap, SD3078_REG_SC, rtc_data, + ret = regmap_bulk_write(regmap, SD3078_REG_SC, rtc_data, NUM_TIME_REGS); if (ret < 0) { dev_err(dev, "writing to RTC failed with err:%d\n", ret); @@ -146,7 +134,7 @@ static int sd3078_rtc_set_time(struct device *dev, struct rtc_time *tm) } #if WRITE_PROTECT_EN - sd3078_disable_reg_write(sd3078); + sd3078_disable_reg_write(regmap); #endif return 0; @@ -166,36 +154,33 @@ static const struct regmap_config regmap_config = { static int sd3078_probe(struct i2c_client *client) { int ret; - struct sd3078 *sd3078; + struct regmap *regmap; + struct rtc_device *rtc; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) return -ENODEV; - sd3078 = devm_kzalloc(&client->dev, sizeof(*sd3078), GFP_KERNEL); - if (!sd3078) - return -ENOMEM; - - sd3078->regmap = devm_regmap_init_i2c(client, ®map_config); - if (IS_ERR(sd3078->regmap)) { + regmap = devm_regmap_init_i2c(client, ®map_config); + if (IS_ERR(regmap)) { dev_err(&client->dev, "regmap allocation failed\n"); - return PTR_ERR(sd3078->regmap); + return PTR_ERR(regmap); } - i2c_set_clientdata(client, sd3078); + i2c_set_clientdata(client, regmap); - sd3078->rtc = devm_rtc_allocate_device(&client->dev); - if (IS_ERR(sd3078->rtc)) - return PTR_ERR(sd3078->rtc); + rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(rtc)) + return PTR_ERR(rtc); - sd3078->rtc->ops = &sd3078_rtc_ops; - sd3078->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; - sd3078->rtc->range_max = RTC_TIMESTAMP_END_2099; + rtc->ops = &sd3078_rtc_ops; + rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; + rtc->range_max = RTC_TIMESTAMP_END_2099; - ret = devm_rtc_register_device(sd3078->rtc); + ret = devm_rtc_register_device(rtc); if (ret) return ret; - sd3078_enable_reg_write(sd3078); + sd3078_enable_reg_write(regmap); return 0; } From patchwork Tue Mar 4 17:05:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001339 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65A13C282DC for ; Tue, 4 Mar 2025 19:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2+a3Z9er7HS5GhzYho010S7pznnO0QcQ46P/wgZR3Rg=; b=Fp9DSNrLDs0RzjERffIUKWnLuY oOWm03pRriY0GsuXUXN+H4KQ0GKZl7DynONvfmy3KY8Be57gGkJp0+0OZ8sKcxepU40kAxjhTPXiq ZjhpijTCfl++nzqIm5kkRDdz/6GUlpRnlOVZTje1nQjkGKqcy+gjxHKPSxL8QG1p6/YpB7sNv5/12 1KPet25U7QDj+7/2v5sod5p0KkQ7fwD7FlxUsO2AiJ2wiQyQViypbL1A3HJopF/rlpx2ft2DOo/G9 LOtTi7X63jAmELUjWniq0gqjb9g7vlAERTApQq1bM2jAeBWUckqD8U9iumRfi7Iqua6+o6VJCdFhb horElySg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpYC6-000000064mo-070R; Tue, 04 Mar 2025 19:44:46 +0000 Received: from mail-wr1-f43.google.com ([209.85.221.43]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViB-00000005YEr-3KjA for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:45 +0000 Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-390ec449556so4764855f8f.1 for ; Tue, 04 Mar 2025 09:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107942; x=1741712742; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2+a3Z9er7HS5GhzYho010S7pznnO0QcQ46P/wgZR3Rg=; b=LU1OU3IkdWNWsUt/aewhUUtEn25SNdRZ7BOkoZwYtNsRO5HvLPGDu53YbqBeBoGAIy s7zOskvE1NFqsk6mLZsBeFW/OK+2B8AMN50c2ITZH1UxsWAdZRLnA8B1rElC3jETrswO rFdIhDOhNKMoAKhdS4rKAbC0Ft4gUMjRX9+CXzEyDCdlomCH1Oa6MvX0qHq0xxZ/92W/ RXdqio9G/wDbo3GHnsFabNQXLBIDODdX8vpE4vdvvEOjJn/E0P/AuGfKswljqz3GXGRi AeBtaSoZ7qxgLQTcAW+LtkPmX0TgTLcTjCYkLqc1jLpIYzwauiABuAZd3A9TbKyo+p9a ji6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107942; x=1741712742; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2+a3Z9er7HS5GhzYho010S7pznnO0QcQ46P/wgZR3Rg=; b=uoxUrL5uNEPb1UIzG//87uGo39o0NW8sWIIQcot3CMB1xFq8gHUt2uWdrv+rmNGAR8 6os8Qlvq8G8JWjq/DkByHWFO/YzS12+6erhED05F8h/UsnEtoBjRYH7BndbpxPa5DCqr ykYPug5dLNJOlJBT7REHfn0wRj3H0MKuJL1I+9tiVCmdZRuCftBZYFbMCtf6hYzFXxVP M4YziFzK+39OF+i7aA13xXFlTuqdAA2svtxVYjihBkQa4WmTSF5E6fm4q5OXLXT8y6oA yY3BJzwvwrrbRGts0F4Xm8HDVvGOimQx7zAOo4ngm1mDhd4MUv7A1wPZwOc4P0FG3/nX 8grg== X-Forwarded-Encrypted: i=1; AJvYcCVl5OfaQkh+GSUsOVe6OFAyFJbj33teOddqMs9c/6Kd78lj7UWlViGfrB0G42HZaezqKpihA40YyM0j2MAWE0zk@lists.infradead.org X-Gm-Message-State: AOJu0YxcNqKR19LjoXNbcnLkCxJbk62S93fMDkmVgoMWD5AW2s6AgkpO Ri5nBY7BiI/in0aJYYDQJyDv8fJfoBMU4/CeeWtYQwq1Ps2MkU94tIM09Chu+Q8= X-Gm-Gg: ASbGncuZeGv0xBs9Cqa1m5Di+9SAbCxx2TXSiprkSsmvYPAvuwk/3ZiCBF7OJNtV01g ITVVPiGZMgToUkzaxuFPEFMQmKmgkuQ3x4jElqjM/KGtSYmcEl3hqdjUhaQ2Tn8/kNCNs+boTJF t3fJnDcJSSq+jAZ3XM5bcq03joBxM2Fzn3wPec+tXsXr9o/LbgCLRbAXSAuJijPkbFQnBIcQtVC lzforM+QjIEopeAFsmwarFMvooc+e+SJ6lrGVI9thMT8M2jPDSv/UYH3R7m7Wheq780JkkmVsNL ipAhxc0teTjWOcjgZdrLX8VxpRpg+oqvEjjUtFIpKJ4BYfR8nI9XATliI/d3AIXnRfbjYsVTRHP 8cA+73eijd+4TAKIZ8YW0enJ1xRw6 X-Google-Smtp-Source: AGHT+IFBi6JjsYJDnSEwMCPY80NtpnY/0pWo317IbLvcMp22I1j/lVgkodnN+FQ/p9Zn6V6GISOI9g== X-Received: by 2002:a05:6000:178c:b0:390:debd:70c3 with SMTP id ffacd0b85a97d-390eca25fbdmr19248281f8f.54.1741107941433; Tue, 04 Mar 2025 09:05:41 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:41 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:43 +0000 Subject: [PATCH v2 15/16] rtc: max77686: use dev_err_probe() where appropriate MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-15-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_090543_837033_0C9AD46E X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- drivers/rtc/rtc-max77686.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 6b0d02b44c8097453f704cbec9f02580fb869ca3..69ea3ce75b5a5426d4a56b979773be71c4ee7562 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -704,10 +704,9 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) } info->regmap = dev_get_regmap(parent, NULL); - if (!info->regmap) { - dev_err(info->dev, "Failed to get rtc regmap\n"); - return -ENODEV; - } + if (!info->regmap) + return dev_err_probe(info->dev, -ENODEV, + "Failed to get rtc regmap\n"); if (info->drv_data->rtc_i2c_addr == MAX77686_INVALID_I2C_ADDR) { info->rtc_regmap = info->regmap; @@ -716,28 +715,24 @@ static int max77686_init_rtc_regmap(struct max77686_rtc_info *info) client = devm_i2c_new_dummy_device(info->dev, parent_i2c->adapter, info->drv_data->rtc_i2c_addr); - if (IS_ERR(client)) { - dev_err(info->dev, "Failed to allocate I2C device for RTC\n"); - return PTR_ERR(client); - } + if (IS_ERR(client)) + return dev_err_probe(info->dev, PTR_ERR(client), + "Failed to allocate I2C device for RTC\n"); info->rtc_regmap = devm_regmap_init_i2c(client, info->drv_data->regmap_config); - if (IS_ERR(info->rtc_regmap)) { - ret = PTR_ERR(info->rtc_regmap); - dev_err(info->dev, "Failed to allocate RTC regmap: %d\n", ret); - return ret; - } + if (IS_ERR(info->rtc_regmap)) + return dev_err_probe(info->dev, PTR_ERR(info->rtc_regmap), + "Failed to allocate RTC regmap\n"); add_rtc_irq: ret = regmap_add_irq_chip(info->rtc_regmap, info->rtc_irq, IRQF_ONESHOT | IRQF_SHARED, 0, info->drv_data->rtc_irq_chip, &info->rtc_irq_data); - if (ret < 0) { - dev_err(info->dev, "Failed to add RTC irq chip: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(info->dev, ret, + "Failed to add RTC irq chip\n"); return 0; } From patchwork Tue Mar 4 17:05:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001350 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ED85C021B8 for ; Tue, 4 Mar 2025 19:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dKiEbfv2wxdcP+dRwBnTiew8ux2INId3e+zLxFho3GE=; b=Ac8dgwbvJVIZnA+hykUlHOB31z nXu06kuagcauO/MTgYsgGyfiQLC6EN8krchHxEg9lsVe/AJsxVwgL98BBnV7oqNVKcSczJxYvHKBM 0/m5JNAklfZ7mWGYT+VCQi0uX1YTT31h6uBFr/0/2+7JRo8lKiXhk2oPZGHEWwStEygApi1iAJex7 raD8nU0DGACEzkjb2oDKMHq7r/fgnqqLoEgtMTr6FhbK7ZsLCx5GHTAEnrtFun6VIbQlXT5m1YJ/I Opmwuylb/Ki0wMIlG72McWQlOhE1ow2/wqRtFfQaRCsKsLSbSa8oQDQaOoT5i4INaqCJBHvGfmHfe aV6QN6Vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpYQb-000000068Iq-3s7O; Tue, 04 Mar 2025 19:59:45 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViI-00000005YHA-1vgL for linux-arm-kernel@bombadil.infradead.org; Tue, 04 Mar 2025 17:05:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=dKiEbfv2wxdcP+dRwBnTiew8ux2INId3e+zLxFho3GE=; b=ANOgTmjQUFGR2Q/yc+CgbKjboX iQ8Vz3WU8x+H8+20dQoiWzFF+IGF/SvIGGdxmLp/Jnk29Jf0hCPlWAFrkbcANxM+OWS+iV/Fi3Hnq h+OupmOmJPmB740bFCsQuOpcTy/7E2kpiF1hcG52eXfGDVX98xhe6/xsHeibWbNssXerYb0kp376Q bQU5srau8DPMBq2Dmxx2Quoq11vQ8viOdsChh9mz25N54YLuyEuEMV2DE8LMQf/Oh8h+AcUgtfyx3 knjYpb2J+6qljm9HEgyMkpG+4b3XD7idIqdeV+KaTsDl9lj/lJAlIDaL/6R82hBMHz57P3DMP16Hj uljgS5Bw==; Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpViC-0000000075G-2Lbw for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 17:05:46 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-abf48293ad0so587734866b.0 for ; Tue, 04 Mar 2025 09:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107942; x=1741712742; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dKiEbfv2wxdcP+dRwBnTiew8ux2INId3e+zLxFho3GE=; b=EE2OgQlutDc7K1zO5JyyjECN8fM57xCEZJHv0GnxImS30+jRC4hO3NAtU829DcU44J y+R99mNtxnWxBf097AayPnq/eGWoerqW2jiwtVEGSjQTxCuGyb1PwBmF5ttp6pha8bOl 3MxD8G6Cg/Lo8tWBdrSOXep62pQfZGSXXR5WBIXPLlmp/NaIA+apjVWqZ5EvCfG4SNLL WmZLHpeSl9cvy0jL7RhXcvfzddOATrvq05Rn4rTjBoAroz1KEzX+gTnc37020lKPYSZy qv0sh+4e4g12uK6HVTCWqmyGElId85xUN2YsfCIxCX6TK9+/tHZze9aY+8KV/GAStFKz 1CjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107942; x=1741712742; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dKiEbfv2wxdcP+dRwBnTiew8ux2INId3e+zLxFho3GE=; b=PK361GnQvHQCqWltjb4WcHhdMH60G2No1t+MdXZXHZNApNASCC9fccRT65r18Gqif0 /aDX0SxLINWYEp0hGhROG5+hG2rAAcOzaKIFIJp3p7QTLi5Ud6P/dMkyV5wdX7nGMjzf EuHlKPL5epaSHZCs8CxrUoUFgIGoZpnFfdU+YE/yo6TFEpBnmsk0qKEkifuvdpUkU9Lv t+FJBgwXmYDFVCfSjvyL/aYjeMwH4UzVkaqS2kHX9hXdbew3gzixOw8S3tmIv6XTz4KE k3M+YyW51LrTLeJHNZ0Xf4NrxQELWupn/I0ksUAks49UjK1sQqAKG3Vujenx0HDLcDhi LfLA== X-Forwarded-Encrypted: i=1; AJvYcCWKjAG/oLJBilq/XetQxQrzYJGgUwsyt/WBCYX5Pu9g4cEWx8WThYpe80pkDjRD1rdWreHU28JaIVdnMlE7rzff@lists.infradead.org X-Gm-Message-State: AOJu0YxkFN8SNIW8azorXKwIJQmrBPTNHLZ/nDiGJdRcGrvM2XCcFeEX T4xnQa0rFR9jfOuRxahvFB3fk06QXtAbaiEb1FfBWbBpsQU1mrMNa24Qe2E6tdo= X-Gm-Gg: ASbGncvK265rPch/WryluQIXvBQumgj/g8jo77o5bLx/HT5EwBSwbaCsGi3PjMPjNWr cDDO1WOOPccNM1X0rJy2+++C5yax+Ut4A6Hw334Zt1cR9zZ7ifVemmWdTuoHNanwfRtzv11JWw0 9ZuOKLyjV+sa3DyrZrXn8VGeYPmI5SCNn/4xaSzoVKCT1QiJuRl8Za1JbtsEgheno1YXB33dtYP 99dP+fX78ZuvSiiw707yKwZEU8O44/2kZ8f0UoHBJsHvNMzTyjBlAUohJzjkX2mK7aj8S36zgzz XeNlL6ap58V7ForY0vp6IJNiRCd+HdNa7xZ1SIHa03JAAY8gDDfwURj2nQ3pBvHv7E5/uowtsxj V+Bir7S43QY5KYbkgZ3/zA7kWcMde X-Google-Smtp-Source: AGHT+IFbhvINfL30hs3YpvAxvNGhpuF08a7SPp+ErND7dZCCpi05AobDmHrT2jaUznfQQ+NeOSHQXw== X-Received: by 2002:a17:907:2d0d:b0:abf:777d:fb7a with SMTP id a640c23a62f3a-ac20da97c7dmr2947466b.46.1741107942351; Tue, 04 Mar 2025 09:05:42 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:41 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 04 Mar 2025 17:05:44 +0000 Subject: [PATCH v2 16/16] rtc: s5m: convert to dev_err_probe() where appropriate MIME-Version: 1.0 Message-Id: <20250304-rtc-cleanups-v2-16-d4689a71668c@linaro.org> References: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> In-Reply-To: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_170544_918201_5FD9B643 X-CRM114-Status: GOOD ( 15.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- drivers/rtc/rtc-s5m.c | 50 +++++++++++++++++++++----------------------------- 1 file changed, 21 insertions(+), 29 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 88aed27660348a05886f080a2848fcabbf9666d0..db5c9b641277213aa1371776c63e2eda3f223465 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -626,11 +626,10 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) } info->rtc_24hr_mode = 1; - if (ret < 0) { - dev_err(info->dev, "%s: fail to write controlm reg(%d)\n", - __func__, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(info->dev, ret, + "%s: fail to write controlm reg\n", + __func__); return ret; } @@ -669,26 +668,21 @@ static int s5m_rtc_probe(struct platform_device *pdev) alarm_irq = S5M8767_IRQ_RTCA1; break; default: - dev_err(&pdev->dev, - "Device type %lu is not supported by RTC driver\n", - platform_get_device_id(pdev)->driver_data); - return -ENODEV; + return dev_err_probe(&pdev->dev, -ENODEV, + "Device type %lu is not supported by RTC driver\n", + platform_get_device_id(pdev)->driver_data); } i2c = devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, RTC_I2C_ADDR); - if (IS_ERR(i2c)) { - dev_err(&pdev->dev, "Failed to allocate I2C for RTC\n"); - return PTR_ERR(i2c); - } + if (IS_ERR(i2c)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c), + "Failed to allocate I2C for RTC\n"); info->regmap = devm_regmap_init_i2c(i2c, regmap_cfg); - if (IS_ERR(info->regmap)) { - ret = PTR_ERR(info->regmap); - dev_err(&pdev->dev, "Failed to allocate RTC register map: %d\n", - ret); - return ret; - } + if (IS_ERR(info->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->regmap), + "Failed to allocate RTC register map\n"); info->dev = &pdev->dev; info->s5m87xx = s5m87xx; @@ -696,11 +690,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) if (s5m87xx->irq_data) { info->irq = regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <= 0) { - dev_err(&pdev->dev, "Failed to get virtual IRQ %d\n", - alarm_irq); - return -EINVAL; - } + if (info->irq <= 0) + return dev_err_probe(&pdev->dev, -EINVAL, + "Failed to get virtual IRQ %d\n", + alarm_irq); } platform_set_drvdata(pdev, info); @@ -724,11 +717,10 @@ static int s5m_rtc_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(&pdev->dev, info->irq, NULL, s5m_rtc_alarm_irq, 0, "rtc-alarm0", info); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", - info->irq, ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "Failed to request alarm IRQ %d\n", + info->irq); device_init_wakeup(&pdev->dev, true); }