From patchwork Thu Mar 6 14:43:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dev Jain X-Patchwork-Id: 14004618 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01936C282D1 for ; Thu, 6 Mar 2025 14:45:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99AD6280004; Thu, 6 Mar 2025 09:45:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 923FB280001; Thu, 6 Mar 2025 09:45:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C5B5280004; Thu, 6 Mar 2025 09:45:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5B2C8280001 for ; Thu, 6 Mar 2025 09:45:46 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0F2F11CE0B1 for ; Thu, 6 Mar 2025 14:43:28 +0000 (UTC) X-FDA: 83191394496.23.6D40648 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 746441A001F for ; Thu, 6 Mar 2025 14:43:26 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741272206; a=rsa-sha256; cv=none; b=0sqk9NJlAIOogVyXXrSC4CudpORRj94n7hFDSznqIC7wkq2FA+WIr0zQLpQ3ogQ5BsmQAN aM4H/jSLFA2HQZaCluLYSyzLHgz3clm4K3F0YPtl/sOMuC1LeP5QEa2P6LMLT/A0zAjoRL liZR6L6DxSmwKsNztFI/ZRKe+mN2wYM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741272206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=Y/WxyYrHJKHI/aZKjwKl4PHoFygO3DpuUKfm64Mjqys=; b=oYFNuZNnh4XnuKBOqHKCuEItOnJ75VP/yBq7dg+VbLqMNt+bMZjhgdPtDprW7J/RWPJvj9 c5pttwLdkotAeWDIrdGo9IT2jq/k0cYnW5ZrXXyNDvxg8XhTTGX2PxTb3sjL7ZLtQwh4yq HBTdPRiRFo5iv33GBd57aJcEC4cRRY4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F3AC1007; Thu, 6 Mar 2025 06:43:38 -0800 (PST) Received: from K4MQJ0H1H2.arm.com (unknown [10.174.36.159]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A410B3F66E; Thu, 6 Mar 2025 06:43:22 -0800 (PST) From: Dev Jain To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: ryan.roberts@arm.com, david@redhat.com, willy@infradead.org, Dev Jain Subject: [PATCH] mm: Remove redundant return in set_huge_zero_folio() Date: Thu, 6 Mar 2025 20:13:15 +0530 Message-Id: <20250306144315.21907-1-dev.jain@arm.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) MIME-Version: 1.0 X-Rspamd-Queue-Id: 746441A001F X-Stat-Signature: idx38pd8txe8jcw9xt7s4rjpny6qncsn X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741272206-207690 X-HE-Meta: U2FsdGVkX1/J/pnlcKCWqoQ8XeWS1BcjUJtTFMEhjlmjneqvk+zSgQzzs1cY3aHG5pDDjLQ0NyGMbUa/yGs6BDhH/1GVyMXI6cfpeVs6Tx+fDv4BRCGp8LQPk+ya/7hoyjxKO56hYZd5Zv40KP+GEv4YmAQVZDeZpGwI0h+NQZKBw8jkyrgUKknwGQ0HTaECkrpYeurYakUJnSmRo+a6mwtFHrdwH/4Q55R2qHrS7jsUfHtt98znEil7hTpf/2cVpH/Oo/tL3ImilEBRaYaCmEXQijSm2uOr7McThy7h1NWGria4XvSSgsECXeVcmrmC42JM82wXVuOVaVap/KnRRbkDRXfKMf/AnxXVA0Mvgr5KualZwfAEBhGZjSga45OUKqre9gRh4H34DSsuCbhINYPvKrOfreRpJgbqtanEO7Jzhc0GkHAu05HPFzHTAfl6rAxA1czYzB5gYdo5P59nxLCrxLdVrFojGTL8Qmc1HxgT87hIjqAjELyyTh1MAxfl55dG11cVNlHP1KGpkcszIJ+mtfIlHBDLpGdXLdj+8eJGf7CiVCCcdkI53rWL8RoVwW59Afg686pK1YUOulad391XMwNtsQ18TkG8rnURqNcrnYdkzEb4mOA+NttZ7JwWUlxpPySvO1vVhXmoXUdv4HoeWlyIrblbYowasq1LVqQPYD60AZ1xS+wGRtIzPkZjFbGmRR4BtTqLpJwD02hd7sfU+fpDGtXzRlTCDfoVRKP3/D7yw2RJ5JfY4lbxW8YHSkNYOTPhMkBeM1p91QXInXQwZ1jdmupQ7zyctmAe6QrfR5YwXdh7o1DhQQKBSCv2kBoBfiwx3TZbgCFSDhXtsNX1w7+Dg16ufSx3xs/7gXpcgdROZamMqXKh3fA85ElkkCy5WbMXl5y+5vEfHYyt/Cr9J6gigsvPZP5nVHFkoZL3mscym4xb1uY/7Fx6+BfgDPoxlhui49CAvBtQPVW lOxFGuZW 9kZh9yfZl6uOQ8yr5fiwEm6/yDWINKpP/0llx9eM2dvTU6rEfyIJIMPHgOCf4x836WfLfSzP6DaAN91ddu1pUXALwZwtfRutRtHxoc2XYUQ5KSrucJtrXgwbu3We0WtoL2PP99xplSAaG+AaI0dBBWIq9CXew10Pg2xnmj2/iErrdzXsFJc3Rvv0xZScpdHfL/lFS16TLrtL5rCE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It is the responsibility of the caller to check pmd_none(); in any case, we are not achieving anything by returning since there is no return value to tell the caller that we succeeded or not. So remove this check. Signed-off-by: Dev Jain Reviewed-by: David Hildenbrand --- mm/huge_memory.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 3d3ebdc002d5..f64212d674fd 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1309,8 +1309,6 @@ static void set_huge_zero_folio(pgtable_t pgtable, struct mm_struct *mm, struct folio *zero_folio) { pmd_t entry; - if (!pmd_none(*pmd)) - return; entry = mk_pmd(&zero_folio->page, vma->vm_page_prot); entry = pmd_mkhuge(entry); pgtable_trans_huge_deposit(mm, pmd, pgtable);