From patchwork Sat Mar 8 02:27:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sunliming X-Patchwork-Id: 14007392 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7BF1C28B25 for ; Sat, 8 Mar 2025 02:28:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C92456B0082; Fri, 7 Mar 2025 21:28:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C43656B0083; Fri, 7 Mar 2025 21:28:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B31C16B0085; Fri, 7 Mar 2025 21:28:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 946BD6B0082 for ; Fri, 7 Mar 2025 21:28:22 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8576E141347 for ; Sat, 8 Mar 2025 02:28:23 +0000 (UTC) X-FDA: 83196799686.23.4E4E939 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by imf17.hostedemail.com (Postfix) with ESMTP id D71AE40004 for ; Sat, 8 Mar 2025 02:28:21 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BrQvCDOS; spf=pass (imf17.hostedemail.com: domain of sunliming@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=sunliming@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741400902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=2MJaxTSbuivKRt/mwyd9lFXJjHZyzoNQYJijn/Im+p0=; b=Vo5qijzI1N2Qf5qo2o2gzdK2IqxnJuh6cvrd4xPXcRwKN71OoLsyYOEO1DXUY87i6zsuof DGRUh27GagW5PO8sr34NfJlwWDQH40/r0ZMzIyvACvn4oGHPzH241Xj2N+7BtqotclhBru E76xHdM/zCPJP8yfBYpv/eFQuG6gTFU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BrQvCDOS; spf=pass (imf17.hostedemail.com: domain of sunliming@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=sunliming@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741400902; a=rsa-sha256; cv=none; b=ra5RVaEj8AjghX/njKcmtA1G9zvRHtpBW0LkGexkBkW1YsPfsISMOxxobRknumMrq7vU/N 8xvA5DaPUHiUIlmCZ2fJYcom0PlD6jUr7mRR0Kn/FWvn3grL7TPbIoCb77yOUnJSo4xbFc kLI0FJ9vI1fP1TtvUOfWnVqXLyTbn2E= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741400900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2MJaxTSbuivKRt/mwyd9lFXJjHZyzoNQYJijn/Im+p0=; b=BrQvCDOSDCliLRm2GbkyJoy2JTds3aVOo4i6YndpHSuyhh+E7ZAJ4/mhY1AsE5kiEm+xtz Z+/brjcVfoqMNotGcVMYqwuipno42D3uCmdU3r15QlrgvPduz/f+hR2UQFLiWtevoAjjsW nuMyIVUwAoA47d2vrzwbZZNz/6in9MY= From: sunliming@linux.dev To: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, ebiederm@xmission.com Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sunliming@kylinos.cn, kernel test robot Subject: [PATCH V2] fs: binfmt_elf_efpic: fix variable set but not used warning Date: Sat, 8 Mar 2025 10:27:54 +0800 Message-Id: <20250308022754.75013-1-sunliming@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D71AE40004 X-Stat-Signature: rhe9obre31s5d5amij5kghursk3rw5rk X-Rspam-User: X-HE-Tag: 1741400901-954816 X-HE-Meta: U2FsdGVkX18gjX7CoisqOHsC/lP9j90aOzEU5tHRfbpL9GosnJaOKnlCyIUZ0IUjs9m853TQVMrx2aDz0x1bJnoUyJ1Idl3hmNjm98yNT/H1yyhHWCSWgPARIMMWDRiEytLEYyLekYMZ6fAaes8e4KhTHG3xRcw3v/edurV3UexSB0AJ3mEagK2ADHX+nGSLzLlVXd7iLJW2JDfZfWAivPo7fbyYMsCV0vRbkzNwQj7hZZ8sCjK6BfpfhEjVABXbCJH4iaZpayRUs1Kc4rUOOuIoU7r61cqzMkXncmzvbOyMKxtXcqM4bjkXX+u7EGFtyeKSjNsD6k5QGPrSsEgYx4z+wkIw85SaM2YCPKmxLa353uMdbuXa2gthEDA4mgJSOO+3Rb9LgcCyoKzL59fwH4boncM52wMmfUuD86Tt8walX+3DMHQH2WZQR/3DB9tOUUlmUxvxNHH6hcihM5W0KPhj7TxTUOcps8nvJbFFwPWMhRFBqK1IzhCjUpX942k0HZfQsFTCFPAJBXHS4Okw/KTlhRUlQfVHIs7RRdybTh35x1w938j723WLxY4qOqzBg9Ag1yiQgD77ZufA7ENZ/9bGiBZA1AJSQIAm9VzLR+OtzEvJbAMyUH+7Oj9U6IGlc9joz4nFuIMWIk62FC6qfiWc9EXbS+2KY69UemaHE8xhWnaq8/Nx3mrOZHGdjAmzzwE2JFTgNo4xvlKffQG/10rXnfgum4At8bw95vEpeiRWp1r000Cpqkq+JTWUYT0YAaclxQTeW1NiXUgrVvTTV9HaJBamIJeYqaSpR+rYgBjMWmANzygbeejNBmt/9blv7hw0CnVkVjioNdw9YQP3wsXeWrR7WavLe/UardoHK6IRx5ZWtHcE100PqWBq+SJhUPrIyZra5OSdAfOC/PaQ0Lb4Xnlyj/5AUiwY0z972HYMkbxyBM/Tr26W3cfZ90Km6p64Fmi1TW93QC84779 rjtOJEDX 7fZPqVq40ndkE7q4v1N5duNlu3fFZufVrgvX0Xnoe04h86ghE4utm9D67tjKCQw7GfldUutGG95Ye3CiEqVj4cdi/fWiAWs8OBVKS9peMup56l3vQUBOFut4fI0StOeL7NZIDqXH8FDY+sYBCNqQsH8T1jWt8Hrk75dYEaeQZXkvZLEIdmQUe9yO9zouNZGqTtIfXcS6Vzvdq8xT9I2Is9a7GyHIupq8LMB0hKGmlDJTydFJD8HH0uQK0utsFEt0f0QDt4Xbxd+9eoPrstjMbqaaMZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: sunliming Fix below kernel warning: fs/binfmt_elf_fdpic.c:1024:52: warning: variable 'excess1' set but not used [-Wunused-but-set-variable] Reported-by: kernel test robot Signed-off-by: sunliming Reviewed-by: Jan Kara --- fs/binfmt_elf_fdpic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index e3cf2801cd64..a1ad3c94b2b7 100644 --- a/fs/binfmt_elf_fdpic.c +++ b/fs/binfmt_elf_fdpic.c @@ -1024,7 +1024,7 @@ static int elf_fdpic_map_file_by_direct_mmap(struct elf_fdpic_params *params, /* deal with each load segment separately */ phdr = params->phdrs; for (loop = 0; loop < params->hdr.e_phnum; loop++, phdr++) { - unsigned long maddr, disp, excess, excess1; + unsigned long maddr, disp, excess; int prot = 0, flags; if (phdr->p_type != PT_LOAD) @@ -1120,9 +1120,10 @@ static int elf_fdpic_map_file_by_direct_mmap(struct elf_fdpic_params *params, * extant in the file */ excess = phdr->p_memsz - phdr->p_filesz; - excess1 = PAGE_SIZE - ((maddr + phdr->p_filesz) & ~PAGE_MASK); #ifdef CONFIG_MMU + unsiged long excess1 + = PAGE_SIZE - ((maddr + phdr->p_filesz) & ~PAGE_MASK); if (excess > excess1) { unsigned long xaddr = maddr + phdr->p_filesz + excess1; unsigned long xmaddr;