From patchwork Mon Mar 10 13:51:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 14010050 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED7DC28B2E for ; Mon, 10 Mar 2025 13:51:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0E35280002; Mon, 10 Mar 2025 09:51:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBEB6280001; Mon, 10 Mar 2025 09:51:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAD77280002; Mon, 10 Mar 2025 09:51:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9EAF7280001 for ; Mon, 10 Mar 2025 09:51:50 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 50BF5A990E for ; Mon, 10 Mar 2025 13:51:51 +0000 (UTC) X-FDA: 83205779622.18.BA2BCB5 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf11.hostedemail.com (Postfix) with ESMTP id E265240019 for ; Mon, 10 Mar 2025 13:51:48 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n4P6hSR1; spf=pass (imf11.hostedemail.com: domain of arnd@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741614709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=5xRDsRxkXizFvr9ZhveRa3YHesfXmp3s2C4WrzZ3w9U=; b=qjlPISqNc2KBaFmFteBkY+Us+YiFGzsUgu0xUNS0AtWS2krEY/7TCmKBauGpPXDgLIXWST 2/IAmkNWazBpRkiPwERhLJ1dMYFiVpB3wofVY2SC3U0yaZ+p+nG3mvO/TV4RYpsdaqND9e udKSeikGQU2awZ9Jup1aVUhLUqYfqSA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n4P6hSR1; spf=pass (imf11.hostedemail.com: domain of arnd@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741614709; a=rsa-sha256; cv=none; b=IfDVx3V4Nm6+X2xnm4KE5+SrgvHG9w5G+lsAJdV7hgBDv1woeqMED+zTFs3jCc6FUTSira ufpor25L3RQbshlnaqoc7Ib7OmO07q1zAg+i8WBHOFqA9zGLqqEu6+G64I5wKK1ffdWqq1 ywoZjwTn4sEQKXni5sFcrrOqe86zuyc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 5CBC0A45C4A; Mon, 10 Mar 2025 13:46:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 642E4C4CEE5; Mon, 10 Mar 2025 13:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741614707; bh=a+lFZ0YwCbTM+uSgXmIyMxhwWDrnxR3g5GHAb9Vg+38=; h=From:To:Cc:Subject:Date:From; b=n4P6hSR1A5/XvBEponlCkImC7nEEJ7usnFTBuvewSUI+xmkLJkU53hL7wgBMm1W1B 5mXea52sCjuhcTqioS093M5fJncP1nxJG75VlUzEtYuXmcbbS2F1EMeIE7u85DZu0R /PsV1vw5zr5o7D2Vg3DB7dcWopjjWRbuhlx1GiuBBSO177txLR/d0Sfv4iXaCz7N1x 0QqxXlzHKochi7eGvqsfUEUqyeLllastqzxlGfu+WUETaJPtx31RtWHpI4PT50aAwK kRmGg/b8GPsNhTae9aTbJU84sMC1GBtDlxatdnQ6yC57A58ZI/2yfA1CzGSJiD7BML 8X/lYArwEyymQ== From: Arnd Bergmann To: SeongJae Park , Andrew Morton Cc: Arnd Bergmann , Hyeongtak Ji , Honggyu Kim , Usama Arif , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/damon/sysfs-schemes: avoid Wformat-security warning Date: Mon, 10 Mar 2025 14:51:37 +0100 Message-Id: <20250310135142.4176976-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: E265240019 X-Rspamd-Server: rspam03 X-Stat-Signature: ijwdbueighi4z48z3kshehaoupsef6jr X-HE-Tag: 1741614708-227555 X-HE-Meta: U2FsdGVkX18yDqZKRDZC9BCVmFJM4aAQU8Ht4lLFeh+321IR5Hi6TMp4C7yk5fY3awuccmVm9VA0qVkONKQz/DLU8CXJDa9PJErhvYMJlKY7Gk12xLcqP+I4okB1o3v/ekK0wGE3q8dp5i0aYupXxHOzsZGTZOK5jRzylgju2W/4kIcODjTd7cPnq2c3TLd9ONsoVRVY1EBNRJ6+XBEPKW1yptIMBKyFG50eGC8tbejNWDdDMWDZpPFSwV5Dn1vv/LnWn0G5Js8sZ0HHHvnHwDKWnGdixNvxBNln+iYhwEiahZrjwN+U9pLTqr04CvtGXmA5O5ITvHUl9UjZZvusCq5iJeGzANRpfIq3dNikbS2U+ufob2pigKeSP9s9bKPelAx7fg03s8XKz482+LhhaGCqzSTEBZcDmgZDIYruGL9+XkZCsUfjdZRfb4XykLJ46w+2UldCX4CC3d4CMgC27igp7sLa+0PVjW+NUO0vhHWzMqhW/P9zLyIqQKIkkWDxFKNLzWJ0Uu3+edEOE4V9mvM4Rzk+gBMzSoVAazbKjs4mnx4/corob0FxTPMIi5boyTFfQ9pV7IrwwTIFAJ//3aPTwa47Gj+2siH2HJhsdbN+T9c1mmDxCt6sWYQhqkyYgaedhuXSS7fUaYsDYzcU7WbP+2RfkimpTsd9CRi607baluyZdgeFmbZMJM9i84LTKIQ9WbYC/PCY3pYx9ItpWVWXhZkvWIdRH4tySH9990xeZwH4UzGdgK9kSPeqS1VImdlS7Iv3i+9LhNiV4oDBJbpLtw9V4DO5Pat5txjzjk2zeSH9JC3d2tuxmmqQZvqB+hA5vC+hLlm1yOvKcj5xwJf6PyxSNDujUdL+wgFB7Cg5Ta4y1mNHF4WItnHlKJ3kInQeHqeEQ7r7T4VqNWrYx4snlkGCFYLd0sZQ3M32GSaFH6gVUJsu88ixGSe9fGFWDojOV5gIbQgQa40qAs+ cdQDC+A5 HgtCPbyzE6IfpiuRaG28r3WBkFfizxxWcs0B8ILQuRol140lmm65Gpj1P5rJ1exBNOyBzbZo+QRUDmj9EIieLo9k6/Nc6VX7wU9MR9tPkdpNlY06ZkmaM+sbW6SmwCeRGipYB757rq7BOvrYqLJg7hXRv8ras3BMhaLy87LbCphDqSCFaUc8JuI+5zuW3vEcb3LKzxDGx2dEG9dY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Arnd Bergmann This warning is for potentially user-defined format strings: mm/damon/sysfs-schemes.c:1664:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] 1664 | name); Change this to use "%s" as the format and the name as the argument. Fixes: 92bc039dd72e ("mm/damon/sysfs-schemes: let damon_sysfs_scheme_set_filters() be used for different named directories") Signed-off-by: Arnd Bergmann Reviewed-by: SeongJae Park --- mm/damon/sysfs-schemes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 50e6907515e6..23ac98dd6451 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -1661,7 +1661,7 @@ static int damon_sysfs_scheme_set_filters(struct damon_sysfs_scheme *scheme, return -ENOMEM; err = kobject_init_and_add(&filters->kobj, &damon_sysfs_scheme_filters_ktype, &scheme->kobj, - name); + "%s", name); if (err) kobject_put(&filters->kobj); else