From patchwork Mon Mar 10 14:34:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 14010103 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05BC1227EBB; Mon, 10 Mar 2025 14:35:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741617313; cv=none; b=pmTR1IZTKGDvmWJ3aYI9W0fCSl4058jU3ZYolK3o0hcsWJe0WDl2Fq06SuPKPG9RziPV45jzfOv7LnEYHSgkmofnF8OX0wlPJADaXo8g34RcnasMdDdGzaUwdymR6yRY3XlInGEbbOJj/T+3QPY4tzTmOxjWQPS9uAOVa1uqbj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741617313; c=relaxed/simple; bh=jt7NDGc8noYexdYzv/8Lg3bRt9IuUj8K8Bh1YPqYeHE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=emtObuveJJ19IxxUZ8vTffjaMaAdiswspepVEETpPokvfDi73DTDYcrcDv8ISumbtO+YQrrYacZxjBm2YPUo79LV1XNtihwEchOhorf4HzanLEbzJIZ66RnJXMDHLdT2VB/7VPSrz2qtBHQr4Crpm7mflvRfvY4bnxc0IAyeI3c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gqmoc2xR; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gqmoc2xR" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-223fb0f619dso80743755ad.1; Mon, 10 Mar 2025 07:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741617311; x=1742222111; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k3PCN1rM0WbHIM2gIVr2uSVcfKomlI7ImWzVGLtI+Ys=; b=gqmoc2xRJLcxH4pWuEMHRb9n/n1Y2FYqFaizutBrDSNVT/2WIH1ponUMROsELxFnRa ts8Hr5U6PI+uakVKvPMz66bJ/Ye5fnh/R6fwccEPqO2WQ+kkKAzFChm0ARtfG3zsUYmO ePhymFPmmNYc9MJEJt5cUEcMPLecWyMwQqXRsD9pnuOlEN5quSB7/hCZJeKCdk7O1HCa yN9nZx2sFSxr/6mqOW1mHYaB53I+sP+xuoLnEc66aMmTZCozYCpe5j6OuB8AVbgvbj8C exOAO9rE2Ebsh3O1Kf/XWDH+r0tYp4R/8Dw75gkrBQ4ziQAk6AixTR7sp93JRHRAHRvA +r8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741617311; x=1742222111; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k3PCN1rM0WbHIM2gIVr2uSVcfKomlI7ImWzVGLtI+Ys=; b=TD1FlHRq1OWIg17FtM8euAgFYCV6t8QjiQGqwVOZ4UxZ6wFyP7YUCJicbmOIUwPhYc RP3PNOq+nyVOrhR2Q2JdK7uhDUaRZc7a1BMm+Bn7KWAKa5vaNnC6b+0aE12IF638cuaS N5qv8L86vg09sb3tzNPQ/6mlQPo7YPuGMDtGrqIzmH/MgzAwNdXrqYIv6s/nBynWyQ09 Mh2lRA1VnmvW6SrnUvmo6iixMCwfSk4NrHPGuVU8lHAXx9dJZWeEr4ZVLGYwW9ayBjbU TGrL41cSBWJxbElZ+3IBZDCUIWwxXjsZJFuXv47qXSxxDGhY+c/9rDE/9n37++XE5vdM Z7kg== X-Forwarded-Encrypted: i=1; AJvYcCVkAl4TihBU8RXrwxgY8KuD7P7QbcGgFf4x39OZy8wO8UvzqBHsTmtE2bUUiSTqHw/Q6MlDft5EtdT7ySamsd463A0=@vger.kernel.org, AJvYcCVkFO0B+RdpnhWWufcdEZC1xweGsL3kCLPiqWltBExV08hcYcs4VxYcOWrXGWe/YaEFgu8v60uYl3VWn7E=@vger.kernel.org, AJvYcCWtM1UPb2Jtbk0vF3HMfD/RdgEIovA5283k8cU9G1NK0v6wJyV5mcfSd27sE6YxaL1ahxmZOQxUC9U=@vger.kernel.org X-Gm-Message-State: AOJu0YzjcV1blVlYdwhTchLXJKj3mUGCavmZyIKjDPiG2nC/Zyf4m9UL ZpFFnJwuaYoMAJKnuTElMENzfuJ8RPNPLqdxKv1U7um9DOvNlu1E X-Gm-Gg: ASbGncvHxv1H80A4hUvfcdFepSNRKI3G0aqT5iFAbDb2dvuY0nyScW9I0pDZKbcCR28 B7aP4E7FT2z0ktDga+h3DCgv68yOANQ4KZjwESVfGze+W3jYtciTMKFgYwN2ENGGorZqUusA5y4 xw+hJZQ0DdkuchI4TVd3jHHqbkk8x2vIpHT5kUdRv/SGKiTsY6hjI0A+4xfIF99HLx8zosX56Ba UwsiEgpRgG+TMosTxOErc58/OF9A2UKbwAN+oWLHsrjVJLXTx7nlBCmLOLqVyjQy6/xYrnxsDpa 48bLTcStrmiZ7XfnGuVEgn6AgxzNvGdYT1YG2+CjSXyobmo3Dkbaf4/yLec= X-Google-Smtp-Source: AGHT+IGRjAcGVcNUlBufVXhtdKF6feTENZiruX3FJiNFzexU5+dfH+syt6bCsQK3e8kMsxDHJZJ4HQ== X-Received: by 2002:a05:6a21:46c4:b0:1f5:6d00:ba05 with SMTP id adf61e73a8af0-1f58cbefa96mr2309637.38.1741617309689; Mon, 10 Mar 2025 07:35:09 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af281096763sm7785900a12.30.2025.03.10.07.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 07:35:09 -0700 (PDT) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v4 1/4] drivers/thermal/exynos: Refactor clk_sec initialization inside SOC-specific case Date: Mon, 10 Mar 2025 20:04:42 +0530 Message-ID: <20250310143450.8276-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310143450.8276-1-linux.amoon@gmail.com> References: <20250310143450.8276-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor the initialization of the clk_sec clock to be inside the SOC_ARCH_EXYNOS5420_TRIMINFO case. It ensures that the clk_sec clock is only initialized for the specified SOC and not for other SOCs, thereby simplifying the code. The clk_sec clock is used by the TMU for GPU on the Exynos 542x platform. Removed redundant IS_ERR() checks for the clk_sec clock since error handling is already managed internally by clk_unprepare() functions. Signed-off-by: Anand Moon --- v4: Fix the aligment of code clk for clk_prepare in proper if/else block. update the commit for clk_sec used. checked to goto clean up all the clks are proper. drop IS_ERR() check for clk_sec. v3: improve the commit message. --- drivers/thermal/samsung/exynos_tmu.c | 37 ++++++++++++++-------------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 47a99b3c53958..3657920de0004 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1037,29 +1037,30 @@ static int exynos_tmu_probe(struct platform_device *pdev) return ret; data->clk = devm_clk_get(dev, "tmu_apbif"); - if (IS_ERR(data->clk)) + if (IS_ERR(data->clk)) { return dev_err_probe(dev, PTR_ERR(data->clk), "Failed to get clock\n"); - - data->clk_sec = devm_clk_get(dev, "tmu_triminfo_apbif"); - if (IS_ERR(data->clk_sec)) { - if (data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) - return dev_err_probe(dev, PTR_ERR(data->clk_sec), - "Failed to get triminfo clock\n"); } else { - ret = clk_prepare(data->clk_sec); + ret = clk_prepare(data->clk); if (ret) { dev_err(dev, "Failed to get clock\n"); return ret; } } - ret = clk_prepare(data->clk); - if (ret) { - dev_err(dev, "Failed to get clock\n"); - goto err_clk_sec; - } - switch (data->soc) { + case SOC_ARCH_EXYNOS5420_TRIMINFO: + data->clk_sec = devm_clk_get(dev, "tmu_triminfo_apbif"); + if (IS_ERR(data->clk_sec)) { + ret = dev_err_probe(dev, PTR_ERR(data->clk_sec), + "Failed to get clk_sec clock\n"); + goto err_clk; + } + ret = clk_prepare(data->clk_sec); + if (ret) { + dev_err(dev, "Failed to prepare clk_sec clock\n"); + goto err_clk_sec; + } + break; case SOC_ARCH_EXYNOS5433: case SOC_ARCH_EXYNOS7: data->sclk = devm_clk_get(dev, "tmu_sclk"); @@ -1112,11 +1113,10 @@ static int exynos_tmu_probe(struct platform_device *pdev) err_sclk: clk_disable_unprepare(data->sclk); +err_clk_sec: + clk_unprepare(data->clk_sec); err_clk: clk_unprepare(data->clk); -err_clk_sec: - if (!IS_ERR(data->clk_sec)) - clk_unprepare(data->clk_sec); return ret; } @@ -1128,8 +1128,7 @@ static void exynos_tmu_remove(struct platform_device *pdev) clk_disable_unprepare(data->sclk); clk_unprepare(data->clk); - if (!IS_ERR(data->clk_sec)) - clk_unprepare(data->clk_sec); + clk_unprepare(data->clk_sec); } #ifdef CONFIG_PM_SLEEP From patchwork Mon Mar 10 14:34:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 14010104 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25F5E22D4E3; Mon, 10 Mar 2025 14:35:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741617318; cv=none; b=KhyUCcd/SsmvsRCMF05c9kLpVxYjpT9+06r9+T+k2xf7OFCW5p/sVcXCbtno2XJVpjOEuFjgVnhn8J5YFpOYs1Hef5CZ1iAZPihRXNVxY1S/kk1iqwRxoUOn1WYQ4rTx+v2qsObmTdRgXdbfUEceIQ1/HspeDHFRAjHC8sMaK3s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741617318; c=relaxed/simple; bh=iFY0Z0lqufvrCBh7TuqQgZceY43vwZRtfNHs9cRGMzs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bw3tWobYB8g8N5B7ubVnxCiug07zWLXSDECn/meA0X308oXI1NuTk79eMPOd0KpFdVqyqx9BXcV9JrJ6t89G8oa5kXQCxN7L0nbDWICByPpayKVElAQGWHg6ojz4EiG9A321GmdNVhcx4lT9L2jEg7aw56kbPXZ0uRci5FrA/UA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gccDq3OB; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gccDq3OB" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2239aa5da08so67682805ad.3; Mon, 10 Mar 2025 07:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741617316; x=1742222116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IS1K9x+4Zn/shvVhPm7Zn9q2gjfD6cEoR0irdxrqpfI=; b=gccDq3OBUXRS0ElF/xdWDeGlVqJfO/lMtVfbwMYKQK+RjAQrArDOEeei/jSIx9fKZO HkgRBMi31sWg1MKKzM49Yuej/iCxlnrA8+Zx8SM0fV/MZ9rymfHdQwDise2ZdSGV+Ocx iplFyus1XGbkoX/OKAkTGs4ZFWmq6IsyAHMuU91WXN+6w0OoLCrDRIZn9/8SARzBUkv8 tCDSlSbiAqhQCPHjW57/+kT4qpCrSB3SFF+CuJ74CBOaLgJqPfM4S1RfmiFkzqmqCRuc TUoVdTP631QRpRwaPxTrH0FEuNO2eqfRztpfWLykWZQ0dBCQkD1T5Wd6HmhQ4/gbbJRK 9/3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741617316; x=1742222116; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IS1K9x+4Zn/shvVhPm7Zn9q2gjfD6cEoR0irdxrqpfI=; b=uaPKaTnAEAd4eDtlmXMurg5d+QodYlC+Q4jCVzf1Q5la3hzQoj17n+o1CrfVNLw8cX E1BcIb06GSog7rz9f4oQEIVr0I7A2L2bCm+pLoK6Pb99JkDm0e6UdJYuUrVbuxWjYMir dy/psPtpuEYF4yCVi/FHUvkklBIL9c7yMKCp0JqluPiiJWMgX3K7CgzuM+xMzScyiywK FFp6WX/tnB08ZCh6h7sKXtUwjZBse1fef7Hwm+G4lKvWAcNZopfgAFYcJ1CGN0neTML8 oUHbxp1bn+k2sA+FcN1K0u8r00UggWeulnT60eqqXcn80rsNgeWemfXF2z15JkG0vjy5 57Mw== X-Forwarded-Encrypted: i=1; AJvYcCUd4uRJPbJlQYpFZpkQHUkm2y7gDcRe+f3uZDAQRmJClhUQGBbLEJeIF32x0fcpthCDAGht1nHJmYyh/S9I54w2UO4=@vger.kernel.org, AJvYcCUt6/EC1mc+yAk7SXFVCDccvSwSfxmYkONPPJHHxMnYFJH7wH/96K6kDsjcLG5F9WU9RZw7nBdn8Yw=@vger.kernel.org, AJvYcCViyBf+D+0AW7eWsPDko7UqQxNd2Yw9aoY98SGX2wTR5twx0PFvv78yXsiQHLigvLtsXB6XeD9CRZZIGRE=@vger.kernel.org X-Gm-Message-State: AOJu0YxhR+yj9hoCCjMmlqR2FQYgJntKiikIqG2wGugVr03ACgxlz1r6 s3lW7kSho4xRGnAinivpvitZpTHqgR6z+XZr0C1KfhIU+xMP0C+F X-Gm-Gg: ASbGncsXjlG7jD3o4N1Xs9LjnWZdBQSnFTAjeIbGX6nVKQ2UCZ+viC6kRAIQPmcT6LZ g+kJM4dK365HQosmo9vMSGnh891FtJML+i1u8SkmQmxbv/4ywr9jDDgfB0GQnvHmvv2JJbBsrHD RPlZoK5wMMC5avzDDAuse4OjCrBPK7F8Eh+E3on5StTQ53zbgj+3NN0Jux8QBnrCVZCxSiyjkcR cIX0Qaqm6kp+i3POgK0j/2YvGjh9Yo7nFE+BWXoCZA/s5zUsPW70V9+dFTanFzLj/enYNdJMUtp IdJbWRJ2MUWhrUl1KBdWyltCC1LRNteX1ASyJQBzi0y+IGkc2K7R+dwDlUvo65Hq+1DOAg== X-Google-Smtp-Source: AGHT+IFRMb8MSt+/SKP7XgvmW56LuHP+OiQQ8mAEyZvr5wqugDw0pMOjRJfiVrvAK9l7JjHXCjXQqQ== X-Received: by 2002:a05:6a00:2e17:b0:736:9f20:a175 with SMTP id d2e1a72fcca58-736aa9c1b4cmr20983288b3a.2.1741617314745; Mon, 10 Mar 2025 07:35:14 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af281096763sm7785900a12.30.2025.03.10.07.35.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 07:35:14 -0700 (PDT) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v4 2/4] drivers/thermal/exymos: Remove redundant IS_ERR() checks for clk_sec clock Date: Mon, 10 Mar 2025 20:04:43 +0530 Message-ID: <20250310143450.8276-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310143450.8276-1-linux.amoon@gmail.com> References: <20250310143450.8276-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Remove unnecessary IS_ERR() checks for the clk_sec clock, the clk_enable() and clk_disable() functions can handle NULL clock pointers, so the additional checks are redundant and have been removed to simplify the code. Signed-off-by: Anand Moon --- v4: drop IE_ERR() for clk_unprepare() as its handle in earlier code. v3: improve the commit message. --- drivers/thermal/samsung/exynos_tmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 3657920de0004..ac3b9d2c900ca 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -258,8 +258,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) mutex_lock(&data->lock); clk_enable(data->clk); - if (!IS_ERR(data->clk_sec)) - clk_enable(data->clk_sec); + clk_enable(data->clk_sec); status = readb(data->base + EXYNOS_TMU_REG_STATUS); if (!status) { @@ -269,8 +268,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) data->tmu_clear_irqs(data); } - if (!IS_ERR(data->clk_sec)) - clk_disable(data->clk_sec); + clk_disable(data->clk_sec); clk_disable(data->clk); mutex_unlock(&data->lock); From patchwork Mon Mar 10 14:34:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 14010105 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C55CA22D799; Mon, 10 Mar 2025 14:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741617322; cv=none; b=BZAXxKnwjhiSjejp2R73xHkNV3xyBXt21YX9nkDH+VIfcOJGb/zZwpzcq8x3XXrGDWBMuFk4kJnDuOHNnTVA4G7Wvvwnk84YYbuIf3izl6vyBYYs+T5uEQoXrlW+faEIoZuLcGRO+GdsAtc7xPEmwDaXvBlG9aQfcA1JFeWnIls= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741617322; c=relaxed/simple; bh=Bd0hvtpCmZJet9xwoJfrc2/uWmqC5K4WKXzpW6jKXP0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NVMxPNeZOWQ/H4rNKlLzzVOWD7iNi988LnQLitylgZ9oTBc0wKAb2WGqUx/EYF22VsVtOTkkWllK2h7kSVF6doggpaG96UvcZFB8GwQ0XImAA9K+ndpFwZA8kw2nHfmRHoYQVdtJ1Os+52RhugNAr/S7MZB9leGYBiZ5hm7MDcs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WQNkDcHQ; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WQNkDcHQ" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2ff615a114bso7539214a91.0; Mon, 10 Mar 2025 07:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741617320; x=1742222120; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+QEal24nNpFB1sUg3m6xqbmF2yfFZnIAbP+jKYgY2yI=; b=WQNkDcHQzbT8QzzFO7NXuMrNM5AWiu1L8uB3CvNvjMLKQAKqQWea3VMji44W9aai5g 9pfaMELAR56NMjNWlVTS0QdPgNR/DDsVcHWFxKAtjYL+bs9Q8022XUd3X6kjAvUxt6Qo MR1+ATZTMtV/wCnwRYf/0DR2pHd8pIj1bRzaFAbNlnZRdWs05JZEuYRo6AxaKmVHRzYl uZFHF13nM+uYNrOr3RL9Lt5Rc3tLHICHiO1Mnz+rlWvFzrB8hECd9OKhPwjwGCo8wUGo NEtE4pgEikN3TPQIWSYwgqmwEZfwHz+jF3uUvvqhqhciXf9RE9ug6Lj7Jyc3tLYBRumY 7LbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741617320; x=1742222120; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+QEal24nNpFB1sUg3m6xqbmF2yfFZnIAbP+jKYgY2yI=; b=ae4sHuFaG/MfWNS+YKrdVyGUszN3QJoNv8sLkYXAkbCWoW+IB1LJZTtDmxTGC7+BZI nHycrpHh23RtF8k5nFVOkoopxeQvlqmRusr5sncuECpFrN8/Y2kIm8pLKu1oBTW3zMgy cTz4ZFNXwCOYRAbRVpX/M/kKwHuSUn1b/AEBP/Na0PIpRD9GrWVvsvuRiPkjRTe48wWo v0Uc05le0Nwy7HtgDx7+Lg6se1DzxvCBqlpXyIz83XNyhvo71IDLAOS7a63sRa4kBLSD tbn0V/n/cD2GYZF87X034Nx/t0aYsZTksivzDJZzUJQPZe5l23xbARj6DOo8ZcbH/vhR 4S+g== X-Forwarded-Encrypted: i=1; AJvYcCUqgFeT0Is3qoazb031tX+Jf1XeS2mcccAxEB+5KCmUmfpuyLamwgsfjLiQv+wfl+MT1apgD3atxOjTFFs=@vger.kernel.org, AJvYcCXYzlv0hcU2TR/B9Q+rtA9IHUZs9QOadHQj9FtxeHSndTE+FcZgx+ZGSes7HWqWXQya01QQKp4HFRAAvMOv7sFB1v8=@vger.kernel.org, AJvYcCXmnMbzpTk3nWSh0iQDKViOjJxDWVdjw5T/JFRnLZvie9Qn/0ZkhPRAYVvnNHhT6CGuNtMEKliH9F4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7dI4jIOqI8eqQyAyGDJ/PHRpw3hRo2DHh74PginspclVhAoVi STk0+LYGsUEX1Nimg6/EzQw/nWnM03sxImdQw41CWbqwgGsBcW5h X-Gm-Gg: ASbGncubtGQY+Cyl6jeubBz9vb27cgM4KeEJyegoQNr+i6+FkY+bZA+s5YekBeeMldf PhUPhtzlAHFpLDD/LfpSrLDQvV2IS4bYhn0Bl1Mq6zMz4dkLOiGi2/8FkL1Aol02Kngq9MtRrUP 3TryoX2S1EGZoT1Nr88bkjBDF+env78uBhSk6YaV3N5pcafkpexIthHooBWbhUO1vmc98+Hi4w7 mcp3Oecmj6DZyMySO58YKsVW4FWygOxnbgYU5oy3vukrgbtieL9Cbv/k6CtXCvZC3QfhAe3ONx8 8+ErsTmlTm4ybPJLqw8JCMMoC2dQlVyWAVmkwCiERCPlfysMZaIYeLA5Pag= X-Google-Smtp-Source: AGHT+IGcgMPRI9hdBCeUstUHpb1PU/WnBc4AvJsnipWByXBWrlcqIrz/Leyj4EN8DuL9JXzghzFyRA== X-Received: by 2002:a05:6a20:cd0e:b0:1e1:a789:1b4d with SMTP id adf61e73a8af0-1f55611c851mr13246121637.15.1741617319780; Mon, 10 Mar 2025 07:35:19 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af281096763sm7785900a12.30.2025.03.10.07.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 07:35:19 -0700 (PDT) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v4 3/4] drivers/thermal/exymos: Fixed the efuse min max value for exynos5422 Date: Mon, 10 Mar 2025 20:04:44 +0530 Message-ID: <20250310143450.8276-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310143450.8276-1-linux.amoon@gmail.com> References: <20250310143450.8276-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 As per Exynos5422 user manual e-Fuse range min~max range is 16~76. if e-Fuse value is out of this range, then thermal sensor may not sense thermal data properly. Refactors the efuse value initialization logic within exynos_map_dt_data function by replacing the nested if-else statements with a switch statement. Ensures proper initialization of efuse values based on the SOC type. Signed-off-by: Anand Moon --- drivers/thermal/samsung/exynos_tmu.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index ac3b9d2c900ca..a71cde0a4b17e 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -899,12 +899,23 @@ static int exynos_map_dt_data(struct platform_device *pdev) data->gain = 8; data->reference_voltage = 16; data->efuse_value = 55; - if (data->soc != SOC_ARCH_EXYNOS5420 && - data->soc != SOC_ARCH_EXYNOS5420_TRIMINFO) + data->max_efuse_value = 100; + switch (data->soc) { + case SOC_ARCH_EXYNOS3250: + case SOC_ARCH_EXYNOS4412: + case SOC_ARCH_EXYNOS5250: + case SOC_ARCH_EXYNOS5260: data->min_efuse_value = 40; - else + break; + case SOC_ARCH_EXYNOS5420: + case SOC_ARCH_EXYNOS5420_TRIMINFO: + data->min_efuse_value = 16; + data->max_efuse_value = 76; + break; + default: data->min_efuse_value = 0; - data->max_efuse_value = 100; + break; + } break; case SOC_ARCH_EXYNOS5433: data->tmu_set_low_temp = exynos5433_tmu_set_low_temp; From patchwork Mon Mar 10 14:34:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 14010106 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB90D22D799; Mon, 10 Mar 2025 14:35:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741617327; cv=none; b=sQXwFQ6l1+k1K1Pw802cWuW7HGQg8R3YE4g6EEGZbvEZid0zlfhExgKMNi2iEELChdnOPNusOlJonOiggty5Z2M9nznypb0zJrinB5G/KW4HO/5RYGkuQJEmmeOI5qxg8/v/MtpuUxGmwbZ9fv/FtwOZ0qJZzYErkhxwgPwlLNw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741617327; c=relaxed/simple; bh=Rgk1KHQBs1SxsiATAGYhTal7QoOm4Z7AqmiLmcjUZ00=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QlTQJkjE5ipP+VsZ9zXQUvauoF5ahbWw8HMCzOSgqsQXcfyHkqZRajurrDOIqbMftA6C+koshQexGhU99+L9iQ+0tUKW3Y9WZVH6X2lr64QCYg+D78C9WoYGgcSE/kfFO/2Vda3zGWrlQRBgaaWP6TQ04NaD1IqgJL3BXEnfPdk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IzSkuC0R; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IzSkuC0R" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-22337bc9ac3so81816175ad.1; Mon, 10 Mar 2025 07:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741617325; x=1742222125; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZPurFq/fNhKB6tsK5KqiD0Uogf6Ze1eS/AV3KtY1Z/8=; b=IzSkuC0Rx4VKC8WqeBZ7gKoRP+giHexitGt9iRW2B2tZ0AKBG/eDd12lBTkFVNjXfU dIVnUHBJuLr0mw1U1WWqO3LWPkFI5fjyIrHG61CfwNCzgLYFwiFV/p2YRa4wNIRZ6WYY A5qbmzb+3elABYEw46xOROZ+5lkQG9XI9vjW5wChG76GukJao24VCnRuCQhJqMCi8lDV 2aeO7KVS84OAXh63J36UuEwxMt+Bn+nMWr0ZxV6OGdgsDFY/CxAN+eehrMl9ctS/fNd9 LQZgByKAeP3qOmXoR/LoEyyHupWCZ4GhH4JnF61YSqtNQ8cS+ghTJZGcdVSsGKUJog9n wu7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741617325; x=1742222125; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZPurFq/fNhKB6tsK5KqiD0Uogf6Ze1eS/AV3KtY1Z/8=; b=P7fWmoqAkQrq2tXtrfXSiaqIEcOiGn9HEAKtNBKGzuMnQwg4KhHbRGsohX1yT6Fka6 FZ7kqiY2tkFJTg4vFP2jLaZxesggUIscFtbw4ZzS9bfhK6WPUmKpVERstANBG1Xh+x4R gCLoLLTTDoG7jHQqlKkzvgRoG5wVNrTc8MgL+AnGIIwoQTasN4hI5b67mwLqy7HZ0jzN rNwNv3FPO8296Hk6kxNXpZVl6wBFoYnZUkUirRUfE+Z+AW+SIlBnh22/SFhnApmBtrUC h2ViUNuk2a8ooT+e3TLcmVytJmSn9D8d20Orhu/rbFout1DWEhTBLOLzgn3AMeeiKvmu tAcQ== X-Forwarded-Encrypted: i=1; AJvYcCU9HmdS6bGzXnCQR6nq09SuBx3AlaindFFUfFVXLpZkYQy0OIBbd/tNgWcZPCL7nnzFeZ6h8DVHVzBnGpI=@vger.kernel.org, AJvYcCV/zz58CJCAe11eeTwYUsy0y50bBy/BhBqioCw3togSEn6uZDcRMJUSDa/bM4pk3Rc9dWUC7SWYoESBw9Yr6FWwo+M=@vger.kernel.org, AJvYcCWhZEC7kOAXX54pE94sLuqfRPX4W7PihLhI0L2bsgw3veR3Q/wEfTLTUO6eiJ7cqM5JUe9nAVJ0zmg=@vger.kernel.org X-Gm-Message-State: AOJu0YwtCr6QiLBWCc1RxF7c2wrKDe7NXepiqvS7BUPra6YDaPskiSSO SgVDydUoR4OAODjL+OjpKHf9B6GYo6bPoKn7tM9nmdZ9zpNcdG2t X-Gm-Gg: ASbGnctVALVBe66l6ajkC9ypqLtvJRsJ+kPnoFD56opYYi/kxaXhRldT9y8FTEhUblg 10qaFNVPdus5nYFrTce5em2ODrPxE2DhdK2pyWrQvtnEKcz/3Nu83fKNflcBidAQtaeyhJs71lk ZOnMX4gOitHtmFU/cAr92VETWeOmoogZgZisyYzWywZDCjNLyNfIEIBGgXmDGVMG9G1Pb69x2cd HVyVaukXFdVobsco1KUZPWueyo8VB2S6HhaMX7sI/BDlrcH48dLYpRaKipc+J/gFnGgEBvn62hE 2zbF1i4DcMhNRgXi5GHmXtNkUVWtTEcaM8Hgjt31++uBPbnXu0DZMYqIxjky4If1aslHAg== X-Google-Smtp-Source: AGHT+IFlxn30vbYNMpCGqOkZQC/33f6L8EuwlU4MuG+cJmyHdrmp3tS4C+2fi8L46Nfo+WlDit4hVA== X-Received: by 2002:a05:6a21:618f:b0:1f5:6b36:f574 with SMTP id adf61e73a8af0-1f58cbdd3e9mr5565637.38.1741617324889; Mon, 10 Mar 2025 07:35:24 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af281096763sm7785900a12.30.2025.03.10.07.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 07:35:24 -0700 (PDT) From: Anand Moon To: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER), linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v4 4/4] drivers/thermal/exymos: Use guard notation when acquiring mutex Date: Mon, 10 Mar 2025 20:04:45 +0530 Message-ID: <20250310143450.8276-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310143450.8276-1-linux.amoon@gmail.com> References: <20250310143450.8276-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Using guard notation makes the code more compact and error handling more robust by ensuring that mutexes are released in all code paths when control leaves critical section. Signed-off-by: Anand Moon --- v4: used DEFINE_GUARD macro to guard exynos_tmu_data structure. However, incorporating guard(exynos_tmu_data)(data); results in a recursive deadlock with the mutex during initialization, as this data structure is common to all the code configurations of Exynos TMU v3: New patch --- drivers/thermal/samsung/exynos_tmu.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index a71cde0a4b17e..85f88c5e0f11c 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -12,6 +12,7 @@ */ #include +#include #include #include #include @@ -199,6 +200,9 @@ struct exynos_tmu_data { void (*tmu_clear_irqs)(struct exynos_tmu_data *data); }; +DEFINE_GUARD(exynos_tmu_data, struct exynos_tmu_data *, + mutex_lock(&_T->lock), mutex_unlock(&_T->lock)) + /* * TMU treats temperature as a mapped temperature code. * The temperature is converted differently depending on the calibration type. @@ -256,7 +260,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) unsigned int status; int ret = 0; - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); clk_enable(data->clk_sec); @@ -270,7 +274,6 @@ static int exynos_tmu_initialize(struct platform_device *pdev) clk_disable(data->clk_sec); clk_disable(data->clk); - mutex_unlock(&data->lock); return ret; } @@ -292,13 +295,12 @@ static int exynos_thermal_zone_configure(struct platform_device *pdev) return ret; } - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); data->tmu_set_crit_temp(data, temp / MCELSIUS); clk_disable(data->clk); - mutex_unlock(&data->lock); return 0; } @@ -325,12 +327,11 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on) { struct exynos_tmu_data *data = platform_get_drvdata(pdev); - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); data->tmu_control(pdev, on); data->enabled = on; clk_disable(data->clk); - mutex_unlock(&data->lock); } static void exynos_tmu_update_bit(struct exynos_tmu_data *data, int reg_off, @@ -645,7 +646,7 @@ static int exynos_get_temp(struct thermal_zone_device *tz, int *temp) */ return -EAGAIN; - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); value = data->tmu_read(data); @@ -655,7 +656,6 @@ static int exynos_get_temp(struct thermal_zone_device *tz, int *temp) *temp = code_to_temp(data, value) * MCELSIUS; clk_disable(data->clk); - mutex_unlock(&data->lock); return ret; } @@ -720,11 +720,10 @@ static int exynos_tmu_set_emulation(struct thermal_zone_device *tz, int temp) if (temp && temp < MCELSIUS) goto out; - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); data->tmu_set_emulation(data, temp); clk_disable(data->clk); - mutex_unlock(&data->lock); return 0; out: return ret; @@ -760,14 +759,13 @@ static irqreturn_t exynos_tmu_threaded_irq(int irq, void *id) thermal_zone_device_update(data->tzd, THERMAL_EVENT_UNSPECIFIED); - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); /* TODO: take action based on particular interrupt */ data->tmu_clear_irqs(data); clk_disable(data->clk); - mutex_unlock(&data->lock); return IRQ_HANDLED; } @@ -987,7 +985,7 @@ static int exynos_set_trips(struct thermal_zone_device *tz, int low, int high) { struct exynos_tmu_data *data = thermal_zone_device_priv(tz); - mutex_lock(&data->lock); + guard(mutex)(&data->lock); clk_enable(data->clk); if (low > INT_MIN) @@ -1000,7 +998,6 @@ static int exynos_set_trips(struct thermal_zone_device *tz, int low, int high) data->tmu_disable_high(data); clk_disable(data->clk); - mutex_unlock(&data->lock); return 0; }