From patchwork Tue Mar 11 13:18:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011863 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B17FAC28B30 for ; Tue, 11 Mar 2025 13:18:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B45A5280003; Tue, 11 Mar 2025 09:18:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA675280001; Tue, 11 Mar 2025 09:18:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9016F280003; Tue, 11 Mar 2025 09:18:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 67F9C280001 for ; Tue, 11 Mar 2025 09:18:21 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 97615C1EE0 for ; Tue, 11 Mar 2025 13:18:23 +0000 (UTC) X-FDA: 83209324086.13.08C83E7 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf29.hostedemail.com (Postfix) with ESMTP id BF31C12000C for ; Tue, 11 Mar 2025 13:18:21 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zZk7fgco; spf=pass (imf29.hostedemail.com: domain of 3HDjQZwgKCBM2tv35t6uz77z4x.v75416DG-553Etv3.7Az@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3HDjQZwgKCBM2tv35t6uz77z4x.v75416DG-553Etv3.7Az@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q3kjR3e+tUhw3L1FQAPtkpKMwUmzOI7e4dVWjhqVqwM=; b=S3MIVsHwHRaLjldftG08XY3cV2lypk+L8/L50pNFt+tSTdjF8Bh+NPPoAF/X9PyZEoH2lA mg9BVkxJrimvMQKoMyxt1SNJzKccOnKZrzdqZLVRMHJw8+37112/EBqkSHLXrlSRTxRgiZ 5f/10efotc4goAX6XVLUpzLy3brnpeo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zZk7fgco; spf=pass (imf29.hostedemail.com: domain of 3HDjQZwgKCBM2tv35t6uz77z4x.v75416DG-553Etv3.7Az@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3HDjQZwgKCBM2tv35t6uz77z4x.v75416DG-553Etv3.7Az@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699101; a=rsa-sha256; cv=none; b=Md/UElxaOmlAzqrGPgewdqO29gL15CV00cEoppO2F00MEr1hO9ojBNs8C6LZ5wBujQ5cP7 fqKWhTcDldOeZuft4B54goawTvgF+dQYpcyK3O1xOzCqLvreeEhzeaVb4fEbrhuTVqIjYL pF1w4esgNiKOjjOTXnHRBcISmtt3vO4= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43d01024089so11528785e9.1 for ; Tue, 11 Mar 2025 06:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699100; x=1742303900; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=q3kjR3e+tUhw3L1FQAPtkpKMwUmzOI7e4dVWjhqVqwM=; b=zZk7fgco9ONPqotAAyV4wQ7o0vxMKr47PTtEALKbZD0enjKrFG3cSk7c0UwVD5mPhh Jyjwy6AL/VcVy6reTnBCL6x1fmqMjZFoqKxSIpP1A9KIoWQ/jOAmY9e3DR7nwdiaOJS4 vEcZBGQolH4BhMWlpSIR1m+HP2SISeFKB+uacw1oqKzj9aAWbSeFQ+tKnwB4c8Ng3+XX isKadWXNmci60Swnl0TAGOvXCQcVoxkfKOXSKPDdGBjJasz5S+T3H5oPv0nQalvB2Vir xHq59wYtWM8UkLo+RUjHidj1o7CFbZfCsQFG+4l91dGYpzIx4poB4rxY5gW2zDSg9+gd INVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699100; x=1742303900; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q3kjR3e+tUhw3L1FQAPtkpKMwUmzOI7e4dVWjhqVqwM=; b=rYpSdHIe3zFXYz8sIZnsIQVZn58sTBdE1vu3eUao6wvDMbnk1Z0IcevCnkE1qgjfci 9PgKJqJOZESKtKlE6snomAF49vr1FayVxEqIiAFBvFjF+BO5v4kiEl+KYMpsHQxckjvo tbhk+0nyTLozrLAX0PhFKvYx15czduCCFC7QiCrNeZLYmFgh1XMCXkrYigru+MHfWGS4 r1gahuzcEBePCvHsvqELDLjK6Sa9oCGe0FJICRJAcrjqWhcYpP8ir0RIVZPx6qE5y/RS lLZvoXlvRcm5MWmXosSxVgxptGmELrGKTD8U+uNvkssZULzfYdryR9aFJEoWMR6C8ocv ellQ== X-Forwarded-Encrypted: i=1; AJvYcCWIUtA6uR7r9QZsr6uYXRJe+a4pomhAACGhkdqsujeGEeFopCVv5sbTjtFs0Lm7CZj+7dX4RpmI5A==@kvack.org X-Gm-Message-State: AOJu0Yxz2YurJL8zbFI46t1T1ahdsC9D4QXl3etNeco1yiUQ64y42Ga7 z8TU9rSJneoG0F1izI23RA64c5pJRJZozGpPndXbPE/SFX1yvtq5lCbFreZ095tNrwaIgGDnXOi MfCxvc1p9WQ== X-Google-Smtp-Source: AGHT+IFvDSGF/OHbPFKrTNFDJv2bYNbhXrjsIZlG+nsyMMEqyV04VNqP84+SWfbxxSYLZ4nKYbR3gmw1XGhYsg== X-Received: from wmpz16.prod.google.com ([2002:a05:600c:a10:b0:43c:ee49:c14d]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3ba3:b0:43c:fcbc:968c with SMTP id 5b1f17b1804b1-43cfcbc97d3mr87744455e9.7.1741699100416; Tue, 11 Mar 2025 06:18:20 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:12 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-1-dec210a658f5@google.com> Subject: [PATCH v4 01/12] selftests/mm: Report errno when things fail in gup_longterm From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Queue-Id: BF31C12000C X-Stat-Signature: 4hhuggu7as54i8343jpjqqr5p9h7zwgp X-Rspamd-Server: rspam09 X-HE-Tag: 1741699101-964563 X-HE-Meta: U2FsdGVkX19oQ5BGsKBUoov2Vfwm2PTgoe2qC+LBzKna9axwQ9KZF2lyhlOCcKV2PycHbk/P8Go1Bj6Dt+JJIA72hQ6eig4g9rfluf4SwvrWMA89jLKtlvbR9gbYCZbZEJ1rWikI1nxyJFKsWyT6h4wNZPoHgiwCurYdcw7DoLYbT59j8Tq8wbfHjvI9yG5KiLXDgafjCu+fJfbGixiMyO2SQAhl/sd0MdPg1V2muOugwHmyveFe30RyvFpfoqbFqn0kdg9tGX3aU5h3raXE6XCEiQUoUcceKwFMNJikeTR4WHBtjMnptU7vS1j9VKhhsnflQS9WfxhWpHxR4Q3T5u2CA4UhYlm+ujqTI6/VI5bIg3ALKXdornhpkVdPard3mJC205qV95zHJ0lCnlmezfAPmrITk3wTUygbClrkhiT1nYuDw5isSYUA4kUp4iDboEGE/g5kSOLBybrWuBpfFCIIhjx8sPrkSIU5ONgs1jMEh9YrZmCQ4KaQoVeCfsITXV9EygMZ20YU+X5Ikbpl19Eeaw1Kjw11b6pEgYc2JqtpXdZtXY+5sXOLdwn9t8Mlw1KJgaoWbXzJurECChI8pYUrIHcXPghKqR8oBqDelE0djqafVM+S/boatn6PCphzUw+/DCmij+jN8HBumPswG2MSBm5L3fpNcgiQaXxqN0wnnZAbjMe6m5gDDaBw6eW0wJFP111ofXlm+Ob/F/MVj535FMYPxXGVgCfzy218pkdnvX2+UPNRHedVn2elI7E7arRZVFx3JnGZStL7ieab3viQe5BzfOe4kxxtPJAfM9OJVnkGZpwYJQ0gbpojDRu/ZTA+ZSDqTpbSm+sQVminLa5gfOJ8O9lBVFjo2HZJE4pHKoRjtkafZkohq7D1KkIXz/9fQ2hfAvYijjoeLPvOm7Eb3IqPEg6lXYJxZPyvXXk2RVgVV8Ic+uS8mIdK0LBTRENKVf8sTHTuwDx/2IY LM+mElKI CU7rYrFAp532QzLfCR8u7e6Q81DEjM4Y3n+U5y4gEO/IN3TY9nO6lfrtRe11ykgbQMiDWF7jlHpkgzuigDPZvK5G9fsojc5xnwxOZnufJ2AlZhESQJhtPHN1VofD1qC7HTBwxHSYmH1BvSDI3eVi7t6O8XE3oAg9wJHe3vPNF+v3aLFMzYTOJ7Ae+2RoA48Ru92iAOqCXxRs29ic/Q9QE3RCxN533eNuAB9CFgxQ8+KlqbXoS+22XGPXLdchXDHTOHmV12rbQ7UTXiRXTxWztsYH+v+SRdYytE60la2QM2rH/ZX+xP3DTMeTi3vDEx0r8zgS1ljgbtRM9s+lMv6L4BUsxL3+9bRuafnhH+odxy8fbmsWlVgI8D49XbqiN40byNQ+Qgzs0G92PVF6MJNGEz4N1wa3hphb+799Wq5SoP0Uh7eKjwSz3rfrvWnSRzUrrURODwIvxUXZ3yzTna1Jb5F0MPYER4EDWSt2/k2dMOFssW1Bj3gHUHbN++SBSy8syKZypw+PrcxK7F/opp0IOqOeF53weWE3sjuDfKR6BuDqN1qSTDRUI+UaCnnPachAfz5LX+HW6XwWwol+sU/WzCe+tdYUdcutvYlnGEK6QzyKp44uqtBJrSvcs9xYBdxaC2utBHSpQnHUj9xB4Plw1Ru+CS/M1FvhbMQb5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000911, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Just reporting failure doesn't tell you what went wrong. This can fail in different ways so report errno to help the reader get started debugging. Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/gup_longterm.c | 37 ++++++++++++++++++------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c index 9423ad439a6140163bdef2974615bb86406a8c14..15335820656b1c143b440b8a1065a025378e22a2 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -96,13 +96,13 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) int ret; if (ftruncate(fd, size)) { - ksft_test_result_fail("ftruncate() failed\n"); + ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); return; } if (fallocate(fd, 0, 0, size)) { if (size == pagesize) - ksft_test_result_fail("fallocate() failed\n"); + ksft_test_result_fail("fallocate() failed (%s)\n", strerror(errno)); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -112,7 +112,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) shared ? MAP_SHARED : MAP_PRIVATE, fd, 0); if (mem == MAP_FAILED) { if (size == pagesize || shared) - ksft_test_result_fail("mmap() failed\n"); + ksft_test_result_fail("mmap() failed (%s)\n", strerror(errno)); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -130,7 +130,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) */ ret = mprotect(mem, size, PROT_READ); if (ret) { - ksft_test_result_fail("mprotect() failed\n"); + ksft_test_result_fail("mprotect() failed (%s)\n", strerror(errno)); goto munmap; } /* FALLTHROUGH */ @@ -165,18 +165,20 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) args.flags |= rw ? PIN_LONGTERM_TEST_FLAG_USE_WRITE : 0; ret = ioctl(gup_fd, PIN_LONGTERM_TEST_START, &args); if (ret && errno == EINVAL) { - ksft_test_result_skip("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_skip("PIN_LONGTERM_TEST_START failed (EINVAL)n"); break; } else if (ret && errno == EFAULT) { ksft_test_result(!should_work, "Should have failed\n"); break; } else if (ret) { - ksft_test_result_fail("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_fail("PIN_LONGTERM_TEST_START failed (%s)\n", + strerror(errno)); break; } if (ioctl(gup_fd, PIN_LONGTERM_TEST_STOP)) - ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed\n"); + ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed (%s)\n", + strerror(errno)); /* * TODO: if the kernel ever supports long-term R/W pinning on @@ -202,7 +204,8 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Skip on errors, as we might just lack kernel support. */ ret = io_uring_queue_init(1, &ring, 0); if (ret < 0) { - ksft_test_result_skip("io_uring_queue_init() failed\n"); + ksft_test_result_skip("io_uring_queue_init() failed (%s)\n", + strerror(-ret)); break; } /* @@ -215,13 +218,15 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Only new kernels return EFAULT. */ if (ret && (errno == ENOSPC || errno == EOPNOTSUPP || errno == EFAULT)) { - ksft_test_result(!should_work, "Should have failed\n"); + ksft_test_result(!should_work, "Should have failed (%s)\n", + strerror(errno)); } else if (ret) { /* * We might just lack support or have insufficient * MEMLOCK limits. */ - ksft_test_result_skip("io_uring_register_buffers() failed\n"); + ksft_test_result_skip("io_uring_register_buffers() failed (%s)\n", + strerror(-ret)); } else { ksft_test_result(should_work, "Should have worked\n"); io_uring_unregister_buffers(&ring); @@ -249,7 +254,7 @@ static void run_with_memfd(test_fn fn, const char *desc) fd = memfd_create("test", 0); if (fd < 0) { - ksft_test_result_fail("memfd_create() failed\n"); + ksft_test_result_fail("memfd_create() failed (%s)\n", strerror(errno)); return; } @@ -266,13 +271,13 @@ static void run_with_tmpfile(test_fn fn, const char *desc) file = tmpfile(); if (!file) { - ksft_test_result_fail("tmpfile() failed\n"); + ksft_test_result_fail("tmpfile() failed (%s)\n", strerror(errno)); return; } fd = fileno(file); if (fd < 0) { - ksft_test_result_fail("fileno() failed\n"); + ksft_test_result_fail("fileno() failed (%s)\n", strerror(errno)); goto close; } @@ -290,12 +295,12 @@ static void run_with_local_tmpfile(test_fn fn, const char *desc) fd = mkstemp(filename); if (fd < 0) { - ksft_test_result_fail("mkstemp() failed\n"); + ksft_test_result_fail("mkstemp() failed (%s)\n", strerror(errno)); return; } if (unlink(filename)) { - ksft_test_result_fail("unlink() failed\n"); + ksft_test_result_fail("unlink() failed (%s)\n", strerror(errno)); goto close; } @@ -317,7 +322,7 @@ static void run_with_memfd_hugetlb(test_fn fn, const char *desc, fd = memfd_create("test", flags); if (fd < 0) { - ksft_test_result_skip("memfd_create() failed\n"); + ksft_test_result_skip("memfd_create() failed (%s)\n", strerror(errno)); return; } From patchwork Tue Mar 11 13:18:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011864 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF1AC28B2E for ; Tue, 11 Mar 2025 13:18:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1727F280005; Tue, 11 Mar 2025 09:18:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D1DE280001; Tue, 11 Mar 2025 09:18:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E41BB280005; Tue, 11 Mar 2025 09:18:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B51FD280001 for ; Tue, 11 Mar 2025 09:18:23 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CC4B781F44 for ; Tue, 11 Mar 2025 13:18:25 +0000 (UTC) X-FDA: 83209324170.18.2B298DB Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf09.hostedemail.com (Postfix) with ESMTP id A579314001A for ; Tue, 11 Mar 2025 13:18:23 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=16+sEb6f; spf=pass (imf09.hostedemail.com: domain of 3HjjQZwgKCBU4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3HjjQZwgKCBU4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eNnWwlE7ZfA4njYaSa6+RHThvRYMfszFV0jljda2YI4=; b=qO60iN/t3idz4aNqgayIAuFMd2aQbblaTn3ESvpeC0vmc492yV5zSiZ61aQX+Gbi8r4r6b veFCOa3BcTNgw1peMKTZdC8FyaRZmJ4DoA7cjobSxMPrXQ8Hf770Yd4QFDvl2b9HlhtOd3 CHV4YX8Ntx1b6M/zYK4K/l/1JLJiIl0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=16+sEb6f; spf=pass (imf09.hostedemail.com: domain of 3HjjQZwgKCBU4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3HjjQZwgKCBU4vx57v8w19916z.x97638FI-775Gvx5.9C1@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699103; a=rsa-sha256; cv=none; b=LuvVG/06Y7EzK8RR6rU+XbwS36iBeRc+hY2vlDo9fGtn1RYKCH0FDLxfoab0fIr4+TwnjR 3tOJYUNb31nB2aAs2JQXJ1yk6puEhpubOKpjGCRawLFNTsEFXhcqQeZCCXRmz3JWBcmR2x 18XxYqqWr/nQsitOWB7ocZoaYYF5SSo= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43cf64f1dc5so12734045e9.2 for ; Tue, 11 Mar 2025 06:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699102; x=1742303902; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=eNnWwlE7ZfA4njYaSa6+RHThvRYMfszFV0jljda2YI4=; b=16+sEb6ftctgVSweswrnAdSQvDi6rrVf/+y5KL16B86fc1t6m1T3EcTvVeUqXrp0Au uMv8qH1kXRl3XfVeoJOKFPtmNacue+nG4jdNAXp9D8RCIQ0z9bJDooiCqtlxqFNQhEFn 1obFtl3sW87BO12GDGqGgfTlmzu/XbtwUNfaboTxNqP140+HUYeFUUrzX/U36+qcB1Pc +5PQy3xR0Td2AZVKBVlAeTYUNgy/hwrPSuD8NDpBUjv88v70zy9NSGF5ppTYdUiw29so +kaEQs44+r2zjB6PVHICDEr0H+34AECiLO8RLisK3EPC69MCl5wsBXXN6J0aGWQrrgIi fqGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699102; x=1742303902; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eNnWwlE7ZfA4njYaSa6+RHThvRYMfszFV0jljda2YI4=; b=AFTbTsd3hOPhfbwm/9icXtgS32maLi1vl+5x72JtsZmnn9WRQeWWL1oS2s2QwLrMHo qhzV8/ZWiannS8ZW2rVrgaQ0h/Gt7G8EolOPCWRe58sB9UnbubjkkzpIVXNpJmDfFbbt Qu5TRKI6cO6V4Na9nMsTJ9KneYGz0+o6orEoIM0CRdpd9NDCz8sD+WzfGzw2x2DgCTPk krfjfktspOXRPC7+zGtSbVNQrRlkh/Ns0xlJ+PrrKnUK2sqhRA8PYd39/UjQ55ks807K B7L13i3dm2VkpDfFDCG+2Vo/Fs0/1rDa1J7P+/W6Y2Z1HQFlI6fRyqQMi9yLJ+B89+4x JIsw== X-Forwarded-Encrypted: i=1; AJvYcCUEyvgFk+2W4jFeHZCztburF91Ll5F2OMIIPfLH3PV5OHLbo4biPJ3cHACLCeWuGnYZmp8QPVdxRw==@kvack.org X-Gm-Message-State: AOJu0YzHVJM5jvNRWxAuSv4WYunT4PF2DvQ+T35PSBe58t7o9VWK7uB/ HqhJk3Lr2YwOUY02SfOPYPSZ/N2RMva1Srmyiplky/WHtEfHRLa7YFbkoyaprJvmBCz8PRzXJ/a a+9Fd0j353A== X-Google-Smtp-Source: AGHT+IF00DB9vxEjSFZYMwiT0cUkAqXFwWmkRj0Y1btbCtCISAk52bWxBSSNcRq9+pCP65pccsXXfMuEUhHyLQ== X-Received: from wmbfk3.prod.google.com ([2002:a05:600c:cc3:b0:43b:c336:7b29]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3512:b0:43c:fded:9654 with SMTP id 5b1f17b1804b1-43cfded98b3mr57431755e9.19.1741699102457; Tue, 11 Mar 2025 06:18:22 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:13 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-2-dec210a658f5@google.com> Subject: [PATCH v4 02/12] selftests/mm: Skip uffd-stress if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Stat-Signature: y56fs56fmhazxxx7dbabn1pocmezah9d X-Rspam-User: X-Rspamd-Queue-Id: A579314001A X-Rspamd-Server: rspam01 X-HE-Tag: 1741699103-921536 X-HE-Meta: U2FsdGVkX1+t6nfN9ZoXDT3FaEUEKWO6y3tGi4B2MBOZ0ktAqJKrEfgDftZi0BYDT5NFlGcGhqKH8VuDx8lj/BeYfXkfWAbx3NMNk2WoHiMnXYdb1/Wj4cVtEtOyM88AsxpH+PcWM0iDFP/iovIYloE2cv9Y0PmOKeEn0AMdd6T2WK/FBuINDN/a9ygblNa/LyuoTkl6VArplKTXDYXkJMuwM8wTDvL9cCtSkmtQDwrecN4z7YTon1DeL8pFN6yeHTf0pzPTEyFcU57s5vJbsonKf8mG9fS5RkSvIVidZvD8GiyqEvg3qaqjJlt8QXCJmJhvwy3nBj7TW2itk2DDtLxz6skTlhw/ahCeBEekvyizQOhXDlmxOqhBkjXQuklY4+3SGAtQnhjeVWGLJ4CKx0N0DnV1qMTtnXV65HnDDrnNy+hzWy0Y48yfzGMsCOK8qGOCEjrddfCedZeeNryuitDy9misRi6Ki1/ewuPwKiivEEVVn96a8SfusiYpxzlDp8HpGMHw+pGuj9fAWilVDaPB3g5cP7V5Lnp8xmEuytH187hODVSHWto3VvpXWpbKVrjW6N4iNP1MXWM9n4Jey1Q6VAqF6uoCg4T8ISX0vbEeR6fjszi2WWphFjMJyLNGCQws+hlBeBdOMD3E6zvr1d76EQnHq+ACXONvDI4W2SmWxjK+kGfJLVsPnqpz+ZKzvIJtSTeoHbEeuI57GBWdswKah+SXc70eWBwZ0z3mVzRbHLbPCrLm4P4kO+glfGWpduA21kV4G0Ygtgn1WFQxo4JzRhknEDQKQqChefgj//d8skz8oHOta9XtrFQRbKVPwgmBXu0psVuDPU47Tgt/nsX/mL5wsVKUyZUU8uwAgWehczgUbN2nT901yQqFQpIMu46ZR4jefm0QYicJL3TEcpYCYbb11F3IsOMj57OBh3Vff2KSTJpsZOxRDW7u1CPBwBjFrTQSUe4W8QXgspp lTrFiIjd +5YHekKsy4jNqQ2e0resjhWM3KQ1TXIrfQqOocSyBP5TFh/Ntp4gwxK07D2qBA1BxknTNRHBNnTqfm1wgxxvEpaTa+Z1a1WF7JwJH47MBeKK7FpoxAVrLH1dqXaPEsnI6I4Df70Cj32ba9ck1KbIt8fCz21vpuSgUimIgTBWwam6disE8Jce0pQDfoDOhY100kubpLpCyu3UVuZdsTpjCCYLEK77+2moOBC+PoRqLe2NDXZAlSbTlPefS+zeD/grnuDMwB5pdrGmljeol118nLP6i9+4nxbnOiBgHLO5SqGufUcatKFYIiYNn4iwyNDNrwOoBuxrK0Pnqxat9ve5hnod0jMniAT+DxDvZCuROpzqBW79sJpU+8rbqvy9JD7wzsGHjENsxorAaeQS6NhQRBboxTUKcLKge1VngA2P0f6iGmsdz1+6K7kpr/t+eDGkCOWtPeJStJUlxkHRZM/RYIZVOJUUtzi1ApWN20rIKnQd+jgrqJXtn/srY2hnHZ+KrLNgcsvNSoP8BeOgvgaPWUBPgHpHKks7Iyrkn4U261HBwfnyg8XMCrAYiX5ARBEBJuVsevKiUhK1s2LVxaBPiFXA8pE6LXH80M9HIQ6MNW5w8nOo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.067406, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's pretty obvious that the test wouldn't work if you don't have the feature enabled. But, it's still useful to SKIP instead of failing so the reader can immediately tell that this is the reason why. Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index 944d559ade21f255404eb38557660e54e81d46b8..91174e9425cde2500b459db78cb27adda6647b55 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -412,8 +412,8 @@ static void parse_test_type_arg(const char *raw_type) * feature. */ - if (uffd_get_features(&features)) - err("failed to get available features"); + if (uffd_get_features(&features) && errno == ENOENT) + ksft_exit_skip("failed to get available features (%d)\n", errno); test_uffdio_wp = test_uffdio_wp && (features & UFFD_FEATURE_PAGEFAULT_FLAG_WP); From patchwork Tue Mar 11 13:18:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011865 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F214DC28B30 for ; Tue, 11 Mar 2025 13:18:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7C78280006; Tue, 11 Mar 2025 09:18:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B31B280001; Tue, 11 Mar 2025 09:18:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 721DF280006; Tue, 11 Mar 2025 09:18:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 466DB280001 for ; Tue, 11 Mar 2025 09:18:27 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 639A81A1F20 for ; Tue, 11 Mar 2025 13:18:27 +0000 (UTC) X-FDA: 83209324254.12.7D4E79D Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf25.hostedemail.com (Postfix) with ESMTP id 8C734A0022 for ; Tue, 11 Mar 2025 13:18:25 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kYiBvXmB; spf=pass (imf25.hostedemail.com: domain of 3IDjQZwgKCBc6xz79xAy3BB381.zB985AHK-997Ixz7.BE3@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3IDjQZwgKCBc6xz79xAy3BB381.zB985AHK-997Ixz7.BE3@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mU0cRsNzbsuSP1E5sjoXt0xKYtlq+gxz63wOE52l3IA=; b=rqztTN7bA7JQYN90G7GCLcEDDEgmgO+eC6A0BrQmwO2rQLRivsFaQoTwlnRsIthC4yhuGm VG9Z2wDhQW4/zxLef6jbx8PJR72mvVw0xG15MeiF95pSBy/laL2CXxA9Pm2+zkivTgFRC1 3cYKvxHwgBbUfFeF6ZYmKRG+DkAz8Vw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kYiBvXmB; spf=pass (imf25.hostedemail.com: domain of 3IDjQZwgKCBc6xz79xAy3BB381.zB985AHK-997Ixz7.BE3@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3IDjQZwgKCBc6xz79xAy3BB381.zB985AHK-997Ixz7.BE3@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699105; a=rsa-sha256; cv=none; b=IOHBaui1oj9nCJug7jIA+3sAo96EeNVefVnGLtmQldBgaO0MoPKdteg2zE/un4PicBiAU3 Q1l2mNPbzSN0eglwiI1rg/XTlXHTxWeoDsIXIj6MehNvP/LfmoARAzETvh28dWVXoqqQN2 98nrt/Zyn3Mpr7vT+iUzodZAFlmkSqM= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43ab5baf62cso38001705e9.0 for ; Tue, 11 Mar 2025 06:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699104; x=1742303904; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mU0cRsNzbsuSP1E5sjoXt0xKYtlq+gxz63wOE52l3IA=; b=kYiBvXmBPEqME/ye3zIpzvM/IqFHWVmVhQoQr1ynunICpIFyRnZO48nEB4zSGzxdoR GBfva7nOZ+ri5NVhyfQ6Ii7cxzlYQd8jdZsMxXlAFsdbARdn+ij6DXZrQuKHNz1SatcU cHXWA+BFzNioyUEzQBx1ReoKbto4i9uW+8hXSdojSGmrMwFab/FSvYgrHpPi5RVCIgdg I4LO6fWYz17RAfETgjtqGEIxoiqMS8OoPXbpRPCRrrgHjr5nv/Ijq7X/X0L3sif8x/t1 tiw98RMCdvr7wybtzQLe91AI5Xw7C+YlvDUCOtB4j8flCQEcIDuAnuGTWC69S5d6Xrq2 OqfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699104; x=1742303904; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mU0cRsNzbsuSP1E5sjoXt0xKYtlq+gxz63wOE52l3IA=; b=ePKgzmFkNN700vYoxwU96XCFfrAHLkQH3bSlULUdXqH3c0Q3sTRddAXg55HsK9rp2Q uMrUtsFwk4AijjL7NjiH1Aq7P9oMSdp5D1c1sbXGXAl7BTDOwUgfAQkQQIY+cQb1XPM9 4tTGk1vsgf27zuaJ6Oe7QwQ5zUFmWz9OCWu3foCwdO97/1eHCW4c/g9DxqcIh/083B8T vq5dfWsiMhTdlOOq9DvoivCof3l7V544ykMBDlc3EMecRzN2h23LEl3rJWgrAReW2vRF 2ft/8tWQF0SiSA1zh5nVjNA3BNa9020J0ZanzHFtrHa9dxNOHDtHxwmoeUuqrdneSu// U/Og== X-Forwarded-Encrypted: i=1; AJvYcCWfSLTy/koZQ4zstfH9Xd60pRpcS8qrjg42ih8N+yyRyQjqescesBbooLbuGEsooWoYF9CiBkc6pA==@kvack.org X-Gm-Message-State: AOJu0YwgMhzFVFegjwZRpICZU48aOGPv0yj3Y4iNqBQrSxnX3ojkTT17 HHXxXDhD9LkHqKNO9XnT/vI+zJ7wF+Z5TRl+qpxv6ByB12djNFSi1VLP+E5zf3UQICwJDolJVZn dLsY+STODcA== X-Google-Smtp-Source: AGHT+IGSV21QBYLlvs34tFS6Vj4C4TFSxgnu4bOOKFjZdG2VcNI1hO3z4RNOQPjlkVLg4FfQFOtvmKJGtJlrQA== X-Received: from wmpz16.prod.google.com ([2002:a05:600c:a10:b0:43c:ee49:c14d]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:46cd:b0:43c:ee3f:2c3 with SMTP id 5b1f17b1804b1-43cee3f0578mr100814485e9.7.1741699104325; Tue, 11 Mar 2025 06:18:24 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:14 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-3-dec210a658f5@google.com> Subject: [PATCH v4 03/12] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Queue-Id: 8C734A0022 X-Stat-Signature: ufprtxf6y8twh9dczjcc3857p8qjgrcu X-Rspamd-Server: rspam09 X-HE-Tag: 1741699105-418135 X-HE-Meta: U2FsdGVkX19Xf3zLnHTO3XyJZAnH8w24nEYAASwEh/nL2nTvqb9toGSauNq4/A5ayg/KcrQuA0m9qeSrE+oaqTw0PgsGBoC3lA8oIL3gQUgqqZCB6ozPGZMFP2ww4u0aFufMfnfXApSn3kxEmwxtF0ci/PHbtKh9V7+Y/ehZjodAJzm+qMqG4o8FiNQB6OJItjcNUgRi3NCsQW+a73sWr+ANNCdPi8NbkTiItbU0YTxG+JYLuE9/an2nDMYjgmKTCbESkLgQGC0gkwUEbTDNn/pv3+2Cqv8zraQKIKodD5HZ94SZOcjQZ6CU5maotEBwhuVzDx5IaOIxaVvRxJqvUuLxvKYo9XI1gzUQsZ6wTMiO82Ycv83UXSr561PzVf+khepAw61F4Op/qk91v/qz1/R+9HannbBGQ8Rc/Fp657yokgBcKYRvd6xdORSA9uw0l97sOSmHCzy5XOZLZ8YVEkY+l26kYIQRhwcVnX0SEHaSKyyVTtRvc55S/zWcq/uEdpRVXzlfRsrfhjYA91zfyV5wRSOJy8tnTHl5ZLnftlJLFh91qJkmU9D0XOEno5yfrshPfJN5QnM/MWaWPMMm0PXP0/D//avVOPAtNHrdVzfG+OzdJgdejTfz35DtHngNcRNPVDikpQK2gesgn4OcmX25UaBHp/Pw/390wg2TLC32pwt75+sGPkXb/1Ns5N60HyjvoT0ArQp8jkXOAHwZTOcT8CSZ2HakNHozwH7INqAhYFqlsjLcw02hwOTs5UUNitrCKjQj+Ccr2IY/8vuMj7FLjO8EW6/syOi7vtpmVOmmZG8qY/zFEqShTti8WkCNjryS8n0cMbFoANxQ1doOq1oPpgPLcq0RJJuscZDsZxrAKRQCSmshiDXIRiqfwgpBUUtIwVcOYfxUT7gws4z0YtF3pjcC39HZDmZg87EySu1VIvsykLNbfG3F6Q6mKh9JbLHlHLE/VPV91kIUDjk 6niYmC6L USFxGQ2u95NburoByobfTzA647VRoSM9R2bP6bjA1x/LJ2ZAWsMNvnnfrQrUdD9Bc+tXVN9f1xYgElByTiPSIlSqzIv3mOKs2DYkKkMl2fMlXUdGueCe9XqbTgClwTCoPd6sTBoEIBujveSpY6MdNLwyenL3zFD20qIxgoOfmnrKaKo9v8MC7Ru1fCUDACtjYPp0lDqhP6maiHXNRPtfLFvc+W7dZNUp4DBJHFru29H9VptgzLSEWdOC3rRI0pdXriZJtwY4ZAiZLeXqTWrcHj8k+4PeVD3pElZ3Siih2zyPZZomfG8pFwZ9krY//XpS1mef43Hx3f7FYKDf3VzJqimGpl7pgOY75JYbwbSO/4mkw+lU7HiO9AYpzcPMbytYw/bNdrQmdS5vDPllbZRCjUWVBibhPZ/wJFiV6icscCON5sBIWMiequKYPLYacJPW2T7nFyVU2PYMm+EnW/08cr5lf17GrqhROY1G2JaU9J++q7Tmv5VZpkJKuxJdB5RaB5PYqYdUwqRKY+gsVkLchRjpeLt+ZV7wQH+DcIX7ebY9Tize+O7PsUl5ABkV4MMOTXeWHcdASYtUMSpHsNNHmsejmSI8WfrBg8pGLs+8sFlMnCXQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.208842, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's obvious that this should fail in that case, but still, save the reader the effort of figuring out that they've run into this by just SKIPping Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-wp-mremap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-wp-mremap.c b/tools/testing/selftests/mm/uffd-wp-mremap.c index 2c4f984bd73caa17e12b9f4a5bb71e7fdf5d8554..c2ba7d46c7b4581a3c32a6b6acd148e3e89c2172 100644 --- a/tools/testing/selftests/mm/uffd-wp-mremap.c +++ b/tools/testing/selftests/mm/uffd-wp-mremap.c @@ -182,7 +182,10 @@ static void test_one_folio(size_t size, bool private, bool swapout, bool hugetlb /* Register range for uffd-wp. */ if (userfaultfd_open(&features)) { - ksft_test_result_fail("userfaultfd_open() failed\n"); + if (errno == ENOENT) + ksft_test_result_skip("userfaultfd not available\n"); + else + ksft_test_result_fail("userfaultfd_open() failed\n"); goto out; } if (uffd_register(uffd, mem, size, false, true, false)) { From patchwork Tue Mar 11 13:18:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011866 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48444C28B2E for ; Tue, 11 Mar 2025 13:18:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 871BC280007; Tue, 11 Mar 2025 09:18:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D15D280001; Tue, 11 Mar 2025 09:18:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FED7280007; Tue, 11 Mar 2025 09:18:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 27620280001 for ; Tue, 11 Mar 2025 09:18:29 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5116DBA8CE for ; Tue, 11 Mar 2025 13:18:29 +0000 (UTC) X-FDA: 83209324338.12.B3D2695 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf06.hostedemail.com (Postfix) with ESMTP id 72365180003 for ; Tue, 11 Mar 2025 13:18:27 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="RknN/V8C"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3IjjQZwgKCBk8z19BzC05DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3IjjQZwgKCBk8z19BzC05DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699107; a=rsa-sha256; cv=none; b=Zbwxf7WpFg3iRb5gkmBMyCNzanJuHcizkMkHbd96IPcywwjQ4QqR2q/5LSeCF7lAtgfuXo PDcpc0e5Sopy7wV/epb+0GxKIxcZy118wO2Vf8IOH1gRZy04su3CILZkkzlvsrgeFPsLsC 9rjeYPdpjmewKFOMFNHace42OZXT+B0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="RknN/V8C"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3IjjQZwgKCBk8z19BzC05DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3IjjQZwgKCBk8z19BzC05DD5A3.1DBA7CJM-BB9Kz19.DG5@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5QUtJ68S5WVMBdPVxDoGekz8XvAVXh0h8UUq5TqoFAw=; b=vnXj5HIGNLtilj3Uxcu1pER5i8Zt8ogMQTqquoudRXLQ4gNwGHswTxslYBpqsZmjzSUH2e p4MjRGW360+RVxXBqKTf+0WGwnTleG6oKQ6tdrDB6XLLRbR3ogq7Hlcwo2ts4rWf+q8/HE PrPCVL+KCvm6xMcvWERqIpWdMDqlr7o= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43cf172ffe1so21726935e9.3 for ; Tue, 11 Mar 2025 06:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699106; x=1742303906; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5QUtJ68S5WVMBdPVxDoGekz8XvAVXh0h8UUq5TqoFAw=; b=RknN/V8Cydw80C8a62jtBl1nYU9G257qp3ORe91LnoB49usGSCvizLiJHXV5hR72I6 cviAYYCLgbOzDehu9cPEM/cFByk0IPf80eC2Xtw0qF+xC8kaRXMWHU7fGoIJFZrV3MFX s/MUUG3C4qN6kApD5E+q7qUnIBjIXkXdhhkHq/QeSiUknA2cRm0CiGYa935mrvRqglP3 8N9v9FQpLje0hXyrx9M+GbWjZ8i+4zxA7NQy+SwrUggtwvJH+qhEugl48W0XexGW7rdj zLvkUryEFDBD72m+JBiIpdC0a1O7ni7jJGf7g3ITuliZ/L+oNrMrMtT7E0JJDW5Jchyq ORnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699106; x=1742303906; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5QUtJ68S5WVMBdPVxDoGekz8XvAVXh0h8UUq5TqoFAw=; b=mejoLnGU0vhAEDXAHTvMETgAaFncl5AsReo/i2VrFSVB/EGJ+uKSEgnYCTyZYM8LPr BC9hJqk8x+0R2u4AycgXJQj+sCozzRgSobqaVEINH4ohfu5gRAOGy8++ArcH9Omv+J0s hQBx9rqQ4NqXFO7MWVktmkOpbBDDd8mrdeHcjnShEuRT87ffdJm1KSgT/oPo3wEYfbMJ 1m/1H18ATQAfehvJnN0MnREXZMNlE3Lk41l0Xej+oEDccY+el5oZG99tQtTZF17fhPVc vZBTYydZ22xA9RNsA1oHKJdIrkTihVbA++x2doVro7A/BlvdMXV5RcS7TUC2PtQI+TXP xrhA== X-Forwarded-Encrypted: i=1; AJvYcCWyyd67ofrGjWfh+oRLOivP+JlGe7FRL4nV7SqCpbGErcs+VzbhQIVlfeOfftWdbNL2qU/lvuLOgg==@kvack.org X-Gm-Message-State: AOJu0YwkyA7vuXS7luizRnpckmxwij71OJuDUsncIBIAbpr/CrWAmnST gLalAqSCSTkDwXwjHD/Njxtv8nyjqFoCy8u0VQmWiRZ5AhUiLex8qg3PpX43sjpaOAGPsNjGCg4 8OLR2zlbFKg== X-Google-Smtp-Source: AGHT+IHToyTOs3PPNxoBJUiCtaIlgO3ErHmKsYxSiQO/bRF9eUGsPTje1OCUomarBDaBQGTLwh5n+zuKNOR9zw== X-Received: from wmbet7.prod.google.com ([2002:a05:600c:8187:b0:43c:fad4:7595]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3554:b0:43c:fffc:787b with SMTP id 5b1f17b1804b1-43cfffc7b0fmr77724175e9.12.1741699106174; Tue, 11 Mar 2025 06:18:26 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:15 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-4-dec210a658f5@google.com> Subject: [PATCH v4 04/12] selftests/mm/uffd: Rename nr_cpus -> nr_parallel From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Queue-Id: 72365180003 X-Stat-Signature: ctwo8xewgdsr5mrssn43jcph8z65sbor X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1741699107-610318 X-HE-Meta: U2FsdGVkX189BvXIQkvshvJ0maje3R0IB6NPKDp8YWceyiHKlC4jjDvn3VXJbht3RQj+DSNOG/8P/PYsErfMczutQxf30Mcewpa+8ivwx+7quHi9UdnpTD5TkcaqllYP41I/QpD5k7yWFXwRMQF/xUwmuFgjNDBJRNneNN+cB/uELmIkZYm8lUvnrVVnrSIP3j6Br48kR7hkZBQAb2wJq9oltx63901zqIbrqvjDjCDBQkBzRCPSfCvYeVayoECTvWhkvXLXsAx8l/4JLRjx6XPKh7n9mR6Gcidq3ovm0iEYt2LVUsMfsrvb8VpLOhn9IkH3sqWZIzZPAp6haUdWvVxo/fU5xRccBJuNhXVCteJafjzMhuxXkIgLQlUTq/oYXairIaZf3b9VUNEHjXokfxkhA9PrwAyuks0HU65hvnnGkabdK3gvUjMwyCgnYsutDGbbUASotDxwsQ6ug5O5lrEyvTpKXdPQMLRCZyAxofQ+oxJuWHqkz3a/FYIBtdmYyhKurkIn15F8k9tIYZDzrSulMEQGNfzLrXFrfr/+T84ejor4wd6uF63obWRyBBAkN7YyH6XCmf/LGUEnXDwMBX518qDeN3sGcLE5o9lXzSXeQIHQcucnspP5hEjwr+QGkdrcIz16aaAiedXiXV6ztt71Xqua0p4cV1Tj5dRiIeBFm+nzajHLq9uS20KO8aj/rQ5hIiYZnia/3v9n5BV2HuGD0TcDJSwGnkbByOLEm1zObwvW8CcSscf0BinIa6oitVs0eXYH51FpPXBmdtMC9k7vL/BuoQHtxUn7CF6A6fYWdf5GtzWSMeVzbiSO5aEdT2N3OSjS4PvMdniJ8uZOvTv596+3Ck9rziSAThSoKXDqABL1j4Z5obiP75bCWZEaTCxOj9CSZwUZhWjCbUSWx1sUe58JylLnODkm9MxGGqXZBd/K1tVq86+BIG6Y2r/14gOopOuAP2ftN+MjM3b 6pSOIi0p SzCdSzNJOY8E4m1GexdxX60YaptPd1QwGooCE1iSLGFjeoE00PaHA6e9yZ1KX9QB1qKbi3/6ntB5++pb+lDXTYCAoePWfz+KRbA+jghPrG72qSj5AVCP4dm/gDnbnv9EvIAearppxmUspbZMuP46K6FfHMUUezDRdUwpz9gCQ/sO21fp392l5eSGh1rSGqHB74gGifvZJMV4yoCcZggxSvG0dknKd3NPtJZYT39ZBdRwsJHlTtlP6dTg8A9tJAsxDqyRvq69WAwIYmobWQUkFFXa1Kgq3u8Bsw9UcCIfArM87UQ3GtCXcfzS66xOEELEYz4IBT1XjzB85Qyk/tCP4+OaPjA9ZnrtORlcc72Fn2DedPuYjplSrNcKaZenpdghybTpq5UXKdgLh4dyZHQSdfBWeyAJ3aLvI4i5Q05TSQl6kMCy/Yu5l27vUcNRGY8uhD8wbGl2qv3TI09QV9mLwxZVmt4bmgau1Nnxs7IwSAmJVyXsUpaiL0k2py0ztVkVh+zrmr/TiMWAuswkrnJEV1LVzxCCcDIBrkrwO1YqR1wYD//Y8DJK455LxnwSeZ695tpNmc0neRX10HCHeHJjkvcgC+jtd6anCs0ANgWT5fMtSLLEQIZZLcjOmkNCgh/XZ6WvigHKEnakbe0/ResFQfukBurAbm467HUTr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A later commit will bound this variable so it no longer necessarily matches the number of CPUs. Rename it appropriately. Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-common.c | 8 ++++---- tools/testing/selftests/mm/uffd-common.h | 2 +- tools/testing/selftests/mm/uffd-stress.c | 28 ++++++++++++++-------------- tools/testing/selftests/mm/uffd-unit-tests.c | 2 +- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-common.c b/tools/testing/selftests/mm/uffd-common.c index 7ad6ba660c7d6f1f5762d0b231b92b05e971a3c5..dd01d2c95175b0329a75e220d2f43c915261090c 100644 --- a/tools/testing/selftests/mm/uffd-common.c +++ b/tools/testing/selftests/mm/uffd-common.c @@ -10,7 +10,7 @@ #define BASE_PMD_ADDR ((void *)(1UL << 30)) volatile bool test_uffdio_copy_eexist = true; -unsigned long nr_cpus, nr_pages, nr_pages_per_cpu, page_size; +unsigned long nr_parallel, nr_pages, nr_pages_per_cpu, page_size; char *area_src, *area_src_alias, *area_dst, *area_dst_alias, *area_remap; int uffd = -1, uffd_flags, finished, *pipefd, test_type; bool map_shared; @@ -269,7 +269,7 @@ void uffd_test_ctx_clear(void) size_t i; if (pipefd) { - for (i = 0; i < nr_cpus * 2; ++i) { + for (i = 0; i < nr_parallel * 2; ++i) { if (close(pipefd[i])) err("close pipefd"); } @@ -365,10 +365,10 @@ int uffd_test_ctx_init(uint64_t features, const char **errmsg) */ uffd_test_ops->release_pages(area_dst); - pipefd = malloc(sizeof(int) * nr_cpus * 2); + pipefd = malloc(sizeof(int) * nr_parallel * 2); if (!pipefd) err("pipefd"); - for (cpu = 0; cpu < nr_cpus; cpu++) + for (cpu = 0; cpu < nr_parallel; cpu++) if (pipe2(&pipefd[cpu * 2], O_CLOEXEC | O_NONBLOCK)) err("pipe"); diff --git a/tools/testing/selftests/mm/uffd-common.h b/tools/testing/selftests/mm/uffd-common.h index a70ae10b5f6206daecc8e19ed3e3bbb388e265aa..7700cbfa397563d2f2bc82be45f96f2fc2032bbe 100644 --- a/tools/testing/selftests/mm/uffd-common.h +++ b/tools/testing/selftests/mm/uffd-common.h @@ -98,7 +98,7 @@ struct uffd_test_case_ops { }; typedef struct uffd_test_case_ops uffd_test_case_ops_t; -extern unsigned long nr_cpus, nr_pages, nr_pages_per_cpu, page_size; +extern unsigned long nr_parallel, nr_pages, nr_pages_per_cpu, page_size; extern char *area_src, *area_src_alias, *area_dst, *area_dst_alias, *area_remap; extern int uffd, uffd_flags, finished, *pipefd, test_type; extern bool map_shared; diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index 91174e9425cde2500b459db78cb27adda6647b55..d6b57e5a2e1d7611aa1588ee41601ce16117a574 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -180,12 +180,12 @@ static void *background_thread(void *arg) static int stress(struct uffd_args *args) { unsigned long cpu; - pthread_t locking_threads[nr_cpus]; - pthread_t uffd_threads[nr_cpus]; - pthread_t background_threads[nr_cpus]; + pthread_t locking_threads[nr_parallel]; + pthread_t uffd_threads[nr_parallel]; + pthread_t background_threads[nr_parallel]; finished = 0; - for (cpu = 0; cpu < nr_cpus; cpu++) { + for (cpu = 0; cpu < nr_parallel; cpu++) { if (pthread_create(&locking_threads[cpu], &attr, locking_thread, (void *)cpu)) return 1; @@ -203,7 +203,7 @@ static int stress(struct uffd_args *args) background_thread, (void *)cpu)) return 1; } - for (cpu = 0; cpu < nr_cpus; cpu++) + for (cpu = 0; cpu < nr_parallel; cpu++) if (pthread_join(background_threads[cpu], NULL)) return 1; @@ -219,11 +219,11 @@ static int stress(struct uffd_args *args) uffd_test_ops->release_pages(area_src); finished = 1; - for (cpu = 0; cpu < nr_cpus; cpu++) + for (cpu = 0; cpu < nr_parallel; cpu++) if (pthread_join(locking_threads[cpu], NULL)) return 1; - for (cpu = 0; cpu < nr_cpus; cpu++) { + for (cpu = 0; cpu < nr_parallel; cpu++) { char c; if (bounces & BOUNCE_POLL) { if (write(pipefd[cpu*2+1], &c, 1) != 1) @@ -246,11 +246,11 @@ static int userfaultfd_stress(void) { void *area; unsigned long nr; - struct uffd_args args[nr_cpus]; + struct uffd_args args[nr_parallel]; uint64_t mem_size = nr_pages * page_size; int flags = 0; - memset(args, 0, sizeof(struct uffd_args) * nr_cpus); + memset(args, 0, sizeof(struct uffd_args) * nr_parallel); if (features & UFFD_FEATURE_WP_UNPOPULATED && test_type == TEST_ANON) flags = UFFD_FEATURE_WP_UNPOPULATED; @@ -325,7 +325,7 @@ static int userfaultfd_stress(void) */ uffd_test_ops->release_pages(area_dst); - uffd_stats_reset(args, nr_cpus); + uffd_stats_reset(args, nr_parallel); /* bounce pass */ if (stress(args)) { @@ -359,7 +359,7 @@ static int userfaultfd_stress(void) swap(area_src_alias, area_dst_alias); - uffd_stats_report(args, nr_cpus); + uffd_stats_report(args, nr_parallel); } uffd_test_ctx_clear(); @@ -453,9 +453,9 @@ int main(int argc, char **argv) return KSFT_SKIP; } - nr_cpus = sysconf(_SC_NPROCESSORS_ONLN); + nr_parallel = sysconf(_SC_NPROCESSORS_ONLN); - nr_pages_per_cpu = bytes / page_size / nr_cpus; + nr_pages_per_cpu = bytes / page_size / nr_parallel; if (!nr_pages_per_cpu) { _err("invalid MiB"); usage(); @@ -466,7 +466,7 @@ int main(int argc, char **argv) _err("invalid bounces"); usage(); } - nr_pages = nr_pages_per_cpu * nr_cpus; + nr_pages = nr_pages_per_cpu * nr_parallel; printf("nr_pages: %lu, nr_pages_per_cpu: %lu\n", nr_pages, nr_pages_per_cpu); diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c index 74c8bc02b5063f4667c4284c432edc7dee7ba3a5..24ea82ee223184612781adc852460138c4fe28f0 100644 --- a/tools/testing/selftests/mm/uffd-unit-tests.c +++ b/tools/testing/selftests/mm/uffd-unit-tests.c @@ -198,7 +198,7 @@ uffd_setup_environment(uffd_test_args_t *args, uffd_test_case_t *test, nr_pages = UFFD_TEST_MEM_SIZE / page_size; /* TODO: remove this global var.. it's so ugly */ - nr_cpus = 1; + nr_parallel = 1; /* Initialize test arguments */ args->mem_type = mem_type; From patchwork Tue Mar 11 13:18:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011880 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ED98C28B2E for ; Tue, 11 Mar 2025 13:26:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F4FF280004; Tue, 11 Mar 2025 09:26:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A4D8280001; Tue, 11 Mar 2025 09:26:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76DA7280004; Tue, 11 Mar 2025 09:26:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 54280280001 for ; Tue, 11 Mar 2025 09:26:09 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 275F8121F2E for ; Tue, 11 Mar 2025 13:26:10 +0000 (UTC) X-FDA: 83209343700.02.618433E Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) by imf25.hostedemail.com (Postfix) with ESMTP id 0C125A0017 for ; Tue, 11 Mar 2025 13:26:07 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ALL+dprU; spf=pass (imf25.hostedemail.com: domain of 3JDjQZwgKCBsA13BD1E27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--jackmanb.bounces.google.com designates 209.85.221.73 as permitted sender) smtp.mailfrom=3JDjQZwgKCBsA13BD1E27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699568; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LGBb/Y6S3RxkI/6vwf1UwhFj4ViFPcNM6Jmgh/1tpM4=; b=hMhHXvFJevpBsmoIevwvJBaSWeKcca55ueIv6KsrBR2N8w4VXS5wcun9exedQe2TE0y/EJ jBoaGldoHrpSnnhfTvUm20x6OEY93myqSqe+PcAStJAQQrQeZ4etUO2Pv2Zh5jny+RsnE3 njlpDkAOBsGtfY1wAfkLKHfq8SI53ns= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ALL+dprU; spf=pass (imf25.hostedemail.com: domain of 3JDjQZwgKCBsA13BD1E27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--jackmanb.bounces.google.com designates 209.85.221.73 as permitted sender) smtp.mailfrom=3JDjQZwgKCBsA13BD1E27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699568; a=rsa-sha256; cv=none; b=lWOVQFhs8EYId2PLPuZBrsEDv/7pgPgFOZsZx2g06lknR1U82ke3RtoCh3RQ1wb4YCSBCL vJ7rcwXH5jksCgbWXFdmc0KR5S9Y6tm7xkv6g7e5L805eOuS7En1XQ0e9qM+VWrnSI+w+x 29/DKOVzWJnlS4IKO8natwpHIhn4iyo= Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-391345e3aa3so2534946f8f.0 for ; Tue, 11 Mar 2025 06:26:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699566; x=1742304366; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=LGBb/Y6S3RxkI/6vwf1UwhFj4ViFPcNM6Jmgh/1tpM4=; b=ALL+dprUSgdU3yAlO6+KYJhoQvmqGhnltRhmV0lBzsGj2luhx18IkZ7AJgsr1SQAoc a38lPOJ5avtCff34DbZlGKkUFctEqY+eJqD5JmORCEkNUvawaUrQaI/1MVpaG6m7Ohzl fgo+gn+WjIB1TKyJIE9YGfwhqdI/noodlPYFM/QXHOruNawMzxi4oiJ6b8EQvPeuwj7n 7DrQiEow2ExmS0R+McA1Q6A+mMqWj23OMToR/mVdfIAILEn6fR2733TEF5t6ZRjuSFyE m6PZUzYZE9ENp5rgBOISzqzGc4lhVQDIfC89z0qwXUqVQbnfP7Eq7LLOXR2zWDJUIfR6 /38g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699566; x=1742304366; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LGBb/Y6S3RxkI/6vwf1UwhFj4ViFPcNM6Jmgh/1tpM4=; b=O1ezIri8lYVC5/a/NnwpK2qQ8TqwYEC0l68zxV1Dar/dB/HXN/DpnJKWwyRaXch7Xu QhMCqYhgh7K8DzEBa9gG1IPQ4BtPPb1d60KJVnXDvw53Z+A/A0npCX/H2tVe7ztN7Ejv 94FIsaeFozSzGo4kxSeD02MdiubawMKcs/P1BHX3GPvBVi18h/bHgADjtV5BI7Kjkj2H OZDSCuSxOUP7H1UqZF9/15KAQT4jOw4X1eYslr59kzskSlKVJiZeA9BZHYuByCyaVxAT lk5hvUE9pqrgVlBOa/hPFozqPEg4wy7l+uBGc/PJWgygeUioNigf11jECWAPHZHEb94V s21Q== X-Forwarded-Encrypted: i=1; AJvYcCWhCpkdt2xm52+7O8gz/YS6UBPgiA6utvMKTkdsv4wHlsxqElMaZZqmmGG6a5pYvm1WWfqCeuXq9g==@kvack.org X-Gm-Message-State: AOJu0YzZz7ozZC/03FZk0STcv4YXZCPer1igAiqswUZ4ph24SW+78nm7 4bjQ+K00/2u7M2uCIop6zAutvl/cOUq+I5cr8L86NsiwvzHANaU7Q6Tg5dyYYaEFn5F8nm88sJ1 py5HCzVSEJg== X-Google-Smtp-Source: AGHT+IEB4Ugao+9oG4PoYlVLqRx0MnCh6L1DYai8LwtyRUN8s3dqA+kO7+QszcVXjAFc8ZgqGgWa+WHaCnWckQ== X-Received: from wmbhc25.prod.google.com ([2002:a05:600c:8719:b0:43c:fce2:1db2]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4e8f:b0:43c:f184:2e16 with SMTP id 5b1f17b1804b1-43d01bd2167mr54372315e9.5.1741699108122; Tue, 11 Mar 2025 06:18:28 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:16 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-5-dec210a658f5@google.com> Subject: [PATCH v4 05/12] selftests/mm: Print some details when uffd-stress gets bad params From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Stat-Signature: ppm8jiwxn6njkgc8615ifbrhe8wjp8og X-Rspam-User: X-Rspamd-Queue-Id: 0C125A0017 X-Rspamd-Server: rspam01 X-HE-Tag: 1741699567-835219 X-HE-Meta: U2FsdGVkX19zKmRxTM1z0wnvptmBiK6yIx+gJz2lk3hSTssl1JTlk03MSDHiA0fNG4ZsbEb8Y2xjmU3f1cim8ZTVVal20mty3LA7/jMiI3Fdk+YYXj1bll7KX3GQ61kW+2HZlZ2GlHdqrb9Bl5jrfNteV2COepVqEpIOuLSyiW3BomVfMkWtcsaSkn1s4E3NtfIngH0ivHvtPUiyY05LpmxVdGtZyzmBNd+wm0yFVcJLyfyN/NyEGPoi1C13rV6jy2dslVFjcBio0p2IGysxq9d8/n0EgZuI/aM/iUNNODPUpbqstctjDBCutzkVMXBm+TouJ1OMoY1aGnN9S4FvkPKSlxUk0m5MnEAvHukCUJpv+vrmwgYQg/3ND4Mkqf2cO6bdKfKxeu9Xl4YGYuuWfOXLWsBRRJ+twWFoMvleG/sRELEnBY0RgiaTMWjvtDhBrwmcFLZxUJBb/xcPwz7M1WDuMdecjUuK+HIYvDXvn3US31rxZKN07F6JDNERTgQArcL0qZ0HPY6QeIU0/0MahjEWz6qcmXi4anPKg7BFFkzEuU8bHrjWNdPon1G4UBapvdvL5IWcS2XrQisbOLx8H/tJzxSEkWM8IsOrAlMhwcuQjNzsUrBPnKcJdmulb1+f0VheOwpNIUcHewc86LKIZhVFnTaBuIMAdMi4+TADrwtP7nyTm4QxUlg3bRHbZ+/0J7Oq64o7txzzIXtO+orhpvrKjxdDYBkqBXOz71c7l410RkAGS0LF9z3KQgcXInnx1Xv48MR34yhWhyOjQFx7/gje5Dh89s0wsHnR/q1wtk1TyhgL/FKnfKkLzejghXTc0TAnASQcB3FuweY6RgU7mZLBAluLo9K/5GsesVUwTyD4QG/Slmx2etdbUemT9fU8xGZxk8pvdV8+mEeC6JQ/hRgmZlAHNoY9Qc7TPkgwiyO9UK3ao7hCf7/0dO+H6X7U9lMCd5uxC4b+pdXKyjg ckEYjkkn IIW5KEBKwF3KzfxCh1ZguouOF6rPqWTXS1KSb08UYYSyJ/S8DWnCHA1L5TRX2rb0IOnllZaTgk51CxMj0EuxML/3HyKKjjpceKRKG2AfqHQ2lD2/3ERy9miiSElHgfuJCSftT7UW1xNXc3Dp9nNLiqSq9MGt2qD0rMaMhQq5TosWh2ErIPJWxEv++HyXCt/aRWN3gUVmtDLxCTLYPaOowEXIgaM2iQYMe41ABN0PC4BMnnV6POZuNpzuJY8uaPecyErwECG1G9KXISBVjRsK3gXdmqThGai9P6f5gh7nwMjP1p+FOUv0+pNx5gk/wm0sEjdbfYjfyVX+rV6VtDO15IT5RyUNATWqbzQC+PPfyZzToAo/mbZvPVKqdtmrXbFZUu347uDzodpPzycgxpSr0I7UIDfhZURwuD/9CPvdrjy6LDEmOlTwssZ+MTyCe+YfxLT4tGJf5Xc1Js1wbMeuEotq/5nR64d6Oqms6j/gOQittoTS9k8rrq01NxZaW1Em0IZ4qn+YB7+7XdLizJAf2lH6diF+gMB8elpIXg6HyWWKIcPkL/HLDz5E0qQ== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.463818, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: So this can be debugged more easily. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index d6b57e5a2e1d7611aa1588ee41601ce16117a574..4ba5bf13a0108435ce8b53340b9e17ccd47e859e 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -457,7 +457,8 @@ int main(int argc, char **argv) nr_pages_per_cpu = bytes / page_size / nr_parallel; if (!nr_pages_per_cpu) { - _err("invalid MiB"); + _err("pages_per_cpu = 0, cannot test (%lu / %lu / %lu)", + bytes, page_size, nr_parallel); usage(); } From patchwork Tue Mar 11 13:18:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011867 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2BB6C28B2E for ; Tue, 11 Mar 2025 13:18:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A3F4280008; Tue, 11 Mar 2025 09:18:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60A4D280001; Tue, 11 Mar 2025 09:18:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47FBB280008; Tue, 11 Mar 2025 09:18:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17D35280001 for ; Tue, 11 Mar 2025 09:18:33 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2982EBA8D4 for ; Tue, 11 Mar 2025 13:18:33 +0000 (UTC) X-FDA: 83209324506.03.89C7D4B Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf09.hostedemail.com (Postfix) with ESMTP id 3D307140008 for ; Tue, 11 Mar 2025 13:18:30 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Td3j6L6Q; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of 3JjjQZwgKCB0C35DF3G49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3JjjQZwgKCB0C35DF3G49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E6JjfJOQBkddVu8mbUCQ3JSQzc9s8ZEC60spagx9Tws=; b=ZdhTowHICcf/irp9Z0I8zCwsLgs8kOk5tg4asKpgM9mHtitdSx9Nbf36AS4vdEV2svzHYO AiAaeJ/DAEg4OgYDtTvgq/AZfe3nF38Icdmdyx8RhdQL0SYlWYp/QxVK+Y1qJ1CUzGrLvY tUx2jAV2LrvRaIOEksA9QhrJGNqZUoQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699111; a=rsa-sha256; cv=none; b=6qJkTwrzcz9hDRAeY1b/TABQa/dnnhyP1TvHMeD1rJC+YYkx8uSrCM+uvW1/7FsqHv2m8x PXZBe5pul4sq8NEMfmPOYBPtfSWLq9vPzAfC/VglGgjfzBPLyWvCdI6ROEwX7+auCjzUD7 JxXzYrJoCjIPfnYsh9GqLR+qb7RfAec= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Td3j6L6Q; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of 3JjjQZwgKCB0C35DF3G49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3JjjQZwgKCB0C35DF3G49HH9E7.5HFEBGNQ-FFDO35D.HK9@flex--jackmanb.bounces.google.com Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43bc97e6360so27362415e9.3 for ; Tue, 11 Mar 2025 06:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699110; x=1742303910; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=E6JjfJOQBkddVu8mbUCQ3JSQzc9s8ZEC60spagx9Tws=; b=Td3j6L6QXUvymVK3a2yQGAKPEw56xugOwPd2AkoET3biY5SEVn1AMwJJ9qyc1u2NFk igcCdc37B8XuOVlu0NPov3Xobq1nBoqPpc8iFm8HSrc88TZvHUzwYnb5IorgeWoQrMnb zZ/TGTDSQYQGVmomlQ0eLEP6Dcdyq5B0sjCUFg+OBP3EZJ5gwQhznuSh0EliaprMfmOe tL8LSzPoz8tGI4WXSIgqkuG5eSuryId0CrsqA0SZqYuOxNJ7DAJe8gQSUJLzQidxQw1F rkE9dj2huTOQlur5AHZnar925XXq3PJsQcK9H1Av2fWLI6e0TBvuAXa921mA9aAg7RjB goug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699110; x=1742303910; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E6JjfJOQBkddVu8mbUCQ3JSQzc9s8ZEC60spagx9Tws=; b=DEnSdYsU0r/MfFVr/nm8oCBAb0gW4o3XfJPnZLGO1DBLbi472CguviFwe0iEA1H6kR 30kd6MI6X2JFOyLz5dJ5C0ZrE/iWSFq3rBlG9O3vXE/hfris1XNSzxfWN2w/48g1qczU 4oOeHznnrOgFJBNE6YOcqcsiDbeggVNVQDprWwhOs9zxTbLE9pPf1pNElwyPEShWYVhY 6MFlb5q+SrbeN3v1NiS1S54ni7DwQxy8Smh/9bxwgV6ZH4l9zcv35G19uO0ueScRzlhu bjEB7298ZFK77PULiUq6byMJupGC0olPhdv3BjnqpA0zJjQJW3FmEp4RWkOy/AvS0TFH 540Q== X-Forwarded-Encrypted: i=1; AJvYcCV7L0uNdtNpHcOr7vLAnsgcDaSc3QK70NUU9+tnnDXXZkW3qDmA0RKUGsYMvwb5cu9rijt60TdUjg==@kvack.org X-Gm-Message-State: AOJu0YwDfmoZGEiO0owlYkkh/xB452dtynbrjiLOmX2NFTvtxljuNACj 8LlhJ3hsWvSI1GIZPn8PntuCJsZN9w1QX2Zu6b5Uuo1rZ0qwm+3RNmOTK5+MRhn1cGstFmDVifV xYeV2P71b6Q== X-Google-Smtp-Source: AGHT+IEIWvgrPAdW1aYeAn80KnMmveyrFiqXf2KEYlIp8fmgFPw+5h8vHeMIpGYZnJb/sky5I2oxhtfkiMAT0Q== X-Received: from wmbbe8.prod.google.com ([2002:a05:600c:1e88:b0:43c:faa1:bb58]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4316:b0:43c:e70d:44f9 with SMTP id 5b1f17b1804b1-43ce70d46f4mr104149745e9.18.1741699110016; Tue, 11 Mar 2025 06:18:30 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:17 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-6-dec210a658f5@google.com> Subject: [PATCH v4 06/12] selftests/mm: Don't fail uffd-stress if too many CPUs From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman , Mateusz Guzik X-Rspam-User: X-Rspamd-Queue-Id: 3D307140008 X-Rspamd-Server: rspam08 X-Stat-Signature: t7duubg3d9cnsutyhb5hpq9hja3g4yrt X-HE-Tag: 1741699110-350798 X-HE-Meta: U2FsdGVkX182X5wkoZirQaLHmk2vZwUydU+i9IRr2jcKMpmsYfO/tCbKYnl0MkldmhAnvoR9mDB53h8PbKMmTz5PIWFLV9DS5NLr4s009NdX2mBoJKtFUJ4pTgRekqKM2PCwcae8ID6okbzq9HkaVWPT3TyNNXi9MNLx+Cip+KA5uMG3aFiWZX5hT33JLRmq8sDwhdHBssEgbQZJoKjA77JZHMt6vCscTvWI33fgCB0bnKaiIWLE8uuDuEkdsSEURYuvrJujCVYkByh0HLEvAm8R7L+YUQnDSNmx9JfxjbS68hjyn/pNMy3xoEJfPqSvL/mgcYDp+rauyRxLL+nS9xjAd3mMRfhF68aJkwMHIopWxE3d8mZ1LffX1MAsRTvdvcSstbL6NXEzXBiTnBckff63AtdFrXnEuD0S1iZToBZ0CEV9hgKUz0SAv4tZ5P2RI+Ia37WmCDjfd8N4waA9rVxVzSYpEPioamgC5glRxRJSe1NgtIcRdyvMwZKyshLTwv+pC9+t469U4hW2Qq3BkfnnlT/C29jx25XnWbYv03CMJK7Ja4nAoUKey87HZ1DMx7gD/zDJ58qbyV6bBVeI1QTksD4lgDQFSn+QPUGjxLIQTTnDXV/6neAAsMWk51/DkTTci4m9vXtF4gPHC2HmB5Q0M0Hmy5f6uE/XP6suxWivxxbTUYq4Z+/vJhJOyqYClCVRvLTNr8rxdBPna/2ogFxrpwijeoYVe24InuvwYw4XhEUPBXjX3FSO4beT4zrcl5NQxVL6VrJSJHkkq1Q2DSQAEPtf84hVbID5v8mOLkGdjiNry4op6V3s11hNHcMRBtzq7Gc42WI6yLeOcR3WM8ooMgIJUVjmO3llbBqeJ0Y1AJUlU8Mevp+Db8JW9m/yRgyHMR8+jxfOH2fxKTbn/czAmqX41BA9siM1a6NqCM6zOENqSzXgPMLyR4n9jiRUgcj5qxPIx/Y+3rmgUBJ 9ccN+xuK FnJk3fCgJMf7XXV0KEQq+sNgYnNGVnbtxzdNRuUgDXwfppbz/vOfD+MFTiFCbcofmhvkpxYs3oPrWG5r0+9VBkkusgOKRHy0QX+3KbpVqtFNq66zA0EJLgiSWxW8R/wSekFgElVLxa2s1cUuX9LegSrLojQu1bAsXMc7eidv2gOnSfJA0FO36am8J7yKDwAwSeEGP4RGDAEDMbMinxYQiJ1gceOYNQ8TrhW6TBILBqkst3oA8xvlszGzNvenJ24l8YN7zSb6rr1cQDLkUjRZOcfaGdmsz0MJCwLfiyu3Gho/Ti8ebzZpIjLiRxZvxtbzHUjwH4Qeu4knmrTmUFACs5+SZS0wYN34s8GxtZArhETNTRXSYheC/fuCmNJEZPIDfWW9pJg/g5aK10ZMatfNWfkR5JW4E+w3ycOKA/jILgs7zktet5ECAyXFAW07Q3i8GwflczStYNHY9R6hmfFTVmdx2Jq34FHFa+TirZQHK2EVZ/nAxFLRph4yxYVru1SwyrlAbPD68xtAqk42BLoYc44Rk/cGElyl+42J+0y6mqVVqWZWt2+no5NYmKnwkPlfa88OGizIZXikrtM4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.036839, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This calculation divides a fixed parameter by an environment-dependent parameter i.e. the number of CPUs. The simple way to avoid machine-specific failures here is to just put a cap on the max value of the latter. Suggested-by: Mateusz Guzik Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index 4ba5bf13a0108435ce8b53340b9e17ccd47e859e..40af7f67c4074d901be6608e5d64bd0490026dae 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -435,6 +435,7 @@ static void sigalrm(int sig) int main(int argc, char **argv) { + unsigned long nr_cpus; size_t bytes; if (argc < 4) @@ -453,7 +454,15 @@ int main(int argc, char **argv) return KSFT_SKIP; } - nr_parallel = sysconf(_SC_NPROCESSORS_ONLN); + nr_cpus = sysconf(_SC_NPROCESSORS_ONLN); + if (nr_cpus > 32) { + /* Don't let calculation below go to zero. */ + ksft_print_msg("_SC_NPROCESSORS_ONLN (%lu) too large, capping nr_threads to 32\n", + nr_cpus); + nr_parallel = 32; + } else { + nr_parallel = nr_cpus; + } nr_pages_per_cpu = bytes / page_size / nr_parallel; if (!nr_pages_per_cpu) { From patchwork Tue Mar 11 13:18:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011868 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA909C28B2E for ; Tue, 11 Mar 2025 13:18:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58A42280009; Tue, 11 Mar 2025 09:18:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E514280001; Tue, 11 Mar 2025 09:18:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33A52280009; Tue, 11 Mar 2025 09:18:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 085A5280001 for ; Tue, 11 Mar 2025 09:18:35 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2B8551CD32E for ; Tue, 11 Mar 2025 13:18:35 +0000 (UTC) X-FDA: 83209324590.27.20028B0 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf21.hostedemail.com (Postfix) with ESMTP id 4B5F81C0019 for ; Tue, 11 Mar 2025 13:18:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ztPkCOEw; spf=pass (imf21.hostedemail.com: domain of 3KDjQZwgKCB8E57FH5I6BJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3KDjQZwgKCB8E57FH5I6BJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vce7eh8mPMitMWqdtTQW3Xgxbt0OG8W7iuQCUiRo4Hc=; b=YedWe8va2+3rL8gXaNaTnYgLq4FDemofK9ezRrndhLGrsXDTTAeCtQhbkeorl3sgsbjaJ5 CVXuUPgl5eOs7zo4tRqJR1/kl46nIKN+sxOFdTiyxfSQ5SUNz7w7bpGWTtraXTVAwN8UXM DPUfwM5BpvzM2UonhtL6iYDqU0P6/WM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ztPkCOEw; spf=pass (imf21.hostedemail.com: domain of 3KDjQZwgKCB8E57FH5I6BJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3KDjQZwgKCB8E57FH5I6BJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699113; a=rsa-sha256; cv=none; b=cDo8mxhGPGhdxo9q9Fcg8MQHPuyYZpyXDHQ+xWzxJ12ouyiDK3e/D6hVoe4n0dgzxLT6sR 42cvKeYozN2Rtvdl6ePR2C7XRQru5ARh85Wh0xtf9HbXmZEnzTMri72VG5GEM3Jqeyva9K pXLYe8shBRNGMGXZ5+hTQQ9OvU/0K4w= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43cf44b66f7so13124865e9.1 for ; Tue, 11 Mar 2025 06:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699112; x=1742303912; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Vce7eh8mPMitMWqdtTQW3Xgxbt0OG8W7iuQCUiRo4Hc=; b=ztPkCOEwzqTz5DgS2XWWIxqKSd15zp1WjDLmolwBzhd+By1fu2yxsLKMLEt6BH6f8+ HKjLTJwSpswWhbpJCu1IkE21h7LLqDMnUTQjMK/jzYBcy3Kj4jhTl6grnhzAyZaeEiMH o9rxDr82LoZ8s9uEWDqWMtTxZmIe1emksAm832NhXLIfmnAyotES0Haf23UEmar40R5j xwGZw2rPAqwx+FdlEGxXWSIFG8JG/gaHfUZlLGLt99iN4pXIm/EDW2FLI5g1vScqOkD/ 4coAaEz6iEgUPudruhBkcenBYQo1OKP6LQe+HsaxG+90BsW9Tm2aSlJqg0vV9y+7LCk/ inZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699112; x=1742303912; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vce7eh8mPMitMWqdtTQW3Xgxbt0OG8W7iuQCUiRo4Hc=; b=FqxX6mniwrguBfYGXwVVn4fjUOsjlQI18XTeO1s4b9wc0JkS76+Prc3qL/0vhLq8Lc aGptBsfN168x+bxvKLPtBWM/yoGgFAMdb2geFhUEfK2WJoENIQhP2OFK/bmuBBOF8njK D5rnbEn+DwaA4BeRdmX6FLDJK/kZHGRR8ri3UD1jhNB/KNaBc7ld50Q+4vjpvn0YAtvA CS/lJvhq0Q2li4KEwA3pvVhKCGRlItHR6lhIsBLLTgQw+e2eARij8TfoZZ9XaMXyVn5a JWpOQZ/7v+Dd7nlvZzVXiMayEW71L3JJZRlD6d4k20wzFRb6dyKuEZSRhwjTto8e76n4 gpPw== X-Forwarded-Encrypted: i=1; AJvYcCXv9gM9yRa0zhplHU3lTWvsWtzadgnBHzRpSjILWUFAMAUL1iO3xD8Vf6gAE5fEJwb32opwZpSBIQ==@kvack.org X-Gm-Message-State: AOJu0YyLP8SV6Q/rFe8uOhB3Sq+wavrCzJgdQdhzYy9uNMiWMEpyYiiQ FuHOX0YhWkTsWrpvywmg245Pg0U3La/RwBvWlphOuOVwtK8lLKPJfbZ9kC7Uz/8pBUxYVYC/bKX AqcdrPb2GCg== X-Google-Smtp-Source: AGHT+IH0f6ArUDAT+Z1aqU0gEtWgWP4WVJVxUFx2+ko5jUv3CK2PIBB6GlZGbkJUJj1SHrJwdvtnC7ZX3WPGDQ== X-Received: from wmbbi10.prod.google.com ([2002:a05:600c:3d8a:b0:43d:7e5:30f0]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:45c6:b0:43c:e7ae:4bcf with SMTP id 5b1f17b1804b1-43ce7ae4f6cmr119062035e9.0.1741699112009; Tue, 11 Mar 2025 06:18:32 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:18 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-7-dec210a658f5@google.com> Subject: [PATCH v4 07/12] selftests/mm: Skip map_populate on weird filesystems From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Queue-Id: 4B5F81C0019 X-Stat-Signature: 579dunfn19z5gf46panfgxko4uzzm441 X-Rspamd-Server: rspam09 X-HE-Tag: 1741699113-327751 X-HE-Meta: U2FsdGVkX1+7YvDcv525yMHPUhtZ6ifHVpS56+QvjvBZSpReDM9MDdMgeVT35tasmQiXeBUFLz10mDaxFL8wOhQDCJBnjDop4bMnZr618Rc+61sgyZqLOtfCV9YzEQVyfHQkp0rcxkyN3AchTJgjeTNS9hIGa2CiyH09SLFkUZ2frhX+g3NoE1hQgH1d+uKhmxgoNjI8CcAF+/t7h3KV+gqeG3KeKQeL+CuyTFHFuujS0Vs6F6lTRXbrpFg/xHqNzndIZOdmKW07mmcNdsIeQOsW9ay3hUK5c/qPSs4wD3vn0XNnb7nU78izCWIvv3wV7/TYpEIP4TXU9JvvHqFsIfWm1OIpFRY0nThWKgXOKQ1l4MLus0c8tK+huvRH2m/lZ6bq4dvtnPPI/p8O7BxDNVUyxiigPdgvi67recXF291AIT3pvttbwp1suvlmJMFZ5tfEzi3Q5HWAAxLakgzS1BdzilkrgOHnH3hJDwrQcxJiM73mZ/dirBJ/3E6AIvPU4pbOfqxY3nbLZyBI8DeaWtX9FLo1LeIeg0p/4rLRLTJ8zgmpUfLS8K3QO8p1rigy+qYXLdEKCvAcKEOy0f10zKRCpMFxGwP14GW4/QW9+BIp0Dzb0+CrDMDb+fFhkawCxsFUH2+4Fmo5vA4mdaX99FUGG/j/bwrLnmc1Ar6SyOoN4yr85HBlSKZrvOF+uACTR6FZaPucLZsl/S1H3TjESrdpJgILvOdtHbf4vAvueDcdhHyayGp3AXzFYorSjAv8t0xsiohU45vWAT8eeltm8tOzO3t8hDlQY6Z5rtiug/EBxR/kbjk35nKq0/12zWT/j7ooVca9iNzq7ACo8Jd27BSOb4B+OkS9XR9WWbKJMRv6zLnYABi/gbaQR9u8NP6Ze9WsbRHhwaS95wRfIThWBtGUpA+X+eKlTlBsWf62fYLdGNiXre+lE+KI239rUBS8urjqjCq0Qe5XVnSP9Rq rCAO/h+m XNBv+sW9yD4073fJHIRa9Oa4k4Zg/LgWHhRk/IklHl5YmP+WOYl/kIy/8TY1Qs+GXk64q0LRf+RDSTdgK6iS2C9tEng6m2LkJ7qsYYPhXx+nnUAq5h8eUVTD6BNalxxgH4YAwGSNMAJ12ILpMC7XeqJ00YQblwPwGpN8NwIgG+Y/Y+n7v57bT8rr2cZ3bCoDWJ2UEIFfwYxLIszwVZYBzNBRxFh0Jo1q7wos7B3tqY1FHzQuli9dm1TtBHZdttoPi3hLpwPxPJVo3O1p49GAmOLzEeuOtRBPRfsT1sbamPpAjo3UtaH7WB6tzvIqGf+PZQTUj/M31N3DGBWQkMa9hSRzdiEvFz12ntm34TpYtbDPJnOznA50/VdKA3rCBIgo7ZKFPABEvdW2TNFs6yplLyOcJMtbsE9zi7opV3+NOfbPmbQ+/kkmATXBavsZANO+bjr39+9Ax8nCBaNzBsoDmgp2zI4ZnkI4O+X0t/dSezwRNOM+OkhEqpUK7H2Q7nKFxz0hA/tu7+4UABzjSclS9W2X+ljbHTK0tfSP5DRP5ItH0OcMwSqv6nN9VgI+U8ZNUF8SkEVsa4M24FqhIN/64dOR7ZtLptVvhznZX X-Bogosity: Ham, tests=bogofilter, spamicity=0.109311, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It seems that 9pfs does not allow truncating unlinked files, Mark Brown has noted that NFS may also behave this way. It doesn't seem quite right to call this a "bug" but it's probably a special enough case that it makes sense for the test to just SKIP if it happens. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/map_populate.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/testing/selftests/mm/map_populate.c b/tools/testing/selftests/mm/map_populate.c index 5c8a53869b1bd287b09a250edf628a66c25c2439..433e54fb634f793f2eb4c53ba6b791045c9f4986 100644 --- a/tools/testing/selftests/mm/map_populate.c +++ b/tools/testing/selftests/mm/map_populate.c @@ -87,6 +87,13 @@ int main(int argc, char **argv) BUG_ON(!ftmp, "tmpfile()"); ret = ftruncate(fileno(ftmp), MMAP_SZ); + if (ret < 0 && errno == ENOENT) { + /* + * This probably means tmpfile() made a file on a filesystem + * that doesn't handle temporary files the way we want. + */ + ksft_exit_skip("ftruncate(fileno(tmpfile())) gave ENOENT, weird filesystem?\n"); + } BUG_ON(ret, "ftruncate()"); smap = mmap(0, MMAP_SZ, PROT_READ | PROT_WRITE, From patchwork Tue Mar 11 13:18:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011869 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E67D9C282EC for ; Tue, 11 Mar 2025 13:18:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA33728000A; Tue, 11 Mar 2025 09:18:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2E76280001; Tue, 11 Mar 2025 09:18:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C7F628000A; Tue, 11 Mar 2025 09:18:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 57BE6280001 for ; Tue, 11 Mar 2025 09:18:37 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 73F7181F50 for ; Tue, 11 Mar 2025 13:18:37 +0000 (UTC) X-FDA: 83209324674.20.4FB7B8C Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf12.hostedemail.com (Postfix) with ESMTP id 8019640019 for ; Tue, 11 Mar 2025 13:18:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jutzItBL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of 3KjjQZwgKCCEG79HJ7K8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3KjjQZwgKCCEG79HJ7K8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699115; a=rsa-sha256; cv=none; b=Dl8Bf4w01Bajly/5im74Tr55GJtuKKQFc05NGqijHYLJkSlQPTdzvntsAb36zlHMuHA+M4 r6xa+IirnAJGqaRp0AgEK65jpDeeVqqsQM6Bwe51SXgkm0k8r54qoofnfNJuwNUqaW5kba 5z7AYXMg2qkYtbGwxkMYK2VIb9m4aJ0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jutzItBL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of 3KjjQZwgKCCEG79HJ7K8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3KjjQZwgKCCEG79HJ7K8DLLDIB.9LJIFKRU-JJHS79H.LOD@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vEpPGTTI1xwsz2Fyvp18/EwqSXfTpjR75q3+Kl9ryQ0=; b=5l3WiTgqHBOab1OCClinb2T22JRhHlbnR/6hvrb1z5cEiczO3pHVV5hyxjqwCQ3MR1rTkT 2M6BIOXBdwV1BVA3OL73Wf9XPu/GnYrUXQDBP4LobJnKCquaySi919J1W14NcFzjiaJuBd BCL5xV38/GW63JpeWplJ263CfKWSecg= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43ced8c2eb7so20518905e9.1 for ; Tue, 11 Mar 2025 06:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699114; x=1742303914; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vEpPGTTI1xwsz2Fyvp18/EwqSXfTpjR75q3+Kl9ryQ0=; b=jutzItBL+uSdO68QOazxRb8Bq6IFHZsLwewrLCyrv4NRnGJSartESW5x5lqlkADLgu hOE+vGBJdZRSfkPTpVRlyd2yYnzfVTMV00MVZ78SbdKMEd2oh+/ElqTE3yWJHL0Zr1ay 3m/Dzwl3A4uUOTtM7R6sxOaDg6CEoEke3J/qa7GoTdxuJDGzrRmpgYVZ47R2h8H6eyDL lzV5apNuHxJ5wifcU6PBMhn3GJMvpJoC1LStGvZTZB1ng0jmJyrQikPmuU0Be60adbRi 6mbcNX4ocqcZNaHONhA3GzL1yhmCt7JAUC93OltJ5RvNOJKTruvLimem9IMLbCbPD061 krQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699114; x=1742303914; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vEpPGTTI1xwsz2Fyvp18/EwqSXfTpjR75q3+Kl9ryQ0=; b=bKao3TZtj5qZc4924DIjsgR/oys0l3ESHp44waRTMaj2LkhsOprs8iahSH79a0vO+h PRYmuL/nlWtQFd4+Rpr3MX6x7HWf6nwadalKqL40dzYpFVkh6uSloqX70fT0zYB4ypsX HUQN7ba7rKq8btgstGANoF2pPnL3IxwHKy8afdP91H3SkeCI+9TGxqTXd7NiOOTOM319 B9Te/7kGRyqASz+jVkjg3DRFWLscLSct+Xw6FjCY4DRPkPSNFLRQG0tKlhBVfar/7u2n XpKmfwjvGLRa+XCE/83dMgR1XdReAb6pza1C4bz0ybq6OfU3f0WqSt7gzGeb0aE0cN3r FNRQ== X-Forwarded-Encrypted: i=1; AJvYcCW95Pt+mrdzax5IyVrh+o5F4716gYn1HvpQIxd2iqFpSEnDNoZDvOtHzilVcl7qUnywwupRSonu/A==@kvack.org X-Gm-Message-State: AOJu0Yx7tSZ+QjXx77ZBffYKttta95CWj+pLdChPCXFSHcW7sqR+iLGG 0nJWripYbH1D6/0MOsyNc5r+QTdQYzJmBCVB2WHeMjR7sd7xUyyyx9B7nck++q8gmi5gT2yAHAk oKx3GHdh0Ng== X-Google-Smtp-Source: AGHT+IF4wKnonit+EpSv5UW7OYNEJNWqpKGUxuJH1HQv+WZ5yf0iB3xBzk58+Z6A+0FjREeEmIvwD2nZ9cCRYA== X-Received: from wmgg10.prod.google.com ([2002:a05:600d:a:b0:43d:10b:2c42]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1547:b0:43c:fceb:91f with SMTP id 5b1f17b1804b1-43cfceb0aedmr83968355e9.11.1741699114176; Tue, 11 Mar 2025 06:18:34 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:19 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-8-dec210a658f5@google.com> Subject: [PATCH v4 08/12] selftests/mm: Skip gup_longterm tests on weird filesystems From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Queue-Id: 8019640019 X-Stat-Signature: pznxri94dskn47jiqxtba3gk7z173ajk X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1741699115-651307 X-HE-Meta: U2FsdGVkX19Q8ddm/XB9KJo7yCPbbQ0+5fy0o3WNS2u5D+HYtUd8bMV+Tj6WydOYt1Pk0wObaAaxCntTdLuU46BXdMVy76whaAS7BBVFR01jd/12AQaYBLfFzVz26fw/gKb1UJ5JiMuPrRaryiW6I4DEp/mwagz+1LQVRB/5jkbiOU/+ZY3FeagE/BE3rBBsTAPnd/PmZrXFg5njiNZjN3rrN2kgvVi6ierV3o6McLnEXC6p030hYOdad3iJP57bQqDG2HD8j5HAF8lQtlZyCw0NheLYiCr8JL7vsDviqqHlfYxZu+hwOw8gXowoTlfIUEoGCursT//vNyP4qkXkclNJVuhxzhatzqNvHaPKOXqcKh0aOz7yMtT3NU6hODFs4aLQ/QVkLSXEcrSBhMHQXebCcPMKxAY/Mutuj9YAi2CUGHttd55ij/Bc5y5WNlbEwySDIJPPWizOAB7Yf2ryy8GFr9SZIe+ULhks1VQmwpDJonHrpKIPOu6gZr0HyfJgYimg0Y1vGnN/nUyna5gRNzqjvVK5uygSFeYXWhrbVVhHXLIoZWigvP1wp8A1nzv3Dj7lx+QmPEiceYYFdl6555wKxfH9lumcWUTOhHmSKxhaSz1Gg0R6INxloPBqCLc4eb7lws53MbeZ2NnQV9s8cUgHuAWZ3/6Ik2dpJc5mA7Uwn0mck38r8bZHw/n76ZQNJrDDp5AnU/VrFNoH+kZZJ7G98MPMs5h05EAdy7f85r5L98k8O/vI0jpV7eBYfr0BoWh6pZdaiQ4/YV+m86JaYKLgIVeuzZwNBKv7XmyzLbSdBX0TJso+a8gBbW2BIf/dHuuwgjWFFucFcRtNsZP6zZCrghMxR4oCDg6runtWrZqrSBFOBCWkXdjzbwMYL/F/iIKeuOglcBvbZPzsmpB/+fawabEmMB1PhiDzxgyctNbp39NGxR5p1lpO5XMW3g+c6NR+NH3qVCJhBIsLttU 4AwLLQ0k X0yoFDdR5WPDzv9FvGBS3GeJuWzMjLcru0H6fzhGX9sN7zsPB2urXz2JEfrs8LzPtuv3gB3n8VVn6nxn5Q4FtU8FjRxtA9NipwGALHyrv9bkxRRhOLdlOppy1h1fY7aW1kss/AxrJ/vL+9Iuvd50FaL1zrPYMV7bIy2p389E+V6IX2wnmPVI2soANKKxP3/ZyvVy9RuKN09+1X3TWEfJY6VdXe8AWcgn/BeGTRG5wJxgA+nk3pBRAYvbYKRy4eINrpHM5hUscjb19lHfuv6WSzaxazGES9j4oRjKYd/H/xIeFWheQcQWfJZJynH5UnMmgiBtRHVqriGd39/CmztjcNdzRpcjABP+uND33LE7r/7Tg1FpWEk5kgzYmpOrmz/OpIGUWFKPbXjorM497slpmy/bQcNa8r3YUwKoDOg3Fg/z2xrShbM9nX015MZuPLwjrf2iiwbC5aXS1oP3VdOhK0UTKvgPj/FDJbPPSKB8b0nYPn2+INkClfBW9sDHhl7QOj545yoHDGPmJp+RFRj1iqg3hINtNad+P4Pkf/EVRWSWt6Skj5G3+G5WVDxHUbERKD7wkOzWp5FEl2ui2rWUSIpUK9HkATDuPZks5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.152789, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Some filesystems don't support ftruncate()ing unlinked files. They return ENOENT. In that case, skip the test. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/gup_longterm.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c index 15335820656b1c143b440b8a1065a025378e22a2..03271442aae5aed060fd44010df552a2eedcdafc 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -96,7 +96,15 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) int ret; if (ftruncate(fd, size)) { - ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); + if (errno == ENOENT) { + /* + * This can happen if the file has been unlinked and the + * filesystem doesn't support truncating unlinked files. + */ + ksft_test_result_skip("ftruncate() failed with ENOENT\n"); + } else { + ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); + } return; } From patchwork Tue Mar 11 13:18:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011870 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC88C28B2E for ; Tue, 11 Mar 2025 13:18:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98ACA28000B; Tue, 11 Mar 2025 09:18:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D30E280001; Tue, 11 Mar 2025 09:18:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 628A128000B; Tue, 11 Mar 2025 09:18:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 376DF280001 for ; Tue, 11 Mar 2025 09:18:39 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 448E281F6A for ; Tue, 11 Mar 2025 13:18:39 +0000 (UTC) X-FDA: 83209324758.25.4413504 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf05.hostedemail.com (Postfix) with ESMTP id 51B0510001F for ; Tue, 11 Mar 2025 13:18:37 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="u/KYT0wx"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3LDjQZwgKCCMI9BJL9MAFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3LDjQZwgKCCMI9BJL9MAFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ezfRKweWcsi8VDsOy21QFyFbC65YGuaZroNiYeoxlPc=; b=0+RXQV2rhBs2h+m9LUhvbug5nDyawKXgq/9UWMzPZ6BckH69ngKOvUWR0n9VWWk8Bg6AwV H8F0D8MUMIU1+Mtjhjq0RmfxBV6rMAgZUUfGArM9cUJNhjHmNFKiDqvtON19UcIMqqaCwI Zl8Wa0I7sgZkv4B0gjkKHiHLExFgZLE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699117; a=rsa-sha256; cv=none; b=VUQYCd8ZKdQFUS4OTNw5W1sQH+zrmTZBmqL+cXQlG5pcavgtELeWDhyRHrHoTKP/NaHNs3 YlLpLMaqFg9FQcnnVLDbS3dgh2bCbv4RSEJoR23tzro07udifKZU4jgW9d2mzjF5SFbHDS dSPvPoUWVVQub7IUdyXW0u/H7KhVwRo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="u/KYT0wx"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3LDjQZwgKCCMI9BJL9MAFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3LDjQZwgKCCMI9BJL9MAFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--jackmanb.bounces.google.com Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4394c489babso27388305e9.1 for ; Tue, 11 Mar 2025 06:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699116; x=1742303916; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ezfRKweWcsi8VDsOy21QFyFbC65YGuaZroNiYeoxlPc=; b=u/KYT0wx9IEy9MC6EAipK3q0cL7MjHFFbjEYtkDXf1I/XOOR26FeCe2wsEUcadflkw R+SfvGo6zTsUvLmWKlNbOp6HmDcP7ZleTaLJw7/yhoibswfelQPVSqBNKnwAcfi3PAH1 Jolx00Eu8Gk09BwN2EE8WrLT/4WjiJ7zVBWx6+AYFtzY/Ng86BaAfUJ2NHJtDTfitW2R 2JYxP+HDZOMYB2kQTwI0XVXWWb110dDijIsxEhMpB/Mt3allmkVI/ni0QVnp5Eeye2NX xMTy+1gPfItA8Wsspcsz605c0rwggJLVuMyAtK0dmOVASJTbkVsdVfQ1vtq8rsjmDwle l+8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699116; x=1742303916; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ezfRKweWcsi8VDsOy21QFyFbC65YGuaZroNiYeoxlPc=; b=lyHLxAQ9aOIy50/Rad5QtTcKMqRVev2QkgiHkDcOQ1UhY1MtFNtUc8Gl0PFL4iiYgz T9ipoQvWqlMK3xnBSCaTECw0hirbrhsdBIfxtSzyFuk9kJDmkxRZkEtor35VgGgyxQ18 TIVIOdrcYt99R7chgWNHYTAmuS/95q5yj79u4fkXwwVxhEPPlPUnyYFAhzJZpu6rzDhe IfgKlXbxbUuHUMwHBBlQTd0Xi/k9SjA+sB7iiXdNIuNFSWLH6K1ClxLA9McjZm8RLByX yqPLRIo2Ojg6eIzHrQMWxc0OwY1cHwP7c+RrEDUKTEz5niLWd51RNjr8+1P8b9wzEFH/ sWCg== X-Forwarded-Encrypted: i=1; AJvYcCWuzC7Mn+7YaEpujCwbCO6j3DHw4CM7mGY39/pmVftmEhqftgSjt10dFvolLm0enuV3GYk/mmMTtQ==@kvack.org X-Gm-Message-State: AOJu0YxPXdNSQPXvPgkwJkYZBlmgzjwOsKNrqjdEXdpv3LC/eQlNuDLs gWY0iU+oRgcRoFker0pJfWviyQbbSYkdIQtNhjc19KQNrz46xvrcrjyCotxaYHd0osByfNUFNR8 zB2tOi7RR3Q== X-Google-Smtp-Source: AGHT+IGM8dDbafePeprrNK04mscqi9s1n3LRsj1p3n0Stvsl5Ct+lcHP80x8iiWL53VzzL0Jri/DkBOybzhFEg== X-Received: from wmbet7.prod.google.com ([2002:a05:600c:8187:b0:43c:fad4:7595]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:35d1:b0:43d:53c:1ad6 with SMTP id 5b1f17b1804b1-43d053c1decmr18085815e9.26.1741699116150; Tue, 11 Mar 2025 06:18:36 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:20 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-9-dec210a658f5@google.com> Subject: [PATCH v4 09/12] selftests/mm: Drop unnecessary sudo usage From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspam-User: X-Rspamd-Queue-Id: 51B0510001F X-Rspamd-Server: rspam08 X-Stat-Signature: uuxkcfia4rzegu5kqa7qogrp6r3x961c X-HE-Tag: 1741699117-961947 X-HE-Meta: U2FsdGVkX19fqIGmIEZLsc4OyPAwtPD0vv+mcEbvM9u45H6N3zQ177RVAt6yb8lrqxSitb9Ucfyp7rZsFVuC34aGGaK72kGIW/3QMxDyR0qvIj/zBpUnqe6bUaPCx4KIYoOJHL6OgSVXNFBZOvXU2RNHlmKA2A5C7zeRfU0m4gg61rrQMRmajofDe//9dw+jetJVgPbNgzRcq20Da/4yN+vhAjP56JsC9jOrDLFPEJD2CdpDu/suPAX7Bi9c0+PYuTl1w3WX48voq8G+YfqrqjacxduBZvJvNDN2q+ci1oo8brb9Ud8oKeS0yXiXR3TADd0OOGMpmrw1bAYRH6D4LwQ4y962uHEWIMw8LCG2+1yBEBhp0jaISIVaEL0SqPZqFXU9NW1N+gGfFg7Uv6Y5XDuW6UP58dCOunk7nLp27h0GcYEaNjl4aYHMd+uGbLLK+rcsFS+kFoIRc3kVKxhcZKTHGs1x2SXtyuuTUA164AXwNXQ7EO/V0gGNNAPh7CjwFu9T0Nf4kaylzAX+Dkl63qVhBhDuoAxHiMUSs6hFqhB/LOB9/9ys48A18ZBCJdDu8h4bItIc3nOYRxy+77sFRDJXj5u0m1rFxzUArJ8LMvw8G6wsL1tswTXaR6FtQORkzB5cME+eH3aorvNK2/SOpPrgSMxB5NLQD6sfXaxjv5b++ycK9p8L5DfANKpil7Ge+Z/cjGsX+tMjZ/Jj6IO9Uf0mwEt8TERnxccL/KaCqnA3gvnqLVkbtMRw7FYixiymKfH0+Cv9EHCmmmXp5MxNhHJmm8ESf8pH20cSU0JQekwIr5Wy6aqCfjS8lpXlsAJ/d5NmzlMcIDrfZ9B/q1bUICoElelqKZ4upD8LKjA4a3bnDFNiWjYfaXeiaIkFFob6mDRps/DnVRIZkWZqNqIO2OQTOsRlr0ihtjHGJnwQ2SpUi84t2UkD9srkrdCH611juBwTC2Uli92mxIbmJrt MKcbb+ad u2ueydKY17y5Fb/G16Em4sjS0k7tdSBFJCTbsInZXN/it0B6aGhhqi0o9N6jy90lmD3RwhJr9U9B3pKXY0RV6lJQcJw8xbEuTmuiZthbFD3Fy0nY2+KZ6l06ixGmP3S5hqWwYLnV/rPmY8BkKFk1gn9QzQ4pd3j3C9PVOutELW+8P7Vwone8r5NaIxVsHa/5txU97LvoFOBG3SswYhJ8Gt1YUP4lDLWaYgiU53QKu2hixFdgj82GRmG/rNcvFoaHwdZbeHK5Z27FUEn8QtWa3pXYP1ybFYACDNI/eeMKDyjsuXJ/dNyi4L6VgV81/mOj6OR1ttOOcgO0MUNEJQZbvnvrf5h6caN3L1Ge91sY+VgrgjfAIHJxp2MX9kdGyLPri40WbZL0d/Jjy3UlyUIovE/YNkwk4SJvM4roF0Mx6ISZauvXyk1rR2jCnyLxtPKAkfLKrvb6T4n0zzEX7TlNI6yQRHYm6CDEqvjcT+r+PS4IPEvNKHG9khmED+QGInnacwqeokRBj8S0tUAtdtcFz3ZbUwXSWDMe2voRf2XmZUws5OpGE2hRvCSelU8ZsItFgCE4kDA3IGqm4e2GsGtAVvmZqdtQwQcpG5WtnaW5g1Px73hE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.160463, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This script must be run as root anyway (see all the writing to privileged files in /proc etc). Remove the unnecessary use of sudo to avoid breaking on single-user systems that don't have sudo. This also avoids confusing readers. Reviewed-by: Dev Jain Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index da7e266681031d2772fb0c4139648904a18e0bf9..0f9fe757c3320a6551e39b6d4552fd4874b0bf43 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -386,7 +386,7 @@ CATEGORY="madv_populate" run_test ./madv_populate if [ -x ./memfd_secret ] then -(echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix +(echo 0 > /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix CATEGORY="memfd_secret" run_test ./memfd_secret fi From patchwork Tue Mar 11 13:18:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011871 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31F7AC28B30 for ; Tue, 11 Mar 2025 13:18:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E4B628000C; Tue, 11 Mar 2025 09:18:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 640B6280001; Tue, 11 Mar 2025 09:18:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46DF228000C; Tue, 11 Mar 2025 09:18:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1D855280001 for ; Tue, 11 Mar 2025 09:18:41 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2C683121EAC for ; Tue, 11 Mar 2025 13:18:41 +0000 (UTC) X-FDA: 83209324842.16.E35BF39 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf14.hostedemail.com (Postfix) with ESMTP id 4AF23100010 for ; Tue, 11 Mar 2025 13:18:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=sBmWMzh2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3LjjQZwgKCCUKBDLNBOCHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3LjjQZwgKCCUKBDLNBOCHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--jackmanb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699119; a=rsa-sha256; cv=none; b=GRoZWIoYX5O11pOP08PfwcCjYZyZ/jbJUFsNzlS2d4no9byQ/CH/8PQ3LH35kguxc49Lie LcQ9cd+h5e2vToGv69pd5msyiS70NktNc+mmlifmNdrTttV5Kk1VfGY1ojUItx3HIpdtr+ uZzj9LKGdBy/Znyu0mVQOFuJrTvXoBY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=sBmWMzh2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3LjjQZwgKCCUKBDLNBOCHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3LjjQZwgKCCUKBDLNBOCHPPHMF.DPNMJOVY-NNLWBDL.PSH@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h7ic2pHOinjRIlh+O43kggDBsm61b3OXoKlUUGdMcQQ=; b=VppfpLEeMH5ahvjOMjhJgVyLEn3ktUbt3k6oa+XXR6Od2x/Um+8RtE085uiX72Nz8w63yk O5MhOdv0OUpDw3W/VbABvZHs0wAKWSnKqTam96HmNFSOI9zRARdyY0eUfzHJy6P2O1c+FI fhfduwl1XV0GctA6nU0PWvHt8q2+Tzc= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43941ad86d4so26659945e9.2 for ; Tue, 11 Mar 2025 06:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699118; x=1742303918; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=h7ic2pHOinjRIlh+O43kggDBsm61b3OXoKlUUGdMcQQ=; b=sBmWMzh29SZxya0zVPBFA/UUXZ1i1OI71V+G0/Eh5Xy02LXdgPDztuhYkgrrTO7bBT pf6PaulBROmzr7W2iffBWZCPF9LG9aAAPVhDlrYkqC0plrvpA7bVsRgxQo2nBIM/FO6u t7YEvysdt6EozD9U23mZMG0oRZ+U1eytCJLS9pwPai5CI2Xsag17TIHvYqaTaLQEDQkL rYm/51dkx38za1wAOVc3TYnuztZCPKLCYf74cAP5743eFUr3wzaFXHs4pkTWYhfNIlrp N+NZefQot0USUfj+2ASRFE7r3Mn/qowFXhvsLoRl5qlalWa6zCaCXW4n+aspTRrV4Kc9 wopg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699118; x=1742303918; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h7ic2pHOinjRIlh+O43kggDBsm61b3OXoKlUUGdMcQQ=; b=IXYoQk0k52XpzBYJlmaoOW9gA4CXhdhHtCz8RS8N+S3IyiHqGCrCm/Gal2NiXaRWbZ Wf7D9YgAkRZ1fZrQcuqIHVxSJ6SRjAB01vZFcDsh7HzJulQCpLRPsXeBmn9CSzgT0WWn xw7CCgUvLnexN0wR6mEjEHg0mxkJ2lLGT761+BxZvDjQ2b1bo+tDccHZcZkUIrk0UmTP srkP+ct0wHyXBebemAHu6aTk34ooYZQFN/gxz/ApGkE0Om6IAMG7WN3yLUCYiAUmpX9T fwXiljAHmYW0y0auoJUeNW1Rsf9vFxOhvC6DOwkzfMIYvrgPJHlX7l1wBFlgbxOpYlMi 13pw== X-Forwarded-Encrypted: i=1; AJvYcCU2rNkj8repRgpWRHeKTsLMUy8XPbgXoDq9V3vFH75epRJO63qLVdu5kF/L96o2YzqqUDKHOzDVUA==@kvack.org X-Gm-Message-State: AOJu0YzUwYVHtbi87sPTHnJgPNZAEn93oBljrCYT+NNqJ9TiwzE+/+nK Q0DPpLgA1+PzJ7RsTYiuZp7OOwxGmTW1NeCxLCfsrY2ZrRPMDgez1ulTX9Z+EvM/Zr/fif0X5Ay azSSXBalEUg== X-Google-Smtp-Source: AGHT+IHZlMGTcKX5RZ/uPw4+acv8n0aHStFuR6vrPyvpA6CiIDxxzLWRCjz5dgJEeQYAtTRRHyrT3C1VMcyAzA== X-Received: from wmbea7.prod.google.com ([2002:a05:600c:6747:b0:43c:f8e5:6033]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3586:b0:43c:ec4c:25b1 with SMTP id 5b1f17b1804b1-43cec4c26d2mr91373805e9.23.1741699118100; Tue, 11 Mar 2025 06:18:38 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:21 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-10-dec210a658f5@google.com> Subject: [PATCH v4 10/12] selftests/mm: Ensure uffd-wp-mremap gets pages of each size From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Queue-Id: 4AF23100010 X-Rspamd-Server: rspam11 X-Stat-Signature: x1pwr39fkrkx8cff63sijp63qhtka8yd X-Rspam-User: X-HE-Tag: 1741699119-42759 X-HE-Meta: U2FsdGVkX1/s7kfeeAMomUXvuPnnF4mnCg+z+wgLU1DB+hpjVflTybI1cwPRi9SwRnw8mcLuJrkSWNgXQL7YGrKCjogLvlUGKmkqAjKKhYflK5uPq3hIb7nVCF7Zyxu64tIzbeTkjLY6+hfWRQrcHs/NFWTS/9lGOFqJ7Z+zdzKqEsLxeQpNs9SirBEcrWz4kx3kWvbZjVKXaE41MlmuTmJtxq4Jm/wDd3CLRSEtxh6wlI1u/eXfH+rUU9WSaPti3qkvUNRQm7Ws+eEGsu2t1DVKlIqHH7IacFmW8XX1lhdI9e3xEMPcJ3kkEQeGJHXQhD5C+3jFYoJKtvsfifvm62jF6UCpjKD46OhzGtpTagudbRYidakzYKOLIPXKglfnqQqzvR/i9Cdt3C+0h2nBb5guX0DbcdlTX2XJTmheklC5l4aDR7bdnZYKKP2QSq1kzKBSxQTKAivzXxtzosfu3M1DsqPA1ILMa58Em+v7a0bHMs41ASA2XWUy0g0xFx7JnwrYy/kBdddUPQMQwakYWw/pAlGbr7EuxsNsp/yRkKXDRGXm9QQWJrysiXCVba6cAm9CyYQwsO3UOy+dlGqQsTXWb631Sphhvgc/AuqL6w1+h3i9fGGbQUncGWFWJ8p3zOdtGkbI9F+8THsRbl4fHYl8T1wKUJkf+1uY66L13brCaLoQc07cUvVx3aVRX7TOZwKG+DgkfS7y4z+L8gFQhDVJUahOgbapXwTD0R/414YfrHNwXHzEq49FaUxkam5fpDXqsipYY7lGxc/sCMugE3mbiWTQUnhFQ7YpEL1xjMAJ0C4dBxbNlfOmMqIRcMMtalMXFfzR0zk7z/ZeKObmM+RG6xlCLY+zDFtn+zLJV8odSl4tjdAalCmcsEiVWdqnK11kT8JjHce4Qtu7ZCdRxeVIYMDFs2LVXa0jts1Y2RIZpvJgxNYJZS6jtTxjqPLjHp9n5fV1KcG//iiAZnA F1isznKI /AiEqNiHxl5TE532WISsmzIv2xw85TnlOX1Q8J2iAiBlAgfAr2sDZqp2WWH7/77Q5B3tf6Sx2Gx+WOKfJHBid/QAQNPGymlAEbNaVZD19zC9bR7YMTh10JEp4jP0rFisAITSBdg7K4X5v6bVZG6n/xaslbTsGHKHrNoxVugM9zU00Y8qdvFdarT+hsUyiit0tna2NJ+e3xdP92AB4o+iP/RrUPd+Qe1yORtGDJISs5zWuK1Zrmfti9UQhiDPLke8u7Cs7eyCYs2BE6UGyTveOXmbEtxcfr+SqxbOGf3yx0Gs2llhUmmi/geuj2zsOT51PP/gsTxNlqZeGPBtupqAigM751h3x4SSrK5CE6aZl8lZPGLuRAM6Ug6JA688gVbe4FPEen/mio1qUftFUHRUavw4bLDszbl23LNpbFOkNyJlyCmttNLurS4UrGB9xZFJI0uNNlkLYPJDCb92orVJ0byPf7o7+OWzp0iq9P3krKpAsIuBD07nWFm/g9KKhxXH/CmXAv4dUsKiKWHhbvwxoi3nHPQXZ7KDFDpkSHuLeA0mHurKIc6KtEmZUSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.069259, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This test allocates a page of every available size and doesn't have any SKIP logic if the allocation fails. So, ensure it's available and skip the test if we can't do so. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index 0f9fe757c3320a6551e39b6d4552fd4874b0bf43..e86ef8cb37d00e572be8cf0ea9cc8246d4eecd7e 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -309,9 +309,30 @@ CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb "$half_ufd_size_MB" 3 CATEGORY="userfaultfd" run_test ${uffd_stress_bin} hugetlb-private "$half_ufd_size_MB" 32 CATEGORY="userfaultfd" run_test ${uffd_stress_bin} shmem 20 16 CATEGORY="userfaultfd" run_test ${uffd_stress_bin} shmem-private 20 16 -CATEGORY="userfaultfd" run_test ./uffd-wp-mremap +# uffd-wp-mremap requires at least one page of each size. +have_all_size_hugepgs=true +declare -A nr_size_hugepgs +for f in /sys/kernel/mm/hugepages/**/nr_hugepages; do + old=$(cat $f) + nr_size_hugepgs["$f"]="$old" + if [ "$old" == 0 ]; then + echo 1 > "$f" + fi + if [ $(cat "$f") == 0 ]; then + have_all_size_hugepgs=false + break + fi +done +if $have_all_size_hugepgs; then + CATEGORY="userfaultfd" run_test ./uffd-wp-mremap +else + echo "# SKIP ./uffd-wp-mremap" +fi #cleanup +for f in "${!nr_size_hugepgs[@]}"; do + echo "${nr_size_hugepgs["$f"]}" > "$f" +done echo "$nr_hugepgs" > /proc/sys/vm/nr_hugepages CATEGORY="compaction" run_test ./compaction_test From patchwork Tue Mar 11 13:18:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011879 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B28FC282EC for ; Tue, 11 Mar 2025 13:24:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7BE3280006; Tue, 11 Mar 2025 09:24:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2AFC280001; Tue, 11 Mar 2025 09:24:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CD98280006; Tue, 11 Mar 2025 09:24:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6BA12280001 for ; Tue, 11 Mar 2025 09:24:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 27204121EBE for ; Tue, 11 Mar 2025 13:24:17 +0000 (UTC) X-FDA: 83209338954.17.2D0ED80 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf16.hostedemail.com (Postfix) with ESMTP id 3AAFE180010 for ; Tue, 11 Mar 2025 13:24:14 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Ia/mA7gC"; spf=pass (imf16.hostedemail.com: domain of 3LzjQZwgKCCYLCEMOCPDIQQING.EQONKPWZ-OOMXCEM.QTI@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3LzjQZwgKCCYLCEMOCPDIQQING.EQONKPWZ-OOMXCEM.QTI@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AK0S7bcFsX0odpC5RGhRJMkWaOy0j3srCbmbQDGiiBc=; b=BiwFhyYNpip4kxMV1NsujYCf83+dPtryVTkv7VsoPPvzKK7acyU6UPetT4iXqghJ3VMtUQ Nqdv0aZSYAdYmUtcjnKi5yFWlAOyxNGDKB52APq1LrHdsEmMA3Krqiu3ew+IeNaBv6rXvQ QrH0xLTArPDTjs8iyOmRo0wJgAlofDA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699455; a=rsa-sha256; cv=none; b=I15o8jFCTpgcyWNUmL+AuBtm1M477pgT4fnglLZq77moyYCuqJIJOX6pTwaO3lxLT1/ssp 0WzCrzr6h3TueGMAlJ8ORFfS4ChI6aZO9uhcY8MUtzDuCV3ShyZcHCeu1O7xFvg6E34waH EC+QyEAi6VmFDn3dpe/jUI8V2JaZFdk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Ia/mA7gC"; spf=pass (imf16.hostedemail.com: domain of 3LzjQZwgKCCYLCEMOCPDIQQING.EQONKPWZ-OOMXCEM.QTI@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3LzjQZwgKCCYLCEMOCPDIQQING.EQONKPWZ-OOMXCEM.QTI@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43ce245c5acso26297995e9.2 for ; Tue, 11 Mar 2025 06:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699453; x=1742304253; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=AK0S7bcFsX0odpC5RGhRJMkWaOy0j3srCbmbQDGiiBc=; b=Ia/mA7gC3vlhEJz4PRqmqVmBEhu46HM52L/aM++FtaH5XjI9F78sSWkdCNPuQQzrFM zQRorNTk6MFR68P2R5F8b+LRvh9swd2u56oi8llS6iSXrmPfm8Esqg7KtbS21HAqgE+e 6/A1Gplviqhrn32AjrkGWpkqA1z5/j/8HwokThv3ZG8t2WrhXyeK5qsi3CBFrVq4HFic 8HFw+4EMrBqlQWdE/Qs1xOVF7tpmzgqyg/QHGh13jwpKcYaUQz98fJ9/1Ldqgk8Wrohs /BKcPNQi/azGLrqZL4vXNv1ljOnpgv7cluMTIcEPK9h+8orBNMV5NiG5on9BHdWGBgW7 bOzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699453; x=1742304253; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AK0S7bcFsX0odpC5RGhRJMkWaOy0j3srCbmbQDGiiBc=; b=NdBnmRXblioPFIMMRwR3ipbsT9x5MgZmAga3IFsnMKiBzV6xvI5dGMiKozNl7w9nnN WYxkgjWGHfLls1wosbeNvYKM2j8mguWONwlEmX/PlQ+ymOQLcMQhYEudEaBbDimjmsWy mCqQ/AygJcv4fK3j7p+vlgzjVSr7GkgMY59NUbnE6na/BkwGfM1kVHH9TfPjnz5RgtRG QT55zhth7n8yU3VsgaQuGOOfObPVS/vKD8G8RYsBLIFiUSuCSHEg+bezhhQGDtotlDQx jFRcw9pvKgGGtZh1l/1z7QT2YnhhB3wugGfz3rDSsTdwpqhDx/ofLHi3JJDxtkSsKGI+ 00bg== X-Forwarded-Encrypted: i=1; AJvYcCW/4M1ynqzNebL8Gv01Ryt6G3jkaw9M+5tkNIchMvAPFI96b7OXFCI/53IdPZtX9Gh3bzObbc0wpw==@kvack.org X-Gm-Message-State: AOJu0YxjCbfJCFaEK97j48En8Mbt6Rm5as2J9UqWT+iyBIrS9GD67+4X PY0bOMLgFziZy6m46oxbYOwLSlZ1iE6yG/lOlT2XhNoHPxWxd7On+q1GIji38+7VIGU7572k0Dm hXnDF8WP4TQ== X-Google-Smtp-Source: AGHT+IFnEky9E+WTZ67n4oDhD85FHBGvf1ZaUlsC4CSzVhw94LW+c4vdMdF17ZTVjJHaNu8o0hoGt9vNnRMLVA== X-Received: from wmpz18.prod.google.com ([2002:a05:600c:a12:b0:43c:ebbe:4bce]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:444d:b0:43c:fe15:41cb with SMTP id 5b1f17b1804b1-43cfe154379mr72788015e9.15.1741699119995; Tue, 11 Mar 2025 06:18:39 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:22 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-11-dec210a658f5@google.com> Subject: [PATCH v4 11/12] selftests/mm: Skip mlock tests if nobody user can't read it From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Server: rspam12 X-Rspam-User: X-Rspamd-Queue-Id: 3AAFE180010 X-Stat-Signature: 3ndb9nogg9tdgz3w436unqyp8cp6txft X-HE-Tag: 1741699454-586035 X-HE-Meta: U2FsdGVkX1+vjIbwEhU9fFJ0IEqEdhxQQlazhHBapKLfX+k9DF44QPRJMjXYtjaIOOvcmbui1NgJzc4cGeqysOOs9/yo7keZy5vXbxPe2iXmPTrt5Z7Shb3YrUeGRWG+hcOXcIC7dr9qZDerz8ilGhurdQp3Jy2oQcLXqEoUMCmSPVbKc5BArKRRMRS/9L7azNxZDX353XopDkaaWiqW3lEUI4VJ1o9Xl2oFPP45Xp5848Fx2PoBV9y4itcoVxUuJHNuIpIHs168imP0NL6A7wGVydz8+m8eXgoAjfk0hkzV5lLSyLFf/5GCg6KlP/bO/Ngf7pFa/NdoxADDwE4iQJtvX5Vg58pPobAGfl4ADbuSTgZFlm3af7UkPwXf4kM2AkTwKbXCbFLp9XhfDhg7ofEjDvGXpk82JjkVHez6l2W67eAv0tVmqHhEhSr1KZ9JhyPvvYBOuLjuCP23zJLC4DEQep5Qsy055IKjoW/hq6NYEokIiUgq37JzFezhZTrU5ADr5VsSUrNxmVKRohaLmMGn3mbUrxQnbcJbManCPajZYnbcRti2GV7i9cVNWTpWNil93uIX0uQWMmkw7wg8a7Ps4X2laEWHHKpjq6tGrbWxNPRxQ30i2NnlyLBF1vD1H66svxBBmrgh8+cOmvWc0tT+e+DevddOZM+K0pIZ8tK4aIzVLaf+61oow8WviecgkFxqsreX8Eyx2/VwQ/D95dqpqLo6J3hIROL2Zjt2GlFE9gK9s1GIqHUMVfZlxRruo2yKdcVRPZ01pC4XOV2qgjvtEEsuTX9opI5WKHejWqBNGHcCw2G4a50Jj6XMxWTZgyY3jVBAi3HDRZE8gizpWrNrc1j+zuTeNphESlo5r++LTHVkBMzFVHzUhB9uhDW3m73gtD1S+X+PwGZTY6zYl6nEXQiVDlAWxKABHGoB17nZKQseOPbg6nP+d6sYKIuiChFxvfv4wmajxfJx5tR PsElQtaS cM98C3qxc14BwozmYgSh6JSqEnpDIMmOqec/pYaB2osH+RbyG3WczIKlDVviJOFgzWCBQ2qfmMieWMJd1A5Kjguvyd3jLPSTXbZUZaNXZYONIvYjahRfwOQ6WNOXYcEfP/dFTXAX22Xu63S49VPAVyNONks1GG76kyCzA+Wd949Y/5yiBf/YSGLxygqQbq8gsXJJ2oh/U8bs+/zUFBgl3Rfrujh+GUYpk4ij6wvAlSIfs6qeJay9WM6JwkClVi62N3fG/UtWuzdTGqPPzX4dcK4jvBB67FX+H7dB+VlKH+jBIsHNHZw9/g5nkAyBlj1lKSTdECl7ATjcdG/HMcZVy1fSH1QtMjXryEQ22/kjxPWenaTB4eSWXbvFkxtVLtxfhw7QgEFlFacFRRG9SuKjPUZdYjtEvZRcshIjRbKblPCBBHB+eL7zJXwOGd30M95Ug51NHWZTVwlJ8W0WKtJyX1+QWGwd0Z0umwWQkewJIUCA43YrEzO3lzjRQ7tc80f4aMn9GXvQkEU6V+aoc/r/8f/ehT4WVgiQLBnvz0n6Snb+rGEUfx+E4XHa1Qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.161236, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If running from a directory that can't be read by unprivileged users, executing on-fault-test via the nobody user will fail. The kselftest build does give the file the correct permissions, but after being installed it might be in a directory without global execute permissions. Since the script can't safely fix that, just skip if it happens. Note that the stderr of the `ls` command is unfiltered meaning the user sees a "permission denied" error that can help inform them why the test was skipped. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/run_vmtests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index e86ef8cb37d00e572be8cf0ea9cc8246d4eecd7e..1467594b594c4fb1dceae875fe7616ecc3cd9382 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -337,7 +337,7 @@ echo "$nr_hugepgs" > /proc/sys/vm/nr_hugepages CATEGORY="compaction" run_test ./compaction_test -if command -v sudo &> /dev/null; +if command -v sudo &> /dev/null && sudo -u nobody ls ./on-fault-limit >/dev/null; then CATEGORY="mlock" run_test sudo -u nobody ./on-fault-limit else From patchwork Tue Mar 11 13:18:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 14011872 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D79C28B2E for ; Tue, 11 Mar 2025 13:18:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33CDE28000D; Tue, 11 Mar 2025 09:18:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D304280001; Tue, 11 Mar 2025 09:18:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 059FA28000D; Tue, 11 Mar 2025 09:18:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C6325280001 for ; Tue, 11 Mar 2025 09:18:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E67BF81F50 for ; Tue, 11 Mar 2025 13:18:44 +0000 (UTC) X-FDA: 83209324968.23.A29A99E Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf09.hostedemail.com (Postfix) with ESMTP id 1E0A8140017 for ; Tue, 11 Mar 2025 13:18:42 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LjsRqoFr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of 3MTjQZwgKCCgNEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3MTjQZwgKCCgNEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741699123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YKUi+ss9u14qyT/Zwiy2mGBFpcrhT9F3tYQ4X8eVY2g=; b=g02UfCvfcqsvnk2u09l8S+8YWjRjALv4EZHR7wxFUoEiJIwWOahwNW3EM9MQ+8labOzVbn 8n+0K8ljUY9rHV24oXQNr9Xcnfdoj+c9sKpuwI0lwVtey/1bgO9dzI8P6yKwtZ4kN1+0CV bHYRlXW4kvweX1hl/I/xceVvKDR71rY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741699123; a=rsa-sha256; cv=none; b=lJREOZ7/JN4tmgc1QYqXe/s7w2Nk7oy/pPdLm5+9yD/5eAnUdaFyZqinPLrpaU8n5dkYC8 eI0klfFRlZN4OurG7U+9Dr2s2yFs3wqG7Xcr6fg+X/41OP2+QfnIOtfrF4PsCm2c37AGwz 78NEgEGcRUbK5/tqrAcucVcry1W8xNg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LjsRqoFr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of 3MTjQZwgKCCgNEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3MTjQZwgKCCgNEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43ab5baf62cso38005125e9.0 for ; Tue, 11 Mar 2025 06:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741699122; x=1742303922; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=YKUi+ss9u14qyT/Zwiy2mGBFpcrhT9F3tYQ4X8eVY2g=; b=LjsRqoFrUkbinutXqUnckYUFzfrCJ4je20/3SR7Bpidlmgsc67H1tdsCLz3QteAQAx dRY4JKZLZlsivJ/dvlahc9GnJd29HcFbxjuPA2c1DGlr2N6pRNjqK/0dxRqXITRiqqkE WK7ku0ikLNDxG+bfRHLP9ZQHk56/qssWKYzU20aydaYcIBePPbA1L5M+x/GIjqEu1W+M CCWvC/MWSoyi46w1L/TaIC/+5GAmuxQPeOkq7h1obpV/pm2jW+sqeblohPjkTo9SPWIm 9N68OG/kF1579H6Lpso82SiLe0VWzMvgvq+iJagWZtckn9ggq4RY0WbD/NhDu58KDlXK hnxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741699122; x=1742303922; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YKUi+ss9u14qyT/Zwiy2mGBFpcrhT9F3tYQ4X8eVY2g=; b=SvQn1jIzGLDwqlT7Zl1dbdb+y43emc6s1/9BIqEZ0ivC7SvXCOdQuKuDzUyG7qEtBq Qxu6UfF2Lkdogp5Dz9zvhpliCnXKZS0/QPTQlF7Va7JtGO0iuweDxP4k5Y0FXYTqviz7 mCVAP799dXk2BsbaNZQQWAXRQSC0d2TSZqnL2/fA6k0hoJjowxfVCapLskKly6K7Dulj G7kaORvja6TMuNKcRCZGUZvGKAC78f5h4ys/pSqVg9iSRNvj8A2vXK12Ta82LNDL7Mmg yW8towpvz9l7KTABU/jKjT8OpwRSdLy6ZZczkzNp2wAL+35+eDbN9idLk4/8GewO/16S gtpQ== X-Forwarded-Encrypted: i=1; AJvYcCVxEUFu1Xnk5Ad2Hpg/q9S/7L5JF+/GfEfTor6tFH/Ut7HZk8aRGLb9ldLkbW+yuKd18aPYyivyQg==@kvack.org X-Gm-Message-State: AOJu0Ywtou5AHzn1oD8VAKL7BulO9LVaNG3cftWCTvNPjMzounGJFPiz vRsJ2GK2q2ifdvEm6ik5bd/tWkdV5vysiHw3zA/XxbB5GopdaPlT88O71pVIPxSTdkIZ9+IwK41 Nv0G2EZxwbQ== X-Google-Smtp-Source: AGHT+IFEGPTY7Ml+tuTOynefjzLO+UpkB6moVI+rzTawpqu6Ohcjxyu/ir2TjMNVGvCGq6alb9Lb1cZqdGxcFw== X-Received: from wmpz18.prod.google.com ([2002:a05:600c:a12:b0:43c:ebbe:4bce]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:6d9a:b0:43c:ef55:f1e8 with SMTP id 5b1f17b1804b1-43cef55f398mr97810345e9.13.1741699121899; Tue, 11 Mar 2025 06:18:41 -0700 (PDT) Date: Tue, 11 Mar 2025 13:18:23 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> X-Mailer: b4 0.14.2 Message-ID: <20250311-mm-selftests-v4-12-dec210a658f5@google.com> Subject: [PATCH v4 12/12] selftests/mm/mlock: Print error on failure From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Stat-Signature: dg1qt6zj97jm8z66hf33p4htafrmfssk X-Rspamd-Server: rspam05 X-Rspam-User: X-Rspamd-Queue-Id: 1E0A8140017 X-HE-Tag: 1741699122-243322 X-HE-Meta: U2FsdGVkX19Jb6AY+LGZhABIvE1yiNgV2BOwuQGNJ8lZi5gnkVDy8RYlD6j8a9ZWf0ywqA1k4ZrOcejOxCfvX3f6kkbZOZnwfEqcgZYRvF5JqNquZseuTTHeBNbHj2HPTpwGXmuSygSws4GT8oB2OEKPPMyXg0aJwtBdAiWzaZG9nm9pzhsepAnFFfRmbKLdUH9rFURRMUKt7c5SoudUDzeCts40ptYc7l1uJQsR/neFO94ByGAZTgtog54+312qrNXs7ACYV3k5oYRYtu1Gl9M5zzn6fyhFN3fX3gZ00WOIA9C534QavZPY94c2K4LQSriJgqWYt9RM3QAv//c2u0VguDvDSUrfNTycKL/Ur7XUfJRgN+LpxONVivd+cq2TA7+aL0knUN1fb9bFjM0cxG8tNHtIg4c/ShHmRdUgdUZL03j9bLWHaYNvAsgDeKxyYz+I1I1JXj0aJFIq/M7JFGu239OsP1YrfQXK5RxrJLkyPKWKxiBo2RMIn4+dWAF+iO98SQtd4+wpAYklleWjCouMQY+zJD/zfF7mn0AQf37zJuECRojOR0deExytuIJRVwVI9Oks7OiyoQGKdF6Vxle5YWV+QxC2peq5FdU+D/alf5fSX0v+qmFtxRWyjbL4r5J5EVmzT+qzbQ45rEkSsk4u3Pak5Zn6YP42gW3vbQUq/VAJFSgRLB41bBJZ6DJ8EwlpWOhnYC0FGodRdF3NaeApO9Ryo7/hLWZ0uW94h7jPRk4pAILJAOkKewZtRlLJvETO8/IKyw3Z3XdXq3eUn8cVJZwuroyzELFlldzP3Z/cj8PgNTCCEci3+ilIVj03CdcZlOLFizzLYLf7PCF/zzQ2TqrDh0hX9edRX965D6KUy7lNPG1RyjMism2O5qd0XCbeMyYox7yaVJpiKirBJG7HJGTMqSLmFLz7RCPyKahF79t3uEC3njbM5GbP+Btnrgc4KCgxngmUBfL4DdU nvAiRAOy G0PEysbuZaHCURUkcLq+jkKoXTljgMIDb2NJk/IPKyKMh+N0pBgv0rnSU5h1fppKEKxUGvuszLG92IX4rTus8CGN2zNyFa44AEbn4HnYigO1sjGb/r4dCczWVH4huKOUwZ+6cAkgwiMKIuPr89b5DNHTobKDZtcCj6TRh15qqin29RU/ZiiPSfADIgoBSgaJSkK79ecmKzyGx/Hzju8M30Zjp9Kr4ztbel+kB8YAp4aM0nPeNkfYUtFXChIZAT/S1BeuPuyOq7NkU1jWv7yj+UEXlvo8pTkyPPEUVG9XI/PevuyWM5caazUrcU2HP0lO1zC8dfWgG5joqZzCaj1s0QHLTw8ZNXl4fVKuHRSMnQY0ADqS8HLX1vt7vbTGUEw9mDFv6iNU8ulH9YJOw2wUVC0ulRLjLQQ+sZ5Ya34+C1qZmZyUSL8ADhI+ozkeql05x1yHlKXBKGxNCA9L91K9YdTMMzUBhKvss8aR+xWwUDzSz6+2jd6JiIVaq2TNrEVP2vSxjsa2wLBVysBSjr0G6GLFmCXbTdbNiYVb2h9iyRBZ5+4XzX7ryMnNZ7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000228, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's not really possible to start diagnosing this without knowing the actual error. Also update the mlock2 helper to behave like libc would by setting errno and returning -1. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/mlock-random-test.c | 4 ++-- tools/testing/selftests/mm/mlock2.h | 8 +++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/mlock-random-test.c b/tools/testing/selftests/mm/mlock-random-test.c index 1cd80b0f76c33f04ef01f4dee6602f28b6a7c991..b8d7e966f44c67e5606d384bd660e5a4e5e8fda9 100644 --- a/tools/testing/selftests/mm/mlock-random-test.c +++ b/tools/testing/selftests/mm/mlock-random-test.c @@ -161,9 +161,9 @@ static void test_mlock_within_limit(char *p, int alloc_size) MLOCK_ONFAULT); if (ret) - ksft_exit_fail_msg("%s() failure at |%p(%d)| mlock:|%p(%d)|\n", + ksft_exit_fail_msg("%s() failure (%s) at |%p(%d)| mlock:|%p(%d)|\n", is_mlock ? "mlock" : "mlock2", - p, alloc_size, + strerror(errno), p, alloc_size, p + start_offset, lock_size); } diff --git a/tools/testing/selftests/mm/mlock2.h b/tools/testing/selftests/mm/mlock2.h index 4417eaa5cfb78ba2bb0f51d3418c9b768ff0fe90..81e77fa41901a095cc041e05d01da7dffbf2f4fe 100644 --- a/tools/testing/selftests/mm/mlock2.h +++ b/tools/testing/selftests/mm/mlock2.h @@ -6,7 +6,13 @@ static int mlock2_(void *start, size_t len, int flags) { - return syscall(__NR_mlock2, start, len, flags); + int ret = syscall(__NR_mlock2, start, len, flags); + + if (ret) { + errno = ret; + return -1; + } + return 0; } static FILE *seek_to_smaps_entry(unsigned long addr)