From patchwork Wed Mar 12 09:05:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14013128 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8D53C28B28 for ; Wed, 12 Mar 2025 09:05:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 35D0210E733; Wed, 12 Mar 2025 09:05:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="e9zdoH5X"; dkim-atps=neutral Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010011.outbound.protection.outlook.com [52.103.68.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6484C10E733 for ; Wed, 12 Mar 2025 09:05:53 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GAADVHF/0GAON4/L3+eIEFMMjelSetNPng2pUTMjtMVFlfh8TUrO+3AO1Lv8N6yA9Gn5jZhOTfXodJ3/VdzocoYkoXGvXB/J+Y511o5hwiUk53apFopH3L30Ywcjh9/0zTYQG2ENzYPhIT9H35hyfmBHmqglFW+tnBOS+3HR4FjM06mX7E6aZ9WyfB58coZcH6mJF7JqZuyw3VFFSNjwuOo/pejllf6OS9En+fKIBC606LsB3cxjdRQnZYCQSv5iglfqwy9YiYJqfMYEa3Onwo9WZ5NC4tZs0kT6t9j+MSZ8UbEY2j+TIDkkocl8UBbpf+bcZnLydUm26LfSP5sp1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/pJqLbtD6xmyotjrr7f0gCRaeWGyq1wlx5kC8RQdDGs=; b=UEctUOoPbHZ4NNrFv0pZrz+rNbY64NZ+QpdplHpx8eWqhdIptjfQVaQcy1YUJVndHFhyNsw+Y2g10eeJa7iFY+YrUUAT8dbGNEEvA2o3ZGMIS6cqa9zCTHob/naSQxMRbbaFEadUlmV40l0QBpLD3WlbCggZSNkvU8unS0/KLRupECa8bAFTbLDXPHJIrY96rVv7XC9VaxfLuX5cz/L8zrnKKjfyXJ9IaVtFTGUs8VngqWiU3g55mdQerBNAIvYURAdHmaOWXfFjWzkCVrwJbLeIqlYEODrH8rBfTRI5Lh+u/PLKMchmUD0OBENdl8qwharwy1LY+W3S0PNHgPZIbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/pJqLbtD6xmyotjrr7f0gCRaeWGyq1wlx5kC8RQdDGs=; b=e9zdoH5XzXCVVpnKpqNu6crHkGZHPJ1fZFZaq77K6m0iwxQPZ15X/9NTvLayUJO7iKVwsw8tkrDst4R1kjD2JWMqlJzyIeZWQgfELLIyfJuwULTiCW4nZB3APeyYzHLyIr41hOYyqLYG1vjJQvntRx5tiLx6l4hlEljcsyeEymphqtlqswiqxVrTMkxK3yGJxWNSg2AkGE9UribiuvfM/sAr1RKSQ5PVEAHkYa5IwEsrd4jaw85P1rNbRBxfINORdnRJKzbSbBtjmtsF6r5UitFeahxLEL1Z+R6bl/2HZSR2QuM5PkvY9ub6HIoHHaJvB+p1jVvLb75ngXvwmzZdnQ== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN3PR01MB9981.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:151::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.27; Wed, 12 Mar 2025 09:05:38 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8511.026; Wed, 12 Mar 2025 09:05:38 +0000 From: Aditya Garg To: Thomas Zimmermann , Aun-Ali Zaidi , Maxime Ripard , "airlied@redhat.com" , Simona Vetter , "andriy.shevchenko@linux.intel.com" , Petr Mladek , Steven Rostedt , Rasmus Villemoes , "senozhatsky@chromium.org" , Jonathan Corbet , Andrew Morton , "apw@canonical.com" , "joe@perches.com" , "dwaipayanray1@gmail.com" , "lukas.bulwahn@gmail.com" CC: Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , "linux-doc@vger.kernel.org" , Hector Martin , Sven Peter , Asahi Linux Mailing List Subject: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc Thread-Topic: [PATCH 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc Thread-Index: AQHbky3sVCTho9z6wEy4WLvGD6MYHw== Date: Wed, 12 Mar 2025 09:05:38 +0000 Message-ID: <376C9BD3-2F41-4511-BE52-1B8468FE2CB3@live.com> References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|PN3PR01MB9981:EE_ x-ms-office365-filtering-correlation-id: 4b5430d8-f1a8-4979-8dfb-08dd61450ef0 x-microsoft-antispam: BCL:0; ARA:14566002|15080799006|7092599003|19110799003|8060799006|8062599003|461199028|41001999003|102099032|440099028|3412199025; x-microsoft-antispam-message-info: w7St64aj0MRXZgXY0f8JbBpC3cMAe8lz0sGePf/HoJz+yo5HA88nuPPBTRVAmEFk1FLiyZLLpGF695wNqccXxNgu0W07jNhKPT035y6oNbekEFmLca2MESQJtRBof+jmQOzvrGd3brM9NXJY66hQVdjwsUV1ftn3I2zeLPwWIC7eDDeG4A+Z26IBavpNwyG2cKexxYbZ1Mxvd/jloxJm7eWSB7PQV344NLh1iEmylQKkSR9rkLTFZ/r3oJTWHj3DxOag38dgIDqBSbj0ZHnBCVrhDUvSJBY7KZoKizrrXJ1Yr8DB5CfhtSPYaT/9NN/bC4DCOqFYXAlMjKZukb6apRVQCmUnyMwgMGCGX17cJzPV4HsSqI0Z1G0GWzdhfeKuDXJqKfJvdcYwyE+NiWdCSvZyHK+tfWzSbERSD7RytaONXDhVQxcDsJFE89jVk646GfgZejCcdILTT8ZDl54bcDoit6v7hC3qRpyXfSCbA06jcyMB7OSf7Ywg3HsBsJxJDzXNMNFQr1iJYlsTbXW0+cYMYodwmMr6BXcBJXhz8LSoF+3DcF97i6UpxWYlrUdUBwn86Vd5Vb7E3QjMSPALbHfFhLAmRis/yGRzsu/7IUtrqvVM6QZoLYsirtClXfa9au7oLRuwoQwiZ1vOvvHEDzgzGLPsjKOH+bHnFkaDlN9KXm+MU6Q4ghqO6mi6C0PEEP2E6LWRT1zDSshqo6iF0COhJ1aNCThqidRb7qfF1AqM2/xv+PsSbPRCLMssXQhmr+XqFmoyQqGohPDBPhmWEdvK5DkzymNqE8FUQYb38PKL3QkLs+5eskJjDjxVsBt7CrJG3YOMeTWTwhXRHu788Rwa/a+u9TCWPpf6A0MWWCQwxwFAoF3k+VYEZmXSeFT/QiuHDR9pGNpojzwGdCYMGjQKXPwGGcHLHqIbwqM5h7kAuLzzaey+uPJgkfkdw/CGIgHvbMnygIdwvGsU1uQpXM8P24MpU7mVLPjGgA6plvPeB6HvlkWxRZigpSWeX3p/5gSUMYVEQsx/QpTJdKRRzxKS5hKIHHKkm45292Lp1hKWc23T9R0csmS6xOmgCj45+LKNVQ+hbjxXLhPmqXTDCkR9gFjM3CWVo+2f1mMTSw4= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: jg/Q5TVww4cetzIzkLvOyzEq1lNlaNfP2ZV4bkta1g8RGtgI8gCofYEx44M0Mh0iaxR6NdDmr6Qjfr8zHu9dSLE2Zs5ZQwiV808B/BtiaxiLUn8vT16UnktW1NIg4ldWOSQUJifXnTYtrVGzDfBD6v5KTSfZWLx3v8fdzlSfV1wKi2ZzViMe1d5otG1qEjUB/DdhNU2tnEoFKQEu9yDm0XJeUeosgESFndOaqOYRxTS/WeOjJ6vUpyyCZ+jSZ4tzl2HMHe6dmKWdqftI9lFDiyIvLNnghaENMcoDi2kr3/46CpPrXQScB/M5nwBJpCu4VeXR/tEVfbCaGLA0A8a8UXEKbU8drihkWw6vB+APCjHtI7nO40+dwJSNBAle3NdYaKGLYdh/yzCwcwpNe2+Yl7Dqh6B9OoFbBfpYDFclJcnZaixPH/1QigrDEiclkoChHS75ZtSabxdfDtGI+TR7wVXQD2Sobb0CkCYiFeoi9quONo/t2IzkM2qOwg9S2nS9lJA0PyHre+C6QcRIk9f5r+x++JN8qkjVsQV10ndmJVdQO9EtQauUOfXJHihI9og+ovSaznaX+iuAHid1DJR1xTABhID0gGsEjKhxPZ3LBzHthV8QCV4dqke9JXw0fPO9zmdvTTg38Jlr4oILH8HD/+j4pDuT3xwb4tocJ/hAnUQuGl65hy8fknnW1e71DmskjbitUbcM+8Ae2TnbTInsVpwpWUBHSHl5m/4tXZWZw/lUs45TvOyUo7IbivskejHwYEqPDjQ6a8TO6WlpBabrvy0EPaRtY09xMofq2bKadfBuYlQEY+CLQA0bw422aDvgajDpuflzkn1WuLtJFpoSzgY7uO2yEiPohio5zLJ/vOT2xSwyP7/cykC2LQPkn4xZM5ViQc1SuA5IPWZZ7k6TN53RvRyCYvQX7LpDB1OTbNZagPp5NUJdH4hROEm6UT/gimKvas/qMPZ6q/7Pc0AEav8KzFFE6jDThRWniFyuQvTBLxhLh2N66ZWvhT3GIOQlYrcFnk5F+BFEZGvSTmZHRF+RH/kd9pZOUNzDZWjYIF9xuihnMocUCKVOb+n2ZyyaeKUcqQqB8zu8QhEHbZE4iDskrM7/hGZA+RBCg2rXhx9n2nOc2mcZs4Gl3pDIyJo0rjMUNqUbq/c9mp7DMfFU1vuceyNEyMl1phb+ZXarblhHgVL7k0He709UNSsL4rdnYDj6XMSSGf7a+Yv3QwytJMae4ff0aASdC1ro4jVayDbY2drUgURs93XX7cf6MDk+dqHhxiPstA9a55DSsMpcQE9OSZBUEad8fSkbMnr0AFrUTg98kxXzTWFZHQ7MwDel Content-ID: <0039A4A56758C047BDB11B805171E318@INDPRD01.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 4b5430d8-f1a8-4979-8dfb-08dd61450ef0 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2025 09:05:38.7676 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB9981 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Hector Martin %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but it's useful to be able to print generic 4-character codes formatted as an integer. Extend it to add format specifiers for printing generic 32-bit FourCCs with various endian semantics: %p4ch Host byte order %p4cn Network byte order %p4cl Little-endian %p4cb Big-endian The endianness determines how bytes are interpreted as a u32, and the FourCC is then always printed MSByte-first (this is the opposite of V4L/DRM FourCCs). This covers most practical cases, e.g. %p4cn would allow printing LSByte-first FourCCs stored in host endian order (other than the hex form being in character order, not the integer value). Acked-by: Rasmus Villemoes Reviewed-by: Andy Shevchenko Signed-off-by: Hector Martin Signed-off-by: Aditya Garg --- Documentation/core-api/printk-formats.rst | 32 +++++++++++++++++++ lib/test_printf.c | 39 +++++++++++++++++++---- lib/vsprintf.c | 35 ++++++++++++++++---- scripts/checkpatch.pl | 2 +- 4 files changed, 94 insertions(+), 14 deletions(-) diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst index ecccc0473..bd420e8aa 100644 --- a/Documentation/core-api/printk-formats.rst +++ b/Documentation/core-api/printk-formats.rst @@ -648,6 +648,38 @@ Examples:: %p4cc Y10 little-endian (0x20303159) %p4cc NV12 big-endian (0xb231564e) +Generic FourCC code +------------------- + +:: + %p4c[hnlb] gP00 (0x67503030) + +Print a generic FourCC code, as both ASCII characters and its numerical +value as hexadecimal. + +The generic FourCC code is always printed in the big-endian format, +the most significant byte first. This is the opposite of V4L/DRM FourCCs. + +The additional ``h``, ``n``, ``l``, and ``b`` specifiers define what +endianness is used to load the stored bytes. The data might be interpreted +using the host byte order, network byte order, little-endian, or big-endian. + +Passed by reference. + +Examples for a little-endian machine, given &(u32)0x67503030:: + + %p4ch gP00 (0x67503030) + %p4cn 00Pg (0x30305067) + %p4cl gP00 (0x67503030) + %p4cb 00Pg (0x30305067) + +Examples for a big-endian machine, given &(u32)0x67503030:: + + %p4ch gP00 (0x67503030) + %p4cn 00Pg (0x30305067) + %p4cl 00Pg (0x30305067) + %p4cb gP00 (0x67503030) + Rust ---- diff --git a/lib/test_printf.c b/lib/test_printf.c index 59dbe4f9a..b9e8afc01 100644 --- a/lib/test_printf.c +++ b/lib/test_printf.c @@ -776,21 +776,46 @@ static void __init fwnode_pointer(void) software_node_unregister_node_group(group); } +struct fourcc_struct { + u32 code; + const char *str; +}; + +static void __init fourcc_pointer_test(const struct fourcc_struct *fc, size_t n, + const char *fmt) +{ + size_t i; + + for (i = 0; i < n; i++) + test(fc[i].str, fmt, &fc[i].code); +} + static void __init fourcc_pointer(void) { - struct { - u32 code; - char *str; - } const try[] = { + static const struct fourcc_struct try_cc[] = { { 0x3231564e, "NV12 little-endian (0x3231564e)", }, { 0xb231564e, "NV12 big-endian (0xb231564e)", }, { 0x10111213, ".... little-endian (0x10111213)", }, { 0x20303159, "Y10 little-endian (0x20303159)", }, }; - unsigned int i; + static const struct fourcc_struct try_ch[] = { + { 0x41424344, "ABCD (0x41424344)", }, + }; + static const struct fourcc_struct try_cn[] = { + { 0x41424344, "DCBA (0x44434241)", }, + }; + static const struct fourcc_struct try_cl[] = { + { (__force u32)cpu_to_le32(0x41424344), "ABCD (0x41424344)", }, + }; + static const struct fourcc_struct try_cb[] = { + { (__force u32)cpu_to_be32(0x41424344), "ABCD (0x41424344)", }, + }; - for (i = 0; i < ARRAY_SIZE(try); i++) - test(try[i].str, "%p4cc", &try[i].code); + fourcc_pointer_test(try_cc, ARRAY_SIZE(try_cc), "%p4cc"); + fourcc_pointer_test(try_ch, ARRAY_SIZE(try_ch), "%p4ch"); + fourcc_pointer_test(try_cn, ARRAY_SIZE(try_cn), "%p4cn"); + fourcc_pointer_test(try_cl, ARRAY_SIZE(try_cl), "%p4cl"); + fourcc_pointer_test(try_cb, ARRAY_SIZE(try_cb), "%p4cb"); } static void __init diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 56fe96319..56511a994 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -1781,27 +1781,50 @@ char *fourcc_string(char *buf, char *end, const u32 *fourcc, char output[sizeof("0123 little-endian (0x01234567)")]; char *p = output; unsigned int i; + bool pixel_fmt = false; u32 orig, val; - if (fmt[1] != 'c' || fmt[2] != 'c') + if (fmt[1] != 'c') return error_string(buf, end, "(%p4?)", spec); if (check_pointer(&buf, end, fourcc, spec)) return buf; orig = get_unaligned(fourcc); - val = orig & ~BIT(31); + switch (fmt[2]) { + case 'h': + break; + case 'n': + orig = swab32(orig); + break; + case 'l': + orig = (__force u32)cpu_to_le32(orig); + break; + case 'b': + orig = (__force u32)cpu_to_be32(orig); + break; + case 'c': + /* Pixel formats are printed LSB-first */ + pixel_fmt = true; + break; + default: + return error_string(buf, end, "(%p4?)", spec); + } + + val = pixel_fmt ? swab32(orig & ~BIT(31)) : orig; for (i = 0; i < sizeof(u32); i++) { - unsigned char c = val >> (i * 8); + unsigned char c = val >> ((3 - i) * 8); /* Print non-control ASCII characters as-is, dot otherwise */ *p++ = isascii(c) && isprint(c) ? c : '.'; } - *p++ = ' '; - strcpy(p, orig & BIT(31) ? "big-endian" : "little-endian"); - p += strlen(p); + if (pixel_fmt) { + *p++ = ' '; + strcpy(p, orig & BIT(31) ? "big-endian" : "little-endian"); + p += strlen(p); + } *p++ = ' '; *p++ = '('; diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 7b28ad331..5595a0898 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6904,7 +6904,7 @@ sub process { ($extension eq "f" && defined $qualifier && $qualifier !~ /^w/) || ($extension eq "4" && - defined $qualifier && $qualifier !~ /^cc/)) { + defined $qualifier && $qualifier !~ /^c[hnlbc]/)) { $bad_specifier = $specifier; last; } From patchwork Wed Mar 12 09:06:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14013129 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 522D3C28B2E for ; Wed, 12 Mar 2025 09:06:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF66610E73A; Wed, 12 Mar 2025 09:06:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="FNQ0i+Y1"; dkim-atps=neutral Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010000.outbound.protection.outlook.com [52.103.67.0]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4875710E73C for ; Wed, 12 Mar 2025 09:06:54 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rfd4gcQKLyZsTX2GifhnfLMTCv0svcL/BHpWIMxywoldifjm1k4+E3+vE9IYGo7mSsmEu0VqoTQlX4bNysRey1NqujdZQRt+dy0EGM5J3SKK48ROp16j2BYpkP9SIp8BuKH+8nnOMKzk8+bqqkUK1HBGyOw1jxL+qTJhp5DcDk3/REcWJkQPmQ/1+5vWKr4p+P7+HdKThASTIneNj0lhPu/WkK++AcZqXXmCtl/uhaOGOCBdk+jS/Fevd6T50+3EHCMTJf/XLaxfFEoQ5JU4NRWStu5KNokLD8qE3T1HQV7G+y33JPcaCVKfRmq+YzscrvAUkTjoKrcG/Z6NC5AV+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PWytK++w7efVge2S3HCDfNc7xFUv7xIt7O1G0q5iL4I=; b=vud2i8XGlyKDEVreERdC1LQgH3/BqHaKq4K//z/FJcEGopZiWBj4PJ1gtPfwIodlc7MApZSmtGRLks7Hp5AkjaVXj/X5CYTybDIfCYINHKb4oh86PLRxivU4O9VAzKYbkGeydrYeSV5McKE7GJLlyUMY4Ct7sL868EVhhovglG4mksOX8d/Qk8Pka69ACYSKYq5cpU8JmkOk9T2BFIqc/CBSLFdMaP8QwF19mOZAGbt8d+0fajqFysEu1QKl7GeDEncF1/wA0cgfYbDfJS3JW0vJPUuP0pKeeClw6rn8bv8exxbpkLgVdZTFaTgC+SxUDdTTP+wp0vPG0WkW+6SOlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PWytK++w7efVge2S3HCDfNc7xFUv7xIt7O1G0q5iL4I=; b=FNQ0i+Y1+VPVPkj7SHutnXpMR7w9CG55koqpQX3Uy09//9z3XUzhoteiyr01bbcM/kgSQOWw7xRZV1M7YE8kqf6KBTH6Nx2AXh5G9apOu2ZH1y4LKRZMr+FRK6FH2emHbjv9JLFkFvTSbA5DULJJmwWwRSwGw8sP8DOABSq9Z4tN5shpOqfTjr5By8ELvjRgSiQSicoXCrRgRkmIAAagbGYjw7L7IXmm92HXrcQMxBwuxmw3tU9eNOqo9ca6dWW32Fx2isqH+ocwLleUQwlldwWRjShJa7dOf14gKRdqq2nyPz1PuDwGXZuQ8Z711E/ti31/8t8lH6JbKJn9kIwE4A== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN3PR01MB9981.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:151::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.27; Wed, 12 Mar 2025 09:06:42 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8511.026; Wed, 12 Mar 2025 09:06:42 +0000 From: Aditya Garg To: Thomas Zimmermann , Aun-Ali Zaidi , Maxime Ripard , "airlied@redhat.com" , Simona Vetter , "andriy.shevchenko@linux.intel.com" , Petr Mladek , Steven Rostedt , Rasmus Villemoes , "senozhatsky@chromium.org" , Jonathan Corbet , Andrew Morton , "apw@canonical.com" , "joe@perches.com" , "dwaipayanray1@gmail.com" , "lukas.bulwahn@gmail.com" CC: Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , "linux-doc@vger.kernel.org" , Hector Martin , Sven Peter , Asahi Linux Mailing List Subject: [PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc Thread-Topic: [PATCH 2/2] drm/appletbdm: use %p4cl instead of %p4cc Thread-Index: AQHbky4SdzBfIMQKI0KeiKFo673KWg== Date: Wed, 12 Mar 2025 09:06:42 +0000 Message-ID: <33F3F7E2-24AE-4F29-9053-3B502D075BA8@live.com> References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|PN3PR01MB9981:EE_ x-ms-office365-filtering-correlation-id: d9a03da8-9340-4d3b-8bed-08dd614534d3 x-microsoft-antispam: BCL:0; ARA:14566002|15080799006|7092599003|19110799003|8060799006|8062599003|461199028|41001999003|12091999003|102099032|440099028|3412199025; x-microsoft-antispam-message-info: 0IkeCQEaT+5TqGNhQUnL9iwHKeCeEeMy6VBGJkLSKkFKh2YDEKSHCBwM3y/a3FVDhbGEl5t2BdtM6YanjgKqd6CBOVDyR1Osly/1U5oJ92gBy6SgSeymN0+km/W8pfiIfzWP/eRpS0JDAGXHkNJe45IytVTVFyNZ6kx5/3bIuf5GekVp8iP2cKH0vb7T2x0JqL2ASNBa/9f4jV9RUz8i7WM3VAYkG9bmnRQr8mxKqJOz8Om6oar+8AdQjVIiPoQzhVRuBJdDDjgKYjc4e0LCgNeaIzp79Gvz89fzxlwTEoqZsu4akItx89mzZnPkvGXnA8cXjdbayrsEgvg0VB0Pfqhva5j/R0Ckzf1GoHuokkPKz+G6d6htwPZGhntE0MRIiiQOVal0L7GivaXKivJBzAP2KT/MrA+msnJ14l8kIuawchYB0yXhrHQHitGlrylWvk6S1jRstgxTVjiHm5VeOYqDNmrPynh24o2FQNTchUhP5tg1yQKnOylaLrrgLdWFhp99Ugdz4NqtNCKVg6Q+95LV7Kqj9gGMTyQhKqlEalGpzfWJSvF+/a18opYDP2ruJ6GPykmmCs7ij73Hox+wOhuOw8Kr+LcW19EM7aeoNgC6AUUwNaiosJS3GzojnLaupCpcN4i1mcFhuTf01h0RtvxLoPI+TA7cbnCH8fMOdd2eJVLpuYtwJWQcfRcfCykFbLUFC2Kq8XeYaRu7tEfSp33Q3786CyWjg1vdxi47xrDBLnE1737992QUiUfE02IU+DAc8jfbcvrBfMqPit89L312D5CXW56l/FCGE4deGb9hD+I8Xv0XHQm3Zx/OqgBxpFy3l3Ik819BsbjbhBq+xGUFz6Y9PBlclx+twGgOmDIDfzfU46Ag/9c/7TvaoHsRRHXIA2bad1r9rEVModzUu9GChmJuB5avX7/lmmzwfhEjqjoZAFN7yjYNjnSOWu/4rvp5k6Cu8Zms+eEBz7lkcwmLxMDnQ6+LCd3z+M3WOEays3xSKMviA8qIs9Q2ybmgBm9CQG7gj+x1iSU0MDareVmGg+jH0bKahSercmK/DuUmoIsDunITHPqvhkFAnZKJuSsRAZU3QaKs34PHwl/nTm12IQA5SqMwlw+PEVaj8wI4HXRrOnh/9+x29FbmteXA x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: 6H8SSlEyPGktk2PXzl/SWqZVKsI/2VsZRE0kpSP2KZeJK9kEiw93jY8xHMNbsFgSA1L9aP2j/Iu4aEAzcrAduZMp7rJDK865PjymIdZLGpeHOz9Ur4mQZFBsRtVJH2hGVJ7AujRSRl+UkFYzSUVG2UDLXavYlXBqIvSYnbxVptLje0pd+ad8gk0r7wz6XtDFW5ryAIIFZbj0eK6MBWZSjosWPs3AbLEohBKHVwXoL+APmDPU3sV0kEJeqt73r52kw5V8ihXVa42SUkp2grD+HX0+KjKXh1TOvYCfTFWJFoYoOtbbEntYrF2+thDW3I9RAPEKmqw6P7dhRP8ENJHoa4k2kT0ygnq2QIvuWJEmZca3R5kUO6iUSZPXjLtVQbqVN+ZITOPy5TsIAYwYDGW3w/PZAI1y2Lne9G2WP5tXQMY1g8RqLg8ZWxZsz0VqgPpG6MdG+aWFLaUKnN4KX5+YFWfTN6NK9LnA6mn1vBn0A9AGJPBqL2qk2CLpGp+zFKk7yf2ReKRZ2C3nDucOlZg28Kc2YHpcru6j0O0keK8KfP1PGZg0Bidn2ezxR4JAj2HD5L4G71FZa57QR3KD/soMpiMQghj81zGPiZqfj6E3Nx9T92gNLZhyG9cTTFyl/lSsylO3GE9FLVEYOgWrgH31l5O46hymoh7kGGrKCqCdrinKKWLDwZQgSEgvj/mhTGkLMR28gVwUW39EQSaz++DyOPDfMldc9DjHEb0DO2nmHCAijCL+4d53mXCvs6RNnHGCb4Gyqr1l/NlsEz4dR0vTN4KssecsnFOdT2f1pU4wQuvDreORnILvqB3Zd7rsTswdxYsXt4PF4G7Nj0+esWHK2KhCdyfk7zJqdaxoYvH4wtKZsYLOeSAa8ujrXXEoMV8IKMoqKC1KA9F+ASVZXsYyrHE9grLAIzS2abAyujqDJqkf7Z2yOfC/OwKzPgGHKEb4FyZ56ehUTBWUKEjthK9yjAvuipFuuDkwCaFaJsqfvl0X68iOMc0IL/9Wk9Af447huUdZQ4AJ2uRL1HoZ1Y3fFeoP63MRCaVlPhccyV2b4FArjP2M35VFAPCexMfkj5IrovE7bk+jyfRylz5MyDGf+QQDWgiZyPfIkEhGLg0aas86fnr5EY7TJ7s0kb41SCp8eAn2J9CRnkU7kZiPIq32ybesTQQmb/vZdBCPEqYw9DO5vBle+Qe0bQDTis29fDynmfyPpDAv8HbjmezrXoNMRHBrO3e9ZJDEvKaRb19WIUuwCpESqMz1ZwO+YVVVN4aRwa6F3CynH8jE2OupB4M/3BPaIg6RSQk43WG1isYtexEGc3IO8+j6tlfBYWza8Yje Content-ID: <4831D0BA280B6E4697AE095A0C14C852@INDPRD01.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: d9a03da8-9340-4d3b-8bed-08dd614534d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2025 09:06:42.2799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB9981 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg Due to lack of a proper printk format, %p4cc was being used instead of %p4cl for the purpose of printing FourCCs. But the disadvange was that they were being printed in a reverse order. %p4cl should correct this issue. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/appletbdrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c index 703b9a41a..751b05753 100644 --- a/drivers/gpu/drm/tiny/appletbdrm.c +++ b/drivers/gpu/drm/tiny/appletbdrm.c @@ -212,7 +212,7 @@ static int appletbdrm_read_response(struct appletbdrm_device *adev, } if (response->msg != expected_response) { - drm_err(drm, "Unexpected response from device (expected %p4cc found %p4cc)\n", + drm_err(drm, "Unexpected response from device (expected %p4cl found %p4cl)\n", &expected_response, &response->msg); return -EIO; } @@ -286,7 +286,7 @@ static int appletbdrm_get_information(struct appletbdrm_device *adev) } if (pixel_format != APPLETBDRM_PIXEL_FORMAT) { - drm_err(drm, "Encountered unknown pixel format (%p4cc)\n", &pixel_format); + drm_err(drm, "Encountered unknown pixel format (%p4cl)\n", &pixel_format); ret = -EINVAL; goto free_info; }