From patchwork Sat Mar 15 08:20:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ritesh Harjani (IBM)" X-Patchwork-Id: 14017852 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F4D318E023; Sat, 15 Mar 2025 08:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742026831; cv=none; b=bLiJXAc0uJCH83/R/23EQEMyhvKGgc6OOEzrdzICfb4rpU/cC1bcOYB0/i36CHeMT55AZmi0yjrZXI/BjdonRnPsvcTIFR7IEUIQh4CWVGn466fxHmnW4SctmQ7/Bt4xBPUCf4lSc/5OzBWzs5qcOvQiupEAGPpUvTJJqb0NHO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742026831; c=relaxed/simple; bh=czJ60Mg0jpKXxP6obLKAe+Jse5gOjYrtu0Z6+1OU33w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RRRgzc0HJ/U+wy9UtZj9VR2xQvS3B2lYXIGB2M/QCKwYzWJfV7GkOy/fA0f4qbBgQrW0ivWpYFiJPb9nTc/mR2SX8ngYzVQT+VAeKdt/zlBdU4w8eoktnOXASj5zwaZA2hXuvIMlX6AeVqrJNKAUSy8R+1IlEpQ/Q6754p+OuvU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QhJIIsPO; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QhJIIsPO" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-224191d92e4so57056105ad.3; Sat, 15 Mar 2025 01:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742026828; x=1742631628; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Uo2iuroLr/xEVn94lcwpCquIfx88/trS/NRdQQvjLt0=; b=QhJIIsPOLuI7yEImM33yfbcNpziRle+XIR3aNC6aei+3sQmtLG7icwIs2PXEFZmGQs azD6wu3OYRDVww3ki+7toDHA+FAQNT6y1N9KOyTTf4GT9Db3aVY5AfFwktv+wnaY08Ul 3FiNl4OCANU/EkjDZzqfkpTykLDB3vhHgI28ul762OtQZp5WS7NjkimryoAvkLT1betd Yaf+MosG7+PhdCMQXIrPn17C1Rycd2F6+LkVJO+mlWGq04wSBRxy0+8MLNMcpqduHpJy yD3qp25GgjwA9hbdEsbjnNqZCW8fUjyP0ukuZ8qGRJWgVSV8luLKIUHTJF+gZMVsGs4+ tReg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742026828; x=1742631628; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Uo2iuroLr/xEVn94lcwpCquIfx88/trS/NRdQQvjLt0=; b=eRdmElGYLURTXZEVjy2SBjm4+KyB0G/oyjh9nEWwH2tvXFT4CxGjMLKV/xSDQ1ULhK 6hACPpuEhz9FaidFfwC9sP//3Qmzc+TEH5WtELzxg9gGGBBNWABcizpzWiB83IKQ0L0z u1tkkh5iB8GGfED5K2Pj+xJK0bIIlxNH01HDb7dLX9V0QHEUHN1ui/ojGmreJNdiQloo DYckDQYKCmrpOQvyMHmIDgv1lFLeeEjGTfY7w0z46WBgVSLY4KHRjZRr/UHrXJepCYLV tky5FOMK8ad8BWW2oN5oDzgLsODOJyu8mmIJhNNFMQtNs9US8p116+6Wdu0fxmrsNdiJ 6b2g== X-Forwarded-Encrypted: i=1; AJvYcCUOrajbSz4QNQ0hdkllUkwEw1DOBxG/IJFqU8JnRjEHXYhoCrf6GD6OTexBjRfYzhCxrVOZiIhJQO+SN4Xf@vger.kernel.org X-Gm-Message-State: AOJu0YxR3xirGH4Ov1l87NlNnubj5x4apNtMDiG+8qSw8SySwguDKdlo 6EGFEB8mEgR/kbP5myCaRIuxnARXP7Eyco9E+qZeuK48glUd9uq+FnSQRw== X-Gm-Gg: ASbGncsGuoK4Nv7a67n0AO8gYaaMGC3QyBCfSrJBV7DAThNKbaibqiku0kjhft71xOL p0X7kKtyxE5K2NKqnODo88tA+U65t99aoVDOuse9XHbEB4xZzTUhmQocbZDzjXXJWC540F8GUm1 PPcVHqnpuexJ6+oIxNeKr1Ti986cV+xgma57incNmc5uAB85YmWcQ9mSW5F3SqaiEgpvyGDPCK7 EVZwGGusmjKARTw2GkDXAXTso+kpnY01XdP40CnyH4UZ9dKAYmSWbgnFMBqtlD6pcT2+HGHU9dg o2y0An5fVbrn3WrdyzyV8744rSfzMzYIFzPe7k6JCXNN2BmBDA== X-Google-Smtp-Source: AGHT+IGy15Irg5VwD3E3zLDMiMU361fqg7mrfdMUkchBHWIY7U7YJyN+AWtmA3ndWUgKt9An9PDNcw== X-Received: by 2002:a17:902:d54f:b0:215:9bc2:42ec with SMTP id d9443c01a7336-225e0b14fb5mr66205455ad.47.1742026827698; Sat, 15 Mar 2025 01:20:27 -0700 (PDT) Received: from dw-tp.ibmuc.com ([171.76.87.44]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6bbe7e4sm40071405ad.189.2025.03.15.01.20.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Mar 2025 01:20:27 -0700 (PDT) From: "Ritesh Harjani (IBM)" To: linux-xfs@vger.kernel.org Cc: "Darrick J . Wong" , Jens Axboe , linux-fsdevel@vger.kernel.org, "Ritesh Harjani (IBM)" Subject: [PATCH v3 1/3] xfs_io: Add support for preadv2 Date: Sat, 15 Mar 2025 13:50:11 +0530 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This patch adds support for preadv2() to xfs_io. Reviewed-by: Darrick J. Wong Signed-off-by: Ritesh Harjani (IBM) --- io/Makefile | 2 +- io/pread.c | 45 ++++++++++++++++++++++++++++++--------------- 2 files changed, 31 insertions(+), 16 deletions(-) diff --git a/io/Makefile b/io/Makefile index 8f835ec7..14a3fe20 100644 --- a/io/Makefile +++ b/io/Makefile @@ -66,7 +66,7 @@ LLDLIBS += $(LIBEDITLINE) $(LIBTERMCAP) endif ifeq ($(HAVE_PWRITEV2),yes) -LCFLAGS += -DHAVE_PWRITEV2 +LCFLAGS += -DHAVE_PWRITEV2 -DHAVE_PREADV2 endif ifeq ($(HAVE_MAP_SYNC),yes) diff --git a/io/pread.c b/io/pread.c index 62c771fb..b314fbc7 100644 --- a/io/pread.c +++ b/io/pread.c @@ -162,7 +162,8 @@ static ssize_t do_preadv( int fd, off_t offset, - long long count) + long long count, + int preadv2_flags) { int vecs = 0; ssize_t oldlen = 0; @@ -181,8 +182,14 @@ do_preadv( } else { vecs = vectors; } +#ifdef HAVE_PREADV2 + if (preadv2_flags) + bytes = preadv2(fd, iov, vectors, offset, preadv2_flags); + else + bytes = preadv(fd, iov, vectors, offset); +#else bytes = preadv(fd, iov, vectors, offset); - +#endif /* restore trimmed iov */ if (oldlen) iov[vecs - 1].iov_len = oldlen; @@ -195,12 +202,13 @@ do_pread( int fd, off_t offset, long long count, - size_t buffer_size) + size_t buffer_size, + int preadv2_flags) { if (!vectors) return pread(fd, io_buffer, min(count, buffer_size), offset); - return do_preadv(fd, offset, count); + return do_preadv(fd, offset, count, preadv2_flags); } static int @@ -210,7 +218,8 @@ read_random( long long count, long long *total, unsigned int seed, - int eof) + int eof, + int preadv2_flags) { off_t end, off, range; ssize_t bytes; @@ -234,7 +243,7 @@ read_random( io_buffersize; else off = offset; - bytes = do_pread(fd, off, io_buffersize, io_buffersize); + bytes = do_pread(fd, off, io_buffersize, io_buffersize, preadv2_flags); if (bytes == 0) break; if (bytes < 0) { @@ -256,7 +265,8 @@ read_backward( off_t *offset, long long *count, long long *total, - int eof) + int eof, + int preadv2_flags) { off_t end, off = *offset; ssize_t bytes = 0, bytes_requested; @@ -276,7 +286,7 @@ read_backward( /* Do initial unaligned read if needed */ if ((bytes_requested = (off % io_buffersize))) { off -= bytes_requested; - bytes = do_pread(fd, off, bytes_requested, io_buffersize); + bytes = do_pread(fd, off, bytes_requested, io_buffersize, preadv2_flags); if (bytes == 0) return ops; if (bytes < 0) { @@ -294,7 +304,7 @@ read_backward( while (cnt > end) { bytes_requested = min(cnt, io_buffersize); off -= bytes_requested; - bytes = do_pread(fd, off, cnt, io_buffersize); + bytes = do_pread(fd, off, cnt, io_buffersize, preadv2_flags); if (bytes == 0) break; if (bytes < 0) { @@ -318,14 +328,15 @@ read_forward( long long *total, int verbose, int onlyone, - int eof) + int eof, + int preadv2_flags) { ssize_t bytes; int ops = 0; *total = 0; while (count > 0 || eof) { - bytes = do_pread(fd, offset, count, io_buffersize); + bytes = do_pread(fd, offset, count, io_buffersize, preadv2_flags); if (bytes == 0) break; if (bytes < 0) { @@ -353,7 +364,7 @@ read_buffer( int verbose, int onlyone) { - return read_forward(fd, offset, count, total, verbose, onlyone, 0); + return read_forward(fd, offset, count, total, verbose, onlyone, 0, 0); } static int @@ -371,6 +382,7 @@ pread_f( int Cflag, qflag, uflag, vflag; int eof = 0, direction = IO_FORWARD; int c; + int preadv2_flags = 0; Cflag = qflag = uflag = vflag = 0; init_cvtnum(&fsblocksize, &fssectsize); @@ -463,15 +475,18 @@ pread_f( case IO_RANDOM: if (!zeed) /* srandom seed */ zeed = time(NULL); - c = read_random(file->fd, offset, count, &total, zeed, eof); + c = read_random(file->fd, offset, count, &total, zeed, eof, + preadv2_flags); break; case IO_FORWARD: - c = read_forward(file->fd, offset, count, &total, vflag, 0, eof); + c = read_forward(file->fd, offset, count, &total, vflag, 0, eof, + preadv2_flags); if (eof) count = total; break; case IO_BACKWARD: - c = read_backward(file->fd, &offset, &count, &total, eof); + c = read_backward(file->fd, &offset, &count, &total, eof, + preadv2_flags); break; default: ASSERT(0); From patchwork Sat Mar 15 08:20:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ritesh Harjani (IBM)" X-Patchwork-Id: 14017853 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DB241662E9; Sat, 15 Mar 2025 08:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742026833; cv=none; b=IhkFWIm/vPdUtrIfuMH/o7t4yiQ+WH4SFCuzrh9bkmclGwoRpZYwIVKymCWwrJtpEBn3f94Ss2VcTV/e4zJb0bn9qFhDjR8XQqfJk3TvPT3NF5SwzY/svcQjFcwhiSaHLz49+PA3yvXWkaKNXbWkPems3jTbIL1EEchpf13XUIY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742026833; c=relaxed/simple; bh=S9W51Duew2XZGYenBRa+F4G20DN69LIGQozW4gp5KpE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lc0IvLF3k9pBBzZCVH/VoEcPu+Xv36w+OR4cf2iy16pD7UWhxQfyNI+6CfD+4G3tDd7O88mGtlYoWnmtv7VuAoSoruorjvBK6omg/h03395BbSPdN1nzlOwXSPclruV+SnxsuykH1pxnkbjp7ZjUfHzkdqQ5crMBJ0EsJc4vlo8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bGTrR16F; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bGTrR16F" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-225477548e1so51117015ad.0; Sat, 15 Mar 2025 01:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742026830; x=1742631630; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZDKmCtnz6WRYvJBmz518KSHy6YVJXCeesgjz9etgMz8=; b=bGTrR16F6IcjkiYozcoSAAMYAqt20lK5J5mcP+2kgg0eX5OBzS5C2SlY0AuyeTtbrF zcilkdn4fFNRT4Q9E4AoqIKaiI5yg4B7qit4rwW48AzW4KGpuK46i6EqIS413diMcsRS iWgO9QIivDeg//XFwDtuQ2PzdqVRrqt3Rqk8Z6qbH7emqkxD0izz+98PxxjDFzlG3WFn fKw+x7Eyv38nM0zPrEtWsNJjXKNOd8oUj+6OGH6bWIkkFpttn/XRQZNh6FboRLpxK4Ek 6l7/lRNCsKw+nNzx1ty6jJr8CQ4MBOqti3zajj3XBPQeNqkoXI3ploqLOxGubDA8zWl6 QAHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742026830; x=1742631630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZDKmCtnz6WRYvJBmz518KSHy6YVJXCeesgjz9etgMz8=; b=HDxf2MEGVL3r63ZJFwATLdT8Cyko8fkp/bZYtz/6bUvFoalZYfREAoMVhgB7FEqSly KdpOq2j/XbokT8SZKqDISiU6m1Q+NcmQT/Rk6f9PJjlO//nr/g5gJUx3wjG7f4iPc/Rp zV0Gf7hiV/GtnN6f94NRkRWUJi9rR4D+rx0PEyDYhGQEVn4IhWCk0nf3S3Gx6tIpczgB Z2x0fy1Pm46yMgmef38FQ9AKWBnN1HuWJhRNfJai7mKX7GaO5Iyu3NnQ3YLrxrpX9ZyZ qkL2CjfFbmLQ0wrMyaTPXeIe8ioTrjqZh5Ikf5XBrhAclNiBp+UcrL84wW9/IRFsBjGw 3vIA== X-Forwarded-Encrypted: i=1; AJvYcCVpwovIx9ewbA6ltbHmxkmz8pCFfo13UF90LzbLaQdhnrrXkVu2mF32hCD/0o0pkZHu2ajmR5CgdaYiNDxr@vger.kernel.org X-Gm-Message-State: AOJu0YxC83iyGrCQDR2VcU/3B60HeSV7GvSGSoIOwsp7mfzF6eY97bvv 6FwcXMigcJvHW5YMEskw7soCNljm6So29BGu4gDd7zazYZisq06Dno5XlA== X-Gm-Gg: ASbGnctTaN9M7v/qoSkBg3i1Z8SBwmtYBmpqO1fgdBUW9myA/6oTG3Y2y0djZxR/kD3 J33NYwCHdVzwqYFV0bkz5SxHiUwon62ozlrJqaoItIPbFZqxFSBzK2qQ8rXex9F9K3j+I2Ci2l0 8L1TVMx6luIeH1XEFF6eOXmYh7tBOGJerVX+a9acEkcyeFIDAh1op/4DFUDOSn703NvAv235T3K MaiAy7RArXuwtNh44mIR4ThhhM+1XbLMjEpKIM3HE8BQRogy2zkuNDPQYSRpu//bz1n5E1NJAza dZfQzdOTQWWaBFDPO2DePapYYe1badFWphEQBjNA4Y7EH21lTw== X-Google-Smtp-Source: AGHT+IG+sI+fAHY8ZG6LvqmZthtOA8k8bZQZOjWIV4pGGtfVDndNn1lV0QlbPxbPMwN/z+ZbosmrmA== X-Received: by 2002:a17:902:ce0b:b0:223:fabd:4f99 with SMTP id d9443c01a7336-225e0a19b97mr76195005ad.5.1742026830260; Sat, 15 Mar 2025 01:20:30 -0700 (PDT) Received: from dw-tp.ibmuc.com ([171.76.87.44]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6bbe7e4sm40071405ad.189.2025.03.15.01.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Mar 2025 01:20:29 -0700 (PDT) From: "Ritesh Harjani (IBM)" To: linux-xfs@vger.kernel.org Cc: "Darrick J . Wong" , Jens Axboe , linux-fsdevel@vger.kernel.org, "Ritesh Harjani (IBM)" Subject: [PATCH v3 2/3] xfs_io: Add RWF_DONTCACHE support to pwritev2 Date: Sat, 15 Mar 2025 13:50:12 +0530 Message-ID: <3e963c2a21a90aaf6f76eb1eec7b58267ef5bf67.1741340857.git.ritesh.list@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add per-io RWF_DONTCACHE support flag to pwritev2(). This enables xfs_io to perform uncached buffered-io writes. e.g. xfs_io -fc "pwrite -U -V 1 0 16K" /mnt/f1 Reviewed-by: Darrick J. Wong Signed-off-by: Ritesh Harjani (IBM) --- include/linux.h | 5 +++++ io/pwrite.c | 14 ++++++++++++-- man/man8/xfs_io.8 | 8 +++++++- 3 files changed, 24 insertions(+), 3 deletions(-) diff --git a/include/linux.h b/include/linux.h index b3516d54..6e83e073 100644 --- a/include/linux.h +++ b/include/linux.h @@ -237,6 +237,11 @@ struct fsxattr { #define RWF_ATOMIC ((__kernel_rwf_t)0x00000040) #endif +/* buffered IO that drops the cache after reading or writing data */ +#ifndef RWF_DONTCACHE +#define RWF_DONTCACHE ((__kernel_rwf_t)0x00000080) +#endif + /* * Reminder: anything added to this file will be compiled into downstream * userspace projects! diff --git a/io/pwrite.c b/io/pwrite.c index fab59be4..7df71e23 100644 --- a/io/pwrite.c +++ b/io/pwrite.c @@ -45,6 +45,7 @@ pwrite_help(void) " -N -- Perform the pwritev2() with RWF_NOWAIT\n" " -D -- Perform the pwritev2() with RWF_DSYNC\n" " -A -- Perform the pwritev2() with RWF_ATOMIC\n" +" -U -- Perform the pwritev2() with RWF_DONTCACHE\n" #endif "\n")); } @@ -285,7 +286,7 @@ pwrite_f( init_cvtnum(&fsblocksize, &fssectsize); bsize = fsblocksize; - while ((c = getopt(argc, argv, "Ab:BCdDf:Fi:NqRs:OS:uV:wWZ:")) != EOF) { + while ((c = getopt(argc, argv, "Ab:BCdDf:Fi:NqRs:OS:uUV:wWZ:")) != EOF) { switch (c) { case 'b': tmp = cvtnum(fsblocksize, fssectsize, optarg); @@ -328,6 +329,9 @@ pwrite_f( case 'A': pwritev2_flags |= RWF_ATOMIC; break; + case 'U': + pwritev2_flags |= RWF_DONTCACHE; + break; #endif case 's': skip = cvtnum(fsblocksize, fssectsize, optarg); @@ -392,6 +396,12 @@ pwrite_f( exitcode = 1; return command_usage(&pwrite_cmd); } + if (pwritev2_flags != 0 && vectors == 0) { + printf(_("pwritev2 flags require vectored I/O (-V)\n")); + exitcode = 1; + return command_usage(&pwrite_cmd); + } + offset = cvtnum(fsblocksize, fssectsize, argv[optind]); if (offset < 0) { printf(_("non-numeric offset argument -- %s\n"), argv[optind]); @@ -480,7 +490,7 @@ pwrite_init(void) pwrite_cmd.argmax = -1; pwrite_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; pwrite_cmd.args = -_("[-i infile [-qAdDwNOW] [-s skip]] [-b bs] [-S seed] [-FBR [-Z N]] [-V N] off len"); +_("[-i infile [-qAdDwNOUW] [-s skip]] [-b bs] [-S seed] [-FBR [-Z N]] [-V N] off len"); pwrite_cmd.oneline = _("writes a number of bytes at a specified offset"); pwrite_cmd.help = pwrite_help; diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8 index 59d5ddc5..47af5232 100644 --- a/man/man8/xfs_io.8 +++ b/man/man8/xfs_io.8 @@ -244,7 +244,7 @@ See the .B pread command. .TP -.BI "pwrite [ \-i " file " ] [ \-qAdDwNOW ] [ \-s " skip " ] [ \-b " size " ] [ \-S " seed " ] [ \-FBR [ \-Z " zeed " ] ] [ \-V " vectors " ] " "offset length" +.BI "pwrite [ \-i " file " ] [ \-qAdDwNOUW ] [ \-s " skip " ] [ \-b " size " ] [ \-S " seed " ] [ \-FBR [ \-Z " zeed " ] ] [ \-V " vectors " ] " "offset length" Writes a range of bytes in a specified blocksize from the given .IR offset . The bytes written can be either a set pattern or read in from another @@ -287,6 +287,12 @@ Perform the call with .IR RWF_ATOMIC . .TP +.B \-U +Perform the +.BR pwritev2 (2) +call with +.IR RWF_DONTCACHE . +.TP .B \-O perform pwrite once and return the (maybe partial) bytes written. .TP From patchwork Sat Mar 15 08:20:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ritesh Harjani (IBM)" X-Patchwork-Id: 14017854 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610C01EEA5D; Sat, 15 Mar 2025 08:20:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742026835; cv=none; b=hIz6JsWGDOMMrkN63YFEbEweLhQkKmJr1y/tlCmW6HYeis5N3qKPavTaVXGGaHiXTw4H05+7w2pEiiu7Lfq6Q5y76bcsqo7zDpRebDAmzSfYlbaHwU3hlD2kx7wCPaBfJWUVyzi4fJgXwd+1Wk4/9orlwnw01jQNdXLweiMPesU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742026835; c=relaxed/simple; bh=scQBckZeUdy0ISbBqgWhJXTDfjcQLLJ9Xy/AnU/E5K0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QMtqd4hRyMBsplOEmvanwiceysMt4vq6srELMVETptOXpkaXfVEmFQ3mMxTS1nWrUnBQQF+BjvvWEmqtXm7AZraWmphG0daPWBJXKRJyJC6kx7JNPlalS3QEE6gUCqyv5ncnGGignd4/CAq8t5qY/QMC05hGDSABpZ/6YjmGZDk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ax+aFz/G; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ax+aFz/G" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-22580c9ee0aso52115355ad.2; Sat, 15 Mar 2025 01:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742026833; x=1742631633; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0r7NtJ9klln0aHhk58CJYXj/8kTnWVGVTMJNGVZQtaw=; b=Ax+aFz/Gt7ehiK44GSJn4kDjVkMhtuwTHdB8x4abg54bAIq0Cgash1q5EhwU71r5B+ Vi1g1e5BEbGguTEjDa1abWSLj5fsb4mYUzD3VNk7rcuDQVa9Pz+uRAQvu4z+3g+6I/MU K9HpV7TssmOnUgNuAmDMABlRNnF19Tibi+So40bXOl8s/v/lZ6IQv7ja1ZoIe780IJYj W/poNg7uiUY1cqPl9ZGw867Txz+evkgJD81mVClUzyjwTd2rP8/gfXT/eyddSMp2E08F XBlV8U7iF6KwEHdx0m0ZipbAR0Ke8BtxBj10RikT5f/GJDdJatbiIRVbpCgzL27RLaJq vA1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742026833; x=1742631633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0r7NtJ9klln0aHhk58CJYXj/8kTnWVGVTMJNGVZQtaw=; b=iXdMeMoFcxYhdsoF39PX4pSDkrfZqJBJCu0u0w1rVNPscoUQ0+iXEJdlu3GvoGBVn7 PfM/iD6nbUN5Tg2PbFWaHgRMvVxRoesmhtnK36OWTx94G9S59Apj/5/VcOt/LUSu/2+8 waeS1rbuuq210iKGjxcz1h9F276fXqhjUb/eY7bIpyO3IvN9klzZI6FfoTHg12rNLx9s ubR2rQlgXa6KAhwB4ADSaNju6Ywk1gQOYtFKQ2z9B/Cas7SXlzCbzY1cIkkN/A8nMDMC y5UBVdx6nK+ggeXiL/ZzvkSJkvczDyk7PuQ2nfUA0oHXWYDkxjV3/mGFEgQ2+g02QLCy Lb4w== X-Forwarded-Encrypted: i=1; AJvYcCXpCYP/i13w+34G4lhCSUBFaYwLEwNpre21U+0lZlLlohz/6WoeBvdeJJ94DO+xw4NeKEckQ0GtmcuV2kOE@vger.kernel.org X-Gm-Message-State: AOJu0Yz2C48U0hxlfDqHopSn+gy0tU5YWfMvq4CUtu95YzTcCe7AQmtc YCsAeyUuHg4LVF93p6tBz6n6X0baqgSlfQjvG3/KsaM9tkTQ2xP3aZ3wDg== X-Gm-Gg: ASbGncuhUz6LBLw+PSTgNyTPfPw4k5ww0GAxLGnrpm3A677dMgZ2Gfob+gOeUDRjYCP xRJQqA+q90tP4L3rhGxGU5S/dVWImFOiUZXd8gSKUUMiogdcRpKZXASlsLdbW0QW/lCW9G1OcAY bME77/m/p39Pb9oRxF7z3eA1zemO/g0Hfa5h4BR5HmInnmcuC+OzDvK8g//Z02Fnl25jfgSzfXu w6a4/JIcuWAibf4bKVWwMd2+LRA0mw6bsgtthQFpiqct52RCKQf4DbJd3ucLJN4G9ij4uc/AH+Q 7NM/+YHnXArsw6/nzgoI5ET4eVMtKIFwo+fC0OFPrcc3E+oAiAb+TzrFiyEM X-Google-Smtp-Source: AGHT+IGK/14wNJTEiKy5DE8PsCS/c/oPToivZVbGCOUp4OzjXzRQtXhOUktxOkPAteyEy2I63UBENw== X-Received: by 2002:a17:90b:5405:b0:2fe:7fea:ca34 with SMTP id 98e67ed59e1d1-30151d7af87mr6137635a91.32.1742026832960; Sat, 15 Mar 2025 01:20:32 -0700 (PDT) Received: from dw-tp.ibmuc.com ([171.76.87.44]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6bbe7e4sm40071405ad.189.2025.03.15.01.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Mar 2025 01:20:32 -0700 (PDT) From: "Ritesh Harjani (IBM)" To: linux-xfs@vger.kernel.org Cc: "Darrick J . Wong" , Jens Axboe , linux-fsdevel@vger.kernel.org, "Ritesh Harjani (IBM)" Subject: [PATCH v3 3/3] xfs_io: Add RWF_DONTCACHE support to preadv2 Date: Sat, 15 Mar 2025 13:50:13 +0530 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add per-io RWF_DONTCACHE support flag to preadv2(). This enables xfs_io to perform uncached buffered-io reads. e.g. xfs_io -c "pread -U -V 1 0 16K" /mnt/f1 Reviewed-by: Darrick J. Wong Signed-off-by: Ritesh Harjani (IBM) --- io/pread.c | 17 +++++++++++++++-- man/man8/xfs_io.8 | 8 +++++++- 2 files changed, 22 insertions(+), 3 deletions(-) -- 2.48.1 diff --git a/io/pread.c b/io/pread.c index b314fbc7..606bfe36 100644 --- a/io/pread.c +++ b/io/pread.c @@ -38,6 +38,9 @@ pread_help(void) " -Z N -- zeed the random number generator (used when reading randomly)\n" " (heh, zorry, the -s/-S arguments were already in use in pwrite)\n" " -V N -- use vectored IO with N iovecs of blocksize each (preadv)\n" +#ifdef HAVE_PREADV2 +" -U -- Perform the preadv2() with RWF_DONTCACHE\n" +#endif "\n" " When in \"random\" mode, the number of read operations will equal the\n" " number required to do a complete forward/backward scan of the range.\n" @@ -388,7 +391,7 @@ pread_f( init_cvtnum(&fsblocksize, &fssectsize); bsize = fsblocksize; - while ((c = getopt(argc, argv, "b:BCFRquvV:Z:")) != EOF) { + while ((c = getopt(argc, argv, "b:BCFRquUvV:Z:")) != EOF) { switch (c) { case 'b': tmp = cvtnum(fsblocksize, fssectsize, optarg); @@ -417,6 +420,11 @@ pread_f( case 'u': uflag = 1; break; +#ifdef HAVE_PREADV2 + case 'U': + preadv2_flags |= RWF_DONTCACHE; + break; +#endif case 'v': vflag = 1; break; @@ -446,6 +454,11 @@ pread_f( exitcode = 1; return command_usage(&pread_cmd); } + if (preadv2_flags != 0 && vectors == 0) { + printf(_("preadv2 flags require vectored I/O (-V)\n")); + exitcode = 1; + return command_usage(&pread_cmd); + } offset = cvtnum(fsblocksize, fssectsize, argv[optind]); if (offset < 0 && (direction & (IO_RANDOM|IO_BACKWARD))) { @@ -514,7 +527,7 @@ pread_init(void) pread_cmd.argmin = 2; pread_cmd.argmax = -1; pread_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK; - pread_cmd.args = _("[-b bs] [-qv] [-i N] [-FBR [-Z N]] off len"); + pread_cmd.args = _("[-b bs] [-qUv] [-i N] [-FBR [-Z N]] off len"); pread_cmd.oneline = _("reads a number of bytes at a specified offset"); pread_cmd.help = pread_help; diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8 index 47af5232..df508054 100644 --- a/man/man8/xfs_io.8 +++ b/man/man8/xfs_io.8 @@ -200,7 +200,7 @@ option will set the file permissions to read-write (0644). This allows xfs_io to set up mismatches between the file permissions and the open file descriptor read/write mode to exercise permission checks inside various syscalls. .TP -.BI "pread [ \-b " bsize " ] [ \-qv ] [ \-FBR [ \-Z " seed " ] ] [ \-V " vectors " ] " "offset length" +.BI "pread [ \-b " bsize " ] [ \-qUv ] [ \-FBR [ \-Z " seed " ] ] [ \-V " vectors " ] " "offset length" Reads a range of bytes in a specified blocksize from the given .IR offset . .RS 1.0i @@ -214,6 +214,12 @@ requests will be split. The default blocksize is 4096 bytes. .B \-q quiet mode, do not write anything to standard output. .TP +.B \-U +Perform the +.BR preadv2 (2) +call with +.IR RWF_DONTCACHE . +.TP .B \-v dump the contents of the buffer after reading, by default only the count of bytes actually read is dumped.