From patchwork Sat Mar 15 22:26:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14018254 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 539B8C28B28 for ; Sat, 15 Mar 2025 22:26:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E80D280002; Sat, 15 Mar 2025 18:26:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 496D9280001; Sat, 15 Mar 2025 18:26:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 386BD280002; Sat, 15 Mar 2025 18:26:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 19EAE280001 for ; Sat, 15 Mar 2025 18:26:22 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5AF96A7E39 for ; Sat, 15 Mar 2025 22:26:22 +0000 (UTC) X-FDA: 83225220204.11.4EBBEB1 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id CC859A0006 for ; Sat, 15 Mar 2025 22:26:20 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IVsETmf8; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742077580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=6giQaMeuEuTqVwi+hP60KVm93/DtjGO479TS+zX56PE=; b=1fqTSUgUzvMgVeziZd1Gzi+pmxwqMJNcfvbcwvJvdgd+7ylkdrtfNhTy50G900CE2gWfTf tjQEVDNNezg35HzuxBfKvhivTmMbqICWMpm6infMr0K1MhK9IiTdtYDfXzWn/gDP87pImL 8YD3H/DbLKbhaSmUml1iv+blSIivkYc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742077580; a=rsa-sha256; cv=none; b=rAfn/Dmclcu2v3bMtH+zBBZtyZd/OCpXrKxM+KvtB9Z+M1uAbmMaFjx0//YyMvsRXPfOWN MnQzu13pPo2AUhFZOhrDZQH5p4lHdpXp2hqONur8YwPBeuJFzSFfUHl8yiW0wq/BUmFalS oTsBtLJmP5Glo4nIiTN8WLkPS4t6rA4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IVsETmf8; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 48F5DA487E0; Sat, 15 Mar 2025 22:20:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DB96C4CEE5; Sat, 15 Mar 2025 22:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742077573; bh=IZ7hQqeuHwLTEWeBLXMbvbomiMzODFwSXk5X/rK2CMA=; h=From:To:Cc:Subject:Date:From; b=IVsETmf8VXTNv10R1QyakcVyZ0QyqiDn17KQ7av61sPG/+ZuURXTIB4VP+wGFEBQ9 YMOy84MrD/eRJqKiY29TY2AklMco5VtKGqPwpAn14mHq8LhtozaIcai5r7Uj+sNlU9 ITut/M5SaQwmxHenFNit57E84kDeChrjkQNDz1q2/XHS4gbB/Wb9vKGqXvf9vDATs8 g0dz+r3U52XVWmuIUxcaA4AjlBYF4PsyqBQee1Oh+T14MduW3rUY78E4fCkRaSUDaB 4HgbproOICNJz/GdzNzON83XzBKavX2rWa/9qZ85q6vYvXZnlm1B8rfu9c07Zvi4r7 gDGmJj3I7FRbA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH mm-unstable] mm/damon/core: setup damos->{core,ops}_filters_default_reject for initial start Date: Sat, 15 Mar 2025 15:26:10 -0700 Message-Id: <20250315222610.35245-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CC859A0006 X-Stat-Signature: fatzucp4gn6t8h5bjbuz5fbuz69zjkwa X-HE-Tag: 1742077580-423894 X-HE-Meta: U2FsdGVkX19VE3HPYOsBaGCSwR18G2qL3cqRlL0x0zFwvodLFU4K8gK8rwMphKztOl+GBWP97xS27wvAiqUfMse/p/eg+DM0Ej3yT4tPvRi4hH41GzhzfcIOyrwWesKkupwaIl7a5uzEp4ozBKQxrubCK/fyeG3Au1b1VXuHn4lys2TxBaen9BkORBqQt2I7J/4Q3mCRR8oTUKindLQVtRwCAXnY4bPOaLRjr8rVFVXBDrekmBA4YFsW85UCxqgHfUz9b8FQcPgfFRAhBvK++9BxnSubZQ3GKg/M8l9X9Rq0t7Mu/i9rvF5eLP/k+bgKxmDA6PX/aBaoUvPaZ8LDChJDWrmlqZ5BMYLpqpnfOCqKmX6h0QkCiUrA2QLetiJBeRI4VdpaAeV0MVhgN7saC5Or+62FIteWs5JcwN+lwEPvfOZpusGDZbxXRrb08dmA3SRLqILAIwgxM06TzK9QgptHx1AjAsvQSDtFi5GUjhxnz6wDIj6yfauJwNDvKz7RXS/3L0a8rpY4HBUpQteWiwrMYrCa4Sd3ygQj350mAcAkM7hC13EPplNZXIsjH3cQZzHralM0v+f2n42gwab3ITHTLcJ+DISGGTNhUiIH9RN6sKOuQeW5r1N3jEFoWIqViYXCQOfYMLheHA/mvlr8P9WkCDHk0YjhXQbsuQHb7mJzt2SmsW7TdriO3fpVZK27Ty8pCWK/13PKGAwdUfthCco2SKM+dNrjAiFhs2s314WaCHVQF5eyDW+xINoyKo8Rxwg7cGWJ9gL0JkHB0GjOzBIR8qniFelJ7ctsgYmGuHRpNn5ORr0Ct8J/24EbzehxkkA4Flz9mqfC+oCMPWjd4D9K+37xeakSR4Rn5rjxl2dgv+/GQjZb3gyHNlSvHw1LHp5xRwbWrZmWdL6jtDHCVP/jvCNawoiTtHnVDP/JDuE8ruiI8bvR3VpkAuww1EOvai7w5lwHh257cHRIhWG xsiw5GjY aCdRYvLXV+TZLBLqkf5yKbS9A9IkgsV8/H24kcaiy78lN2+zNPqgVXiCO0tleKMabBxwBxdl7RbDDbywbQHvLxMEn8Tl2liod4+lphwOpyLz1M3lv6M9vRU48/yKBmocZhNEWnImQaMLB7vZltGeE6QfvPDPTEWRd8qteNFqR8HcWMglMKSLzKgbP2xBC1ek5ZwMJhmtoI2MZ2eyLKBKHWGCDsE58qIGTB8HnrhVyu+qon8I1cr/9oWIWW50oglr6+TMxd42hbIr9ss26Gw5jU/96Cg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Commit 6a0f07289bc7 ("mm/damon/core: set damos_filter default allowance behavior based on installed filters") on mm-unstable sets damos->{core,ops}_filters_default_reject fields on only damon_commit_ctx() code path, which is called for only online parameters update. Hence, users who set filters from the beginning could set it not properly initialized. As a result, unnnecessarily DAMOS target regions can be rejected. Set the fields at the beginning of DAMON worker thread execution, too. Fixes: 6a0f07289bc7 ("mm/damon/core: set damos_filter default allowance behavior based on installed filters") # mm-unstable Signed-off-by: SeongJae Park --- mm/damon/core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) base-commit: dba212acaa779ea422b1c0653951af5fdf837314 diff --git a/mm/damon/core.c b/mm/damon/core.c index db357892da74..fc1eba3da419 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -525,7 +525,7 @@ struct damon_ctx *damon_new_ctx(void) ctx->attrs.ops_update_interval = 60 * 1000 * 1000; ctx->passed_sample_intervals = 0; - /* These will be set from kdamond_init_intervals_sis() */ + /* These will be set from kdamond_init_ctx() */ ctx->next_aggregation_sis = 0; ctx->next_ops_update_sis = 0; @@ -2363,7 +2363,7 @@ static int kdamond_wait_activation(struct damon_ctx *ctx) return -EBUSY; } -static void kdamond_init_intervals_sis(struct damon_ctx *ctx) +static void kdamond_init_ctx(struct damon_ctx *ctx) { unsigned long sample_interval = ctx->attrs.sample_interval ? ctx->attrs.sample_interval : 1; @@ -2381,6 +2381,7 @@ static void kdamond_init_intervals_sis(struct damon_ctx *ctx) apply_interval = scheme->apply_interval_us ? scheme->apply_interval_us : ctx->attrs.aggr_interval; scheme->next_apply_sis = apply_interval / sample_interval; + damos_set_filters_default_reject(scheme); } } @@ -2398,7 +2399,7 @@ static int kdamond_fn(void *data) pr_debug("kdamond (%d) starts\n", current->pid); complete(&ctx->kdamond_started); - kdamond_init_intervals_sis(ctx); + kdamond_init_ctx(ctx); if (ctx->ops.init) ctx->ops.init(ctx);