From patchwork Tue Mar 25 19:49:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Purva Yeshi X-Patchwork-Id: 14029418 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73FB8C36008 for ; Tue, 25 Mar 2025 19:49:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 310B0280013; Tue, 25 Mar 2025 15:49:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BFEB28000B; Tue, 25 Mar 2025 15:49:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18865280013; Tue, 25 Mar 2025 15:49:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EF6AB28000B for ; Tue, 25 Mar 2025 15:49:30 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 602D51A0DE4 for ; Tue, 25 Mar 2025 19:49:32 +0000 (UTC) X-FDA: 83261112984.19.DB06C32 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf13.hostedemail.com (Postfix) with ESMTP id 92EF020003 for ; Tue, 25 Mar 2025 19:49:30 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JnhsPSha; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of purvayeshi550@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=purvayeshi550@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742932170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=34tbpW8BH2aqAy4+jZFikzk4k9oyhAq1g+2Ui0jyM1w=; b=bzStusrfOlZt6LiKGR7VEX1JbxpBxdBIi3nVtHG8FHZFcGTrurc+S4SoWUqONlq+pBYklr 6f2WRUak6p6/+0MrbK1ITu5za1emyxujbdosqhywz3ITu8P0aQ15hE3COWdRF+E9CEO3Ff dTb7qmerBsFi9+kdQ+byPsKwgu70nfg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JnhsPSha; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of purvayeshi550@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=purvayeshi550@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742932170; a=rsa-sha256; cv=none; b=HiCx81yp9dyylWYypKqiKY91f6qYQ+Md37ZGN0M8eDWdJ6iVqYzTw9nfj2YcluNCrTXISy PGlXymTOeNZV2Mv8+vdX3aKmhXXcVY4SuN0ejup4d3C12SDQNW8A+I8AQppQtKmDI4cTQS PAB8fYvl9bDAMpdgB1BGWrhXIYDl7KU= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-227b828de00so54085965ad.1 for ; Tue, 25 Mar 2025 12:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742932169; x=1743536969; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=34tbpW8BH2aqAy4+jZFikzk4k9oyhAq1g+2Ui0jyM1w=; b=JnhsPShazwCynFS23/OatX6I3q9PavoWZ31j1h8BwwKBtWBrr4tde4l30dOIBCCCxu cZiMcPiVzR+34TNX1gDPiGuDpYVBvBMJZeuppp3aAx8GCWrUpUyxBZJFGKhGqI5FCUl3 Ow27ojakyWXsoYr4dIV4nxcnTyuiG4u6sjy1vf4gEuvXyGlH+S2yIxvWDqVXykHHq4Hw UpSkgk9F0b1fgY5vlj4BnF7QqPXpBLQ9Qf18TJqfYCLt8ET/GMW0IIZfXbiZFSxa9Xb4 nWvvkTax30rdkUTcGRMHe985MXVkfqISl87bv8DLCOZO+qJro1NdTUV9bIER2u76Opyw 2LwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742932169; x=1743536969; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=34tbpW8BH2aqAy4+jZFikzk4k9oyhAq1g+2Ui0jyM1w=; b=wpibUXu/hTc6VmV0zsL///4Cvio1cXifOKN50OdNK1XsqakbvynwdsiDbwqwZCJf6G EqVm/2c/XldY06JToJBZIXiCKIQOsFJBKPrjcsV2j17NFoJnm0PMOHBtVbbwNkzZ5LrL sSbGqYdRX+nkKY5LAzoYAtnrv/rPKc0BSbzMXJooFm/vCqha9LkmwCKSbyMA8Mc3d0vf odIBmFuJcQ0v2ZGy2zAAR3ncf+CJueZCJBTujS2e/dhK/UXbb+HnMzJr1LlLQt4dbbzR OBbv85dN3s7MY9M0BD7VdNVRDjfCj4/35UFkvuFM9fjRY9vNq1UwYS7b/ydQ+wVo2533 RIxA== X-Gm-Message-State: AOJu0YwQU4nXva6ZJar/HQkLb8Hvagd5DF/MxOYWT/Zxne8RyZCHJiJr fB84kUZCPBoy6wEgsUkPMcq+B2UAZcm+oMBwK801689KU0vDymzK X-Gm-Gg: ASbGncs7bbf7A+RMXaTz++fi/8ix+e9/+DIewk7n0o1sz9+6pyqllsVSIhDzSGhSrMg 35e80C89HOL0vu/nPxG8IJK8SYfOu+5q6iguvz/xSdhivVWQuOM5j/mza2/O6zECCPg53Zl0EEm cjvP1mlgFdvTQHpsf/GyUgJyMmS1ilIRmaP9tu5Lp4asO1vM3QKv4PtCAAn2OHtUr4QLuZE3fPK dMOuXEMoGGFaSIdkefm/x65AabywYbuVc3eV4jBpe0cbN5d8OqqaPAwpkv6Rc8irsMGftFiQqER aiuTL2UqQawjPLDIri+0qP5kMnlGYRSzXZlUg2DZ8jsMBdJUTo4hm2gZPkGsS30NfIyfQUcHKbz 9ruo= X-Google-Smtp-Source: AGHT+IHuD4gU2NB/Cm9OJi4UNA2DHkgt3xOtYAV0HSQIHALTmHNx1aZFVH90L3KBo1cExPRliedHOQ== X-Received: by 2002:a05:6a00:234c:b0:736:4e67:d631 with SMTP id d2e1a72fcca58-73905a50170mr24970197b3a.23.1742932169094; Tue, 25 Mar 2025 12:49:29 -0700 (PDT) Received: from purva-IdeaPad-Gaming-3-15IHU6.. ([2409:4080:119f:3ad6:66e:eb88:9ca5:b5e6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73905fab592sm10992435b3a.19.2025.03.25.12.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 12:49:28 -0700 (PDT) From: Purva Yeshi To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Purva Yeshi Subject: [PATCH] mm/vmscan: Initialize dirty to prevent uninitialized use Date: Wed, 26 Mar 2025 01:19:20 +0530 Message-Id: <20250325194920.53307-1-purvayeshi550@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 92EF020003 X-Stat-Signature: 5reojbfamj17umaraw5znqne9krr7jft X-Rspam-User: X-HE-Tag: 1742932170-516597 X-HE-Meta: U2FsdGVkX19Ggmuog3jTjjbdvr2/GPV0msiFexFYEOLlc/DGw+gPeqIlpTi1KhreWp2oA1s2Pay+qu6XzMsEbAGq5f6G2fD7JmR5b6YSM08OeQQlqnG9bWvHrT7ss5GUSnn++BvTkxPv0V1uuA1gFowB89G8eICoL0AgWIJV0s7wdWAizEbyIBL5Y+jpDDo6N1TgBTUod6dmXo2gbuoDCxhZwXvirBnTZJDQP5O+ouCSXZW7CfffUu5mG1uBWZtMXDLrab5N2Gm3Q3dCgQsBFZOODhuP6uqNkUkjCXsDtvG5610hizWRYmQn03JDuWBuPgqiN8Op36DW/fOm7zjvAMJtilz41rCnMaLb3mBLHZYJuK8H/xHbI4HDKby2257LfLT+DanY4YLTdJfCDSPv7FT5iqmJl5qndD+4YL/Fw88vdmMLED1FD+h6PrLFYPCxf93zXUP5Q2rc1fYjpwOMBhUx1gKs6Rz8FNtfk1SlViJkE4wFM5NZ24breTBtdtNBiJUYJ46OEGEJOIcbTA8SFrbTjhniUA3D96M5Q06OpaLYOuD5JmpdzLv/Yz1bwoHWVmUMqqeDDuoJLiU4xzYcMmZyRRSIsoIMZvhANSML5fjSfaFKn+ltM1Dc1G0+I4ahZCDkFFWeSnIb/X4IcIvacz1LSkRKt/fY+odc9+STRA8FOZff9L1jKp2mJdxBXk2ACt3uvLmMqTLdFY85kV/QQj+2ovadNtwXLzU16jAF+IPVeIvhXnwrU7e1RmT+0NnnGrSLgNZGvwmCwpmZgEw3vDhq76UIwMFsUH0T1/Z9ZU9hWrJ1ERJ5K/sN0FuTIS73ebfOVTCgdEJZ5aZvr3rnB9XIta94RGNH0dXbSWmonfwvjG0L8UeiNOXCOXph/mDRdr+zWyk8w4AiyIdQBDtE5pDV/YtQYT8cIoanY9jL6PcTYeFbjsnqaIJud2OdynprtoUAvS9gozC7ZMt1i/J 1K7V2q26 WmbbUEqJY7q1QUDheaKyUbJ7p9XHK24QF1frVhil04046nU31QF8BwPKDmefCxwMDe12OV1/KMXbTBbMdebjCg/sl0N2BMD0FRq1zeblB/flA7WMAAdYqfw4akL0erduZwAyu/lgMYa3zowFtFxs5lzQcZvJ1Cnxp3UhE8xWe6LqiU8MdWEionexjtU+FL4UG541uacrGO25uTHC5rl5y6bq9LSQlUA3uMqBkndADXK+APRCE+y6xuioJgK3pjPwycKbQdeK/7XM2UqonxfSxQkc/eF7qhWEbylByfWlfnN081AZLMyoRuycFn4lrWmZ1f4TnPVPanlhub8I5yYinGznRtds8AmeEQUx9uMt4z+IkdCvYEqlCyHEf7XAkBkyBZZSH9F2Hr5tSfh4QQmXc5lEUjA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Fix Smatch-detected error: mm/vmscan.c:3509 walk_pte_range() error: uninitialized symbol 'dirty'. mm/vmscan.c:3522 walk_pte_range() error: uninitialized symbol 'dirty'. mm/vmscan.c:3600 walk_pmd_range_locked() error: uninitialized symbol 'dirty'. mm/vmscan.c:3614 walk_pmd_range_locked() error: uninitialized symbol 'dirty'. mm/vmscan.c:4220 lru_gen_look_around() error: uninitialized symbol 'dirty'. mm/vmscan.c:4232 lru_gen_look_around() error: uninitialized symbol 'dirty'. Smatch reports 'dirty' as uninitialized, leading to potential undefined behavior. Explicitly initialize dirty to 0 in walk_pte_range(), walk_pmd_range_locked(), and lru_gen_look_around() in mm/vmscan.c to fix Smatch error. Signed-off-by: Purva Yeshi --- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index c767d71c43d7..39c49fcd960c 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3456,7 +3456,7 @@ static bool walk_pte_range(pmd_t *pmd, unsigned long start, unsigned long end, struct mm_walk *args) { int i; - bool dirty; + bool dirty = 0; pte_t *pte; spinlock_t *ptl; unsigned long addr; @@ -3535,7 +3535,7 @@ static void walk_pmd_range_locked(pud_t *pud, unsigned long addr, struct vm_area struct mm_walk *args, unsigned long *bitmap, unsigned long *first) { int i; - bool dirty; + bool dirty = 0; pmd_t *pmd; spinlock_t *ptl; struct folio *last = NULL; @@ -4147,7 +4147,7 @@ static void lru_gen_age_node(struct pglist_data *pgdat, struct scan_control *sc) bool lru_gen_look_around(struct page_vma_mapped_walk *pvmw) { int i; - bool dirty; + bool dirty = 0; unsigned long start; unsigned long end; struct lru_gen_mm_walk *walk;