From patchwork Thu Mar 27 14:51:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexei Starovoitov X-Patchwork-Id: 14031207 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 794C1C36010 for ; Thu, 27 Mar 2025 14:52:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35F7E2800FB; Thu, 27 Mar 2025 10:52:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30F852800F8; Thu, 27 Mar 2025 10:52:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 201362800FB; Thu, 27 Mar 2025 10:52:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 036FB2800F8 for ; Thu, 27 Mar 2025 10:52:13 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0C28E120EB2 for ; Thu, 27 Mar 2025 14:52:10 +0000 (UTC) X-FDA: 83267621262.19.7A654CD Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by imf02.hostedemail.com (Postfix) with ESMTP id 58E9E80013 for ; Thu, 27 Mar 2025 14:52:04 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NFDuobdk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.219.43 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743087125; a=rsa-sha256; cv=none; b=s8Pl6kohSv3knPhVKfxG7k0B03cCLU49/I8dqNzZ64BaKUOEqd5de5tV8TFYLu2dIklQeu PyM/WxrhC9uaOPHlYO4MHDs15XmCSUrraBV+mx+XUl3fTHt5HVaw5x8hFq6SnNpmlhUd/i WGL/zG/Zg0EnmVJj4IvqezI6n9wRgx8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NFDuobdk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.219.43 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743087125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=6F0q/kxgMh4HTjwgKMB6A+5VY81dq/P/Rx36ntiQZRI=; b=4OMJ8iPwSrnNhv6PeS44+pKLWLJ/XFsJnGVKTXtlpqIbauBUwanaLdK3RtwGQ/7XRHaMn5 xS6384r4WVlM//DYV9jkQiqSfcc591ExDqRC4TipjxNjEJOH31+3AofS5tBUBnvLAxyg7s wVNhJdFbr1D2vvbgAPwpTYsCtAfsdlQ= Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6e8f7019422so9270046d6.1 for ; Thu, 27 Mar 2025 07:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743087124; x=1743691924; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6F0q/kxgMh4HTjwgKMB6A+5VY81dq/P/Rx36ntiQZRI=; b=NFDuobdkCs4g6wcyNmlVgrr1saK0u3rzckYdrsm03mtUY+n19snnYOQiV+ZIhisITr yRnAf7rSrGvJfn4yeiOe5ICAirkVxdWQtE2b0sea8E6D43B8Qlx9kWgG4/becDcopsCG 9VIkOoJuX8fJJWmhdDxPWGo/VbsVpyVjejHOc75lQXlRhJufo6pUfW3bXhwEpdN+GJgp av69AZ9msxNK898+mibbvlqXqSQOqXezClK3eReeLqLwQY8CWIxKgIb+HPVLC5lkrjYR egWYBecjVjTW60/3S866V1IgHs+6B7NR7yeqP88rZ3d8Xfk/mwIOXKdEkgLPF+9HJq1G EoBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743087124; x=1743691924; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6F0q/kxgMh4HTjwgKMB6A+5VY81dq/P/Rx36ntiQZRI=; b=gLofn8nNHp5GmCvAnDfhzLPJMOrWOId/uUXIyD/e6wFsSJhJRhuJkUzvYHpY1Z1a65 qt/O1sVJPQh1yFW43Nrgh/Q8EMfJf28fD9dWKGmdgoiFQc4d1AetR/lDl/VkuXrWcg50 cCPrKSiP9eh2XPOilfYA75iLoajwYfkqC49TlY4Jy0J9UoW/YwtkWMPIt1M9uksJQcm8 L6QVUZfZb3ANKW2ZNLmair5BXrPUIoHvUeU707AsXNSARLr/SPXJBi60UsJahaKw8zjx 9aZdEKbCDfDzE5AiV60VFgIWHwjAZERvyYsdhVsd98jMx7jYxsSouaSJU/VKkP+oFaC6 9FvQ== X-Forwarded-Encrypted: i=1; AJvYcCVw/N/vR7FHXW9tp7mKcWsNuFGO91Oua3gZA6uPHFMADn4JmfDL+ZrYnkSsGYUmH6hpP8fc1b6YKQ==@kvack.org X-Gm-Message-State: AOJu0Yzv7H3ZJs94dZUnupb4QABux9ZSiB5UZNMY2bI21FE9ZNInAyMJ dn32sqYsBbJYbZpZSXJF1UWOmp1kNd5M+fDGms3dzLC/Yu4sHETx X-Gm-Gg: ASbGncva03skXoLH1Sna3Hw7A4q+hGlY8BscDAep/2Q/ODxEs8epCu79rbeBO+rErtO K3ILPUjiRWnXUxc5EfwnTroQW1IngosG/7XOqUXREIJpvDxlhpZHkTtpwK0NTn6XBmQb5AT2Ssn B4Y4ZVOwz7XYVfoTC7EUZew2USKcfB319/CX2UQkaOdhOHBIkcmR521tUwH+e7/N76qPkdgZqo+ tWDgj6KWLI/KFOR1Up4FawSw7ZdwZgxUg2MaiY9VtBvEK8ZQmqfjVFeTl7T6T2Kq4bF4uQPPUjX nL+tBu3rM6Uk9cLlbewus34hFmdsMFzPlX+EsaQfcEAI0FI+95wnG4mLlMcXTKTskyVKbfSSvci QnJu+85xWQ02b/nbsTpR3JQScbTMF9/Dm5EU= X-Google-Smtp-Source: AGHT+IEoG/2aSIZRRI3VLRjKxgjxIVKISbF3fSEXZY9id3JPyrhW2IqRCw1GyMaQcZXfUYjfPwUUVA== X-Received: by 2002:a05:6214:1d02:b0:6e8:f4e2:26ef with SMTP id 6a1803df08f44-6ed23904822mr59197876d6.31.1743087123789; Thu, 27 Mar 2025 07:52:03 -0700 (PDT) Received: from localhost.localdomain (219.sub-174-198-10.myvzw.com. [174.198.10.219]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6eec965a40bsm181656d6.61.2025.03.27.07.52.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 27 Mar 2025 07:52:03 -0700 (PDT) From: Alexei Starovoitov To: torvalds@linux-foundation.org Cc: bpf@vger.kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org, akpm@linux-foundation.org, peterz@infradead.org, vbabka@suse.cz, bigeasy@linutronix.de, rostedt@goodmis.org, mhocko@suse.com, shakeel.butt@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [GIT PULL] Introduce try_alloc_pages for 6.15 Date: Thu, 27 Mar 2025 10:51:59 -0400 Message-Id: <20250327145159.99799-1-alexei.starovoitov@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 58E9E80013 X-Stat-Signature: mdc3u53jbnya97uq7puowagn9qt63rbz X-HE-Tag: 1743087124-361092 X-HE-Meta: U2FsdGVkX1/2/muaDCxxqt88b0IKESZbMlVTvdGziljeWzRftMdEmpmW/YdAujQpjLLRH4C+skaVP/SJaA/qymE+usnJ/5STwO+aEAsKTKSaBxflzjHpR4MGeZm2LcjTbMBUCfBWHZMkvRbgIxtIuhWyK+ggUxCGFCcQA/2HKtVxF8c7T22EvPrltQwrmldTZICfLIuiBBK9jDy2jKEeH4jQ9JYSFCKShSx0lFtfrMlOvpAwr4WK2Jd4SKJ6CVFW7p+9pILTltZUv3tqTgUsP/vqYxD9WsPQ8LIA3tB9T5z07CKNVd6AYpwUlJU10n03igejJlODXblcN6PeIyPu4BJZ3ZYSyi3OeD3oUL4hcnqCYqcXsxrutBYB7LIYuUmyftQF9t0Cr2qX8ct1QLiSS7/FSdWWgB09gpKtCvLJVzX4fRPzt50Xa9n85GG+bV1RE0woOVDrUaykq/qfjazPE576sreeKwNqhx7esr4b0HSkV30wylUnBL23oOQ/BrO/HTyOJ0Q3EtzP0G3oXe6MNqLhlJBelyIKGesET5lSY6n5OXw5EWPaRdHaK0YQKh85gklsx/pOFWZS5Cc4VbAl5GdO3QcAH3GAZsuuONiJgjPwRaL8YupB5B9oC6YMkVOiNa79KnygXfCkaRS09CfQRWk2dVtOwK7Bj6vB4y92T3DmU7xrDdXksQtNWdHjF5Fan5N8uJTrvA6tETMtBiVZi/bUD5wJ/a1qJ6V+y6NPDohFTEAc51eep6WSHKcQF6B00CCtlGG5kB89rVm0ldxa4JNjziSer9ZSJDkm8eHLyxgRJGFs3rYSe74j/QUqzoNH+4XnOoEuknWeKwE8vrIGZcD107fi2rNvOkmIgm9uREx7PG7Ie/e4PXQ/67gy/FE/olOhY700zQkTjPDm8pVJ+zM+/jMzkiOd7KV55Dj1KNckMBnQQbW8MNaDvyv6k2W5aWLhJe1YBRRhYn5Y6Mx 2QnyxHZ0 s/AU436QXrDQvHkY10CVM2uWRaqKWRlyxoTYVd8urZ/XIGDm+i1TbDaWRgxPnHc4GUs6QxVYDu2NSDbGVgv4TFqA4gXTGB6eczSRyL46RJXCzm50wYvqX31GSS9TdwFCC2r+gEdPAbQzjXAUU4rMLV518FIsjc5EjifqNw9S+TEH3Qp9ub6rf0Rqo74/0l18+XE6Ybi1b0ozI6LSrYKtKvAUSt0oM8h1Ch83khuKc3CGyI65jZQwx5mcnzO62dwhCaC4PXFsZ4hEcYcxrCvYaLMGGvvWY766XveVnMPg0y2+aVodNurMvIKE5Jq3gOsSXeq35Y1E9SdZmRONpUDqexKEWqF/vqpdBJpmvn3/vKXBOtw7u/yuGmNpgl+qTS51LqOwpqAvufr05KIozm1sgN8qjKVQ6TrrLNdvVMOi6OFMnZ4wG9P+KjxqKMq7xNxVok0+CfLftTVfWymlQkdCLE4Qhnz+C5IyaAy0IlTwR6mQnaKyHp+hOE5PtLp6QypZa5lZ6juioLxRphv3shPQXjgAkIu/C0xKLYIV+UyOhXbl56/YTlCIO/tDQBrwPlIGUj5sxJFyZQh0LB5SbcKSW3ipQ3NviXnZHY8aZ5eaIehjBHN2UeVhEwMdqjw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Linus, The following changes since commit 2014c95afecee3e76ca4a56956a936e23283f05b: Linux 6.14-rc1 (2025-02-02 15:39:26 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git tags/bpf_try_alloc_pages for you to fetch changes up to f90b474a35744b5d43009e4fab232e74a3024cae: mm: Fix the flipped condition in gfpflags_allow_spinning() (2025-03-15 11:18:19 -0700) ---------------------------------------------------------------- Please pull after main MM changes. The pull includes work from Sebastian, Vlastimil and myself with a lot of help from Michal and Shakeel. This is a first step towards making kmalloc reentrant to get rid of slab wrappers: bpf_mem_alloc, kretprobe's objpool, etc. These patches make page allocator safe from any context. Vlastimil kicked off this effort at LSFMM 2024: https://lwn.net/Articles/974138/ and we continued at LSFMM 2025: https://lore.kernel.org/all/CAADnVQKfkGxudNUkcPJgwe3nTZ=xohnRshx9kLZBTmR_E1DFEg@mail.gmail.com/ Why: SLAB wrappers bind memory to a particular subsystem making it unavailable to the rest of the kernel. Some BPF maps in production consume Gbytes of preallocated memory. Top 5 in Meta: 1.5G, 1.2G, 1.1G, 300M, 200M. Once we have kmalloc that works in any context BPF map preallocation won't be necessary. How: Synchronous kmalloc/page alloc stack has multiple stages going from fast to slow: cmpxchg16 -> slab_alloc -> new_slab -> alloc_pages -> rmqueue_pcplist -> __rmqueue. rmqueue_pcplist was already relying on trylock. This set changes rmqueue_bulk/rmqueue_buddy to attempt a trylock and return ENOMEM if alloc_flags & ALLOC_TRYLOCK. Then it wraps this functionality into try_alloc_pages() helper. We make sure that the logic is sane in PREEMPT_RT. End result: try_alloc_pages()/free_pages_nolock() are safe to call from any context. try_kmalloc() for any context with similar trylock approach will follow. It will use try_alloc_pages() when slab needs a new page. Though such try_kmalloc/page_alloc() is an opportunistic allocator, this design ensures that the probability of successful allocation of small objects (up to one page in size) is high. Even before we have try_kmalloc(), we already use try_alloc_pages() in BPF arena implementation and it's going to be used more extensively in BPF. Once the set was applied to bpf-next we ran into two two small conflicts with MM tree as reported by Stephen: https://lore.kernel.org/bpf/20250311120422.1d9a8f80@canb.auug.org.au/ https://lore.kernel.org/bpf/20250312145247.380c2aa5@canb.auug.org.au/ So Andrew suggested to keep thing as-is instead of moving patchset between the trees before merge window: https://lore.kernel.org/all/20250317132710.fbcde1c8bb66f91f36e78c89@linux-foundation.org/ Note "locking/local_lock: Introduce localtry_lock_t" patch is later used in Vlastimil's sheaves and in Shakeel's changes. Signed-off-by: Alexei Starovoitov ---------------------------------------------------------------- Alexei Starovoitov (6): mm, bpf: Introduce try_alloc_pages() for opportunistic page allocation mm, bpf: Introduce free_pages_nolock() memcg: Use trylock to access memcg stock_lock. mm, bpf: Use memcg in try_alloc_pages(). bpf: Use try_alloc_pages() to allocate pages for bpf needs. Merge branch 'bpf-mm-introduce-try_alloc_pages' Sebastian Andrzej Siewior (1): locking/local_lock: Introduce localtry_lock_t Vlastimil Babka (1): mm: Fix the flipped condition in gfpflags_allow_spinning() include/linux/bpf.h | 2 +- include/linux/gfp.h | 23 ++++ include/linux/local_lock.h | 70 +++++++++++++ include/linux/local_lock_internal.h | 146 ++++++++++++++++++++++++++ include/linux/mm_types.h | 4 + include/linux/mmzone.h | 3 + kernel/bpf/arena.c | 5 +- kernel/bpf/syscall.c | 23 +++- lib/stackdepot.c | 10 +- mm/internal.h | 1 + mm/memcontrol.c | 53 +++++++--- mm/page_alloc.c | 203 +++++++++++++++++++++++++++++++++--- mm/page_owner.c | 8 +- 13 files changed, 509 insertions(+), 42 deletions(-)