From patchwork Fri Mar 28 01:20:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ye Liu X-Patchwork-Id: 14031525 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C201AC3600B for ; Fri, 28 Mar 2025 01:20:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3070280125; Thu, 27 Mar 2025 21:20:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDF3B280120; Thu, 27 Mar 2025 21:20:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCDA7280125; Thu, 27 Mar 2025 21:20:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AE532280120 for ; Thu, 27 Mar 2025 21:20:52 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 83C56141903 for ; Fri, 28 Mar 2025 01:20:54 +0000 (UTC) X-FDA: 83269205628.20.B1342F6 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) by imf03.hostedemail.com (Postfix) with ESMTP id EDC4D20004 for ; Fri, 28 Mar 2025 01:20:52 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VYi14ezY; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.189 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743124853; a=rsa-sha256; cv=none; b=jxsgZn4uJ/7lVivuUPBOKcR/4dLc+kdW4WYDqIoxDydt4S5r/ZjNctjt6jAxi+8gBryezi zdy0dD7fITLVj/msHnRcOiVTRL38yF3ZWG2irICORTTvMmnENPaBI1f2EQmBKAvwR5ZG0c DKcNmpNg+joFEp5H3EAxSZUnTsuUaF4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=VYi14ezY; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.189 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743124853; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=ST7Zz7wKtV5N6+j7N6XxfcEuTgJnBuYUlRquTGdqjb0=; b=CSbaUwuYxqf3O5X20a1NDWfhjekt9o2fjgR+K2bxB35e13lbBYG3n2rFBRG5/gscCBJqda o12ZrlU5hFQlPcJUYMLY4QAvYyUyQl8lDFNRgThex5V0rRtBBoBwTFcAD3Vp5JplNgq6RH SW8TtCbrFjyAoPvWcYM5LSI9SQWKCDM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1743124850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ST7Zz7wKtV5N6+j7N6XxfcEuTgJnBuYUlRquTGdqjb0=; b=VYi14ezYdTog1/Ijv+H6W4/z68D2gFTHElWi2LvCcyNjbRk6hD2kRGZx+bQcYLlOMs9uXp mv7jkdhIV0+aHlAQ1P1UVXP318IlIJf5v4zuECWJf0Je1lQDck+rx/Kg1E39A/4uKT0Ccv W1iAYedZB0o2oVNtHjfoqYkF/gjlm5U= From: Ye Liu To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ye Liu , Anshuman Khandual , Oscar Salvador Subject: [PATCH v4] mm/page_alloc: Simplify free_page_is_bad by removing free_page_is_bad_report Date: Fri, 28 Mar 2025 09:20:31 +0800 Message-Id: <20250328012031.1204993-1-ye.liu@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: EDC4D20004 X-Stat-Signature: btn3eh4do5j5m94tgxp9s1fcekx5h6ts X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1743124852-571601 X-HE-Meta: U2FsdGVkX18ssFMqBgl70a0Me0fhvz/z8SyIvjCl4Z9S3vV9+esJoNLun3V/4j6qhtSQlw9N3D79Y39vdntxPt1FXRzyv4dzVgGC0VqqhP+pU4m4q9DR4XTtZvbEIk2SmVtI2gsDGVMHUTct/oSHyZtEZNKY8UVodDL3V4TRV7ypzN1XEv0kucp0QHzFTHjoc12tADeG2FdxXrybpFMdUMy9emIiiFFp0Ddpr9gj8R0xnbYewc5acLP+CDGnw9EMsmO1Gccm0gBgHBGnsenFGDwyjYXX2R6M+pmmVODiWxaNTcZo11lepaGrAFSrb5aSDsF5BYAoDivn35EbAO1o/G77z9TcM//6mcJ46KLQfQgDd27lHSs2B1uePahPYbJ/enKQn/X7ksStaH8UxihSmXr4/zS+RVqqwLMGe9jWbg+cC91yweXkiQ4Dlrvp9rumUEB6Il8oGWQpRJZ+uvdJzuTH62xrZ0p5eTaV/h8xxZBByVfkoo8uqOpoWGjWyobyqIgalUGcSvfQ1LT4m+FJvGUO8uG9jLxlLW9JvwPo99ELt5piYaUV6XaZ7LUc5Od1ADuK2ypy0Ca+zAHlWeGcJQpBImoeZjGXdaGawnSEv6TQZNxRm64rgGxu9vbRylI4MPgeifsElS6aSIYl1mKdVTVx+v1Z5TXmNVk44pJ+3PofRZVvO8r2C866WrG5NBn2MEgf0mZqqLSLK2CaMjDDjZjHctK9kjoURxofkcZrid0LFTGn7+bS+ZleOfhQPN1lsbEcy4tMFMW2+dfzq4KfIhzKt9ZWG975w6wXbjL+nDMjJ9+3clVUpDPnFU+16l4iD7bx5iQsmgYdvNPnOfs/il5nfBypvhHTXNyOY05kGW6XMZIIFWbL744Uj0dCRdeVgeg13CM34WMIayl463ncjdrBU0nCN2DltywIqrxyuyG/rdudbbIZ9ltha4Z8V/wxIxdfohbPdfQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ye Liu Refactor free_page_is_bad() to call bad_page() directly, removing the intermediate free_page_is_bad_report(). This reduces unnecessary indirection, improving code clarity and maintainability without changing functionality. Signed-off-by: Ye Liu Reviewed-by: Anshuman Khandual Reviewed-by: Oscar Salvador --- V4: Simplify commit information. V3: Delete 'This patch'. V2: Simplify the code by removing unnecessary line breaks. --- mm/page_alloc.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 61d6a3b1b286..60c54ba78a11 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -933,19 +933,13 @@ static const char *page_bad_reason(struct page *page, unsigned long flags) return bad_reason; } -static void free_page_is_bad_report(struct page *page) -{ - bad_page(page, - page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE)); -} - static inline bool free_page_is_bad(struct page *page) { if (likely(page_expected_state(page, PAGE_FLAGS_CHECK_AT_FREE))) return false; /* Something has gone sideways, find it */ - free_page_is_bad_report(page); + bad_page(page, page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE)); return true; }