From patchwork Sat Mar 29 09:34:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14032638 X-Patchwork-Delegate: jikos@jikos.cz Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010009.outbound.protection.outlook.com [52.103.67.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A40032AEED; Sat, 29 Mar 2025 09:34:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.67.9 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743240852; cv=fail; b=T1GnJYZZyPpI8uJchk+69IQnjsWIMeqaxlgK3M/tzh/HIJECMehQVopYK1G+0DqQH/CYE5vmOSGxWY6pRoK/FkMKhpaAAoCNypvClHE2/RgtGk/EFtvff8V0KQRC+m6pm8Wzt29jdrU9844+CmDIH2UmdAkdKu5AaUNSAV7qRs4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743240852; c=relaxed/simple; bh=xJQR0CC4nV/IrSxv1kc0XKN68FkiQsjGBJmSM1K6fKU=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: Content-Type:MIME-Version; b=tLR1f1DCsbqcJhvinNRziDFNWyl3nwFT2+4ull2TleK/qPVy+axVo8ffGMPnG7sOyHuea//g9G0+2OG5PezQBABvoUpraobtNGWeK1qodow/0oHS9EOUPrq0hfUQGs+yEeEKqGVAiMctXpbfY03lf2NnPk9Q/PYiI1hhLFXmlqI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=YTpqtvdS; arc=fail smtp.client-ip=52.103.67.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="YTpqtvdS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y/7HHCm2VxPVx2JAwxRIE0ja9n7QqCYMBqxuLuAbYF2kY1XO9UBpAcNEHvSaTGzUtJD34RyPVHxX6IvlHGlnrnYoajQaXnTolKI/AaKb4maKbjQxfsTACVsh7w0jK7hs6QXZ5RcyhhrAtg4+r0GqkGMthjn24mU8ZcnqTV4xfiku0blgug0jKwvdSzCRLyHuBtxxWbKxY665AwQorDzim2hfL7mq3ud0ukRLSzXRnCddo9VMADeAxdkHkzS6aYURVriOgBQGm0+wNq8yaN8hDN6YNKbCMgVXjuId035Tri5DoZgBk21ySkXQ23Ui8GIsqwlb2hJkkqr74x/pIDz6yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rdFFVbEAbnxpC4fjLPdyMTsLjDbBHlIdn7oF7oloh1w=; b=NM7TgdDk9oGhnfZf37vidlbVmi+MiPI1+1ABRQ2U8k6e7Pn8S8qRlpLlKF3MPoMJ7+Y4QQY/iZh8nWK6YJo7arIVsHzWtacFZWvut0ZV9vbE6x3fF5lIplESkgO6t6n2p5n95WBN997YlpE7NF5M6DsTvcCdCu3owIfPXUfG2AviskZ26psrT6xB4r4gGDB8TALz6uEBuXIoHuWNyRz5fEAA+ZlUuSuFPb0PUYDXWO7WNiI0Odtxmv3ZcAJ2H2ktbACXK/KOxq6uge5NRgMR8SysLbYrZuf7VVEzTQB3eOzwn/6bKPrQbKyk5p5ZC2+lzWNCxZR2kLpeQ4/gcr5KIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rdFFVbEAbnxpC4fjLPdyMTsLjDbBHlIdn7oF7oloh1w=; b=YTpqtvdSb2HouGMpLVyDBQOr0r1RinO/sPOOVffKDgpgpCtMohr3BWdPGs0MqaXZrN4mLcPxa3ZJVZ/Kg01P0uJikQgLZafBySat6BdGiRQdLlX1CU4Ydk+4+HYMJB/eC2T35jTTy71UKQgR6AxINdA1d1fx6zmqF2TSsFnv4/OZ8mNmX9nje0dPciHBZaUKVM7qyE9MMCVUBOL+wDE8j7kJdksKhIBPGPlxG1JoqDWIZDmxez13A8nOaCUvx3nVqve+XVBqstP2E4nYdX+nsirQpGs8XGoO7nk4AB59+hDwO8cnrvyctws6G+v2l5z5hSfGxGWhVK2718401PeAiw== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN0PR01MB10042.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:1e9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.27; Sat, 29 Mar 2025 09:34:04 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8583.028; Sat, 29 Mar 2025 09:34:04 +0000 Message-ID: Date: Sat, 29 Mar 2025 15:04:01 +0530 User-Agent: Mozilla Thunderbird Subject: [PATCH v5 1/5] HID: apple: move backlight report structs to other backlight structs From: Aditya Garg To: jikos@kernel.org, jkosina@suse.com, bentiss@kernel.org, benjamin.tissoires@redhat.com Cc: g.sokol99@g-sokol.info, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org References: Content-Language: en-US In-Reply-To: X-ClientProxiedBy: BM1PR01CA0152.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::22) To PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) X-Microsoft-Original-Message-ID: <4756305f-5269-4e20-94ed-1a8576d0a2f0@live.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3PR01MB9597:EE_|PN0PR01MB10042:EE_ X-MS-Office365-Filtering-Correlation-Id: 7eadc198-adce-4e4c-e061-08dd6ea4d8aa X-Microsoft-Antispam: BCL:0;ARA:14566002|19110799003|8060799006|15080799006|7092599003|461199028|6090799003|5072599009|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?q?Bb9JXjm3rP5RvdLWsdELoN/V+QQvEwf?= =?utf-8?q?7QtrluYFfRmJXCRc/6zQJS9tva8lMDYr59AjW4axbGXitIx8IR0jvagwdAMEMpGgv?= =?utf-8?q?y0ggZ97ylVyVkrNFxYJ5JKyB4hq/pul5MitdV3kxTrnfgUsTOr4xhZSKue/X0l29B?= =?utf-8?q?8hB2MUX+OHNtSnIDEN3o+CvO68rh439riCIGaS1ejB385/fVY8H7FZxLyI+kNF+9D?= =?utf-8?q?b/XlBYPWgzwULIiMPn6wNEirWKgaho9tfnYCHCddmcV3QFgf3t5+bZPmDnMys6RZZ?= =?utf-8?q?QPKmqsYcweXHdALGPES82wsc3n/ZOwRyzcDKpUkJKjF7nk+sghhaUnXICtZwZCOE+?= =?utf-8?q?930HUi6XClITpKP6lf3toiabvkj3IyDqoI5I2uLV5ZaLkaLwOycvRGlPL5TUNNeD7?= =?utf-8?q?NRxqaSmSt6n1N4AVNSEQ+jB6w4Moed04XKiIlilhymSLICXb8zQotFGMUcrroOHaW?= =?utf-8?q?F/FrMGEPWWnlXcX370Q6bwS1IWDfMpDWg9ZDHl2zLcVOMeDttFbrmN+TuXbgBMG6L?= =?utf-8?q?DtfaiepVpYAUmVoButzuKr3T53goOAwPfSj+TDZLLfu94IJ1WBC9E4ajLTV6X8T+M?= =?utf-8?q?jmrwRkkxKpvlZznUc0QK2ZLXo/0NX3U8DfT8FlH6GJ8KhnZw2vqJ9EJK3gLKSVC6x?= =?utf-8?q?MHRescwcMiulMNt0323qfh5pSSyEPjf2x8zXkBDnzJEh0YGi+uEk4OGVpHZJawdfH?= =?utf-8?q?2N50os+RLSg8vRbFOa12Yl/cUh2CZkTTPfppbdsevW/lYakQPs5xovPR6Z7KouLYJ?= =?utf-8?q?EKRO7lAQ6mC6JiytTdMM4O6V6PzkSX6ft1a7LnEHuBOTPMXzMA/2c/3BvngYumWV1?= =?utf-8?q?Aw39GgZEts/Fu38VxrBgWRTQMDZFD/hETL/gdJaGG5TzmfkcWZFChnYEsJojrUwzT?= =?utf-8?q?H49ZdOrPrZ5qKPl+LKeKuSx//D79WeA27ejOQftGuXXA4WTGJOy2O4/TE3Q2jbkoG?= =?utf-8?q?y4oTTAR99Bw182ljjechfDS1QIGdbY8ytd468TVZwUJd6q/5SXQtlrea8xxTU0anK?= =?utf-8?q?MHr7qdSObY6Og5F2cLVvac+u7GbtJ8XnQB8f8onvoSoB1jSuANFqx2ij0OijMM2wk?= =?utf-8?q?C/uv4UGe1W3sjjaSQQc+EkGW7eSwtBnpi6kIHg=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?FO6tjXA7yw5Z26LCGD25Qow1oIFg?= =?utf-8?q?xjwSYPo630waLIGhzoPBZYDmBGCPGodJul0LpXp0VppmXxPFuzpYHDtn79WKyOVHq?= =?utf-8?q?+pfZ6qyc6RBQA4dn79wpN6kYHe0I231k4+88vNElBP4pzUIRZyvRr9NAgI1Ovv+XS?= =?utf-8?q?dMmvxXmv3bsNiVGCdJh7bDuzd2GKB4pFV7xj4I6TrxaEn6QXmVc1xydCoWXsXX8ve?= =?utf-8?q?htoN9f4owe+plVcwb0/BSwAazFYddUMLMSl2ceKizeYbNgYcV4PMstNLhvXW4aHH+?= =?utf-8?q?nIknmnjnN4BGnRM12iEWawkuzh3fzKhcmt0wMqBx1dK4CROI+bmUg3p1/PnBgRAPK?= =?utf-8?q?mSzZbboyYua0K0wFk27Pb1RKic8mG8pzQQhYj9EQCgB+stS7I9nyIUbyed4082lvz?= =?utf-8?q?Z8+qRJZq0/HWbw8bJZ53phDoMjuEXT0k9NgeQ9Im735/MPJIRhcQgl6XyWZcUFxJV?= =?utf-8?q?lN1/TuEWtJujvQv7A0ssti/gp2KS+jiEfYkRpU6N0PvKbr+DoVJ7/I+R8M3TQ4Uup?= =?utf-8?q?PzvBO0zsiOIIUfuLIGCaS3kPU3m7yCKOkrWrQMT0uh3Xe80ohU3FavQwDpDmfVX3G?= =?utf-8?q?AJL1OXmVq1C2xDB4TQYyv7//Ehh/A55WPiTO4U6hGFPQ/6jbXiEKQuGuOJ2bHfEYF?= =?utf-8?q?fqnrfRQXKfCpnq2UCPTSN9YWMhTfV1qvQKnaJDPZadu3xva+xu8HZRTerFXqAbNdu?= =?utf-8?q?gbk8ZfYdM9zxuzwQSA3QFib1ceiHEsC6T/Oh40e08/ebketeHnNJNRXjLk0ltf8ll?= =?utf-8?q?f0oFSJ8+CTP2aGS3OT2YDYAZNlK8cDDtbz87JRCsf9LPT75ana2gf2tHjo0JHnqMv?= =?utf-8?q?/dQc4eiHsNeYO/DO2SGUW9M+zHBXClzkbBzqzA/kRb8TsUk3jrUudrMvz9lbDCcSo?= =?utf-8?q?CWNwcsGQR+XBOfKukboJBg/IwWAdxH73pORx+JoQinsi8KyQbOhAdGFnWpJKOx4cf?= =?utf-8?q?pqZnrlGPrmz6FoOLnzPcEXwifNiVX5tdRYpnSvtn2ATb73n4yhnT60FbzlpbTUJpx?= =?utf-8?q?WSHHFFNzU9gLhff+EoXVzQv8eUZl7vo3QoLI6AKW4Uj4waB0k0AoaTRBjaEIhAAxO?= =?utf-8?q?4XBriPM30BhxtvQ7gHYwTbNTQNkRBWPTjL8VzexL1bXn0COPxdFOcBH4NUhGW8d3J?= =?utf-8?q?YajMnCw6itcgNyfFpv6pO3z4mpzkJ+ftJCZIpW19RayLb2gaU/iEvwFmD2EjarMKW?= =?utf-8?q?P9AcKegzzC32wXEENBQUiUz/JD/p5eAA9UGasK11X88LDarizAwxLKCcOPw/uurvj?= =?utf-8?q?MLyZNQkvsQA6bZKT?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 7eadc198-adce-4e4c-e061-08dd6ea4d8aa X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2025 09:34:04.7289 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0PR01MB10042 From: Aditya Garg The apple_backlight_config_report and apple_backlight_set_report structs were incorrectly placed between the translation tables. Fix this. Signed-off-by: Aditya Garg --- drivers/hid/hid-apple.c | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index d900dd05c..93b990603 100644 --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c @@ -89,6 +89,19 @@ struct apple_sc_backlight { struct hid_device *hdev; }; +struct apple_backlight_config_report { + u8 report_id; + u8 version; + u16 backlight_off, backlight_on_min, backlight_on_max; +}; + +struct apple_backlight_set_report { + u8 report_id; + u8 version; + u16 backlight; + u16 rate; +}; + struct apple_magic_backlight { struct led_classdev cdev; struct hid_report *brightness; @@ -152,20 +165,6 @@ static const struct apple_key_translation magic_keyboard_2015_fn_keys[] = { { } }; -struct apple_backlight_config_report { - u8 report_id; - u8 version; - u16 backlight_off, backlight_on_min, backlight_on_max; -}; - -struct apple_backlight_set_report { - u8 report_id; - u8 version; - u16 backlight; - u16 rate; -}; - - static const struct apple_key_translation apple2021_fn_keys[] = { { KEY_BACKSPACE, KEY_DELETE }, { KEY_ENTER, KEY_INSERT }, From patchwork Sat Mar 29 09:34:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14032639 X-Patchwork-Delegate: jikos@jikos.cz Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010002.outbound.protection.outlook.com [52.103.68.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4209D18DB1D; Sat, 29 Mar 2025 09:34:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.68.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743240902; cv=fail; b=Iq8h+FET0g9rsYhXsx1xhwj+qt6kK+JMqgm/bCiO29sqM4w9ke3HHV5kd1rx30ECZAJp3hc/cJWqqfnFjYezLVpzuulUbYnn0MEbU1XXPGvSoilWXcME5OP/Doz3htDw/d3YeC99ojZ2ysFzruez8vCh6cPVWhbt1MHAx2wmVI4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743240902; c=relaxed/simple; bh=nzq3V0lIObZXASlwj2H00r7AtQjj5AYycpE0LYSU1Js=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: Content-Type:MIME-Version; b=dnlThiAQ9rRjSTMmj/UOVYz6CK54gVFnxG2lwfGAtBnGW//W+JaBzuybfbXh3V0FAqHAySBIU9UInqRoelexinkOtukcFoG/ja8VmWebt2l1vJWaQZFB/7Imr+Q3/k3TcVy4wwnVZHmjCsbgqCGs++HkEwx2RY84H+mlni4hC3Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=jaWdpq19; arc=fail smtp.client-ip=52.103.68.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="jaWdpq19" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UD+jgRzZV/HGdxWHsrvSl+WJHbUpEAj+BrNV9luGBtN95/UdAL+F20BbZ5O9xMgCjchMYcdnYXKlCx2qH6vRjNFhg0rJlJ0xuLbHYauOiUegvcEnNaw9Mr/RL+GCTJOaavABpgb/tHzjlB8vKd1l4iLdHcgY3bblpnNQg9s42GS6UEpqsY7stM/5CMbbLkrYaVK98mGzinCoaeYOw3KPqtHHqLZshaRUaVOtHyBtI2StWjRu0flzLzcRGJFTlbhpRJyTVWezA/MySQwdV/DgMmQwqEWESKqI2r2XohHMeagu9KehznZKT8zgIslZEmhk83UGgKT3UpuxEAtfMw4nmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FKGanad7+drHTEl33e2KHSYUTbwACe358IBP4DV5a2U=; b=OcMiGXb9fPWUvPvZs+Rdpzjj7lsqHi2KpBVO3FqqzSP4DjhBUfi+Sv565MgcALTV+Z4NT3rQyD+UA7D28OolCCjdO1dRWmprUck53XPLffHg5NQSbExGSoQTZ/QyEPYbgWzGJI0JXxPHjDNcf+KzCcNJv+uV8jB2p0BT8KtVddTSnvqZXDxFPM/haNEze9zfWt/EYd7f9zUo8LhNIGm6C/zs5GQGWQ9+0Wsy+k+W/XvroiNrhKasoQMaAa8PrfG7vMVgvkBIWRKSzt+3zSxYBgA2avRjEzAxnecIlsGYjxpBetNq1yYb7NzTD8/RO8eVzM7qOIYPM1eB9Buhy7kS1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FKGanad7+drHTEl33e2KHSYUTbwACe358IBP4DV5a2U=; b=jaWdpq19GEsoPSlvGi6kRhJvh6hJdErJ23bz81XO0f2gYL4MEAl0vVqef/d45/S4qby//wzuNq0H8OpiErb8RJOZ1OdaYigLEXuTyZiTRU3U2eykj8LqAe3aemeOCrNID6hQVzCpGkogTYBjKAcjdD0zHiWFSW1rz7YySRt91nQeFrIOV0bJ0PsoZUMZVmfnIKgQJFcgHWMDLdTx5Rhhttab3aPIsEZRgClnFZre82Awi0paz/7lfOdt3cVTlAv7Sxer4SBNY69IxHoP1zaklEHxT0+o+8j8u1RCI7127Prmn+h1BzAYdieuHw6rBSUapzXwtjT8ysyz4TrlWwan5A== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN0PR01MB10042.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:1e9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.27; Sat, 29 Mar 2025 09:34:55 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8583.028; Sat, 29 Mar 2025 09:34:55 +0000 Message-ID: Date: Sat, 29 Mar 2025 15:04:52 +0530 User-Agent: Mozilla Thunderbird Subject: [PATCH v5 2/5] HID: apple: use switch case to set fn translation table From: Aditya Garg To: jikos@kernel.org, jkosina@suse.com, bentiss@kernel.org, benjamin.tissoires@redhat.com Cc: g.sokol99@g-sokol.info, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org References: Content-Language: en-US In-Reply-To: X-ClientProxiedBy: BM1PR01CA0149.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::19) To PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) X-Microsoft-Original-Message-ID: Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3PR01MB9597:EE_|PN0PR01MB10042:EE_ X-MS-Office365-Filtering-Correlation-Id: 05312937-eada-4ecd-0bee-08dd6ea4f6ec X-Microsoft-Antispam: BCL:0;ARA:14566002|19110799003|8060799006|15080799006|7092599003|461199028|6090799003|5072599009|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?q?UniKJXY2Eh69z8cn3bF66pXvLZr/1jy?= =?utf-8?q?S24KtP889dl3i1QIPWYorzKfiKTo3b7Rz2GdgXSFDxCE3TElBPNC4ggo89MpBRVaF?= =?utf-8?q?AIoP0fBQx91nH5LTyD0QDJylTqcrMDBQZnwnUTzbVGFl2Tto/GjrKUmDLbwLM7ilO?= =?utf-8?q?V5mZHwC+17D5tQlnrjXv6FbipqeVcGde6rUlgfLo84ODk5QqKafuEOcLYcHnhTFsf?= =?utf-8?q?lp1RhI3aT7/4IWYk/BriE+h/YV21cwBg+DSSpCQfurZ/WLXLRt3DsUFSxRuNVnXqG?= =?utf-8?q?0RzZ66702JizgI1ePieYGBRzNQvQOS6JlOAH1y+B3VYHK42/p37f6l48KPc4Un+gn?= =?utf-8?q?wcBv7vjRSFvwdaFnFjcnyIy5leuCYdxbdIgjCoy5Kt/eFr7toh/+BVxF4RDx+wHxn?= =?utf-8?q?MO4RsNda41lijQYFpa8tt2Z7UeiOCzgT3Oq8MaSaJ+IhQCR/Bs1bl4EfckYxd8v9Y?= =?utf-8?q?4HSfPhRaK5KiVHiqGa1dABHfwVLdVw6oPdaXnY6lfUi6dalnUjDbCbSbSnocUi43A?= =?utf-8?q?+i++eS2KGGMrGD9xlfaVnsBKfYaPrDKFGEdUeSKzK/+WROWu8AxSnDPeNUFrN4ue6?= =?utf-8?q?Kt8gRumNFDWmKY/wL7RH+93PFVKBwMukk0CSSdh/aFQETqcHBihVLs8OwQq/ZhysE?= =?utf-8?q?qfm8Z3SgM++95LxMi3eiYXYb1EmIuTHnx3mrcd0baZCCtNZJ3NNCJX2C9DmtYdvUV?= =?utf-8?q?4I+0MkJ+I684aV1FRTN0o8ddOedK1pamJ6tHeQKDpvi0Df4JMmNwlnD425HDZ3hL4?= =?utf-8?q?c6nGhDdLInWuCpq7WV+7aTF0PeH4ZqH2RGvXVSwBRk2APPffjl6GPqyL9iCkUXgoS?= =?utf-8?q?2aPw74VBvqMmcj4BmDA2C+nBxhpA9PqnMmnqpnVShmw84qYpK8P3d3WaEitSjgTP3?= =?utf-8?q?KzVaOXMMQL4Abr7drgrQmpvHJwi1bYG3i/KRnXprYMQktNJqmUuK4IPM4Rw/WLLvY?= =?utf-8?q?Q3BjEi9IT0Wt1mmG1qSS090h95OaXJiUd6BJXy4PmuQuUS6Mbku0MbEVefZkXyUAK?= =?utf-8?q?nMitjTQGL0bDxjoQO/Ie3LWAUJ+W8katmNl7acQxOHkrYDUnbbMXsnTS4jLBNNfn+?= =?utf-8?q?Oe+1hUR8hfTFsY0iEL27qO9eG+UssqKPgBn7Iw=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ZAs1iErEEz9kfNG37ORda0wKLAEK?= =?utf-8?q?/SvS5cxizYwwJzqCzn278faKqaeTvZczECACZPurKdpwWZcFJGbV+oF43m+TPDBnO?= =?utf-8?q?u/UCpax21Q3iXikxi9DMepXkGjmKK8uEnQ0ZmJc3WcV0AwnzI1U4TEgRI3WLlDHBC?= =?utf-8?q?amdj7cqg1BefKbFD8f1NoXlSEAfzEoexkDng4q2bhxkH5oU7q0L2ixv/cSLQfu29J?= =?utf-8?q?tb4ENgspD47RnAYpuOZ3quqqSi6b3mfRaDPVIt+r1+Z4RUcQEC3OFXchke0hWieiv?= =?utf-8?q?aF/6fRyTvoQCywwC/xF007de8sqwaml05T2SrK99lPIpDkDlUKL+WRj1Lq0T1Va1b?= =?utf-8?q?yIMMQs1Lggp38T746ckXDMBtWsF/brAnrh9I2y9KzvgVQnuQiVRgZtVE/bfaFCR49?= =?utf-8?q?7GYWgM4E5Owu7e4Unjk6EYZGR1pBB7FVFvxUJDzI9jwH9HCMRHezM21lTf3CUapD2?= =?utf-8?q?BENpkohyh4EKIqzhtHGZnY+3mygdKiCpVp+awRFs4lzJLYZErdTowbmQrD9ikuKkL?= =?utf-8?q?zKhML6+j10XTTLPSnUiY66DTV9B7ai5XFUIiOklvGFt74Hwry/Czs+tX0DCe3mB8P?= =?utf-8?q?LvZvB6EyMhZgiYLhpXjZJwQCTH5ljM8dRW5jyrbSU12tSMWDLjI5e+oh8F2yGQk5V?= =?utf-8?q?0SMv2mPk1CDUCiBI/WhW1ySaSZz9dXvPxLM3kPDgonWFs1+wFpLlsNffwZ7ynkDQJ?= =?utf-8?q?WShAXKhPCd2irSe3+VpRMz7bClSzSvzqmA7ndEVLBIodbHgCppA04/0WZ4p9tYIjQ?= =?utf-8?q?OSsmA3Z6PPACE8lfFIJPguXZOnxAJDgMUL5NJJEZI8pfE5GpKco5FraUPHSR2xEBB?= =?utf-8?q?8YZrwQuRFQ/5kVFVzmawp3zhnKDkIYJCYl/2KEGakSo1SphHL9ef+5AVbp+6m876/?= =?utf-8?q?qrufG3QEXeGh7ECM7sGkZR5ftrW1N/qPOqp7Uf5LcxOCXUWBgrhQaQotj/uLV82Ed?= =?utf-8?q?FqRjCYyEqkjPF9Ke3Pw+DXyxi10hsGztOxVse50TV5B9K0AWhP7aog6uXXfAFr8ic?= =?utf-8?q?ZzgSblnOexsF1AK0zP3aPh5HDvUBq8QWY+M3UW5D48fo0zVnE3KHqx6kXYC1xthRu?= =?utf-8?q?kxpGL5G00e1eJmwxOleNYfGe1JTgwODQKbpiAExN0XnaDiNI0hksnFXGkQExSmZnL?= =?utf-8?q?nLmXUgMBw1nmGsWSd3ZgzWzDd1I0nSR/w6GUaFAvumda1bwheNdWY3THGl67vm+HJ?= =?utf-8?q?5LXxhLwUslABTlrpk55o7LYIjr9OWc2Qdh+upW1QK82XtFfgzocA32hsIjt2Gam97?= =?utf-8?q?cnx9vZkam9JYcrqF?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 05312937-eada-4ecd-0bee-08dd6ea4f6ec X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2025 09:34:55.4926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0PR01MB10042 From: Aditya Garg There has been a continuous increase in the number of devices requiring hid-apple driver during the last few years. Moreover, unlike previous releases, the PIDs of the newer devices released cannot be combined in a specific range, thus filling up the if else if statements with individual device IDs. For such large table, its now more suitable to use switch case instead of if else if for improved readability. Signed-off-by: Aditya Garg --- drivers/hid/hid-apple.c | 73 +++++++++++++++++++++++------------------ 1 file changed, 41 insertions(+), 32 deletions(-) diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index 93b990603..3d7befe0a 100644 --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c @@ -465,42 +465,51 @@ static int hidinput_apple_event(struct hid_device *hid, struct input_dev *input, asc->fn_on = !!value; if (real_fnmode) { - if (hid->product == USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI || - hid->product == USB_DEVICE_ID_APPLE_ALU_WIRELESS_ISO || - hid->product == USB_DEVICE_ID_APPLE_ALU_WIRELESS_JIS || - hid->product == USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ANSI || - hid->product == USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ISO || - hid->product == USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_JIS || - hid->product == USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI || - hid->product == USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ISO || - hid->product == USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_JIS) + switch (hid->product) { + case USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI: + case USB_DEVICE_ID_APPLE_ALU_WIRELESS_ISO: + case USB_DEVICE_ID_APPLE_ALU_WIRELESS_JIS: + case USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ANSI: + case USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ISO: + case USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_JIS: + case USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI: + case USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ISO: + case USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_JIS: table = magic_keyboard_alu_fn_keys; - else if (hid->product == USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2015 || - hid->product == USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2015) + break; + case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2015: + case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2015: table = magic_keyboard_2015_fn_keys; - else if (hid->product == USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2021 || - hid->product == USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024 || - hid->product == USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2021 || - hid->product == USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2021) + break; + case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2021: + case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024: + case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2021: + case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2021: table = apple2021_fn_keys; - else if (hid->product == USB_DEVICE_ID_APPLE_WELLSPRINGT2_J132 || - hid->product == USB_DEVICE_ID_APPLE_WELLSPRINGT2_J680 || - hid->product == USB_DEVICE_ID_APPLE_WELLSPRINGT2_J213) - table = macbookpro_no_esc_fn_keys; - else if (hid->product == USB_DEVICE_ID_APPLE_WELLSPRINGT2_J214K || - hid->product == USB_DEVICE_ID_APPLE_WELLSPRINGT2_J223 || - hid->product == USB_DEVICE_ID_APPLE_WELLSPRINGT2_J152F) - table = macbookpro_dedicated_esc_fn_keys; - else if (hid->product == USB_DEVICE_ID_APPLE_WELLSPRINGT2_J140K || - hid->product == USB_DEVICE_ID_APPLE_WELLSPRINGT2_J230K) - table = apple_fn_keys; - else if (hid->product >= USB_DEVICE_ID_APPLE_WELLSPRING4_ANSI && - hid->product <= USB_DEVICE_ID_APPLE_WELLSPRING4A_JIS) - table = macbookair_fn_keys; - else if (hid->product < 0x21d || hid->product >= 0x300) - table = powerbook_fn_keys; - else + break; + case USB_DEVICE_ID_APPLE_WELLSPRINGT2_J132: + case USB_DEVICE_ID_APPLE_WELLSPRINGT2_J213: + case USB_DEVICE_ID_APPLE_WELLSPRINGT2_J680: + table = macbookpro_no_esc_fn_keys; + break; + case USB_DEVICE_ID_APPLE_WELLSPRINGT2_J152F: + case USB_DEVICE_ID_APPLE_WELLSPRINGT2_J214K: + case USB_DEVICE_ID_APPLE_WELLSPRINGT2_J223: + table = macbookpro_dedicated_esc_fn_keys; + break; + case USB_DEVICE_ID_APPLE_WELLSPRINGT2_J140K: + case USB_DEVICE_ID_APPLE_WELLSPRINGT2_J230K: table = apple_fn_keys; + break; + default: + if (hid->product >= USB_DEVICE_ID_APPLE_WELLSPRING4_ANSI && + hid->product <= USB_DEVICE_ID_APPLE_WELLSPRING4A_JIS) + table = macbookair_fn_keys; + else if (hid->product < 0x21d || hid->product >= 0x300) + table = powerbook_fn_keys; + else + table = apple_fn_keys; + } trans = apple_find_translation(table, code); From patchwork Sat Mar 29 09:35:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14032640 X-Patchwork-Delegate: jikos@jikos.cz Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010011.outbound.protection.outlook.com [52.103.68.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D6862AEED; Sat, 29 Mar 2025 09:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.68.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743240945; cv=fail; b=T/ektEVcAJYT1+qF2C3tqU2nJoTOWDeXLsizOIYPRk3hH0iUVuac6m12H1Rpu25kQJ5nI+YRwVF2RqxPVoiIPGmLl7JfkWkse2gLmRokgrdW9L35b6cgkEuG7jJHrXfvnsUPAC8pNybOKWcWxrxhko3ED/NfZRONGOYVPVPXT2I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743240945; c=relaxed/simple; bh=Uao/vznF7YPzQjjvKQ/e4G+dYT4N981eknNNcO6OVi4=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: Content-Type:MIME-Version; b=j4/4ntbPTT5Qdbxb2XYHAyi1TW7+y9eCTFxwYfsdYENuqgEea472oyXEbdMDWu8rJgP/xvXcGNZxOOHGsY7Gx2Otb5xJ+3iPEcCy78KhQ7M0P6yOLewCPFdLVSbBen8TEFxwiug+7IvQq9I1Nl4AFYQ6rTTVp0rfWfGseQv7D/k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=k/iZRzkl; arc=fail smtp.client-ip=52.103.68.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="k/iZRzkl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xckDG/SLK5g427+c0MqG3iegAxADXcVlZjaHEnUPfh5vd3RJyct0Gjc66/J8caydAlCTc9yqWVzcUYLrn1U97twY9uAUBPg2HJhKjk0JOMaUhgMIG8kF5m4eKmMF/R3F8tOJku4KtC5Nk4lXnmIj5Yc2001MauyCOlAdOg4XBxevWcH7j2mJoR+XDg8c8CRaeUvH+Xsw4X02lHNzV+LznxOQLaxgjmZEWk629mPqvDpVVR54knroC66CsSoTBno68/SL1wohIEDdrZkomVpX0sAoJ3yX/j+1dXHsr784HfIojroOGv/NFaSYAeyuOBG3xQ+3gqbvF+vy+8yPDRDeGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0PFcD4dPmw5tMmpyN6Ma3j5dl2+e1S7E7ca/EbbGmoI=; b=STVpIUGrc2w+tsQiXUUZmiJYFMVr9i6eNqZJ5OnM+ITt06iMA320YLCWntJjyjSnzqiy/Vf6C4Zhcf4q9QEzB0zbg0bhTOdDvBZeap+lGahCrYgF/ei/9D2NNAWGp5pdvBylCm7o0U/v7iVtomGPl9Xa7yZpk7g9yE+sD0rm6qVMzKNHJWxd1qFtEYR5A+WdHtAFbw9V/z5N3im4a4DT5TRwT2JPKlbJ2QQyMUKGbZcMk7/Y77RdDs6VasJiTUNwAegWv012gR+bqvIGclKcmpvrdWuasECFirR1Aq5qftjoj2+bXp8UYfkmqHsF4TGxXwe1WQU7oNZzFWR6/SwdrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0PFcD4dPmw5tMmpyN6Ma3j5dl2+e1S7E7ca/EbbGmoI=; b=k/iZRzklI7WXjRIn8GSbL7FzPowVdhFNO+9ACWovOCZeCGs6MIcaG7oXtyXa7f2dIFQ9ecQboXLdX6hUPm9v2evV66/Iw7R2vfVxzIb1oj+7JRBUNPCrjVrrphOzukFK4g2sBWDXx+qFu5KJ9f0a2a76He+e7Weme/1Rm1PvdO0JiARtCuc2vZ+3vrNpi7ru2jd9QDlt+VSUWxEQFx0bZFol0E1/5L+3Gip3UiRRDl6prAGUvD24fGQT97Bf+1wosOlyopsD1ib7k5OBe4dMWpkVYMcT0G5NtRJGbZA7KIP4DavQa/1cWimZivm0lMICeKLKNDjHlocdoMUeX13mrQ== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN0PR01MB10042.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:1e9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.27; Sat, 29 Mar 2025 09:35:38 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8583.028; Sat, 29 Mar 2025 09:35:38 +0000 Message-ID: Date: Sat, 29 Mar 2025 15:05:36 +0530 User-Agent: Mozilla Thunderbird Subject: [PATCH v5 3/5] HID: apple: remove unused APPLE_IGNORE_MOUSE quirk From: Aditya Garg To: jikos@kernel.org, jkosina@suse.com, bentiss@kernel.org, benjamin.tissoires@redhat.com Cc: g.sokol99@g-sokol.info, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org References: Content-Language: en-US In-Reply-To: X-ClientProxiedBy: PN2PR01CA0244.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:21a::13) To PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) X-Microsoft-Original-Message-ID: <9bcd5d50-42d1-4188-9dc4-86bda5ad95f8@live.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3PR01MB9597:EE_|PN0PR01MB10042:EE_ X-MS-Office365-Filtering-Correlation-Id: 18ff6a04-70b5-44e0-43e9-08dd6ea510d0 X-Microsoft-Antispam: BCL:0;ARA:14566002|19110799003|8060799006|15080799006|7092599003|461199028|6090799003|5072599009|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?q?o4QXdiw70Gkxvu/4eZ7jbAQ8es+7phB?= =?utf-8?q?yEwFOVmIZzrb0AQEZ8KPH3+2I25zlnbkugNXYuM24iHHXupCF8VvP3ZYiPtZan8hK?= =?utf-8?q?Il0pUuyafoPUo+M3bQlmL2qfW0vF3GKe6358np8MGzomlxuJUgyWBleEPKjkV2eYA?= =?utf-8?q?4B+XLxq8zHHFuT/PBtNY4JOUU9SfMsuiY/TBynG7oqiaQkQ0QaORruJwqha/UtTdr?= =?utf-8?q?SUrdr8qTM+ZkL3HCkDkNyBTtkRDWe4XLclyhh4zEDV3rsI0mUJwQg+wftChrg7wUC?= =?utf-8?q?QTNLcM/ky8JV9m28qQSONqOUfUVdWXAaVftug4xyVXW9Mntmm//KU/ej+jVhgpMvK?= =?utf-8?q?fdr8Vcfvo5P1/iWRoL5xs3Z3VqoJ3FdsIexEbBpVcrmx9FBI+b4pdOPDIEiMFQ7BX?= =?utf-8?q?3KVl7YzQyXwYU4Ls9CtGgxsmR7uTIBYuOOQr+R5IuArbk5uckW024gGSo/8SPsK67?= =?utf-8?q?btZWcQUxBTn0+wFRVg++MfEOWWyGbycQ/7aI9OTKOmecOJcxjYlma5bA7CJU/gry/?= =?utf-8?q?cTrrknVH1ne5VFQKX8sG5Zjvx6F5SrlxM2GHVK7k0jGM/hs4UF119ujsnGEH53j4Q?= =?utf-8?q?IQcXSqCgtQRJ11SfS3QALI9/zAPQOqJHkTBwAOz5LtbvNrQ8Q476NGlXatiWdIKpT?= =?utf-8?q?QLOj9PaaZzGIOqqSPSN4rLRm6JmHz0yghwziCYuFx5AGcsQwHsTI3+p1+Dz/egIwC?= =?utf-8?q?14s55mmM0fELRQ20dRBPzu5PCY8MsnoBYsZ8GQeh1xZwzR/1aWrFqJGoAX4W2ygzu?= =?utf-8?q?QvGoRFn5JvqlNvJjbhPAdqRwvy4AE4tK7aQg4mLddksJMORwGZZMNDwSfNsBkV6H7?= =?utf-8?q?+SXOkJIEJxJfY9EuAE1qi6F+JpmM93Tvp3fDTj2H8OHKkKeOdDJrOZdKAp1NfmkC4?= =?utf-8?q?Pd+fPw+iQ1OuYiHRwcnSjqSAd8pSXouV1DLyMdOLqUAbDQOjYBWFR135yFaZwyfof?= =?utf-8?q?+IIAMrcp9WexENa0av4XUt03MAJWFM8JV3nX9VXDmS+DFto8BYeubbDjwSD2fobMb?= =?utf-8?q?Bb9SAV/bpmlrxvtg5ZCERLFFNLvCR08YvHXyBtIM0LzFbySORqAZU07nHcKPGWsLP?= =?utf-8?q?E1QXGCjLbUllm1EE7VSusrNk7EpVSWDgKIZ7ig=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?qSL7GwUqAvSaOQJ0rOugcbdG0EO6?= =?utf-8?q?su/n2H4y7T0GuT9WNtz72CV6w+48ZPKet0bEE9f1sNqM73m7pgJEv+AiOSz9cXm2I?= =?utf-8?q?v4ypIfVIATYnigWGu+D2BvEM8LxOrVsNdes2wswwCLPuQydsCk7ozH//OvdP/w4kA?= =?utf-8?q?Ju+0D906RD3jz9HR0nKEJURhSRz1KMOGSK61ZYF6P8ObpCGFZKG7X/hzq0ttseLsG?= =?utf-8?q?WJKMpmXWZArScP3ZPzV+pVOCfOhj09kBkwIsv0pGf8aqbfBCeYQn5jTUbY2dy+tXT?= =?utf-8?q?N1UZsHKeY43K8pjsQt8XIQYlN54nbD/GM0t5nQ6Z453l0JhtB2wIdLqnDGtl69N84?= =?utf-8?q?2d3lTwRNSrC1OlHmSJE8oepPvrCh0U8x97YBsFSOFhhUpaiJh6Z8JHbloct+7d6V7?= =?utf-8?q?cYi3GITzSYzL/k4XQwyoQ4yjomRVlu6htq8oaUXZnWa0YsG+JwAHwVE0Iv21gVtsT?= =?utf-8?q?bzkGJ0DcaIkMzVj1Ap5RHrSB/rsfiQ0VpaOAElMB01OIYQvwE4FAuo1KD/WYrxzjA?= =?utf-8?q?37scDatFnWfR6XS3jT1fNECIsMf/dmPagYh5REs6U/MRxjKgBHUpOP/LBUpVPQrdB?= =?utf-8?q?H4jNmipY+Z1Lsx2HKWSiaSlLe8o1dBM6Tb5j82VAwPPGOsE0nk9jPHMxBDxb1Wlby?= =?utf-8?q?nswDn2SSCwgnY74housL5OzMQfKttt27eHhNhIH9uM7XDJOwzPSz774H8Lvd7MKhx?= =?utf-8?q?MaVWexv3G1sJIChHbDhh3i9OZEXVd5IFdCgrsx0HCYNzV9+4BGoxBu+FJA5/Kxj3T?= =?utf-8?q?HLW4FTCNZd84zQunOTWyaYj5aiW8P8lJJir+8ygHzOTBpTXNz0oEU5LNsLMsdS9Rl?= =?utf-8?q?aodv6ugyxwmkHW52DyPgSnpqhfrBfHQk8ZZqut7/kxSg+LoSSPXKA6AAd1/Pf6oKL?= =?utf-8?q?TE8PqVRitPLuggrzpO7t16nb99Th/+xKkA/2wkQCa0wWgdFmYIID1RY0NmK4cQIQi?= =?utf-8?q?fl2TvpUoap0GzNgbbmrOB6v8fwFxP9ZuWGM5hXjTvNC9CUdMXdNs8xvgs7XAh5CMz?= =?utf-8?q?QZHigzhl431RNKAKBSfHvD3ZkEsbTuPecBtxFFy5vGv7By8YvpxqUSsHdpZUVshhN?= =?utf-8?q?yB2cWEr0QLt6YhlkK47KW1ioDqP/647ZendQukGu5e5q085GwYdajEuyOvFKDowpD?= =?utf-8?q?5MOpVi+97mAP70GdJkPA1b9WWTAaeG1o9qq+v4Ts2ekbS6WHglgjz/OxrKGW3K40v?= =?utf-8?q?klCZKPgbvuJcBZDOAd4Eya4R6f/EJRngb/8sWlDJCfI+hLdGS7VF+SWc9KQ6slrrW?= =?utf-8?q?AO225ZnMhwHDuc1B?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 18ff6a04-70b5-44e0-43e9-08dd6ea510d0 X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2025 09:35:38.8963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0PR01MB10042 From: Aditya Garg The APPLE_IGNORE_MOUSE quirk was not used anywhere in this driver, so can be removed. Signed-off-by: Aditya Garg --- drivers/hid/hid-apple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index 3d7befe0a..fde438bee 100644 --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c @@ -30,7 +30,7 @@ #include "hid-ids.h" #define APPLE_RDESC_JIS BIT(0) -#define APPLE_IGNORE_MOUSE BIT(1) +/* BIT(1) reserved, was: APPLE_IGNORE_MOUSE */ #define APPLE_HAS_FN BIT(2) /* BIT(3) reserved, was: APPLE_HIDDEV */ #define APPLE_ISO_TILDE_QUIRK BIT(4) From patchwork Sat Mar 29 09:36:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14032641 X-Patchwork-Delegate: jikos@jikos.cz Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010004.outbound.protection.outlook.com [52.103.68.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44918188A3B; Sat, 29 Mar 2025 09:36:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.68.4 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743240982; cv=fail; b=XNJSYExDHg0lHKAANV7nVmDKJ3phDAs6XPSuMWERyIw/NFic7RLAxM2OdZGc9AW9605Yw2pN9+Wr6o7sJfMdZEpT8mOqYNoaXr5DahogQk8SEImnM04HyqXWyv4V96iWAsLZs9ohzIUQML/oJBm/0YwsIPlTq+DooVaqAaBBAaU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743240982; c=relaxed/simple; bh=b37/FPgu82P/p+dt7dm6jL8PHu/l3c16LCQ7H8Wt1xs=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: Content-Type:MIME-Version; b=em1kFQGUhhixYPTOymm3kukLtR5len/Tq/BsA1xpSJ7p0yadw3TW2KNbCexOlM1f7O7A7gF6890zaJAL2qhKL63HL0orAPe2tkjKbpv/lwcwCv+JAF5G78rLJ2KWUday9PEZufvs4vs6n9Wcce9X9/T8/IYXeLN6QUOduRCuVEs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=S5PKz1Qa; arc=fail smtp.client-ip=52.103.68.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="S5PKz1Qa" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q9s7hOwtP/DBvnSGqMvHzqHyBk+KCv9D1vIBwgvrhscyWGMc3uX5N1bC2ojRAs3f2LGTF8zDtMx5UjRceR86SQAZBpqeeTs5vMc9b3izCYUfNCAk8cWYj+9fRnOXfLNvBh/fO+XCjXeWxRW9huD6VOwrcfULIik/T994LR4KtEvA9QtEujM4H/YxJsv3Kig+EK0X1ThD8hKTbYLY3iLYS7LJIp4vJtmRAB2gaLxl2Hu2aS4SRaawkcJjLA8EiS5PhVgAM6YFRYacxJEq+iIe3jIlKjDZeVoNUO8FlHhZEWd932HZPOIHfZgS+2sH5QPcvs3gl4bX57JhkjTKrLeWeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MNC7MN9Y10OcKnn4KzodRFpVn3mMlPo87kxfSqxr340=; b=tKaGRjCO7nAZyxyxazqh4X5RSox9/37tGj5BqXGhouX7mekOr7mh1TKj0P6nUw7H3l0eooNnaxofH1AB35QafJ74CNwJMvfxzVIo4kj4JJTPVEk1tQsek88dxdX4DrJZW8StJVVTPChD5xQTbywlmMdSRqI7ZLgSwf0DHsScM4IL0R924Aq46bonIyhjhEBXuCMXfXAd2XEwhebZ8JACWrnM5IoZoybx6yrhSaTtp/x3TwxpKDg0ublZFEkGx/MUt5xgU3qUbt5if+tASVNwTSc52bMzgfdw/7fxDt7klYK/Jzaag+C7z1i4Z8QxLFB3XxAiJBa7aN/a8Oky6MrEMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MNC7MN9Y10OcKnn4KzodRFpVn3mMlPo87kxfSqxr340=; b=S5PKz1QabOkubUPB4JPQZiNhZigNEjJLVMubSSRdoCJ+vleouYv7z7V7XxswJm5s1glWao3UwXpuEkVk0NJKVqsW1h87KDxFnmZJUl5NmMdZZzZjKlQ/G6YEya1F5YwUzkU4dWZALvP2hk+9mIMka6bL48t9GSy3RfOLoevlgzM3G9UyppIK8sP2TEPAFJn0UyuaGb5NNgEhF7Re9GsNiiR9RoX+shhw6jgWBBOIhXLvT8/G0sm4g3hHMtv2T0nYOIWc0jG7rzS7uVshTV1uysp+OOuL9FTsou6AMysXTrjPMmpM83Ea8K5xKcKwL8b6HWcZ+EfDR8FrOkh7ezYO+Q== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN0PR01MB10042.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:1e9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.27; Sat, 29 Mar 2025 09:36:15 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8583.028; Sat, 29 Mar 2025 09:36:15 +0000 Message-ID: Date: Sat, 29 Mar 2025 15:06:13 +0530 User-Agent: Mozilla Thunderbird Subject: [PATCH v5 4/5] HID: apple: Add Apple Magic Keyboard A3118 USB-C support From: Aditya Garg To: jikos@kernel.org, jkosina@suse.com, bentiss@kernel.org, benjamin.tissoires@redhat.com Cc: g.sokol99@g-sokol.info, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org References: Content-Language: en-US In-Reply-To: X-ClientProxiedBy: PN2PR01CA0252.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:21a::11) To PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) X-Microsoft-Original-Message-ID: <8f924e4b-6d8e-418d-8cc7-e723d19ea7cd@live.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3PR01MB9597:EE_|PN0PR01MB10042:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e7dca9d-c98f-4136-c3e3-08dd6ea526cb X-Microsoft-Antispam: BCL:0;ARA:14566002|19110799003|8060799006|15080799006|7092599003|461199028|6090799003|5072599009|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?q?3Bt6TLiMKsTJj0vDQr8w1zjsMRUwIez?= =?utf-8?q?ngliMgaMYz0z/21HPkiOQ3ReQz1xcHo0kUb5u0Wcp2dKjscvlFZGFuZkhDdkAMikg?= =?utf-8?q?jvVEdD/H9Sigxhepcun2NiXgv2K+mq8t5BePq8tcbUJS2x1uwaHsaAmeS1BXs8t9t?= =?utf-8?q?L5gyu3HRuh77SE1QFJbOTemK5Xo6zcs36LK4D8AZOQY0ZNuMnVzuxPBTwVytc/lde?= =?utf-8?q?QDnSdunpXMinNdYLZWaVakaVX7PGaA1tR5TBkQNulp25WTT8r/bUx9YSIn3uRdpVP?= =?utf-8?q?7/cXehwI/TVq+KXhyMQnGjZKiFInpo90L4J93bib0cuYHbwTrgUJINe0YFigaOole?= =?utf-8?q?PFgC8rErymJodIo/w0V8yq+1ENuEW56477oAtxzgASQiT3TGThXtSP1/7A7JtwLVa?= =?utf-8?q?D+5fT/P+2+VT+LAalEdME2x0icxAX66z+c1mECweL57NMEsFKkm99B0kmZ5NQ7Vht?= =?utf-8?q?7CwYKirh8Od6OFvt7Xp9jSY5DixF6TN03IpjSMKuXtElwMeKo1NoS1PZSn90dMXLN?= =?utf-8?q?snEWr5zgQSklHa5y/Wy5F5lfJemqchg25Q7eBHIOaXHtQmHXxlRI3hwRiD7YGfMmV?= =?utf-8?q?zr/kGW+1/Sq9aSpHfe6K1N6VEq36Zg0kRMbr1z+qAWLf1KqPTzA+nCLiFG8GWPS7i?= =?utf-8?q?zhBmZY+HwttPloCKIoq5xHBNwK+uTn042qsjBE6so56Jl9Evk6CGaLWG283pcLUgB?= =?utf-8?q?KHrAWgGIFJVCmi1vaUH35uB4LPK03p+0dTI3l3lXxeWeVDIDd9dVhj2zNcwTCj3xR?= =?utf-8?q?zg6flEwSVv/ZOalnWZ7cQFRhHiKtyg1UqOjZlTtdBKXK7e4x8cClJuOh419e35/b7?= =?utf-8?q?OX3drJqs8wHiU4TiNspoIU577CqZ8Hdfv1zsNZd2SaQXv2v/TmrYkV/3MTG9D2T+A?= =?utf-8?q?DFGglgDptWzhTDqWHuhFECopZ9rmfwJSIOZnJvYxcCDGf4/g/uKLvWEt5eUMs58Hp?= =?utf-8?q?ztSFA44hymIf3pxPjOEE7hUFwhUaDuIJoqCNqRU+6wFrYtfe3FMA0/CX15fecsh2L?= =?utf-8?q?yLBqSMd8fTA8/MZ9+FBXuKzpF+b7P5bFuDuzgTgAh2afUZurG2JATqgHws580Hecb?= =?utf-8?q?kXAxexCa/ueLRuinIBaSBpEftAmxhtR0+Vmlig=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?0WfunPNSTpg+ep3eZVszb1tLWgsd?= =?utf-8?q?9CR5hbr0Sma74g4YXXoXLzvMVt/Y9/z12jXBraKlm+T7XMniN4fg33sBQYSatPruy?= =?utf-8?q?TML+Tq3h/oLCKMni3eRfOmsCOzbjRO31y8dxhdQK9KqSK73Q02/suwUsUMs5VI4KX?= =?utf-8?q?DWYWWy2AT6cMr0g040Evo4aUT1gt10SSzuKltb9D5G/ke+/e2FzVy3agu4IxtaG9k?= =?utf-8?q?vBSaREgQqiXO0iH6uUx3gDyrpPsrFU3o+sPvsTrkOw1ksWCT2aOqtJs7ncokpYFdl?= =?utf-8?q?43E+4uMrPtxbNNQ0wzatmPekJ/E3a11+tfhkFHTghiMEQ+4my2rmpiCX5fu6Lu9lj?= =?utf-8?q?GbjOhOv6JRK9u7af1fcgHp6+EeiZPkqElksQW39Kn+WZ+Ff/G7yt9o3x18P/zZpIv?= =?utf-8?q?/lnJGaCplzvWD91aTIyGDUfmcUsRxqa75AWaKn8/3QPD81g8cVsDxjKXl9bBdqfkY?= =?utf-8?q?NySrBZ1st7blxCjlhkMh+8B14EzVkGnUlTNheszWqZM9xP5VwdZc5tXwvK3HxzQZ2?= =?utf-8?q?OOJNUhtHynHN+gMCSsLOtHW62aTITxbQQyEyVlRy6nygIMFYbuU5VRe9eSl0gtqF3?= =?utf-8?q?9eTn0YhYsoCyPtZ6QDuLGyNFCv+9RnFv4YqlXTYbQ5RFBno09zdf65mnIvukus2y7?= =?utf-8?q?hTNdeo1QOc2l0y0jBmZmD5ljgW8yiUz0z3vxfkY8APaJURVYcX336pV7qomXFDNO8?= =?utf-8?q?hIJ/BzoQrWIb9qENq9cPtSAc7AqUP6vtX7nQOagO6l9zsQUeptqiQscgbqfKUPo7N?= =?utf-8?q?UEYdYR9SaqC2W8smyPsIRQmFcbqvzcVo2/ThzM/95IsQPlPP6tgDZKQaIV8l5Qh9R?= =?utf-8?q?aPez0tDztmmh9AZN6kqUONxqPdi9g6jZsFgLbdZ3HtrCgQOQOCfX6fucWmGfwHQN2?= =?utf-8?q?lFpw5fV+42GM5FQ/I32azMsRlOXg7tJ3c6AUpSNh9ePMQnSHC8M3ZRh9mAQqMbivR?= =?utf-8?q?ZzVjPoOs/lXEslquDfW6Nw1UheVI1iZ+fRpURUrS+naIcH4eJkt4kwYWTd0GmupmU?= =?utf-8?q?1aS+euP3tz5jvLu5j8dVJAlWgKfxwGpQNozdhfTdW6GZ7qsPXl/i8u0JCe4mZG6KG?= =?utf-8?q?emtuO1WsRNqphAyKXwH/yNaHwGkUz6H1VmQTL/vmtsfXZJrawdWYiSmsIa0rdttbg?= =?utf-8?q?pkiHoW0rYEQMUzATaZKeyxwEdp4oYtalNTseASYVE3ShZoYqTFNIuGbNpcY594WjM?= =?utf-8?q?EAZvuwfB3GM+InVBAzDoyzskUK+NZnGvh3wEpuGByOfVAi68oRnelJ/cfpr7DX1EJ?= =?utf-8?q?1EuKCOsnldH/byf2?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 0e7dca9d-c98f-4136-c3e3-08dd6ea526cb X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2025 09:36:15.8081 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0PR01MB10042 From: Grigorii Sokolik Add Apple Magic Keyboard 2024 with Touch ID device ID (05ac:0321) to those recognized by the hid-apple driver. Keyboard is otherwise compatible with the existing implementation for its earlier 2021 model. Signed-off-by: Grigorii Sokolik Co-developed-by: Aditya Garg Signed-off-by: Aditya Garg --- drivers/hid/hid-apple.c | 21 +++++++++++++-------- drivers/hid/hid-ids.h | 9 +++++---- 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index fde438bee..e95a54113 100644 --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c @@ -165,7 +165,7 @@ static const struct apple_key_translation magic_keyboard_2015_fn_keys[] = { { } }; -static const struct apple_key_translation apple2021_fn_keys[] = { +static const struct apple_key_translation magic_keyboard_2021_and_2024_fn_keys[] = { { KEY_BACKSPACE, KEY_DELETE }, { KEY_ENTER, KEY_INSERT }, { KEY_F1, KEY_BRIGHTNESSDOWN, APPLE_FLAG_FKEY }, @@ -482,10 +482,11 @@ static int hidinput_apple_event(struct hid_device *hid, struct input_dev *input, table = magic_keyboard_2015_fn_keys; break; case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2021: - case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024: case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2021: case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2021: - table = apple2021_fn_keys; + case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024: + case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2024: + table = magic_keyboard_2021_and_2024_fn_keys; break; case USB_DEVICE_ID_APPLE_WELLSPRINGT2_J132: case USB_DEVICE_ID_APPLE_WELLSPRINGT2_J213: @@ -690,7 +691,7 @@ static void apple_setup_input(struct input_dev *input) apple_setup_key_translation(input, apple_iso_keyboard); apple_setup_key_translation(input, magic_keyboard_alu_fn_keys); apple_setup_key_translation(input, magic_keyboard_2015_fn_keys); - apple_setup_key_translation(input, apple2021_fn_keys); + apple_setup_key_translation(input, magic_keyboard_2021_and_2024_fn_keys); apple_setup_key_translation(input, macbookpro_no_esc_fn_keys); apple_setup_key_translation(input, macbookpro_dedicated_esc_fn_keys); } @@ -1165,10 +1166,6 @@ static const struct hid_device_id apple_devices[] = { .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK | APPLE_RDESC_BATTERY }, { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2021), .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK }, - { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024), - .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK | APPLE_RDESC_BATTERY }, - { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024), - .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK }, { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2021), .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK | APPLE_RDESC_BATTERY }, { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2021), @@ -1177,6 +1174,14 @@ static const struct hid_device_id apple_devices[] = { .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK | APPLE_RDESC_BATTERY }, { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2021), .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK }, + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024), + .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK | APPLE_RDESC_BATTERY }, + { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024), + .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK }, + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2024), + .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK | APPLE_RDESC_BATTERY }, + { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2024), + .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK }, { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_TOUCHBAR_BACKLIGHT), .driver_data = APPLE_MAGIC_BACKLIGHT }, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 288a2b864..8682e1b11 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -162,6 +162,11 @@ #define USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_JIS 0x0257 #define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2015 0x0267 #define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2015 0x026c +#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2021 0x029c +#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2021 0x029a +#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2021 0x029f +#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024 0x0320 +#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2024 0x0321 #define USB_DEVICE_ID_APPLE_WELLSPRING8_ANSI 0x0290 #define USB_DEVICE_ID_APPLE_WELLSPRING8_ISO 0x0291 #define USB_DEVICE_ID_APPLE_WELLSPRING8_JIS 0x0292 @@ -183,10 +188,6 @@ #define USB_DEVICE_ID_APPLE_IRCONTROL3 0x8241 #define USB_DEVICE_ID_APPLE_IRCONTROL4 0x8242 #define USB_DEVICE_ID_APPLE_IRCONTROL5 0x8243 -#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2021 0x029c -#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024 0x0320 -#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2021 0x029a -#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2021 0x029f #define USB_DEVICE_ID_APPLE_TOUCHBAR_BACKLIGHT 0x8102 #define USB_DEVICE_ID_APPLE_TOUCHBAR_DISPLAY 0x8302 From patchwork Sat Mar 29 09:36:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14032642 X-Patchwork-Delegate: jikos@jikos.cz Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010014.outbound.protection.outlook.com [52.103.68.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A35219004A; Sat, 29 Mar 2025 09:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.68.14 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743241022; cv=fail; b=IPn9MrlX+lGzupAFbVOFVvdnkuFfRLq6dfXLN0REeHjQ0Ihzq9i5K4oOp6zjOLdpgDdhxtLFiGbXdtwrF3zSMjzO7SJfIfIZshDoWy4cJ4btxfOyQnR2nG16EihNAE1QOvgopAV34qnNj20AaSO5lNgFwIOIVm0Z3ab/MszXy4g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743241022; c=relaxed/simple; bh=y0jHra9XgMcl2ILOdu5UwGrt0Bl8EFarotMqjhbIiUk=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: Content-Type:MIME-Version; b=nLGnoaO03OFOcZpryTv24P5dKB4LAbBGQdzGw7fOGAl9BI86j8HmvaFoZQBv84cK8hzs1GtmLFMGmm8kRJ8mxoO5bfUC2Z29pzIjvnyFu33MR8kQNLdpoHjszEbNJ96qXQX8+GO7LTX9wwpZ9fu31S8+03/G3TNjTPjHRAqkPmY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=RtE2/cHQ; arc=fail smtp.client-ip=52.103.68.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="RtE2/cHQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=clBM8j0P6F+0MHztjQYzOCOSQWkMcvM8SghF9qEUrEENjeS0iNtuRb/6tmbHmgQ5PomOR19RFe7hA+H/9NFNnvf7YHJ9KmuuUGRljmyKaotiHEFnTUPwWgsWBbHIo36r0UGsWXEUxIy/IOlJH4s7Zw4RTZbNAFPNeI1SfZegkZ1OuiZjAqS/YG6XXp/BA18GX0WAaRtKtYDYexJa1/V6k6YHniIMK9YSTOlYsHA2R9hxzbQenU240dS/uQGg+I9UTOi/16D3thCeUnZkdyrU04L5q4qdsKYAek1XOx8Aa9lgyulnlPvg4VZrMr4s2bLEo5H9rHi6yY16UnK9oA/Ycw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z9E3evAXFtqh3K8HqsNk/YDfqH3XprhMB7zuawZtJAM=; b=mug0G+tQkRsglxuim6jRqpwIDqvc8iVV0Xk/+zvNmV33v8VNO4okbJCkwmwQLX/HqFsSDPtqUZD6sJ6u8AX2SLO0sWYzsUfpBIjVO7gC1J5xehJa035AUxwWm5EQ/AeSHNsaE4AeJX1nswYwtVzBPIifcjnduw5wHIyc1KvghFzIY8K+v26+GoBD5u/H5hu47XtFU9CmLd8C3wBD/ZtMlPc3oHppI8c/Z/OOHCjJnuVpa5P7oYGqHrAJ9VpCdl14CHVXrowvEyXwFeSncoti0aK2WSMjT4Aq/xRs4GIs9JCiKM9/ehR0U+qS3kLno0kESbIu+o/nAzleDsvY9NGxSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z9E3evAXFtqh3K8HqsNk/YDfqH3XprhMB7zuawZtJAM=; b=RtE2/cHQ7PYKDjxRgjQBaNRmyM+ZnUsihEVGdw5oLwcjB/rQRiTsJrAY3jPOR+X+6vtnPmxgZuPXzUKIJHXRLkRMsWLYMINTg6HNpM9hzyC3I+xpqPLr+kYnB3MmQvwP83JNQ1tYI6lMXKcaIsoSYRYmg2F0gJX5JTV9D529AN4ln1tTzfreVGtU/mkxUBGW04AsqCCUxAeFim06eT7GueMEpM/hLi3xihjeKrrNcyXK/XOLJH9d0K3ESkSJ7HZ5fuO/e6FHs6jtRbPd+lbgNzykBjHt4xz2B1dlwTkKobrB+GeIa1LCiH4MvZdkTbmbBKQbdzXUer/0q9QPhJ6lFQ== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN0PR01MB10042.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:1e9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.27; Sat, 29 Mar 2025 09:36:56 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8583.028; Sat, 29 Mar 2025 09:36:56 +0000 Message-ID: Date: Sat, 29 Mar 2025 15:06:53 +0530 User-Agent: Mozilla Thunderbird Subject: [PATCH v5 5/5] HID: apple: Add Apple Magic Keyboard A3119 USB-C support From: Aditya Garg To: jikos@kernel.org, jkosina@suse.com, bentiss@kernel.org, benjamin.tissoires@redhat.com Cc: g.sokol99@g-sokol.info, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org References: Content-Language: en-US In-Reply-To: X-ClientProxiedBy: PN2PR01CA0053.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:22::28) To PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) X-Microsoft-Original-Message-ID: Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3PR01MB9597:EE_|PN0PR01MB10042:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d927c83-1a2b-4c32-8610-08dd6ea53ef6 X-Microsoft-Antispam: BCL:0;ARA:14566002|19110799003|8060799006|15080799006|7092599003|461199028|6090799003|5072599009|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?q?kiWui5bz4rXAcnT7gM9mapgSaXrdvNA?= =?utf-8?q?AYD9I4sj0Y9N7QNTa11OcOeKpoDW3pIhy/4gkNUeghQt9fAAWc0csSxq+k0rsPWi0?= =?utf-8?q?wugTxgIM5wWOBa8re93ffr2bYRHwpv8Rr0yhAH7vRWw2+loqC/yF/7XpBz1V6qg0L?= =?utf-8?q?nFPJVFQdfPAR9KHBIyC6i4H/q/fqzHFUV/DrvrR3D9STS+c6LPijAqjxcUkLYd7r0?= =?utf-8?q?gxwzoyhQzKxKZ9Oqwu50Ye4jQo+xbHoDNIMyQ50l1uhT1D5lLXIcEko55CKFbK6Ql?= =?utf-8?q?K4FdRs9ItJqRno4brvo1NaWC2jskd4VFRw9epSGpN3lpaH3eN4LDuQ2qnMlobZMBR?= =?utf-8?q?zXeFxOgg/O6++PJbUWqOkNvbLVnVcwYyT3iNcN2n73Aw8zdcJIE14h63a2yjQ6HlO?= =?utf-8?q?r4UlRA+mr1vdyxbp6wYnme6Xa1w6rs3TvJOrxTZVxT4yIlZoQ4XIE5kw4QRnV8wiQ?= =?utf-8?q?IZ64M8lNeRSwyaJbb0Dth0urRLDNNozLcn8l+UKpEGLqJgkz552C/fqRZQjqmknKV?= =?utf-8?q?n/Rg96xUCC0B6T0O5ngEbEfi/GrP/VTBbLm3T81rhC80p+Bvnd4AgdScJtxuqPxCZ?= =?utf-8?q?xEoO7RVCFGmtmYrtSgVMvqcgOo+hUr6ejKfyxwxmddgDxIhHGeGmrYSzu8GRJbkK3?= =?utf-8?q?EIpfqUwvRo5DtZTj8ZuQSA1ygKZdWSQF4HZsW2Ayma2AXXGDQJ5qOBq7zgtMM7wUo?= =?utf-8?q?nIcxolr0bCIyHZPZ1c2QPxTjLhwSjvkWTsPA6BsT6qC4KPLnLFgXvWzjnzYhkPAvG?= =?utf-8?q?JGmhPYi0EtkhowUNByPJqITGSJblFgwpwegSWmsG1RgWCNDV9lc/UJJEC1TY46Kc/?= =?utf-8?q?f4xr1y9fvp1x84B8piISiaqwVabJe99KmypF2sjcBH+IqMKtCSSqJaVA1TBBEFLuh?= =?utf-8?q?rYG+0r4iPl8lwANvr0kfnMlNeyBDjIPG7lMS0DGdWf5OPjx9GwfiQGGsUFemxL9o5?= =?utf-8?q?0Nzx63SFfM8dE+MW3GqnE1Xmbve2/kZ7grSYw45R35tNY1OBqaKq8NzH678JPAlZf?= =?utf-8?q?zC2iSydybYrRUxYxLY8cExiwEPYhbltA3m/Q22OAt2x0/6eH5Qj1wjnooyNY+j+If?= =?utf-8?q?gi9wwuYTPmg3wH9XP2SnnlfkOjCaUJAhu/kkMQ=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?CSLCNEvG7i5OkEk0KprVPWjeKa6r?= =?utf-8?q?De+nWGmulPUpMTojciXpp8eSbFzuDtC2AMCY3sf1QyvVaAJQ870eD8snNCN+SrNvl?= =?utf-8?q?G6Xal/AKjgUt/EDv5wAKaoCcxNDGx9247w8lzNnKnE76Oa/cm+t2hQFj+TGbD3jKw?= =?utf-8?q?7WzdbL3FGzx3mx8ZtseuxxRO9hdc202Cxf2bI5AKJa3ihEdd02H8QjwLaeBOjRjbN?= =?utf-8?q?tJibYyMOAAun65bPjdmFejsmd54Bsv8WuinXxaFtZXDf4bhUmMIoDNzWPVJHrJk5r?= =?utf-8?q?lNiH2N8Q7hzgUI+5EjdJESKip7TC5M6YYRVwMir6MDRKZ6E6VL2bGTHWB2CPMSH7d?= =?utf-8?q?PKnSMyxQf03LoYo50YHGCc0yI7rXWT1Amir4jhhdrYU2zam5rQ2ABnxr/1WuKx0Hf?= =?utf-8?q?PmuxAQXxwUSPIMvQf8HWMpfTQEremg0gM2l2ef4SCgeVxObgoH1oMiChnMPsqnVrF?= =?utf-8?q?XK5qglILEgmDKai/L8774OisDNeLveqHdoisNF6i2uF8hCJS5TLQJN60DG1sraz60?= =?utf-8?q?qH/q1vj2irFxtDabdus3SsuBcp5GraM4HDSbf2rGqbCPnhdVbhiXnvYtG+qOkAeCv?= =?utf-8?q?tMWAbqQAU/RPh+6+y6DudfsDShlewsmEv8sGZDpMABR+qiuxzRYFIQwwqI0TLqU6h?= =?utf-8?q?vBE7C9uE4fyU4CDlBG/akOKBAHdsg64Wnceffuo3Z74vZtR4cVKyUlJ0il/ojPuuI?= =?utf-8?q?aEjxjOIjDXxVjRNSnUPYHOu8l4wrwRk4ahzKPxzwJ5bnzlN5j3MmskNzgV5v6Fq0I?= =?utf-8?q?QrKf7qVLRBkoCPdiCRcCQhcWkiTWQkLlY/N1XG75WvQ7WffsRoKpu9AZFjWJb+9a5?= =?utf-8?q?jy+FbUnkjrubtn6HW+6qCcvd8KjpSG5V+TXMyRF89x9YTvYn0VbwuTB9Mi7GMLUD/?= =?utf-8?q?I+CISQ/cAheQXyGIfgw03ig4Eg+MUSBfBn6nzqjmSxbaqy6zocPn9lvqHRyIU691n?= =?utf-8?q?JPCVv0DZRzC+uAhB57Y+7kGAqN7kFaGSkgHKYR6hpNXaWqWD73/h5GFdr4mahURtE?= =?utf-8?q?EHEOF9X3FJ6qZrKm9E5nBPccyjL3iNQ+UmhhIxU5mobndounT7SI1cW1Q/I//oIoK?= =?utf-8?q?qTHX+6ADhT5LjTOMtCeE3416HTJZ2uCFr2785mzgsPJDfQxW5cztRyf0FacG0nkjh?= =?utf-8?q?+YnuGeN43Zfgz8JJQL/xvNJz5RNQNuWLzGlQO4nSU+ef9WZf2t1Jr45+4ZipHTIx7?= =?utf-8?q?swOPk8QHFZQJwhay2dyUurEH9nrBIpD3RHxeNWa1sl4m1oxXmWQfYngFMkESCg8Ze?= =?utf-8?q?Yc7EC1CFPcenvKPD?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 4d927c83-1a2b-4c32-8610-08dd6ea53ef6 X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2025 09:36:56.3270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0PR01MB10042 From: Aditya Garg Add Apple Magic Keyboard 2024 with Touch ID and Numeric Keypad device ID (05ac:0322) to those recognized by the hid-apple driver. Keyboard is otherwise compatible with the existing implementation for its earlier 2021 model. Signed-off-by: Aditya Garg --- drivers/hid/hid-apple.c | 5 +++++ drivers/hid/hid-ids.h | 1 + 2 files changed, 6 insertions(+) diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c index e95a54113..0524893f7 100644 --- a/drivers/hid/hid-apple.c +++ b/drivers/hid/hid-apple.c @@ -486,6 +486,7 @@ static int hidinput_apple_event(struct hid_device *hid, struct input_dev *input, case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2021: case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024: case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2024: + case USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2024: table = magic_keyboard_2021_and_2024_fn_keys; break; case USB_DEVICE_ID_APPLE_WELLSPRINGT2_J132: @@ -1182,6 +1183,10 @@ static const struct hid_device_id apple_devices[] = { .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK | APPLE_RDESC_BATTERY }, { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2024), .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK }, + { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2024), + .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK | APPLE_RDESC_BATTERY }, + { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2024), + .driver_data = APPLE_HAS_FN | APPLE_ISO_TILDE_QUIRK }, { HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_TOUCHBAR_BACKLIGHT), .driver_data = APPLE_MAGIC_BACKLIGHT }, diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 8682e1b11..4925bfd08 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -167,6 +167,7 @@ #define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2021 0x029f #define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024 0x0320 #define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2024 0x0321 +#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_NUMPAD_2024 0x0322 #define USB_DEVICE_ID_APPLE_WELLSPRING8_ANSI 0x0290 #define USB_DEVICE_ID_APPLE_WELLSPRING8_ISO 0x0291 #define USB_DEVICE_ID_APPLE_WELLSPRING8_JIS 0x0292