From patchwork Mon Mar 31 16:50:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nam Cao X-Patchwork-Id: 14033807 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 898ED1DF748; Mon, 31 Mar 2025 16:50:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743439854; cv=none; b=Kz4h2k7BYpweH9rzHi/DXQi+55yVU6P6jkDK68wz7vO3Ji6wGsIXzinSSeaQRCHUGb8xE7bGKM6aio0VXkb5rGMSNWwTLglxJX1Y15+aYiBRNbb0nELin1K7k8E/rY2AVeggB6fubd2c6bu/r2noDttSRclwASArGqqeAph+rnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743439854; c=relaxed/simple; bh=bgMwNkhBGnv8rP3ZdwMmJTU8/JPMOzHPhegnc9gemY8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kxqnOeCly+o+h74NUcfENmx2EQPHEwjuFaSM0/LewGnQArL8aHz15IOroQqdp3D3uDHqBLnIxMwcTV4xiAYqY15OOLepqq0jiGXJt2ufBXr11uwjf1Puxv4UE1dDQ2FuLMhzGdPQgrqy7Bg/RyvAt4nDFDOHoGbEMFya+kxKtr8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=RQzOTIXI; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=NTq5m2PU; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="RQzOTIXI"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="NTq5m2PU" From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1743439849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CbpPGliuR2iTK+/0zgI72kw6GIkb/4OY3SUNCgGx+MI=; b=RQzOTIXIzsE34ANhyDzSXgAhNiZVpmtmNPt2sIWfc5UB5yQzsmcDv+EdXOMQdcIfkYT1ZT a1FJXNyNEwGq5vhOQEW23EBo3jYPfiGBw1yD30Go1EfzE44VzRR7WZ/1wlkblUTX1q51DA yv/L4J3wswnJLa6QGQIbv+vcZihXDUeX51CUKHfRhTnfRm0A2wrysbOc5tJMNLNAW2vm5e Wq0L0VOoMb2AMBBlIZFWmFOsQeioDHkuWDOd1pRkSwdNJndHqFlrIhNRBdWcVEwkLvo0JP Dlh5bGtWmzdzX3KZ3CgQB8wcJE3jsvTHXmmUtzwh0xGzk6RVRrhfdGqqEd8aKQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1743439849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CbpPGliuR2iTK+/0zgI72kw6GIkb/4OY3SUNCgGx+MI=; b=NTq5m2PU5/F6l9bLpli0Ajd211xsV/DSVnq7JQI9d5vSCMYaahUf2B8TPJa01fbOt7+4oW aehLwA7z9RP+DsDA== To: Christian Brauner Cc: Shuah Khan , John Ogness , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Nam Cao Subject: [PATCH 1/3] selftests: coredump: Properly initialize pointer Date: Mon, 31 Mar 2025 18:50:42 +0200 Message-Id: In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The buffer pointer "line" is not initialized. This pointer is passed to getline(). It can still work if the stack is zero-initialized, because getline() can work with a NULL pointer as buffer. But this is obviously broken. This bug shows up while running the test on a riscv64 machine. Fix it by properly initializing the pointer. Fixes: 15858da53542 ("selftests: coredump: Add stackdump test") Signed-off-by: Nam Cao --- tools/testing/selftests/coredump/stackdump_test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/coredump/stackdump_test.c b/tools/testing/selftests/coredump/stackdump_test.c index 137b2364a082..1dc54e128586 100644 --- a/tools/testing/selftests/coredump/stackdump_test.c +++ b/tools/testing/selftests/coredump/stackdump_test.c @@ -100,6 +100,8 @@ TEST_F(coredump, stackdump) FILE *file; pid_t pid; + line = NULL; + /* * Step 1: Setup core_pattern so that the stackdump script is executed when the child * process crashes From patchwork Mon Mar 31 16:50:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nam Cao X-Patchwork-Id: 14033805 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B08C1E47C9; Mon, 31 Mar 2025 16:50:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743439853; cv=none; b=j7jCb3yXfLvpjav/ibWJrEUBmJDyodh8lx5zdvCjNZ2v1ilc5yJwrBZLmJDf0kjCDEDZidPfjt19fJerSUrg4MC/uG2gZgTOvNFPH91C+snxHRuZTmoTmjvl+a2d6hrdfaEvSEeqcW2yU2LrW7elo/gOpUjwtopjZYHYmnZGxPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743439853; c=relaxed/simple; bh=JqKlDQuXzjsUcrvvN3ujBAWagZ//OblvwLgrNIB+jfU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=epq8T8hvdQPkyeqNHQNEFPKNLwoRbxHZFDXrbt/q8rhAjaeFaoYcQrvkO17PAw/NaBhSMBY+WCfG/k+zR9Rbf/FItEgAcNPBQGqxXlX/zPCNWqNBe106+OhfXczW4SeAaxP0ySgBYM48XnzOC0oh87ii1Gl3S4KvSL4Vwj2ppKk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=vYcuHjFZ; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=HS5nx1zI; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="vYcuHjFZ"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="HS5nx1zI" From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1743439850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kBPp69KpEetCt+Or6JrG0k52llQ+2PSTJOeU1Zxb5PM=; b=vYcuHjFZRZ6yS0WB4mv/ed/EuZR9Vo++DyFXKC9gQLbTkvuzoBsyFcaNGmHBvaxYTx6hZ4 KUBdUlk3ZVnwB1MqeagtG+ZNNBLTzTohs58+6sLfFvWKFxw7QB2eTcefRR9wGn934hz4lS Dzpn3/WnvsbUgvuDX0np4faDhdNeQmy9DP16TV2kvfQB4+LI7/VYiBbxJxbHkO+XQC6dIR 4Eptif6zJZwIPqXD3qq67VfQW7Y3fPHbNRDClTFBJnKN3m5VaF/zPTn9mXeoow4LIjdo4i 0BMhFgKFU5jCEr/YxVr6tBu9n7QoxhzPONYOIm+iVl8DeuLfFwdwBLmiAtVhKg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1743439850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kBPp69KpEetCt+Or6JrG0k52llQ+2PSTJOeU1Zxb5PM=; b=HS5nx1zIGdtiWhJE+3lq5WU/ejXiR/f61Ovt9P5ZMzlQ/Vljx+JETQizvD9ISjP1ZnLuiw 0tpv1f88pRkEcSCg== To: Christian Brauner Cc: Shuah Khan , John Ogness , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Nam Cao Subject: [PATCH 2/3] selftests: coredump: Use waitpid() instead of busy-wait Date: Mon, 31 Mar 2025 18:50:43 +0200 Message-Id: <133d0dc62cebb6fde2764af384b0166d98755a3c.1743438749.git.namcao@linutronix.de> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The test waits for coredump to finish by busy-waiting for the stackdump_values file to be created. The maximum wait time is 10 seconds. This doesn't work for slow machine (qemu-system-riscv64), because coredump takes longer. Switch to use waitpid(). With this, the stack_values file doesn't need to be atomically written by coredump anymore, therefore simplify the stackdump script. Fixes: 15858da53542 ("selftests: coredump: Add stackdump test") Signed-off-by: Nam Cao --- tools/testing/selftests/coredump/stackdump | 6 +----- tools/testing/selftests/coredump/stackdump_test.c | 13 ++++++------- 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/tools/testing/selftests/coredump/stackdump b/tools/testing/selftests/coredump/stackdump index 96714ce42d12..ad487fd5ff15 100755 --- a/tools/testing/selftests/coredump/stackdump +++ b/tools/testing/selftests/coredump/stackdump @@ -4,11 +4,7 @@ CRASH_PROGRAM_ID=$1 STACKDUMP_FILE=$2 -TMP=$(mktemp) - for t in /proc/$CRASH_PROGRAM_ID/task/*; do tid=$(basename $t) - cat /proc/$tid/stat | awk '{print $29}' >> $TMP + cat /proc/$tid/stat | awk '{print $29}' >> $STACKDUMP_FILE done - -mv $TMP $STACKDUMP_FILE diff --git a/tools/testing/selftests/coredump/stackdump_test.c b/tools/testing/selftests/coredump/stackdump_test.c index 1dc54e128586..733feaa0f895 100644 --- a/tools/testing/selftests/coredump/stackdump_test.c +++ b/tools/testing/selftests/coredump/stackdump_test.c @@ -96,7 +96,7 @@ TEST_F(coredump, stackdump) char *test_dir, *line; size_t line_length; char buf[PATH_MAX]; - int ret, i; + int ret, i, status; FILE *file; pid_t pid; @@ -131,12 +131,11 @@ TEST_F(coredump, stackdump) /* * Step 3: Wait for the stackdump script to write the stack pointers to the stackdump file */ - for (i = 0; i < 10; ++i) { - file = fopen(STACKDUMP_FILE, "r"); - if (file) - break; - sleep(1); - } + waitpid(pid, &status, 0); + ASSERT_TRUE(WIFSIGNALED(status)); + ASSERT_TRUE(WCOREDUMP(status)); + + file = fopen(STACKDUMP_FILE, "r"); ASSERT_NE(file, NULL); /* Step 4: Make sure all stack pointer values are non-zero */ From patchwork Mon Mar 31 16:50:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nam Cao X-Patchwork-Id: 14033806 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1ED7210185; Mon, 31 Mar 2025 16:50:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743439853; cv=none; b=enp/kGAaMxC23Q40ILGnD21fYdPqQSpKcvisVEt3EmifZXgzPUNhSoRcx4czLD6Kzr9otIpJWCwEnB1w1Oro8xyVTNAaMPKn/Enkin8K/jwh7YzbJOEIo/hh+LSwnOCUGou1j/V2w8pJ8NayQtrFP+oOyjuUzqSctci5k0ksRd4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743439853; c=relaxed/simple; bh=vfd7GsqSM1N+IaBAQA6GTPL3evHFk1Bl+lKqhv8ePws=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jCvrdWuRGxj7fSvuLLnDsBPabAwd4FblFHtI04bTLHb5OXLrRCZ8ezxD61mvZJF55fVqJlyUFLB3YGvMGOgek8VJC9pE81cvIwRTcmQ57LdRRjpN6R9O/N5fDZh4SyLSiQeTVWAu1M6ls1xnh7UsBpWO/4Ao4kGo2fK3eBkCAy0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=Bb/jdihU; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=LKG8H3RP; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Bb/jdihU"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="LKG8H3RP" From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1743439850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8TSq+iUEvcTWreQkuBF7G0xi5S2XYUc6egrdiVdP/W8=; b=Bb/jdihUtYcy4+Ou8JRMLwMSU/KNNwvZzu8AlG6SUFGqQaSNCLTS92UedD0tL+tLN2s6D0 9ZFy1NRxifwcjWiKdsFZrvsRkbufwk2e+uxWBaPYQ2ity5hCZsTtIHKqxzhk0U8oQj5p9Y 55h3BPkp4SuMDxey8CDmoAI3akio2ONkijEZiwvv9q3pbIpKw2C8YMGbW9qOBXT5UDElvY 7MbrBKWsJZiZewx33umgg7T2/b4TyISFBx6G93HEb6ba9ndIjjQ4WKkI8EW4LzMzmkRyxC yt1cAr8lZ9UT+eqS2AoYYxc9g2H5stt8vD4GG2m0HBt0qxEUXTMh9O/N13LyDA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1743439850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8TSq+iUEvcTWreQkuBF7G0xi5S2XYUc6egrdiVdP/W8=; b=LKG8H3RPmgAQrHsD+8FsCrJTHRt1qCZVfwvFqHFo1ng4w/9UaTGWec32OKF+FBtGmUewV/ MqCR8mplE80/7CDg== To: Christian Brauner Cc: Shuah Khan , John Ogness , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Nam Cao Subject: [PATCH 3/3] selftests: coredump: Raise timeout to 2 minutes Date: Mon, 31 Mar 2025 18:50:44 +0200 Message-Id: <09fe0146860c63dff734fab0c1ecea6ea39c2cc0.1743438749.git.namcao@linutronix.de> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The test's runtime (nearly 20s) is dangerously close to the limit (30s) on qemu-system-riscv64: $ time ./stackdump_test > /dev/null real 0m19.210s user 0m0.077s sys 0m0.359s There could be machines slower than qemu-system-riscv64. Therefore raise the test timeout to 2 minutes to be safe. Fixes: 15858da53542 ("selftests: coredump: Add stackdump test") Signed-off-by: Nam Cao --- tools/testing/selftests/coredump/stackdump_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/coredump/stackdump_test.c b/tools/testing/selftests/coredump/stackdump_test.c index 733feaa0f895..b1924acf02af 100644 --- a/tools/testing/selftests/coredump/stackdump_test.c +++ b/tools/testing/selftests/coredump/stackdump_test.c @@ -89,7 +89,7 @@ FIXTURE_TEARDOWN(coredump) fprintf(stderr, "Failed to cleanup stackdump test: %s\n", reason); } -TEST_F(coredump, stackdump) +TEST_F_TIMEOUT(coredump, stackdump, 120) { struct sigaction action = {}; unsigned long long stack;