From patchwork Tue Apr 1 15:43:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Mihalcea X-Patchwork-Id: 14035068 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6604C36010 for ; Tue, 1 Apr 2025 15:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RB1PP1x3fa02Q8papa7Q4qbO9lj9DsfbybLuQtv7HIQ=; b=ew7tNBY0Awc0Df/z1ln6/wUI9s z9Pfq0fTnvRmDsYxwV/6pJqXO2NXKpROl8w7fnjmYxY648UdsHVnTm2FbvtwhwDfC53RJX8qyI6Bw EL41lP8SAGeZfMqeEHvhuNFO1GQhekkL+gmLZDiV/kAS9bXV5CWrXcnxRzJhlomxwH5DGofhrB0D4 oMrh49O9G4plq+/JN94j0HzeGOGkWqG3THhP6zvi5NJNrxCOthLqdxo1XGONmRs9shaaU6/b3+yVq 1pS/qe7aSqM2KvAsNGyyVqWJ2HmvKAGlrXH5zPYExEsfFbNQCT3gbNuCdHilab4cmrFGmaCx0xKL2 j6iClUyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzdvO-00000003mak-3gJ2; Tue, 01 Apr 2025 15:53:14 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzdoF-00000003kuL-0LTu for linux-arm-kernel@lists.infradead.org; Tue, 01 Apr 2025 15:45:52 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-43690d4605dso39620925e9.0 for ; Tue, 01 Apr 2025 08:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743522349; x=1744127149; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RB1PP1x3fa02Q8papa7Q4qbO9lj9DsfbybLuQtv7HIQ=; b=K15MuzqvdtEGHQaG49DzVAGPNd5lSLko0JY9HtQA0IbhMSwkQzb1BSYYAKKHrAjh0q v8PFv8EXw3iNly8JTJlGuOjgH+NjFXUdHO3zvOxwpr88PWG6v5Dyh4+JZZYlSgHu38+x IvX8P//FVcbV1eyO1Z516Qf+I2nkJ1EpyXSwG8trTbuGBeFWRQXQ/FnrO0EulVQbpC/M CKDS4hyY3JoCltrkN98MaQbob0/6tWhpETMraHlBHrDha9CzC6Al9htYyb1MC7FXj9oo HNxrV6Umm7ge22TyTzXg0VmqSnKhabVbixg3f85VmPY4GeokOekA6qknR5URkk5rwFDp 7Vuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743522349; x=1744127149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RB1PP1x3fa02Q8papa7Q4qbO9lj9DsfbybLuQtv7HIQ=; b=Qy8QUNeijzOwkjYz7VDf3xsFYV25ut3PqyoMRgXJtSIdR6TFATukhP/5yIM64OWCuw OUDgFdHfCPaG34RY5ahmgJ8ydrmtZmR9ikL4JVIin5H66npFUNynabgVlZERTslkKGq2 O0w6wXuatjYVARvyiW4SyiAF+FXiZZSMhmg8fS9yLAfL6Wn5CNzyPQQZ7s37JvEurS3U o30wE+Ptnfs8rYiy61kMZxIYFDdqoowZ9VO6fF9LTkI7QyM8DLzIeX2r47RcGuL12CQl f3QX9O6kRiaP66VL8FhQOXPs5IcZ0hLhrh7ahGxCHtmLgOag4ZbcyTue6qB8AeLg0jSR RLHw== X-Forwarded-Encrypted: i=1; AJvYcCWmCmcBiWFKxgOyzqYvgdLmJ06CSyZJtD+UMB8ed3TCswTapwrI6PNyGnNoTgcbpWZV7ex0zG5C98fqR80zPj9V@lists.infradead.org X-Gm-Message-State: AOJu0YyGVCJr5ot3HWS1IrJMwiXDyn1AIhf6IIMEOlo6D084LYgquqZI 9sqGKzXxTt1+xDPiwYgkUBl892pcmnw/wbEo3W3UATVq5M0ns/cu X-Gm-Gg: ASbGncsv5meDSVfrb4P8fmFj7YZ4TrrXyIBYEEdOKlrENhsYjSv5wdouQphK7VsPUqT x4fj4MIInYx0zmdaI/zjAnwof7Afdp4FCWilaqa0JKSdLAGCC6hTVJACU0usvvLpywyg4LSb2AJ mzgmi250Lo1D8Jhm/lVb6l8Polcdlv9VCSKsLCK6J/NnNdB72P01lEaT2Vg1aLjbEv1ogL3aBmg Z+qKm4sqWw6YjnCwLLZyaxZ87zc5afJYjJEc2ookwlU+GZwEFH8FYp4P+zfV/KQX63Qa4wyDzPH RhY+CALFHRlcucBiH6zbrI1MNOgODKKWFO3bWBYoSgQ0LLAbdYeNiG0miOKNBDEQ62ZLpPGFMt5 CaMrv5VI= X-Google-Smtp-Source: AGHT+IEwP1LRFyekKJgsxs9B8k784Op1Fz73VSFZYv3B3/zly1RjzrL3LrijYBHY+f5sPUhyA6ADAg== X-Received: by 2002:a05:6000:420d:b0:391:2ab1:d4b8 with SMTP id ffacd0b85a97d-39c120c7d4cmr10416753f8f.1.1743522349145; Tue, 01 Apr 2025 08:45:49 -0700 (PDT) Received: from playground.localdomain ([82.79.237.110]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d8ff042bcsm158795735e9.28.2025.04.01.08.45.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 08:45:48 -0700 (PDT) From: Laurentiu Mihalcea To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Daniel Baluta , Shengjiu Wang , Frank Li , Marco Felsch , Marc Kleine-Budde Cc: Pengutronix Kernel Team , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/6] dt-bindings: bus: add documentation for the IMX AIPSTZ bridge Date: Tue, 1 Apr 2025 11:43:59 -0400 Message-Id: <20250401154404.45932-2-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> References: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250401_084551_122563_565CBB1D X-CRM114-Status: GOOD ( 17.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Laurentiu Mihalcea Add documentation for IMX AIPSTZ bridge. Co-developed-by: Daniel Baluta Signed-off-by: Daniel Baluta Signed-off-by: Laurentiu Mihalcea --- .../bindings/bus/fsl,imx8mp-aipstz.yaml | 104 ++++++++++++++++++ include/dt-bindings/bus/imx-aipstz.h | 25 +++++ 2 files changed, 129 insertions(+) create mode 100644 Documentation/devicetree/bindings/bus/fsl,imx8mp-aipstz.yaml create mode 100644 include/dt-bindings/bus/imx-aipstz.h diff --git a/Documentation/devicetree/bindings/bus/fsl,imx8mp-aipstz.yaml b/Documentation/devicetree/bindings/bus/fsl,imx8mp-aipstz.yaml new file mode 100644 index 000000000000..13b7fb39d6ac --- /dev/null +++ b/Documentation/devicetree/bindings/bus/fsl,imx8mp-aipstz.yaml @@ -0,0 +1,104 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/bus/fsl,imx8mp-aipstz.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Secure AHB to IP Slave bus (AIPSTZ) bridge + +description: + The secure AIPS bridge (AIPSTZ) acts as a bridge for AHB masters issuing + transactions to IP Slave peripherals. Additionally, this module offers access + control configurations meant to restrict which peripherals a master can + access. + +maintainers: + - Laurentiu Mihalcea + +properties: + compatible: + const: fsl,imx8mp-aipstz + + reg: + maxItems: 1 + + power-domains: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + + "#access-controller-cells": + const: 3 + description: + The first cell consists of the consumer type (master or peripheral). + The second cell consists of the consumer ID. + The third cell consists of the configuration value. + + ranges: true + +# borrowed from simple-bus.yaml, no additional requirements for children +patternProperties: + "@(0|[1-9a-f][0-9a-f]*)$": + type: object + additionalProperties: true + properties: + reg: + items: + minItems: 2 + maxItems: 4 + minItems: 1 + maxItems: 1024 + ranges: + oneOf: + - items: + minItems: 3 + maxItems: 7 + minItems: 1 + maxItems: 1024 + - $ref: /schemas/types.yaml#/definitions/flag + anyOf: + - required: + - reg + - required: + - ranges + +required: + - compatible + - reg + - power-domains + - "#address-cells" + - "#size-cells" + - "#access-controller-cells" + - ranges + +additionalProperties: false + +examples: + - | + #include + #include + + bus@30df0000 { + compatible = "fsl,imx8mp-aipstz"; + reg = <0x30df0000 0x10000>; + power-domains = <&pgc_audio>; + #address-cells = <1>; + #size-cells = <1>; + #access-controller-cells = <3>; + ranges = <0x30c00000 0x30c00000 0x400000>; + + dma-controller@30e00000 { + compatible = "fsl,imx8mp-sdma", "fsl,imx8mq-sdma"; + reg = <0x30e00000 0x10000>; + #dma-cells = <3>; + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_SDMA3_ROOT>, + <&clk IMX8MP_CLK_AUDIO_ROOT>; + clock-names = "ipg", "ahb"; + interrupts = ; + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; + }; + }; diff --git a/include/dt-bindings/bus/imx-aipstz.h b/include/dt-bindings/bus/imx-aipstz.h new file mode 100644 index 000000000000..b81b4654e00f --- /dev/null +++ b/include/dt-bindings/bus/imx-aipstz.h @@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright 2025 NXP + */ + +#ifndef _DT_BINDINGS_BUS_IMX_AIPSTZ_H +#define _DT_BINDINGS_BUS_IMX_AIPSTZ_H + +/* consumer type - master or peripheral */ +#define IMX_AIPSTZ_MASTER 0x0 +#define IMX_AIPSTZ_PERIPH 0x1 + +/* master configuration options */ +#define IMX_AIPSTZ_MPL 0x1 +#define IMX_AIPSTZ_MTW 0x2 +#define IMX_AIPSTZ_MTR 0x4 +#define IMX_AIPSTZ_MBW 0x8 + +/* peripheral configuration options */ +#define IMX_AIPSTZ_TP 0x1 +#define IMX_AIPSTZ_WP 0x2 +#define IMX_AIPSTZ_SP 0x4 +#define IMX_AIPSTZ_BW 0x8 + +#endif /* _DT_BINDINGS_BUS_IMX_AIPSTZ_H */ From patchwork Tue Apr 1 15:44:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Mihalcea X-Patchwork-Id: 14035069 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B65EC3DA4A for ; Tue, 1 Apr 2025 15:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gu5G8CnhO94dSAWaShWe9FJyZsw97QYskm73IppyfbE=; b=ZF/8rtAJJI0qcH61tEk4Qmr9Iv oFWst2Sr+iSnioalW7MTTr5De97SmJeIpW/BfdYodSyzKifq633FUuBjscoY48kiXjxGatEU35S75 hqTIGCAdAFsbL4cA6avdoidwbMHy6cITwkAIEgM7EI+jXRGK36b4Yj+nvrpJTmfcjCa1F9khCxRo6 FNh8HUM2EGPJHtX/p2qyPeCAxXUYKodQg6f02vvzVkIfkjauD5c+c+B6vJSyM9kyu/MfXrVsn4q8h Em0IFrQ+IIlqki458Q16Syb9pamKwfIrZO5Jo34zf1NVhoQ6+4hxN/n2ta/pwOCV+VGbAUGAIFhuD h6434Zsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzdxA-00000003muU-2Hhc; Tue, 01 Apr 2025 15:55:04 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzdoG-00000003kvO-25Hi for linux-arm-kernel@lists.infradead.org; Tue, 01 Apr 2025 15:45:53 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4394a0c65fcso55453175e9.1 for ; Tue, 01 Apr 2025 08:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743522351; x=1744127151; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gu5G8CnhO94dSAWaShWe9FJyZsw97QYskm73IppyfbE=; b=UxLoAf0U7uTBA168fCP73VmtmML5RZ1xYRrYHxBrNJkaggLyDXPyGXWKr/RzkkcqID gLgvYwEIJ1iscRuEXcpY5VuomzZW0+jcNTsLWalLN//WIUF9yRufHzipei3uWJuVEPQp AnOiMcEczAa5SB+BulAGaZdaBi9IM2chbrPcEILEsSz7g7odmT2lcw6SjNm+2l5deBvy HM6XNUVkNj8s+J/xThdRGTya88sRcQe4keJnczzu4juJDLF68WY1TkfneWm5Eqwfj/q0 71topAKUFJUelQ9mG19BeCSiYEWFjz6VO0TluEiYJKs59TATQp+D+Mmgik3N76eZUx+n 8THg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743522351; x=1744127151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gu5G8CnhO94dSAWaShWe9FJyZsw97QYskm73IppyfbE=; b=SAIqTdPdpAZ4lAng2Dcx2DBj71VVgEOnteScBJPvfiBpYh3yTtb9vbZQ+XV1Qc2q/S +m6U9JODVXua8mpSmu5L9IMiIsn86LjZojKp1rHLy/mwXMHH1r1o7iS5XobaQVXcUnV9 raVI6VefGOBQ8Qkmj5QOvAkR4nAvSXOzOUNUzo7vEA78j+5rPK2H+cZJopzqpPivWIKW u1WGkzK0V5nW4nxjVeG8K8C0uQ/4FcMDcjNeGXX6arftzgCYKcZnwbgxD1HYJ4kioh/4 wmANMqfZmac83bLNFpHRdGkGA4Ss15O00KybJN6AqfA66s5WY2R5o8lPshnm9EOWNtRT FLnA== X-Forwarded-Encrypted: i=1; AJvYcCWUxc9+rt8aXN8AWlFnJYI8x759ewaoxMrBFYD+HRppW5iyD5ilaugP/4MQEJi7C2xymL4YwttiG+57H/Lhv1bg@lists.infradead.org X-Gm-Message-State: AOJu0YzRJKNbrmxKtSJzLdg1FChoYNKQEPeBy7+P+xnhsRlTBy6Ym85Z CJoYlUdOhzrqMnDGzisL4icZNyaiY9yBGMopHKjIyRdxNRUyB9sU X-Gm-Gg: ASbGncsolFQJZLEq4TeoJn6ZM8vxiXLWrM+QtvlGf+oDHn/fbBUP8/y3WDSRaTl3yvf 2GvM1CYVoOidAUjU87aurd5OPSYXgFSPeQlRVjd3Zh/eFv/Wl6E1gC3mf6BTWiqyaHKsdvodYuz T+4vJkFJxnGq29L15T3IM2aVlHDAfBVs5XIDrbQP9uBnHESekuJrU1dx/7MUt+rnYUFTDzxgtdC 7LaY5NVfbSBGAdjL2R37rHgJVX/wHVHyuq/4PMS+2ynWmiXzRx7BZMGxcLfDk651ZWcgPjvkIKa vMALpneFLeGwhSLZkf+H+t4q+4y0B9DThCPjqOoSmBuH0ez/V7l0nNvc87nh4vhwv0AbMUVljMA d9sY/7Ws= X-Google-Smtp-Source: AGHT+IHGjpv3EKCnHFF5eKJe9tjoaQRXwwsvagQBmS5kvWyHdixkP+Aak1uOZaWLdm7A5+xOdO8cRw== X-Received: by 2002:a05:600c:310c:b0:43c:f575:e305 with SMTP id 5b1f17b1804b1-43db6227bb7mr114695995e9.8.1743522350993; Tue, 01 Apr 2025 08:45:50 -0700 (PDT) Received: from playground.localdomain ([82.79.237.110]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d8ff042bcsm158795735e9.28.2025.04.01.08.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 08:45:50 -0700 (PDT) From: Laurentiu Mihalcea To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Daniel Baluta , Shengjiu Wang , Frank Li , Marco Felsch , Marc Kleine-Budde Cc: Pengutronix Kernel Team , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/6] dt-bindings: dsp: fsl,dsp: document 'access-controllers' property Date: Tue, 1 Apr 2025 11:44:00 -0400 Message-Id: <20250401154404.45932-3-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> References: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250401_084552_577758_D471C698 X-CRM114-Status: GOOD ( 11.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Laurentiu Mihalcea Some DSP instances may have their access to certain peripherals conditioned by a bus access controller such as the one from the AIPSTZ bridge. Add the optional 'access-controllers' property, which may be used in such cases. Signed-off-by: Laurentiu Mihalcea Reviewed-by: Frank Li Acked-by: Rob Herring (Arm) --- Documentation/devicetree/bindings/dsp/fsl,dsp.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml index b8693e4b4b0d..e610b7636a08 100644 --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml @@ -91,6 +91,9 @@ properties: - const: runstall - const: softreset + access-controllers: + maxItems: 1 + required: - compatible - reg From patchwork Tue Apr 1 15:44:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Mihalcea X-Patchwork-Id: 14035070 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49AA2C36010 for ; Tue, 1 Apr 2025 15:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3+/ol304EYZFzmHf5qWZCvTKblJaCdBMbBu4cFrdM28=; b=PVM3fK4QJdMoirIGGOp4yaN/im UdK4+miP/56NJ6MrYsPRziMBHzVY0CYoOMa2Zf7zCaYMNySZH7DJniSnOFUNjQppVmfl7ApHD2z6B E5Hf68MJM+XtEC4Uh7RWYj77xG7B1CViD9agE4jtCmn7Z884btIR9FzIGsFk1+mBr+j9QEdCAR9VC pliUUSZ0vQ2Puhjyy26I4MLZp9U6y0kIgNt0zxB2m2z6Ow9SA4HXM00Q64anOrmloHjcv8NVqZVua IpX2/SgkTIQ4G7GB31bA9aOzpX2G56rGVBxJshU/VZfLFWa3wmH5s/Y27vfM1yrPWSd1cP1Pfyp8r T4L6ggbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzdyu-00000003nBN-3y2f; Tue, 01 Apr 2025 15:56:52 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzdoJ-00000003kwf-1q6e for linux-arm-kernel@lists.infradead.org; Tue, 01 Apr 2025 15:45:57 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-391342fc0b5so4182605f8f.3 for ; Tue, 01 Apr 2025 08:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743522354; x=1744127154; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3+/ol304EYZFzmHf5qWZCvTKblJaCdBMbBu4cFrdM28=; b=lukTJjenXLqlMoP4vwdhDdHR/Lc+LjBXEcfH8i+NlJXRAGC9UMWqbrvUesK3Gm6S2m OiScUuDyHgxyLVStR/9IcZxkacPVE6GLYdiJnRuAtBxmoHZ5uJGv4JSw1tE7MXqtyasH VjP5DUbY77nkqeFlSHtJKsIzdJSuWdbXi12ETgubB1OC78AmxTbypnJ5OvUEHwtflik1 DXI9hHk4aq2WScfghPOpIj+N2NH9USZIsVkqI9KWMAdW4GMq8td9VLHAjVX7LAxemLsg I7ROgFsMaff6uU21pK50TdPNCkotytjz73JuqiVMJTTqB2yUkahioqGF8UqC82QSjZ32 bQgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743522354; x=1744127154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3+/ol304EYZFzmHf5qWZCvTKblJaCdBMbBu4cFrdM28=; b=tN7ErWZA2j2M2ADv6XQN4EbXgUUeErt02IxnjfMFg7sIvNlSaDsxZPVwQ+y23+Woy1 ufKB51PcKO5x0ifrne8eExooA65XH3IkDnl1eRbPhUpzQ5pzJ7vPQF+zcKb1lw66pqQZ 7FXVM1kuR2hykfQeA06YEKo0IOfgTxO/xj2AkF/h30hln/zxTTueERN72xfM91TAx5qC THaf3vNgw7z8JjCzfu0NAGJJx4mNVcqNhOq86lwDGC4HUoj9NRQqZLFCf3TVoasIDKtC tZFyYH4AGM8l7N9G6Blbq3pZ4PjeqkmSJ0hhIdBqGK/T7V66qXTBlahxgwdbxDux7TLx PgcA== X-Forwarded-Encrypted: i=1; AJvYcCVAWBdQ3zsvINaTSaymmBzUOcKNZBzeYr/IJ873uvvxAxkF2MWcxglhkOGZN3b9uV5p+bIXqo0qO9THFFVJ6o1z@lists.infradead.org X-Gm-Message-State: AOJu0Yzf6jjVQJhC84A8aUCU8wRwPKyy/YG+dSosFh/XGGrFfLKAuQzq DFeNbL5gfiZA2d4CYSGPlWER7+z4zSZeZ7YDi36Mv4GT142sRZXg1BVKptAh X-Gm-Gg: ASbGnctRx2jEuuGdP+ULv9VQqUP+nvhnzbwtCYvgYQ3OTvCp4CPfzlODgI+skvE9Ipi gJ0RsiwnmZu1rSYcujkVmX2f1LL01eCOjw4rEebQyLcNyrU10OCtuO6tSqXKNsx7Nd8KVLFa+m9 e2Stl9jZmyQszSXnCwdcTl9m8sT0rKLiXMOb7ED9S6fmxnzBxnpQbjj+739ADm0IgN0Ufxb2QmS fhMjz70UIw73P6TxXyy4iCG4Hp9e4/5IVfGTOkM26LquEL/vmHiUdgXOaOuzm3RsnyTmh8TCS9v CaZWAeQNEaazgaMEd9oJgz+7b4ILIktnULbSGAMDOE3B5wBfD7MG50G8eI5YrP7+il/hulAHUDS XoDEJSeI= X-Google-Smtp-Source: AGHT+IE2m9aQ7hxMdL1hcSCVBaAL9i81WJkbAFdNTU9OkqMxfa+QpMQqlgxt2/QmZqWboPf3GEwH7Q== X-Received: by 2002:a5d:64cc:0:b0:399:6dc0:f134 with SMTP id ffacd0b85a97d-39c1211de8dmr10794398f8f.51.1743522353458; Tue, 01 Apr 2025 08:45:53 -0700 (PDT) Received: from playground.localdomain ([82.79.237.110]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d8ff042bcsm158795735e9.28.2025.04.01.08.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 08:45:53 -0700 (PDT) From: Laurentiu Mihalcea To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Daniel Baluta , Shengjiu Wang , Frank Li , Marco Felsch , Marc Kleine-Budde Cc: Pengutronix Kernel Team , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 3/6] bus: add driver for IMX AIPSTZ bridge Date: Tue, 1 Apr 2025 11:44:01 -0400 Message-Id: <20250401154404.45932-4-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> References: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250401_084555_630075_78B21219 X-CRM114-Status: GOOD ( 24.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Laurentiu Mihalcea The secure AHB to IP Slave (AIPSTZ) bus bridge provides access control configurations meant to restrict access to certain peripherals. Some of the configurations include: 1) Marking masters as trusted for R/W. Based on this (and the configuration of the accessed peripheral), the bridge may choose to abort the R/W transactions issued by certain masters. 2) Allowing/disallowing write accesses to peripherals. Add driver for this IP. Since there's currently no framework for access controllers (and since there's currently no need for having flexibility w.r.t the configurations) all this driver does is it applies a relaxed, "default" configuration, in which all masters are trusted for R/W. Note that some instances of this IP (e.g: AIPSTZ5 on i.MX8MP) may be tied to a power domain and may lose their configuration when the domain is powered off. This is why the configuration has to be restored when the domain is powered on. Co-developed-by: Daniel Baluta Signed-off-by: Daniel Baluta Signed-off-by: Laurentiu Mihalcea --- drivers/bus/Kconfig | 6 +++ drivers/bus/Makefile | 1 + drivers/bus/imx-aipstz.c | 92 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 99 insertions(+) create mode 100644 drivers/bus/imx-aipstz.c diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig index ff669a8ccad9..fe7600283e70 100644 --- a/drivers/bus/Kconfig +++ b/drivers/bus/Kconfig @@ -87,6 +87,12 @@ config HISILICON_LPC Driver to enable I/O access to devices attached to the Low Pin Count bus on the HiSilicon Hip06/7 SoC. +config IMX_AIPSTZ + tristate "Support for IMX Secure AHB to IP Slave bus (AIPSTZ) bridge" + depends on ARCH_MXC + help + Enable support for IMX AIPSTZ bridge. + config IMX_WEIM bool "Freescale EIM DRIVER" depends on ARCH_MXC || COMPILE_TEST diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile index cddd4984d6af..8e693fe8a03a 100644 --- a/drivers/bus/Makefile +++ b/drivers/bus/Makefile @@ -15,6 +15,7 @@ obj-$(CONFIG_FSL_MC_BUS) += fsl-mc/ obj-$(CONFIG_BT1_APB) += bt1-apb.o obj-$(CONFIG_BT1_AXI) += bt1-axi.o +obj-$(CONFIG_IMX_AIPSTZ) += imx-aipstz.o obj-$(CONFIG_IMX_WEIM) += imx-weim.o obj-$(CONFIG_INTEL_IXP4XX_EB) += intel-ixp4xx-eb.o obj-$(CONFIG_MIPS_CDMM) += mips_cdmm.o diff --git a/drivers/bus/imx-aipstz.c b/drivers/bus/imx-aipstz.c new file mode 100644 index 000000000000..44db40dae71b --- /dev/null +++ b/drivers/bus/imx-aipstz.c @@ -0,0 +1,92 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright 2025 NXP + */ + +#include +#include +#include +#include +#include +#include + +#define IMX_AIPSTZ_MPR0 0x0 + +struct imx_aipstz_config { + u32 mpr0; +}; + +static void imx_aipstz_apply_default(void __iomem *base, + const struct imx_aipstz_config *default_cfg) +{ + writel(default_cfg->mpr0, base + IMX_AIPSTZ_MPR0); +} + +static int imx_aipstz_probe(struct platform_device *pdev) +{ + const struct imx_aipstz_config *default_cfg; + void __iomem *base; + + base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL); + if (IS_ERR(base)) + return dev_err_probe(&pdev->dev, -ENOMEM, + "failed to get/ioremap AC memory\n"); + + default_cfg = of_device_get_match_data(&pdev->dev); + + imx_aipstz_apply_default(base, default_cfg); + + dev_set_drvdata(&pdev->dev, base); + + pm_runtime_set_active(&pdev->dev); + devm_pm_runtime_enable(&pdev->dev); + + return devm_of_platform_populate(&pdev->dev); +} + +static int imx_aipstz_runtime_resume(struct device *dev) +{ + const struct imx_aipstz_config *default_cfg; + void __iomem *base; + + base = dev_get_drvdata(dev); + default_cfg = of_device_get_match_data(dev); + + /* restore potentially lost configuration during domain power-off */ + imx_aipstz_apply_default(base, default_cfg); + + return 0; +} + +static const struct dev_pm_ops imx_aipstz_pm_ops = { + RUNTIME_PM_OPS(NULL, imx_aipstz_runtime_resume, NULL) + SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) +}; + +/* + * following configuration is equivalent to: + * masters 0-7 => trusted for R/W + use AHB's HPROT[1] to det. privilege + */ +static const struct imx_aipstz_config imx8mp_aipstz_default_cfg = { + .mpr0 = 0x77777777, +}; + +static const struct of_device_id imx_aipstz_of_ids[] = { + { .compatible = "fsl,imx8mp-aipstz", .data = &imx8mp_aipstz_default_cfg }, + { } +}; +MODULE_DEVICE_TABLE(of, imx_aipstz_of_ids); + +static struct platform_driver imx_aipstz_of_driver = { + .probe = imx_aipstz_probe, + .driver = { + .name = "imx-aipstz", + .of_match_table = imx_aipstz_of_ids, + .pm = pm_ptr(&imx_aipstz_pm_ops), + }, +}; +module_platform_driver(imx_aipstz_of_driver); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("IMX secure AHB to IP Slave bus (AIPSTZ) bridge driver"); +MODULE_AUTHOR("Laurentiu Mihalcea "); From patchwork Tue Apr 1 15:44:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Mihalcea X-Patchwork-Id: 14035084 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F325C36010 for ; Tue, 1 Apr 2025 15:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+vDwb9HDwdUl0Ebx/4UWYmvDHxD9AeyHufpsAE/MqOc=; b=ljHAWdoLVjyxZ8Gcz4OK1GDzWW tCxzGZNH7IhWmQdTBbHG3whHHR72yJgqYNBRVl6ybfpQXA6/jClCPAb3b/VihzzAOou3bO9/7Gv5+ 5MUgVo4k/vhmjd8HjPgbxV/C8oFKIaAtBr9Vs2A0re19DPYrwafDoC8VnWFodgMVzQHOJomVl1YNa y2EoV11B+4+0D1u02wqHjtmIt4wmSKyeFnk1JF0AFzg40Jzbi9UTHb/c/JTh6J0k1Gjeoqef6um7p oNhGVIHyvgg1bjn7dR6yQmSp7jbPFkux9B2ODDZMswUxbmqnn89YP2rgsJLagaupS2ZzDWsv38mLj R9YK5SXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tze0f-00000003nU5-2vmD; Tue, 01 Apr 2025 15:58:41 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzdoL-00000003kxO-0tgn for linux-arm-kernel@lists.infradead.org; Tue, 01 Apr 2025 15:45:58 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-43cfdc2c8c9so32691845e9.2 for ; Tue, 01 Apr 2025 08:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743522356; x=1744127156; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+vDwb9HDwdUl0Ebx/4UWYmvDHxD9AeyHufpsAE/MqOc=; b=YoC86Srlb7ENDgJ+SvN0IT3iUFwcVuaAbjDALn6aOHaXt029qy8pgD62fCnSHIaXPm njG0GsYtl3/mW+cG5v1P8e0U5lb06M/61ohpOR5fcxDFCkubA6dT2A8b5n/DCizZGk0v G7zNzcyt9MsFhRd7Sx88tnLMuf79sM7tcSAOGks5GTfJWIMTqKFuhi+gBq5xPuW5/ngh v1G4u6yuIaWNSTtBI7avcOqejTq2s27bf7XrV/TujlEo1AEXTPPsyHo3Plg1ApEKz9ew HXsj4x4M5Toj+k2P6/TbuBGzOfIEYHSlqNlFu3CpgfV5VbnLkrqLhlDTieSM2FTI3IKf aipg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743522356; x=1744127156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+vDwb9HDwdUl0Ebx/4UWYmvDHxD9AeyHufpsAE/MqOc=; b=BbmqyiuyKXFck94HKMgy3vxzLUbEjc6HVvEorIHhgqjX/3YglR3mFwa9C6gQ7VK9ae erMmQpr3BPC5cewdQKBPo8aAOCRwaOYYqKkfHzUWKcJhjX4jm7FHB1UQj5uPepo+m03B qG3qhvq9MiGxQ6bE/pV2std9VMK3wU42OsFbZvzooboglXwWi1fDUUUxE269/RNogjK6 AAoVKM/HRt3HdFL0/Ogta23TZnNHhHIQF2gR8Z3MYMB4AyqJVE8oh2RCU99CxE3/ElJ5 Y2b1EvdvBNfNlHKPaIlszGjAwPmwQqE4ccgvWfzVx8l52UdNOu1xnT5KDJirrtqAmsWI WyJw== X-Forwarded-Encrypted: i=1; AJvYcCUnFjqJYWuIcz+A8+l4A/T36jMyYu6WZT6OAoV9LXrrzggW1Og5uOy2eb7dFJfPgbJV8UCTL/PQODKNcBCpmfZU@lists.infradead.org X-Gm-Message-State: AOJu0YwhNPrnEzhJljHUY6DHqcavTVri8yHYrxFpHtEFcq+5nn7HeD2I 4IhCq+bHzx4mD1vEWkDBqMtj3+6jSe/+7rr4Dci+G0MiiewgtmUN X-Gm-Gg: ASbGncsyJOhjfmJuBZRDGpJOl/Od5YDGBATrcKEB602qt1PkOq9ZeA/CB+JJ6lBt60w RjUCG2L3Wd48dj/IdmiOwfxgk6RrKK1FPlLBiGBCxCb7n39zFoT8tAbI0WzOR6eCRGoy0qC2mP/ RQzyXw/eHDVnK2witrP5f64tfDx2CjbxYUugBVpFM8DpZLedbREo62BpEpmyp5hzLQVeeuB6I/V Zy73Hf5ABg/+aBWgz3f4NBitr8pSDiwh8efkZX1V4BxwCGLfxY/bXiSnx178LUCQDcN695Ubbml GXUnIpbBLWPDV6rk1UO8cHgNCT6ro+mVLa8bLAqZzXqQNtD0HDGcb90m4MojzV8zqsV4y8Kq16I sumdwBwk= X-Google-Smtp-Source: AGHT+IGdYh9AkcbLHhxheKqNkh4lODmhkDXHSRQLhJxdjuV8FbGHRILAROQeiewvtT5pJYBzkuZvJw== X-Received: by 2002:a05:600c:3d8e:b0:43d:5ec:b2f4 with SMTP id 5b1f17b1804b1-43db6228293mr144790085e9.10.1743522355870; Tue, 01 Apr 2025 08:45:55 -0700 (PDT) Received: from playground.localdomain ([82.79.237.110]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d8ff042bcsm158795735e9.28.2025.04.01.08.45.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 08:45:55 -0700 (PDT) From: Laurentiu Mihalcea To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Daniel Baluta , Shengjiu Wang , Frank Li , Marco Felsch , Marc Kleine-Budde Cc: Pengutronix Kernel Team , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 4/6] arm64: dts: imx8mp: convert 'aips5' to 'aipstz5' Date: Tue, 1 Apr 2025 11:44:02 -0400 Message-Id: <20250401154404.45932-5-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> References: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250401_084557_254427_99E3FA96 X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Laurentiu Mihalcea AIPS5 is actually AIPSTZ5 as it offers some security-related configurations. Since these configurations need to be applied before accessing any of the peripherals on the bus, it's better to make AIPSTZ5 be their parent instead of keeping AIPS5 and adding a child node for AIPSTZ5. Also, because of the security configurations, the address space of the bus has to be changed to that of the configuration registers. Finally, since AIPSTZ5 belongs to the AUDIOMIX power domain, add the missing 'power-domains' property. The domain needs to be powered on before attempting to configure the security-related registers. The DT node name is not changed to avoid potential issues with DTs in which this node is referenced. Co-developed-by: Daniel Baluta Signed-off-by: Daniel Baluta Signed-off-by: Laurentiu Mihalcea Reviewed-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index ce6793b2d57e..aa7940c65f2d 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -1399,12 +1399,14 @@ eqos: ethernet@30bf0000 { }; }; - aips5: bus@30c00000 { - compatible = "fsl,aips-bus", "simple-bus"; - reg = <0x30c00000 0x400000>; + aips5: bus@30df0000 { + compatible = "fsl,imx8mp-aipstz"; + reg = <0x30df0000 0x10000>; + power-domains = <&pgc_audio>; #address-cells = <1>; #size-cells = <1>; - ranges; + #access-controller-cells = <3>; + ranges = <0x30c00000 0x30c00000 0x400000>; spba-bus@30c00000 { compatible = "fsl,spba-bus", "simple-bus"; From patchwork Tue Apr 1 15:44:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Mihalcea X-Patchwork-Id: 14035085 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58023C36010 for ; Tue, 1 Apr 2025 16:00:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ietc0fMCi11BuUwuyiJvWRzPfrCW2xOJHK6xEAe6XA8=; b=Wvy5Es1v8SxkbB/Qv8YjZPXHZq m3+B2E0S+EMkoX6PhvVOTvU894qB6d/dA4HaNie8qlxHd2N2oymQ/4Tn1s7jX5Y/AovPtdOUTaIkH uce/baK6cFM0r2OsRogvKiH4a9eyOClkctNhO/TkOfsyxBsx+DjkAyieCVWQvj85P0C7f47IZYdvw V5lCz7ZlVsZGZYiS1ve0Zi1xf+QcKbYZow4fFBGF2W7CVrQQ/quEnNtOcYvjCdzJlLdt6+U0Kl29a kFPlmJyDWsNt1Z5fNCEKVXVKC7RRCQxLi/t7JzczTo+WZ0qOrHoY/gVR08iBQ7h//ZkcGuuls8H6E iMfEyo3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tze2R-00000003no9-2mHF; Tue, 01 Apr 2025 16:00:31 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzdoN-00000003kyJ-1enF for linux-arm-kernel@lists.infradead.org; Tue, 01 Apr 2025 15:46:00 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43cf3192f3bso58081025e9.1 for ; Tue, 01 Apr 2025 08:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743522358; x=1744127158; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ietc0fMCi11BuUwuyiJvWRzPfrCW2xOJHK6xEAe6XA8=; b=IqYmo9eMmqeuxQ4t9iBSZfuC1FRcWYA424j38UTfI1G0j2OR6KnI73JGgIdA8GURbj 4CbPVl/bfxNQ+DlphHlnrgqoFAeVgKdNuBOYDAu7NcWTnKzVIPXP1avl/3Jen2DNSyDz DkikVOcGLpi/tTTRP9JbfAzuCUg5uO8rtgXZhZe5RDoHjeWQWLUVXT6vqxGqMXF2Y7aJ aQOD4/657iY2mI3QTAxBJayWfCwFdSGtIJ2DeO7r4CF0TGdwMu9MjYP/qmI9gqunkhmR D0OyX0zIjxtrTYWaRiO5cQInNbh/2kLOSxOHuuuSuJG34Juugn/xBuOHOfcibUugBwQ8 E/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743522358; x=1744127158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ietc0fMCi11BuUwuyiJvWRzPfrCW2xOJHK6xEAe6XA8=; b=Leq2HOxVa7tVxlYCylij9jjkcaf/EEi+69Tn/2XIWC2Pb4Pu4M3JhsSIeZ5awYcwa5 nR6G2yzLZgn2S8HLWL5nU2E1xTIQTifcUPB3ad08Y+H3iViZvDur08p8V2jo2ULF8D21 ofujg+Km4Y8BhaHNRJ7zIg1/9mXTLR9kylf3C9RKEvkuydflkYU/CY//S3LwLxe1k0Z2 KZVfk9ulm8hIQRS47QYZLHYlFqJd8AEPbU3lhquQWklmguqRmux/ho2VNtdZPLfR5cJO 23fgGIj9w6QS2VcLgjwE+6qGcWSR+RNTR4bBA4YKCqvxg2i4z7TD4hC2ffbk0mXEAQ+e TUPQ== X-Forwarded-Encrypted: i=1; AJvYcCVt+Ja1Dmm7Lc+dsVim290vUL3oynOf8jrf7zwfPU6uZS6IjcJtMIpdk64yk3coEdaBwjpK3hXFJMow7KtP6n1l@lists.infradead.org X-Gm-Message-State: AOJu0YyCLQi9v5jPBMQ/T1Oy2lI6qzgi+WaObHgK0J53TsVWFNo+UnUr +JG0wg2CZ+LCydAgcw55aaHz0T0Ny71msj3rHOWjZc1OcEkWbCfL X-Gm-Gg: ASbGncsUqycMv/gNAM3H81CDkHQzuxRQ549ctAMyc0WY4tfFBctu2O3XXYjUDzPk8/a jhVxhfhYmHJaYMSAQYHo43ehfxrcRvMsMPgN6RGxDccbDHcbu6jAGJYr++tcnJZJq4+Q0zEIc8Y EQmjGBq0omeYb+E1f1nvkkgFintMUX4QH9G2R/+7cFYHp6/2KFvqgfTyAGDCE/yT9eoLL7Rq5h+ gYXZumup/ubUBnHMVupMQoimuRxxheaJRX7c5r8ou4K554gdHxNamkOGoVLMHKNVA3aTDiqAHDN WgCUag6XB9tJ3x3L4dcifd1zr8hs4esXYeH7Fz2dSjO0AXDItD+Bmyn65jWfBLNfTcVK8OF1vHr v1vajbuI= X-Google-Smtp-Source: AGHT+IG9ZYKWN1b40JEhYbcSZx3uZ/1WRX1tT2EFyx9rWI4+Ii3DekqK4BS11iLLv97oUFUaX8G+Zw== X-Received: by 2002:a05:600c:3d0d:b0:43c:f44c:72a6 with SMTP id 5b1f17b1804b1-43db61e0584mr134804935e9.2.1743522357576; Tue, 01 Apr 2025 08:45:57 -0700 (PDT) Received: from playground.localdomain ([82.79.237.110]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d8ff042bcsm158795735e9.28.2025.04.01.08.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 08:45:57 -0700 (PDT) From: Laurentiu Mihalcea To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Daniel Baluta , Shengjiu Wang , Frank Li , Marco Felsch , Marc Kleine-Budde Cc: Pengutronix Kernel Team , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 5/6] arm64: dts: imx8mp: add aipstz master ID definitions Date: Tue, 1 Apr 2025 11:44:03 -0400 Message-Id: <20250401154404.45932-6-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> References: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250401_084559_435469_FCCC79A5 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Laurentiu Mihalcea Add header file with master ID definitions for i.MX8MP's AIPSTZ. Signed-off-by: Laurentiu Mihalcea Reviewed-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8mp-aipstz.h | 25 +++++++++++++++++++ arch/arm64/boot/dts/freescale/imx8mp.dtsi | 1 + 2 files changed, 26 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-aipstz.h diff --git a/arch/arm64/boot/dts/freescale/imx8mp-aipstz.h b/arch/arm64/boot/dts/freescale/imx8mp-aipstz.h new file mode 100644 index 000000000000..23725cdef23b --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-aipstz.h @@ -0,0 +1,25 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */ +/* + * Copyright 2025 NXP + */ + +#ifndef __IMX8MP_AIPSTZ_H +#define __IMX8MP_AIPSTZ_H + +#include + +/* master ID definitions */ +#define IMX8MP_AIPSTZ_EDMA 0 /* AUDIOMIX EDMA */ +#define IMX8MP_AIPSTZ_CA53 1 /* Cortex-A53 cluster */ +#define IMX8MP_AIPSTZ_SDMA2 3 /* AUDIOMIX SDMA2 */ +#define IMX8MP_AIPSTZ_SDMA3 3 /* AUDIOMIX SDMA3 */ +#define IMX8MP_AIPSTZ_HIFI4 5 /* HIFI4 DSP */ +#define IMX8MP_AIPSTZ_CM7 6 /* Cortex-M7 */ + +/* helper macros */ +#define IMX8MP_AIPSTZ_HIFI4_T_RW_PL \ + IMX_AIPSTZ_MASTER \ + IMX8MP_AIPSTZ_HIFI4 \ + (IMX_AIPSTZ_MPL | IMX_AIPSTZ_MTW | IMX_AIPSTZ_MTR) + +#endif /* __IMX8MP_AIPSTZ_H */ diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index aa7940c65f2d..ebbc99f9ceba 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -12,6 +12,7 @@ #include #include +#include "imx8mp-aipstz.h" #include "imx8mp-pinfunc.h" / { From patchwork Tue Apr 1 15:44:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurentiu Mihalcea X-Patchwork-Id: 14035086 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6572C36010 for ; Tue, 1 Apr 2025 16:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ESjB9FswjsXqDkh+hAstUPSbEKWZtoMzCjv/1OB1iXM=; b=NTEfSzlVC4bH0oa7y4CH0OrigJ ISxqHBmXi1idYGMaUUGZMU741BsK53g2+RWdVediYFT2G8VDCfArj8kueJ0u38xr/nkCvSw/BrLvH wFsRDnniXwwQY/j29f7BOETt13jUD1IeIkArlE88X4XlnZqHGxHUyXmXoWdU/zAQ/N2V5fDoGfpgQ 4rCnuWHwBpibdfVj2WFtaQcaQy/MAleToM6wALVPJ/R9XHjy6olrFPXhQ8uawqOIvwTduhqrcT+Xj njKdWBre9m2aZlEwsGLe5KyOXqFP88xrK5d3X/cIUpCDHKwFJGib3Zq9KDYPu1PxMj02KFrHEvXED pExXwGQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tze4C-00000003o4Y-1VyQ; Tue, 01 Apr 2025 16:02:20 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzdoP-00000003kz9-0nAy for linux-arm-kernel@lists.infradead.org; Tue, 01 Apr 2025 15:46:02 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-43cef035a3bso41902875e9.1 for ; Tue, 01 Apr 2025 08:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743522359; x=1744127159; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ESjB9FswjsXqDkh+hAstUPSbEKWZtoMzCjv/1OB1iXM=; b=WTnrPK9plhnJtIvVJWojnbVzmFSVEGK1pXkCgfxtVAZjOg6pLStBuTqF34+fWGF+J6 17rWVDsz+VthYeHag4Z87VMp2URzwkYfCYX2kj76bI/BPdto0/i+4XS4sY3Vj79H3CO8 JCUv+w0KWIfnXZZo4Dey6IPoMbIEcO4FNZQI5u6RQVP8M/u1LAD3eAfnLKI+E7FA/j5s T6yM9Uf4NPZoHXqseMnC0isgost9ONiJc+pD+ckXssGDXDZZAw1mNrNLiZuw/kTCKlVR PpPrNhZikKoBoEX1dEUaiRLgpDfYrY8pDdxWDQx5+j8gmP8RJ1FXtA1ZRdE0QH0IQsae CsuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743522359; x=1744127159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ESjB9FswjsXqDkh+hAstUPSbEKWZtoMzCjv/1OB1iXM=; b=DVfJAJ0yVU2aT2Mm6lrORk1nG5WnvOkpXhd2NVu/Te/DR9h71xjW4A38rCMOMWOOwZ jVwX+0d4ptJWBRIoke1qOLNMNYbnKwIGEnGIrlMLPa9LKRTls7RM2IDGKoybrXxHZGWU noIBeAtpHTRThtafS6MDrFk7S7L0IiQMrDT2t3dlip0EvNdLBUJ3D+i+JIeDBTTv7Vgg YClsDReYxuztG4+VnrrSFHBo4UL3ByQZV9UTHHVTbP7/44o9Z84tZmUSiqjzsRSV9Dgv Mo7ZrFTD6DZL9v6D8ftc3g7Rk/RGn4oZTaC6jtfLFasUlp5joRhJxTQzVYpFk1sTZWcf ULuA== X-Forwarded-Encrypted: i=1; AJvYcCWrnowxW2xX4sM00tH/JGd1oRzfhiAn+Z8NFWeb3/xtQptMgoUQ/xuFy+GnEG/YpT6tzAKpIjIeFl+sV1jNJgVk@lists.infradead.org X-Gm-Message-State: AOJu0YysPCsVn2qclPdkHGZwcx0WkJ5LB8kh0Gj17d7sZRSy9QIBPnRg wZ8Z7MFPxh4TGwvdCFpSHpDGPQ8uEddjz1EBWBtKY1TDYZaR76QZ X-Gm-Gg: ASbGnctX7n4+0WMwVth2iHh+7ml/wj4Rmsuf5CyHG1YjMB1v7O/uDBVgX9Kdx2Q3rzI zSuqPhQNHJVbrWJmi/LnPVPyt/ANdWxUgOeFTUsAUa+PIXxMCsnszA9A53QF9eARVnFCj4Js6uV W6ZVAvciwYzHg9unw6FevhXT2pPYpA3ijsqMr/Spk8UfF3qO4YsjHdgsBJCUSc+jFjwTVlM0JZ3 N1zRXnNVjGT91uxDZdDPHKc8+ywefH+vkd7pfE0x2sAHiVLsNRGBrfM7ODQcbEQuev1NNPbPzp9 8FQMgPVtOrdnUeuhAYlGClxHTVfI+h+qJqGlqGFttsCPuWR9g5yJPeLQ219S2BBD2hgYQfHIbi1 xWMIIpOmp5gY3VWNWCw== X-Google-Smtp-Source: AGHT+IGKhtb6fsJZMzdARBi+gb1FIGOla8Dmwwf9ptz7h3kdFPWq1TAOfA22Dh/s0xKKlSvTPmHHiQ== X-Received: by 2002:a05:6000:381:b0:39c:1f0a:ee0 with SMTP id ffacd0b85a97d-39c1f0a0f69mr5198566f8f.2.1743522359440; Tue, 01 Apr 2025 08:45:59 -0700 (PDT) Received: from playground.localdomain ([82.79.237.110]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d8ff042bcsm158795735e9.28.2025.04.01.08.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 08:45:59 -0700 (PDT) From: Laurentiu Mihalcea To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Daniel Baluta , Shengjiu Wang , Frank Li , Marco Felsch , Marc Kleine-Budde Cc: Pengutronix Kernel Team , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 6/6] arm64: dts: imx8mp: make 'dsp' node depend on 'aips5' Date: Tue, 1 Apr 2025 11:44:04 -0400 Message-Id: <20250401154404.45932-7-laurentiumihalcea111@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> References: <20250401154404.45932-1-laurentiumihalcea111@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250401_084601_245627_4A270C3B X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Laurentiu Mihalcea The DSP needs to access peripherals on AIPSTZ5 (to communicate with the AP using AUDIOMIX MU, for instance). To do so, the security-related registers of the bridge have to be configured before the DSP is started. Enforce a dependency on AIPSTZ5 by adding the 'access-controllers' property to the 'dsp' node. Signed-off-by: Laurentiu Mihalcea Reviewed-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index ebbc99f9ceba..f0f0ff5edea6 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -2425,6 +2425,7 @@ dsp: dsp@3b6e8000 { mboxes = <&mu2 2 0>, <&mu2 2 1>, <&mu2 3 0>, <&mu2 3 1>; memory-region = <&dsp_reserved>; + access-controllers = <&aips5 IMX8MP_AIPSTZ_HIFI4_T_RW_PL>; status = "disabled"; }; };