From patchwork Thu Mar 21 21:20:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Mack X-Patchwork-Id: 10864381 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0B3DD1515 for ; Thu, 21 Mar 2019 21:20:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D9CDE2A4BC for ; Thu, 21 Mar 2019 21:20:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CDE962A4F4; Thu, 21 Mar 2019 21:20:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C40332A4FC for ; Thu, 21 Mar 2019 21:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Nyl/k8qXtHGi5b9/jxCu8UJLa+e+AlQBTvAzeJSg7dg=; b=Jsl/CP2xLzoEwf ZOw5kRKYW0WE8xPmgCM2JDZoPcSVTsEZxkIsMf5JusZfO7HkCjCf2Xbx4ac00jMjBU3QaE/Kp4UuE cVEevnM2toFChdI9WPBpXjmQzCztEsom7D1H+EERNuJB5ogVW96zH25/heVHkKmqP6b2/bkp+sr8O +qMOmRYhKP0T3gllIi5Qn8kNbnzmO5SakUcFCn/oTNWziYbqWpZUYzW3+JlrA3JGjilbgaMvatE7z wFQvr4S2LidLAJc8Bts0d4sP4OtPGJ+BdLdAkKvIHROCJ2br9TjKNdzwXF9Efkzrml+KIFkSOFmdv jKSsV+JkVk8Bv3XxsFdg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h756z-0004Qe-No; Thu, 21 Mar 2019 21:20:29 +0000 Received: from mail.bugwerft.de ([2a03:6000:1011::59]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h756w-0004QF-4t; Thu, 21 Mar 2019 21:20:27 +0000 Received: from localhost.localdomain (pD95EF74E.dip0.t-ipconnect.de [217.94.247.78]) by mail.bugwerft.de (Postfix) with ESMTPSA id 8DE10381860; Thu, 21 Mar 2019 21:19:07 +0000 (UTC) From: Daniel Mack To: boris.brezillon@collabora.com Subject: [PATCH] mtd: rawnand: marvell: select target before setting up data interface Date: Thu, 21 Mar 2019 22:20:10 +0100 Message-Id: <20190321212010.3995-1-daniel@zonque.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190321_142026_328323_0A1B40E0 X-CRM114-Status: UNSURE ( 8.11 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: haojian.zhuang@gmail.com, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, miquel.raynal@bootlin.com, stable@vger.kernel.org, robert.jarzmik@free.fr, Daniel Mack Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Now that the nand drivers are responsible for selecting the target prior to hardware access, a call to marvell_nfc_select_target() is necessary from marvell_nfc_setup_data_interface(). This is a regression introduced by commit b25251414f6e ("mtd: rawnand: marvell: Stop implementing ->select_chip()"). Fixes: b25251414f6e ("mtd: rawnand: marvell: Stop implementing ->select_chip()") Cc: Boris Brezillon Cc: Signed-off-by: Daniel Mack Acked-by: Miquel Raynal --- drivers/mtd/nand/raw/marvell_nand.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c index 84283c6bb0ff..93abe5be8995 100644 --- a/drivers/mtd/nand/raw/marvell_nand.c +++ b/drivers/mtd/nand/raw/marvell_nand.c @@ -2325,6 +2325,8 @@ static int marvell_nfc_setup_data_interface(struct nand_chip *chip, int chipnr, struct marvell_nfc_timings nfc_tmg; int read_delay; + marvell_nfc_select_target(chip, chip->cur_cs); + sdr = nand_get_sdr_timings(conf); if (IS_ERR(sdr)) return PTR_ERR(sdr);