From patchwork Tue Apr 8 07:17:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042333 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63B21C3600C for ; Tue, 8 Apr 2025 07:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6bblWb/A3f8Vp31ZlZJvX8Y6uILdxWWSmqIBQEBD8XE=; b=Rc86dpqR/iC113nbNkDsNFO358 zyPjoDaxqegfbjIJ3GcFR/UumcSrJ8K14goAiz2YKRXHrAX/tUDKrdTA31yWpvCqqgVdA1dEy8sRo /7P0ZuRYiXZOArY3IO5o2JG5OAAxFTusUO1SPuIcvitT8aJrqGx8kj2IqIZfB51Q6y3x+d7usZIBX +jHITTnb3gL1SnjnrpNQwbHTt03DmyyGZaRxTgS924i1yvRjh7Ytg9EB/YqpskyT+Z7WYLuhUTrjX p4elOgFm9AKQE2GyPkzZAss+7WtDwHD8Tsa4ppfFfoJM2Fn43Nl8GXfCW/uP1jnKuDvfrrwSkLV77 dxhViMPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23T8-000000035I3-35Kn; Tue, 08 Apr 2025 07:34:02 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Je-0000000331j-34tq for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 07:24:15 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-548409cd2a8so6172574e87.3 for ; Tue, 08 Apr 2025 00:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097053; x=1744701853; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6bblWb/A3f8Vp31ZlZJvX8Y6uILdxWWSmqIBQEBD8XE=; b=TIkULY0G55+hSIJqzLnGL/KpEHN9Z6kuwe/zshQQpckDQxB20glI+QfBmR+GODCHMP g3iHSaJ5SbuBj6WciZZkqcky8xZA1Hd8kIy1PhiY3PnlmMsXX99k0zGal2PRU3pHtSsm 7rYupgUt4mEk8DfUjlEzdOdVpUbSSUXW6VEZfuB665gKy5btl98DpJ0uCHHWGree0urA DoeX6lSBQ8F/Tv6SuzpUbDuJFuXvh4aDgOsEl8rF/0hRfdlcUGnDomQgVdA6M9jYvWPi PIgajNpPbjo5Rvks7oFgPJJ00G7lKzGMcVYK0YL0+z1dQnYgqvZb34tXobnD0ZpL02G5 YB9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097053; x=1744701853; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6bblWb/A3f8Vp31ZlZJvX8Y6uILdxWWSmqIBQEBD8XE=; b=c9OyvLvGeqeGVAb//zLoqCFXaoW9JQpplfA1VvbL4u6TmMYEHGtxEGafc84ZVPXWzF eV+xyo2qNOafKYozLxDNSWXbSyfdkgMljoH1R885drXANi4r4pj/FnGcHjIyDO8idFi2 C3w8u79U7S3lVQsgA1dEyQBSC9KSh/Aayz+TbLLekqH54iQU2NWgqJXyxQuAtwPApS4X 9n7n9D6eYx0GP+a5j8dKSd0MxAN3h4fDuqk37ae1iAnpCtzsPKR+CZDx/QhPDthiX5CD mmL5ipvl8Ro/y+9dsqTGIK35wDGrvhlQwpW6wCg2TDG8r+lHPYjggQzTY3Z/BzQt/txt /d3Q== X-Gm-Message-State: AOJu0YwkJq8DzYPb1tZI8C1v9r3aXzLjjD+EOZUjUKdu7N3wDvssiIPH FUZz0wK216zG6sl5Yf27iS6gimiUzov77Q9CBHCHIsmvrVZM4Br/0Qio6tWtwnMTcOFwxkst6ZE kicI= X-Gm-Gg: ASbGncsNkVOZ6uJjgyGEjWmHuAcnXDmaThVJMaipNkHjrnczqM/4Gj7sXDVrnmYeVFc iAaXOhtgw9UFVIKW1CGm58JOSWT7bGW6S8Z3ksZaNCnHiGTCSmDgPGJqw1vSf0P0Xq6NMJY+CeE liJskEE5mlZHE4B9VbW7t8f+AwLX4CDNuo98PvcmN7ZMrovqdZ8VIRLWS/3c6OmTshTCnFuY3z2 mymBuTGuLKPchzfBUoRaXNfik16TIiyvDzHJ3hJuWuD4G5qPNKBNf3B7S9PWR7607mfS+Llq1Po dv9rLC+Ol7Tq/XJiO91nmsDy4JwpqyusYkp3Vw== X-Google-Smtp-Source: AGHT+IHqIWuX5sWz9MJQWDS2IT6lTfF85m614lClDoVvdHMGky/Ix50ZxwKNqFgfUZCLhjcPg/Mzog== X-Received: by 2002:a05:6000:4313:b0:39c:2669:d786 with SMTP id ffacd0b85a97d-39cb359830amr12025582f8f.19.1744096669312; Tue, 08 Apr 2025 00:17:49 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:48 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:38 +0200 Subject: [PATCH 01/10] pinctrl: at91-pio4: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-1-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2256; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=6oXQdDn+JiYI7kPrR9MR4Ulr8BlxDaIdgOQst72f6aI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2ZS1CVSr+OpPpLt+g73dsnxK7Cn+5jOBkEm S4RhLYFpI2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX ckshEADgmKAecLNRDwbY5cLUNohPOOEtx7wPD6IeqZgsOFSImxcR1AYiTklwNvcEyx4WnHhAmzb oG3lzRmS0xFVCzQi9mX4uHbuIJXP1MxN2ddsgnB6lg1CEj1b4qv6DNNxxtBQ0ipnDwRNuawQcwH aeYqABy61n2vfrZJBJVOSi9TQAkdSEJwgvanfueiX/vJnvVKET+cxjJqHSgRCxlPdre/sm0kKMI CCPKVMovBcpT7OOGP0j4+p0kCB6NCqevlaTewuoV/h4tWjYpF6SH9gESREPjsk7R213eO+DWr4n UFTfB1ByxQw7vd5agHmcng2yl1ZV7SUNOsT5kf6nSoI4cvkeO4ons+t63tePlkRUDoQumIQzhga N/mIkjV7W2xjVvZrcZEGS63D38/fzY4sA7sVuWaWgZwWrCrfhPajPxotxjxOsvTWXSWJkfh6ixI f2yLdNBgi9wSYNat2UoYPTLeRh3lzFjphWxPajFb+ZQczTx/bXcjtpDXNQewa78BXhZ30rEIrF/ M3gIErsXpEjyv3RmSJV7CGPdxfLwaxjHq9SZNfNqeeYValUtoqirxITK0jSaQrmdUBMmUx/IqJs XwWZMdG3msE++lZ6NvgjhT2WFVsie3VhFAI2l/WdsxXhiwXItFE0r0m2V8VtqyUKn2/YCh5ew2+ nnZya7p1LkYH6fg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_002414_777818_9333AA22 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Claudiu Beznea --- drivers/pinctrl/pinctrl-at91-pio4.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c index 8b01d312305a..5db839fa9b3f 100644 --- a/drivers/pinctrl/pinctrl-at91-pio4.c +++ b/drivers/pinctrl/pinctrl-at91-pio4.c @@ -390,7 +390,7 @@ static int atmel_gpio_direction_output(struct gpio_chip *chip, return 0; } -static void atmel_gpio_set(struct gpio_chip *chip, unsigned int offset, int val) +static int atmel_gpio_set(struct gpio_chip *chip, unsigned int offset, int val) { struct atmel_pioctrl *atmel_pioctrl = gpiochip_get_data(chip); struct atmel_pin *pin = atmel_pioctrl->pins[offset]; @@ -398,10 +398,12 @@ static void atmel_gpio_set(struct gpio_chip *chip, unsigned int offset, int val) atmel_gpio_write(atmel_pioctrl, pin->bank, val ? ATMEL_PIO_SODR : ATMEL_PIO_CODR, BIT(pin->line)); + + return 0; } -static void atmel_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, - unsigned long *bits) +static int atmel_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, + unsigned long *bits) { struct atmel_pioctrl *atmel_pioctrl = gpiochip_get_data(chip); unsigned int bank; @@ -431,6 +433,8 @@ static void atmel_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, bits[word] >>= ATMEL_PIO_NPINS_PER_BANK; #endif } + + return 0; } static struct gpio_chip atmel_gpio_chip = { @@ -438,8 +442,8 @@ static struct gpio_chip atmel_gpio_chip = { .get = atmel_gpio_get, .get_multiple = atmel_gpio_get_multiple, .direction_output = atmel_gpio_direction_output, - .set = atmel_gpio_set, - .set_multiple = atmel_gpio_set_multiple, + .set_rv = atmel_gpio_set, + .set_multiple_rv = atmel_gpio_set_multiple, .to_irq = atmel_gpio_to_irq, .base = 0, }; From patchwork Tue Apr 8 07:17:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042286 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2526DC3600C for ; Tue, 8 Apr 2025 07:21:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KHbdZ8I5zBJbhRifEOkTpCnTw3e9jVPzpvQJpqCzg30=; b=nBF0NDDDnqKGajyypWlQKo+1WS B8SHrrgWJ60iMP7CebKRFIOcsGsWoT4qa81+gC4ue2y9c5E2tBZxffsLSIKoERE2Z7iH+R5/UnbJj 5TzfkOpJ8qMOvH5Cf6cFkIzZItyFxRM4LV1uBX0QHn/dbPDgKfwSjr/BS/MeRXexgFM057q+Z800g 7XT+8MxQwzbupNN427CwPg0Fqe9AGCY9C0ZU4dLz+mdP+keefn0dRdmEUs9GFx7i73tVUTUAr1SoP LZMwMvnX4HHKGLAbIbHsZ1LW2olTX0MEVIdj5vUf2XPKtoxXrKOYepf+9Cm2Q6ZmKJTRXF6aUbciP CgIBXwfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Gy-000000032NC-3Om1; Tue, 08 Apr 2025 07:21:28 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23DV-000000031e7-3kus for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 07:17:54 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-38f2f391864so2824959f8f.3 for ; Tue, 08 Apr 2025 00:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096672; x=1744701472; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KHbdZ8I5zBJbhRifEOkTpCnTw3e9jVPzpvQJpqCzg30=; b=w0tMD1QQ3CrVrwot2hVqwf+UUBr2I0A83Sh/N0n0ST6U4mGmYjWOvqLYiC7l8iJUY2 Rt4/kqR4ga/a4koGK7AHaff77tDUGzSdqf7WbTcLA2JXZdWMzLjmpGiZKbkCoUCK4KHN +0YRu+65pDbOW3LcsaYqBPeEfN1aPKlGnpGKIRrbIzFHpmTibNJ6k0r/D+vuCmq4ypKn zKKMcSfYXBA2daQ5YKdZSmi1V1LhLYhDiyHY/KGMvVcL0TDek877uyo81QrSrkT+fuBA pWdGbmDEW3qIIvmyRPHm7Re/pGYphcx5oGZQb1UsOLTlX5KcLhOL1enivfIN+pODeCmO ZolQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096672; x=1744701472; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KHbdZ8I5zBJbhRifEOkTpCnTw3e9jVPzpvQJpqCzg30=; b=qLL7z/sp2HTuj79/KP1xSyZaVHGMQjvpX7NSHW96HiX0i9sD8Ls51aEIdd8HKE/ayK GmupGYAeWnueV+0j1lWgKfLomjEUDQQl+p3EDmh4zkwtKQxRiZSJFaj6AOu6vS8RORfF 0Ecn9NxU6cgh3yjHAWSXMaa3hmkzsFd/ySy5vS1aknN4c8+2E0yFkqQlKoobi9HK9HHu p0TZ40J0pchqy8ZGr52EOJOSOt7MLuFugsazB9bVVuRib78qhph6FcEI5yIMTyF9R5jr vARuOrlUAcud4wl7nVGdCmDLKPmynzrUPsyMdtyyeSlp6bjjoK7Aj2a1uu5k6EybnKW5 3I0w== X-Gm-Message-State: AOJu0YxWQIwZsbBDf2tnaRu5vDy5BAMjGj6Melx+bZBY1L4oSeyPZPoz fCIe/WSXSpsjQfn15aTufvjOUhKVmN6t3M98buAnAQu0GyMJ5XZdZtj8ReUIWszSh2BuD6igKZW IqzM= X-Gm-Gg: ASbGncunsRMQQdRBeKRJTdfrs4pzYAZKGiZPI4cpLG62dZMPPHYNY4NiCfJBUt3Y7r0 Fxu+yRG95ABxDnjr5/t3Jj/xCGiNb95YF13hFA1JxoCA82DAE3hltmdsUfssd+6Q7IWx9ZU89aI ImfMqbpoOswO0cK9yEW0fET/Kg89DSCH3r3RTDz1U67s/B8jJloXvwkajdKNVZ0XwPV9+kXNKcK a4e9vn6LTdWKJ1QiZygsoyYILfmqhkBUlGlN/lOoR85+2kjGH1FEyuIiNP6vdcDNTV8otx/MHKx vRKtRq2ARXpSl6qMtbgcN5nQBHVAGdTOyMaDaA== X-Google-Smtp-Source: AGHT+IG66JLNMA6/+F4yvPGqakGWzMF6ZtCNetVsbjFv2aPqMbejsIAN56v674i7htexv9OZa2w1UA== X-Received: by 2002:a5d:5f96:0:b0:390:f2f1:2a17 with SMTP id ffacd0b85a97d-39d1466229bmr14181138f8f.53.1744096672155; Tue, 08 Apr 2025 00:17:52 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:51 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:39 +0200 Subject: [PATCH 02/10] pinctrl: rk805: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-2-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2092; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=sUTrzWuOo7PVik1QzFjSyEGMbbgvgdGB1epc3LKWdY4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2ZtGmml6ycwEzk3KhRs/YW0AQqsaUfB686c +V6uDVoAR+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX cttsEACbtqoZ/RYzP/rSItzAm6RyIKDSI67qmiaM3eZO+Qwuz4UvIvJ/GL6pV94KgneXWwmwPKo P7ywI2W0szbMsr9K+DM7p2BGeLSS8pyImHtM3ITgmaayPUvVb3Y7MrTj+v9MYNRnjYl5sGRlIjK 1EmAEesdJqsGiDikg07oXYnqGVad+4NJ2zxDtQ5n7tB3ShEJusRuIFA35sixjIGRTR4Nr+0DmSH ARiPMtTFkfjtgsXBEDCv0PRzyup4961wgfvFgQ7GRwqsXxRacjsZAEmoYduAjZjqdJ1dny8C8i/ Evwq8RUqfgTcjvwjmVDu3klH9BEGNcZX9frolFeag0oRT7/RZHWm0ZxaKaU4rlH/E0Io6pd73nU sw0vsjb8AZuD4il5knSflEdQN3RuRoPp/QdnpHdPim0zwLKdIVMyzNu6p2O0tRQGmQi3tJnf6+/ +iwIO4FrFQOgX9vh4VdG91Tuu+BBuoCRJMWkbcnWF5dZaX6tREBxwtDhCsxPH58+4G5NQgX0XN+ IJgHJLn/R/KYnp/l1eWewkxcLXRRPGbcaEUJ5lTHuvd6fGpdv0Af4X3rK0WZJ6UwBJw5u6pQLY5 8YdLZCYvmvA8jSXhIocYAmemyaGKAMW/JnBi6mtMkH5dOwmpnp+SvX5iwwf+9a5m+kDEg4dWidg WpA2txNtQ9d547g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001753_950163_23F498D2 X-CRM114-Status: GOOD ( 12.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-rk805.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rk805.c b/drivers/pinctrl/pinctrl-rk805.c index c42f1bf93404..fc0e330b1d11 100644 --- a/drivers/pinctrl/pinctrl-rk805.c +++ b/drivers/pinctrl/pinctrl-rk805.c @@ -325,26 +325,26 @@ static int rk805_gpio_get(struct gpio_chip *chip, unsigned int offset) return !!(val & pci->pin_cfg[offset].val_msk); } -static void rk805_gpio_set(struct gpio_chip *chip, - unsigned int offset, - int value) +static int rk805_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct rk805_pctrl_info *pci = gpiochip_get_data(chip); - int ret; - ret = regmap_update_bits(pci->rk808->regmap, - pci->pin_cfg[offset].reg, - pci->pin_cfg[offset].val_msk, - value ? pci->pin_cfg[offset].val_msk : 0); - if (ret) - dev_err(pci->dev, "set gpio%d value %d failed\n", - offset, value); + return regmap_update_bits(pci->rk808->regmap, + pci->pin_cfg[offset].reg, + pci->pin_cfg[offset].val_msk, + value ? pci->pin_cfg[offset].val_msk : 0); } static int rk805_gpio_direction_output(struct gpio_chip *chip, unsigned int offset, int value) { - rk805_gpio_set(chip, offset, value); + int ret; + + ret = rk805_gpio_set(chip, offset, value); + if (ret) + return ret; + return pinctrl_gpio_direction_output(chip, offset); } @@ -378,7 +378,7 @@ static const struct gpio_chip rk805_gpio_chip = { .free = gpiochip_generic_free, .get_direction = rk805_gpio_get_direction, .get = rk805_gpio_get, - .set = rk805_gpio_set, + .set_rv = rk805_gpio_set, .direction_input = pinctrl_gpio_direction_input, .direction_output = rk805_gpio_direction_output, .can_sleep = true, From patchwork Tue Apr 8 07:17:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3018C3600C for ; Tue, 8 Apr 2025 07:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kgKpi2eMQzrwoQvXzcbqAzy5xxQOgpVGvK0+n6zqybM=; b=h0Bl8yygYB+hQsQ5yEBd/Wri2U LZYYuBJ7kzFKuNgNwxbIIE2Dal8IsjkPbkqmkZuCB+6/W3rlupy4g7pEHLuGA65jlQxkgLS03Bxbr iHkH5mEi79tu2nLLtCX0VCBiyPH2Lj6EdbKlsqGhDYyB8e8LYm9CyJmg2uvBixKVUyd+3Vp6cIw/W wgEUy2k0qEA4QNZvRYy1fY6YlCL1MqfgJPC/AGeSgchdSScF8hZLLh0QFtN3RcgMY/WsbcO0qdp/1 ZSM60mCdejyp/8v4DvgrP0Rf62BJEUWEpp6vpZPtdzN5lZmohHpTYfXqqtZTg6wX5e8iPoT4FaHzo zl9oP6aQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Ii-000000032p4-1Jmb; Tue, 08 Apr 2025 07:23:16 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23DW-000000031eI-3bIN for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 07:17:56 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3913d129c1aso3548063f8f.0 for ; Tue, 08 Apr 2025 00:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096673; x=1744701473; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kgKpi2eMQzrwoQvXzcbqAzy5xxQOgpVGvK0+n6zqybM=; b=WJww3g8PjrYpTaphVdOKHc2Nh+nHI+oACWaNsBvm7Y8368n4bE1nmqz25mkgitMVrQ 9yd4i1HdD017vEtzjOe73UjN7pPUax61onolN7YGmUzSTtqwCDZgEqJ+IEyKt+fIa/1U yK7ASpQK2SFrM7WF6tYz2Jcxv+GYM+qkL+m+Dfd3C3+4yHI1Z8D3Z5nbroLVtRQtlG8V oRkL/qJFGG+TV2ACQlmB96tm6JyAAJtVluz3H7uD8KN49mv1QUZwRTkDBwsk3dHXt/CZ I7+GNC8Tfclofi/kfGZLDrtgf0Cy5QOCVX9MehN8F07B6dnFX/ceAZfd/GWrkK4TmdtD iOzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096673; x=1744701473; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kgKpi2eMQzrwoQvXzcbqAzy5xxQOgpVGvK0+n6zqybM=; b=G5rQGrov3l6WQKPSXsD7r/Ph/jCuQzOr9EaASp2ZRLf2mEQQsZ5/Q2mqTjFR/aszrK zN9a5jYgW6WLe14LkTqrAjXS/ojUKuWVwMK42Geyy3gbQQZ3nbT0oOjlYyMYoSpr3BP/ AdUFbs+LHdP8UHZFPtEmlrurvzIt54dj36a5fYKSJ7L+Fbyft2ntJc+OVhi9+6GJt1PJ gO47xXtqboxztwYdhVz77W0HOf1naY/XWlHyY6AQyoLArtSHsO+n5qx4g8qub7GQLff8 p4G7S/ausOmPwowkqnBDcUc8pjuuiBcgq2/ojMUgOetDfu4AAp9qdT77rIA8Rej1+z0F lUbQ== X-Gm-Message-State: AOJu0Yxlnw2lyOeP7zObYuP4I4MJ28PuB6qNKwtIjKhLPK5LXM8jKDd8 p1B3GS/O0Hc+DluKCkNTsxcRBUiCZI0e3/2heSGJFREasTSrZi8EWDuWa7rfZJU= X-Gm-Gg: ASbGncuwCe4WU0+S2gRo70tuK4ajUiLIbwqtn2NVHIbYCSjIJT6GE494MZWNB9+IUtc I0/44SKYNVGDo+1OkIIkG2GoFkyePCirTVjJcmpvwM0E3+JGjLUruKb4CuNerxCyYUD4+XDeJt6 0RIxSxuIxdzrxr0B+8Ap6i9X6SujfP7X//NZjnUoTPvj0akA39wvrxp3XLswYuGnyTModuaBr+G k9jGwjSZ8zlLENwN6+Dijr68sL6CQNF7hAhjhkE4JCTY163LzozhQ7fXi7zr4R7TNlNKc+tT9Yl bV3vI5FlJHFhMCxaNpw3pDdGbIpQpQLXbRbGPQ== X-Google-Smtp-Source: AGHT+IFIDoEgtgjZmRm76oLe4qBixaJVFcxIWBxSgP9eQc/+muRPjB5OZ4DhcXqFSFfMWbn8IPCLNw== X-Received: by 2002:a05:6000:2484:b0:38d:ae1e:2f3c with SMTP id ffacd0b85a97d-39d820eb1f9mr1593525f8f.25.1744096673169; Tue, 08 Apr 2025 00:17:53 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:52 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:40 +0200 Subject: [PATCH 03/10] pinctrl: abx500: enable building modules with COMPILE_TEST=y MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-3-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1197; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=7gT59a+ieEBoRyUfHtp8d/jvYbZrPQXR8M3Rkb54480=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2Z62HjgrUOk13umM6zCKtt5wsF8hMyPqGii +FbeYzWZu2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX cr+9D/4pVK6myjhrhbvOnoR4PHJ367IIWOAh/Zh8cc762qftCq98AjRSHWjpi3KMWk+T1SoewR6 yd9FAaYyN5ggStwHN8ifchYiv+JA8sO+i6UuSIOQUVQzey/SsbW1SeTgmZ3o/GsdKPG/HjoxejZ M1kbfrXMCRWGU5zTxGwLAZl126dUhXDTKScOqGDG6ZLFctZH0MSBmu4Nu7uWpRWQK3R+Xr6OGfa +BSLVhz77RThlP5bmwNejIlKFQNdlTKOpKLwZ4d0FEN5QJPa8Epbb+Vvkputkda+ERCCbCEvjf9 8ZSHC0SCNCcLyorbyOA6rgYWiPo+GZMHSqoF/Pl1OFZzp2mCtAXPyQrKJ2wv0I5KYUJSLuNstbX pAA8HtMWVKN2o8VTfFf0kYbEFAo7BM5D+3B86ctemR78XtjX9vA/33qPRw6qbRuWNjF2jLMxwGg 7sr3CLWFwcyqt8oNdhyjEWmfnIO2z+BYPCo7Btr52pKon7rbGIyJAAG4gxmUqgjRO/PJ06aCPjV erKdtcafZvxLT9Mf2jX/+expNbOTo5PKgOvekHmSlI2xdATbBZgMQPxFNUNJVlXLL3UGV8fR/Zh +ApMwVs12NjHuf/sT9aZDxPH2zbKJvARpXLKynmGD52HIn+u06LPHHbZH2+obwAez7+Tde1ydSJ G1AuErL37JcATMA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001754_900242_DDF9D9F5 X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski Increase the build coverage by enabling the abx500 modules with COMPILE_TEST=y. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/nomadik/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/nomadik/Kconfig b/drivers/pinctrl/nomadik/Kconfig index aafecf348670..2c1f8a4f5d24 100644 --- a/drivers/pinctrl/nomadik/Kconfig +++ b/drivers/pinctrl/nomadik/Kconfig @@ -1,20 +1,20 @@ # SPDX-License-Identifier: GPL-2.0-only -if ARCH_U8500 +if (ARCH_U8500 || COMPILE_TEST) config PINCTRL_ABX500 bool "ST-Ericsson ABx500 family Mixed Signal Circuit gpio functions" - depends on AB8500_CORE + depends on AB8500_CORE || COMPILE_TEST select GENERIC_PINCONF help Select this to enable the ABx500 family IC GPIO driver config PINCTRL_AB8500 bool "AB8500 pin controller driver" - depends on PINCTRL_ABX500 && ARCH_U8500 + depends on PINCTRL_ABX500 && (ARCH_U8500 || COMPILE_TEST) config PINCTRL_AB8505 bool "AB8505 pin controller driver" - depends on PINCTRL_ABX500 && ARCH_U8500 + depends on PINCTRL_ABX500 && (ARCH_U8500 || COMPILE_TEST) endif From patchwork Tue Apr 8 07:17:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042298 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F3C7C369A4 for ; Tue, 8 Apr 2025 07:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oinSzm+bMahZJYAUWu862y4MPTAeTqz9q0Fj/pnJpP0=; b=phwujWPvGT3B2XPmkKR3smBQw/ SEY/cv29H8HUK/8USTf4EYx/1+F979iUJOsgbZ25PMOS2pAXUKXPn6jBVnPcXi6CpVeNchIEWLm0O wA8vJFA+qlPPJTZt8P47QnvVYDgX12tfFIhpETB/CWjivpKCHtxq+PtDCw+p2jT/sbwSkmtvNKb+W c/Zr5ohXOPSxjBhXykq/uyajptedSRHq+rdPnsWEkMMoqrm+0EX4xaklosKKa58idg0gnhvrBl+8M IZ1GJRgOeCEG6C+o8JwBEiW1LFVlrTNN4x0V0iaNE+uT5lMTINHb5s78lkXQiSMbexA4alNGaje4+ zdYBpdBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23KS-000000033DK-1QtR; Tue, 08 Apr 2025 07:25:04 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23DY-000000031fU-1B3R for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 07:17:57 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3912fdddf8fso3973065f8f.1 for ; Tue, 08 Apr 2025 00:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096674; x=1744701474; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oinSzm+bMahZJYAUWu862y4MPTAeTqz9q0Fj/pnJpP0=; b=igWbW1iAw3FYGURemyDT7qynBLbtmjtoSINC03Nh+DjJGxvseSSf7NTW/c1fvdHdnJ ZTf02CsSqCooKZnR0JHE9UegJVmok/kAfXagFZNhQ9FV/7RO20a6jA78c2fCQ/6mXKVW BxyUagxlO/EQ8yIVHzjOyCCOOWRmZoapcd+P+/6/XxONphk9k2N1mByFWb+0pEL21QbT hjj4TAOUSPyUlp+QUxgABZRrM9TK6Jua+JgSTCdqJwGwS46D6v52NreJtI6T8op7k4Pi FHNreF4K51uwImA+fWwVsV//edGwqgOtVhDjGGhMyIqXWs70MhnwHOBdSgJ9K6OIoKhK OGCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096674; x=1744701474; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oinSzm+bMahZJYAUWu862y4MPTAeTqz9q0Fj/pnJpP0=; b=XcR7xgQ3+/5uEZMlaax+ca6cHjOaY9gjLOU2B8MIrO7FyVgoo56utwLcvfk4Jv7hgQ xVHWesJEa0Xv5cIytSlxjuye+jka1cS6cg++L4n7Qe29gTA8VL51MdH0KC2ie/yOqXtG Mggpnu3psVjP8tpT4xfg2dfRDJ5/C0K9rkx1h2KMkBjtMUD/10kmcr29LQqQ2cru3mUz kxruZFZprvoM0e3Fb95bstMkcc82SsdekW6Qhs/fDOzxBw7/lTa/r1mcLCoCmgl3Voll 0Va6sYMC03+c8ALHklkSsxBgtfzrz8OkDiAJ1o7pMVwb1FkgPcUmqzMVLG7lpLaeCgO2 VJgg== X-Gm-Message-State: AOJu0YxDHy8Xq+JTmxYP9CRki/XSPCLcEh59RKOozj0TUAaefURxn+l1 PVgOftyAlmwNUDcIRZez71EACsTOJUvf3Hb4qBveZebhpYKUd3JS0m/SzLayWOU= X-Gm-Gg: ASbGnctt06S+JpwN8jjv5HUTCdk+R07svYJ2YW6hmnesiNFuRujaUJZ2S0BjSL5bbie g6GK/fSKfPRFEoOe9rKEMX6Iqsi3v7Wku+z2+O0IjkbUNLsmEQL8+wqDZQzQcDggLgEsu3I5kwj uyyGxDWeOUQ6Ep/cIXn9rtr3VIxfhqcoyRHUFdwNPgD43h2b6zGQWBNwj+1E0rG5T964C/8w6Rq AvzVYjUDmHjiyh079jPfqRhT2y9F7FPacAHxCVdkjiRuT1SgOOop0pAvr+vJeNhyq1txBRVrRd0 UgtycDxoZk3LlKtjBdOdV81fyN8EYa103hQ47A== X-Google-Smtp-Source: AGHT+IHrjnllwruX19f7P/GJ6q4XihZ8rfCQK9jOXGEEswSMIiSKCV482ACd4hwI02zSsicA1Cwvhg== X-Received: by 2002:a05:6000:2289:b0:39c:30f7:a599 with SMTP id ffacd0b85a97d-39d820f7f4emr1793514f8f.18.1744096674126; Tue, 08 Apr 2025 00:17:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:53 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:41 +0200 Subject: [PATCH 04/10] pinctrl: abx500: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-4-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1591; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nW8gbeASZZPGvCfMjx4XcSCJQKXVyNGKry+o6wrAY6k=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2ZVzNUI3VgRQMzfUNu5ztBdbgFOzKCX2cTD gqJRJh5fnqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX ckcMD/9lHTxFJCt7mJF9tP1pyTVlOFcI4iTV1L1QK53z5FW2Z3SMIbsg/WP0Ox+KZTEQhQIH3rM wwqGzcFbxbursx8+r7+ZvVqkU4QZIBUyACF7u1pek1/n8JBWnexyzkfimQ/4dv84Mg8fblHxX6/ e9AxG0M296lr/4pAiXZ1OD25/6m9fmgaetnGniuV57A4pLBJe9hlfZ2YzB5mYUgkf1H//Jbwa+A 6XaU8J7I4WJxHP8tl6QsF4nWHGmtgm2fhT82RFptXXjqk4O4soM7AG+Ss+tjQK6UQz9anNLU6Lm rmqduN1o+po7YG+d9QycugTfQLY+ldfFNdSba874x5yFE0yN5u6hWFUlf7kqCSA9/ShGC3h1b1d P3SrzAAp/KzpaZ0qz4k3uHr8AWzjtoebNiQLf0np9Rhj6QlsXMPTjpRvO8qu6TwbjgMUVwXs+ML LAU2zu2R1fixy6aGTWSrsqOHHB7OOlUsUa2Gx4LvWVk5suCmM1xbfDPoByv89XnsFLphWZVxUvK aJGTZoxqeRJVCy+Hfx8X9v29LWuxTlLQC6oNMkvVpk9Pycf8fKsnjpKqnwNQ8Of16WN8gMmVTAb w4ONrOgUNVqfGiBiUJqcKD1U3JafBOwIdNX7SuEwqraaSC6bMhiSiynASp0nnYhkZEAuJMLEqV9 8aWIUWj5E3JEMig== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001756_316582_54F1C6E1 X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/nomadik/pinctrl-abx500.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/nomadik/pinctrl-abx500.c b/drivers/pinctrl/nomadik/pinctrl-abx500.c index 8cd4ba5cf0bd..2f55f83127cf 100644 --- a/drivers/pinctrl/nomadik/pinctrl-abx500.c +++ b/drivers/pinctrl/nomadik/pinctrl-abx500.c @@ -167,14 +167,10 @@ static int abx500_gpio_get(struct gpio_chip *chip, unsigned offset) return bit; } -static void abx500_gpio_set(struct gpio_chip *chip, unsigned offset, int val) +static int abx500_gpio_set(struct gpio_chip *chip, unsigned int offset, + int val) { - struct abx500_pinctrl *pct = gpiochip_get_data(chip); - int ret; - - ret = abx500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, val); - if (ret < 0) - dev_err(pct->dev, "%s write failed (%d)\n", __func__, ret); + return abx500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, val); } static int abx500_gpio_direction_output(struct gpio_chip *chip, @@ -540,7 +536,7 @@ static const struct gpio_chip abx500gpio_chip = { .direction_input = abx500_gpio_direction_input, .get = abx500_gpio_get, .direction_output = abx500_gpio_direction_output, - .set = abx500_gpio_set, + .set_rv = abx500_gpio_set, .to_irq = abx500_gpio_to_irq, .dbg_show = abx500_gpio_dbg_show, }; From patchwork Tue Apr 8 07:17:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042299 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40770C3600C for ; Tue, 8 Apr 2025 07:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WVFJWADW/y0RMccjVQrvsZvTL6Kql3Z12L3/megvx2A=; b=rFPzywwNw7yN/5PLEYzOnsjjnT CJFub1Dpk58T28MgXibDhMzCj0yC8EZxD61VR/VGB5z+zKtMAHSjrvawEN7sA6h7FkFI2o4fZ1OoT rg7OInjfrN5hYPaTrFyOvYkzTf2DACm1TBhWE4J97UhHVzPyU8rvdBqD42NoBY824fmD56qa7KhEr +Pj06/VVcYfEwGJsbs7d5Ou+Vyz0IX/18dDsbdwUDs9GPPtTKzQhCz3Me3Swtvr6FIHBfA2sCwkFx DRQZ5acAZDp+CZ2PURzL9NxYH6OaAH/q42sBdDP4GCxgcuzFHPsMKwUSZgxYh94+iL6HLsYKT2ius X7JbDl8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23MB-000000033Vi-07tU; Tue, 08 Apr 2025 07:26:51 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23DY-000000031g0-3wdq for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 07:17:58 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3914aba1ce4so4167521f8f.2 for ; Tue, 08 Apr 2025 00:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096675; x=1744701475; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WVFJWADW/y0RMccjVQrvsZvTL6Kql3Z12L3/megvx2A=; b=P5L+fkuIKBj1aFekzclEylg1x7sz6YuH6XFHbIFChe+DSxC8z4UzW/rzRp5gS/8RTi JHmRRhaQClGkP4CXe9TnNqVwfps1Jcw2npDuD9eep5AD+V10be3wzFrbr+E7z9joNHng nJuaxqLc01Mw3BhCfkIsUVwHW5J+ltckIwm8uRpbwQdf1+PYvR30uv76+VsmZY+6Y9X3 r4ieWkzMEu1gPC14zezDA9DwF8Z4H5hOTiT3jmTCjsKsiCQ8jJ3z+4A86OAmNcGszp1y ocKNmrbH7BlBqaIhcS9518r1op3e1VeTALX4E9iorwrYHrBfcrAGF1+YUrBjhsbXCT8l H5nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096675; x=1744701475; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WVFJWADW/y0RMccjVQrvsZvTL6Kql3Z12L3/megvx2A=; b=IAb8IvhgnqBYDKVJ9eB2uJu7lX1meftbqWoJl2c+4BAMhdOFZNOvnPVYJXYOAG0sp9 fi4Q/IMm/QQ/oImXH3r7nbyxDdEjgeZ1OaaZWoE6SOuquDWXyo4fyYJIw5p3WB05R+wY O+JrJq+Phsl4edqi8mUB9/ajgK+5vKfoqXcstJi0/cRSUpW+/pQFWQKyIhU7wOjnHJti eygLEKk0ELCr0bsYZrJggJz3fZ2PH4UE56+93rS2lFqVIGg3oF/L1/zK9p9gpkxPwkYQ yQ/UCT3slTzFtcuuK/cyWeXNbDDPwRFv+5FMQz22U62eEgUqhZqVuid+uR4yqa8gYSFt s8NQ== X-Gm-Message-State: AOJu0Yxl0mrgTvDsUp8PFXQuYKbwLPKLn1Osavwu8Cr5vAGvKln0xvFR gDOgs/Q6VJ7Jmq0BfSWjAJF4oIREQL2ZGN7mz9VnelAbLHvvlNFchMninzpLWGM= X-Gm-Gg: ASbGncus4eCv9kwm02AUpRc3oVS1s2wT9vK5320JacChE8fkk5TIIl58ggAgTal39kh zvxKgnfWZMCrbd72UIfWnMw/V490eZk9W8zs95KvpOvaykACumT3e+jGLOcB3nT+Gcyt2QCgtew er9YcJt6WEYxTPxYA4I0oKykDoUFa9J6QV9bkCTDvEsZPy1OsN2qudh17jDatmFFfqp5VJwOvjS 7gOwIJQBK0KE81noH+4PdNpfsLsgvsEx+Pv2SFEMP6Uv0b84KemF2GOy9CkyvCoeBdDIWn9qvS8 ZX6yUarkFge1LnLDbKc0uhCp4TdHzdc0v8zt8g== X-Google-Smtp-Source: AGHT+IGb12K5x3MyGax1/meWBHx/ceb2e/LqJgU9QQIZHIFbzKHDCky62yygJ2VTuSCj50YJyfE4bw== X-Received: by 2002:a05:6000:4313:b0:38f:2413:2622 with SMTP id ffacd0b85a97d-39d0de679d1mr13305391f8f.47.1744096675082; Tue, 08 Apr 2025 00:17:55 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:54 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:42 +0200 Subject: [PATCH 05/10] pinctrl: meson: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-5-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1477; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=S3igGGikbfII9kNPL0KKjqnS8YUnpBiOi6WZKLdujUk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2a21smivbrNX7hovJ5AmOVQjkGrJhwqOgTw 9GIegrUEM2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX ci67EADKEh90ymTKMGsCY74l9LHK8QIQ4v/81+Rc6Eqfw4wVjL+lPNaGTcSBP2utqyO2KrQMMFw Ud7MCMHcZm7kzMCKgZhr4Q5hxKegKb2tXZsgsyhV8YdIebBSZmZS3xjHm1FTslGntrxTtZfUcgD 9Ncx7bkinKF9GE+JhCUYTwm5rX/ImXZPua18/+263zoA9IcowGvpu+sHiPYBinPQTG/NzQUeczO GStvT8lo/PvFW5C2evtDAAac3WkpMH72Zd++nH3ZSzFjmh6wa+JuZj4++IaVtdQvf34/rVmBvxm 6lfHwsxcLCcvsiKLGQvJ0pyMUTgjTXWuCVx1yI4OFqh/vGStiEpFn/FM4m6cgY2+8721nFS0XSg skTUnIqE+icmuFIxh33ZNyBinNKoXfA262Dd1FT4UU/UGWwK/zVzRXebNxxuWVofBCrpGfvckJj 5An31hmmubXfJwwqfo1WCobGVNTYhODCiiFTT1nEEdIOgEF1ogNVoLg7ND2vY3mbvxs/m59mrBt Ghvcu71zj2ubCbOCger+FJ91d0OXgTTDx3l6RxskE+/H9YiT3YVPYtaxsW15NZ/wrgk3dpqh3Pb pxgF2SOpd2n46VLipFyjCU5PmDaB9KG2fyxu5yKFQym8Uk1AbdlkcgldvEzqzVK06tjwV4yQehq CrMwCr4lgCvIlLQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001756_990827_5F781F58 X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Neil Armstrong Reviewed-by: Martin Blumenstingl --- drivers/pinctrl/meson/pinctrl-meson.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c index 253a0cc57e39..e7485c82089c 100644 --- a/drivers/pinctrl/meson/pinctrl-meson.c +++ b/drivers/pinctrl/meson/pinctrl-meson.c @@ -580,9 +580,9 @@ static int meson_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, gpio, value); } -static void meson_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) +static int meson_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) { - meson_pinconf_set_drive(gpiochip_get_data(chip), gpio, value); + return meson_pinconf_set_drive(gpiochip_get_data(chip), gpio, value); } static int meson_gpio_get(struct gpio_chip *chip, unsigned gpio) @@ -616,7 +616,7 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc) pc->chip.direction_input = meson_gpio_direction_input; pc->chip.direction_output = meson_gpio_direction_output; pc->chip.get = meson_gpio_get; - pc->chip.set = meson_gpio_set; + pc->chip.set_rv = meson_gpio_set; pc->chip.base = -1; pc->chip.ngpio = pc->data->num_pins; pc->chip.can_sleep = false; From patchwork Tue Apr 8 07:17:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042362 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91A67C369A1 for ; Tue, 8 Apr 2025 07:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XOjNNeHzyY58LMv3k+FTJZV8HBjSzUrYs1slCEoFb4s=; b=IfLCnt7vnTScJ3fgPxXpeCDzM1 dyYNGBErNs6r+r5Yok25LxGJWa4D1E6i7kgiuXUPo6a5Csb5OJRvX0vOsFn1tv4HhS6KLQ0GXgaFf 4jf/UmldEbF5FS7KmrjeegW+5g1QmtZNJaCAEEB0vy+JFSFVJbIWIu3IlxwIIBXaNn6Ic4U2qZ6TQ CYLNvPAaB3sxYEiLH4bbFkgAQYy0P7TGzz+SG7DMcnslR6FIYzeeN4Aal1DEaYdfJhJeOj7s8vU9U 4LwLcHXf4OCTfn99xfc+4lagavjlqx1xuvFJ0+Deya6oRWpjbL4043WJCEDk0ELuOljxiobWfM+4o L+i4T1NA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23kW-000000039cT-3FKZ; Tue, 08 Apr 2025 07:52:00 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23cM-000000037wD-28Rt for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 07:43:40 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-ac2c663a3daso975176166b.2 for ; Tue, 08 Apr 2025 00:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744098213; x=1744703013; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XOjNNeHzyY58LMv3k+FTJZV8HBjSzUrYs1slCEoFb4s=; b=PwjtMKFBe9MUD55dKMUpJnt6LlkiU/QVh8FDUJaX47dTUiwToAuo6ycuS+c1Wvjrvc H/9NyEwspWBicAC4MaahHis0g7QwVIjvO4h59aSgd1QEzOegwVJu4PlnUbeoedGCxaPC JSgnvIpZkhorN3hXdVSOZdYyV/s8W3nUnFdcmxaxk0ovKLWZvEorYwFX3VWhYVSStLNh a+I5a2kA4Z9N/TtdVWWifuEshh2xCEB2CqgifLcxHT8zZWy0BzJTbytQmlf+woALHnsp ccFUqCUBvX25O5f3kYf448Twlx0AzjyQBRKBI63z9+SjLbysTa5chyvd+dztlG/n685E qDwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744098213; x=1744703013; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XOjNNeHzyY58LMv3k+FTJZV8HBjSzUrYs1slCEoFb4s=; b=UCVFbvU1vm2qj63eWUHVX4A61vVtunhtSyW6GRJlxkYitEhtKWPK6o00PD631jTezb dgGzsOJLgF3/UAb1bql4jsdVGvs/dpzUh5uyemsdD9BUxEwk3eqUi+IsYXKezs170++Z 1fzgfyzfMlb1pXbmmm60VOFeaoznwRzaUrKq5+bvV09dmG7JefcJMCZZmv7FVlCo0D91 KTp4RUVBB2aqPT2lGNXtVzoYDq3QG/RNCOdPkTblA3/Oj0ZY0KxXFC5u5AbFYPafW85P IBg5i+hMcFp+u8S5wMBhFksR0IL9NRH9kzdz7UbLLV01X2yjwXPpghaP9sp3F5leHAgg ggVg== X-Gm-Message-State: AOJu0Ywf47BTOeevW2jiZnc/i/h5d0r+ZBCNLTB4CYetD63FVIZ1NuCG 4D1ajf95fhC0Wm4bmsPZskYGHre/Sp3sFZzuYhIvO/P9b6Gu9jdNxKJK8ppWOkWCVj7XE8xBUox aOVc= X-Gm-Gg: ASbGncuJvZn0QH/vlF/sf7sqNww9YrocEwSM5X9b1z2QV8eaqAgEwVem6vsSGTuB2GO zrTIJTtFlIYbn63EuafrYJQEd29bq6Dshh+Qug/Cd2ocI0HbrABCMDrpd/FmiYx+NUNeFM2HAeA awD1WR00e648aMi6yvjly5TG1+JCmd407TWLWoN+h8WYf8jceOUSIBo0+FjeYxUO6I9UqnAfsil rATWbhi1JUkYQYUcfMrqpuiuq8R3goHwR/yh+pJ5pnNl4nEYsrAUuURK4j049fFu3TGQtMRkDwI sSmeitXCyfKgqfjHkiLwzcg/TPLlJwK57gq1rw== X-Google-Smtp-Source: AGHT+IGDlv/Wz2Tv0JI+8Hx2njCPUM9rczyDR5EAPHa4oqor0nd3oFYHO3dEgeKjIpQ3eleoyeURtg== X-Received: by 2002:a5d:59ae:0:b0:39c:27cc:7ba3 with SMTP id ffacd0b85a97d-39cb35aa8ecmr14702868f8f.33.1744096676320; Tue, 08 Apr 2025 00:17:56 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:55 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:43 +0200 Subject: [PATCH 06/10] pinctrl: amlogic-a4: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-6-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1680; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zFDAJ44H3rDElvqiaNPmVwvOeCsvopBV8K2+vzPv+N0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2aCcCPhwuF/Scl+dWhUvbWutpdgADlyzo6E dkwEIOpAkiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cnRjEACRE1eo2DpKjHGbPlQbMpv86tO6SMwS6frSIq+KfYxOaODnxG0vYoNPl1XeTMMPfKWxuKo MspJKWTkvUN0QuIxmjcZ8vBjIh2Ssf2biltkgH+3Ut1/ExIvxXr/M7gT0UOy2/r94+c7DkVzBEK MXr/4KXQXVZ4OSvLf588xywzpAYfsAPShtYaqDz9OdGk8uc9fPG5lzGH4ccc++V5cuv0ZlY9tD3 ZXnb+hLdVs0BvC1ESV29eq9xcIkTRj/KhdzH4WdJDJB4Fx4xRvCBxuTrv9+Hv2FE6VyVgnX8Knt wPQY7lA3cwjzj0sWtwauKnLeZ0x1DD6IMexNhfxrfvgGpEXh0w3i09yOn6vnAvTxetgrzUoiZsq 5210n+9CVXDRsBqfEUuqtBOx2/HJBwMibEOeyf/tK8wVBtbrEFq1ji769lP5H/PGJUFNT0bPXLd vnKVHrJiJUiyX0REr7gSm1AjTYXZb/jNq6PcBIY1JG8vYGaruh/7KsvN5PbWlmeIxn2DIKitoEB 5c3paQ4gObhMQ1lHal6NduGavNkTb99awzhp7MjrFLQ7vHEkk6LWPVdn1/obav1Qnh7bwi6/RYI rfIeivF5Tge1zaLyASFLrEOQUIffbwsDEofBTf4iFicbK3EDjEXXtUNKuD4DDgO+q2/1XPzUYDj IgJ4xDux3XMrr+w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_004334_543459_F6EA2B68 X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Martin Blumenstingl Reviewed-by: Xianwei Zhao --- drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c index ee7bbc72f9b3..a76f266b4b94 100644 --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c @@ -806,15 +806,15 @@ static int aml_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio, value ? BIT(bit) : 0); } -static void aml_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) +static int aml_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) { struct aml_gpio_bank *bank = gpiochip_get_data(chip); unsigned int bit, reg; aml_gpio_calc_reg_and_bit(bank, AML_REG_OUT, gpio, ®, &bit); - regmap_update_bits(bank->reg_gpio, reg, BIT(bit), - value ? BIT(bit) : 0); + return regmap_update_bits(bank->reg_gpio, reg, BIT(bit), + value ? BIT(bit) : 0); } static int aml_gpio_get(struct gpio_chip *chip, unsigned int gpio) @@ -832,7 +832,7 @@ static const struct gpio_chip aml_gpio_template = { .request = gpiochip_generic_request, .free = gpiochip_generic_free, .set_config = gpiochip_generic_config, - .set = aml_gpio_set, + .set_rv = aml_gpio_set, .get = aml_gpio_get, .direction_input = aml_gpio_direction_input, .direction_output = aml_gpio_direction_output, From patchwork Tue Apr 8 07:17:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042334 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52FA5C3600C for ; Tue, 8 Apr 2025 07:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o6prcSe997utkmrj2Wk6sqfMRushEUX5sURGCDCfQ/A=; b=MLjL9uUwMqDOh3T9wbONuILwyH EAW/P4b9NbEIhZEvXWPhmx/86OgG9+CZHrahD7ZnG26c5kfKvAZmeXBsYEpiziZERHtjDROLgs+D8 fHCa1UYSSpmjWX2gGDR50AK9hvvrGCddt/Smxw4goMK682bEqn8tGJbmEGg7Q14SEkdlvFC4eNNfl T3PvXq+s34uCz7ibPXB0iPc14KPqMrlWvtdnOAID2LsqAowgvGKb7dV6JoNOo5bEOyKAOaUjCkgjt sNh545RnRCD4QaD5e75k3ruMmJ9hEFhAaseNQe9A5sTJww2Io/oo45a9NM1oaBaoXdlRSAm8xz4Ny Lt21MFKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Us-000000035rf-2BFX; Tue, 08 Apr 2025 07:35:50 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23La-000000033Oy-3O0L for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 07:26:15 +0000 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-39ac56756f6so4430435f8f.2 for ; Tue, 08 Apr 2025 00:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097173; x=1744701973; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=o6prcSe997utkmrj2Wk6sqfMRushEUX5sURGCDCfQ/A=; b=QzMA/X896hVu8Xi59r8a1u/pNHYiFo8kT0UuJWZy8A1s7iW6Jqh34edMFfeFTybJo+ yQxPAiztjvyrL+Cq6amqP8Pk6IOEl9FCMCA5+89llGe1FZmE267M+DmTQ4L9wqlw9Gxu +/Hfkm8r+zMzPzE01k04rkY+kAkJSBo2ZavpdtFlN83EOyBJQpgCsV+RqQUmgGe/XmCB bdptzSQ5FBGenmgEJrNMwKu94hdadZQiuVDIWsjytmZRcJjKL7QTnL/+sS38Jo8C/883 dtDEMlUsVk5RwOD2oTDjopenHiR3s5hDFAkf0DVWcGdA/sqii1Kz1YsWIQbLxLAMY5bg pngw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097173; x=1744701973; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o6prcSe997utkmrj2Wk6sqfMRushEUX5sURGCDCfQ/A=; b=PAd6m69hk25D4cmryaaGJwnxKnAECIwY6OF3eUHt1bkX3yrRUiOD/t/XPciZ034nXR ermHeH5vvnpt7qhV3Bf8PtSf9KEn/qeiLViKiL/HFyKDExdk8SF4AyqV8Bbs1iAy7LFU M4cSIdROdL+8/rZKlAdAdDN9tEYPJ8iysfhGMryhqhVBeTIV9XW226h1LzN9KYoBXxy/ /54YCwDU35ZnoLtACjxWvIixIawQUODtCrvH0naRBQqKIf7x/rzM2ZFFdolzh8CvRfYO yhZeaMXf94SNJxytIvlW/taJ8XL+HP1pVHHuu6ViRcnQAFuAm+f3/N1q7fHSSrefSNyZ JANw== X-Gm-Message-State: AOJu0YyP+h4XKXjOCq5tm287uwdATtqkQWW1YSLm2D3SFotFzwOeMWSf LgJoLP5tA2ZWqalztUE/L0DznaakdzpcCSTACd4i4H8Rg/Rq7qNoQD7lKu7XALFruV5Icq6aJrv 0R+U= X-Gm-Gg: ASbGncuHb4+wlZVdBPhMAZFxwKLiQDfkh+03UF7NwKzFfNvpIfkjv1mvH4vKrIwjh5Y lgYytpDbiw/kY3Ho/Ob+e0nHycFcasweVz3A5IDVRxUnY0mbUtiNstx3OA5i7qveEEku0dFjAtB 0qU9NoyNFsn+auayw8XRuD2axmzKHY8N0hkgHcHoTWzDy5H+1FM8yRN/n6AyqDCGVNpzyovMawm YBxPTvAm8031OAFW4P9f7aFOECAufRgdn/Xs2xUjvzmeYykTU2ZMp7ZzfkhokfZovcPJ050gJPa UHjNrjzeOX+/gzBzJxv4Ljj0HOg6WnzLvdpEHQ== X-Google-Smtp-Source: AGHT+IHzySH+p8lRsbpEKp8XdjRw3BmN8WdHjMLgCKHMXaLLom4rGv3xsF4growXW8khurtrZ60whA== X-Received: by 2002:a05:6000:1846:b0:390:eb6f:46bf with SMTP id ffacd0b85a97d-39cb36b298fmr15212511f8f.5.1744096677281; Tue, 08 Apr 2025 00:17:57 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:57 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:44 +0200 Subject: [PATCH 07/10] pinctrl: sx150x: enable building modules with COMPILE_TEST=y MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-7-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=667; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=YmzRn8TzGA6hsDQ4Ls1ViAlvgo7b9jMn9Wlo//Y9vfE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2a3aI8tyRJWFB0j50+lYKjuGbu/ifeaeFQ/ 4M0t4m17MyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cnJ4EACh4EPB2PiBQrpFxrQpn3I5/hHOewyCLs6D3bGW26OisrbJ6BrXg5SN88KZnurmvDHsuP3 MvwP+6leXhNTitXtnj5TQxtJin6NVZ0Al8MJyd9xwa21k8YTlRMm7rgA4Vx9CNvjDV9gf5XOdBF o3JYv1QhJr/SgcdkDr5Ox/diUgdt5Z+bjO2zMLW0i90TN8XxW/blNaWT5xnj070aBbwHIva6E+l v1y1VlHp/I4MrpZmV4MtqxBFHCOAQZEOd+itR+n/S8LP50+qens7NAVqfZhfaQQ7KSmLbRKJpm5 kiG1CDXKTkVqJunSULnVtRahqu1J6ZcmwDJeXTo5PtKQZiFIlUHRjOs60Av24wdhwd+FY4ptQOp pU+EYeQcKSLcEMkga3AqSlN+IrU5XJAo9Y4FLczzGc6/9kTe7Y/MLq04J3fmVsp5KDuJR98aytJ 6m/1/sJrIyiE38hKgq9Ta2I/s9/NjynRehGmP87FTcRsCV1bnl97G4/o6CZtPg/knk7WmCFCogS WBIkWDQrNxAYw16mjSeY+350vXO3jYh+7OIbRVqdjqYiZKSAy9A2h4HULcXVra+fEX2z6ALsNmI gsWEWEJpEXYy62lnL9J9OTf1+ihsnQZFt0jOnnge9cZzyJTQW7bhCj2GDkVkcgK5wezSQQbuork C6IVZWbEkEfQnFg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_002614_839066_8E3BCA08 X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski Increase the build coverage by enabling the sx150x modules with COMPILE_TEST=y. Signed-off-by: Bartosz Golaszewski Reviewed-by: Neil Armstrong --- drivers/pinctrl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 464cc9aca157..94eb41bb9cf2 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -541,7 +541,7 @@ config PINCTRL_STMFX config PINCTRL_SX150X bool "Semtech SX150x I2C GPIO expander pinctrl driver" - depends on I2C=y + depends on I2C=y || COMPILE_TEST select PINMUX select PINCONF select GENERIC_PINCONF From patchwork Tue Apr 8 07:17:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042310 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FAEDC3600C for ; Tue, 8 Apr 2025 07:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XD5pUwvjF21WHvNYwLGg3m0Hf3jMmd7qTIORgnVtv+o=; b=ImgZdwhurdRfVu9IOinYFzuUwi Qj+TKM21loXqjuiMIO4vg9/9diCz8FifMP+Pc+HZ6epYHyqh2kUFqsZ3jjiNIw+YOf1KuQJ32pwSa G+P3ucCXdMQNMp9hvQwG6eMpu+1L+xlYbRyaSYkE9nVdP32tQ+S+VU9XWWAktJ120jUXg9Ikg17Mq W3cuUMi890DOZWlActE024RF4c/ElQBHA6aB0OGKe/ecKBBb4tTOe6ndb/ghIvQHVW10gKaT7wMXK 1rfDRUSo+iRrx1cBf7QS+RD4+5RLCgRhVVTrnJcGZ0ClJHz0bkcdDwmJy3ZaNdcs8DCTSIEyqbVg7 JYamYNFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Nv-0000000340I-0coE; Tue, 08 Apr 2025 07:28:39 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Dh-000000031jS-2VVP for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 07:18:06 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-39141ffa9fcso5662106f8f.0 for ; Tue, 08 Apr 2025 00:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096684; x=1744701484; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XD5pUwvjF21WHvNYwLGg3m0Hf3jMmd7qTIORgnVtv+o=; b=BJXueTru7PlYa08crIeV9MmrHoZCNguzOIDzvgioHh/XV0GQVdbqOun1iqJqXm6Irp +jJ8I0uBiTzU7l0NDQp32Fg4/D+q2ZJ5EjRUxtZJQTQ2bQNwzXg4JoXtTLXN47DKCHeL i8cDh+7U1l4xaYIGo0QAnrKG+Px6W1AR28z3Oa5ZnXWS6fisjPl8ieTIsJbsXll0AOvx t0uzvtFiAY3yDPxFlsfLv1mzy//93P77uLAjVXoUOaNrR0xpO7y9gT644Zlg1cQWrsGt 3t88nKVe8cYDEz9OWn/kncd5E5W/GWrwgu167qZedRjAd44pque1Ho+WhXuxEM3ptzMj t4NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096684; x=1744701484; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XD5pUwvjF21WHvNYwLGg3m0Hf3jMmd7qTIORgnVtv+o=; b=brn5cypMHuDU4zjcjgsx+YpfCy8m+VW5ZSb0VSMCMo0wyUUg22FZlDMDHE0mThcd0/ IqYBeABN8o1RY/f6gVZEqnmVakADJLtOW4taXhEW2eBduCcS+Wh/lLBJyaffoaSUsDNS +gmxkftkgUHk+vFxl4uOL6i0uKnhqHT3ldjAmIGeBaIYkT13eerDwSKR5WJaMgi4Yz7C m/Lcoj2sFJ12KnPTU4nfYQALFrkBqxrsPLFOLN7i5lNQ420gfMTKlR9R+NR4aelx2gYa UbJ0XqHC8+KSQYjzkLnnYnsCrqlEwWroOlNn9jg+0HU7chXfcOpArCat0yaKVTqs3JiZ XDDQ== X-Gm-Message-State: AOJu0YzNCWb3RhTr5/gi/hv1omZhMelXu7d/Otp0XrbIwOpYjRCrZQUU 1fsdJ16h0dvjkK+tpmxYxRtooRcqX1oW4yYpo4cWUMK7XkqxLesL0shOWWYHZq8= X-Gm-Gg: ASbGncs8xmPAI4g/B7FMP+pCYjILvxuDpvuftxCsfOjdvn57tmmJKXUdG3ENf/1+68E a4RCIFuuIR5cbVh9kF2gGTrsbGUGIvHMuyUGDtTqtN8ctlxmd22ytTcpm0QfQJU6V63yLFQPJ6a DxMvsBDDDwYAx19DT0UhNIekTfbbPVUlkCOZ06ndv72uSxnnl6b3ornFShm+yo8fjDOt6RM0Jgk lpx5WthzIMIjDhnwacsIMcFND78eJ1uWJzxsGZayXS/jnUcgw23Cg/Nr/G+2qiECHM0vT4FJcLr rm0e/95H3UfyjNdGIGKsfv8a14CaNVlsHzJdinWMgrY2w5nm X-Google-Smtp-Source: AGHT+IFABP+0NyYfjrmBkKOY8Qu8GHG07RX08meqZeJWYd12gU6oEH77JekbQo0tofcJZaJ2znOR0A== X-Received: by 2002:a5d:64cb:0:b0:38f:4d20:4a17 with SMTP id ffacd0b85a97d-39d6fc48b9fmr10149766f8f.13.1744096683833; Tue, 08 Apr 2025 00:18:03 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:18:03 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:45 +0200 Subject: [PATCH 08/10] pinctrl: sx150x: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-8-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2534; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nW90rn+BHn4CcA4KM6329dEBeQrDE0H95eIQ6kXIjjg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2anp9vmc2BpNT/BOe9JwVC3uov6dAPDjgly g/s/D9FRDaJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cjUhEACQA8gdiny3H0cIs/eCXCdyJOM9rKhuf2+4gj2/MdJ4pjxMDZN3V2spjwTYGEBIvnaD2aw 8YI4+5YrJ/gacqwT5jdjBrv5M86+lRF5x86+aNRAFzrvKT1fp2ZQOSVCdFg5c/pDmPEU8HMJu85 eZM4/n8/sw0vlUHZ6wC5A3oX5Sbxxq0ODdGC1dCdre8Msr4AIZF9Rud/U0l/y22pDHy5AKDsEBJ 45mZjH1OmDd53+rAicyRRakUYgVM4hjGDmZuiAYrNQATMYnENj+DH367L8luvpChW7o8fHoDRZ8 SOKri5vWh0/qd01aZY1waCCyH/8jjdOf3v663xcAX+vBZg0z11mfZY544nqEXoIPun+NYhC9goA +elwZSvzY6TjL5X3SaNFiWSrcNSGObk3otEPfb1/Rys5r5iJNEucwjKiGjKDVc0/WJC9BLewaBE yHyUqES98sh2Ku2o6e40CjdKDsXHwa4Nu4U873+GjpDrypUhlpb83ax2OzzkXuHv4mvLvUQu9lx Op0AGrK6iBc7LT0wuW6I63145+LILkjBnDCErF8JdK9Kjq1HYTLQvslx8onmZ3l8ge9yrQfWCGV i29GbD3Msfrbsdl06ZuAND29xiKUyTaL39tudfMlz6CPR/ii5YZmxVuFSe0vVWBkc3Pxb7B/FM8 aL2+h9Qb3cin5zQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001805_658142_92D10070 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Neil Armstrong --- drivers/pinctrl/pinctrl-sx150x.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c index 98262b8ce43a..d3a12c1c0de2 100644 --- a/drivers/pinctrl/pinctrl-sx150x.c +++ b/drivers/pinctrl/pinctrl-sx150x.c @@ -432,24 +432,25 @@ static int sx150x_gpio_oscio_set(struct sx150x_pinctrl *pctl, (value ? 0x1f : 0x10)); } -static void sx150x_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int sx150x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct sx150x_pinctrl *pctl = gpiochip_get_data(chip); if (sx150x_pin_is_oscio(pctl, offset)) - sx150x_gpio_oscio_set(pctl, value); - else - __sx150x_gpio_set(pctl, offset, value); + return sx150x_gpio_oscio_set(pctl, value); + + return __sx150x_gpio_set(pctl, offset, value); } -static void sx150x_gpio_set_multiple(struct gpio_chip *chip, - unsigned long *mask, - unsigned long *bits) +static int sx150x_gpio_set_multiple(struct gpio_chip *chip, + unsigned long *mask, + unsigned long *bits) { struct sx150x_pinctrl *pctl = gpiochip_get_data(chip); - regmap_write_bits(pctl->regmap, pctl->data->reg_data, *mask, *bits); + return regmap_write_bits(pctl->regmap, pctl->data->reg_data, *mask, + *bits); } static int sx150x_gpio_direction_input(struct gpio_chip *chip, @@ -1175,7 +1176,7 @@ static int sx150x_probe(struct i2c_client *client) pctl->gpio.direction_input = sx150x_gpio_direction_input; pctl->gpio.direction_output = sx150x_gpio_direction_output; pctl->gpio.get = sx150x_gpio_get; - pctl->gpio.set = sx150x_gpio_set; + pctl->gpio.set_rv = sx150x_gpio_set; pctl->gpio.set_config = gpiochip_generic_config; pctl->gpio.parent = dev; pctl->gpio.can_sleep = true; @@ -1190,7 +1191,7 @@ static int sx150x_probe(struct i2c_client *client) * would require locking that is not in place at this time. */ if (pctl->data->model != SX150X_789) - pctl->gpio.set_multiple = sx150x_gpio_set_multiple; + pctl->gpio.set_multiple_rv = sx150x_gpio_set_multiple; /* Add Interrupt support if an irq is specified */ if (client->irq > 0) { From patchwork Tue Apr 8 07:17:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042311 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D604C3600C for ; Tue, 8 Apr 2025 07:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5HVOt+4srGnvQwsP1v9+2VHPQ1xwkV/AAlcGkzlseiw=; b=OQdt6YgOYgEBrrQxsj5EyF/dWD /SYtQbGKavOom+S/TUBtPbqIMlXyjD1OVJOxOq34lgO+rb0w3mc01A7fapjxKd8Az10hKuqZ7ZJ/L 2onEH2HenQ73QLrPEElk3Pz6MKIOR+N4K/zWWzlT3iYPcVwpg1Trrw3o7TGwCgzWqOO+YPN4KNPBT 6fj/eZPI+S9Tt1G6tOrUZUUAGnubF3ysH/fX/dD4RQE1sTDXz1G53c4j+dSo42Idc6Ps6A5W0Xfsk tbrrkjGAdUsBR7vM+ZO05TVFS1K+uNwIYCok806mQjeiGvUpfcVmdnq/FmXm/swirHazYn/s2ZRPY L3ZaTlgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Pf-000000034Q7-0amf; Tue, 08 Apr 2025 07:30:27 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Di-000000031k6-3Iqs for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 07:18:07 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43ede096d73so20959865e9.2 for ; Tue, 08 Apr 2025 00:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096685; x=1744701485; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5HVOt+4srGnvQwsP1v9+2VHPQ1xwkV/AAlcGkzlseiw=; b=TA9Oxg/CfmO1mA2TeThTBq/VCGMTMAk7uFwafrweSYmEdc+OgglsI6GoMMKm6pA6Sg mcCqKwAe5e//ZK5tCVk/JuKJPSt1Dvb8Bz9dYWx/aG0EezQJovhaARLTst0qLFa35xpO Tcx/82bIKwkrJa+amuaueflhdRJOLoM7VeZFoDvSAXHy3xl98A+yUjLK9ABp0/omC72R +/jue3Tm+Ai7oM07FN4eJ30hzO8TX/EXSXRKEH5GVqrOe9//mKkq82zoRkp8tHb4qIaN a/wtyIB6QQ2wut9O+F9sFbDupwd5x050VQYRgCd87Ry9/Y42ycktYOXCwuugcGj+wSbB NmGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096685; x=1744701485; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5HVOt+4srGnvQwsP1v9+2VHPQ1xwkV/AAlcGkzlseiw=; b=FpZWNC++ioHiWYr8M9LPX9UEL0DMgu2JaRE/at5y+BmB1KRkDtTW08jvu78i11b3ZM oKCixueBP/994wZ42pQLYzTc2r/pzOMG/OfKXAHVwr5j+whclOIqmN0vE4jlF1lrd/3Y BLdf5Ondf6BRaFff6Tp/C1o9NFZhrSUd3guHHG+eArOLEs+atKxtFOGAsOncBU8mqGv1 qoSGISvLQKUjszmucax+iXB45kCqAcp/jvMIx8VeZnZc1+ciFIyKj2FfiCEn3IL+IMtv dnpMCZMyA5G1vtxN0/l/4tXscrxdQH5S2ab+VzzBJLoAwrntWnK1/k50EoBARcyw8xS4 XKqQ== X-Gm-Message-State: AOJu0Yzb6z+Gbv9KEe9F2EHCpOsInBbLapCxtJzcc+eaLRndVxvlzB96 2oRbrzELGNkrmMAxyO/BZNFyk6LkE3EwHot1RV6VupuluoFw5sZWUPJmPfiFBbE= X-Gm-Gg: ASbGncvfMgolk8NIisa0kgAODJdpRs6blCJlsOFqqCrRowBhMSqHAYDuTv7P0xXLoWy Q6fWLKsN69UpHgb1lywaBYpttFDbhRJcUpIsaQSuflzupM62WohGzTwFzqB+Pvz0pw85jLKrlma qNCJF1B3BDGcN0KqFnQypbV2vJTxM8O/56/RDRCs6yk3bNG1QFruSXwT4OufnJLj0pBoj+wv7yk z5dHAa5PJ9DS1MetrvnWwfJS0cR9hOtQ+orxUaWLvtFJ9zqsCi3mLJ3Swj0twMxEMUrhOFf0Ydw fYH8q3fkIH5ZkhSgv4z0+UlBDSvJn0mzqS88ew== X-Google-Smtp-Source: AGHT+IGSySduYIODYDDBNhKW+V8JxaftIxx0mbfbLM56e4WvjRuBEIilNZOQDJkJo2kY1AIOFFw1zA== X-Received: by 2002:a05:600c:1d28:b0:43d:7de:16e3 with SMTP id 5b1f17b1804b1-43ed0d9d18emr123594385e9.24.1744096684912; Tue, 08 Apr 2025 00:18:04 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:18:04 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:46 +0200 Subject: [PATCH 09/10] pinctrl: ocelot: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-9-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1855; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=spvpQCaMJt/FlIsnba8JPp3MhbofiKGgIiv9FJg4rZg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2agt3O6aR1vCS8hOqHTDKX4aiCLJ+nYrJpF NCIW4f85ciJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cij6EADKyrhyl0qDS61cTLux6MOWrF0i8ovx0ZQmpwIhr0Bg5B+CblqHxvZat19Nu7Z/KQuhoxa 5a4ZjXS8zPhwsmNHcJL8XmmCO7AuZyzbIw/dJAygTYI6OrSzueQYkwP5vZpAyxet7FuT1YH5JCw AKvK5JuGVvzXt/1+S0QhyqRa1DBk/r9qW/PGztC+Q+1JIP2r7feH6HlncUVIUwcUmAtz47d1GKU d9WdVpTnCDHkoQOSX43tLjkyf+bWEUz35UYdBYvlfQ691lbhiEgyJZo8cU56ecomEvyTazRrZel IPsNTSh1TYRxmQ/gG/yks6vYRor8W09Gaw0FrsS6r5ifS5/BdkYI0/W5gX6I54YDaQYReRflW6G e96ttMnq/Z8KuMsKIUEteJbJMqomGgb5fJ9q5gEIw3QafPDTn9G5b99Jco4HVa6RwDPA5/LAXmY ttBiDSb/t7dTmdHdHxNHdzkYKzwk2MxkH34FBOX0/wo+7HoCuAeePRR1D72+DhbDm40qtzwPhIW Tkd+O16r6I0zfcX4kMUD7znBhtCMNTTSCyKjzQofWO3wqRQmC/lxZU+m+9WjsnCobS2jV6bTGb/ 6HE1y+gTQLWisUWQCGbsYviBPph9oEM1aA7O3zarkvGGcMtGx5/W0bKBdZ2nCh/us7+xv45Qh88 jH2gOpx/XG01JmA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001806_835468_11B4BC67 X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-ocelot.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c index 329d54b11529..fbb3d43746bb 100644 --- a/drivers/pinctrl/pinctrl-ocelot.c +++ b/drivers/pinctrl/pinctrl-ocelot.c @@ -1950,17 +1950,18 @@ static int ocelot_gpio_get(struct gpio_chip *chip, unsigned int offset) return !!(val & BIT(offset % 32)); } -static void ocelot_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int ocelot_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct ocelot_pinctrl *info = gpiochip_get_data(chip); if (value) - regmap_write(info->map, REG(OCELOT_GPIO_OUT_SET, info, offset), - BIT(offset % 32)); - else - regmap_write(info->map, REG(OCELOT_GPIO_OUT_CLR, info, offset), - BIT(offset % 32)); + return regmap_write(info->map, + REG(OCELOT_GPIO_OUT_SET, info, offset), + BIT(offset % 32)); + + return regmap_write(info->map, REG(OCELOT_GPIO_OUT_CLR, info, offset), + BIT(offset % 32)); } static int ocelot_gpio_get_direction(struct gpio_chip *chip, @@ -1996,7 +1997,7 @@ static int ocelot_gpio_direction_output(struct gpio_chip *chip, static const struct gpio_chip ocelot_gpiolib_chip = { .request = gpiochip_generic_request, .free = gpiochip_generic_free, - .set = ocelot_gpio_set, + .set_rv = ocelot_gpio_set, .get = ocelot_gpio_get, .get_direction = ocelot_gpio_get_direction, .direction_input = pinctrl_gpio_direction_input, From patchwork Tue Apr 8 07:17:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042312 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1133CC3600C for ; Tue, 8 Apr 2025 07:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lsLjcRrGKuzDX9mvNJ2l1Pj3maW/MPJjpEEItwHgjBM=; b=uBTkJ8Fdw+07WPT7p5vQbR+Knh XNN6PVJQKEboKWOwCUN1Z5p70NILhIULup5fU/64GB+w33KXngzgOm8HBJ1LtOYiQhBw05CFT3wTi W9awG0cPdG0L0UFMTvkNnILhtAjaypTqTc+YKLgMISD6CQeVIUQALe+wbiIhVjiO8Hl5oDuEea/2r /IAP4duZxkd76U1RQPmYbyaMUtpx4JrgZlbcSGt2cAuL9tdRF3aCxZbXowIRYQgLOHT87c2bx8kIr +I9L98nytPKe6B47GPp6W9T6twIlOBcj8sytO33KbI+IclH0peNcEMdEVRht2LxivTtEJLcLtv6S9 ApR0+a/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23RO-000000034i9-0dFj; Tue, 08 Apr 2025 07:32:14 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Dj-000000031kV-1ijY for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 07:18:08 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-39c14016868so4586611f8f.1 for ; Tue, 08 Apr 2025 00:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096686; x=1744701486; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lsLjcRrGKuzDX9mvNJ2l1Pj3maW/MPJjpEEItwHgjBM=; b=dWBO1n+wU7VZglteaBDB7xffD1nLM3rsQdruTrGN0iRkuiV9oc/TUSCBygc5FSVyV+ p3jLuD4f+JM0L7nrvuWltFYv9cepzzDlnkOLl/fMrENnaRwQZ+LorqaGFGT0V6D3HsjD 1HJmNxsNMd7fY+qo5QVpfOUudyRT/qWLHviUcnrU5FU0lJ0ocfw/6QBs0/DlvCjesszm yPe8i5j5cvbOf6x6EVNNKUKDHujwE0gyZftSJhb/bFzWUDJ8u9gmzz4MM5xiaCpQT77V xC14orCqb8nlNSOE6ZSX7d3LsJuoGmVmG6tZhs9cGsr5leot995BbU2+Gkv/sZXE2NeL 5EEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096686; x=1744701486; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lsLjcRrGKuzDX9mvNJ2l1Pj3maW/MPJjpEEItwHgjBM=; b=aSnmYGqUHXN7ZrjQIGKmYotDKGalCsr4gu9G6ampltdTAhRduNOKUQ5j3a87qH/89b fcW73I6ohvc2jjja/iNCWWK3//RsHjtQdTG+vO2CP89rA5uaXtYOVWsS4RDjMPCOWT66 EfIpzngBLg4ViEzGrbEz9K+Qx49YGfXP7HVTvMK8CUsULplFu4WjFI088VXwX/YlsOSj NYROcwANZ6hL+OAHdjCgjiCtgHag5Qg+l7IJG1pez6Sj3C4MdkX55Umf7O51MKTarhyz DJfYI2SKwfusIObCZ5QjolHmfxRMLIb1j8+1ZA+1pb2F+Pqs5RnxS1JRmAyXzXuaTH+b Aa+A== X-Gm-Message-State: AOJu0YwKG7ZI1eWSfFsLMuIgiTVY7YJYq/KUGxsKBcjkdP4JOSPTRWh7 2dohyLP8vKpbPFavz10Hd0VuIuLaSRfanLmQxgKuco6CvGNV1cFBeeKubFDq8zo= X-Gm-Gg: ASbGncsyLFXxynF33537onX0iyY0a1E2rB38TMxnBrzguIeFN+PmIw5rkGrP09G+H8A M6s+iZmLSIUuHqZY34ERvPjJRxg4UYpXLDWQd6jI86WGmOkq3haDWTDJuJv3or0xm2tDywBVE+d rVlcCAukb/LqXALiLPGdZQ4epCL49fvvGUqu4D5WgIHequuieqaAGE9xdcFli4NG5fFepAnWvB4 D26O+sDHpDxMErYyyZc8hsQn46lgq5HHXyfBbLJ3D7L/J1stM1HrptPeSB7lbHJieMuJfO+LJ7h 3SEYUGEe14FB/2Gyrw5c8CWWE+Xt0fdcAsPSNg== X-Google-Smtp-Source: AGHT+IFVLY1WNvAayiNBB006bFO4nSra7Yx4DcKw1yaLoj6yk4wJfEbc8yNlS2Lbk6qsNo9ohgkRog== X-Received: by 2002:a05:6000:40cc:b0:39c:142a:ed6c with SMTP id ffacd0b85a97d-39d0de66a15mr12602862f8f.40.1744096686025; Tue, 08 Apr 2025 00:18:06 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:18:05 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:47 +0200 Subject: [PATCH 10/10] pinctrl: cy8c95x0: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-10-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2609; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nFz0ZQu1wB25C83nAY0bNQ02w+UniTfC+j0g7wZb9Vw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2b7PYpEd1QYwzkZOLJp94uziWDLFCT9+cRZ 6jtV1w9v+CJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmwAKCRARpy6gFHHX cphiEAC83D/t8tFMiLHRxWuKzVZS6TAwB9yfLq3bsdR9gOgBqJaavIsx28w0liHuZZIj8w3UHJ3 te5PhEz/S5S7Osm2h1k+wsZovOT4+g7Tn/BqJ04NbpBDccfDwNlRHz9dp5oTqhX/I9BxlNdAM6j nw2qiHcJBTD+wKKdTworBCco10+UdxKyIVJZ1xIEUUha9S7j83VF0X/lo/D6JFLOPf7hVAxpMUg UAs4h9Zmbh+zfoE3OX3QPGFNlwtL/UHFHuKx8uHYrmKv0tOmFEJL2FpJ1Dpt21Ue0har4mN7d+z XYTh2aZ5lZBpTRONkVjKs17D58wvSoBeJSXBp60u0KOD5isuDZxUWicE89i2IY9+jkffOPFNBBj hwVA2QcAYCAUMMtWb4BzW4sg02wn+SwW/2TRCl5aUXcF7n+rRnYBTlfmliRX2kHJ3PA3532UUS4 0qF0kn7hDbX9yY7oX/aD3N97/Eyh9HrOfWH13ZdvF5Hh+MT56nrovr0kjLQFazEgd8IYV8CEPDg ZoCCrIrePRmAOUTYwyZAb/qrH/mEh2qLVE5EAVKijNbE+LV0QR4DWDglwYmR6LbjrmcfnyoOS3U 1/73A3TxYyCRipzULEk7VLJXFMw5u8ROVTWk+4s4XCehemi1NJRDj9ORfPUJMTW0b8refz8JnQW hv7fa/dGOTU4VTg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001807_487252_F07B4163 X-CRM114-Status: GOOD ( 11.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-cy8c95x0.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c index 3cfbcaee9e65..8a2fd632bdd4 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -742,14 +742,15 @@ static int cy8c95x0_gpio_get_value(struct gpio_chip *gc, unsigned int off) return reg_val ? 1 : 0; } -static void cy8c95x0_gpio_set_value(struct gpio_chip *gc, unsigned int off, - int val) +static int cy8c95x0_gpio_set_value(struct gpio_chip *gc, unsigned int off, + int val) { struct cy8c95x0_pinctrl *chip = gpiochip_get_data(gc); u8 port = cypress_get_port(chip, off); u8 bit = cypress_get_pin_mask(chip, off); - cy8c95x0_regmap_write_bits(chip, CY8C95X0_OUTPUT, port, bit, val ? bit : 0); + return cy8c95x0_regmap_write_bits(chip, CY8C95X0_OUTPUT, port, bit, + val ? bit : 0); } static int cy8c95x0_gpio_get_direction(struct gpio_chip *gc, unsigned int off) @@ -908,12 +909,12 @@ static int cy8c95x0_gpio_get_multiple(struct gpio_chip *gc, return cy8c95x0_read_regs_mask(chip, CY8C95X0_INPUT, bits, mask); } -static void cy8c95x0_gpio_set_multiple(struct gpio_chip *gc, - unsigned long *mask, unsigned long *bits) +static int cy8c95x0_gpio_set_multiple(struct gpio_chip *gc, + unsigned long *mask, unsigned long *bits) { struct cy8c95x0_pinctrl *chip = gpiochip_get_data(gc); - cy8c95x0_write_regs_mask(chip, CY8C95X0_OUTPUT, bits, mask); + return cy8c95x0_write_regs_mask(chip, CY8C95X0_OUTPUT, bits, mask); } static int cy8c95x0_add_pin_ranges(struct gpio_chip *gc) @@ -938,10 +939,10 @@ static int cy8c95x0_setup_gpiochip(struct cy8c95x0_pinctrl *chip) gc->direction_input = cy8c95x0_gpio_direction_input; gc->direction_output = cy8c95x0_gpio_direction_output; gc->get = cy8c95x0_gpio_get_value; - gc->set = cy8c95x0_gpio_set_value; + gc->set_rv = cy8c95x0_gpio_set_value; gc->get_direction = cy8c95x0_gpio_get_direction; gc->get_multiple = cy8c95x0_gpio_get_multiple; - gc->set_multiple = cy8c95x0_gpio_set_multiple; + gc->set_multiple_rv = cy8c95x0_gpio_set_multiple; gc->set_config = gpiochip_generic_config; gc->can_sleep = true; gc->add_pin_ranges = cy8c95x0_add_pin_ranges;