From patchwork Wed Apr 9 20:37:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14045633 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11839C36002 for ; Wed, 9 Apr 2025 21:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RLmgb19AbWrd/UJeKJUHWxq/eTD9hl5bKw4d7syAvGk=; b=f+Ab2jbmWKkkE8vPN4aim3bDhj Q3H7e1iHwko5yUw/+qODb44jTH+6rWRQZkY4XVnnaY3F6fo7U8Wrs2mCjF5/dQOgCH0mGWKDMYQSv qABceHZNBOyQmtirsMDiDY4tswY1nHhDiOxQ+I2q557mfmHt5+xmGuIeGN9t9mtY9inTmn/q9zojs vD/IjEKYkOcqLNxUHt0dT4Kk7GzFGhu9AQWW+EG5+3A7HeI0lcojClAhyVsIc6CyTa4zP07XHJU2r guhjR+a4PAJn9f4N2R2rK69T6AMHMgELdqKk8zndMI+Pz1nMZ9ivot7rC8FrZh0OiMiBauXiNIFs7 PVv4FUvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2dQm-00000008el1-1ZAd; Wed, 09 Apr 2025 21:58:00 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cAv-00000008SZo-0ehI for linux-arm-kernel@lists.infradead.org; Wed, 09 Apr 2025 20:37:34 +0000 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-ac2ab99e16eso26349766b.0 for ; Wed, 09 Apr 2025 13:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744231051; x=1744835851; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RLmgb19AbWrd/UJeKJUHWxq/eTD9hl5bKw4d7syAvGk=; b=ZanQmqFXMpKtPottX9mrE31umlTqppUvc9xKfGN2mIvZ7f91iUmMHLSc/0Sra2rpxK eCkN/uq/H7+BZQJukXcmUsZpyfm2uKrjHEFEzeHGoXA4tHJDWq7KNDhUsR56Vl6Xh3xT XlqQ+1UODlyj8Ru5utLbuJ6NIukGY4842cJDkpm9kPCfSCSiqaJJcDERaksM+Punre04 vPWawGIfqY1MQiKSLk/K2dXW8wDzAxC9nM37YvQf8dmBfDEfteeBItqF28sI0JDtGa1u V0Kj5Ad4T2R2T63EXAhCG1YVTPfwOMIM3kfrnQxRTVD9tbn7lbIU0Y5jXHM5GI3twDu8 ufbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744231051; x=1744835851; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RLmgb19AbWrd/UJeKJUHWxq/eTD9hl5bKw4d7syAvGk=; b=vxnBbUCEQenfHsHbMeqLxw2H62Ays6nKgBTDNMWpjAVCkSuUq7ui+diK4xwj1q2AoU hYy2OdCH23UmDkpjZuLYDNpTtSot/gAFjt9l1zFYgmaGHwrnKed9eoaiJnN0yb4gCOzB /wu9c/F8twbSKrsfFxMaV5sJR91C30Tcq5iJGI9EicpFkwMD9GEquyjLKtckxNmH2lwa x7irQCxQKmDXHR15Ykg1VDi1KFC9q0IGO0bh3IXSXtsfkos8gbGWXuK5ayWa9ZboxvwN odc1930oBK7uDme56SqHEJk4XN+fJLTGNWUtjX35zj65uhQG6/DFjgWI6CvYxxXXQm+D ffbg== X-Forwarded-Encrypted: i=1; AJvYcCWjkThKRI2ri6V0PRdTktBX1dio8Za6le13tXLteqisQ2RGfTD0gQPeGTuF+nhvxMCiu9SU/5Hcg8xWJ+6Tm6Y2@lists.infradead.org X-Gm-Message-State: AOJu0YyHL9w9q0A/iK8WLLVYlP743ne5sdOcF/T6/uIJMppZmlkO4OaS BFCKozspozDbhLu5e8mzZMDn+vqtr3xdvMtN8tnCmTHqqhqczvr6Wb5DWQt8GYs= X-Gm-Gg: ASbGncvGyFGF7+J5iCKTkccwPHp0siXzbt9gFgb1+icVde+h7vMB1sz42wSYL2gaihR lPFUFF+yNJpgzOvVHZh02/KxBgK5zE83HpRLn9K56xkrBjdlgibujdV/WKYYKaBOHpXnzz2rjsA 4Bbe88oiCHh0HhuDuz2CEw95qSKLctOL3YhE7Ix9DFO64Jsic2rEunIhunaC50V070EXsijkEcd d8lguEWWNAYkEf8xK7bDXOrQCp121sv2l6jNJp1TeKkxbuDIdusJwXhrzYr104AasLLZKz99022 j5KFMqEGajvGoF3MQFw4gzl9KCvdMXv/7RUhMKIlG0tCc1Lq1EZbi3ay4anoNEYStNmCNgJ1ueq dmVDFb0S3DCOMGZo5ignd4wbsiHjf/v0RQkrTAQ== X-Google-Smtp-Source: AGHT+IH0zvKNuRDAGqLs83RwWCcDR6aym1X5YrwLki7lH6aKqe66Jq6ZWK7rMjqREavabKtC1MlIlw== X-Received: by 2002:a17:907:3d87:b0:ac3:c59a:413e with SMTP id a640c23a62f3a-acabd4dc96dmr8505266b.55.1744231051490; Wed, 09 Apr 2025 13:37:31 -0700 (PDT) Received: from puffmais.c.googlers.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 13:37:31 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 09 Apr 2025 21:37:25 +0100 Subject: [PATCH v4 04/32] mfd: sec-core: Drop non-existing forward declarations MIME-Version: 1.0 Message-Id: <20250409-s2mpg10-v4-4-d66d5f39b6bf@linaro.org> References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_133733_199221_55F89404 X-CRM114-Status: GOOD ( 10.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org sec_irq_resume() was removed in commit 6445b84abf91 ("mfd: Add s2mps11 irq driver") and sec_irq_exit() in commit 3dc6f4aaafbe ("mfd: sec: Use devm_mfd_add_devices and devm_regmap_add_irq_chip") while the prototypes were left. They should be removed. Do so. Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- include/linux/mfd/samsung/core.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/core.h index f35314458fd22e43fa13034439406bea17a155c9..b7008b50392ab857751b89e0a05d2c27f6306906 100644 --- a/include/linux/mfd/samsung/core.h +++ b/include/linux/mfd/samsung/core.h @@ -72,8 +72,6 @@ struct sec_pmic_dev { }; int sec_irq_init(struct sec_pmic_dev *sec_pmic); -void sec_irq_exit(struct sec_pmic_dev *sec_pmic); -int sec_irq_resume(struct sec_pmic_dev *sec_pmic); struct sec_platform_data { struct sec_regulator_data *regulators; From patchwork Wed Apr 9 20:37:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14045513 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8F61C36002 for ; Wed, 9 Apr 2025 21:25:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Yvl4l0Ok5PkRG0EWi21Y82ldA8DtM3z/BsTax0kidDk=; b=a4VQ7Otps4bZYqqoobqgfdLV7I gVG24I4MYU5ajveSVnbIEq08jayJw/VU3L2MhsZxwit//jOH+V2zp/T569X84VKVnX4tKGTuPw/0f poqh25TOAZ/fW7wJzRYu68aBmBSzzWkB+Ql2SQKyX+mV83X0xKWIi2wgsVdppFvAP9umE4ef5RJqD Jf8MGnJv9vKitTGKnzs+sEQjTZdfxdKA/q98kaUlzK8OFyT513fANY7p4nR9cQKzQd9kQSOk7+Wzi 6SuEfsUsJhzQxBWjAmEYeTjvMUHx81+P3rOVtcup6IpMqyyvOwTzn03EVoG52jsh/OAcwPiGtzJ7c C4ImQ2qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cvY-00000008Zv2-0HHJ; Wed, 09 Apr 2025 21:25:44 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cB6-00000008ShW-0JUg for linux-arm-kernel@lists.infradead.org; Wed, 09 Apr 2025 20:37:45 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5e5e8274a74so178516a12.1 for ; Wed, 09 Apr 2025 13:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744231062; x=1744835862; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Yvl4l0Ok5PkRG0EWi21Y82ldA8DtM3z/BsTax0kidDk=; b=J0CMYV0hc0yw/R0j1IxiGbKXoZjV4zf38lArHrFVB6bDFuQ+V8lP9iQRmq1g7RgR4/ I7G/m4h5l7azJsZ1e/u8UVjupG1buyC7P1GPM5zNti7bG0viL2r2YYyXKzYo81wahSWh qHP+dMg09T188Xdpl9/NkeWMcJyqwSW3LjjK6BI7QaHdtRkI91Jut3uE6hRp5EMUgUiq cuwN2vQz0onDb30b0TyNz1S6PgTg46u2wYEDmLMQv2gTXI2yb/s9aBwDo8FxT8zA4yPb xyTHgIrvLqvNY5z0Bp8RjQzehBQQk54Oc6fUKl29QjhQIqc120uBAj/XeZSRmXuzg5xX 9i2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744231062; x=1744835862; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yvl4l0Ok5PkRG0EWi21Y82ldA8DtM3z/BsTax0kidDk=; b=mvE0CIRovSvIPZgTxmXNxFRnkJVFQgCMxbjwtDlARYrXeRsKoIKwNAPG/jMfqTy2nG pzy5mQY5cCdt69kl+K2vnUWVGbm7eYo4SHj7lHQynPBeuMd6egMCANKX9HW+vS7PX7j4 wLZB4oR+DW73IrWwvssK776VUHLaeoW3E79S3kR4Ev7hKW21l20HKnTFgTHH/2qSkoTV zzUCHQclrr79Eoa7JKAKEl0pKve3290tB4CYTf9SFbMmQS8G4y0ty4H3SA4u3ARVcoCs rUaotDgDQ9SH/AFMVwKYOZl45D32KERZlh7vX/c08fpBxm4k5kf0geN9BnAC8AnXATPG ykXA== X-Forwarded-Encrypted: i=1; AJvYcCXM1ff722fan+IDpW477hljK+1M5GY2L05a29Xoaz8/qhgCqqB8Xnlp3lkpP/VKqnVkUh+XRwdArGRV2Dp9Pkch@lists.infradead.org X-Gm-Message-State: AOJu0YxoA/f+SPu3XuWTUwyDKFYjhXsUo4Yv+LL5Y9XutwnlL+wOR9/7 W6WYDKNZwGwSaXtP++bgBMt947hmyEJ7k1Akz5dUJHcITaWemKolt8+GhNSR4nk= X-Gm-Gg: ASbGncsvsXC5qPu5l1v6xQvomidYVj1uG2316kH7c9BZeVwL0NO9hQBSTesJH4hSnPi 4+iuomM5tSesJn1WkKgJQ+B4485iCjRbb8SyafGg/sCI5/g9lJoZ9EuONLuXCUTggIV5whCimoo PhVPwWjpq3HoxaGqlBYT1+lWlxDX+T1L2IeripsMo34l9lXwYAepbAE/YnD4pS4oYi9eUq7hESE xzro6RrKacxc1yTInRrGLz0mMWkLd6Oif6Hb4GDRrXJ/ujXslS9kN0ha9YbSfOCbnE5eHFrbmi0 8hiYEeo/oC2E8bhgcbhUKwipYuZFk7Dqwv9aUv9RY9y8q9kt15faTCCLdZXRu7uNvC4P0V8TMnT pJw8fLUqI7ElOETs9+vWpH6yqRD0= X-Google-Smtp-Source: AGHT+IHbuLfVklw/YEV595LIDXkT6NJfGZ8tsFxVvFej7hgAnnMJK0l8IFDXzmywh/fHAbSmWr9RuQ== X-Received: by 2002:a17:906:dc89:b0:aaf:103a:e6e3 with SMTP id a640c23a62f3a-acabd3c36a7mr7622566b.43.1744231062434; Wed, 09 Apr 2025 13:37:42 -0700 (PDT) Received: from puffmais.c.googlers.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 13:37:42 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 09 Apr 2025 21:37:46 +0100 Subject: [PATCH v4 25/32] rtc: s5m: cache device type during probe MIME-Version: 1.0 Message-Id: <20250409-s2mpg10-v4-25-d66d5f39b6bf@linaro.org> References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_133744_111375_E6E99155 X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_device_id() is called mulitple times during probe to retrieve the device type. This makes the code harder to read than necessary. Just get the type once, which also trims the lengths of the lines involved. Signed-off-by: André Draszik --- v4: - cache the driver data, i.e. the enum type (Krzysztof) --- drivers/rtc/rtc-s5m.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index db5c9b641277213aa1371776c63e2eda3f223465..c7636738b797b8087a0ed6844df62d47427e33b8 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -637,6 +637,8 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) static int s5m_rtc_probe(struct platform_device *pdev) { struct sec_pmic_dev *s5m87xx = dev_get_drvdata(pdev->dev.parent); + enum sec_device_type device_type = + platform_get_device_id(pdev)->driver_data; struct s5m_rtc_info *info; struct i2c_client *i2c; const struct regmap_config *regmap_cfg; @@ -646,7 +648,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) if (!info) return -ENOMEM; - switch (platform_get_device_id(pdev)->driver_data) { + switch (device_type) { case S2MPS15X: regmap_cfg = &s2mps14_rtc_regmap_config; info->regs = &s2mps15_rtc_regs; @@ -669,8 +671,8 @@ static int s5m_rtc_probe(struct platform_device *pdev) break; default: return dev_err_probe(&pdev->dev, -ENODEV, - "Device type %lu is not supported by RTC driver\n", - platform_get_device_id(pdev)->driver_data); + "Device type %d is not supported by RTC driver\n", + device_type); } i2c = devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, @@ -686,7 +688,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) info->dev = &pdev->dev; info->s5m87xx = s5m87xx; - info->device_type = platform_get_device_id(pdev)->driver_data; + info->device_type = device_type; if (s5m87xx->irq_data) { info->irq = regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); From patchwork Wed Apr 9 20:37:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14045514 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37FA7C36002 for ; Wed, 9 Apr 2025 21:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=10AZOLwAO1V0GSmGNS0bnbti04nTAWbZ/3NrDOuj7Tg=; b=yrmnQYvIBIZq3tDazOmIwd9S8w QZH7BzeiyVJxueJKnTM60Q/R2Djdr36Fy7HmIKSMxesVXa+iEjiWpGPgVuuJpEbO6PvuClH7ak39x FzV926H35LojA+o0/Wep3u5OHDjCJ2kbZvSmSbvkVVH4EHq9dtDfRpQS8aRjAfHSwJXfzIIuz8FT/ 5yhcxF9n3JMroVMhg0JgszFRSu6eYuRMLXaEhvaouMnsTshKTAZmU2loipwsoZoe/fYTZ+uQ4taBT iAqCNWmXtoM9JcQdBaKRkSr5WV83ERUjwdsA1pmUrKSXNAs92jOSiTFj89nr98nozngPtFdABM9Lq uKx4CDvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cxI-00000008aEf-3Z1x; Wed, 09 Apr 2025 21:27:32 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cB6-00000008Shr-1Esx for linux-arm-kernel@lists.infradead.org; Wed, 09 Apr 2025 20:37:45 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-aaecf50578eso19326066b.2 for ; Wed, 09 Apr 2025 13:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744231063; x=1744835863; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=10AZOLwAO1V0GSmGNS0bnbti04nTAWbZ/3NrDOuj7Tg=; b=vuRK/UDx/vfk7AEH8KnmIOjyWOxJVO11HmBUmIexF0rqoVB12dra9NjgjiDd0MRIq8 n6Qv5SK1H/hwkpv6c8i/jA/VBo7n+lbXfgKTQ6CLlCO+VLly3VrLzKnP0aKbrR2UdwF1 wEcqh8TvjqaLsGxJmDlotpJuuDK2mq2D/v3g6gQvZrtkSFVfd3UCphl2FpYNjpDIKyf7 LauvWtLrUqFA3a+mZcXaZ6JU7j0WvyI1Fqu6/xXJcotUYryGkQpvIITaJ7CqitWrl43Y sszdR1QcUC/MfBqf5YfhZc3UZQM8U/xq0RDeUGi4N8PI/w6QGSHLJ8YQC/Gsbtru7PUn oK7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744231063; x=1744835863; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=10AZOLwAO1V0GSmGNS0bnbti04nTAWbZ/3NrDOuj7Tg=; b=n+LqS2fp19XkqXvSDp0iE/JRe531J+7P/SiofjuAAhtcONcCXubxBJ2HrS99XX6pgQ dx9T6i7V1S+J0THRPCiHnfZ2ZD7UdAQMh8liGzzjOkNkXgrVETC73rX7Rr7NXy3d4Y8m ysAWne+IQ9c1yywJyp4r8Nqe+nAmJ3kcm2FGyrg4A1/HOerIrOasbGIyM40cRChtHRQn dLCQ7cL6tl5/ZkKAwj3V3Odm50o1v8P1eudU3xuk6V+W9ULZm6RMAxw7Dxqh2Sr1y5G3 tK5ghMAuXaNfcljpWIQCXYY3GpZQTkDZqImTlsCMOSti2mCQfyOMdJh7VsudghWgdkYB Fhzg== X-Forwarded-Encrypted: i=1; AJvYcCXRADXLwGCg4Nb3L8AUcZVT7CP2pN1WVOAnT7Ma5tAjFiLO8JL85Qrqkz/b3eZPMUZKvVstgGXb+AD+3gRKvhag@lists.infradead.org X-Gm-Message-State: AOJu0YwhYOq5x04aQNB4JS/y6svA4i9B8mXs5hXBzSvQ1iAWMu4UxY4v TJxJLtjKWZx9ZXk/NY1FU0CgONGA7sqHPiEpLtZrRwOzSpb9ULessHjXwC00rU0= X-Gm-Gg: ASbGncufVKqBHomFN3u8vVU6N08CylcPaIR7f/EgXC5wBbax/fEbrtudwboM0ErP+rg 9i1+teWEgmkmq2AmwkAxHN1f9QKbf7Gr0STtCndNE0DzfpPES1zNtSdclHkEOU/jzuqXMwQOaPv 98TH1+MkuYuSqUR8LsqZPE3aCPXz/S/qKOd4x3nyP/e31LAbdFRwRDyFRiWf2kEraKNafaMzbH4 5tNAtRgJxbxoDzGNYrc/Aw+Jy3YgopD9dY4yulSzaBGOU3vOaf70C8/sn4kZHCTNw3Mm3x1dDuR BM7mdsgN5gaAH7/kcuvFGXIdL6xWvlWeyKxbUI+JlFl9R4beFofcmmiYBVOMkWkT9DuD7kwbmNB oy7rtVyMEd5U/23EV1H/8ive+MVc= X-Google-Smtp-Source: AGHT+IFUTssASe24CO9TPtl71HAttAgy9US9arxRXimezJ/dltcAvjXzhwFcY2meWd733DjD83/qUg== X-Received: by 2002:a17:907:980a:b0:abf:6ec7:65e9 with SMTP id a640c23a62f3a-acabd3ac9bemr9253366b.43.1744231062911; Wed, 09 Apr 2025 13:37:42 -0700 (PDT) Received: from puffmais.c.googlers.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 13:37:42 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 09 Apr 2025 21:37:47 +0100 Subject: [PATCH v4 26/32] rtc: s5m: prepare for external regmap MIME-Version: 1.0 Message-Id: <20250409-s2mpg10-v4-26-d66d5f39b6bf@linaro.org> References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_133744_345196_9BAAA1D6 X-CRM114-Status: GOOD ( 16.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Samsung S2MPG10 PMIC is not connected via I2C as this driver assumes, hence this driver's current approach of creating an I2C-based regmap doesn't work for it, and this driver should use the regmap provided by the parent (core) driver instead for that PMIC. To prepare this driver for s2mpg support, restructure the code to only create a regmap if one isn't provided by the parent. No functional changes, since the parent doesn't provide a regmap for any of the PMICs currently supported by this driver. Having this change separate will simply make the addition of S2MPG10 support more self-contained, without additional restructuring. Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- drivers/rtc/rtc-s5m.c | 81 ++++++++++++++++++++++++++++----------------------- 1 file changed, 45 insertions(+), 36 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index c7636738b797b8087a0ed6844df62d47427e33b8..f8abcdee8611d1181fb575aeb8d094360538ca7e 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -640,52 +640,61 @@ static int s5m_rtc_probe(struct platform_device *pdev) enum sec_device_type device_type = platform_get_device_id(pdev)->driver_data; struct s5m_rtc_info *info; - struct i2c_client *i2c; - const struct regmap_config *regmap_cfg; int ret, alarm_irq; info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); if (!info) return -ENOMEM; - switch (device_type) { - case S2MPS15X: - regmap_cfg = &s2mps14_rtc_regmap_config; - info->regs = &s2mps15_rtc_regs; - alarm_irq = S2MPS14_IRQ_RTCA0; - break; - case S2MPS14X: - regmap_cfg = &s2mps14_rtc_regmap_config; - info->regs = &s2mps14_rtc_regs; - alarm_irq = S2MPS14_IRQ_RTCA0; - break; - case S2MPS13X: - regmap_cfg = &s2mps14_rtc_regmap_config; - info->regs = &s2mps13_rtc_regs; - alarm_irq = S2MPS14_IRQ_RTCA0; - break; - case S5M8767X: - regmap_cfg = &s5m_rtc_regmap_config; - info->regs = &s5m_rtc_regs; - alarm_irq = S5M8767_IRQ_RTCA1; - break; - default: + info->regmap = dev_get_regmap(pdev->dev.parent, "rtc"); + if (!info->regmap) { + const struct regmap_config *regmap_cfg; + struct i2c_client *i2c; + + switch (device_type) { + case S2MPS15X: + regmap_cfg = &s2mps14_rtc_regmap_config; + info->regs = &s2mps15_rtc_regs; + alarm_irq = S2MPS14_IRQ_RTCA0; + break; + case S2MPS14X: + regmap_cfg = &s2mps14_rtc_regmap_config; + info->regs = &s2mps14_rtc_regs; + alarm_irq = S2MPS14_IRQ_RTCA0; + break; + case S2MPS13X: + regmap_cfg = &s2mps14_rtc_regmap_config; + info->regs = &s2mps13_rtc_regs; + alarm_irq = S2MPS14_IRQ_RTCA0; + break; + case S5M8767X: + regmap_cfg = &s5m_rtc_regmap_config; + info->regs = &s5m_rtc_regs; + alarm_irq = S5M8767_IRQ_RTCA1; + break; + default: + return dev_err_probe(&pdev->dev, -ENODEV, + "Unsupported device type %d\n", + device_type); + } + + i2c = devm_i2c_new_dummy_device(&pdev->dev, + s5m87xx->i2c->adapter, + RTC_I2C_ADDR); + if (IS_ERR(i2c)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c), + "Failed to allocate I2C\n"); + + info->regmap = devm_regmap_init_i2c(i2c, regmap_cfg); + if (IS_ERR(info->regmap)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->regmap), + "Failed to allocate regmap\n"); + } else { return dev_err_probe(&pdev->dev, -ENODEV, - "Device type %d is not supported by RTC driver\n", + "Unsupported device type %d\n", device_type); } - i2c = devm_i2c_new_dummy_device(&pdev->dev, s5m87xx->i2c->adapter, - RTC_I2C_ADDR); - if (IS_ERR(i2c)) - return dev_err_probe(&pdev->dev, PTR_ERR(i2c), - "Failed to allocate I2C for RTC\n"); - - info->regmap = devm_regmap_init_i2c(i2c, regmap_cfg); - if (IS_ERR(info->regmap)) - return dev_err_probe(&pdev->dev, PTR_ERR(info->regmap), - "Failed to allocate RTC register map\n"); - info->dev = &pdev->dev; info->s5m87xx = s5m87xx; info->device_type = device_type; From patchwork Wed Apr 9 20:37:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14045515 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8222C36002 for ; Wed, 9 Apr 2025 21:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Tv6T8/JtNiPh/U9srmK1zriSPC7xSek3blAJnMyaQM0=; b=ZRQp/8XdTg2rF9z6lD0PJ/IzJo 4kdRScflZpsyQA5X3ry6ifCFculE/oQxr5FTGrW2bxPrpHG8K1XZULycFoeTTYDhm+PskBZrsURNi LzrOkGvHrKWO0+fNeBtwasf6OJsVkKS+eXYHzuGDH6q/PcNEYdPlmA93LMso1pS+2GrpK/Ncenhsa zhtR9aaFAlXDERDlYuhb+uFjsIRjcHC7n1Ix2FEeicYnQhj5TP+QoL8yo7Ifxc9UtiG9Zhd3nPCVy Q9I6ndxN2ZAJxSpBudiJYIDoDeVRAlMAej6ciSlsbxbh9bLr+L34PFsLcMHN0I5Qnp+dOCJs1fHdS jZqGezCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cz2-00000008acN-2HXC; Wed, 09 Apr 2025 21:29:20 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cB7-00000008Si4-0fR6 for linux-arm-kernel@lists.infradead.org; Wed, 09 Apr 2025 20:37:46 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5e6f4b3ebe5so222422a12.0 for ; Wed, 09 Apr 2025 13:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744231063; x=1744835863; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Tv6T8/JtNiPh/U9srmK1zriSPC7xSek3blAJnMyaQM0=; b=Uz/kj77pD2LB4kqzllnjyLnaAFtxqpjrky/6x7jCSLQwV7lfbfPcKxcUi+hSuLtAxB tncFZP1Vg8k8dNR5gPojuzE1aRfUBf6nvGqbMZHUTXm646W7SoF9kQ03uehB0b4x3qJJ 1QawVSKOl1zTwfQIgcX1lqPFonnOtx/V+Xy9VGwYOaJIqao3FeV3qe6UytVZJ7wx0Jx9 qq2kVb95JTOlDjSQaEJc7XeC4opYj+3Er8A5Pj7Uooc7hPj6N4zH0bMzSfWH9n3Q0RNb RgvEtGM5i9Gx3gxIhicNcXuRjNyyKbeGfZlUy9l04OaIL8uApkn0pDtF06dXDBw67gz0 fS5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744231063; x=1744835863; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tv6T8/JtNiPh/U9srmK1zriSPC7xSek3blAJnMyaQM0=; b=piTMlxdcRQ1+Hcn4c82jqPnpHMaTHvMRECv9bxKUaich/Yo68XtXaeJg7ceLYjMXlu v+t70/ou8ecTBQbFOgaYeP8hOFRQaX+HIx0F4aOUHzP6RjukauuM/++vJ5H0sZXcW3uT YMYdPKB/kvvnXkpp1rMq4BxiSMhwH0btKhsBz8JSEQn+hWJPgb/NTOXEy+SEtDPzNR5q +noSrGylGluRQfzWMVelpURM8TPoAU3IxAWJYmyY/WJb1Za0X+1955X9Nlj6gyNlyUJY SkBeHphlNOAIJlQ1H+tqiK6TVNY0QvGEYLS7QgJC7YqO6aA1B+YT6SpJIi6mPQo355n+ THRw== X-Forwarded-Encrypted: i=1; AJvYcCUBnW/88UW6O989X33Z+bMW+Tmcktsp59ErPN7KD1mKx4xQqwywFud7yvnnShJYK/7nybGvjZ80XGmM4gWvH716@lists.infradead.org X-Gm-Message-State: AOJu0YytOJ0EbI0+szz8ksiw+bjJmzV2okxn2gFQdLJt4UgsiHL3H+34 mc55YYqFZEr1bxlt7eZAhKvt2lNoIKRLb9YEIBTZhXrdg8RwrP7t6Gp/pzzyFdc= X-Gm-Gg: ASbGncvPbFTjrkS9R1XISn7hxzpfZVmTDYawG4ivxXHtoEm6NVgzE7ePdm8BUdLSnlo OQD6TtlCo54/slPPd5y6+kAVSLsMfaxItIAQfOyUPZp/xidc4tB09lFvZZDYds2iDIHHRTrUkWJ NCOQo3oK2dXDxu1GfW74VFuV/OrycGCW4geqWL7LU8Zyg611ZLDwmLXqjfk65EaqGPvZt8tuYy7 DqOL5v7y+akY6fVcWlp5pLQj19Jqk4FYGU1s6XKPqorKfWlGNFcayDBLQ8k2a5jqqFqOEfxMlbG 8UCRMB3c+Mx4Y1IbUo1og+Be6x42wuW9X+1gHC2G8RCnGsgQ/xG7HhSwZWPIwU+KSIURNkASqGd z8ViI6i0Ph+ujqTsrfqwkwUAKCuNPEd0nT9usbg== X-Google-Smtp-Source: AGHT+IHuFxbIJJjU+odGQEb+Z2z7HvoeRr2IGwkfZgpVlPcf92trUW7rJVrEbL1uMQYZ7TzU/wGXvA== X-Received: by 2002:a17:907:608d:b0:ac3:8895:2776 with SMTP id a640c23a62f3a-acabd12c4b4mr7347566b.5.1744231063463; Wed, 09 Apr 2025 13:37:43 -0700 (PDT) Received: from puffmais.c.googlers.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 13:37:43 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 09 Apr 2025 21:37:48 +0100 Subject: [PATCH v4 27/32] rtc: s5m: add support for S2MPG10 RTC MIME-Version: 1.0 Message-Id: <20250409-s2mpg10-v4-27-d66d5f39b6bf@linaro.org> References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_133745_201302_FF47ACD7 X-CRM114-Status: GOOD ( 20.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add support for Samsung's S2MPG10 PMIC RTC, which is similar to the existing PMIC RTCs supported by this driver. S2MPG10 doesn't use I2C, so we expect the core driver to have created a regmap for us. Additionally, it can be used for doing a cold-reset. If requested to do so (via DT), S2MPG10 is programmed with a watchdog configuration that will perform a full power cycle upon watchdog expiry. Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- v4: - keep headers as alphabetical as possible (Krzysztof) --- drivers/rtc/rtc-s5m.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index f8abcdee8611d1181fb575aeb8d094360538ca7e..c6394faaee860427e8b84e9c6df2d8229cf06d93 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -53,6 +54,7 @@ enum { * Device | Write time | Read time | Write alarm * ================================================= * S5M8767 | UDR + TIME | | UDR + * S2MPG10 | WUDR | RUDR | AUDR * S2MPS11/14 | WUDR | RUDR | WUDR + RUDR * S2MPS13 | WUDR | RUDR | WUDR + AUDR * S2MPS15 | WUDR | RUDR | AUDR @@ -99,6 +101,20 @@ static const struct s5m_rtc_reg_config s5m_rtc_regs = { .write_alarm_udr_mask = S5M_RTC_UDR_MASK, }; +/* Register map for S2MPG10 */ +static const struct s5m_rtc_reg_config s2mpg10_rtc_regs = { + .regs_count = 7, + .time = S2MPG10_RTC_SEC, + .ctrl = S2MPG10_RTC_CTRL, + .alarm0 = S2MPG10_RTC_A0SEC, + .alarm1 = S2MPG10_RTC_A1SEC, + .udr_update = S2MPG10_RTC_UPDATE, + .autoclear_udr_mask = S2MPS15_RTC_WUDR_MASK | S2MPS15_RTC_AUDR_MASK, + .read_time_udr_mask = S2MPS_RTC_RUDR_MASK, + .write_time_udr_mask = S2MPS15_RTC_WUDR_MASK, + .write_alarm_udr_mask = S2MPS15_RTC_AUDR_MASK, +}; + /* Register map for S2MPS13 */ static const struct s5m_rtc_reg_config s2mps13_rtc_regs = { .regs_count = 7, @@ -238,6 +254,7 @@ static int s5m_check_peding_alarm_interrupt(struct s5m_rtc_info *info, ret = regmap_read(info->regmap, S5M_RTC_STATUS, &val); val &= S5M_ALARM0_STATUS; break; + case S2MPG10: case S2MPS15X: case S2MPS14X: case S2MPS13X: @@ -300,6 +317,7 @@ static int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) case S5M8767X: data &= ~S5M_RTC_TIME_EN_MASK; break; + case S2MPG10: case S2MPS15X: case S2MPS14X: case S2MPS13X: @@ -351,6 +369,7 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm) switch (info->device_type) { case S5M8767X: + case S2MPG10: case S2MPS15X: case S2MPS14X: case S2MPS13X: @@ -374,6 +393,7 @@ static int s5m_rtc_set_time(struct device *dev, struct rtc_time *tm) switch (info->device_type) { case S5M8767X: + case S2MPG10: case S2MPS15X: case S2MPS14X: case S2MPS13X: @@ -411,6 +431,7 @@ static int s5m_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) switch (info->device_type) { case S5M8767X: + case S2MPG10: case S2MPS15X: case S2MPS14X: case S2MPS13X: @@ -449,6 +470,7 @@ static int s5m_rtc_stop_alarm(struct s5m_rtc_info *info) switch (info->device_type) { case S5M8767X: + case S2MPG10: case S2MPS15X: case S2MPS14X: case S2MPS13X: @@ -487,6 +509,7 @@ static int s5m_rtc_start_alarm(struct s5m_rtc_info *info) switch (info->device_type) { case S5M8767X: + case S2MPG10: case S2MPS15X: case S2MPS14X: case S2MPS13X: @@ -524,6 +547,7 @@ static int s5m_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) switch (info->device_type) { case S5M8767X: + case S2MPG10: case S2MPS15X: case S2MPS14X: case S2MPS13X: @@ -604,6 +628,7 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) ret = regmap_raw_write(info->regmap, S5M_ALARM0_CONF, data, 2); break; + case S2MPG10: case S2MPS15X: case S2MPS14X: case S2MPS13X: @@ -634,6 +659,25 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) return ret; } +static int s5m_rtc_restart_s2mpg10(struct sys_off_data *data) +{ + struct s5m_rtc_info *info = data->cb_data; + int ret; + + if (data->mode != REBOOT_COLD && data->mode != REBOOT_HARD) + return NOTIFY_DONE; + + /* + * Arm watchdog with maximum timeout (2 seconds), and perform full reset + * on expiry. + */ + ret = regmap_set_bits(info->regmap, S2MPG10_RTC_WTSR, + (S2MPG10_WTSR_COLDTIMER | S2MPG10_WTSR_COLDRST + | S2MPG10_WTSR_WTSRT | S2MPG10_WTSR_WTSR_EN)); + + return ret ? NOTIFY_BAD : NOTIFY_DONE; +} + static int s5m_rtc_probe(struct platform_device *pdev) { struct sec_pmic_dev *s5m87xx = dev_get_drvdata(pdev->dev.parent); @@ -689,6 +733,9 @@ static int s5m_rtc_probe(struct platform_device *pdev) if (IS_ERR(info->regmap)) return dev_err_probe(&pdev->dev, PTR_ERR(info->regmap), "Failed to allocate regmap\n"); + } else if (device_type == S2MPG10) { + info->regs = &s2mpg10_rtc_regs; + alarm_irq = S2MPG10_IRQ_RTCA0; } else { return dev_err_probe(&pdev->dev, -ENODEV, "Unsupported device type %d\n", @@ -735,6 +782,18 @@ static int s5m_rtc_probe(struct platform_device *pdev) device_init_wakeup(&pdev->dev, true); } + if (of_device_is_system_power_controller(pdev->dev.parent->of_node) && + info->device_type == S2MPG10) { + ret = devm_register_sys_off_handler(&pdev->dev, + SYS_OFF_MODE_RESTART, + SYS_OFF_PRIO_HIGH + 1, + s5m_rtc_restart_s2mpg10, + info); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "Failed to register restart handler\n"); + } + return devm_rtc_register_device(info->rtc_dev); } @@ -766,6 +825,7 @@ static SIMPLE_DEV_PM_OPS(s5m_rtc_pm_ops, s5m_rtc_suspend, s5m_rtc_resume); static const struct platform_device_id s5m_rtc_id[] = { { "s5m-rtc", S5M8767X }, + { "s2mpg10-rtc", S2MPG10 }, { "s2mps13-rtc", S2MPS13X }, { "s2mps14-rtc", S2MPS14X }, { "s2mps15-rtc", S2MPS15X }, From patchwork Wed Apr 9 20:37:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14045516 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13CF0C36002 for ; Wed, 9 Apr 2025 21:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mKIEGv3zVsS/tvIgE0OLlPL/FateDyHpIQVfqm7tXaQ=; b=ghd3MHGsXcZJmUUXNuu1MRiZNZ jUujKGGKeVtVJMqB7IB7qbNyZNDOko1oQENP+O5Z/di5w3VeoJSlgFY6F8wtUhOYqz6c7nQildv4k fWfNpxBYSK3YHCJtcTt/GsxFidmjNuRAydEZyOHO32/jQR9udVg6huudBDSpoIhJ695lkf3hiyqYo hptUd49UaV/ft+7ip3tacugzRqC5UEBiHsEZbRqKwQZ1lN6qTeL9odPsoLUYt3D41JENnsq6sOTEj Wl891O/7kFj9H1itadK1hl1if2sVas/YOMEYb6Jo/S/4m7Ns8+9jQvrWezbFo1agZcpPVQz7B5aLl rTwNQLCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2d0m-00000008app-11jd; Wed, 09 Apr 2025 21:31:08 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cB7-00000008SiZ-2nyX for linux-arm-kernel@lists.infradead.org; Wed, 09 Apr 2025 20:37:46 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5e5e22e6ed2so177074a12.3 for ; Wed, 09 Apr 2025 13:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744231064; x=1744835864; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mKIEGv3zVsS/tvIgE0OLlPL/FateDyHpIQVfqm7tXaQ=; b=QFfgihD6Ufy/zk6I5IHARzEpKwurvU341kBaEXyUXC9+nE+2qUuIYvi4WYUj9GvOK2 8UalWkWLw15XQdY/qHiV4+yMoL5Aq2PsZDOKS0aKizAlHe1ZELNw9uk82x6IsukLcWy0 OdYykwJB5IqHnxubYUlzzh6VmAkZ5xkp9mQLrQZ404PgjyFZ82RamvZMmkpAS4J/sl3L iLLoFVRz+0rdq7juCuAtXSAQEYonobH3T700iyhTuEdTw5EtkhBJOHAQ9uOCdHMOXQzG NwlkDPxpjspDOe6LkwJ7opTHwAktF65T8DbZLcB8jQRlztwAS2dwd8muiFEtWVhiFwO4 KwUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744231064; x=1744835864; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mKIEGv3zVsS/tvIgE0OLlPL/FateDyHpIQVfqm7tXaQ=; b=hYfXJwRT8LNWHF4/YT+1QkRMxIx9U629HA1ZLzZnZjxf06q/YLkVk+sUtyxjGue6g8 /uMSRejTm6oPj25C0tqDadDxZlslVGkNl4ctQpqsv9eYkk/r+GXDR3GgsphfXSrmlqEx G0965bHTOQU9DzypuEHF0+f/PAJyx23YNVhzu4HDyHjT2domInEwWsjfmwRROFflAGFu PK4Vu/QQTDbhD4HVU6Reizr1ojpTzP72aySAqgJj3KB4sOzLmmfQZg0vCRy/yMc1ywsL CX66KTEGdp2YDvGT0DhoEzLL08eqV4G2I17/6hCgTeSf8hyYk+jBYczHmPgcDq5Gwfzk VpEA== X-Forwarded-Encrypted: i=1; AJvYcCUALjsTimkfhoDryM/fnmLzGs4i+3W9YjEvpWCfLy7cJw0oehcSaMh0NiU8NnAxIGuHvLpfCATKQcoZdI3GsLLW@lists.infradead.org X-Gm-Message-State: AOJu0YwSb3TDGEFn1eGEHbPvGFbIebiMBzQYeKAdR9crrN4ekwwoYQjL AmIwo5fgcpq6s0dnAeJTsz4XPaURrgq1sVdkVeW/CrzHnrPKOGQKeiT/DM1GEtI= X-Gm-Gg: ASbGncu4DlxiKWoEBgDV/wsi2XzV/o8hEzvvz2qZvKWBUcEOoLTaK7eFojruynigWdi DYe0LsTGK+eExlt0evp/f8EmOHKsYTyYQITZb/I6mWQ3VVakF2VZtDkJgGgQgkEfi4Q+EwSGfGr yCkuLEm1aklWXu97w0pE/nDbLp1z/Xzl4c1OvH4bbYWxUbhVhVV7pw1rXU3gAGjP+LblcOTlXZo 2sXXQWOhb9PxON1P9NXaF/rdCwP9QCmbQbgJJ401qfzzz3GWZxrF4dHHMYHWwprxGhS3PHTsYce /GfFy+psU4OWeWAXUBw7hxDuFENPBdyqbpg2DCRYgEncyIjaeao8awdBnSDXP92RRKdUYLVSTv8 0Wn0sznJRa7GcUok/dqgXGXQ5uSfUmbiW3qBD1Q== X-Google-Smtp-Source: AGHT+IG1YTLblK2ZacnQ+muHHFTtW2fsPo4+YsM4khlJQ2EKJXJA7UZyAbkh8L9PKTjc8rDv/I4VCQ== X-Received: by 2002:a17:907:7da3:b0:ac2:cae8:e153 with SMTP id a640c23a62f3a-acabd126d26mr9987066b.4.1744231063960; Wed, 09 Apr 2025 13:37:43 -0700 (PDT) Received: from puffmais.c.googlers.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 13:37:43 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 09 Apr 2025 21:37:49 +0100 Subject: [PATCH v4 28/32] rtc: s5m: fix a typo: peding -> pending MIME-Version: 1.0 Message-Id: <20250409-s2mpg10-v4-28-d66d5f39b6bf@linaro.org> References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_133745_709284_1BF921DB X-CRM114-Status: GOOD ( 11.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix this minor typo, and adjust the a related incorrect alignment to avoid a checkpatch error. Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- drivers/rtc/rtc-s5m.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index c6394faaee860427e8b84e9c6df2d8229cf06d93..095b090ec3949e0e8074cc344105daa00b795245 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -243,8 +243,8 @@ static int s5m8767_wait_for_udr_update(struct s5m_rtc_info *info) return ret; } -static int s5m_check_peding_alarm_interrupt(struct s5m_rtc_info *info, - struct rtc_wkalrm *alarm) +static int s5m_check_pending_alarm_interrupt(struct s5m_rtc_info *info, + struct rtc_wkalrm *alarm) { int ret; unsigned int val; @@ -451,7 +451,7 @@ static int s5m_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) dev_dbg(dev, "%s: %ptR(%d)\n", __func__, &alrm->time, alrm->time.tm_wday); - return s5m_check_peding_alarm_interrupt(info, alrm); + return s5m_check_pending_alarm_interrupt(info, alrm); } static int s5m_rtc_stop_alarm(struct s5m_rtc_info *info) From patchwork Wed Apr 9 20:37:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14045517 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6795BC36002 for ; Wed, 9 Apr 2025 21:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+zcRydoPq0e3uOYwLlj7ABnDIgPKatAxdb7+TG8s1Ss=; b=FEiSZo+Vak8EB9G6AkkrDO55p3 D2vCZ0vWbnMbWFw04gXWuZUERG6LX6tceyZe2O0MzZQkAHNzOCzyGKwM2+4Ot+nB1l06xqQpYYYGg VX/PQd9+GMHOOJ47a51OkQmSOHUzQOQccDVciqHgo/P1US1iMPF+CmjlII3p+slAM6urIUnLM6Mg/ bGAQRu2nhmwy829eqDbnw05JGM4vhnUnN87t58PKiTAg9e5ZxxLRRFY2loGbjElJ34FWihb9yCE92 XAdet2ShDDOBIP+DQ6n13zPJ/BLqw3YvmjLAxFTHcoVuqGeYU4oiB0YtQkKYZ+uhcxRaAX4Q/F/ib yVT+yDGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2d2W-00000008b3G-4ARg; Wed, 09 Apr 2025 21:32:57 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cB8-00000008Sif-06fA for linux-arm-kernel@lists.infradead.org; Wed, 09 Apr 2025 20:37:47 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5e60cfef9cfso191717a12.2 for ; Wed, 09 Apr 2025 13:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744231064; x=1744835864; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+zcRydoPq0e3uOYwLlj7ABnDIgPKatAxdb7+TG8s1Ss=; b=aHpannJAACqsNMF99LJbrrCqo6qVrq5c5RlkvLKzaMR5/xw4iU+URcxzFwhsP+bXvv FGbEj3GWnZFz7YDHJLOoDxpsQKN1Wu4Ibo43kJqQ9Kz0rn3xTHQN1aUVwP/awWR8nQkG MJXHnNVf0q6BdfDIew7QFHemTIibPvj0ZcHFs7YSI+EcJw7y3RA2OCJB+V3Ky0/ecsio jRyYnnEg2V0yfPBDQrwAQON2P+0kiNxY7v2vWOBYoHg3KfdCUhHXtpag9s10Z1Ua0Aw8 VQN1HU18hsOr/oBdkok5wdS2J9/aKYOOsNTTVaetqw9nUkULkOntpCq8rzNGk1t/3P2j BYaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744231064; x=1744835864; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+zcRydoPq0e3uOYwLlj7ABnDIgPKatAxdb7+TG8s1Ss=; b=jIYvmRTXzlns3BLJsNHJJCDxqZ3YQfb13xpO+HnMfdHSq0Wyi+nC6xWs6QaPPm5hNW jh3gnCv8FQEC39WfMXfd7OZGSmCIMaOZhEvujJGPSxe8jQ1ihnzFh+DtXBdf9P2rhMCo TBQo0VWf876kGeKgCv/azcxQwArfpu8v1xq6gt5b7U+GWInarNQQuz8vew0uwz5/0YdP 011PC5qR9b05/J9GQlKQh2SXHwXrqa3xWdShLDIlCPJoGAmY0bYsSI4/Ya9V1svmui0G ntat2qUZBTn6Ag2VCYid1dYPOWMM8aX46mweqlthff4eV10aM8qUkyw9h8BMYDkdMYzR VQzw== X-Forwarded-Encrypted: i=1; AJvYcCUtDLZGMM6NCN4EQ9tiJS9ARYeIbMxs83zGirop0gRcL6ya6X4zJLqV/2ddNFMmkFPiXcdbRcV9IDmb3pajddEn@lists.infradead.org X-Gm-Message-State: AOJu0Yx06c8RLE4Dl5M9Y+F602CEaAsVd6raHzhvTvpGaRG0kVil9J1R l86tva6WjLMNESndwalwy0OJgQJzzhjZVj+cjpV19Mo9mw6NXRNYGeOk+pnwopA= X-Gm-Gg: ASbGncuTGlKgcjkXzIHuuWTW0v3YnWTplmeYM6OFBuEO0B7fra3i6F9o0Wfn9QGg98R 0CqkCogxH53kK8tSLxLzCg4APLE/qS4KUrG8zzbsgCYOC8lEtZevora7xt1oF9rGf3k/JuEZ0Qn 1pR86+eqPhQw1W3lBJiCUr20JY+ZzqgayRKpkXB3V0MqPP0k13MjXj8zU+F3qURXv2gcYT26rWI ebokQyvHyz/dfydmZDXpw9x+Bzpk1XCJ1NOF4jv+ug5Bu2Li5hKMGlLq4P0Mj1R76Vp4z9LXrP9 WriOF2isN8zW3wr93mmBTzosc/8T4POg4iGeOB5IK2sKXFawy/+HkVyoD5KA28tjZQJRg8z2dn1 rwM5T8l0qqRRuWbP9lvHvkJ714gU= X-Google-Smtp-Source: AGHT+IGvuuLoVK2j6sMyyQsZa8p1VCqZY8y0EZ8duJvRWZG85z91U/cgYPqYUZihq20x9iTbe4XZTg== X-Received: by 2002:a17:907:7203:b0:ac7:19f0:aa5a with SMTP id a640c23a62f3a-acabd2517dcmr7867666b.27.1744231064521; Wed, 09 Apr 2025 13:37:44 -0700 (PDT) Received: from puffmais.c.googlers.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 13:37:44 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 09 Apr 2025 21:37:50 +0100 Subject: [PATCH v4 29/32] rtc: s5m: switch to devm_device_init_wakeup MIME-Version: 1.0 Message-Id: <20250409-s2mpg10-v4-29-d66d5f39b6bf@linaro.org> References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_133746_066070_EAE15CF5 X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org To release memory allocated by device_init_wakeup(true), drivers have to call device_init_wakeup(false) in error paths and unbind. Switch to the new devres managed version devm_device_init_wakeup() to plug this memleak. Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- drivers/rtc/rtc-s5m.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 095b090ec3949e0e8074cc344105daa00b795245..f4caed953efdd23fd0132d74d5199dec9cdfd294 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -779,7 +779,11 @@ static int s5m_rtc_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, ret, "Failed to request alarm IRQ %d\n", info->irq); - device_init_wakeup(&pdev->dev, true); + + ret = devm_device_init_wakeup(&pdev->dev); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "Failed to init wakeup\n"); } if (of_device_is_system_power_controller(pdev->dev.parent->of_node) && From patchwork Wed Apr 9 20:37:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14045518 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C89A1C36002 for ; Wed, 9 Apr 2025 21:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aro3/v5oHaDdhAQCIG1fg5IWgisO7nOka33BpVTMzSM=; b=aYTdvSUjyjpk2bCvXUOskpLtpq oOpRVL1O2IuDaWa3BXu7jTk9tR9j7sxY8D4bDk19sStQIk7lt21f8DzefcxMUN196aWt+/RimSm/4 Msx2SqzP6G7Q2upa6uC873y0c9tWMLyE+9TB/qQ0ujRUHkad6Vb8uDR2LH1RXxdUW9HWlToh4JuTt Q6RRAv8R/nVKTI1gQeYD6c6u3J/tV2pNVHTyXQxnZvVH6V6yqMUqTLht3YqhNU3lW55ihn7hMdZbp I9pF3fQyj8Kc4qLq4sAQKgkfJeuhGWEnruIMv3KUe5CaBT0LDsMl2wUn6dzkKZ+WOFdFSsHiyQgiV +ahNJAWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2d4G-00000008bF0-2spX; Wed, 09 Apr 2025 21:34:44 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cB8-00000008Sj3-1bWY for linux-arm-kernel@lists.infradead.org; Wed, 09 Apr 2025 20:37:47 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-ac2dfdf3c38so19211666b.3 for ; Wed, 09 Apr 2025 13:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744231065; x=1744835865; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aro3/v5oHaDdhAQCIG1fg5IWgisO7nOka33BpVTMzSM=; b=xtUpdM4dqH++/Gi3Fhqk8v2L22uTYcXgX79tzV4KdcEXORXtsZwRGvFxKIZyAKZ7/Y JJsRgZfMOgTWwjHkAFcy8/CtaBqIKcdv2HwQaimyPMrSAUJgUPQkqdusxQny+Wn29kxw SzrjWfhN0mC3OFp1+6L1FCeBmCakLuMnFp4B43bqCXbR9enIQicpqP4Vwahoo+vHRn3c GUYXgD65zVWMh/KW0vvY6L5M03vmXIFo2+7GTifqG7QB0WKbc1ajFFroUfIxw+sfbd7f VxbW6kGyXZjBGo1n18uNZ7Zh9Jupw2Jm7CmelAmyEOrN4OiYqZPEK84g7xlhSOK9YslX QrSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744231065; x=1744835865; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aro3/v5oHaDdhAQCIG1fg5IWgisO7nOka33BpVTMzSM=; b=FpiESyuHpwnvxTzBVNeXNZaNzAxUyXnCfSUyZcAaVHWagy3965GDF70N/EtKoCfq4S Jde/CIH1apazSSPBrFVP1vbQbRVLSNdgXZ/1EvgvyAAxh9MhrIx0zZU4n9An/lf9WmNg ReVHDdXyxNG8pc5J3Zr5N6ffNgII1q+pvToiJpPsoLgp38NgLeWqh4EBWWhZ7hv/NipL od9ijOosl291OTxd6S3moMivSbY0jPIWwf7wby3iTp9tYGgdMLaPRjkv17Lo82Wb5bCk /p5JXuvdLFiOTC6ipi6F+Kt/Eqw5hV6eq3+18Hd6PB/sb1wzFrIYeATT2FGQCk899Tkq ee4g== X-Forwarded-Encrypted: i=1; AJvYcCXUz1+YYH091UP5JA21kFVIkVTdfScz/39AE4TAgGyslsyAiiN6QwelyN3WvABtLyXTCeJn8WFCa6zhdQa7E21N@lists.infradead.org X-Gm-Message-State: AOJu0Yxo4ZWAGfA5n/QZ9DEzSAFeU3ljRV8sg7Cn1YLJypryQnGk+xbp 2g3ZWZDfJ+RVwXIuURTzRvBfIBh2DF9kR+Dht8+tk9EkIlvW8hAkNBWR50OJq+o= X-Gm-Gg: ASbGncvzKxay7oD2Fe+jgzBLTHoqH6w+mDSvXaUvaKn0pMer6THen8H2hr4ismH6Yg0 DHaB0dfbgjtCdkhizR6ms0RODctVBHXgmqPFb9Y5C7FNY/Wi4gq8hJYiwwT+GGgPFJqv/uEU9A0 43aqSFopfPJkt4ppTRCdaUhcgwPaOrrKE/C86i2/6kdpdSQoV4x5P5dPK5N+nSQvXSW5wXcVNtm jTcZ+Qq2wUZBVMjRNl6bjiX+VbzNuYfMxz6/IXks0TFN3b9FoYAAeq2aZvw0GuWMBUqwlXIsp2z f+d4HSYf04+X3XOEA3EjRnSm3+UtZEq8tJH56jqKIqfN89sOuy4H2hdzW/tiM6N2GYem6KQxsg1 vvKOl+YrnZ5X8ShePKwth17dcHRA= X-Google-Smtp-Source: AGHT+IEdkkXow6n79ZWPbZRhN5XFCjydXvQNxgGlSC/PrHUaOACC0tp9PiBCaVoIN+0xJ5YXvd/Wlg== X-Received: by 2002:a17:907:3e0f:b0:ac7:391a:e159 with SMTP id a640c23a62f3a-acabd4d8449mr5988466b.60.1744231065076; Wed, 09 Apr 2025 13:37:45 -0700 (PDT) Received: from puffmais.c.googlers.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 13:37:44 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 09 Apr 2025 21:37:51 +0100 Subject: [PATCH v4 30/32] rtc: s5m: replace regmap_update_bits with regmap_clear/set_bits MIME-Version: 1.0 Message-Id: <20250409-s2mpg10-v4-30-d66d5f39b6bf@linaro.org> References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_133746_456142_5D50B381 X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The regmap_clear_bits() and regmap_set_bits() helper macros state the intention a bit more obviously. Use those. Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- drivers/rtc/rtc-s5m.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index f4caed953efdd23fd0132d74d5199dec9cdfd294..27115523b8c25794a9f3ac8e734bb1ed998e9518 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -338,8 +338,8 @@ static int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) /* On S2MPS13 the AUDR is not auto-cleared */ if (info->device_type == S2MPS13X) - regmap_update_bits(info->regmap, info->regs->udr_update, - S2MPS13_RTC_AUDR_MASK, 0); + regmap_clear_bits(info->regmap, info->regs->udr_update, + S2MPS13_RTC_AUDR_MASK); return ret; } @@ -351,10 +351,8 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm) int ret; if (info->regs->read_time_udr_mask) { - ret = regmap_update_bits(info->regmap, - info->regs->udr_update, - info->regs->read_time_udr_mask, - info->regs->read_time_udr_mask); + ret = regmap_set_bits(info->regmap, info->regs->udr_update, + info->regs->read_time_udr_mask); if (ret) { dev_err(dev, "Failed to prepare registers for time reading: %d\n", From patchwork Wed Apr 9 20:37:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14045601 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B314C36002 for ; Wed, 9 Apr 2025 21:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=96SpQhawR8x63CHV+WMoNeJ+9FHffMMf4Oxsm8b8rjw=; b=g+BN11sXIDJ1xoMdzcczf1zQ8s LcPHfrBHYbTJW5L7ub/9HanMBEmQJN/9yY4AW1xdGjC6uBRvm7jcT5Wu3c/VRSfrOf+ZjonZ0ej6h iM3RBB9wbKZ1kE0go1jeWaUiQqUSJwaksd62HREhX701BkLsBVCr12RWgZyx75FyeMotDQEJ2/2/R 4wRG0vnnLlmL8zP4Qp3Qh+gUQwPpEGi+plbhfG7wK4d82qjOgasD//2FDCeHdGrI1X5zKyxTqOQZe FKcbzKK+yXh5zJlY7wb0zTp6fnu7Es+J3eG3y73vebBT4+iyLLcrF8KNmOGj2gSFvC39mDZr+vO4j 9D7vZPHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2d61-00000008bVu-1RDk; Wed, 09 Apr 2025 21:36:33 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cB8-00000008SjV-3iD0 for linux-arm-kernel@lists.infradead.org; Wed, 09 Apr 2025 20:37:48 +0000 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5ec9d24acfbso2151335a12.0 for ; Wed, 09 Apr 2025 13:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744231065; x=1744835865; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=96SpQhawR8x63CHV+WMoNeJ+9FHffMMf4Oxsm8b8rjw=; b=JatkkR8/y5YiUWOzzgG3qPugyR/ZINDfCJOTiAkX3ARZr4p9kvImnvy0QqkeXKZ40Q OmRxAujTtZc6w0fWoeWC86M+CEKYUm0WCGmd7u7X/9kZdN6TuORxivoIdPdxHuIO88fa 79B7aezq1j+zz4YxU9SyjyoTWJ/Zx/uoFmOu0i2+m7q9rXoLWgG/PA6WZQC0+6ejufpv 10CPYYpQdmWGwTi5b+Fb3gXOvyEopSHp1CmBuz/I9TTGqPsxLqyQI42/SwJoHrJ7JQg4 gmi9txGukiJTw/ETRJjjK8w7f29isLHwpI9YW1UbgsfQVbrj0eQhs7h44iNz8AdTeix8 rjSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744231065; x=1744835865; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=96SpQhawR8x63CHV+WMoNeJ+9FHffMMf4Oxsm8b8rjw=; b=YYTDcafzKaeUHIdkWIJDYQiwp8a780CetrWxi+Uup8Bx2cq1IVU13fyklAuTwoNRgp XULu03LxZHzt5ohKTrAWdmK7NXsmN8JKBGVL6twhvRkGVQgC6NUKlLxEaDu/2AetONzs ZFNLSzzqfrw1hilMQ4r/NrFo7zOnWusu5MGdjG5dXzIWj0QMFSeGJiLZlGvWTTCXq8QZ E43tU3qVrftg6y6xlt9s+UO4O2bg7JKkJFO7/sFYheSF3gcbI5222DUDBB1niUGC5H7S dxWAjCYrnBlYWI1qgCRdaVBbm3exYdIvQtyRlhxY2O7imyOr5f0N9SFDfFosqB6vDANQ A/jQ== X-Forwarded-Encrypted: i=1; AJvYcCX5kQSIrODu88+oqXiO0KLF55jMiUQ9SrVTW3OkBX5TBMri5mjFEwUhq/kW+nSorrjBo9B1iwmyvMrQlgpNg+Gn@lists.infradead.org X-Gm-Message-State: AOJu0YyHNtOyupfObuLtBo0bZ0t2GjQ4Ez7GX2Uqnrr4Kk0lhmWbGw8K m79D8M7hXhJBi/hkPumJDgImOlqVf/G3/pvL7N3pFQiHAVSJvCHLeqc9lZtpbPo= X-Gm-Gg: ASbGncuxxTn0Fye4fCGjZNAZWzq0r1BuQdNRVc9WFaMA3DsmlKz+I9ymgVNeVGmnF75 yW4eGuA0PYGcnARo+mTHDc7vr8KCR3DpiSHbOIY6vJSKesmkpiiKbdG2k6psrtTIf04/tgRRije M0XiW2w6EyLfyJzOt2lADpqst0ezg67d836toE7AFApG+ZcOTNkCOTJJyXUNUJ3C/mWFWp1aDQ6 theVWgsk+PJl250ifmo6J5zXZuIbpFjPQjB1ipxNxhavqeoUAWfnFkApnKu9Y1LgKrEif8blKfb MAxfiTmDGAtCNaWWN83KTZL57wNnZF5l0g/HSi+gdsDdRI7uq6bXqPfv2ELvQonFPQ8uRx8kyU1 ASYyiHAOoDHv7QDMVu9llp1tQI9g= X-Google-Smtp-Source: AGHT+IEzQMsFiFL/jdSvqMTouRITC/7JunlX1FkfQVGWlY9H5peZ1h9WvmD7A/zfy8HqRCQ5/PLUeg== X-Received: by 2002:a17:907:7e86:b0:ac7:7d3e:7336 with SMTP id a640c23a62f3a-acabd3a3d95mr6823066b.22.1744231065588; Wed, 09 Apr 2025 13:37:45 -0700 (PDT) Received: from puffmais.c.googlers.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 13:37:45 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 09 Apr 2025 21:37:52 +0100 Subject: [PATCH v4 31/32] rtc: s5m: replace open-coded read/modify/write registers with regmap helpers MIME-Version: 1.0 Message-Id: <20250409-s2mpg10-v4-31-d66d5f39b6bf@linaro.org> References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_133746_929280_5A3E4C1E X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of the open-coded read/modify/write sequence, we can simply use the regmap helpers regmap_set_bits() and regmap_update_bits() respectively. This makes the code easier to read, and avoids extra work in case the underlying bus supports updating bits via struct regmap_bus::reg_update_bits() directly (which is the case for S2MPG10 on gs101 where this driver communicates via ACPM). Signed-off-by: André Draszik --- drivers/rtc/rtc-s5m.c | 28 +++++++--------------------- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 27115523b8c25794a9f3ac8e734bb1ed998e9518..a7220b4d0e8dd35786b060e2a4106e2a39fe743f 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -279,17 +279,9 @@ static int s5m_check_pending_alarm_interrupt(struct s5m_rtc_info *info, static int s5m8767_rtc_set_time_reg(struct s5m_rtc_info *info) { int ret; - unsigned int data; - - ret = regmap_read(info->regmap, info->regs->udr_update, &data); - if (ret < 0) { - dev_err(info->dev, "failed to read update reg(%d)\n", ret); - return ret; - } - - data |= info->regs->write_time_udr_mask; - ret = regmap_write(info->regmap, info->regs->udr_update, data); + ret = regmap_set_bits(info->regmap, info->regs->udr_update, + info->regs->write_time_udr_mask); if (ret < 0) { dev_err(info->dev, "failed to write update reg(%d)\n", ret); return ret; @@ -303,19 +295,12 @@ static int s5m8767_rtc_set_time_reg(struct s5m_rtc_info *info) static int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) { int ret; - unsigned int data; - - ret = regmap_read(info->regmap, info->regs->udr_update, &data); - if (ret < 0) { - dev_err(info->dev, "%s: fail to read update reg(%d)\n", - __func__, ret); - return ret; - } + unsigned int udr_mask; - data |= info->regs->write_alarm_udr_mask; + udr_mask = info->regs->write_alarm_udr_mask; switch (info->device_type) { case S5M8767X: - data &= ~S5M_RTC_TIME_EN_MASK; + udr_mask |= S5M_RTC_TIME_EN_MASK; break; case S2MPG10: case S2MPS15X: @@ -327,7 +312,8 @@ static int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) return -EINVAL; } - ret = regmap_write(info->regmap, info->regs->udr_update, data); + ret = regmap_update_bits(info->regmap, info->regs->udr_update, + udr_mask, info->regs->write_alarm_udr_mask); if (ret < 0) { dev_err(info->dev, "%s: fail to write update reg(%d)\n", __func__, ret); From patchwork Wed Apr 9 20:37:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14045602 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3BADC36002 for ; Wed, 9 Apr 2025 21:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+Ow5hOPbiIZXZpWZ6Uu6oQmw7CcTYqg39bQG6yedoPQ=; b=pRkGyMYVa8PnCpohTUiIYtESU3 ishq5+IpZd5Klnn3Cnpjj8Tno6fE6W07yr6VBU9gbGUQ7LfEZvpoGed23n5UrMd2N7g90julcA1gG sbeHwwy/BkBiQKDn2mtwN0xLffexSXIozAqE0nPW63QV5fdWY1jbTzG3k5t0JeXKk8yw+LiuXRBgo zupAYxVhpEhJoh8mKArY1gxTCzLB7CLUC3sB0WzHiN1oEPBDl5J0Q5I4A86Kv63l3vAyU43wxWkjm DNDr7APy+aI7+1wxF80XWTuz8KE6lWRsbUw2NJ4gXGQAaMHCZtG/ts49V/S5NXEYocrc7ww4Qui1g WMlIxejw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2d7l-00000008beF-0TUJ; Wed, 09 Apr 2025 21:38:21 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cB9-00000008Sjt-1y7j for linux-arm-kernel@lists.infradead.org; Wed, 09 Apr 2025 20:37:48 +0000 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-ab78e6edb99so13304866b.2 for ; Wed, 09 Apr 2025 13:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744231066; x=1744835866; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+Ow5hOPbiIZXZpWZ6Uu6oQmw7CcTYqg39bQG6yedoPQ=; b=ypcSKwXgFzwYtmFINm2YH9/zjTVZ0cyPet/bV7tRvLXW/RvNupgelYc9J1WMXnbco3 jXGD0nYY5ItIad+FeTNLD/ryug97/ub6eNrn6sKwicm0a1fEGg4+mlzDa6WLmrK7TFI8 R46k4Br4tUmjYt+xN95Qkq90IMxCm1lJTjg93Dg7TbbMiFjjs2yPNXn1WlU+UXGRBIIa uEiof1PlfddRGXGyjficJ0xbGIVwPYcJf19XUDSunk7eoCtJVbZ3Yja08tNMAaSdWEFR NI5WAo515+UVw3wU4HLr+UdNmurhhD1qiTTrLvEjmeL0PQjJReja3OnDyrCzIhW3Z82g dVIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744231066; x=1744835866; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Ow5hOPbiIZXZpWZ6Uu6oQmw7CcTYqg39bQG6yedoPQ=; b=krDNnggmCO59SYtqKh5xcMHz1M4RB8sNhN0zKSxVC9Nk18T131CS5i6kdjva/BN5bH KbG1pWiuAaXSIm9GtEXm364saC6mKEnMA03gDFOZdqPPtzNCYSok/7PyFcNiAp8gRsWl SHjoUw811YwRvTXCotxkdBV00PBVUmSsFkDnXdp++VzcmVvoQSF/JzjBVMcEwGL8peFs 7hwmRgGwFofKYX1oRDbVKcDGSrulb0djtENmNOXTD6Cerk6k6EnyG0jehkBw63KzEF2S JqNTCaqvsaz8OVaWy3iY7sJRrNcY0rfvPGVmJnNedftRIXJuY7HX1OKdBS1Gkh2nKyEj CbLg== X-Forwarded-Encrypted: i=1; AJvYcCWH2iX6jI6PvTP3qBE5hUSzB5njAqVYhw1nMcG44TDcVEgbINm/VfFCx8woXzXawXfierlA8bdPGBKGySGY1gm8@lists.infradead.org X-Gm-Message-State: AOJu0Yx90Hawu7tfOBByNNBJ/lwpFt3pH5pBxfItcIOTgtae26OYabcp j9tQv/PZha392G8X9u92YAKi6PKkzATvhb/94b3f3z81MsvoOxO8qLdTRNOGMFw= X-Gm-Gg: ASbGncuZp07jpsGwwd9Dvu0gQBJa89TN9bsKsNbilK6r0pxIdWK+RHAe8mmFXzGCYro ku6Kq/LvZm4wH44RMlYPmieWbYnK5xdb7Ej1//d0ioSc/fuSufLjIxETz5Sioa5jqu7Qj4hriJ/ xMhd0Ey8fuA/EHg0frB1opyb4O/QyhXt/nA9VauSlnBwL2GKa87pkPAAKOqpS+vylUHvzfZ5uah h/GDjBKz5SYKRe8lPkKrzH38Uywfa88VvIr+is4IjOjVseYyhnUvCjddIzvDsL7kefK7EZeMFsS OHAlphVtki/xR7iSeBLiwV/R5MQMcv1uuJnqpH287sy1bgwz5BqG+cPpjbhNSNpjFUY++Xp1Gzf Au9XCSVjZ1Z1wt8fsbhwXWuPEAps= X-Google-Smtp-Source: AGHT+IHIxFKwjUo5uFV6Jyj3wWXPZsF8lPwam2ydOiylWhWcuYhWeTd4XU5X8ZDB51XZhRzJ2FSu4w== X-Received: by 2002:a17:907:7d8b:b0:ac7:9acf:4ef with SMTP id a640c23a62f3a-acabd4d7131mr6904366b.56.1744231066055; Wed, 09 Apr 2025 13:37:46 -0700 (PDT) Received: from puffmais.c.googlers.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 13:37:45 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 09 Apr 2025 21:37:53 +0100 Subject: [PATCH v4 32/32] MAINTAINERS: add myself as reviewer for Samsung S2M MFD MIME-Version: 1.0 Message-Id: <20250409-s2mpg10-v4-32-d66d5f39b6bf@linaro.org> References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_133747_509684_0D421C83 X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I'm working on a Samsung device which includes this MFD and would like to be Cc'ed to further contributions and help on reviewing them. Add me as reviewer. Signed-off-by: André Draszik --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d4d577b54d798938b7a8ff0c2bdbd0b61f87650f..9f05af52b062d8cab0f8b48b2625432108604c3e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21397,6 +21397,7 @@ F: drivers/platform/x86/samsung-laptop.c SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS M: Krzysztof Kozlowski +R: André Draszik L: linux-kernel@vger.kernel.org L: linux-samsung-soc@vger.kernel.org S: Maintained