From patchwork Thu Apr 10 13:33:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 14046536 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9657FC369A6 for ; Thu, 10 Apr 2025 13:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nh0VanLTR8k7JGV4ABz+/PnmlXleZHArR9ROXTfckbg=; b=OA4J4NNm9kdsz76umUTB0w/cKV CgeeTCBUlVraOKPif0czxMnO/s0kaXDsLx5FrEJ58S8zGyUW97TFCoN8YgCzAjsJF/EenX65ZaywL kruJ0ZSg8k0OH5h7xoBftUt/1qWQZmClD1udIbtqeW06YKsNdzv+8gGtCpyZhXrvFM5z4nPCLKaoL IXrPHsaCktfpeDpuNzinCduOYalO+Ygp7/3i/C2Y7ZHUmrhyQReM/4k46cI0JPT4eGA2TLDnDG8fD 8bFb5v/DAzWedAKxjb8U6s8d51dUbkE4zSVs2k9YT1upDaFzua7XzFPL725T8xYyjvLwkfj39tjn8 UbqNM8QQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2s6T-0000000AhEC-2mlx; Thu, 10 Apr 2025 13:38:01 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2s2U-0000000AgPg-0pnK; Thu, 10 Apr 2025 13:33:55 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-22409077c06so10872025ad.1; Thu, 10 Apr 2025 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292033; x=1744896833; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nh0VanLTR8k7JGV4ABz+/PnmlXleZHArR9ROXTfckbg=; b=SJr6NMSjR1B0STcQ4OGoPpU28UMgYJzZBW3QsPnYJ9zKrojDHaOreJ1Krg+UjfyAC5 ft4gYP4WXRB+Psn9ScESzAstfWh2PtPXgGkF+FgDe48dVq/qHFzJYMea2hcW6HH6rV53 Xtodg03/jqKS4hSvfyj+RygxilbKwTFSPgm4AjUZ7E5hmlV/qqV6sJBD5lNYXDbDr2NG EX61yPfMi46DKahNSIB3B5Haf6RoPiBNjRIO/bYjvJABkz4g9u5YmtwBYyC3IRoxqduD pvMpZdzmivI4eEQWIEqYcBmlNwDW0tMbkasN8SxtYqWmhf40mUFibCKPI4QLeWNB2JcV JjzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292033; x=1744896833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nh0VanLTR8k7JGV4ABz+/PnmlXleZHArR9ROXTfckbg=; b=BHD3WbvLV6D8YPFbYh5wQnoEnJpMRRF00VKsUpMosjmVy2skXyGL8T3OD0J2tfwmQk WxhNWG2qVtJPW8I3lRk/UaNJx934IZrzv2bN3TQE4O7k4EYH1OQDGp0ATOTKfwv3Qj2D VnfvfIIXUHbtJhQt0OPHlSgglUXAbb3a08AsO8a8LmZS3LJL56ruu3p26ywzPjTJ8z9i Qox4zDSKjZmJ7oYrnx7UYlO5XltGr93ada/RnHnfh3borfkUqOx9P6vsemz/RPJK1qz4 pdmaKJciDupzldXf1rUmCGoFUSkN3Eqk17jpROmch1+6LtgGGsusC5bNy0fSQ31Z8hd7 VORw== X-Forwarded-Encrypted: i=1; AJvYcCUfGLaMjHbWBoNPml3a9IEWaXfQwMPs3ZGvSvwd9mLL4EzXJY3IorIMMPagQYkQHWTGAEKxE9KwwjyLWd1vRQyQIQ==@lists.infradead.org, AJvYcCWN6iHG6V9CviOAhsYO0a5E5SY4bVTZZtKanSOjf3YObjd7aHS1YcTxRNWhCWYy5rI7tpKlXw4tI+T/@lists.infradead.org, AJvYcCXguXsxFJM1KDFO3sSlIxSV24p4EMf/ZIaEoEXGYOmOiF5wmpejlK7mPTT6uEnErvJgbEquEVF5EwmIcETO@lists.infradead.org X-Gm-Message-State: AOJu0YwnKm/MNnrvTE+uzFsNCPNsiAuhfK28YQL5voApE8FgormlzVJq i5drqB34wZK4umiyel67ujeOrMcn19iifQTF+ieweSuiqJ5e8IIm X-Gm-Gg: ASbGncuQ7WDfofZjIY7TP2Y0U9n1pKUUlco8DEyn78MhAxKMOs0ZNJeuw87kWNJynLp E+zzaLd58TtCYO88Zlbkgigmm2NQZWbwoAprCk+YtSv5xWKysdDgnc344nAOs0wa4w6ll0lj497 AvzydyxDEMS38zQuF7rb2wnvzzySpzI0KBF2g9O251SDSfFNzzEyWEvwdSovX1qIeqZOS5nsGef 4LjRzoY+cLI+VY3R2ZiVNPAs5bxOpzrEVe/XzsVQUBvYsdnksESctV5oX/Z460QndjTspss6o6s Pe0Ib4gfaEqW09tZ0h4XZkXGCcrMfGLJLaYGceIXzzKK8AlH6PR2p3M= X-Google-Smtp-Source: AGHT+IEhJosZc1PPq47EzJpgLKAV0sW8OUksWP/T0By+TlgLPTsHhEsBRkYklsNnL3vMaEPTFuyMZg== X-Received: by 2002:a17:902:f686:b0:220:e655:d77 with SMTP id d9443c01a7336-22be03cf8d3mr28766255ad.36.1744292033274; Thu, 10 Apr 2025 06:33:53 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:33:52 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 1/6] phy: amlogic: phy-meson-gxl-usb2: Simplify error handling with dev_err_probe() Date: Thu, 10 Apr 2025 19:03:16 +0530 Message-ID: <20250410133332.294556-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250410_063354_234952_6A75E6C7 X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-gxl-usb2.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-gxl-usb2.c b/drivers/phy/amlogic/phy-meson-gxl-usb2.c index 14ea89927ab14..6b390304f723c 100644 --- a/drivers/phy/amlogic/phy-meson-gxl-usb2.c +++ b/drivers/phy/amlogic/phy-meson-gxl-usb2.c @@ -237,7 +237,6 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev) struct phy_meson_gxl_usb2_priv *priv; struct phy *phy; void __iomem *base; - int ret; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -266,13 +265,9 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev) return PTR_ERR(priv->reset); phy = devm_phy_create(dev, NULL, &phy_meson_gxl_usb2_ops); - if (IS_ERR(phy)) { - ret = PTR_ERR(phy); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to create PHY\n"); - - return ret; - } + if (IS_ERR(phy)) + return dev_err_probe(dev, PTR_ERR(phy), + "failed to create PHY\n"); phy_set_drvdata(phy, priv); From patchwork Thu Apr 10 13:33:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 14046537 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BB08C369A6 for ; Thu, 10 Apr 2025 13:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t7/MnhQ+XPTlJRR1H/JsR3WjkkF0jznVuDOQtTNzl7E=; b=y/jGPMMUNV8ZbBmL1o8uASPNyi iLHegQxgpGaFFsMGMFRA0E8vHj5vSnINbzm1AoQazBLeVE2drRn8JNb3w859uMw4OqdwwL761DPHe t3NgQhCf2FXT0mwlO8EowZpsom2Yb/B9lxzay5aszYJ1ax2JdCETVtcDFR11OW5zQsX1DnCM27Px+ Im35kpMSwBtTepI43vio41GAKgGVygDmWQCSTTWQ1xbzpyYnZ4XDtmO/HRiouRJan1wkbSemVd2HB CtMRm/PtuZHZCAkaRius+ZbzCETHGOkkWYImHO1vCij3655si4hBJiNqTkgxBZRQRAZgpBoKO2FH7 cfhKggQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2s8E-0000000AhbG-3zo7; Thu, 10 Apr 2025 13:39:50 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2s2Z-0000000AgR3-1nkm; Thu, 10 Apr 2025 13:34:00 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-22403cbb47fso7845955ad.0; Thu, 10 Apr 2025 06:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292039; x=1744896839; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t7/MnhQ+XPTlJRR1H/JsR3WjkkF0jznVuDOQtTNzl7E=; b=NPeHsg28U69JrxtoNpkwh0+L5/iIOr1Zs6yRblX3Aylzzem480O9bFbwMrPchyelzt e9YEvDx1f5lqDrSsEflaBIjdbsvk26KjA7903WcktOD1/fvDZvPlWPApn0rNXSqVLlC2 aWccmE2RfyflwQ9/84TxTP1pY1wVufaQeWllEWmheH4oudrBmQqtt6RFTWVaWIKb/N/g rIet8OzvjVzzdOiDTmjasRrQ9TnVxrshK9lfQ2Lv5gMlKJGl8ot+XFV7c3VnGGlJyog5 KCLRKgBj/1HKQYgof7p0bXe9Iad1c7M2To/j3gVj8DDujcXJuQpCYuwQMRDt5tZ/MWbk etWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292039; x=1744896839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t7/MnhQ+XPTlJRR1H/JsR3WjkkF0jznVuDOQtTNzl7E=; b=Yeo10zaKK3XsM/vidXTUHz429E5XhP2gzlBpwiPnus4idXMvV28d6/FNBdum2s5/Cc T6zu3pN3MM9hmrI/5ncfgl1TlnM6SRcvvB0e2Ei0ObKlnaUHXK5rCUPsJOmiP/xMG9dd R3yITiq6mnCWxXKHOkckGmAh2Ui0LM/mVdFafTWBoK33RCQR1wyA4jieX/BSMSDnjXT4 nBOySdb0MzFjcTiy8Poi1vMHejZQ2Z5YQlxMR4sJ1hlFN2PIiqqOGplc+WOI/ZMy27Lx YRmGMk9yL/uy2aaZEwLKRWlyAegAyzd/79hi9R36//ly9L3xYK36TxhhqoMOm62oieBN H72Q== X-Forwarded-Encrypted: i=1; AJvYcCU+UyZoSmSU6Sm1lsACBGs3zXhHssMo2eAnCPTkxdKW17wPGayV0AdjWqbyy23r3g0aYFclP0K9bJ+l@lists.infradead.org, AJvYcCW9TkuYxsRpz32oH5BjLkqaSupY5JkZssffMdrXZGUi6zvw4Gom06m3+WLYQgDib9LQyQicumbeX39Uu2OK@lists.infradead.org, AJvYcCWeuCp2ipkBIhybGVLDk8ph/BxtVg2kToLLPpaShyQrvYmY+ebcXKxKqrtvE+IzYf2fbTwgcVflKpqjlv8z7KCglA==@lists.infradead.org X-Gm-Message-State: AOJu0YwXM0Wky34avLR8aSlEtphup+nf1wV1YfhQxnap74yIwcLbFf7M 8nRezdz98I8N8l/actmz+eKKbUo2cA4yvYFvWygqB6G3jKAfqk17 X-Gm-Gg: ASbGncvxVzubgD0M8baVwFRR3Qy7TebaIcUKrNSvHlPNIZpq+u6LqkWO8jeOrpCziIM /4qAKpWK1Xh4AoamGNTm6593dtsBPU9ieOeGK9n9vJw+tbgJAyQnKgKQkFixh+QvOPHlie8SKfp a/XukpqAudik9ocusnodfHnBkouSaf3TWCba63Bp1VGfHixARO7NWnqPMbsmOjiwOi9F/dJFsyP h3hmcuFSqiSDxMV8qoZjI2mqeWKPYGJfQnnkWTVOiCWA+VesaylrglzGfMZ2PSTNIOyE5XNna+M 1kxvTk4JYMZMN7K0lL57rafMfhu7Wt23jSG92Kc/ql5BACiYebAlehE= X-Google-Smtp-Source: AGHT+IG1oHEnhJcJPMpJXFVc2lblDNzFL0NCm1/z6pryHmDc/E60Sjg2zPGvf+IjlruZt6r44yNjmg== X-Received: by 2002:a17:903:46cb:b0:224:a74:28cd with SMTP id d9443c01a7336-22be03167bamr34974705ad.31.1744292038682; Thu, 10 Apr 2025 06:33:58 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:33:58 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 2/6] phy: amlogic: phy-meson-g12a-usb2: Simplify error handling with dev_err_probe() Date: Thu, 10 Apr 2025 19:03:17 +0530 Message-ID: <20250410133332.294556-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250410_063359_465150_543F092B X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-g12a-usb2.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c index 0e0b5c00b676f..66bf0b7ef8ed3 100644 --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c @@ -339,13 +339,9 @@ static int phy_meson_g12a_usb2_probe(struct platform_device *pdev) return ret; phy = devm_phy_create(dev, NULL, &phy_meson_g12a_usb2_ops); - if (IS_ERR(phy)) { - ret = PTR_ERR(phy); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to create PHY\n"); - - return ret; - } + if (IS_ERR(phy)) + return dev_err_probe(dev, PTR_ERR(phy), + "failed to create PHY\n"); phy_set_bus_width(phy, 8); phy_set_drvdata(phy, priv); From patchwork Thu Apr 10 13:33:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 14046544 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3691C3601E for ; Thu, 10 Apr 2025 13:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ppfroywA/WF+8dvpxb3LW0A1l9sdjedjaaEGMEvs0rQ=; b=nmth4qBJpKPbdHE0c4cFDqdiYN /xj+Teo0KE9lAb6Zuxf9Wm/LStmahMUXLJFzmTvvPuczq+xh/5oTGrF+ptJNpFXW0XLfZi3d8Y0u8 CwceLPercG/MdjCTC2Exp3Svl16Pf3iUMwe23q/KmauZe7zMGoAvne9jOhM+gwMpwdkE/hYIUeOiB AFEsBpFvNoHTVkmCN531aZh4wsUkK0nNKF19yOaDI7t+BitHBbXbQhMePPNx7cQgZe9OuTPX2jEu/ jBzjIpzYuWO4fx8pHeXnFH6ddNzXzYwvHOOLh7ylPs+tUdQVUaL8BifvFHn/ZG5EPY9fQIi84gMrF KpLWvw3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2sA0-0000000Ai21-1Aba; Thu, 10 Apr 2025 13:41:40 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2s2f-0000000AgSC-1bVv; Thu, 10 Apr 2025 13:34:06 +0000 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-b03bc416962so521754a12.0; Thu, 10 Apr 2025 06:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292044; x=1744896844; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ppfroywA/WF+8dvpxb3LW0A1l9sdjedjaaEGMEvs0rQ=; b=TQlR7u5+45u80st/vy5xolMwPF9/Ow/bF9d9oxBquwxBulCmlh6On7LfcmRVf5AReE dJOdL4Ca0mhkTiIQ8dKBkTUiDQBAhJ/eoVzM9TQTtTqa/yMN80WxN+7UCacTcpcYdoNm xTTi/9tVBXN7laGTcmlfxXoahYe10TwmFk/1UcLXDl347TCs710L/qEN8J/AEbkYpFt8 L8Mb924scFhFJgHfd/Kz6dXRUpUcGAfCjwzQugtXRzjsdLi1LEWE8NnVuT2LD5p8RTbk QApZCyzqLLWMwx7af+tDtjoabEGUsUbOf1AKtNoFbZ5OJg+oT1dg6jW63szjCQ2QRCC4 1KHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292044; x=1744896844; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ppfroywA/WF+8dvpxb3LW0A1l9sdjedjaaEGMEvs0rQ=; b=FC2Is+2+4Fj/KOu2KZhdDFd1L4E49Xikubs6mgepaZM/vc8xYBCP+wYSNE8C+rmcP+ qeSS5J4HrDz2ZmBiLsZurggpPbnY6SXbiUSoYEHbpOcDUB5pW49Lmaq2EhEA9wCuc0A/ qON1r4ZgLq623+V22la7fUaXMsLJ/wiJOcneS3GEt6eCArvw7i/J/siHnSAhnLSyxymc m0g+5ISA1ePuWjE04VcM4CgFDy9NX4Ls4jKR3IyDAIoGgTs/CrXTPfJHbdFjolko2Mmx mqleMSTPbzMSfx+iCUj6D1muQSI5Xh/kbOjMIK8q4gzsMx3n5OdoN7BgicYPv2vvE4gL 4DIQ== X-Forwarded-Encrypted: i=1; AJvYcCV1V6rksMQLN2zK2gUbYp7DizIyv8JOEMywHP33Viidqb6qP9589JXxGnYYDBJfWEg0AarTSRfsUMTTVBUZ@lists.infradead.org, AJvYcCVsQ8FHMVXbZY+W8vqC1KVBoar0NDkaBB+N4t1xNTfjB5UXnny8bTMuIgSaKJbko9j2dbpyZXGPkIW+@lists.infradead.org, AJvYcCWytRJHpDBPNp2T6xlFQgnqzCMvIs1W2AwaHHRNqIWtVBFfrLHDrDUrEaheYnqAh1SW5fJ3duPOQEc7MlkanUV+Ew==@lists.infradead.org X-Gm-Message-State: AOJu0YwHKoHj4G+MTv3GGUXPXxjDQEJQwunU8sx4SvcYiDOTACXjsMP5 TlU4DkSxdQO/HVeYgDUICkrN7AXuJ/mnJlT9N8UNwu4hrkIddCbl X-Gm-Gg: ASbGncuHS42a3ybPsKHr11BhYy//ViZm3tOiUBbzI7bGxPBQ1e3lZrUtG4+9JmqHSA0 wu+hlzAfvCbE5wbjy10euOknWU6/PkGPUY40R/1ELcQdgFg6M7bxh668RWtBZZZ174g6i9ywzZu ka39kW5XrZT66Myr2vkklXUMAPxnlNfsxIgc2VToMtw8lBZb1zaz4M8qMehCoQjhaTos2CVKZKQ aHIB8ylog0cWSy4KNB7Ig+JBfjwf939CFop9t98WZxOGbJoXSW6nEmoh/F9OkP3ocFDAKgGd7av TGQewu+efazzGk4A3h4VGIPK79C0wQfUxV+/2ulbOauMJsTwFtazBIg= X-Google-Smtp-Source: AGHT+IEx7fjFPOwJFBqQcxYwcNEjjXqC0n7A40gc7RBPd72Er1kad1UbyK8eNmLCNZzCP+fmYv0iMg== X-Received: by 2002:a17:902:db01:b0:216:53fa:634f with SMTP id d9443c01a7336-22b42c44052mr47156885ad.48.1744292044230; Thu, 10 Apr 2025 06:34:04 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:34:03 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 3/6] phy: amlogic: phy-meson-axg-mipi-pcie-analog: Simplify error handling with dev_err_probe() Date: Thu, 10 Apr 2025 19:03:18 +0530 Message-ID: <20250410133332.294556-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250410_063405_419545_7EA98A5F X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c index ae898f93f97b2..c0ba2852dbb8e 100644 --- a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c +++ b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c @@ -200,7 +200,6 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev) struct phy_axg_mipi_pcie_analog_priv *priv; struct device_node *np = dev->of_node, *parent_np; struct regmap *map; - int ret; priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -219,12 +218,9 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev) priv->regmap = map; priv->phy = devm_phy_create(dev, np, &phy_axg_mipi_pcie_analog_ops); - if (IS_ERR(priv->phy)) { - ret = PTR_ERR(priv->phy); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to create PHY\n"); - return ret; - } + if (IS_ERR(priv->phy)) + return dev_err_probe(dev, PTR_ERR(priv->phy), + "failed to create PHY\n"); phy_set_drvdata(priv->phy, priv); dev_set_drvdata(dev, priv); From patchwork Thu Apr 10 13:33:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 14046546 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C17F1C3601E for ; Thu, 10 Apr 2025 13:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ie2WYSBT3Vb3/RLr/kVYn30UdEBVb+2bXcwDKP51ids=; b=X4xpxUdIqTE0T1dw7UnlY+8hEG QnxVlyBIUINlrFKpnCCYXmfCql3zWzQWhAk9maj8+6+JVwfU2Y75/H3cVTA842+LqaFlY14D4n+D2 bzR4jLRKPeVY1KTvH9zL/QO7S4WovOVmXNcJLtcTDSav2dOuPfYw+1sAWoP/uR1ZcGUuvXzno1tEK ijf/EV4kpE9LdWxw2j6Evyf3OXgZXbPp8Fcn6VWGfIPEtimfOpmhc6bLWteu1HchAR+llxJ7bTNfn 6nPvSQWhekyvhIFa7GEyTn3o4TPsFNsvuCFuoWZOUVtr5uQtDvZR6426xzg1m99J/S3GyD+5+HmRf 2N/HdgvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2sBr-0000000AiTa-0IQy; Thu, 10 Apr 2025 13:43:35 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2s2k-0000000AgSl-32ap; Thu, 10 Apr 2025 13:34:11 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-226185948ffso7990835ad.0; Thu, 10 Apr 2025 06:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292050; x=1744896850; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ie2WYSBT3Vb3/RLr/kVYn30UdEBVb+2bXcwDKP51ids=; b=Z0uTLtKMfp2KJZCjgE2Z0HIRDLx8rDn/RvDEKQcHLCiAuGdz3KxBiw2nzuF2DrN0fe RVJA34PitYCZjKKFGDmtlFHJVs5guHguTxEI840e6HbDYpdZ2FCE1xwNO0q5PD6j4AG6 c3cI7CcjU2YIfQaq+lftDucrOzgTqz9yQTdNf7lUAnZCUVkwk5lOi9ztke3tFBXp5/72 PJsjf/DLrUoaQiAKQMIY1XBeZCABTmZG0mm8ntpE0HIVkwTjVJaeeK6O9tQ/cQHdrmJT KwubOPpCLr6EYmXrpxlKJwpT31IyUNq+30REiH0VtEtl5iu4wOXscrFNHkXbITJMrHPc mkeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292050; x=1744896850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ie2WYSBT3Vb3/RLr/kVYn30UdEBVb+2bXcwDKP51ids=; b=E1AkkoEy6invfKRo2EqPBGg6GTjUzC32ikxnI3E5TOtTvBggR+0M+Wm8SjQer57t4x hnAUFG2yfPftNt1VS8lP3oJJ2zEkD8kBazrAQIzluLkAcZdo0OO3tymmqcwHP+yjCoi1 omeRuljI8FNReq2GEEWovUAwtGB9HNAPVjvI6DagSeA1xch6oeKe0mYNREkNJCUjtpK+ hDPlqqRV89x4Ba2GJSct7HaK9aPQcUrnNNoRGk/BgcFtPLF/3+W8HODj2w+OizsH15E1 QDeIb+vDF65pkzjKKrus0LbohTMu39qcl5eQJJUyQL+OoCcerb8crQTvJLXruvOU5nMe W1Qg== X-Forwarded-Encrypted: i=1; AJvYcCW+NLLujsZzxCn77DSss8oUJEB+zNsy4uP/G7z98avrR69XePCO8aoQuCxqCxt3tyCN3CQjy/rF/wxgWDH3@lists.infradead.org, AJvYcCW9CbNZoK7av/92zaribcsJKEde5e9yc44wBKI37DiyEs7vvOzg99gRqQQCw5xOjvVHkV5eEpIxA8He@lists.infradead.org, AJvYcCXsiWlf+oBBCAPL2JVPVOfdVW+0+AHxj58602e+pjkuorve78s6Zz1Ni2MeKKQxz32WjMqr9yQ5y0aTG+sfvZ47xw==@lists.infradead.org X-Gm-Message-State: AOJu0YxYfV5PxHMf5ATl30ArZ+avraK2oZdvcSgBhnNRPvr3jswfXv5n gmcyBM88wq8XHqjGnvywxrhbFS7DaGG352sEonAqMFyOC+1PxWES X-Gm-Gg: ASbGncvv693ACKDOHlCatYbg8pA399UqH2U2YTJensWLqPSnVnc1Ygcvtfe18EjzTXa Tfi8ICftgIllpIxRI9Px5em7ffeu3D7i9L8OcObQdBCyxAQdetjOtDvY6UqAZR46PBO+A/Pz++P 86ESlAANIcl3qmrA1ZSu/t6S+i32h21TdtY8HIQW0OYWM1RZGK+zSIx2SnVu5RBJGjTLzvQVnoR Rpoj2k5MZbv0/aC+FSYK36W+9MUcIgjI4OeMVHx/tJe8WDQCPfaXdS+DeNaLyNBBwC/Dlbm6NmB SUSyb+92PWrJZXQJnn8/+O7aZ6N8t6h29/NFaWc1/wZkSYVp52uzvA8= X-Google-Smtp-Source: AGHT+IFebE9GR8x4kSqiJ5cenp/8FxgShjyDitPJ8W8qx7xYFtufybCnsYQR0VTIIrJFw2c46H3Qfg== X-Received: by 2002:a17:902:d2ca:b0:224:c46:d167 with SMTP id d9443c01a7336-22b2edceda8mr42616955ad.16.1744292049826; Thu, 10 Apr 2025 06:34:09 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:34:09 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 4/6] phy: amlogic: phy-meson-axg-mipi-dphy: Simplify error handling with dev_err_probe() Date: Thu, 10 Apr 2025 19:03:19 +0530 Message-ID: <20250410133332.294556-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250410_063410_760165_A0CBD138 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c b/drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c index 08a86962d9492..c4a56b9d32897 100644 --- a/drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c +++ b/drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c @@ -377,13 +377,9 @@ static int phy_meson_axg_mipi_dphy_probe(struct platform_device *pdev) return ret; phy = devm_phy_create(dev, NULL, &phy_meson_axg_mipi_dphy_ops); - if (IS_ERR(phy)) { - ret = PTR_ERR(phy); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to create PHY\n"); - - return ret; - } + if (IS_ERR(phy)) + return dev_err_probe(dev, PTR_ERR(phy), + "failed to create PHY\n"); phy_set_drvdata(phy, priv); From patchwork Thu Apr 10 13:33:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 14046551 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C4D2C3601E for ; Thu, 10 Apr 2025 13:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DxeSbPIzszjGnSvrpOvcwkfeAlvfBRAjswzSiZSoXzQ=; b=UOpWC2fCD9YVTJYIC33NNgsx4H Q0mNoFgiGVrGZ3YwWSNgSDbNnXPHgQitK4/F1D9t0eR2IauNGgpeNNTwHzjzOWjQ3X4Rq6QTThoQa ufoReoPnSCAC2ysNuzQ8OYosyI6vyif8fpm5jQvdZ4ypQ3Biu45H9yHkvdASS0Zz+9iBsGTOD5cs9 QP04mKdi51z0aL4Ze7n/nW8/5nSEdMXky03JB0dv3AbsXXe3ZAPA//AGP+C0bBJtNEfT3WPIE7DrJ zUxcXBDxLdhYvuvxVluOjtoGDLF5mXMNBoC7n6f6zXzDCZ7dKKG8QI9sv9eS8ln1KYHTjIYqlCcz9 1SqixbaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2sDc-0000000Ainh-1Zbg; Thu, 10 Apr 2025 13:45:24 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2s2q-0000000AgUf-0yw0; Thu, 10 Apr 2025 13:34:17 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-227b828de00so7130445ad.1; Thu, 10 Apr 2025 06:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292055; x=1744896855; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DxeSbPIzszjGnSvrpOvcwkfeAlvfBRAjswzSiZSoXzQ=; b=Hhc03LzK+W0yNWepbpr42cL8t6yBYcTKUuykOLbcWPOTWylXSx4nxzWKkIejaPQVR3 iPdITyYHTcn/CqJ+Jd/+TYwSBOCLFxKNctMUh6KDCSioKbaeBoNM8bzEAizDdl3l8XCh GgCrpmsGevMa5tW2R5JBJ9iydzYeG9y/yaD9BRHuMj04L/462K/0TglSj30emgKH4uuZ mk7jy3XXFH3rKGPLG+ll9h+H//7UmFdBV6uw8sLipA9NrD9lmrYfanbIaUm5VduWmgow xEZczEnXvaFMpjFiwJfzQ1QLsdZz11aJaUHltlGrbTnva2YqyfYVLsW0fSCj7uEaq39u yz7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292055; x=1744896855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DxeSbPIzszjGnSvrpOvcwkfeAlvfBRAjswzSiZSoXzQ=; b=tLxUQLUnsIc9UxDuCgDJssOEU0xABc1CZRgEZIJMWyxKEY9eIBJEvdo1m4bhqW4tVY H5TVTaqhJWiLuE2MlzVuujUkD6TfDswlp3gy6RTLSyrXYpAxLByanNzlKlkbYGagdtU8 RZP3zHjfBvVuCZ5eRVGwyWHnvl+JcGtJzPGP6Z8fYsBWpjPWsJhlsY81VVAUPngfvLWl BtG4hz97zhIh2zcrMWcrmtbWyk6pWzJsf9viZcjC4zdQDpuD79obgcUWeDqC0s2ZOMSH +/5sZDXJ1k749Bpkb+Zcs5qPMedGa71ywApWQ8qzSgkecZ2aSfTbybBlI1uPD0zzl0Oo 2Skw== X-Forwarded-Encrypted: i=1; AJvYcCUrAgRWpLfSQ60hX+M4sq25CVtwyb+PO9fdmBuLJ/w76tPZcLRwy218pwu0dzhHgzeX/gJ59aRBh7P3nFjOTpCDXg==@lists.infradead.org, AJvYcCXdCGLASozgdCbNCPUE7n3ajzTMWLQL/2zNSSU+cJ/QBwM7oAOUOmPM3Jr5i2bsd/rcXVjUfwwYinEm@lists.infradead.org, AJvYcCXhk4cy/20/dkaaNJgeJNETBssD61MCkSpqMXdkjgWTNFr0NO9xczdmEPrTXzRZe/+GiJJ+SQjOPKeJn/pC@lists.infradead.org X-Gm-Message-State: AOJu0YyNvP8e2lsJ1CW4zNXgNaV9ZYdBOIZ4Zn3KWve/JopOsoRuN+Zt MGOqapzp/L/YW2nGkz0FNNw2IyBQ461i4Cwk/pKbuHLuiSCDHewv X-Gm-Gg: ASbGncum2dw7FIWNSxTiuswiGVhfd4ChQNf7+7EqmWzgNYLs2IZ14vGlgKG12Vpf1Zy qi8NmjkMBh53Qkn3oO+0DYVY1/KBwsEnVd//x4zczObDUQHuzgGbsMtAL1TvM74/ujARVOEs998 a1cC3SAA46F/mWYGam0dWTRfZ1RUsGahmCKV7GCQWhi1Z2zYM1VizSCDlDKvaol40CovbwtuKAr lBpx5bEnA/J/HOXsy2QoSREwE0nA9ghW6sNUyupE56vPNF9E30pV4klU6XXRv6OsPmVOF4O3R3G 29CaPw4is4F6hInjDN2yR2yUNfiVR68xcaDyz67IuabSH685edVmlW8= X-Google-Smtp-Source: AGHT+IFfGKT+CjmFhjdjDFWm//5beQJ4RbUV7i3qqJwAHO8GX2iN4WUrgtrevE+4mbbu/BuXURpkQw== X-Received: by 2002:a17:902:ccc8:b0:223:3396:15e8 with SMTP id d9443c01a7336-22b2edd1cb9mr51008155ad.22.1744292055287; Thu, 10 Apr 2025 06:34:15 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:34:14 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 5/6] phy: amlogic: phy-meson-axg-pcie: Simplify error handling with dev_err_probe() Date: Thu, 10 Apr 2025 19:03:20 +0530 Message-ID: <20250410133332.294556-6-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250410_063416_273731_5EF8313B X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use dev_err_probe() for phy resources to indicate the deferral reason when waiting for the resource to come up. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-axg-pcie.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c index 60be5cdc600b3..54baf7b8930e1 100644 --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c @@ -131,19 +131,15 @@ static int phy_axg_pcie_probe(struct platform_device *pdev) struct phy_axg_pcie_priv *priv; struct device_node *np = dev->of_node; void __iomem *base; - int ret; priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; priv->phy = devm_phy_create(dev, np, &phy_axg_pcie_ops); - if (IS_ERR(priv->phy)) { - ret = PTR_ERR(priv->phy); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to create PHY\n"); - return ret; - } + if (IS_ERR(priv->phy)) + return dev_err_probe(dev, PTR_ERR(priv->phy), + "failed to create PHY\n"); base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) From patchwork Thu Apr 10 13:33:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 14046552 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96F4FC369A8 for ; Thu, 10 Apr 2025 13:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=snDm+R9HSu34qLr874FxLnOvyHahTzryBYCxyI70mec=; b=zVY0JVwzOTf4zfG3YiVha5Pn5c dkc3RXa21OotrPLxOizSF/01PFJQh5Sb6AgupIxWrXNWpUdXqsLYffJwrhCnp23tizzoRT03qCyxI qJLK/L7cWPxhWBkQdifUfsFCMc5izxYNhDgWzc0WWpso/dv7RTiEBXMCb5LZMyk+Q6uY3shLRyRJM Tiyp8hcSuObdJ1Uj2gbG4zbEeIQQFhse32s4ItZtW8UQ2KgLl9P3wthdM+qiTsi7W172YDqCTu6IX q1MiKcxomk+fO6qrzZVy09663n4u+nE8SXuh5r0hgiGYyaVDXE6mjW2b3RS216jvwO6Me0w2gA5YL u727DnMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2sFM-0000000AjFL-3A9R; Thu, 10 Apr 2025 13:47:12 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2s2v-0000000AgWx-2qRz; Thu, 10 Apr 2025 13:34:23 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2254e0b4b79so10495835ad.2; Thu, 10 Apr 2025 06:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744292061; x=1744896861; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=snDm+R9HSu34qLr874FxLnOvyHahTzryBYCxyI70mec=; b=UEzqj60Zh+PhpdILO3rFtG8tkeg98HbFt65EGvFdk3H2mx2GYxM5zt11Iui5aHO9X1 99S0WwdtUT1CSYjhfEQGeANf5Kjnadwt1dG5a1IzF/OLWZ0BLpw+cLS2KRdxLOwpSZzv YYq8I+s6AKXCy9gAWfS243ZigxPtFt07rd/JgTlsVDQDY+5EPyv9yMK3SYL/bu+S5zub mDXzGUWF8SS5q4ybHcL6x1DfWVkObnQrt17Pa1W/+0SdRnZIk5VpXa+6bDCi5IUxe5HX U64VSmcfvWn5CgkP0bqgu+Yz1ywpLcxqDlhAO34RllsB90gQsuFVakASwQrTSzNs6u1+ 2bkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744292061; x=1744896861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=snDm+R9HSu34qLr874FxLnOvyHahTzryBYCxyI70mec=; b=qkkfuFG2qH8venFjfqzjyQa9Zo74Aw2qYfgUfR4M4AbwoNzAvpfqpgA0KU9UsPJDBj NDaLWKOiYYPTgBATb0oVxJe+N3yqqiCTdxVYCVNpduG1E2fE5o194HKchsAIzLwr1kXI zqyyHwb4bOKDqWRK+BtnmoMXlcjOHui0EOcj+NTwdO5D+Jc0gvbzCSkF9+o/s98iywpM B4oZqeepwyEHPd3O7zCUDG9MNfASc863CBQuOI2tzjgIX7Gzn4cmTwia0i1tCrrJvaBk 2VphbyFKrYU14WxV3+1OAidLVNuDTeuzzi7AHJLXCIlL39rUPN7dGMy3fKwsiUXTNBRy 8wQg== X-Forwarded-Encrypted: i=1; AJvYcCW7qA6aStfpIKUiWLLf/yMuGtXkZmp/zrQN1aLBLxwZggzIvZay2u00XmM2k2r1P5dFqBD7nnXofarO@lists.infradead.org, AJvYcCWHUNzTWSoyBY99r1/dt5e3GWav+kE6NJUE9XgabSPnCibY/NjdaEPmmAdLIR3kGi1misSLZhz8xNcvZ5FJ8mqsvA==@lists.infradead.org, AJvYcCXxF9ydFeNp7Z9OxHVxDnjXZGDe8FdyKsipVi6ApI+k4t39tXTs1sHDVqcV++qmscuySEuZRpgQ+k0uVZ2y@lists.infradead.org X-Gm-Message-State: AOJu0YxrmehVFkTvui71DlhmECMHayFx4dAWpyVt6vgXsppfFu3E9teF KQEVubDFjFZTWGKKqQeGqvAZ9m3eL/3n7r2zdDIzN0naFUuPX6yL X-Gm-Gg: ASbGncu/SehULYC54JmdHi2YGpUBaegnwsysnx2qZPth5vefxo4LvDMLbn1QEvATAlV 6eQ8WReAHZpGQN5LDxulVhH0o3CZkn2fqmh/vANZSB7CteO2gRzty60Qjvw9HypeP0y8dIzhWfu MYqcztdFzdie7By0uJYNQy6sJEp83IHKn1ipTqj6Igqpxsxk/BktveUGa9I7KFlaBePhQrntfzR a43FvhO0ONOZnJkGmf/5crnXDxn76eTIQKZs8pXGBV0V3elbuk9fT9Q6fB5Kd9VQ8DCdQI8YgfA IA99IlTCwYCPQnmohqPPRA38fiS+gM7pbT2dJGrQ97Q95YLh2OYvxes= X-Google-Smtp-Source: AGHT+IG8FTT4kfyWPBOyAb7OIrEAVZZGG4LdxWb3S85G2ZZGHkha/cC8RTwaJM0VFBFY0ZFSfbmjFw== X-Received: by 2002:a17:902:e748:b0:229:1cef:4c83 with SMTP id d9443c01a7336-22be02d9318mr30954625ad.4.1744292060733; Thu, 10 Apr 2025 06:34:20 -0700 (PDT) Received: from localhost.localdomain ([103.221.69.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb0400sm30121475ad.160.2025.04.10.06.34.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 06:34:20 -0700 (PDT) From: Anand Moon To: Vinod Koul , Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org (open list:GENERIC PHY FRAMEWORK), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 6/6] phy: amlogic: phy-meson-axg-pcie: Fix PHY creation order in axg-pcie probe Date: Thu, 10 Apr 2025 19:03:21 +0530 Message-ID: <20250410133332.294556-7-linux.amoon@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410133332.294556-1-linux.amoon@gmail.com> References: <20250410133332.294556-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250410_063421_718121_17F65C3A X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Reorder the PHY creation in the axg-pcie probe function to ensure all the resource is mapped before creating the PHY. This change addresses the issue where the PHY creation was attempted before mapping the necessary resources, potentially causing failures. Signed-off-by: Anand Moon Reviewed-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-axg-pcie.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c index 54baf7b8930e1..14dee73f9cb57 100644 --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c @@ -136,11 +136,6 @@ static int phy_axg_pcie_probe(struct platform_device *pdev) if (!priv) return -ENOMEM; - priv->phy = devm_phy_create(dev, np, &phy_axg_pcie_ops); - if (IS_ERR(priv->phy)) - return dev_err_probe(dev, PTR_ERR(priv->phy), - "failed to create PHY\n"); - base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) return PTR_ERR(base); @@ -158,6 +153,11 @@ static int phy_axg_pcie_probe(struct platform_device *pdev) if (IS_ERR(priv->analog)) return PTR_ERR(priv->analog); + priv->phy = devm_phy_create(dev, np, &phy_axg_pcie_ops); + if (IS_ERR(priv->phy)) + return dev_err_probe(dev, PTR_ERR(priv->phy), + "failed to create PHY\n"); + phy_set_drvdata(priv->phy, priv); dev_set_drvdata(dev, priv); pphy = devm_of_phy_provider_register(dev, of_phy_simple_xlate);