From patchwork Sat Apr 12 20:26:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 14049106 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ABC3C369AB for ; Sat, 12 Apr 2025 20:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Da1KpB06Y/TqEa6ekqfV5ZuW8D2WP8Hedn0iTA125cM=; b=GQxVTjr/bz+kcA hBlz7VpYdvhtbsUvwfE0LSWCtLcdslb1MlbHf0SG8o4i21BYtiJi9l7tmhVvMXfwNfGm0zU45h44q V+MuGrVNJ4/V1Kc0LIVWceU/AmZXwSd7gEUdyYT5Uf+QzjP6SF0uZveagrKHWE6A+OMCO2bykY//R jvBxlhio6GJPS3tAMDSUd7grneGJIZg1Y3oZnMxZN7Nazg5MRf3r3YXlczfnZy3hjFw4bBs0R4OG1 xCjeBEmo8bKYZXbRIoJliuWmnNUONnQvm+ejeaSHOJL55B7Zhj+G1h0JWB6TFwtqY/HXqvmvNcV+l i+I+ZyBAxZw3odjFkxtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hTA-0000000GPNb-0nUS; Sat, 12 Apr 2025 20:28:52 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hRK-0000000GOyy-32ea; Sat, 12 Apr 2025 20:27:00 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso23566305e9.3; Sat, 12 Apr 2025 13:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744489617; x=1745094417; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LsQ/Xff2+RA/VYwRRvqpIoChOLpkXdtKapMvgQDbuBs=; b=Yp+BuBdXuZNeD+8N0gH11Qw6Q/aTvxJ92Acdjw8byyIi9T3prNXMzVtVdJSACAiaXQ QEqrrB89IEQ7I8LimwckV3KZcnfBAufH1TOC0tMikRRVPzg2PDlKbDEZ9XAFk59Ky5EJ hjyUOPUwxYkh6eO7ISDbMudn704D0C8GLwif2+wUwet1NRprZVQmqChT/Js7Z7/w2HWb p4nnpJLlQTVEwQmmbus7TfpTUkOMqmimAk4yj2SH+2ml851IiUK1cgZ5EjgqXxctSNB7 chy9ilHv0UN6nm5dc5WsxQVZt+J1J7/TMn2FtRWRs1dwYoitkJqiDf6TL+aeExRpC5xp bq1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744489617; x=1745094417; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LsQ/Xff2+RA/VYwRRvqpIoChOLpkXdtKapMvgQDbuBs=; b=P0iX9gYFxcuht7AJDvHyoPvKbL+AynA9qE6cd8hkqEf58xJNyAzBfDyf5WT6uM+oaW v8gDFvGYxhU4nOQaP6itNUBaA2QvlY3wnRFKzhAKXXuRAuhDBb/NAT9U7X1FZFptSi6y uXOFqHyjwrKOLym9uGNtpyX8Ml2Szuwfv1rRhDwnJfgn1hchCzVPHzv03hLr1mqXjppv 1ocsv0bqEA8fdPzaA7kYBpfFxAF8aIcx8wiWnCu6decPFEeErGskB9YFN0ud+kr7d5ns voTu4D9s/CZHnYWIj4gC6YJAf0+FZx092p2bkealDWElxQ+5nRcrrZWNbMeYIZsqw5+f AXWg== X-Forwarded-Encrypted: i=1; AJvYcCUyZjA6JgHLRzW4GAhIx2+I4gvcjD8raIoVZPBQEqHcn2FPMTTJSmqcsSAaw9349xamxTYSwr+SlYN7@lists.infradead.org, AJvYcCVgj4TbpCwOAVg8PnfHsf6jVPDv9OhfubAUnTbJFPDcPcvrJm/7YYpIINqCPpxTjsWc3X/Sa2Ri9iSPQNBqWYTK@lists.infradead.org X-Gm-Message-State: AOJu0YygtFlMZ41KbkPe6XEIb89iu+k3OsZhnezwVHbgxI0takZhZnYs xOCXmILy6zsdzqbUfbOfxy8UYRDNdRRmAYtA0tGm1yGqqFtlLDHxhupXeA== X-Gm-Gg: ASbGncsRKxt0M12TkQ5kZcDJ/MmqHzdWRw0pONRIgNBIOKXCZ1g5pM+IOGt1DW3vImS WpQOtsUnFvdGLIfIUNPnWhAHwM8Gs/z9Gjtxf7N0GPAlYav84uY0eV9UaQGKYa8cde8G0JjrfGc WGZ3B3siWmunsocrEEPea6rvu5glGKAQ390L3Fq8a8wsAMaSUX5ztagbL3tocczyAb7HrrQwZfH xWLIYp6M7VQPB4k8CnK1x735vcIji272M9R+zFExcAFSiiDv0QiZAnX9PsVlDH2GE7PJtl5yt1C 5doiOcECTI3i/92CYIGlDodRLtsm3Dl5eyfvsIsAoQhuLTmnUaHVBpaYl/t6KfvQjDMedJwfvkx ITLFLE+qh4w7tfjtl X-Google-Smtp-Source: AGHT+IFP+XkFysoPsINc3NpIKIT4Gtr8job/cOX6Be9DaYeNjIosjEEY2429amZfVdkYJ3ZD3XRl9A== X-Received: by 2002:a05:600c:b90:b0:43d:fa58:8377 with SMTP id 5b1f17b1804b1-43f3a9afb11mr62712575e9.32.1744489616759; Sat, 12 Apr 2025 13:26:56 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d802sm131797845e9.1.2025.04.12.13.26.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 13:26:56 -0700 (PDT) From: Ivaylo Ivanov To: Krzysztof Kozlowski , Vinod Koul , Conor Dooley , Alim Akhtar , Kishon Vijay Abraham I , Rob Herring , Philipp Zabel Cc: linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v4 01/10] dt-bindings: phy: add exynos2200 eusb2 phy support Date: Sat, 12 Apr 2025 23:26:11 +0300 Message-ID: <20250412202620.738150-2-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> References: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250412_132658_762472_A3D7050F X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Document the exynos2200 eUSB2 compatible. Unlike the currently documented Qualcomm SoCs, the driver doesn't make use of reset lines for reset control and uses more clocks. Signed-off-by: Ivaylo Ivanov Reviewed-by: Krzysztof Kozlowski --- .../bindings/phy/samsung,snps-eusb2-phy.yaml | 79 +++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/samsung,snps-eusb2-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/samsung,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,snps-eusb2-phy.yaml new file mode 100644 index 000000000..09d3fdd4a --- /dev/null +++ b/Documentation/devicetree/bindings/phy/samsung,snps-eusb2-phy.yaml @@ -0,0 +1,79 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/samsung,snps-eusb2-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SNPS eUSB2 phy controller + +maintainers: + - Ivaylo Ivanov + +description: + eUSB2 controller supports LS/FS/HS usb connectivity on Exynos2200. + +properties: + compatible: + enum: + - samsung,exynos2200-snps-eusb2-phy + + reg: + maxItems: 1 + + "#phy-cells": + const: 0 + + clocks: + items: + - description: Reference clock + - description: Bus (APB) clock + - description: Control clock + + clock-names: + items: + - const: ref + - const: bus + - const: ctrl + + resets: + maxItems: 1 + + phys: + maxItems: 1 + description: + Phandle to eUSB2 to USB 2.0 repeater + + vdd-supply: + description: + Phandle to 0.88V regulator supply to PHY digital circuit. + + vdda12-supply: + description: + Phandle to 1.2V regulator supply to PHY refclk pll block. + +required: + - compatible + - reg + - "#phy-cells" + - clocks + - clock-names + - vdd-supply + - vdda12-supply + +additionalProperties: false + +examples: + - | + usb_hsphy: phy@10ab0000 { + compatible = "samsung,exynos2200-snps-eusb2-phy"; + reg = <0x10ab0000 0x10000>; + #phy-cells = <0>; + + clocks = <&cmu_hsi0 7>, + <&cmu_hsi0 5>, + <&cmu_hsi0 8>; + clock-names = "ref", "bus", "ctrl"; + + vdd-supply = <&vreg_0p88>; + vdda12-supply = <&vreg_1p2>; + }; From patchwork Sat Apr 12 20:26:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 14049130 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C1C8C369AB for ; Sat, 12 Apr 2025 20:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wz+Cm32pQQvr01Iry0xUfha648xBCnIpIxud9WZ7WeI=; b=l+fpXHq9Ka5NbP 9XfNiqIpfpHK5Y6jPZ4tsvC9KEV519Ui7bSNXQ7WWfEa/OySyW7uqSUYaVRYyYcMTnRiZUbzGWdw+ ArMqYVf4Q1WLPicfOIviggArDFzaxFuezFkWtxXrHFkG60xEj9xJZnnfp21p0kk+YEKLdGaVXI5Vs T1bz0dWzgNQ3NZyaDxtZiPhsMg7oUuohK05hipxbl39G0NgTSNrC28deGdKvmD1JGCF1ZTMOchkN9 SZYvwdDHKrS3AUnR4QdMfjd2mzcnGvbIml6yVp/4Tn0eg7KZKnBpjblpxxEheFsGJ4UE94dB8i7q7 VL+YRO6L3fxufN14Nq4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hUy-0000000GPfy-0ofD; Sat, 12 Apr 2025 20:30:44 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hRM-0000000GOzS-0Vih; Sat, 12 Apr 2025 20:27:01 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-43ce71582e9so24848415e9.1; Sat, 12 Apr 2025 13:26:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744489618; x=1745094418; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FGZMdc52q13yeO94asjBB7hiXHPLQfLBvZpzYqeIrBI=; b=ILoaOZaoHasdiev1HqP34NNBIFaZiqFT9hIfhZ53Ayyr3gRpWN0lTonha6W28gAQKG 0WMKM0bvBovqhewYcz9ASxlxqGobAQVFid5yjrUyICkY/k7zJtyPAKEcTAGZ8MXLtoVP Evwd+X7UV6fxx9KsidjkTHKHzEdQ8EpjV8VJ9HJuyBpaPAfQiVPgxabSV14XuWWtcQu/ V+7489lJxGWbABOQbOt2LCL39IWg5Xkp64lgBjoHHhIU6tqFxVU+UIgIri02Ba3xqHr6 8M3CWkl9EaN3c5m/FYWf4AoTuJlmQOQlEpafCM9TC2KhLQb2TB3zNuksyK1WvlYNm+wu 1d6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744489618; x=1745094418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FGZMdc52q13yeO94asjBB7hiXHPLQfLBvZpzYqeIrBI=; b=eM8iax3e6oak7xjUTIIVRQWOHgVJkPE9oMzlyJB2Ll8rNrdpKPzA9gGSUU3WlGcd57 NVadFSBSVFAw1CsbUDQiznuTy/4nuvm8x4wLESA6h8ODliDkM7NK3n6rp7kdoGT3lD+v 6IvUPMCj88fB0lFRiE9huSbsogbo+pf+AbnmFC0dG+5//OgJZXu2qB/OVQxyP40trSgK I8G8C4aV92qwxoIxWLv9Iylga9FmiwrpkxZmez//slDcLCbqUi5gO7jkp+9IEcFZkLyb qbCMSpHFqGbcFtzdQe/UXUhNv3CWeY1g8TkZQBWiBqNnvSQ39QMU/TloL7BG/hD0WvQA 4wkQ== X-Forwarded-Encrypted: i=1; AJvYcCUizQJqgmOuWv6hGCbL5FxgEEbRhypGKuJ1hgedjnI+mLC7mQXgWnJpWEP0vfYHrL40HxPSKqMFWkBA@lists.infradead.org, AJvYcCV2xQglclYDS8U35+51ehbJ+Mt8//JIcu+hoDWF+nHAus3iSao5VJR/2z5r5+7LV4+Niu9jLmIfiVrLx/tee3DJ@lists.infradead.org X-Gm-Message-State: AOJu0YxyUK4USACIUjh2L0yfRrMRp7GxEb6CSKt+tbrE9VGWSFBPbQRv WZDkVLKcvlNM1rHjeqJ/NLw0ZmuUxJ57HA1MaVBdhjozuO6dtJos X-Gm-Gg: ASbGncv+0+bUEhrrZ7w/iuIslcG7lui4xrmwbjVIS0hcMBnxrqG5TIDXod1S2k5bPmN bYU6vm1UaCeBU0UnziFQ0Yjanv7bS5FK8Wz6AjCsKQUOe+p0qK58eF+Ql5tC4l6RJ3CqymInzGY epiAbAhDYPSt1gk6I6GOTuywtuxJmw8lWaZKGIHrVoarYaUkKgcS6MTAuGn+rRcNzW8BaeYQaXA 9T9ea7qdMnNRjm0GjjefZSGqztYo9ykWha+CaTpGr8e//HBTYdUhg6l3mJxbACefbTlyfyUK5/9 SDbkwUpu7j3n/kQNA5YKz8/IH6B3GCqYwJoLLQO3wfTbyBRRqO1VZQTIylGY4YRzFqaxUOPQYf0 pYfguEJUjihB5P0EI X-Google-Smtp-Source: AGHT+IGx6h+geTf/v9W2DKJjLgpVdgmXIoVjN4mCIjEb6l8h9zRIXZaS88d0GwzNPTfrjVbCyUePFg== X-Received: by 2002:a05:600c:c06:b0:43d:8ea:8d7a with SMTP id 5b1f17b1804b1-43f3a9b00c2mr60408365e9.28.1744489618240; Sat, 12 Apr 2025 13:26:58 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d802sm131797845e9.1.2025.04.12.13.26.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 13:26:57 -0700 (PDT) From: Ivaylo Ivanov To: Krzysztof Kozlowski , Vinod Koul , Conor Dooley , Alim Akhtar , Kishon Vijay Abraham I , Rob Herring , Philipp Zabel Cc: linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v4 02/10] dt-bindings: phy: samsung,usb3-drd-phy: add exynos2200 support Date: Sat, 12 Apr 2025 23:26:12 +0300 Message-ID: <20250412202620.738150-3-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> References: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250412_132700_171138_3E9C92AD X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Document support for Exynos2200. As the USBDRD 3.2 4nm controller consists of Synopsys eUSB2.0 phy and USBDP/SS combophy, which will be handled by external drivers, define only the bus clocked used by the link controller. Signed-off-by: Ivaylo Ivanov Reviewed-by: Krzysztof Kozlowski --- .../bindings/phy/samsung,usb3-drd-phy.yaml | 38 +++++++++++++++++-- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml index 27295acbb..4506c5801 100644 --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml @@ -26,6 +26,7 @@ properties: compatible: enum: - google,gs101-usb31drd-phy + - samsung,exynos2200-usb32drd-phy - samsung,exynos5250-usbdrd-phy - samsung,exynos5420-usbdrd-phy - samsung,exynos5433-usbdrd-phy @@ -33,24 +34,32 @@ properties: - samsung,exynos850-usbdrd-phy clocks: - minItems: 2 + minItems: 1 maxItems: 5 clock-names: - minItems: 2 + minItems: 1 maxItems: 5 description: | - At least two clocks:: + Typically two clocks: - Main PHY clock (same as USB DRD controller i.e. DWC3 IP clock), used for register access. - PHY reference clock (usually crystal clock), used for PHY operations, associated by phy name. It is used to determine bit values for clock settings register. For Exynos5420 this is given as 'sclk_usbphy30' - in the CMU. + in the CMU. It's not needed for Exynos2200. "#phy-cells": const: 1 + phys: + maxItems: 1 + description: + USBDRD-underlying high-speed PHY + + phy-names: + const: hs + port: $ref: /schemas/graph.yaml#/properties/port description: @@ -150,6 +159,27 @@ allOf: - vdda-usbdp-supply - vddh-usbdp-supply + - if: + properties: + compatible: + contains: + enum: + - samsung,exynos2200-usb32drd-phy + then: + properties: + clocks: + maxItems: 1 + clock-names: + items: + - const: phy + reg: + maxItems: 1 + reg-names: + maxItems: 1 + required: + - phys + - phy-names + - if: properties: compatible: From patchwork Sat Apr 12 20:26:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 14049131 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B70BCC369AB for ; Sat, 12 Apr 2025 20:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=96zhoKv3YQjAVYZSExwrbYQP8neowjmkJEX41hYgK8Y=; b=O6cXAyacXGpO5/ lBf6TaNR5Qhrd3RfxCWNMr8YM893PhjaqOFj781ygLUdShCxCxdrGeg65KJ1Ag0T5FqEt3h+FW/IF DMwmwSolZx3KqZFrAYoNaKQgmVIhAwv/Hww23QXutURaby4OpUKfm1xxmT0EJSXgwGyULlknzyyTs JFktgYp1iE47j+/o9HQ9oJqqJSz16thfc+ZoPIKjaDvBcVM4Q7FnuxzgBIz77tPjkREmTCrV0EMaQ +XlJR9LI2AOaXMt9aJO0dRXLh5yLPGARwMO+TvCcvtWmGzoT/20oBtM7+0q4wY/cbsa+ZAImoJhpj rsuapBxRvT1JyzyGQADg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hWl-0000000GPxk-23ua; Sat, 12 Apr 2025 20:32:35 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hRN-0000000GP01-2Fu3; Sat, 12 Apr 2025 20:27:02 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-43edecbfb46so21564595e9.0; Sat, 12 Apr 2025 13:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744489620; x=1745094420; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2usqzIFp+F+sor9mgGvMP54EUED928aPFjm+huTcOyg=; b=CpdhtK8bLvL2IxfpF7hpFUvMSh5SEqWKi91XCK3E8LAO7gFViJXCZFid6GfEzH11v4 MH9xE+9xs045thuXWRpCS7Z4YW30cfyTBUdTeQUTArBffV5LFmAFPINQNu11kqvx5J2i 05Jfu5GxmDliH3kejADrEIGVVG7qxP9k3ZcWwYTLjjmfk0mYmr5LxQwHP4VTEQBthKAf b6GI3e6rfXmi4fZYb5h8+6U3zv3+ePp+DvdXjIWw5dTq6+CRWSgnqRRU8vLtLFSp3RKf 8zdWLE8wJHJHwNsui5E+f1MdEZbm+c4elbw9Uc3COSOs3eJzYHRXrEtObO5hMKbOQM9D CHbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744489620; x=1745094420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2usqzIFp+F+sor9mgGvMP54EUED928aPFjm+huTcOyg=; b=spyuIXr58KM2JKe9AvaLv+3ArQu3NubNe2/QnctbHdi0mve1Tu7PQ7hCiJpHA4Fd4o jBTfY0vdGdm9yOUHNArWXeQK1IyWUzYOPgk9iTKuSXGe5eOx6vsr3jFTjF9bIv57KxE+ JBWZs7ELDGgi5gh1GLZ0y74Dm1Ll2upZjwR4J5WyOLxgQiUNc68cBdZOn+Xx2UPTewxH +JL7tcaby259lVwypHiUDX3+1smqdW0YVc4xt/L/QwRuRwEy0/O2/OSED1Ptt6deUdCT BfvTBVj6+hS3hof85DG+PiIrm8ufkASQrfN5rqEFB6YpsR6FSoMlSpy0DF7KC7D7EP5N 8wAQ== X-Forwarded-Encrypted: i=1; AJvYcCUBAUlojjgiQYHR3vsaIQqOyJXfoS/wJcYHXMMH4IT6blpE3mOcONt6KyTYy+BPf3OMzGvR0KjjmtDW@lists.infradead.org, AJvYcCXyNzlrFUlbwtQivMhDyXFrvJdp88Mu/OvQ9iVRIqd/6IcRdH2EtxUijBJS4LUu5nnkr4R5Zr2jRa91rWraY4Ud@lists.infradead.org X-Gm-Message-State: AOJu0Yymux/ta1oWz3r0py9c3dT05m25UmY7LC26IL0rmSfpRnjxuSaj 66vJzNINmTJBSrJ0FhX8Q5jkq00hK9p02IIxPHBJoCyWFPu7nAIkrMyQzw== X-Gm-Gg: ASbGncsZXHpor5GH/qOzlkyjbha7hROpEZQD/8qI9bqkwHpWVWxRBkERFK18qRUXzNN h8SnHOuizZRRYi1Ccxu2P+sU7EaneGq+mivyOSqS6AxrzVpRJ0W7JEVYP1QWDRsoCEi/Rmpv4Mn AkzifZbfTuod0Din8KVGa0OPjy4ROt389onxUQv4M/VGne4onidcHyVLhh3lGcSPns19dwxV8DJ lnZZWJrtCAiiOnN9Mtv0FUHQb8cjIJYK5C9ICafaLOvlhCPr7tjJQwO6K/pI8w8aXg+UgfB/sx4 ThQ+KCUpilGoeLJgmAW8Pbz/QAIR9xjDOowTTxVHK209Zf/oyIwSm5yvWzbQ5mPNVh3cWBXgQH5 QpSLsUuFGBsqTiy+B X-Google-Smtp-Source: AGHT+IEah7+QhHhcMI502D3K184AdzgML6oZ4zalt7NAyqUNE6otZecWQFpnPiMPSdxHbSRclrEr4g== X-Received: by 2002:a05:600c:5107:b0:43d:4e9:27ff with SMTP id 5b1f17b1804b1-43f3a925477mr59707825e9.7.1744489619878; Sat, 12 Apr 2025 13:26:59 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d802sm131797845e9.1.2025.04.12.13.26.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 13:26:59 -0700 (PDT) From: Ivaylo Ivanov To: Krzysztof Kozlowski , Vinod Koul , Conor Dooley , Alim Akhtar , Kishon Vijay Abraham I , Rob Herring , Philipp Zabel Cc: linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v4 03/10] phy: move phy-qcom-snps-eusb2 out of its vendor sub-directory Date: Sat, 12 Apr 2025 23:26:13 +0300 Message-ID: <20250412202620.738150-4-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> References: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250412_132701_590096_78A7CCC8 X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org As not only Qualcomm, but also Samsung is using the Synopsys eUSB2 IP (albeit with a different register layout) in their newer SoCs, move the driver out of its vendor sub-directory and rename it to phy-snps-eusb2. Suggested-by: Krzysztof Kozlowski Signed-off-by: Ivaylo Ivanov Reviewed-by: Dmitry Baryshkov --- drivers/phy/Kconfig | 8 ++++++++ drivers/phy/Makefile | 1 + .../{qualcomm/phy-qcom-snps-eusb2.c => phy-snps-eusb2.c} | 0 drivers/phy/qualcomm/Kconfig | 9 --------- drivers/phy/qualcomm/Makefile | 1 - 5 files changed, 9 insertions(+), 10 deletions(-) rename drivers/phy/{qualcomm/phy-qcom-snps-eusb2.c => phy-snps-eusb2.c} (100%) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 8d58efe99..11c166204 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -43,6 +43,14 @@ config PHY_PISTACHIO_USB help Enable this to support the USB2.0 PHY on the IMG Pistachio SoC. +config PHY_SNPS_EUSB2 + tristate "SNPS eUSB2 PHY Driver" + depends on OF && (ARCH_QCOM || COMPILE_TEST) + select GENERIC_PHY + help + Enable support for the USB high-speed SNPS eUSB2 phy on select + SoCs. The PHY is usually paired with a Synopsys DWC3 USB controller. + config PHY_XGENE tristate "APM X-Gene 15Gbps PHY support" depends on HAS_IOMEM && OF && (ARCH_XGENE || COMPILE_TEST) diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index e281442ac..c670a8dac 100644 --- a/drivers/phy/Makefile +++ b/drivers/phy/Makefile @@ -9,6 +9,7 @@ obj-$(CONFIG_PHY_CAN_TRANSCEIVER) += phy-can-transceiver.o obj-$(CONFIG_PHY_LPC18XX_USB_OTG) += phy-lpc18xx-usb-otg.o obj-$(CONFIG_PHY_XGENE) += phy-xgene.o obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-pistachio-usb.o +obj-$(CONFIG_PHY_SNPS_EUSB2) += phy-snps-eusb2.o obj-$(CONFIG_USB_LGM_PHY) += phy-lgm-usb.o obj-$(CONFIG_PHY_AIROHA_PCIE) += phy-airoha-pcie.o obj-$(CONFIG_PHY_NXP_PTN3222) += phy-nxp-ptn3222.o diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c similarity index 100% rename from drivers/phy/qualcomm/phy-qcom-snps-eusb2.c rename to drivers/phy/phy-snps-eusb2.c diff --git a/drivers/phy/qualcomm/Kconfig b/drivers/phy/qualcomm/Kconfig index c1e0a11dd..ef14f4e33 100644 --- a/drivers/phy/qualcomm/Kconfig +++ b/drivers/phy/qualcomm/Kconfig @@ -125,15 +125,6 @@ config PHY_QCOM_QUSB2 PHY which is usually paired with either the ChipIdea or Synopsys DWC3 USB IPs on MSM SOCs. -config PHY_QCOM_SNPS_EUSB2 - tristate "Qualcomm SNPS eUSB2 PHY Driver" - depends on OF && (ARCH_QCOM || COMPILE_TEST) - select GENERIC_PHY - help - Enable support for the USB high-speed SNPS eUSB2 phy on Qualcomm - chipsets. The PHY is paired with a Synopsys DWC3 USB controller - on Qualcomm SOCs. - config PHY_QCOM_EUSB2_REPEATER tristate "Qualcomm SNPS eUSB2 Repeater Driver" depends on OF && (ARCH_QCOM || COMPILE_TEST) diff --git a/drivers/phy/qualcomm/Makefile b/drivers/phy/qualcomm/Makefile index 42038bc30..3851e28a2 100644 --- a/drivers/phy/qualcomm/Makefile +++ b/drivers/phy/qualcomm/Makefile @@ -15,7 +15,6 @@ obj-$(CONFIG_PHY_QCOM_QMP_USB) += phy-qcom-qmp-usb.o obj-$(CONFIG_PHY_QCOM_QMP_USB_LEGACY) += phy-qcom-qmp-usb-legacy.o obj-$(CONFIG_PHY_QCOM_QUSB2) += phy-qcom-qusb2.o -obj-$(CONFIG_PHY_QCOM_SNPS_EUSB2) += phy-qcom-snps-eusb2.o obj-$(CONFIG_PHY_QCOM_EUSB2_REPEATER) += phy-qcom-eusb2-repeater.o obj-$(CONFIG_PHY_QCOM_UNIPHY_PCIE_28LP) += phy-qcom-uniphy-pcie-28lp.o obj-$(CONFIG_PHY_QCOM_USB_HS) += phy-qcom-usb-hs.o From patchwork Sat Apr 12 20:26:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 14049132 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B19ABC369AB for ; Sat, 12 Apr 2025 20:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FrmgHIpXOrWWcqG+4w1MXiIpdo6jGugQ5A1zTNH2ymQ=; b=KmtvZV+5Xv+BXA DymBUY3H3kPX4m8rFoy/NDPoREA/N/l4k7JqDL9f8U/V0lOo4hAGWEnnxW1ACDivwrgx5qgmfhCY8 2kmCpTUbZUscOXL+Ur81FCvRhLq0WLbU+8tYuhvopjpepv9jBX8DyONJV9bc6WJqRppf1Mjp9LEZX tAiSRGwduZtRmgQj+gIuHRZsmr1FkO94B2IHOxM0okfn/IR1zNS2QeCeB9SslnZffWgHFKB6FX1Ts 64Mc4QQEbju2a7c2aqND3Wq6UFtMJaHc6nrGj4D+jiKTpZC+++woUwkd+c1IJSXtCf01wucUCKHqe s8Og9PMCfZ4VGL3bH0mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hYY-0000000GQCf-1sx4; Sat, 12 Apr 2025 20:34:26 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hRP-0000000GP1G-1cXW; Sat, 12 Apr 2025 20:27:04 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43cf848528aso24697665e9.2; Sat, 12 Apr 2025 13:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744489622; x=1745094422; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o5tSHqpXtWFPabFBWZB93znRyMEz1UyBewsCCfTVVvw=; b=J5t2F650YOoLVb3UnYrcKFOLxZH/PojdE7O7Sl/HUn9Uroerd8KcAfGIvkQHArxqn2 jqTBd8/xXVyDHWIFHnnUm5ZpqlrdsYp3ITHfodeBoGqbtyL72cGn4OU9ofOBp9HcKZgD xXKAyDlTTvTftDkm8iYjdbQigoGNAKVPApfOUBSW//5BLf0LCJMyiJu3FmmBQ4ikJK6i G5IEUFI/mjYYIHAr85uCaeBOhw74J7ALAIldY+GC6LFOwPKecdKoS8f9hAudQ1vtaDmw T1TsTMHQCZh2qq212GM9kIPfiaYpdyt0kXQtwqa0eEeLVW6yLeRtKGY5eYBiwyq6Kc7k ShDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744489622; x=1745094422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o5tSHqpXtWFPabFBWZB93znRyMEz1UyBewsCCfTVVvw=; b=UAoU5JWQViQ29c6MrYNODs/fUdwndKMIIGx7IU77AeyGWKmVqk1OXUM2IikzeAUQMw Kz0vVEQMXdKtdBlWnUsCY/CBKeOR1zynmzFMx+llDOy9SBWAMrMNRxPW9qwnSulC7Yae L1xqQtj6slWpOc1cq0GAukDuExVTOx/TU0YycN0wu/3g/hBwsvXGv4TERQHSMOwj3C2m 6SQPDz3lhVrjbdYztyhIj5ZTjycqSe88pXOmRBn69PnhAwsvkaS7uQGxDvcPGqSFATTj OX1hVf0M8SWBpoqBrBwWHxYHf9/DTWHo6J0Gvv7rd88OGM/tJG8yMzogr3je/odROV37 4vFA== X-Forwarded-Encrypted: i=1; AJvYcCUISq6R61SJAEbRYCBnPi6tZkz7pnZCJUgZXxfz28cMRO79kuW8o26iRaRgNqOrHq7gguk4rdb0ESVC@lists.infradead.org, AJvYcCUpJdVp1KynsngvS7aZWPdlq/J+Tf2wDbj6DCThfTjd0D9Eb5CTDwAGK9spwtFj26TCcH/w+pk8QTcHqRWcXqyC@lists.infradead.org X-Gm-Message-State: AOJu0YycwAMRFnQVUE9n4dbJnZrpOOJ7ExfH1zOr417M6C8f4KiXdXoW iplHdB3W/2rxtiPKAtTkSfDl6wap0MXyrNsVh2p3rryUi3un6mFp X-Gm-Gg: ASbGnct2+TY/K78xthtXIAGCJ2qtCPlLI5TiN+hsQaSNqvEHr+/irebJfz1hPVW6X2t WujbNxtGA9MfVwP6dyKXIyM6KwqhhKvBkR7YkW33VbrdGdQEf9XCDGgQUu+HZv7g/XK8xviDa9A 6K1idmBCKgQwB4fx85ZST1/tSeIh1o1L5q6LnX5urSQjlv3MW1P2cILOT0+X2k4R0KCZsDlYB6u 7W1rk0AO2tqs84SNvz+dymOJbrycWssXOHuCZnYtQao4X6Q4KpBaDZuZcZ1oj36WdtXzMS++1Cn Vq1wUPQ/7pEQto7xmuf3wREwxWmmqubUyri7cXkZsm/bxRBJkrxmOgwYuB/XS+2NNdgVnQOhmZI 5tRHYxiXjt0xeQQ8L X-Google-Smtp-Source: AGHT+IFGERhEFeIkVDOYD6Yzb6G2rEUf354mEF4ppJQHj7t1UF49/aGi/PdBkH1u06EYB3XnlcOnRg== X-Received: by 2002:a05:600c:1d84:b0:43d:fa:1f9a with SMTP id 5b1f17b1804b1-43f3a9aedc7mr76266225e9.30.1744489621370; Sat, 12 Apr 2025 13:27:01 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d802sm131797845e9.1.2025.04.12.13.26.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 13:27:00 -0700 (PDT) From: Ivaylo Ivanov To: Krzysztof Kozlowski , Vinod Koul , Conor Dooley , Alim Akhtar , Kishon Vijay Abraham I , Rob Herring , Philipp Zabel Cc: linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v4 04/10] phy: phy-snps-eusb2: refactor constructs names Date: Sat, 12 Apr 2025 23:26:14 +0300 Message-ID: <20250412202620.738150-5-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> References: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250412_132703_547687_FB33D761 X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org As the driver now resides outside the phy subdirectory under a different name, refactor all definitions, structures and functions to explicitly specify what code is Qualcomm-specific and what is not. Signed-off-by: Ivaylo Ivanov Reviewed-by: Dmitry Baryshkov --- drivers/phy/phy-snps-eusb2.c | 256 +++++++++++++++++------------------ 1 file changed, 128 insertions(+), 128 deletions(-) diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index 1484691a4..e1b175f48 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -13,15 +13,15 @@ #include #include -#define USB_PHY_UTMI_CTRL0 (0x3c) +#define QCOM_USB_PHY_UTMI_CTRL0 (0x3c) #define SLEEPM BIT(0) #define OPMODE_MASK GENMASK(4, 3) #define OPMODE_NONDRIVING BIT(3) -#define USB_PHY_UTMI_CTRL5 (0x50) +#define QCOM_USB_PHY_UTMI_CTRL5 (0x50) #define POR BIT(1) -#define USB_PHY_HS_PHY_CTRL_COMMON0 (0x54) +#define QCOM_USB_PHY_HS_PHY_CTRL_COMMON0 (0x54) #define PHY_ENABLE BIT(0) #define SIDDQ_SEL BIT(1) #define SIDDQ BIT(2) @@ -30,15 +30,15 @@ #define FSEL_19_2_MHZ_VAL (0x0) #define FSEL_38_4_MHZ_VAL (0x4) -#define USB_PHY_CFG_CTRL_1 (0x58) +#define QCOM_USB_PHY_CFG_CTRL_1 (0x58) #define PHY_CFG_PLL_CPBIAS_CNTRL_MASK GENMASK(7, 1) -#define USB_PHY_CFG_CTRL_2 (0x5c) +#define QCOM_USB_PHY_CFG_CTRL_2 (0x5c) #define PHY_CFG_PLL_FB_DIV_7_0_MASK GENMASK(7, 0) #define DIV_7_0_19_2_MHZ_VAL (0x90) #define DIV_7_0_38_4_MHZ_VAL (0xc8) -#define USB_PHY_CFG_CTRL_3 (0x60) +#define QCOM_USB_PHY_CFG_CTRL_3 (0x60) #define PHY_CFG_PLL_FB_DIV_11_8_MASK GENMASK(3, 0) #define DIV_11_8_19_2_MHZ_VAL (0x1) #define DIV_11_8_38_4_MHZ_VAL (0x0) @@ -46,73 +46,73 @@ #define PHY_CFG_PLL_REF_DIV GENMASK(7, 4) #define PLL_REF_DIV_VAL (0x0) -#define USB_PHY_HS_PHY_CTRL2 (0x64) +#define QCOM_USB_PHY_HS_PHY_CTRL2 (0x64) #define VBUSVLDEXT0 BIT(0) #define USB2_SUSPEND_N BIT(2) #define USB2_SUSPEND_N_SEL BIT(3) #define VBUS_DET_EXT_SEL BIT(4) -#define USB_PHY_CFG_CTRL_4 (0x68) +#define QCOM_USB_PHY_CFG_CTRL_4 (0x68) #define PHY_CFG_PLL_GMP_CNTRL_MASK GENMASK(1, 0) #define PHY_CFG_PLL_INT_CNTRL_MASK GENMASK(7, 2) -#define USB_PHY_CFG_CTRL_5 (0x6c) +#define QCOM_USB_PHY_CFG_CTRL_5 (0x6c) #define PHY_CFG_PLL_PROP_CNTRL_MASK GENMASK(4, 0) #define PHY_CFG_PLL_VREF_TUNE_MASK GENMASK(7, 6) -#define USB_PHY_CFG_CTRL_6 (0x70) +#define QCOM_USB_PHY_CFG_CTRL_6 (0x70) #define PHY_CFG_PLL_VCO_CNTRL_MASK GENMASK(2, 0) -#define USB_PHY_CFG_CTRL_7 (0x74) +#define QCOM_USB_PHY_CFG_CTRL_7 (0x74) -#define USB_PHY_CFG_CTRL_8 (0x78) +#define QCOM_USB_PHY_CFG_CTRL_8 (0x78) #define PHY_CFG_TX_FSLS_VREF_TUNE_MASK GENMASK(1, 0) #define PHY_CFG_TX_FSLS_VREG_BYPASS BIT(2) #define PHY_CFG_TX_HS_VREF_TUNE_MASK GENMASK(5, 3) #define PHY_CFG_TX_HS_XV_TUNE_MASK GENMASK(7, 6) -#define USB_PHY_CFG_CTRL_9 (0x7c) +#define QCOM_USB_PHY_CFG_CTRL_9 (0x7c) #define PHY_CFG_TX_PREEMP_TUNE_MASK GENMASK(2, 0) #define PHY_CFG_TX_RES_TUNE_MASK GENMASK(4, 3) #define PHY_CFG_TX_RISE_TUNE_MASK GENMASK(6, 5) #define PHY_CFG_RCAL_BYPASS BIT(7) -#define USB_PHY_CFG_CTRL_10 (0x80) +#define QCOM_USB_PHY_CFG_CTRL_10 (0x80) -#define USB_PHY_CFG0 (0x94) +#define QCOM_USB_PHY_CFG0 (0x94) #define DATAPATH_CTRL_OVERRIDE_EN BIT(0) #define CMN_CTRL_OVERRIDE_EN BIT(1) -#define UTMI_PHY_CMN_CTRL0 (0x98) +#define QCOM_UTMI_PHY_CMN_CTRL0 (0x98) #define TESTBURNIN BIT(6) -#define USB_PHY_FSEL_SEL (0xb8) +#define QCOM_USB_PHY_FSEL_SEL (0xb8) #define FSEL_SEL BIT(0) -#define USB_PHY_APB_ACCESS_CMD (0x130) +#define QCOM_USB_PHY_APB_ACCESS_CMD (0x130) #define RW_ACCESS BIT(0) #define APB_START_CMD BIT(1) #define APB_LOGIC_RESET BIT(2) -#define USB_PHY_APB_ACCESS_STATUS (0x134) +#define QCOM_USB_PHY_APB_ACCESS_STATUS (0x134) #define ACCESS_DONE BIT(0) #define TIMED_OUT BIT(1) #define ACCESS_ERROR BIT(2) #define ACCESS_IN_PROGRESS BIT(3) -#define USB_PHY_APB_ADDRESS (0x138) +#define QCOM_USB_PHY_APB_ADDRESS (0x138) #define APB_REG_ADDR_MASK GENMASK(7, 0) -#define USB_PHY_APB_WRDATA_LSB (0x13c) +#define QCOM_USB_PHY_APB_WRDATA_LSB (0x13c) #define APB_REG_WRDATA_7_0_MASK GENMASK(3, 0) -#define USB_PHY_APB_WRDATA_MSB (0x140) +#define QCOM_USB_PHY_APB_WRDATA_MSB (0x140) #define APB_REG_WRDATA_15_8_MASK GENMASK(7, 4) -#define USB_PHY_APB_RDDATA_LSB (0x144) +#define QCOM_USB_PHY_APB_RDDATA_LSB (0x144) #define APB_REG_RDDATA_7_0_MASK GENMASK(3, 0) -#define USB_PHY_APB_RDDATA_MSB (0x148) +#define QCOM_USB_PHY_APB_RDDATA_MSB (0x148) #define APB_REG_RDDATA_15_8_MASK GENMASK(7, 4) static const char * const eusb2_hsphy_vreg_names[] = { @@ -121,7 +121,7 @@ static const char * const eusb2_hsphy_vreg_names[] = { #define EUSB2_NUM_VREGS ARRAY_SIZE(eusb2_hsphy_vreg_names) -struct qcom_snps_eusb2_hsphy { +struct snps_eusb2_hsphy { struct phy *phy; void __iomem *base; @@ -135,17 +135,17 @@ struct qcom_snps_eusb2_hsphy { struct phy *repeater; }; -static int qcom_snps_eusb2_hsphy_set_mode(struct phy *p, enum phy_mode mode, int submode) +static int snps_eusb2_hsphy_set_mode(struct phy *p, enum phy_mode mode, int submode) { - struct qcom_snps_eusb2_hsphy *phy = phy_get_drvdata(p); + struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); phy->mode = mode; return phy_set_mode_ext(phy->repeater, mode, submode); } -static void qcom_snps_eusb2_hsphy_write_mask(void __iomem *base, u32 offset, - u32 mask, u32 val) +static void snps_eusb2_hsphy_write_mask(void __iomem *base, u32 offset, + u32 mask, u32 val) { u32 reg; @@ -158,65 +158,65 @@ static void qcom_snps_eusb2_hsphy_write_mask(void __iomem *base, u32 offset, readl_relaxed(base + offset); } -static void qcom_eusb2_default_parameters(struct qcom_snps_eusb2_hsphy *phy) +static void qcom_eusb2_default_parameters(struct snps_eusb2_hsphy *phy) { /* default parameters: tx pre-emphasis */ - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_9, - PHY_CFG_TX_PREEMP_TUNE_MASK, - FIELD_PREP(PHY_CFG_TX_PREEMP_TUNE_MASK, 0)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_9, + PHY_CFG_TX_PREEMP_TUNE_MASK, + FIELD_PREP(PHY_CFG_TX_PREEMP_TUNE_MASK, 0)); /* tx rise/fall time */ - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_9, - PHY_CFG_TX_RISE_TUNE_MASK, - FIELD_PREP(PHY_CFG_TX_RISE_TUNE_MASK, 0x2)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_9, + PHY_CFG_TX_RISE_TUNE_MASK, + FIELD_PREP(PHY_CFG_TX_RISE_TUNE_MASK, 0x2)); /* source impedance adjustment */ - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_9, - PHY_CFG_TX_RES_TUNE_MASK, - FIELD_PREP(PHY_CFG_TX_RES_TUNE_MASK, 0x1)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_9, + PHY_CFG_TX_RES_TUNE_MASK, + FIELD_PREP(PHY_CFG_TX_RES_TUNE_MASK, 0x1)); /* dc voltage level adjustement */ - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_8, - PHY_CFG_TX_HS_VREF_TUNE_MASK, - FIELD_PREP(PHY_CFG_TX_HS_VREF_TUNE_MASK, 0x3)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_8, + PHY_CFG_TX_HS_VREF_TUNE_MASK, + FIELD_PREP(PHY_CFG_TX_HS_VREF_TUNE_MASK, 0x3)); /* transmitter HS crossover adjustement */ - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_8, - PHY_CFG_TX_HS_XV_TUNE_MASK, - FIELD_PREP(PHY_CFG_TX_HS_XV_TUNE_MASK, 0x0)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_8, + PHY_CFG_TX_HS_XV_TUNE_MASK, + FIELD_PREP(PHY_CFG_TX_HS_XV_TUNE_MASK, 0x0)); } -static int qcom_eusb2_ref_clk_init(struct qcom_snps_eusb2_hsphy *phy) +static int qcom_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy) { unsigned long ref_clk_freq = clk_get_rate(phy->ref_clk); switch (ref_clk_freq) { case 19200000: - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL_COMMON0, - FSEL_MASK, - FIELD_PREP(FSEL_MASK, FSEL_19_2_MHZ_VAL)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + FSEL_MASK, + FIELD_PREP(FSEL_MASK, FSEL_19_2_MHZ_VAL)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_2, - PHY_CFG_PLL_FB_DIV_7_0_MASK, - DIV_7_0_19_2_MHZ_VAL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_2, + PHY_CFG_PLL_FB_DIV_7_0_MASK, + DIV_7_0_19_2_MHZ_VAL); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_3, - PHY_CFG_PLL_FB_DIV_11_8_MASK, - DIV_11_8_19_2_MHZ_VAL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, + PHY_CFG_PLL_FB_DIV_11_8_MASK, + DIV_11_8_19_2_MHZ_VAL); break; case 38400000: - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL_COMMON0, - FSEL_MASK, - FIELD_PREP(FSEL_MASK, FSEL_38_4_MHZ_VAL)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + FSEL_MASK, + FIELD_PREP(FSEL_MASK, FSEL_38_4_MHZ_VAL)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_2, - PHY_CFG_PLL_FB_DIV_7_0_MASK, - DIV_7_0_38_4_MHZ_VAL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_2, + PHY_CFG_PLL_FB_DIV_7_0_MASK, + DIV_7_0_38_4_MHZ_VAL); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_3, - PHY_CFG_PLL_FB_DIV_11_8_MASK, - DIV_11_8_38_4_MHZ_VAL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, + PHY_CFG_PLL_FB_DIV_11_8_MASK, + DIV_11_8_38_4_MHZ_VAL); break; default: @@ -224,15 +224,15 @@ static int qcom_eusb2_ref_clk_init(struct qcom_snps_eusb2_hsphy *phy) return -EINVAL; } - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_3, - PHY_CFG_PLL_REF_DIV, PLL_REF_DIV_VAL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, + PHY_CFG_PLL_REF_DIV, PLL_REF_DIV_VAL); return 0; } -static int qcom_snps_eusb2_hsphy_init(struct phy *p) +static int snps_eusb2_hsphy_init(struct phy *p) { - struct qcom_snps_eusb2_hsphy *phy = phy_get_drvdata(p); + struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); int ret; ret = regulator_bulk_enable(ARRAY_SIZE(phy->vregs), phy->vregs); @@ -265,73 +265,73 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p) goto disable_ref_clk; } - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG0, - CMN_CTRL_OVERRIDE_EN, CMN_CTRL_OVERRIDE_EN); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG0, + CMN_CTRL_OVERRIDE_EN, CMN_CTRL_OVERRIDE_EN); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_UTMI_CTRL5, POR, POR); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_UTMI_CTRL5, POR, POR); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL_COMMON0, - PHY_ENABLE | RETENABLEN, PHY_ENABLE | RETENABLEN); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + PHY_ENABLE | RETENABLEN, PHY_ENABLE | RETENABLEN); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_APB_ACCESS_CMD, - APB_LOGIC_RESET, APB_LOGIC_RESET); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_APB_ACCESS_CMD, + APB_LOGIC_RESET, APB_LOGIC_RESET); - qcom_snps_eusb2_hsphy_write_mask(phy->base, UTMI_PHY_CMN_CTRL0, TESTBURNIN, 0); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_UTMI_PHY_CMN_CTRL0, TESTBURNIN, 0); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_FSEL_SEL, - FSEL_SEL, FSEL_SEL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_FSEL_SEL, + FSEL_SEL, FSEL_SEL); /* update ref_clk related registers */ ret = qcom_eusb2_ref_clk_init(phy); if (ret) - goto disable_ref_clk; + return ret; - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_1, - PHY_CFG_PLL_CPBIAS_CNTRL_MASK, - FIELD_PREP(PHY_CFG_PLL_CPBIAS_CNTRL_MASK, 0x1)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_1, + PHY_CFG_PLL_CPBIAS_CNTRL_MASK, + FIELD_PREP(PHY_CFG_PLL_CPBIAS_CNTRL_MASK, 0x1)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_4, - PHY_CFG_PLL_INT_CNTRL_MASK, - FIELD_PREP(PHY_CFG_PLL_INT_CNTRL_MASK, 0x8)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_4, + PHY_CFG_PLL_INT_CNTRL_MASK, + FIELD_PREP(PHY_CFG_PLL_INT_CNTRL_MASK, 0x8)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_4, - PHY_CFG_PLL_GMP_CNTRL_MASK, - FIELD_PREP(PHY_CFG_PLL_GMP_CNTRL_MASK, 0x1)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_4, + PHY_CFG_PLL_GMP_CNTRL_MASK, + FIELD_PREP(PHY_CFG_PLL_GMP_CNTRL_MASK, 0x1)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_5, - PHY_CFG_PLL_PROP_CNTRL_MASK, - FIELD_PREP(PHY_CFG_PLL_PROP_CNTRL_MASK, 0x10)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_5, + PHY_CFG_PLL_PROP_CNTRL_MASK, + FIELD_PREP(PHY_CFG_PLL_PROP_CNTRL_MASK, 0x10)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_6, - PHY_CFG_PLL_VCO_CNTRL_MASK, - FIELD_PREP(PHY_CFG_PLL_VCO_CNTRL_MASK, 0x0)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_6, + PHY_CFG_PLL_VCO_CNTRL_MASK, + FIELD_PREP(PHY_CFG_PLL_VCO_CNTRL_MASK, 0x0)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_CFG_CTRL_5, - PHY_CFG_PLL_VREF_TUNE_MASK, - FIELD_PREP(PHY_CFG_PLL_VREF_TUNE_MASK, 0x1)); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_5, + PHY_CFG_PLL_VREF_TUNE_MASK, + FIELD_PREP(PHY_CFG_PLL_VREF_TUNE_MASK, 0x1)); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL2, - VBUS_DET_EXT_SEL, VBUS_DET_EXT_SEL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL2, + VBUS_DET_EXT_SEL, VBUS_DET_EXT_SEL); /* set default parameters */ qcom_eusb2_default_parameters(phy); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL2, - USB2_SUSPEND_N_SEL | USB2_SUSPEND_N, - USB2_SUSPEND_N_SEL | USB2_SUSPEND_N); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL2, + USB2_SUSPEND_N_SEL | USB2_SUSPEND_N, + USB2_SUSPEND_N_SEL | USB2_SUSPEND_N); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_UTMI_CTRL0, SLEEPM, SLEEPM); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_UTMI_CTRL0, SLEEPM, SLEEPM); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL_COMMON0, - SIDDQ_SEL, SIDDQ_SEL); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + SIDDQ_SEL, SIDDQ_SEL); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL_COMMON0, - SIDDQ, 0); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + SIDDQ, 0); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_UTMI_CTRL5, POR, 0); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_UTMI_CTRL5, POR, 0); - qcom_snps_eusb2_hsphy_write_mask(phy->base, USB_PHY_HS_PHY_CTRL2, - USB2_SUSPEND_N_SEL, 0); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL2, + USB2_SUSPEND_N_SEL, 0); return 0; @@ -344,9 +344,9 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p) return ret; } -static int qcom_snps_eusb2_hsphy_exit(struct phy *p) +static int snps_eusb2_hsphy_exit(struct phy *p) { - struct qcom_snps_eusb2_hsphy *phy = phy_get_drvdata(p); + struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); clk_disable_unprepare(phy->ref_clk); @@ -357,18 +357,18 @@ static int qcom_snps_eusb2_hsphy_exit(struct phy *p) return 0; } -static const struct phy_ops qcom_snps_eusb2_hsphy_ops = { - .init = qcom_snps_eusb2_hsphy_init, - .exit = qcom_snps_eusb2_hsphy_exit, - .set_mode = qcom_snps_eusb2_hsphy_set_mode, +static const struct phy_ops snps_eusb2_hsphy_ops = { + .init = snps_eusb2_hsphy_init, + .exit = snps_eusb2_hsphy_exit, + .set_mode = snps_eusb2_hsphy_set_mode, .owner = THIS_MODULE, }; -static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev) +static int snps_eusb2_hsphy_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; - struct qcom_snps_eusb2_hsphy *phy; + struct snps_eusb2_hsphy *phy; struct phy_provider *phy_provider; struct phy *generic_phy; int ret, i; @@ -405,7 +405,7 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev) return dev_err_probe(dev, PTR_ERR(phy->repeater), "failed to get repeater\n"); - generic_phy = devm_phy_create(dev, NULL, &qcom_snps_eusb2_hsphy_ops); + generic_phy = devm_phy_create(dev, NULL, &snps_eusb2_hsphy_ops); if (IS_ERR(generic_phy)) { dev_err(dev, "failed to create phy %d\n", ret); return PTR_ERR(generic_phy); @@ -418,25 +418,25 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev) if (IS_ERR(phy_provider)) return PTR_ERR(phy_provider); - dev_info(dev, "Registered Qcom-eUSB2 phy\n"); + dev_info(dev, "Registered Snps-eUSB2 phy\n"); return 0; } -static const struct of_device_id qcom_snps_eusb2_hsphy_of_match_table[] = { +static const struct of_device_id snps_eusb2_hsphy_of_match_table[] = { { .compatible = "qcom,sm8550-snps-eusb2-phy", }, { }, }; -MODULE_DEVICE_TABLE(of, qcom_snps_eusb2_hsphy_of_match_table); +MODULE_DEVICE_TABLE(of, snps_eusb2_hsphy_of_match_table); -static struct platform_driver qcom_snps_eusb2_hsphy_driver = { - .probe = qcom_snps_eusb2_hsphy_probe, +static struct platform_driver snps_eusb2_hsphy_driver = { + .probe = snps_eusb2_hsphy_probe, .driver = { - .name = "qcom-snps-eusb2-hsphy", - .of_match_table = qcom_snps_eusb2_hsphy_of_match_table, + .name = "snps-eusb2-hsphy", + .of_match_table = snps_eusb2_hsphy_of_match_table, }, }; -module_platform_driver(qcom_snps_eusb2_hsphy_driver); -MODULE_DESCRIPTION("Qualcomm SNPS eUSB2 HS PHY driver"); +module_platform_driver(snps_eusb2_hsphy_driver); +MODULE_DESCRIPTION("Synopsys eUSB2 HS PHY driver"); MODULE_LICENSE("GPL"); From patchwork Sat Apr 12 20:26:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 14049141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D427CC369AB for ; Sat, 12 Apr 2025 20:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CkKbf06yFgRJdag0RnXKSByCgwFVd+Ap1C4bQBdb/gs=; b=hIfgVcGnEoxCQy SpWrrVHKnETpoNQZX+33khNMaOnNOyfgWv/ICUCbufsQEFSs9eJGrYWqOTcH6nEI8Ro9zbaKZ667z /2i6Z7bPhtHk3qwnPwtiCB+ddERO8PDftP+73CXVILtqiCPhCYSurYEK7azZ2Y8K7ZUTAdczqT6IW DL73e2PZvBL4ARTC9cda26GRD8+HzQ5y8Steq/O4MGEfh5hO63EGn3ei0MrR8E1vRDXBkMSCweHD7 uaOkVBgtkJ3xdhpwYrO/UDvqNKKIXGrQjGD/vKdHrIjQ6Qlc0DdmrUpUd/9U/ZHpAbFxn3eCgc2xT g7u7UayE5X6koRwKJwvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3haL-0000000GQOe-2bGw; Sat, 12 Apr 2025 20:36:17 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hRR-0000000GP2r-05Z9; Sat, 12 Apr 2025 20:27:06 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-399749152b4so1331237f8f.3; Sat, 12 Apr 2025 13:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744489623; x=1745094423; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=S/2ZMg6LQNzP+WqoJGSl/J+PhbKTk0j0hhnJ6TPVsHY=; b=ShEqd0k11O4ZMqlG8AGKuo46/KORF53I0a2J14bpym7hVTz8dUpSJDhNq51aJJqGVd ZMWvgs3wuK6QH/eFd3SI+stHS32DYyAyCGI8/bo5FIjZ1Zas791gkbVvi841ka50ZSry myhdm/FIRQNs3RnSJgLjAHrtGPR9CY4oOXsZOq+UmusrBySutm3RQ8G4kxugf+Lmtnym 7o05sqG7OoI+sdIXenuG20s9wuOacmWQ9yLuTd/HdIpwka4L8ZkCRde8EVTFlFdf/FSK qbYXkOfr5OxyLit/qUb95nOUppIfRbilfSNNgcqxy+Uv+OiyqudLqaKiPlT/hqFU/LK2 H85A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744489623; x=1745094423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S/2ZMg6LQNzP+WqoJGSl/J+PhbKTk0j0hhnJ6TPVsHY=; b=Oc1cNSGpcnuPWj5FfX3Crxi/zuYwzpyVVDIYOzA4VYug8ZBiur4L9DtJ03uP17/5kU pckvTShQAaEj+nqK3O23sV7ktCkkVBzNNVORno3jGQdBzMlr8+leEA3HlHfAdIy5SRlB vUoMCJ9/K1ks4JtKsLqdHIgmnJ5wxFs4mthXj3pD9AQaLrcv5277ZJa6FrtuqH58ckpa HzPHg6leqdaO9h/OWTGFScWeyPMURle998Hi2sa/p+psidP+VI9hs93layIMSlpHMq4r +W+7lmxxyKT+0Lxvs9uVRpr7BTaUTQtdtXQLiRoJZFdl1744lo/KGahuXh+cwbMIWikD rGVg== X-Forwarded-Encrypted: i=1; AJvYcCVFGRJm6ESZofOThyUF8E+LZr5aRGxxZO98IRB6oRevy6cV6yLbq4gzNGRvXMZmoqAGn2PuKOjTR0I4swxG37TE@lists.infradead.org, AJvYcCXOIzWQIKKgtRoSZpPty/YtJR2GZo5flTq64PuThkc80r/iGNpLPQNOYmcND+4WFD1QA9dDFOxfBnGJ@lists.infradead.org X-Gm-Message-State: AOJu0YwfXHl4E79LS3Z9Xr9DdGijroyj2m8ZlXftcX4vWJHRsPDfGrZ1 DvmxwhAuFOCYs329o+HsuHCZdiN8HSvztvj7VFOQLfqipXHbF7iZ X-Gm-Gg: ASbGncviBhy4Ln+PVb08GcN5kV4ROyRM1RDyalqYkHKsIfYBCylUjsfYCV8MvfnnJ6S +/J77oDEqJFYzETIkX3P7N6a011ZI+QruhBeuCNLg9eT7jCQr/eb6CFDneabm2bvHITPG98ehqe X0cgIOAgVBlecOklQUsqChB3/NeG9fJr0SA03Bins/XvffASTx6hFVbOJfFyqcBSyECvFQrbUeg G04rQSdVA3LOrFsya7TcUuI3uU6rVAYhgXg0aWiE8ZHReIN71D5+DM744PGfgssu49wIeNZILDd adwyi8/RuZLWrMAbPmNTZ6l+RpCdOZbNYrZYcoNSFiSwtr7nus6trmMDFcZ1eAJToAeSNJ3Nhuh N7S+zoSj0sH8ykYAw X-Google-Smtp-Source: AGHT+IFJDUur0adD/E+6mc6RzqJoyEDVCAPitJd/TRf5iOWy3NXGIjLX4HQcNm9eTWMzQfsVlLv4vQ== X-Received: by 2002:a05:6000:40cd:b0:39c:266c:421 with SMTP id ffacd0b85a97d-39e9f3d9c2cmr5527869f8f.0.1744489622902; Sat, 12 Apr 2025 13:27:02 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d802sm131797845e9.1.2025.04.12.13.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 13:27:02 -0700 (PDT) From: Ivaylo Ivanov To: Krzysztof Kozlowski , Vinod Koul , Conor Dooley , Alim Akhtar , Kishon Vijay Abraham I , Rob Herring , Philipp Zabel Cc: linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v4 05/10] phy: phy-snps-eusb2: split phy init code Date: Sat, 12 Apr 2025 23:26:15 +0300 Message-ID: <20250412202620.738150-6-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> References: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250412_132705_062295_28A7D625 X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The current phy init consists of hardware power-up, as well as QCOM-specific eUSB2 init code. Split it into two parts, to make room for such non-QCOM init code. Signed-off-by: Ivaylo Ivanov Reviewed-by: Dmitry Baryshkov --- drivers/phy/phy-snps-eusb2.c | 94 +++++++++++++++++++++++------------- 1 file changed, 61 insertions(+), 33 deletions(-) diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index e1b175f48..1933e8440 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -121,6 +121,10 @@ static const char * const eusb2_hsphy_vreg_names[] = { #define EUSB2_NUM_VREGS ARRAY_SIZE(eusb2_hsphy_vreg_names) +struct snps_eusb2_phy_drvdata { + int (*phy_init)(struct phy *p); +}; + struct snps_eusb2_hsphy { struct phy *phy; void __iomem *base; @@ -133,6 +137,8 @@ struct snps_eusb2_hsphy { enum phy_mode mode; struct phy *repeater; + + const struct snps_eusb2_phy_drvdata *data; }; static int snps_eusb2_hsphy_set_mode(struct phy *p, enum phy_mode mode, int submode) @@ -230,41 +236,11 @@ static int qcom_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy) return 0; } -static int snps_eusb2_hsphy_init(struct phy *p) +static int qcom_snps_eusb2_hsphy_init(struct phy *p) { struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); int ret; - ret = regulator_bulk_enable(ARRAY_SIZE(phy->vregs), phy->vregs); - if (ret) - return ret; - - ret = phy_init(phy->repeater); - if (ret) { - dev_err(&p->dev, "repeater init failed. %d\n", ret); - goto disable_vreg; - } - - ret = clk_prepare_enable(phy->ref_clk); - if (ret) { - dev_err(&p->dev, "failed to enable ref clock, %d\n", ret); - goto disable_vreg; - } - - ret = reset_control_assert(phy->phy_reset); - if (ret) { - dev_err(&p->dev, "failed to assert phy_reset, %d\n", ret); - goto disable_ref_clk; - } - - usleep_range(100, 150); - - ret = reset_control_deassert(phy->phy_reset); - if (ret) { - dev_err(&p->dev, "failed to de-assert phy_reset, %d\n", ret); - goto disable_ref_clk; - } - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG0, CMN_CTRL_OVERRIDE_EN, CMN_CTRL_OVERRIDE_EN); @@ -334,6 +310,52 @@ static int snps_eusb2_hsphy_init(struct phy *p) USB2_SUSPEND_N_SEL, 0); return 0; +} + +static const struct snps_eusb2_phy_drvdata sm8550_snps_eusb2_phy = { + .phy_init = qcom_snps_eusb2_hsphy_init, +}; + +static int snps_eusb2_hsphy_init(struct phy *p) +{ + struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); + int ret; + + ret = regulator_bulk_enable(ARRAY_SIZE(phy->vregs), phy->vregs); + if (ret) + return ret; + + ret = phy_init(phy->repeater); + if (ret) { + dev_err(&p->dev, "repeater init failed. %d\n", ret); + goto disable_vreg; + } + + ret = clk_prepare_enable(phy->ref_clk); + if (ret) { + dev_err(&p->dev, "failed to enable ref clock, %d\n", ret); + goto disable_vreg; + } + + ret = reset_control_assert(phy->phy_reset); + if (ret) { + dev_err(&p->dev, "failed to assert phy_reset, %d\n", ret); + goto disable_ref_clk; + } + + usleep_range(100, 150); + + ret = reset_control_deassert(phy->phy_reset); + if (ret) { + dev_err(&p->dev, "failed to de-assert phy_reset, %d\n", ret); + goto disable_ref_clk; + } + + ret = phy->data->phy_init(p); + if (ret) + goto disable_ref_clk; + + return 0; disable_ref_clk: clk_disable_unprepare(phy->ref_clk); @@ -378,6 +400,10 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) if (!phy) return -ENOMEM; + phy->data = device_get_match_data(dev); + if (!phy->data) + return -EINVAL; + phy->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(phy->base)) return PTR_ERR(phy->base); @@ -424,8 +450,10 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) } static const struct of_device_id snps_eusb2_hsphy_of_match_table[] = { - { .compatible = "qcom,sm8550-snps-eusb2-phy", }, - { }, + { + .compatible = "qcom,sm8550-snps-eusb2-phy", + .data = &sm8550_snps_eusb2_phy, + }, { }, }; MODULE_DEVICE_TABLE(of, snps_eusb2_hsphy_of_match_table); From patchwork Sat Apr 12 20:26:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 14049142 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F119C369AB for ; Sat, 12 Apr 2025 20:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+gAkrMeFEFV8uOXoR3xtAdQsiXYtQShqlYoRfjT1KBc=; b=Ea6Cx/FdArsFO/ K1s3mlyJC0MuJk+cKTJnRe2rl7cHwj1J4dQWAlsT97H5sgTcM4WcM4nZIFPTPUp/AeffmDWuEvrCF wgXNrk9kbu2HyKizpkZavur8O8853S85RzPYLsrs3o3KogxnFqaQrkxIXY0w2XNIPV1YE5Q9qwcy6 zsPEDaglmLpVkwO6TVnoFz7gGZxU3Ehex76V+PrhWoVAh8TMITJueTNEvIo3yzFTN3SfNu8eQGy0Q Zx+fAPXqrzelkp3AJPcB+VFMCoG4XNfgcqkIKjgFf5pUtJWq3YlpD/tchHfQkJoaJIVux4IxlGL51 8wRl3Ee09XEoaExTptkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hc9-0000000GQY9-2hG8; Sat, 12 Apr 2025 20:38:09 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hRS-0000000GP3P-0IKC; Sat, 12 Apr 2025 20:27:07 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-43cef035a3bso21588465e9.1; Sat, 12 Apr 2025 13:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744489624; x=1745094424; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4mVbqwsxzgFPfZ9lDdnu8dfGQADmGRwdt2QEaF4tnGI=; b=MLdFJE4FBFzWiXaFhOmvyZgNGQ0xtFqI0fAPHVi0MAk+4gtoHoVVSR4mg6NzydZYju Vw9NxQGvMfH1sMThzR/R8yfNHG54Cf3jF3+qVfbfsp4dnIavrVdfRwSKHgSyrTAd9r+h X4Jnrq4dawI69mq5gQeNDaDqJVl06yxZmv8WpW6d3FqiZ09Fetk2QtXEKQzZfYC9PtYC VZgor6saGJ1MMjw2mvQJBcTrsId1mW9eVJlyiEwJBfyzJCiJssCgdkskx+sZVQUYdJAP iquJ0sTML/09BybhEduz/3WXGrz0OzyX1m1aKQLYykdMB1lU/P2xk46O15tAKe/vL0U/ CN3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744489624; x=1745094424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4mVbqwsxzgFPfZ9lDdnu8dfGQADmGRwdt2QEaF4tnGI=; b=C1/isS9EbZBhhHQ/aszJQrbM2KGJ+5OPdYBwra1nvwi8Sb3l9iFux4vivubHTNnHs1 WJyRFvz/tbLXvk7rZnm47AGPnzjdN0/IOfqnYi2WkZ+WjP2i4B9hfLYiGTdjxExrB1bq ALW0srl7s0vGRyeGwar18TozN1KCnK6b80W5vUwLDVVXHJCsNC+olU9pwvvmcGxolK9e 3GXRh9xTPJ0CEX7MVY2/tn/ZNcelhjtzqehKPU9FmUmoBPAdZ0M4RSzlAKM8/X+vwN5X dVJQGVp0EiILDnKoGI+BE8CCyLYfCjaGgViYBU/40hj3ij15JEDicf9O2Sd7cUHEfGRc g10A== X-Forwarded-Encrypted: i=1; AJvYcCVQc1fcH2rr4J8hlhvNSLn26586lJZ1W4mG9NxxPHtuQLcycjoeTyvTrC9mICBoxaIGRzC4ILszInBk@lists.infradead.org, AJvYcCXb1j3uuZ4hsIbbE0RaFL4uMWMIEomtYwOG83jnslmB7W7lVIVDPOLT+hLh1IR8EEI87mOFkiCt3U08suyHSZI8@lists.infradead.org X-Gm-Message-State: AOJu0YynTi6Ll6m8GbgcE55eNDdOave6VTNLb04fX0ikAIRzXWRAMAoC 2ay4Jib/1D1geDKatN5YLWpQArR5cQY6zFgfPkyGMJLj1Vk/kDrf X-Gm-Gg: ASbGncuYvhAjUpA1G7g8YmKlNP2zRsJPZ7fWrESHxbRsXFgD1abt0kpTPSeRUiRnW2M tPd92lY0nC3wQOuBwWhXU0BcFUCiocmtQz45tEFkeYeFRrUHD46IqJsDU7AL8CRqHLP5H0VukHE NPZrJ95aljyuxHGAsAKZzTEjMSEQpxGq6ncd0VgcsaOhXqDEU0BM8IpgtJyQJMw9jW1iuO4zheT 4xJVt1qYrEmKqPoSeqs+4tlDOEI1LJooKxp0Pyf5rvo6oYAXdjhdj0VixFFqspbgHnpo5OZOQh1 /j5fGeCe2oTl/K1eX1VOnHGzI5OEsAA7AmdT0fpt0NxyEolk1wKBPo3tZgyp+NqDAYALmcmb5+a RtpbA4adJFO03KWNw X-Google-Smtp-Source: AGHT+IEsgvtrWdgSeL0DlLpKGI9k/yst2bpThSyr13W7zdJuj6gazbdG6ZqfVwdkcHDp3Ks5PdCzxQ== X-Received: by 2002:a05:600c:1e18:b0:43d:2230:303b with SMTP id 5b1f17b1804b1-43f3a9ab06bmr50489615e9.20.1744489624337; Sat, 12 Apr 2025 13:27:04 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d802sm131797845e9.1.2025.04.12.13.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 13:27:03 -0700 (PDT) From: Ivaylo Ivanov To: Krzysztof Kozlowski , Vinod Koul , Conor Dooley , Alim Akhtar , Kishon Vijay Abraham I , Rob Herring , Philipp Zabel Cc: linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v4 06/10] phy: phy-snps-eusb2: make repeater optional Date: Sat, 12 Apr 2025 23:26:16 +0300 Message-ID: <20250412202620.738150-7-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> References: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250412_132706_104841_D61D5BDB X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org As described in the device tree bindings, it's not necessary for the SNPS eUSB2 phy to be connected to a repeater. In configurations where there are such instances, the driver probing fails and the usb controller does not work. Make the repeater optional to avoid that, which also lets us use the eUSB2 phy when it's connected to a repeater that is not configurable by the kernel (for example it's missing a driver), as long as it has been configured beforehand (usually by the bootloader). Signed-off-by: Ivaylo Ivanov Acked-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/phy/phy-snps-eusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index 1933e8440..4094786d2 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -426,7 +426,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) return dev_err_probe(dev, ret, "failed to get regulator supplies\n"); - phy->repeater = devm_of_phy_get_by_index(dev, np, 0); + phy->repeater = devm_of_phy_optional_get(dev, np, 0); if (IS_ERR(phy->repeater)) return dev_err_probe(dev, PTR_ERR(phy->repeater), "failed to get repeater\n"); From patchwork Sat Apr 12 20:26:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 14049146 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9140C369AB for ; Sat, 12 Apr 2025 20:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G7lEULVJZA/CHUmuKXONkDzoRpW9Svbf5bI4rBG1EGo=; b=WVS9jDKg1ITd0f XUaI84PlaQzFOyHqzEQ8f83bl9ljTIt6x/ld+CqOASNtZJzKZUi9acfkgVwStEvGAJ3ihBVAUfKbe 3tJvXmVS2+0wmkdaRfArGw/n3Uq8qIIk03hE8Xe6YjS92UJera6ztW9tTalczBlFFA3eelxiuEfGP JY0LiyjnuQosbO6uklZmoOZPv6RqdQv4sN6MiwBZzByHNz50VJfeO0hMDF3KuhFEyBgyCzRKFk4W9 QJsdmjPLUKu7yx0+F7YsQwP6TYU3L/xvR3HA7nPIXRVyD2X9KUbZogmZzqDMxjTjS6OFr9FEoPsZc ++KpJlx5EP/H1znTOlvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hdw-0000000GQiH-2OfR; Sat, 12 Apr 2025 20:40:00 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hRT-0000000GP44-1SqT; Sat, 12 Apr 2025 20:27:08 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-43d07ca6a80so14700185e9.1; Sat, 12 Apr 2025 13:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744489626; x=1745094426; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RbJk9bz6EFQthks8Ev5pNh2F644o6dRNVZmRCAlT3D8=; b=U9AcA8uKf7rP7W/Z8brPJxhbGJ5LYn/+oYbrwPkLcYD9+SSjqBrLaGvo+56BL9a5Ae ywB++aTnmNf60swL3Qozk8CEDUfKO3bBwYydmoV2Sr6zdny4DEQrBvn1k/1OKj5P8KfZ CY/23jxFB/WbB9k0hNSw0aYGi913W4jXIdxfnivtjDv2pWgTXMvRDI2EmUIwwMmMRK9b PR3jsoKhRGxUyQdboVF12deLKUEOB6w8nYeE8sw5pjIEo5UqQgarZHZwCjqn/oHENO70 yuqrPeZi0oDbce15pCgLtNf3FaqPSAFSoQeEd4egltCX3svgY7EyPeK3gE2aOarXoKOb tBBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744489626; x=1745094426; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RbJk9bz6EFQthks8Ev5pNh2F644o6dRNVZmRCAlT3D8=; b=sTfZHwyylKmNlQ+yp5MDWhjg3hBD7GCmGxV6qUbXlQrFDPkCDQmnVBdQTSiLEYZF2K bi0LiNdTIHxCEc13UE28CpmJ+CXIFaQ9Vxht7jAP6GqayYOD3N1JNDnomIb5Cs2mHO19 RC17lN3vZT4Owg/5j4TOFgk9i09P5P/9tBVkhpRf1Hd8y5ATHpOHnHTk2WLocqhGugZK SU9vrANWLTQVqI7h+Zt6R4IU1sI0haa7XEv+z9CjW8bctgKBUevTgXGgWQ7J8it3c+Zl dB0zaJm+kgHH6ZsovKQyl8uSqFF4Pg7m9kRpYlomUDxWfuw6MpREoYXWHwYNqHVDgH54 6EFg== X-Forwarded-Encrypted: i=1; AJvYcCXOLnndbaV/svqVfc5Yl2dVV+B5EYz2U8M540zHe+h22s8yiQaDIiIs7FeDYNyzio+hV1cRdw14w36M/YZyuRqd@lists.infradead.org, AJvYcCXYGKgXEUlawsj6XvhMIE9JCG0iP0dA2zoN2W8xy2Nl03SXvHVjRMsg5IHLUAHqlKetga83eVEw8EH+@lists.infradead.org X-Gm-Message-State: AOJu0Yxq9rg4FFy171yFhksADo+TLxlX/CIs8acC6fO4AREOF1GECtkZ jYUUGH4V+z8U6tszIUo1Mn6YlkOZzZLTQE+X5G9MUQuEXlQcWbMi X-Gm-Gg: ASbGncsOfydh2f94TAv2Ou7k4ZeWn7s26XR3YSoz7cl30hBQrE+BYAcdRswHtnFkPQV mw3aDjsG2IICt4DqA6vX/GaGRcQTftyugkC/ih9dHjjPDq+dijJU4ZmB7/seMppLXphmEpvt6aW m0oRBbNbsaMxh5c5dcQt/xfIzfOTja6vC/O92VUCYDM04jisSs8uBVjPehoodsJTR0BzX/KqDbA TooHCZBJHo+iuB0rXYraviDyoxAwz5KB+fDtVJ4oNGBk5WJiuC7IM/1d9FgKFh3rakGAmYz/QoE Vkw9o1YmexIZN9y1TgxIcm0pgBW5yaHhi82GiZxvU6bwF1iwsNcdz2fgvrFU39kapHZ+NTl0epO DUJjOmgicOY/axIm3 X-Google-Smtp-Source: AGHT+IF7eQA+y8Lqvzil16h/BZ20xtsseNQHcX3MasiH+W36JGiRILYfIiYVwPVlNIgUn3fdc+Vv5Q== X-Received: by 2002:a05:600c:3ac6:b0:43c:f8fc:f69a with SMTP id 5b1f17b1804b1-43f3a925e28mr71377265e9.4.1744489625722; Sat, 12 Apr 2025 13:27:05 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d802sm131797845e9.1.2025.04.12.13.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 13:27:05 -0700 (PDT) From: Ivaylo Ivanov To: Krzysztof Kozlowski , Vinod Koul , Conor Dooley , Alim Akhtar , Kishon Vijay Abraham I , Rob Herring , Philipp Zabel Cc: linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v4 07/10] phy: phy-snps-eusb2: make reset control optional Date: Sat, 12 Apr 2025 23:26:17 +0300 Message-ID: <20250412202620.738150-8-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> References: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250412_132707_386638_09165FB4 X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Not all SoCs expose the reset line controls to the kernel, so make them optional. Signed-off-by: Ivaylo Ivanov Reviewed-by: Dmitry Baryshkov --- drivers/phy/phy-snps-eusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index 4094786d2..f05333901 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -408,7 +408,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) if (IS_ERR(phy->base)) return PTR_ERR(phy->base); - phy->phy_reset = devm_reset_control_get_exclusive(dev, NULL); + phy->phy_reset = devm_reset_control_get_optional_exclusive(dev, NULL); if (IS_ERR(phy->phy_reset)) return PTR_ERR(phy->phy_reset); From patchwork Sat Apr 12 20:26:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 14049147 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2E1DC369AB for ; Sat, 12 Apr 2025 20:41:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ry2TrxOd0sV/zUyFUQjyVbFLQ6xCRUfHpeZ8L7OYMos=; b=HFZGOwX0qmTj7p f4U3pT+xaJfdMmimGL/fpXG3kY4KlQLdKQoN/U1szUbgpmosFJi8ZExs5/nKc3YO3Y0Zw4b9hohlu 7RPdDHzyQe39tRj3KDnAzj3CPlcFoz0vakphi/LLGHvz87n0Dw9NGxDQvCbqPmIWg9R0HhgaIqCx4 amIJvlPTwzeb/0mDuM1ZxwKBBMcU2yQHz9Hj2woaE8DHpTOyuMaQnd/JGSNSFwEbBprUri8TsZy9V 9Q3OzB6zoeFVUFnsrnNS7dm+qx3EZ//DuGXRiqMsBPOzhKJc/mieRpb/gpJBseKyU9B4r1wen61sf YIJYMnBi7ac5pN4NniVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hfi-0000000GQq3-2CcS; Sat, 12 Apr 2025 20:41:50 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hRU-0000000GP4T-3R7E; Sat, 12 Apr 2025 20:27:10 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-43d0359b1fcso20323125e9.0; Sat, 12 Apr 2025 13:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744489627; x=1745094427; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H8Z64jhMWr4f68K+GRZRK+Jca5FzqJ7OziWBl/OdXKA=; b=c9bk+hJkiikxChqKbLmHLXkiGsEwBxIMjGvb6iZbREVM5E6s1Sojhz6n+pvTmMSd0C bYNLo4/4Sb9JYVkoTg7R2xY7LKLz3osQuc/hErbK090x6lu13inKxMkxIXPTPdGeQ+he 12pxIFrpm3YGpgEZbCIjSRBQK0px7ukGqcmslcDGDzn2lo+P6vdRt7eXg1bSiDEaTRZz G+u/3il1x9eEHGaGRjdNDwhAVf8osE/2/I1F73F+UwmyQpJHTaX0R91VkejXW/7GK78j jKUVdCYjpXJg5sRc9QMTa9kkLAmUB4lxjs7pcDW4XQk2V9qv4n0rdS+QKgXaMJ+GKHGl Fthw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744489627; x=1745094427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H8Z64jhMWr4f68K+GRZRK+Jca5FzqJ7OziWBl/OdXKA=; b=ex9kwjZkC+ZdbX0rw0AlNjeWu5m1BOslMCtTnPdOvugvO8n3nNW8yjk/ctY8Vz6Yrc Hja8fFrxJ+fM5lLS23q0SVqk0eOvd09sJxH5sTGB9GmJLMPHGWVrAdwID4nEteWglU+K lCbcvVrim25y8JAWjti6sm22At/JorvtQ1SgQQnfSj5UdRda+z4zhUf1WCiMtwlRhFKr 5HpdUUqT3IisVSdkxeCzbl1Q8Os7yRQvAOjPdn9SyRsf+7KP0DiStHLjv3NqPdQuH6vW 0S5rfU5vAS7sbJjWHDu44jxK0oVTx0HRnoGMEsaONW3BODCYsOA0OJNig1ylogl7fVi4 p5VA== X-Forwarded-Encrypted: i=1; AJvYcCVPe3T5NDhX8cDDr62eBTrYVgITz8oudr9Da/BBMbbEEREBl1XSEFr8fuToZPUGPcxkLcvs5YBPQ7/bVQRAE6Q+@lists.infradead.org, AJvYcCXfku7ixu8QSNPgNQSttXyyKrKIpsduv9xUUCluC5yeBLcSw+Qs2FSbcMoIHeyDlC4K39CpQYbfJDQP@lists.infradead.org X-Gm-Message-State: AOJu0YwcfJitrDiBVEtuQETkZVRD9IaamBDPjZf65L+Oeugmj1ahQ9zp owkoIhKPpZdZLvwvK28vfh0ZtoG4A/220rGY3RC0yRW1WZQqEvXK X-Gm-Gg: ASbGnctLZicZ7Xj0zX5/GOKUkhucCjtpgSSoiHiXueans/Sl3hteCu7k1uQsGKELt3c rawc+KlC2/CBBSuHOVnyBPoy4Ho3sTlmawHimtwgKte9eNt/MXXKzzrr4RCnnODDR7bxJdeMrjd ULblBwSGv4hDYoYOWquynFMEvPHQ6o0qzx0YH3Om7zoBLkMi1oDb+Sq3bDaAjdEcvlmxeFAtuKN MqywKcqeY3/uA5DB8NogXtP4GDmBHrR1R1A47YdNw2aa8DB0F5axQp424m9t//+SIPnj3a6J/qc 14W7SDocuU2gYD7QD5bcQiWaiaTB6HWfGaHnqVrSb4a+IPKvLo4luMJdlPrmJSGSBbBP0QBFh8y bsYrNpwePxtGLdFvKff5DfYL3yfk= X-Google-Smtp-Source: AGHT+IG73wjyA14hJiUHlYys0uHoP/Gq7sjSROhJNkoVVZBSO2iuHMJltm4VuHHk5qyF/mQobHC8yg== X-Received: by 2002:a05:600c:1e1c:b0:43d:1bf6:15e1 with SMTP id 5b1f17b1804b1-43f39622728mr61973155e9.1.1744489627005; Sat, 12 Apr 2025 13:27:07 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d802sm131797845e9.1.2025.04.12.13.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 13:27:06 -0700 (PDT) From: Ivaylo Ivanov To: Krzysztof Kozlowski , Vinod Koul , Conor Dooley , Alim Akhtar , Kishon Vijay Abraham I , Rob Herring , Philipp Zabel Cc: linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v4 08/10] phy: phy-snps-eusb2: refactor reference clock init Date: Sat, 12 Apr 2025 23:26:18 +0300 Message-ID: <20250412202620.738150-9-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> References: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250412_132708_858966_12AEFD75 X-CRM114-Status: GOOD ( 12.41 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Instead of matching frequencies with a switch and case, introduce a table-based lookup. This improves readability, reduces redundancy, and makes it easier to extend support for additional frequencies in the future. Signed-off-by: Ivaylo Ivanov Reviewed-by: Dmitry Baryshkov --- drivers/phy/phy-snps-eusb2.c | 61 +++++++++++++++++++----------------- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index f05333901..8caa62c0b 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -192,44 +192,47 @@ static void qcom_eusb2_default_parameters(struct snps_eusb2_hsphy *phy) FIELD_PREP(PHY_CFG_TX_HS_XV_TUNE_MASK, 0x0)); } +struct snps_eusb2_ref_clk { + unsigned long freq; + u32 fsel_val; + u32 div_7_0_val; + u32 div_11_8_val; +}; + +static const struct snps_eusb2_ref_clk qcom_eusb2_ref_clk[] = { + { 19200000, FSEL_19_2_MHZ_VAL, DIV_7_0_19_2_MHZ_VAL, DIV_11_8_19_2_MHZ_VAL }, + { 38400000, FSEL_38_4_MHZ_VAL, DIV_7_0_38_4_MHZ_VAL, DIV_11_8_38_4_MHZ_VAL }, +}; + static int qcom_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy) { + const struct snps_eusb2_ref_clk *config = NULL; unsigned long ref_clk_freq = clk_get_rate(phy->ref_clk); - switch (ref_clk_freq) { - case 19200000: - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, - FSEL_MASK, - FIELD_PREP(FSEL_MASK, FSEL_19_2_MHZ_VAL)); - - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_2, - PHY_CFG_PLL_FB_DIV_7_0_MASK, - DIV_7_0_19_2_MHZ_VAL); - - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, - PHY_CFG_PLL_FB_DIV_11_8_MASK, - DIV_11_8_19_2_MHZ_VAL); - break; - - case 38400000: - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, - FSEL_MASK, - FIELD_PREP(FSEL_MASK, FSEL_38_4_MHZ_VAL)); - - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_2, - PHY_CFG_PLL_FB_DIV_7_0_MASK, - DIV_7_0_38_4_MHZ_VAL); - - snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, - PHY_CFG_PLL_FB_DIV_11_8_MASK, - DIV_11_8_38_4_MHZ_VAL); - break; + for (int i = 0; i < ARRAY_SIZE(qcom_eusb2_ref_clk); i++) { + if (qcom_eusb2_ref_clk[i].freq == ref_clk_freq) { + config = &qcom_eusb2_ref_clk[i]; + break; + } + } - default: + if (!config) { dev_err(&phy->phy->dev, "unsupported ref_clk_freq:%lu\n", ref_clk_freq); return -EINVAL; } + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL_COMMON0, + FSEL_MASK, + FIELD_PREP(FSEL_MASK, config->fsel_val)); + + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_2, + PHY_CFG_PLL_FB_DIV_7_0_MASK, + config->div_7_0_val); + + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, + PHY_CFG_PLL_FB_DIV_11_8_MASK, + config->div_11_8_val); + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG_CTRL_3, PHY_CFG_PLL_REF_DIV, PLL_REF_DIV_VAL); From patchwork Sat Apr 12 20:26:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 14049148 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 075A5C369AB for ; Sat, 12 Apr 2025 20:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ddB2moOLh8W+Nf4/tiz70/DdZ3Cg+UKCQwjuClvxVso=; b=WPs8sg0/gxbFmQ fpHP/dyLG+kAR0vs0q6NmjSfL/4T1n1rOcRQ7WVmExp7kvuYoVU8kE67QABqsYgRn/2BTurWsQLjX mKeWOZCWhryBamTtxGKsLpw+mBuh7fvqFIvvuh0ZRwy2a7rS+FHNu/zx2fINlg1lVTsM+YJaFwKNK 3LAuIbGgDAtR5we+5CWTf/euGXRFlBHQwa0drtJPbmf08hGhQB4dQ2ylRHSBNbnQqDz368wYxxYXE nFrcyRM34gwZF/T+j0GAZBn4U8Sc3/xhrVk5jN/VhMa29cHoT6PeNfU001r77S1+IvU8S5jpbl8o0 tI4FPUyPWaXOjHl8DXFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hhV-0000000GQzk-3FUF; Sat, 12 Apr 2025 20:43:41 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hRW-0000000GP5F-3PTd; Sat, 12 Apr 2025 20:27:11 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so27262085e9.1; Sat, 12 Apr 2025 13:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744489629; x=1745094429; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oiAf53C7ZnTbYps0PrN9/DfVbsgINyfTunf3aDFoB+k=; b=VCvE+DjjvchNSb30GeSlMX/eAP+u9UdLukkKBkwjshGoGuOkhfP8291z1jmYsKhm5h w3uVAOu6HZP6fKBub/hm5ifRcKy+np4vHPOtE0BcNg0h2LlnTF3ZjNnGlFIsMi5GnZzn GA7xF64WeJ5+32Gg8NLSOrhIpEnu3h07bsFVxkQddJMTuIOAsbhEF3yepIrhSCCKZcRQ ak4Vwby4M9ZtVIdx34Tn3qiw6RESEDo9FFFk/oi1IcHhE71MIkYk/kIfNIuXxoWmxLah KFYJRK8+G/JvPNhwiG5z//DgN/O4rV9EfR32lzZx8EcDvDCaKYggM2u5lQq6JR1fFJ1U BVjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744489629; x=1745094429; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oiAf53C7ZnTbYps0PrN9/DfVbsgINyfTunf3aDFoB+k=; b=hDQ9b0mcVb17riEJO+woX27MIGRqmWJJ7l6CAsTHUPUX/PpTR5RT9xfiBC+h6PCFCs woBSr5GcFaNwRF1F6r+SPA4lj1WcND6CwxiRT9RXXHSrcQIhUWf1s+7EU/pUIrMjDWRO qFVvjdOJAGHBrGO0GFSmerBBq7wWU9jfJs9DDvV7VdudEqqSanRA6Tu45L/oXvCODIrP KVxm3yKBKawEJ+gKXlrOGu2R0nIji02yURbC4SnqW/XlVSHMIWLD7gyJPwJ6RweOcYiP S4UzFO8hGOkrpUSzsTIFfivQQkxVW775SF8dr8KXu5u1VJv2E7BlAsEuGwXIzpgVQACU NqxQ== X-Forwarded-Encrypted: i=1; AJvYcCV2yTGrEmIV7g6BvvraJCCLiJ3sSDYRc8GhSgaoR4LXmY+rNZDhmLF1D2x6l8EF69Yymq2vW2vpVdMOlvjxNg8Z@lists.infradead.org, AJvYcCWSKJkyGfg0jfmghSEoWMGLZwYs5caeF2fIfVbVfxHk+SB3Ioasc4oH1PNwdxfLWFGfubCXsXavw6rc@lists.infradead.org X-Gm-Message-State: AOJu0Yx/SjUbuFOyKcrPMEG9hbieCs+XDFxYi0nN373tnctFbcFprxDw NaOn58FW+6bDTjO7wL8F4mEtsPVaEMYDCuDAcIMuQQnytGZF0nBf X-Gm-Gg: ASbGncuNHg5lwYoZglYfkRbd+vWRifQivvAPyld45ya/zfVLufWbHShU7PqdkJX+BLe zhtlLegJhMUxVC2gv1LNYWn10qFKbYHYFCR7RITleJckhC/Sj13bhsV7kyTDJAbO+2HF+R2WVJk NWg3mAOMi2soFmPL8i1LZHPj05Cy4PAvx8MOH6NtwGFtxd6141RlVg2/Dzk/AfUlWI0S3wcI9rT j5rNYUEOlI/seRQJ/yFz6zIhNVkfDsBMfm4zpnk1KvfnaSfkC1j8JcRvK3Bo9FGbQXYr9gk1vEY LZGSpkAuv81SZHN6cs5PKpquxBF3dubeNqKUimhUicCTkKhtjb0lYzBWVEUaQ1paYneYP6RCJX+ Z5BiQ/QwORwEYV0GGZbhxIHpILKs= X-Google-Smtp-Source: AGHT+IG0+EQ5ZHlXT+K0utbNPBKa36hf+YEVRE97ohaH5aCTaJIRJCESsDT0lPqorgHmB8JT1EHFPw== X-Received: by 2002:a05:600c:83c4:b0:43c:fb8e:aec0 with SMTP id 5b1f17b1804b1-43f3a925ademr59846615e9.1.1744489628646; Sat, 12 Apr 2025 13:27:08 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d802sm131797845e9.1.2025.04.12.13.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 13:27:07 -0700 (PDT) From: Ivaylo Ivanov To: Krzysztof Kozlowski , Vinod Koul , Conor Dooley , Alim Akhtar , Kishon Vijay Abraham I , Rob Herring , Philipp Zabel Cc: linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v4 09/10] phy: phy-snps-eusb2: add support for exynos2200 Date: Sat, 12 Apr 2025 23:26:19 +0300 Message-ID: <20250412202620.738150-10-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> References: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250412_132710_859493_4ED6FF1F X-CRM114-Status: GOOD ( 21.84 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The Exynos2200 SoC reuses the Synopsis eUSB2 PHY IP, alongside an external repeater, for USB 2.0. Add support for it to the existing driver, while keeping in mind that it requires enabled more than the reference clock. Signed-off-by: Ivaylo Ivanov Acked-by: Dmitry Baryshkov --- drivers/phy/Kconfig | 2 +- drivers/phy/phy-snps-eusb2.c | 162 ++++++++++++++++++++++++++++++++++- 2 files changed, 159 insertions(+), 5 deletions(-) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 11c166204..58c911e1b 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -45,7 +45,7 @@ config PHY_PISTACHIO_USB config PHY_SNPS_EUSB2 tristate "SNPS eUSB2 PHY Driver" - depends on OF && (ARCH_QCOM || COMPILE_TEST) + depends on OF && (ARCH_EXYNOS || ARCH_QCOM || COMPILE_TEST) select GENERIC_PHY help Enable support for the USB high-speed SNPS eUSB2 phy on select diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index 8caa62c0b..1ce18cbac 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -13,6 +13,39 @@ #include #include +#define EXYNOS_USB_PHY_HS_PHY_CTRL_RST (0x0) +#define USB_PHY_RST_MASK GENMASK(1, 0) +#define UTMI_PORT_RST_MASK GENMASK(5, 4) + +#define EXYNOS_USB_PHY_HS_PHY_CTRL_COMMON (0x4) +#define RPTR_MODE BIT(10) +#define FSEL_20_MHZ_VAL (0x1) +#define FSEL_24_MHZ_VAL (0x2) +#define FSEL_26_MHZ_VAL (0x3) +#define FSEL_48_MHZ_VAL (0x2) + +#define EXYNOS_USB_PHY_CFG_PLLCFG0 (0x8) +#define PHY_CFG_PLL_FB_DIV_19_8_MASK GENMASK(19, 8) +#define DIV_19_8_19_2_MHZ_VAL (0x170) +#define DIV_19_8_20_MHZ_VAL (0x160) +#define DIV_19_8_24_MHZ_VAL (0x120) +#define DIV_19_8_26_MHZ_VAL (0x107) +#define DIV_19_8_48_MHZ_VAL (0x120) + +#define EXYNOS_USB_PHY_CFG_PLLCFG1 (0xc) +#define EXYNOS_PHY_CFG_PLL_FB_DIV_11_8_MASK GENMASK(11, 8) +#define EXYNOS_DIV_11_8_19_2_MHZ_VAL (0x0) +#define EXYNOS_DIV_11_8_20_MHZ_VAL (0x0) +#define EXYNOS_DIV_11_8_24_MHZ_VAL (0x0) +#define EXYNOS_DIV_11_8_26_MHZ_VAL (0x0) +#define EXYNOS_DIV_11_8_48_MHZ_VAL (0x1) + +#define EXYNOS_PHY_CFG_TX (0x14) +#define EXYNOS_PHY_CFG_TX_FSLS_VREF_TUNE_MASK GENMASK(2, 1) + +#define EXYNOS_USB_PHY_UTMI_TESTSE (0x20) +#define TEST_IDDQ BIT(6) + #define QCOM_USB_PHY_UTMI_CTRL0 (0x3c) #define SLEEPM BIT(0) #define OPMODE_MASK GENMASK(4, 3) @@ -123,6 +156,8 @@ static const char * const eusb2_hsphy_vreg_names[] = { struct snps_eusb2_phy_drvdata { int (*phy_init)(struct phy *p); + const char * const *clk_names; + int num_clks; }; struct snps_eusb2_hsphy { @@ -130,6 +165,7 @@ struct snps_eusb2_hsphy { void __iomem *base; struct clk *ref_clk; + struct clk_bulk_data *clks; struct reset_control *phy_reset; struct regulator_bulk_data vregs[EUSB2_NUM_VREGS]; @@ -199,6 +235,46 @@ struct snps_eusb2_ref_clk { u32 div_11_8_val; }; +static const struct snps_eusb2_ref_clk exynos_eusb2_ref_clk[] = { + { 19200000, FSEL_19_2_MHZ_VAL, DIV_19_8_19_2_MHZ_VAL, EXYNOS_DIV_11_8_19_2_MHZ_VAL }, + { 20000000, FSEL_20_MHZ_VAL, DIV_19_8_20_MHZ_VAL, EXYNOS_DIV_11_8_20_MHZ_VAL }, + { 24000000, FSEL_24_MHZ_VAL, DIV_19_8_24_MHZ_VAL, EXYNOS_DIV_11_8_24_MHZ_VAL }, + { 26000000, FSEL_26_MHZ_VAL, DIV_19_8_26_MHZ_VAL, EXYNOS_DIV_11_8_26_MHZ_VAL }, + { 48000000, FSEL_48_MHZ_VAL, DIV_19_8_48_MHZ_VAL, EXYNOS_DIV_11_8_48_MHZ_VAL }, +}; + +static int exynos_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy) +{ + const struct snps_eusb2_ref_clk *config = NULL; + unsigned long ref_clk_freq = clk_get_rate(phy->ref_clk); + + for (int i = 0; i < ARRAY_SIZE(exynos_eusb2_ref_clk); i++) { + if (exynos_eusb2_ref_clk[i].freq == ref_clk_freq) { + config = &exynos_eusb2_ref_clk[i]; + break; + } + } + + if (!config) { + dev_err(&phy->phy->dev, "unsupported ref_clk_freq:%lu\n", ref_clk_freq); + return -EINVAL; + } + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_COMMON, + FSEL_MASK, + FIELD_PREP(FSEL_MASK, config->fsel_val)); + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_CFG_PLLCFG0, + PHY_CFG_PLL_FB_DIV_19_8_MASK, + FIELD_PREP(PHY_CFG_PLL_FB_DIV_19_8_MASK, + config->div_7_0_val)); + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_CFG_PLLCFG1, + EXYNOS_PHY_CFG_PLL_FB_DIV_11_8_MASK, + config->div_11_8_val); + return 0; +} + static const struct snps_eusb2_ref_clk qcom_eusb2_ref_clk[] = { { 19200000, FSEL_19_2_MHZ_VAL, DIV_7_0_19_2_MHZ_VAL, DIV_11_8_19_2_MHZ_VAL }, { 38400000, FSEL_38_4_MHZ_VAL, DIV_7_0_38_4_MHZ_VAL, DIV_11_8_38_4_MHZ_VAL }, @@ -239,6 +315,55 @@ static int qcom_eusb2_ref_clk_init(struct snps_eusb2_hsphy *phy) return 0; } +static int exynos_snps_eusb2_hsphy_init(struct phy *p) +{ + struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); + int ret; + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_RST, + USB_PHY_RST_MASK | UTMI_PORT_RST_MASK, + USB_PHY_RST_MASK | UTMI_PORT_RST_MASK); + fsleep(50); /* required after holding phy in reset */ + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_COMMON, + RPTR_MODE, RPTR_MODE); + + /* update ref_clk related registers */ + ret = exynos_eusb2_ref_clk_init(phy); + if (ret) + return ret; + + /* default parameter: tx fsls-vref */ + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_PHY_CFG_TX, + EXYNOS_PHY_CFG_TX_FSLS_VREF_TUNE_MASK, + FIELD_PREP(EXYNOS_PHY_CFG_TX_FSLS_VREF_TUNE_MASK, 0x0)); + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_UTMI_TESTSE, + TEST_IDDQ, 0); + fsleep(10); /* required after releasing test_iddq */ + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_RST, + USB_PHY_RST_MASK, 0); + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_COMMON, + PHY_ENABLE, PHY_ENABLE); + + snps_eusb2_hsphy_write_mask(phy->base, EXYNOS_USB_PHY_HS_PHY_CTRL_RST, + UTMI_PORT_RST_MASK, 0); + + return 0; +} + +static const char * const exynos_eusb2_hsphy_clock_names[] = { + "ref", "bus", "ctrl", +}; + +static const struct snps_eusb2_phy_drvdata exynos2200_snps_eusb2_phy = { + .phy_init = exynos_snps_eusb2_hsphy_init, + .clk_names = exynos_eusb2_hsphy_clock_names, + .num_clks = ARRAY_SIZE(exynos_eusb2_hsphy_clock_names), +}; + static int qcom_snps_eusb2_hsphy_init(struct phy *p) { struct snps_eusb2_hsphy *phy = phy_get_drvdata(p); @@ -315,8 +440,14 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p) return 0; } +static const char * const qcom_eusb2_hsphy_clock_names[] = { + "ref", +}; + static const struct snps_eusb2_phy_drvdata sm8550_snps_eusb2_phy = { .phy_init = qcom_snps_eusb2_hsphy_init, + .clk_names = qcom_eusb2_hsphy_clock_names, + .num_clks = ARRAY_SIZE(qcom_eusb2_hsphy_clock_names), }; static int snps_eusb2_hsphy_init(struct phy *p) @@ -334,7 +465,7 @@ static int snps_eusb2_hsphy_init(struct phy *p) goto disable_vreg; } - ret = clk_prepare_enable(phy->ref_clk); + ret = clk_bulk_prepare_enable(phy->data->num_clks, phy->clks); if (ret) { dev_err(&p->dev, "failed to enable ref clock, %d\n", ret); goto disable_vreg; @@ -361,7 +492,7 @@ static int snps_eusb2_hsphy_init(struct phy *p) return 0; disable_ref_clk: - clk_disable_unprepare(phy->ref_clk); + clk_bulk_disable_unprepare(phy->data->num_clks, phy->clks); disable_vreg: regulator_bulk_disable(ARRAY_SIZE(phy->vregs), phy->vregs); @@ -415,8 +546,28 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) if (IS_ERR(phy->phy_reset)) return PTR_ERR(phy->phy_reset); - phy->ref_clk = devm_clk_get(dev, "ref"); - if (IS_ERR(phy->ref_clk)) + phy->clks = devm_kcalloc(dev, phy->data->num_clks, sizeof(*phy->clks), + GFP_KERNEL); + if (!phy->clks) + return -ENOMEM; + + for (int i = 0; i < phy->data->num_clks; ++i) + phy->clks[i].id = phy->data->clk_names[i]; + + ret = devm_clk_bulk_get(dev, phy->data->num_clks, phy->clks); + if (ret) + return dev_err_probe(dev, ret, + "failed to get phy clock(s)\n"); + + phy->ref_clk = NULL; + for (int i = 0; i < phy->data->num_clks; ++i) { + if (!strcmp(phy->clks[i].id, "ref")) { + phy->ref_clk = phy->clks[i].clk; + break; + } + } + + if (IS_ERR_OR_NULL(phy->ref_clk)) return dev_err_probe(dev, PTR_ERR(phy->ref_clk), "failed to get ref clk\n"); @@ -456,6 +607,9 @@ static const struct of_device_id snps_eusb2_hsphy_of_match_table[] = { { .compatible = "qcom,sm8550-snps-eusb2-phy", .data = &sm8550_snps_eusb2_phy, + }, { + .compatible = "samsung,exynos2200-snps-eusb2-phy", + .data = &exynos2200_snps_eusb2_phy, }, { }, }; MODULE_DEVICE_TABLE(of, snps_eusb2_hsphy_of_match_table); From patchwork Sat Apr 12 20:26:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivaylo Ivanov X-Patchwork-Id: 14049153 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3C2DC369AB for ; Sat, 12 Apr 2025 20:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iRPSfnrIbKYQj3AWYcen/mrqbvHeJxP7tQruvEbS25s=; b=4HF3uqRlLfENca ppXcpmTjIs6tfeR/uDdSmMyMSZwtxAAX02rvNi+dA4aleAnhsY6OujOxMMglPoTOK9cwKMvObNXtA dn1ANGrb7/3N61X76JFOY00bsNxnBYbd3ak5SNl5eXwtq+DmowOEzN38ntw5Q14cT+mXDDqKj9+/K uUDk+VZQgm0Q4u957LfP4AhXRDrseyW9ftb6ShV+BuqbV2jUWHRlk1DOKOJgu7EUkovWEksS3u/MW GdFaxEbnfbY3RYtCpIqr5yKIz+tDmREcQT6WN3Z+sP4QDKHYmcxxPoAOQxVtkgd7tDS9UuqsktQJQ pO1yxR0FMLCJfRGIVL9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hjI-0000000GR6x-34jD; Sat, 12 Apr 2025 20:45:32 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u3hRX-0000000GP5t-3ehe; Sat, 12 Apr 2025 20:27:13 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-43d04ea9d9aso14965305e9.3; Sat, 12 Apr 2025 13:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744489630; x=1745094430; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=olWmtpJVJyP5ihquepeKVhUKSgcRCRnX8hMSMQjAVm0=; b=AeCQ5TGxMKGDAi4pe7sTw6O0+0Kk/28aPjtoDnyF+1JMx1CjWNj1fFkvYLZzjalCq7 /oWWhb0X511XnzpXJUdl0ho0k1BOnAmpwX/5dAN8CrDkBvh7IPqXyaXOiPYHnESRJ/DX ABxpgSnuuogwDUGnF35DRNZc6ac0hEXLjk7t4GeMYlYNN37H23p/btZWCEGAvTCAYpxd SXN6WbmYZrq8yqBpJyqZfaPcQKhkKosD8vpskqDCIrwVqTupGbg+LpAgklAxYTqBiSAM 7+PGPzCqHfGjJFwJ6csAoxdlYIVIORxjWTVWlvfdGKToXC0U/ZWGV7IQTGxJaJc+Wfej F2og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744489630; x=1745094430; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=olWmtpJVJyP5ihquepeKVhUKSgcRCRnX8hMSMQjAVm0=; b=ozDM6YK8YhVoC8HZFwF+rXjn/ErR00eaV+rMQOBm5t4kkp5137kddmqevNiLKpgLVO hyzLh4zu7Suu4u0o6BrJjunbWtOwMZD45zZzZWYO1vjYW2YjxnHvwSoAwwig+VcFh/hn tepgICqzw8+WIHpOYDIOEzhwLkThGLeh+79rNYcXzEmvkMYr0gIjjjmWbzy4UA3T+JkQ foVMOY6dydIZcyNVA/VWWCf0HOri0IlX4+NDrmhODL35JjbQWti1qpMKnw3FjiysyMid 3cxERjWr8MaYOnj7ZEbpBC4Hd1tq1H34r0jJcYrRWEMZPux9o98TMm29x9ugEVirBmBe wK/A== X-Forwarded-Encrypted: i=1; AJvYcCWa6hXPLdqQxX8yqg6hfSG68fL5ECJzJ2Uu4lvhSgT3EE9td1hk/20CJBtTy3Y8eXUKuLrdfIo8mNq1OHYa9EOz@lists.infradead.org, AJvYcCXS9F5H13UdXyklzJLYmqE9kDFlddLg10BSTKhPzRay0voclQYAJVfLwklNOtoiW2fuB/DTaeU/qLLo@lists.infradead.org X-Gm-Message-State: AOJu0YzgQdee7P6UGANriZ0EkQDOrVj+fZedJufcmS1faWuxiKJq3uR2 mw0Jzvg8ClP8jirHwbIZ5q5EHREkpgQAwGy/fbCBPHmyXEDoTbL3 X-Gm-Gg: ASbGnct1zBcNulqD5P3alxiOh2FMMOGUB+Diray/460JMBBzqRVFUUroAsMumrh5Faj /1jJUayAQGc5pcL3czcCluogCsCjUui2x9L2OCTgJcJ4VG4cyZbBmajR7HIU1A/YCJuY0EUEbqD c4O9QnTpVRwLWR8SpOQSq+QX2MUyIbgmi94nf3H00SDQxlzCw7YGwyUMw8FUDTJ+KOEC+RBF8LJ WnF82Jxm05dFtWqnjD9mmqHt999tmi3qnzwx4iJFJ96fsmTWAAnSb7xFFkPPnuUl3dGyvstHxcN oqhZOnNftCuCIBzy8RMzruMtyAjpABXr+Fhe8vcMWQNefO/AojDpgjrP/rNY2hfrdb+UynG6zMU YE1AJF4mXNp7+ED8L X-Google-Smtp-Source: AGHT+IEtxyW3UZ/3u0BXgkHZsM+YoFZNao9NjKVr3gYfBTIxWSJRFnSO9EXDpk7LBa79WamAspfqPg== X-Received: by 2002:a05:600c:3b19:b0:43d:b3:fb1 with SMTP id 5b1f17b1804b1-43f3a9b02f9mr74840105e9.27.1744489630266; Sat, 12 Apr 2025 13:27:10 -0700 (PDT) Received: from ivaylo-T580.. (91-139-201-119.stz.ddns.bulsat.com. [91.139.201.119]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f2338d802sm131797845e9.1.2025.04.12.13.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 13:27:09 -0700 (PDT) From: Ivaylo Ivanov To: Krzysztof Kozlowski , Vinod Koul , Conor Dooley , Alim Akhtar , Kishon Vijay Abraham I , Rob Herring , Philipp Zabel Cc: linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v4 10/10] phy: exynos5-usbdrd: support Exynos USBDRD 3.2 4nm controller Date: Sat, 12 Apr 2025 23:26:20 +0300 Message-ID: <20250412202620.738150-11-ivo.ivanov.ivanov1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> References: <20250412202620.738150-1-ivo.ivanov.ivanov1@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250412_132712_016636_3540B8D4 X-CRM114-Status: GOOD ( 24.45 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Add support for the Exynos USB 3.2 DRD 4nm controller. It's used in recent 4nm SoCs like Exynos2200 and Exynos2400. This device consists of 3 underlying and independent phys: SEC link control phy, Synopsys eUSB 2.0 and Synopsys USBDP/SS combophy. Unlike older device designs, where the internal phy blocks were all IP of Samsung, Synopsys phys are present. This means that the link controller is now mapped differently to account for missing bits and registers. The Synopsys phys also have separate register bases. As there are non-SEC PHYs present now, it doesn't make much sense to implement them in this driver. They are expected to be configured by external drivers, so pass phandles to them. USBDRD3.2 link controller set up is still required beforehand. This commit adds the necessary changes for USB HS to work. USB SS and DisplayPort are out of scope in this commit and will be introduced in the future. Signed-off-by: Ivaylo Ivanov --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 227 ++++++++++++++++++-- include/linux/soc/samsung/exynos-regs-pmu.h | 3 + 2 files changed, 215 insertions(+), 15 deletions(-) diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c index 817fddee0..f9a657642 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -36,6 +36,21 @@ #define EXYNOS5_FSEL_26MHZ 0x6 #define EXYNOS5_FSEL_50MHZ 0x7 +/* USB 3.2 DRD 4nm PHY link controller registers */ +#define EXYNOS2200_DRD_CLKRST 0x0c +#define EXYNOS2200_CLKRST_LINK_PCLK_SEL BIT(1) + +#define EXYNOS2200_DRD_UTMI 0x10 +#define EXYNOS2200_UTMI_FORCE_VBUSVALID BIT(1) +#define EXYNOS2200_UTMI_FORCE_BVALID BIT(0) + +#define EXYNOS2200_DRD_HSP_MISC 0x114 +#define HSP_MISC_SET_REQ_IN2 BIT(4) +#define HSP_MISC_RES_TUNE GENMASK(1, 0) +#define RES_TUNE_PHY1_PHY2 0x1 +#define RES_TUNE_PHY1 0x2 +#define RES_TUNE_PHY2 0x3 + /* Exynos5: USB 3.0 DRD PHY registers */ #define EXYNOS5_DRD_LINKSYSTEM 0x04 #define LINKSYSTEM_XHCI_VERSION_CONTROL BIT(27) @@ -389,6 +404,7 @@ struct exynos5_usbdrd_phy_drvdata { * @clks: clocks for register access * @core_clks: core clocks for phy (ref, pipe3, utmi+, ITP, etc. as required) * @drv_data: pointer to SoC level driver data structure + * @hs_phy: pointer to non-Samsung IP high-speed phy controller * @phy_mutex: mutex protecting phy_init/exit & TCPC callbacks * @phys: array for 'EXYNOS5_DRDPHYS_NUM' number of PHY * instances each with its 'phy' and 'phy_cfg'. @@ -406,6 +422,7 @@ struct exynos5_usbdrd_phy { struct clk_bulk_data *clks; struct clk_bulk_data *core_clks; const struct exynos5_usbdrd_phy_drvdata *drv_data; + struct phy *hs_phy; struct mutex phy_mutex; struct phy_usb_instance { struct phy *phy; @@ -1075,6 +1092,149 @@ static const struct phy_ops exynos5_usbdrd_phy_ops = { .owner = THIS_MODULE, }; +static void exynos2200_usbdrd_utmi_init(struct exynos5_usbdrd_phy *phy_drd) +{ + /* Configure non-Samsung IP PHY, responsible for UTMI */ + phy_init(phy_drd->hs_phy); +} + +static void exynos2200_usbdrd_link_init(struct exynos5_usbdrd_phy *phy_drd) +{ + void __iomem *regs_base = phy_drd->reg_phy; + u32 reg; + + /* + * Disable HWACG (hardware auto clock gating control). This will force + * QACTIVE signal in Q-Channel interface to HIGH level, to make sure + * the PHY clock is not gated by the hardware. + */ + reg = readl(regs_base + EXYNOS850_DRD_LINKCTRL); + reg |= LINKCTRL_FORCE_QACT; + writel(reg, regs_base + EXYNOS850_DRD_LINKCTRL); + + /* De-assert link reset */ + reg = readl(regs_base + EXYNOS2200_DRD_CLKRST); + reg &= ~CLKRST_LINK_SW_RST; + writel(reg, regs_base + EXYNOS2200_DRD_CLKRST); + + /* Set link VBUS Valid */ + reg = readl(regs_base + EXYNOS2200_DRD_UTMI); + reg |= EXYNOS2200_UTMI_FORCE_BVALID | EXYNOS2200_UTMI_FORCE_VBUSVALID; + writel(reg, regs_base + EXYNOS2200_DRD_UTMI); +} + +static void +exynos2200_usbdrd_link_attach_detach_pipe3_phy(struct phy_usb_instance *inst) +{ + struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); + void __iomem *regs_base = phy_drd->reg_phy; + u32 reg; + + reg = readl(regs_base + EXYNOS850_DRD_LINKCTRL); + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) { + /* force pipe3 signal for link */ + reg &= ~LINKCTRL_FORCE_PHYSTATUS; + reg |= LINKCTRL_FORCE_PIPE_EN | LINKCTRL_FORCE_RXELECIDLE; + } else { + /* disable forcing pipe interface */ + reg &= ~LINKCTRL_FORCE_PIPE_EN; + } + writel(reg, regs_base + EXYNOS850_DRD_LINKCTRL); + + reg = readl(regs_base + EXYNOS2200_DRD_HSP_MISC); + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) { + /* calibrate only eUSB phy */ + reg |= FIELD_PREP(HSP_MISC_RES_TUNE, RES_TUNE_PHY1); + reg |= HSP_MISC_SET_REQ_IN2; + } else { + /* calibrate for dual phy */ + reg |= FIELD_PREP(HSP_MISC_RES_TUNE, RES_TUNE_PHY1_PHY2); + reg &= ~HSP_MISC_SET_REQ_IN2; + } + writel(reg, regs_base + EXYNOS2200_DRD_HSP_MISC); + + reg = readl(regs_base + EXYNOS2200_DRD_CLKRST); + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) + reg &= ~EXYNOS2200_CLKRST_LINK_PCLK_SEL; + else + reg |= EXYNOS2200_CLKRST_LINK_PCLK_SEL; + + writel(reg, regs_base + EXYNOS2200_DRD_CLKRST); +} + +static int exynos2200_usbdrd_phy_init(struct phy *phy) +{ + struct phy_usb_instance *inst = phy_get_drvdata(phy); + struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); + int ret; + + if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) { + /* Power-on PHY ... */ + ret = regulator_bulk_enable(phy_drd->drv_data->n_regulators, + phy_drd->regulators); + if (ret) { + dev_err(phy_drd->dev, + "Failed to enable PHY regulator(s)\n"); + return ret; + } + } + /* + * ... and ungate power via PMU. Without this here, we get an SError + * trying to access PMA registers + */ + exynos5_usbdrd_phy_isol(inst, false); + + ret = clk_bulk_prepare_enable(phy_drd->drv_data->n_clks, phy_drd->clks); + if (ret) + return ret; + + /* Set up the link controller */ + exynos2200_usbdrd_link_init(phy_drd); + + /* UTMI or PIPE3 link preparation */ + exynos2200_usbdrd_link_attach_detach_pipe3_phy(inst); + + /* UTMI or PIPE3 specific init */ + inst->phy_cfg->phy_init(phy_drd); + + clk_bulk_disable_unprepare(phy_drd->drv_data->n_clks, phy_drd->clks); + + return 0; +} + +static int exynos2200_usbdrd_phy_exit(struct phy *phy) +{ + struct phy_usb_instance *inst = phy_get_drvdata(phy); + struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst); + void __iomem *regs_base = phy_drd->reg_phy; + u32 reg; + int ret; + + ret = clk_bulk_prepare_enable(phy_drd->drv_data->n_clks, phy_drd->clks); + if (ret) + return ret; + + reg = readl(regs_base + EXYNOS2200_DRD_UTMI); + reg &= ~(EXYNOS2200_UTMI_FORCE_BVALID | EXYNOS2200_UTMI_FORCE_VBUSVALID); + writel(reg, regs_base + EXYNOS2200_DRD_UTMI); + + reg = readl(regs_base + EXYNOS2200_DRD_CLKRST); + reg |= CLKRST_LINK_SW_RST; + writel(reg, regs_base + EXYNOS2200_DRD_CLKRST); + + clk_bulk_disable_unprepare(phy_drd->drv_data->n_clks, phy_drd->clks); + + exynos5_usbdrd_phy_isol(inst, true); + return regulator_bulk_disable(phy_drd->drv_data->n_regulators, + phy_drd->regulators); +} + +static const struct phy_ops exynos2200_usbdrd_phy_ops = { + .init = exynos2200_usbdrd_phy_init, + .exit = exynos2200_usbdrd_phy_exit, + .owner = THIS_MODULE, +}; + static void exynos5_usbdrd_usb_v3p1_pipe_override(struct exynos5_usbdrd_phy *phy_drd) { @@ -1384,27 +1544,37 @@ static int exynos5_usbdrd_phy_clk_handle(struct exynos5_usbdrd_phy *phy_drd) return dev_err_probe(phy_drd->dev, ret, "failed to get phy core clock(s)\n"); - ref_clk = NULL; - for (int i = 0; i < phy_drd->drv_data->n_core_clks; ++i) { - if (!strcmp(phy_drd->core_clks[i].id, "ref")) { - ref_clk = phy_drd->core_clks[i].clk; - break; + if (phy_drd->drv_data->n_core_clks) { + ref_clk = NULL; + for (int i = 0; i < phy_drd->drv_data->n_core_clks; ++i) { + if (!strcmp(phy_drd->core_clks[i].id, "ref")) { + ref_clk = phy_drd->core_clks[i].clk; + break; + } } - } - if (!ref_clk) - return dev_err_probe(phy_drd->dev, -ENODEV, - "failed to find phy reference clock\n"); + if (!ref_clk) + return dev_err_probe(phy_drd->dev, -ENODEV, + "failed to find phy reference clock\n"); - ref_rate = clk_get_rate(ref_clk); - ret = exynos5_rate_to_clk(ref_rate, &phy_drd->extrefclk); - if (ret) - return dev_err_probe(phy_drd->dev, ret, - "clock rate (%ld) not supported\n", - ref_rate); + ref_rate = clk_get_rate(ref_clk); + ret = exynos5_rate_to_clk(ref_rate, &phy_drd->extrefclk); + if (ret) + return dev_err_probe(phy_drd->dev, ret, + "clock rate (%ld) not supported\n", + ref_rate); + } return 0; } +static const struct exynos5_usbdrd_phy_config phy_cfg_exynos2200[] = { + { + .id = EXYNOS5_DRDPHY_UTMI, + .phy_isol = exynos5_usbdrd_phy_isol, + .phy_init = exynos2200_usbdrd_utmi_init, + }, +}; + static int exynos5_usbdrd_orien_sw_set(struct typec_switch_dev *sw, enum typec_orientation orientation) { @@ -1525,6 +1695,19 @@ static const char * const exynos5_regulator_names[] = { "vbus", "vbus-boost", }; +static const struct exynos5_usbdrd_phy_drvdata exynos2200_usb32drd_phy = { + .phy_cfg = phy_cfg_exynos2200, + .phy_ops = &exynos2200_usbdrd_phy_ops, + .pmu_offset_usbdrd0_phy = EXYNOS2200_PHY_CTRL_USB20, + .clk_names = exynos5_clk_names, + .n_clks = ARRAY_SIZE(exynos5_clk_names), + /* clocks and regulators are specific to the underlying PHY blocks */ + .core_clk_names = NULL, + .n_core_clks = 0, + .regulator_names = NULL, + .n_regulators = 0, +}; + static const struct exynos5_usbdrd_phy_drvdata exynos5420_usbdrd_phy = { .phy_cfg = phy_cfg_exynos5, .phy_ops = &exynos5_usbdrd_phy_ops, @@ -1769,6 +1952,9 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = { { .compatible = "google,gs101-usb31drd-phy", .data = &gs101_usbd31rd_phy + }, { + .compatible = "samsung,exynos2200-usb32drd-phy", + .data = &exynos2200_usb32drd_phy, }, { .compatible = "samsung,exynos5250-usbdrd-phy", .data = &exynos5250_usbdrd_phy @@ -1841,6 +2027,17 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev) return PTR_ERR(phy_drd->reg_phy); } + /* + * USB32DRD 4nm controller implements Synopsys eUSB2.0 PHY + * and Synopsys SS/USBDP COMBOPHY, managed by external code. + */ + if (of_property_present(dev->of_node, "phy-names")) { + phy_drd->hs_phy = devm_of_phy_get(dev, dev->of_node, "hs"); + if (IS_ERR(phy_drd->hs_phy)) + return dev_err_probe(dev, PTR_ERR(phy_drd->hs_phy), + "failed to get hs_phy\n"); + } + ret = exynos5_usbdrd_phy_clk_handle(phy_drd); if (ret) return ret; diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h index ce1a3790d..b77187ba5 100644 --- a/include/linux/soc/samsung/exynos-regs-pmu.h +++ b/include/linux/soc/samsung/exynos-regs-pmu.h @@ -185,6 +185,9 @@ /* Only for S5Pv210 */ #define S5PV210_EINT_WAKEUP_MASK 0xC004 +/* Only for Exynos2200 */ +#define EXYNOS2200_PHY_CTRL_USB20 0x72C + /* Only for Exynos4210 */ #define S5P_CMU_CLKSTOP_LCD1_LOWPWR 0x1154 #define S5P_CMU_RESET_LCD1_LOWPWR 0x1174