From patchwork Mon Apr 14 07:27:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Guo X-Patchwork-Id: 14049851 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9188EC3601E for ; Mon, 14 Apr 2025 07:30:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09696280030; Mon, 14 Apr 2025 03:30:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04537280026; Mon, 14 Apr 2025 03:30:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E76BB280030; Mon, 14 Apr 2025 03:30:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CB7FD280026 for ; Mon, 14 Apr 2025 03:30:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7D1578196E for ; Mon, 14 Apr 2025 07:30:40 +0000 (UTC) X-FDA: 83331827040.03.A6BD4BF Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf05.hostedemail.com (Postfix) with ESMTP id 8A54E10000A for ; Mon, 14 Apr 2025 07:30:38 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=Ov8XkArb; spf=pass (imf05.hostedemail.com: domain of gavinguo@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=gavinguo@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744615839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=vEgQw4Oeh0QWFwliFzc7dalA4Bm+0n5fXz5F6FYvZqM=; b=IShy1yxSLwUAS4HT5Tas2Ema8RYRsO91EVe2pIwcTY/DtUa8khbln18bv9rgPHRINu3Z8N OGLSc5do8R4ah7rTTVQDkX/vy6DOOmfbKhBicrHoYB0KGPN+L04WCdVE000tpdykDdDU5f SI4s1S5o8PD8bu1RdbTSgF34MFzCkYI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744615839; a=rsa-sha256; cv=none; b=JOIZO3RLBRVxmEU22l0MEVKg04mDpfZegnlvAKqMkvKCRs3yMbXHrngHXfNltNbSqrHjCM unR64vD2zLAsGWNSFCgVW4sUESgSAmuqrfoZSmkVqifueRQ5YA/MFkds7OOIog8f1a9IrX JHqraOdOmza4ChlteDrulX3cOpCML74= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=Ov8XkArb; spf=pass (imf05.hostedemail.com: domain of gavinguo@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=gavinguo@igalia.com; dmarc=pass (policy=none) header.from=igalia.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vEgQw4Oeh0QWFwliFzc7dalA4Bm+0n5fXz5F6FYvZqM=; b=Ov8XkArbr9XmCTfO400l0lXI5h Vm8AVuIA9VvF7xGsbmxrBIvZs/LsGC+NwwHi49LN00REb73Qj1EceSuoQT1zmzXee9penmNUcJnV3 RotzY8UC+jwnC55zzItWfD1/ykelnhWEkDaphrcmEYtx8W76zeeru1AdAbYsHaAhaJzSv0GzBDndm J5PtSpaNmQORvtKQ9/TVqgWZ0Iav9tZrhX+8nN7yTbWW96O/YCnJ37VQkaHW+3B35k+yd4mER3Rxy evzVNhBrZXo7u9DaMoGov41ijQOW93qjeQylVqVrzUjftpH4z6jcMrePkz3qmCEUTdmUuYmGN1AVM s3pgzcMQ==; Received: from 114-44-251-90.dynamic-ip.hinet.net ([114.44.251.90] helo=gavin-HP-Z840-Workstation..) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1u4EH2-00GG91-A1; Mon, 14 Apr 2025 09:30:32 +0200 From: Gavin Guo To: linux-mm@kvack.org, akpm@linux-foundation.org Cc: willy@infradead.org, ziy@nvidia.com, linmiaohe@huawei.com, hughd@google.com, revest@google.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] mm/huge_memory: fix dereferencing invalid pmd migration entry Date: Mon, 14 Apr 2025 15:27:37 +0800 Message-ID: <20250414072737.1698513-1-gavinguo@igalia.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Stat-Signature: o1ky13kzbpu1fsco57jcram74hm6ygot X-Rspam-User: X-Rspamd-Queue-Id: 8A54E10000A X-Rspamd-Server: rspam08 X-HE-Tag: 1744615838-913523 X-HE-Meta: U2FsdGVkX1/EWdF/itxMijSgZ+FG1ht+A9fg169NfWt/fW7au2mz2iTRrWfewH/QAodrWL+cnqrltsEboPu65o0Nj057WNXE8Gu0bd5x/xCFJfDuaSSXzqRf0bwZYl/GdmF0RZKsP0HTqBs9B3yhF8yvL6jYBGKsnOIAczWB0rl5fvIOfJYVSXR2FkSCj0GSz1eIFTz8tMxMTFux+iUj2OSwUSF5i+Covuo9ADzF6jkpQ2x5vTcXta5wcxpGqlbToCNtVsaS7Q+MvJJOzo12vre3dXSpfDhRDOlQmx4b835IvP0KKFoOoAcNHnW9F5Fdsg3mlGk4Sp2HjVEkpxVkgmL1eeSYlQA/R22gW5wi/IvjnUljcLUZrUlCSP1wmPeosapzQt+yHAe+KovmDv2NpzD/iaLMthXSezZlF4FxNtZJt6wTsLEyY+Oz7zYCW5NATLNCyA7iJZy1gPkXDmaoh4HlnIKB2Par+PdqF63fgRzsG4t1DVTKSUBuhqJBSOZcPjaIFo0c5xBHWRfol2LDPogfD9fr7vSNxzIuy9lsn97Gzfekky9IQRefIF3MJ6D97WTdsBRUNCvyqS5SLcu+5uQCCtknv1c6R6sbSQItmRgb5dA67njnPPpy4Sycgrzc68Nbaw+I7AY08EtCxr6g/1WuCVjAfsbx0xhaIR19PkG3J8DVP7pKMMkGOs+cRpx7K6CcWgSiZ0OQRf/X9PlLauuSt7WaAl0+v3q14I2ZSUYNZTQQ4QoTtdUEvRVVF4cleOJ5U/EaXYxmjgBFK+JKoUDRjQUSXEtXyB8t7ZsFFpLO0p+gQn9aePXfP0H5rZdZpbgb/16hq5y8158OVt3r5r6XiTjPC1RRi7yHYKD7QuRm7o3wUsTuenNZ+es0hPDw9Q4az536lNi5UrLHps5LWax0h0s2OLsxplID7HAbd6qxrFNEn6TcqVRExMA3yU4cZN1su+RhVyG4qF2UWE7 BcgpLjiS 9NyTis+VNrOcEqOq42CXKGuNTNtrB0fgQvm2LLmw3e453e2/9TCqog7jthc15oAfcdlOZo+TfjsT52oWmliFVe+C34kLy+5lIVpF//gKbFggE/YkTfb0mlOnYNZCCw0hC9DmxTA4+0Bc8wGPVr91D1dPXnCEBxbIZmtGdrm/Q+/hlt+JLp53X7qnGywVTHQEUDmQhXordlJhcjvVyy/7cIGNvf0iO81t1J7shL3O1vA3F3nY6bi+jtSZKmuwYw9fxpyFdvYND6ZaK8TkuCFfyUc4Fk+AqG+YsM2zxPh0kailJAW1Y/25j7OXXNMozTDgJ6YT5+XbUH/ZP8XZ7yn14+GmedA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When migrating a THP, concurrent access to the PMD migration entry during a deferred split scan can lead to a page fault, as illustrated below. To prevent this page fault, it is necessary to check the PMD migration entry and return early. In this context, there is no need to use pmd_to_swp_entry and pfn_swap_entry_to_page to verify the equality of the target folio. Since the PMD migration entry is locked, it cannot be served as the target. BUG: unable to handle page fault for address: ffffea60001db008 CPU: 0 UID: 0 PID: 2199114 Comm: tee Not tainted 6.14.0+ #4 NONE Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 RIP: 0010:split_huge_pmd_locked+0x3b5/0x2b60 Call Trace: try_to_migrate_one+0x28c/0x3730 rmap_walk_anon+0x4f6/0x770 unmap_folio+0x196/0x1f0 split_huge_page_to_list_to_order+0x9f6/0x1560 deferred_split_scan+0xac5/0x12a0 shrinker_debugfs_scan_write+0x376/0x470 full_proxy_write+0x15c/0x220 vfs_write+0x2fc/0xcb0 ksys_write+0x146/0x250 do_syscall_64+0x6a/0x120 entry_SYSCALL_64_after_hwframe+0x76/0x7e The bug is found by syzkaller on an internal kernel, then confirmed on upstream. Fixes: 84c3fc4e9c56 ("mm: thp: check pmd migration entry in common path") Cc: stable@vger.kernel.org Signed-off-by: Gavin Guo Acked-by: Hugh Dickins Acked-by: David Hildenbrand --- mm/huge_memory.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) base-commit: a24588245776dafc227243a01bfbeb8a59bafba9 diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 2a47682d1ab7..0cb9547dcff2 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3075,6 +3075,8 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, void split_huge_pmd_locked(struct vm_area_struct *vma, unsigned long address, pmd_t *pmd, bool freeze, struct folio *folio) { + bool pmd_migration = is_pmd_migration_entry(*pmd); + VM_WARN_ON_ONCE(folio && !folio_test_pmd_mappable(folio)); VM_WARN_ON_ONCE(!IS_ALIGNED(address, HPAGE_PMD_SIZE)); VM_WARN_ON_ONCE(folio && !folio_test_locked(folio)); @@ -3085,10 +3087,18 @@ void split_huge_pmd_locked(struct vm_area_struct *vma, unsigned long address, * require a folio to check the PMD against. Otherwise, there * is a risk of replacing the wrong folio. */ - if (pmd_trans_huge(*pmd) || pmd_devmap(*pmd) || - is_pmd_migration_entry(*pmd)) { - if (folio && folio != pmd_folio(*pmd)) - return; + if (pmd_trans_huge(*pmd) || pmd_devmap(*pmd) || pmd_migration) { + if (folio) { + /* + * Do not apply pmd_folio() to a migration entry; and + * folio lock guarantees that it must be of the wrong + * folio anyway. + */ + if (pmd_migration) + return; + if (folio != pmd_folio(*pmd)) + return; + } __split_huge_pmd_locked(vma, pmd, address, freeze); } }