From patchwork Mon Apr 14 09:06:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 14050042 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD7B6C369B2 for ; Mon, 14 Apr 2025 09:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:Content-Type :Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+yO9l6NypA73F3si3x4Rah7yT1uH33qyI9s83W5hLGc=; b=EbCd0wdnMmK13MvJHw2dzTk5Ha FECNpCgyiSs1Tvl6rL7afsXN0cj8z/o4ROBQ1LZIcxc7EPbs87ujqNBo6dLLRAzZJkq4vp1wRSBYm TO9FHdpnD4+wcHhyPX74LBGhbsB94d0ucYNL3h5cMU3X5cKCXMYfayn+W6PvmjG+3ho131M5We/hU yIYCJAU1EEOdsebsVB3bzhJ/RNnF27polnWZtTMDIFKp+NFcDLKL4YlogZTcNeXZOsPWkZVPn8e1P d0fP9qR5nG3PtvU1kmSK/Q4T3DcpT83hCubPl53ZyG0O3Wawvho6jDxmYK4HEYChnw8I7EAREY8/C /dlLdd4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4GAK-00000001HUl-3aJB; Mon, 14 Apr 2025 09:31:44 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4Fo6-00000001DPK-1IRO for linux-arm-kernel@lists.infradead.org; Mon, 14 Apr 2025 09:08:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+yO9l6NypA73F3si3x4Rah7yT1uH33qyI9s83W5hLGc=; b=Ksk8FdndM/GvS83XU3Qi1TovIF vpPq5U5SvLmfp2wxasbmXUh9qY3X2YoHgIJO6b3oub93pP7Dd1egaT4m9heeT9eGCPcOGZvmbKgf9 9Z8KTbCeaQEw0+OCkZq/mcxgMwqk4XSCabtddXndmXVLrufATGSM+RfOY95CuknWnmKcrhGStynCV ZR3IdSgt/rZ6h6J9S1rj3wHIkTC9QtFePf5zyzu1I11pzxmpl6twZFvW/fmukxnfXgN/ZcoAznrMh dRjL+235NHC0AwvnSZebXC/KKzpUog2GsnIaZLqm8e5+mHONY382QqHFMVTw6kF7lIigFrpt7sdfx CAzmR4NA==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:46022 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u4Fm1-0006CQ-1T; Mon, 14 Apr 2025 10:06:37 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1u4FlQ-000XjA-2V; Mon, 14 Apr 2025 10:06:00 +0100 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: [PATCH net-next v2 1/4] net: stmmac: anarion: clean up anarion_config_dt() error handling MIME-Version: 1.0 Content-Disposition: inline Message-Id: Date: Mon, 14 Apr 2025 10:06:00 +0100 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250414_020846_342386_821881AF X-CRM114-Status: UNSURE ( 9.32 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When enabled, print a user friendly description of the error when failing to ioremap() the control resource, and use ERR_CAST() when propagating the error. This allows us to get rid of the "err" local variable in anarion_config_dt(). Reviewed-by: Andrew Lunn Signed-off-by: Russell King (Oracle) --- drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c index 37fe7c288878..232aae752690 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c @@ -65,13 +65,12 @@ anarion_config_dt(struct platform_device *pdev, { struct anarion_gmac *gmac; void __iomem *ctl_block; - int err; ctl_block = devm_platform_ioremap_resource(pdev, 1); if (IS_ERR(ctl_block)) { - err = PTR_ERR(ctl_block); - dev_err(&pdev->dev, "Cannot get reset region (%d)!\n", err); - return ERR_PTR(err); + dev_err(&pdev->dev, "Cannot get reset region (%pe)!\n", + ctl_block); + return ERR_CAST(ctl_block); } gmac = devm_kzalloc(&pdev->dev, sizeof(*gmac), GFP_KERNEL); From patchwork Mon Apr 14 09:06:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 14050034 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BBC2C369B2 for ; Mon, 14 Apr 2025 09:24:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:Content-Type :Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wOqlWtFSPV7O6xwum69lDdpSmcDreIi287vOPBtUK1g=; b=nVUwntcYBd4okVFLMhb8YmXPzc RM+DWBGZ/eZDn+zt9x5FNiQYhrHZzxZA9EhlnXaeV2KiSXHz5ED7E9FDnWMxAIItnGv/F0ksCDySQ uJERNw49Yp7ojOEBEXdwVKg8tMrN8ulvohrAWw0PzP/Qbn6kBLoxhyb5vGsLerWz57UdzgJQg668b 9n0yuK7/rleye2yddXfye8k9eeOTd6ws6sNgEQAdKzN3bxqrZ1UH+rjr4lCMfjagEgr0vhVi+0cBa 3k0IpQMeokuURn/9jbph0IWON9oXj9NkNBSTNTo4A/lib1uahh/AqPIjJ+OPmzMB8XXulPQVsJGMB PJ16gwog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4G3A-00000001GTn-2Ail; Mon, 14 Apr 2025 09:24:20 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4FmE-00000001DPT-3r2J for linux-arm-kernel@lists.infradead.org; Mon, 14 Apr 2025 09:06:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wOqlWtFSPV7O6xwum69lDdpSmcDreIi287vOPBtUK1g=; b=ud6F4mT5ycwwzMR0SWj57hOdK0 eJrhqgZZR0WcP7CX1KTr0T44rMI875/x5gmuu+UXquOYe7nSF+wTH/+j8ka4v47mN92CTgY/UJ+Kf S9DF/5zXIZlyjJYNHgIk4Ov01r01aZbIW+LnUcsHp+Hi9lEuaWz5HzG6N2vdCw1qDfx1HvoOZuV/y vsvrZGwcGZuImWPKlfLoKHksUL6PBE5o6oyox8baN8O/Zjkifh94J+S4fN7PcYeJz/4xdWTMa5jNQ k63oTHVgWbhBpbTWkgT7j2kW1PAGXp/UPyPuPBoC60MiWPk04/TpRScnU2Zn4vBKnbVGLS3+imZqe CRMruvSQ==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:41504 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u4Fm6-0006Cb-1r; Mon, 14 Apr 2025 10:06:42 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1u4FlV-000XjG-83; Mon, 14 Apr 2025 10:06:05 +0100 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: [PATCH net-next v2 2/4] net: stmmac: anarion: clean up interface parsing MIME-Version: 1.0 Content-Disposition: inline Message-Id: Date: Mon, 14 Apr 2025 10:06:05 +0100 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250414_020650_958514_B74A3BD0 X-CRM114-Status: GOOD ( 10.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org anarion_config_dt() used a switch statement to check for the RGMII modes, complete with an unnecessary "fallthrough", and also printed the numerical value of the PHY interface mode on error. Clean this up using the phy_interface_mode_is_rgmii() helper, and print the English version of the PHY interface mode on error. Reviewed-by: Andrew Lunn Signed-off-by: Russell King (Oracle) --- .../net/ethernet/stmicro/stmmac/dwmac-anarion.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c index 232aae752690..941ea724c643 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c @@ -79,17 +79,11 @@ anarion_config_dt(struct platform_device *pdev, gmac->ctl_block = ctl_block; - switch (plat_dat->phy_interface) { - case PHY_INTERFACE_MODE_RGMII: - fallthrough; - case PHY_INTERFACE_MODE_RGMII_ID: - case PHY_INTERFACE_MODE_RGMII_RXID: - case PHY_INTERFACE_MODE_RGMII_TXID: + if (phy_interface_mode_is_rgmii(plat_dat->phy_interface)) { gmac->phy_intf_sel = GMAC_CONFIG_INTF_RGMII; - break; - default: - dev_err(&pdev->dev, "Unsupported phy-mode (%d)\n", - plat_dat->phy_interface); + } else { + dev_err(&pdev->dev, "Unsupported phy-mode (%s)\n", + phy_modes(plat_dat->phy_interface)); return ERR_PTR(-ENOTSUPP); } From patchwork Mon Apr 14 09:06:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 14050036 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1001AC369B2 for ; Mon, 14 Apr 2025 09:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:Content-Type :Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ueUNA14OVeEPQ6yDhGtqR0ixCik1TrsIANs9nUl+K/4=; b=QltckAYEH9Ek4qut/1eUMgnTAo Q2J1PtUHtMwIw1wFZW6KK9UZwC59gi6OBg8MSHS2l3qDYdufk2rwlJv8L4WPq/OkfqJRa+Cv3uWOf no4xIAH2mxiWfQBgoxkxE0+P+lPyInygjCX29DHp7hhu+aCVu+F+4UU36Ek3iZdzwaibMgBOGiq3O 7K394D2AefvmIpebdnrLniI+gb5fjksamVha2CUfHfSkxsEKyfbFkdZQRFAbx+AbyLASMCoZmtefD v/egfrcvYhRCaOW5Q587fe4jDh5UW+9tKPGVbVaD4aUATMYLjvHRO/1bBtOlbpg2Nmny7wMY8EJ9B PcG8zJbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4G4x-00000001GiD-18cI; Mon, 14 Apr 2025 09:26:11 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4FmL-00000001DPx-1x0O for linux-arm-kernel@lists.infradead.org; Mon, 14 Apr 2025 09:06:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ueUNA14OVeEPQ6yDhGtqR0ixCik1TrsIANs9nUl+K/4=; b=hoLn4b4zLHROIv6XBtc1AVDBlg IxzwN6NDNuK2sV394D+tTFGvbVWW5ZVGDfMnUCom4AczNYgDIg8X5CJdSJWagwjENKO0rosNxHgvO XC3Mvju7IEa32zcE0TTOxaLpj7+w4uztvykihRHhIsAT0i0TR+yQlYIGeNB1pmRArj+TXO80GtCD7 RzhEzFAZ6TULGHHyJhvKPi+TXtO/CqwwLoDPEfJvItX9fQW6YsZt2jmssd9rT8zCEFbOF9wPpB3bu Er3c7TkkaAbGnDRBtlt0tb+6QZ4b8ckh/9hv6JrZVEJVJ0hKewXl/QKIKu8Qk1LnNxuyFzVj9sXy3 8RVxId8Q==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:41512 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u4FmB-0006Cn-2J; Mon, 14 Apr 2025 10:06:47 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1u4Fla-000XjM-Bw; Mon, 14 Apr 2025 10:06:10 +0100 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: [PATCH net-next v2 3/4] net: stmmac: anarion: use stmmac_pltfr_probe() MIME-Version: 1.0 Content-Disposition: inline Message-Id: Date: Mon, 14 Apr 2025 10:06:10 +0100 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250414_020657_524692_51B108A4 X-CRM114-Status: GOOD ( 10.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rather than open-coding the call to anarion_gmac_init() and then stmmac_dvr_probe(), omitting the cleanup of calling anarion_gmac_exit(), use stmmac_pltfr_probe() which will handle this for us. Reviewed-by: Andrew Lunn Signed-off-by: Russell King (Oracle) --- drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c index 941ea724c643..99f6c977ec41 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c @@ -111,10 +111,9 @@ static int anarion_dwmac_probe(struct platform_device *pdev) plat_dat->init = anarion_gmac_init; plat_dat->exit = anarion_gmac_exit; - anarion_gmac_init(pdev, gmac); plat_dat->bsp_priv = gmac; - return stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res); + return stmmac_pltfr_probe(pdev, plat_dat, &stmmac_res); } static const struct of_device_id anarion_dwmac_match[] = { From patchwork Mon Apr 14 09:06:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 14050037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB36DC369B2 for ; Mon, 14 Apr 2025 09:28:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:Content-Type :Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FmTbfO2XzBCI5WUjtZDeqNTumSUDOLu5j8tSDSzeqjw=; b=vK8sAjxXITMnmdXHtDXe7Wdxdh OtEcLAh+GDOPpGIdiKbLwcHP56PpKvc1QqfrRCirT4r5yWvnrcHAcAEJGyu867IRoHmC7xEAhJwIt Tn45qTuqLQSLd0wJrEVzEoXFTBCeiyDtUypgHhOzmMeKTGVW74PvkRf0fJQft5iIe/CU0RwUzAVjW DWoUoEwq5VtZXc/0rh4T1kA6iHN4gFvhMBWBTpwo+cmv+rRg2hoxWNqrZYI9R1QTIhQS0dfcBYdoS Osyi8eKugFasoDwkW11Vx1SiKEr3mKfRu+4e9QhHkP4JRleATTwuoRrpbBOrgSSrz1B09wVGEGJhS pnCG298Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4G6j-00000001H0R-3sZp; Mon, 14 Apr 2025 09:28:01 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4Fme-00000001Df0-3Bu0 for linux-arm-kernel@lists.infradead.org; Mon, 14 Apr 2025 09:07:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FmTbfO2XzBCI5WUjtZDeqNTumSUDOLu5j8tSDSzeqjw=; b=aZs867V0nvhBEraOD8+wtPp4Ot LZG9u1F29qgKWIJmS4+FpzKs4mpYPJ2rYbG+852jURIxyG/rgRiA5j5mbVl1aBSpPrZtRjUgC34u+ MpTumZQWWJtHE1QaJb3aOQG/rYaP8d3QYYtPF0Y8q/uDz+tNIVdwLf71q+opjRWkSKKQVnrbNEQ4C HGHA0mkv5HUFggzPPd3oghQvF+rQwv7oc/f3jrp+0m5rQrW3bfhm229fXHeZr9HGvLLVD8aIVRZWK 6DW7YzY4rX7WGe+XqFqYXht5hmJIf4OKgPEU2HrKLzAFt+XJYX3zJA+lwnT7iUSOPknxBq4schcd4 Vnk3hGEw==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:60814 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u4FmK-0006DB-1A; Mon, 14 Apr 2025 10:06:56 +0100 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1u4Flf-000XjS-Fi; Mon, 14 Apr 2025 10:06:15 +0100 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: [PATCH net-next v2 4/4] net: stmmac: anarion: use devm_stmmac_pltfr_probe() MIME-Version: 1.0 Content-Disposition: inline Message-Id: Date: Mon, 14 Apr 2025 10:06:15 +0100 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250414_020716_807017_AC84F1C0 X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Convert anarion to use devm_stmmac_pltfr_probe() which allows the removal of an explicit call to stmmac_pltfr_remove(). Reviewed-by: Andrew Lunn Signed-off-by: Russell King (Oracle) --- drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c index 99f6c977ec41..84072c8ed741 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c @@ -113,7 +113,7 @@ static int anarion_dwmac_probe(struct platform_device *pdev) plat_dat->exit = anarion_gmac_exit; plat_dat->bsp_priv = gmac; - return stmmac_pltfr_probe(pdev, plat_dat, &stmmac_res); + return devm_stmmac_pltfr_probe(pdev, plat_dat, &stmmac_res); } static const struct of_device_id anarion_dwmac_match[] = { @@ -124,7 +124,6 @@ MODULE_DEVICE_TABLE(of, anarion_dwmac_match); static struct platform_driver anarion_dwmac_driver = { .probe = anarion_dwmac_probe, - .remove = stmmac_pltfr_remove, .driver = { .name = "anarion-dwmac", .pm = &stmmac_pltfr_pm_ops,