From patchwork Tue Apr 15 01:38:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Junxuan Liao X-Patchwork-Id: 14051326 Received: from mx0a-007b0c01.pphosted.com (mx0a-007b0c01.pphosted.com [205.220.165.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 294DBEEA9; Tue, 15 Apr 2025 01:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744681172; cv=fail; b=OFT9bykcxs1M2+zrcbt8J+TLZ5JZzMvoYGOQYebLepYRC/B2oFlKQbS55UvE0ju5lJa9vFg6lf0uiZ62SHOIcViqSMSyPxWZHvpCMM5yqvsmOCGZr/V9DLbH8DfHtMMUnnKN9bolZq3TDSGyJPx9atCdZJCsZ53LvcaaOEAcv2w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744681172; c=relaxed/simple; bh=Zki7NbayZwnu+/MiPZHEZXxq9/3KKtbm/RnKyT7IGJ8=; h=Message-ID:Date:From:Subject:To:Cc:Content-Type:MIME-Version; b=bsu8LZYcPu93TQGLMtELbIGubkqdJKdAlkPZiLqd/NIbGSC/6JNNiYd6zVlycvdwVsXbZaGGfN+k7MXFWb/54zMd4VyOvAAkzVW5iqXP+ss6winaNrbC7pb/G5YFtK68ac/hw1hqhzYLXLKOT6YdZzppZkdgmnInRg1O/WMBs94= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cs.wisc.edu; spf=pass smtp.mailfrom=cs.wisc.edu; dkim=pass (2048-bit key) header.d=cs.wisc.edu header.i=@cs.wisc.edu header.b=h4fsnBHi; arc=fail smtp.client-ip=205.220.165.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cs.wisc.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cs.wisc.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cs.wisc.edu header.i=@cs.wisc.edu header.b="h4fsnBHi" Received: from pps.filterd (m0316040.ppops.net [127.0.0.1]) by mx0a-007b0c01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53EJTaAU014782; Mon, 14 Apr 2025 20:39:03 -0500 Received: from sj2pr03cu002.outbound.protection.outlook.com (mail-westusazlp17013078.outbound.protection.outlook.com [40.93.1.78]) by mx0a-007b0c01.pphosted.com (PPS) with ESMTPS id 460b13u8my-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Apr 2025 20:39:02 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RZvQ3F0Y1MwIYvFWIiUNjCtYBeHXxXRawSOW4QgEjvholi+xHvCnQJMe6PQexMptg/qK5Gn/qxfELV/UMEnO6lwHeDEAJVUqyaZAbervL7VQkJGbCWNrg07SbrefamuOFbBFz8e6zqw61Hb5ikc+f50XImgMB3IM7k8kWVKcEKfBijJc0TGNyol3GIN6e2HApZ0PRs1iPQLZ6OSCEXjLc4IeK4PUFSoAMckW4T7Ncb2WWVXbewwXqouhkRins4uKgOoFKTdnjiavqzD0+NSuUqdoLFyJXIvqbOBDdxfbL1MR44VpJT3hgFXPLanBa35JHXlZxkep69ROxDWPxf9eWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wWepKURXVfNYrrPFCpO9tyM2kltf6fJgiw5xIX+afbE=; b=mZUIq1Tw3i/WUHN+xAswR/21i1m34Dvj5qp/r+YJWiPboSKEM01aWyqoCLEJW8WrXyH9Kvnl8vvSkpnu3xlNbxJq5BDQsYRqkkho8OmYKVKeWnoGnjBTD0xoIp4L3ay76V3JoIlmB+Q2cfaxG8GPmwuYdsg2j3Phg3pY01uBnEULrK0br5iWBVTbp2iAz7qsyB+WFGi+7hEcsHhj7L3JwtSsl0DSwG7xXXr6qD0+xD01/JqxRuJFCncYn+hdJ0zhnbVYnglQyqY9pONgkN/kbRBqt944IsiWPLrwqsq9MZlCcRpipN6o4t8Y5ex9FTGF4hNtKv5ggfq8WyjtEEatZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cs.wisc.edu; dmarc=pass action=none header.from=cs.wisc.edu; dkim=pass header.d=cs.wisc.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.wisc.edu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wWepKURXVfNYrrPFCpO9tyM2kltf6fJgiw5xIX+afbE=; b=h4fsnBHiGQ7l+PXYxlSCQYZygpuZTLT9OMpbG0NSwzdU5d4DUk9W1GtdhxOF1viyWEcFI3h4QbchkN/ZJfwIr/fWIRuGDdjOZ0IJukqyXvSfyWwyxULXmOyCyIvkrYeviiN0U0g+ai55j3nlF6AmkEm0r1n0+qUD6yvLNF9p47lKt9+1UGU8SYofq3/j0PdNL19JqAYOgPya3sbNnDaIyxGd8MWYY0GupPti2y3Za25bmV+b+2NSCO9Gugs0TvQW/E1wnVTCePV5/caJqmIPxTdGOcAGgIVp/RY4S83KncVPS5TlyeH8ueDQXX4H6qaXACJYH2U5DUXqN2L2/y44Ag== Received: from DS7PR06MB6808.namprd06.prod.outlook.com (2603:10b6:5:2d2::10) by SA1PR06MB8420.namprd06.prod.outlook.com (2603:10b6:806:1cf::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.35; Tue, 15 Apr 2025 01:39:01 +0000 Received: from DS7PR06MB6808.namprd06.prod.outlook.com ([fe80::76b2:e1c8:9a15:7a1c]) by DS7PR06MB6808.namprd06.prod.outlook.com ([fe80::76b2:e1c8:9a15:7a1c%5]) with mapi id 15.20.8632.030; Tue, 15 Apr 2025 01:39:00 +0000 Message-ID: <76ace3c5-2882-4b48-8aba-45480714cc71@cs.wisc.edu> Date: Mon, 14 Apr 2025 20:38:58 -0500 User-Agent: Mozilla Thunderbird From: Junxuan Liao Subject: [PATCH v3] x86/tracing: introduce enter/exit tracepoint pairs for page faults To: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Paul E. McKenney" Content-Language: en-US X-ClientProxiedBy: BL1P223CA0044.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:5b6::17) To DS7PR06MB6808.namprd06.prod.outlook.com (2603:10b6:5:2d2::10) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR06MB6808:EE_|SA1PR06MB8420:EE_ X-MS-Office365-Filtering-Correlation-Id: fdab5639-9004-44fa-f577-08dd7bbe4c18 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|41320700013|7416014|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?ub81Ygw3M+cggOLrsEInkXM8cDDGWfj?= =?utf-8?q?MKH71Ev4dI1PHfdhO9WwX7q1mzTNJ8TV2sAZiyBqzWXby84bbi2/suiG+vlZI1015?= =?utf-8?q?QDl0QNRGYQxRnJpEQ+ysqWWoquLZ6wQeYkoi4R/wGTh5j44Tw+1LzN1D+b4ol4UA/?= =?utf-8?q?bh6nZ9YkVtq8T5fTfesLg2I/w/iWT0VdVe338vqzWEPrrShOG72+ROEPphNsgTCZ2?= =?utf-8?q?i/nJF3Te+toIZfgdULX/5kDLq7r312d23U5EBV91KbPJCxN3LFICVqZuQVLsk0/w/?= =?utf-8?q?bHtXi/KR7QBOYIy/ofjLAx4qwGxYwsoFjks5PjhKjz4IsmYXOygdIRMOf2rNycDuO?= =?utf-8?q?ssDAgi+TjYrOzYzBX+BEu16Mc/zXDjwz1/QFM7Q6hlTMuvPngXzf47ZDBcBG40Xyx?= =?utf-8?q?nBnR0ywRFJ1P6U1tQIyeZaZq4EtXYSDgcpM5a48pdylMMHYvJTfeo+EX7O2JjZ/Jj?= =?utf-8?q?bFjrTrUADiAvBWR5NwJhTq8PrPx+ceTX6j1O3wn/QeBKlgCtB1CrAl9KPMLDTaTc/?= =?utf-8?q?F8oHErn1VI4M3jc6ixXen/yx0oQB3u87WKtTJ6jn3vligLGhCULD0bZUvRjiGZ9UM?= =?utf-8?q?E+C5+9ZEic0blUm4BlQ2HLjvnJEEXLook41/80OoKoIoqnCDXOeoJi/Mv+QzdBwNR?= =?utf-8?q?50guzyfiHs1tVVuutvOc8OJsr1oudxsXJ+fvHYr3hdqPVe8h4OLvnIfx3enJ4/xZY?= =?utf-8?q?3X59LRj1r7LC+uUY0es52E5j69hXFz1i6P4Huw3uUiCrWgxAbQ9SQAQvnZ0AtHW8V?= =?utf-8?q?diTvctC5lhy/2p9YzfUOlqPJE1EZwH9f/pMIPpmchOee9HXZkEOyAb58uZXYklAYT?= =?utf-8?q?/HHSQXEAoitQCtiLWlUWt2x6eJprCsyUdvxssyxuTtDL0s006EILB2F1rGldFOfXg?= =?utf-8?q?5tCQl5DwG6wFDPsCq+Jz26xH4nx4jwpcw+fx4oXijxsIzLOHkZB+KDCiNtBnL6EY3?= =?utf-8?q?xaNyWa+SHGe6wof3O4CxCxCiyjf8Ackb3J9cyXxp5a+tGRWIIlHyK6kmUvkK1C0+w?= =?utf-8?q?WMG+e1MVdbg3vI3Px65iZkWd1YsLso7Mp0PZ11hAQvIaSWsvPL220O5B/dwFfZqp6?= =?utf-8?q?YyGQOx9Ot0cRhWWgxZcWJj+jDLR5MBvK65HXtDtNm695ylr1x95XhMOs/OcocbzLs?= =?utf-8?q?Br1bI+F2emndg0VC0Mylx6bmHp3UZ7TCcF2DUpN1IUSQYgYgUfjpes7xQ3TYnQIYB?= =?utf-8?q?nhlpka4/4JOrsPpH3ol5d+R4FNwhiHnxBtOiKPouReLAkRNb33r26aRcSVsGqM0Vm?= =?utf-8?q?pRWFwbNYgg2iRx1SSkiEiBL5UE+k3PrGZK+J2QHNeDh2Av8BlLS3VNU3cR96eM78w?= =?utf-8?q?+seiKAQ0kCfjIKuGBPhX4wrl4+XMrpWL9HZA8Tp9yTNKS7oBeFqKzbk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR06MB6808.namprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(41320700013)(7416014)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?/7H2QELJAMrezI/j1DwBcJnHnTlX?= =?utf-8?q?r7dJXaa5bxZQR999RUymZaneRg5bjDv5k+YdJGeNv7tKCnel2OFw+txKkbkAo3VFi?= =?utf-8?q?YnK1O65cCT3/g0/kM97io21KkfdTwHqqfwHU2nHtSQ43rXn1bbz5gseEUx8RO1dAK?= =?utf-8?q?9Q2JQAip3fuIQ1CPSkGEGL3R34kICJij29kWFqlCpFFivGVDtEKEcoanFmXNWzKBt?= =?utf-8?q?6pJyOGYDJ2v1NpqmjS6+UcYv/9wZ9GwYcVXE9GtjU1yyDn2IpZ6Ddpl421DWGn+eg?= =?utf-8?q?v1JcSuwF7wFu5C4FkKIy+wPpJpKd/j58G1MnF6sk4fM9WW8C4Da5HsPFafJ7nG0FQ?= =?utf-8?q?JjsOck1irFE7iKRYVQSNn9l/vb1PiK6QmaTYW+B/PoDt8Gy38o5NxTl/3/VFJHDZP?= =?utf-8?q?z42aFfIZgdtBHSWafkNmv2dSZrbTNgogFp2VMFLBaSsz9DaG6KtzFrQqW/ZK41hf2?= =?utf-8?q?77urepykq3oH2fnJRiQZhmBoLvTASEfuqZoL7fasj0q/hjcPX62tmxOjoLo3f9LI7?= =?utf-8?q?kJnyT65T1AttCWa5XN5WfmeNliuvkHy0OjOmJzeGuwVsiIG3aPeWwE//hWUv+Fjgs?= =?utf-8?q?44ywdduzrQhDfDIEKwoXHRRqy6kLecw97oFiUlTtH/3nznIM5+Dl+KrlfPm1BHbH+?= =?utf-8?q?5w4tDMF4PVVNz8R0YG/8LafEe1xDFJSMLUb6yVfcBK+cjAeduNOgjrlYfgfGgqbUd?= =?utf-8?q?/gdCVZ5ubF01IIrXqSgVs13++X5HDFhchZg24+x7oYigHCGRBjEkv6/bcovA2MtUg?= =?utf-8?q?cjAC2NXsH11Mf5ZGBMje8x8ZZqojB3u7ZFBptDOmDoGRtxqtt/rWcsJINuSzWFif0?= =?utf-8?q?JL0IjhIChg+f0TCHqBxoBiClj0iJYtKGSIWWBnkeRUYcpZdJ4nQ4rF8DEVZDyeauD?= =?utf-8?q?+Tj+feejdhMT89l9yi67c+9tfk1vAjMtf3HI2oaI4up+rmLGWVea+Ld61YF7Gu8Mv?= =?utf-8?q?rpPGhoYRIt/WwrlhpmqEenn4FtXWZrxkF0vjbnDVv0bfEnxA10zg6Nduto57Nv1Qy?= =?utf-8?q?zRTzLC1KF1rmFvoKLyYfCZwUWlkgrsKxJjUBhCPMqomNYKqnpm9XxZHOvBpl4eSCG?= =?utf-8?q?0uMmWiNmqeoj5iBkn4Od5jqRLIn/KrF+IfWtt0rvxTIDPh+WfXDYrGh4dGo8cWzLM?= =?utf-8?q?eCqAGceVMqSyfRiO9ETPivlBHhsadSoN6pc+VsZ4X5wlN+xeNGiSORF4PouFCh8Jk?= =?utf-8?q?qxSo5r7HTPF6wsQQlP8+j2kg1XtM3TW4VvOPjqen3jt4+55poZpSfQk83yflBtyib?= =?utf-8?q?+csWIqBBlRPr1kG2Ca9iPUlrSvrbtCZhqL9cAApiutbrx6Qy7njfFU7k/V1wpdcSj?= =?utf-8?q?/E2+uFW/Kj5w8OBePAvFm2BlocRF/Fvyadb043B0fH9uGODMTdgSNEF7XUi4q73jD?= =?utf-8?q?OSQb9ee7e/k7pE2CC7fsZ82nGQK5Y67ZyCH4y4hRYi/LfptiLZhOHOqHnzu3QZbZV?= =?utf-8?q?R3iGpzvuFgDT9t3q+4rRQJ+KYVeU2/pgYE99zqyBpb+fcIvY1OXGuQYT+GLQ600iV?= =?utf-8?q?I4tvHRwPByHI?= X-OriginatorOrg: cs.wisc.edu X-MS-Exchange-CrossTenant-Network-Message-Id: fdab5639-9004-44fa-f577-08dd7bbe4c18 X-MS-Exchange-CrossTenant-AuthSource: DS7PR06MB6808.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2025 01:39:00.8767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 2ca68321-0eda-4908-88b2-424a8cb4b0f9 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oXT5B66KaiqrD41n/5K3Mb2VYHDNSfpi1M6WYk1sffsdpRj2zF1IVYZcb0hcIHQ7K3bJRM0VtHY4hCMWdGGXig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR06MB8420 X-Proofpoint-ORIG-GUID: 2_5P-a37wzg9jcTAjPfgxR0UMHOaC6dL X-Authority-Analysis: v=2.4 cv=R4QDGcRX c=1 sm=1 tr=0 ts=67fdb8b6 cx=c_pps a=l9cCpZ6fIogKje1+qubiRw==:117 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=3-xYBkHg-QkA:10 a=VwQbUJbxAAAA:8 a=x30EXVXcAAAA:8 a=Vjf5HUuonJV36XDs38UA:9 a=QEXdDO2ut3YA:10 a=yI8jHdU-MAB4nH2QTHtW:22 X-Proofpoint-GUID: 2_5P-a37wzg9jcTAjPfgxR0UMHOaC6dL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-15_01,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 phishscore=0 mlxlogscore=916 suspectscore=0 impostorscore=0 spamscore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504150007 Merge page_fault_{user,kernel}, rename it page_fault_enter, and add page_fault_exit. This pair is useful for measuring page fault handling latencies. Add a new field to the merged tracepoints to indicate whether the page fault happened in userspace. We no longer need the static key associated, since it was used just to avoid checking user_mode when the tracepoints were disabled. Signed-off-by: Junxuan Liao Link: https://lore.kernel.org/9e2ac1e3-d07d-4f17-970e-6b7a5248a5bb@cs.wisc.edu --- v1 -> v2: Merge the user and kerenl tracepoints. Remove the static keys. v2 -> v3: Added back trace.o. Sorry that I accidentally deleted that in v2. arch/x86/include/asm/trace/common.h | 12 ------------ arch/x86/include/asm/trace/exceptions.h | 15 +++++++-------- arch/x86/include/asm/trace/irq_vectors.h | 1 - arch/x86/kernel/Makefile | 1 - arch/x86/kernel/tracepoint.c | 21 --------------------- arch/x86/mm/fault.c | 16 ++-------------- 6 files changed, 9 insertions(+), 57 deletions(-) delete mode 100644 arch/x86/include/asm/trace/common.h delete mode 100644 arch/x86/kernel/tracepoint.c diff --git a/arch/x86/include/asm/trace/common.h b/arch/x86/include/asm/trace/common.h deleted file mode 100644 index f0f9bcdb74d9..000000000000 --- a/arch/x86/include/asm/trace/common.h +++ /dev/null @@ -1,12 +0,0 @@ -#ifndef _ASM_TRACE_COMMON_H -#define _ASM_TRACE_COMMON_H - -#ifdef CONFIG_TRACING -DECLARE_STATIC_KEY_FALSE(trace_pagefault_key); -#define trace_pagefault_enabled() \ - static_branch_unlikely(&trace_pagefault_key) -#else -static inline bool trace_pagefault_enabled(void) { return false; } -#endif - -#endif diff --git a/arch/x86/include/asm/trace/exceptions.h b/arch/x86/include/asm/trace/exceptions.h index 6b1e87194809..f98c9024cbe3 100644 --- a/arch/x86/include/asm/trace/exceptions.h +++ b/arch/x86/include/asm/trace/exceptions.h @@ -6,10 +6,6 @@ #define _TRACE_PAGE_FAULT_H #include -#include - -extern int trace_pagefault_reg(void); -extern void trace_pagefault_unreg(void); DECLARE_EVENT_CLASS(x86_exceptions, @@ -21,17 +17,20 @@ DECLARE_EVENT_CLASS(x86_exceptions, TP_STRUCT__entry( __field( unsigned long, address ) __field( unsigned long, ip ) + __field( bool , user_mode) __field( unsigned long, error_code ) ), TP_fast_assign( __entry->address = address; __entry->ip = regs->ip; + __entry->user_mode = user_mode(regs); __entry->error_code = error_code; ), - TP_printk("address=%ps ip=%ps error_code=0x%lx", + TP_printk("address=%ps ip=%ps %s error_code=0x%lx", (void *)__entry->address, (void *)__entry->ip, + __entry->user_mode ? "user" : "kernel", __entry->error_code) ); #define DEFINE_PAGE_FAULT_EVENT(name) \ @@ -39,10 +38,10 @@ DEFINE_EVENT_FN(x86_exceptions, name, \ TP_PROTO(unsigned long address, struct pt_regs *regs, \ unsigned long error_code), \ TP_ARGS(address, regs, error_code), \ - trace_pagefault_reg, trace_pagefault_unreg); + NULL, NULL) -DEFINE_PAGE_FAULT_EVENT(page_fault_user); -DEFINE_PAGE_FAULT_EVENT(page_fault_kernel); +DEFINE_PAGE_FAULT_EVENT(page_fault_enter); +DEFINE_PAGE_FAULT_EVENT(page_fault_exit); #undef TRACE_INCLUDE_PATH #undef TRACE_INCLUDE_FILE diff --git a/arch/x86/include/asm/trace/irq_vectors.h b/arch/x86/include/asm/trace/irq_vectors.h index 88e7f0f3bf62..7408bebdfde0 100644 --- a/arch/x86/include/asm/trace/irq_vectors.h +++ b/arch/x86/include/asm/trace/irq_vectors.h @@ -6,7 +6,6 @@ #define _TRACE_IRQ_VECTORS_H #include -#include #ifdef CONFIG_X86_LOCAL_APIC diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index b43eb7e384eb..e8e33ec684ba 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile @@ -139,7 +139,6 @@ obj-$(CONFIG_OF) += devicetree.o obj-$(CONFIG_UPROBES) += uprobes.o obj-$(CONFIG_PERF_EVENTS) += perf_regs.o -obj-$(CONFIG_TRACING) += tracepoint.o obj-$(CONFIG_SCHED_MC_PRIO) += itmt.o obj-$(CONFIG_X86_UMIP) += umip.o diff --git a/arch/x86/kernel/tracepoint.c b/arch/x86/kernel/tracepoint.c deleted file mode 100644 index 03ae1caaa878..000000000000 --- a/arch/x86/kernel/tracepoint.c +++ /dev/null @@ -1,21 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* - * Copyright (C) 2013 Seiji Aguchi - */ -#include -#include - -#include - -DEFINE_STATIC_KEY_FALSE(trace_pagefault_key); - -int trace_pagefault_reg(void) -{ - static_branch_inc(&trace_pagefault_key); - return 0; -} - -void trace_pagefault_unreg(void) -{ - static_branch_dec(&trace_pagefault_key); -} diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index 296d294142c8..eda312707fde 100644 --- a/arch/x86/mm/fault.c +++ b/arch/x86/mm/fault.c @@ -1451,24 +1451,10 @@ void do_user_addr_fault(struct pt_regs *regs, } NOKPROBE_SYMBOL(do_user_addr_fault); -static __always_inline void -trace_page_fault_entries(struct pt_regs *regs, unsigned long error_code, - unsigned long address) -{ - if (!trace_pagefault_enabled()) - return; - - if (user_mode(regs)) - trace_page_fault_user(address, regs, error_code); - else - trace_page_fault_kernel(address, regs, error_code); -} - static __always_inline void handle_page_fault(struct pt_regs *regs, unsigned long error_code, unsigned long address) { - trace_page_fault_entries(regs, error_code, address); if (unlikely(kmmio_fault(regs, address))) return; @@ -1535,7 +1521,9 @@ DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) state = irqentry_enter(regs); instrumentation_begin(); + trace_page_fault_enter(address, regs, error_code); handle_page_fault(regs, error_code, address); + trace_page_fault_exit(address, regs, error_code); instrumentation_end(); irqentry_exit(regs, state);