From patchwork Thu Apr 17 16:12:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 14055832 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02FBC369B2 for ; Thu, 17 Apr 2025 16:12:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 723056B029F; Thu, 17 Apr 2025 12:12:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D1196B02A0; Thu, 17 Apr 2025 12:12:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C11E6B02A1; Thu, 17 Apr 2025 12:12:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3BA136B029F for ; Thu, 17 Apr 2025 12:12:21 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EAF00121AB9 for ; Thu, 17 Apr 2025 16:12:22 +0000 (UTC) X-FDA: 83344028124.10.3D4B8B4 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf05.hostedemail.com (Postfix) with ESMTP id 2199F100005 for ; Thu, 17 Apr 2025 16:12:20 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hgkrH6bb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744906341; a=rsa-sha256; cv=none; b=N8uB6brK9+IlJn0SdX8BVN5YO1TRP+XUfjaX6A9DPErA32ppJtALi4t60dsnC2omQlc+wV yAJI9Nz+ZwD1b7SUU1mQBgFiTZDtsP+zOzA1wPJ6bMJei8BQuSMul+4qJXCVJF4XMvQxN/ cFqlGCk8RZ4u13851Wmk72zLvbF7KdY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hgkrH6bb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744906341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=pP2JHfGtEbeQt6MxQz+Ftq1QIgZyi2KIG08JxM2kREc=; b=KGQ5+EwFB46//jTr+3dAGixZ+AtB1rXybydIEAz1GntUCd2Ydd5s9zYDPMdLVqvQootrSL NsDImC7fY6V1KnzCFEKU9OG26Z5iLwIlU2J2c7HG9kj0ENNdSBgBctBtNDKHGI7ALEyE6Q NDKfrxZdEdIHLT5PtfqWOQkOXxDJWi4= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-54addb5a139so1119806e87.0 for ; Thu, 17 Apr 2025 09:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744906339; x=1745511139; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pP2JHfGtEbeQt6MxQz+Ftq1QIgZyi2KIG08JxM2kREc=; b=hgkrH6bbwg0FQhdgQZJmXscOr1FE00MhXs9d05LZLtYS5Fzfv2FjEV8JJWdtUixS+j OgUKlKBMMBKtaLwoAW7F8sDGZCJSoHS3LvSJvDqtddepuovwAm1rDprKPFGTnqXRHo/w 428+yNLjKebZG0CJJEbMfvqXsuQdE5g74Fv4qYZWCU11WaPm0+JVYVnITe3sn46qHCs0 WYY7DsgattVeKLmPY/ntLWFxgGMhsS0Uk+EFsKmMXCOZFbS88/ScheyKaZrpirwXJJqK cSJLC2D0Mw+FMMFLNzWkY7Yk/OLpOc0VkVlmiKKOZUvv8NuCZCQR6ThU9a5owV/5hzDx Kenw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744906339; x=1745511139; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pP2JHfGtEbeQt6MxQz+Ftq1QIgZyi2KIG08JxM2kREc=; b=JP/3Az8NaFyWfjggBDnC8ns5Tr2oML92bA43ftsgP0gyOpC+88In7runAHkxaBCHz2 g5lkG5gi/q5MHI4ceiE1FziH5opPhk500kC2wrd7Zp0DNWxc0fpRBCzdjXJ9LIClS1ZZ OwneoEwk/8Gf3PYTrWr32Dmt/j2FB1i5dSM2oOVUFGeduNanld2pSE76xoULb8CH9Bi2 wAcCtN/4TRqV5qvb+B8QK8rPR8qhtsuD1lAKZOpOqrkMISVdmxG0vQ/lXDoDnVdd/qeB XPyEyZLM7lt041GfP7rX3gDJV196/z/CB8p5+NCbIL+BRuH28jfSFD0AxWDJTsiMUWGU R4lQ== X-Gm-Message-State: AOJu0Yw+0+L0KKUpaPlXcJ9l0hCHl+8DyN2tv85mrIXNaUov01YKwvOR fKUVtRvZkKc3RRLXP66u5/O+pm4uuTP2qXnBAMrrjnmTRiYwRe1J X-Gm-Gg: ASbGncuK4UfBKxiRYfT5Xg72Oy9yuCJ+8VdWCUuANUpeiQBExgLIt9ekijWuotD7quD M9oCY2TGP4QUN+s4QfTKWGHS/KNTZuPv5aWFjQ2W5WIAVNOv86KC69qgGDKjA+dlV9dFq8lSSBz voAyVHlgbSdjqCsYeIyQqxJUW5ftXPtlFRODH8y2j1OkY2u+ji3Lktott73YDVb9XXf0ULzKLLP UfafpOpmMJLdCMkUK6fZsp4QYSuBp3gm+c3h1Du24+qom2PauJlMMxD4llL6YZeFH0HgqdK51QB +OvawGRNfJRUFQ9bXBeR6sdBViFny+Dc6hab X-Google-Smtp-Source: AGHT+IGr8svtmU66VHJua0H8YKMP4oFA1Xc/Puv08hiW/VcgcSZzl/c2MLzMDv6Lv8uNkgabsQTkMg== X-Received: by 2002:a05:6512:12d3:b0:54a:c514:76f0 with SMTP id 2adb3069b0e04-54d64a9c225mr2505066e87.14.1744906339056; Thu, 17 Apr 2025 09:12:19 -0700 (PDT) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54d6df60cf6sm2882e87.66.2025.04.17.09.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 09:12:18 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH 1/4] lib/test_vmalloc.c: Replace RWSEM to SRCU for setup Date: Thu, 17 Apr 2025 18:12:13 +0200 Message-Id: <20250417161216.88318-1-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Rspamd-Queue-Id: 2199F100005 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 9pyphjr6yaqnufuqdjcx781xi3z1ks8f X-HE-Tag: 1744906340-560917 X-HE-Meta: U2FsdGVkX18m/33uTQIgX7Rrvz8Q3ygcPtADomfAFYYU80yBnQT7NFdFzdqzO8/1uLNXLpPK4pgnx2N3xtN7Vp24zYRygCun6gL9Q3i6nAX55ejAphfrLC0EDEWLpvJjjxCw6YTJBndKI3zxJvX8KQnpB6LpyHmfKJ9pTs7mbyLTHG/CJme+9tFQXcv0ANbF/sHBQwEOIYF1R8W1ql5nvORszj3bDi3bP/ATmG20/2VoTI3xvQd+ciAVhmghB+N4CZWBxPBofZxgGK0HXRR+EZ4Su59b+xrcIB6EYTcnpdvQsgvB+zEpsc+fAcESqfBDZ+p1lS40F0F53ksz4oyuLA6gGRwh+cmIwD4owFMmx3Z2lfTf8uHYd+g9qrK04ZurHad/O3TUaBo6FXNGAK/a8h4iWbXJ+osFfzY1TxnQutIp8tI/W+5MwENtKbrdPIHI7EBOpt9UZQKQgIJDSr+sppKEyPVvWV4hssyFbi2x85G9zuO8aUzwcZmdax5vLRx8Z60lZV/FyJMhz2hnwjrbCwhulyfaenhJSKQl594vOR1Hdmbr9VYE3FZU3GZ6aL+S5BWYCdrAiYqiK7t1RR/jhEIzxMmIGudokRs1hrTo8TNZ1I+2juzuxuyL2xWzZfvE4az10x/v1L+z/GSmir5lF2HoNV6n0lKTcAc3ehpIhIYkUk0+saTMsxzOGD2X1GAlXDSnpES0kDmPFkhUmGLezsScX4+ZBk7tD0FoAv0JEWCfxkP/90xiBO6LnMkX5PWcrr8V1hz657Y0nIdoLGgd54p+9wo3XIvJOMRd+K46CNJzybyzXcvwSxW+e7pr0Jrw4BqRSqpPLPqS1VD3QaTXRHxLYAIPIJV6cuWQ5PR7gZ6HKi2vRycxHoR4Kob6p3cYdGKd/tcR0nxy/f3CXIW8O+gh8wy2BEcdlKlfsNROmus+NtMFbA4gAj2KDpOXfPADYr+kyVNygdfIj9R5rsz CleViRwD zzRJzJVAHHJwmq3jQNdfhOho7xiu4/oYlyC+EM1Ql+5ewBi/h+HnymVan13Fni4Qef2U+1snKRUCQZleSJkhv9WW4lgmxl7lFcjQ58wJMHRhLyH6Iybqh/w/W2iAciw2MX83L1zXIw8szX3pTrFjkJQdd+9CRoJGCrS4ZkHM6o+9cOzEIJiYB/wI4QTwi7lJmz5eBIuOXYcCQcj3mrckHEybddbTgT1OxwPeto/O+7YWQjQHPGiOqe0dRhm/gAj9oC/YCoesQgqyPO82S0S6N992lu2SHjlYQlJwojKESYSui0rqaMmEQ4SHygTStlqVAU73fLZWPgxBorWJhkrg6STkcIymGaWbuB34T3BVrlBhwmbE7aKFqjJSDKh8lM6ifHaIQC5mZUhlKl2RHtpdcQmQitLUx/9Yb0pTRD46Ned/PkQE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The test has the initialization step during which threads are created. To prevent the workers from starting prematurely a write lock was previously used by the main setup thread, while each worker would block on a read lock. Replace this RWSEM based synchronization with a simpler SRCU based approach. Which does two basic steps: - Main thread wraps the setup phase in an SRCU read-side critical section. Pair of srcu_read_lock()/srcu_read_unlock(). - Each worker calls synchronize_srcu() on entry, ensuring it waits for the initialization phase to be completed. This patch eliminates the need for down_read()/up_read() and down_write()/up_write() pairs thus simplifying the logic and improving clarity. Signed-off-by: Uladzislau Rezki (Sony) --- lib/test_vmalloc.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c index f585949ff696e..4ab23e5e772d0 100644 --- a/lib/test_vmalloc.c +++ b/lib/test_vmalloc.c @@ -13,9 +13,9 @@ #include #include #include -#include #include #include +#include #include #define __param(type, name, init, msg) \ @@ -58,10 +58,9 @@ __param(int, run_test_mask, INT_MAX, ); /* - * Read write semaphore for synchronization of setup - * phase that is done in main thread and workers. + * This is for synchronization of setup phase. */ -static DECLARE_RWSEM(prepare_for_test_rwsem); +DEFINE_STATIC_SRCU(prepare_for_test_srcu); /* * Completion tracking for worker threads. @@ -458,7 +457,7 @@ static int test_func(void *private) /* * Block until initialization is done. */ - down_read(&prepare_for_test_rwsem); + synchronize_srcu(&prepare_for_test_srcu); t->start = get_cycles(); for (i = 0; i < ARRAY_SIZE(test_case_array); i++) { @@ -487,8 +486,6 @@ static int test_func(void *private) t->data[index].time = delta; } t->stop = get_cycles(); - - up_read(&prepare_for_test_rwsem); test_report_one_done(); /* @@ -526,7 +523,7 @@ init_test_configuration(void) static void do_concurrent_test(void) { - int i, ret; + int i, ret, idx; /* * Set some basic configurations plus sanity check. @@ -538,7 +535,7 @@ static void do_concurrent_test(void) /* * Put on hold all workers. */ - down_write(&prepare_for_test_rwsem); + idx = srcu_read_lock(&prepare_for_test_srcu); for (i = 0; i < nr_threads; i++) { struct test_driver *t = &tdriver[i]; @@ -555,7 +552,7 @@ static void do_concurrent_test(void) /* * Now let the workers do their job. */ - up_write(&prepare_for_test_rwsem); + srcu_read_unlock(&prepare_for_test_srcu, idx); /* * Sleep quiet until all workers are done with 1 second From patchwork Thu Apr 17 16:12:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 14055833 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE96CC369C9 for ; Thu, 17 Apr 2025 16:12:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B4FC6B02A0; Thu, 17 Apr 2025 12:12:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43FF06B02A1; Thu, 17 Apr 2025 12:12:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01C7D6B02A2; Thu, 17 Apr 2025 12:12:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D997D6B02A0 for ; Thu, 17 Apr 2025 12:12:21 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9C43D1618FA for ; Thu, 17 Apr 2025 16:12:23 +0000 (UTC) X-FDA: 83344028166.14.3C911A3 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf11.hostedemail.com (Postfix) with ESMTP id D59C64000E for ; Thu, 17 Apr 2025 16:12:21 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=efQ559Oh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744906342; a=rsa-sha256; cv=none; b=jvVwhuYBecADwmUEgMImX6F8/+8LWmsKxwEQDFzmKlb14MGCQIJpvUr8Ek7qRFBDE2Vlbb OhjmskbMLDpvDTGcZkhJSHPJps/efpTV628jprN5kpmkGFOff4+eVitz9tc/ihcic2rYRV 0YCVUHDfuqHKjPaIdWX9xdz3M8xZfsc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=efQ559Oh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744906342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q2DqD9BQAtvDREsRw2DN/6o2wQp/L1QLQLFU4UGNmDU=; b=DgP1ywMQwyhNxR35AzZncHS3317itiXYooZfdImYAISGHbhEY5bvMy2eXyWlSKDf3nn8X0 2nmDG88S/Oe6dc9HqMfkO1iLP1S3WMKXGxg2VKl8+4htWgYYP3Jbk0AkJsxoFUpVtlKhp5 oIYlLSIdl99XA40zw1SWkJ4YYgIYNuc= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5499c5d9691so1206215e87.2 for ; Thu, 17 Apr 2025 09:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744906340; x=1745511140; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q2DqD9BQAtvDREsRw2DN/6o2wQp/L1QLQLFU4UGNmDU=; b=efQ559OhIi0mMDOuLC9OX6r5p18cBeEsrpIp4I0o4aIRe/gFlbzO9C6Dvb5YqlF9Tv xzVIIYtjotkwL6cmXOdiG0X85WnZQgHDYka9HdjS8vsmh25jp+ZiBCv/UnuHu6NqjRz6 +Nef4Q1mg+kKKygZp1/ieCGtaTgO+FsbiMJREQ5a1R3jReA6MmcD8O+j/gN+jEcpl4VI RWleHDVlT7/+zHxGcvODgSCyutfnolkaVhrRMToFto0cJfSHfl6HI2TMf0NAfcyv5F7n +tlUBcQTtpahmiozXVkT/oNm51gddUZ4TI72lic3jPgBt9mFXEPzaroq5NvLna4SABSG A3Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744906340; x=1745511140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q2DqD9BQAtvDREsRw2DN/6o2wQp/L1QLQLFU4UGNmDU=; b=Uc5io+A5xqqN4NYtVKFsaqrNw/pUvo7GCkxR5vHeeoAGpsKWRsKaUFmfLk+HOVp6h6 Wn5lJSENyp13rwcTfeCwFlNmzBMC8aSJUAY91aS5JAS5v6z0cZq4YBrWinxwYJT1VGAN Bl9Av196fO3ZeK89kAPo1ADOXWO36mCKeLumy5dfZNaqm56w4cTsMukmLa0Mps1STWn0 VMhMELkJ4cXFFG6DV9akXQ0gU0h1JbtEYx4xGCUAEk0A6pwgt/ZMEczZ7LT5GqrWE0mI 69UcRO4pUwDZcnUnd5wO0Uy70UDtENghdDzLttUsyx35mYxSanVQoH3SlDOHM2ocA/Og Dcrg== X-Gm-Message-State: AOJu0YybncEPgnmTaSePGDpBQzvJ6w7lz7oD7sq7VCUrb/Adpz1AL9IM 3LQyrbEZDhyqq95ImcmATCh/ILONoOz0Esnw4DbORi8BaEa8sHgD X-Gm-Gg: ASbGncvAB2ghMw83oHYXE2LuaKSXjONvR5l7Oa9m93AeTE7KY6l3ccAR5tjgwnMdeAS /gKlR0ukq+Pg+fJ6Hs6kdLtiKzqQlBBK+6ebNbQdBnlTClcvbr0yICPXLWo8etbkyd+0d3ylYez TTyUWQeat98JtQzSYsl6N/8bibExz6OKrS4CCGqDPyC3R4aVgM4AzSkRnFHeTyqiEzGMCYNJpd7 34VvNwvOhAEtj7HcZSuWf+NFEct1qL6Ls4cLiP3wTLU7b3khVqg8tfiEm5Ho+j+MkXOTCVUm0oQ IUWIqac6iLHHLH8cV2l5GIXKA3RDrLW2WLKv X-Google-Smtp-Source: AGHT+IFrLX6vE1RvZB2qO8Upzy1nOrDt6DKQMQLhorbBry2iEtc4ISaiMBxadO/UPacQLXXCe8bOvg== X-Received: by 2002:a05:6512:a87:b0:545:ee3:f3be with SMTP id 2adb3069b0e04-54d64a7b390mr2599525e87.10.1744906339861; Thu, 17 Apr 2025 09:12:19 -0700 (PDT) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54d6df60cf6sm2882e87.66.2025.04.17.09.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 09:12:19 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH 2/4] lib/test_vmalloc.c: Allow built-in execution Date: Thu, 17 Apr 2025 18:12:14 +0200 Message-Id: <20250417161216.88318-2-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250417161216.88318-1-urezki@gmail.com> References: <20250417161216.88318-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D59C64000E X-Stat-Signature: 6iueftko71tcbjnt63jfhyn8suthdx5d X-Rspam-User: X-HE-Tag: 1744906341-195933 X-HE-Meta: U2FsdGVkX1/gA2PSrx1bGQ2pr5MSED51ZqTLAtccxgRyBesGZ+m+QpqKVnvnanQP2Ple/opO2Nc9jJTwLDYiE6PmZowYRX5HJt3Ullv0r0GdN/DVYz7xAbwpxbDGfANX016WwDaYwOchwIldBJewZdasct52zOqhtKlbXQbnHRPiRfJBEPnsrmE4OqYEAV2MjYHUi+cPhhLvWVmmwYXIVkamd1++z5vMxlaDYG0qHvrlwgtGPbBg0PpQmcGHNOFiUPqCoZ3rKw63WDpsAzOXFn1eI2JTG+IviUTKHbJl01vLxd9BUtw4kcnqtx2ifM2p0m4wgI6qlAwHFLGS7RpRE8fL9tq8u3QooTn+1vYnrmYDh8u1JJOjy/QpDxf/rQVH7h0BHjo0DH8ev+Z/rQ304sdaZKqVFr0xrB3NuVsClb7k0XrcPz5t+aAtPNBAQj5KFWxDd1SwWdzFWhQ7Ed5C9gohBuyr201zavyWkY6j8rNG034Lp2bDcBiOV2QvLacbRTVuSz1O5xAoAAcP786WT4wglsr6fL0LJOlq5TVQXhlnpQ5vKYcJYXUVtIS55vY7HdeUXzyt40S7w3v0rabi/a58MAFUOIJsBYOxNEWpa6OCMy25HNAmRKUQx7LbRecTFwwMFC9EEBZrsT46H8tPkSrETzxXB6x2nioK95IXjaN2xB/ZxpY5qkfWMzP80Rzs949OEmMnb0DFaJJmfXvRH3f25iyf9ksisM2VwnIoU2h7cbZWoIL3fia8675ItlIhKNFyUXeSfhp8WW9BAsz94SMhHkfTB2DA0JFP8V6Eh+NJd16NTpyQiS2A1pTU2w3triNlQdo8eRmfQsBOKXAcoBIME/r1RRqvAKd5Pe6iPDw5MNB5Iffe6qLnK1eDWQ3ZvAOMA2rmG47q7q//aJBMWq+Tx711uu8ra73Y2BtyfhNMu/YB+0N/byJ97Ie7bstSYUpvTHfC54hqe7tHawn pMu6QLpi XapJUv1n9BzHFDDv1sFAfWyVbp6+8MCDSDA3BSwMCqeWDsYZ5bOnpn4X6feyU/CcgJr4/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch removes the dependency on module loading ("m") for the vmalloc test suite, enabling it to be built directly into the kernel, so both ("=m") and ("=y") are supported. Motivation: - Faster debugging/testing of vmalloc code; - It allows to configure the test via kernel-boot parameters. Configuration example: test_vmalloc.nr_threads=64 test_vmalloc.run_test_mask=7 test_vmalloc.sequential_test_order=1 Signed-off-by: Uladzislau Rezki (Sony) Reviewed-by: Baoquan He --- lib/Kconfig.debug | 3 +-- lib/test_vmalloc.c | 5 +++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index f9051ab610d54..166b9d830a85a 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -2574,8 +2574,7 @@ config TEST_BITOPS config TEST_VMALLOC tristate "Test module for stress/performance analysis of vmalloc allocator" default n - depends on MMU - depends on m + depends on MMU help This builds the "test_vmalloc" module that should be used for stress and performance analysis. So, any new change for vmalloc diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c index 4ab23e5e772d0..6d65ef725d42c 100644 --- a/lib/test_vmalloc.c +++ b/lib/test_vmalloc.c @@ -591,10 +591,11 @@ static void do_concurrent_test(void) kvfree(tdriver); } -static int vmalloc_test_init(void) +static int __init vmalloc_test_init(void) { do_concurrent_test(); - return -EAGAIN; /* Fail will directly unload the module */ + /* Fail will directly unload the module */ + return IS_BUILTIN(CONFIG_TEST_VMALLOC) ? 0:-EAGAIN; } module_init(vmalloc_test_init) From patchwork Thu Apr 17 16:12:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 14055834 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D77C369B2 for ; Thu, 17 Apr 2025 16:12:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 034476B02A1; Thu, 17 Apr 2025 12:12:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F146C6B02A2; Thu, 17 Apr 2025 12:12:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8EEF6B02A3; Thu, 17 Apr 2025 12:12:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BA39F6B02A1 for ; Thu, 17 Apr 2025 12:12:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8588F121B09 for ; Thu, 17 Apr 2025 16:12:24 +0000 (UTC) X-FDA: 83344028208.04.9AE74CE Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf04.hostedemail.com (Postfix) with ESMTP id CDE4B4000B for ; Thu, 17 Apr 2025 16:12:22 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f3s3FpZs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744906342; a=rsa-sha256; cv=none; b=R57hIONN2mAC0ZvJiT3yj82hmdF++jRlGQ5l4Bzib8N1/yi2yd15lwgSzc6c/B12LgolFc 9o4j0QgHhNf33Y47ueuPxMnkeprUouF8vCsgVMm8pEV0UKq+w+LxehX5f3xzh/kmm+3ZDf rPfF4mW8ua5jhxrSClv+FbvL48V+4Yo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f3s3FpZs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744906342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XKhggK0iP4H5P0sO/10YkMOJNAlvYeGYtR/+VEiaaSw=; b=T1jFSPaj8gSS4VvL6hPFOVV28ZSCm3NJaYhqnB3MSG2FZjMizlHtacGw5z2xcda3510Uzh 5ZA57j5qDWcOfeiLmd4zNAYbMtm0a2Rhk4uD45ixsJE2QQN2GHk5Io0c+M0u01vFwgRMQY WysYACNEpxD6w1traWewptNTLFZV554= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-30bfc79ad97so22836141fa.1 for ; Thu, 17 Apr 2025 09:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744906341; x=1745511141; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XKhggK0iP4H5P0sO/10YkMOJNAlvYeGYtR/+VEiaaSw=; b=f3s3FpZsJ4Ed2X2AB5pIMGWkkVbhcJcrufPrGjJNtZzqNG/b0Cnshl/SWa4a/411LE 6KV3erkhbf/RCpRfhBp6C2jNrfIVKs0wHfpv8lC6YPdV3LRMxAum1F8St7Zf3MYKUySK f3wUg4c7klPYa/dd8iTBgSYmjIZGeCI7yYBjKJTK8qFpZFauVU47CAu6VSEG6Vz/asp3 dECm2WGc/00rcANI/6+gqHadyr9fJPCivCrU3YAXeh+owpIw9ZYa5xkY0cuC8fWTSMS2 yT8FQKg6AJwRd+uuEyt7Hc44NfX3z8Q1cX3tgi2mySZ+Jxe+0aSe3lnFmvsW/fURe5yF wiXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744906341; x=1745511141; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XKhggK0iP4H5P0sO/10YkMOJNAlvYeGYtR/+VEiaaSw=; b=LBK+JL+2ByL4dPeiYgQ0LKQtXfiRQsuTaLeSGPb0jhwT1VN/yYKwPOm45l2/84m5CN lNKxfThznzXe7AVkAw1bqf0oTQhD4MvRgKemrZGWdfWYKpy306PA1F4qxD/bLTgCSr7F Gi0Q+wCGLWPoM104L5zsXNFxFj8ufU4CRuigsGq3wjMMdh/bxencMHfCtu/pO9k46U2K 05DxRkr2hEfuws4P2/45WK5RuyqXBb+w8r9hkqAQybZnxwqEj9cuUm8+Rd3sGEdCeF0B RrVpGZxh47g2pxEA87tG//0uWH8qIJdjWsm3vGSC04kkKc+E1SEEL20uzjRzG/wRKgZQ D6vw== X-Gm-Message-State: AOJu0YxIIVr43DTIlFu5OILY0RZWWlJQ2OaxbeCR/5W51OFNEthkARoW nLExB1I5ZwzkzN/TIl1tCNFK+kgP9hfala5/3uR724T6n3Dy/yfn X-Gm-Gg: ASbGnctYqf3wfxtU9bxsVS0Sfj0HoGXNz5JnurQFAPDbQYUCQNn9ce5/yk+y5SRoi2s x/fsVY1kgP2odFNsxN22Xm+ML48CrHCEPqlMhlZSopv+j/uR7ZBAcZtSGGAoQZJAn1SW7HeLH7L TBml84XIqDNEzZggCzWZ8fVmA49EfJYdNhJZv441X4uScCW3yErO3034t2aO/xNIRMqH2e/Ev4l K/zjmYj4wLeETCQOaaZL8qcxAB6ObBV+ujDM0ylcX9Uvcqti2O3EalYOj1Qn88Qfv6VA/CcMbDg 3rHBEbnB/JeFpTEr508D6U3VczLTq48rBuqTNm2cBO3EE1I= X-Google-Smtp-Source: AGHT+IGh7I+jBQr7/0yO8FtaSB6NaNAo61mH5JNRvIsJ3e/mPOwTiyea8rKQrKdbmrErMCqFG66OkQ== X-Received: by 2002:a05:6512:32cb:b0:54b:e70:4122 with SMTP id 2adb3069b0e04-54d6dbf65b7mr196315e87.21.1744906340739; Thu, 17 Apr 2025 09:12:20 -0700 (PDT) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54d6df60cf6sm2882e87.66.2025.04.17.09.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 09:12:20 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH 3/4] MAINTAINERS: Add test_vmalloc.c to VMALLOC section Date: Thu, 17 Apr 2025 18:12:15 +0200 Message-Id: <20250417161216.88318-3-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250417161216.88318-1-urezki@gmail.com> References: <20250417161216.88318-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: CDE4B4000B X-Rspamd-Server: rspam04 X-Stat-Signature: a8keh59f9139xnnn1am9syg6ndntwoj5 X-HE-Tag: 1744906342-262146 X-HE-Meta: U2FsdGVkX1/+VF11gBq6ZGYUmQuTONtfi58msBAzIZzGRxWBdo7s45Gs12/P25SiO0yCOWsOup6cPHmfXH/O1MPBItX/iLK3oplVMM5n0QAQlLg20g42ZQy9dN20Em2XPToQnI5DZodSlJgM0dDwTRJhb4qKMWv9Sp/G08RRYxOzLf0zt/h069ALLf/TuAs4A1k5atw0y/AZz6aa+AF/4lJIxPKsP1i6fRgHYBodUFyWac/iIVRNrgpyKb3xzRBXCI1sG6UgNVDkr0vjeswf9sRQpOcdX3vP/Ylz3bYIsnSoAn7thVLe8FQyJeL6Zw6r4pkbBTyGdFEKXmv2haOeoMUe0EAHHgqs4xkeEmmUY5raeAQSB1dbkIyKy48mjHy62vZa3AS4Mq7ieBRjJXzxE5k55AEXhlTd8rLX6U/P46D2i/vp9+ygR+Om2KtEAvNhhFqz5cKbu8Ao7YW3a2FPqlU/1eKbGLw67NkX7X8YSGoc0tAMmrq3rZkzwmdh2DQ4bi3JJC2H51r/lv+OZemZIfYuLgyXi+3bDpLgB1Vxpj5FUg+7SfSDp2Yj3jo4QS+TtDm4gXWEHYBWgGcRHQ7vK/7MN0BrRpN4bYPvQSJb4EflHcx4xOzuntGmLI0ruf5+T+4BvyOfOWA8eXgo9KIXWAcJWVhvIP8laJJ+QTvYkqjUWyfCZNx0cj7hnw6/q2q2Ci4cfFUdi7PNAUWAPvuscS2gWbt7Txbedd2OCE2N515+C27FsCX0y6/wom5KFe1thi+vBN6+P8m79ePUKFWIYETvmUtBf9WWrjuf1dCBTUZ18PCuR+GcqR5am0g0oxAxmyqB9urry4vwyzri49CpQk0qNXpuhE2Uk5K74lZDvHo7I/3lKqStiIcHWUyHkEUX71JAcHTvX9y5Tp57G7TlPNitCE5t1c2nXvWtxAh0IXBBubx6XCk5PiTK72edrbAdse3i9vW/i3M09jTJ7fU Lf2j/LqZ D8/fr7jwFsjSYvM1Io/QbvbbL8nzYY0ygV0ntLN4UzQGqy/MjnPTOrOfWLvjW0xAmxoIy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A vmalloc subsystem includes "lib/test_vmalloc.c" test suite. Add an "F:" entry under VMALLOC section to track this file as part of the subsystem. Signed-off-by: Uladzislau Rezki (Sony) Reviewed-by: Baoquan He --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 17ed0b5ffdd20..8e62b09e4c9e4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -25874,6 +25874,7 @@ W: http://www.linux-mm.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm F: include/linux/vmalloc.h F: mm/vmalloc.c +F: lib/test_vmalloc.c VME SUBSYSTEM L: linux-kernel@vger.kernel.org From patchwork Thu Apr 17 16:12:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 14055835 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2ED0C369B2 for ; Thu, 17 Apr 2025 16:12:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35F456B02A3; Thu, 17 Apr 2025 12:12:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30980280005; Thu, 17 Apr 2025 12:12:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1347C6B02A5; Thu, 17 Apr 2025 12:12:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E70E26B02A3 for ; Thu, 17 Apr 2025 12:12:23 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8DFB3B4199 for ; Thu, 17 Apr 2025 16:12:25 +0000 (UTC) X-FDA: 83344028250.24.C6D82E1 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf02.hostedemail.com (Postfix) with ESMTP id 874AF8000C for ; Thu, 17 Apr 2025 16:12:23 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V3JvTYYV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744906343; a=rsa-sha256; cv=none; b=1eIuVFxE79iwMHsUKPOsZ86XbiLLYy+fAVp6p3vkV53X42mGqDtELqYoSHZ0Yaz9rv3t8Z 6EkU4Nc/6AupNxYVqxwxYsuYVHUv9hKsiVaK99vabJhWeYjRQbpaejv2bJ9Ff6iX+H8Qbv SQrd7zZlPIZbrxY6YXzPmDWlWebpVM4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V3JvTYYV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744906343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kiIA8fIy8YmbCJnZvN/tju1TgqCKi7yKEus7AdngHaA=; b=cJKMw61YUEefz04VCySTirVI9HFPUSw86aXN7GxWCArGPhPSyRj2LmP7D1FQikaFHt2V0Y hJHhjUug6BkUpctqnKw5dj+3AZ3abBtviwOdA/IbJplMPXSH6yfFJk16yyAO/O0zOVYVWN kQPk2FhwmiLwV2WajL5s0fLPHp119Ss= Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5499c5d9691so1206255e87.2 for ; Thu, 17 Apr 2025 09:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744906342; x=1745511142; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kiIA8fIy8YmbCJnZvN/tju1TgqCKi7yKEus7AdngHaA=; b=V3JvTYYVuJBKLn6i7ZdpiaeC+4bNq4tu1+80AROfwEcCF80i41XPvM3lBDkJpXCU9G HcwVL1e8KpH0mSEYRD25jDcIyEJ5Ds4BSwF9hkanxtWu8Sui5Km31k8QNbKvY+0zRLfb ckwAB/v1dwDerciRdE3wKRWalkNoQdPWMyoBoEhQlTvCcOZFcxN4MVwqBcdo1PZfLlC1 a+LF+OXvqWmf+ti1Sy3c1NSltYgsrfYtdgSc1m/2UBnrC0p4XgLE40u4XnNc5LpoDVRe I5fLWgUbUei66jzH0tZlkuXi8XULvDv7JQC49UJORUJuNTj+pispwyFCKwNcfOaK+O0k rE0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744906342; x=1745511142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kiIA8fIy8YmbCJnZvN/tju1TgqCKi7yKEus7AdngHaA=; b=Op+CToSQGtFkTun/f1tTjXMQbHV1IHkZaHaGzSY72/QWHXRzY6URT6pjr+L+taVA4Y R2zd5VagOV70tB7PHNbBM1wv+xXNuDTjoc7ndGaLyAl95AvhKesh+zvC+Bq6jXRFrC8R SQGfrxIg9+4aEZTxEcHuKhTnHm+hcjXp1M2brBgeMveS9m+u0oe8mgps8bZesr6I3t9p Tm844n9KULjzFFv9fbcQv7nIH+Pu28xb6q6wEdpNxizmUZ9UHY5kFE2Lizz5Z/LeKXyZ sICJre1VmQeIMXxIeFe84f8O3u27F2GnQzT/0j6YDFyCjEMQ/4BXHFhYW6kJ1lewSKPv ESyQ== X-Gm-Message-State: AOJu0YxpkkV1t22Eymx7GYXqtkstQnkrWkIolbAvL8L74X9pe+jt1TBp 3k/Yy8pLOUrrLrmOa45kadliJR68DDOtmLnOUW5/aPkoQ9dDS4l+ X-Gm-Gg: ASbGnctBlQId6lqSmufh2ZuxF8myPoFrW4yNEzUGJnpDZxLnPSHA45j/IJ+vi+HLqw0 6LDJ1TuvERZdoaCXV0vDOaTXlc1K7CQN7sBcrxVRTamkzwcQvEdQt8bR1ke+YUJ1vx7zONAJ4BQ oprdIsADA2JCWgqWi+1pLhfZD69ChtUyXWutxVGmyU7XIRL0Hwr0M7oicAbEKH+3c+YKnaFQRUc DUYWgJg+mU+7ccwBnFpRBo6W8PX4Az1aa0wuZe8pH655oRq12dT7g4qPl4MvtO+Olbi0m0qq0xQ 9dzpq+Ix6KbFC7HwZP5+CLolUsdhRoKUC+Dv X-Google-Smtp-Source: AGHT+IHEqcCUYv49u9TJin5pQQY9jjmHnrt6QzVErhvQ26P4aN8IZwhobOglByroR8+wQnj41vZmsQ== X-Received: by 2002:a05:6512:a87:b0:545:ee3:f3be with SMTP id 2adb3069b0e04-54d64a7b390mr2599564e87.10.1744906341619; Thu, 17 Apr 2025 09:12:21 -0700 (PDT) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54d6df60cf6sm2882e87.66.2025.04.17.09.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 09:12:21 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Uladzislau Rezki , Oleksiy Avramchenko , Mateusz Guzik Subject: [PATCH 4/4] vmalloc: Align nr_vmalloc_pages and vmap_lazy_nr Date: Thu, 17 Apr 2025 18:12:16 +0200 Message-Id: <20250417161216.88318-4-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250417161216.88318-1-urezki@gmail.com> References: <20250417161216.88318-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 874AF8000C X-Stat-Signature: yqetcjeyasaf8gnjmqboppp939bwmrbg X-Rspam-User: X-HE-Tag: 1744906343-267762 X-HE-Meta: U2FsdGVkX19A6yxKdFw39QkDfPQuCBzBuhE8VuudxiKD3UQBENH6tRCA98haYvZ7Ua6Y9DvPG5OW/spvm+Hu9J51pnpHNhZFUOvt5qbffDc9nKLs3EI948SL/DcZRoY8Z7dLcQJMx2/hh8HEr7nVFVRdpXEzCqhsfkA7sr1ZSxi/lDWrf4ACMTfcxrY6hPLph/z4YtEigy0X8f5ufqOl4rChnUsYcWgWUCfOvqroWfPLnsZ9Ev7iibo07SzJ+4OePaQFv5HPkzXi+BfnKu3/0EJ/gnrX52usR8Wx3TEyHha9K5bMWii0tBnFisVEB5fZS8aChTCN4viOYDt0sSvBZfKC3e+NQocOCm/FPlIwQV7Q+/Cgyoc5aeQXC3K4phrDY4hho6gRvTZgS+apHQat0xm/uaOUGw7r2RR5fBuh1JOG/yZkJtAUnAKcghPH+GSI/aV8u64PbVPnnzoIhgV0JZeFHjUGuKhprQo+K56LlwTZ/956ASsxnxq7airmtxQ1B0eiGvJpmTFBlH2OKv/u/UdUkdnaHo0me4il31FCbFXYN+lLKXV9gVhjMc8DtekXV8XkZKHbhAVs4Ba/z1GoU5+RSdTrlquIyv70rIPZDvse93zbiutijseH/CqeYku+nx7spIJf58+yOEWc/sbuaCBtrbREgb3eHoBnO6h4QmyFu87kle1UP9Z/JeTj2odaLGg8ikFyNhLsX9XuUIMjsmbq87AYJOgrewTbkzmPhgHXJDr0625rUnyHY3bNRXOTzDjLcJnsfd1f538z6bWD6OVBt6U76WBqkf7xZqk/Gl1G60gZrMjRMfJ4IL/VjZYgMPVVyVtMbyA7AkuP3AYhYxdB4fP1d+O3eT3d/sO9qA0+DnbCs7T8JXKzhwbUqWPkZbe7FBB5ZyAW4L7QIwepeuO3xYdnUN7g5riq5CWuCWXVBNtWFQ7pRBMzIccfn6MYe1PyZbPg7p+OIFPUkDC mEK22kaK yNa7I5JJjnfGte4Wj/jKqoq3Ze44CjkgR3fnueUUqJ4RCNVoFtwhODmQ4Ku651+bZyB6AggWcL0JftCEiyVZ4JNl6gRGdhAFVqkje4U+wPAccCp3UdBzL2kaO6pgco5hsStjv9JdvPI3iARhTzJvBVCiXQBa5Be+RCtdezVvCFcyhX+zDMBd4O1upE4GxlCVrSrCHFQ4SSAAZnBpkEVjQfTR55noUkVO2hzAvd/E85m6fLqrOEMICrtVyNH1+RZ/SyCazTOcjAXEPbVTc0SkaA11plapM0LDb4VvJPNhyUpxUJuwFPqMByRYYsQ3Hbs7DacS0Egco/9SdamGxuuwIW04h+V1fElLJrnhovS5ocO/TrxfuFdWnK499eun5xzyrxwmueKJNaO8ayC460UCEpXjmy05KAvKLQfBGJRxRXeJ/evU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently both atomics share one cache-line: ... ffffffff83eab400 b vmap_lazy_nr ffffffff83eab408 b nr_vmalloc_pages ... those are global variables and they are only 8 bytes apart. Since they are modified by different threads this causes a false sharing. This can lead to a performance drop due to unnecessary cache invalidations. After this patch it is aligned to a cache line boundary: ... ffffffff8260a600 d vmap_lazy_nr ffffffff8260a640 d nr_vmalloc_pages ... Cc: Mateusz Guzik Signed-off-by: Uladzislau Rezki (Sony) Reviewed-by: Baoquan He --- mm/vmalloc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 77da4613f07ff..54f60d62051da 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1008,7 +1008,8 @@ static BLOCKING_NOTIFIER_HEAD(vmap_notify_list); static void drain_vmap_area_work(struct work_struct *work); static DECLARE_WORK(drain_vmap_work, drain_vmap_area_work); -static atomic_long_t nr_vmalloc_pages; +static __cacheline_aligned_in_smp atomic_long_t nr_vmalloc_pages; +static __cacheline_aligned_in_smp atomic_long_t vmap_lazy_nr; unsigned long vmalloc_nr_pages(void) { @@ -2117,8 +2118,6 @@ static unsigned long lazy_max_pages(void) return log * (32UL * 1024 * 1024 / PAGE_SIZE); } -static atomic_long_t vmap_lazy_nr = ATOMIC_LONG_INIT(0); - /* * Serialize vmap purging. There is no actual critical section protected * by this lock, but we want to avoid concurrent calls for performance