From patchwork Mon Mar 25 13:54:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10869245 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9ADAC1390 for ; Mon, 25 Mar 2019 14:01:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EC95285B3 for ; Mon, 25 Mar 2019 14:01:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6FA6B291B3; Mon, 25 Mar 2019 14:01:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1FD23285B3 for ; Mon, 25 Mar 2019 14:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+kv3IFzh6x1x3M+RFsvKe6/kjuhidzqFN4UyhnjWD48=; b=JLVUWdUzv38SKn nDR9MaDjHQQ3JtZZINscbnC3EPKY5RXyuZzMSm1wtdLCz+OcuY5tXIDtewcgda+MKhJKGqXFaCze0 xn2MNEhZbWcHMToyPphKb44b2HgBdxJslOwWKzMYoFcIRlK6QjbjBahzdRbsKFnbLPl7f92GIZwRJ m6CT22EeZGsDti384nOeg7iRdyAPbSjsdQcIJawZvvMTJ34/q1uyOrtSLgoPf0ogdpXzDbUMtklsm ayk6IoaiZsPD4h5qWrFemhVrpfJN528apZpzawHGytav6srqeNQAcdrzSj4PBppOCCfdYVOxduU6/ qMoZnsLEWdHFpq7/qfcg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8Q9e-0007k2-Ow; Mon, 25 Mar 2019 14:00:46 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8Q95-0005rn-FM; Mon, 25 Mar 2019 14:00:30 +0000 Received: from wuerfel.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPA (Nemesis) id 1MEFnR-1hIcf10MWD-00AI1A; Mon, 25 Mar 2019 14:54:42 +0100 From: Arnd Bergmann To: Chunfeng Yun , Greg Kroah-Hartman Subject: [PATCH] usb: mtu3: fix EXTCON dependency Date: Mon, 25 Mar 2019 14:54:30 +0100 Message-Id: <20190325135440.2166315-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:Zbb7MMeGdeb863Dkkf0uRINDNXGjdVZvMW1rsAu4DzSl+dH8DM1 7JmYSZTemXkBoWkf+P81jpmFEFmA76GMyZvvgd3MS70/0DNYHHT37c+I6jpjlrNQyfPSu0K SC800mUXVa4iTiHPWbm4va3Ul7XTkk44GlVwMJypx8yUgP0pm6eJKfPS4zVBeVu/e/fGzKn f/Gl9a9c09yPFKTZQaJyw== X-UI-Out-Filterresults: notjunk:1;V03:K0:jcUb/1Q6h/Q=:YjSoPT+Yygr9LweqO7nkLW 2xcQy96APTWEQfzrtPMhfXKtDseQbA+qOAGWZpQJ+aDNPMu7CQauIsoONJB/uj8AisYNbPIlN 8vaqb4GZaejIP7IP/4GWr09N2DTs4zk3L5XZE3uGYBFOqPmrP/Kqpn4XybBK30GlznoaxzacZ NzvcrqMtTm1cNRLqHEEf3Z1K8kX9qOAHZnmmAA3oxBGiWxug7k3h74KwzEzYN2cnpmQcDhHy4 xRDUrx3uuUx6gteEVwrSaweNglO0cBCdG7hRYYeRDSvNp0yX0ZlVSNZ8bacrjX7KUhYvTaTeN csydjTMbjs2uoSyEBnQbJXqzh0gx99O3CLYu9jQnSpPxBioK2hEtJF5luRZlDfCK8ziPv6ivM 77IEg4NmW5Cpz68eHXonhr6nijLU2XC1vYnofIczDUqFfdQo86f7gqh/McD1/JZ8WiVuYSeh1 suz2qf2GPp20Qti03x3Ih97NtuWif4ikO7OdABIyISsI7/bakcA81qCJyUiH2By73dS6xLezL 7YpPGpxD+m3ZqddVoAETzIV+eFDITIoP3qvcesu2TEDvApQbqZX1BCjHPOCju6UK6bz+Q1RaK YXPlY5EQbS8Ht0A9WZeNV45wySETe9ubNViVuJVN3dXR87pVBLTsh0D7+x43mTwwFkhTOxhLU T4t9I4YRU5XgPMFxGN31mKX58zsRh0DpifEOjRMVPfBgMGC/D16+NG2WKKN8IfVN55K+rRyOu YTsj0W/R2N0QwoRyAHhsyhinhepbkbkmcAA61A== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_070012_115847_C4549A75 X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When EXTCON is a loadable module, mtu3 fails to link as built-in: drivers/usb/mtu3/mtu3_plat.o: In function `mtu3_probe': mtu3_plat.c:(.text+0x690): undefined reference to `extcon_get_edev_by_phandle' Add a Kconfig dependency to force mtu3 also to be a loadable module if extconn is, but still allow it to be built without extcon. Fixes: d0ed062a8b75 ("usb: mtu3: dual-role mode support") Signed-off-by: Arnd Bergmann Tested-by: Chunfeng Yun --- drivers/usb/mtu3/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/mtu3/Kconfig b/drivers/usb/mtu3/Kconfig index bcc23486c4ed..928c2cd6fc00 100644 --- a/drivers/usb/mtu3/Kconfig +++ b/drivers/usb/mtu3/Kconfig @@ -6,6 +6,7 @@ config USB_MTU3 tristate "MediaTek USB3 Dual Role controller" depends on USB || USB_GADGET depends on ARCH_MEDIATEK || COMPILE_TEST + depends on EXTCON || !EXTCON select USB_XHCI_MTK if USB_SUPPORT && USB_XHCI_HCD help Say Y or M here if your system runs on MediaTek SoCs with