From patchwork Wed Mar 27 06:34:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10872753 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8442117E0 for ; Wed, 27 Mar 2019 06:35:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C1DC28A29 for ; Wed, 27 Mar 2019 06:35:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4DC4728BF8; Wed, 27 Mar 2019 06:35:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DACB328A29 for ; Wed, 27 Mar 2019 06:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=maofwL5lyXx3KOKr3za8B+s/HF0JgJmZQQtS0u8W0L8=; b=tJeiIBPfwCMJxh 9zvp+Lw1aOquhGqHQc2crb0K6PC9d2g+xvRJAyzYNUG43ayrB7sMe06DKVT4na6nsmzdb3W+jaz5K ilzlU+tymgGTD/eiwPdGB9UpNYjDbIk07pLmKDdUlv2qPAw9L/9uQWPv+el8OWQ2vkjgU2F+aZnEA 40LDeVttWSbirEs7/2koAJzddb8W8ro3K5jk8xM4DLSd/5c04vkj+U6Tigq5X3GWFrEvWFcJ76kbn TFZSi4dwn4OlLsomeSOnf9JV9vXsT5dxtZg3HArVvj2EAC718oqcB1jL5swosqr8fk1u+nIbL37eH V+uaRs990KWUpYuR4Gqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h929U-0004p9-DV; Wed, 27 Mar 2019 06:35:08 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h929Q-0004G7-Us for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 06:35:06 +0000 Received: by mail-pf1-x442.google.com with SMTP id c207so9254540pfc.7 for ; Tue, 26 Mar 2019 23:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=isVyGu4L9+2S0FNKN5ZEi8kzQawHlgpIIQ13w9ZrByI=; b=OwmXc8RFOwbR84z8LBgKF6An2yApZn709Q/xuBqmcNZ7255Qpe/8TfCPhSgrJriFTc tG7GLoIlhKqqnUbArDhIQ62O79gk3mJ8Oo8dPnsR39VCg6oEeBgp8S1ZKU8z3bsw+hYe DJOlBFU7MVlFrLfzcaQz0xaFxf6dRRH1TgTBAJ5CNmwMIxM3N1lA15mSfNmPRcTIBde+ YqXgDSIxe+lwIfNc86Yp1xNwBIGbnDMywc2QbRwcRYohZutf/Cr3FT8sk7niduppUeB6 OU33gHtykQ1aI6KE3YJrtCns4hCrsOnWoTYKFVek3PLJ0qKlzja6gxM2SSGO4nM16aUi RROA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=isVyGu4L9+2S0FNKN5ZEi8kzQawHlgpIIQ13w9ZrByI=; b=MO2c7LzEuDiPXYvJJucOjtIx7XTSgFwTRWGDUnK2/PtafmaozXp/Uv+Apae2cAAwIu PVAjGNgF3A8rUnxwrB0E8qjg6zBqXoHxV/kZGZDx1TQ1dFQnDp1BTaNxRuHavW2Cp+hZ m3YZrOdVm1egX9yAwPsmzislBCFWhpTs08oWDFwWUY1H9lm2+Ls/Emm0yiM+g62SX3Bf APx236gkp/JnQxj1616NDS39VK6yPYTxcfXiYlTk8BfTtAwHBFAW/BYU7oEKlprp5Gpg S03w5Ckm2f/1SwFAQ1EXqRvLqwtDVFygBEQmTtGKb9Cpg5he9cpwdKihd/I/NvMZRVfD zgbQ== X-Gm-Message-State: APjAAAU4BmBHvfZPOiIpY1MBqAGZTFKJgS5lwH7Hj3l7WtlKRo/1plAy +qRDTjkoz2ZtM3qh9xe40Jg= X-Google-Smtp-Source: APXvYqzfvcGTW5dPqnlN/meZmb4Nyb1yCdbzoFpAnIh6kvUqFcFU9vRop5tEc3fXpb1ZOO07QLHQ1A== X-Received: by 2002:a63:cd47:: with SMTP id a7mr2969266pgj.434.1553668503628; Tue, 26 Mar 2019 23:35:03 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id k1sm19950258pfo.121.2019.03.26.23.35.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 23:35:02 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v2 1/3] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA Date: Tue, 26 Mar 2019 23:34:49 -0700 Message-Id: <20190327063451.25629-1-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_233505_025992_65098E57 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6QDL_CLK_SDMA result in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA functionality(this at least breaks RAVE SP serdev driver on RDU2). Fix the code to specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6qdl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 9f9aa6e7ed0e..354feba077b2 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -949,7 +949,7 @@ compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; reg = <0x020ec000 0x4000>; interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks IMX6QDL_CLK_SDMA>, + clocks = <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; From patchwork Wed Mar 27 06:34:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10872755 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AF1A31390 for ; Wed, 27 Mar 2019 06:35:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 940E528A29 for ; Wed, 27 Mar 2019 06:35:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 86C5128BF8; Wed, 27 Mar 2019 06:35:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 32ACD28A29 for ; Wed, 27 Mar 2019 06:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9d1VfwgIdcMIp+QHW37XlvhHRmp8k82GPYrd0rvFaL8=; b=mK7HGHSUYICZCw bxVqCq1L6OQSw+QpKYQb+IUZ4/6i8Ds/RZOydK/1x3BczkD6sdzMW0Vrx72IYbczRNgb3yW2TrHJn YY0G47thEGRHESAd2v0heBaj1kEtUlakbhuPgzju2t5F2R+2jNRHioy3wrA7R4TJtbOQkQ8MJMTKP igJ8QaBwnkvFCzycrYLxnrMEW5bx345W40tfu2kazUn/POS88qS3hXNQoZn+2GLGu3bkwGxTQ8Emj Z8WN1LhithHXhBO9bKNZ8PwTTbDqGfjAD0jeyEoFOLDdAT4ocN823RqSu0AMmeX5bmiBAkcGz1M+K S9RVigNg16LM9FeNNPHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h929c-0005Ji-EW; Wed, 27 Mar 2019 06:35:16 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h929R-0004Qb-Gn for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 06:35:06 +0000 Received: by mail-pf1-x443.google.com with SMTP id y13so3128045pfm.11 for ; Tue, 26 Mar 2019 23:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8peri8YrjObG6mnV61AuNYFEhPQ7twqVoziYh+diY6w=; b=jRX1l50gpnDO44z1/f2GOK8+1xw0+LwdOOCXBhHbSdQMYjXk9QGVaIqhFaxu2XQohT NJ8dzSAZq+8WuM9Kbzd2b3tDpeEWnltnUsnJEYSnROVluk6Qopy63AYe5A0IRec8Vfbm ke01ZUBF4AsdXSFvjfO5oMei8kFPAN8YufWe1P/B5fCTMDRYRZaBU3Qomw3uMHayj/hb pc/+noZBun3L7zP6ow99qmN1DPh///LilRzuJ5wPGOzQDwtavishSr2flEoZdGeelPX5 TI32cPlV8ZJsGDBsyPDg5YbBBCAe7I6O5tFMN9twKrpYwgb+KYIcCXamdXDoBl9hzYQE rkYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8peri8YrjObG6mnV61AuNYFEhPQ7twqVoziYh+diY6w=; b=Gl2FQohjn7S4sI/Xqs8YtFZ95ghNRkMytE3Sbow8z+dwWE59pJMI5nQZ+yhkKkLijY IN3Z7WkY8BnnmsbhrPbxpOfT0jKDWNT2UseUF7q3RZ9F9c7/AqCtfHrpieshDb5jvWp2 3H1dryO1x69JlKRaxB7faC+hQ/LnsV0+agbwsW2bs7uixqghOsCSALhz8CF1IWtkhFDg 5ERoPvpV0v+v+KUzxhN/iE5fsC7R/1NQrSTwLzMb5uhmSsPjymV5C3x4wk8wLuYKlBsK HbWV3nvP9EwxFdN3G4vnjGdOWfWs4Nbw/rFsXEg/7aeBGitlS7FmdY5Kq6W3X1In4u1o CsJw== X-Gm-Message-State: APjAAAXaY0CV5w4EN9SRV+lZrZBroAWMHPbDQoBCCkoXd2QqO/eKGbC3 iV7G6HVJix6XSJVtkeYMQJk= X-Google-Smtp-Source: APXvYqyQPZqriXYwvMYuesQUEu6Ora8blYjEhoXUBw1AST2Hn3uM16LQeO86E6eF5Dag4ArWEq3HNQ== X-Received: by 2002:a63:f310:: with SMTP id l16mr32299019pgh.72.1553668504783; Tue, 26 Mar 2019 23:35:04 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id k1sm19950258pfo.121.2019.03.26.23.35.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 23:35:03 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v2 2/3] ARM: dts: imx6sx: Specify IMX6SX_CLK_IPG as "ipg" clock to SDMA Date: Tue, 26 Mar 2019 23:34:50 -0700 Message-Id: <20190327063451.25629-2-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190327063451.25629-1-andrew.smirnov@gmail.com> References: <20190327063451.25629-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_233505_561133_D7E5F08B X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6SX_CLK_SDMA result in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA functionality. Fix the code to specify IMX6SX_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6sx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index df0c59519886..b16a123990a2 100644 --- a/arch/arm/boot/dts/imx6sx.dtsi +++ b/arch/arm/boot/dts/imx6sx.dtsi @@ -820,7 +820,7 @@ compatible = "fsl,imx6sx-sdma", "fsl,imx6q-sdma"; reg = <0x020ec000 0x4000>; interrupts = ; - clocks = <&clks IMX6SX_CLK_SDMA>, + clocks = <&clks IMX6SX_CLK_IPG>, <&clks IMX6SX_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; From patchwork Wed Mar 27 06:34:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10872757 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 91BCF1390 for ; Wed, 27 Mar 2019 06:35:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 76FCF28A29 for ; Wed, 27 Mar 2019 06:35:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B03128BF8; Wed, 27 Mar 2019 06:35:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1953C28A29 for ; Wed, 27 Mar 2019 06:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0x+jqzO5c1HepDq6tmSJ7t4f90VkLNrZ0QqpisHDIak=; b=g+Iqrsp7Oq8Fs0 sPIJmEUGbHO/lPjzh9E25xlZLEoc1YuNLazjd+Ljj7vTGG8anM7+1+U6kJXCyKGnmRNAjbH9MOT4N JZ4cxWETAp4PS6eQVFSZQXBDojsOAM01qgKyGlF0bfx3TV1lUW4dwyzeZyXeDZnhliV5viBKvr1Wi HV3gkd5+vmF0/KgKKlYGIlieOTGqSnda03r5LWg36Ej3LKnwM/sTrQ1O+vfHvluh7hnwJ/hvQsTMJ kEAKKEMgPgWOSdVP15ykORbFAfGBaWZOHfkfj5rKxg+gazU6dwm+hx2HQv+LnHaGaFTySdFfx1Ips Swp36jbzscRGddsmXjcw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h929z-0005jI-2g; Wed, 27 Mar 2019 06:35:39 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h929S-0004eG-LX for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 06:35:08 +0000 Received: by mail-pf1-x442.google.com with SMTP id 9so9230015pfj.13 for ; Tue, 26 Mar 2019 23:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=q69uzChJtoAuSsBw165cu2bB+9J9hZYbB2aNHX+ivb0=; b=AHbTU6IVnbAmfvbWJrWP+uMEmRfYSWGT+caN2AcKJHinyPLhTy8JVrXiF9meMjdJaY 7/AXPSmBgFSkkcaZhD7s6a1xT7tS2R8SJ+aKm/UJ+fFiyreqK6TkZ95upOG8NO2PQBue /KatWFveFxWv66Q7NqZdk3nB+HP7PuOcRldeWYPOXpCW/TVBXQnpkcQbdfMEwzCS5kd+ WvnWOf2DQLWGQMsSYFDqdJhPA6yCY2+YEZJ19m25sZr8kxqA0OOTzf9n6i/j1u/UVRwN D7MbccUToK05tH2W+io6EGcH0d/9o+Os14o/toQ+tRjiEh9WcTQQq604NXBuBwQMy4Wt Zzkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q69uzChJtoAuSsBw165cu2bB+9J9hZYbB2aNHX+ivb0=; b=QEk9Kr/CgygQAeABv7ipZPkX34LuopruH0e813pTCQ5uPmh98d9xNct5PHPOFHpkMG VonbWmx2uZG3o8yH750eOSUI24DfO/zj238zkerBFYAdikdHWNsxbZCSo+b0GP4epdP/ D2tK4l8lpyp6a9KLL/OcwQBNJY6fR95QseVUe1NXqDJzw/R+PBi49nR08+aF0ekIuXET GlabDWXtSl93PtyRjO3tmUccfqbP5OGyrrYtlWbdcUvDgFMLlgNpfEq97zJhODlGnhYz ELCbC3/5/t21OKcdW/xJ36lpdAY5dMK3QaCqBMfoZ1tfFOV5Aax3DG2XNzHHZsXuQ96D fa+w== X-Gm-Message-State: APjAAAWsroFH+pW5+nZp3+CPNZr7IJsD2SWQIPtpcWffcw3n/ObJQdE9 ToVokbLTBB2TfM6N1aiRzEw= X-Google-Smtp-Source: APXvYqwmP3g/k5dvwPJIzi2Sud76Pt4atW1kGWRYhFTFz2nwQpUr86C9loO+x9E4ij7marAPc0CDtw== X-Received: by 2002:a63:fc64:: with SMTP id r36mr32909309pgk.280.1553668506123; Tue, 26 Mar 2019 23:35:06 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id k1sm19950258pfo.121.2019.03.26.23.35.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 23:35:05 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v2 3/3] ARM: dts: imx7d: Specify IMX7D_CLK_IPG as "ipg" clock to SDMA Date: Tue, 26 Mar 2019 23:34:51 -0700 Message-Id: <20190327063451.25629-3-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190327063451.25629-1-andrew.smirnov@gmail.com> References: <20190327063451.25629-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_233506_710114_AA86A9AA X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX7D_CLK_SDMA result in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA functionality. Fix the code to specify IMX7D_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx7s.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index e88f53a4c7f4..2f45ef527e6c 100644 --- a/arch/arm/boot/dts/imx7s.dtsi +++ b/arch/arm/boot/dts/imx7s.dtsi @@ -1067,8 +1067,8 @@ compatible = "fsl,imx7d-sdma", "fsl,imx35-sdma"; reg = <0x30bd0000 0x10000>; interrupts = ; - clocks = <&clks IMX7D_SDMA_CORE_CLK>, - <&clks IMX7D_AHB_CHANNEL_ROOT_CLK>; + clocks = <&clks IMX7D_IPG_ROOT_CLK>, + <&clks IMX7D_SDMA_CORE_CLK>; clock-names = "ipg", "ahb"; #dma-cells = <3>; fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";