From patchwork Thu Mar 28 17:17:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10875527 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 31F11925 for ; Thu, 28 Mar 2019 17:18:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B55528B49 for ; Thu, 28 Mar 2019 17:18:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EF6E328BE7; Thu, 28 Mar 2019 17:18:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 95C0628B49 for ; Thu, 28 Mar 2019 17:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wzSmLxDojJZZXJ8O0zOeDjlCMc6EHpN9aB0aLAFWuWs=; b=YcNTP5x1bB/1zS I+kZegOMsglePyTy2Hev2i9wjU0Cn5ZvpKZwN6EqP3f0sC+IDdILpwBE6u6EOAm8tH2Mk8KJcvhGj ALDIVcqIdCIMwVTMulpKYjZiQcBmAWxCNwGXtAE5SR2WjMs3HUCO+FqwkqQJJar6bI4SrSmFeKtl1 Mh32+thupHXZZU1aO5ZPVSxHIb6RjQock/w0I5B6gIh0TSpZICZG5a8rGBjucAXJQ5fWXl3/G0Kjc YUjvlEmYuPxtKiyi30CEPjzJDCqwQlZvT6DxoSVtscfv9ksK7OYjfC60SpPXdcHz/5q4ZjzrLKcxa VuVLvXHgqxl12dywHnNQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9YfU-0007jg-HT; Thu, 28 Mar 2019 17:18:20 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Yf9-0007KL-Gm for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 17:18:04 +0000 Received: by mail-pf1-x442.google.com with SMTP id e24so10794326pfi.12 for ; Thu, 28 Mar 2019 10:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PLZp80c5zmxWFSyZnvtSAhGFGjN8GgpaVzXeZauR/As=; b=lf4nxR7Uk6SllC3sXaohqZU0wZL8kGjBbH8P55XZQHkEsOa8AbUOCVIx4d4JguH3ma fYUqogrV9g5bt5C71Y6/93mYdjA4wfcxM6/cWQl08oaFgVq0Y37HswfGdbaB4rYef3ru jkdVvOCtY0ev1MnFjkcXYpSEYRCXXH5wvTF+k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PLZp80c5zmxWFSyZnvtSAhGFGjN8GgpaVzXeZauR/As=; b=LgN6LXGNQsm+FQvGElP60CYCdk4P8wbUcfsW5X2XdIKW2v9e04xfCnsrA9TIhtpRES KwwlrSS9RrxGt0bcofF+DGpu9J/Z28mpzsyeNSSsH9vHH3wT6c7IKVhdOMqjDrTzgPkt CPQv2MpihhEaUa8XdAEYnAygU67AZEfSOe+xp0uv6XAEZtiQc4ZRBQO5xvAnXtx20DSX GDu+UiF71TdIWqfjPIZKBcKbJMWaWWGNMurmc9RA7yp80jkU84i7fRgO0ISLDX98a4FZ 6B4iN67gMDvymC+JxJkStVYq4svUnvLaNoSSik9F7P9KF0X8Qlscd6o4KFqokod/cNEb i1Kg== X-Gm-Message-State: APjAAAUPb3a3rFossXqTZP0PS6kzea1fQWMHY9u+2TGOW9J8GsCddWSo sRC/0QevTgvt82Qe0843qpAhrA== X-Google-Smtp-Source: APXvYqx9eJkDT/kFjG4NENDdfGYDqem2sMd4BUAVPj+/+V7ttxHpGj0MWP+qW8V6CsAXc9oqciCyow== X-Received: by 2002:aa7:82d9:: with SMTP id f25mr42008749pfn.45.1553793478806; Thu, 28 Mar 2019 10:17:58 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id r10sm31699414pfn.188.2019.03.28.10.17.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 10:17:58 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Heiko Stuebner , Sean Paul Subject: [PATCH v4 3/7] arm64: dts: rockchip: Specify override mode for kevin panel Date: Thu, 28 Mar 2019 10:17:06 -0700 Message-Id: <20190328171710.31949-4-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190328171710.31949-1-dianders@chromium.org> References: <20190328171710.31949-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_101759_751217_3476B364 X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Brian Norris , Rob Herring , Eric Anholt , Viresh Kumar , Jeffy Chen , Doug Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Boris Brezillon , Klaus Goger , Laurent Pinchart , =?utf-8?q?Enric_Balle?= =?utf-8?q?tb=C3=B2?= , =?utf-8?q?St=C3=A9phan?= =?utf-8?q?e_Marchesin?= , Dmitry Torokhov , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sean Paul This patch adds an override mode for kevin devices. The mode increases both back porches to allow a pixel clock of 26666kHz as opposed to the 'typical' value of 252750kHz. This is needed to avoid interference with the touch digitizer on these laptops. Cc: Doug Anderson Cc: Eric Anholt Cc: Heiko Stuebner Cc: Jeffy Chen Cc: Rob Herring Cc: Stéphane Marchesin Cc: Thierry Reding Cc: devicetree@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-rockchip@lists.infradead.org Signed-off-by: Sean Paul Tested-by: Enric Balletbo i Serra Signed-off-by: Douglas Anderson --- Changes in v4: - Rebase to top of Heiko's tree - Converted changelog to after-the-cut for non-DRM change. Changes in v3: - Unwrap the timing from display-timings and rename panel-timing (Rob) Changes in v2: - Wrap the timing in display-timings node to match binding (Rob/Thierry) arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts index 15e254a77391..454f4149585f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts @@ -43,6 +43,20 @@ backlight = <&backlight>; power-supply = <&pp3300_disp>; + panel-timing { + clock-frequency = <266604720>; + hactive = <2400>; + hfront-porch = <48>; + hback-porch = <84>; + hsync-len = <32>; + hsync-active = <0>; + vactive = <1600>; + vfront-porch = <3>; + vback-porch = <120>; + vsync-len = <10>; + vsync-active = <0>; + }; + port { panel_in_edp: endpoint { remote-endpoint = <&edp_out_panel>; From patchwork Thu Mar 28 17:17:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10875543 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A5A5E925 for ; Thu, 28 Mar 2019 17:18:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EBAE28B49 for ; Thu, 28 Mar 2019 17:18:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7297328BE7; Thu, 28 Mar 2019 17:18:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 247C128B49 for ; Thu, 28 Mar 2019 17:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a+qYjGdpC5cutkBSOShhw3r3GGUmjyM5nLRObc4Rou0=; b=X41RwGCBWjRXqb WYSQPWNdpYD9+d3FtkW0zWLvtB7yvB6T3S/vAPGmX86+MxGLC3UT9hVdY5RHy1kSBru3IAcG9VAm7 9zYdO6nNIdkFjtB/aR633f2lFBjDa2Tj4tWVX1euDzLSWNjY3OEAws60dI/RtKTO0zceb8Utfs0XS YNlvx7syLjbuiEW2Zo3f2iS7J+Lpiy+NQTRtvqExiHkM7KvURVdP3qUXF3HNAdt3m19U2+oL0nBKf pkcFihcASTO3M2xbf2sXBndA4akLoIJFf1nLabl78njt7NDdDEUrC2etJBWEf9nvcQBaiyD0XJwUW OVc253eSJa007pHB9i+Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Yft-0008As-Hg; Thu, 28 Mar 2019 17:18:45 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9YfC-0007OW-SE for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 17:18:08 +0000 Received: by mail-pf1-x441.google.com with SMTP id 9so11629072pfj.13 for ; Thu, 28 Mar 2019 10:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7ZYljoQT7r56q7Tny0+lw7nyShUHc+6HtAil+X2f22M=; b=J5dDv2C/IsLvgq0R2c6mRd3DgFJ9/x4/bzXxI6HTiLrcHnyT7WCjrgXxS6s3mqvYQn QZMfUOIVvTwRoEtSVUam5mPFkkOnU3QKQ2bm3wp8C3IWyh9Ll+JYAWuYPpXBDhvZJ6WE Tj3fJyqF0R8fe60H59+emYcXytDsYfGJvjZ5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7ZYljoQT7r56q7Tny0+lw7nyShUHc+6HtAil+X2f22M=; b=q0rr2QEtWU9tVBzsnjCFuaSn26xgK00e62mh5qX6d+DQAzK/xJlJhht7slQeSG/r9b 9UC9ZkfqHMB9zITxJRg3Rm8VbkfFHm2bhFz3cYhVfGVEH/szJMccdkmBUijvft9tmrsW cPxZi4a5QcF9v8luIusvAmwDRTDHtjwHtsuUfSfRtoC0vo0zbtWiCQ6GyDn4BLSIAM22 spOMxpM96TT+ztLyROAmfL7UnWDlWFHfbemYXhA8w/ePABawawjjsDsK0S9+fya6pCS2 AiCvh+q0ushqYu1HFvu+Bkj4lvGhw8CjTtiays8U4ECYuqokVsY/ODgaT1ZkR6Zk0Rve AGrQ== X-Gm-Message-State: APjAAAWzFfD9jgfpT9ASiDPkdvU7F8UzPzMcs42eL+LXAZJjiXwQUvlR 4DaA1bAWgFu057LfWLhNJffWdQ== X-Google-Smtp-Source: APXvYqxf6fx61pSdlisSBsdNvqz/BSOMo3J7lRV4ilP3yWjGujrBqUv+XHcmnYlnp/902LC3MvQrNA== X-Received: by 2002:a62:6c43:: with SMTP id h64mr42413296pfc.123.1553793482086; Thu, 28 Mar 2019 10:18:02 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id r10sm31699414pfn.188.2019.03.28.10.18.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 10:18:01 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Heiko Stuebner , Sean Paul Subject: [PATCH v4 6/7] ARM: dts: rockchip: Specify rk3288-veyron-jerry's display timings Date: Thu, 28 Mar 2019 10:17:09 -0700 Message-Id: <20190328171710.31949-7-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190328171710.31949-1-dianders@chromium.org> References: <20190328171710.31949-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_101803_348138_BE03A6D6 X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rob Herring , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Boris Brezillon , Laurent Pinchart , =?utf-8?q?Enric_Balle?= =?utf-8?q?tb=C3=B2?= , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Let's document the display timings that jerry has been using out in the field. This uses the standard blankings but a slightly slower clock rate, thus getting a refresh rate 58.3 Hz. NOTE: this won't really do anything except cause DRM to properly report the refresh rate since vop_crtc_mode_fixup() was rounding the pixel clock to 74.25 MHz anyway. Apparently the adjusted rate isn't exposed to userspace so it's important that the rate we're trying to achieve is mostly right. For the downstream kernel change related to this see See https://crrev.com/c/324558. NOTE: minnie will be fixed up in a future patch, so for now we'll just delete the panel timings there. Signed-off-by: Douglas Anderson --- Changes in v4: - rk3288-veyron-jerry patch new for v4. Changes in v3: None Changes in v2: None arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 14 ++++++++++++++ arch/arm/boot/dts/rk3288-veyron-minnie.dts | 2 ++ 2 files changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi index b54746df3661..0b1789b50c21 100644 --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi @@ -76,6 +76,20 @@ power-supply = <&vcc33_lcd>; backlight = <&backlight>; + panel-timing { + clock-frequency = <74250000>; + hactive = <1366>; + hfront-porch = <136>; + hback-porch = <60>; + hsync-len = <30>; + hsync-active = <0>; + vactive = <768>; + vfront-porch = <8>; + vback-porch = <12>; + vsync-len = <12>; + vsync-active = <0>; + }; + ports { panel_in: port { panel_in_edp: endpoint { diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index f95d0c5fcf71..ca7512ade222 100644 --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts @@ -142,6 +142,8 @@ &panel { compatible = "auo,b101ean01", "simple-panel"; power-supply= <&panel_regulator>; + + /delete-node/ panel-timing; }; &rk808 { From patchwork Thu Mar 28 17:17:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10875545 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CE2C8925 for ; Thu, 28 Mar 2019 17:18:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A63EB28B49 for ; Thu, 28 Mar 2019 17:18:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9A0EC28BE7; Thu, 28 Mar 2019 17:18:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4B7C228B49 for ; Thu, 28 Mar 2019 17:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OFPORwRYjFhHPRsVQcJ9WzRmhyDYGyMpB2ViJmdMN+Y=; b=EBATXBqMncWXPs B0+Eu6wZCdtef4reA5xdEb4lu44B4bp0f5O+wQtekdoTZt8hJhFc1WM15zcL2GvUtT+1dPth6Wp2Z kog+GQgArOAtIKLLl2cFXIcrpRv0HLydJnIMfsOPd9hYaZMZBVUm4DmBI8oErRVShEVzTt79R1yUA wsSpF3zP6KALX4NIjahiQJTT7pGeJhoh9GczkmQhkvNepWlJT4iyXzIiioNoUTK0uss2prgrHOD6b bPOd+gGphMK0lkekeAbv6lu8AH8Z7Pp20RhBH4ZVzjn19r756xljg1gtJ/LuFv73Il3wQKyF11F+g UHd8bM5rq4lnfN8Og3jQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Yg0-0008J4-3b; Thu, 28 Mar 2019 17:18:52 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9YfF-0007TI-JG for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 17:18:12 +0000 Received: by mail-pl1-x641.google.com with SMTP id b11so5252407plr.7 for ; Thu, 28 Mar 2019 10:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9vt45JTo9+c6j8dWNrO0OHz+tpId79deEfwrm9YqjVA=; b=C0sXUDY310SL/SQYeRt4iQe5a7IZUNKd2ajEsEMma+zuySpcP46oeny6KE9+HvqCCb fN8X9jGjPYtVY98XypzXk7M779imEhiwyHtsPbCogehzomsLOXt5a0NgUr3tZU+p50UY GsxEaaAIt0s/GZv1v0PtUwNUIWSAb8nqrs8FM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9vt45JTo9+c6j8dWNrO0OHz+tpId79deEfwrm9YqjVA=; b=UydK4qFrZjWKOiOyeU5iO6Utf2cAX5apHwlQW828Xra8kms4hkjT6g3fQXyXylQ9sY +BRkgqZP6XCMDMHKx3IFKu9xfXVrprPJr0g0rds6bt00vzrJZj2BsdHjdVo5PLw5/x47 YDJ8eExjd0V2ToRMxaaRULI5SMba7v+yee1hrfuyGoddENKRdK9lanxky/oDqDUvMqiV MjhV2lefMGoBIIHWJ+5EU1ockVKr/YUXgjdA94Pi1j+uqnMgsI4WWrdCv2WLh+P/MIUj 6rho1pli1MLf/eDwd/0XjosO0eaW7obRbGYSuz9+Vj/xy/GzSL3dzMSbddRZ5ldDRyfL LdGQ== X-Gm-Message-State: APjAAAVRtVHU+IZvn9WhdRutdy3Vd0GsuIkd/aJvkpa3UmANLYNkaknG a5I/C7hW3XUADgk4fHvxdFyRbQ== X-Google-Smtp-Source: APXvYqy6oeccNYbpih420nJpkiSJvEecbt9/dnOQ+Wdy7u1wEm70eNYUBkQD9q8fhTg2nXIVeJ/zvQ== X-Received: by 2002:a17:902:7587:: with SMTP id j7mr25505653pll.304.1553793483508; Thu, 28 Mar 2019 10:18:03 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id r10sm31699414pfn.188.2019.03.28.10.18.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 10:18:02 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Heiko Stuebner , Sean Paul Subject: [PATCH v4 7/7] ARM: dts: rockchip: Specify rk3288-veyron-minnie's display timings Date: Thu, 28 Mar 2019 10:17:10 -0700 Message-Id: <20190328171710.31949-8-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190328171710.31949-1-dianders@chromium.org> References: <20190328171710.31949-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_101806_314730_1616897B X-CRM114-Status: GOOD ( 17.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rob Herring , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Boris Brezillon , Laurent Pinchart , =?utf-8?q?Enric_Balle?= =?utf-8?q?tb=C3=B2?= , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Just like rk3288-veyron-jerry, we want to be able to use one of the fixed PLLs in the system to make the pixel clock for minnie. Specifying these timings matches us with how the display is used on the downstream Chrome OS kernel. See https://crrev.com/c/323211. Unlike jerry, this CL actually changes the timings (though not the pixel clock) that is used when using the upstream kernel. Booting up a minnie shows that it ended up with a 66.67 MHz pixel clock but it was still using the porches/blankings it would have wanted for a 72.5 MHz pixel clock. NOTE: compared to the downstream kernel, this seems to cause a slightly different result reported in the 'modetest' command on a Chromebook. The downstream kernel shows: 1280x800 60 1280 1298 1330 1351 800 804 822 830 66667 With this patch we have: 1280x800 59 1280 1298 1330 1351 800 804 822 830 66666 Specifically modetest was reporting 60 Hz on the downstream kernel but the upstream kernel does the math and comesup with 59 (because we actually achieve 59.45 Hz). Also upstream doesn't round the Hz up when converting to kHz--it seems to truncate. ALSO NOTE: when I look at the EDID from the datasheet, I see: -hsync -vsync ...but it seems like we've never actually run with that so I've continued leaving that out. Signed-off-by: Douglas Anderson --- Changes in v4: - rk3288-veyron-minnie patch new for v4. Changes in v3: None Changes in v2: None arch/arm/boot/dts/rk3288-veyron-minnie.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index ca7512ade222..8179cf9f6e98 100644 --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts @@ -144,6 +144,18 @@ power-supply= <&panel_regulator>; /delete-node/ panel-timing; + + panel-timing { + clock-frequency = <66666667>; + hactive = <1280>; + hfront-porch = <18>; + hback-porch = <21>; + hsync-len = <32>; + vactive = <800>; + vfront-porch = <4>; + vback-porch = <8>; + vsync-len = <18>; + }; }; &rk808 {