From patchwork Fri Mar 29 06:49:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10876453 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E453A1575 for ; Fri, 29 Mar 2019 06:49:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C141E28753 for ; Fri, 29 Mar 2019 06:49:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AF41728E20; Fri, 29 Mar 2019 06:49:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 08AFC28753 for ; Fri, 29 Mar 2019 06:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7L7Pk7fSY1C5Co42FAkx9MY1I+nOepf+ws4d7w0WCoU=; b=I8q8KzyVBRxdH6 kn9BeFbmhMU8x49iIFZ8oJsZXbvfjQpIumwJ5JAtAo4ApDexynBRXkFvte5xzNrqVbGhKERzFmtp9 1KDAy8B1YzUwZr+SagYPHby0LP3MhXHvXTcDonwCiL7woPzcpU0SuI48RhmTyvaymDEPy71h9J6Lq hVmRNZamPqF5W3Pi5JhG19XjDowNQEr7SadH+5IYOQrpUEKMoKpkwGwEdCW0lh1vwY1dGvWMcFhu6 u+LuJctUgP5O2URvwNEv8wn47IZj9vrfYNNMAzn4DB9I9ZOJWfLIE4k58heN7PlqGJTggJ3WsDCmg EQKUjG2TbJxdL0XVR1jw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKe-0003xR-7Z; Fri, 29 Mar 2019 06:49:40 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKa-0003wm-VR for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:38 +0000 Received: by mail-pl1-x642.google.com with SMTP id g12so550908pll.11 for ; Thu, 28 Mar 2019 23:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JyhG4KiqlmUctaeL7IFcdOPmGqfvH8RvX9zGV1WlMVQ=; b=SgvAku8jw3wNvgs0TT7my7hxPqoXsHzhUdta34s0A60ci2PMJ4TJtUWb107YbCrxdq PwlX3Fu4CBQkx1gTDxhE/Q7H1N0dOREQ6PRtdz83ZijOt56JRd6shbHixMxi2MqsLDNY yUHPVP1oQ6zGAsc6iz6jReJkzlbipuLDhs8IUvFdMoyQFBXenyWo5zm+nNNrmCuyZKgP As0CoJOfRlDBp4lLxbv6c6PO7235x8S6qJesaHcggxO4c3nGocRoggnreF5TkVGr0U42 3QSW/amV9/PSJArijESjrm9Zzgqn/Xs7OuTM8YwHEPxQQKpHJpaR0YqwqHSrM/xZUaeV glRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JyhG4KiqlmUctaeL7IFcdOPmGqfvH8RvX9zGV1WlMVQ=; b=PG2yUSygKOMM/GEN7J1K/qJmtVsW6NJPu5+RV3BlRhKALpC/s2l8WSG0kszr0y2Qn3 bkndKSBtDlYHODZ57HVGxXawNWDaXVuk+1YDQWufZWUkTsTEvh5g1veAsai/Mtc7Hezy lE41dkz2rv8MS9uOMslVZjK2bC06acj1CqLSxpE/vKl99Prb75VhnqFTFE+4OnF7HDe2 8T4ymD+IyN50YJBynKzsbN646BIzY4YpUMQcfRyNUSvzIi702wBH3ioSbhIaDXqU2a5p C/uNq+IJTZe7/umBoyDJh2xZkBz7slgkI5v23L4jJbZE3zGA8AbGzBWcyE73Dh5zOzY/ dHlg== X-Gm-Message-State: APjAAAW6PlaGg3OLPtUb2DKhdLPet0vGZN205Bn60m5jtnEp2EGRe+hO JHIl5jpHmkO7JCXjonIME8g= X-Google-Smtp-Source: APXvYqxJsoIPHTMM893IvjPDXA3c35Q3WVKowu3BuI5NY3nm2bAneFzlEj+i5R9Xufith4BF5tlTJg== X-Received: by 2002:a17:902:12f:: with SMTP id 44mr47511002plb.208.1553842176395; Thu, 28 Mar 2019 23:49:36 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:35 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:16 -0700 Message-Id: <20190329064924.8728-1-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234937_033426_0A8E0DAA X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality(this at least breaks RAVE SP serdev driver on RDU2). Fix the code to specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Tested-by: Adam Ford #imx6q-logicpd --- arch/arm/boot/dts/imx6qdl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 9f9aa6e7ed0e..354feba077b2 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -949,7 +949,7 @@ compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; reg = <0x020ec000 0x4000>; interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks IMX6QDL_CLK_SDMA>, + clocks = <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; From patchwork Fri Mar 29 06:49:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10876455 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 74C3618A6 for ; Fri, 29 Mar 2019 06:49:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D84728753 for ; Fri, 29 Mar 2019 06:49:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 520B628E20; Fri, 29 Mar 2019 06:49:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 023BB28753 for ; Fri, 29 Mar 2019 06:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yp9mHLNvnVaJC6ltYC9Zbn4in3Yn6MzsxPnFLqx6p4A=; b=M15J24JZncI4+n /gWbamMaNitIDSF85rVhQjJRARlERl3bow83IXWI8dRsMlfu2gbyWQrtAZclPVcJxNAjoCtTv48C1 nfd5KgJdrCM3WaYAg6ubuo9eHvAWu28GxcaE8+SfA8Px1v31ngdWpTSzUlGwLC3iXxXP0+JY9bi5F oTIeL12bCgzsjZQbgz6vpnnV5Je63HnEGjP0BU4/Y0oBk5kVJwOLOukQokRycqNzmw1K6cvaS27hD lYym/bSH0FOAh+tT6cDwlAbpIrJA/YjGJ2/nIxREm+Dn+4q7icqfCkC0axNY4xF27uBZC8jC091Nw w9S5p/CT81cJUTjerTxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKu-0004GA-HZ; Fri, 29 Mar 2019 06:49:56 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKc-0003x0-4D for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:39 +0000 Received: by mail-pl1-x642.google.com with SMTP id m10so551412plt.10 for ; Thu, 28 Mar 2019 23:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ATUitjO3l5PbwZI7xwdst/n1EivnhW4ELZtfYtpsmzw=; b=mXVa01cBPZ7ASZa37qhHs4ST7gC2TNZy2CJhdh58DleRfCAP5gO4/Gj0HF4UhfotyW dLOckldShqSGLe45uZYTabqXJ7AeBliYVfzcRkDT6llDdzcSEIFoTNbsknh3g8mXCKYM cu6GdE749wjKCS/dl+3vcMExs0my2l0IVThw1yiR33vxNPuAuB/yJKeoOarXtv3tC5gh sxCL+sYFdFyZb+9l8FgrEudBO6Vzqx4X0Sf0B7tFN7YqAYZSAd40G8OshNNhGTQhvrUF Mq5AWfsQtuMHddOvpWqbrxvn6JprOWzNOUOMQ8kR84+nu9qjJPP9EWAlEGVtmb7ib7fM nyHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ATUitjO3l5PbwZI7xwdst/n1EivnhW4ELZtfYtpsmzw=; b=MjBgmU6zjsV8CEMOu/o9RGyL7ruKy/l+TWZ3FGs+NAaaILTiy6KGrgGNSomCQDm9+J ZO+vgELz426gFgYaGVNf3L41UamcFvQa0DoIM71umtLW5XhzK2ElIzyrJz2rpBBQPo2F XrLTNOl+OM30fY3SbTKipv6r43c85lvJqrg0CWZQ4rmKV4FgxaMnVIW1LL/jLTH02spK RntVj/FoNvQlQddEhCm4VU4pjXWUNXGtEYsnQJo5oA4Aqb8KexCX7bF3MASDdmqDaHTs ZyUcLrybFSHJuN6BvRQBEHSKjjYx9Bhkt54WsAJWWUHexHZV//iW9jvGkgKGn6TVmPzV wMnQ== X-Gm-Message-State: APjAAAXeBIHvLX0lUDjT1trgGxW32aGldjszs9QsGwyMMYiBjF8iRssN 5d/chjEi0K3LD4IeWpA9oYY= X-Google-Smtp-Source: APXvYqzV0tPHbLG88WNKysL3Wa8O359cTEJVEk9eVaBs+hzI7yM83kE12caFJk5WxVMmsfMrp6Spow== X-Received: by 2002:a17:902:526:: with SMTP id 35mr44501356plf.276.1553842177646; Thu, 28 Mar 2019 23:49:37 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:36 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 2/9] ARM: dts: imx6sx: Specify IMX6SX_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:17 -0700 Message-Id: <20190329064924.8728-2-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234938_163214_450B7EB0 X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6SX_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX6SX_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6sx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index df0c59519886..b16a123990a2 100644 --- a/arch/arm/boot/dts/imx6sx.dtsi +++ b/arch/arm/boot/dts/imx6sx.dtsi @@ -820,7 +820,7 @@ compatible = "fsl,imx6sx-sdma", "fsl,imx6q-sdma"; reg = <0x020ec000 0x4000>; interrupts = ; - clocks = <&clks IMX6SX_CLK_SDMA>, + clocks = <&clks IMX6SX_CLK_IPG>, <&clks IMX6SX_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; From patchwork Fri Mar 29 06:49:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10876457 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0BA261575 for ; Fri, 29 Mar 2019 06:50:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E8AD028E69 for ; Fri, 29 Mar 2019 06:50:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DCDDC28F8B; Fri, 29 Mar 2019 06:50:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 64DDF28F2F for ; Fri, 29 Mar 2019 06:50:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ImdF7MkGdOGYOjgZhd93fIXzNwnV9GVcQiAfmFuOH3U=; b=KA73nsMeJgaSnW XvBSK2lOKc2s6MFOe9GlknaiZZZ36MgBmfwOwX37QNSQmIFoP9XxFoYE7ZRT0raH044qK9EBGxi00 PvIASEHPqqygH2NtUS6clJtXbHkUKmu1Hjjb2t//7rBK7wsa8aa/hxmRi5y3wrah7jk+SoH1ap19a pUQ2FjEMpuB/e0X+UZQOmzf9odihW9bBVpLvG218FRDsEaLCvU7UUIuoWLYIsjuE2WcJ1ZVs126Rb IXpkSrO+jxHoafM4vgu6ihTFnATxtqkXqh4fZYakqZL3lVME1DBPasyOZpx/rOygISLQMBZzjsgaO 0amRSGYlOQbVbdFAGJng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lL4-0004aO-Kj; Fri, 29 Mar 2019 06:50:06 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKd-0003xU-P6 for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:41 +0000 Received: by mail-pl1-x643.google.com with SMTP id y6so544826pll.13 for ; Thu, 28 Mar 2019 23:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ed5a919dY3TxioV9CWgdr4Ii/JOsTqTVDo8QZTkeUjA=; b=KcKE6eZhvOYJHOCyRNr4s2zhCAYrl5ce/sL08Ih58ZtQb4/P6Bd804ndV+TBEAqas4 K7EVk/lOuOTTvDFV+7dQqFeQiUyInitppPvIJOKXJa2HvVG+R8H7XCvZW/KUA5f3f40W rYxT7qVqz/2ndfDF0NacotSNNQk8JkranhiTfgmr98QICOR8K/FmipXXaUyI6dOpT5uB BMRyohFY94UONxszcSm86DkYC5M15HnmjsSwUvLGve5x40RuH9u6bSavV8Pn0rf9kqZw 4vPadMwfe57PKh74ZJn6PWv6tBODJQm53nlg+0JSMqPQxIL1/CzPHouG4lkmYrMQD2bJ W5Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ed5a919dY3TxioV9CWgdr4Ii/JOsTqTVDo8QZTkeUjA=; b=c26GrkD55Q/RIrRcGcqn3tZuXo8miXLy1VDxoMjfkaAw1ATeI0mla43BJV4kd9P2EP mML/YPPe8rm/S/RJCJsFsU0+pOI4FFVZqFPaPDPgV79e/JPyAjaak9kkP1lR9jjm7hDW Rf6OnCifQSTpda7e1b8HxcxaOU6l2LohVAaZrCOBUeq58qN+FNceMbLi5Qa9qDvsc0lV f3fhP+1cHZMigT3G3ypSUELMo+MaSkc7zE2ibr1cTKTqE10Vim0JW2t9ylKpd+5YKRyF 3oLvemxYYB6adaEjlb8bXFm/Jh1OGblnG0d1HAunhWoNNX9yRoS5LP+u/qdQeaH9K7Tp sTEQ== X-Gm-Message-State: APjAAAWbux5XUZ4fPsaceVqtSYFotW35Y3qglWJCX613A7IP4AwzDUUJ E3EqTB5vRmH/PmYhuCyGb3BRbWjt X-Google-Smtp-Source: APXvYqxOo1/psk3OHk8i2powPOqxmXlOQVNlKw+z26Vm4Mk9/xWXvGHAkg5lpLFi3mthdjz1MPB3FQ== X-Received: by 2002:a17:902:5ac9:: with SMTP id g9mr47531462plm.205.1553842179162; Thu, 28 Mar 2019 23:49:39 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:38 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 3/9] ARM: dts: imx7d: Specify IMX7D_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:18 -0700 Message-Id: <20190329064924.8728-3-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234939_927728_A378B773 X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX7D_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX7D_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx7s.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index e67c8dd4bdab..31c610e6c788 100644 --- a/arch/arm/boot/dts/imx7s.dtsi +++ b/arch/arm/boot/dts/imx7s.dtsi @@ -1071,8 +1071,8 @@ compatible = "fsl,imx7d-sdma", "fsl,imx35-sdma"; reg = <0x30bd0000 0x10000>; interrupts = ; - clocks = <&clks IMX7D_SDMA_CORE_CLK>, - <&clks IMX7D_AHB_CHANNEL_ROOT_CLK>; + clocks = <&clks IMX7D_IPG_ROOT_CLK>, + <&clks IMX7D_SDMA_CORE_CLK>; clock-names = "ipg", "ahb"; #dma-cells = <3>; fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; From patchwork Fri Mar 29 06:49:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10876459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 134C01575 for ; Fri, 29 Mar 2019 06:50:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F30E628753 for ; Fri, 29 Mar 2019 06:50:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E773728E69; Fri, 29 Mar 2019 06:50:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 299CE28F6C for ; Fri, 29 Mar 2019 06:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X2qRMs+u5U8NuQucAzuUjy113kfaGX+wGjFQF2bZLGg=; b=iyHIBHJLZGVj0H KWPcBjJPISLqnJ7fL+ff0I0AHKxCvKVPZTcP5F0wnU3quSunxCLyaW+F8OPhE0FoT94mdX6TYMMTW FgfarK+IuOyzqz3qLWRt1aeDZeaQBmhltDmCIgqRePyhkdczy7bF5j+ZGlIzQ0qmlRm404hYiqHlX hwRjSEG0eAKYz8N87H4WE5RsZuTkShc9KbV+opyPd1Mru/dg7tlkSGVzHs4W1Mgb7WVzwPRCSIs9B rey6cB2O5IxwnktpyE7aAW/HIhlA2QUBxyF2M3ZJJm4nYLa+NuinO5A+/BhAqpM9MnONXhJoI5PoC cfC39K8RPa+737UuollQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lLJ-0005xX-MT; Fri, 29 Mar 2019 06:50:21 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKf-0003yp-5A for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:45 +0000 Received: by mail-pl1-x641.google.com with SMTP id b11so555879plr.7 for ; Thu, 28 Mar 2019 23:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m4pOoTrjvfOyO3lHRQoZI3YMKtiCY3JviBbDnHNKrZw=; b=vbdKKoXViIM/SovhysLeQXfHIVYG/D4nV9xP5yW5NZ+wAfQ+AjPJujO7Jje835EFof 4tXzapRiS36ccIrdV+mLfOszyR+PHQ7keR5yfyjE0JueDZ+m2QTAD0PxbFDxHj+vqINh FOzsp1lXZtXSnP3vSweHCg0m10zC7gXsuSRw4NmIP6zOVwJl7Dzq+MErSBew2XMJ5hy3 3v0eaOWGaSlL+kdmQA/MrOv0dhwUX8WhNvwH8gbJcohL8sc/Dl0IoZ5AhaTVorYkQktB XWMNipRieOA3tmCnbwk5FXAe05ClKoGjGYrUsC6+qCCflkBQXmqtLtj/NsmZb5PBZZmO 7l+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m4pOoTrjvfOyO3lHRQoZI3YMKtiCY3JviBbDnHNKrZw=; b=b/KswKzD/50cl7AILtLprWc98OEhbHJIpAlWzIQDRL2DlznOr5M4cBJyUMzG3gaz2f M4D4QU0kxa1hyOBrTzACHDVvNGdYoXjMaXAIE2sYhYB7br7DcTMss63wvdGyA4nbPM2U 7os6XCNXaD0F5MuMCIx268kSCuWkoq8qlKDm68qU9Jph0VeMtKvKDc2rqRg15wfSBJHD VYAv6Ysq7E4DXQP+1gTThQHJgmxwQjq9hxQvQiw5qJwNd+BDUrruji89TSUW9IaVsEC0 7HnsSmjoiemVxEj2Q2s/Vst52JBUfHTqZDxoyZdOLrLjobdi/QzZJDyaL54I+P5Mow6H qn6Q== X-Gm-Message-State: APjAAAUVBBY73O7wBPz/EB/KFEdx6/lFJMAO5pFYEySIo6idk5Nmjj+h o5S8jRf8uVDOdFpBFD/FKTQe/GkS X-Google-Smtp-Source: APXvYqze/oP0qjRXMP8y7FGSppGFqi5zNAs7vi/n5aMY6ZrDInjtpFmXY971ohTMpMPSRFLOo0haGA== X-Received: by 2002:a17:902:2aca:: with SMTP id j68mr270129plb.233.1553842180433; Thu, 28 Mar 2019 23:49:40 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:39 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 4/9] ARM: dts: imx6ul: Specify IMX6UL_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:19 -0700 Message-Id: <20190329064924.8728-4-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234941_363901_006B4681 X-CRM114-Status: GOOD ( 13.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6UL_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX6UL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6ul.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index a77bbcae4571..bbf010c73336 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot/dts/imx6ul.dtsi @@ -708,7 +708,7 @@ "fsl,imx35-sdma"; reg = <0x020ec000 0x4000>; interrupts = ; - clocks = <&clks IMX6UL_CLK_SDMA>, + clocks = <&clks IMX6UL_CLK_IPG>, <&clks IMX6UL_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; From patchwork Fri Mar 29 06:49:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10876461 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E4F35139A for ; Fri, 29 Mar 2019 06:50:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFE4428ECE for ; Fri, 29 Mar 2019 06:50:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C426028F8F; Fri, 29 Mar 2019 06:50:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 67E0228F2F for ; Fri, 29 Mar 2019 06:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xTrVU6I+HZM98JF1WIniMI7k3LbhgtPj1BRq9J2mMbw=; b=QY4TXeMaCTZjwm I+9UgXJRziQMjwyCfH4tT/5uEPL+Fc+Rz91jMBo0w4ETr+OMA2tJmC4Iyrd2fFq6QW56x33+qBqQT geh9+52+e8D8JfkuqrixIyLE6OawvyJZz8TXOSgbz/Bl1EVG6inYHO4iP0RAAwMJ3VYSPaB4XKSux D/d5c+2LTvRK1hO+aqUntv2gieiSIUMFKemYZxlKpeXDahaoXoeFX5edcca0LBwoX0g38m69KH7B0 5JtIzu0OkvZy8SPST+LvwNfVO99F6lXo3og5FcyzojGbgrNUITcIDn4s9C6+Jei+g2gdVJWa8zvQ1 Tm3JTnScxxqx80DHsGzA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lLS-0006Bv-S5; Fri, 29 Mar 2019 06:50:30 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKg-000412-Av for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:45 +0000 Received: by mail-pl1-x641.google.com with SMTP id y6so572398plt.1 for ; Thu, 28 Mar 2019 23:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=klOQQder074G6QHLH5zIbrfbm39+4L8f6wWRAdAHSDY=; b=A3T01U2LaJJfUFIHi9Uynzel0Se7kfMqns7j3aJ+mcXBvDMYUrEKj7kFtywWt3UauZ jjghDJ2GN61ejYubBhsRcU8D6i78y5p1Y5nvY6tripyM1xnVJ4Y2/u+cFN4fwi2LiKIe v6IojykzLkuSnHTrL/lC9ZF5qcwy0FVm0fOuJfP+lIvI517RSAyjUhxilSUQFbWmhwaB 9wy/BFPbmyMwk1wPwWkI9t0jmTzMOcVmQi1kfLJkZult0Os9FbEbLLMwTzKL4w0cxLvg ZKCixyQegnm/AAVCHimWuuhbrMkHGYIYNtf+yCzsF7kaYGkjK8sD61jn3tRX0jvk0XZw WaYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=klOQQder074G6QHLH5zIbrfbm39+4L8f6wWRAdAHSDY=; b=UdFKK4gWwpEmbOMT3jdAQA0rM6GBFakoJvSJXJ+vpkG8bsIdSu67Ou6ZuMldaGjFan X29CyqUUAzFVeGy+qNBR0Elu0QBQGh/JZ8yPMPxo3ZZ6jSY5nw4PgDEPMMyzxTI/74Vw gWX37ktOAi76UxEK2msHMQ75xo2hGs342D/nUeioTy8Y/xdVBoz17qg5ETomUdRFKuMw U25D1lkdxhdvPUuC8eGlol47tjfSBrFbO/Jj+2ugpi6TF6FoGqhMggg+w8iK8T+b4YWe oA7PZ4jjfo6mgzZhvDxFLlZ2yC2lntygKqsEeG+No9CfbCHAVA+ddHLBeMTb1kE4RwTf /ahg== X-Gm-Message-State: APjAAAXLeaxWML4dBdsCUEpsM1rqQrBiFoorqX4IkPTZ2NW/CN3tU0bg uw+NSOulSh33hvE2oiMLs5U= X-Google-Smtp-Source: APXvYqxffam5Lj41/BYdtCA9pV8HcHSI25Yg6Yn5m7tFnacaLSC+0EkebK08KLGNmOwAJaHF4xJhoA== X-Received: by 2002:a17:902:70c8:: with SMTP id l8mr15461096plt.177.1553842181806; Thu, 28 Mar 2019 23:49:41 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:41 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 5/9] ARM: dts: imx6sll: Specify IMX6SLL_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:20 -0700 Message-Id: <20190329064924.8728-5-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234942_802314_C417F4E0 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6SLL_CLK_SDMA result in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX6SLL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6sll.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi index 62847c68330b..ed598d72038c 100644 --- a/arch/arm/boot/dts/imx6sll.dtsi +++ b/arch/arm/boot/dts/imx6sll.dtsi @@ -621,7 +621,7 @@ compatible = "fsl,imx6sll-sdma", "fsl,imx35-sdma"; reg = <0x020ec000 0x4000>; interrupts = ; - clocks = <&clks IMX6SLL_CLK_SDMA>, + clocks = <&clks IMX6SLL_CLK_IPG>, <&clks IMX6SLL_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; From patchwork Fri Mar 29 06:49:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10876465 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 68A5C139A for ; Fri, 29 Mar 2019 06:50:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5341A290CF for ; Fri, 29 Mar 2019 06:50:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4766A290D0; Fri, 29 Mar 2019 06:50:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DE96D290CF for ; Fri, 29 Mar 2019 06:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=olsY/LviXgpSHyMTBX3/ueoH1L00+2aQQNJbZCDPRSk=; b=DqVW2il9dVUeM1 YXFVGLZauaMIGQrmNgmxxJ1Qde5Fi9Y9FDtFEJuIpwFqn64/iPGO2Zv3TdpqQaSFhrNM0ZVffSGJr 1YMRLsKlCoixzOmnL3/pEaa0v0lacobQcmYDpmdLKJFcCU/9P2cL2ZEXQX/ekQgh6r2Hgq2PCgtSm E+IeqQ3PTuj6BoNhVVI2YpgK6P++2e9wfNL2TxylrIHxd0ED8R4rausZjtXomVTdigLpD5wCHpDF5 7x+ZpKPszTOpkuid7UXJaRlWdK88wMOAeS2sv//895eON0nSy3/Zcc06ryLueHS1c8fGjMtiJbUgt mwFhzZj1C702qy3kZ2HA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lLo-0006k8-6t; Fri, 29 Mar 2019 06:50:52 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKh-00042p-Sr for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:50 +0000 Received: by mail-pl1-x644.google.com with SMTP id y6so544907pll.13 for ; Thu, 28 Mar 2019 23:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=78oAD7dh5w277bxAutRdh7nAgrOQBYKs5ByiPHxGBA8=; b=u2EIPsDCRnexkBkXBBhY4+QyGfu7+OqxmXr8/rIvO07APnvnwDIY3WCbTidyJx2HGI ekDympdtLmlCkbuaftjOHfQZ/4Xnh3UwpZSKUj6N535RUxAODbKS9zu/LaId1GfUEUGI 565KsprppJegS6X5aP9Z5ZBXxb6IM/w07DR0wo2OeIX0cccBheClsOixISgmUjmbmdLR 0up5jC1ne7jie0t58f2whITfkfoRahC3J+TmTcRytOzuM9VV8jqhLXufrWFNW2kiXeI6 vbWzgci+2p5yCJXy3KCaN2UXgRWc6SSAdzKtI6r4n8Uv1EIhr6mwAXAJuCJ2CqfeDv9j D9sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=78oAD7dh5w277bxAutRdh7nAgrOQBYKs5ByiPHxGBA8=; b=ICXL59ykHNI4yqEDsnbRjNdL+K/FXS9/FhJiBJvdWRAjH5iILrO/Q/KVRujE2f/FDF 7bebobDfC63xPj97J8wx7XpMSCLc8MATiaazpX+JnM0ImIVqwV285M/tTRfP8wIMaAQo 4VcwiqbQu3YIHp4VJzoHybc17oC5/LnRQ2F6vFPF3iaQoFA1nkv79iW8N5WCpoovMsT1 h6h82du+hB02qaI2gmaDAMdaqxjpgdCtIoi8yQ1JdSXYFNMWXQdbi6dK+4Tz46ELj+r3 TQX804yYorXJceZ7XZUD7ukk/91aWrLLBxaxXzvPvwObNq9C+BQaZCTbbL//bEtjOdxx bWYg== X-Gm-Message-State: APjAAAV/GdGXI9P2Sg5MYg4hm04r2ajtCsFlk/S7jCqwi+XCQ/MjRpmg PAsxwmAnfcXmdv9y+/l8vjk= X-Google-Smtp-Source: APXvYqynp+0OiZazdXehyCana77TpGKT7NkRiOb6NE8phdvYxlXMhscTeH9ANLbK0A1N99HYJQWHpQ== X-Received: by 2002:a17:902:523:: with SMTP id 32mr45978430plf.249.1553842183045; Thu, 28 Mar 2019 23:49:43 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:42 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 6/9] ARM: dts: imx6sx: Specify IMX6SX_CLK_IPG as "ahb" clock to SDMA Date: Thu, 28 Mar 2019 23:49:21 -0700 Message-Id: <20190329064924.8728-6-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234944_386338_5E6C1748 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6SL_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX6SL_CLK_AHB as "ahb" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6sl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index 0ad5d507abec..9ddbeea64b72 100644 --- a/arch/arm/boot/dts/imx6sl.dtsi +++ b/arch/arm/boot/dts/imx6sl.dtsi @@ -748,7 +748,7 @@ reg = <0x020ec000 0x4000>; interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SL_CLK_SDMA>, - <&clks IMX6SL_CLK_SDMA>; + <&clks IMX6SL_CLK_AHB>; clock-names = "ipg", "ahb"; #dma-cells = <3>; /* imx6sl reuses imx6q sdma firmware */ From patchwork Fri Mar 29 06:49:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10876463 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 80E5D139A for ; Fri, 29 Mar 2019 06:50:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E0B128EB8 for ; Fri, 29 Mar 2019 06:50:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6258328F45; Fri, 29 Mar 2019 06:50:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DEE93290CD for ; Fri, 29 Mar 2019 06:50:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=845rvnqvogq8VQPQN4gVzTKf8XkxVNSnAxDmGJxV0eg=; b=sYQmtpwiykp7bg Q/A2ZsgVHiWHmI/THa//0hWRsPwPfLqQN3RmolgypwYGrBvlK1/WBAaswNkeBlhU2c8H8bawK7J7i o14hLcpwVnK5lGE6X/t2mx6OvClXHEkPc6hGo65sCOEloyx7/Fp4P0FQDexx/gC9DbPDj4iP6P/yg JLI8XcZUGodIDjwuvQTL5F+tZ8Tj4iCklkkmxy2EDInQpHbikqEqKL8G08/uzPCjjak/GS49fgqTU QYcC702T80ls39aeoHLw4nVq4UADRtlz1RpgrQZIlM5LYWm9PWXxUNqhnuPhmEJpyYHWvTMvpuwka 9tRvQja9M4HRfkLiwYEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lLe-0006QG-Pv; Fri, 29 Mar 2019 06:50:42 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKj-00045C-1i for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:49 +0000 Received: by mail-pl1-x642.google.com with SMTP id q6so565383pll.4 for ; Thu, 28 Mar 2019 23:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=14vBhqFf5cJryvoCa3IsFyVfRVbgmQyJmJY/JUXSOH8=; b=bzYiADF+z5x4y+NuS5hTb/LAfuQlw750wIfQ8yvJUY+ijj2Q9TuMAa2oSHZhNJqKpt m3XKhpZhynAlNtnjXpivMxZ2Cor8wwXK3H7VdgeNXJ6D9PMfVDjOLUpJ7GvFDhHf1oP5 HB9/L1nND9PYa4/Ytg0cxeOhclbAFK1z9rpU2A105YV3aga2FGCzfEKcsw7jRQsgPWLY ttuVg/EQmi5+HVkQw8RJPtzBSMyM0o3asep8jQv0+fceWq+Bjm1cWUhIVVEQ5FenJrkP 6nSPZXCHwvqrOKwQKfxLxkJrWhxd9E+Y30bZlOTRiVQ04yuOr0K/2jwWW8pCi81jp6sZ mBiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=14vBhqFf5cJryvoCa3IsFyVfRVbgmQyJmJY/JUXSOH8=; b=G0f4OA3y5Jtwf1CtGT8bCOOyZKzLLca0KbOgti4+Hu3ZtyjIY5zCePgcejdkL5yAy8 QlhjXYb4llsKVK0ytZR0NcOTiEBWQY/I0n5kNgek5a1uZ5c7iI4raV3lYG9rjrqXqiG4 Br6FRNktEZKjG9+n6OArkT+9hQIDiWwIpqxuXE/SaqtiTYAYv2lmVR2mkMuS/t9HZKep 9apGIQeaOGzj5RncgSOMCbT0BOyTs+ES2pAaY3aBVxcPFBGGyRi8ircUR4y6/dapq4nk 9opST78TtTHX7ouEMFCQv4TtAL0hcNrMUGYEVZYYzFIPxzZ646wbFBUYjKmH5DIWraFq rGrw== X-Gm-Message-State: APjAAAX3RY0TelvEtVZyyYIa1Il6bb/Si/RqxXMFt8RUWV0i+svEKCKb gdVz+mwJ3UrPjA7fWIBarh0= X-Google-Smtp-Source: APXvYqxvEvw/9gvcKhnyndKu5mOIK4ZeAoGtW9V1jSyslFFz3RZMUyzGoT7UD10MJVH9r1nYfkuahQ== X-Received: by 2002:a17:902:6907:: with SMTP id j7mr44998446plk.32.1553842184488; Thu, 28 Mar 2019 23:49:44 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:43 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 7/9] ARM: dts: imx53: Specify IMX5_CLK_IPG as "ahb" clock to SDMA Date: Thu, 28 Mar 2019 23:49:22 -0700 Message-Id: <20190329064924.8728-7-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234945_512491_8975B96D X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX5_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX5_CLK_AHB as "ahb" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx53.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index b3300300aabe..9b672ed2486d 100644 --- a/arch/arm/boot/dts/imx53.dtsi +++ b/arch/arm/boot/dts/imx53.dtsi @@ -702,7 +702,7 @@ reg = <0x63fb0000 0x4000>; interrupts = <6>; clocks = <&clks IMX5_CLK_SDMA_GATE>, - <&clks IMX5_CLK_SDMA_GATE>; + <&clks IMX5_CLK_AHB>; clock-names = "ipg", "ahb"; #dma-cells = <3>; fsl,sdma-ram-script-name = "imx/sdma/sdma-imx53.bin"; From patchwork Fri Mar 29 06:49:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10876467 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5D60314DE for ; Fri, 29 Mar 2019 06:51:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41FDE28F2F for ; Fri, 29 Mar 2019 06:51:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4017828753; Fri, 29 Mar 2019 06:51:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D188828F42 for ; Fri, 29 Mar 2019 06:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FMXQ7yBUdygGImYp97inuvDy5oin5Ykmhu0UZA2Maz0=; b=aV8M/gLXTzXciJ 1nTc1FZMrRH45gJ/GVND6XRXvhu2zOlSs8sfOKaZogE7UJoArY0S/EP3eud4Fo/BbgkY1sHu+57MI SLpM9/eaUM1/HJXiVIdGSwBMhs7QIlkN3I8TqsFvjSTGieBaPJPNekKFwaOGahZ960vz9FLDsxWSZ fjS0nVhb6WudDwf5631NDiDdnU5K0H2fQ11QMb0dIRtID1G504pE5SnYKzJUu4wqLUbpBr/dQnz4K kj9W4b/JazafsCaiq7QkdEpDrgPzQbXbRwAY7mYjv3xXwbSPO2kahvypZTup9cgrSi3gnX2+l48aF ntmNr1LV3FIl9mSUDSCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lM0-0006zv-4p; Fri, 29 Mar 2019 06:51:04 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKl-00047D-BD for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:51 +0000 Received: by mail-pf1-x443.google.com with SMTP id 188so579581pfd.8 for ; Thu, 28 Mar 2019 23:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k2Cjq9x631wLzGK9gtayGHpM1M/LJ4e0deWNdmi+j4Q=; b=Jbx8eCCxlkj9f7lJcaEAl/HEHgnmd23R2aMcPE63P988aQzKfTpRGRqss7KmVBiP90 jDkNg2oZxMGgXzun5Z4ASHo65AF2SsbCn5jEGOFay2GfCplLoJfJoUL/DB6sgh67f3Kb Iqee6lVHWiaClL11akdrKiRKVFU/w4NX5+xFhJr+J+YLjO6rB68zuLnbMvJHd5ERWrWK X3TzLtwek6CnqwZIdkCfjs07KR2E7RzQbo5wSZ6QJ1Z+Idil0GyLY8vaErb6BrvK4B+A lypAoCjfnYgf4zDlCl40bsd23rJmlC2SHNtZRmOASJQsH18jiJPcsv4PgcskE9jN2gko dwkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k2Cjq9x631wLzGK9gtayGHpM1M/LJ4e0deWNdmi+j4Q=; b=LAovk8BadjNhKTAOzyfuZWwxp+LRZPpFa9CeXr1mXsx86iwKKlsz2jpFkvL+CaHGIW HfoU3trl40Y/dI2AJSIMNkz0X7LiPBp4KjI1paS8VdJ2h28qDN4eCgt/gdXhfeHiDkq/ cm9yLsM5kHdoo5WKHMSdUaZlTKq5+JrrpEfNaV6YNlk86GZO8cxiGZS6w2t5Tixn4F5t +b4RjZwQqJePlBcPQjBLqNzzn0P5N5FgupaLFo7fRzVMjpG6yQX7MNHVl3zBTyO+kMRJ LxME3ZN4e5/G/8nPL2gmD2a2d0vpuX23P3dKJNoJyre4zverNo7gzqzROrVTqbDWDJx/ 6XvQ== X-Gm-Message-State: APjAAAX/zdy1aw29kJM5ZDVjiaej8vH/DrHfVDpay7teWWJqIH/SRRB2 Gnxi6PLGBZL7lhzayIe64ng= X-Google-Smtp-Source: APXvYqxLsZC5YO8cJYi/3oaIayEUxv71d9UTF146nTi30hXAygzBFtodjO31jw3aEpc97YjhVfGy+w== X-Received: by 2002:a63:78a:: with SMTP id 132mr36937172pgh.196.1553842185715; Thu, 28 Mar 2019 23:49:45 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:44 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 8/9] ARM: dts: imx51: Specify IMX5_CLK_IPG as "ahb" clock to SDMA Date: Thu, 28 Mar 2019 23:49:23 -0700 Message-Id: <20190329064924.8728-8-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234947_695115_0C4F99E6 X-CRM114-Status: GOOD ( 13.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX5_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX5_CLK_AHB as "ahb" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx51.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi index 0b28b68a17bb..e3fa3d213cd8 100644 --- a/arch/arm/boot/dts/imx51.dtsi +++ b/arch/arm/boot/dts/imx51.dtsi @@ -502,7 +502,7 @@ reg = <0x83fb0000 0x4000>; interrupts = <6>; clocks = <&clks IMX5_CLK_SDMA_GATE>, - <&clks IMX5_CLK_SDMA_GATE>; + <&clks IMX5_CLK_AHB>; clock-names = "ipg", "ahb"; #dma-cells = <3>; fsl,sdma-ram-script-name = "imx/sdma/sdma-imx51.bin"; From patchwork Fri Mar 29 06:49:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10876469 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4217C14DE for ; Fri, 29 Mar 2019 06:51:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D50A28EB8 for ; Fri, 29 Mar 2019 06:51:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 218A4290D9; Fri, 29 Mar 2019 06:51:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C62A928EB8 for ; Fri, 29 Mar 2019 06:51:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VuNuuE87xyzQ0U+nTztRSrNfHApWEtlISYw03d9exvA=; b=u1zerqVGUM4GW+ CCxMWcix20hahp2hbUzpOHgtZmDUkWH2bOIYIJwFgVGPWPM1Nmzm5RNJLcpYUTKN2sX7/t4NxUX5S zFg9UP4wdN8jMeK5IA08eUvQAjJAbeYTro3VG2mtHzqwLeaiwurvqsGluppHgbdYqSkw++Y5gOm0l npeK15Y5rcigpzh7cW+Xr5t37Hz0Yw1RUUFoBgeyjXwn77xPo6ZRt7aB2B2Ud3BZN2rCNhosOS+Hx /T5f/dX1cRUZnWPMje62+S0gFFSq7EaZ7g8aAX2bjrncKAA45wTnFEHKod98Ks4oNyZSrhCJSkDLY lC4LsJ0RGh/v5OKppdSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lMA-0007FJ-Gg; Fri, 29 Mar 2019 06:51:14 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKl-00049o-Vs for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:52 +0000 Received: by mail-pg1-x544.google.com with SMTP id q206so736995pgq.4 for ; Thu, 28 Mar 2019 23:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nLcLvDQ0tBdUld5eZ44Ef7wclD7DpyhXGUY4yFYZw3M=; b=q1qTbgw+Ievjh/GvVSVJX0qEad3vtX70IL71heAynHc2rhGt/qNzbRuHmUkgkjQt6x Bi8UCCKhfeHSXXJXRxJwYBL0OmKRDCbJwyZugFqzZKBjLtjS0AaA+KZqt6T9E5czSeOB AcWT40BDH97GlAqyuWCxEKMfjP52m5Jy/I0HJpmStWCsWqlKliVJIO9RkPPxZDiTbPN9 g1/devdDCQGvUQbeBFDHq3GDLsDYZUfDuyxeW7r8CvNX+L8WHlHaBAzpfXxW3IvnNWly pceLk1RAiTHKPGpz59T4Zss701LtA7Soep88KfhF0euDWGru62bzJpSavfmRjQifJoyg zTPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nLcLvDQ0tBdUld5eZ44Ef7wclD7DpyhXGUY4yFYZw3M=; b=mR6dNVciEJ1ugBuS7N5EeWIOTL+H8xJVzu7yVdsLMvY3s2tbiv/b2WY93mNjxBcLEg F2I8Ev1XCYG+AWeV2QRhyd2qb+cAbrT3ViGAcSdroPneZ86iDvj73uolk7sVJUgLrERG 2iSdk2dl24Oz+V7ESEl7VF+2aII5u6bXIpzPgQiLhst9JW6PhTqfUFdxWZMqKZL7VCDn d+ebrV+NhoejJqvnT4z0yLFXC/Arq1kzggsgSry/u/t5GMnCGrs/R4Hx0o2NycEQKfSz z3mTf6KDoq+BmW1n+uuWW5Dj0nPMyG9OTm6ovlJzKAo9BRIky4YJOvwqYf+yZdBGMKwG +Rfg== X-Gm-Message-State: APjAAAWliQ/3r8b9MzEnYW5E4Uex/fo3a5RYHz6erL7RjxGlVBF4TjuL fk1dmAqIXYsItYGpX+u/MP0= X-Google-Smtp-Source: APXvYqz5Fm6NvMET8kFLBgZhRHarg/+O+9aIwtUQeHtsyhroZoEY2FTxmmOEg+5tC++QpdIk3gu05w== X-Received: by 2002:a65:64c8:: with SMTP id t8mr16459312pgv.248.1553842187291; Thu, 28 Mar 2019 23:49:47 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:46 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 9/9] ARM: dts: imx50: Specify IMX5_CLK_IPG as "ahb" clock to SDMA Date: Thu, 28 Mar 2019 23:49:24 -0700 Message-Id: <20190329064924.8728-9-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234948_288224_3EBB7325 X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX5_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX5_CLK_AHB as "ahb" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx50.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi index 5dd61bff3b76..0bfe7c91d0eb 100644 --- a/arch/arm/boot/dts/imx50.dtsi +++ b/arch/arm/boot/dts/imx50.dtsi @@ -430,7 +430,7 @@ reg = <0x63fb0000 0x4000>; interrupts = <6>; clocks = <&clks IMX5_CLK_SDMA_GATE>, - <&clks IMX5_CLK_SDMA_GATE>; + <&clks IMX5_CLK_AHB>; clock-names = "ipg", "ahb"; #dma-cells = <3>; fsl,sdma-ram-script-name = "imx/sdma/sdma-imx50.bin";