From patchwork Mon Apr 1 17:17:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10880391 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1269C139A for ; Mon, 1 Apr 2019 17:18:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2C3B287FE for ; Mon, 1 Apr 2019 17:18:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DE80F288A2; Mon, 1 Apr 2019 17:18:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 85D732888D for ; Mon, 1 Apr 2019 17:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BCyHefKR1hB3pS5OCl9MLnhfQTerGUGASKpmEdzP0yU=; b=roI0cATWzwOuIm LTh+uAZGB6vyDHGo9u4+NBAVQC+AHo2KkxN8IUhx+kJPd0FHWw2C4M7J1YfuXXDAXkOVNCmVOQDDI Vp6ykhMUzA2o/NSK/8SX2vL2ctV5DQMefJIzusvteGhCMeqle7p680jqMhnkdoTyYeziEAUJX8Ain SPl9C48axEXeyWdm+5SBfItahuXQiYahI0zey5kw85i3/SVs0eNR8HKozxde3yZS20OaU0aHB9j4j MXNBDl6lLFvv1CSUGHid2g1w7q/zllCamkihTcLqkljW1F/rd4vlVeAZoPHpTtYk4x0ALUurIEWtB VqdNxXOLUkMCeIy7xZlg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB0Za-0004XY-6i; Mon, 01 Apr 2019 17:18:14 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB0ZI-00049h-Qp for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 17:18:00 +0000 Received: by mail-pl1-x642.google.com with SMTP id bf11so4793786plb.12 for ; Mon, 01 Apr 2019 10:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+AmmzLpPuFAi2VfTCy3FGaIq62ToFSCjB0vDQGXh5jI=; b=eBBUS132qAEAeeyD4XiRW5YP1rww5Lg7gYGB+oO7KS3ovyzwyTAPsd/h/x4GhBW8KP OP83v8dKgY6b7HdwPPONQ1UYQin9i5p+Ck7+45RqSRc7CDVw3W5yQL8vCpAMTCe+vPDd Z3Hv9W3nk/2/TCKJbxNAHJ9HNKv7dR4vyMEqU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+AmmzLpPuFAi2VfTCy3FGaIq62ToFSCjB0vDQGXh5jI=; b=l6pSOR127VRpFhoHbnK5d2ppXfiojpwujblm4Fe4dav4jCEcG1vFnKbu9kgOOth1hj 0ksNtcqn/X3UXW66BHwPMJ+cPS+4FYUZkZTGrgbKDpifZtkQBz3S/z6/eI2tX4rfMOV5 6lWgnkfZpyMQt6jh9keBtUXvMACIiKoIREOSiFIaX3dMmMCtPOdiDMTDe6QAHNSuuoHf gk9ztvrheGRbzGv16wCnoqoPK9UZWwasTcby820gUdrppt+mytpLZcs6Q4givb3R+ygT Y5yykbl6lmFB+hJS9jC1CtB3xlb6T7ahnBevDduU1b/6FS3B3fEDEM1xyK6WIU9rXeAC 6sng== X-Gm-Message-State: APjAAAXeaVdzjQxD2VMSgcggGsUcLrjIm+hhtclW6e2w9Wy6vbdPfr3g PDFdhOzJxc8ScVL3UBXfVwCS5w== X-Google-Smtp-Source: APXvYqwyiWBFZw15HVw5xaJZLX3TCLYZ5TaRziMtPFmNwUJOtKUj6mfNqpf7cxkIZjBhV3IxoVIxVg== X-Received: by 2002:a17:902:2de4:: with SMTP id p91mr8321570plb.191.1554139076325; Mon, 01 Apr 2019 10:17:56 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y12sm31370112pgq.64.2019.04.01.10.17.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 10:17:55 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Heiko Stuebner , Sean Paul Subject: [PATCH v5 3/7] arm64: dts: rockchip: Specify override mode for kevin panel Date: Mon, 1 Apr 2019 10:17:20 -0700 Message-Id: <20190401171724.215780-4-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190401171724.215780-1-dianders@chromium.org> References: <20190401171724.215780-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_101757_020284_EF980AC4 X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Brian Norris , Rob Herring , Eric Anholt , Viresh Kumar , Jeffy Chen , Doug Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Boris Brezillon , Klaus Goger , Laurent Pinchart , =?utf-8?q?Enric_Balle?= =?utf-8?q?tb=C3=B2?= , =?utf-8?q?St=C3=A9phan?= =?utf-8?q?e_Marchesin?= , Dmitry Torokhov , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sean Paul This patch adds an override mode for kevin devices. The mode increases both back porches to allow a pixel clock of 26666kHz as opposed to the 'typical' value of 252750kHz. This is needed to avoid interference with the touch digitizer on these laptops. Cc: Doug Anderson Cc: Eric Anholt Cc: Heiko Stuebner Cc: Jeffy Chen Cc: Rob Herring Cc: Stéphane Marchesin Cc: Thierry Reding Cc: devicetree@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-rockchip@lists.infradead.org Signed-off-by: Sean Paul Tested-by: Enric Balletbo i Serra Signed-off-by: Douglas Anderson --- Changes in v5: None Changes in v4: - Rebase to top of Heiko's tree - Converted changelog to after-the-cut for non-DRM change. Changes in v3: - Unwrap the timing from display-timings and rename panel-timing (Rob) Changes in v2: - Wrap the timing in display-timings node to match binding (Rob/Thierry) arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts index 15e254a77391..454f4149585f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts @@ -43,6 +43,20 @@ backlight = <&backlight>; power-supply = <&pp3300_disp>; + panel-timing { + clock-frequency = <266604720>; + hactive = <2400>; + hfront-porch = <48>; + hback-porch = <84>; + hsync-len = <32>; + hsync-active = <0>; + vactive = <1600>; + vfront-porch = <3>; + vback-porch = <120>; + vsync-len = <10>; + vsync-active = <0>; + }; + port { panel_in_edp: endpoint { remote-endpoint = <&edp_out_panel>; From patchwork Mon Apr 1 17:17:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10880399 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1E930139A for ; Mon, 1 Apr 2019 17:18:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB627288AF for ; Mon, 1 Apr 2019 17:18:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E8049288AC; Mon, 1 Apr 2019 17:18:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7D43A288AF for ; Mon, 1 Apr 2019 17:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5zMLZV/nyUqeXZRqaiFPo73UQDgTrJO1BrTOg9067v8=; b=kN+xutE1dsxsOU 4tCwX1rF3MWMzb6YbKkdif8JA4BvjTgGN5AnPYkXfpg/pR6HQylmUscYYxDe6x2GB47Qiny36ZKY6 PEr1zYPuRNmH5fcm72Bt3Xv6uiP84CgyIZsOb6mZMwXPa9Caaa+cCAUR2ikeI7iGKyfV+ZUjkfL2u IoI62ljqwpRNFewHdCRiC20Ny1EoQRhDBYqBtOKosLTtjOj4GGJZ41xedD1o8alWGn7c9dqjd+ezK kdBbh71We9kPQmM5aXn35Ut+EzWnEDBiXwU6UJGhDYRS9+/DO7FP8UoOXFeyay4RMWXgXr3f8BkEq Xa/y416HZehDKk/DcCvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB0Zq-0004sp-Fy; Mon, 01 Apr 2019 17:18:30 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB0ZM-0004Ei-Hr for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 17:18:06 +0000 Received: by mail-pg1-x542.google.com with SMTP id b12so5112914pgk.0 for ; Mon, 01 Apr 2019 10:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FwO/jDHDC0Ih7P0JglUjIP9FDc3AOf9qDgJIWXGCK7g=; b=mreDX7Z65nkxGWJLVlsYOQBiVbZAl7CTxx2DLguTXxMbsbnzBcm7Fz9mRcq3Z93xaf PHtmpl3gh5H9v0CyqJ3YV4PuIoOWx8mBUe/P/Z+7P5BqZkNDlmUnKHq/feULbm1lVLPJ WcBNapWip1/O2y6fqpzL3X/jFihRReorI5SKs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FwO/jDHDC0Ih7P0JglUjIP9FDc3AOf9qDgJIWXGCK7g=; b=o5OfcdAchUb8Affph+mT0lfOV5CNlF+E6i6gG8mgKtfuUVkvCvdcmulLPp1sO6Uhfk dQGW/5ZN20UJZfFe/+FupLtzWza0N4Cnn5WBAnRuegECRWn+bqdczJhSiUXKXxk1cZDe ig30Mb1JrXw8canaNhEc+6dtykC1D1A5Hqdb86Rgw6C3Fc4wpQNJwkUOWJeVkV5iYa+N Y+G3mYmltzEtc3Up8twUcAfUhdGSLkCPA55AoWQXvvN5c8z1gNQP6IHJpoPTIOo2uvru vF944NJBc480c4cW1+9gerQ3LyoXgGwSe+nKRUvSBThnPaGt061XpyvZatDRx7+mU/Di x9+Q== X-Gm-Message-State: APjAAAVClFVw43UxQ2Tw74Fg6vl5ZARDonMwPkSbr5nyCcosC7OppHZi 8sZCyl6as4UH3BDsf1d9AthEpg== X-Google-Smtp-Source: APXvYqxliGhmmm3S7XUc7qRSL8b+dkWlmU9UvKgIxWWF1EFr0muoV/R9ZUpW3OhnJsCUbAW9URE/+w== X-Received: by 2002:a62:19c3:: with SMTP id 186mr62668508pfz.172.1554139079862; Mon, 01 Apr 2019 10:17:59 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y12sm31370112pgq.64.2019.04.01.10.17.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 10:17:59 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Heiko Stuebner , Sean Paul Subject: [PATCH v5 6/7] ARM: dts: rockchip: Specify rk3288-veyron-chromebook's display timings Date: Mon, 1 Apr 2019 10:17:23 -0700 Message-Id: <20190401171724.215780-7-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190401171724.215780-1-dianders@chromium.org> References: <20190401171724.215780-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_101800_913464_45476843 X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rob Herring , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Boris Brezillon , Laurent Pinchart , =?utf-8?q?Enric_Balle?= =?utf-8?q?tb=C3=B2?= , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Let's document the display timings that most veyron chromebooks (like jaq, jerry, mighty, speedy) have been using out in the field. This uses the standard blankings but a slightly slower clock rate, thus getting a refresh rate 58.3 Hz. NOTE: this won't really do anything except cause DRM to properly report the refresh rate since vop_crtc_mode_fixup() was rounding the pixel clock to 74.25 MHz anyway. Apparently the adjusted rate isn't exposed to userspace so it's important that the rate we're trying to achieve is mostly right. For the downstream kernel change related to this see See https://crrev.com/c/324558. NOTE: minnie uses a different panel will be fixed up in a future patch, so for now we'll just delete the panel timings there. Signed-off-by: Douglas Anderson --- Changes in v5: - It's not just jerry, it's most rk3288 Chromebooks (Heiko) Changes in v4: - rk3288-veyron-jerry patch new for v4. Changes in v3: None Changes in v2: None arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 14 ++++++++++++++ arch/arm/boot/dts/rk3288-veyron-minnie.dts | 2 ++ 2 files changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi index b54746df3661..0b1789b50c21 100644 --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi @@ -76,6 +76,20 @@ power-supply = <&vcc33_lcd>; backlight = <&backlight>; + panel-timing { + clock-frequency = <74250000>; + hactive = <1366>; + hfront-porch = <136>; + hback-porch = <60>; + hsync-len = <30>; + hsync-active = <0>; + vactive = <768>; + vfront-porch = <8>; + vback-porch = <12>; + vsync-len = <12>; + vsync-active = <0>; + }; + ports { panel_in: port { panel_in_edp: endpoint { diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index f95d0c5fcf71..ca7512ade222 100644 --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts @@ -142,6 +142,8 @@ &panel { compatible = "auo,b101ean01", "simple-panel"; power-supply= <&panel_regulator>; + + /delete-node/ panel-timing; }; &rk808 { From patchwork Mon Apr 1 17:17:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10880403 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ACDA41800 for ; Mon, 1 Apr 2019 17:18:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86FD6288A6 for ; Mon, 1 Apr 2019 17:18:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 842FC2888D; Mon, 1 Apr 2019 17:18:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 29A55288A6 for ; Mon, 1 Apr 2019 17:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aioky5XtirWvDtLybEdGPmjB5RtVhwxOLBy9bQjuAIE=; b=cUVFpNJopblX7H nBJMOiwdqOK8IxU/ZBLXprbF6LT1cJPypxxO7wOQ2PEzlx8NxDWesunleFUwJ8CaoYFq/4oZRClK1 5WNpAMnOcAe/X1KaB/AdDelvZmIWjxhmKlgCeQKXDZsMa6bXZTy8DmZzlckYKz7l5YhBS2VM4BG7q aw54JssrKNN1p14RkwOHFhyxWHWEhqObqBmgNeZcDQNnBtfFkp+eCdLvv0jOJz7x7RrcXwvZVm5rx 0vxAOGrLJqUoRWUSyB4sJoC78C5rXp49gtMZv0GrDdmRrVWhIPBDcS9UxOImVfMg92jI1Y2dqhvaF EghlQYfFRiRiHKe6c9/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB0a2-00059r-Rt; Mon, 01 Apr 2019 17:18:42 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB0ZN-0004H4-Or for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 17:18:10 +0000 Received: by mail-pl1-x641.google.com with SMTP id g37so4808851plb.5 for ; Mon, 01 Apr 2019 10:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=92at8vUta2fC2XN1pKFFPCkHFJWYYJixqtIuh16qRd8=; b=PuwiY+gDlXPS2BRq9eoaWfWDB2j1H9/9kFlbWKpKuyv8x775CHcSkF9PtohFS4L/AN MebDQWa6TzOmQI9Eube6euAXCCKTMrw6qMGxcM5K/N5P4sbK1MUGLtfvv7yQniVwylxv 55ROovHraJqtpI0gXazttyeJFmpeBD8bAjIVo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=92at8vUta2fC2XN1pKFFPCkHFJWYYJixqtIuh16qRd8=; b=euggWY+TfuQG3Pr+DGQCEcuICk/evsHQ1VnpAI3ayZ6OmrKgercpgGLJBo/u/hx7oB ZPU0nsktVXa6oR79ABAgGAZDgGXwSxDgu619E9WaTuEjmAqMCGJeJMVs15k1TDb51Uca I/9o4oO2jYvRbfwIoZTDiIKovAAnFo6LbWZpzfemA45/hNt6Tqm0qYVpKGQrM+W6JTeh 0GG9Cg+gyBmFHRoZar3PZ6B2384dRjvvXEg21iB9fTbM9YQMvZjIpG3x+oeXJRcU+x8z jbZV23Jy2C8rFczXUULZ91EtVnJW3BugmXSGFZ7l4tL9hm2L8VrYV5VjQPBgnwpRpuaH /DRA== X-Gm-Message-State: APjAAAWnxGAw4oKmmxJGyr2zxGeJt2jzTKAmll8GoNozhplY6SZ0aofz uIojcjYXTA0ETaU/+X5Nl31YTA== X-Google-Smtp-Source: APXvYqwXPIDZF3EjTK+apAxCXhBFSTWfuVlSfZa4zc0Zr6UCqPiw0E8+9YtFgMTzXnmJco5r2/Nunw== X-Received: by 2002:a17:902:b217:: with SMTP id t23mr66226168plr.184.1554139081162; Mon, 01 Apr 2019 10:18:01 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y12sm31370112pgq.64.2019.04.01.10.17.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 10:18:00 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Heiko Stuebner , Sean Paul Subject: [PATCH v5 7/7] ARM: dts: rockchip: Specify rk3288-veyron-minnie's display timings Date: Mon, 1 Apr 2019 10:17:24 -0700 Message-Id: <20190401171724.215780-8-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190401171724.215780-1-dianders@chromium.org> References: <20190401171724.215780-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_101802_447412_C457C63D X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rob Herring , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Boris Brezillon , Laurent Pinchart , =?utf-8?q?Enric_Balle?= =?utf-8?q?tb=C3=B2?= , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Just like we did for rk3288-veyron-chromebook, we want to be able to use one of the fixed PLLs in the system to make the pixel clock for minnie. Specifying these timings matches us with how the display is used on the downstream Chrome OS kernel. See https://crrev.com/c/323211. Unlike what we did for rk3288-veyron-chromebook, this CL actually changes the timings (though not the pixel clock) that is used when using the upstream kernel. Booting up a minnie shows that it ended up with a 66.67 MHz pixel clock but it was still using the porches/blankings it would have wanted for a 72.5 MHz pixel clock. NOTE: compared to the downstream kernel, this seems to cause a slightly different result reported in the 'modetest' command on a Chromebook. The downstream kernel shows: 1280x800 60 1280 1298 1330 1351 800 804 822 830 66667 With this patch we have: 1280x800 59 1280 1298 1330 1351 800 804 822 830 66666 Specifically modetest was reporting 60 Hz on the downstream kernel but the upstream kernel does the math and comesup with 59 (because we actually achieve 59.45 Hz). Also upstream doesn't round the Hz up when converting to kHz--it seems to truncate. ALSO NOTE: when I look at the EDID from the datasheet, I see: -hsync -vsync ...but it seems like we've never actually run with that so I've continued leaving that out. Signed-off-by: Douglas Anderson --- Changes in v5: - It's not just jerry, it's most rk3288 Chromebooks (Heiko) Changes in v4: - rk3288-veyron-minnie patch new for v4. Changes in v3: None Changes in v2: None arch/arm/boot/dts/rk3288-veyron-minnie.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index ca7512ade222..8179cf9f6e98 100644 --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts @@ -144,6 +144,18 @@ power-supply= <&panel_regulator>; /delete-node/ panel-timing; + + panel-timing { + clock-frequency = <66666667>; + hactive = <1280>; + hfront-porch = <18>; + hback-porch = <21>; + hsync-len = <32>; + vactive = <800>; + vfront-porch = <4>; + vback-porch = <8>; + vsync-len = <18>; + }; }; &rk808 {