diff mbox series

[7/7,RFT] arm64: zynqmp: Add PCIe phys

Message ID 20240422195904.3591683-8-sean.anderson@linux.dev (mailing list archive)
State Superseded
Delegated to: Krzysztof Wilczyński
Headers show
Series PCI: xilinx-nwl: Add phy support | expand

Commit Message

Sean Anderson April 22, 2024, 7:59 p.m. UTC
Add PCIe phy bindings for the ZCU102.

Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---
I don't have a ZCU102, so please test this.

 arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Michal Simek April 23, 2024, 6:15 a.m. UTC | #1
Hi Bharat,

On 4/22/24 21:59, Sean Anderson wrote:
> Add PCIe phy bindings for the ZCU102.
> 
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> ---
> I don't have a ZCU102, so please test this.
> 
>   arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index ad8f23a0ec67..68fe53685351 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -941,6 +941,8 @@ conf-pull-none {
>   
>   &pcie {
>   	status = "okay";
> +	phys = <&psgtr 0 PHY_TYPE_PCIE 0 0>;
> +	phy-names = "pcie-phy0";
>   };
>   
>   &psgtr {

Please review and test this series.

Thanks,
Michal
Havalige, Thippeswamy April 24, 2024, 9:11 a.m. UTC | #2
Hi Michal,

> -----Original Message-----
> From: Simek, Michal <michal.simek@amd.com>
> Sent: Tuesday, April 23, 2024 11:46 AM
> To: Sean Anderson <sean.anderson@linux.dev>; Lorenzo Pieralisi
> <lpieralisi@kernel.org>; Krzysztof Wilczyński <kw@linux.com>; Rob Herring
> <robh@kernel.org>; linux-pci@vger.kernel.org; Gogada, Bharat Kumar
> <bharat.kumar.gogada@amd.com>
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Havalige,
> Thippeswamy <thippeswamy.havalige@amd.com>; Bjorn Helgaas
> <bhelgaas@google.com>
> Subject: Re: [PATCH 7/7] [RFT] arm64: zynqmp: Add PCIe phys
> 
> Hi Bharat,
> 
> On 4/22/24 21:59, Sean Anderson wrote:
> > Add PCIe phy bindings for the ZCU102.
> >
> > Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> > ---
> > I don't have a ZCU102, so please test this.
> >
> >   arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> > index ad8f23a0ec67..68fe53685351 100644
> > --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> > +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> > @@ -941,6 +941,8 @@ conf-pull-none {
> >
> >   &pcie {
> >   	status = "okay";
> > +	phys = <&psgtr 0 PHY_TYPE_PCIE 0 0>;
> > +	phy-names = "pcie-phy0";
> >   };
> >
> >   &psgtr {
> 
> Please review and test this series.
> 
> Thanks,
> Michal

Reviewed and tested the patch.

Regards,
Thippeswamy H
Michal Simek April 24, 2024, 11:27 a.m. UTC | #3
On 4/24/24 11:11, Havalige, Thippeswamy wrote:
> Hi Michal,
> 
>> -----Original Message-----
>> From: Simek, Michal <michal.simek@amd.com>
>> Sent: Tuesday, April 23, 2024 11:46 AM
>> To: Sean Anderson <sean.anderson@linux.dev>; Lorenzo Pieralisi
>> <lpieralisi@kernel.org>; Krzysztof Wilczyński <kw@linux.com>; Rob Herring
>> <robh@kernel.org>; linux-pci@vger.kernel.org; Gogada, Bharat Kumar
>> <bharat.kumar.gogada@amd.com>
>> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Havalige,
>> Thippeswamy <thippeswamy.havalige@amd.com>; Bjorn Helgaas
>> <bhelgaas@google.com>
>> Subject: Re: [PATCH 7/7] [RFT] arm64: zynqmp: Add PCIe phys
>>
>> Hi Bharat,
>>
>> On 4/22/24 21:59, Sean Anderson wrote:
>>> Add PCIe phy bindings for the ZCU102.
>>>
>>> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
>>> ---
>>> I don't have a ZCU102, so please test this.
>>>
>>>    arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
>> b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
>>> index ad8f23a0ec67..68fe53685351 100644
>>> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
>>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
>>> @@ -941,6 +941,8 @@ conf-pull-none {
>>>
>>>    &pcie {
>>>    	status = "okay";
>>> +	phys = <&psgtr 0 PHY_TYPE_PCIE 0 0>;
>>> +	phy-names = "pcie-phy0";
>>>    };
>>>
>>>    &psgtr {
>>
>> Please review and test this series.
>>
>> Thanks,
>> Michal
> 
> Reviewed and tested the patch.

can you please provide proper Tested-by: line?

Thanks,
Michal
Havalige, Thippeswamy April 24, 2024, 12:37 p.m. UTC | #4
Tested-by: thippeswamy.havalige@amd.com

> -----Original Message-----
> From: Simek, Michal <michal.simek@amd.com>
> Sent: Wednesday, April 24, 2024 4:57 PM
> To: Havalige, Thippeswamy <thippeswamy.havalige@amd.com>; Sean Anderson
> <sean.anderson@linux.dev>; Lorenzo Pieralisi <lpieralisi@kernel.org>; Krzysztof
> Wilczyński <kw@linux.com>; Rob Herring <robh@kernel.org>; linux-
> pci@vger.kernel.org; Gogada, Bharat Kumar <bharat.kumar.gogada@amd.com>
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Bjorn
> Helgaas <bhelgaas@google.com>
> Subject: Re: [PATCH 7/7] [RFT] arm64: zynqmp: Add PCIe phys
> 
> 
> 
> On 4/24/24 11:11, Havalige, Thippeswamy wrote:
> > Hi Michal,
> >
> >> -----Original Message-----
> >> From: Simek, Michal <michal.simek@amd.com>
> >> Sent: Tuesday, April 23, 2024 11:46 AM
> >> To: Sean Anderson <sean.anderson@linux.dev>; Lorenzo Pieralisi
> >> <lpieralisi@kernel.org>; Krzysztof Wilczyński <kw@linux.com>; Rob
> >> Herring <robh@kernel.org>; linux-pci@vger.kernel.org; Gogada, Bharat
> >> Kumar <bharat.kumar.gogada@amd.com>
> >> Cc: linux-arm-kernel@lists.infradead.org;
> >> linux-kernel@vger.kernel.org; Havalige, Thippeswamy
> >> <thippeswamy.havalige@amd.com>; Bjorn Helgaas <bhelgaas@google.com>
> >> Subject: Re: [PATCH 7/7] [RFT] arm64: zynqmp: Add PCIe phys
> >>
> >> Hi Bharat,
> >>
> >> On 4/22/24 21:59, Sean Anderson wrote:
> >>> Add PCIe phy bindings for the ZCU102.
> >>>
> >>> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> >>> ---
> >>> I don't have a ZCU102, so please test this.
> >>>
> >>>    arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 2 ++
> >>>    1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> >> b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> >>> index ad8f23a0ec67..68fe53685351 100644
> >>> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> >>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> >>> @@ -941,6 +941,8 @@ conf-pull-none {
> >>>
> >>>    &pcie {
> >>>    	status = "okay";
> >>> +	phys = <&psgtr 0 PHY_TYPE_PCIE 0 0>;
> >>> +	phy-names = "pcie-phy0";
> >>>    };
> >>>
> >>>    &psgtr {
> >>
> >> Please review and test this series.
> >>
> >> Thanks,
> >> Michal
> >
> > Reviewed and tested the patch.
> 
> can you please provide proper Tested-by: line?
> 
> Thanks,
> Michal
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
index ad8f23a0ec67..68fe53685351 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
@@ -941,6 +941,8 @@  conf-pull-none {
 
 &pcie {
 	status = "okay";
+	phys = <&psgtr 0 PHY_TYPE_PCIE 0 0>;
+	phy-names = "pcie-phy0";
 };
 
 &psgtr {